On 12/08/2017 12:56 AM, Collin L. Walling wrote:
> Hello,
>
> I'd like to bring up a formal discussion regarding the utilization of
> reserved space
> in the IPL Parameter Blocks for s390x guests. Particularly the following:
>
> * How should we approach "claiming" bytes so that we do not obst
On Fri, Dec 8, 2017 at 6:43 AM, Wei Wang wrote:
> On 12/08/2017 07:54 AM, Michael S. Tsirkin wrote:
>>
>> On Thu, Dec 07, 2017 at 06:28:19PM +, Stefan Hajnoczi wrote:
>>>
>>> On Thu, Dec 7, 2017 at 5:38 PM, Michael S. Tsirkin
>>> wrote:
On Thu, Dec 07, 2017 at 05:29:14PM +, Stef
A bit more detail in the commit message would make this patch easier to
review.
Marc-André Lureau writes:
> Signed-off-by: Marc-André Lureau
> ---
> scripts/qapi.py | 39
> -
> tests/Makefile.include | 1 -
> tests/qapi
On Thu, 7 Dec 2017 16:31:37 +0100
David Hildenbrand wrote:
> We'll need it later on in two places. Refactor it to just indicate the
> validity bits. While at it, introduce a define for the used CR14 bit (we'll
> also need later on).
>
> Signed-off-by: David Hildenbrand
> ---
> target/s390x/cp
This RFC patch is based on Qemu UI on-going work of rendering guest
framebuffer through dma-buf interface, to show a protype of SDL with
dma-buf interface.
Against branch: work/intel-vgpu
Signed-off-by: Tina Zhang
---
include/ui/sdl2.h | 11
ui/sdl2-gl.c | 84 +
On Thu, Dec 07, 2017 at 06:33:04PM +0100, Kevin Wolf wrote:
> Am 07.12.2017 um 12:56 hat Kashyap Chamarthy geschrieben:
[...]
> > So from the above interesting discussion, it seems like Kevin is leaning
> > towards a single job type that offers 'stream', 'commit', 'backup', and
> > 'mirror' funct
On Thu, 7 Dec 2017 16:31:38 +0100
David Hildenbrand wrote:
> The architecture mode indication wasn't stored. The split of certain
> 64bit fields was unnecessary. Also, the complete clock comparator, not
> just bit 0-55 (starting at byte 1) was stored.
>
> We now generate a proper MCIC via the s
This patch is using SDL_GL_GetCurrentContext() to get a context and meet an
issue with SDL_GL_CONTEXT_EGL which is deprecated since SDL 2.1.
Before SDL 2.1, SDL_GL_CONTEXT_EGL can be used with SDL_GL_SetAttribute, so
that an EGLContext can be created with SDL_GL_GetCurrentContext().
Since SDL_GL
On Fri, Dec 08, 2017 at 01:58:22AM +0100, Marc-André Lureau wrote:
> ASAN complains about:
>
> ==8856==ERROR: AddressSanitizer: stack-buffer-overflow on address
> 0x7ffd8a1fe168 at pc 0x561136cb4451 bp 0x7ffd8a1fe130 sp 0x7ffd8a1fd8e0
> READ of size 16 at 0x7ffd8a1fe168 thread T0
> #0 0x56113
On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote:
> +@item --force-share (-U)
> +
> +If specified, @code{qemu-img} will open the image with shared permissions,
> +which makes it less likely to conflict with a running guest's permissions due
> +to image locking. For example, this can be use
On 7 December 2017 at 21:20, Brijesh Singh wrote:
> On 12/06/2017 04:03 PM, Peter Maydell wrote:
>> For instance, if a device gets a debug=1 transaction
>> should it refuse to do things like read-clears-bits
>> semantics or other side-effects you wouldn't expect
>> of debugger accesses?
>>
>
> Sor
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote:
> Direct leak of 12 byte(s) in 2 object(s) allocated from:
> #0 0x7f50d403c850 in malloc (/lib64/libasan.so.4+0xde850)
> #1 0x7f50d1ddf98f in vasprintf (/lib64/libc.so.6+0x8098f)
>
> Signed-off-by: Marc-André Lureau
There's an iden
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote:
> Fixes leaks such as:
>
> Direct leak of 2 byte(s) in 1 object(s) allocated from:
> #0 0x7eff58beb850 in malloc (/lib64/libasan.so.4+0xde850)
> #1 0x7eff57942f0c in g_malloc ../glib/gmem.c:94
> #2 0x7eff579431cf in g_malloc_n ..
On Thu, 7 Dec 2017 19:18:44 +0200
"Michael S. Tsirkin" wrote:
> I see this in ccw in qemu:
>
> if (virtio_set_status(vdev, status) == 0) {
> if (vdev->status == 0) {
> virtio_ccw_reset_virtio(dev, vdev);
> }
> if (st
On Wed, Dec 06, 2017 at 01:54:00PM -0600, Mark Kanda wrote:
> Depending on the configuration, it can be beneficial to adjust the virtio-blk
> queue size to something other than the current default of 128. Add a new
> property to make the queue size configurable.
>
> Signed-off-by: Mark Kanda
> Re
On Thu, 7 Dec 2017 18:56:16 -0500
"Collin L. Walling" wrote:
> Hello,
>
> I'd like to bring up a formal discussion regarding the utilization of
> reserved space
> in the IPL Parameter Blocks for s390x guests. Particularly the following:
>
> * How should we approach "claiming" bytes so that w
On Wed, Dec 06, 2017 at 01:54:01PM -0600, Mark Kanda wrote:
> virtio-blk logical block size should never be larger than physical block
> size because it doesn't make sense to have such configurations. QEMU doesn't
> have a way to effectively express this condition; the best it can do is
> report th
On Thu, 7 Dec 2017 18:56:16 -0500
"Collin L. Walling" wrote:
> --- The Fields We Need To Store ---
>
> Currently, we're utilizing 3 bytes out of a 77 byte reserved field in
> the IPLB for
> CCW and SCSI. We do this because need a way to pass the Qemu command
> line opti
On Wed, Dec 06, 2017 at 02:45:41PM +, Stefan Hajnoczi wrote:
> v2:
> * Use StrOrNull for x-blockdev-set-iothread iothread argument [eblake]
Thanks for the reviews, Eric.
I will wait for one more block layer person (Kevin, Paolo, or Fam?) to
review before merging.
Stefan
signature.asc
Desc
On Fri, Dec 08, 2017 at 09:55:26AM +, Peter Maydell wrote:
> On 7 December 2017 at 21:20, Brijesh Singh wrote:
> > On 12/06/2017 04:03 PM, Peter Maydell wrote:
> >> For instance, if a device gets a debug=1 transaction
> >> should it refuse to do things like read-clears-bits
> >> semantics or o
* Charles Kelimod (lichs...@gmail.com) wrote:
> Hi Dave and Sahlberg,
>
> for this type of name:iser:, I completely agree with
> you.
> my issue is when I create an vm from libvirt, the qemu command line should
> be:
> -drive
> file.driver=iser,file.portal=xx.xx.xx.xx:3260,file.target=iqn.xxx,
On Fri, Dec 08, 2017 at 03:27:27PM +0800, Charles Kelimod wrote:
> Hi Dave and Sahlberg,
>
> for this type of name:iser:, I completely agree with
> you.
> my issue is when I create an vm from libvirt, the qemu command line should
> be:
> -drive
> file.driver=iser,file.portal=xx.xx.xx.xx:3260,f
* Juan Quintela (quint...@redhat.com) wrote:
> Signed-off-by: Juan Quintela
> Reported-by: Peter Xu
Reviewed-by: Dr. David Alan Gilbert
(same as Marc-André's)
> ---
> tests/migration-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/migration-test.c b/t
* Juan Quintela (quint...@redhat.com) wrote:
> We now test the deprecated commands everytime that we test the new
> commands. This makes unnecesary to add tests for deprecated commands.
>
> Signed-off-by: Juan Quintela
> ---
> tests/migration-test.c | 32
> 1 fi
This series just do some cleanup to comply with the QEMU coding style.
No functional change.
--
Greg
---
Greg Kurz (5):
virtio-9p: move unrealize/realize after virtio_9p_transport definition
9pfs: fix XattrOperations typedef
fsdev: fix some type definitions
9pfs: fix some
And drop the now useless forward declaration of virtio_9p_transport.
Signed-off-by: Greg Kurz
---
hw/9pfs/virtio-9p-device.c | 60 +---
1 file changed, 29 insertions(+), 31 deletions(-)
diff --git a/hw/9pfs/virtio-9p-device.c b/hw/9pfs/virtio-9p-device.
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
---
fsdev/file-op-9p.h |5 +++--
hw/9pfs/9p-xattr.h |5 ++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
index 474c79d003f6..05b3ef357462 100644
--- a/fsdev/file-op-
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
---
hw/9pfs/9p-handle.c | 48
1 file changed, 24 insertions(+), 24 deletions(-)
diff --git a/hw/9pfs/9p-handle.c b/hw/9pfs/9p-handle.c
index 9875f1894cc5..65b12de230c1 100644
--- a/
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
---
fsdev/file-op-9p.h | 27 ---
1 file changed, 12 insertions(+), 15 deletions(-)
diff --git a/fsdev/file-op-9p.h b/fsdev/file-op-9p.h
index 05b3ef357462..63d19a6dcd0e 100644
--- a/fsdev/file-op-9p.h
+++ b
To comply with the QEMU coding style.
Signed-off-by: Greg Kurz
---
hw/9pfs/9p.c |6 +++---
hw/9pfs/9p.h | 12 ++--
hw/9pfs/virtio-9p-device.c |2 +-
hw/9pfs/xen-9p-backend.c |2 +-
4 files changed, 11 insertions(+), 11 deletions(-)
diff --git
On Wed, Dec 06, 2017 at 11:53:03AM +0100, Kevin Wolf wrote:
> I was looking into the drain functions in order to develop them a bit in
> the direction that Fam suggested, to unify the code between bdrv_drain()
> and bdrv_drain_all() a bit more, and maybe to find a place to take
> coroutine locks fo
On Tue, Dec 05, 2017 at 01:39:54PM +, Stefan Hajnoczi wrote:
> Commit 1351d1ec89eabebc9fdff20451a62c413d7accc1 ("qdev: drop iothread
> property type") forgot to remove this include.
>
> Signed-off-by: Stefan Hajnoczi
> ---
> hw/core/qdev-properties-system.c | 1 -
> 1 file changed, 1 deletio
C99 inline functions are useful whenever a function provide an
abstraction that is generally expected to be inlined away, but
yet a function pointer might be needed. One such case is function
passed to GCC's cleanup attribute.
Unfortunately, C99 inline functions clash a bit with -Wredundant-decls
This is an attempt to make a C API that resembles the C++
std::unique_lock (mostly untested). The idea is that you can write
QEMU_LOCK_GUARD(QemuMutex, guard_name, &some_mutex);
instead of
qemu_mutex_lock(&some_mutex);
...
out:
qemu_mutex_unlock(&some_mutex);
and the mutex will
Signed-off-by: Paolo Bonzini
---
util/thread-pool.c | 26 +++---
1 file changed, 11 insertions(+), 15 deletions(-)
diff --git a/util/thread-pool.c b/util/thread-pool.c
index 610646d131..06ada38376 100644
--- a/util/thread-pool.c
+++ b/util/thread-pool.c
@@ -78,7 +78,7 @@ stat
Signed-off-by: Paolo Bonzini
---
util/qemu-timer.c | 84 +++
1 file changed, 42 insertions(+), 42 deletions(-)
diff --git a/util/qemu-timer.c b/util/qemu-timer.c
index 82d56507a2..7a99e0e336 100644
--- a/util/qemu-timer.c
+++ b/util/qemu-timer.
Signed-off-by: Paolo Bonzini
---
include/qemu/coroutine.h | 4 ++
include/qemu/lock-guard.h | 99 +++
include/qemu/thread.h | 7
util/Makefile.objs| 1 +
util/qemu-thread.c| 17
5 files changed, 128 insertions(+)
c
Signed-off-by: Paolo Bonzini
---
util/qht.c | 59 +--
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/util/qht.c b/util/qht.c
index ff4d2e6974..95ac32f990 100644
--- a/util/qht.c
+++ b/util/qht.c
@@ -248,18 +248,18 @@ void qh
On Tue, Dec 05, 2017 at 07:35:36PM +0100, BALATON Zoltan wrote:
> On Tue, 5 Dec 2017, Stefan Hajnoczi wrote:
> > On Mon, Dec 04, 2017 at 08:22:48PM +0100, BALATON Zoltan wrote:
> I don't really know what to look for
> so if anyone has any more ideas then please share.
I don't have a specific idea,
* Juan Quintela (quint...@redhat.com) wrote:
> Signed-off-by: Juan Quintela
OK, although you seem to have chosen a bandwidth 10x what I use
in the postcopy test but for the same reason.
Reviewed-by: Dr. David Alan Gilbert
> ---
> tests/migration-test.c | 44 ++
On Wed, Dec 06, 2017 at 10:48:45AM +0100, Paolo Bonzini wrote:
> On 06/12/2017 10:26, Yang Zhong wrote:
> > Hello Paolo,
> >
> > The best option is only trim one time after guest kernel bootup or VM
> > bootup, and as for
> > hotplug/unhotplug operations during the VM running, the trim stil
* Juan Quintela (quint...@redhat.com) wrote:
> Not sharing code from precopy/unix because we have to read back the
> tcp parameter.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
> ---
> tests/migration-test.c | 59
> +++---
>
On Wed, Dec 06, 2017 at 03:11:55PM +, Stefan Hajnoczi wrote:
> On Tue, Dec 05, 2017 at 02:35:42PM +0100, Paolo Bonzini wrote:
> > On 05/12/2017 13:06, Stefan Hajnoczi wrote:
> > > On Tue, Dec 05, 2017 at 02:33:13PM +0800, Yang Zhong wrote:
> > Referring to your slides, the remaining points for
On Thu, 7 Dec 2017 18:15:57 +0100
Halil Pasic wrote:
> On 12/07/2017 06:06 PM, Cornelia Huck wrote:
> > On Thu, 7 Dec 2017 18:01:46 +0100
> [..]
> Regarding the discussion about whether the QOM tree is API and what
> exploiters like libvirt should do, Halil asked me to chip in.
>
* Juan Quintela (quint...@redhat.com) wrote:
> Signed-off-by: Juan Quintela
> ---
> tests/migration-test.c | 68
> ++
> 1 file changed, 68 insertions(+)
>
> diff --git a/tests/migration-test.c b/tests/migration-test.c
> index 841c89e28a..41dee78a9
On Tue, 28 Nov 2017 14:46:47 +0100
Cornelia Huck wrote:
> Logically, the css bridge should be attached to the machine.
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/css-bridge.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/hw/s390x/css-bridge.c b/hw/s390x/css-bridge.c
> inde
* Juan Quintela (quint...@redhat.com) wrote:
> Yeap, it is still not working. trying to learn how to debug threads
> for guests running from the testt hardness.
>
> For some reason, compression is not working at the moment, test is
> disabled until I found why.
How does it fail?
Dave
> Signed-o
Am 08.12.2017 um 10:54 hat Stefan Hajnoczi geschrieben:
> On Fri, Dec 08, 2017 at 09:44:56AM +0800, Fam Zheng wrote:
> > +@item --force-share (-U)
> > +
> > +If specified, @code{qemu-img} will open the image with shared permissions,
> > +which makes it less likely to conflict with a running guest's
On 26 October 2017 at 18:31, Jason A. Donenfeld wrote:
> On Thu, Oct 26, 2017 at 6:41 PM, Peter Maydell
> wrote:
>> Those are primarily about migration compatibility -- you should
>> be able to live migrate a guest from QEMU 2.6's virt-2.6 machine to
>> QEMU 2.7's virt-2.6 machine. That's a stri
fix a bug leaving the allocmap in a wrong state if an UNMAP fails and
improve the logging of iscsi failures.
Peter Lieven (2):
block/iscsi: dont leave allocmap in an invalid state on UNMAP failure
block/iscsi: only report an iSCSI Failure if we don't handle it
gracefully
block/iscsi.c |
we forgot to set the allocmap to invalid if an UNMAP call fails.
Cc: qemu-sta...@nongnu.org
Signed-off-by: Peter Lieven
---
block/iscsi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/iscsi.c b/block/iscsi.c
index 4683f3b..c532ec7 100644
--- a/block/iscsi.c
++
we currently report an "iSCSI Failure" in iscsi_co_generic_cb if the task
hasn't completed with SCSI_STATUS_GOOD. However, we expect a failure in
some cases and handle it gracefully. This is the case for misaligned UNMAPs
and WRITESAME10/16 calls without UNMAP. In this case a failure in the
logs ca
* Peter Xu (pet...@redhat.com) wrote:
> On Fri, Dec 01, 2017 at 01:57:49PM +0100, Juan Quintela wrote:
> > It will be used to store the uri tcp_port parameter. This is the only
> > parameter than can change and we can need to be able to connect to it.
> >
> > Signed-off-by: Juan Quintela
> >
>
The current docs for TLS assume only VNC is using TLS. Some of the information
is also outdated (ie lacking subject alt name info for certs). Rewrite it to
more accurately reflect the current situation.
Signed-off-by: Daniel P. Berrange
---
qemu-doc.texi | 368 +++
On 08.12.2017 00:56, Collin L. Walling wrote:
> Hello,
>
> I'd like to bring up a formal discussion regarding the utilization of
> reserved space
> in the IPL Parameter Blocks for s390x guests. Particularly the following:
>
> * How should we approach "claiming" bytes so that we do not obstruct
It will be needed to handle invalid requests
Signed-off-by: Anton Nefedov
---
hw/ide/core.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 471d0c9..02a6b2c 100644
--- a/hw/ide/core.c
+++ b/hw/ide/core.c
@@ -383,7 +383,7 @@ s
Started from the separate series discussion (trim statistics) , see
http://lists.nongnu.org/archive/html/qemu-devel/2017-12/msg01059.html
There is no range check for IDE trim requests now.
Such request will likely be rejected by the block layer and count as
failed and not an invalid/aborted operat
to use it without a forward declaration in the commit to follow
Signed-off-by: Anton Nefedov
---
hw/ide/core.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/hw/ide/core.c b/hw/ide/core.c
index 02a6b2c..23c71fa 100644
--- a/hw/ide/core.c
+++ b/hw/i
ATA8-ACS3, 7.9 DATA SET MANAGEMENT - 06h, DMA
7.9.5 Error Outputs
If the Trim bit is set to one and:
a) the device detects an invalid LBA Range Entry; or
b) count is greater than IDENTIFY DEVICE data word 105
(see 7.16.7.55),
then the device shall return command ab
On 12/08/2017 12:42 PM, Cornelia Huck wrote:
[..]
>> In general, I kind of agree with Halil. Unless somewhere in QEMU it is
>> documented that the QOM tree is not guaranteed to be stable for
>> exploiters, I'd consider is part of the API. libvirt does use at least
>> some hardcode
* Daniel P. Berrange (berra...@redhat.com) wrote:
> qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
> done and thus getchar() will never return the EOF constant. Instead we have to
> check for an explicit Ctrl-D, aka 0x4, to detect EOF and exit the qemu-io
> shell. T
On 08.12.2017 01:00, Richard Henderson wrote:
> On 12/07/2017 07:31 AM, David Hildenbrand wrote:
>> +DEF_HELPER_FLAGS_1(sckpf, TCG_CALL_NO_RWG, void, env)
> ...
>> +/* Set Tod Programmable Field */
>> +void HELPER(sckpf)(CPUS390XState *env)
>> +{
>> +uint32_t val = env->regs[0];
>> +
>> +if
On 08.12.2017 01:02, Richard Henderson wrote:
> On 12/07/2017 07:31 AM, David Hildenbrand wrote:
>> +/* 16 bit value store in an uint32_t (only valid bits set) */
>> +tcg_gen_ld32u_i64(todpr, cpu_env, offsetof(CPUS390XState, todpr));
>
> Any reason not to use a uint16_t and use tcg_gen_ld1
On 08.12.2017 00:41, Richard Henderson wrote:
> On 12/07/2017 08:53 AM, David Hildenbrand wrote:
>> +static ExitStatus op_asi(DisasContext *s, DisasOps *o)
>> +{
>> +o->in1 = tcg_temp_new_i64();
>> +/* Perform the atomic addition in memory. */
>> +tcg_gen_atomic_fetch_add_i64(o->in1, o-
On 08.12.2017 00:43, Richard Henderson wrote:
> On 12/07/2017 08:53 AM, David Hildenbrand wrote:
>> We can simply reuse our ASI implementation. Only the way CC is
>> calculated differs.
>>
>> Signed-off-by: David Hildenbrand
>> ---
>> target/s390x/insn-data.def | 4 ++--
>> 1 file changed, 2 inse
On 12/08/2017 01:45 PM, David Hildenbrand wrote:
> On 08.12.2017 01:02, Richard Henderson wrote:
>> On 12/07/2017 07:31 AM, David Hildenbrand wrote:
>>> +/* 16 bit value store in an uint32_t (only valid bits set) */
>>> +tcg_gen_ld32u_i64(todpr, cpu_env, offsetof(CPUS390XState, todpr));
>
On Thu, 7 Dec 2017 17:26:53 +
Peter Maydell wrote:
> On 7 December 2017 at 17:13, Peter Maydell wrote:
> > On 7 December 2017 at 17:07, Eduardo Habkost wrote:
> >> On Thu, Dec 07, 2017 at 04:53:59PM +, Peter Maydell wrote:
> >>> On 7 December 2017 at 16:48, Igor Mammedov wrote:
>
On 8 December 2017 at 13:16, Igor Mammedov wrote:
> TBH:
> I do not recall why we have x86 max/host cpu types do feature
> loading at realize time instead of at class init like the rest
> of static cpu types.
class init is too early, IIRC -- it's before KVM has been set up at all.
thanks
-- P
Am 06.12.2017 um 15:45 hat Stefan Hajnoczi geschrieben:
> v2:
> * Use StrOrNull for x-blockdev-set-iothread iothread argument [eblake]
>
> (This is for QEMU 2.12 because this bug is not -rc4 critical)
>
> Previously AioContext was held across QMP 'transaction' in an attempt to
> achieve bdrv_dra
qemu-io puts the TTY into non-canonical mode, which means no EOF processing is
done and thus getchar() will never return the EOF constant. Instead we have to
query the TTY attributes to determine the configured EOF character (usually
Ctrl-D / 0x4), and then explicitly check for that value. This fix
On Fri, Dec 08, 2017 at 12:15:21PM +, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrange (berra...@redhat.com) wrote:
> > qemu-io puts the TTY into non-canonical mode, which means no EOF processing
> > is
> > done and thus getchar() will never return the EOF constant. Instead we have
> > to
Ladi Prosek writes:
> The effects of ivshmem_enable_irqfd() was not undone on device reset.
>
> This manifested as:
> ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' failed.
>
> when irqfd was enabled before reset and then enabled again after reset, making
> ivshmem_enable_irqf
On Fri, Dec 08, 2017 at 01:58:25AM +0100, Marc-André Lureau wrote:
> Not strictly necessary, but it may help ASAN and remove some false
> positives.
>
> Sadly, this annotation produces an ASAN error:
>
> $ tests/test-coroutine -p /basic/lifecycle
> /basic/lifecycle: ==27655==WARNING: ASan doesn't
On 2017-12-06 10:12, Kevin Wolf wrote:
> Am 06.12.2017 um 08:28 hat Kangjie Xi geschrieben:
>> Hi,
>>
>> I encountered a qemu-nbd segfault, finally I found it was caused by
>> NULL bs-drv, which is located in block/io.c function bdrv_co_flush
>> line 2377:
>>
>> https://git.qemu.org/?p=qemu.git;a=
On Fri, Dec 8, 2017 at 2:36 PM, Markus Armbruster wrote:
> Ladi Prosek writes:
>
>> The effects of ivshmem_enable_irqfd() was not undone on device reset.
>>
>> This manifested as:
>> ivshmem_add_kvm_msi_virq: Assertion `!s->msi_vectors[vector].pdev' failed.
>>
>> when irqfd was enabled before res
On 2017-12-05 11:31, Alberto Garcia wrote:
> On Mon 04 Dec 2017 07:26:02 PM CET, Max Reitz wrote:
+static void curl_refresh_filename(BlockDriverState *bs)
+{
+BDRVCURLState *s = bs->opaque;
+
+if (!s->sslverify || s->cookie ||
+s->username || s->passwor
Am 08.12.2017 um 14:39 hat Max Reitz geschrieben:
> On 2017-12-06 10:12, Kevin Wolf wrote:
> > Am 06.12.2017 um 08:28 hat Kangjie Xi geschrieben:
> >> Hi,
> >>
> >> I encountered a qemu-nbd segfault, finally I found it was caused by
> >> NULL bs-drv, which is located in block/io.c function bdrv_co
On Fri, Dec 08, 2017 at 02:47:52PM +0100, Max Reitz wrote:
> On 2017-12-05 11:31, Alberto Garcia wrote:
> > On Mon 04 Dec 2017 07:26:02 PM CET, Max Reitz wrote:
> +static void curl_refresh_filename(BlockDriverState *bs)
> +{
> +BDRVCURLState *s = bs->opaque;
> +
> +
Marc-André Lureau writes:
> Add condition to QAPIEvent enum members based on the event 'if'.
>
> Signed-off-by: Marc-André Lureau
> ---
> scripts/qapi-event.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/scripts/qapi-event.py b/scripts/qapi-event.py
> index 38f42648
On 2017-12-05 14:27, Alberto Garcia wrote:
> On Mon 20 Nov 2017 09:09:44 PM CET, Max Reitz wrote:
>> @@ -5016,6 +5016,7 @@ void bdrv_refresh_filename(BlockDriverState *bs)
>>
>> opts = qdict_new();
>> has_open_options = append_open_options(opts, bs);
>> +has_open_options
On 2017-12-08 14:51, Kevin Wolf wrote:
> Am 08.12.2017 um 14:39 hat Max Reitz geschrieben:
>> On 2017-12-06 10:12, Kevin Wolf wrote:
>>> Am 06.12.2017 um 08:28 hat Kangjie Xi geschrieben:
Hi,
I encountered a qemu-nbd segfault, finally I found it was caused by
NULL bs-drv, which
Markus Armbruster writes:
> Marc-André Lureau writes:
>
>> Add condition to QAPIEvent enum members based on the event 'if'.
>>
>> Signed-off-by: Marc-André Lureau
>> ---
>> scripts/qapi-event.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/scripts/qapi-event.py b
- Original Message -
> From: "Ladi Prosek"
> To: qemu-devel@nongnu.org
> Cc: mar...@redhat.com, ge...@hostfission.com, m...@redhat.com, "alex
> williamson"
> Sent: Friday, December 8, 2017 8:31:13 AM
> Subject: [PATCH v2] msix: don't mask already masked vectors on reset
>
> msix_mask_
On 2017-12-08 14:53, Daniel P. Berrange wrote:
> On Fri, Dec 08, 2017 at 02:47:52PM +0100, Max Reitz wrote:
>> On 2017-12-05 11:31, Alberto Garcia wrote:
>>> On Mon 04 Dec 2017 07:26:02 PM CET, Max Reitz wrote:
>> +static void curl_refresh_filename(BlockDriverState *bs)
>> +{
>> +BD
For PMSAv7, the v7A/R Arm ARM defines that setting AP to 0b111
is an UNPREDICTABLE reserved combination. However, for v7M
this value is documented as having the same behaviour as 0b110:
read-only for both privileged and unprivileged. Accept this
value on an M profile core rather than treating it as
The Configurable Fault Status Register for ARMv7M and v8M is
supposed to be byte and halfword accessible, but we were only
implementing word accesses. Add support for the other access
sizes, which are used by the Zephyr RTOS.
Signed-off-by: Peter Maydell
Reported-by: Andy Gross
---
hw/intc/armv
This was added in 13f1243, but is missing from qemu-options.hx
Signed-off-by: Christophe Fergeau
---
qemu-options.hx | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index f11c4ac960..118784ceb7 100644
--- a/qemu-options.hx
+++ b/q
On Fri, Dec 08, 2017 at 03:14:30PM +0100, Christophe Fergeau wrote:
> This was added in 13f1243, but is missing from qemu-options.hx
>
> Signed-off-by: Christophe Fergeau
> ---
> qemu-options.hx | 11 ++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx
On 2017-12-07 23:47, John Snow wrote:
>
>
> On 12/07/2017 06:56 AM, Kashyap Chamarthy wrote:
>> On Tue, Nov 21, 2017 at 07:10:19PM -0500, John Snow wrote:
>>> On 11/21/2017 12:23 PM, Kevin Wolf wrote:
>>
>> [...] # Snip lot of good discussion.
>>
On another note, I would double check before
Like other virtio tests, use the used ring APIs instead of assuming ISR
being set means the request has completed.
Signed-off-by: Greg Kurz
---
tests/virtio-9p-test.c | 30 +++---
1 file changed, 11 insertions(+), 19 deletions(-)
diff --git a/tests/virtio-9p-test.c b/t
On Fri, Dec 08, 2017 at 11:55:51AM +0100, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> util/qemu-timer.c | 84
> +++
> 1 file changed, 42 insertions(+), 42 deletions(-)
>
> diff --git a/util/qemu-timer.c b/util/qemu-timer.c
> in
On Fri, Dec 08, 2017 at 11:55:52AM +0100, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini
> ---
> util/qht.c | 59 +--
> 1 file changed, 29 insertions(+), 30 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP si
On Fri, Dec 08, 2017 at 06:08:05AM +, Stefan Hajnoczi wrote:
> On Thu, Dec 7, 2017 at 11:54 PM, Michael S. Tsirkin wrote:
> > On Thu, Dec 07, 2017 at 06:28:19PM +, Stefan Hajnoczi wrote:
> >> On Thu, Dec 7, 2017 at 5:38 PM, Michael S. Tsirkin wrote:
> >> > On Thu, Dec 07, 2017 at 05:29:14
Am 05.12.2017 um 02:08 hat John Snow geschrieben:
> VPC has some difficulty creating geometries of particular size.
> However, we can indeed force it to use a literal one, so let's
> do that for the sake of test 197, which is testing some specific
> offsets.
>
> Signed-off-by: John Snow
> Reviewe
On 2017-12-05 01:48, John Snow wrote:
>
>
> On 12/04/2017 05:21 PM, Max Reitz wrote:
>> On 2017-12-04 23:15, John Snow wrote:
>>>
>>>
>>> On 12/01/2017 02:41 PM, Max Reitz wrote:
((By the way, I don't suppose that's how it should work... But I don't
suppose that we want propagation of
On Thu, 7 Dec 2017 18:17:51 +
"Dr. David Alan Gilbert" wrote:
> * Igor Mammedov (imamm...@redhat.com) wrote:
> > vhost_verify_ring_mappings() were used to verify that
> > rings are still accessible and related memory hasn't
> > been moved after flatview is updated.
> >
> > It were doing chec
Peter Maydell writes:
> On 6 December 2017 at 15:28, Alex Bennée wrote:
>> This fixes bug #1735384 while running java under qemu-sh4. When debug
>> was enabled it showed a problem with TCG temps. Once fixed I was able
>> to run java -version normally.
>>
>
> I don't think this merits holding up
On Fri, 8 Dec 2017 13:19:27 +
Peter Maydell wrote:
> On 8 December 2017 at 13:16, Igor Mammedov wrote:
> > TBH:
> > I do not recall why we have x86 max/host cpu types do feature
> > loading at realize time instead of at class init like the rest
> > of static cpu types.
>
> class init i
On 07.12.2017 20:27, Michael S. Tsirkin wrote:
> On Thu, Dec 07, 2017 at 09:39:36AM +0300, Ilya Maximets wrote:
>> On 06.12.2017 19:45, Michael S. Tsirkin wrote:
>>> On Wed, Dec 06, 2017 at 04:06:18PM +0300, Ilya Maximets wrote:
In case virtio error occured after vhost_dev_close(), qemu will c
This patchset adds a second UART to the ARM virt board, which
can be useful in some cases where you'd like a second comms
channel but don't want have to deal with PCI to get it.
Patch 3 attempts to add it to the ACPI tables, but this is
entirely untested and pure guesswork, since I don't really
kn
1 - 100 of 207 matches
Mail list logo
