Re: [Qemu-devel] [PATCH 1/2] virtio: check VirtQueue Vring object is set

2017-11-24 Thread P J P
+-- On Fri, 24 Nov 2017, Paolo Bonzini wrote --+ | Why not check vring->num in virtio_queue_update_rings too? Yes, sent a revised patch v1. These checks seem to repeat through sequence of functions. I guess it'll help to do them in one place. Thank you. -- Prasad J Pandit / Red Hat Product Secur

Re: [Qemu-devel] [PATCH 06/25] spapr: introduce a spapr_irq_get_qirq() helper

2017-11-24 Thread Cédric Le Goater
On 11/24/2017 04:18 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:36PM +0100, Cédric Le Goater wrote: >> xics_get_qirq() is only used by the sPAPR machine. Let's move it there >> and change its name to reflect its scope. It will be useful for XIVE >> support which will use its own set of

Re: [Qemu-devel] [PATCH 13/25] spapr: introduce the XIVE Event Queues

2017-11-24 Thread Cédric Le Goater
On 11/23/2017 09:31 PM, Benjamin Herrenschmidt wrote: > On Thu, 2017-11-23 at 14:29 +0100, Cédric Le Goater wrote: >> The Event Queue Descriptor (EQD) table, also known as Event Notification >> Descriptor (END), is one of the internal tables the XIVE interrupt >> controller uses to redirect excepti

Re: [Qemu-devel] [RFC v3 0/4] vITS Reset

2017-11-24 Thread Auger Eric
Hi, On 23/11/17 19:01, Christian Borntraeger wrote: > > > On 11/23/2017 06:44 PM, Auger Eric wrote: >> Hi Cornelia, Peter, >> >> On 23/11/17 18:14, Cornelia Huck wrote: >>> On Thu, 23 Nov 2017 17:01:32 + >>> Peter Maydell wrote: >>> On 23 November 2017 at 16:05, Auger Eric wrote:

Re: [Qemu-devel] [PATCH 05/25] spapr: introduce a spapr_irq_set() helper

2017-11-24 Thread Cédric Le Goater
On 11/24/2017 04:16 AM, David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:35PM +0100, Cédric Le Goater wrote: >> It will make synchronisation easier with the XIVE interrupt mode when >> available. The 'irq' parameter refers to the global IRQ number space. >> >> Signed-off-by: Cédric Le Goater >

Re: [Qemu-devel] [PATCH 0/1] block: Workaround for the iotests errors

2017-11-24 Thread Fam Zheng
On Fri, 11/24 01:12, Jeff Cody wrote: > On Fri, Nov 24, 2017 at 01:57:46AM +0800, Fam Zheng wrote: > > Jeff's block job patch made the latent drain bug visible, and I find this > > patch, which by itself also makes some sense, can hide it again. :) With it > > applied we are at least back to the gr

Re: [Qemu-devel] [PATCH 1/2] docs: Add image locking subsection

2017-11-24 Thread Fam Zheng
On Thu, 11/23 18:01, Kevin Wolf wrote: > Am 23.11.2017 um 14:59 hat Fam Zheng geschrieben: > > This documents the image locking feature and explains when and how > > related options can be used. > > > > Signed-off-by: Fam Zheng > > --- > > docs/qemu-block-drivers.texi | 36 ++

Re: [Qemu-devel] [PATCH 1/2] docs: Add image locking subsection

2017-11-24 Thread Fam Zheng
On Thu, 11/23 17:07, Philipp Hahn wrote: > Hello, > > Am 23.11.2017 um 14:59 schrieb Fam Zheng: > > diff --git a/docs/qemu-block-drivers.texi b/docs/qemu-block-drivers.texi > > index 1cb1e55686..fa2e90d15f 100644 > > --- a/docs/qemu-block-drivers.texi > > +++ b/docs/qemu-block-drivers.texi > > @@

Re: [Qemu-devel] [PATCH 2/2] qemu-options: Mention locking option of file driver

2017-11-24 Thread Fam Zheng
On Thu, 11/23 18:03, Kevin Wolf wrote: > Am 23.11.2017 um 14:59 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > --- > > qemu-options.hx | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/qemu-options.hx b/qemu-options.hx > > index 3728e9b4dd..bcb7a88ec3 100644 > > ---

[Qemu-devel] [PATCH v2 1/2] docs: Add image locking subsection

2017-11-24 Thread Fam Zheng
This documents the image locking feature and explains when and how related options can be used. Signed-off-by: Fam Zheng --- docs/qemu-block-drivers.texi | 36 qemu-doc.texi| 1 + 2 files changed, 37 insertions(+) diff --git a/docs/qemu-bloc

[Qemu-devel] [PATCH v2 0/2] docs: Add documentation for image locking

2017-11-24 Thread Fam Zheng
v2: Grammar and spelling fixes pointed out by Kevin and Philipp. Image locking feature was added in 2.10 but the documentation has been missing. Users sometimes get confused and wonder how to configure it for their specific needs. We should address common use cases in the man page and explain rela

[Qemu-devel] [PATCH v2 2/2] qemu-options: Mention locking option of file driver

2017-11-24 Thread Fam Zheng
Signed-off-by: Fam Zheng --- qemu-options.hx | 4 1 file changed, 4 insertions(+) diff --git a/qemu-options.hx b/qemu-options.hx index 3728e9b4dd..f10c2a3ddb 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -693,6 +693,10 @@ This is the protocol-level block driver for accessing regula

Re: [Qemu-devel] [PATCH v1 1/2] virtio: check VirtQueue Vring object is set

2017-11-24 Thread Cornelia Huck
On Fri, 24 Nov 2017 13:25:41 +0530 P J P wrote: > From: Prasad J Pandit > > An user could attempt to use an uninitialised VirtQueue object > or unset Vring.align leading to a arithmetic exception. Add check > to avoid it. > > Reported-by: Zhangboxian > Signed-off-by: Prasad J Pandit > --- >

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/25] ppc/xics: introduce an icp_create() helper

2017-11-24 Thread Greg Kurz
On Thu, 23 Nov 2017 14:29:31 +0100 Cédric Le Goater wrote: > The sPAPR and the PowerNV core objects create the interrupt presenter > object of the CPUs in a very similar way. Let's provide a common > routine in which we use the presenter 'type' as a child identifier. > > Signed-off-by: Cédric Le

[Qemu-devel] [PATCH v2 1/7] memory: rename existing iommu notifier to be iommu mr notifier

2017-11-24 Thread Liu, Yi L
From: Peter Xu IOMMU notifiers before are mostly used for [dev-]IOTLB stuffs. It is not suitable for other kind of notifiers (one example would be the future virt-svm support). Considering that current notifiers are targeted for per memory region, renaming the iommu notifier definitions. * all t

[Qemu-devel] [PATCH v2 0/7] Introduce new iommu notifier framework

2017-11-24 Thread Liu, Yi L
This patchset is a follow-up of Peter Xu's patchset as the link below. In brief, Peter's patchset is to introduce a common IOMMU object which is an abstract of IOMMU in Qemu. And based on it, an iommu object based notifier framework is introduced. And also AddressSpaceOps is added to provide method

[Qemu-devel] [PATCH v2 7/7] vfio/pci: register vfio_iommu_bind_pasidtbl_notify notifier

2017-11-24 Thread Liu, Yi L
This is an example to show the usage of IOMMUObject based notifier. For passthru devices, if there is a vIOMMU exposed to guest, guest would issue iommu operation on the devices. And the iommu operations needs to be propagated to host iommu driver. In future, the IOMMUObject notifiers may include

[Qemu-devel] [PATCH v2 4/7] memory: introduce AddressSpaceOps

2017-11-24 Thread Liu, Yi L
From: Peter Xu This patch is going to introduce AddressSpaceOps which is to link an AddressSpace to the IOMMU abstraction behind it. The basic idea here is to associate an IOMMUObject with an AddressSpace. This is still an open so far. Needs to have more inputs on it. Here is my thoughts, and an

[Qemu-devel] [PATCH v2 3/7] hw/core: introduce IOMMUObject

2017-11-24 Thread Liu, Yi L
From: Peter Xu This patch is introducing an IOMMU abstract in Qemu to support the new IOMMU operations other than MAP/UNMAP. For systems that have IOMMUs, it would introduce DMA isolation. The isolation may be multiple DMA AddressSpaces or multiple DMA windows. Without IOMMU, the DMA AddressSpac

[Qemu-devel] [PATCH v2 5/7] intel_iommu: provide AddressSpaceOps.iommu_get instance

2017-11-24 Thread Liu, Yi L
From: Peter Xu Provide AddressSpaceOps.iommu_get() in Intel IOMMU emulator. Signed-off-by: Peter Xu Signed-off-by: Liu, Yi L --- hw/i386/intel_iommu.c | 8 include/hw/i386/intel_iommu.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/hw/i386/intel_iommu.c b/hw/i386/in

[Qemu-devel] [PATCH v2 6/7] vfio/pci: add notify framework based on IOMMUObject

2017-11-24 Thread Liu, Yi L
This patch introduce a notify framework for IOMMUObject.iommu_notifiers. Introduce VFIOGuestIOMMUObject is to link VFIO Container and the new IOMMUObject notififiers. VFIOGuestIOMMUObject instance is allocated when device is assigned and meanwhile vIOMMU is exposed to guest. If there is IOMMUObje

[Qemu-devel] [PATCH v2 2/7] vfio: rename GuestIOMMU to be GuestIOMMUMR

2017-11-24 Thread Liu, Yi L
Rename GuestIOMMU to GuestIOMMUMR as the existing GuestIOMMU is for MemoryRegion related notifiers. Signed-off-by: Liu, Yi L --- hw/vfio/common.c | 15 --- include/hw/vfio/vfio-common.h | 8 2 files changed, 12 insertions(+), 11 deletions(-) diff --git a/hw/vf

Re: [Qemu-devel] [Qemu-ppc] [PATCH 02/25] ppc/xics: assign of the CPU 'intc' pointer under the core

2017-11-24 Thread Greg Kurz
On Thu, 23 Nov 2017 14:29:32 +0100 Cédric Le Goater wrote: > The 'intc' pointer of the CPU references the interrupt presenter in > the XICS interrupt mode. When the XIVE interrupt mode is available and > activated, the machine will need to reassign this pointer to reflect > the change. > > Movin

Re: [Qemu-devel] [PATCH v1 0/2] check VirtiQueue Vring objects

2017-11-24 Thread Paolo Bonzini
On 24/11/2017 08:55, P J P wrote: > From: Prasad J Pandit > > Hello, > > An user could attempt to use an uninitialised VirtQueue object > or set Vring object with undue values, raising an unexpected > exception in Qemu. This patch set fixes this issue and also adds > a unit test to the suite. >

[Qemu-devel] [PATCH for 2.11] hw/arm/virt: Add 2.11 machine type

2017-11-24 Thread Eric Auger
Add virt-2.11 machine type. Signed-off-by: Eric Auger --- --- hw/arm/virt.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/hw/arm/virt.c b/hw/arm/virt.c index 9e18b41..151592b 100644 --- a/hw/arm/virt.c +++ b/hw/arm/virt.c @@ -1618,7 +1618,7 @@ static v

Re: [Qemu-devel] [PATCH] docs/devel/migration.txt: keep functions consistent with the code

2017-11-24 Thread Dr. David Alan Gilbert
* Jay Zhou (jianjay.z...@huawei.com) wrote: > This patch does not touch any code at all. > > So I think this patch is not relevant to this test failure. Yes, that's true; there's a block problem that's been affecting all tests recently. Dave > Regards, > Jay > > On 2017/11/23 17:15, no-re...@p

Re: [Qemu-devel] [RFC v3 0/4] vITS Reset

2017-11-24 Thread Cornelia Huck
On Thu, 23 Nov 2017 19:01:46 +0100 Christian Borntraeger wrote: > On 11/23/2017 06:44 PM, Auger Eric wrote: > > Hi Cornelia, Peter, > > > > On 23/11/17 18:14, Cornelia Huck wrote: > >> On Thu, 23 Nov 2017 17:01:32 + > >> Peter Maydell wrote: > >> > >>> On 23 November 2017 at 16:05, Auge

Re: [Qemu-devel] [Qemu-ppc] [PATCH 01/25] ppc/xics: introduce an icp_create() helper

2017-11-24 Thread Greg Kurz
On Fri, 24 Nov 2017 13:51:00 +1100 David Gibson wrote: > On Thu, Nov 23, 2017 at 02:29:31PM +0100, Cédric Le Goater wrote: > > The sPAPR and the PowerNV core objects create the interrupt presenter > > object of the CPUs in a very similar way. Let's provide a common > > routine in which we use the

[Qemu-devel] [PULL for-2.11 1/1] s390/kvm_virtio/linux-headers: remove traces of old virtio transport

2017-11-24 Thread Cornelia Huck
From: Christian Borntraeger We no longer support the old s390 transport, neither does the newest Linux kernel. Remove it from the linux header script as well as the s390x virtio code. We still should handle the VIRTIO_NOTIFY hypercall, to tolerate early printk on older guest kernels without an s

[Qemu-devel] [PULL for-2.11 0/1] s390x: headers deletion fallout

2017-11-24 Thread Cornelia Huck
The following changes since commit c65d5e4e1d6841524c49a07bcdd56094f49982a4: configure: Deal with OpenBSD/i386 emulation linker (2017-11-23 16:52:24 +) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20171124 for you to fetch changes up to

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-24 Thread Peter Maydell
On 23 November 2017 at 22:08, Paolo Bonzini wrote: > On 22/11/2017 13:14, Peter Maydell wrote: >>> We do this all of the time for more regular tests that are obviously >>> compile-time. I am a really big fan of this, because it makes sure that the >>> (usually 32-bit) else branch continues to com

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/25] spapr: introduce a spapr_icp_create() helper

2017-11-24 Thread Greg Kurz
On Thu, 23 Nov 2017 14:29:33 +0100 Cédric Le Goater wrote: > On sPAPR, the creation of the interrupt presenter depends on some of > the machine attributes. When the XIVE interrupt mode is available, > this will get more complex. So provide a machine-level helper to > isolate the process and hide

Re: [Qemu-devel] [PATCH] tcg: Fix complilation with TCG

2017-11-24 Thread Paolo Bonzini
On 24/11/2017 11:07, Peter Maydell wrote: > On 23 November 2017 at 22:08, Paolo Bonzini wrote: >> On 22/11/2017 13:14, Peter Maydell wrote: We do this all of the time for more regular tests that are obviously compile-time. I am a really big fan of this, because it makes sure that

Re: [Qemu-devel] [PATCH for 2.11] hw/arm/virt: Add 2.11 machine type

2017-11-24 Thread Peter Maydell
On 24 November 2017 at 09:43, Eric Auger wrote: > Add virt-2.11 machine type. > > Signed-off-by: Eric Auger > > --- Argh, did we forget this again? I think we should just make a rule that we have to bump all the versioned machine types when the dev tree reopens...I wonder if there's a way to cat

Re: [Qemu-devel] [PATCH for 2.11] hw/arm/virt: Add 2.11 machine type

2017-11-24 Thread Auger Eric
Hi Peter, On 24/11/17 11:11, Peter Maydell wrote: > On 24 November 2017 at 09:43, Eric Auger wrote: >> Add virt-2.11 machine type. >> >> Signed-off-by: Eric Auger >> >> --- > > Argh, did we forget this again? Yes we did, please apologize for that. I think we should just > make a rule that we

[Qemu-devel] [Questions] about the VHOST_MEMORY_MAX_NREGIONS of vhost-user backend?

2017-11-24 Thread Gonglei (Arei)
Hi, Currently, the maximum number of supported memory regions for vhost-user backends is 8, and the maximum supported memory regions for vhost-net backends is determined by " /sys/module/vhost/parameters/max_mem_regions". In many scenarios, the vhost-user NIC will cause the memory region to

Re: [Qemu-devel] [PATCH for 2.11] virtio-net: don't touch virtqueue if vm is stopped

2017-11-24 Thread Stefan Hajnoczi
On Fri, Nov 24, 2017 at 10:57:11AM +0800, Jason Wang wrote: > On 2017年11月23日 18:59, Stefan Hajnoczi wrote: > > On Thu, Nov 23, 2017 at 11:37:46AM +0800, Jason Wang wrote: > > > Guest state should not be touched if VM is stopped, unfortunately we > > > didn't check running state and tried to drain t

Re: [Qemu-devel] [RFC v4 23/27] monitor: enable IO thread for (qmp & !mux) typed

2017-11-24 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Start to use dedicate IO thread for QMP monitors that are not using > MUXed chardev. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert I guess another way to do this would be to have a property on the Chardev something like 'can use iothrea

Re: [Qemu-devel] [PATCH] pcc: define the Power-saving mode Exit Cause Enable bits in PowerPCCPUClass

2017-11-24 Thread David Gibson
On Fri, Nov 24, 2017 at 08:04:59AM +0100, Cédric Le Goater wrote: > On 11/24/2017 01:09 AM, David Gibson wrote: > > On Thu, Nov 23, 2017 at 06:05:24PM +0100, Cédric Le Goater wrote: > >> and use the value to define precisely the default value of the LPCR in > >> the helper routine cpu_ppc_set_papr(

Re: [Qemu-devel] [PULL for-2.11 0/1] s390x: headers deletion fallout

2017-11-24 Thread Peter Maydell
//github.com/cohuck/qemu tags/s390x-20171124 > > for you to fetch changes up to c1c4c2192c1c063a6c53c600bb97f20555b2a528: > > s390/kvm_virtio/linux-headers: remove traces of old virtio transport > (2017-11-24 10:52:05 +0100) > >

Re: [Qemu-devel] [PATCH v3] rcu: reduce more than 7MB heap memory by malloc_trim()

2017-11-24 Thread Stefan Hajnoczi
On Fri, Nov 24, 2017 at 02:30:30PM +0800, Yang Zhong wrote: > diff --git a/configure b/configure > index 0c6e757..6292ab0 100755 > --- a/configure > +++ b/configure > @@ -426,6 +426,7 @@ vxhs="" > supported_cpu="no" > supported_os="no" > bogus_os="no" > +malloc_trim="yes" Looks pretty good, sor

Re: [Qemu-devel] [PATCH v1 2/2] tests: add test to check VirtQueue object

2017-11-24 Thread Stefan Hajnoczi
On Fri, Nov 24, 2017 at 01:25:42PM +0530, P J P wrote: > From: Prasad J Pandit > > An uninitialised VirtQueue object or one with Vring.align field > set to zero(0) could lead to arithmetic exceptions. Add a unit > test to validate it. > > Signed-off-by: Prasad J Pandit > --- > tests/virtio-blk

Re: [Qemu-devel] [PATCH v1 1/2] virtio: check VirtQueue Vring object is set

2017-11-24 Thread Stefan Hajnoczi
On Fri, Nov 24, 2017 at 01:25:41PM +0530, P J P wrote: > From: Prasad J Pandit > > An user could attempt to use an uninitialised VirtQueue object > or unset Vring.align leading to a arithmetic exception. Add check > to avoid it. > > Reported-by: Zhangboxian > Signed-off-by: Prasad J Pandit > -

Re: [Qemu-devel] [PATCH RESEND v12 00/12] Add RAS virtualization support in QEMU

2017-11-24 Thread gengdongjiu
Hi all, whether it is possible you can give a review? thanks a lot in advance. I have tested this series patches. as shown in [1][2]. For the APEI GHES table, I only enabled the GPIO-pin, ARMv8 SEA and ARMv8 SEI notification type. and also reserved the space for other notification type. [1] Fo

Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/25] spapr: introduce a spapr_icp_create() helper

2017-11-24 Thread Cédric Le Goater
On 11/24/2017 10:09 AM, Greg Kurz wrote: > On Thu, 23 Nov 2017 14:29:33 +0100 > Cédric Le Goater wrote: > >> On sPAPR, the creation of the interrupt presenter depends on some of >> the machine attributes. When the XIVE interrupt mode is available, >> this will get more complex. So provide a machi

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-24 Thread Pankaj Gupta
Hello, Thank you all for all the useful suggestions. I want to summarize the discussions so far in the thread. Please see below: > >> > >>> We can go with the "best" interface for what > >>> could be a relatively slow flush (fsync on a > >>> file on ssd/disk on the host), which requires > >>> th

[Qemu-devel] [Bug 1732679] Re: Cisco NX-OSv 9k crashes during boot with qemu 2.10.1(Debian 1:2.10.0+dfsg-2) and ovmf 0~20161202.7bbe0b3e-1

2017-11-24 Thread Thomas Huth
Closing, according to the previous comment. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1732679 Title: Cisco NX-OSv 9k crashes during boot with

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-24 Thread Paolo Bonzini
On 24/11/2017 13:40, Pankaj Gupta wrote: >- Suggestion by Paolo & Stefan(previously) to use virtio-blk makes sense > if just > want a flush vehicle to send guest commands to host and get reply after > asynchronous > execution. There was previous discussion [1] with Rik & Dan on thi

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-24 Thread Cornelia Huck
On Thu, 23 Nov 2017 14:33:56 +0100 Halil Pasic wrote: > Having an adequate representation for the css in QOM would be certainly > interesting, but at the same time (IMHO) is somewhat challenging. Let me > make some observations, which should some of my concerns. > > We already have virtual-css-

[Qemu-devel] Windows 10 guest hang during 'info mem'

2017-11-24 Thread Igor Mammedov
I've stumbled on WS2016 hang when trying to list memory map in QEMU. Steps to reproduce: qemu-system-x86_64 -monitor stdio -enable-kvm -m 1G ws2016x64.img wait till guest boots and execute in monitor (qemu) info mem qemu will hang while printing mappings, consuming 100% cpu and not respondi

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-24 Thread Christian Borntraeger
On 11/24/2017 01:46 PM, Cornelia Huck wrote: > On Thu, 23 Nov 2017 14:33:56 +0100 > Halil Pasic wrote: > >> Having an adequate representation for the css in QOM would be certainly >> interesting, but at the same time (IMHO) is somewhat challenging. Let me >> make some observations, which should

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-24 Thread Pankaj Gupta
> >- Suggestion by Paolo & Stefan(previously) to use virtio-blk makes sense > >if just > > want a flush vehicle to send guest commands to host and get reply > > after asynchronous > > execution. There was previous discussion [1] with Rik & Dan on this. > > > > [1] https

Re: [Qemu-devel] [RFC v4 21/27] qmp: let migrate-incoming allow out-of-band

2017-11-24 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > So it can get rid of being run on main thread. > > Signed-off-by: Peter Xu Last time I asked if you were sure that we didn't do locking, and you explained that we end up just setting up a callback that happens in the mainloop, and this shouldn't take a loc

Re: [Qemu-devel] [QEMU-PPC] [PATCH 1/2] target/ppc: Move setting of patb_entry on hash table init

2017-11-24 Thread Greg Kurz
On Fri, 24 Nov 2017 15:23:24 +1100 Suraj Jitindar Singh wrote: > The patb_entry is used to store the location of the process table in > guest memory. The msb is also used to indicate the mmu mode of the > guest, that is patb_entry & 1 << 63 ? radix_mode : hash_mode. > > Currently we set this to

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-24 Thread Paolo Bonzini
On 24/11/2017 14:02, Pankaj Gupta wrote: > >>>- Suggestion by Paolo & Stefan(previously) to use virtio-blk makes sense >>>if just >>> want a flush vehicle to send guest commands to host and get reply >>> after asynchronous >>> execution. There was previous discussion [1] wit

[Qemu-devel] [PATCH] i386: turn off l3-cache property by default

2017-11-24 Thread Denis Plotnikov
Commit 14c985cffa "target-i386: present virtual L3 cache info for vcpus" introduced and set by default exposing l3 to the guest. The motivation behind it was that in the Linux scheduler, when waking up a task on a sibling CPU, the task was put onto the target CPU's runqueue directly, without sendi

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-24 Thread Cornelia Huck
On Fri, 24 Nov 2017 14:01:20 +0100 Christian Borntraeger wrote: > I first liked the idea to have it as a property of the css, but > this is all pretty unclear how to do right. I start to think that going with > Halils first patch (a property per virtio device) is going to be the most > simple so

[Qemu-devel] [PATCH v4 1/4] hw/intc/arm_gicv3_its: Don't call post_load on reset

2017-11-24 Thread Eric Auger
>From the very beginning, post_load() was called from common reset. This is not standard and obliged to discriminate the reset case from the restore case using the iidr value. Let's get rid of that call. Signed-off-by: Eric Auger --- hw/intc/arm_gicv3_its_common.c | 2 -- hw/intc/arm_gicv3_its_

[Qemu-devel] [PATCH v4 4/4] hw/intc/arm_gicv3_its: Implement full reset

2017-11-24 Thread Eric Auger
Voiding the ITS caches is not supposed to happen via individual register writes. So we introduced a dedicated ITS KVM device ioctl to perform a cold reset of the ITS: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_ITS_CTRL_RESET. Let's use this latter if the kernel supports it. Signed-off-by: Eric Auger -

[Qemu-devel] [PATCH v4 0/4] vITS Reset

2017-11-24 Thread Eric Auger
At the moment the ITS is not properly reset. On System reset or reboot, previous ITS register values and caches are left unchanged. Some of the registers might point to some guest RAM tables which are not valid anymore. This leads to state inconsistencies that are detected by the kernel save/restor

[Qemu-devel] [PATCH v4 2/4] hw/intc/arm_gicv3_its: Implement a minimalist reset

2017-11-24 Thread Eric Auger
At the moment the ITS is not properly reset and this causes various bugs on save/restore. We implement a minimalist reset through individual register writes but for kernel versions before v4.15 this fails voiding the vITS cache. We cannot claim we have a comprehensive reset (hence the error message

[Qemu-devel] [PATCH v4 3/4] linux-headers: update to pre 4.15-rc0

2017-11-24 Thread Eric Auger
Update headers against post v4.14 and pre v4.15-rc0. Signed-off-by: Eric Auger --- include/standard-headers/asm-s390/virtio-ccw.h | 1 + include/standard-headers/asm-x86/hyperv.h | 394 + include/standard-headers/linux/input-event-codes.h | 2 + include/stand

Re: [Qemu-devel] [PATCH v4 2/4] hw/intc/arm_gicv3_its: Implement a minimalist reset

2017-11-24 Thread Peter Maydell
On 24 November 2017 at 13:30, Eric Auger wrote: > At the moment the ITS is not properly reset and this causes > various bugs on save/restore. We implement a minimalist reset > through individual register writes but for kernel versions > before v4.15 this fails voiding the vITS cache. We cannot > c

Re: [Qemu-devel] [PATCH v4 3/4] linux-headers: update to pre 4.15-rc0

2017-11-24 Thread Peter Maydell
On 24 November 2017 at 13:30, Eric Auger wrote: > Update headers against post v4.14 and pre v4.15-rc0. > > Signed-off-by: Eric Auger > --- > include/standard-headers/asm-s390/virtio-ccw.h | 1 + > include/standard-headers/asm-x86/hyperv.h | 394 > + > include/

Re: [Qemu-devel] [PATCH v4 2/4] hw/intc/arm_gicv3_its: Implement a minimalist reset

2017-11-24 Thread Auger Eric
Hi Peter, On 24/11/17 14:34, Peter Maydell wrote: > On 24 November 2017 at 13:30, Eric Auger wrote: >> At the moment the ITS is not properly reset and this causes >> various bugs on save/restore. We implement a minimalist reset >> through individual register writes but for kernel versions >> befor

Re: [Qemu-devel] [PATCH v4 1/4] hw/intc/arm_gicv3_its: Don't call post_load on reset

2017-11-24 Thread Peter Maydell
On 24 November 2017 at 13:30, Eric Auger wrote: > From the very beginning, post_load() was called from common > reset. This is not standard and obliged to discriminate the > reset case from the restore case using the iidr value. > > Let's get rid of that call. > > Signed-off-by: Eric Auger > ---

Re: [Qemu-devel] [PATCH v4 4/4] hw/intc/arm_gicv3_its: Implement full reset

2017-11-24 Thread Peter Maydell
On 24 November 2017 at 13:30, Eric Auger wrote: > Voiding the ITS caches is not supposed to happen via > individual register writes. So we introduced a dedicated > ITS KVM device ioctl to perform a cold reset of the ITS: > KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_ITS_CTRL_RESET. Let's > use this latt

[Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2017-11-24 Thread Eduardo Otubo
v3: * Removed all unecessary local_err * Change return of isa_bus_dma() and DMA_init() from void to int8_t, returning -EBUSY on error and 0 on success * Added qdev_cleanup_nofail() in case isa_bus_dma() returns error. The cleanup looks safe, but please review if I didn't miss any detail v

Re: [Qemu-devel] [PATCH v4 3/4] linux-headers: update to pre 4.15-rc0

2017-11-24 Thread Auger Eric
Hi Peter, On 24/11/17 14:38, Peter Maydell wrote: > On 24 November 2017 at 13:30, Eric Auger wrote: >> Update headers against post v4.14 and pre v4.15-rc0. >> >> Signed-off-by: Eric Auger >> --- >> include/standard-headers/asm-s390/virtio-ccw.h | 1 + >> include/standard-headers/asm-x86/h

Re: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11

2017-11-24 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11 Type: series Message-id: 20171120215034.22212-1-mdr...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 t

Re: [Qemu-devel] Windows 10 guest hang during 'info mem'

2017-11-24 Thread Paolo Bonzini
On 24/11/2017 13:57, Igor Mammedov wrote: > I've stumbled on WS2016 hang when trying to list memory map in QEMU. > > Steps to reproduce: > qemu-system-x86_64 -monitor stdio -enable-kvm -m 1G ws2016x64.img > wait till guest boots and execute in monitor > (qemu) info mem > > qemu will hang wh

[Qemu-devel] [Bug 1721224] Re: qemu crashes with Assertion `!bus->dma[0] && !bus->dma[1]' failed

2017-11-24 Thread Eduardo Otubo
v2 patch posted on list and waiting for review: https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg04604.html [PATCHv3] dma/i82374: avoid double creation of i82374 device -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://

[Qemu-devel] [PATCH v5 0/4] ITS Reset

2017-11-24 Thread Eric Auger
At the moment the ITS is not properly reset. On System reset or reboot, previous ITS register values and caches are left unchanged. Some of the registers might point to some guest RAM tables which are not valid anymore. This leads to state inconsistencies that are detected by the kernel save/restor

[Qemu-devel] [PATCH v5 1/4] hw/intc/arm_gicv3_its: Don't call post_load on reset

2017-11-24 Thread Eric Auger
>From the very beginning, post_load() was called from common reset. This is not standard and obliged to discriminate the reset case from the restore case using the iidr value. Let's get rid of that call. Signed-off-by: Eric Auger Reviewed-by: Peter Maydell --- v4 -> V5: - added Peter's R-b --

[Qemu-devel] [PATCH v5 2/4] hw/intc/arm_gicv3_its: Implement a minimalist reset

2017-11-24 Thread Eric Auger
At the moment the ITS is not properly reset and this causes various bugs on save/restore. We implement a minimalist reset through individual register writes but for kernel versions before v4.15 this fails voiding the vITS cache. We cannot claim we have a comprehensive reset (hence the error message

[Qemu-devel] [PATCH v5 3/4] linux-headers: update to pre 4.15-rc0

2017-11-24 Thread Eric Auger
Update headers against post v4.14 and pre v4.15-rc0. Signed-off-by: Eric Auger --- include/standard-headers/asm-s390/virtio-ccw.h | 1 + include/standard-headers/asm-x86/hyperv.h | 394 + include/standard-headers/linux/input-event-codes.h | 2 + include/stand

[Qemu-devel] [PATCH v5 4/4] hw/intc/arm_gicv3_its: Implement full reset

2017-11-24 Thread Eric Auger
Voiding the ITS caches is not supposed to happen via individual register writes. So we introduced a dedicated ITS KVM device ioctl to perform a cold reset of the ITS: KVM_DEV_ARM_VGIC_GRP_CTRL/KVM_DEV_ARM_ITS_CTRL_RESET. Let's use this latter if the kernel supports it. Signed-off-by: Eric Auger -

Re: [Qemu-devel] [PATCH v5 0/4] ITS Reset

2017-11-24 Thread Peter Maydell
On 24 November 2017 at 14:18, Eric Auger wrote: > At the moment the ITS is not properly reset. On System reset or > reboot, previous ITS register values and caches are left > unchanged. Some of the registers might point to some guest RAM > tables which are not valid anymore. This leads to state >

[Qemu-devel] [PATCH] util: add is_equal to UUID API

2017-11-24 Thread Roman Kagan
It's going to be useful, in particular, in VMBus code massively using uuids aka GUIDs. Signed-off-by: Roman Kagan --- include/qemu/uuid.h | 2 ++ tests/test-uuid.c | 24 util/uuid.c | 7 ++- 3 files changed, 32 insertions(+), 1 deletion(-) diff --git a/i

Re: [Qemu-devel] [PATCH v5 0/4] ITS Reset

2017-11-24 Thread Auger Eric
Hi Peter, On 24/11/17 15:20, Peter Maydell wrote: > On 24 November 2017 at 14:18, Eric Auger wrote: >> At the moment the ITS is not properly reset. On System reset or >> reboot, previous ITS register values and caches are left >> unchanged. Some of the registers might point to some guest RAM >> t

Re: [Qemu-devel] [PATCH v5 0/4] ITS Reset

2017-11-24 Thread Peter Maydell
On 24 November 2017 at 14:32, Auger Eric wrote: > On 24/11/17 15:20, Peter Maydell wrote: >> Thanks. My remaining question is: how important it is to >> put some of this into 2.11? We're getting quite close to >> the release now so I'm getting gradually more reluctant >> to put in changes. > > I f

Re: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device

2017-11-24 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCHv3] dma/i82374: avoid double creation of i82374 device Type: series Message-id: 20171124134644.49

Re: [Qemu-devel] [PATCH v5 0/4] ITS Reset

2017-11-24 Thread Auger Eric
Hi Peter, On 24/11/17 15:35, Peter Maydell wrote: > On 24 November 2017 at 14:32, Auger Eric wrote: >> On 24/11/17 15:20, Peter Maydell wrote: >>> Thanks. My remaining question is: how important it is to >>> put some of this into 2.11? We're getting quite close to >>> the release now so I'm gettin

Re: [Qemu-devel] Windows 10 guest hang during 'info mem'

2017-11-24 Thread Igor Mammedov
On Fri, 24 Nov 2017 15:05:24 +0100 Paolo Bonzini wrote: > On 24/11/2017 13:57, Igor Mammedov wrote: > > I've stumbled on WS2016 hang when trying to list memory map in QEMU. > > > > Steps to reproduce: > > qemu-system-x86_64 -monitor stdio -enable-kvm -m 1G ws2016x64.img > > wait till guest bo

Re: [Qemu-devel] [ovs-dev] [PATCH RFC] netdev-dpdk: Fix device obtain mac address when received first packet in vhost type

2017-11-24 Thread Chen Hailin
Hi Aaron Conole && Jianfeng, The stp could not work in ovs-dpdk vhostuser. Because the attached vhost device doesn't have MAC address. Now we have two ways to solve this problem. 1. The vhost learns MAC address from packet like as my first patch. 2. The virtio notifies MAC address actively to vho

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-24 Thread Christian Borntraeger
On 11/24/2017 02:27 PM, Cornelia Huck wrote: > On Fri, 24 Nov 2017 14:01:20 +0100 > Christian Borntraeger wrote: > >> I first liked the idea to have it as a property of the css, but >> this is all pretty unclear how to do right. I start to think that going with >> Halils first patch (a propert

Re: [Qemu-devel] [PATCH for-2.12 0/4] qmp dirty bitmap API

2017-11-24 Thread Vladimir Sementsov-Ogievskiy
John, Kevin, do we reach a consensus? Can we go on with this? 20.11.2017 19:00, Denis V. Lunev wrote: On 11/17/2017 06:10 AM, John Snow wrote: On 11/16/2017 03:17 AM, Vladimir Sementsov-Ogievskiy wrote: 16.11.2017 00:20, John Snow wrote: On 11/13/2017 11:20 AM, Vladimir Sementsov-Ogievskiy wr

Re: [Qemu-devel] [PATCH for-2.11?] osdep.h: Make TIME_MAX handle different time_t types

2017-11-24 Thread Peter Maydell
On 23 November 2017 at 16:00, Paolo Bonzini wrote: > On 23/11/2017 16:56, Peter Maydell wrote: >> In our various supported host OSes, the time_t type may be either 32 >> or 64 bit, and could in theory also be either signed or unsigned. >> Notably, in OpenBSD time_t is a 64 bit type even if 'long'

Re: [Qemu-devel] [PATCH for 2.11] hw/arm/virt: Add 2.11 machine type

2017-11-24 Thread Peter Maydell
On 24 November 2017 at 10:16, Auger Eric wrote: > Hi Peter, > > On 24/11/17 11:11, Peter Maydell wrote: >> On 24 November 2017 at 09:43, Eric Auger wrote: >>> Add virt-2.11 machine type. >>> >>> Signed-off-by: Eric Auger >>> >>> --- >> >> Argh, did we forget this again? > > Yes we did, please ap

Re: [Qemu-devel] [PATCH v2 2/2] qemu-options: Mention locking option of file driver

2017-11-24 Thread Kevin Wolf
Am 24.11.2017 um 09:53 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > --- > qemu-options.hx | 4 > 1 file changed, 4 insertions(+) > > diff --git a/qemu-options.hx b/qemu-options.hx > index 3728e9b4dd..f10c2a3ddb 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -693,6 +6

Re: [Qemu-devel] [PATCH v2 0/2] docs: Add documentation for image locking

2017-11-24 Thread Kevin Wolf
Am 24.11.2017 um 09:53 hat Fam Zheng geschrieben: > v2: Grammar and spelling fixes pointed out by Kevin and Philipp. > > Image locking feature was added in 2.10 but the documentation has been > missing. > Users sometimes get confused and wonder how to configure it for their specific > needs. We s

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-24 Thread Halil Pasic
On 11/24/2017 03:58 PM, Christian Borntraeger wrote: > > > On 11/24/2017 02:27 PM, Cornelia Huck wrote: >> On Fri, 24 Nov 2017 14:01:20 +0100 >> Christian Borntraeger wrote: >> >>> I first liked the idea to have it as a property of the css, but >>> this is all pretty unclear how to do right.

[Qemu-devel] [PATCH for-2.12] s390x: introduce 2.12 compat machine

2017-11-24 Thread Cornelia Huck
Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 17 - include/hw/compat.h| 3 +++ 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 6a57f94197..a23b8aec9f 100644 --- a/hw/s390x/s390-v

Re: [Qemu-devel] [PATCH for-2.12] s390x: introduce 2.12 compat machine

2017-11-24 Thread Christian Borntraeger
On 11/24/2017 04:33 PM, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck Just to be ahead of ARM again? ;-) Acked-by: Christian Borntraeger + > --- > hw/s390x/s390-virtio-ccw.c | 17 - > include/hw/compat.h| 3 +++ > 2 files changed, 19 insertions(+), 1 deletion(

[Qemu-devel] [PATCH 0/2] add UUID property type

2017-11-24 Thread Roman Kagan
UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated property type becomes helpful. In the existing code, vmgenid can immediately profit from it. Roman Kagan (2): qdev-properties: add UUID property type vmgenid: use UUID property type include/hw/qdev-properties.h | 3 +++ h

Re: [Qemu-devel] [PATCH for-2.12] s390x: introduce 2.12 compat machine

2017-11-24 Thread David Hildenbrand
On 24.11.2017 16:33, Cornelia Huck wrote: > Signed-off-by: Cornelia Huck > --- > hw/s390x/s390-virtio-ccw.c | 17 - > include/hw/compat.h| 3 +++ > 2 files changed, 19 insertions(+), 1 deletion(-) > > diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c >

[Qemu-devel] [PATCH 1/2] qdev-properties: add UUID property type

2017-11-24 Thread Roman Kagan
UUIDs (GUIDs) are widely used in VMBus-related stuff, so a dedicated property type becomes helpful. Signed-off-by: Roman Kagan --- include/hw/qdev-properties.h | 3 +++ hw/core/qdev-properties.c| 52 2 files changed, 55 insertions(+) diff --git

[Qemu-devel] [PATCH 2/2] vmgenid: use UUID property type

2017-11-24 Thread Roman Kagan
Switch vmgenid device to use the UUID property type introduced in the previous patch for its 'guid' property. One semantic change it introduces is that post-realize modification of 'guid' via HMP or QMP will now be rejected with an error; however, according to docs/specs/vmgenid.txt this is actual

Re: [Qemu-devel] [PATCH for-2.12 2/2] xlnx-zynqmp: add the timers

2017-11-24 Thread KONRAD Frederic
On 11/23/2017 01:29 AM, Alistair Francis wrote: On Wed, Nov 8, 2017 at 3:32 AM, KONRAD Frederic wrote: This adds the TTC to the xlnx-zynqmp board according to the ultrascale TRM. Signed-off-by: KONRAD Frederic --- hw/arm/xlnx-zynqmp.c | 25 + include/hw/ar

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-24 Thread Cornelia Huck
On Fri, 24 Nov 2017 16:30:24 +0100 Halil Pasic wrote: > On 11/24/2017 03:58 PM, Christian Borntraeger wrote: > > > > > > On 11/24/2017 02:27 PM, Cornelia Huck wrote: > >> On Fri, 24 Nov 2017 14:01:20 +0100 > >> Christian Borntraeger wrote: > >> > >>> I first liked the idea to have it as a

  1   2   >