Re: [Qemu-devel] qemu-system-ppc hangs

2017-11-21 Thread Richard Purdie
On Tue, 2017-11-21 at 07:50 +, Mark Cave-Ayland wrote: > On 21/11/17 00:00, Richard Purdie wrote: > > I work on the Yocto Project and we use qemu to test boot our Linux > > images and run tests against them. We've been noticing some > > instability > > for ppc where the images sometimes hang, u

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr: Implement bug in spapr-vty device to be compatible with PowerVM

2017-11-21 Thread Greg Kurz
On Tue, 21 Nov 2017 08:27:51 +0100 Thomas Huth wrote: > On 20.11.2017 08:14, David Gibson wrote: > > The spapr-vty device implements the PAPR defined virtual console, > > which is also implemented by IBM's proprietary PowerVM hypervisor. > > > > PowerVM's implementation has a bug where it insert

Re: [Qemu-devel] [PATCH for-2.11] Makefile: use $(MAKE) variable

2017-11-21 Thread Philippe Mathieu-Daudé
On 11/21/2017 03:01 AM, Fam Zheng wrote: > On Tue, 11/21 00:21, Philippe Mathieu-Daudé wrote: >> @@ -904,7 +904,7 @@ $(patsubst %, check-%, $(check-qapi-schema-y)): >> check-%.json: $(SRC_PATH)/%.json >> echo $$? >$*.test.exit, \ >> "TEST","$*.out") >> @diff -q $(SRC

Re: [Qemu-devel] qemu-system-ppc hangs

2017-11-21 Thread Alex Bennée
Richard Purdie writes: > Hi, > > I work on the Yocto Project and we use qemu to test boot our Linux > images and run tests against them. We've been noticing some instability > for ppc where the images sometimes hang, usually around udevd bring up > time so just after booting into userspace. > >

[Qemu-devel] [PATCH v2 for-2.11] Makefile: use $(MAKE) variable

2017-11-21 Thread Philippe Mathieu-Daudé
For some systems (i.e. FreeBSD) the default 'make' is not compatible with the GNU extensions used by QEMU makefiles. Calling the GNU make (gmake) works, however the help displayed refers to the host 'make' and copy/paste leads to lot of unobvious errors: $ gmake check-help [...] make check

Re: [Qemu-devel] [PULL for-2.11 0/4] s390x fixes for 2.11

2017-11-21 Thread Peter Maydell
On 20 November 2017 at 15:21, Cornelia Huck wrote: > The following changes since commit 2e02083438962d26ef9dcc7100f3b378104183db: > > Merge remote-tracking branch 'remotes/kevin/tags/for-upstream' into staging > (2017-11-17 19:08:07 +) > > are available in the git repository at: > > git:/

Re: [Qemu-devel] [PATCH v4 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

2017-11-21 Thread Kashyap Chamarthy
On Fri, Nov 17, 2017 at 07:54:44PM +0100, Kashyap Chamarthy wrote: [...] > +So there are two possible actions to take, after a 'mirror' job has > +emitted the event ``BLOCK_JOB_READY``, indicating that the source and > +target have reached synchronization: > + > +(1) Issuing the command ``block-j

Re: [Qemu-devel] Questions about usability mess that caused by differentiating address based on devices types

2017-11-21 Thread Cornelia Huck
On Tue, 21 Nov 2017 14:51:26 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2017-11-14 11:50:14 +0100]: > > Hallo Conny, > > After spending some time, just some updates for this one. > > > On Tue, 14 Nov 2017 16:25:47 +0800 > > Dong Jia Shi wrote: > > > So that we can remove the restrictions

[Qemu-devel] [PATCH RESEND v12 03/12] docs: APEI GHES generation description

2017-11-21 Thread Dongjiu Geng
Add APEI/GHES description document Signed-off-by: Dongjiu Geng --- Address Igor's comments to add a doc --- docs/specs/acpi_hest_ghes.txt | 98 +++ 1 file changed, 98 insertions(+) create mode 100644 docs/specs/acpi_hest_ghes.txt diff --git a/docs/specs/

[Qemu-devel] [PATCH RESEND v12 08/12] target-arm: kvm64: inject synchronous External Abort

2017-11-21 Thread Dongjiu Geng
Add synchronous external abort injection logic, setup spsr_elx, esr_elx, PSTATE, elr_elx etc, when switch to guest, guest will jump to the synchronous external abort vector table entry. The ESR_ELx.DFSC is set to Synchronous external abort(0x10), and ESR_ELx.FnV is set to not valid(0x1), which wil

[Qemu-devel] [PATCH RESEND v12 01/12] ACPI: add related GHES structures and macros definition

2017-11-21 Thread Dongjiu Geng
Add Generic Error Status Block structures and some macros definition, which refer to the ACPI 4.0 and ACPI 6.1. The HEST table generation and CPER record will use them. Signed-off-by: Dongjiu Geng --- Address Igor's comments to to get rid of most structures and use build_append_int_noprefix() AP

[Qemu-devel] [PATCH RESEND v12 00/12] Add RAS virtualization support in QEMU

2017-11-21 Thread Dongjiu Geng
In the ARMv8 platform, the CPU error type are synchronous external abort(SEA) and SError Interrupt (SEI). If guest happen exception, sometimes guest itself do the recovery is better, because host does not know guest's detailed info. For example, if a guest user-space application happen exception

[Qemu-devel] [PATCH RESEND v12 04/12] ACPI: enable APEI GHES in the configure file and build it

2017-11-21 Thread Dongjiu Geng
Add CONFIG_ACPI_APEI configuration in the arm-softmmu.mak and add build choice in the Makefile.objs. Signed-off-by: Dongjiu Geng --- default-configs/arm-softmmu.mak | 1 + hw/acpi/Makefile.objs | 1 + 2 files changed, 2 insertions(+) diff --git a/default-configs/arm-softmmu.mak b/defa

[Qemu-devel] [PATCH RESEND v12 02/12] ACPI: Add APEI GHES table generation and CPER record support

2017-11-21 Thread Dongjiu Geng
This implements APEI GHES Table generation when OS boot and record CPER in runtime via fw_cfg blobs. After a CPER info is recorded into guest memory, it need to inject whatever interrupt (or assert whatever GPIO line) to notify the guest. About the detailed design or implementation, please see the

[Qemu-devel] [PATCH RESEND v12 12/12] target-arm: kvm64: handle SIGBUS signal from kernel or KVM

2017-11-21 Thread Dongjiu Geng
Add SIGBUS signal handler. In this handler, it checks the SIGBUS type, translate the host VA which is delivered by host to guest PA, then fill this PA to CPER and fill the CPER to guest APEI GHES memory, finally notify guest according the SIGBUS type. There are two kinds of SIGBUS that QEMU need to

[Qemu-devel] [PATCH RESEND v12 09/12] Move related hwpoison page function to accel/kvm/ folder

2017-11-21 Thread Dongjiu Geng
kvm_hwpoison_page_add() and kvm_unpoison_all() will be used by both X86 and ARM platforms, so move them to a common accel/kvm/ folder to avoid duplicate code. Signed-off-by: Dongjiu Geng --- Address Peter's comments to move related hwpoison page function to accel/kvm folder in [1] Address Paolo'

[Qemu-devel] [PATCH RESEND v12 10/12] ARM: ACPI: Add _E04 for hardware error device

2017-11-21 Thread Dongjiu Geng
In ARM platform we implements a notification of error events via a GPIO pin. In this case of GPIO-signaled events, an _AEI object lists the appropriate GPIO pin. GPIO pin 4 is used for hardware error device (PNP0C33), so add _E04 in ACPI DSDT table. When GPIO-pin 4 signaled a events, the guest ACP

[Qemu-devel] [PATCH RESEND v12 05/12] linux-headers: sync against Linux v4.14-rc8

2017-11-21 Thread Dongjiu Geng
Signed-off-by: Dongjiu Geng --- Address Peter's comments to sync mainline Linux header file in [1] [1]: https://lkml.org/lkml/2017/9/5/575 --- include/standard-headers/asm-s390/kvm_virtio.h | 1 + include/standard-headers/asm-s390/virtio-ccw.h | 1 + include/standard-headers/asm-x86/hyp

[Qemu-devel] [PATCH RESEND v12 11/12] hw/arm/virt: Add RAS platform version for migration

2017-11-21 Thread Dongjiu Geng
Support this feature since version 2.10, disable it by default in the old version. Signed-off-by: Dongjiu Geng --- Address Shannon's comments to add platform version in [1]. [1]: https://lkml.org/lkml/2017/8/25/821 --- hw/arm/virt-acpi-build.c | 14 +- hw/arm/virt.c| 4

[Qemu-devel] [PATCH RESEND v12 06/12] target-arm: kvm64: detect whether can set vsesr_el2

2017-11-21 Thread Dongjiu Geng
Check if kvm can support to set vsesr_el2 value for vcpu. When guest takes a virtual SError interrupt exception, this value will provides syndrome value reported into ESR_EL1 ISS filed. Signed-off-by: Dongjiu Geng Signed-off-by: Quanming Wu --- Address James's(james.mo...@arm.com) comments to d

[Qemu-devel] [PATCH RESEND v12 07/12] target-arm: handle SError interrupt exception from the guest OS

2017-11-21 Thread Dongjiu Geng
When guest OS happens SError interrupt(SEI), it will trap to host. Host check the Asynchronous Error Type(ESR_ELx.AET). If it the error has not been propagated and has not (yet) been architecturally consumed by the PE, it will return to use space with error code KVM_SEI_SEV_RECOVERABLE. Qemu recei

Re: [Qemu-devel] [PATCH v2 4/7] s390x/pci: rework PCI STORE BLOCK

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:52 +0100 Pierre Morel wrote: > Enhance the fault detection. > > Fixup the precedence to check the destination path existance > before checking for the source accessibility. > > Add the maxstbl entry to both the Query PCI Function Group > response and the PCIBusDevice s

Re: [Qemu-devel] [PATCH v2 1/7] s390x/pci: factor out endianess conversion

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:49 +0100 Pierre Morel wrote: > There are two places where the same endianness conversion > is done. > Let's factor this out into a static function. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > Signed-off-by: Pierre Morel Your two s-o-bs look a bit od

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:50 +0100 Pierre Morel wrote: > Enhance the fault detection, correction of the fault reporting. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > Signed-off-by: Pierre Morel Same double s-o-b. > --- > hw/s390x/s390-pci-inst.c | 39 ++-

Re: [Qemu-devel] [PULL 0/5] target-arm queue for rc2

2017-11-21 Thread Peter Maydell
On 20 November 2017 at 17:37, Peter Maydell wrote: > A small set of bugfixes for rc2. (Some are patches I > should have put into rc1 but forgot about; oops.) > > thanks > -- PMM > > > The following changes since commit b11ce33fe0266f8ede18cfcf961536f6a209b02b: > > Revert "cpu-exec: don't overwri

Re: [Qemu-devel] [PATCH v2 3/7] s390x/pci: rework PCI LOAD

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:51 +0100 Pierre Morel wrote: > Enhance the fault detection, correction of the fault reporting. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > Signed-off-by: Pierre Morel Same as last patch... > --- > hw/s390x/s390-pci-inst.c | 25 ++--

Re: [Qemu-devel] [PATCH v2 5/7] s390x/pci: move the memory region read from pcilg

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:53 +0100 Pierre Morel wrote: > Let's move the memory region read from pcilg into a dedicated function. > This allows us to prepare a later patch. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > --- > hw/s390x/s390-pci-inst.c | 15 +++ > 1 fil

Re: [Qemu-devel] [PATCH v2 6/7] s390x/pci: move the memory region write from pcistg

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:54 +0100 Pierre Morel wrote: > Let's move the memory region write from pcistg into a dedicated > function. > This allows us to prepare a later patch searching for subregions > inside of the memory region. > > Signed-off-by: Pierre Morel > Reviewed-by: Yi Min Zhao > --

Re: [Qemu-devel] [PATCH v2 7/7] s390x/pci: search for subregion inside the BARs

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:55 +0100 Pierre Morel wrote: > When dispatching memory access to PCI BAR region, we must > look for possible subregions, used by the PCI device to map > different memory areas inside the same PCI BAR. > > Since the data offset we received is calculated starting at the >

Re: [Qemu-devel] [PATCH v2 0/7] s390x/pci: Improve zPCI to cover more cases

2017-11-21 Thread Cornelia Huck
On Thu, 16 Nov 2017 18:51:48 +0100 Pierre Morel wrote: > This patch fixes the following BUG: > Even a guest is able to detect virtio_pci device, the init function > the Linux virtio_pci driver will hang because zPCI does not support > the subregions used by virtio_pci. > > It follows that right

Re: [Qemu-devel] [PATCH v7 3/5] fw_cfg: do DMA read operation

2017-11-21 Thread Marc-André Lureau
Hi - Original Message - > On Mon, Nov 20, 2017 at 10:55:17AM +0100, Marc-André Lureau wrote: > > Modify fw_cfg_read_blob() to use DMA if the device supports it. > > Return errors, because the operation may fail. > > > > The DMA operation is expected to run synchronously with today qemu, >

[Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-21 Thread Halil Pasic
The default css 0xFE is currently restricted to virtual subchannel devices. The hope when the decision was made was, that non-virtual subchannel devices will come around when guest can exploit multiple channel subsystems. Since the guests generally don't do, the pain of the partitioned (cssid) name

Re: [Qemu-devel] [PULL 00/15] late linux-user fixes for 2.11

2017-11-21 Thread Peter Maydell
On 20 November 2017 at 21:21, wrote: > From: Riku Voipio > > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) > > are available in the git repository at: > > git://git.linaro.org/people/riku.vo

Re: [Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks

2017-11-21 Thread Vladimir Sementsov-Ogievskiy
Hi! Is it a latest portion of moving to byte-based? All other parts are already merged? Are you going to update it? (or this version if ok for review?) 12.10.2017 21:58, Eric Blake wrote: There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to report status on byte gr

Re: [Qemu-devel] [PATCH v2 1/4] qcow2: multiple clusters write compressed

2017-11-21 Thread Stefan Hajnoczi
On Mon, Nov 20, 2017 at 06:03:00PM +0300, Denis V. Lunev wrote: > On 11/20/2017 05:53 PM, Stefan Hajnoczi wrote: > > On Thu, Nov 16, 2017 at 07:54:55PM +0300, Anton Nefedov wrote: > >> From: Pavel Butsykin > >> > >> At the moment, qcow2_co_pwritev_compressed can process the requests size > >> less

[Qemu-devel] [PATCH v5 for-2.11] QAPI & interop: Clarify events emitted by 'block-job-cancel'

2017-11-21 Thread Kashyap Chamarthy
When you cancel an in-progress 'mirror' job (or "active `block-commit`") with QMP `block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. However, when `block-job-cancel` is issued *after* `drive-mirror` has indicated (via the event BLOCK_JOB_READY) that the source and destination have reached

Re: [Qemu-devel] [Qemu-block] [PATCH 3/5] coroutines: abort if we try to enter a still-sleeping coroutine

2017-11-21 Thread Stefan Hajnoczi
On Mon, Nov 20, 2017 at 08:45:21AM -0500, Jeff Cody wrote: > On Mon, Nov 20, 2017 at 11:43:34AM +, Stefan Hajnoczi wrote: > > On Sun, Nov 19, 2017 at 09:46:44PM -0500, Jeff Cody wrote: > > BTW an alternative to adding individual bools is to implement a finite > > state machine for the entire co

Re: [Qemu-devel] [PATCH 1/2] Use qemu.org domain name

2017-11-21 Thread Stefan Hajnoczi
On Mon, Nov 20, 2017 at 02:26:15PM +, Peter Maydell wrote: > On 20 November 2017 at 14:22, Stefan Hajnoczi wrote: > > The owner of qemu.org has delegated authority to modify DNS records to > > the QEMU Project. This has allowed us to use the domain name without > > worries about IP address ch

Re: [Qemu-devel] [PATCH v2 for-2.11 1/4] blockjob: do not allow coroutine double entry or entry-after-completion

2017-11-21 Thread Stefan Hajnoczi
On Mon, Nov 20, 2017 at 09:23:23PM -0500, Jeff Cody wrote: > @@ -291,10 +291,10 @@ void block_job_start(BlockJob *job) > { > assert(job && !block_job_started(job) && job->paused && > job->driver && job->driver->start); > -job->co = qemu_coroutine_create(block_job_co_entry, job

Re: [Qemu-devel] [RISU PATCH 6/7] risugen: support @GroupName in risu files

2017-11-21 Thread Peter Maydell
On 31 October 2017 at 14:54, Alex Bennée wrote: > The existing pattern support is useful but it does get a little > tedious when faced with large groups of instructions. This introduces > the concept of a @GroupName which can be sprinkled in the risu > definition and is attached to all instruction

Re: [Qemu-devel] [Qemu-block] [PATCH 1/5] blockjob: do not allow coroutine double entry or entry-after-completion

2017-11-21 Thread Stefan Hajnoczi
On Mon, Nov 20, 2017 at 08:36:19AM -0500, Jeff Cody wrote: > On Mon, Nov 20, 2017 at 11:16:53AM +, Stefan Hajnoczi wrote: > > On Sun, Nov 19, 2017 at 09:46:42PM -0500, Jeff Cody wrote: > > > --- a/blockjob.c > > > +++ b/blockjob.c > > > @@ -291,10 +291,10 @@ void block_job_start(BlockJob *job)

[Qemu-devel] [PATCH for-2.11 v2 0/2] Update qemu.org domains

2017-11-21 Thread Stefan Hajnoczi
v2: * Do not change SeaBIOS extraversion string [Eduardo] * Do not change git submodules [Peter] The first patch replaces qemu-project.org with qemu.org. The second uses HTTPS URLs instead of HTTP. I have left out the .gitmodules and SeaBIOS extraversion changes. They will be sent separately.

[Qemu-devel] [PATCH for-2.11 v2 1/2] Use qemu.org domain name

2017-11-21 Thread Stefan Hajnoczi
The owner of qemu.org has delegated authority to modify DNS records to the QEMU Project. This has allowed us to use the domain name without worries about IP address changes or technical issues disrupting service. The issues described in commit 859389810910f232188675d2f10b15f1aad77660 ("Use qemu-pr

Re: [Qemu-devel] [PULL for-2.11 0/1] qemu-ga patch queue for 2.11

2017-11-21 Thread Peter Maydell
On 20 November 2017 at 21:50, Michael Roth wrote: > The following changes since commit b2996bb405e2806725a341c72d80be9e77ed8b82: > > Merge remote-tracking branch 'remotes/dgibson/tags/ppc-for-2.11-20171120' > into staging (2017-11-20 18:00:16 +) > > are available in the git repository at: >

[Qemu-devel] [PATCH for-2.11 v2 2/2] Use HTTPS for qemu.org and other domains

2017-11-21 Thread Stefan Hajnoczi
qemu.org enabled HTTPS in 2017 and it should be used instead of HTTP. There are also URLs to json.org, openvpn.net, and other domains that support HTTPS. This patch updates the qemu.org domains everywhere and also third-party domains that I have checked. Signed-off-by: Stefan Hajnoczi --- MAINT

Re: [Qemu-devel] [PATCH v2 for-2.11 2/4] coroutine: abort if we try to schedule or enter a pending coroutine

2017-11-21 Thread Stefan Hajnoczi
On Mon, Nov 20, 2017 at 09:23:24PM -0500, Jeff Cody wrote: > @@ -438,6 +439,16 @@ fail: > void aio_co_schedule(AioContext *ctx, Coroutine *co) > { > trace_aio_co_schedule(ctx, co); > +const char *scheduled = atomic_read(&co->scheduled); > + > +if (scheduled) { > +fprintf(stde

Re: [Qemu-devel] [RISU PATCH 0/7] Add @Group support and some aarch64.risu cleanups

2017-11-21 Thread Peter Maydell
On 31 October 2017 at 14:54, Alex Bennée wrote: > Hi Peter, > > My RISU patch queue was running a little long so I thought I should > push up stuff that was ready. The first few patches are simply > clean-ups to the aarch64.risu file, mostly removing duplicate blocks > that have crept in. > > Ther

Re: [Qemu-devel] [PATCH v2 for-2.11] Makefile: use $(MAKE) variable

2017-11-21 Thread Eric Blake
On 11/21/2017 03:55 AM, Philippe Mathieu-Daudé wrote: > For some systems (i.e. FreeBSD) the default 'make' is not compatible with the > GNU extensions used by QEMU makefiles. > > Calling the GNU make (gmake) works, however the help displayed refers to the > host 'make' and copy/paste leads to lot

Re: [Qemu-devel] [PATCH v2 for-2.11 2/4] coroutine: abort if we try to schedule or enter a pending coroutine

2017-11-21 Thread Eric Blake
On 11/20/2017 08:23 PM, Jeff Cody wrote: > The previous patch fixed a race condition, in which there were > coroutines being executing doubly, or after coroutine deletion. > > We can detect common scenarios when this happens, and print an error > message and abort before we corrupt memory / data,

Re: [Qemu-devel] [PATCH v4 00/20] add byte-based block_status driver callbacks

2017-11-21 Thread Eric Blake
On 11/21/2017 05:27 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > Is it a latest portion of moving to byte-based? All other parts are > already merged? Are you going to update it? (or this version if ok for > review?) This version is okay to review; although it will need a v5 respin once 2.12

Re: [Qemu-devel] [Qemu-block] [PATCH 1/5] blockjob: do not allow coroutine double entry or entry-after-completion

2017-11-21 Thread Kevin Wolf
Am 20.11.2017 um 23:25 hat Paolo Bonzini geschrieben: > On 20/11/2017 12:16, Stefan Hajnoczi wrote: > > This raises questions about the ability to cancel sleep: > > > > 1. Does something depend on cancelling sleep? > > block_job_cancel does, but in practice the sleep time is so small > (smaller t

Re: [Qemu-devel] [PATCH v2 for-2.11 0/2] Fix TCG atomic writes to nondirty pages

2017-11-21 Thread Peter Maydell
On 20 November 2017 at 20:54, Paolo Bonzini wrote: > On 20/11/2017 19:08, Peter Maydell wrote: >> To do a write to memory that is marked as notdirty, we need >> to invalidate any TBs we have cached for that memory, and >> update the cpu physical memory dirty flags for VGA and migration. >> The slo

Re: [Qemu-devel] [Qemu-block] segfault in parallel blockjobs (iotest 30)

2017-11-21 Thread Alberto Garcia
On Thu 16 Nov 2017 05:09:59 PM CET, Anton Nefedov wrote: I have the impression that one major source of headaches is the fact that the reopen queue contains nodes that don't need to be reopened at all. Ideally this should be detected early on in bdrv_reopen_queue(), so there's n

Re: [Qemu-devel] [PATCH v2 for-2.11 2/4] coroutine: abort if we try to schedule or enter a pending coroutine

2017-11-21 Thread Paolo Bonzini
On 21/11/2017 11:59, Stefan Hajnoczi wrote: > On Mon, Nov 20, 2017 at 09:23:24PM -0500, Jeff Cody wrote: >> @@ -438,6 +439,16 @@ fail: >> void aio_co_schedule(AioContext *ctx, Coroutine *co) >> { >> trace_aio_co_schedule(ctx, co); >> +const char *scheduled = atomic_read(&co->scheduled);

Re: [Qemu-devel] [PATCH v2 for-2.11 1/4] blockjob: do not allow coroutine double entry or entry-after-completion

2017-11-21 Thread Paolo Bonzini
On 21/11/2017 11:49, Stefan Hajnoczi wrote: > On Mon, Nov 20, 2017 at 09:23:23PM -0500, Jeff Cody wrote: >> @@ -291,10 +291,10 @@ void block_job_start(BlockJob *job) >> { >> assert(job && !block_job_started(job) && job->paused && >> job->driver && job->driver->start); >> -job-

Re: [Qemu-devel] [PATCH v1] ps2: check PS2Queue pointers in post_load routine

2017-11-21 Thread Dr. David Alan Gilbert
* Gerd Hoffmann (kra...@redhat.com) wrote: > > > diff --git a/hw/input/ps2.c b/hw/input/ps2.c > > > index f388a23c8e..de171a28dd 100644 > > > --- a/hw/input/ps2.c > > > +++ b/hw/input/ps2.c > > > @@ -1225,24 +1225,21 @@ static void ps2_common_reset(PS2State *s) > > > static void ps2_common_post_lo

Re: [Qemu-devel] [PULL 00/15] late linux-user fixes for 2.11

2017-11-21 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Type: series Subject: [Qemu-devel] [PULL 00/15] late linux-user fixes for 2.11 Message-id: cover.1511212753.git.riku.voi...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will be invoked under the gi

Re: [Qemu-devel] [Qemu-stable] [PATCH for-2.11] scripts/make-release: ship u-boot source as a tarball

2017-11-21 Thread Peter Maydell
On 20 November 2017 at 22:00, Michael Roth wrote: > Quoting Michael Roth (2017-11-07 14:52:01) >> The u-boot sources we ship currently cause problems with unpacking on >> a case-insensitive filesystem due to path conflicts. This has been >> fixed in upstream u-boot via commit 610eec7f, but since i

Re: [Qemu-devel] [PATCH v2] tests/bios-tables-test: Fix endianess problems when passing data to iasl

2017-11-21 Thread Igor Mammedov
On Mon, 20 Nov 2017 22:32:29 +0200 "Michael S. Tsirkin" wrote: > On Mon, Nov 20, 2017 at 05:55:22PM +0100, Igor Mammedov wrote: > > On Thu, 16 Nov 2017 13:17:02 +0100 > > Thomas Huth wrote: > > > > > The bios-tables-test was writing out files that we pass to iasl in > > > with the wrong endia

Re: [Qemu-devel] [PATCH v2 for-2.11 1/4] blockjob: do not allow coroutine double entry or entry-after-completion

2017-11-21 Thread Jeff Cody
On Tue, Nov 21, 2017 at 02:12:32PM +0100, Paolo Bonzini wrote: > On 21/11/2017 11:49, Stefan Hajnoczi wrote: > > On Mon, Nov 20, 2017 at 09:23:23PM -0500, Jeff Cody wrote: > >> @@ -291,10 +291,10 @@ void block_job_start(BlockJob *job) > >> { > >> assert(job && !block_job_started(job) && job->

Re: [Qemu-devel] [RFC PATCH 1/1] s390x/css: unresrict cssids

2017-11-21 Thread Cornelia Huck
On Tue, 21 Nov 2017 12:18:25 +0100 Halil Pasic wrote: Subject: s/unresrict/unrestrict/ > The default css 0xFE is currently restricted to virtual subchannel > devices. The hope when the decision was made was, that non-virtual > subchannel devices will come around when guest can exploit multiple >

Re: [Qemu-devel] [PATCH v2 for-2.11 2/4] coroutine: abort if we try to schedule or enter a pending coroutine

2017-11-21 Thread Kevin Wolf
Am 21.11.2017 um 03:23 hat Jeff Cody geschrieben: > The previous patch fixed a race condition, in which there were > coroutines being executing doubly, or after coroutine deletion. > > We can detect common scenarios when this happens, and print an error > message and abort before we corrupt memory

Re: [Qemu-devel] [RFC v2 3/6] possible_cpus: add CPUArchId::type field

2017-11-21 Thread Igor Mammedov
On Thu, 9 Nov 2017 18:02:35 -0200 Eduardo Habkost wrote: > On Thu, Nov 09, 2017 at 05:58:03PM +1100, David Gibson wrote: > > On Tue, Nov 07, 2017 at 04:04:04PM +0100, Cornelia Huck wrote: > > > On Mon, 6 Nov 2017 16:02:16 -0200 > > > Eduardo Habkost wrote: > > > > > > > On Tue, Oct 31, 2017

[Qemu-devel] [PATCH v3 01/45] windbg: added empty windbgstub files

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- Makefile.target |7 +++ include/exec/windbgstub-utils.h | 18 ++ include/exec/windbgstub.h | 17 + stubs/Makefile.objs

[Qemu-devel] [PATCH v3 00/45] Windbg supporting

2017-11-21 Thread Mihail Abakumov
An update of: v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07092.html We made the debugger module WinDbg (like GDB) for QEMU. This is the replacement of the remote stub in Windows kernel. Used for remote Windows kernel debugging without debugging mode. WinDbg is a m

[Qemu-devel] [PATCH v3 02/45] windbg: added windbg's KD header file

2017-11-21 Thread Mihail Abakumov
Header file from windbg's source code describing the main structures. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 873 +++ include/exec/windbgstub-utils.h |1 2 fil

[Qemu-devel] [PATCH v3 04/45] windbg: added '-windbg' option

2017-11-21 Thread Mihail Abakumov
This option starts windbg server. Signed-off-by: Mihail Abakumov Acked-by: Alistair Francis Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- qemu-options.hx |8 vl.c|8 2 files changed, 16 insertions(+) diff --git a/qemu-options.hx b/qe

[Qemu-devel] [PATCH v3 08/45] windbg: hook to wrmsr operation

2017-11-21 Thread Mihail Abakumov
Inserted hook to wrmsr operation. Windows Kernel put address on KPCR struct to fs/gs (x32/x64) register. Needs catch this moment and allow windbg server handle packets. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-u

[Qemu-devel] [PATCH v3 11/45] windbg: parsing data stream

2017-11-21 Thread Mihail Abakumov
Added function of parsing data stream from windbg to packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 111 +- 1 file changed, 110 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v3 03/45] windbg: modified windbgkd.h

2017-11-21 Thread Mihail Abakumov
Added useful name arrays of some defines. Not used yet. Needs for the future. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 75 +++ 1 file changed, 75 insertions(+) diff

[Qemu-devel] [PATCH v3 05/45] windbg: added helper features

2017-11-21 Thread Mihail Abakumov
Added some helper features for windbgstub. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 27 +++ include/exec/windbgstub.h |6 ++ 2 files changed, 33 insertions(+) dif

[Qemu-devel] [PATCH v3 06/45] windbg: added WindbgState

2017-11-21 Thread Mihail Abakumov
Added definition of the WindbgState struct and its initialization. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 28 1 file changed, 28 insertions(+) diff --git a/windbgstub.c b/windbgstub.c inde

[Qemu-devel] [PATCH v3 13/45] windbg: handler of parsing context

2017-11-21 Thread Mihail Abakumov
Implemented handler of parsing context. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 36 ++-- 1 file changed, 34 insertions(+), 2 deletions(-) diff --git a/windbgstub.c b/windbgstub.c index 8

[Qemu-devel] [PATCH v3 12/45] windbg: send data and control packets

2017-11-21 Thread Mihail Abakumov
Added functions for send data and control packets to windbg. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 56 1 file changed, 56 insertions(+) diff --git a/windbgstub

[Qemu-devel] [PATCH v3 19/45] windbg: implemented windbg_process_control_packet

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/windbgstub.c b/windbgstub.c index dc9eba3e3c..b2d4881ee8 100755 --- a/windbgstub.c +++

[Qemu-devel] [PATCH v3 21/45] windbg: implemented windbg_process_manipulate_packet

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ windbgstub-utils.c |8 windbgstub.c| 26 +- 3 files changed, 35 insertions(+), 1 d

[Qemu-devel] [PATCH v3 16/45] windbg: generate ExceptionStateChange

2017-11-21 Thread Mihail Abakumov
Added function for generate ExceptionStateChange packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ target/i386/windbgstub.c| 20 +++- 2 files changed, 21 insertions(+),

[Qemu-devel] [PATCH v3 15/45] windbg: sized data buffer

2017-11-21 Thread Mihail Abakumov
Defined useful sized data buffer. It contains pointer to data and size of this data. Also, defined some macros for init and free. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 16 1 file c

[Qemu-devel] [PATCH v3 07/45] windbg: added chardev

2017-11-21 Thread Mihail Abakumov
Added chardev for listening to windbg. Target device is a parameter in the '-windbg' option. Signed-off-by: Mihail Abakumov Acked-by: Alistair Francis Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 30 ++ 1 file changed, 30 ins

[Qemu-devel] [PATCH v3 31/45] windbg: implemented windbg_set_dr

2017-11-21 Thread Mihail Abakumov
Defined useful macros for breakpoints. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 50 +- 1 file changed, 49 insertions(+), 1 deletion(-) diff --git a/target/i386/win

[Qemu-devel] [PATCH v3 17/45] windbg: generate LoadSymbolsStateChange

2017-11-21 Thread Mihail Abakumov
Added function for generate LoadSymbolsStateChange packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + target/i386/windbgstub.c| 15 +++ 2 files changed, 16 insertions(+) diff

[Qemu-devel] [PATCH v3 10/45] windbg: structures for parsing data stream

2017-11-21 Thread Mihail Abakumov
Added structures for parsing data stream from windbg to packet. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h | 11 +++ windbgstub.c| 30 ++ 2 files c

[Qemu-devel] [PATCH v3 22/45] windbg: implemented kd_api_read_virtual_memory and kd_api_write_virtual_memory

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ windbgstub-utils.c | 47 +++ windbgstub.c|8 +++ 3 files changed, 57 insert

[Qemu-devel] [PATCH v3 42/45] windbg: implemented kd_api_fill_memory

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |1 + windbgstub-utils.c | 39 +++ windbgstub.c|4 3 files changed, 44 insertions

[Qemu-devel] [PATCH v3 26/45] windbg: implemented windbg_read_context

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 96 ++ 1 file changed, 96 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index bf1afab1f8..

[Qemu-devel] [PATCH v3 09/45] windbg: handler of fs/gs register

2017-11-21 Thread Mihail Abakumov
Added handler of fs/gs register. It tries to find and check KPCR and version address. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |8 ++ target/i386/windbgstub.c| 49 +++

[Qemu-devel] [PATCH v3 20/45] windbg: implemented windbg_process_data_packet

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 20 +++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/windbgstub.c b/windbgstub.c index b2d4881ee8..8058972dc7 100755 --- a/windbgstub.c +++ b/wind

[Qemu-devel] [PATCH v3 44/45] windbg: added new api functions

2017-11-21 Thread Mihail Abakumov
Added some definitions for new windbg. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgkd.h | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/include/exec/windbgkd.h b/include/exec/wi

[Qemu-devel] [PATCH v3 25/45] windbg: implemented kd_api_read_control_space and kd_api_write_control_space

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 + target/i386/windbgstub.c| 89 +++ windbgstub.c|8 3 files changed, 99 insertions

[Qemu-devel] [PATCH v3 14/45] windbg: init DBGKD_ANY_WAIT_STATE_CHANGE

2017-11-21 Thread Mihail Abakumov
Added function for init DBGKD_ANY_WAIT_STATE_CHANGE. It is a header of 'state change' packets. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |8 ++ target/i386/windbgstub.c| 49 +

[Qemu-devel] [PATCH v3 23/45] windbg: kernel's structures

2017-11-21 Thread Mihail Abakumov
Defined Windows kernel's structures (CPU_CONTEXT and CPU_KSPECIAL_REGISTERS) for i386 and x64_86. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 247 ++ 1 file changed, 2

[Qemu-devel] [PATCH v3 18/45] windbg: windbg_vm_stop

2017-11-21 Thread Mihail Abakumov
Added function for stop vm. Also, ExceptionStateChange data is generated and sent here. Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- windbgstub.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/windbgstu

[Qemu-devel] [PATCH v3 27/45] windbg: implemented windbg_write_context

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 212 ++ 1 file changed, 212 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index 1fccd8eee7.

[Qemu-devel] [PATCH v3 28/45] windbg: implemented windbg_read_ks_regs

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index dc2a10f8e6..c492ee5

[Qemu-devel] [PATCH v3 24/45] windbg: implemented kd_api_get_context and kd_api_set_context

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 ++ target/i386/windbgstub.c| 39 +++ windbgstub.c|8 3 files changed, 49 inser

[Qemu-devel] [PATCH v3 40/45] windbg: implemented kd_api_read_msr and kd_api_write_msr

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- include/exec/windbgstub-utils.h |2 target/i386/windbgstub.c| 319 +++ windbgstub.c|8 + 3 files changed, 329 insertions(+)

[Qemu-devel] [PATCH v3 29/45] windbg: implemented windbg_write_ks_regs

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 111 ++ 1 file changed, 111 insertions(+) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index c492ee58d8.

[Qemu-devel] [PATCH v1] hmp: 'info snapshots' not showing the id

2017-11-21 Thread Seeteena Thoufeek
(qemu) info snapshots List of snapshots present on all disks: IDTAG VM SIZEDATE VM CLOCK -- 1 314M 2017-11-15 15:22:18 00:02:25.695 -- 2 319M 2017-11-15 15:23:03 00:02:45.970 -- 3

Re: [Qemu-devel] [PATCH v2 2/7] s390x/pci: rework PCI STORE

2017-11-21 Thread Cornelia Huck
On Tue, 21 Nov 2017 11:38:45 +0100 Cornelia Huck wrote: > On Thu, 16 Nov 2017 18:51:50 +0100 > Pierre Morel wrote: > > @@ -493,9 +494,13 @@ int pcistg_service_call(S390CPU *cpu, uint8_t r1, > > uint8_t r2) > > break; > > } > > > > -data = env->regs[r1]; > > -if (pcias <

[Qemu-devel] [PATCH v3 30/45] windbg: implemented windbg_set_sr

2017-11-21 Thread Mihail Abakumov
Signed-off-by: Mihail Abakumov Signed-off-by: Pavel Dovgalyuk Signed-off-by: Dmitriy Koltunov --- target/i386/windbgstub.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/target/i386/windbgstub.c b/target/i386/windbgstub.c index 63962b48dd..c59d1401ad 100

  1   2   3   >