On 11/14/2017 12:01 PM, Max Reitz wrote:
> Add a new test file (check-qobject.c) for unit tests that concern
> QObjects as a whole.
>
> Its only purpose for now is to test the qobject_is_equal() function.
>
> + * Note that qobject_is_equal() is not really an equivalence relation,
> + * so this f
On 11/14/2017 12:30 PM, Anton Nefedov wrote:
> On 14/11/2017 7:50 PM, Eric Blake wrote:
>> On 11/14/2017 04:16 AM, Anton Nefedov wrote:
>>> Misaligned compressed write is not supported.
>>>
>>> Signed-off-by: Anton Nefedov
>>> ---
>>> block/qcow2.c | 4
>>> 1 file changed, 4 insertions(+)
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Subject: [Qemu-devel] [PATCH] qapi: block-core: Clarify events emitted by
'block-job-cancel'
Type: series
Message-id: 2017111
Le 11/11/2017 à 02:48, Zach Riggle a écrit :
> I wrote up a quick example to show that this should work specifically for
> /proc/self/exe:
>
> #define _GNU_SOURCE
> #include
> #include
> #include
> #include
> int main(int argc, char** argv) {
> int fd = open("/proc/self/exe", O_NOFOLLOW |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v2 for-2.11] hw/net/vmxnet3: Fix code to work on
big endian hosts, too
Type: series
Message-id: 1510658424-16527-1-git-send-email-th...@redhat.com
=== TEST SCRIPT BEGIN
On 11/14/2017 12:41 PM, Max Reitz wrote:
> @mem_size and @offset are both size_t, thus subtracting them from one
> another will just return a big size_t if mem_size < offset -- even more
> obvious here because the result is stored in another size_t.
>
> Checking that result to be positive is there
Hello,
On behalf of the QEMU Team, I'd like to announce the availability of the
second release candidate for the QEMU 2.11 release. This release is meant
for testing purposes and should not be used in a production environment.
http://download.qemu-project.org/qemu-2.11.0-rc1.tar.xz
http://do
On 11/14/2017 01:46 PM, Max Reitz wrote:
> On 2017-11-14 19:45, Thomas Huth wrote:
>> On 14.11.2017 14:32, Max Reitz wrote:
>> [...]
>>> Well, do you want to document it? I'd rather deprecate it altogether.
>>
>> Maybe a first step could be to change qemu-img so that it refuses to
>> create new
On 2017-11-14 21:30, John Snow wrote:
>
>
> On 11/14/2017 01:46 PM, Max Reitz wrote:
>> On 2017-11-14 19:45, Thomas Huth wrote:
>>> On 14.11.2017 14:32, Max Reitz wrote:
>>> [...]
Well, do you want to document it? I'd rather deprecate it altogether.
>>>
>>> Maybe a first step could be to ch
On 11/14/2017 03:35 PM, Max Reitz wrote:
> On 2017-11-14 21:30, John Snow wrote:
>>
>>
>> On 11/14/2017 01:46 PM, Max Reitz wrote:
>>> On 2017-11-14 19:45, Thomas Huth wrote:
On 14.11.2017 14:32, Max Reitz wrote:
[...]
> Well, do you want to document it? I'd rather deprecate it alt
On 2017-11-14 21:38, John Snow wrote:
>
>
> On 11/14/2017 03:35 PM, Max Reitz wrote:
>> On 2017-11-14 21:30, John Snow wrote:
>>>
>>>
>>> On 11/14/2017 01:46 PM, Max Reitz wrote:
On 2017-11-14 19:45, Thomas Huth wrote:
> On 14.11.2017 14:32, Max Reitz wrote:
> [...]
>> Well, do y
It helps but I'm quite sure that lower level security systems (guest)
should never be able to crash higher level security systems
(hypervisor).
PS. It repros in 2.10.0 as well.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://
It happened again, both with the e1000 and the rtl8139 NICs under qemu
2.11.0.rc0-7-g4ffa88c99c. Kernel is the official Arch one, right now on
4.13.12.
At this point I have no idea anymore what could be causing this, and am
unable to test without having to remove basic functionality from the VM
(e
On Tue, Nov 14, 2017 at 05:28:36PM +0100, Dariusz Stojaczyk wrote:
> Commit 5c0919d0 [1] introduced virtqueue_size parameter
> for common virtio-scsi path, without updaing the vhost-user-scsi
> code. vhost-user-scsi devices right now report size 0 for each vq.
>
> This patch introduces virtqueue_s
Hi,
This series failed build test on s390x host. Please find the details below.
Type: series
Subject: [Qemu-devel] [PATCH] qapi: block-core: Clarify events emitted by
'block-job-cancel'
Message-id: 20171114191605.22349-1-kcham...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script
On Tue, Nov 14, 2017 at 08:02:03PM +0800, Wei Wang wrote:
> On 11/14/2017 01:32 AM, Michael S. Tsirkin wrote:
> > > - guest2host_cmd: written by the guest to ACK to the host about the
> > > commands that have been received. The host will clear the corresponding
> > > bits on the host2guest_cmd regi
Am 06.11.2017 um 21:35 schrieb Mike Nawrocki:
> Adds a new PCI ID for the i82559a (0x8086 0x1030) interface. Enables
> this ID with a new property "use-alt-device-id" to preserve
> compatibility.
>
> Signed-off-by: Mike Nawrocki
> ---
> hw/net/eepro100.c| 12
> include/hw/pci/pc
From: Stefan Berger
The following patches fix a performance issue (patch 1) and an
error path issue (patches 2 and 3) for 2.11.
Stefan
Stefan Berger (3):
tpm_emulator: Add a caching layer for the TPM Established flag
tpm_tis: Return TPM_VERSION_UNSPEC in case of BE failure
tpm_tis: Ret
Rather than returning ~0, return 0 for every register in case of
failure mode. The '0' is better to indicate that there's no device
there.
Signed-off-by: Stefan Berger
---
hw/tpm/tpm_tis.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/tpm/tpm_tis.c b/hw/tpm/tpm_tis.c
ind
Hi Yi L,
On 14/11/2017 14:59, Liu, Yi L wrote:
> On Tue, Nov 14, 2017 at 09:53:07AM +0100, Auger Eric wrote:
> Hi Eric,
>
>> Hi Yi L,
>>
>> On 13/11/2017 10:58, Liu, Yi L wrote:
>>> On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote:
On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Y
In case the backend has a failure, such as the tpm_emulator's CMD_INIT
failing, the TIS goes into failure mode and does not respond to reads
or writes to MMIO registers. In this case we need to prevent the ACPI
table from being added and the straight-forward way is to indicate that
there's no known
Add a caching layer for the TPM established flag so that we don't
need to go to the emulator every time the flag is read by accessing
the REG_ACCESS register.
Signed-off-by: Stefan Berger
v1->v2:
- move the caching to the backend layer since detecting the
TPM 1.2 TSC_ResetEstablishmentBit()
This fixes a crash caused by picking the wrong memory region in
address_space_lookup_region seen with client code accessing a device
model that uses alias memory regions.
Signed-off-by: BALATON Zoltan
---
exec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/exec.c b/exec.c
index 97a24a8..e
On Tue, 14 Nov 2017, Paolo Bonzini wrote:
On 21/10/2017 13:24, BALATON Zoltan wrote:
diff --git a/exec.c b/exec.c
index db5ae23..a915817 100644
--- a/exec.c
+++ b/exec.c
@@ -370,7 +370,8 @@ static inline bool section_covers_addr(const
MemoryRegionSection *section,
* the section must cover
From: Prasad Singamsetty
This pair of patches extends the intel-iommu to support address
width to 48 bits. This is required to support qemu guest with large
memory (>=1TB).
Patch1 implements changes to redefine macros and usage to
allow further changes to add support for 48 bit address width.
T
From: Prasad Singamsetty
The current implementation of Intel IOMMU code only supports 39 bits
host/iova address width so number of macros use hard coded values based
on that. This patch is to redefine them so they can be used with
variable address widths. This patch doesn't add any new functional
From: Prasad Singamsetty
The current implementation of Intel IOMMU code only supports 39 bits
iova address width. This patch provides a new parameter (x-aw-bits)
for intel-iommu to extend its address width to 48 bits but keeping the
default the same (39 bits). The reason for not changing the defa
stat64_min_slow() and stat64_max_slow() compare the wrong way. This
makes iotest 136 fail with clang and -m32.
Signed-off-by: Max Reitz
---
util/stats64.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/util/stats64.c b/util/stats64.c
index 9968fcceac..389c365a9e 100644
The transmit offload implementation in QEMU's e1000 device is
deficient and causes packet data corruption in some situations.
According to the Intel 8254x software developer's manual[1], the
device maintains two separate contexts: the TCP segmentation offload
context includes parameters for both s
sum_needed and cptse flags are received from the guest within each
transmit data descriptor. They are not part of the offload context;
instead, they determine how to apply a previously received context to
the packet being transmitted:
- If cptse is set, perform both segmentation and checksum offlo
The device is supposed to maintain two distinct contexts for transmit
offloads: one has parameters for both segmentation and checksum
offload, the other only for checksum offload. The guest driver can
send two context descriptors, one for each context (the TSE flag
specifies which). Then the guest
Hi,
This series failed build test on ppc host. Please find the details below.
Type: series
Subject: [Qemu-devel] [PATCH] qapi: block-core: Clarify events emitted by
'block-job-cancel'
Message-id: 20171114191605.22349-1-kcham...@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script w
The checksum algorithm used by IPv4, TCP and UDP allows a zero value
to be represented by either 0x and 0x. But per RFC 768, a zero
UDP checksum must be transmitted as 0x, as 0x is a special
value meaning no checksum.
Substitute 0x whenever a checksum is computed as zero on a U
On 2017-11-14 19:01, Max Reitz wrote:
> bdrv_reopen_prepare() assumes that all BDS options are strings, which is
> not necessarily correct. This series introduces a new qobject_is_equal()
> function which can be used to test whether any options have changed,
> independently of their type.
Aaand on
On Tue, 14 Nov 2017 12:20:24 +0100
Thomas Huth wrote:
> Since commit ab06ec43577177a442e8 we test the vmxnet3 device in the
> pxe-tester, too (when running "make check SPEED=slow"). This now
> revealed that the code is not working there if the host is a big
> endian machine (for example ppc64 or
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
> Add a caching layer for the TPM established flag so that we don't
> need to go to the emulator every time the flag is read by accessing
> the REG_ACCESS register.
What's the impact? Isn't this just a "small" optimization? Iotw, why
is t
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
> In case the backend has a failure, such as the tpm_emulator's CMD_INIT
> failing, the TIS goes into failure mode and does not respond to reads
> or writes to MMIO registers. In this case we need to prevent the ACPI
> table from being add
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
> Rather than returning ~0, return 0 for every register in case of
> failure mode. The '0' is better to indicate that there's no device
> there.
For most registers, 0 makes more sense. However, I wonder if we
shouldn't just fail to start
On Thu, Nov 9, 2017 at 5:53 AM, Daniel P. Berrange wrote:
> My fear is that this approach of building a new e1000-ng device in
> parallel with having the existing e1000 device is going to cause
> long term pain, possibly never getting to a state where the e1000-ng
> device can replace the e1000 de
- Max Reitz ha scritto:
> stat64_min_slow() and stat64_max_slow() compare the wrong way. This
> makes iotest 136 fail with clang and -m32.
Queued, thanks.
Cc: qemu-sta...@nongnu.org
Paolo
> Signed-off-by: Max Reitz
> ---
> util/stats64.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 d
On Tue, Nov 7, 2017 at 7:01 AM, Peter Maydell wrote:
> The CPU ID registers ID_AA64PFR0_EL1, ID_PFR1_EL1 and ID_PFR1
> have a field for reporting presence of GICv3 system registers.
> We need to report this field correctly in order for Xen to
> work as a guest inside QEMU emulation. We mustn't inc
On 11/14/2017 06:40 PM, Marc-André Lureau wrote:
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
Add a caching layer for the TPM established flag so that we don't
need to go to the emulator every time the flag is read by accessing
the REG_ACCESS register.
What's the impact? Isn't th
On 11/14/2017 06:47 PM, Marc-André Lureau wrote:
Hi
On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
wrote:
Rather than returning ~0, return 0 for every register in case of
failure mode. The '0' is better to indicate that there's no device
there.
For most registers, 0 makes more sense. However
Quoting lu.zhip...@zte.com.cn (2017-11-14 05:09:35)
> i test the latest qga in xp , it run ok .
>
>
> my qga config :
>
> Configured with: './configure' '--enable-guest-agent' '--cross-prefix=
> x86_64-w64-mingw32-' '--with-vss-sdk=/home/VSSSDK72' '--disable-fdt'
> '--target-list=x86_64
Hi Igor,
[...]
+parse_numa_node(ms, &node, NULL);
I get build break here:
numa.c:451:13: error: too few arguments to function ‘parse_numa_node’
parse_numa_node(ms, &node, NULL);
In upstream tree, your commit
cc001888b780 ("numa: fixup parsed NumaNodeOptions earli
i used xp version:
xp professional 2002 service pack 3
build environment:
root@localhost qemu-2.5.0]# cat /etc/redhat-release
CentOS Linux release 7.0.1406 (Core)
为了让您的VPlat虚拟机故障和docker故障得到高效的处理，请上报故障到: $VPlat技术支持。
芦志朋 luzhipeng
IT开发工程师 IT Development
E
On 10/30/2017 12:33 PM, Vladimir Sementsov-Ogievskiy wrote:
> Postcopy migration of dirty bitmaps. Only named dirty bitmaps,
> associated with root nodes and non-root named nodes are migrated.
>
> If destination qemu is already containing a dirty bitmap with the same name
> as a migrated bitmap
On 2017年11月15日 07:25, Ed Swierk wrote:
The checksum algorithm used by IPv4, TCP and UDP allows a zero value
to be represented by either 0x and 0x. But per RFC 768, a zero
UDP checksum must be transmitted as 0x, as 0x is a special
value meaning no checksum.
Substitute 0x whe
On Mon, Nov 13, 2017 at 03:07:45PM +0200, Marcel Apfelbaum wrote:
> On 11/11/2017 17:25, Marcel Apfelbaum wrote:
> > Currently there is no MMIO range over 4G
> > reserved for PCI hotplug. Since the 32bit PCI hole
> > depends on the number of cold-plugged PCI devices
> > and other factors, it is ver
Quoting lu.zhip...@zte.com.cn (2017-11-14 19:41:58)
> i used xp version:
>
> xp professional 2002 service pack 3
Hmm, doesn't --cross-prefix=x86_64-w64-mingw32- result in a 64-bit
qemu-ga.exe? How are you running this on 32-bit Windows XP?
>
> build environment:
>
> root@localhost qemu-2.5.
On Tue, Nov 14, 2017 at 6:10 PM, Jason Wang wrote:
>
>
> On 2017年11月15日 07:25, Ed Swierk wrote:
>>
>> The checksum algorithm used by IPv4, TCP and UDP allows a zero value
>> to be represented by either 0x and 0x. But per RFC 768, a zero
>> UDP checksum must be transmitted as 0x, as 0x0
Quoting lu.zhip...@zte.com.cn (2017-11-14 19:41:58)> i used xp version:> > xp
professional 2002 service pack 3>Hmm, doesn't
--cross-prefix=x86_64-w64-mingw32- result in a 64-bit> qemu-ga.exe? How are you
running this on 32-bit Windows XP?
i build two version :32bit and 64 bit , run 32bit
Hi Eric,
On Tue, Nov 14, 2017 at 10:52:54PM +0100, Auger Eric wrote:
> Hi Yi L,
>
> On 14/11/2017 14:59, Liu, Yi L wrote:
> > On Tue, Nov 14, 2017 at 09:53:07AM +0100, Auger Eric wrote:
> > Hi Eric,
> >
> >> Hi Yi L,
> >>
> >> On 13/11/2017 10:58, Liu, Yi L wrote:
> >>> On Mon, Nov 13, 2017 at 0
The checksum algorithm used by IPv4, TCP and UDP allows a zero value
to be represented by either 0x and 0x. But per RFC 768, a zero
UDP checksum must be transmitted as 0x, as 0x is a special
value meaning no checksum.
Substitute 0x whenever a checksum is computed as zero when
m
build 32 bit config:
./configure --enable-guest-agent --cross-prefix=i686-w64-mingw32-
--with-vss-sdk="/home/VSSSDK72" --disable-fdt --target-list=i386-softmmu
为了让您的VPlat虚拟机故障和docker故障得到高效的处理，请上报故障到: $VPlat技术支持。
芦志朋 luzhipeng
IT开发工程师 IT Development
Engineer
操作系统产品
Hi, guys
I met a strange problem, with qemu 2.8.1:
qemu consumes too many heap memory after several operations and can not release
them anymore:
hot pulg/unplug disk & net, vnc connect/disconnect, guestOS reboot, etc.
01a7a000-3b4efe000 rw-p 00:00 0 [hea
On 11/15/2017 05:21 AM, Michael S. Tsirkin wrote:
On Tue, Nov 14, 2017 at 08:02:03PM +0800, Wei Wang wrote:
On 11/14/2017 01:32 AM, Michael S. Tsirkin wrote:
- guest2host_cmd: written by the guest to ACK to the host about the
commands that have been received. The host will clear the correspondi
Hi
On Wed, Nov 15, 2017 at 2:18 AM, Stefan Berger
wrote:
> On 11/14/2017 06:47 PM, Marc-André Lureau wrote:
>>
>> Hi
>>
>> On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
>> wrote:
>>>
>>> Rather than returning ~0, return 0 for every register in case of
>>> failure mode. The '0' is better to ind
Hi
On Wed, Nov 15, 2017 at 2:16 AM, Stefan Berger
wrote:
> On 11/14/2017 06:40 PM, Marc-André Lureau wrote:
>>
>> Hi
>>
>> On Tue, Nov 14, 2017 at 10:52 PM, Stefan Berger
>> wrote:
>>>
>>> Add a caching layer for the TPM established flag so that we don't
>>> need to go to the emulator every time
在 2017/11/14 19:40, Marc-André Lureau 写道:
> Hi
>
> On Tue, Nov 14, 2017 at 8:09 AM, fangying wrote:
>> Hi all,
>>
>> We have a vm running migration with vhost-user as network backend, we notice
>> that qemu will abort when openvswitch is restarted
>> when MEMORY_LISTENER_CALL_GLOBAL(log_global
Some more details about this experiment:
The host is running Ubuntu-16.04 with 4.4.0 Linux kernel and QEMU-2.5.1; The
guest is running Ubuntu-12.04, except Memcached with Ubuntu-16.04.
The exact numbers of the proportions of write-not-dirty pages for the first
2 pre-copy iterations: (0.445 mea
Hi,
I currently think that this patch is wrong and should be reverted.
It fixes a certain use case by hacking the PCI device id, but does
not model the way how that device id is set on the real hardware
correctly.
As far as I know, all i82559 have a default PCI device id of 0x1229.
It can be cha
Max Reitz writes:
> On 2017-11-14 15:57, Markus Armbruster wrote:
>> Max Reitz writes:
>>
>>> Signed-off-by: Max Reitz
>>> ---
>>> include/qapi/qmp/qdict.h | 1 +
>>> qobject/qdict.c | 10 ++
>>> 2 files changed, 11 insertions(+)
>>>
>>> diff --git a/include/qapi/qmp/qdict.h
From: Ying Fang
QEMU will abort when vhost-user process is restarted during migration when
vhost_log_global_start/stop is called. The reason is clear that
vhost_dev_set_log returns -1 because network connection is temporarily lost.
To handle this situation, let's cancel migration and report it to
On 15.11.2017 00:33, David Gibson wrote:
> On Tue, 14 Nov 2017 12:20:24 +0100
> Thomas Huth wrote:
>
>> Since commit ab06ec43577177a442e8 we test the vmxnet3 device in the
>> pxe-tester, too (when running "make check SPEED=slow"). This now
>> revealed that the code is not working there if the hos
On Tue, Nov 14, 2017 at 10:52:54PM +0100, Auger Eric wrote:
[...]
> I meant, in the current intel_iommu code, vtd_find_add_as() creates 1
> IOMMU MR and 1 AS per PCIe device, right?
I think this is the most tricky point - in QEMU IOMMU MR is not really
a 1:1 relationship to devices. For Intel,
As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"),
QEMU crashes with:
ivshmem: msix_set_vector_notifiers failed
msix_unset_vector_notifiers: Assertion `dev->msix_vector_use_notifier &&
dev->msix_vector_release_notifier' failed.
if MSI-X is repeatedly enabled and disabled
Fixes bugs in the ivshmem device implementation uncovered with the new
Windows ivshmem driver:
https://github.com/virtio-win/kvm-guest-drivers-windows/tree/master/ivshmem
v1->v2:
* Patch 1 - added reproducer info to commit message (Markus)
* Patch 2 - restructured conditionals, fixed comment forma
Adds a rollback path to ivshmem_enable_irqfd() and fixes
ivshmem_disable_irqfd() to bail if irqfd has not been enabled.
To reproduce, run:
ivshmem-server -n 0
and QEMU with:
-device ivshmem-doorbell,chardev=iv
-chardev socket,path=/tmp/ivshmem_socket,id=iv
then load, unload, and load aga
As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"),
QEMU crashes with:
kvm_irqchip_commit_routes: Assertion `ret == 0' failed.
if the ivshmem device is configured with more vectors than what the server
supports. This is caused by the ivshmem_vector_unmask() being called
On Tue, Nov 14, 2017 at 06:13:48PM -0500, prasad.singamse...@oracle.com wrote:
> From: Prasad Singamsetty
>
> This pair of patches extends the intel-iommu to support address
> width to 48 bits. This is required to support qemu guest with large
> memory (>=1TB).
>
> Patch1 implements changes to
Guest triggerable assert() isn't exactly nice indeed.
But it's not a show stopper.
It doesn't allow exploiting the host, the guest can only DoS itself.
And you must be priviledged in the guest to do so.
Most likely this is the driver placing the qxl commands in the wrong pci
bar. See commit 86dbc
On Tue, 7 Nov 2017 06:04:55 +1100
David Gibson wrote:
> On Mon, Nov 06, 2017 at 04:03:07PM +0100, Greg Kurz wrote:
> > On Tue, 17 Oct 2017 17:16:09 +1100
> > David Gibson wrote:
> >
> > > On Mon, Oct 16, 2017 at 10:26:38AM +0200, Igor Mammedov wrote:
> > > > On Sat, 14 Oct 2017 20:33:37 +11
I think we can skip SRUing this, apt now has a new workaround based on
execve()ing with QEMU_VERSION=meow, which calls qemu-user to exit with
0. It executes a program guaranteed to exit with 1, and just disables
seccomp if that exits with 0.
https://anonscm.debian.org/cgit/apt/apt.git/commit/?id=2
Documentation: document pretty parameter for mon option
that turns on JSON pretty printing
Signed-off-by: Vicente Jimenez Aguilar
---
qemu-options.hx | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/qemu-options.hx b/qemu-options.hx
index 3728e9b4dd..a62c260d5f 100644
-
Accidentally sent draft version of patches to the mailing list.
Please consider this one as the correct one.
This set of patches includex fixes from Alex Bennée for fixing
BQL and replay locks after inventing the MTTCG. It also includes some
additional replay patches that makes this set of fixes w
Accidentally sent draft version of patches to the mailing list.
Please consider this one as the correct one.
This set of patches includex fixes from Alex Bennée for fixing
BQL and replay locks after inventing the MTTCG. It also includes some
additional replay patches that makes this set of fixes w
Accidentally sent draft version of patches to the mailing list.
Please consider this one as the correct one.
This set of patches includex fixes from Alex Bennée for fixing
BQL and replay locks after inventing the MTTCG. It also includes some
additional replay patches that makes this set of fixes w
This patch fixes assignment to internal events_enabled variable.
Now it is set only in record/replay mode. This affects the behavior
of the external functions that check this flag.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay-events.c |8 +---
1 file changed, 5 insertions(+), 3 dele
From: Pavel Dovgalyuk
This patch enables making snapshots with blkreplay used in
block devices.
This function is required to make bdrv_snapshot_goto without
calling .bdrv_open which is not implemented.
Signed-off-by: Pavel Dovgalyuk
---
block/blkreplay.c |8
1 file changed, 8 ins
From: Pavel Dovgalyuk
This patch enables making snapshots with blkreplay used in
block devices.
This function is required to make bdrv_snapshot_goto without
calling .bdrv_open which is not implemented.
Signed-off-by: Pavel Dovgalyuk
---
block/blkreplay.c |8
1 file changed, 8 ins
From: Pavel Dovgalyuk
This patch adds description of the replay log file format
into the docs/replay.txt.
Signed-off-by: Pavel Dovgalyuk
---
docs/replay.txt | 69 +++
1 file changed, 69 insertions(+)
diff --git a/docs/replay.txt b/docs/re
From: Pavel Dovgalyuk
This patch allows using '-snapshot' behavior in record/replay mode.
blkreplay layer creates temporary overlays on top of underlaying
disk images. It is needed, because creating an overlay over blkreplay
breaks the determinism.
This patch creates similar temporary overlay (wh
This patch adds saving and restoring of the icount warp
timers in the vmstate.
It is needed because there timers affect the virtual clock value.
Therefore determinism of the execution in icount record/replay mode
depends on determinism of the timers.
Signed-off-by: Pavel Dovgalyuk
---
cpus.c |
From: Pavel Dovgalyuk
This patch disables setting '-snapshot' option on by default
in record/replay mode. This is needed for creating vmstates in record
and replay modes.
Signed-off-by: Pavel Dovgalyuk
---
vl.c |8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/vl.c
From: Alex Bennée
This is modelled after the iothread mutex lock. We keep a TLS flag to
indicate when that thread has acquired the lock and assert we don't
double-lock or release when we shouldn't have.
Signed-off-by: Alex Bennée
Tested-by: Pavel Dovgalyuk
---
replay/replay-internal.c | 11
From: Alex Bennée
The powerctl code is run in the context of the vCPU changing power
state. It does not need the BQL to protect its changes.
Signed-off-by: Alex Bennée
---
target/arm/arm-powerctl.c |8
1 file changed, 8 deletions(-)
diff --git a/target/arm/arm-powerctl.c b/targe
From: Pavel Dovgalyuk
This patch enables making snapshots with blkreplay used in
block devices.
This function is required to make bdrv_snapshot_goto without
calling .bdrv_open which is not implemented.
Signed-off-by: Pavel Dovgalyuk
---
block/blkreplay.c |8
1 file changed, 8 ins
This patch adds saving/restoring of the host clock field 'last'.
It is used in host clock calculation and therefore clock may
become incorrect when using restored vmstate.
Signed-off-by: Pavel Dovgalyuk
---
include/qemu/timer.h | 14 ++
replay/replay-internal.h |2 ++
repl
From: Alex Bennée
We only really need to grab the lock for initial setup (so we don't
race with the thread-spawning thread). After that we can drop the lock
for the whole main loop and only grab it for waiting for IO events.
There is a slight wrinkle for the round-robin TCG thread as we also
exp
From: Alex Bennée
Now instead of using the replay_lock to guard the output of the log we
now use it to protect the whole execution section. This replaces what
the BQL used to do when it was held during TCG execution.
We also introduce some rules for locking order - mainly that you
cannot take th
From: Pavel Dovgalyuk
This patch allows using '-snapshot' behavior in record/replay mode.
blkreplay layer creates temporary overlays on top of underlaying
disk images. It is needed, because creating an overlay over blkreplay
breaks the determinism.
This patch creates similar temporary overlay (wh
From: Alex Bennée
This time commit 802f045a5f61b781df55e4492d896b4d20503ba7 broke the
replay file format. Also add a comment about this to
replay-internal.h.
Signed-off-by: Alex Bennée
Reviewed-off-by: Pavel Dovgalyuk
---
replay/replay-internal.h |2 +-
replay/replay.c |2 +-
From: Alex Bennée
The replay_mutex_lock/unlock/locked functions are now going to be used
for ensuring lock-step behaviour between the two threads. Make them
public API functions and also provide stubs for non-QEMU builds on
common paths.
Signed-off-by: Alex Bennée
Tested-by: Pavel Dovgalyuk
-
This patch adds a condition before overwriting exception_index fiels.
It is needed when exception_index is already set to some meaningful value.
Signed-off-by: Pavel Dovgalyuk
---
accel/tcg/cpu-exec.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/accel/tcg/cpu-exec.c
Asynchronous events saved at checkpoints may invoke
callbacks when processed. These callbacks may also generate/read
new events (e.g. clock reads). Therefore event processing flag must be
reset before callback invocation.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay-events.c |4 ++--
1
This patch resets icount_decr.u32.high before calling cpu_exec_nocache
when exception is pending. Exception is caused by the first instruction
in the block and it cannot be executed without resetting the flag.
This patch also moves this check to the beginning of cpu_handle_exception
function to pr
Replay mutex is held by vCPU thread and destroy function is called
from atexit of the main thread. Therefore we cannot destroy it safely.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay.c |1 -
1 file changed, 1 deletion(-)
diff --git a/replay/replay.c b/replay/replay.c
index 6e34b79..be1
This patch does not allows saving/loading vmstate when
replay events queue is not empty. There is no reliable
way to save events queue, because it describes internal
coroutine state. Therefore saving and loading operations
should be deferred to another record/replay step.
Signed-off-by: Pavel Dovg
This patch adds error reporting when fwrite cannot completely
save the buffer to the file.
Signed-off-by: Pavel Dovgalyuk
---
replay/replay-internal.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/replay/replay-internal.c b/replay/replay-internal.c
index a1a7686..188
101 - 200 of 306 matches
Mail list logo
