This bug was fixed in the package qemu - 1:2.10+dfsg-0ubuntu4
---
qemu (1:2.10+dfsg-0ubuntu4) bionic; urgency=medium
* Apply linux-user-return-EINVAL-from-prctl-PR_-_SECCOMP.patch from
James Cowgill to prevent qemu-user from forwarding prctl seccomp
calls (LP: #1726394)
--
Hi Eric,
On Tue, Nov 14, 2017 at 11:23:03AM +0100, Auger Eric wrote:
> Hi Yi L,
>
> On 03/11/2017 13:01, Liu, Yi L wrote:
> > This patch introduce a notify framework for IOMMUObject.iommu_notifiers.
> > Introduce VFIOGuestIOMMUObject is to link VFIO Container and the new
> > IOMMUObject notififie
On Tue, Nov 14, 2017 at 09:15:51AM +0800, zhuyi...@huawei.com wrote:
> From: Zhu Yijun
>
> Register a ram_memory_region_init notify to allocate memory region
> from system memory and add them as subregions.
>
> Signed-off-by: Zhu Yijun
> ---
> hw/arm/virt.c | 21 -
>
On 2017-11-13 17:35, Max Reitz wrote:
> On 2017-11-13 13:39, Gerd Hoffmann wrote:
>> On Sun, Nov 12, 2017 at 08:30:25PM +0100, Jindrich Makovicka wrote:
>>> With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN
>>> blocks all subsequent display updates.
>>>
>>> Instead of trying to o
On Tue, Nov 14, 2017 at 09:15:52AM +0800, zhuyi...@huawei.com wrote:
> From: Zhu Yijun
>
> Dig out reserved memory holes and collect scattered RAM memory
> regions by adding mem_list member in arm_boot_info struct.
>
> Signed-off-by: Zhu Yijun
> ---
> hw/arm/boot.c| 8
> hw/arm/
See it passed [1] but britney not picking up.
Giving it some time to do so.
[1]:
https://objectstorage.prodstack4-5.canonical.com/v1/AUTH_77e2ada1e7a84929a74ba3b87153c0ac
/autopkgtest-bionic/bionic/amd64/o/open-
iscsi/20171114_135029_17bf1@/log.gz
--
You received this bug notification because yo
LP, this was unfair to reverse-pass me :-)
Anyway - done - thanks Julian and James C. for your work on that.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1726394
Title:
Passes through prctl(PR_SET
On Tue, Nov 14, 2017 at 09:15:54AM +0800, zhuyi...@huawei.com wrote:
> From: Zhu Yijun
>
> In case of accessing memory holes, we build srat table by
> traversing mem_list.
>
> Signed-off-by: Zhu Yijun
> ---
> hw/arm/virt-acpi-build.c | 40 +++-
> 1 file chan
On Tue, Nov 14, 2017 at 09:15:53AM +0800, zhuyi...@huawei.com wrote:
> From: Zhu Yijun
>
> In case of accessing memory holes, we create memory fdt node by
> traversing mem_list and adjust memory address if the addr is not
> belong to RAM memory region.
>
> Signed-off-by: Zhu Yijun
> ---
> hw/a
I know it won't work in KVM. I'm arguing that something not working in
KVM is not grounds for removal from the UEFI image, since qemu != KVM.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1717708
Tit
On Fri 10 Nov 2017 09:31:08 PM CET, Max Reitz wrote:
> We should check whether the cluster offset we are about to use is
> actually valid; that is, whether it is aligned to cluster boundaries.
>
> Reported-by: R. Nageswara Sastry
> Buglink: https://bugs.launchpad.net/qemu/+bug/1728643
> Buglink: h
Max Reitz writes:
> Signed-off-by: Max Reitz
> ---
> include/qapi/qmp/qdict.h | 1 +
> qobject/qdict.c | 10 ++
> 2 files changed, 11 insertions(+)
>
> diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h
> index fc218e7be6..c65ebfc748 100644
> --- a/include/qapi/q
On 2017-10-23 11:29, Vladimir Sementsov-Ogievskiy wrote:
> Snapshot-switch actually changes active state of disk so it should
> reflect on dirty bitmaps. Otherwise next incremental backup using
> these bitmaps will be invalid.
>
> Signed-off-by: Vladimir Sementsov-Ogievskiy
> ---
> block/snapsho
On Thu, 26 Oct 2017 11:54:50 -0400
Tony Krowiak wrote:
> This patch introduces the base object model for an AP matrix device. An AP
> matrix is comprised of the AP adapters, usage domains and control domains
> assigned to a KVM guest. The matrix is represented in three bit masks:
>
> * The AP Ma
On 2017-11-14 15:57, Markus Armbruster wrote:
> Max Reitz writes:
>
>> Signed-off-by: Max Reitz
>> ---
>> include/qapi/qmp/qdict.h | 1 +
>> qobject/qdict.c | 10 ++
>> 2 files changed, 11 insertions(+)
>>
>> diff --git a/include/qapi/qmp/qdict.h b/include/qapi/qmp/qdict.h
>>
On Thu, 26 Oct 2017 11:54:51 -0400
Tony Krowiak wrote:
> Introduces a VFIO based AP matrix device. This device will establish
> a communication pathway to the VFIO AP Matrix kernel device driver
> via a mediated AP matrix device file descriptor. This communication pathway
> will be used to:
>
>
On Fri 10 Nov 2017 09:31:10 PM CET, Max Reitz wrote:
> +static int64_t get_refblock_offset(BlockDriverState *bs, uint64_t offset)
> +{
> +BDRVQcow2State *s = bs->opaque;
> +uint32_t index = offset_to_reftable_index(s, offset);
> +int64_t covering_refblock_offset = 0;
> +
> +if (inde
On Fri 10 Nov 2017 09:31:11 PM CET, Max Reitz wrote:
> +static inline const char *qcow2_cache_get_name(BDRVQcow2State *s, Qcow2Cache
> *c)
> +{
> +if (c == s->refcount_block_cache) {
> +return "refcount block";
> +} else if (c == s->l2_table_cache) {
> +return "L2 table";
>
On 2017-11-13 16:00, Fam Zheng wrote:
> In the "Overlapping multiple requests" cases, the 3rd reqs (the break
> point B) doesn't wait for the 2nd, and once resumed the I/O will just
> continue. This is because the 2nd is already waiting for the 1st, and
> in wait_serialising_requests() there is:
>
On Thu, 26 Oct 2017 11:54:52 -0400
Tony Krowiak wrote:
> The VFIO AP matrix mediated device driver provides an ioctl interface
> to configure the APM, ADM and APM fields contained in the
> CRYCB referenced by the guest's SIE state description. The mask
> values are specified in the mediated AP ma
On 2017-11-14 16:06, Alberto Garcia wrote:
> On Fri 10 Nov 2017 09:31:11 PM CET, Max Reitz wrote:
>> +static inline const char *qcow2_cache_get_name(BDRVQcow2State *s,
>> Qcow2Cache *c)
>> +{
>> +if (c == s->refcount_block_cache) {
>> +return "refcount block";
>> +} else if (c == s
On Thu, 26 Oct 2017 11:54:53 -0400
Tony Krowiak wrote:
> Sets up the following STFLE bits to enable the specified AP
> facilities for the guest VM:
> * STFLE.12: Enables the AP Query Configuration Information
> facility. The AP bus running in the guest uses
>
If you want to argue for things being in UEFI images, you're in the
wrong place, because this is the QEMU bug tracker, not a UEFI one...
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1717708
Title:
> > The only thing I can say is that I submitted
> > https://bugzilla.libsdl.org/show_bug.cgi?id=2818 as a result. Nobody
> > has replied to that in three years, but when testing it on SDL 2.0.7,
> > the issue appears to be fixed.
>
> Having done a bisect, SDL2 revision 11151:7cfe088fafba seems t
On Fri, 10 Nov 2017 15:20:12 +
Cédric Le Goater wrote:
> To save some state when the guest is migrated, we capture the IRQ
> bitmap after all devices have been reseted and store it as a reference
> for the machine.
>
> Signed-off-by: Cédric Le Goater
> ---
>
> We should probably merge thi
Max Reitz writes:
> Instead of converting all "backing": null instances into "backing": "",
> handle a null value directly in bdrv_open_inherit().
>
> This enables explicitly null backing links for json:{} filenames.
>
> Signed-off-by: Max Reitz
> ---
> block.c| 2 +-
> blo
On 2017-11-07 14:10, Jeff Cody wrote:
> The VHDX specification requires that before user data modification of
> the vhdx image, the VHDX header file and data GUIDs need to be updated.
> In vhdx_open(), if the image is set to RDWR, we go ahead and update the
> header.
>
> However, just because the
On Fri 10 Nov 2017 11:42:58 PM CET, Max Reitz wrote:
> Berto's "Test I/O limits with removable media" patch proves that
> throttling survives a blockdev-remove-medium/blockdev-insert-medium pair
> now, so let's mark them stable (because that was the reason they were
> considered experimental, see c
On 2017-11-14 16:17, Markus Armbruster wrote:
> Max Reitz writes:
>
>> Instead of converting all "backing": null instances into "backing": "",
>> handle a null value directly in bdrv_open_inherit().
>>
>> This enables explicitly null backing links for json:{} filenames.
>>
>> Signed-off-by: Max R
Max Reitz writes:
> We have a clear replacement, so let's deprecate it.
>
> Signed-off-by: Max Reitz
> ---
> qapi/block-core.json | 4 ++--
> block.c | 4
> qemu-doc.texi| 7 +++
> qemu-options.hx | 4 ++--
> 4 files changed, 15 insertions(+), 4 deletions(-)
>
On Thu, 26 Oct 2017 11:54:54 -0400
Tony Krowiak wrote:
Cool, documentation!
> Signed-off-by: Tony Krowiak
> ---
> docs/ap_matrix.txt | 529
>
> 1 files changed, 529 insertions(+), 0 deletions(-)
> create mode 100644 docs/ap_matrix.txt
>
On 14 November 2017 at 02:11, Jason Wang wrote:
> The following changes since commit 4ffa88c99c54d2a30f79e3dbecec50b023eff1c8:
>
> Merge remote-tracking branch
> 'remotes/berrange/tags/pull-qcrypto-2017-11-08-1' into staging (2017-11-10
> 16:01:35 +)
>
> are available in the git repository
On Thu, 26 Oct 2017 11:54:49 -0400
Tony Krowiak wrote:
> I was asked to post this QEMU patch set to the mailing list to illustrate
> how the KVM/kernel counterpart will be used. The KVM/kernel patches can be
> viewed at:
>
> https://lkml.org/lkml/2017/10/13/706
>
> The IBM Adjunct Processor (AP
On 2017-11-14 16:02, Alberto Garcia wrote:
> On Fri 10 Nov 2017 09:31:10 PM CET, Max Reitz wrote:
>> +static int64_t get_refblock_offset(BlockDriverState *bs, uint64_t offset)
>> +{
>> +BDRVQcow2State *s = bs->opaque;
>> +uint32_t index = offset_to_reftable_index(s, offset);
>> +int64_t
On Tue, 14 Nov 2017 11:54:53 +
Cédric Le Goater wrote:
> On 11/14/2017 09:42 AM, Greg Kurz wrote:
> > On Fri, 10 Nov 2017 15:20:11 +
> > Cédric Le Goater wrote:
> >
> >> Let's define a new set of XICSFabric IRQ operations for the latest
> >> pseries machine. These simply use a a bitma
On 2017-11-07 14:10, Jeff Cody wrote:
> Changes from v3->v4:
>
> Patch 3: Add migrate_del_blocker and error_free (Thanks Stefan)
Thanks, applied to my block branch:
https://github.com/XanClic/qemu/commits/block
Max
signature.asc
Description: OpenPGP digital signature
On Tue 14 Nov 2017 04:09:16 PM CET, Max Reitz wrote:
>>> +static inline const char *qcow2_cache_get_name(BDRVQcow2State *s,
>>> Qcow2Cache *c)
>>> +{
>>> +if (c == s->refcount_block_cache) {
>>> +return "refcount block";
>>> +} else if (c == s->l2_table_cache) {
>>> +return
On Tue, 14 Nov 2017 10:34:01 +0800
Dou Liyang wrote:
> Linux and Windows need ACPI SRAT table to make memory hotplug work properly,
> however currently QEMU doesn't create SRAT table if numa options aren't
> present
> on CLI.
>
> Which breaks both linux and windows guests in certain conditions:
On 2017-11-10 22:46, Eric Blake wrote:
> On 11/10/2017 02:31 PM, Max Reitz wrote:
>> We currently do not guard everywhere against a NULL bs->drv where we
>> should be doing so. Most of the places fixed here just do not care
>> about that case at all.
>>
>> Some care implicitly, e.g. through a prio
On Tue 14 Nov 2017 04:27:56 PM CET, Max Reitz wrote:
>>> +static int64_t get_refblock_offset(BlockDriverState *bs, uint64_t offset)
>>> +{
>>> +BDRVQcow2State *s = bs->opaque;
>>> +uint32_t index = offset_to_reftable_index(s, offset);
>>> +int64_t covering_refblock_offset = 0;
>>> +
>>>
On 2017-11-14 16:38, Alberto Garcia wrote:
> On Tue 14 Nov 2017 04:27:56 PM CET, Max Reitz wrote:
+static int64_t get_refblock_offset(BlockDriverState *bs, uint64_t offset)
+{
+BDRVQcow2State *s = bs->opaque;
+uint32_t index = offset_to_reftable_index(s, offset);
+
On Fri, 10 Nov 2017 15:20:13 +
Cédric Le Goater wrote:
> 'irq_base' is a base IRQ number which lets us allocate only the subset
> of the IRQ numbers used on the sPAPR platform. It is sync with the
> ICSState 'offset' attribute and this is slightly redundant. We could
> also choose to waste so
On Tue, 14 Nov 2017 09:15:50 +0800
wrote:
> From: Zhu Yijun
>
> With kernel 4.11, iommu/smmu will populate the MSI IOVA reserved window and
> PCI reserved window which has to be excluded from Guest iova allocations.
>
> However, If it falls within the Qemu default virtual memory address space,
On 2017-10-04 17:25, Max Reitz wrote:
> bdrv_reopen_prepare() assumes that all BDS options are strings, which is
> not necessarily correct. This series introduces a new qobject_is_equal()
> function which can be used to test whether any options have changed,
> independently of their type.
>
>
> v
On 2017-11-10 22:21, Max Reitz wrote:
> On 2017-06-16 15:58, Max Reitz wrote:
>> Signed-off-by: Max Reitz
>> ---
>> In order to pass, this depends on "fix: avoid an infinite loop or a
>> dangling pointer problem in img_commit"
>> (http://lists.nongnu.org/archive/html/qemu-block/2017-06/msg00443.ht
On 10/27/2017 02:58 PM, Richard Henderson wrote:
From: Richard Henderson
Signed-off-by: Richard Henderson
---
Rebased and updated for changes to tcg_gen_lookup_and_goto_ptr.
---
I am experiencing a remarkable performance boost running a simple scenario
up to SLOF prompt with this patch. I
Richard Henderson writes:
> When we handle a signal from a fault within a user-only memory helper,
> we cannot cpu_restore_state with the PC found within the signal frame.
> Use a TLS variable, helper_retaddr, to record the unwind start point
> to find the faulting guest insn.
>
> Reported-by: P
Richard Henderson writes:
> We use raw memory primitives along the !parallel_cpus paths in order to
> simplify the endianness handling. Because of that, we did not benefit
> from the generic changes to cpu_ldst_user_only_template.h.
>
> The simplest fix is to manipulate helper_retaddr here.
>
>
Richard Henderson writes:
> Use of GETPC must be restricted to those functions that are
> directly called from TCG generated code.
>
> Fixes: 2399d4e7cec22ecf1c51062d2ebfd45220dbaace
> Signed-off-by: Richard Henderson
Reviewed-by: Alex Bennée
> ---
> target/arm/helper-a64.c | 14 ++-
;
> are available in the git repository at:
>
> git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20171114
>
> for you to fetch changes up to dcb556fc6ad879f7d29fb233a273a1ea3aa0549c:
>
> xics/kvm: synchonize s
On Fri, 10 Nov 2017 15:20:14 +
Cédric Le Goater wrote:
> It will be used later on to distinguish the allocation of an LSI
> interrupt from an MSI and also to reduce the use of the ICSIRQState
> array of the ICSState object, which is on our way to introduce XIVE.
>
> The 'irq' parameter conti
On 14.11.2017 16:11, Cornelia Huck wrote:
> On Thu, 26 Oct 2017 11:54:53 -0400
> Tony Krowiak wrote:
>
>> Sets up the following STFLE bits to enable the specified AP
>> facilities for the guest VM:
>> * STFLE.12: Enables the AP Query Configuration Information
>> facility.
[reviving an old thread]
On 01/23/2017 08:54 AM, Eric Blake wrote:
> I'm still thinking that allowing the client to query the current size is
> useful. Over the weekend, I was thinking of SEEK_SET/SEEK_END semantics
> (SEEK_CUR doesn't really make sense, since we don't maintain a current
> offse
On 11/06/2017 07:16 AM, David Gibson wrote:
> On Thu, Nov 02, 2017 at 11:35:59AM +0100, Luc MICHEL wrote:
>> When overwritting a valid TLB entry with a new one, the previous page
>> were not flushed in QEMU TLB, leading to incoherent mapping. This commit
>> fixes this.
>
> I don't think this is ri
On 11/14/2017 04:16 AM, Anton Nefedov wrote:
> Misaligned compressed write is not supported.
>
> Signed-off-by: Anton Nefedov
> ---
> block/qcow2.c | 4
> 1 file changed, 4 insertions(+)
Should this one be applied in 2.11?
Reviewed-by: Eric Blake
>
> diff --git a/block/qcow2.c b/block/
On 14 November 2017 at 10:37, Stefan Hajnoczi wrote:
> The following changes since commit 508ba0f7e2092d3ca56e3f75e894d52d8b94818e:
>
> Merge remote-tracking branch 'remotes/cohuck/tags/s390x-20171109' into
> staging (2017-11-13 11:41:47 +)
>
> are available in the git repository at:
>
>
From: Alberto Garcia
Each entry in the qcow2 cache contains an offset field indicating the
location of the data in the qcow2 image. If the offset is 0 then it
means that the entry contains no data and is available to be used when
needed.
Because of that it is not possible to store in the cache t
The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9:
Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into
staging (2017-11-14 16:11:19 +)
are available in the git repository at:
git://github.com/XanClic/qemu.git tags/pull-block-2017-11-14
First of all, test 055 does a valiant job of invoking pause_drive()
sometimes, but that is worth nothing without blkdebug. So the first
thing to do is to sprinkle a couple of "blkdebug::" in there -- with the
exception of the transaction tests, because the blkdebug break points
make the transactio
From: Alberto Garcia
qcow2_do_open() is checking that header.refcount_table_clusters is not
too large, but it doesn't check that it's greater than zero. Apart
from the fact that an image like that is obviously corrupted, trying
to use it crashes QEMU since we end up with a null s->refcount_table
From: Alberto Garcia
If the refcount data is corrupted then we can end up trying to
allocate a new L2 table at offset 0 in the image, triggering an
assertion in the qcow2 cache that would crash QEMU:
qcow2_cache_entry_mark_dirty: Assertion `c->entries[i].offset != 0' failed
This patch adds an
From: Alberto Garcia
This patch adds a simple iotest in which we try to write to an image
with the refcount table offset set to 0.
This scenario was already handled by the existing consistency checks,
but we add an explicit test case for completeness.
Signed-off-by: Alberto Garcia
Message-id:
From: Alberto Garcia
The crypto header is initialized only when QEMU is creating a new
image, so there's no chance of this happening on a corrupted image.
If QEMU is really trying to allocate the header overlapping other
existing metadata sections then this is a serious bug in QEMU itself
so let
083 has (at least) two issues:
1. By launching the nbd-fault-injector in background, it may not be
scheduled until the first grep on its output file is executed.
However, until then, that file may not have been created yet -- so it
either does not exist yet (thus making the grep emit an e
From: Alberto Garcia
If the refcount data is corrupted then we can end up trying to
allocate a new compressed cluster at offset 0 in the image, triggering
an assertion in qcow2_alloc_bytes() that would crash QEMU:
qcow2_alloc_bytes: Assertion `offset' failed.
This patch adds an explicit check
This patch fixes two race conditions in 030:
1. The first is in TestENOSPC.test_enospc(). After resuming the job,
querying it to confirm it is no longer paused may fail because in the
meantime it might have completed already. The same was fixed in
TestEIO.test_ignore() already (in commi
From: Alberto Garcia
We just fixed a few bugs that caused QEMU to crash when trying to
write to corrupted qcow2 images, and iotest 060 was expanded to test
all those scenarios.
In almost all cases the corrupted images can be repaired using
qemu-img, so this patch verifies that.
Signed-off-by: A
136 executes some AIO requests without a final aio_flush; then it
advances the virtual clock and thus expects the last access time of the
device to be less than the current time when queried (i.e. idle_time_ns
to be greater than 0). However, without the aio_flush, some requests
may be settled afte
From: Alberto Garcia
This patch adds a simple iotest in which we try to write to an image
with an empty refcount table (i.e. with all entries set to 0).
This scenario was already handled by the existing consistency checks,
but we add an explicit test case for completeness.
Signed-off-by: Albert
From: Eric Blake
Old-style NBD is deprecated upstream (it is documented, but no
longer implemented in the reference implementation), and it is
severely limited (it cannot support structured replies, which
means it cannot support efficient handling of zeroes), when
compared to new-style NBD. We a
From: Fam Zheng
In the "Overlapping multiple requests" cases, the 3rd reqs (the break
point B) doesn't wait for the 2nd, and once resumed the I/O will just
continue. This is because the 2nd is already waiting for the 1st, and
in wait_serialising_requests() there is:
/* If the request is alr
040 tries to invoke pause_drive() on a drive that does not use blkdebug.
Good idea, but let's use blkdebug to make it actually work.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Message-id: 20171109203025.27493-3-mre...@redhat.com
Signed-off-by: Max Reitz
---
From: Jeff Cody
If we write or modify the image file while the QEMU run state is
INMIGRATE, then the BDRV_O_INACTIVE BDS flag is set. This will cause
an assert, since the image is marked inactive. Make sure we obey this
flag.
Tested-by: Alexey Kardashevskiy
Signed-off-by: Jeff Cody
Message-i
From: Jeff Cody
The VHDX specification requires that before user data modification of
the vhdx image, the VHDX header file and data GUIDs need to be updated.
In vhdx_open(), if the image is set to RDWR, we go ahead and update the
header.
However, just because the image is set to RDWR does not me
From: Vladimir Sementsov-Ogievskiy
Snapshot-switch actually changes active state of disk so it should
reflect on dirty bitmaps. Otherwise next incremental backup using
these bitmaps will be invalid.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Message-id: 20171023092945.54532-1-vsement...@virtuo
ilable in the git repository at:
>
> git://git.kraxel.org/qemu tags/seabios-1.11-final-20171114-pull-request
>
> for you to fetch changes up to 6350b2a09b8a330cbfaea462a34bbb1b8c63d7b1:
>
> seabios: update to 1.11 final (2017-11-14 15:36:08 +0100)
>
> --
From: Jeff Cody
Migration does not work for parallels, and has been broken for a while
(see patch 'block/parallels: Do not update header or truncate image when
INMIGRATE'). The bdrv_invalidate_cache() method needs to be added for
migration to be supported. Until this is done, prohibit migratio
From: Jeff Cody
Test 194 checks for 'luks' to exclude as an unsupported format,
However, most formats are unsupported, due to migration blockers.
Rather than specifying a blacklist of unsupported formats, whitelist
supported formats (specifically, qcow2, qed, raw, dmg).
Tested-by: Alexey Kardas
On 14 November 2017 at 17:23, Max Reitz wrote:
> The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2017-11-14 16:11:19 +)
>
> are available in the git repository at:
>
>
On Fri, 27 Oct 2017, BALATON Zoltan wrote:
On Sat, 21 Oct 2017, BALATON Zoltan wrote:
When a section with non-0 offset_within_region field is tested to
cover an address the offset should be taken into account as well.
This fixes a crash caused by picking the wrong memory region in
address_space
On 2017-11-14 18:28, Peter Maydell wrote:
> On 14 November 2017 at 17:23, Max Reitz wrote:
>> The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9:
>>
>> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
>> into staging (2017-11-14 16:11:19 +)
>>
On Tue, Nov 14, 2017 at 10:41:39AM -0600, Eric Blake wrote:
> Another thought - with structured replies, we finally have a way to let
> the client ask for the server to send resize information whenever the
> server wants, rather than having to be polled by a new client request
> all the time. This
Besides the macro itself, this patch also adds a corresponding
Coccinelle rule.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
---
include/qapi/qmp/qlist.h | 3 +++
scripts/coccinelle/qobject.cocci | 3 +++
2 files changed, 6 insertions(+)
diff --git a/in
bdrv_reopen_prepare() assumes that all BDS options are strings, which is
not necessarily correct. This series introduces a new qobject_is_equal()
function which can be used to test whether any options have changed,
independently of their type.
v7:
- Patch 6: Fix a clang warning:
tests/check-q
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
Reviewed-by: Markus Armbruster
---
include/qapi/qmp/qdict.h| 1 +
include/qapi/qmp/qnull.h| 30 ++
include/qapi/qmp/qobject.h | 12
include/qapi/qmp/types.h| 1 +
This generic function (along with its implementations for different
types) determines whether two QObjects are equal.
Signed-off-by: Max Reitz
Reviewed-by: Eric Blake
Reviewed-by: Alberto Garcia
Reviewed-by: Markus Armbruster
---
include/qapi/qmp/qbool.h | 1 +
include/qapi/qmp/qdict.h |
Currently, bdrv_reopen_prepare() assumes that all BDS options are
strings. However, this is not the case if the BDS has been created
through the json: pseudo-protocol or blockdev-add.
Note that the user-invokable reopen command is an HMP command, so you
can only specify strings there. Therefore, s
Signed-off-by: Max Reitz
Reviewed-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/133 | 9 +
tests/qemu-iotests/133.out | 5 +
2 files changed, 14 insertions(+)
diff --git a/tests/qemu-iotests/133 b/tests/qemu-iotests/133
index 9d35a6a1ca..af6b3e1dd4 100755
--- a/
On 21/10/2017 13:24, BALATON Zoltan wrote:
> When a section with non-0 offset_within_region field is tested to
> cover an address the offset should be taken into account as well.
>
> This fixes a crash caused by picking the wrong memory region in
> address_space_lookup_region seen with client code
Add a new test file (check-qobject.c) for unit tests that concern
QObjects as a whole.
Its only purpose for now is to test the qobject_is_equal() function.
Signed-off-by: Max Reitz
---
tests/Makefile.include | 4 +-
tests/check-qobject.c | 328
On 15/10/2017 13:30, BALATON Zoltan wrote:
> I've got a bit further with this but still could use some hints to find
> what is happening. Here are some more details I've found so far.
>
> The memory map I have (see below) is a bit complex but the interesting
> part is that I have sii3112.bar5 as a
On 14 November 2017 at 17:23, Max Reitz wrote:
> The following changes since commit 191b5fbfa66e5b23e2150f3c6981d30eb84418a9:
>
> Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request'
> into staging (2017-11-14 16:11:19 +)
>
> are available in the git repository at:
>
>
On 14/11/2017 7:50 PM, Eric Blake wrote:
On 11/14/2017 04:16 AM, Anton Nefedov wrote:
Misaligned compressed write is not supported.
Signed-off-by: Anton Nefedov
---
block/qcow2.c | 4
1 file changed, 4 insertions(+)
Should this one be applied in 2.11?
For the record, this one is p
@mem_size and @offset are both size_t, thus subtracting them from one
another will just return a big size_t if mem_size < offset -- even more
obvious here because the result is stored in another size_t.
Checking that result to be positive is therefore not sufficient to
excluse the case that offset
On 14.11.2017 14:32, Max Reitz wrote:
[...]
> Well, do you want to document it? I'd rather deprecate it altogether.
Maybe a first step could be to change qemu-img so that it refuses to
create new qcow1 images (but still can convert them into other formats).
So basically make qcow1 read-only?
Th
On 2017-11-14 19:45, Thomas Huth wrote:
> On 14.11.2017 14:32, Max Reitz wrote:
> [...]
>> Well, do you want to document it? I'd rather deprecate it altogether.
>
> Maybe a first step could be to change qemu-img so that it refuses to
> create new qcow1 images (but still can convert them into othe
On 11/14/2017 11:37 AM, Wouter Verhelst wrote:
> On Tue, Nov 14, 2017 at 10:41:39AM -0600, Eric Blake wrote:
>> Another thought - with structured replies, we finally have a way to let
>> the client ask for the server to send resize information whenever the
>> server wants, rather than having to be
On 11/14/2017 06:09 AM, Thomas Huth wrote:
> On 14.11.2017 09:54, Yu Ning wrote:
>> Hello,
>>
>> As some of you may have noticed, since QEMU 2.9.0, an accelerator known
>> as “hax” has been available for Windows and macOS builds of QEMU, thanks
>> to the hard work of Vincent Palatin and help from
When you cancel an in-progress live block operation with QMP
`block-job-cancel`, it emits the event: BLOCK_JOB_CANCELLED. However,
when `block-job-cancel` is issued after `drive-mirror` has indicated (by
emitting the event BLOCK_JOB_READY) that the source and destination
remain synchronized:
On 11/14/2017 12:01 PM, Max Reitz wrote:
> bdrv_reopen_prepare() assumes that all BDS options are strings, which is
> not necessarily correct. This series introduces a new qobject_is_equal()
> function which can be used to test whether any options have changed,
> independently of their type.
>
>
1 - 100 of 306 matches
Mail list logo
