Re: [Qemu-devel] [PATCH v1] highbank: validate register offset before access

2017-11-13 Thread P J P
Hello Philippe, +-- On Sun, 12 Nov 2017, Philippe Mathieu-Daudé wrote --+ | I'd rather use: | |"highbank: bad write offset 0x%" HWADDR_PRIx "\n", offset); Sent revised patch v2. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE

Re: [Qemu-devel] [PATCH for 2.11 1/5] qom: move CPUClass.tcg_initialize to a global

2017-11-13 Thread Richard Henderson
On 11/10/2017 08:53 PM, Emilio G. Cota wrote: > 55c3cee ("qom: Introduce CPUClass.tcg_initialize", 2017-10-24) > introduces a per-CPUClass bool that we check so that the target CPU > is initialized for TCG only once. This works well except when > we end up creating more than one CPUClass, in which

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-13 Thread Paolo Bonzini
On 11/11/2017 19:59, Stefan Priebe - Profihost AG wrote: > Hello, > > Am 10.11.2017 um 05:18 schrieb Jason Wang: >> >> >> On 2017年11月08日 19:22, Jason Wang wrote: >>> >>> >>> On 2017年11月08日 18:46, Paolo Bonzini wrote: On 08/11/2017 09:21, Jason Wang wrote: > > On 2017年11月08日 17:05, Ste

Re: [Qemu-devel] [PATCH v12 09/12] Move related hwpoison page function to accel/kvm/ folder

2017-11-13 Thread Paolo Bonzini
On 13/11/2017 02:45, gengdongjiu wrote: > On 2017/11/10 19:32, Paolo Bonzini wrote: >> On 10/11/2017 20:19, Dongjiu Geng wrote: >>> +typedef struct HWPoisonPage { >>> +ram_addr_t ram_addr; >>> +QLIST_ENTRY(HWPoisonPage) list; >>> +} HWPoisonPage; >>> + >> >> Is this actually needed outside

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-13 Thread Peter Xu
On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > From: Peter Xu > > > > AddressSpaceOps is similar to MemoryRegionOps, it's just for address > > spaces to store arch-specific hooks. > > > > The first hook I would like

Re: [Qemu-devel] [PATCH v12 09/12] Move related hwpoison page function to accel/kvm/ folder

2017-11-13 Thread gengdongjiu
On 2017/11/13 16:27, Paolo Bonzini wrote: >> If you think this structure should be added in accel/kvm/kvm-all.c, I will >> move it. > It can be done later; but if you have to send a v13 series, I would be > grateful if you included this change as well. Ok, got it, thanks Paolo. > > Paolo >

[Qemu-devel] [PATCH v2] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-13 Thread Ladi Prosek
The statement being removed doesn't change anything as virtio PCI devices already have Subsystem Vendor ID set to pci_default_sub_vendor_id (0x1af4), same as Vendor ID. And the Virtio spec does not require the two to be equal, either: "The PCI Subsystem Vendor ID and the PCI Subsystem Device I

Re: [Qemu-devel] [RFC PATCH 13/26] cpus: only take BQL for sleeping threads

2017-11-13 Thread Pavel Dovgalyuk
> From: Paolo Bonzini [mailto:pbonz...@redhat.com] > > From: "David Hildenbrand" > > On 02.11.2017 12:08, Paolo Bonzini wrote: > > > On 31/10/2017 12:26, Pavel Dovgalyuk wrote: > > >> From: Alex Bennée > > >> > > >> Now the only real need to hold the BQL is for when we sleep on the > > >> cpu->ha

Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE

2017-11-13 Thread Pierre Morel
On 09/11/2017 17:50, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:34 +0100 Pierre Morel wrote: Enhance the fault detection, correction of the fault reporting. Signed-off-by: Pierre Morel Reviewed-by: Yi Min Zhao --- hw/s390x/s390-pci-inst.c | 41 -

Re: [Qemu-devel] [PATCH 3/7] s390x/pci: rework PCI LOAD

2017-11-13 Thread Pierre Morel
On 09/11/2017 17:51, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:35 +0100 Pierre Morel wrote: Enhance the fault detection, correction of the fault reporting. Basically the same comments as for the previous patch (but looks good in general). thanks I will process it the same way as patch

Re: [Qemu-devel] [PATCH 6/7] s390x/pci: move the memory region write from pcistg

2017-11-13 Thread Pierre Morel
On 10/11/2017 10:51, Cornelia Huck wrote: On Fri, 10 Nov 2017 17:40:12 +0800 Yi Min Zhao wrote: 在 2017/11/10 上午3:23, Cornelia Huck 写道: On Tue, 7 Nov 2017 18:24:38 +0100 Pierre Morel wrote: Let's move the memory region write from pcistg into a dedicated function. This allows us to prepar

[Qemu-devel] [PATCH] scripts/make-release: No need to delete pixman/.git anymore

2017-11-13 Thread Thomas Huth
The pixman submodule has been removed in commit c12b6d70e384c769ca372e1, so there is no need anymore to delete pixman/.git while building a release tarball. Signed-off-by: Thomas Huth --- scripts/make-release | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/make-releas

Re: [Qemu-devel] [PATCH v2] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-13 Thread Gerd Hoffmann
On Mon, Nov 13, 2017 at 09:45:58AM +0100, Ladi Prosek wrote: > The statement being removed doesn't change anything as virtio PCI devices > already > have Subsystem Vendor ID set to pci_default_sub_vendor_id (0x1af4), same as > Vendor > ID. And the Virtio spec does not require the two to be equal,

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Pierre Morel
On 09/11/2017 19:55, Philippe Mathieu-Daudé wrote: On 11/09/2017 01:38 PM, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel

Re: [Qemu-devel] [PATCH 1/7] s390x/pci: factor out endianess conversion

2017-11-13 Thread Pierre Morel
On 09/11/2017 19:55, Philippe Mathieu-Daudé wrote: On 11/09/2017 01:38 PM, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:33 +0100 Pierre Morel wrote: There are two places where the same endianness conversion is done. Let's factor this out into a static function. Signed-off-by: Pierre Morel

Re: [Qemu-devel] [PATCH 6/7] s390x/pci: move the memory region write from pcistg

2017-11-13 Thread Pierre Morel
On 10/11/2017 10:51, Cornelia Huck wrote: On Fri, 10 Nov 2017 17:40:12 +0800 Yi Min Zhao wrote: 在 2017/11/10 上午3:23, Cornelia Huck 写道: On Tue, 7 Nov 2017 18:24:38 +0100 Pierre Morel wrote: Let's move the memory region write from pcistg into a dedicated function. This allows us to prepar

Re: [Qemu-devel] [PATCH 3/7] s390x/pci: rework PCI LOAD

2017-11-13 Thread Pierre Morel
On 09/11/2017 17:51, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:24:35 +0100 Pierre Morel wrote: Enhance the fault detection, correction of the fault reporting. Basically the same comments as for the previous patch (but looks good in general). thanks I will process it the same way as patch

[Qemu-devel] [Bug 530077] Re: kvm: 16-bit code execution failure should be more friendly

2017-11-13 Thread Thomas Huth
Triaging old bug tickets... has this ever been fixed, thus could we close this ticket nowadays? Or is there something left to do here? ** Changed in: qemu Status: Confirmed => Incomplete ** Changed in: qemu Assignee: Anthony Liguori (anthony-codemonkey) => (unassigned) -- You receiv

Re: [Qemu-devel] [PATCH] scripts/make-release: No need to delete pixman/.git anymore

2017-11-13 Thread Thomas Huth
On 13.11.2017 10:43, no-re...@patchew.org wrote: > Hi, > > This series failed automatic build test. Please find the testing commands and > their output below. If you have docker installed, you can probably reproduce > it > locally. > > Subject: [Qemu-devel] [PATCH] scripts/make-release: No need

Re: [Qemu-devel] [PATCH for-2.12 v3 01/11] spapr: add pseries 2.12 machine type

2017-11-13 Thread Greg Kurz
On Mon, 13 Nov 2017 16:51:03 +1100 David Gibson wrote: > On Fri, Nov 10, 2017 at 03:20:07PM +, Cédric Le Goater wrote: > > Signed-off-by: Cédric Le Goater > > --- > > hw/ppc/spapr.c | 16 +++- > > 1 file changed, 15 insertions(+), 1 deletion(-) > > > > diff --git a/hw/ppc/spapr

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 07:13, Jason Wang wrote: > > > On 2017年11月06日 21:28, Jens Freimann wrote: >> >> This fixes coverity issue CID1005339. >> >> Make sure that saddr is not used uninitialized if the >> mcast parameter is NULL. >> >> Cc: qemu-sta...@nongnu.org >> Reported-by: Peter Maydell >> Si

Re: [Qemu-devel] QEMU 3.0 ? (was: [PATCH for-2.12 v3 01/11] spapr: add pseries 2.12 machine type)

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 07:14, Thomas Huth wrote: > By the way, before everybody now introduces "2.12" machine types ... is > there already a consensus that the next version will be "2.12" ? > > A couple of months ago, we discussed that we could maybe do a 3.0 after > 2.11, e.g. here: > > https://

Re: [Qemu-devel] [PATCH v4] throttle-groups: drain before detaching ThrottleState

2017-11-13 Thread Alberto Garcia
On Fri 10 Nov 2017 04:19:34 PM CET, Stefan Hajnoczi wrote: > I/O requests hang after stop/cont commands at least since QEMU 2.10.0 > with -drive iops=100: > > (guest)$ dd if=/dev/zero of=/dev/vdb oflag=direct count=1000 > (qemu) stop > (qemu) cont > ...I/O is stuck... > > This happens becau

Re: [Qemu-devel] [PATCH] net/socket: fix coverity issue

2017-11-13 Thread Jason Wang
On 2017年11月13日 17:51, Peter Maydell wrote: On 13 November 2017 at 07:13, Jason Wang wrote: On 2017年11月06日 21:28, Jens Freimann wrote: This fixes coverity issue CID1005339. Make sure that saddr is not used uninitialized if the mcast parameter is NULL. Cc: qemu-sta...@nongnu.org Reported-by

[Qemu-devel] [Bug 1731588] Re: qemu-system-arm black screen and keyboard not detected

2017-11-13 Thread Peter Maydell
"stm32-p103" is not a board model supported by upstream QEMU. Presumably you're using a fork of QEMU -- you should ask whoever is responsible for that fork about it. For the second command line -- is the binary you're trying to run built for the stellaris board model you're trying to run it on?

Re: [Qemu-devel] QEMU 3.0 ?

2017-11-13 Thread Cédric Le Goater
On 11/13/2017 10:53 AM, Peter Maydell wrote: > On 13 November 2017 at 07:14, Thomas Huth wrote: >> By the way, before everybody now introduces "2.12" machine types ... is >> there already a consensus that the next version will be "2.12" ? >> >> A couple of months ago, we discussed that we could ma

Re: [Qemu-devel] [PULL for-2.11-rc1 v2 0/2] Block patches

2017-11-13 Thread Peter Maydell
On 8 November 2017 at 19:20, Stefan Hajnoczi wrote: > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) > > are available in the git repository at: > > git://github.com/stefanha/qemu.git tags/bloc

Re: [Qemu-devel] [RFC PATCH 13/26] cpus: only take BQL for sleeping threads

2017-11-13 Thread Alex Bennée
Pavel Dovgalyuk writes: >> From: Paolo Bonzini [mailto:pbonz...@redhat.com] >> > From: "David Hildenbrand" >> > On 02.11.2017 12:08, Paolo Bonzini wrote: >> > > On 31/10/2017 12:26, Pavel Dovgalyuk wrote: >> > >> From: Alex Bennée >> > >> >> > >> Now the only real need to hold the BQL is for w

Re: [Qemu-devel] [RESEND PATCH 2/6] memory: introduce AddressSpaceOps and IOMMUObject

2017-11-13 Thread Liu, Yi L
On Mon, Nov 13, 2017 at 04:56:01PM +1100, David Gibson wrote: > On Fri, Nov 03, 2017 at 08:01:52PM +0800, Liu, Yi L wrote: > > From: Peter Xu > > > > AddressSpaceOps is similar to MemoryRegionOps, it's just for address > > spaces to store arch-specific hooks. > > > > The first hook I would like

Re: [Qemu-devel] QEMU 3.0 ?

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 10:03, Cédric Le Goater wrote: > One of the sweeping change for 3.0 could be to stop to maintaining > migration compatibility with older versions (2.x). Even if the > feature is really a must have in some cluster environment, the > code (and the developer) is starting to suf

Re: [Qemu-devel] [PATCH for-2.12 3/3] block: Deprecate "backing": ""

2017-11-13 Thread Daniel P. Berrange
On Fri, Nov 10, 2017 at 04:21:05PM -0600, Eric Blake wrote: > On 11/10/2017 04:13 PM, Max Reitz wrote: > > We have a clear replacement, so let's deprecate it. > > > > Signed-off-by: Max Reitz > > --- > > qapi/block-core.json | 4 ++-- > > block.c | 4 > > qemu-doc.texi|

Re: [Qemu-devel] QEMU 3.0 ?

2017-11-13 Thread Thomas Huth
On 13.11.2017 10:53, Peter Maydell wrote: > On 13 November 2017 at 07:14, Thomas Huth wrote: >> By the way, before everybody now introduces "2.12" machine types ... is >> there already a consensus that the next version will be "2.12" ? >> >> A couple of months ago, we discussed that we could maybe

Re: [Qemu-devel] [PATCH v17 6/6] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-11-13 Thread Wei Wang
Ping for comments, thanks. On 11/03/2017 04:13 PM, Wei Wang wrote: Negotiation of the VIRTIO_BALLOON_F_FREE_PAGE_VQ feature indicates the support of reporting hints of guest free pages to the host via virtio-balloon. The host requests the guest to report the free pages by sending commands via th

Re: [Qemu-devel] [PATCH] scripts/make-release: No need to delete pixman/.git anymore

2017-11-13 Thread Gerd Hoffmann
On Mon, Nov 13, 2017 at 10:21:45AM +0100, Thomas Huth wrote: > The pixman submodule has been removed in commit c12b6d70e384c769ca372e1, > so there is no need anymore to delete pixman/.git while building a > release tarball. > > Signed-off-by: Thomas Huth Reviewed-by: Gerd Hoffmann

Re: [Qemu-devel] [PATCH V5] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-11-13 Thread Laszlo Ersek
On 11/11/17 16:25, Marcel Apfelbaum wrote: > Currently there is no MMIO range over 4G > reserved for PCI hotplug. Since the 32bit PCI hole > depends on the number of cold-plugged PCI devices > and other factors, it is very possible is too small > to hotplug PCI devices with large BARs. > > Fix it

Re: [Qemu-devel] [RFC PATCH 13/26] cpus: only take BQL for sleeping threads

2017-11-13 Thread Paolo Bonzini
On 13/11/2017 11:14, Alex Bennée wrote: > > Pavel Dovgalyuk writes: > >>> From: Paolo Bonzini [mailto:pbonz...@redhat.com] From: "David Hildenbrand" On 02.11.2017 12:08, Paolo Bonzini wrote: > On 31/10/2017 12:26, Pavel Dovgalyuk wrote: >> From: Alex Bennée >> >> Now

Re: [Qemu-devel] [Qemu-arm] [PATCH] arm/translate-a64: mark path as unreachable to eliminate warning

2017-11-13 Thread Peter Maydell
On 8 November 2017 at 12:37, Philippe Mathieu-Daudé wrote: > On 11/07/2017 05:46 PM, Emilio G. Cota wrote: >> Fixes the following warning when compiling with gcc 5.4.0 with -O1 >> optimizations and --enable-debug: >> >> target/arm/translate-a64.c: In function ‘aarch64_tr_translate_insn’: >> target

Re: [Qemu-devel] [PATCH v2] highbank: validate register offset before access

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 06:26, P J P wrote: > From: Prasad J Pandit > > An 'offset' parameter sent to highbank register r/w functions > could be greater than number(NUM_REGS=0x200) of hb registers, > leading to an OOB access issue. Add check to avoid it. > > Reported-by: Moguofang (Dennis mo) > S

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 01/12] HACK: use objdump disas

2017-11-13 Thread Alex Bennée
Richard Henderson writes: > --- > disas.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/disas.c b/disas.c > index d6a1eb9c8e..69069a85ca 100644 > --- a/disas.c > +++ b/disas.c > @@ -231,7 +231,7 @@ void target_disas(FILE *out, CPUState *cpu, target_ulong > code, >

Re: [Qemu-devel] [Qemu devel PATCH v2] MAINTAINERS: Add entries for Smartfusion2

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 05:55, Subbaraya Sundeep wrote: > Voluntarily add myself as maintainer for Smartfusion2 > > Signed-off-by: Subbaraya Sundeep > Reviewed-by: Alistair Francis > Reviewed-by: Philippe Mathieu-Daudé > --- > v2: > reframed commit message as per Alistair's comment. >

Re: [Qemu-devel] [Qemu-arm] [PATCH v1 02/12] target/arm: Add ARM_FEATURE_V8_1_SIMD

2017-11-13 Thread Alex Bennée
Richard Henderson writes: "...and enable it for the 'any' CPUs used by linux-user"? Otherwise: Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > target/arm/cpu.h | 1 + > linux-user/elfload.c | 9 + > target/arm/cpu.c | 1 + > target/arm/cpu64.c | 1 + >

Re: [Qemu-devel] [PATCH for-2.11] nbd: Don't crash when server reports NBD_CMD_READ failure

2017-11-13 Thread Vladimir Sementsov-Ogievskiy
12.11.2017 04:39, Eric Blake wrote: If a server fails a read, for example with EIO, but the connection is still live, then we would crash trying to print a non-existent error message. Bug introduced in commit f140e300. Signed-off-by: Eric Blake --- block/nbd-client.c | 4 ++-- 1 file change

Re: [Qemu-devel] [PATCH for 2.11 0/5] TCG/ARM fixes for 2.11

2017-11-13 Thread Peter Maydell
On 10 November 2017 at 19:53, Emilio G. Cota wrote: > Some MachineClass changes to fix TCG initialization of some > ARM boards for 2.11. This was originally reported by Thomas Huth in [1], > where Peter suggested a way to fix it. Further discussion in > another thread [2] followed up on this. > >

Re: [Qemu-devel] [PATCH v1] migration/ram.c: do not set 'postcopy_running' in POSTCOPY_INCOMING_END

2017-11-13 Thread Daniel Henrique Barboza
Hi Peter, On 11/13/2017 01:22 AM, Peter Xu wrote: On Fri, Nov 10, 2017 at 06:35:16PM -0200, Daniel Henrique Barboza wrote: When migrating a VM with 'migrate_set_capability postcopy-ram on' a postcopy_state is set during the process, ending up with the state POSTCOPY_INCOMING_END when the migrat

Re: [Qemu-devel] [PULL for-2.11 0/2] Capstone updates

2017-11-13 Thread Peter Maydell
On 9 November 2017 at 07:52, Richard Henderson wrote: > One build fix for mingw cross-compiling, one feature regression fix. > > > r~ > > > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) > > are

Re: [Qemu-devel] [PATCH 2/7] s390x/pci: rework PCI STORE

2017-11-13 Thread Cornelia Huck
On Mon, 13 Nov 2017 10:03:37 +0100 Pierre Morel wrote: > On 09/11/2017 17:50, Cornelia Huck wrote: > > On Tue, 7 Nov 2017 18:24:34 +0100 > > Pierre Morel wrote: > >> +case PCI_ROM_SLOT: > > > > So, will this be filled in a later patch? (Reading from the top.) > > No it will not it is

Re: [Qemu-devel] [PATCH 6/7] s390x/pci: move the memory region write from pcistg

2017-11-13 Thread Cornelia Huck
On Mon, 13 Nov 2017 10:39:50 +0100 Pierre Morel wrote: > On 10/11/2017 10:51, Cornelia Huck wrote: > > On Fri, 10 Nov 2017 17:40:12 +0800 > > Yi Min Zhao wrote: > > > >> 在 2017/11/10 上午3:23, Cornelia Huck 写道: > >>> On Tue, 7 Nov 2017 18:24:38 +0100 > >>> Pierre Morel wrote: > >>> > >

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

2017-11-13 Thread Ladi Prosek
On Wed, Nov 8, 2017 at 3:28 PM, Mihail Abakumov wrote: > Ladi Prosek писал 2017-11-08 16:43: > >> On Wed, Nov 8, 2017 at 12:54 PM, Mihail Abakumov >> wrote: >>> >>> Ladi Prosek писал 2017-11-06 18:15: >>> >>> In your case windbg does not send packets, more specifically, does not >>> continue to d

[Qemu-devel] [RFC 3/5] hw/arm: add scattered RAM memory region support

2017-11-13 Thread zhuyijun
From: Zhu Yijun Dig out reserved memory holes and collect scattered RAM memory regions by adding mem_list member in arm_boot_info struct. Signed-off-by: Zhu Yijun --- hw/arm/boot.c| 8 hw/arm/virt.c| 101 ++- include/hw/arm

[Qemu-devel] [RFC 0/5] arm: Exclude reserved memory regions of iommu to avoid

2017-11-13 Thread zhuyijun
From: Zhu Yijun With kernel 4.11, iommu/smmu will populate the MSI IOVA reserved window and PCI reserved window which has to be excluded from Guest iova allocations. And on certain HiSilicon platforms (hip06/hip07), the GIC ITS and PCIe RC deviates from the standard implementation will reserve

[Qemu-devel] [RFC 1/5] hw/vfio: Add function for getting reserved_region of device iommu group

2017-11-13 Thread zhuyijun
From: Zhu Yijun With kernel 4.11, iommu/smmu will populate the MSI IOVA reserved window and PCI reserved window which has to be excluded from Guest iova allocations. However, If it falls within the Qemu default virtual memory address space, then reserved regions may get allocated for a Guest VF

Re: [Qemu-devel] QMP, HMP: introduce 'writeconfig' command

2017-11-13 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: >> Hi Guys, >> >> This thread is a continuation of discussion started in >> http://lists.nongnu.org/archive/html/qemu-devel/2017-02/msg03182.html. >> >> This series introduces ‘writeconfig’ command supp

Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

2017-11-13 Thread Gerd Hoffmann
On Sun, Nov 12, 2017 at 08:30:25PM +0100, Jindrich Makovicka wrote: > With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN > blocks all subsequent display updates. > > Instead of trying to override the change, just update the scon->hidden > flag. Has for me the side effect that so

Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

2017-11-13 Thread Gerd Hoffmann
On Mon, Nov 13, 2017 at 01:39:14PM +0100, Gerd Hoffmann wrote: > On Sun, Nov 12, 2017 at 08:30:25PM +0100, Jindrich Makovicka wrote: > > With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN > > blocks all subsequent display updates. > > > > Instead of trying to override the change,

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Auger Eric
Hi Peter, On 09/10/2017 19:47, Peter Maydell wrote: > On 1 September 2017 at 18:21, Eric Auger wrote: >> The VirtMachineState contains some dt phandles that will be used >> in some node creation functions. For instance we plan to use the >> PCI host controller phandle in the smmu node creation fu

Re: [Qemu-devel] [PATCH v13 2/6] qmp: Use ThrottleLimits structure

2017-11-13 Thread Pradeep Jagadeesh
On 10/13/2017 4:26 PM, Eric Blake wrote: [adding Markus, and block list] On 10/13/2017 09:16 AM, Alberto Garcia wrote: On Mon 02 Oct 2017 04:33:28 PM CEST, Pradeep Jagadeesh wrote: This patch factors out code to use the ThrottleLimits structure. { 'struct': 'BlockIOThrottle', - 'data': {

Re: [Qemu-devel] [PATCH V5] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-11-13 Thread Marcel Apfelbaum
On 11/11/2017 17:25, Marcel Apfelbaum wrote: Currently there is no MMIO range over 4G reserved for PCI hotplug. Since the 32bit PCI hole depends on the number of cold-plugged PCI devices and other factors, it is very possible is too small to hotplug PCI devices with large BARs. Fix it by reservi

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 13:00, Auger Eric wrote: > On 09/10/2017 19:47, Peter Maydell wrote: >> More generally, why is sysbus-fdt involved in this at all? >> I expected that instantiating and wiring up the SMMU would >> be the job of hw/arm/virt.c, like any other device we >> might have on the boar

Re: [Qemu-devel] [virtio-dev] Re: [v21 1/2] virtio-crypto: Add virtio crypto device specification

2017-11-13 Thread Halil Pasic
On 11/13/2017 08:17 AM, Gonglei (Arei) wrote: >>> +struct virtio_crypto_cipher_session_req { >>> +/* Device-readable part */ >>> +struct virtio_crypto_cipher_session_para para; >>> +/* The cipher key */ >>> +u8 cipher_key[keylen]; >>> + >> Is there a limit to the size of chiper_ke

Re: [Qemu-devel] [PULL for-2.11 0/2] s390x changes for 2.11-rc1

2017-11-13 Thread Peter Maydell
On 9 November 2017 at 15:32, Cornelia Huck wrote: > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) > > are available in the git repository at: > > git://github.com/cohuck/qemu tags/s390x-201711

Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

2017-11-13 Thread Jindřich Makovička
On Mon, Nov 13, 2017 at 1:59 PM, Gerd Hoffmann wrote: > On Mon, Nov 13, 2017 at 01:39:14PM +0100, Gerd Hoffmann wrote: >> On Sun, Nov 12, 2017 at 08:30:25PM +0100, Jindrich Makovicka wrote: >> > With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN >> > blocks all subsequent display

Re: [Qemu-devel] [PATCH 4/8] sdl2: Do not hide the cursor on auxilliary windows

2017-11-13 Thread Gerd Hoffmann
Fails scripts/checkpatch.pl (trailing whitespace on several lines).

Re: [Qemu-devel] [PATCH 5/8] sdl2 uses surface relative coordinates

2017-11-13 Thread Gerd Hoffmann
On Sun, Nov 12, 2017 at 08:30:29PM +0100, Jindrich Makovicka wrote: > This patch fixes mouse positioning with -device usb-tablet and fullscreen > or resized window. Fails checkpatch too (long lines). Also: can you add a "Fixes: 46522a82236ea0cf9011b89896d2d8f8ddaf2443" line (that is the commit wh

[Qemu-devel] [Bug 1563887] Re: qemu-system-ppc64 freezes on starting image on ppc64le

2017-11-13 Thread ChristianEhrhardt
Thanks for the Detail Robin! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1563887 Title: qemu-system-ppc64 freezes on starting image on ppc64le Status in QEMU: Invalid Status in linux package i

Re: [Qemu-devel] [PATCH v2 1/2] accel/tcg/translate-all: expand cpu_restore_state addr check

2017-11-13 Thread Peter Maydell
On 8 November 2017 at 15:32, Alex Bennée wrote: > We are still seeing signals during translation time when we walk over > a page protection boundary. This expands the check to ensure the host > PC is inside the code generation buffer. The original suggestion was > to check versus tcg_ctx.code_gen_

Re: [Qemu-devel] [PATCH] hw/arm/aspeed: Unlock SCU when running kernel

2017-11-13 Thread Joel Stanley
On Thu, Nov 9, 2017 at 5:54 PM, Cédric Le Goater wrote: > On 11/08/2017 04:24 AM, Joel Stanley wrote: >> --- a/hw/misc/aspeed_sdmc.c >> +++ b/hw/misc/aspeed_sdmc.c >> @@ -18,7 +18,6 @@ >> >> /* Protection Key Register */ >> #define R_PROT(0x00 / 4) >> -#define PROT_KEY_UNLOCK

[Qemu-devel] [PATCH v2] hw/arm/aspeed: Unlock SCU when running kernel

2017-11-13 Thread Joel Stanley
The ASPEED hardware contains a lock register for the SCU that disables any writes to the SCU when it is locked. The machine comes up with the lock enabled, but on all known hardware u-boot will unlock it and leave it unlocked when loading the kernel. This means the kernel expects the SCU to be unl

Re: [Qemu-devel] [PATCH 8/8] sdl2: Ignore UI hotkeys after a focus change when GUI modifier is held

2017-11-13 Thread Gerd Hoffmann
Hi, > if (!gui_grab && (qemu_input_is_absolute() || absolute_enabled)) { > absolute_mouse_grab(scon); > } Can you please add a comment here describing why this is done? >From the code alone it isn't obvious that this is a workaround for a SDL bug. > +scon-

[Qemu-devel] [Bug 1727737] Re: qemu-arm stalls on a GCC sanitizer test since qemu-2.7

2017-11-13 Thread Christophe Lyon
I looked a bit more at the sanitizers source code, to understand the differences between arm and aarch64. And it turns out that on aarch64, we have: sanitizer_common/sanitizer_syscall_linux_aarch64.inc: 133 // Helper function used to avoid cobbler errno. 134 bool internal_iserror(uptr retv

[Qemu-devel] [Bug 1727737] Re: qemu-arm stalls on a GCC sanitizer test since qemu-2.7

2017-11-13 Thread Christophe Lyon
I also looked at QEMU's code, and I am suprised that do_syscall() returns the value of errno rather than the return code from the syscall. So for instance, if clone() fails, do_syscall() returns get_errno(do_fork(...)) instead of -1. I thought the target code expects -1 in case of failure, but I'm

Re: [Qemu-devel] [PATCH v3] SDL2 various fixes

2017-11-13 Thread Gerd Hoffmann
On Sun, Nov 12, 2017 at 08:30:24PM +0100, Jindrich Makovicka wrote: > Hi, > > here is an identical patchset with Signed-off-by. Please post a new version without reply-to. Queued up four patches: sdl2: Do not leave grab when fullscreen sdl2: Fix dead keyboard after fullsceen sdl2: Use the

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Auger Eric
Hi Peter, On 13/11/2017 14:08, Peter Maydell wrote: > On 13 November 2017 at 13:00, Auger Eric wrote: >> On 09/10/2017 19:47, Peter Maydell wrote: >>> More generally, why is sysbus-fdt involved in this at all? >>> I expected that instantiating and wiring up the SMMU would >>> be the job of hw/arm

Re: [Qemu-devel] [PATCH 1/8] sdl2: Fix broken display updating after the window is hidden

2017-11-13 Thread Gerd Hoffmann
Hi, > >> Have a slightly older SDL version (2.0.3). Do you see that effect with > >> 2.0.6 too? > > > > Oh, and I've just seen the current code has been added as attempt to > > workaround that bug, see commit d3f3a0f453ea590be529079ae214c200bb5ecc1a. > > > > Hmm. Seems we are trading one issue

Re: [Qemu-devel] [virtio-dev] Re: [v21 1/2] virtio-crypto: Add virtio crypto device specification

2017-11-13 Thread Gonglei (Arei)
Hello Halil, Thanks for your feedback. > > On 11/13/2017 08:17 AM, Gonglei (Arei) wrote: > >>> +struct virtio_crypto_cipher_session_req { > >>> +/* Device-readable part */ > >>> +struct virtio_crypto_cipher_session_para para; > >>> +/* The cipher key */ > >>> +u8 cipher_key[keyl

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Peter Maydell
On 13 November 2017 at 13:37, Auger Eric wrote: > On 13/11/2017 14:08, Peter Maydell wrote: >> Not being able to conveniently wire up a sysbus device on the >> command line or pass it options are general problems. I don't >> think the SMMU is a special case that should work around these >> general

[Qemu-devel] [Bug 1727737] Re: qemu-arm stalls on a GCC sanitizer test since qemu-2.7

2017-11-13 Thread Peter Maydell
Hmm, the do_fork() code is a bit inconsistent there. Generally in linux-user/ functions should either: (1) return -1 with host errno set to a host errno; the caller then must use get_errno() to convert to the negative-target-errno that we need to return from do_syscall() (2) return negative-targ

Re: [Qemu-devel] [PULL 0/8] NBD patches for 2.11-rc1

2017-11-13 Thread Peter Maydell
On 9 November 2017 at 16:59, Eric Blake wrote: > The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: > > Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) > > are available in the git repository at: > > git://repo.or.cz/qemu/ericb.git tags/pull-nbd-201

Re: [Qemu-devel] [PATCH v7 15/20] hw/arm/sysbus-fdt: Pass the VirtMachineState to the node creation functions

2017-11-13 Thread Auger Eric
Hi, On 13/11/2017 14:44, Peter Maydell wrote: > On 13 November 2017 at 13:37, Auger Eric wrote: >> On 13/11/2017 14:08, Peter Maydell wrote: >>> Not being able to conveniently wire up a sysbus device on the >>> command line or pass it options are general problems. I don't >>> think the SMMU is a

Re: [Qemu-devel] [PATCH v3 2/2] qdev: Check for the availability of a hotplug controller before adding a device

2017-11-13 Thread Markus Armbruster
Thomas Huth writes: > The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, > so QEMU crashes when the user tries to device_add + device_del a device > that does not have a corresponding hotplug controller. This could be > provoked for a couple of devices in the past (see commit

Re: [Qemu-devel] [PATCH] block: Close a BlockDriverState completely even when bs->drv is NULL

2017-11-13 Thread Alberto Garcia
On Wed 08 Nov 2017 03:33:54 PM CET, Kevin Wolf wrote: >> This patch makes bdrv_close() do the full uninitialization process in >> all cases. This fixes the problem with corrupted images and still >> works fine with freshly created BDSs. >> >> Signed-off-by: Alberto Garcia > > This doesn't apply c

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: Test I/O limits with removable media

2017-11-13 Thread Alberto Garcia
On Fri 10 Nov 2017 11:21:27 PM CET, Max Reitz wrote: > By the way, I just noticed that this test tests that > x-blockdev-remove-medium and x-blockdev-insert-medium do not destroy > throttling information -- which is exactly why those commands had been > declared experimental in the first place. O

[Qemu-devel] [PULL 8/9] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-13 Thread Peter Maydell
From: "Emilio G. Cota" max_cpus needs to be an upper bound on the number of vCPUs initialized; otherwise TCG region initialization breaks. Some boards initialize a hard-coded number of vCPUs, which is not captured by the global max_cpus and therefore breaks TCG initialization. Fix it by adding t

[Qemu-devel] [PULL 7/9] xlnx-zcu102: Specify the max number of CPUs for the EP108

2017-11-13 Thread Peter Maydell
From: "Emilio G. Cota" Just like the zcu102, the ep108 can instantiate several CPUs. Signed-off-by: Emilio G. Cota Reviewed-by: Alistair Francis Message-id: 1510343626-25861-5-git-send-email-c...@braap.org Signed-off-by: Peter Maydell --- hw/arm/xlnx-zcu102.c | 1 + 1 file changed, 1 inserti

[Qemu-devel] [PULL 1/9] arm/translate-a64: mark path as unreachable to eliminate warning

2017-11-13 Thread Peter Maydell
From: "Emilio G. Cota" Fixes the following warning when compiling with gcc 5.4.0 with -O1 optimizations and --enable-debug: target/arm/translate-a64.c: In function ‘aarch64_tr_translate_insn’: target/arm/translate-a64.c:2361:8: error: ‘post_index’ may be used uninitialized in this function [-We

[Qemu-devel] [PULL 6/9] xlnx-zcu102: Add an info message deprecating the EP108

2017-11-13 Thread Peter Maydell
From: Alistair Francis The EP108 was an early access development board that is no longer used. Add an info message to convert any users to the ZCU102 instead. On QEMU they are both identical. This patch also updated the qemu-doc.texi file to indicate that the EP108 has been deprecated. Signed-o

[Qemu-devel] [PULL 2/9] highbank: validate register offset before access

2017-11-13 Thread Peter Maydell
From: Prasad J Pandit An 'offset' parameter sent to highbank register r/w functions could be greater than number(NUM_REGS=0x200) of hb registers, leading to an OOB access issue. Add check to avoid it. Reported-by: Moguofang (Dennis mo) Signed-off-by: Prasad J Pandit Message-id: 20171113062658.

Re: [Qemu-devel] [PATCH v3 2/2] qdev: Check for the availability of a hotplug controller before adding a device

2017-11-13 Thread Thomas Huth
On 13.11.2017 15:00, Markus Armbruster wrote: > Thomas Huth writes: > >> The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, >> so QEMU crashes when the user tries to device_add + device_del a device >> that does not have a corresponding hotplug controller. This could be >> pr

[Qemu-devel] [PULL 9/9] accel/tcg/translate-all: expand cpu_restore_state addr check

2017-11-13 Thread Peter Maydell
From: Alex Bennée We are still seeing signals during translation time when we walk over a page protection boundary. This expands the check to ensure the host PC is inside the code generation buffer. The original suggestion was to check versus tcg_ctx.code_gen_ptr but as we now segment the transla

[Qemu-devel] [PULL 5/9] xlnx-zynqmp: Properly support the smp command line option

2017-11-13 Thread Peter Maydell
From: Alistair Francis Allow the -smp command line option to control the number of CPUs we create. Signed-off-by: Alistair Francis Reviewed-by: Eduardo Habkost Reviewed-by: Emilio G. Cota Tested-by: Emilio G. Cota Message-id: 1510343626-25861-3-git-send-email-c...@braap.org Signed-off-by: Pe

[Qemu-devel] [PULL 3/9] MAINTAINERS: Add entries for Smartfusion2

2017-11-13 Thread Peter Maydell
From: Subbaraya Sundeep Voluntarily add myself as maintainer for Smartfusion2 Signed-off-by: Subbaraya Sundeep Reviewed-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé Message-id: 1510552520-3566-1-git-send-email-sundeep.l...@gmail.com Signed-off-by: Peter Maydell --- MAINTAINERS |

Re: [Qemu-devel] [PATCH v4] throttle-groups: drain before detaching ThrottleState

2017-11-13 Thread Stefan Hajnoczi
On Fri, Nov 10, 2017 at 03:19:34PM +, Stefan Hajnoczi wrote: > I/O requests hang after stop/cont commands at least since QEMU 2.10.0 > with -drive iops=100: > > (guest)$ dd if=/dev/zero of=/dev/vdb oflag=direct count=1000 > (qemu) stop > (qemu) cont > ...I/O is stuck... > > This happe

[Qemu-devel] [PULL 0/9] target-arm queue

2017-11-13 Thread Peter Maydell
e/pmaydell/qemu-arm.git tags/pull-target-arm-20171113 for you to fetch changes up to d25f2a72272b9ffe0d06710d6217d1169bc2cc7d: accel/tcg/translate-all: expand cpu_restore_state addr check (2017-11-13 13:55:27 +) target

Re: [Qemu-devel] NBD BLOCK_STATUS

2017-11-13 Thread Eric Blake
On 11/10/2017 10:51 AM, Vladimir Sementsov-Ogievskiy wrote: > 10.11.2017 19:06, Eric Blake wrote: >> On 11/09/2017 06:42 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Hi! >>> >>> Interesting fact: list/set_meta_context options are per-export, >>> so, in the server we should keep context selection per

[Qemu-devel] [PULL 4/9] qom: move CPUClass.tcg_initialize to a global

2017-11-13 Thread Peter Maydell
From: "Emilio G. Cota" 55c3cee ("qom: Introduce CPUClass.tcg_initialize", 2017-10-24) introduces a per-CPUClass bool that we check so that the target CPU is initialized for TCG only once. This works well except when we end up creating more than one CPUClass, in which case we end up incorrectly in

[Qemu-devel] [Bug 1727737] Re: qemu-arm stalls on a GCC sanitizer test since qemu-2.7

2017-11-13 Thread Christophe Lyon
Thanks for the clarification. But how does the target get the actual syscall return code, if do_syscall() is supposed to return negative-target-errno? I mean, in general the target code will check if the syscall returned -1, and only then query errno? But if QEMU's do_syscall returns -errno, and

Re: [Qemu-devel] [PATCH 1/3] ivshmem: Don't update non-existent MSI routes

2017-11-13 Thread Markus Armbruster
Ladi Prosek writes: > As of commit 660c97eef6f8 ("ivshmem: use kvm irqfd for msi notifications"), > QEMU crashes with: > > kvm_irqchip_commit_routes: Assertion `ret == 0' failed. > > if the ivshmem device is configured with more vectors than what the server > supports. This is caused by the ivs

Re: [Qemu-devel] [Qemu-block] [PATCH v2 0/1] Add 8-byte wide AMD flash support, partial interleaving

2017-11-13 Thread Michael Nawrocki
On 11/10/2017 06:12 PM, Paolo Bonzini wrote: On 10/11/2017 21:25, Mike Nawrocki wrote: This patch set does a few things. First, it switches the AMD CFI flash MMIO operations from the old MMIO API to the new one. Second, it enables 8-byte wide flash arrays. Finally, it adds flash interleaving usi

[Qemu-devel] Command-line option to change ungrab key(s)

2017-11-13 Thread Programmingkid
Would you accept a patch that allows the user to change the mouse ungrab key(s) in QEMU? It would look something like this: -ungrab or -ungrab ,,... If the user wanted the F19 key to be the ungrab key, this is what would be sent to QEMU: -ungrab F19 If the user wanted F16 and F17 held

Re: [Qemu-devel] [PATCH v4] throttle-groups: drain before detaching ThrottleState

2017-11-13 Thread Alberto Garcia
On Fri 10 Nov 2017 04:19:34 PM CET, Stefan Hajnoczi wrote: > I/O requests hang after stop/cont commands at least since QEMU 2.10.0 > with -drive iops=100: > > (guest)$ dd if=/dev/zero of=/dev/vdb oflag=direct count=1000 > (qemu) stop > (qemu) cont > ...I/O is stuck... > > This happens becau

Re: [Qemu-devel] [PATCH v2 for-2.11] block: Make bdrv_next() keep strong references

2017-11-13 Thread Stefan Hajnoczi
On Fri, Nov 10, 2017 at 06:25:45PM +0100, Max Reitz wrote: > On one hand, it is a good idea for bdrv_next() to return a strong > reference because ideally nearly every pointer should be refcounted. > This fixes intermittent failure of iotest 194. > > On the other, it is absolutely necessary for bd

  1   2   3   4   >