Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-08 Thread Stefan Priebe - Profihost AG
Am 08.11.2017 um 08:54 schrieb Jason Wang: > > > On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote: >> Hi Paolo, >> >> Am 06.11.2017 um 12:27 schrieb Paolo Bonzini: >>> On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote: HI Paolo, could this patchset be related? >>> Uh

[Qemu-devel] [PULL 2/3] hw/display/sm501: Fix comment in sm501_sysbus_class_init()

2017-11-08 Thread David Gibson
From: Thomas Huth The "cannot_instantiate_with_device_add_yet" flag has been renamed to "user_creatable" a while ago. Signed-off-by: Thomas Huth Reviewed-by: Gerd Hoffmann Signed-off-by: David Gibson --- hw/display/sm501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/h

[Qemu-devel] [PULL 3/3] e500: ppce500_init_mpic() return device instead of IRQ array

2017-11-08 Thread David Gibson
From: Michael Davidsaver Actual number of interrupt pins isn't known in ppce500_init_mpic() so a hardcoded number was used, which causes a crash with older openpic. Instead, return the DeviceState* and change ppce500_init() to call qdev_get_gpio_in() to get only the irq pins which are needed. S

Re: [Qemu-devel] [PATCH 2/6] migration: print features as on off

2017-11-08 Thread Peter Xu
On Mon, Oct 30, 2017 at 12:21:08PM +0100, Juan Quintela wrote: > Once there, do one thing for line > > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu > --- > migration/migration.c | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/migration/migration.c

[Qemu-devel] [PULL 0/3] ppc-for-2.11 queue 20171108

2017-11-08 Thread David Gibson
The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) are available in the git repository at: git://github.com/dgibson/qemu.git tags/ppc-for-2.11-20171108 for you to fetch changes up to

Re: [Qemu-devel] [PATCH 3/6] migration: free addr in the same function that we created it

2017-11-08 Thread Peter Xu
On Mon, Oct 30, 2017 at 12:21:09PM +0100, Juan Quintela wrote: > Otherwise, we can't use it after calling socket_start_incoming_migration > > Signed-off-by: Juan Quintela Reviewed-by: Peter Xu http://lists.gnu.org/archive/html/qemu-devel/2017-11/msg01305.html So I got a same patch. Let's see

[Qemu-devel] [PULL 1/3] ppc: fix setting of compat mode

2017-11-08 Thread David Gibson
From: Greg Kurz While trying to make KVM PR usable again, commit 5dfaa532ae introduced a regression: the current compat_pvr value is passed to KVM instead of the new one. This means that we always pass 0 instead of the max-cpu-compat PVR during the initial machine reset. And at CAS time, we eithe

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-08 Thread Jason Wang
On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote: Am 08.11.2017 um 08:54 schrieb Jason Wang: On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote: Hi Paolo, Am 06.11.2017 um 12:27 schrieb Paolo Bonzini: On 06/11/2017 12:09, Stefan Priebe - Profihost AG wrote: HI Paolo, could

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-08 Thread Alexey Kardashevskiy
On 07/11/17 21:12, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: >>> On 04/11/17 02:33, Daniel P. Berrange wrote: We short circuit the git submodule update when passed an empty module list. >>

Re: [Qemu-devel] [PATCH for-2.11] linux-user: Fix calculation of auxv length

2017-11-08 Thread Richard Henderson
On 11/07/2017 07:25 PM, Peter Maydell wrote: > In commit 7c4ee5bcc82e643 we changed the order in which we construct > the AUXV, but forgot to adjust the calculation of the length. The > result is that we set info->auxv_len to a bogus and negative value, > and then later on the code in open_self_aux

Re: [Qemu-devel] [PATCH 0/7] s390x/pci: Improve zPCI to cover more cases

2017-11-08 Thread Cornelia Huck
On Tue, 7 Nov 2017 18:50:10 +0100 Christian Borntraeger wrote: > On 11/07/2017 06:31 PM, Cornelia Huck wrote: > > On Tue, 7 Nov 2017 18:24:32 +0100 > > Pierre Morel wrote: > > > >> Right now the PCI support is very limited (e.g. pass through of a > >> host vfio device) > >> To enable feature

Re: [Qemu-devel] [PATCH 1/1] s390x/pci: let pci devices start in configured mode

2017-11-08 Thread Cornelia Huck
On Tue, 7 Nov 2017 18:54:55 +0100 Christian Borntraeger wrote: > Currently, to enable a pci device in the guest, the user has to issue > echo 1 > /sys/bus/pci/slots//power. This is not what people > expect. On an LPAR, the user can put a PCI device in configured or > deconfigured state v

Re: [Qemu-devel] [PATCH] accel/tcg/translate-all: expand cpu_restore_state retaddr check

2017-11-08 Thread Richard Henderson
On 11/07/2017 07:53 PM, Peter Maydell wrote: >> Then why call cpu_restore_state at all? We should be consistent as there >> are plenty of places that do things like: >> >> if (pc) { >> /* now we have a real cpu fault */ >> cpu_restore_state(cs, pc); >> } >> >> I'm happy to m

Re: [Qemu-devel] i440/piix and dynamic sysbus check

2017-11-08 Thread Marcel Apfelbaum
On 07/11/2017 18:40, Marc-André Lureau wrote: Hi, I am working on a TPM CRB device (last sent version: https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg02014.html). It's a sysbus device, and when starting qemu with i440, I get "Option '-device tpm-crb' cannot be handled by this machine".

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 07:28:31PM +1100, Alexey Kardashevskiy wrote: > On 07/11/17 21:12, Daniel P. Berrange wrote: > > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: > >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: > >>> On 04/11/17 02:33, Daniel P. Berrange wrote: > >>>

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 09:58:11AM +1100, Alexey Kardashevskiy wrote: > On 07/11/17 21:12, Daniel P. Berrange wrote: > > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: > >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: > >>> On 04/11/17 02:33, Daniel P. Berrange wrote: > >>>

Re: [Qemu-devel] [PATCH v1 1/1] Makefile: Capstone: Add support for cross compile ranlib

2017-11-08 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 05:10:46PM -0800, Alistair Francis wrote: > When cross compiling QEMU for Windows we need to specify the cross > version of ranlib to avoid build errors when buildling capstone. This > patch ensures we use the same cross prefix on ranlib as other toolchain > components. > >

Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-08 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 11:28:28PM -0300, Philippe Mathieu-Daudé wrote: > Deprecated since 2.9.0, guests should be able to use "pc" instead. Isn't isapc important to allow QEMU to old operating systems that predate the PCI era. I do recall seeing some messages about specific cases where you cannot

Re: [Qemu-devel] [RFC PATCH 0/6] generic way to deprecate machines

2017-11-08 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 11:28:22PM -0300, Philippe Mathieu-Daudé wrote: > Hi, > > This series intends to provide a simple and common way to deprecate > machines between releases. It may be extended to deprecate devices. > > I started with the machines list from: > > https://wiki.qemu.org/Featu

Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 12:28:00AM -0300, Philippe Mathieu-Daudé wrote: > Hi Alexey, > > On 11/07/2017 11:48 PM, Alexey Kardashevskiy wrote: > > On 08/11/17 13:28, Philippe Mathieu-Daudé wrote: > >> Both are deprecated since 2.9.0 > > > > May be so but I could not find where this happened in git

Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

2017-11-08 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 11:28:27PM -0300, Philippe Mathieu-Daudé wrote: > Both are deprecated since 2.9.0 > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc_piix.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index f79d5cb694..c462

Re: [Qemu-devel] [RFC PATCH 2/6] hw/arm: deprecate the EP108 board

2017-11-08 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 11:28:24PM -0300, Philippe Mathieu-Daudé wrote: > From: Alistair Francis > > The EP108 was an early access development board that is no longer used. > Add an info message to convert any users to the ZCU102 instead. On QEMU > they are both identical. > > Signed-off-by: Ali

Re: [Qemu-devel] [PATCH] Makefile: simpler/faster "make help"

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 12:20:52AM -0300, Philippe Mathieu-Daudé wrote: > Using obscure black magic introduced in eaa2ddbb767 :) > > In an out-of-tree directory, running "../configure && make help" will generate > some required files (.mak), then clone some submodules, compile at least > the capst

Re: [Qemu-devel] [PATCH 1/1] s390x/pci: let pci devices start in configured mode

2017-11-08 Thread Pierre Morel
On 08/11/2017 09:53, Cornelia Huck wrote: On Tue, 7 Nov 2017 18:54:55 +0100 Christian Borntraeger wrote: Currently, to enable a pci device in the guest, the user has to issue echo 1 > /sys/bus/pci/slots//power. This is not what people expect. On an LPAR, the user can put a PCI device

[Qemu-devel] [Bug 1245703] Re: LD_PREFIX option reads directories recursively in an endless loop

2017-11-08 Thread Richard Henderson
I posted a patch a while back that would fix this: https://patchwork.kernel.org/patch/9512083/ -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1245703 Title: LD_PREFIX option reads directories recur

Re: [Qemu-devel] [PATCH for-2.11] target/arm: Report GICv3 sysregs present in ID registers if needed

2017-11-08 Thread Richard Henderson
On 11/07/2017 04:01 PM, Peter Maydell wrote: > The CPU ID registers ID_AA64PFR0_EL1, ID_PFR1_EL1 and ID_PFR1 > have a field for reporting presence of GICv3 system registers. > We need to report this field correctly in order for Xen to > work as a guest inside QEMU emulation. We mustn't incorrectly

Re: [Qemu-devel] [PATCH 10/10] migration: [RFC] Use proper types in json

2017-11-08 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: > >> "Daniel P. Berrange" wrote: >>> On Tue, Oct 10, 2017 at 08:15:42PM +0200, Juan Quintela wrote: We use int for everything (int64_t), and then we check that value is between 0 and 255. Change it to the valid types. For qmp

Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-08 Thread Gerd Hoffmann
On Wed, Nov 08, 2017 at 09:09:00AM +, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 11:28:28PM -0300, Philippe Mathieu-Daudé wrote: > > Deprecated since 2.9.0, guests should be able to use "pc" instead. > > Isn't isapc important to allow QEMU to old operating systems that > predate the P

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-08 Thread Paolo Bonzini
On 08/11/2017 09:21, Jason Wang wrote: > > > On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote: >> Am 08.11.2017 um 08:54 schrieb Jason Wang: >>> >>> On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote: Hi Paolo, Am 06.11.2017 um 12:27 schrieb Paolo Bonzini: > On 06

Re: [Qemu-devel] [PATCH 1/8] spapr: introduce an IRQ allocator at the machine level

2017-11-08 Thread Greg Kurz
On Sun, 29 Oct 2017 19:12:10 +0100 Cédric Le Goater wrote: > Currently, the ICSState 'ics' object of the sPAPR machine acts as the > global interrupt source handler and also as the IRQ number allocator > for the machine. Some IRQ numbers are allocated very early in the > machine initialization se

Re: [Qemu-devel] [Qemu-block] [PATCH v2 4/7] qcow2: Don't open images with header.refcount_table_clusters == 0

2017-11-08 Thread Alberto Garcia
On Tue 07 Nov 2017 05:43:49 PM CET, Kevin Wolf wrote: >> +echo >> +echo "=== Testing zero refcount table size ===" >> +echo >> +_make_test_img 64M >> +poke_file "$TEST_IMG" "56""\x00\x00\x00\x00" >> +$QEMU_IO -c "write 0 64k" "$TEST_IMG" 2>&1 | _filter_testdir | >> _filter_imgfmt >

[Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Thomas Huth
That automatic git submodule stuff now broke my workflow again. I usually keep the git repository on my laptop and then simply rsync the sources (without .git directories) to my target machine to compile it there. Used to work great for years. Now it's broken, the build process complains: GIT sub

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Kevin Wolf
Am 07.11.2017 um 21:29 hat Eric Blake geschrieben: > On 11/07/2017 11:26 AM, Kevin Wolf wrote: > > bdrv_set_read_only() is used by some block drivers to override the > > read-only option given by the user. This is not how read-only images > > generally work in QEMU: Instead of second guessing what

Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-08 Thread Thomas Huth
On 08.11.2017 10:44, Gerd Hoffmann wrote: > On Wed, Nov 08, 2017 at 09:09:00AM +, Daniel P. Berrange wrote: >> On Tue, Nov 07, 2017 at 11:28:28PM -0300, Philippe Mathieu-Daudé wrote: >>> Deprecated since 2.9.0, guests should be able to use "pc" instead. >> >> Isn't isapc important to allow QEMU

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-08 Thread R.Nageswara Sastry
Thomas thanks for your hint about the configuration option named "--enable-tcg-interpreter". By removing it the test case started working fine. [root@zzfp365-lp1 qemu]# ./sparc64-softmmu/qemu-system-sparc64 -nographic -M sun4u -prom-env 'use-nvramrc?=true' -prom-env 'nvramrc=." Hello World!" cr'

Re: [Qemu-devel] [PATCH 4/7] sdl2: Only accept the hotkeys on the main window

2017-11-08 Thread Gerd Hoffmann
On Sun, Nov 05, 2017 at 09:10:45AM -0500, Cole Robinson wrote: > On 11/02/2017 01:12 PM, Jindřich Makovička wrote: > > This fixes the following case: > > > > 1) Ctrl-Alt-2 for console is pressed > > 2) console pops up and gets focus > > 3) console receives the Ctrl-Alt-2 keypress event > > 4) cons

Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

2017-11-08 Thread Thomas Huth
On 08.11.2017 10:16, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 11:28:27PM -0300, Philippe Mathieu-Daudé wrote: >> Both are deprecated since 2.9.0 >> >> Signed-off-by: Philippe Mathieu-Daudé >> --- >> hw/i386/pc_piix.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/hw/i386

Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-11-08 Thread Gerd Hoffmann
On Fri, Nov 03, 2017 at 11:56:27AM +, Owen Smith wrote: > Improve the input device model in xenfb, by updating the > Qemu input handlers and adding a feature to allow for > raw (unscaled) absolute coordinates to be represented. Reviewed-by: Gerd Hoffmann Will this be merged via xen queue? I

Re: [Qemu-devel] kvm: virtio-net: saved image requires TUN_F_UFO support

2017-11-08 Thread Jason Wang
On 2017年11月08日 18:46, Paolo Bonzini wrote: On 08/11/2017 09:21, Jason Wang wrote: On 2017年11月08日 17:05, Stefan Priebe - Profihost AG wrote: Am 08.11.2017 um 08:54 schrieb Jason Wang: On 2017年11月08日 15:41, Stefan Priebe - Profihost AG wrote: Hi Paolo, Am 06.11.2017 um 12:27 schrieb Paolo B

Re: [Qemu-devel] [RFC PATCH 1/6] machine: add a deprecated_reason property

2017-11-08 Thread Thomas Huth
On 08.11.2017 03:28, Philippe Mathieu-Daudé wrote: > If a machine has the deprecated_reason property set: > - it won't get listed anymore by the "-M help" command, > - a warning will be displayed if the machine is used. > > Example: > $ ppc-softmmu/qemu-system-ppc -M prep > qemu-system-ppc: -M

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 10:57:21AM +0100, Thomas Huth wrote: > > That automatic git submodule stuff now broke my workflow again. I > usually keep the git repository on my laptop and then simply rsync the > sources (without .git directories) to my target machine to compile it > there. Used to work

Re: [Qemu-devel] [PATCH 10/10] migration: [RFC] Use proper types in json

2017-11-08 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> "Daniel P. Berrange" wrote: On Tue, Oct 10, 2017 at 08:15:42PM +0200, Juan Quintela wrote: > We use int for everything (int64_t), and then we check that value is > between 0 and 255. Change it to the

Re: [Qemu-devel] [RFC PATCH 1/6] machine: add a deprecated_reason property

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 11:23:53AM +0100, Thomas Huth wrote: > On 08.11.2017 03:28, Philippe Mathieu-Daudé wrote: > > If a machine has the deprecated_reason property set: > > - it won't get listed anymore by the "-M help" command, > > - a warning will be displayed if the machine is used. > > > > E

Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

2017-11-08 Thread Thomas Huth
On 08.11.2017 10:13, Daniel P. Berrange wrote: > On Wed, Nov 08, 2017 at 12:28:00AM -0300, Philippe Mathieu-Daudé wrote: >> Hi Alexey, >> >> On 11/07/2017 11:48 PM, Alexey Kardashevskiy wrote: >>> On 08/11/17 13:28, Philippe Mathieu-Daudé wrote: Both are deprecated since 2.9.0 >>> >>> May be s

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Paolo Bonzini
On 07/11/2017 18:39, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wolf wrote: >> bdrv_set_read_only() is used by some block drivers to override the >> read-only option given by the user. This is not how read-only images >> generally work in QEMU: Instead of second gue

Re: [Qemu-devel] [Qemu-block] [PATCH v3 7/7] block/curl: code cleanup to comply with coding style

2017-11-08 Thread Darren Kenny
Hi Jeff, While I'm relatively new to this community, I do have some comments about the styling in this file. I don't see anything in the CODING_STYLE file that tells me I'm wrong here, but it's certainly possible... More inline. On Tue, Nov 07, 2017 at 05:27:24PM -0500, Jeff Cody wrote: This

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: > On 07/11/2017 18:39, Daniel P. Berrange wrote: > > On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wolf wrote: > >> bdrv_set_read_only() is used by some block drivers to override the > >> read-only option given by the user. This is no

Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/7] block/sheepdog: remove spurious NULL check

2017-11-08 Thread Darren Kenny
On Tue, Nov 07, 2017 at 05:27:20PM -0500, Jeff Cody wrote: 'tag' is already checked in the lines immediately preceding this check, and set to non-NULL if NULL. No need to check again, it hasn't changed. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Reviewed-by: Darren Kenny --- block/

Re: [Qemu-devel] [Qemu-block] [PATCH v3 2/7] block/ssh: make compliant with coding guidelines

2017-11-08 Thread Darren Kenny
On Tue, Nov 07, 2017 at 05:27:19PM -0500, Jeff Cody wrote: Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Reviewed-by: Darren Kenny --- block/ssh.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index de81ec

Re: [Qemu-devel] [Qemu-trivial] [PATCH] Makefile: simpler/faster "make help"

2017-11-08 Thread Laurent Vivier
On 08/11/2017 04:20, Philippe Mathieu-Daudé wrote: > Using obscure black magic introduced in eaa2ddbb767 :) > > In an out-of-tree directory, running "../configure && make help" will generate > some required files (.mak), then clone some submodules, compile at least > the capstone submodule, genera

Re: [Qemu-devel] [Qemu-block] [PATCH v3 5/7] block/curl: check error return of curl_global_init()

2017-11-08 Thread Darren Kenny
On Tue, Nov 07, 2017 at 05:27:22PM -0500, Jeff Cody wrote: If curl_global_init() fails, per the documentation no other curl functions may be called, so make sure to check the return value. Also, some minor changes to the initialization latch variable 'inited': - Make it static in the file, for

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Gerd Hoffmann
On Wed, Nov 08, 2017 at 10:57:21AM +0100, Thomas Huth wrote: > > That automatic git submodule stuff now broke my workflow again. I > usually keep the git repository on my laptop and then simply rsync the > sources (without .git directories) to my target machine to compile it > there. How about ex

Re: [Qemu-devel] [Qemu-block] [PATCH v3 4/7] block/sheepdog: code beautification

2017-11-08 Thread Darren Kenny
On Tue, Nov 07, 2017 at 05:27:21PM -0500, Jeff Cody wrote: No functional changes, just whitespace manipulation. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake Reviewed-by: Darren Kenny --- block/sheepdog.c | 164 +++ 1 file changed, 82

Re: [Qemu-devel] [RISU PATCH 00/10] Initial support for SVE

2017-11-08 Thread Alex Bennée
Dave Martin writes: > On Tue, Nov 07, 2017 at 03:05:48PM +, Alex Bennée wrote: >> Hi, >> >> These patches apply on-top of the last clean-up series: >> >> Subject: [RISU PATCH 0/7] Add @Group support and some aarch64.risu cleanups >> Date: Tue, 31 Oct 2017 14:54:37 + >> Message-Id:

Re: [Qemu-devel] [RISU PATCH 06/10] configure: support CPPFLAGS

2017-11-08 Thread Alex Bennée
Dave Martin writes: > On Tue, Nov 07, 2017 at 03:05:54PM +, Alex Bennée wrote: >> Useful for accessing API's that are still brewing, e.g: >> >> CROSS_PREFIX=aarch64-linux-gnu- \ >> CPPFLAGS=-I/home/alex/lsrc/qemu/risu.git/sve-headers/include \ >> ../configure >> >> Signed-off-by: A

Re: [Qemu-devel] [PATCH 1/1] s390x/pci: let pci devices start in configured mode

2017-11-08 Thread Cornelia Huck
On Tue, 7 Nov 2017 18:54:55 +0100 Christian Borntraeger wrote: > Currently, to enable a pci device in the guest, the user has to issue > echo 1 > /sys/bus/pci/slots//power. This is not what people > expect. On an LPAR, the user can put a PCI device in configured or > deconfigured state v

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-08 Thread Thomas Huth
OK, so this was "only" the TCG-interpreter that was causing the sparc64 problem here. Since there are known issues with the TCG-interpreter on certain architectures, this is not really related to the prom-env-test. And since the fix for the original "ERROR:tests/libqtest.c:628:qtest_get_arch: asser

Re: [Qemu-devel] [RFC v3 23/27] qmp: isolate responses into io thread

2017-11-08 Thread Fam Zheng
On Wed, 11/08 15:31, Peter Xu wrote: > On Tue, Nov 07, 2017 at 03:57:08PM +0800, Fam Zheng wrote: > > On Mon, 11/06 17:46, Peter Xu wrote: > > > @@ -4294,6 +4366,11 @@ static GMainContext *monitor_io_context_get(void) > > > return iothread_get_g_main_context(mon_global.mon_iothread); > > > }

Re: [Qemu-devel] [RFC v3 10/27] monitor: create monitor dedicate iothread

2017-11-08 Thread Fam Zheng
On Wed, 11/08 15:25, Peter Xu wrote: > On Tue, Nov 07, 2017 at 03:11:31PM +0800, Fam Zheng wrote: > > On Mon, 11/06 17:46, Peter Xu wrote: > > > +static GMainContext *monitor_io_context_get(void) > > > +{ > > > +return iothread_get_g_main_context(mon_global.mon_iothread); > > > +} > > > + > > >

Re: [Qemu-devel] [PATCH v5 0/4] xenfb: Enablement for Windows PV HID frontend

2017-11-08 Thread Owen Smith
I'd imagine this would be merged via the Xen queue, as it primarily deals with the xen backend Owen > -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: 08 November 2017 10:21 > To: Owen Smith > Cc: sstabell...@kernel.org; Anthony Perard ; > qemu-devel@nongnu.or

Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] spapr_pci: fix the path while fetching loc-code from host DT

2017-11-08 Thread Greg Kurz
On Tue, 7 Nov 2017 18:48:58 +0530 Seeteena Thoufeek wrote: > The function spapr_phb_vfio_get_loc_code uses wrong path for > fetching loc-code from host DT > Why is it wrong ? Are you experiencing actual issues ? > this is the call that needs to be fixed: > /* Construct and read from host devi

[Qemu-devel] [PATCH for-2.12 2/2] xlnx-zynqmp: add the timers

2017-11-08 Thread KONRAD Frederic
This adds the TTC to the xlnx-zynqmp board according to the ultrascale TRM. Signed-off-by: KONRAD Frederic --- hw/arm/xlnx-zynqmp.c | 25 + include/hw/arm/xlnx-zynqmp.h | 3 +++ 2 files changed, 28 insertions(+) diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zy

[Qemu-devel] [PATCH for-2.12 0/2] Add the TTC to the xlnx-zynqmp board

2017-11-08 Thread KONRAD Frederic
Hi, This serie adds the TTC timers to the xlnx-zynqmp board required to boot some os. It seems that the waveform feature is not implemented but since that's not directly software visible it is not an issue. An other limitation is that the frequency is fixed and should be configurable through the z

Re: [Qemu-devel] [RFC v3 10/27] monitor: create monitor dedicate iothread

2017-11-08 Thread Peter Xu
On Wed, Nov 08, 2017 at 07:18:44PM +0800, Fam Zheng wrote: > On Wed, 11/08 15:25, Peter Xu wrote: > > On Tue, Nov 07, 2017 at 03:11:31PM +0800, Fam Zheng wrote: > > > On Mon, 11/06 17:46, Peter Xu wrote: > > > > +static GMainContext *monitor_io_context_get(void) > > > > +{ > > > > +return iothr

[Qemu-devel] [PATCH for-2.12 1/2] cadence_ttc: extract CadenceTTCState to a new header file

2017-11-08 Thread KONRAD Frederic
We want to add this model to the xlnx-zynqmp board so let's make CadenceTTCState available in an header file. Signed-off-by: KONRAD Frederic --- hw/timer/cadence_ttc.c | 35 +--- include/hw/timer/cadence_ttc.h | 61 ++ 2 files c

Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

2017-11-08 Thread Thomas Huth
On 08.11.2017 03:28, Philippe Mathieu-Daudé wrote: > Both are deprecated since 2.9.0 > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc_piix.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index f79d5cb694..c462b702ff 100644 > --- a

Re: [Qemu-devel] [PATCH v3 2/7] block/ssh: make compliant with coding guidelines

2017-11-08 Thread Richard W.M. Jones
On Tue, Nov 07, 2017 at 05:27:19PM -0500, Jeff Cody wrote: > Signed-off-by: Jeff Cody > Reviewed-by: Eric Blake This one is just simple coding style fixes, so: Reviewed-by: Richard W.M. Jones Rich. > block/ssh.c | 32 ++-- > 1 file changed, 18 insertions(+), 14 d

Re: [Qemu-devel] [PATCH v3 1/7] block/ssh: don't call libssh2_init() in block_init()

2017-11-08 Thread Richard W.M. Jones
On Tue, Nov 07, 2017 at 05:27:18PM -0500, Jeff Cody wrote: > We don't need libssh2 failure to be fatal (we could just opt to not > register the driver on failure). But, it is probably a good idea to > avoid external library calls during the block_init(), and call the > libssh2 global init function

Re: [Qemu-devel] [PATCH v3 5/7] block/curl: check error return of curl_global_init()

2017-11-08 Thread Richard W.M. Jones
On Tue, Nov 07, 2017 at 05:27:22PM -0500, Jeff Cody wrote: > If curl_global_init() fails, per the documentation no other curl > functions may be called, so make sure to check the return value. > > Also, some minor changes to the initialization latch variable 'inited': > > - Make it static in the

Re: [Qemu-devel] [RISU PATCH 10/10] risu_reginfo_aarch64: add SVE support to reginfo_dump_mismatch

2017-11-08 Thread Alex Bennée
Dave Martin writes: > On Tue, Nov 07, 2017 at 03:05:58PM +, Alex Bennée wrote: >> Signed-off-by: Alex Bennée >> --- >> risu_reginfo_aarch64.c | 49 >> + >> 1 file changed, 49 insertions(+) >> >> diff --git a/risu_reginfo_aarch64.c b/risu_reg

Re: [Qemu-devel] [PATCH] qcow2: don't permit changing encryption parameters

2017-11-08 Thread Kevin Wolf
Am 03.11.2017 um 15:39 hat Daniel P. Berrange geschrieben: > Currently if trying to change encryption parameters on a qcow2 image, qemu-img > will abort. We already explicitly check for attempt to change encrypt.format > but missed other parameters like encrypt.key-secret. Rather than list each > p

Re: [Qemu-devel] [PATCH v3 6/7] block/curl: fix minor memory leaks

2017-11-08 Thread Richard W.M. Jones
On Tue, Nov 07, 2017 at 05:27:23PM -0500, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > block/curl.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/block/curl.c b/block/curl.c > index 00a9879..35cf417 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -857,6 +857,9 @@ ou

Re: [Qemu-devel] [PATCH v3 7/7] block/curl: code cleanup to comply with coding style

2017-11-08 Thread Richard W.M. Jones
On Tue, Nov 07, 2017 at 05:27:24PM -0500, Jeff Cody wrote: > This addresses non-functional changes to help curl.c better comply > with the coding styles (comments, indentation, brackets, etc.). > > One minor code change is the combination of two if statements into > a single if statement. > > Sig

Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option

2017-11-08 Thread Ian Jackson
Markus Armbruster writes ("Re: [Qemu-devel] [PATCH 7/8] os-posix: Provide new -runasid option"): > Ian Jackson writes: > > qemu_strtoul fails (returns an error) if the delimiter (that is, the > > first character which is not processed as digit by strtoul) is not > > '\0'. > > It does that *only*

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Thomas Huth
On 08.11.2017 11:53, Gerd Hoffmann wrote: > On Wed, Nov 08, 2017 at 10:57:21AM +0100, Thomas Huth wrote: >> >> That automatic git submodule stuff now broke my workflow again. I >> usually keep the git repository on my laptop and then simply rsync the >> sources (without .git directories) to my targ

Re: [Qemu-devel] [qemu-s390x] [PATCH] target/s390x: Finish implementing RISBGN

2017-11-08 Thread Cornelia Huck
On Tue, 7 Nov 2017 15:55:46 +0100 Richard Henderson wrote: > We added the entry to insn-data.def, but failed to update op_risbg > to match. No need to special-case the imask inversion, since that > is already ~0 for RISBG (and now RISBGN). > > Fixes: 375ee58bedcda359011fe7fa99e0647f66f9ffa0 >

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Kevin Wolf
Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: > On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: > > On 07/11/2017 18:39, Daniel P. Berrange wrote: > > > On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wolf wrote: > > >> bdrv_set_read_only() is used by some block drivers

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

2017-11-08 Thread Mihail Abakumov
Ladi Prosek писал 2017-11-06 18:15: On Mon, Oct 23, 2017 at 10:31 AM, Ladi Prosek wrote: On Tue, Oct 17, 2017 at 3:08 PM, Mihail Abakumov wrote: An update of: v1: https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07092.html We made the debugger module WinDbg (like GDB) f

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Paolo Bonzini
On 08/11/2017 12:51, Kevin Wolf wrote: > Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: >> On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: >>> I am not sure this counts as deprecation, but it should go in the >>> release notes as "future incompatible changes", and that se

Re: [Qemu-devel] [PULL 2/3] ui/cocoa.m: move ungrab to ctrl-alt-g

2017-11-08 Thread Programmingkid
> On Nov 7, 2017, at 5:16 AM, Peter Maydell wrote: > > From: John Arbuckle > > Currently the cocoa user interface relis on the user pushing I would change "relis" to "relies" here. > control-alt to ungrab the mouse. This is patch changes the key > combination to control-alt-g to be in line

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Michal Suchánek
On Wed, 8 Nov 2017 10:25:29 + "Daniel P. Berrange" wrote: > On Wed, Nov 08, 2017 at 10:57:21AM +0100, Thomas Huth wrote: > > > > That automatic git submodule stuff now broke my workflow again. I > > usually keep the git repository on my laptop and then simply rsync > > the sources (without .

[Qemu-devel] [PATCH 0/1] qcow2: Check that corrupted images can be repaired in iotest 060

2017-11-08 Thread Alberto Garcia
Hi, I sent the 'Misc qcow2 corruption checks' series the other day, and Kevin suggested that we check that the corrupted images can be repaired using qemu-img. This patch extends the tests that I wrote in order to do just that. Since the series is already in Max's branch I decided to write this a

[Qemu-devel] [PATCH 1/1] qcow2: Check that corrupted images can be repaired in iotest 060

2017-11-08 Thread Alberto Garcia
We just fixed a few bugs that caused QEMU to crash when trying to write to corrupted qcow2 images, and iotest 060 was expanded to test all those scenarios. In almost all cases the corrupted images can be repaired using qemu-img, so this patch verifies that. Signed-off-by: Alberto Garcia --- tes

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Kevin Wolf
Am 08.11.2017 um 13:00 hat Paolo Bonzini geschrieben: > On 08/11/2017 12:51, Kevin Wolf wrote: > > Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: > >> On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: > >>> I am not sure this counts as deprecation, but it should go in the >

Re: [Qemu-devel] [Qemu-block] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Kevin Wolf
Am 08.11.2017 um 11:04 hat Kevin Wolf geschrieben: > Am 07.11.2017 um 21:29 hat Eric Blake geschrieben: > > On 11/07/2017 11:26 AM, Kevin Wolf wrote: > > > bdrv_set_read_only() is used by some block drivers to override the > > > read-only option given by the user. This is not how read-only images >

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/08/2017 06:57 AM, Thomas Huth wrote: > > That automatic git submodule stuff now broke my workflow again. I > usually keep the git repository on my laptop and then simply rsync the > sources (without .git directories) to my target machine to compile it > there. Used to work great for years. N

Re: [Qemu-devel] [PATCH] util/async: use atomic_mb_set in qemu_bh_cancel

2017-11-08 Thread Stefan Hajnoczi
On Tue, Nov 07, 2017 at 04:09:37PM +0100, Sergio Lopez wrote: > Commit b7a745d added a qemu_bh_cancel call to the completion function > as an optimization to prevent it from unnecessarily rescheduling itself. > > This completion function is scheduled from worker_thread, after setting > the state o

Re: [Qemu-devel] [Qemu-block] [PATCH v3] util/async: use atomic_mb_set in qemu_bh_cancel

2017-11-08 Thread Stefan Hajnoczi
On Wed, Nov 08, 2017 at 07:34:47AM +0100, Sergio Lopez wrote: > Commit b7a745d added a qemu_bh_cancel call to the completion function > as an optimization to prevent it from unnecessarily rescheduling itself. > > This completion function is scheduled from worker_thread, after setting > the state o

[Qemu-devel] [PULL for-2.11-rc1 0/2] Block patches

2017-11-08 Thread Stefan Hajnoczi
The following changes since commit b0fbe46ad82982b289a44ee2495b59b0bad8a842: Update version for v2.11.0-rc0 release (2017-11-07 16:05:28 +) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 161d53bbed2be4c43

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 12:51:27PM +0100, Kevin Wolf wrote: > Am 08.11.2017 um 11:49 hat Daniel P. Berrange geschrieben: > > On Wed, Nov 08, 2017 at 11:44:01AM +0100, Paolo Bonzini wrote: > > > On 07/11/2017 18:39, Daniel P. Berrange wrote: > > > > On Tue, Nov 07, 2017 at 06:26:38PM +0100, Kevin Wo

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 01:05:27PM +0100, Michal Suchánek wrote: > On Wed, 8 Nov 2017 10:25:29 + > "Daniel P. Berrange" wrote: > > > On Wed, Nov 08, 2017 at 10:57:21AM +0100, Thomas Huth wrote: > > > > > > That automatic git submodule stuff now broke my workflow again. I > > > usually keep t

Re: [Qemu-devel] [Qemu-arm] [PATCH] arm/translate-a64: mark path as unreachable to eliminate warning

2017-11-08 Thread Philippe Mathieu-Daudé
On 11/07/2017 05:46 PM, Emilio G. Cota wrote: > Fixes the following warning when compiling with gcc 5.4.0 with -O1 > optimizations and --enable-debug: > > target/arm/translate-a64.c: In function ‘aarch64_tr_translate_insn’: > target/arm/translate-a64.c:2361:8: error: ‘post_index’ may be used > un

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Michal Suchánek
On Wed, 8 Nov 2017 12:34:17 + "Daniel P. Berrange" wrote: > On Wed, Nov 08, 2017 at 01:05:27PM +0100, Michal Suchánek wrote: > > On Wed, 8 Nov 2017 10:25:29 + > > "Daniel P. Berrange" wrote: > > > > > On Wed, Nov 08, 2017 at 10:57:21AM +0100, Thomas Huth wrote: > > > > > > > > That

Re: [Qemu-devel] [PATCH] AMD Processor Topology Information

2017-11-08 Thread Philippe Mathieu-Daudé
Hi Stanislav, This does not seem so trivial ;) Cc'ing more reviewers. On 11/03/2017 02:30 PM, Stanislav Lanci wrote: > V2: > Adds information about cache size and topology on leaf 0x801D for family > 17h > Without the added cache topology guest with SMT suffers latency problems > > Add CPU

Re: [Qemu-devel] [PATCH] gtk: fix wrong id between texture and framebuffer

2017-11-08 Thread Philippe Mathieu-Daudé
Hi Anthoine, Cc'ing Gerd Hoffmann who is the maintainer of this file. See https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer: $ ./scripts/get_maintainer.pl -f ui/gtk-gl-area.c Gerd Hoffmann (odd fixer:Graphics) On 10/02/2017 09:40 AM, Anthoine Bourgeois wrote: > From: Ant

Re: [Qemu-devel] [PATCH v2] gitignore: ignore check-qlit test

2017-11-08 Thread Philippe Mathieu-Daudé
On 09/26/2017 06:07 PM, Carlo Marcelo Arenas Belón wrote: > test introduced in 382176b4d78e070d119af8e0dcd00884c11bbec2 > > Signed-off-by: Carlo Marcelo Arenas Belón > Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé > --- > tests/.gitignore | 1 + > 1 file changed, 1 insertion(+)

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 01:43:15PM +0100, Michal Suchánek wrote: > On Wed, 8 Nov 2017 12:34:17 + > "Daniel P. Berrange" wrote: > > > On Wed, Nov 08, 2017 at 01:05:27PM +0100, Michal Suchánek wrote: > > > On Wed, 8 Nov 2017 10:25:29 + > > > "Daniel P. Berrange" wrote: > > > > > > > On

Re: [Qemu-devel] [U-Boot] Support of latest qemux86-64

2017-11-08 Thread Anton Gerasimov
To whoever might be interested: I've bisected qemu and the breaking commit is 208fa0e43645edd0b0d8f838857dfc79daff40a8 (pc: make 'pc.rom' readonly when machine has PCI enabled). It's just three lines added, I'll paste the whole patch here. Not quite sure what can we do here though.   diff --git a

Re: [Qemu-devel] [PATCH v6 18/25] block: Add sgfnt_runtime_opts to BlockDriver

2017-11-08 Thread Alberto Garcia
On Thu 02 Nov 2017 05:18:31 PM CET, Max Reitz wrote: > On 2017-11-02 17:11, Alberto Garcia wrote: >> On Fri 29 Sep 2017 06:53:40 PM CEST, Max Reitz wrote: >>> QLIST_ENTRY(BlockDriver) list; >>> + >>> +/* Pointer to a NULL-terminated array of names of significant options >>> that >>> +

Re: [Qemu-devel] Yet another git submodule rant

2017-11-08 Thread Daniel P. Berrange
On Wed, Nov 08, 2017 at 09:26:01AM -0300, Philippe Mathieu-Daudé wrote: > On 11/08/2017 06:57 AM, Thomas Huth wrote: > > > > That automatic git submodule stuff now broke my workflow again. I > > usually keep the git repository on my laptop and then simply rsync the > > sources (without .git direct

  1   2   3   4   >