[Qemu-devel] [Bug 1383857] Re: aarch64: virtio disks don't show up in guest (neither blk nor scsi)

2017-11-07 Thread Peter Maydell
** Changed in: qemu Status: Incomplete => Fix Committed ** Changed in: qemu Status: Fix Committed => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1383857 Title: aarch64

Re: [Qemu-devel] [PATCH v2 2/2] Add new PCI ID for i82559a

2017-11-07 Thread Michael Nawrocki
On 11/07/2017 11:12 AM, Michael S. Tsirkin wrote: On Mon, Nov 06, 2017 at 03:35:20PM -0500, Mike Nawrocki wrote: Adds a new PCI ID for the i82559a (0x8086 0x1030) interface. Enables this ID with a new property "use-alt-device-id" to preserve compatibility. Signed-off-by: Mike Nawrocki ---

[Qemu-devel] [PATCH v3 1/2] Fix eepro100 simple transmission mode

2017-11-07 Thread Mike Nawrocki
The simple transmission mode was treating the area immediately after the transmit command block (TCB) as if it were a transmit buffer descriptor, when in reality it is simply the packet data. This change simply copies the data following the TCB into the packet buffer. Signed-off-by: Mike Nawrocki

[Qemu-devel] [PATCH v3 0/2] Fix eepro100 simple transmission, add i82559 PCI ID

2017-11-07 Thread Mike Nawrocki
This patch set does two things. First, it fixes the simple transmission mode for the eepro100 chipset. Second, it adds the PCI device ID 0x1030 for the i82559a chipset. This ID is set as the "alternate" PCI device ID for that chipset, and is selected by default using the new "x-use-alternate-device

[Qemu-devel] [PATCH v3 2/2] Add new PCI ID for i82559a

2017-11-07 Thread Mike Nawrocki
Adds a new PCI ID for the i82559a (0x8086 0x1030) interface. The "x-use-alt-device-id" property controls whether this new ID is to be used, and is true by default, and set to false in a compat entry. Signed-off-by: Mike Nawrocki --- hw/net/eepro100.c| 13 + include/hw/compat.h |

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-07 Thread Peter Maydell
v2 of the patch (https://lists.gnu.org/archive/html/qemu- devel/2017-11/msg01199.html) has been accepted upstream, though it isn't in master yet. ** Tags added: linux-user ** Changed in: qemu Status: New => In Progress -- You received this bug notification because you are a member of qe

[Qemu-devel] [Bug 1728116] Re: Empty /proc/self/auxv (linux-user)

2017-11-07 Thread Peter Maydell
I've just sent this patch which fixes this bug: https://lists.gnu.org/archive/html/qemu-devel/2017-11/msg01199.html (it turns out it wasn't quite as simple as getting the sign wrong, we were subtracting two things that were totally wrong). ** Changed in: qemu Status: Confirmed => In Progr

Re: [Qemu-devel] [PATCH] accel/tcg/translate-all: expand cpu_restore_state retaddr check

2017-11-07 Thread Alex Bennée
Peter Maydell writes: > On 7 November 2017 at 16:52, Alex Bennée wrote: >> We are still seeing signals during translation time when we walk over >> a page protection boundary. This expands the check to ensure the >> retaddr is inside the code generation buffer. The original suggestion >> was to

Re: [Qemu-devel] [PATCH] accel/tcg/translate-all: expand cpu_restore_state retaddr check

2017-11-07 Thread Peter Maydell
On 7 November 2017 at 18:45, Alex Bennée wrote: > > Peter Maydell writes: > >> On 7 November 2017 at 16:52, Alex Bennée wrote: >>> We are still seeing signals during translation time when we walk over >>> a page protection boundary. This expands the check to ensure the >>> retaddr is inside the

Re: [Qemu-devel] [PATCH v3 0/2] Fix eepro100 simple transmission, add i82559 PCI ID

2017-11-07 Thread Michael S. Tsirkin
On Tue, Nov 07, 2017 at 01:35:01PM -0500, Mike Nawrocki wrote: > This patch set does two things. First, it fixes the simple transmission mode > for the eepro100 chipset. Second, it adds the PCI device ID 0x1030 for the > i82559a chipset. This ID is set as the "alternate" PCI device ID for that > ch

[Qemu-devel] [Bug 1080086] Re: MC146818 RTC breaks when SET bit in Register B is on.

2017-11-07 Thread Peter Maydell
We fixed this bug long ago in 2012, in commit 02c6ccc6dde90d (thanks for your patch!) but forgot to close the bug...so I'm doing it now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed t

[Qemu-devel] [PATCH v1 2/2] xlnx-zcu102: Add an info message deprecating the EP108

2017-11-07 Thread Alistair Francis
The EP108 was an early access development board that is no longer used. Add an info message to convert any users to the ZCU102 instead. On QEMU they are both identical. Signed-off-by: Alistair Francis --- hw/arm/xlnx-zcu102.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/arm/xlnx-zc

[Qemu-devel] [PATCH v1 0/2] Xilinx ZCU102 fixes for 2.11

2017-11-07 Thread Alistair Francis
These are two small fixes for 2.11. Alistair Francis (2): xlnx-zynqmp: Properly support the smp command line option xlnx-zcu102: Add an info message deprecating the EP108 hw/arm/xlnx-zcu102.c | 6 +- hw/arm/xlnx-zynqmp.c | 26 -- 2 files changed, 21 insertions(+)

[Qemu-devel] [Bug 1426593] Re: linux-user: doesn't handle guest setting its memory ulimit very small

2017-11-07 Thread Peter Maydell
*** This bug is a duplicate of bug 1163034 *** https://bugs.launchpad.net/bugs/1163034 I've just noticed that this is a duplicate of bug 1163034 (gnutls uses a very similar configure test), so I'm going to mark this one as a dup of that one, since it's older. ** This bug has been marked a du

[Qemu-devel] [Bug 1163034] Re: linux-user mode can't handle guest setting a very small RLIMIT_AS (hangs running gnutls28, coreutils configure check code)

2017-11-07 Thread Peter Maydell
** Summary changed: - linux-user mode can't handle guest setting RLIMIT_AS (hangs running gnutls28 configure check code) + linux-user mode can't handle guest setting a very small RLIMIT_AS (hangs running gnutls28, coreutils configure check code) ** Tags added: linux-user -- You received this

[Qemu-devel] [Bug 1133668] Re: Bad validate ELF MIPSel format

2017-11-07 Thread Peter Maydell
To copy the information out of that web page for posterity: the problem is that we weren't able to execute ELF files in linux-user if they had had the section table stripped out of them. We fixed this in the way suggested in that web page, by simply not checking the section header size, since we d

[Qemu-devel] [Bug 1165383] Re: executable qemu-1.4.0/i386-linux-user/./qemu-i386 gives a segmentation fault

2017-11-07 Thread Peter Maydell
I'm going to close this bug, since there was no response to the 2013 request for more detail. If you're still having problems with QEMU, please open a fresh bug report. ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- deve

[Qemu-devel] [Bug 1156313] Re: X86-64 flags handling broken

2017-11-07 Thread Peter Maydell
It looks from this bug that we fixed the initial ADOX bug in commit c53de1a2896cc (2013), and I've just tried the 'qemu-denorm-problem.s' test case from comment #1 and it works OK, so I think we've fixed that denormals bug too. Given that, and that this bug report is 4 years old, I'm going to close

[Qemu-devel] [Bug 1726394] Re: Passes through prctl(PR_SET_SECCOMP, SECCOMP_MODE_FILTER, address)

2017-11-07 Thread Julian Andres Klode
@pmaydell It's actually https://lists.gnu.org/archive/html/qemu- devel/2017-11/msg00828.html :) @paelzer It mostly depends how people run a apt 1.6 foreign architecture chroot with the same pointer size as the host architecture - if they install qemu-user inside the chroot, they're fine, if the

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-07 Thread Eduardo Habkost
On Mon, Nov 06, 2017 at 04:54:54PM -0500, Emilio G. Cota wrote: > On Mon, Nov 06, 2017 at 12:10:22 -0200, Eduardo Habkost wrote: > > On Fri, Nov 03, 2017 at 06:24:07PM -0400, Emilio G. Cota wrote: > > > /** > > > * MachineClass: > > > * @max_cpus: maximum number of CPUs supported. Default: 1 >

Re: [Qemu-devel] [PATCH v2] s390x/cpu: expose the guest crash information

2017-11-07 Thread Eric Blake
On 11/07/2017 05:00 AM, QingFeng Hao wrote: >>> + >>> +## >>> +# @GuestPanicInformationS390: >>> +# >>> +# S390 specific guest panic information (PSW) >>> +# >>> +# Since: 2.11 >>> +## >>> +{'struct': 'GuestPanicInformationS390', >>> + 'data': { 'psw-mask': 'uint64', >>> +   'psw-addr': 'u

Re: [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

2017-11-07 Thread Eric Blake
On 11/07/2017 04:12 AM, Markus Armbruster wrote: > Juan Quintela writes: > >> Alistair Francis wrote: >>> Replace all occurs of __FUNCTION__ except for the check in checkpatch >>> with the non GCC specific __func__. >>> >>> +++ b/audio/audio_int.h >>> @@ -253,7 +253,7 @@ static inline int audio

Re: [Qemu-devel] [Resend][PATCH] qapi-docs: fix a comment typo

2017-11-07 Thread Michael Roth
Quoting Michael Roth (2017-11-07 11:06:55) > Quoting Chen Hanxiao (2017-11-07 05:37:16) > > From: Chen Hanxiao > > > > s/Subection/Subsection > > > > Reviewed-by: Marc-André Lureau > > Signed-off-by: Chen Hanxiao > > Thanks, applied to qga tree: > https://github.com/mdroth/qemu/commits/qg

Re: [Qemu-devel] [PATCH v2] crypto: afalg: fix a NULL pointer dereference

2017-11-07 Thread Eric Blake
On 11/07/2017 05:32 AM, Longpeng(Mike) wrote: > From: Longpeng > > Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with > errp=NULL, this will cause a NULL pointer deference if afalg_driver s/deference/dereference/ (I called out two typo fixes against v1, but you only fixed one of them

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-07 Thread Alistair Francis
On Tue, Nov 7, 2017 at 11:32 AM, Eduardo Habkost wrote: > On Mon, Nov 06, 2017 at 04:54:54PM -0500, Emilio G. Cota wrote: >> On Mon, Nov 06, 2017 at 12:10:22 -0200, Eduardo Habkost wrote: >> > On Fri, Nov 03, 2017 at 06:24:07PM -0400, Emilio G. Cota wrote: >> > > /** >> > > * MachineClass: >> >

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-07 Thread Eduardo Habkost
On Tue, Nov 07, 2017 at 11:48:13AM -0800, Alistair Francis wrote: > On Tue, Nov 7, 2017 at 11:32 AM, Eduardo Habkost wrote: > > On Mon, Nov 06, 2017 at 04:54:54PM -0500, Emilio G. Cota wrote: > >> On Mon, Nov 06, 2017 at 12:10:22 -0200, Eduardo Habkost wrote: > >> > On Fri, Nov 03, 2017 at 06:24:0

Re: [Qemu-devel] [PATCH v1 1/2] xlnx-zynqmp: Properly support the smp command line option

2017-11-07 Thread Eduardo Habkost
On Tue, Nov 07, 2017 at 10:59:39AM -0800, Alistair Francis wrote: > Allow the -smp command line option to control the number of CPUs we > create. > > Signed-off-by: Alistair Francis > --- > > hw/arm/xlnx-zcu102.c | 3 ++- > hw/arm/xlnx-zynqmp.c | 26 -- > 2 files change

Re: [Qemu-devel] [PATCH 0/4] linux-user: fix various SIGSEGV delivery bugs

2017-11-07 Thread Riku Voipio
On Mon, Nov 06, 2017 at 06:33:22PM +, Peter Maydell wrote: > This patchset fixes most of the problems with delivering SIGSEGV > noted in https://bugs.launchpad.net/qemu/+bug/1705118: > * s390x is missing masking operations on the fault address >passed to the guest in si_addr > * ppc is pa

Re: [Qemu-devel] [PATCH v1 1/2] xlnx-zynqmp: Properly support the smp command line option

2017-11-07 Thread Alistair Francis
On Tue, Nov 7, 2017 at 12:00 PM, Eduardo Habkost wrote: > On Tue, Nov 07, 2017 at 10:59:39AM -0800, Alistair Francis wrote: >> Allow the -smp command line option to control the number of CPUs we >> create. >> >> Signed-off-by: Alistair Francis >> --- >> >> hw/arm/xlnx-zcu102.c | 3 ++- >> hw/ar

Re: [Qemu-devel] [PATCH v2] linux-user: fix is_proc_myself to check the paths via realpath

2017-11-07 Thread Riku Voipio
Hi, On Mon, Nov 06, 2017 at 08:17:44PM +, Zach Riggle wrote: > Ping! What needs to be done to move this forward? My current implementation > is compatible with musl. I'll have a look at it soon. Riku > On Thu, Nov 2, 2017 at 12:36 PM Peter Maydell > wrote: > > > On 28 October 2017 at 06:1

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-07 Thread R.Nageswara Sastry
After talking to Mark Cave-Ayland over e-mail, to make sure I have the proper versions of OpenBIOS binaries - removed the existing git tree and with a fresh clone not seeing the 'qemu-system-sparc64' related crash. Before cleanup I was seeing the crash all the times. Thanks!! -- You received th

Re: [Qemu-devel] [Qemu-block] [PATCH v2] throttle: fix a qemu crash problem when calling blk_delete

2017-11-07 Thread Manos Pitsidianakis
On Fri, Nov 03, 2017 at 02:26:33PM +, Stefan Hajnoczi wrote: On Wed, Oct 25, 2017 at 10:40:47AM +0200, Alberto Garcia wrote: On Tue 24 Oct 2017 05:33:51 AM CEST, sochin jiang wrote: > --- a/block/throttle-groups.c > +++ b/block/throttle-groups.c > @@ -576,7 +576,9 @@ void throttle_group_unre

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-07 Thread Eduardo Habkost
On Fri, Nov 03, 2017 at 02:47:33PM -0400, Emilio G. Cota wrote: > max_cpus needs to be an upper bound on the number of vCPUs > initialized; otherwise TCG region initialization breaks. > > Some boards initialize a hard-coded number of vCPUs, which is not > captured by the global max_cpus. Fix it by

[Qemu-devel] [ANNOUNCE] QEMU 2.11.0-rc0 is now available

2017-11-07 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the first release candidate for the QEMU 2.11 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.11.0-rc0.tar.xz http://dow

Re: [Qemu-devel] [PATCH v1 1/2] xlnx-zynqmp: Properly support the smp command line option

2017-11-07 Thread Eduardo Habkost
On Tue, Nov 07, 2017 at 12:04:18PM -0800, Alistair Francis wrote: > On Tue, Nov 7, 2017 at 12:00 PM, Eduardo Habkost wrote: > > On Tue, Nov 07, 2017 at 10:59:39AM -0800, Alistair Francis wrote: > >> Allow the -smp command line option to control the number of CPUs we > >> create. > >> > >> Signed-o

Re: [Qemu-devel] [PATCH] block: Deprecate bdrv_set_read_only() and users

2017-11-07 Thread Eric Blake
On 11/07/2017 11:26 AM, Kevin Wolf wrote: > bdrv_set_read_only() is used by some block drivers to override the > read-only option given by the user. This is not how read-only images > generally work in QEMU: Instead of second guessing what the user really > meant (which currently includes making an

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-07 Thread R.Nageswara Sastry
Some times it's still puzzling, when I got the clean git tree still seeing crash with correct OpenBIOS file. [root@zzfp365-lp1 test]# git clone git://git.qemu.org/qemu.git Cloning into 'qemu'... remote: Counting objects: 349636, done. remote: Compressing objects: 100% (66763/66763), done. remote:

[Qemu-devel] [PATCH] arm/translate-a64: mark path as unreachable to eliminate warning

2017-11-07 Thread Emilio G. Cota
Fixes the following warning when compiling with gcc 5.4.0 with -O1 optimizations and --enable-debug: target/arm/translate-a64.c: In function ‘aarch64_tr_translate_insn’: target/arm/translate-a64.c:2361:8: error: ‘post_index’ may be used uninitialized in this function [-Werror=maybe-uninitialized]

[Qemu-devel] [PATCH for-2.11] scripts/make-release: ship u-boot source as a tarball

2017-11-07 Thread Michael Roth
The u-boot sources we ship currently cause problems with unpacking on a case-insensitive filesystem due to path conflicts. This has been fixed in upstream u-boot via commit 610eec7f, but since it is not yet included in an official release we implement this approach as a temporary workaround. Once

[Qemu-devel] [Bug 1725267] Re: armeb regression since qemu version 2.8

2017-11-07 Thread Christophe Lyon
Great, thanks! -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1725267 Title: armeb regression since qemu version 2.8 Status in QEMU: Fix Committed Bug description: Hi, I have noticed a regr

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2017-11-07 Thread Bruno Haible
c64 hello.sparc64 Segmentation fault (core dumped) $ QEMU_LD_PREFIX=/usr/sparc64-linux-gnu ~/inst-qemu/2.10+-20171107/bin/qemu-sparc64 hello.sparc64 Segmentation fault (core dumped) $ QEMU_LD_PREFIX=/usr/mips-linux-gnu ~/inst-qemu/2.9.0/bin/qemu-mips hello.mips qemu: uncaught target signal

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2017-11-07 Thread Bruno Haible
you identified as a different issue): $ QEMU_LD_PREFIX=/usr/sparc64-linux-gnu ~/inst-qemu/2.10+-20171107/bin/qemu-sparc64 hello.sparc64 Hello world $ QEMU_LD_PREFIX=/usr/mips-linux-gnu ~/inst-qemu/2.10+-20171107/bin/qemu-mips hello.mips Hello world $ QEMU_LD_PREFIX=/usr/mips64-linux-gnuabi64 ~/inst-qem

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2017-11-07 Thread Peter Maydell
That patch would prevent us from picking up a legitimate ld.so.cache for the guest (in a chroot, for instance), so I don't think we should take it. (I'm also not a fan of trying to work around specific guest code issues: I'd much rather this was just fixed in ld.so where it ought to be, so I'd enco

[Qemu-devel] [PATCH v3 3/7] block/sheepdog: remove spurious NULL check

2017-11-07 Thread Jeff Cody
'tag' is already checked in the lines immediately preceding this check, and set to non-NULL if NULL. No need to check again, it hasn't changed. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake --- block/sheepdog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/sheepd

[Qemu-devel] [PATCH v3 0/7] Code cleanup and minor fixes (for 2.11)

2017-11-07 Thread Jeff Cody
Changes from v2 -> v3: Patch 1: Return -EIO for ssh_state_init() (Thanks Eric) Patch 4: fixed missed line (Thanks Eric) Patch 7: fixed opaque pointer assignment (Thanks Eric) git-backport-diff -r master.. -u 81fb084 001/7:[0007] [FC] 'block/ssh: don't call libssh2_init() in block_init()' 002/7:[

[Qemu-devel] [PATCH v3 4/7] block/sheepdog: code beautification

2017-11-07 Thread Jeff Cody
No functional changes, just whitespace manipulation. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake --- block/sheepdog.c | 164 +++ 1 file changed, 82 insertions(+), 82 deletions(-) diff --git a/block/sheepdog.c b/block/sheepdog.c index 459

[Qemu-devel] [PATCH v3 6/7] block/curl: fix minor memory leaks

2017-11-07 Thread Jeff Cody
Signed-off-by: Jeff Cody --- block/curl.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/block/curl.c b/block/curl.c index 00a9879..35cf417 100644 --- a/block/curl.c +++ b/block/curl.c @@ -857,6 +857,9 @@ out_noclean: qemu_mutex_destroy(&s->mutex); g_free(s->cookie); g_f

[Qemu-devel] [PATCH v3 5/7] block/curl: check error return of curl_global_init()

2017-11-07 Thread Jeff Cody
If curl_global_init() fails, per the documentation no other curl functions may be called, so make sure to check the return value. Also, some minor changes to the initialization latch variable 'inited': - Make it static in the file, for clarity - Change the name for clarity - Make it a bool Signe

[Qemu-devel] [PATCH v3 1/7] block/ssh: don't call libssh2_init() in block_init()

2017-11-07 Thread Jeff Cody
We don't need libssh2 failure to be fatal (we could just opt to not register the driver on failure). But, it is probably a good idea to avoid external library calls during the block_init(), and call the libssh2 global init function on the first usage, returning any errors. Signed-off-by: Jeff Cody

[Qemu-devel] [PATCH v3 2/7] block/ssh: make compliant with coding guidelines

2017-11-07 Thread Jeff Cody
Signed-off-by: Jeff Cody Reviewed-by: Eric Blake --- block/ssh.c | 32 ++-- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/block/ssh.c b/block/ssh.c index de81ec8..39cacc1 100644 --- a/block/ssh.c +++ b/block/ssh.c @@ -241,7 +241,7 @@ static int parse

[Qemu-devel] [PATCH v3 7/7] block/curl: code cleanup to comply with coding style

2017-11-07 Thread Jeff Cody
This addresses non-functional changes to help curl.c better comply with the coding styles (comments, indentation, brackets, etc.). One minor code change is the combination of two if statements into a single if statement. Signed-off-by: Jeff Cody Reviewed-by: Eric Blake --- block/curl.c | 100 +

Re: [Qemu-devel] [PATCH] block: Close a BlockDriverState completely even when bs->drv is NULL

2017-11-07 Thread Eric Blake
On 11/06/2017 08:53 AM, Alberto Garcia wrote: > bdrv_close() skips much of its logic when bs->drv is NULL. This is > fine when we're closing a BlockDriverState that has just been created > (because e.g the initialization process failed), but it's not enough > in other cases. > > For example, when

[Qemu-devel] [PATCH] coroutine: Fix documentation of co_aio_sleep_ns()

2017-11-07 Thread Eric Blake
co_sleep_ns() was removed in commit 0b9caf9b, leaving behind a stale comment. Update the documentation to match the current usage of this function. Suggested-by: Paolo Bonzini Signed-off-by: Eric Blake --- include/qemu/coroutine.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) d

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2017-11-07 Thread Bruno Haible
> That patch would prevent us from picking up a legitimate ld.so.cache for the > guest (in a chroot, for instance), so I don't think we should take it. But in a chroot, QEMU_LD_PREFIX is most likely NOT set. So how about this pseudocode? if (strcmp (pathname, "/etc/ld.so.cache") == 0 && getenv

Re: [Qemu-devel] [PATCH v3 1/7] block/ssh: don't call libssh2_init() in block_init()

2017-11-07 Thread Eric Blake
On 11/07/2017 04:27 PM, Jeff Cody wrote: > We don't need libssh2 failure to be fatal (we could just opt to not > register the driver on failure). But, it is probably a good idea to > avoid external library calls during the block_init(), and call the > libssh2 global init function on the first usage

Re: [Qemu-devel] [PULL, 08/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2017-11-07 Thread Alexey Kardashevskiy
On 07/11/17 19:42, Laurent Vivier wrote: > On 05/07/2016 07:31, David Gibson wrote: >> From: Alexey Kardashevskiy >> >> This adds support for Dynamic DMA Windows (DDW) option defined by >> the SPAPR specification which allows to have additional DMA window(s) >> >> The "ddw" property is enabled by

[Qemu-devel] [PATCH v2] util/async: use atomic_mb_set in qemu_bh_cancel

2017-11-07 Thread Sergio Lopez
Commit b7a745d added a qemu_bh_cancel call to the completion function as an optimization to prevent it from unnecessarily rescheduling itself. This completion function is scheduled from worker_thread, after setting the state of a ThreadPoolElement to THREAD_DONE. This was considered to be safe, a

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-07 Thread Alexey Kardashevskiy
On 07/11/17 21:12, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: >>> On 04/11/17 02:33, Daniel P. Berrange wrote: We short circuit the git submodule update when passed an empty module list. >>

Re: [Qemu-devel] capstone broke mingw cross build

2017-11-07 Thread Alistair Francis
On Tue, Nov 7, 2017 at 9:53 AM, Peter Maydell wrote: > On 7 November 2017 at 17:52, Alistair Francis wrote: >> On Fri, Nov 3, 2017 at 6:40 AM, Gerd Hoffmann wrote: >>> Hi, >>> > "x86_64-w64-mingw32-ar --version" says "GNU ar (GNU Binutils) 2.25" Hmm, I guess this 'ar' isn't capa

Re: [Qemu-devel] [PATCH v3 0/5] Add a valid_cpu_types property

2017-11-07 Thread Alistair Francis
On Mon, Oct 23, 2017 at 12:26 AM, Alistair Francis wrote: > On Wed, Oct 18, 2017 at 12:31 AM, Alistair Francis > wrote: >> There are numorous QEMU machines that only have a single or a handful of >> valid CPU options. To simplyfy the management of specificying which CPU >> is/isn't valid let's cr

[Qemu-devel] [PATCH v2] configure: Deal with OpenBSD/i386 emulation linker

2017-11-07 Thread Brad Smith
OpenBSD/i386 uses elf_i386_obsd for the emulation linker. Signed-off-by: Brad Smith diff --git a/configure b/configure index dd73cce62f..c9dd747283 100755 --- a/configure +++ b/configure @@ -5159,9 +5159,9 @@ if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) -a \ "$targetos" != "Darwi

Re: [Qemu-devel] [PATCH] configure: Deal with OpenBSD/i386 emulation linker

2017-11-07 Thread Brad Smith
On Mon, Nov 06, 2017 at 11:37:45AM +, Peter Maydell wrote: > On 6 November 2017 at 00:53, Brad Smith wrote: > > OpenBSD/i386 uses elf_i386_obsd for the emulation linker. > > > > Signed-off-by: Brad Smith > > > > > > diff --git a/configure b/configure > > index dd73cce62f..02799d38ac 100755 >

Re: [Qemu-devel] [PATCH v3 6/7] block/curl: fix minor memory leaks

2017-11-07 Thread Eric Blake
On 11/07/2017 04:27 PM, Jeff Cody wrote: > Signed-off-by: Jeff Cody > --- > block/curl.c | 6 ++ > 1 file changed, 6 insertions(+) Reviewed-by: Eric Blake > > diff --git a/block/curl.c b/block/curl.c > index 00a9879..35cf417 100644 > --- a/block/curl.c > +++ b/block/curl.c > @@ -857,6 +85

Re: [Qemu-devel] [Resend][PATCH] qapi-docs: fix a comment typo

2017-11-07 Thread Chen Hanxiao
在 2017-11-08 03:43:20,"Michael Roth" 写道: >Quoting Michael Roth (2017-11-07 11:06:55) >> Quoting Chen Hanxiao (2017-11-07 05:37:16) >> > From: Chen Hanxiao >> > >> > s/Subection/Subsection >> > >> > Reviewed-by: Marc-André Lureau >> > Signed-off-by: Chen Hanxiao >> >> Thanks, applied to qg

[Qemu-devel] [PATCH v1 1/1] Makefile: Capstone: Add support for cross compile ranlib

2017-11-07 Thread Alistair Francis
When cross compiling QEMU for Windows we need to specify the cross version of ranlib to avoid build errors when buildling capstone. This patch ensures we use the same cross prefix on ranlib as other toolchain components. Signed-off-by: Alistair Francis Suggested-by: Peter Maydell --- Makefile

Re: [Qemu-devel] [PATCH v2] util/async: use atomic_mb_set in qemu_bh_cancel

2017-11-07 Thread Fam Zheng
Hi Sergio, On Tue, 11/07 23:54, Sergio Lopez wrote: > Commit b7a745d added a qemu_bh_cancel call to the completion function > as an optimization to prevent it from unnecessarily rescheduling itself. > > This completion function is scheduled from worker_thread, after setting > the state of a Threa

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-07 Thread Alexey Kardashevskiy
On 07/11/17 21:12, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: >> On 07/11/17 15:12, Alexey Kardashevskiy wrote: >>> On 04/11/17 02:33, Daniel P. Berrange wrote: We short circuit the git submodule update when passed an empty module list. >>

[Qemu-devel] [RFC PATCH 0/6] generic way to deprecate machines

2017-11-07 Thread Philippe Mathieu-Daudé
Hi, This series intends to provide a simple and common way to deprecate machines between releases. It may be extended to deprecate devices. I started with the machines list from: https://wiki.qemu.org/Features/LegacyRemoval#Deprecated_machines Comment welcomed :) Regards, Phil. Alistair Fr

[Qemu-devel] [RFC PATCH 2/6] hw/arm: deprecate the EP108 board

2017-11-07 Thread Philippe Mathieu-Daudé
From: Alistair Francis The EP108 was an early access development board that is no longer used. Add an info message to convert any users to the ZCU102 instead. On QEMU they are both identical. Signed-off-by: Alistair Francis Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/xlnx-zcu102.c | 6 ++

[Qemu-devel] [RFC PATCH 1/6] machine: add a deprecated_reason property

2017-11-07 Thread Philippe Mathieu-Daudé
If a machine has the deprecated_reason property set: - it won't get listed anymore by the "-M help" command, - a warning will be displayed if the machine is used. Example: $ ppc-softmmu/qemu-system-ppc -M prep qemu-system-ppc: -M prep: warning: The PowerPC PREP platform machine is deprecated

[Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

2017-11-07 Thread Philippe Mathieu-Daudé
Both are deprecated since 2.9.0 Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index f79d5cb694..c462b702ff 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_piix.c @@ -941,6 +941,7 @@ static v

[Qemu-devel] [RFC PATCH 3/6] hw/arm: deprecate the Gumstix boards

2017-11-07 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/gumstix.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c index bba9e9f57a..160f7f089c 100644 --- a/hw/arm/gumstix.c +++ b/hw/arm/gumstix.c @@ -129,6 +129,7 @@ static void connex_class_init(ObjectClass *oc,

[Qemu-devel] [RFC PATCH 4/6] hw/ppc: deprecate the PReP machine

2017-11-07 Thread Philippe Mathieu-Daudé
It is obsoleted by the "40p" machine. Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/prep.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c index 6f8accc397..c032ec3af1 100644 --- a/hw/ppc/prep.c +++ b/hw/ppc/prep.c @@ -682,6 +682,7 @@ static void prep_machine

[Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-07 Thread Philippe Mathieu-Daudé
Deprecated since 2.9.0, guests should be able to use "pc" instead. Signed-off-by: Philippe Mathieu-Daudé --- hw/i386/pc_piix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index c462b702ff..df4669c6d3 100644 --- a/hw/i386/pc_piix.c +++ b/hw/i386/pc_pi

Re: [Qemu-devel] [Qemu-ppc] [PATCH v1] spapr_pci: fix the path while fetching loc-code from host DT

2017-11-07 Thread Alexey Kardashevskiy
On 08/11/17 00:18, Seeteena Thoufeek wrote: > The function spapr_phb_vfio_get_loc_code uses wrong path for > fetching loc-code from host DT > > this is the call that needs to be fixed: > /* Construct and read from host device tree the loc-code */ > path = g_strdup_printf("/proc/device-tree%s/ibm,l

[Qemu-devel] [PATCH] docker: correctly escape $BACKEND in the help output

2017-11-07 Thread Philippe Mathieu-Daudé
In Makefiles the $ must be escaped as $$ in shell uses. Since 8a2390a4f47: $ make docker [...] NETWORK=1Enable virtual network interface with default backend. NETWORK=ACKEND Enable virtual network interface with ACKEND. Once escaped: $ make docker [...]

Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

2017-11-07 Thread Alexey Kardashevskiy
On 08/11/17 13:28, Philippe Mathieu-Daudé wrote: > Both are deprecated since 2.9.0 May be so but I could not find where this happened in git history: [vpl1 qemu]$ git log -n1 --grep 'pc-0.10' f6d5a0bad2 2 years, 5 months ago Eduardo Habkost piix: Define PC_COMPAT_0_10 Having some pointers in the

[Qemu-devel] 答复: Re: [PATCH v2] qga: replace GetIfEntry

2017-11-07 Thread lu.zhipeng
>I have the modified patch staged here: > > https://github.com/mdroth/qemu/commit/de597a8b27722ce4f9cc660f930f7dccc712712d>Let > me know if it looks okay and I'll send a pull request for rc1 the code right, but running QGA on the Windows XP, error: can not find the link to GetIfEntry2

Re: [Qemu-devel] [PATCH] docker: correctly escape $BACKEND in the help output

2017-11-07 Thread Fam Zheng
On Tue, 11/07 23:47, Philippe Mathieu-Daudé wrote: > In Makefiles the $ must be escaped as $$ in shell uses. > > Since 8a2390a4f47: > > $ make docker > [...] > NETWORK=1Enable virtual network interface with default > backend. > NETWORK=ACKEND Enable virtual networ

[Qemu-devel] [PATCH] Makefile: simpler/faster "make help"

2017-11-07 Thread Philippe Mathieu-Daudé
Using obscure black magic introduced in eaa2ddbb767 :) In an out-of-tree directory, running "../configure && make help" will generate some required files (.mak), then clone some submodules, compile at least the capstone submodule, generate QMP and Trace files, and finally display the help. On an

[Qemu-devel] [PATCH] hw/arm/aspeed: Unlock SCU when running kernel

2017-11-07 Thread Joel Stanley
The ASPEED hardware contains a lock register for the SCU that disables any writes to the SCU when it is locked. The machine comes up with the lock enabled, but on all known hardware u-boot will unlock it and leave it unlocked when loading the kernel. This means the kernel expects the SCU to be unl

Re: [Qemu-devel] [RFC PATCH 5/6] hw/i386: deprecate the pc-0.10 and pc-0.11 machines

2017-11-07 Thread Philippe Mathieu-Daudé
Hi Alexey, On 11/07/2017 11:48 PM, Alexey Kardashevskiy wrote: > On 08/11/17 13:28, Philippe Mathieu-Daudé wrote: >> Both are deprecated since 2.9.0 > > May be so but I could not find where this happened in git history: > > [vpl1 qemu]$ git log -n1 --grep 'pc-0.10' > f6d5a0bad2 2 years, 5 months

Re: [Qemu-devel] [RFC PATCH 6/6] hw/i386: deprecate the "isapc" machine

2017-11-07 Thread Philippe Mathieu-Daudé
On 11/07/2017 11:28 PM, Philippe Mathieu-Daudé wrote: > Deprecated since 2.9.0, guests should be able to use "pc" instead. I forgot to add Paolo's comment: "but firmware code paths would be different, do we care?" > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/i386/pc_piix.c | 1 + > 1

[Qemu-devel] [Bug 1178101] Re: Could not enable gtk UI on build for Windows target

2017-11-07 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1178101 Title: Could not e

[Qemu-devel] [Bug 1060928] Re: Error in launch virtual server port

2017-11-07 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1060928 Title: Error in la

[Qemu-devel] [Bug 1061778] Re: signal mask not reset on exec

2017-11-07 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1061778 Title: signal mask

[Qemu-devel] [Bug 1196426] Re: Setup virtual serial connection for Windows VMs FAILS

2017-11-07 Thread Launchpad Bug Tracker
[Expired for QEMU because there has been no activity for 60 days.] ** Changed in: qemu Status: Incomplete => Expired -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1196426 Title: Setup virtu

Re: [Qemu-devel] [PATCH v1 1/1] Makefile: Capstone: Add support for cross compile ranlib

2017-11-07 Thread Philippe Mathieu-Daudé
Hi Alistair, On 11/07/2017 10:10 PM, Alistair Francis wrote: > When cross compiling QEMU for Windows we need to specify the cross What toolchain do you use? > version of ranlib to avoid build errors when buildling capstone. This "building" > patch ensures we use the same cross prefix on ranlib

Re: [Qemu-devel] [PATCH v3 6/7] block/curl: fix minor memory leaks

2017-11-07 Thread Philippe Mathieu-Daudé
Hi Jeff, On 11/07/2017 07:27 PM, Jeff Cody wrote: "Missed in 1bff9606429." > Signed-off-by: Jeff Cody Reviewed-by: Philippe Mathieu-Daudé > --- > block/curl.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/block/curl.c b/block/curl.c > index 00a9879..35cf417 100644 > --- a/

Re: [Qemu-devel] [PATCH for-2.11] scripts/make-release: ship u-boot source as a tarball

2017-11-07 Thread Thomas Huth
On 07.11.2017 21:52, Michael Roth wrote: > The u-boot sources we ship currently cause problems with unpacking on > a case-insensitive filesystem due to path conflicts. This has been > fixed in upstream u-boot via commit 610eec7f, but since it is not > yet included in an official release we implemen

[Qemu-devel] [PATCH v4 01/32] migration: better error handling with QEMUFile

2017-11-07 Thread Peter Xu
If the postcopy down due to some reason, we can always see this on dst: qemu-system-x86_64: RP: Received invalid message 0x length 0x However in most cases that's not the real issue. The problem is that qemu_get_be16() has no way to show whether the returned data is valid or not, and we

[Qemu-devel] [PATCH v4 10/32] qmp: hmp: add migrate "resume" option

2017-11-07 Thread Peter Xu
It will be used when we want to resume one paused migration. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- hmp-commands.hx | 7 --- hmp.c | 4 +++- migration/migration.c | 2 +- qapi/migration.json | 5 - 4 files changed, 12 insertions(+), 6 del

[Qemu-devel] [PATCH v4 02/32] migration: reuse mis->userfault_quit_fd

2017-11-07 Thread Peter Xu
It was only used for quitting the page fault thread before. Let it be something more useful - now we can use it to notify a "wake" for the page fault thread (for any reason), and it only means "quit" if the fault_thread_quit is set. Since we changed what it does, renaming it to userfault_event_fd.

[Qemu-devel] [PATCH v4 00/32] Migration: postcopy failure recovery

2017-11-07 Thread Peter Xu
Tree is pushed here for better reference and testing: github.com/xzpeter postcopy-recovery-support Please review, thanks. v4: - fix two compile errors that patchew reported - for QMP: do s/2.11/2.12/g - fix migrate-incoming logic to be more strict v3: - add r-bs correspondingly - in ram_load_p

[Qemu-devel] [PATCH v4 06/32] migration: allow dst vm pause on postcopy

2017-11-07 Thread Peter Xu
When there is IO error on the incoming channel (e.g., network down), instead of bailing out immediately, we allow the dst vm to switch to the new POSTCOPY_PAUSE state. Currently it is still simple - it waits the new semaphore, until someone poke it for another attempt. Signed-off-by: Peter Xu ---

[Qemu-devel] [PATCH v4 04/32] migration: new postcopy-pause state

2017-11-07 Thread Peter Xu
Introducing a new state "postcopy-paused", which can be used when the postcopy migration is paused. It is targeted for postcopy network failure recovery. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 2 ++ qapi/migration.json | 5 - 2 files change

[Qemu-devel] [PATCH v4 03/32] migration: provide postcopy_fault_thread_notify()

2017-11-07 Thread Peter Xu
A general helper to notify the fault thread. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/postcopy-ram.c | 35 --- migration/postcopy-ram.h | 2 ++ 2 files changed, 22 insertions(+), 15 deletions(-) diff --git a/migration/postcopy-r

[Qemu-devel] [PATCH v4 18/32] migration: new message MIG_RP_MSG_RESUME_ACK

2017-11-07 Thread Peter Xu
Creating new message to reply for MIG_CMD_POSTCOPY_RESUME. One uint32_t is used as payload to let the source know whether destination is ready to continue the migration. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/migration.c | 37 +

[Qemu-devel] [PATCH v4 15/32] migration: new cmd MIG_CMD_RECV_BITMAP

2017-11-07 Thread Peter Xu
Add a new vm command MIG_CMD_RECV_BITMAP to request received bitmap for one ramblock. Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- migration/savevm.c | 61 ++ migration/savevm.h | 1 + migration/trace-events | 2 ++ 3

[Qemu-devel] [PATCH v4 08/32] migration: allow send_rq to fail

2017-11-07 Thread Peter Xu
We will not allow failures to happen when sending data from destination to source via the return path. However it is possible that there can be errors along the way. This patch allows the migrate_send_rp_message() to return error when it happens, and further extended it to migrate_send_rp_req_page

<    1   2   3   4   >