Re: [Qemu-devel] [PATCH 1/4] linux-user/s390x: Mask si_addr for SIGSEGV

2017-11-07 Thread Laurent Vivier
Le 06/11/2017 à 19:33, Peter Maydell a écrit : > For s390x, the address passed to a signal handler in the > siginfo_t si_addr field is masked (in the kernel this is done in > do_sigbus() and do_sigsegv() in arch/s390/mm/fault.c). Implement > this architecture-specific oddity in linux-user. > > Thi

Re: [Qemu-devel] [PATCH v2 00/43] Windbg supporting

2017-11-07 Thread Ladi Prosek
On Mon, Nov 6, 2017 at 7:41 PM, Andrew Baumann wrote: > Hi, > > I just noticed this thread, and the problem sounded very familiar... > >> From: Ladi Prosek >> Sent: Monday, 6 November 2017 07:16 > [...] >> FS base passes all the checks in windbg_on_load() as the guest kernel >> loads and it return

Re: [Qemu-devel] [PATCH 2/4] linux-user/ppc: Report correct fault address for data faults

2017-11-07 Thread Laurent Vivier
Le 06/11/2017 à 19:33, Peter Maydell a écrit : > For faults on loads and stores, ppc_cpu_handle_mmu_fault() in > target/ppc/user_only_helper.c stores the offending address > in env->spr[SPR_DAR]. Report this correctly to the guest > in si_addr, rather than incorrectly using the address of the > ins

Re: [Qemu-devel] [PATCH 3/4] linux-user/sparc: Put address for data faults where linux-user expects it

2017-11-07 Thread Laurent Vivier
Le 06/11/2017 à 19:33, Peter Maydell a écrit : > In the user-mode-only version of sparc_cpu_handle_mmu_fault(), > we must save the fault address for a data fault into the CPU > state's mmu registers, because the code in linux-user/main.c > expects to find it there in order to populate the si_addr >

Re: [Qemu-devel] [PATCH] virtio-pci: Don't force Subsystem Vendor ID = Vendor ID

2017-11-07 Thread Ladi Prosek
On Mon, Nov 6, 2017 at 5:51 PM, Michael S. Tsirkin wrote: > On Mon, Nov 06, 2017 at 10:02:54AM +0100, Ladi Prosek wrote: >> On Fri, Nov 3, 2017 at 4:11 PM, Michael S. Tsirkin wrote: >> > On Fri, Nov 03, 2017 at 09:23:07AM +0100, Ladi Prosek wrote: >> >> On Fri, Nov 3, 2017 at 8:20 AM, Gerd Hoffma

Re: [Qemu-devel] [PULL, 08/14] spapr_pci/spapr_pci_vfio: Support Dynamic DMA Windows (DDW)

2017-11-07 Thread Laurent Vivier
On 05/07/2016 07:31, David Gibson wrote: > From: Alexey Kardashevskiy > > This adds support for Dynamic DMA Windows (DDW) option defined by > the SPAPR specification which allows to have additional DMA window(s) > > The "ddw" property is enabled by default on a PHB but for compatibility > the ps

Re: [Qemu-devel] about qemu-img info on block dev

2017-11-07 Thread Kevin Wolf
Am 07.11.2017 um 08:18 hat wang.guan...@zte.com.cn geschrieben: > hello > > > if we create a qcow2 file on a block dev. > > > we can,t get the right disk size by qemu-img info。 > > > > > > > [root@host-120-79 qemu]# ./qemu-img create -f qcow2 /dev/zs/lvol0 1G > > Formatting '/dev/zs/lvol

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-07 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 10:27:10AM +0800, Longpeng (Mike) wrote: > > > On 2017/11/7 1:00, Eric Blake wrote: > > > On 11/06/2017 12:21 AM, Longpeng(Mike) wrote: > >> Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with > >> errp=NULL, this will cause a NULL poniter deference if afalg_dri

Re: [Qemu-devel] [PATCH] linux-user: Support explicit targets for PowerPC

2017-11-07 Thread Laurent Vivier
Le 07/11/2017 à 03:50, Aaron Sierra a écrit : > Enable building PowerPC targets supporting a specific CPU, without > having to set QEMU_CPU via the environment. For example these build > targets (and many more) become available: > > qemu-ppc.e500mc qemu-ppc.e500v2 qemu-ppc.e5500 qemu-ppc.e600 >

Re: [Qemu-devel] [PATCH 3/4] linux-user/sparc: Put address for data faults where linux-user expects it

2017-11-07 Thread Laurent Vivier
Le 06/11/2017 à 19:33, Peter Maydell a écrit : > In the user-mode-only version of sparc_cpu_handle_mmu_fault(), > we must save the fault address for a data fault into the CPU > state's mmu registers, because the code in linux-user/main.c > expects to find it there in order to populate the si_addr >

Re: [Qemu-devel] [PULL v1 0/2] Merge IO 2017/11/06

2017-11-07 Thread Daniel P. Berrange
On Mon, Nov 06, 2017 at 05:58:41PM +, Peter Maydell wrote: > On 6 November 2017 at 17:43, Daniel P. Berrange wrote: > > On Mon, Nov 06, 2017 at 04:11:56PM +, Peter Maydell wrote: > >> On 6 November 2017 at 15:33, Daniel P. Berrange > >> wrote: > >> > The following changes since commit >

Re: [Qemu-devel] [PATCH 3/4] linux-user/sparc: Put address for data faults where linux-user expects it

2017-11-07 Thread Peter Maydell
On 7 November 2017 at 08:28, Laurent Vivier wrote: > Le 06/11/2017 à 19:33, Peter Maydell a écrit : >> In the user-mode-only version of sparc_cpu_handle_mmu_fault(), >> we must save the fault address for a data fault into the CPU >> state's mmu registers, because the code in linux-user/main.c >> e

Re: [Qemu-devel] [PATCH] linux-user: Support explicit targets for PowerPC

2017-11-07 Thread Peter Maydell
On 7 November 2017 at 06:57, Laurent Vivier wrote: > Le 07/11/2017 à 03:50, Aaron Sierra a écrit : >> Enable building PowerPC targets supporting a specific CPU, without >> having to set QEMU_CPU via the environment. For example these build >> targets (and many more) become available: >> >> qem

Re: [Qemu-devel] RFC: connecting chardev to a command forked by qemu

2017-11-07 Thread Daniel P. Berrange
On Mon, Nov 06, 2017 at 10:02:05PM +0100, Patrick Ohly wrote: > On Mon, 2017-11-06 at 17:26 +, Daniel P. Berrange wrote: > > I can see the argument about it making QEMU easier to use, and those > > who care about security aren't forced to use this new feature. It > > none the less has a cost on

Re: [Qemu-devel] [PATCH] crypto: afalg: fix a NULL pointer dereference

2017-11-07 Thread Longpeng (Mike)
On 2017/11/7 17:16, Daniel P. Berrange wrote: > On Tue, Nov 07, 2017 at 10:27:10AM +0800, Longpeng (Mike) wrote: >> >> >> On 2017/11/7 1:00, Eric Blake wrote: >> >>> On 11/06/2017 12:21 AM, Longpeng(Mike) wrote: Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with errp=NULL, t

Re: [Qemu-devel] RFC: connecting chardev to a command forked by qemu

2017-11-07 Thread Patrick Ohly
On Tue, 2017-11-07 at 09:23 +, Daniel P. Berrange wrote: > On Mon, Nov 06, 2017 at 10:02:05PM +0100, Patrick Ohly wrote: > > On Mon, 2017-11-06 at 17:26 +, Daniel P. Berrange wrote: > > > I can see the argument about it making QEMU easier to use, and > > > those > > > who care about securit

Re: [Qemu-devel] [PATCH] linux-user: Support explicit targets for PowerPC

2017-11-07 Thread Laurent Vivier
Le 07/11/2017 à 10:29, Peter Maydell a écrit : > On 7 November 2017 at 06:57, Laurent Vivier wrote: >> Le 07/11/2017 à 03:50, Aaron Sierra a écrit : >>> Enable building PowerPC targets supporting a specific CPU, without >>> having to set QEMU_CPU via the environment. For example these build >>> ta

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-07 Thread R.Nageswara Sastry
Similar failure seen with the following test too. # make check-qtest-sparc64 V=1 (cd /home/nasastry/qemu; printf '#define QEMU_PKGVERSION '; if test -n ""; then printf '""\n'; else if test -d .git; then printf '" ('; git describe --match 'v*' 2>/dev/null | tr -d '\n'; if ! git diff-index --quiet

Re: [Qemu-devel] [PATCH v3 3/4] block/parallels: add migration blocker

2017-11-07 Thread Stefan Hajnoczi
On Mon, Nov 06, 2017 at 09:31:21PM -0500, Jeff Cody wrote: > @@ -720,6 +722,16 @@ static int parallels_open(BlockDriverState *bs, QDict > *options, int flags, > s->bat_dirty_bmap = > bitmap_new(DIV_ROUND_UP(s->header_size, s->bat_dirty_block)); > > +/* Disable migration until b

Re: [Qemu-devel] [PATCH v2] Make scrolling work again

2017-11-07 Thread Peter Maydell
On 1 November 2017 at 15:46, John Arbuckle wrote: > Make scrolling in the monitor work. > > Signed-off-by: John Arbuckle > --- > ui/cocoa.m | 96 > +- > 1 file changed, 64 insertions(+), 32 deletions(-) Hi; I've applied this to my coc

Re: [Qemu-devel] [PATCH v3 1/2] ui/cocoa.m: move ungrab to ctrl-alt-g

2017-11-07 Thread Peter Maydell
On 2 November 2017 at 21:39, John Arbuckle wrote: > Currently the cocoa user interface relys on the user pushing control-alt to > ungrab the mouse. This is patch changes the key combination to control-alt-g > to be in line with the GTK user interface. Hi; I've applied this to cocoa.next. This

Re: [Qemu-devel] [PATCH v3 01/46] Replace all occurances of __FUNCTION__ with __func__

2017-11-07 Thread Markus Armbruster
Juan Quintela writes: > Alistair Francis wrote: >> Replace all occurs of __FUNCTION__ except for the check in checkpatch >> with the non GCC specific __func__. >> >> One line in hcd-musb.c was manually tweaked to pass checkpatch. >> >> Signed-off-by: Alistair Francis >> Cc: Gerd Hoffmann >> Cc

Re: [Qemu-devel] [PATCH v3 2/2] ui/cocoa.m: send ctrl-alt key combinations to guest if not used by QEMU

2017-11-07 Thread Peter Maydell
On 2 November 2017 at 21:39, John Arbuckle wrote: > Send control-alt key combinations to the guest if not used by the user > interface. > > Signed-off-by: John Arbuckle > --- > v3 changes: > - Code is now keyboard layout aware > > v2 changes: > - changed logic to use existing if case > > ui/coc

[Qemu-devel] [PULL 3/3] ui/cocoa.m: Send ctrl-alt key combos to guest if QEMU isn't using them

2017-11-07 Thread Peter Maydell
Send those ctrl-alt key combos that QEMU doesn't treat specially to the guest rather than ignoring them. All the case where we do special handling of ctrl-alt-X exit the event handling using a "return" statement, so we can simply allow the rest to fall through into the normal key handling by delet

[Qemu-devel] [PULL 0/3] cocoa queue

2017-11-07 Thread Peter Maydell
ydell/qemu-arm.git tags/pull-cocoa-20171107 for you to fetch changes up to ef2088f9af16d3a19f5f094da160dd8ba52231a9: ui/cocoa.m: Send ctrl-alt key combos to guest if QEMU isn't using them (2017-11-07 10:14:14 +) cocoa

[Qemu-devel] [PULL 1/3] ui/cocoa.m: Make scrolling work again in GUI monitor windows

2017-11-07 Thread Peter Maydell
From: John Arbuckle Make scrolling in the monitor work, by correctly passing through control+key combinations. Signed-off-by: John Arbuckle Message-id: 20171101154607.1582-1-programmingk...@gmail.com [PMM: fixed coding style nits; cleaned up commit message] Reviewed-by: Peter Maydell Signed-of

[Qemu-devel] [PULL v1 1/6] build: allow setting a custom GIT binary for transparent proxying

2017-11-07 Thread Daniel P. Berrange
Some users can't run a bare 'git' command, due to need for a transparent proxying solution such as 'tsocks'. This adds an argument to configure to let users specify such a thing: ./configure --with-git="tsocks git" The submodule script is also updated to give the user a hint about using this fl

[Qemu-devel] [PULL v1 3/6] build: allow automatic git submodule updates to be disabled

2017-11-07 Thread Daniel P. Berrange
Some people building QEMU use VPATH builds where the source directory is on a read-only volume. In such a case 'scripts/git-submodules.sh update' will always fail and users are required to run it manually themselves on their original writable source directory. While this is already supported, it i

[Qemu-devel] [PULL 2/3] ui/cocoa.m: move ungrab to ctrl-alt-g

2017-11-07 Thread Peter Maydell
From: John Arbuckle Currently the cocoa user interface relis on the user pushing control-alt to ungrab the mouse. This is patch changes the key combination to control-alt-g to be in line with the GTK user interface. Signed-off-by: John Arbuckle Message-id: 20171102213907.11443-1-programmingk..

[Qemu-devel] [PULL v1 0/6] Merge build 2017/11/07

2017-11-07 Thread Daniel P. Berrange
The following changes since commit ec7a8bf0b8f7dc7288fe8745464ee8217528cc6c: Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into staging (2017-11-06 10:04:16 +) are available in the git repository at: git://github.com/berrange/qemu tags/pull-build-2017-11-07-1 for you

[Qemu-devel] [PULL v1 5/6] build: delay check for empty git submodule list

2017-11-07 Thread Daniel P. Berrange
We short circuit the git submodule update when passed an empty module list. This accidentally causes the 'status' command to write to the status file. The test needs to be delayed into the individual commands to avoid this premature writing of the status file. Tested-by: Philippe Mathieu-Daudé Re

[Qemu-devel] [PULL v1 6/6] build: remove use of MAKELEVEL optimization in submodule handling

2017-11-07 Thread Daniel P. Berrange
The Makefile attempts to optimize the handling of submodules by using MAKELEVEL to only check the submodule status when running from the top level make invokation. This causes problems for people who are using a makefile of their own to in turn invoke QEMU's makefile, as MAKELEVEL is already set to

Re: [Qemu-devel] [PATCH v3 5/5] build: delay check for empty git submodule list

2017-11-07 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 04:13:27PM +1100, Alexey Kardashevskiy wrote: > On 07/11/17 15:12, Alexey Kardashevskiy wrote: > > On 04/11/17 02:33, Daniel P. Berrange wrote: > >> We short circuit the git submodule update when passed an empty module list. > >> This accidentally causes the 'status' command

Re: [Qemu-devel] [Qemu-block] Clean Block Driver Shutdown

2017-11-07 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Tue, Oct 17, 2017 at 01:46:25PM +0200, Kevin Wolf wrote: >> Am 17.10.2017 um 12:33 hat Peter Lieven geschrieben: >> > I noticed that Qemu quits at several points with an exit() if the >> > supplied parameters in the commandline are incorrect. This at some >> > stages

[Qemu-devel] [PULL v1 4/6] build: don't fail if given a git submodule which does not exist

2017-11-07 Thread Daniel P. Berrange
If going back in time in git history, across a commit that introduces a new submodule, the 'git-submodule.sh' script will fail, causing rebuild to fail. This is because config-host.mak contains a GIT_SUBMODULES variable that lists a submodule that only exists in the later commit. config-host.mak w

[Qemu-devel] [PULL v1 2/6] build: don't create temporary files in source dir

2017-11-07 Thread Daniel P. Berrange
There are cases where users do VPATH builds with the source directory being on a read-only volume. In such a case they have to manually run the command 'git-submodule.sh ...modules...' ahead of time. When checking for status we should not then write into the source dir. Tested-by: Philippe Mathieu

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-07 Thread Thomas Huth
Is that 100% reproducible? Which version of QEMU did you use here? And which host are you using, POWER9 again? The very latest git master branch is using a timeout of 10 minutes now, so that should be sufficient for all cases... Could you please try to run this manually: qemu-system-sparc64 -nogr

Re: [Qemu-devel] Crash with pcie-pci-bridge on qemu-system-s390x

2017-11-07 Thread Cornelia Huck
On Thu, 2 Nov 2017 17:59:58 +0300 Aleksandr Bezzubikov wrote: > 2017-11-02 17:42 GMT+03:00 Marcel Apfelbaum : > > On 02/11/2017 16:19, Thomas Huth wrote: > >> > >> Hi, > >> > > > > Hi Thomas, > > > > Hi Thomas, Marcel, > > >> seems like there's a new way to crash QEMU with the pcie-pci-

Re: [Qemu-devel] [Qemu-block] question: I found a qemu crash when attach virtio-scsi disk

2017-11-07 Thread Paolo Bonzini
On 07/11/2017 02:59, Fam Zheng wrote: > On Mon, 11/06 17:33, Paolo Bonzini wrote: >> On 06/11/2017 17:11, Kevin Wolf wrote: >>> Am 03.11.2017 um 11:26 hat Stefan Hajnoczi geschrieben: On Wed, Nov 01, 2017 at 06:42:33AM +, lizhengui wrote: > Hi, when I attach virtio-scsi disk to VM, the

Re: [Qemu-devel] [Qemu-block] Clean Block Driver Shutdown

2017-11-07 Thread Peter Lieven
Am 07.11.2017 um 11:22 schrieb Markus Armbruster: Stefan Hajnoczi writes: On Tue, Oct 17, 2017 at 01:46:25PM +0200, Kevin Wolf wrote: Am 17.10.2017 um 12:33 hat Peter Lieven geschrieben: I noticed that Qemu quits at several points with an exit() if the supplied parameters in the commandline

Re: [Qemu-devel] [RFC PATCH] remove numpy dependency

2017-11-07 Thread Stefan Hajnoczi
On Mon, Nov 06, 2017 at 07:35:55PM +0300, Joannah Nanjekye wrote: > Users tend to hit an ImportError when running analyze-migration.py due > to the numpy dependency. numpy functionality isn't actually used, just > binary serialization that the standard library 'struct' module already > provides.

Re: [Qemu-devel] [PATCH v2 26/28] qdev: add DEFINE_PROP_TPMBE

2017-11-07 Thread Marc-André Lureau
On Mon, Nov 6, 2017 at 9:31 PM, Stefan Berger wrote: > On 11/06/2017 01:39 PM, Marc-André Lureau wrote: >> >> A property to lookup a tpm backend. >> >> Signed-off-by: Marc-André Lureau >> --- >> include/hw/qdev-properties.h | 3 ++ >> hw/core/qdev-properties-system.c | 64 >> +

Re: [Qemu-devel] [PULL v2 0/3] target-mips queue

2017-11-07 Thread Peter Maydell
On 6 November 2017 at 16:07, Yongbok Kim wrote: > The following changes since commit d24aaf2a2915424962fb101142f28fa4307f4740: > > Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' > into staging (2017-11-06 11:24:14 +) > > are available in the git repository at: > >

Re: [Qemu-devel] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions

2017-11-07 Thread Stafford Horne
On Sun, Nov 05, 2017 at 03:39:48PM +0100, Laurent Vivier wrote: > Le 04/11/2017 à 22:20, Stafford Horne a écrit : > > Hello, > > > > On Fri, Nov 03, 2017 at 09:26:22PM +0100, Laurent Vivier wrote: > >> Signed-off-by: Laurent Vivier > > > > There is no commit body here, do we need one? I can see

Re: [Qemu-devel] [PATCH v2] s390x/cpu: expose the guest crash information

2017-11-07 Thread QingFeng Hao
在 2017/9/19 21:04, Eric Blake 写道: On 09/19/2017 02:43 AM, Christian Borntraeger wrote: From: Jing Liu This patch is the s390 implementation of guest crash information, similar to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and the related commits. We will detect severa

Re: [Qemu-devel] [PATCH 3/8] raw: Reflect read-only protocol layer

2017-11-07 Thread Paolo Bonzini
On 07/11/2017 04:02, Eric Blake wrote: > We forbid operations like a zero-length write zero or a discard > at the protocol layer when it is marked read-only, but those > same operations were succeeding at the format layer because the > raw format was not reflecting the underlying read-only status >

Re: [Qemu-devel] [PATCH 0/2] Optimize sparse reads over NBD

2017-11-07 Thread Paolo Bonzini
On 07/11/2017 04:09, Eric Blake wrote: > When I first proposed the NBD extension of structured reads, > it was in order to more efficiently read sparse files without > sending lots of zeroes over the wire. These two patches feel > like a feature addition, and missed soft freeze, so I'm > reluctant

Re: [Qemu-devel] [Qemu-block] Clean Block Driver Shutdown

2017-11-07 Thread Markus Armbruster
Peter Lieven writes: > Am 07.11.2017 um 11:22 schrieb Markus Armbruster: >> Stefan Hajnoczi writes: >> >>> On Tue, Oct 17, 2017 at 01:46:25PM +0200, Kevin Wolf wrote: Am 17.10.2017 um 12:33 hat Peter Lieven geschrieben: > I noticed that Qemu quits at several points with an exit() if the

Re: [Qemu-devel] [PATCH v2 25/28] tpm-emulator: protect concurrent ctrl_chr access

2017-11-07 Thread Marc-André Lureau
Hi On Tue, Nov 7, 2017 at 2:11 AM, Stefan Berger wrote: > On 11/06/2017 05:11 PM, Marc-André Lureau wrote: >> >> Hi >> >> - Original Message - >>> >>> On 11/06/2017 01:39 PM, Marc-André Lureau wrote: The control chardev is being used from the data thread to set the locality

Re: [Qemu-devel] [Qemu-block] Clean Block Driver Shutdown

2017-11-07 Thread Peter Lieven
Am 07.11.2017 um 12:02 schrieb Markus Armbruster: Peter Lieven writes: Am 07.11.2017 um 11:22 schrieb Markus Armbruster: Stefan Hajnoczi writes: On Tue, Oct 17, 2017 at 01:46:25PM +0200, Kevin Wolf wrote: Am 17.10.2017 um 12:33 hat Peter Lieven geschrieben: I noticed that Qemu quits at s

Re: [Qemu-devel] [Qemu-block] Clean Block Driver Shutdown

2017-11-07 Thread Kevin Wolf
Am 07.11.2017 um 11:48 hat Peter Lieven geschrieben: > Am 07.11.2017 um 11:22 schrieb Markus Armbruster: > > Stefan Hajnoczi writes: > > > > > On Tue, Oct 17, 2017 at 01:46:25PM +0200, Kevin Wolf wrote: > > > > Am 17.10.2017 um 12:33 hat Peter Lieven geschrieben: > > > > > I noticed that Qemu qui

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-07 Thread R.Nageswara Sastry
Git head is at 299d1ea9bb56bd9f45f905125489bdd7d543a1aa latest today 100% re-producible. This is different & working Power9 machine than the other day. # ./sparc64-softmmu/qemu-system-sparc64 -nographic -M sun4u -prom-env 'use-nvramrc?=true' -prom-env 'nvramrc=." Hello World!" cr' OpenBIOS for S

[Qemu-devel] [PATCH v3] xen-disk: use an IOThread per instance

2017-11-07 Thread Paul Durrant
This patch allocates an IOThread object for each xen_disk instance and sets the AIO context appropriately on connect. This allows processing of I/O to proceed in parallel. The patch also adds tracepoints into xen_disk to make it possible to follow the state transtions of an instance in the log. S

[Qemu-devel] [Bug 1585840] Re: multiprocess program gets incorrect results with qemu arm-linux-user

2017-11-07 Thread Peter Maydell
Hi. Your test program doesn't work for me running natively (x86-64): $ gcc -O -pthread -o /tmp/shmipc-native -static /tmp/shmipc.c $ time /tmp/shmipc-native threaded test ^C real929m16.382s user1858m14.140s sys 0m2.924s ...I left it running overnight and it still hadn't finished when

Re: [Qemu-devel] [libvirt] [PATCH 0/7] x86: Rework KVM-defaults compat code, enable kvm_pv_unhalt by default

2017-11-07 Thread Paolo Bonzini
On 14/10/2017 01:56, Eduardo Habkost wrote: > Now, I don't know yet what's the best default for a guest that > has CONFIG_PARAVIRT_SPINLOCK when it sees a host that supports > kvm_pv_unhalt. But I'm arguing that it's the guest > responsibility to choose what to do when it detects such a host, > in

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-07 Thread Pankaj Gupta
> > > > > >> [..] > >> >> Yes, the GUID will specifically identify this range as "Virtio Shared > >> >> Memory" (or whatever name survives after a bikeshed debate). The > >> >> libnvdimm core then needs to grow a new region type that mostly > >> >> behaves the same as a "pmem" region, but drivers/

Re: [Qemu-devel] [PATCH] memory: remove unused memory_region_set_global_locking()

2017-11-07 Thread Paolo Bonzini
On 06/11/2017 19:55, Marc-André Lureau wrote: > This was never used since its introduction in commit > 196ea13104f8 ("memory: Add global-locking property to memory > regions"). > > Signed-off-by: Marc-André Lureau Indeed, it was introduced for symmetry with memory_region_clear_global_locking but

Re: [Qemu-devel] [PATCH for-2.11] tests-aio-multithread: fix /aio/multi/schedule race condition

2017-11-07 Thread Paolo Bonzini
On 06/11/2017 20:02, Stefan Hajnoczi wrote: > test_multi_co_schedule_entry() set to_schedule[id] in the final loop > iteration before terminating the coroutine. There is a race condition > where the main thread attempts to enter the terminating or terminated > coroutine when signalling coroutines

[Qemu-devel] [PATCH v2] crypto: afalg: fix a NULL pointer dereference

2017-11-07 Thread Longpeng(Mike)
From: Longpeng Test-crypto-hash calls qcrypto_hash_bytesv/digest/base64 with errp=NULL, this will cause a NULL pointer deference if afalg_driver doesn't support requested algos: ret = qcrypto_hash_afalg_driver.hash_bytesv(alg, iov, niov, result

[Qemu-devel] [Resend][PATCH] qapi-docs: fix a comment typo

2017-11-07 Thread Chen Hanxiao
From: Chen Hanxiao s/Subection/Subsection Reviewed-by: Marc-André Lureau Signed-off-by: Chen Hanxiao --- docs/devel/qapi-code-gen.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi-code-gen.txt index f04c63fe82..06ab699066

[Qemu-devel] target-s390x: assertion failure in op_risbg

2017-11-07 Thread Peter Maydell
This is from https://bugs.launchpad.net/qemu/+bug/1701798, but that's quite a large thing, so here's the s390 specific part. On an ubuntu xenial install: $ apt install g++-5-s390x-linux-gnu $ cat hello.c #include int main(void) { printf("hello world\n"); return 0; } $ s390x-linux-gnu-gcc

[Qemu-devel] [Bug 1701798] Re: dynamically linked binaries crash for big-endian targets

2017-11-07 Thread Peter Maydell
I just tested with powerpc and current head-of-git QEMU and it works: e104462:xenial:bug-1701798$ cat hello.c #include int main(void) { printf("hello world\n"); return 0; } e104462:xenial:bug-1701798$ powerpc-linux-gnu-gcc-5 -O hello.c -o hello.powerpc e104462:xenial:bug-1701798$ QEMU_LD_

Re: [Qemu-devel] [PULL 0/2] 9pfs fixes for 2.11 20171106

2017-11-07 Thread Peter Maydell
On 6 November 2017 at 20:05, Greg Kurz wrote: > The following changes since commit 299d1ea9bb56bd9f45f905125489bdd7d543a1aa: > > Merge remote-tracking branch 'remotes/yongbok/tags/mips-20171106' into > staging (2017-11-06 16:13:10 +) > > are available in the git repository at: > > https:/

Re: [Qemu-devel] target-s390x: assertion failure in op_risbg

2017-11-07 Thread Thomas Huth
On 07.11.2017 12:41, Peter Maydell wrote: > This is from https://bugs.launchpad.net/qemu/+bug/1701798, but > that's quite a large thing, so here's the s390 specific part. > > On an ubuntu xenial install: > > $ apt install g++-5-s390x-linux-gnu > $ cat hello.c > #include > int main(void) { >

Re: [Qemu-devel] [PATCH v6 16/25] block: Add 'base-directory' BDS option

2017-11-07 Thread Alberto Garcia
On Thu 02 Nov 2017 11:06:28 PM CET, Eric Blake wrote: Using this option, one can directly override what bdrv_dirname() will return. This is useful if one uses e.g. qcow2 on top of quorum (with only protocol BDSs under the quorum BDS) and wants to be able to use relative backing

Re: [Qemu-devel] target-s390x: assertion failure in op_risbg

2017-11-07 Thread Richard Henderson
On 11/07/2017 12:41 PM, Peter Maydell wrote: > This is from https://bugs.launchpad.net/qemu/+bug/1701798, but > that's quite a large thing, so here's the s390 specific part. > > On an ubuntu xenial install: > > $ apt install g++-5-s390x-linux-gnu > $ cat hello.c > #include > int main(void) { >

Re: [Qemu-devel] target-s390x: assertion failure in op_risbg

2017-11-07 Thread Richard Henderson
On 11/07/2017 01:00 PM, Thomas Huth wrote: > If I've got the spec right, it's doing the same as > RISBG (with subcode 0x55), but just does not set the condition code at > the end, so this should be quite easy to implement? That's right. r~

Re: [Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-07 Thread Thomas Huth
On 07.11.2017 11:58, R.Nageswara Sastry wrote: > Git head is at 299d1ea9bb56bd9f45f905125489bdd7d543a1aa > latest today > > 100% re-producible. This is different & working Power9 machine than the > other day. > > # ./sparc64-softmmu/qemu-system-sparc64 -nographic -M sun4u -prom-env > 'use-nvramr

Re: [Qemu-devel] [PULL v1 0/6] Merge build 2017/11/07

2017-11-07 Thread Peter Maydell
On 7 November 2017 at 10:16, Daniel P. Berrange wrote: > The following changes since commit ec7a8bf0b8f7dc7288fe8745464ee8217528cc6c: > > Merge remote-tracking branch 'remotes/bonzini/tags/for-upstream' into > staging (2017-11-06 10:04:16 +) > > are available in the git repository at: > >

[Qemu-devel] [PATCH] disas: Dump insn bytes along with capstone disassembly

2017-11-07 Thread Richard Henderson
This feature is present for some targets in the bfd disassembler(s). Implement it generically for all capstone users. Suggested-by: Peter Maydell Signed-off-by: Richard Henderson --- include/disas/bfd.h | 2 ++ disas.c | 96 ++--- tar

Re: [Qemu-devel] [PATCH 3/5] tpm: tpm_passthrough: Read the buffer size from the host device

2017-11-07 Thread Stefan Berger
On 11/06/2017 07:58 PM, Stefan Berger wrote: Rather than hard coding the buffer size in the tpm_passthrough backend read the TPM I/O buffer size from the host device. Signed-off-by: Stefan Berger --- hw/tpm/tpm_int.h | 9 hw/tpm/tpm_passthrough.c | 11 - hw/tpm/tpm_util.

Re: [Qemu-devel] [PATCH] hw: add .min_cpus and .default_cpus fields to machine_class

2017-11-07 Thread Eduardo Habkost
On Mon, Nov 06, 2017 at 04:43:34PM -0800, Alistair Francis wrote: > On Mon, Nov 6, 2017 at 12:13 PM, Emilio G. Cota wrote: > > On Mon, Nov 06, 2017 at 12:10:22 -0200, Eduardo Habkost wrote: > >> IMO, initialization state doesn't belong to CPUClass. We already > >> have a single accelerator object

Re: [Qemu-devel] [PATCH] linux-user: remove nmi.c and fw-path-provider.c

2017-11-07 Thread Paolo Bonzini
On 03/11/2017 20:38, Laurent Vivier wrote: > linux-user binaries don't need firmware and NMI, > so don't add them in this case, move QDEV > firmware functions to qdev-fw.c > > Signed-off-by: Laurent Vivier Acked-by: Paolo Bonzini > --- > hw/core/Makefile.objs | 5 +-- > hw/core/qdev-fw.c

Re: [Qemu-devel] [PULL 0/3] cocoa queue

2017-11-07 Thread Peter Maydell
00) > > are available in the git repository at: > > git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-cocoa-20171107 > > for you to fetch changes up to ef2088f9af16d3a19f5f094da160dd8ba52231a9: > > ui/cocoa.m: Send ctrl-alt key combos to guest if

Re: [Qemu-devel] [PATCH v2] aarch64: advertise the GIC system register interface

2017-11-07 Thread Peter Maydell
On 6 November 2017 at 22:16, Stefano Stabellini wrote: > When QEMU emulates a GICv3, it needs to advertise the presence of the > system register interface, which is done via id_aa64pfr0. > > To do that, and at the same time to avoid advertising the presence of > the system register interface when

[Qemu-devel] [PATCH v4 3/4] block/parallels: add migration blocker

2017-11-07 Thread Jeff Cody
Migration does not work for parallels, and has been broken for a while (see patch 'block/parallels: Do not update header or truncate image when INMIGRATE'). The bdrv_invalidate_cache() method needs to be added for migration to be supported. Until this is done, prohibit migration. Signed-off-by:

[Qemu-devel] [PATCH v4 0/4] Don't write headers if BDS is INACTIVE

2017-11-07 Thread Jeff Cody
Changes from v3->v4: Patch 3: Add migrate_del_blocker and error_free (Thanks Stefan) git-backport-diff -r qemu/master.. -u ba11b69 001/4:[] [--] 'block/vhdx.c: Don't blindly update the header' 002/4:[] [--] 'block/parallels: Do not update header or truncate image when INMIGRATE' 003/4:

[Qemu-devel] [PATCH v4 2/4] block/parallels: Do not update header or truncate image when INMIGRATE

2017-11-07 Thread Jeff Cody
If we write or modify the image file while the QEMU run state is INMIGRATE, then the BDRV_O_INACTIVE BDS flag is set. This will cause an assert, since the image is marked inactive. Make sure we obey this flag. Tested-by: Alexey Kardashevskiy Signed-off-by: Jeff Cody --- block/parallels.c | 7

[Qemu-devel] [PATCH v4 1/4] block/vhdx.c: Don't blindly update the header

2017-11-07 Thread Jeff Cody
The VHDX specification requires that before user data modification of the vhdx image, the VHDX header file and data GUIDs need to be updated. In vhdx_open(), if the image is set to RDWR, we go ahead and update the header. However, just because the image is set to RDWR does not mean we can go ahead

[Qemu-devel] [PATCH v4 4/4] qemu-iotests: update unsupported image formats in 194

2017-11-07 Thread Jeff Cody
Test 194 checks for 'luks' to exclude as an unsupported format, However, most formats are unsupported, due to migration blockers. Rather than specifying a blacklist of unsupported formats, whitelist supported formats (specifically, qcow2, qed, raw, dmg). Tested-by: Alexey Kardashevskiy Signed-of

[Qemu-devel] [PATCH v1] spapr_pci: fix the path while fetching loc-code from host DT

2017-11-07 Thread Seeteena Thoufeek
The function spapr_phb_vfio_get_loc_code uses wrong path for fetching loc-code from host DT this is the call that needs to be fixed: /* Construct and read from host device tree the loc-code */ path = g_strdup_printf("/proc/device-tree%s/ibm,loc-code", buf); Signed-off-by: Seeteena Thoufeek ---

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-07 Thread R.Nageswara Sastry
Here is the md5sum of openbios-sparc64 # md5sum ./pc-bios/openbios-sparc64 15418a4c9429d9ee9c637701b94c7ffb ./pc-bios/openbios-sparc64 > Could you please check with the QEMU 2.10 release to see whether this is a > regression or whether it was already failing there? Sure, I will update here. Mo

[Qemu-devel] [PULL 4/7] hw/arm: Mark the "fsl, imx31" device with user_creatable = false

2017-11-07 Thread Peter Maydell
From: Thomas Huth QEMU currently crashes when the user tries to instantiate the fsl,imx31 device manually: $ aarch64-softmmu/qemu-system-aarch64 -M kzm -device fsl,,imx31 ** ERROR:/home/thuth/devel/qemu/tcg/tcg.c:538:tcg_register_thread: assertion failed: (n < max_cpus) Aborted (core dumped) T

[Qemu-devel] [PULL 6/7] hw/intc/arm_gicv3_its: Fix the VM termination in vm_change_state_handler()

2017-11-07 Thread Peter Maydell
From: Shanker Donthineni The commit cddafd8f353d ("hw/intc/arm_gicv3_its: Implement state save /restore") breaks the backward compatibility with the older kernels where vITS save/restore support is not available. The vmstate function vm_change_state_handler() should not be registered if the runni

[Qemu-devel] [PULL 5/7] translate.c: Fix usermode big-endian AArch32 LDREXD and STREXD

2017-11-07 Thread Peter Maydell
For AArch32 LDREXD and STREXD, architecturally the 32-bit word at the lowest address is always Rt and the one at addr+4 is Rt2, even if the CPU is big-endian. Our implementation does these with a single 64-bit store, so if we're big-endian then we need to put the two 32-bit halves together in the o

[Qemu-devel] [PULL 0/7] target-arm queue

2017-11-07 Thread Peter Maydell
A small set of arm bugfixes for rc0. The following changes since commit 5853e92207193e967abf5e4c25b4a551c7604725: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-cocoa-20171107' into staging (2017-11-07 12:19:48 +) are available in the git repository

[Qemu-devel] [PULL 1/7] arm: implement cache/shareability attribute bits for PAR registers

2017-11-07 Thread Peter Maydell
From: Andrew Baumann On a successful address translation instruction, PAR is supposed to contain cacheability and shareability attributes determined by the translation. We previously returned 0 for these bits (in line with the general strategy of ignoring caches and memory attributes), but some g

[Qemu-devel] [PULL 2/7] hw/arm: Mark the "fsl, imx6" device with user_creatable = false

2017-11-07 Thread Peter Maydell
From: Thomas Huth This device causes QEMU to abort if the user tries to instantiate it: $ qemu-system-aarch64 -M sabrelite -smp 1,maxcpus=2 -device fsl,,imx6 Unexpected error in qemu_chr_fe_init() at chardev/char-fe.c:222: qemu-system-aarch64: -device fsl,,imx6: Device 'serial0' is in use Aborte

[Qemu-devel] [PULL 7/7] hw/intc/arm_gicv3_its: Don't abort on table save failure

2017-11-07 Thread Peter Maydell
From: Eric Auger The ITS is not fully properly reset at the moment. Caches are not emptied. After a reset, in case we attempt to save the state before the bound devices have registered their MSIs and after the 1st level table has been allocated by the ITS driver (device BASER is valid), the firs

[Qemu-devel] [PULL 3/7] hw/arm: Mark the "fsl, imx25" device with user_creatable = false

2017-11-07 Thread Peter Maydell
From: Thomas Huth QEMU currently crashes when the user tries to instantiate the fsl,imx25 device manually: $ aarch64-softmmu/qemu-system-aarch64 -S -M imx25-pdk -device fsl,,imx25 ** ERROR:/home/thuth/devel/qemu/tcg/tcg.c:538:tcg_register_thread: assertion failed: (n < max_cpus) The imx25-pdk

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-11-07 Thread R.Nageswara Sastry
This test case was working till 2.10.0 and got broken in 2.10.1 I checked with 2.9.1, 2.10.0-rc2, 2.10.0-rc3, 2.10.0-rc4, 2.10.0 Working scenario: # ./sparc64-softmmu/qemu-system-sparc64 -nographic -M sun4u -prom-env 'use-nvramrc?=true' -prom-env 'nvramrc=." Hello World!" cr' OpenBIOS for Sparc6

Re: [Qemu-devel] [PATCH v3 1/2] qdev_monitor: Simplify error handling in qdev_device_add()

2017-11-07 Thread Cornelia Huck
On Thu, 2 Nov 2017 11:10:05 +0100 Thomas Huth wrote: > Instead of doing the clean-ups on errors multiple times, introduce > a jump label at the end of the function that can be used by all > error paths that need this cleanup. > > Suggested-by: Igor Mammedov > Signed-off-by: Thomas Huth > ---

Re: [Qemu-devel] [PATCH 4/4] linux-user: Handle rt_sigaction correctly for SPARC

2017-11-07 Thread Laurent Vivier
Le 06/11/2017 à 19:33, Peter Maydell a écrit : > SPARC is like Alpha in its handling of the rt_sigaction syscall: > it takes an extra parameter 'restorer' which needs to be copied > into the sa_restorer field of the sigaction struct. The order > of the arguments differs slightly between SPARC and A

Re: [Qemu-devel] [PATCH v3 2/2] qdev: Check for the availability of a hotplug controller before adding a device

2017-11-07 Thread Cornelia Huck
On Thu, 2 Nov 2017 11:10:06 +0100 Thomas Huth wrote: > The qdev_unplug() function contains a g_assert(hotplug_ctrl) statement, > so QEMU crashes when the user tries to device_add + device_del a device > that does not have a corresponding hotplug controller. This could be > provoked for a couple

Re: [Qemu-devel] [Qemu-block] Drainage in bdrv_replace_child_noperm()

2017-11-07 Thread Kevin Wolf
Am 06.11.2017 um 19:49 hat Max Reitz geschrieben: > Hi everyone, > > On my quest to fix some flaky iotests, I came to a bit of a halt on 129. > (Details: Its issue is that block jobs now generally ignore throttling > in a BB (because they use their own), so we have to add a throttle node > instea

Re: [Qemu-devel] [PULL 0/7] target-arm queue

2017-11-07 Thread Peter Maydell
On 7 November 2017 at 13:35, Peter Maydell wrote: > A small set of arm bugfixes for rc0. > > > > The following changes since commit 5853e92207193e967abf5e4c25b4a551c7604725: > > Merge remote-tracking branch 'remotes/pmaydell/tags/pull-cocoa-20171107' > into

[Qemu-devel] [PULL v2 0/1] Merge IO 2017/11/06

2017-11-07 Thread Daniel P. Berrange
The following changes since commit 5853e92207193e967abf5e4c25b4a551c7604725: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-cocoa-20171107' into staging (2017-11-07 12:19:48 +) are available in the git repository at: git://github.com/berrange/qemu pull-2017-11-06-

[Qemu-devel] [PULL v2 1/1] sockets: avoid leak of listen file descriptor

2017-11-07 Thread Daniel P. Berrange
If we iterate over the full port range without successfully binding+listening on the socket, we'll try the next address, whereupon we overwrite the slisten file descriptor variable without closing it. Rather than having two places where we open + close socket FDs on different iterations of nested

Re: [Qemu-devel] [Qemu-arm] [PATCH 2/4] openrisc: fix float32 and float64 helper definitions

2017-11-07 Thread Philippe Mathieu-Daudé
On 11/03/2017 05:26 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier Acked-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé > --- > target/openrisc/fpu_helper.c | 52 > ++-- > target/openrisc/helper.h | 20 - >

Re: [Qemu-devel] [PULL v1 0/2] Merge IO 2017/11/06

2017-11-07 Thread Daniel P. Berrange
On Tue, Nov 07, 2017 at 09:19:45AM +, Daniel P. Berrange wrote: > On Mon, Nov 06, 2017 at 05:58:41PM +, Peter Maydell wrote: > > On 6 November 2017 at 17:43, Daniel P. Berrange wrote: > > > On Mon, Nov 06, 2017 at 04:11:56PM +, Peter Maydell wrote: > > >> On 6 November 2017 at 15:33, D

  1   2   3   4   >