[Qemu-devel] [PATCH 0/3] hw/arm: Mark the "fsl, imx" devices with user_creatable = false

2017-11-01 Thread Thomas Huth
These devices can not be used by the user directly and cause QEMU to abort() if the user tried it anyway. So simply mark the devices with user_creatable = false to avoid that the users can run into this unpleasant situation. Thomas Huth (3): hw/arm: Mark the "fsl,imx6" device with user_creatable

[Qemu-devel] [PATCH 2/3] hw/arm: Mark the "fsl, imx25" device with user_creatable = false

2017-11-01 Thread Thomas Huth
QEMU currently crashes when the user tries to instantiate the fsl,imx25 device manually: $ aarch64-softmmu/qemu-system-aarch64 -S -M imx25-pdk -device fsl,,imx25 ** ERROR:/home/thuth/devel/qemu/tcg/tcg.c:538:tcg_register_thread: assertion failed: (n < max_cpus) The imx25-pdk board (which is the

[Qemu-devel] [PATCH v6 00/13] Add support for the ZynqMP Generic QSPI

2017-11-01 Thread Francisco Iglesias
Hi, This patch series is an attempt to add support for the ZynqMP QSPI (consisting of the Generic QSPI and the legacy QSPI) to the xlnx-zcu102 board and connect Numonyx n25q512a11 flashes to the QSPI. Also some functionality is added to m25p80. The series starts by adding support in m25p80 for c

[Qemu-devel] [PATCH v6 07/13] xilinx_spips: Add support for RX discard and RX drain

2017-11-01 Thread Francisco Iglesias
Add support for the RX discard and RX drain functionality. Also transmit one byte per dummy cycle (to the flash memories) with commands that require these. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 167 +- include/hw/ssi/xilinx_

[Qemu-devel] [PATCH v6 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-11-01 Thread Francisco Iglesias
Add support for continuous read out of the RDSR and READ_FSR status registers until the chip select is deasserted. This feature is supported by amongst others 1 or more flashtypes manufactured by Numonyx (Micron), Windbond, SST, Gigadevice, Eon and Macronix. Signed-off-by: Francisco Iglesias ---

[Qemu-devel] [PATCH v6 04/13] m25p80: Add support for n25q512a11 and n25q512a13

2017-11-01 Thread Francisco Iglesias
Add support for Micron (Numonyx) n25q512a11 and n25q512a13 flashes. Signed-off-by: Francisco Iglesias Acked-by: Marcin Krzemiński Reviewed-by: Alistair Francis --- hw/block/m25p80.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 3f8154b..2f665

[Qemu-devel] [PATCH v6 02/13] m25p80: Add support for SST READ ID 0x90/0xAB commands

2017-11-01 Thread Francisco Iglesias
Add support for SST READ ID 0x90/0xAB commands for reading out the flash manufacuter ID and device ID. Signed-off-by: Francisco Iglesias Acked-by: Alistair Francis Acked-by: Marcin Krzemiński --- hw/block/m25p80.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/hw/

[Qemu-devel] [PATCH v6 13/13] xlnx-zcu102: Add support for the ZynqMP QSPI

2017-11-01 Thread Francisco Iglesias
Add support for the ZynqMP QSPI (consisting of the Generic QSPI and Legacy QSPI) and connect Numonyx n25q512a11 flashes to it. Signed-off-by: Francisco Iglesias Reviewed-by: Alistair Francis --- hw/arm/xlnx-zcu102.c | 23 +++ hw/arm/xlnx-zynqmp.c | 26 +++

[Qemu-devel] [PATCH v6 10/13] xilinx_spips: Add support for 4 byte addresses in the LQSPI

2017-11-01 Thread Francisco Iglesias
Add support for 4 byte addresses in the LQSPI and correct LQSPI_CFG_SEP_BUS. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/ssi/xilinx_spips.c index 3a98799..7f0f317 100644 --- a/hw/s

[Qemu-devel] [PATCH v6 08/13] xilinx_spips: Make tx/rx_data_bytes more generic and reusable

2017-11-01 Thread Francisco Iglesias
Make tx/rx_data_bytes more generic so they can be reused (when adding support for the Zynqmp Generic QSPI). Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 64 +-- 1 file changed, 37 insertions(+), 27 deletions(-) diff --git a/hw/ssi

[Qemu-devel] [PATCH v6 05/13] xilinx_spips: Move FlashCMD, XilinxQSPIPS and XilinxSPIPSClass

2017-11-01 Thread Francisco Iglesias
Move the FlashCMD enum, XilinxQSPIPS and XilinxSPIPSClass structures to the header for consistency (struct XilinxSPIPS is found there). Also move out a define and remove two dubbel included headers (while touching the code). Finally, add 4 byte address commands to the FlashCMD enum. Signed-off-by:

[Qemu-devel] [PATCH v6 11/13] xilinx_spips: Don't set TX FIFO UNDERFLOW at cmd done

2017-11-01 Thread Francisco Iglesias
Don't set TX FIFO UNDERFLOW interrupt after done transmiting the commands. Also update interrupts after reading out the interrupt status. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ssi/xilinx_spips.c b/hw/

[Qemu-devel] [PATCH v6 09/13] xilinx_spips: Add support for zero pumping

2017-11-01 Thread Francisco Iglesias
Add support for zero pumping according to the transfer size register. Signed-off-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c | 47 --- include/hw/ssi/xilinx_spips.h | 2 ++ 2 files changed, 42 insertions(+), 7 deletions(-) diff --git a/hw/ss

[Qemu-devel] [PATCH v6 06/13] xilinx_spips: Update striping to be big-endian bit order

2017-11-01 Thread Francisco Iglesias
Update striping functionality to be big-endian bit order (as according to the Zynq-7000 Technical Reference Manual). Output thereafter the even bits into the flash memory connected to the lower QSPI bus and the odd bits into the flash memory connected to the upper QSPI bus. Signed-off-by: Francisc

[Qemu-devel] [PATCH v6 12/13] xilinx_spips: Add support for the ZynqMP Generic QSPI

2017-11-01 Thread Francisco Iglesias
Add support for the Zynq Ultrascale MPSoc Generic QSPI. Signed-off-by: Francisco Iglesias --- default-configs/arm-softmmu.mak | 1 + hw/ssi/xilinx_spips.c | 574 include/hw/ssi/xilinx_spips.h | 32 ++- 3 files changed, 559 insertions(+), 48

[Qemu-devel] [PATCH v6 03/13] m25p80: Add support for BRRD/BRWR and BULK_ERASE (0x60)

2017-11-01 Thread Francisco Iglesias
Add support for the bank address register access commands (BRRD/BRWR) and the BULK_ERASE (0x60) command. Signed-off-by: Francisco Iglesias Acked-by: Marcin Krzemiński --- hw/block/m25p80.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 12f

[Qemu-devel] qemu disk use writeback don't take effect in centos 7.2 1511

2017-11-01 Thread Paul Schlacter
qemu version: 2.9.0 image: centos 7.2 1511 raw cache mode: writeback In centos7.2 time, the use of writeback and none, the result of dd disk is the same io, no change But I replaced centos7.1 centos7.3 centos7.4 when writeback was significantly faster than none Would like to ask what is going

Re: [Qemu-devel] [PULL 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq)

2017-11-01 Thread Gerd Hoffmann
Hi, > No one confirmed whether or not this new field needs to be added to > the > VMSTATE sections, and if so, how todo this in a back compatible > manner Good question. Sky isn't falling if we don't send this over, worst case is a minor keyboard glitch, affecting only the SysRq key, right

Re: [Qemu-devel] [Bug 1728615] [NEW] qemu-io crashes with SIGABRT and Assertion `c->entries[i].offset != 0' failed

2017-11-01 Thread Alberto Garcia
On Wed 01 Nov 2017 07:13:08 AM CET, Thomas Huth wrote: > On 30.10.2017 15:43, R.Nageswara Sastry wrote: >> Public bug reported: >> >> git is at HEAD a93ece47fd9edbd4558db24300056c9a57d3bcd4 >> This is on ppc64le architecture. >> >> Re-production steps: >> >> 1. Copy the attached files named back

Re: [Qemu-devel] qemu disk use writeback don't take effect in centos 7.2 1511

2017-11-01 Thread Dr. David Alan Gilbert
* Paul Schlacter (wlfigh...@gmail.com) wrote: > qemu version: 2.9.0 > image: centos 7.2 1511 raw > cache mode: writeback > > > In centos7.2 time, the use of writeback and none, the result of dd disk is > the same io, no change > > But I replaced centos7.1 centos7.3 centos7.4 when writeback was

Re: [Qemu-devel] [PULL 4/9] ps2: fix scancodes sent for Alt-Print key combination (aka SysRq)

2017-11-01 Thread Daniel P. Berrange
On Wed, Nov 01, 2017 at 08:58:32AM +0100, Gerd Hoffmann wrote: > Hi, > > > No one confirmed whether or not this new field needs to be added to > > the > > VMSTATE sections, and if so, how todo this in a back compatible > > manner > > Good question. Sky isn't falling if we don't send this o

Re: [Qemu-devel] [PATCH] io: Fix QIOChannelFile when creating and opening read-write

2017-11-01 Thread Daniel P. Berrange
On Tue, Oct 31, 2017 at 04:09:02PM +, Ross Lagerwall wrote: > The code wrongly passes the mode to open() only if O_WRONLY is set. > Instead, the mode should be passed when O_CREAT is set (or O_TMPFILE on > Linux). Fix this by always passing the mode since open() will correctly > ignore the mode

Re: [Qemu-devel] [PATCH] io: Fix QIOChannelFile when creating and opening read-write

2017-11-01 Thread Ross Lagerwall
On 11/01/2017 10:04 AM, Daniel P. Berrange wrote: On Tue, Oct 31, 2017 at 04:09:02PM +, Ross Lagerwall wrote: The code wrongly passes the mode to open() only if O_WRONLY is set. Instead, the mode should be passed when O_CREAT is set (or O_TMPFILE on Linux). Fix this by always passing the mod

Re: [Qemu-devel] [PATCH 1/7] sdl2: Fix broken display updating after the window is hidden

2017-11-01 Thread Gerd Hoffmann
On Mon, 2017-10-23 at 23:07 +0200, Jindrich Makovicka wrote: > With SDL 2.0.6, calling SDL_ShowWindow during SDL_WINDOWEVENT_HIDDEN > blocks all subsequent display updates. Hmm, yes, seems we confuse SDL that way. Also not letting the user hide the window isn't very nice (same for the _SHOWN even

Re: [Qemu-devel] [PATCH 2/7] sdl2: Do not quit the emulator when an auxilliary window is closed

2017-11-01 Thread Gerd Hoffmann
On Mon, 2017-10-23 at 23:07 +0200, Jindrich Makovicka wrote: > --- >  ui/sdl2.c | 10 +++--- >  1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/ui/sdl2.c b/ui/sdl2.c > index 7f51933234..aa37b39547 100644 > --- a/ui/sdl2.c > +++ b/ui/sdl2.c > @@ -566,9 +566,13 @@ static void han

[Qemu-devel] [Bug 1719339] Re: serial8250: too much work for irq3

2017-11-01 Thread Denys Zagorui
** Changed in: qemu Assignee: Denys Zagorui (dzagorui) => (unassigned) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719339 Title: serial8250: too much work for irq3 Status in QEMU: In Pro

Re: [Qemu-devel] [PATCH 4/7] sdl2: Only accept the hotkeys on the main window

2017-11-01 Thread Gerd Hoffmann
Why? > --- >  ui/sdl2.c | 2 +- >  1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ui/sdl2.c b/ui/sdl2.c > index 685e4fabec..fa54353430 100644 > --- a/ui/sdl2.c > +++ b/ui/sdl2.c > @@ -349,7 +349,7 @@ static void handle_keydown(SDL_Event *ev) >  } >  gui_key_modifier_pressed

Re: [Qemu-devel] [PATCH 5/7] sdl2 uses surface relative coordinates

2017-11-01 Thread Gerd Hoffmann
Why? Also I think this breaks the pointer in case window size doesn't match surface size. cheers, Gerd

Re: [Qemu-devel] [Bug 1728615] [NEW] qemu-io crashes with SIGABRT and Assertion `c->entries[i].offset != 0' failed

2017-11-01 Thread Alberto Garcia
On Wed 01 Nov 2017 09:55:21 AM CET, Alberto Garcia wrote: > On Wed 01 Nov 2017 07:13:08 AM CET, Thomas Huth wrote: >> On 30.10.2017 15:43, R.Nageswara Sastry wrote: >>> Public bug reported: >>> >>> git is at HEAD a93ece47fd9edbd4558db24300056c9a57d3bcd4 >>> This is on ppc64le architecture. >>> >>

Re: [Qemu-devel] qemu disk use writeback don't take effect in centos 7.2 1511

2017-11-01 Thread Paul Schlacter
Hi David: yes, with the same qemu, centos 7.2 guest cache is writeback and none, the disk io almost, writeback feeling no effect. but 7.1/7.3/7.4 cache is writeback was significantly faster than none model On Wed, Nov 1, 2017 at 8:02 PM, Paul Schlacter wrote: > Hi David: > yes,

[Qemu-devel] Buslogic scsi adapter. Problem with executing scsi commands.

2017-11-01 Thread Denis Dmitriev
Hi, I'm trying to implement a buslogic scsi adapter (BT-958) for qemu. As a basis I use its implementations in virtualbox. At the moment, it is possible to send commands and data through the ports. It is also possible to read data from kernel memory (mailboxes). The current problem is that I can no

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-11-01 Thread dann frazier
** Tags removed: verification-needed-zesty ** Tags added: verification-done-zesty -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1719196 Title: [arm64 ocata] newly created instances are unable to ra

[Qemu-devel] [PATCH v2 3/4] io: Don't call close multiple times in QIOChannelFile

2017-11-01 Thread Ross Lagerwall
If the file descriptor underlying QIOChannelFile is closed in the io_close() method, don't close it again in the finalize() method since the file descriptor number may have been reused in the meantime. Signed-off-by: Ross Lagerwall --- New in v2. io/channel-file.c | 1 + 1 file changed, 1 inser

[Qemu-devel] [PATCH v2 1/4] migration: Don't leak IO channels

2017-11-01 Thread Ross Lagerwall
Since qemu_fopen_channel_{in,out}put take references on the underlying IO channels, make sure to release our references to them. Signed-off-by: Ross Lagerwall --- New in v2. migration/savevm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/migration/savevm.c b/migration/savevm.c index 4a

[Qemu-devel] [PATCH v2 0/4] QIOChannelFile bug fixes

2017-11-01 Thread Ross Lagerwall
Hi, Here is a bug fix with the use of QIOChannelFile and 2 bug fixes and an improvement to implementation of QIOChannelFile. Regards, Ross Lagerwall Ross Lagerwall (4): migration: Don't leak IO channels io: Fix QIOChannelFile when creating and opening read-write io: Don't call close multip

[Qemu-devel] [PATCH v2 2/4] io: Fix QIOChannelFile when creating and opening read-write

2017-11-01 Thread Ross Lagerwall
The code wrongly passes the mode to open() only if O_WRONLY is set. Instead, the mode should be passed when O_CREAT is set (or O_TMPFILE on Linux). Fix this by always passing the mode since open() will correctly ignore the mode if it is not needed. Add a testcase which exercises this bug and also c

[Qemu-devel] [PATCH v2 4/4] io: Add /dev/fdset/ support to QIOChannelFile

2017-11-01 Thread Ross Lagerwall
Add /dev/fdset/ support to QIOChannelFile by calling qemu_open() instead of open() and qemu_close() instead of close(). There is a subtle semantic change since qemu_open() automatically sets O_CLOEXEC, but this doesn't affect any of the users of the function. Signed-off-by: Ross Lagerwall --- Cha

Re: [Qemu-devel] [PATCH 2/2] Add i82559a eepro100 interface

2017-11-01 Thread Nawrocki, Michael
On 10/31/17, 13:50, "Dr. David Alan Gilbert" wrote: * Mike Nawrocki (michael.nawro...@gtri.gatech.edu) wrote: > Signed-off-by: Mike Nawrocki > --- > hw/net/eepro100.c| 2 +- > hw/pci/pci.c | 2 ++ > include/hw/pci/pci.h | 1 + > qemu-options.hx | 2 +

Re: [Qemu-devel] [PATCH 0/2] Add 8-byte wide AMD flash support, partial interleaving

2017-11-01 Thread Nawrocki, Michael
On 10/31/17, 13:00, "Peter Maydell" wrote: On 31 October 2017 at 15:44, Mike Nawrocki wrote: > This patch set does a few things. First, it switches the AMD CFI flash MMIO > operations from the old MMIO API to the new one. Second, it enables 8-byte > wide flash arrays. Final

Re: [Qemu-devel] [PATCH v2 2/2] ui/cocoa.m: send ctrl-alt key combinations to guest if not used by QEMU

2017-11-01 Thread Programmingkid
> On Oct 31, 2017, at 10:52 AM, Peter Maydell wrote: > > On 31 October 2017 at 14:38, Peter Maydell wrote: >> On 5 October 2017 at 15:55, John Arbuckle wrote: >>> Send control-alt key combinations to the guest if not used by the user >>> interface. >>> >>> --- >>> v2 changes: >>> - changed l

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-11-01 Thread Dan Williams
> On 11/01/2017 12:25 PM, Dan Williams wrote: [..] >> It's not persistent memory if it requires a hypercall to make it >> persistent. Unless memory writes can be made durable purely with cpu >> instructions it's dangerous for it to be treated as a PMEM range. >> Consider a guest that tried to map i

Re: [Qemu-devel] [PATCH 2/2] Add i82559a eepro100 interface

2017-11-01 Thread Michael S. Tsirkin
On Wed, Nov 01, 2017 at 02:48:17PM +, Nawrocki, Michael wrote: > On 10/31/17, 13:50, "Dr. David Alan Gilbert" wrote: > > * Mike Nawrocki (michael.nawro...@gtri.gatech.edu) wrote: > > Signed-off-by: Mike Nawrocki > > --- > > hw/net/eepro100.c| 2 +- > > hw/pci/pci.c

[Qemu-devel] [PATCH 2/2] nbd/server: add assert to nbd_negotiate_handle_info

2017-11-01 Thread Vladimir Sementsov-Ogievskiy
Add an assert here to make last length assignment meaningful and following return without tail dropping obvious. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 1 + 1 file changed, 1 insertion(+) diff --git a/nbd/server.c b/nbd/server.c index 7fcec0af7e..bcf0cdb47c 100644 --- a/

[Qemu-devel] [PATCH 1/2] nbd/server: fix nbd_negotiate_handle_info

2017-11-01 Thread Vladimir Sementsov-Ogievskiy
namelen should be here, lenght is unrelated. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/server.c b/nbd/server.c index 70b40ed27e..7fcec0af7e 100644 --- a/nbd/server.c +++ b/nbd/server.c @@ -433,7 +433,7 @@

[Qemu-devel] [PATCH 2/4] qcow2: Prevent allocating L2 tables at offset 0

2017-11-01 Thread Alberto Garcia
If the refcount data is corrupted then we can end up trying to allocate a new L2 table at offset 0 in the image, triggering an assertion in the qcow2 cache that would crash QEMU: qcow2_cache_entry_mark_dirty: Assertion `c->entries[i].offset != 0' failed This patch adds an explicit check for thi

[Qemu-devel] [PATCH v5 00/15] qcow2: space preallocation and COW improvements

2017-11-01 Thread Anton Nefedov
v5: rebased, patches slightly reordered; cluster allocation (to avoid writing zero-buffers) now goes before an optional ahead preallocation v4: http://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg00109.html This pull request is to improve a few performance problems of qcow2 format:

[Qemu-devel] [PATCH 4/4] qcow2: Add iotest for an empty refcount table

2017-11-01 Thread Alberto Garcia
This patch adds a simple iotests in which we try to write to an image with an empty refcount table (i.e. with all entries set to 0). This scenario was already handled by the existing consistency checks, but we add an explicit test case for completeness. Signed-off-by: Alberto Garcia --- tests/q

[Qemu-devel] [PATCH v5 08/15] qcow2: skip writing zero buffers to empty COW areas

2017-11-01 Thread Anton Nefedov
If COW areas of the newly allocated clusters are zeroes on the backing image, efficient bdrv_write_zeroes(flags=BDRV_REQ_ALLOCATE) can be used on the whole cluster instead of writing explicit zero buffers later in perform_cow(). iotest 060: write to the discarded cluster does not trigger COW anymo

[Qemu-devel] [PATCH 3/4] qcow2: Don't open images with header.refcount_table_clusters == 0

2017-11-01 Thread Alberto Garcia
qcow2_do_open() is checking that header.refcount_table_clusters is not too large, but it doesn't check that it's greater than zero. Apart from the fact that an image like that is obviously corrupted, trying to use it crashes QEMU since we end up with a null s->refcount_table after qcow2_refcount_in

[Qemu-devel] [PATCH 1/4] qcow2: Prevent allocating refcount blocks at offset 0

2017-11-01 Thread Alberto Garcia
Each entry in the qcow2 cache contains an offset field indicating the location of the data in the qcow2 image. If the offset is 0 then it means that the entry contains no data and is available to be used when needed. Because of that it is not possible to store in the cache the first cluster of the

[Qemu-devel] [PATCH v5 02/15] blkverify: set supported write/zero flags

2017-11-01 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- block/blkverify.c | 9 + 1 file changed, 9 insertions(+) diff --git a/block/blkverify.c b/block/blkverify.c index 06369f9..9ba65d0 100644 --- a/block/blkverify.c +++ b/block/blkverify.c @@ -140,6 +140,15 @@ static int blkverify_open(BlockDriverState *bs,

[Qemu-devel] [PATCH v5 09/15] qcow2: preallocation at image expand

2017-11-01 Thread Anton Nefedov
From: "Denis V. Lunev" This patch adds image preallocation at expand to provide better locality of QCOW2 image file and optimize this procedure for some distributed storage where this procedure is slow. Preallocation is not issued upon writing metadata clusters. Possible conflicts are resolved

[Qemu-devel] [PATCH 0/4] Misc qcow2 corruption checks

2017-11-01 Thread Alberto Garcia
Misc qcow2 corruption checks This series contains a few checks that prevent QEMU from crashing under some scenarios with corrupted qcow2 images. The first patch solves the crash reported here: https://bugs.launchpad.net/qemu/+bug/1728615 And the others solve similar crashes that I detected in

[Qemu-devel] [PATCH v5 03/15] block: introduce BDRV_REQ_ALLOCATE flag

2017-11-01 Thread Anton Nefedov
The flag is supposed to indicate that the region of the disk image has to be sufficiently allocated so it reads as zeroes. The call with the flag set must return -ENOTSUP if allocation cannot be done efficiently. This has to be made sure of by both - the drivers that support the flag - and the

[Qemu-devel] [PATCH v5 11/15] qcow2: truncate preallocated space

2017-11-01 Thread Anton Nefedov
From: "Denis V. Lunev" This could be done after calculation of the end of data and metadata in the qcow2 image. Signed-off-by: Denis V. Lunev Signed-off-by: Anton Nefedov --- block/qcow2.h | 3 +++ block/qcow2-cluster.c | 9 + block/qcow2-refcount.c | 7 +++ block/qcow2.

[Qemu-devel] [PATCH v5 13/15] qcow2: do not zero out clusters if already preallocated

2017-11-01 Thread Anton Nefedov
if space preallocation feature is used, it can be detected that the space is already zeroes, so COW can be skipped without additional zeroing of the clusters. Signed-off-by: Anton Nefedov --- block/qcow2.h | 6 ++ block/qcow2-cluster.c | 2 ++ block/qcow2.c | 45 +++

[Qemu-devel] [PATCH v5 01/15] mirror: inherit supported write/zero flags

2017-11-01 Thread Anton Nefedov
Signed-off-by: Anton Nefedov Reviewed-by: Eric Blake --- block/mirror.c | 5 + 1 file changed, 5 insertions(+) diff --git a/block/mirror.c b/block/mirror.c index 307b639..19c8987 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1064,6 +1064,11 @@ static void bdrv_mirror_top_refresh_fil

[Qemu-devel] [PATCH v5 14/15] iotest 198: test BDRV_REQ_ALLOCATE

2017-11-01 Thread Anton Nefedov
Signed-off-by: Anton Nefedov --- tests/qemu-iotests/198 | 146 + tests/qemu-iotests/198.out | 50 tests/qemu-iotests/group | 1 + 3 files changed, 197 insertions(+) create mode 100755 tests/qemu-iotests/198 create mode 100644

[Qemu-devel] [PATCH v5 05/15] file-posix: support BDRV_REQ_ALLOCATE

2017-11-01 Thread Anton Nefedov
Current write_zeroes implementation is good enough to satisfy this flag too Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia --- block/file-posix.c | 8 1 file changed, 8 insertions(+) diff --git a/block/file-posix.c b/block/file-posix.c index 36ee89e..c36e156 100644 --- a/blo

[Qemu-devel] [PATCH v5 04/15] block: treat BDRV_REQ_ALLOCATE as serialising

2017-11-01 Thread Anton Nefedov
The idea is that ALLOCATE requests may overlap with other requests. Reuse the existing block layer infrastructure for serialising requests. Use the following approach: - mark ALLOCATE serialising, so subsequent requests to the area wait - ALLOCATE request itself must never wait if another reque

[Qemu-devel] [PATCH v5 07/15] qcow2: move is_zero() up

2017-11-01 Thread Anton Nefedov
To be used in the following commit without a forward declaration. Signed-off-by: Anton Nefedov --- block/qcow2.c | 35 +-- 1 file changed, 17 insertions(+), 18 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 92cb9f9..db759ce 100644 --- a/block/qcow2

[Qemu-devel] [PATCH v5 06/15] block: support BDRV_REQ_ALLOCATE in passthrough drivers

2017-11-01 Thread Anton Nefedov
Support the flag if the underlying BDS supports it Signed-off-by: Anton Nefedov Reviewed-by: Alberto Garcia --- block/blkdebug.c | 3 ++- block/blkverify.c | 2 +- block/mirror.c | 2 +- block/raw-format.c | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git a/block/blkd

[Qemu-devel] [PATCH v5 10/15] qcow2: set inactive flag

2017-11-01 Thread Anton Nefedov
Qcow2State and BlockDriverState flags have to be in sync Signed-off-by: Anton Nefedov --- block/qcow2.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/qcow2.c b/block/qcow2.c index 3899524..f41aaac 100644 --- a/block/qcow2.c +++ b/block/qcow2.c @@ -2184,6 +2184,7 @@ static int qcow2_i

[Qemu-devel] [PATCH v5 12/15] qcow2: check space leak at the end of the image

2017-11-01 Thread Anton Nefedov
From: Pavel Butsykin Preallocated space in the image may remain unused; the patch adds the functionality to identify and fix it in the qcow2_check to avoid wasting storage space on the host. Signed-off-by: Pavel Butsykin Signed-off-by: Denis V. Lunev Signed-off-by: Anton Nefedov --- block/qc

[Qemu-devel] [PATCH v5 15/15] iotest 134: test cluster-misaligned encrypted write

2017-11-01 Thread Anton Nefedov
COW (even empty/zero) areas require encryption too Signed-off-by: Anton Nefedov --- tests/qemu-iotests/134 | 9 + tests/qemu-iotests/134.out | 10 ++ 2 files changed, 19 insertions(+) diff --git a/tests/qemu-iotests/134 b/tests/qemu-iotests/134 index 9914415..6083ae4 100755

[Qemu-devel] [Bug 1728615] Re: qemu-io crashes with SIGABRT and Assertion `c->entries[i].offset != 0' failed

2017-11-01 Thread Alberto Garcia
The attached image is corrupted and QEMU doesn't handle it correctly. Here are the fixes for this and other related problems: https://lists.gnu.org/archive/html/qemu-block/2017-11/msg00010.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscri

[Qemu-devel] [PATCH v2] Make scrolling work again

2017-11-01 Thread John Arbuckle
Make scrolling in the monitor work. Signed-off-by: John Arbuckle --- ui/cocoa.m | 96 +- 1 file changed, 64 insertions(+), 32 deletions(-) diff --git a/ui/cocoa.m b/ui/cocoa.m index 93e56d0518..744fa31a56 100644 --- a/ui/cocoa.m +++ b/

Re: [Qemu-devel] [RFCPATCH06/20] replay: fix save/load vm for non-empty queue

2017-11-01 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20171031104813.3079.66585.stgit@pasha-VirtualBox Subject: [Qemu-devel] [RFCPATCH06/20] replay: fix save/load vm for non-empty queue === TEST SCRIPT BEGIN === #!/bin/bash # Testing script wil

Re: [Qemu-devel] [PULL 00/51] tcg queued patches

2017-11-01 Thread Thomas Huth
On 25.10.2017 11:34, Richard Henderson wrote: > Primarily Emilio's work toward removing tb_lock, with fixes. > But there are some other tcg-related patches that are queued. > > r~ > > The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b: > > Merge remote-tracking branch

[Qemu-devel] [PATCH] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debug --target-list=ppc64-softmmu ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter - This

Re: [Qemu-devel] [PATCH v2 3/4] io: Don't call close multiple times in QIOChannelFile

2017-11-01 Thread Marc-André Lureau
On Wed, Nov 1, 2017 at 3:25 PM, Ross Lagerwall wrote: > If the file descriptor underlying QIOChannelFile is closed in the > io_close() method, don't close it again in the finalize() method since > the file descriptor number may have been reused in the meantime. > > Signed-off-by: Ross Lagerwall

Re: [Qemu-devel] [PATCH v2 4/4] io: Add /dev/fdset/ support to QIOChannelFile

2017-11-01 Thread Marc-André Lureau
On Wed, Nov 1, 2017 at 3:25 PM, Ross Lagerwall wrote: > Add /dev/fdset/ support to QIOChannelFile by calling qemu_open() instead > of open() and qemu_close() instead of close(). There is a subtle > semantic change since qemu_open() automatically sets O_CLOEXEC, but this > doesn't affect any of the

Re: [Qemu-devel] [PATCH] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Peter Maydell
On 1 November 2017 at 17:53, Daniel Henrique Barboza wrote: > When executing 'configure' in a fresh QEMU clone, in a fresh > OS install running in a ppc64le host, this is the error > shown: > > - > > ../configure --enable-trace-backend=simple --enable-debug > --target-list=ppc64-softmmu >

Re: [Qemu-devel] [PATCH] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
On 11/01/2017 04:23 PM, Peter Maydell wrote: On 1 November 2017 at 17:53, Daniel Henrique Barboza wrote: When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debu

[Qemu-devel] [PATCH v2] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debug --target-list=ppc64-softmmu ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter - This

Re: [Qemu-devel] How to implement different endian accesses per MMU page?

2017-11-01 Thread Mark Cave-Ayland
On 15/08/17 19:10, Richard Henderson wrote: > [CC Peter re MemTxAttrs below] > > On 08/15/2017 09:38 AM, Mark Cave-Ayland wrote: >> Working through an incorrect endian issue on qemu-system-sparc64, it has >> become apparent that at least one OS makes use of the IE (Invert Endian) >> bit in the SP

Re: [Qemu-devel] [PATCH v2] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread no-reply
Hi, This series failed build test on ppc host. Please find the details below. Subject: [Qemu-devel] [PATCH v2] configure: adding ppc64le to supported host CPUs Type: series Message-id: 20171101191030.16136-1-danie...@linux.vnet.ibm.com === TEST SCRIPT BEGIN === #!/bin/bash # Testing script will

Re: [Qemu-devel] [PATCH v2] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
Ops, sorry about that. Resending On 11/01/2017 05:10 PM, Daniel Henrique Barboza wrote: When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debug --target

Re: [Qemu-devel] [PATCH v6 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-11-01 Thread mar.krzeminski
Hi Francisco, W dniu 01.11.2017 o 08:16, Francisco Iglesias pisze: Add support for continuous read out of the RDSR and READ_FSR status registers until the chip select is deasserted. This feature is supported by amongst others 1 or more flashtypes manufactured by Numonyx (Micron), Windbond, SST,

[Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debug --target-list=ppc64-softmmu ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter - This

[Qemu-devel] [PATCH v4] configure: do CC check before verifying host CPU

2017-11-01 Thread Daniel Henrique Barboza
When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debug --target-list=ppc64-softmmu ERROR: Unsupported CPU = ppc64le, try --enable-tcg-interpreter - This

Re: [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
The commit title/subject is misleading. I'll resend with a better commit title. On 11/01/2017 05:21 PM, Daniel Henrique Barboza wrote: When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-

Re: [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Philippe Mathieu-Daudé
Hi Daniel, On 11/01/2017 04:21 PM, Daniel Henrique Barboza wrote: > When executing 'configure' in a fresh QEMU clone, in a fresh > OS install running in a ppc64le host, this is the error > shown: > > - > > ../configure --enable-trace-backend=simple --enable-debug > --target-list=ppc64-so

Re: [Qemu-devel] [PATCH v4] configure: do CC check before verifying host CPU

2017-11-01 Thread Philippe Mathieu-Daudé
Maybe "configure: check $CC available before verifying host CPU" ? On 11/01/2017 04:31 PM, Daniel Henrique Barboza wrote: > When executing 'configure' in a fresh QEMU clone, in a fresh > OS install running in a ppc64le host, this is the error > shown: > > - > > ../configure --enable-trace-ba

Re: [Qemu-devel] [PATCH v3] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread Daniel Henrique Barboza
On 11/01/2017 05:34 PM, Philippe Mathieu-Daudé wrote: Hi Daniel, On 11/01/2017 04:21 PM, Daniel Henrique Barboza wrote: When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simpl

Re: [Qemu-devel] [PATCH v4] configure: do CC check before verifying host CPU

2017-11-01 Thread Daniel Henrique Barboza
On 11/01/2017 05:36 PM, Philippe Mathieu-Daudé wrote: Maybe "configure: check $CC available before verifying host CPU" ? If the maintainer is willing to amend the patch before pushing, works for me! Daniel On 11/01/2017 04:31 PM, Daniel Henrique Barboza wrote: When executing 'configur

Re: [Qemu-devel] [PATCH v4] configure: do CC check before verifying host CPU

2017-11-01 Thread Peter Maydell
On 1 November 2017 at 19:31, Daniel Henrique Barboza wrote: > When executing 'configure' in a fresh QEMU clone, in a fresh > OS install running in a ppc64le host, this is the error > shown: > > - > > ../configure --enable-trace-backend=simple --enable-debug > --target-list=ppc64-softmmu >

Re: [Qemu-devel] [PATCH v4] configure: do CC check before verifying host CPU

2017-11-01 Thread Daniel Henrique Barboza
On 11/01/2017 05:41 PM, Peter Maydell wrote: On 1 November 2017 at 19:31, Daniel Henrique Barboza wrote: When executing 'configure' in a fresh QEMU clone, in a fresh OS install running in a ppc64le host, this is the error shown: - ../configure --enable-trace-backend=simple --enable-debu

Re: [Qemu-devel] [PULL 00/51] tcg queued patches

2017-11-01 Thread Emilio G. Cota
On Wed, Nov 01, 2017 at 18:34:23 +0100, Thomas Huth wrote: > Seems like something in this patch series broke a couple of ARM boards > (smdkc210, nuri, raspi2, xlnx-ep108 and xlnx-zcu102). With current > master branch, I just get this error: > > $ aarch64-softmmu/qemu-system-aarch64 -machine raspi

Re: [Qemu-devel] [RFCPATCH10/20] icount: fixed saving/restoring of icount warp timers

2017-11-01 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFCPATCH10/20] icount: fixed saving/restoring of icount warp timers Type: series Message-id: 20171031104835.3079.2722.stgit@pasha-VirtualBox === TEST SCRIPT BEGIN === #!/bin/b

Re: [Qemu-devel] [PATCH v6 01/13] m25p80: Add support for continuous read out of RDSR and READ_FSR

2017-11-01 Thread francisco iglesias
On 1 November 2017 at 20:20, mar.krzeminski wrote: > Hi Francisco, > > W dniu 01.11.2017 o 08:16, Francisco Iglesias pisze: > > Add support for continuous read out of the RDSR and READ_FSR status >> registers until the chip select is deasserted. This feature is supported >> by amongst others 1 or

Re: [Qemu-devel] [PATCH v2] configure: adding ppc64le to supported host CPUs

2017-11-01 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH v2] configure: adding ppc64le to supported host CPUs Type: series Message-id: 20171101191030.161

Re: [Qemu-devel] [Qemu-block] [PATCH v3 16/46] hw/ide: Replace fprintf(stderr, "*\n" with error_report()

2017-11-01 Thread John Snow
On 10/24/2017 11:56 AM, Philippe Mathieu-Daudé wrote: > Hi Alistair, > > On 10/19/2017 01:16 PM, Alistair Francis wrote: >> Replace a large number of the fprintf(stderr, "*\n" calls with >> error_report(). The functions were renamed with these commands and then >> compiler issues where manually

Re: [Qemu-devel] [PATCH v4] configure: do CC check before verifying host CPU

2017-11-01 Thread Peter Maydell
On 1 November 2017 at 19:46, Daniel Henrique Barboza wrote: > On 11/01/2017 05:41 PM, Peter Maydell wrote: >> I think that currently we try to make "--help" work >> even if you don't have a working C compiler. Does this >> break that? > > Just checked, configure --help isn't broken with this chang

[Qemu-devel] [PATCH 0/5 v2] CAN bus support for QEMU (SJA1000 PCI so far)

2017-11-01 Thread pisa
From: Pavel Pisa Basic emulation of CAN bus controller and interconnection for QEMU. Patches version 2: The bus emulation and the SJA1000 chip emulation introduced by individual patches as suggested by Frederic Konrad. Simple example board to test SJA1000 as single memory-mapped BAR has been omi

[Qemu-devel] [PATCH 1/5] CAN bus simple messages transport implementation for QEMU

2017-11-01 Thread pisa
From: Pavel Pisa The CanBusState state structure is created for each emulated CAN channel. Individual clients/emulated CAN interfaces or host interface connection registers to the bus by CanBusClientState structure. Connection to the real host CAN bus network through SocketCAN network interface

[Qemu-devel] [PATCH 4/5] CAN bus PCM-3680I PCI (dual SJA1000 channel) emulation added.

2017-11-01 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_pcm3680_pci.c | 335 +++ 2 files changed, 336 insertions(+) create mode 100644 hw/can/can_pcm3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can/Makefile.o

[Qemu-devel] [PATCH 3/5] CAN bus Kvaser PCI CAN-S (single SJA1000 channel) emulation added.

2017-11-01 Thread pisa
From: Pavel Pisa Signed-off-by: Pavel Pisa --- default-configs/pci.mak | 1 + hw/can/Makefile.objs| 1 + hw/can/can_kvaser_pci.c | 376 3 files changed, 378 insertions(+) create mode 100644 hw/can/can_kvaser_pci.c diff --git a/default-c

[Qemu-devel] [PATCH 2/5] CAN bus SJA1000 chip register level emulation for QEMU

2017-11-01 Thread pisa
From: Pavel Pisa The core SJA1000 support is independent of following patches which map SJA1000 chip to PCI boards. The work is based on Jin Yang GSoC 2013 work funded by Google and mentored in frame of RTEMS project GSoC slot donated to QEMU. Rewritten for QEMU-2.0+ versions and architecture c

[Qemu-devel] [PATCH 5/5] CAN bus MIOe-3680 PCI (dual SJA1000 channel) emulation added.

2017-11-01 Thread pisa
From: Deniz Eren Signed-off-by: Pavel Pisa --- hw/can/Makefile.objs | 1 + hw/can/can_mioe3680_pci.c | 335 ++ 2 files changed, 336 insertions(+) create mode 100644 hw/can/can_mioe3680_pci.c diff --git a/hw/can/Makefile.objs b/hw/can/Makefile

  1   2   >