On Thu, Oct 26, 2017 at 11:54:59AM +1100, Alexey Kardashevskiy wrote:
> On 26/10/17 08:11, Daniel P. Berrange wrote:
> > On Wed, Oct 25, 2017 at 07:10:40PM +1100, Alexey Kardashevskiy wrote:
> >> On 25/10/17 17:57, Daniel P. Berrange wrote:
> >>> On Wed, Oct 25, 2017 at 12:45:10PM +1100, Alexey Kar
On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> a stub is now provided.
>
> Signed-off-by: Philippe Mathieu-Daudé
> Tested-by: Richard W.M. Jones
Reviewed-by: Amarnath Valluri
> ---
> vl.c | 2 --
> 1 file changed, 2 deletions(-)
> Reviewed-by:
> diff --git a/vl.c b/vl.c
>
On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> Makefile.objs now checks for $(CONFIG_TPM).
>
> Suggested-by: Stefan Berger
> Signed-off-by: Philippe Mathieu-Daudé
> ---
Reviewed-by: Amarnath Valluri
> tpm.c | 4
> 1 file changed, 4 deletions(-)
>
> diff --git a/tpm.
I've tried the recent QEMU 2.10 (Windows build
qemu-w64-setup-20171006.exe) and the bug is still there. It hangs right
after "Getting ready to run Windows 95 for the first time..." screen.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEM
On Tue, 2017-10-24 at 09:20 -0300, Philippe Mathieu-Daudé wrote:
> Commit c37cacabf22 moved tpm_cleanup() in the main loop exit, however
> this
> function is not available when compiling with --disable-tpm.
>
> Provides necessary stubs to keep code clean of #ifdef'fery.
>
> Reported-by: BALATON Z
On Thu, Oct 26, 2017 at 07:16:45AM +0100, Peter Maydell wrote:
> On 26 October 2017 at 07:07, Peter Maydell wrote:
> > Hi. This failed to build for Windows:
>
> Also, after it failed and I backed out the merge, the next thing I
> tried to build failed everywhere with:
>
> warning: unable to rmdi
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> After the previous commits, we make sure that the value passed is
>> right, or we just drop an error. So now we return if there is one
>> error or we have setup correctly the value passed.
>>
>> Signed-off-by: Juan
On 10/26/2017 08:07 AM, Peter Maydell wrote:
> On 25 October 2017 at 13:30, Richard Henderson
> wrote:
>> Support for Capstone, plus an arm32 fix.
>>
>>
>> r~
>>
>>
>> The following changes since commit 3d7196d43bfe12efe98568cb60057e273652b99b:
>>
>> Merge remote-tracking branch
>> 'remotes/kra
On 2017-10-26 03:06, Changlimin wrote:
> share-rw=on is good for raw format file, but bad for qcow2 format file:
>
> Failed to get "write" lock
> Is another process using the image?
>
> Is this intented?
Yes, because you can never share qcow2 image files between VMs. The
qcow2 format itself doe
Hi Alexey,
On Thu, Oct 26, 2017 at 12:34:45PM +1100, Alexey Kardashevskiy wrote:
The new git-submodule.sh script writes .git-submodule-status to
the source directory every time no matter what. This makes it conditional.
Signed-off-by: Alexey Kardashevskiy
---
Changes:
v2:
* fixed "status" bran
If the qcow2 file is created with preallocation=full, I think metadata will not
corrupt when it is shared between two vms? Snapshot is not required.
Is this right?
BR
Chang limin
-Original Message-
From: Max Reitz [mailto:mre...@redhat.com]
Sent: Thursday, October 26, 2017 3:12 PM
To:
On 26 October 2017 at 08:06, Daniel P. Berrange wrote:
> I'm not sure what's giving you the 'pathspec' message though ? I would
> expect anything to ignore the capstone dir - its just like any other
> untracked file once you go back in time before it was committed.
Sorry, just realized that was t
On 2017-10-26 09:18, Changlimin wrote:
> If the qcow2 file is created with preallocation=full, I think metadata will
> not corrupt when it is shared between two vms? Snapshot is not required.
>
> Is this right?
I wouldn't count on it.
If you really want to take the risk, you can probably use t
On 26/10/17 18:02, Daniel P. Berrange wrote:
> On Thu, Oct 26, 2017 at 11:54:59AM +1100, Alexey Kardashevskiy wrote:
>> On 26/10/17 08:11, Daniel P. Berrange wrote:
>>> On Wed, Oct 25, 2017 at 07:10:40PM +1100, Alexey Kardashevskiy wrote:
On 25/10/17 17:57, Daniel P. Berrange wrote:
> On W
Instead of repeating the code, we are going to bo more tests on this file
Signed-off-by: Juan Quintela
---
MAINTAINERS | 1 +
tests/Makefile.include | 6 +++---
tests/{postcopy-test.c => migration-test.c} | 8 +++-
3 files changed, 7 inser
Hi
This is on top of my set_cache_size series.
big changes is this v2:
- to make review easier, I started renaming postcopy-test.c to migration-test.c
- Did cleanups/refactoring there
- Don't use global-qtest anymore
- check that the parameters that we sent got really set
- RFH: comrpress thread
As we have two guests running, just pass always who we want to send a
message to. Once there, refactor return_or_event() into wait_command.
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 55 +-
1 file changed, 27 insertions(+), 28 delet
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index a8718770c9..338254bafe 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -620,6 +620,13 @@ static void test_p
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index c429a13403..be598d3257 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@
Once there, make postcopy test to use the new commands now that we
have other test for deprecated ones
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 48 ++--
1 file changed, 46 insertions(+), 2 deletions(-)
diff --git a/tests/migration-tes
So we can use them in future tests
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 101 +++--
1 file changed, 64 insertions(+), 37 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 55c4aed719..19a1445076 100644
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 68 --
1 file changed, 66 insertions(+), 2 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index be598d3257..a8718770c9 100644
--- a/tests/migration-test.c
+++ b/te
We fix global_test users left and right
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 86 --
1 file changed, 48 insertions(+), 38 deletions(-)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 19a1445076..91fb0277d6 10
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 66 ++
1 file changed, 66 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index b72dff3917..db30b3864b 100644
--- a/tests/migration-test.c
+++ b/tests/migration-te
Yeap, it is still not working. trying to learn how to debug threads
for guests running from the testt hardness.
For some reason, compression is not working at the moment, test is
disabled until I found why.
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 51 +++
qemu-img commit invalidates all images between base and top. This
should be mentioned in the man page.
Suggested-by: Ping Li
Signed-off-by: Max Reitz
---
qemu-img.texi | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/qemu-img.texi b/qemu-img.texi
index ee5c5940d3..f
Hi,
Sorry for taking so long to review it:
On Mon, Oct 23, 2017 at 09:33:42AM +0800, Dou Liyang wrote:
> Linux and Windows need ACPI SRAT table to make memory hotplug work properly,
> however currently QEMU doesn't create SRAT table if numa options aren't
> present
> on CLI.
>
> Which breaks bo
Running "qemu-system-ppc64 -machine prep -device i82374" creates an ISA
bus with two i82374 DMA controllers - one is implicit from ppc_prep_init(),
the other one is from "-device i82374". QEMU asserts but it is not
immediately clear why.
This adds an error message to explain the failure.
Signed-o
On 25.10.2017 18:45, Marc Hartmayer wrote:
> On Wed, Oct 25, 2017 at 05:50 PM +0200, David Hildenbrand
> wrote:
>> On 25.10.2017 17:09, Boris Fiuczynski wrote:
>>> On 10/25/2017 12:23 PM, David Hildenbrand wrote:
On 25.10.2017 12:18, Christian Borntraeger wrote:
> Ping, I plan to submit
On Thu, Oct 26, 2017 at 09:59:47AM +0200, Max Reitz wrote:
> qemu-img commit invalidates all images between base and top. This
> should be mentioned in the man page.
>
> Suggested-by: Ping Li
> Signed-off-by: Max Reitz
> ---
> qemu-img.texi | 9 -
> 1 file changed, 4 insertions(+), 5 d
On 10/26/2017 01:35 AM, Halil Pasic wrote:
try the most interesting scenarios out.
>
> The idea of the patch is very clear, but I don't understand the bigger gs
> feature context fully.
>
> From what I read in the code, the attempt to enable the gs capability in
> the kernel is made regardless
** Changed in: qemu
Status: Incomplete => Triaged
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1342686
Title:
Windows 95 setup hangs
Status in QEMU:
Triaged
Bug description:
Windows 9
This commit:
commit 55c3ceef61fcf06fc98ddc752b7cce788ce7680b
Author: Richard Henderson
Date: Sun Oct 15 19:02:42 2017 -0700
qom: Introduce CPUClass.tcg_initialize
Brocke compilation without CONFIG_TCG
Signed-off-by: Juan Quintela
CC: Richard Henderson
---
target/i386/cpu.c | 2 ++
1 f
On Fri, 20 Oct 2017 16:54:37 +0200
Christian Borntraeger wrote:
> Starting a guest with
>
> hvm
>
>
>
> on an IBM z14 results in
>
> "qemu-system-s390x: Some features requested in the CPU model are not
> available in the configuration: gs"
>
> This is because guarded storage is f
On 26/10/17 18:13, Darren Kenny wrote:
> Hi Alexey,
>
> On Thu, Oct 26, 2017 at 12:34:45PM +1100, Alexey Kardashevskiy wrote:
>> The new git-submodule.sh script writes .git-submodule-status to
>> the source directory every time no matter what. This makes it conditional.
>>
>> Signed-off-by: Alexey
On 26 October 2017 at 08:45, Alexey Kardashevskiy wrote:
> Submodules change once/twice a year so we could live quite happily without
> this automation imho.
This is a significant underestimate. The openbios submodule alone
has been updated 12 times this year.
> What if I do not want submodules
On Mon, Oct 23, 2017 at 10:23:43AM -0700, Prasad Singamsetty wrote:
[...]
> >>Proposal:
> >>
> >>We can simply change the VTD_HOST_ADDRESS_WIDTH to 48 bits
> >>with out any other changes to the code. The current set of
> >>features in the intel iommu emulator code works for q35
> >>machine type a
On Thu, Oct 26, 2017 at 07:18:24PM +1100, Alexey Kardashevskiy wrote:
On 26/10/17 18:13, Darren Kenny wrote:
Hi Alexey,
On Thu, Oct 26, 2017 at 12:34:45PM +1100, Alexey Kardashevskiy wrote:
The new git-submodule.sh script writes .git-submodule-status to
the source directory every time no matte
On 26/10/17 19:51, Darren Kenny wrote:
> On Thu, Oct 26, 2017 at 07:18:24PM +1100, Alexey Kardashevskiy wrote:
>> On 26/10/17 18:13, Darren Kenny wrote:
>>> Hi Alexey,
>>>
>>> On Thu, Oct 26, 2017 at 12:34:45PM +1100, Alexey Kardashevskiy wrote:
The new git-submodule.sh script writes .git-subm
I don't know if this process is:
1. qemu call kernel API to alloc 40G memory.
2. qemu process is killed by hand.
3. kernel alloc 40G memory, but qemu process is down, then this 40G is left
in kernel.
2017-10-26 11:54 GMT+08:00 Sam :
> BTW, I start VM by this command, and then stop it, then memory
On Wed, Oct 25, 2017 at 4:29 AM, Subbaraya Sundeep
wrote:
> Fixed incorrect frame size mask, validated maximum frame
> size in spi_write and removed dead code.
>
> Signed-off-by: Subbaraya Sundeep
Reviewed-by: Alistair Francis
> ---
> v4:
> changed %d to %u while logging frame size err
On 10/26/2017 10:18 AM, Juan Quintela wrote:
> This commit:
>
> commit 55c3ceef61fcf06fc98ddc752b7cce788ce7680b
> Author: Richard Henderson
> Date: Sun Oct 15 19:02:42 2017 -0700
>
> qom: Introduce CPUClass.tcg_initialize
>
> Brocke compilation without CONFIG_TCG
>
> Signed-off-by: Juan
At 2017-10-26 05:58:07, "Michael Roth" wrote:
>Quoting Tomáš Golembiovský (2017-09-29 16:31:02)
>> On Fri, 29 Sep 2017 17:11:22 +0800
>> Chen Hanxiao wrote:
>>
>> > From: Chen Hanxiao
>> >
>> > On some of windows (win08 sp2),
>> > it doesn't work by calling LookupAccountSidW with
>> > well-k
On Mon, Oct 23, 2017 at 1:14 PM, Philippe Mathieu-Daudé wrote:
> On 10/17/2017 07:31 PM, Alistair Francis wrote:
>> List all possible valid CPU options.
>>
>> Signed-off-by: Alistair Francis
>> ---
>>
>> An implementation for single CPU machines is still being discussed. A
>> solution proposed by
Quoting Chen Hanxiao (2017-10-26 04:27:40)
>
>
> At 2017-10-26 05:58:07, "Michael Roth" wrote:
> >Quoting Tomáš Golembiovský (2017-09-29 16:31:02)
> >> On Fri, 29 Sep 2017 17:11:22 +0800
> >> Chen Hanxiao wrote:
> >>
> >> > From: Chen Hanxiao
> >> >
> >> > On some of windows (win08 sp2),
> >
Do not require the submodule, but use it if present. Allow the
command-line to override system or git submodule either way.
Tested-by: Philippe Mathieu-Daudé
Reviewed-by: Philippe Mathieu-Daudé
Signed-off-by: Richard Henderson
---
Makefile| 15 ++
.gitmodules | 3 +++
capston
quest'
into staging (2017-10-24 16:05:57 +0100)
are available in the git repository at:
git://github.com/rth7680/qemu.git tags/pull-dis-20171026
for you to fetch changes up to e219c499e9f5d4fa0e25dc07682f75531ee84d86:
disas: Add capstone as submodule (2017-10-26 11:5
On 10/26/2017 09:21 AM, Peter Maydell wrote:
> On 26 October 2017 at 08:06, Daniel P. Berrange wrote:
>> I'm not sure what's giving you the 'pathspec' message though ? I would
>> expect anything to ignore the capstone dir - its just like any other
>> untracked file once you go back in time before
Triaging old bug tickets... can you still reproduce this issue with the
latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QE
On Thu, Oct 26, 2017 at 08:21:48AM +0100, Peter Maydell wrote:
> On 26 October 2017 at 08:06, Daniel P. Berrange wrote:
> > I'm not sure what's giving you the 'pathspec' message though ? I would
> > expect anything to ignore the capstone dir - its just like any other
> > untracked file once you go
On 25/10/17 18:47, Peter Maydell wrote:
> On 25 October 2017 at 16:59, Mark Cave-Ayland
> wrote:
>> This enables them to be used outside of lance.c.
>>
>> Signed-off-by: Mark Cave-Ayland
>> CC: Jason Wang
>
>
>> diff --git a/include/hw/net/lance.h b/include/hw/net/lance.h
>> new file mode 100
Since libcacard is not longer part of QEMU, I assume this is not an
issue anymore today. So can we close this bug nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://
Triaging old bug tickets... can you still reproduce this issue with the
latest version of QEMU? Or could we close this ticket nowadays?
** Changed in: qemu
Status: New => Incomplete
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QE
On Thu, Oct 26, 2017 at 08:03:24PM +1100, Alexey Kardashevskiy wrote:
On 26/10/17 19:51, Darren Kenny wrote:
On Thu, Oct 26, 2017 at 07:18:24PM +1100, Alexey Kardashevskiy wrote:
On 26/10/17 18:13, Darren Kenny wrote:
Hi Alexey,
On Thu, Oct 26, 2017 at 12:34:45PM +1100, Alexey Kardashevskiy w
On 10/26/2017 10:13 AM, Christian Borntraeger wrote:
>
>
> On 10/26/2017 01:35 AM, Halil Pasic wrote:
> try the most interesting scenarios out.
>>
>> The idea of the patch is very clear, but I don't understand the bigger gs
>> feature context fully.
>>
>> From what I read in the code, the atte
There seem to be some bugs in these patches, causing my VM failed to boot.
Test case:
0. Merge these 3 patches in to release 2.10.1
1. qemu-system-x86_64_2.10.1 ... \
-device vfio-pci,host=04:00.0 \
-device vfio-pci,host=05:00.0 \
-device vfio-pci,host=08:00.0 \
-device vfio-pci,host=09:00.0 \
From: Richard Henderson
The implementation of these two instructions was swapped.
At the same time, unify the setup of eflags for the insn group.
Reported-by: Ricardo Ribalda Delgado
Signed-off-by: Richard Henderson
---
target/i386/translate.c | 26 +-
1 file changed,
From: Richard Henderson
Signed-off-by: Richard Henderson
---
target/i386/translate.c | 46 --
1 file changed, 32 insertions(+), 14 deletions(-)
diff --git a/target/i386/translate.c b/target/i386/translate.c
index 7df9233ded..db88cc4764 100644
--- a/t
From: Richard Henderson
Reported-by: Ricardo Ribalda Delgado
Signed-off-by: Richard Henderson
---
target/i386/cc_helper_template.h | 18 ++
target/i386/cpu.h| 7 ++-
target/i386/cc_helper.c | 28 +++--
target/i386/cpu.c| 3 +-
target/i386/
Resurrecting some patches that were on the list in July.
There are two bug fixes in here, so we should at least
get those into 2.11.
Changes since v1:
* Rebased, adjusting for x86_ldub_code.
r~
Ricardo Ribalda Delgado (1):
target/i386: Fix ANDN (bmi)
Richard Henderson (3):
target/i386:
From: Ricardo Ribalda Delgado
Operands on ANDN are swapped.
Tested with the following function:
long test_andn(long v1, long v2){
return (~v1 & v2);
}
Compiled with:
gcc kk.c -mbmi -O3 -Wall
0910 :
910:c4 e2 c0 f2 c6 andn %rsi,%rdi,%rax
915:c3
At 2017-10-26 17:59:34, "Michael Roth" wrote:
>Quoting Chen Hanxiao (2017-10-26 04:27:40)
>>
>>
>> At 2017-10-26 05:58:07, "Michael Roth" wrote:
>> >Quoting Tomáš Golembiovský (2017-09-29 16:31:02)
>> >> On Fri, 29 Sep 2017 17:11:22 +0800
>> >> Chen Hanxiao wrote:
>> >>
>> >> > From: Chen Ha
Hi
On Mon, Oct 23, 2017 at 5:13 PM, Vadim Galitsyn <
vadim.galit...@profitbricks.com> wrote:
> Add support for `writeconfig' command for QMP monitor.
> This is a simple way to keep track of current state of VM
> after series of hotplugs and/or hotunplugs of different devices.
>
> Signed-off-by: V
On Fri 29 Sep 2017 06:53:27 PM CEST, Max Reitz wrote:
> Besides being safe for arbitrary path lengths, after some follow-up
> patches all callers will want a freshly allocated buffer anyway.
>
> In the meantime, path_combine_deprecated() is added which has the same
> interface as path_combine() had
On 30.06.2017 20:37, Richard Henderson wrote:
> Cc: qemu-...@nongnu.org
> Signed-off-by: Richard Henderson
> ---
> target/ppc/translate.c | 23 ---
> 1 file changed, 8 insertions(+), 15 deletions(-)
*ping*
Richard, David, any chance that we can still get this in for 2.11? I
On Thu, Oct 26, 2017 at 12:34:45PM +1100, Alexey Kardashevskiy wrote:
> The new git-submodule.sh script writes .git-submodule-status to
> the source directory every time no matter what. This makes it conditional.
>
> Signed-off-by: Alexey Kardashevskiy
> ---
> Changes:
> v2:
> * fixed "status" br
On Mon, Aug 21, 2017 at 10:22:15AM +0800, Lan Tianyu wrote:
> On 2017年08月19日 00:38, Eduardo Habkost wrote:
> > On Thu, Aug 17, 2017 at 09:37:10AM +0800, Lan Tianyu wrote:
> >> On 2017年08月16日 19:21, Paolo Bonzini wrote:
> >>> On 16/08/2017 02:22, Lan Tianyu wrote:
> Xen vIOMMU device model will
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert" wrote:
> > * Juan Quintela (quint...@redhat.com) wrote:
> >> After the previous commits, we make sure that the value passed is
> >> right, or we just drop an error. So now we return if there is one
> >> error or we have setup
This implements a testcase for pxe-test using the vhost-user interface. Spawn a
vhost-user-bridge process and connect it to the qemu process
v2->v3:
* rebase to current master
* run test with slow test cases, as it takes a bit of time
Jens Freimann (2):
tests/vhost-user-bridge: disable debug
From: Jens Freimann
vhost-user-bridge prints out a lot of information, including dumps
of all transmitted data. When called from a testcase this output
clutters the actual test results, so let's make the default no debug
output.
Reviewed-by: Maxime Coquelin
Signed-off-by: Jens Freimann
---
te
From: Jens Freimann
Add a PXE testcase tunneling traffic through vhost-user-bridge process.
Create a vhost-user-bridge process and connect it to qemu via a socket.
Signed-off-by: Jens Freimann
---
tests/Makefile.include | 4 +-
tests/pxe-test.c | 111 +++
On Wed, Oct 25, 2017 at 11:35:04AM +0200, Richard Henderson wrote:
> Move target cpu tcg initialization to common code,
> called from cpu_exec_realizefn.
>
> Acked-by: Andreas Färber
> Reviewed-by: Emilio G. Cota
> Reviewed-by: Philippe Mathieu-Daudé
> Signed-off-by: Richard Henderson
It look
If I've got the comments right, this bug has been fixed, so closing this
now. If there is an issue remaining, please open a new bug.
** Changed in: qemu
Status: New => Fix Released
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEM
This patch replaces the use of numpy with the standard Library struct module
where possible.
Signed-off-by: Joannah Nanjekye
---
scripts/analyze-migration.py | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/scripts/analyze-migration.py b/scripts/analyze
Am 26.10.2017 um 09:59 hat Max Reitz geschrieben:
> qemu-img commit invalidates all images between base and top. This
> should be mentioned in the man page.
>
> Suggested-by: Ping Li
> Signed-off-by: Max Reitz
Thanks, applied to the block branch.
Kevin
Some people building QEMU use VPATH builds where the source directory is on a
read-only volume. In such a case 'scripts/git-submodules.sh update' will always
fail and users are required to run it manually themselves on their original
writable source directory.
While this is already supported, it i
There are cases where users do VPATH builds with the source directory being on
a read-only volume. In such a case they have to manually run the command
'git-submodule.sh ...modules...' manually ahead of time. When checking for
status we should not then write into the source dir.
Signed-off-by: Da
This changes test case 191 to include a backing image that has
backing_fmt set in the image file, but is referenced by node name in the
qemu command line.
Signed-off-by: Kevin Wolf
Reviewed-by: Eric Blake
---
tests/qemu-iotests/191 | 3 ++-
tests/qemu-iotests/191.out | 2 +-
2 files changed
From: Eric Blake
Not all callers care about which BDS owns the mapping for a given
range of the file, or where the zeroes lie within that mapping. In
particular, bdrv_is_allocated() cares more about finding the
largest run of allocated data from the guest perspective, whether
or not that data is
The following changes since commit ae49fbbcd8e4e9d8bf7131add34773f579e1aff7:
Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20171025' into
staging (2017-10-25 16:38:57 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/kevin.git tags/for-upstream
for you to fetch
From: Eric Blake
Not all callers care about which BDS owns the mapping for a given
range of the file. This patch merely simplifies the callers by
consolidating the logic in the common call point, while guaranteeing
a non-NULL file to all the driver callbacks, for no semantic change.
The only cal
From: Eric Blake
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Change the internal
loop iteration of zeroing a device to track by bytes instead of
sectors (although we are still guaranteed that we iterate by steps
that are sector-alig
From: Peter Krempa
When referring to a backing file of an image via node name
bdrv_open_backing_file would add the 'driver' option to the option list
filling it with the backing format driver. This breaks construction of
the backing chain via -blockdev, as bdrv_open_inherit reports an error
if bo
From: Eric Blake
Compare the following images with all-zero contents:
$ truncate --size 1M A
$ qemu-img create -f qcow2 -o preallocation=off B 1G
$ qemu-img create -f qcow2 -o preallocation=metadata C 1G
On my machine, the difference is noticeable for pre-patch speeds,
with more than an order of
From: Eric Blake
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end o
From: Eric Blake
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change).
Signed-off-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/io.c | 61 ++-
From: Eric Blake
In the process of converting sector-based interfaces to bytes,
I'm finding it easier to represent a byte count as a 64-bit
integer at the block layer (even if we are internally capped
by SIZE_MAX or even INT_MAX for individual transactions, it's
still nicer to not have to worry a
From: Eric Blake
If a read error is encountered during 'qemu-img compare', we
were printing the "Error while reading offset ..." message twice;
this was because our helper function was awkward, printing output
on some but not all paths. Fix it to consistently report errors
on all paths, so that
From: Eric Blake
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Continue by converting
an internal function (no semantic change), and simplifying its
caller accordingly.
Signed-off-by: Eric Blake
Reviewed-by: Fam Zheng
Reviewed-by:
From: Eric Blake
As long as we are querying the status for a chunk smaller than
the known image size, we are guaranteed that a successful return
will have set pnum to a non-zero size (pnum is zero only for
queries beyond the end of the file). Use that to slightly
simplify the calculation of the
From: Eric Blake
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change), and rename it to is_zero() in the
process.
Signed-off-by: Eric Blake
Reviewed-by: Fam Zheng
Reviewed-by: John Sn
From: Eric Blake
During 'qemu-img compare', when we are checking that an allocated
portion of one file is all zeros, we don't need to waste time
computing how many additional sectors after the first non-zero
byte are also non-zero. Create a new helper find_nonzero() to do
the check for a first n
From: Eric Blake
We are gradually moving away from sector-based interfaces, towards
byte-based. In the common case, allocation is unlikely to ever use
values that are not naturally sector-aligned, but it is possible
that byte-based values will let us be more precise about allocation
at the end o
From: Eric Blake
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change); and as with its public counterpart,
rename to bdrv_co_block_status() and split the offset return, to
make the compi
From: Eric Blake
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
type (no semantic change), and rename it to match the corresponding
public function rename.
Signed-off-by: Eric Blake
Signed-off-by: Kevin Wolf
From: Eric Blake
Continue on the quest to make more things byte-based instead of
sector-based.
Signed-off-by: Eric Blake
Reviewed-by: John Snow
Signed-off-by: Kevin Wolf
---
qemu-img.c | 27 +++
1 file changed, 15 insertions(+), 12 deletions(-)
diff --git a/qemu-img.
From: Eric Blake
Now that bdrv_is_allocated accepts non-aligned inputs, we can
remove the TODO added in earlier refactoring.
Signed-off-by: Eric Blake
Signed-off-by: Kevin Wolf
---
block/qcow2.c | 12 +++-
1 file changed, 3 insertions(+), 9 deletions(-)
diff --git a/block/qcow2.c b/b
From: Eric Blake
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
type (no semantic change), and rename it to match the corresponding
public function rename.
Signed-off-by: Eric Blake
Signed-off-by: Kevin Wolf
From: Max Reitz
A qcow2 image file's length is not required to have a length that is a
multiple of the cluster size. However, qcow2_refcount_area() expects an
aligned value for its @start_offset parameter, so we need to round
@old_file_size up to the next cluster boundary.
Reported-by: Ping Li
From: Eric Blake
In the continuing quest to make more things byte-based, change
compare_sectors(), renaming it to compare_buffers() in the
process. Note that one caller (qemu-img compare) only cares
about the first difference, while the other (qemu-img rebase)
cares about how many consecutive se
1 - 100 of 284 matches
Mail list logo
