[Qemu-devel] [PATCH] ui: add qemu-keymap and shader to .gitignore

2017-10-20 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- .gitignore | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index 620eec6b47..588769b250 100644 --- a/.gitignore +++ b/.gitignore @@ -14,6 +14,7 @@ /trace/generated-tcg-tracers.h /ui/shader/texture-blit-frag.h /ui/shader/texture-bli

Re: [Qemu-devel] [PULL 07/11] tools: add qemu-keymap

2017-10-20 Thread Fam Zheng
On Fri, 10/20 08:52, Thomas Huth wrote: > On 20.10.2017 00:12, Eric Blake wrote: > > On 10/19/2017 05:09 PM, Eric Blake wrote: > >> On 10/16/2017 08:16 AM, Gerd Hoffmann wrote: > >>> qemu-keymap generates qemu reverse keymaps from xkb keymaps, > >>> which can be used with the qemu "-k" command line

Re: [Qemu-devel] [PATCH v6 00/50] tcg tb_lock removal

2017-10-20 Thread Paolo Bonzini
On 19/10/2017 22:11, Emilio G. Cota wrote: > On Thu, Oct 19, 2017 at 15:05:17 +0200, Paolo Bonzini wrote: >> On 19/10/2017 00:45, Emilio G. Cota wrote: >>> I have just pushed a branch on top of this series that includes >>> 10 patches that further pave the way for the removal of tb_lock: >>> >>>

Re: [Qemu-devel] linux-user: refactor socket.h into architecture specific sockbits

2017-10-20 Thread Laurent Vivier
Le 17/10/2017 à 16:35, Carlo Arenas a écrit : > On Mon, Oct 16, 2017 at 5:32 AM, Riku Voipio wrote: >> On Wed, Oct 11, 2017 at 12:10:04AM -0700, Carlo Arenas wrote: >>> some of the patches already have a Reviewed-by as shown by : >>> >>> http://patchwork.ozlabs.org/patch/818378/ >> >> Can you se

Re: [Qemu-devel] [PATCH v3 46/46] target: Replace fprintf(stderr, "*\n" with error_report()

2017-10-20 Thread Thomas Huth
On 19.10.2017 18:18, Alistair Francis wrote: > Replace a large number of the fprintf(stderr, "*\n" calls with > error_report(). The functions were renamed with these commands and then > compiler issues where manually fixed. [...] > target/arm/arm-powerctl.c| 5 +++-- > target/arm/arm-semi.c

Re: [Qemu-devel] [PATCH v5 03/11] nbd: Expose constants and structs for structured read

2017-10-20 Thread Vladimir Sementsov-Ogievskiy
20.10.2017 01:26, Eric Blake wrote: Upcoming patches will implement the NBD structured reply extension [1] for both client and server roles. Declare the constants, structs, and lookup routines that will be valuable whether the server or client code is backported in isolation. This includes movi

Re: [Qemu-devel] [RFC 2/2] KVM: add virtio-pmem driver

2017-10-20 Thread Christoph Hellwig
On Thu, Oct 19, 2017 at 11:21:26AM -0700, Dan Williams wrote: > The difference is that nvdimm_flush() is not mandatory, and that the > platform will automatically perform the same flush at power-fail. > Applications should be able to assume that if they are using MAP_SYNC > that no other coordinati

Re: [Qemu-devel] [PATCH v3 0/7] migration: pause-before-switchover

2017-10-20 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Oct 19, 2017 at 12:21:23PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Wed, Oct 18, 2017 at 06:40:06PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > > > [...] > > > > > > > The precopy flow is:

Re: [Qemu-devel] [PATCH v5 04/11] nbd/server: Report error for write to read-only export

2017-10-20 Thread Vladimir Sementsov-Ogievskiy
20.10.2017 01:26, Eric Blake wrote: When the server is read-only, we were already reporting an error message for NBD_CMD_WRITE_ZEROES, but failed to set errp for a similar NBD_CMD_WRITE. This will matter more once structured replies allow the server to propagate the errp information back to the

Re: [Qemu-devel] [PATCH v1 0/2] s390x/tcg: LAP support using immediate TLB invalidation

2017-10-20 Thread Cornelia Huck
On Tue, 17 Oct 2017 14:17:06 +0200 Cornelia Huck wrote: > On Mon, 16 Oct 2017 22:23:56 +0200 > David Hildenbrand wrote: > > > Details about Low-Address Protection can be found in description of > > patch 1 and 2. It is basically a subpage protection of the first two > > pages of every address s

[Qemu-devel] [PATCH] pci-assign: Remove

2017-10-20 Thread Paolo Bonzini
Legacy PCI device assignment has been removed from Linux in 4.12, and had been deprecated 2 years ago there. We can remove it from QEMU as well. The ROM loading code was shared with Xen PCI passthrough, so move it to hw/xen. Cc: Stefano Stabellini Cc: Anthony Perard Cc: xen-de...@lists.xenproj

Re: [Qemu-devel] [PATCH v5 05/11] nbd/server: Refactor zero-length option check

2017-10-20 Thread Vladimir Sementsov-Ogievskiy
20.10.2017 01:26, Eric Blake wrote: Consolidate the check for a zero-length payload to an option into a new function, nbd_check_zero_length(); this check will also be used when introducing support for structured replies. By sticking a catch-all check at the end of the loop for processing options

Re: [Qemu-devel] [PATCH v1 2/2] ide: support reporting of rotation rate

2017-10-20 Thread Kevin Wolf
[ Cc: qemu-block ] Am 04.10.2017 um 13:40 hat Daniel P. Berrange geschrieben: > The Linux kernel will query the ATA IDENTITY DEVICE data, word 217 > to determine the rotations per minute of the disk. If this has > the value 1, it is taken to be an SSD and so Linux sets the > 'rotational' flag to 0

Re: [Qemu-devel] [PATCH v1 2/2] ide: support reporting of rotation rate

2017-10-20 Thread Daniel P. Berrange
On Fri, Oct 20, 2017 at 10:42:21AM +0200, Kevin Wolf wrote: > [ Cc: qemu-block ] > > Am 04.10.2017 um 13:40 hat Daniel P. Berrange geschrieben: > > The Linux kernel will query the ATA IDENTITY DEVICE data, word 217 > > to determine the rotations per minute of the disk. If this has > > the value 1,

[Qemu-devel] [PATCH v4 3/7] migration: Wait for semaphore before completing migration

2017-10-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Wait for a semaphore before completing the migration, if the previously added capability was enabled. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 38 ++ migration/migration.h | 3 ++

[Qemu-devel] [PATCH v4 1/7] migration: Add 'pause-before-switchover' capability

2017-10-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" When 'pause-before-switchover' is enabled, the outgoing migration will pause before invalidating the block devices and serializing the device state. At this point the management layer gets the chance to clean up any device jobs or other device users before the migra

[Qemu-devel] [PATCH v4 0/7] migration: pause-before-switchover

2017-10-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Hi, This set attempts to make a race condition between migration and drive-mirror (and other block users) soluble by allowing the migration to be paused after the source qemu releases the block devices but before the serialisation of the device state. The symptom

[Qemu-devel] [PATCH v4 2/7] migration: Add 'pre-switchover' and 'device' statuses

2017-10-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add two statuses for use when the 'pause-before-switchover' capability is enabled. 'pre-switchover' is the state that we wait in for management to allow us to continue. 'device' is the state we enter while serialising the devices after management gives us the OK.

[Qemu-devel] [PATCH v4 6/7] migration: allow cancel to unpause

2017-10-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" If a migration_cancel is issued during the new paused state, kick the pause_sem to get to unpause so it can cancel. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 4 1 file changed, 4 insertions(+) diff --git a/migr

[Qemu-devel] [PATCH v4 5/7] migrate: HMP migate_continue

2017-10-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" HMP equivalent to the just added migrate-continue Unpause a migrate paused at a given state. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- hmp-commands.hx | 12 hmp.c | 13 + hmp.h | 1 + 3 files ch

[Qemu-devel] [PATCH v4 4/7] migration: migrate-continue

2017-10-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A new qmp command allows the caller to continue from a given paused state. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 11 +++ qapi/migration.json | 17 + 2 files changed, 28 insertions(+) di

[Qemu-devel] [PATCH v4 7/7] migration: pause-before-switchover for postcopy

2017-10-20 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Add pause-before-switchover support for postcopy. After starting postcopy it will transition active->pre-switchover->postcopy_active Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- migration/migration.c | 29 ++--- 1 f

Re: [Qemu-devel] [RFC 0/6] enable numa configuration before machine_init() from HMP/QMP

2017-10-20 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 05:56:49PM -0200, Eduardo Habkost wrote: > On Thu, Oct 19, 2017 at 04:28:59PM +0100, Daniel P. Berrange wrote: > > On Thu, Oct 19, 2017 at 11:21:22AM -0400, Igor Mammedov wrote: > > > - Original Message - > > > > From: "Daniel P. Berrange" > > > > To: "Igor Mammedov

[Qemu-devel] [PATCH] ide: avoid referencing NULL dev in rotational rate setting

2017-10-20 Thread Daniel P. Berrange
The 'dev' variable can be NULL when the guest OS calls identify on an IDE unit that does not have a drive attached to it. Signed-off-by: Daniel P. Berrange --- hw/ide/core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/ide/core.c b/hw/ide/core.c index a04766aee7..471

Re: [Qemu-devel] [RFC v2 13/22] monitor: separate QMP parser and dispatcher

2017-10-20 Thread Paolo Bonzini
On 19/10/2017 15:13, Stefan Hajnoczi wrote: > Up to you. I don't remember the details of out_lock usage well enough > to know whether using the lock for the queues is good or bad. out_lock is called like that because it's only writes that can be done from multiple threads (at both the chardev and

Re: [Qemu-devel] [PATCH] build: Don't force preserving permissions on config-devices.mak.old

2017-10-20 Thread Peter Maydell
On 19 October 2017 at 21:04, Aaron Lindsay wrote: > I get the following error when building on an NFSv3 filesystem: > > % make -j8 > GEN aarch64-softmmu/config-devices.mak.tmp > GEN config-host.h > [snip] > GEN qmp-marshal.c > GEN aarch64-softmmu/config-devices.mak > cp: pr

Re: [Qemu-devel] [PATCH] implement strnlen for systems that need it

2017-10-20 Thread David Gibson
On Thu, Oct 19, 2017 at 09:50:05PM -0400, John Arbuckle wrote: > Signed-off-by: John Arbuckle I preferred the idea of just putting it inline into libfdt_env.h. They're both ugly, but that one's small and ugly; the approach here seems overkill. Also, patch submissions for dtc and libfdt should go

[Qemu-devel] [PATCH] sockets: avoid leak of listen file descriptor

2017-10-20 Thread Daniel P. Berrange
If we iterate over the full port range without successfully binding+listening on the socket, we'll try the next address, whereupon we overwrite the slisten file descriptor variable without closing it. Rather than having two places where we open + close socket FDs on different iterations of nested

Re: [Qemu-devel] [PATCH] fix WFI/WFE length in syndrome register

2017-10-20 Thread Peter Maydell
On 19 October 2017 at 21:56, Stefano Stabellini wrote: > On Thu, 19 Oct 2017, Peter Maydell wrote: >> On 18 October 2017 at 23:03, Stefano Stabellini >> wrote: >> > WFI/E are 4 bytes long: set ARM_EL_IL_SHIFT in the syndrome. >> > >> > Signed-off-by: Stefano Stabellini >> > >> > diff --git a/ta

[Qemu-devel] wurb test zt

2017-10-20 Thread li.shanlue
It's a test mail for testing relative between topic and reply.

Re: [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-20 Thread Laszlo Ersek
On 10/20/17 08:55, Gerd Hoffmann wrote: > Hi, > >>> commit message says: >>> >>> >>>  It turns out that some 32 bit windows guests crash >>>  if 64 bit PCI hole size is >2G. >>> >>> >>> Why this suddenly isn't a problem any more? >>> >> >> I suppose it is, so we need a way to turn it "

Re: [Qemu-devel] wurb test zt

2017-10-20 Thread li.shanlue
reply for an original mail from mail group system 收件人: ; 日 期 :2017年10月20日 17:32 主 题 :[Qemu-devel] wurb test zt It's a test mail for testing relative between topic and reply.

Re: [Qemu-devel] [Qemu-block] [PATCH] ide: avoid referencing NULL dev in rotational rate setting

2017-10-20 Thread Stefan Hajnoczi
On Fri, Oct 20, 2017 at 10:14:03AM +0100, Daniel P. Berrange wrote: > The 'dev' variable can be NULL when the guest OS calls identify on an IDE > unit that does not have a drive attached to it. > > Signed-off-by: Daniel P. Berrange > --- > hw/ide/core.c | 4 +++- > 1 file changed, 3 insertions(+

Re: [Qemu-devel] [PATCH] implement strnlen for systems that need it

2017-10-20 Thread Stefan Hajnoczi
On Thu, Oct 19, 2017 at 09:50:05PM -0400, John Arbuckle wrote: Which repo does this patch apply to? Please add a tag in the email subject like "[libfdt]" to distinguish it from qemu.git patches. > Signed-off-by: John Arbuckle > --- > Makefile.dtc | 3 ++- > libfdt/Makefile.libfdt |

Re: [Qemu-devel] [PULL 0/5] OpenRISC SMP Support

2017-10-20 Thread Stafford Horne
Hello Peter, It looks like I didn't send this directly to you. Please let me know if there are any issues. On 13 Oct 2017 11:57 p.m., "Stafford Horne" wrote: Hello, Please consider for pull. The following changes since commit 7851197b812b383ae1208c5d86391c5179c8209d: Update version for 2

Re: [Qemu-devel] [PULL 0/5] OpenRISC SMP Support

2017-10-20 Thread Peter Maydell
On 20 October 2017 at 10:39, Stafford Horne wrote: > Hello Peter, > > It looks like I didn't send this directly to you. Please let me know if > there are any issues. It's on my list to deal with, yes, but it's at the bottom of the pile because pull requests from people who I haven't pulled from

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2017-10-20 Thread Peter Maydell
On 19 October 2017 at 20:13, Mark Cave-Ayland wrote: > If you check the signed tag again, I've rebased the commit and re-pushed > to github again so you should now hopefully be able to apply without any > issues. Thanks -- I've now applied that version. -- PMM

Re: [Qemu-devel] [Block-io] qemu virtual machine get stuck during startup

2017-10-20 Thread Stefan Hajnoczi
On Fri, Oct 20, 2017 at 09:51:01AM +0800, Wahaha Huang wrote: > Sorry for the late reply. > Unfortunately, when it gets stuck(block at the windows welcome screen), Have you booted the same disk image with the same QEMU command-line successfully before? > there are no any error messages print out,

Re: [Qemu-devel] [PATCH] sockets: avoid leak of listen file descriptor

2017-10-20 Thread Daniel P. Berrange
On Fri, Oct 20, 2017 at 10:28:44AM +0100, Daniel P. Berrange wrote: > If we iterate over the full port range without successfully binding+listening > on the socket, we'll try the next address, whereupon we overwrite the slisten > file descriptor variable without closing it. > > Rather than having

[Qemu-devel] [PATCH] hw/display/sm501: Fix comment in sm501_sysbus_class_init()

2017-10-20 Thread Thomas Huth
The "cannot_instantiate_with_device_add_yet" flag has been renamed to "user_creatable" a while ago. Signed-off-by: Thomas Huth --- hw/display/sm501.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 6eddac9..7f18224 100644 --- a/hw

Re: [Qemu-devel] [PATCH v4 2/4] vhost-user-blk: introduce a new vhost-user-blk host device

2017-10-20 Thread Stefan Hajnoczi
On Fri, Oct 20, 2017 at 01:47:58AM +, Liu, Changpeng wrote: > > > +static Property vhost_user_blk_properties[] = { > > > +DEFINE_PROP_CHR("chardev", VHostUserBlk, chardev), > > > +DEFINE_PROP_UINT16("num_queues", VHostUserBlk, num_queues, 1), > > > +DEFINE_PROP_UINT32("queue_size",

Re: [Qemu-devel] [PATCH v4 1/4] vhost-user: add new vhost user messages to support virtio config space

2017-10-20 Thread Stefan Hajnoczi
On Thu, Oct 19, 2017 at 06:36:00PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 19, 2017 at 04:09:35PM +0200, Stefan Hajnoczi wrote: > > On Thu, Oct 19, 2017 at 01:24:07PM +0800, Changpeng Liu wrote: > > > @@ -922,6 +931,91 @@ static void vhost_user_set_iotlb_callback(struct > > > vhost_dev *dev

Re: [Qemu-devel] [PATCH] sockets: avoid leak of listen file descriptor

2017-10-20 Thread Darren Kenny
Hi Daniel, On Fri, Oct 20, 2017 at 10:28:44AM +0100, Daniel P. Berrange wrote: If we iterate over the full port range without successfully binding+listening on the socket, we'll try the next address, whereupon we overwrite the slisten file descriptor variable without closing it. Rather than hav

Re: [Qemu-devel] [PATCH] sockets: avoid leak of listen file descriptor

2017-10-20 Thread Darren Kenny
On Fri, Oct 20, 2017 at 10:54:31AM +0100, Daniel P. Berrange wrote: On Fri, Oct 20, 2017 at 10:28:44AM +0100, Daniel P. Berrange wrote: If we iterate over the full port range without successfully binding+listening on the socket, we'll try the next address, whereupon we overwrite the slisten file

[Qemu-devel] SDL2 issues

2017-10-20 Thread Michael Tokarev
Hello After we tried to switch from SDL1 to SDL2 in Debian qemu, we receives quite some reports about various issues. We use 2.10.1 version of qemu. Example of the issues: http://bugs.debian.org/879193 http://bugs.debian.org/870025 - a few patches at the bottom http://bugs.debian.org/878087 Wha

Re: [Qemu-devel] [Qemu-block] Clean Block Driver Shutdown

2017-10-20 Thread Stefan Hajnoczi
On Tue, Oct 17, 2017 at 01:46:25PM +0200, Kevin Wolf wrote: > Am 17.10.2017 um 12:33 hat Peter Lieven geschrieben: > > I noticed that Qemu quits at several points with an exit() if the > > supplied parameters in the commandline are incorrect. This at some > > stages happens after there have already

[Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers

2017-10-20 Thread Paolo Bonzini
GCC 4.9 and newer stopped warning for missing braces around the "universal" C zero initializer {0}. One such initializer sneaked into scsi/qemu-pr-helper.c and is breaking the build with such older GCC versions. Detect the lack of support for the idiom, and disable the warning in that case. Sign

Re: [Qemu-devel] use qemu dataplane report '.x-data-plane' not found

2017-10-20 Thread Stefan Hajnoczi
On Mon, Oct 16, 2017 at 01:28:42PM +0100, Daniel P. Berrange wrote: > On Mon, Oct 16, 2017 at 08:19:36PM +0800, Paul Schlacter wrote: > > qemu-kvm: -device > > virtio-blk-pci,scsi=off,bus=pci.0,addr=0x5,drive=drive-virtio-disk0,id=virtio-disk0,bootindex=1: > > Property '.x-data-plane' not found > >

[Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Christian Borntraeger
From: "Collin L. Walling" The sclp console in the s390 bios writes raw data, leading console emulators (such as virsh console) to treat a new line ('\n') as just a new line instead of as a Unix line feed. Because of this, output appears in a "stair case" pattern. Let's print \r\n on every occurr

Re: [Qemu-devel] [PATCH 1/8] xen: link against xentoolcore

2017-10-20 Thread Ian Jackson
Anthony PERARD writes ("Re: [PATCH 1/8] xen: link against xentoolcore"): > On Thu, Oct 19, 2017 at 05:38:10PM +0100, Ian Jackson wrote: > > We still need this patch for the rest of the series, though. > > Of course, I was only arguing that this patch on its own is not usefull. Right. I wanted to

Re: [Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers

2017-10-20 Thread Laszlo Ersek
On 10/20/17 12:12, Paolo Bonzini wrote: > GCC 4.9 and newer stopped warning for missing braces around the > "universal" C zero initializer {0}. One such initializer sneaked s/sneaked/snuck/ Hmmm, no, wait, both forms are valid! https://en.wiktionary.org/wiki/sneaked https://en.wiktionary.org/wi

Re: [Qemu-devel] SDL2 issues

2017-10-20 Thread Gerd Hoffmann
On Fri, 2017-10-20 at 13:05 +0300, Michael Tokarev wrote: > Hello > > After we tried to switch from SDL1 to SDL2 in Debian qemu, > we receives quite some reports about various issues. > > We use 2.10.1 version of qemu. > > Example of the issues: http://bugs.debian.org/879193 Doesn't reproduce.

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Alexander Graf
On 20.10.17 12:25, Christian Borntraeger wrote: > From: "Collin L. Walling" > > The sclp console in the s390 bios writes raw data, > leading console emulators (such as virsh console) to > treat a new line ('\n') as just a new line instead > of as a Unix line feed. Because of this, output > appe

Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements

2017-10-20 Thread Ian Jackson
no-re...@patchew.org writes ("Re: [Qemu-devel] [PATCH v5 0/8] xen: xen-domid-restrict improvements"): > This series seems to have some coding style problems. See output below for > more information: No, it doesn't have coding style problems. At least, this mail contains only one complaint which

Re: [Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers

2017-10-20 Thread Paolo Bonzini
On 20/10/2017 12:27, Laszlo Ersek wrote: >> +if compile_object "-Werror" "" ; then >> + : >> +else > Is this an established idiom for the configure script, in place of: > > if ! compile_object "-Werror" "" ; then > > ? > > Looks good to me otherwise. I tend not use "if !". In general that's

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Christian Borntraeger
On 10/20/2017 12:30 PM, Alexander Graf wrote: > > > On 20.10.17 12:25, Christian Borntraeger wrote: >> From: "Collin L. Walling" >> >> The sclp console in the s390 bios writes raw data, >> leading console emulators (such as virsh console) to >> treat a new line ('\n') as just a new line instead

Re: [Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers

2017-10-20 Thread Laszlo Ersek
On 10/20/17 12:37, Paolo Bonzini wrote: > On 20/10/2017 12:27, Laszlo Ersek wrote: >>> +if compile_object "-Werror" "" ; then >>> + : >>> +else >> Is this an established idiom for the configure script, in place of: >> >> if ! compile_object "-Werror" "" ; then >> >> ? >> >> Looks good to me othe

Re: [Qemu-devel] [PATCH] build: Don't force preserving permissions on config-devices.mak.old

2017-10-20 Thread Stefan Hajnoczi
On Thu, Oct 19, 2017 at 04:04:43PM -0400, Aaron Lindsay wrote: > I get the following error when building on an NFSv3 filesystem: > > % make -j8 > GEN aarch64-softmmu/config-devices.mak.tmp > GEN config-host.h > [snip] > GEN qmp-marshal.c > GEN aarch64-softmmu/config-devices

Re: [Qemu-devel] [PATCH v3 42/46] util: Replace fprintf(stderr, "*\n" with error_report()

2017-10-20 Thread Stefan Hajnoczi
On Fri, Oct 20, 2017 at 08:27:41AM +0200, Thomas Huth wrote: > On 19.10.2017 21:47, Stefan Weil wrote: > > Am 19.10.2017 um 19:53 schrieb Thomas Huth: > >> On 19.10.2017 18:18, Alistair Francis wrote: > >>> Replace a large number of the fprintf(stderr, "*\n" calls with > >>> error_report(). The fun

Re: [Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers

2017-10-20 Thread Peter Maydell
On 20 October 2017 at 11:12, Paolo Bonzini wrote: > GCC 4.9 and newer stopped warning for missing braces around the > "universal" C zero initializer {0}. One such initializer sneaked > into scsi/qemu-pr-helper.c and is breaking the build with such > older GCC versions. > > Detect the lack of supp

Re: [Qemu-devel] [PATCH] hw/pci-host: Fix x86 Host Bridges 64bit PCI hole

2017-10-20 Thread Gerd Hoffmann
On Fri, 2017-10-20 at 11:32 +0200, Laszlo Ersek wrote: > On 10/20/17 08:55, Gerd Hoffmann wrote: > >   Hi, > > > > > > commit message says: > > > > > > > > > > > >  It turns out that some 32 bit windows guests crash > > > >  if 64 bit PCI hole size is >2G. > > > > > > > > > > > > Why t

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Christian Borntraeger
On 10/20/2017 12:41 PM, Christian Borntraeger wrote: [...] >>> @@ -76,17 +76,28 @@ static int _strlen(const char *str) >>> long write(int fd, const void *str, size_t len) >>> { >>> WriteEventData *sccb = (void *)_sccb; >>> +const char *p; >>> +size_t data_len = 0; >>> >>> if

Re: [Qemu-devel] [PATCH] build: disable -Wmissing-braces on older compilers

2017-10-20 Thread Paolo Bonzini
On 20/10/2017 12:48, Peter Maydell wrote: > On 20 October 2017 at 11:12, Paolo Bonzini wrote: >> GCC 4.9 and newer stopped warning for missing braces around the >> "universal" C zero initializer {0}. One such initializer sneaked >> into scsi/qemu-pr-helper.c and is breaking the build with such >>

Re: [Qemu-devel] SDL2 issues

2017-10-20 Thread Thomas Huth
On 20.10.2017 12:29, Gerd Hoffmann wrote: > On Fri, 2017-10-20 at 13:05 +0300, Michael Tokarev wrote: >> Hello >> >> After we tried to switch from SDL1 to SDL2 in Debian qemu, >> we receives quite some reports about various issues. >> >> We use 2.10.1 version of qemu. >> >> Example of the issues: h

Re: [Qemu-devel] [libvirt] Question about the host-model CPU mode

2017-10-20 Thread Marc Hartmayer
On Thu, Oct 12, 2017 at 02:07 PM +0200, Jiri Denemark wrote: > On Mon, Oct 09, 2017 at 10:16:48 +0200, Marc Hartmayer wrote: >> On Thu, Oct 05, 2017 at 02:11 PM +0200, Jiri Denemark >> wrote: >> > But it's going to be a bit complicated because we ask QEMU what the >> > host CPU is and the inter

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Alexander Graf
On 20.10.17 13:02, Christian Borntraeger wrote: > > > On 10/20/2017 12:41 PM, Christian Borntraeger wrote: > [...] @@ -76,17 +76,28 @@ static int _strlen(const char *str) long write(int fd, const void *str, size_t len) { WriteEventData *sccb = (void *)_sccb; +

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Christian Borntraeger
On 10/20/2017 01:09 PM, Alexander Graf wrote: > > > On 20.10.17 13:02, Christian Borntraeger wrote: >> >> >> On 10/20/2017 12:41 PM, Christian Borntraeger wrote: >> [...] > @@ -76,17 +76,28 @@ static int _strlen(const char *str) > long write(int fd, const void *str, size_t len) >

[Qemu-devel] [PATCH] qemu-pr-helper: Do not use {0} for initialization

2017-10-20 Thread Paolo Bonzini
The first field in struct dm_ioctl is an array, and old GCC warns about it with -Wmissing-braces (GCC <= 4.8). The "{0}" universal zero initializer is only useful if the other side might be a scalar; for a struct, "{}" is enough and shuts up the compiler. Suggested-by: Peter Maydell Signed-off-b

Re: [Qemu-devel] Key signing party at KVM Forum 2017

2017-10-20 Thread Igor Mammedov
Hi Peter, here is my key fingerprint for key signing party if it's not too late pub 4096R/F14191D4 2017-10-20 Key fingerprint = 23B8 11E7 7EFB D339 50AE 0D43 5BCA 8AE0 F141 91D4 uid Igor Mammedov sub 4096R/91ED3DB8 2017-10-20

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Thomas Huth
On 20.10.2017 13:02, Christian Borntraeger wrote: > > > On 10/20/2017 12:41 PM, Christian Borntraeger wrote: > [...] @@ -76,17 +76,28 @@ static int _strlen(const char *str) long write(int fd, const void *str, size_t len) { WriteEventData *sccb = (void *)_sccb; +

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Cornelia Huck
On Fri, 20 Oct 2017 12:25:17 +0200 Christian Borntraeger wrote: > From: "Collin L. Walling" > > The sclp console in the s390 bios writes raw data, > leading console emulators (such as virsh console) to > treat a new line ('\n') as just a new line instead > of as a Unix line feed. Because of thi

Re: [Qemu-devel] [PULL v1 00/21] Merge tpm 2017/10/19

2017-10-20 Thread Peter Maydell
On 19 October 2017 at 19:02, Stefan Berger wrote: > The following changes since commit f2a48d696c12aaac12993364371daae9f6233c37: > > Merge remote-tracking branch 'remotes/riku/tags/pull-linux-user-20171018' > into staging (2017-10-19 14:39:30 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [libvirt] Question about the host-model CPU mode

2017-10-20 Thread David Hildenbrand
On 20.10.2017 13:09, Marc Hartmayer wrote: > On Thu, Oct 12, 2017 at 02:07 PM +0200, Jiri Denemark > wrote: >> On Mon, Oct 09, 2017 at 10:16:48 +0200, Marc Hartmayer wrote: >>> On Thu, Oct 05, 2017 at 02:11 PM +0200, Jiri Denemark >>> wrote: But it's going to be a bit complicated because w

Re: [Qemu-devel] [PATCH] s390-ccw: print carriage return with new lines

2017-10-20 Thread Halil Pasic
On 10/20/2017 12:25 PM, Christian Borntraeger wrote: > From: "Collin L. Walling" > > The sclp console in the s390 bios writes raw data, > leading console emulators (such as virsh console) to > treat a new line ('\n') as just a new line instead > of as a Unix line feed. Because of this, output >

Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: fix a qemu crash problem when calling blk_delete

2017-10-20 Thread Alberto Garcia
On Sun 24 Nov 2013 04:55:52 AM CET, sochin.jiang wrote: ^^^ I guess the date in your computer is wrong :-) > commit 7ca7f0 moves the throttling related part of the BDS life cycle > management to BlockBackend, adds call to > throttle_timers_detach_aio_context in blk_remove_bs. commi

[Qemu-devel] [PULL 02/46] s390x/css: be more consistent if broken beyond repair

2017-10-20 Thread Cornelia Huck
From: Halil Pasic Calling do_subchannel_work with no function control flags set in SCSW is a programming error. Currently we handle this differently in do_subchannel_work_virtual and do_subchannel_work_passthrough. Let's be consistent and guard with a common assert against this programming error.

[Qemu-devel] [PULL 03/46] s390x/tcg: turn INTERRUPT_EXT into a mask

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand External interrupts are currently all handled like floating external interrupts, they are queued. Let's prepare for a split of floating and local interrupts by turning INTERRUPT_EXT into a mask. While we can have various floating external interrupts of one kind, there is

[Qemu-devel] [PULL 00/46] more s390x patches for 2.11

2017-10-20 Thread Cornelia Huck
The following changes since commit e67277f8f32d56c64c7993163f41bb4338aec566: Merge remote-tracking branch 'remotes/stefanberger/tags/pull-tpm-2017-10-19-1' into staging (2017-10-20 10:49:55 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390

[Qemu-devel] [PULL 05/46] s390x/tcg: injection of emergency signals and external calls

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Preparation for new TCG SIGP code. Especially also prepare for indicating that another external call is already pending. Take care of interrupt priority. Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-4-da...@redhat.com> Reviewed-by: Richard Henderson

[Qemu-devel] [PULL 04/46] s390x/tcg: cleanup service interrupt injection

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand There are still some leftovers from old virtio interrupts in there. Most importantly, we don't have to queue service interrupts anymore. Just like KVM, we can simply multiplex the SCLP service interrupts and avoid the queue. Also, now only valid parameters/cpu_addr will b

[Qemu-devel] [PULL 10/46] target/s390x: factor out handling of WAIT PSW into s390_handle_wait()

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand This will now also detect crashes under TCG. We can directly use cpu->env.psw.addr instead of kvm_run, as we do a cpu_synchronize_state(). Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-9-da...@redhat.com> Signed-off-by:

[Qemu-devel] [PULL 01/46] S390: use g_new() family of functions

2017-10-20 Thread Cornelia Huck
From: Marc-André Lureau Signed-off-by: Marc-André Lureau Signed-off-by: Philippe Mathieu-Daudé [PMD: more changes in hw/s390x/css.c, added target/s390x/cpu_models.c] Message-Id: <20171006235023.11952-27-f4...@amsat.org> Signed-off-by: Cornelia Huck --- hw/s390x/css.c| 10 +

[Qemu-devel] [PULL 08/46] s390x/tcg: STOPPED cpus can never wake up

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Interrupts can't wake such CPUs up. SIGP from other CPUs has to be used to toggle the state. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-7-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/cpu.c | 6 ++

[Qemu-devel] [PULL 06/46] s390x/tcg: rework checking for deliverable interrupts

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Currently, enabling/disabling of interrupts is not really supported. Let's improve interrupt handling code by explicitly checking for deliverable interrupts only. This is the first step. Checking for external interrupt subclasses will be done next. Signed-off-by: David H

[Qemu-devel] [PULL 07/46] s390x/tcg: take care of external interrupt subclasses

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand We can now let go of INTERRUPT_EXT. When cr0 changes, we have to revalidate if we now have a pending external interrupt, just like when the PSW (or SYSTEM MASK only) changes. Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-6-da...@redhat.com> Reviewed-b

[Qemu-devel] [PULL 12/46] target/s390x: interpret PSW_MASK_WAIT only for TCG

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand KVM handles the wait PSW itself and triggers a WAIT ICPT in case it really wants to sleep (disabled wait). This will later allow us to change the order of loading a restart interrupt and setting a CPU to OPERATING on SIGP RESTART without changing KVM behavior. Signed-off

[Qemu-devel] [PULL 15/46] s390x/kvm: factor out storing of CPU status

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Factor it out into s390_store_status(), to be used also by TCG later on. Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-14-da...@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Cornelia Huck --- target/s390x/helper.c | 60 +++

[Qemu-devel] [PULL 13/46] s390x/kvm: pass ipb directly into handle_sigp()

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand No need to pass kvm_run. Pass parameters alphabetically ordered. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-12-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 6 +++

[Qemu-devel] [PULL 09/46] s390x/tcg: a CPU cannot switch state due to an interrupt

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Going to OPERATING here looks wrong. A CPU should even never be !OPERATING at this point. Unhalting will already be done in cpu_handle_halt() if there is work, so we can drop this statement completely. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Mess

[Qemu-devel] [PULL 19/46] s390x/kvm: factor out actual handling of STOP interrupts

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand For KVM, the KVM module decides when a STOP can be performed (when the STOP interrupt can be processed). Factor it out so we can use it later for TCG. Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-19-da...@redhat.com> Reviewed-by: Richard Henderson S

[Qemu-devel] [PULL 26/46] s390x/tcg: flush the tlb on SIGP SET PREFIX

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Thanks to Aurelien Jarno for doing this in his prototype. We can flush the whole TLB as this should happen really rarely. Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-26-da...@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Cornelia Huck

[Qemu-devel] [PULL 14/46] s390x/kvm: generalize SIGP stop and restart interrupt injection

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Preparation for factoring it out into !kvm code. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-13-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/internal.h | 2 ++ target/s390x/interrupt.c | 20

[Qemu-devel] [PULL 11/46] s390x/tcg: handle WAIT PSWs during interrupt injection

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand If we encounter a WAIT PSW, we have to halt immediately. Using cpu_loop_exit() at this point feels wrong. Simply leaving cs->exception_index set doesn't result in an immediate stop. This is also necessary to properly handle SIGP STOP interrupts later. The CPU_INTERRUPT_H

[Qemu-devel] [PULL 22/46] s390x/tcg: implement SIGP EXTERNAL CALL

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand As preparation for TCG. Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-22-da...@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Cornelia Huck --- target/s390x/sigp.c | 25 +++-- 1 file changed, 23 insertions(+), 2 delet

[Qemu-devel] [PULL 28/46] s390x/cpumodel: allow to enable SENSE RUNNING STATUS for qemu

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand As we properly implement it, allow to enable it. Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-28-da...@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Cornelia Huck --- target/s390x/cpu_models.c | 1 + 1 file changed, 1 insertion(+) dif

[Qemu-devel] [PULL 29/46] s390x/tcg: unlock NMI

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Nothing hindering us anymore from unlocking the restart code (used for NMI). Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-29-da...@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Cornelia Huck --- hw/s390x/s390-virtio-ccw.c | 4 +--- tar

[Qemu-devel] [PULL 17/46] s390x/kvm: drop two debug prints

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Preparation for moving it out of kvm.c. Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-16-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/kvm.c | 2 -- 1 file changed, 2 deleti

[Qemu-devel] [PULL 18/46] s390x/kvm: factor out SIGP code into sigp.c

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand We want to use the same code base for TCG, so let's cleanly factor it out. The sigp mutex is currently not really needed, as everything is protected by the iothread mutex. But this could change later, so leave it in place and initialize it properly from common code. Revi

[Qemu-devel] [PULL 16/46] s390x/kvm: factor out storing of adtl CPU status

2017-10-20 Thread Cornelia Huck
From: David Hildenbrand Called from SIGP code to be factored out, so let's move it. Add a FIXME for TCG code in the future. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand Message-Id: <20170928203708.9376-15-da...@redhat.com> Signed-off-by: Cornelia Huck --- target/s390x/help

[Qemu-devel] [PULL 32/46] virtio-ccw: Add the virtio-input devices for CCW bus

2017-10-20 Thread Cornelia Huck
From: Farhan Ali Wire up the virtio-input HID devices (keyboard, mouse, tablet) for the CCW bus. The virtio-input is a virtio-1 device, so disable legacy revision 0. Signed-off-by: Farhan Ali Reviewed-by: Halil Pasic Reviewed-by: Christian Borntraeger Message-Id: <6a8ea4c503ee32c2ca7fa608b5f

  1   2   3   4   >