Re: [Qemu-devel] [RFC 24/29] vhost+postcopy: Lock around set_mem_table

2017-10-12 Thread Maxime Coquelin
On 10/09/2017 02:12 PM, Dr. David Alan Gilbert wrote: * Maxime Coquelin (maxime.coque...@redhat.com) wrote: On 10/03/2017 03:23 PM, Dr. David Alan Gilbert wrote: * Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: * Maxime Coquelin (maxime.coque...@redhat.com) wrote: On 06/28/2017 09:

Re: [Qemu-devel] [PATCH] s390x/MAINTAINERS: add mailing list

2017-10-12 Thread Cornelia Huck
On Thu, 12 Oct 2017 08:02:12 +0200 Thomas Huth wrote: > On 05.10.2017 17:16, Cornelia Huck wrote: > > On Thu, 5 Oct 2017 17:13:13 +0200 > > Cornelia Huck wrote: > > > >> There's a new qemu-s3...@nongnu.org mailing list: add it to the > >> s390 sections. > >> > >> Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-12 Thread Paul Durrant
> -Original Message- > From: Xen-devel [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of > Stefano Stabellini > Sent: 11 October 2017 21:19 > To: Anthony Perard > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Stefano > Stabellini ; Owen Smith ; > kra...@redhat.com > Subjec

Re: [Qemu-devel] [PATCH 0/7] migration: pause-before-device

2017-10-12 Thread Daniel P. Berrange
On Wed, Oct 11, 2017 at 08:13:10PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This set attempts to make a race condition between migration and > drive-mirror (and other block users) soluble by allowing the migration > to be paused after the source qemu

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Daniel P. Berrange
On Wed, Oct 11, 2017 at 05:45:04PM +0100, Peter Maydell wrote: > On 11 October 2017 at 16:49, Daniel P. Berrange wrote: > > On Wed, Oct 11, 2017 at 03:37:08PM +0100, Peter Maydell wrote: > >> Build failures: > >> > >> NetBSD: > >> CC ui/input-keymap.o > >> /root/qemu/ui/input-keymap.c:8:44:

Re: [Qemu-devel] [PATCH RFC 2/3] s390x/tcg: low-address protection support

2017-10-12 Thread Thomas Huth
On 29.09.2017 13:27, Cornelia Huck wrote: > On Thu, 28 Sep 2017 15:08:11 +0200 > David Hildenbrand wrote: > >> On 28.09.2017 06:50, Thomas Huth wrote: >>> On 27.09.2017 19:00, David Hildenbrand wrote: This is a neat way to implement low address protection, whereby only the first 512 b

Re: [Qemu-devel] [RFC] KVM "fake DAX" device flushing

2017-10-12 Thread Stefan Hajnoczi
On Thu, Oct 12, 2017 at 12:21:46AM +0530, Pankaj Gupta wrote: > We are sharing the prototype version of 'fake DAX' flushing > interface for the initial feedback. This is still work in progress > and not yet ready for merging. > > Protoype right now just implements basic functionality without advan

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Peter Maydell
On 12 October 2017 at 09:24, Daniel P. Berrange wrote: > On Wed, Oct 11, 2017 at 05:45:04PM +0100, Peter Maydell wrote: >> $ ./scripts/git-submodule.sh update ui/keycodemapdb dtc >> Cloning into 'ui/keycodemapdb'... >> fatal: unable to access >> 'https://gitlab.com/keycodemap/keycodemapdb.git/': P

Re: [Qemu-devel] [PATCH 0/7] migration: pause-before-device

2017-10-12 Thread Kevin Wolf
Am 12.10.2017 um 10:21 hat Daniel P. Berrange geschrieben: > On Wed, Oct 11, 2017 at 08:13:10PM +0100, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Hi, > > This set attempts to make a race condition between migration and > > drive-mirror (and other block users)

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-12 Thread Cédric Le Goater
On 10/12/2017 12:46 AM, David Gibson wrote: > On Wed, Oct 11, 2017 at 01:55:20PM +0200, Cédric Le Goater wrote: >> On 10/11/2017 08:45 AM, David Gibson wrote: >>> On Mon, Oct 09, 2017 at 05:49:28PM +0200, Cédric Le Goater wrote: When a CPU is stopped with the 'stop-self' RTAS call, its state >

Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-12 Thread Gerd Hoffmann
Hi, > It's probably OS specific though. I guess the behaviour changed > because the OS favours absolute pointing devices over relative ones > and how it has two absolute ones to choose from. How it reconciles > those, who knows? Typically hid emulation calls qemu_input_handler_activate() when t

Re: [Qemu-devel] [PATCH] qapi-docs: fix a comment typo

2017-10-12 Thread Marc-André Lureau
On Thu, Oct 12, 2017 at 8:44 AM, Chen Hanxiao wrote: > From: Chen Hanxiao > > s/Subection/Subsection > > Signed-off-by: Chen Hanxiao Reviewed-by: Marc-André Lureau > --- > docs/devel/qapi-code-gen.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/docs/devel/qap

Re: [Qemu-devel] [PATCH 0/7] migration: pause-before-device

2017-10-12 Thread Daniel P. Berrange
On Thu, Oct 12, 2017 at 11:18:31AM +0200, Kevin Wolf wrote: > Am 12.10.2017 um 10:21 hat Daniel P. Berrange geschrieben: > > On Wed, Oct 11, 2017 at 08:13:10PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > Hi, > > > This set attempts to make a

Re: [Qemu-devel] [PATCH v2 2/4] spapr/rtas: disable the decrementer interrupt when a CPU is unplugged

2017-10-12 Thread Cédric Le Goater
On 10/12/2017 11:25 AM, Cédric Le Goater wrote: > On 10/12/2017 12:46 AM, David Gibson wrote: >> On Wed, Oct 11, 2017 at 01:55:20PM +0200, Cédric Le Goater wrote: >>> On 10/11/2017 08:45 AM, David Gibson wrote: On Mon, Oct 09, 2017 at 05:49:28PM +0200, Cédric Le Goater wrote: > When a CPU

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Gerd Hoffmann
Hi, > > $ ./scripts/git-submodule.sh update ui/keycodemapdb dtc > > Cloning into 'ui/keycodemapdb'... > > fatal: unable to access > > 'https://gitlab.com/keycodemap/keycodemapdb.git/': Problem with the > > SSL CA cert (path? access rights?) > > fatal: clone of 'https://gitlab.com/keycodemap/keyc

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Daniel P. Berrange
On Thu, Oct 12, 2017 at 11:30:26AM +0200, Gerd Hoffmann wrote: > Hi, > > > > $ ./scripts/git-submodule.sh update ui/keycodemapdb dtc > > > Cloning into 'ui/keycodemapdb'... > > > fatal: unable to access > > > 'https://gitlab.com/keycodemap/keycodemapdb.git/': Problem with the > > > SSL CA cert (

Re: [Qemu-devel] [Xen-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-12 Thread Paul Durrant
> -Original Message- > From: Gerd Hoffmann [mailto:kra...@redhat.com] > Sent: 12 October 2017 10:26 > To: Paul Durrant ; 'Stefano Stabellini' > ; Anthony Perard > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; Owen Smith > > Subject: Re: [Xen-devel] [PATCH 3/3 v4] xenfb: Add [

[Qemu-devel] [PATCH] numa: fixup parsed NumaNodeOptions earlier

2017-10-12 Thread Igor Mammedov
numa 'mem' option with suffix or without one is possible only on CLI/HMP. Instead of fixing up special suffix less CLI case deep in parse_numa_node() do it earlier right after option is parsed into NumaNodeOptions with OptVisistor so that the rest of the code would use valid values in NumaNodeOptio

Re: [Qemu-devel] [PATCH] xen: Log errno rather than return value

2017-10-12 Thread Paul Durrant
> -Original Message- > From: Qemu-devel [mailto:qemu-devel- > bounces+paul.durrant=citrix@nongnu.org] On Behalf Of Ross Lagerwall > Sent: 11 October 2017 16:52 > To: qemu-devel@nongnu.org > Cc: Anthony Perard ; Ross Lagerwall > ; Stefano Stabellini > Subject: [Qemu-devel] [PATCH] xen:

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Peter Maydell
On 12 October 2017 at 10:30, Gerd Hoffmann wrote: > Indeed. Is this openbsd? They are a bit paranoid, possibly the usual > ca bundle (from nss/mozilla IIRC) isn't installed by default. No, it's an Ubuntu chroot. ca-certificates is "Priority: optional", so on a small thing like a chroot which on

Re: [Qemu-devel] [PATCH 0/7] migration: pause-before-device

2017-10-12 Thread Kevin Wolf
Am 12.10.2017 um 11:27 hat Daniel P. Berrange geschrieben: > On Thu, Oct 12, 2017 at 11:18:31AM +0200, Kevin Wolf wrote: > > Am 12.10.2017 um 10:21 hat Daniel P. Berrange geschrieben: > > > On Wed, Oct 11, 2017 at 08:13:10PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David

[Qemu-devel] [PATCH v3 10/13] nbd/client: refactor nbd_receive_starttls

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Split out nbd_receive_simple_option to be reused for structured reply option. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 64 nbd/trace-events | 7 --- 2 files changed, 50 insertions(+), 21 deletions(-) diff --

[Qemu-devel] [PATCH v3 07/13] nbd-server: simplify reply transmission

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Send qiov via qio_channel_writev_all instead of calling nbd_write twice with a cork. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 50 -- 1 file changed, 24 insertions(+), 26 deletions(-) diff --git a/nbd/server.c b/nbd/server.c i

[Qemu-devel] [PATCH v3 09/13] nbd: Minimal structured read for server

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Minimal implementation of structured read: one structured reply chunk, no segmentation. Minimal structured error implementation: no text message. Support DF flag, but just ignore it, as there is no segmentation any way. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 33 ++

[Qemu-devel] [PATCH v3 05/13] nbd/server: do not use NBDReply structure

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
NBDReply structure will be upgraded in future patches to handle both simple and structured replies and will be used only in the client Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 36 +++- 1 file changed, 15 insertions(+), 21 deletions(-) diff -

[Qemu-devel] [PATCH v3 02/13] block/nbd-client: refactor nbd_co_receive_reply

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Pass handle parameter directly, as the whole request isn't needed. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- block/nbd-client.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/nbd-client.c b/block/nbd-client.c index ddf273a6a4..c06

[Qemu-devel] [PATCH v3 04/13] nbd/server: structurize simple reply header sending

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Use packed structure instead of pointer arithmetics. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 6 ++ nbd/server.c| 36 ++-- 2 files changed, 20 insertions(+), 22 deletions(-) diff --git a/include/block/nbd.h b/include/bloc

[Qemu-devel] [PATCH v3 00/13] nbd minimal structured read

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Minimally implement nbd structured read extension. v3: clone: tag up-nbd-minimal-structured-read-v3 from https://src.openvz.org/scm/~vsementsov/qemu.git online: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=up-nbd-minimal-structured-read-v3 03: rename nbd_co_send_reply here too

[Qemu-devel] [PATCH v3 03/13] nbd: rename some simple-request related objects to be _simple_

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
To be consistent when their _structured_analogs will be introduced. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/nbd-internal.h | 2 +- nbd/client.c | 4 ++-- nbd/server.c | 12 ++-- nbd/trace-events

[Qemu-devel] [PATCH v3 11/13] nbd: share some nbd entities to be reused in block/nbd-client.c

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 48 nbd/nbd-internal.h | 25 - nbd/client.c| 32 3 files changed, 48 insertions(+), 57 deletions(-) diff --git

[Qemu-devel] [PATCH v3 01/13] block/nbd-client: assert qiov len once in nbd_co_request

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Also improve the assertion: check that qiov is NULL for other commands than CMD_READ and CMD_WRITE. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/block/nbd-client.c b/block/nbd-client.c index 7265

[Qemu-devel] [PATCH v3 08/13] nbd: header constants indenting

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Prepare indenting for the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake --- include/block/nbd.h | 15 --- nbd/nbd-internal.h | 34 +- 2 files changed, 25 insertions(+), 24 deletions(-) diff --git a/include/blo

Re: [Qemu-devel] [PATCH 0/7] migration: pause-before-device

2017-10-12 Thread Daniel P. Berrange
On Thu, Oct 12, 2017 at 11:52:40AM +0200, Kevin Wolf wrote: > Am 12.10.2017 um 11:27 hat Daniel P. Berrange geschrieben: > > On Thu, Oct 12, 2017 at 11:18:31AM +0200, Kevin Wolf wrote: > > > Am 12.10.2017 um 10:21 hat Daniel P. Berrange geschrieben: > > > > On Wed, Oct 11, 2017 at 08:13:10PM +0100,

[Qemu-devel] [PATCH v3 13/13] nbd: Minimal structured read for client

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Minimal implementation: for structured error only error_report error message. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/nbd.h | 6 + block/nbd-client.c | 395 nbd/client.c| 7 + 3 files changed, 379 insertions(

[Qemu-devel] [PATCH v3 12/13] nbd/client: prepare nbd_receive_reply for structured reply

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
In following patch nbd_receive_reply will be used both for simple and structured reply header receiving. NBDReply is altered into union of simple reply header and structured reply chunk header, simple error translation moved to block/nbd-client to be consistent with further structured reply error t

Re: [Qemu-devel] [RFC v4 00/16] VIRTIO-IOMMU device

2017-10-12 Thread Peter Maydell
On 11 October 2017 at 17:08, Auger Eric wrote: > Hi Peter, > > On 11/10/2017 16:56, Peter Maydell wrote: >> On 19 September 2017 at 08:46, Eric Auger wrote: >>> This series implements the virtio-iommu device. >>> >>> This v4 is an upgrade to v0.4 spec [1] and applies on QEMU v2.10.0. >>> - probe

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Gerd Hoffmann
Hi, > FreeBSD: > > >   CC  ui/input-keymap.o > /root/qemu/ui/input-keymap.c:8:10: fatal error: > 'ui/input-keymap-linux-to-qcode.c' file not found > #include "ui/input-keymap-linux-to-qcode.c" >  ^ scripts/git-modules.sh has no bashims, a simple s/bash/sh/ fixes the build on freeb

[Qemu-devel] [PATCH v3 06/13] nbd/server: refactor nbd_co_send_simple_reply parameters

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
Pass client and buffer (*data) parameters directly, to make the function consistent with further structured reply sending functions. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/server.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/nbd/server.c b/nbd/s

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Gerd Hoffmann
Hi, > Not AFAICT - if i try it just never completes connect() Hmm, so maybe we should mirror the thing on git.qemu.org and use that? cheers, Gerd

Re: [Qemu-devel] [PATCH 03/10] migration: Make cache size elements use the right types

2017-10-12 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/page_cache.c | 8 > migration/page_cache.h | 2 +- > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/migration/page_cache.c b/migration/page_cache.c > index 381e555ddb..6b2dd7

Re: [Qemu-devel] [PATCH 0/7] migration: pause-before-device

2017-10-12 Thread Daniel P. Berrange
On Wed, Oct 11, 2017 at 08:13:10PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This set attempts to make a race condition between migration and > drive-mirror (and other block users) soluble by allowing the migration > to be paused after the source qemu

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Daniel P. Berrange
On Thu, Oct 12, 2017 at 12:04:47PM +0200, Gerd Hoffmann wrote: > Hi, > > > Not AFAICT - if i try it just never completes connect() > > Hmm, so maybe we should mirror the thing on git.qemu.org and use that? Can that be made 100% automated - I don't want to have to push changes to two different

Re: [Qemu-devel] [PULL 0/5] Python queue, 2017-10-11

2017-10-12 Thread Peter Maydell
On 11 October 2017 at 19:50, Eduardo Habkost wrote: > The following changes since commit bac960832015bf4c4c1b873011612e2675e4464c: > > Merge remote-tracking branch 'remotes/elmarco/tags/vus-pull-request' into > staging (2017-10-11 13:10:36 +0100) > > are available in the git repository at: > >

Re: [Qemu-devel] [RFC v4 00/16] VIRTIO-IOMMU device

2017-10-12 Thread Auger Eric
Hi Peter, On 12/10/2017 11:54, Peter Maydell wrote: > On 11 October 2017 at 17:08, Auger Eric wrote: >> Hi Peter, >> >> On 11/10/2017 16:56, Peter Maydell wrote: >>> On 19 September 2017 at 08:46, Eric Auger wrote: This series implements the virtio-iommu device. This v4 is an upgr

Re: [Qemu-devel] [PATCH 1/5] hbitmap: add next_zero function

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
10.10.2017 00:51, John Snow wrote: On 10/02/2017 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: The function searches for next zero bit. Also add interface for BdrvDirtyBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy --- include/block/dirty-bitmap.h | 1 + include/qemu/hbitmap.h

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Peter Maydell
On 12 October 2017 at 11:07, Daniel P. Berrange wrote: > On Thu, Oct 12, 2017 at 12:04:47PM +0200, Gerd Hoffmann wrote: >> Hi, >> >> > Not AFAICT - if i try it just never completes connect() >> >> Hmm, so maybe we should mirror the thing on git.qemu.org and use that? > > Can that be made 100% au

Re: [Qemu-devel] [PATCH v1 4/5] s390x/pci: Refuse to realize VFIO-PCI if AIS needed but supported

2017-10-12 Thread Pierre Morel
On 11/10/2017 14:20, Cornelia Huck wrote: On Tue, 10 Oct 2017 18:01:53 +0200 Pierre Morel wrote: Since in the case we have no AIS in KVM only PCI is impacted, do you think we can fence IRQFD for MSI with kvm_msi_via_irqfd_allowed = false; in kvm_arch_init_irq_routing() ? Hm, it seems we ne

Re: [Qemu-devel] [PATCH v2] cirrus: fix oob access in mode4and5 write functions

2017-10-12 Thread P J P
+-- On Wed, 11 Oct 2017, Gerd Hoffmann wrote --+ | Move dst calculation into the loop, so we apply the mask on each s/into the loop/inside for loop | interation and will not overflow vga memory. s/interation/iteration | diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c | index afc

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Gerd Hoffmann
On Thu, 2017-10-12 at 11:07 +0100, Daniel P. Berrange wrote: > On Thu, Oct 12, 2017 at 12:04:47PM +0200, Gerd Hoffmann wrote: > >   Hi, > > > > > Not AFAICT - if i try it just never completes connect() > > > > Hmm, so maybe we should mirror the thing on git.qemu.org and use > > that? > > Can tha

Re: [Qemu-devel] [PULL 00/10] Ui 20171011 patches

2017-10-12 Thread Daniel P. Berrange
On Thu, Oct 12, 2017 at 12:13:23PM +0200, Gerd Hoffmann wrote: > On Thu, 2017-10-12 at 11:07 +0100, Daniel P. Berrange wrote: > > On Thu, Oct 12, 2017 at 12:04:47PM +0200, Gerd Hoffmann wrote: > > >   Hi, > > > > > > > Not AFAICT - if i try it just never completes connect() > > > > > > Hmm, so ma

Re: [Qemu-devel] [PATCH] s390x/MAINTAINERS: add mailing list

2017-10-12 Thread Christian Borntraeger
On 10/12/2017 09:40 AM, Cornelia Huck wrote: > On Thu, 12 Oct 2017 08:02:12 +0200 > Thomas Huth wrote: > >> On 05.10.2017 17:16, Cornelia Huck wrote: >>> On Thu, 5 Oct 2017 17:13:13 +0200 >>> Cornelia Huck wrote: >>> There's a new qemu-s3...@nongnu.org mailing list: add it to the

Re: [Qemu-devel] [PATCH] s390x/MAINTAINERS: add mailing list

2017-10-12 Thread Cornelia Huck
On Thu, 12 Oct 2017 12:20:47 +0200 Christian Borntraeger wrote: > On 10/12/2017 09:40 AM, Cornelia Huck wrote: > > On Thu, 12 Oct 2017 08:02:12 +0200 > > Thomas Huth wrote: > > > >> On 05.10.2017 17:16, Cornelia Huck wrote: > >>> On Thu, 5 Oct 2017 17:13:13 +0200 > >>> Cornelia Huck wrote

Re: [Qemu-devel] [PATCH] s390x/MAINTAINERS: add mailing list

2017-10-12 Thread Christian Borntraeger
On 10/12/2017 12:34 PM, Cornelia Huck wrote: > On Thu, 12 Oct 2017 12:20:47 +0200 > Christian Borntraeger wrote: > >> On 10/12/2017 09:40 AM, Cornelia Huck wrote: >>> On Thu, 12 Oct 2017 08:02:12 +0200 >>> Thomas Huth wrote: >>> On 05.10.2017 17:16, Cornelia Huck wrote: > On Thu,

Re: [Qemu-devel] [RFC 0/3] vITS Reset

2017-10-12 Thread Peter Maydell
On 11 October 2017 at 17:06, Auger Eric wrote: > On 09/10/2017 20:17, Peter Maydell wrote: >> It's not clear to me why we need a new KVM device attribute >> for doing ITS reset. The usual approach for this is: >> * system reset causes QEMU's device model reset code >>to reset state structure

Re: [Qemu-devel] [PATCH 3/3 v4] xenfb: Add [feature|request]-raw-pointer

2017-10-12 Thread Anthony PERARD
On Wed, Oct 11, 2017 at 01:19:25PM -0700, Stefano Stabellini wrote: > On Wed, 11 Oct 2017, Anthony PERARD wrote: > > The only observation I have is that on a Linux guest, when I have > > usbdevice=tablet, with this series the pv mouse seems to become the > > primary way of gueting mouse events (wit

Re: [Qemu-devel] [RFC] KVM "fake DAX" device flushing

2017-10-12 Thread Pankaj Gupta
> On Thu, Oct 12, 2017 at 12:21:46AM +0530, Pankaj Gupta wrote: > > We are sharing the prototype version of 'fake DAX' flushing > > interface for the initial feedback. This is still work in progress > > and not yet ready for merging. > > > > Protoype right now just implements basic functionality

Re: [Qemu-devel] [RFC v4 00/16] VIRTIO-IOMMU device

2017-10-12 Thread Jean-Philippe Brucker
On 12/10/17 11:09, Auger Eric wrote: > Hi Peter, > > On 12/10/2017 11:54, Peter Maydell wrote: >> On 11 October 2017 at 17:08, Auger Eric wrote: >>> Hi Peter, >>> >>> On 11/10/2017 16:56, Peter Maydell wrote: On 19 September 2017 at 08:46, Eric Auger wrote: > This series implements the

Re: [Qemu-devel] [PATCH v3 00/13] nbd minimal structured read

2017-10-12 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171012095319.136610-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v3 00/13] nbd minimal structured read === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

Re: [Qemu-devel] [PATCH v3 00/13] nbd minimal structured read

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
This is a code movement, no changes. 12.10.2017 13:49, no-re...@patchew.org wrote: Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20171012095319.136610-1-vsement...@virtuozzo.com Subject: [Qemu-devel] [PATCH v3 00/13] n

[Qemu-devel] [PATCH] usb-ccid: remove needless migration state code

2017-10-12 Thread Marc-André Lureau
This code appears to be unused since its introduction. It should be safe to remove from VMState. Signed-off-by: Marc-André Lureau --- hw/usb/dev-smartcard-reader.c | 22 -- 1 file changed, 22 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-read

Re: [Qemu-devel] [PATCH 3/5] backup: init copy_bitmap from sync_bitmap for incremental

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
10.10.2017 01:56, John Snow wrote: On 10/02/2017 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: We should not copy non-dirty clusters in write notifiers. So, initialize copy_bitmap from sync_bitmap. ...! Duh, good find!! So, previously we'd copy extra sectors if they just so happened to be wr

Re: [Qemu-devel] [PATCH 4/5] backup: simplify non-dirty bits progress processing

2017-10-12 Thread Vladimir Sementsov-Ogievskiy
10.10.2017 02:44, John Snow wrote: On 10/02/2017 10:39 AM, Vladimir Sementsov-Ogievskiy wrote: Set fake progress for non-dirty clusters in copy_bitmap initialization, to. It simplifies code and allows further refactoring. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Motivation (some of th

Re: [Qemu-devel] [PATCH v2 2/8] s390x/css: IO instr handler ending control

2017-10-12 Thread Halil Pasic
On 10/12/2017 08:58 AM, Thomas Huth wrote: > On 10.10.2017 13:41, Halil Pasic wrote: >> [..] Yeah, the ABI is smart enough (where it matters) and this one is obviously less that 8 bytes. I read this as you assumed that the return won't be passed via register (general purpose

Re: [Qemu-devel] [RFC 3/3] hw/intc/arm_gicv3_its: Implement reset

2017-10-12 Thread Peter Maydell
On 27 September 2017 at 15:56, Eric Auger wrote: > Currently the ITS is not reset and this causes trouble > when state backup is initiated before the guest has initialized > the ITS registers and especially GITS_CBASER. > > We are likely to save register values set before the reset/ > restart. The

Re: [Qemu-devel] [RFC 1/3] hw/intc/arm_gicv3_its: Don't abort on table save/restore

2017-10-12 Thread Peter Maydell
On 27 September 2017 at 15:56, Eric Auger wrote: > The ITS is not properly reset at the moment. It is possible the > GITS_BASER.valid is set and the in-kernel ITS caches are not > empty (list of devices, collections, LPIs) while data structures > in guest RAM are invalid/inconsistent. > > For inst

Re: [Qemu-devel] [PATCH 09/10] migration: Make xbzrle_cache_size a migration parameter

2017-10-12 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Right now it is a variable in MigrationState instead of a > MigrationParameter. The change allows to set it as the rest of the > Migration parameters, from the command line, with > query_migration_paramters, set_migrate_parameters, etc. > > Signed-of

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-12 Thread Halil Pasic
On 10/10/2017 04:36 PM, Halil Pasic wrote: > > > On 10/10/2017 03:07 PM, Cornelia Huck wrote: >> On Wed, 4 Oct 2017 17:41:39 +0200 >> Halil Pasic wrote: >> >>> Simplify the error handling of the SSCH and RSCH handler avoiding >>> arbitrary and cryptic error codes being used to tell how the in

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-12 Thread Cornelia Huck
On Thu, 12 Oct 2017 14:06:42 +0200 Halil Pasic wrote: > On 10/10/2017 04:36 PM, Halil Pasic wrote: > > > > > > On 10/10/2017 03:07 PM, Cornelia Huck wrote: > >> On Wed, 4 Oct 2017 17:41:39 +0200 > >> Halil Pasic wrote: > >> > >>> Simplify the error handling of the SSCH and RSCH handler av

Re: [Qemu-devel] [PATCH v2 3/8] s390x: improve error handling for SSCH and RSCH

2017-10-12 Thread Halil Pasic
On 10/12/2017 02:11 PM, Cornelia Huck wrote: > On Thu, 12 Oct 2017 14:06:42 +0200 > Halil Pasic wrote: > >> On 10/10/2017 04:36 PM, Halil Pasic wrote: >>> >>> >>> On 10/10/2017 03:07 PM, Cornelia Huck wrote: On Wed, 4 Oct 2017 17:41:39 +0200 Halil Pasic wrote: > Simplif

Re: [Qemu-devel] [RFC v2 10/33] migration: allow dst vm pause on postcopy

2017-10-12 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Tue, Oct 10, 2017 at 01:30:18PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Mon, Oct 09, 2017 at 07:58:13PM +0100, Dr. David Alan Gilbert wrote: > > [...] > > > > > We have to be careful about this; a network c

[Qemu-devel] QAPI magician wanted ...

2017-10-12 Thread Igor Mammedov
I'm working on introducing QMP command to set numa mappings via QMP interface at runtime instead of CLI. I'd prefer to reuse NumaOptions for parsing input, but I can't wrap my head around QAPI magic. So far I've added new command in qapi-schema.json: { 'command': 'set-numa-node',

Re: [Qemu-devel] [PATCH] tests/pxe: Test more NICs when running in SPEED=slow mode

2017-10-12 Thread Thomas Huth
On 20.09.2017 11:02, Thomas Huth wrote: > The pxe-test is a very good test to excercise NICs, thus we should use > it to test all NICs that can be used by the BIOS for booting via network. > However, to avoid that the default testing time increases too much, the > additional NICs are only tested in

Re: [Qemu-devel] QAPI magician wanted ...

2017-10-12 Thread Daniel P. Berrange
On Thu, Oct 12, 2017 at 02:21:53PM +0200, Igor Mammedov wrote: > > I'm working on introducing QMP command to set numa mappings > via QMP interface at runtime instead of CLI. > > I'd prefer to reuse NumaOptions for parsing input, > but I can't wrap my head around QAPI magic. > > So far I've added

Re: [Qemu-devel] [RFC v2 09/22] monitor: create monitor dedicate iothread

2017-10-12 Thread Stefan Hajnoczi
On Fri, Sep 29, 2017 at 11:38:31AM +0800, Peter Xu wrote: > @@ -4126,10 +4150,23 @@ void monitor_init(Chardev *chr, int flags) > qemu_mutex_unlock(&monitor_lock); > } > > +static void monitor_io_thread_destroy(void) > +{ > +iothread_destroy(mon_global.mon_io_thread); > +mon_global.m

Re: [Qemu-devel] [PATCH v4 0/9] Support the Capstone disassembler

2017-10-12 Thread Peter Maydell
On 28 September 2017 at 17:54, Richard Henderson wrote: > Changes since v3: > * Adjust how the submodule is detected and invoked. > - This should fix the reported patchew failure, > - Fixes e.g. -m32 "cross" compilation, or similar > abi-changing option sets. > > > r~ > > > Richard

Re: [Qemu-devel] [RFC v2 10/22] monitor: allow to use IO thread for parsing

2017-10-12 Thread Stefan Hajnoczi
On Fri, Sep 29, 2017 at 11:38:32AM +0800, Peter Xu wrote: > For each Monitor, add one field "use_io_thr" to show whether it will be > using the dedicated monitor IO thread to handle input/output. When set, > monitor IO parsing work will be offloaded to dedicated monitor IO > thread, rather than th

Re: [Qemu-devel] QAPI magician wanted ...

2017-10-12 Thread Igor Mammedov
On Thu, 12 Oct 2017 13:28:26 +0100 "Daniel P. Berrange" wrote: > On Thu, Oct 12, 2017 at 02:21:53PM +0200, Igor Mammedov wrote: > > > > I'm working on introducing QMP command to set numa mappings > > via QMP interface at runtime instead of CLI. > > > > I'd prefer to reuse NumaOptions for parsin

[Qemu-devel] qemu.org: new git repos to be mirrored (qemu-palcode, capstone, keycodemapdb)

2017-10-12 Thread Peter Maydell
On 12 October 2017 at 11:14, Daniel P. Berrange wrote: > On Thu, Oct 12, 2017 at 12:13:23PM +0200, Gerd Hoffmann wrote: >> On Thu, 2017-10-12 at 11:07 +0100, Daniel P. Berrange wrote: >> > On Thu, Oct 12, 2017 at 12:04:47PM +0200, Gerd Hoffmann wrote: >> > > Hmm, so maybe we should mirror the thin

Re: [Qemu-devel] [RFC QEMU PATCH v3 00/10] Implement vNVDIMM for Xen HVM guest

2017-10-12 Thread Haozhong Zhang
On 10/10/17 12:05 -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 12, 2017 at 11:15:09AM +0800, Haozhong Zhang wrote: > > On 09/11/17 11:52 -0700, Stefano Stabellini wrote: > > > CC'ing xen-devel, and the Xen tools and x86 maintainers. > > > > > > On Mon, 11 Sep 2017, Igor Mammedov wrote: > > >

Re: [Qemu-devel] [RFC v2 13/22] monitor: separate QMP parser and dispatcher

2017-10-12 Thread Stefan Hajnoczi
On Fri, Sep 29, 2017 at 11:38:35AM +0800, Peter Xu wrote: > Originally QMP is going throw these steps: s/is going throw/goes through/ > > JSON Parser --> QMP Dispatcher --> Respond > /|\(2)(3) | >(1) | \|/ (4) >+-

Re: [Qemu-devel] [RFC v2 15/22] monitor: send event when request queue full

2017-10-12 Thread Stefan Hajnoczi
On Fri, Sep 29, 2017 at 11:38:37AM +0800, Peter Xu wrote: > Set maximum QMP request queue length to 8. If queue full, instead of > queue the command, we directly return a "request-dropped" event, telling > client that specific command is dropped. > > Signed-off-by: Peter Xu > --- > monitor.c |

[Qemu-devel] [PATCH v4] docs/devel/loads-stores.rst: Document our various load and store APIs

2017-10-12 Thread Peter Maydell
QEMU has a wide selection of different functions for doing loads and stores; provide some overview documentation of what they do and how to pick which one to use. Signed-off-by: Peter Maydell Reviewed-by: Eric Blake --- Changes v3->v4: last couple of nits fixed, added Eric's r-by tag. Changes v

Re: [Qemu-devel] [PATCH] s390x/MAINTAINERS: add mailing list

2017-10-12 Thread Cornelia Huck
On Thu, 5 Oct 2017 17:13:13 +0200 Cornelia Huck wrote: > There's a new qemu-s3...@nongnu.org mailing list: add it to the > s390 sections. > > Signed-off-by: Cornelia Huck > --- > MAINTAINERS | 6 ++ > 1 file changed, 6 insertions(+) Queued to s390-next.

[Qemu-devel] [PATCH 31/31] qcow2: Allow configuring the L2 slice size

2017-10-12 Thread Alberto Garcia
Now that the code is ready to handle L2 slices we can finally add an option to allow configuring their size. An L2 slice is the portion of an L2 table that is read by the qcow2 cache. Until now the cache was always reading full L2 tables, and since the L2 table size is equal to the cluster size th

[Qemu-devel] [PATCH 28/31] qcow2: Rename l2_table in count_contiguous_clusters()

2017-10-12 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --g

[Qemu-devel] [PATCH 23/31] qcow2: Update zero_single_l2() to support L2 slices

2017-10-12 Thread Alberto Garcia
zero_single_l2() limits the number of clusters to be zeroed to the amount that fits inside an L2 table. Since we'll be loading L2 slices instead of full tables we need to update that limit. Apart from that, this function doesn't need any additional changes, so this patch simply updates the variabl

[Qemu-devel] [PATCH 30/31] qcow2: Rename l2_table in count_cow_clusters()

2017-10-12 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PATCH 02/31] qcow2: Add table size field to Qcow2Cache

2017-10-12 Thread Alberto Garcia
The table size in the qcow2 cache is currently equal to the cluster size. This doesn't allow us to use the cache memory efficiently, particularly with large cluster sizes, so we need to be able to have smaller cache tables that are independent from the cluster size. This patch adds a new field to Q

[Qemu-devel] [PATCH 27/31] qcow2: Rename l2_table in qcow2_alloc_compressed_cluster_offset()

2017-10-12 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[Qemu-devel] [PATCH 21/31] qcow2: Update handle_alloc() to support L2 slices

2017-10-12 Thread Alberto Garcia
handle_alloc() loads an L2 table and limits the number of checked clusters to the amount that fits inside that table. Since we'll be loading L2 slices instead of full tables we need to update that limit. Apart from that, this function doesn't need any additional changes, so this patch simply updat

[Qemu-devel] [PATCH 26/31] qcow2: Update qcow2_truncate() to support L2 slices

2017-10-12 Thread Alberto Garcia
The qcow2_truncate() code is mostly independent from whether we're using L2 slices or full L2 tables, but in full and falloc preallocation modes new L2 tables are allocated using qcow2_alloc_cluster_link_l2(). Therefore the code needs to be modified to ensure that all nb_clusters that are processe

[Qemu-devel] [PATCH 29/31] qcow2: Rename l2_table in count_contiguous_clusters_unallocated()

2017-10-12 Thread Alberto Garcia
This function doesn't need any changes to support L2 slices, but since it's now dealing with slices intead of full tables, the l2_table variable is renamed for clarity. Signed-off-by: Alberto Garcia --- block/qcow2-cluster.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 22/31] qcow2: Update discard_single_l2() to support L2 slices

2017-10-12 Thread Alberto Garcia
discard_single_l2() limits the number of clusters to be discarded to the amount that fits inside an L2 table. Since we'll be loading L2 slices instead of full tables we need to update that limit. Apart from that, this function doesn't need any additional changes, so this patch simply updates the v

[Qemu-devel] [PATCH 15/31] qcow2: Update l2_load() to support L2 slices

2017-10-12 Thread Alberto Garcia
Each entry in the qcow2 L2 cache stores a full L2 table (which uses a complete cluster in the qcow2 image). A cluster is usually too large to be used efficiently as the size for a cache entry, so we want to decouple both values by allowing smaller cache entries. Therefore the qcow2 L2 cache will no

[Qemu-devel] [PATCH 25/31] qcow2: Update expand_zero_clusters_in_l1() to support L2 slices

2017-10-12 Thread Alberto Garcia
expand_zero_clusters_in_l1() expands zero clusters as a necessary step to downgrade qcow2 images to a version that doesn't support metadata zero clusters. This function takes an L1 table (which may or may not be active) and iterates over all its L2 tables looking for zero clusters. Since we'll be

[Qemu-devel] [PATCH 24/31] qcow2: Update qcow2_update_snapshot_refcount() to support L2 slices

2017-10-12 Thread Alberto Garcia
qcow2_update_snapshot_refcount() increases the refcount of all clusters of a given snapshot. In order to do that it needs to load all its L2 tables and iterate over their entries. Since we'll be loading L2 slices instead of full tables we need to add an extra loop that iterates over all slices of e

[Qemu-devel] [PATCH 18/31] qcow2: Update qcow2_get_cluster_offset() to support L2 slices

2017-10-12 Thread Alberto Garcia
qcow2_get_cluster_offset() checks how many contiguous bytes are available at a given offset. The returned number of bytes is limited by the amount that can be addressed without having to load more than one L2 table. Since we'll be loading L2 slices instead of full tables this patch changes the lim

[Qemu-devel] [PATCH 14/31] qcow2: Add offset_to_l2_slice_index()

2017-10-12 Thread Alberto Garcia
Similar to offset_to_l2_index(), this function takes a guest offset and returns the index in the L2 slice that contains its L2 entry. An L2 slice has currently the same size as an L2 table (one cluster), so both functions return the same value for now. Signed-off-by: Alberto Garcia --- block/qc

[Qemu-devel] [PATCH 20/31] qcow2: Update handle_copied() to support L2 slices

2017-10-12 Thread Alberto Garcia
handle_copied() loads an L2 table and limits the number of checked clusters to the amount that fits inside that table. Since we'll be loading L2 slices instead of full tables we need to update that limit. Apart from that, this function doesn't need any additional changes, so this patch simply upda

[Qemu-devel] [PATCH 08/31] qcow2: Remove BDS parameter from qcow2_cache_destroy()

2017-10-12 Thread Alberto Garcia
This function was never using the BlockDriverState parameter so it can be safely removed. Signed-off-by: Alberto Garcia --- block/qcow2-cache.c | 2 +- block/qcow2.c | 16 block/qcow2.h | 2 +- 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/block/

  1   2   3   >