On Fri, 29 Sep 2017 17:15:54 -0700
Alistair Francis wrote:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
> diff --git a/hw/intc/s390_flic_kvm.c b/hw/intc/s390_flic
On Fri, 29 Sep 2017 17:17:26 -0700
Alistair Francis wrote:
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
> diff --git a/target/s390x/kvm.c b/target/s390x/kvm.c
> i
On Tue, 2017-10-03 at 17:21 -0400, Stefan Berger wrote:
> On 09/29/2017 07:10 AM, Amarnath Valluri wrote:
> >
> > This change introduces a new TPM backend driver that can
> > communicate with
> > swtpm(software TPM emulator) using unix domain socket interface.
> > QEMU talks to
> > TPM emulator us
ping
On Wed, Sep 27, 2017 at 03:21:18PM +, Jens Freimann wrote:
Since commit 0f8c289ad "net: fix -netdev socket,fd= for UDP sockets"
we allow more than one parameter for -netdev socket. But now
we run into an assert when no parameter at all is specified
qemu-system-x86_64 -netdev socket
s
On Mon, 02 Oct 2017 09:46:41 +0200
Markus Armbruster wrote:
> David Hildenbrand writes:
>
> > CPU hotplug is only possible on a per core basis on s390x. So let's
> > add possible_cpus and properly wire everything up.
> >
> > Signed-off-by: David Hildenbrand
> [...]
> > diff --git a/qapi-sche
On Mon, 02 Oct 2017 09:47:58 +0200
Markus Armbruster wrote:
> Cornelia Huck writes:
>
> > On Wed, 13 Sep 2017 15:23:55 +0200
> > David Hildenbrand wrote:
> >
> >> The first patches are a bunch of cleanups. I decided to go the
> >> extra mile and implement CPU hotplug via "device_add", as wel
On Tue, 3 Oct 2017 13:58:29 +0200
Thomas Huth wrote:
> On 11.07.2017 16:54, Halil Pasic wrote:
> > Turn on migration for the channel subsystem for the next machine. For
> > legacy machines we still have to do things the old way.
> >
> > Signed-off-by: Halil Pasic
> > Reviewed-by: Cornelia Huck
On Thu, Aug 10, 2017 at 11:13 PM, Stefan Hajnoczi
wrote:
> On Thu, Aug 10, 2017 at 9:18 AM, Ashijeet Acharya
> wrote:
> > On Thu, Aug 10, 2017 at 1:41 PM, Stefan Hajnoczi
> wrote:
> >>
> >> On Thu, Jul 27, 2017 at 3:33 PM, Ashijeet Acharya
> >> wrote:
> >> > Previously posted series patches:
>
On Wed, 10/04 13:47, Ashijeet Acharya wrote:
> Fam: Ping?
Hi Ashijeet, looks like this patch doesn't apply to current master, could you
rebase and post another version?
Fam
On Wed, Oct 4, 2017 at 1:58 PM, Fam Zheng wrote:
> On Wed, 10/04 13:47, Ashijeet Acharya wrote:
> > Fam: Ping?
>
> Hi Ashijeet, looks like this patch doesn't apply to current master, could
> you
> rebase and post another version?
>
Hello Fam,
I will try to do it over the weekend then and you ca
On Tue, Oct 03, 2017 at 04:07:06PM -0600, Alex Williamson wrote:
> On Tue, 19 Sep 2017 14:29:33 +0200
> Paolo Bonzini wrote:
>
> > From: "Daniel P. Berrange"
> >
> > Currently before submitting a series, devs should run checkpatch.pl
> > across each patch to be submitted. This can be automated
On Tue, Oct 03, 2017 at 06:17:29PM -0300, Eduardo Habkost wrote:
> Both -nodefconfig and -no-user-config options do the same thing
> today, we only need one variable to keep track of them.
>
> Suggested-by: Markus Armbruster
> Acked-by: Alistair Francis
> Reviewed-by: Markus Armbruster
> Signed
On Tue, Oct 03, 2017 at 06:17:30PM -0300, Eduardo Habkost wrote:
> Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we
> have no default config files that would be disabled using
> -nodefconfig. Update documentation and document -nodefconfig as
> deprecated.
>
> Cc: Markus Armbruste
On Wed, Oct 04, 2017 at 12:00:25AM -0300, Eduardo Habkost wrote:
> Since 2012 (commit ba6212d8 "Eliminate cpus-x86_64.conf file") we
> have no default config files that would be disabled using
> -nodefconfig. Update documentation and document -nodefconfig as
> deprecated.
>
> Cc: Markus Armbruste
On Wed, Oct 04, 2017 at 12:00:24AM -0300, Eduardo Habkost wrote:
> Both -nodefconfig and -no-user-config options do the same thing
> today, we only need one variable to keep track of them.
>
> Suggested-by: Markus Armbruster
> Acked-by: Alistair Francis
> Reviewed-by: Markus Armbruster
> Signed
Hi!
Any chance that this patch gets merged soon?
Looks like it has been reviewed by at least Richard and Philippe.
Adrian
On 09/15/2017 09:33 PM, James Clarke wrote:
Fixes: https://bugs.launchpad.net/qemu/+bug/1716767
Signed-off-by: James Clarke
---
Changes since v2:
* Fixed opening curly
Signed-off-by: Greg Kurz
---
hw/ppc/spapr.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 352ff3d614e8..b284e0b9d43e 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -2334,7 +2334,8 @@ static void ppc_spapr_init(MachineState *mac
Hi,
> This fails to build from clean (x86-64 Linux host):
>
> make[1]: *** No rule to make target '../hw/usb/host-stub.o', needed
> by
> 'qemu-system-microblaze'. Stop.
>
> (and similar for other targets).
/me looks puzzled.
There is a "hw/usb/host-stub.c" file in the repo, so I fail so see
Add missing categorizations for some s390x devices:
- zpci device -> misc
- 3270 -> display
- vfio-ccw -> misc
Signed-off-by: Cornelia Huck
---
hw/s390x/3270-ccw.c | 1 +
hw/s390x/s390-pci-bus.c | 1 +
hw/vfio/ccw.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/hw/s390x/327
On 10/04/2017 11:00 AM, Cornelia Huck wrote:
> Add missing categorizations for some s390x devices:
> - zpci device -> misc
> - 3270 -> display
> - vfio-ccw -> misc
>
> Signed-off-by: Cornelia Huck
Acked-by: Christian Borntraeger
> ---
> hw/s390x/3270-ccw.c | 1 +
> hw/s390x/s390-pci-bus.c
The CAS buffer is provided by SLOF. A broken SLOF could pass a silly
size: either smaller than the diff header, in which case the current
code will try to allocate 16 Exabytes of memory and g_malloc0() will
abort, or bigger than the maximum memory provisioned for SLOF (ie,
40 Megabytes), which does
>>> On 03.10.17 at 02:12, wrote:
> On Thu, Sep 28, 2017 at 10:12:34AM -0300, Eduardo Habkost wrote:
>> On Thu, Sep 28, 2017 at 02:33:57AM -0600, Jan Beulich wrote:
>> > >>> On 27.09.17 at 21:56, wrote:
>> > > --- a/hw/xen/xen_pt.c
>> > > +++ b/hw/xen/xen_pt.c
>> > > @@ -964,6 +964,10 @@ static co
On 04.10.2017 11:00, Cornelia Huck wrote:
> Add missing categorizations for some s390x devices:
> - zpci device -> misc
> - 3270 -> display
> - vfio-ccw -> misc
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c | 1 +
> hw/s390x/s390-pci-bus.c | 1 +
> hw/vfio/ccw.c | 1
Content is based on Michael Roth's announce e-mail for this release.
Signed-off-by: Thomas Huth
---
_posts/2017-10-04-qemu-2-10-1.md | 21 +
1 file changed, 21 insertions(+)
create mode 100644 _posts/2017-10-04-qemu-2-10-1.md
diff --git a/_posts/2017-10-04-qemu-2-10-1.md b/
04.10.2017 01:00, Alex Williamson wrote:
Commit c3e5875afc0f ("checkpatch: check trace-events code style")
introduces a regression as reported:
https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg05820.html
Bareword found where operator expected at ./scripts/checkpatch.pl line 1350, near
On 10/04/2017 10:16 AM, Cornelia Huck wrote:
> On Tue, 3 Oct 2017 13:58:29 +0200
> Thomas Huth wrote:
>
>> On 11.07.2017 16:54, Halil Pasic wrote:
>>> Turn on migration for the channel subsystem for the next machine. For
>>> legacy machines we still have to do things the old way.
>>>
>>> Signe
On 04.10.2017 10:43, Gerd Hoffmann wrote:
> Hi,
>
>> This fails to build from clean (x86-64 Linux host):
>>
>> make[1]: *** No rule to make target '../hw/usb/host-stub.o', needed
>> by
>> 'qemu-system-microblaze'. Stop.
>>
>> (and similar for other targets).
>
> /me looks puzzled.
>
> There is
On 04/10/2017 11:31, Thomas Huth wrote:
> Content is based on Michael Roth's announce e-mail for this release.
>
> Signed-off-by: Thomas Huth
> ---
> _posts/2017-10-04-qemu-2-10-1.md | 21 +
> 1 file changed, 21 insertions(+)
> create mode 100644 _posts/2017-10-04-qemu-2-10-
On Mon, Oct 2, 2017 at 3:45 PM, Markus Armbruster wrote:
> A command's STEXI..ETEXI stanza follows the command's initializer.
> Two commands got them backwards. Correct that.
>
> Signed-off-by: Markus Armbruster
> ---
> hmp-commands-info.hx | 20 ++--
> 1 file changed, 10 inser
Hi,
>
> Ah, deja vu. I think you've now run into the problem that I had with
> my
> patch, too - see:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01875.html
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02082.html
>
> I think this is a race condition when buildi
On Wed, 4 Oct 2017 11:20:00 +0200
Thomas Huth wrote:
> On 04.10.2017 11:00, Cornelia Huck wrote:
> > Add missing categorizations for some s390x devices:
> > - zpci device -> misc
> > - 3270 -> display
> > - vfio-ccw -> misc
> >
> > Signed-off-by: Cornelia Huck
> > ---
> > hw/s390x/3270-ccw.c
On Wed, 4 Oct 2017 11:00:32 +0200
Cornelia Huck wrote:
> Add missing categorizations for some s390x devices:
> - zpci device -> misc
> - 3270 -> display
> - vfio-ccw -> misc
>
> Signed-off-by: Cornelia Huck
> ---
> hw/s390x/3270-ccw.c | 1 +
> hw/s390x/s390-pci-bus.c | 1 +
> hw/vfio/ccw.
On Wed, Oct 04, 2017 at 11:02:31AM +0200, Greg Kurz wrote:
> The CAS buffer is provided by SLOF. A broken SLOF could pass a silly
> size: either smaller than the diff header, in which case the current
> code will try to allocate 16 Exabytes of memory and g_malloc0() will
> abort, or bigger than the
On Wed, Oct 04, 2017 at 10:43:18AM +0200, Greg Kurz wrote:
> Signed-off-by: Greg Kurz
Applied, except I corrected the short description.
ibm,client-architecture-support is an OF word, not actually an RTAS
method.
> ---
> hw/ppc/spapr.c |3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-
On 04/10/2017 11:37, Thomas Huth wrote:
> Ah, deja vu. I think you've now run into the problem that I had with my
> patch, too - see:
>
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01875.html
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02082.html
>
> I think this is
04.10.2017 01:00, Alex Williamson wrote:
Commit c3e5875afc0f ("checkpatch: check trace-events code style")
introduces a regression as reported:
https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg05820.html
Bareword found where operator expected at ./scripts/checkpatch.pl line 1350, near
On 04/10/2017 11:50, Gerd Hoffmann wrote:
> Hi,
>>
>> Ah, deja vu. I think you've now run into the problem that I had with
>> my
>> patch, too - see:
>>
>> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01875.html
>> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg02082.html
Which version of QEMU are you using? Did you compile QEMU on your own or are
you using a pre-build binary?
Anyway, to be able to use USB devices, you've got to specify the "-usb"
parameter when starting QEMU.
--
You received this bug notification because you are a member of qemu-
devel-ml, whic
following thread '[PATCH 01/38] qom: add helper type_init_from_array()'
here is reworked variant of above patch as Eduardo have suggested
(+ split in several atomic parts)
PS:
posting for early review, I'll wait for a couple of days before reposting whole
series that will use DEFINE_TYPES() to sim
type_register()/type_register_static() functions in current impl.
can't fail returning 0, also none of the users check for error
so update doc comment to reflect current behaviour.
Suggested-by: Eduardo Habkost
Signed-off-by: Igor Mammedov
---
include/qom/object.h | 4 ++--
1 file changed, 2 in
it will help to remove code duplication of registration
static types in places that have open coded loop to
perform batch type registering.
Signed-off-by: Igor Mammedov
---
include/qom/object.h | 10 ++
qom/object.c | 9 +
2 files changed, 19 insertions(+)
diff --git a/
DEFINE_TYPES() will help to simplify following routine patterns:
static void foo_register_types(void)
{
type_register_static(&foo1_type_info);
type_register_static(&foo2_type_info);
...
}
type_init(foo_register_types)
or
static void foo_register_types(void)
{
int i;
f
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
> Missed in commit 795dc6e46d, v2.4.0.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> qemu-options.hx | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qemu-options.hx b/qemu-option
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
> Cc: Paolo Bonzini
> CC: Marc-André Lureau
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> qemu-options.hx | 15 ---
> 1 file changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/qemu-optio
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> Reported-by: Daniel P. Berrange
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
(reviweing this patch makes me realize that the last
expression/command in qapi-schema isn't in the generated doc..)
> ---
> qapi-sche
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
> Commit 43f187a broke --help: it put colons into blank lines. It
> removed the colon from DEFHEADING(TITLE:) and added it back in the
> macro expansion of DEFHEADING(TITLE), so hxtool can emit "@subsection
> TITLE" more easily. Trouble is
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
> Cc: Stefan Berger
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> qemu-options.hx | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/qemu-options.hx b/qemu-options.
On Mon, Oct 2, 2017 at 3:45 PM, Markus Armbruster wrote:
> qemu-doc has the monitor commands in the "Function Index". The "info
> FOO" are listed as "FOO" there. List them as "info FOO" instead.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> hmp-commands-info.h
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
> Cc: Ronnie Sahlberg
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: qemu-bl...@nongnu.org
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
(that's very short doc)
> ---
> qemu-options.hx | 6 ++
> 1 file changed, 6 ins
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
> The table of option parameters lacks @table and @end table. The
> parameters become items in the enclosing table of options. Screwed up
> when l2tpv3 was added in commit 3fb69aa. Fix the obvious way.
>
> Cc: Jason Wang
> Signed-off-by:
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
> -iscsi ended up under the "Device URL Syntax" heading by a sequence of
> errors, as explained in the previous commit. Move it under the "Block
> device options" heading. Nothing left under "Device URL Syntax";
> drop the heading.
>
> Cc:
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> Commit 1d8bda1 got rid of #optional tags, and added a check to keep
> them from getting added back, to make sure patches then in flight
> don't add them back. It's been six months, time to drop that check.
>
> Signed-off-by: Markus Armbru
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> scripts/qapi.py | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index dc92bca620..6c8001e96d 10
On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
> Commit 0f5314a (v1.0) added section "Device URL Syntax" to
> qemu-options.hx. It's enclosed in STEXI..ETEXI, thus affects only
> qemu-options.texi, not --help. It appears as a subsection under
> section "Invocation". Similarly, qemu.1 h
Public bug reported:
Re-production steps:
git clone today's qemu git tree (4th Oct 2017)
./configure --target-list=ppc64-softmmu && make -j 8
Run the device-crash-test from scripts folder, seeing the following
error
INFO: running test case: machine=bamboo binary=ppc64-softmmu/qemu-system-ppc64
On Mon, Oct 2, 2017 at 3:45 PM, Markus Armbruster wrote:
> A command's STEXI..ETEXI stanza follows the command's initializer.
> Two commands got them backwards. Correct that.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> hmp-commands-info.hx | 20 ++
On Mon, Oct 2, 2017 at 3:45 PM, Markus Armbruster wrote:
> Screwed up in commit da76ee7.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> hmp-commands-info.hx | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/hmp-commands-info.hx b/hmp-
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> Repurposing the function parameter doc for stepping through
> doc.sections.__str__() is not nice. Use new variable @text instead.
>
> While there, eliminate variables name and func.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> QAPISchemaParser.cur_doc is used only by .__init__() and its helper
> .reject_expr_doc(). Make it local to __init__() and pass it to
> .reject_expr_doc() explicitly.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> We have two representations of sections without a name: the main
> section uses name=None, the others name=''. Standardize on name=None.
>
> Signed-off-by: Markus Armbruster
> ---
> scripts/qapi.py | 2 +-
> scrip
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> A negative test case crept into doc-good.json: invalid use of section
> markup we currently fail to reject. Move this into its own
> doc-bad-section.json.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> t
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> We have two representations of sections without a name: the main
> section uses name=None, the others name=''. Standardize on name=None.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> scripts/qapi.py
On Tue 28 Feb 2017 01:54:13 PM CET, Kevin Wolf wrote:
> bdrv_append() cares about isolation of the node that it modifies, but
> not about activity in some subtree below it. Instead of using the
> recursive bdrv_requests_pending(), directly check bs->in_flight, which
> considers only the node in que
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> Use a string instead of a list of strings. While there, generate
> fewer superfluous blank lines.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> scripts/qapi2texi.py| 33 -
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> Use a string instead of a list of strings.
>
> This makes qapi2texi.py generate additional blank lines. They're
> harmless, and the next commit will get rid of them again.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lur
Public bug reported:
Re-production steps:
git clone today's qemu git tree (4th Oct 2017)
./configure --target-list=ppc64-softmmu && make -j 8
Run the device-crash-test from scripts folder, seeing the following
error
INFO: running test case: machine=powernv binary=ppc64-softmmu/qemu-system-ppc64
Public bug reported:
Re-production steps:
git clone today's qemu git tree (4th Oct 2017)
./configure --target-list=ppc64-softmmu && make -j 8
Run the device-crash-test from scripts folder, seeing the following
error
INFO: running test case: machine=prep binary=ppc64-softmmu/qemu-system-ppc64
de
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> scripts/qapi.py | 52 ++--
> 1 file changed, 26 insertions(+), 26 deletions(-)
>
> diff --git a/scripts/qapi.py b
** Summary changed:
- qemu crashes with signal 6 when tried with -machine bamboo,accel=kvm -device
pcie-pci-bridge
+ qemu crashes with signal 6 with assertion error `!mr->container' failed
** Summary changed:
- qemu crashes with signal 6 with assertion error `!mr->container' failed
+ qemu crash
Reviewed-by: Ronnie Sahlberg
On Tue, Oct 3, 2017 at 12:03 AM, Markus Armbruster wrote:
> Cc: Ronnie Sahlberg
> Cc: Kevin Wolf
> Cc: Max Reitz
> Cc: qemu-bl...@nongnu.org
> Signed-off-by: Markus Armbruster
> ---
> qemu-options.hx | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a
On Mon, Oct 2, 2017 at 4:13 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> scripts/qapi2texi.py | 12 ++--
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/scripts/qapi2texi.py b/scripts/qapi2texi.py
> index 5
Reviewed-by: Ronnie Sahlberg
Would be nice if this died at some stage :
[,password=password]
But that is for a different patch.
On Wed, Oct 4, 2017 at 8:12 PM, Marc-André Lureau
wrote:
> On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
>> -iscsi ended up under the "Device URL Syntax"
On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster wrote:
> Demonstrates a qapi2texi.py bug: it can fail to escape '@'.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> tests/qapi-schema/doc-good.json | 3 +++
> tests/qapi-schema/doc-good.out | 3 +++
> tests/qapi-
On Wed, Oct 4, 2017 at 8:12 PM, Marc-André Lureau
wrote:
> On Mon, Oct 2, 2017 at 4:03 PM, Markus Armbruster wrote:
>> Commit 0f5314a (v1.0) added section "Device URL Syntax" to
>> qemu-options.hx. It's enclosed in STEXI..ETEXI, thus affects only
>> qemu-options.texi, not --help. It appears as
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 71 ++
1 file changed, 71 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 8ef2b72459..8549e4c2c6 100644
--- a/tests/migration-test.c
+++ b/tests/migration-te
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 8
1 file changed, 8 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index cd954caee4..8ef2b72459 100644
--- a/tests/migration-test.c
+++ b/tests/migration-test.c
@@ -466,6 +466,13 @@ static void test_p
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 80 ++
1 file changed, 80 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-test.c
index 8549e4c2c6..f0734e4ba0 100644
--- a/tests/migration-test.c
+++ b/tests/migration-te
His this series:
- add test for precopy for unix/tcp
exec and fd to came, don't know how to test rdma without hardware
- add tests using deprecated interfaces
- add test for xbzrle
Note to myself, there is no way to set the cache size with
migraton_set_parameters
- Add test for compress thread
For some reason, compression is not working at the moment, test is
disabled until I found why.
Signed-off-by: Juan Quintela
---
tests/migration-test.c | 51 ++
1 file changed, 51 insertions(+)
diff --git a/tests/migration-test.c b/tests/migration-
migrate_set_speed and migrate_set_dowtime are deprecated since long ago.
Signed-off-by: Juan Quintela
---
tests/postcopy-test.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
index 8142f2ab90..991b954a83 100644
--- a/test
Signed-off-by: Juan Quintela
---
tests/Makefile.include | 3 +
tests/migration-test.c | 497 +
2 files changed, 500 insertions(+)
create mode 100644 tests/migration-test.c
diff --git a/tests/Makefile.include b/tests/Makefile.include
index abc670
Hi
On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster wrote:
> Instead of quoting example text so that the @example environment shows
> it verbatim, simply use the @verbatim environment.
>
Not sure if this is really worth it, unless we have a real use-case of
@ in examples.
> Examples are no lon
We create new channels for each new thread created. We send through
them a string containing multifd so we are
sure that we connect the right channels in both sides.
Signed-off-by: Juan Quintela
--
Split SocketArgs into incoming and outgoing args
Use UUID's on the initial message, so we are s
Reported-by: Eric Blake
Signed-off-by: Juan Quintela
---
qapi/migration.json | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/qapi/migration.json b/qapi/migration.json
index f8b365e3f5..d94d6c0e46 100644
--- a/qapi/migration.json
+++ b/qapi/migration.json
@@ -471,7 +471,
So far, we had to free the error after each caller, so just do it
here. Once there, tls.c was leaking the error.
Signed-off-by: Juan Quintela
---
migration/channel.c | 1 -
migration/migration.c | 10 --
migration/migration.h | 4 ++--
migration/socket.c| 1 -
4 files changed,
Hi
This series is on top of my migration test series just sent, only reject should
be on the test system, though.
On v9 series for you:
- qobject_unref() as requested by dan
Yes he was right, I had a reference leak for _non_ multifd, I
*thought* he mean for multifd, and that took a while to
The function still don't use multifd, but we have simplified
ram_save_page, xbzrle and RDMA stuff is gone. We have added a new
counter and a new flag for this type of pages.
Signed-off-by: Juan Quintela
--
Add last_page parameter
Add commets for done and address
Remove multifd field, it is the
We are still sending the page through the main channel, that would
change later in the series
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/ram.c | 13 +++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/migration/ram.c b/migration/ram.c
We just send the address through the alternate channels and test that it
is ok.
Signed-off-by: Juan Quintela
--
Use qio_channel_*all functions
---
migration/ram.c | 39 +++
1 file changed, 39 insertions(+)
diff --git a/migration/ram.c b/migration/ram.c
inde
We now report errors also when we finish migration, not only on info
migrate. We plan to use this error from several places, and we want
the first error to happen to win, so we add an mutex to order it.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/migration.c
We set the x-multifd-page-count and x-multifd-channels.
Signed-off-by: Juan Quintela
---
tests/Makefile.include | 3 +
tests/multifd-test.c | 511 +
2 files changed, 514 insertions(+)
create mode 100644 tests/multifd-test.c
diff --git a/tests
Now it is called qemu_file_bytes that reflects better what it does,
and we create qemu_file_bytes_now to not have to call qemu_ftell() twice.
Signed-off-by: Juan Quintela
Reviewed-by: Dr. David Alan Gilbert
---
migration/migration.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
We make the locking and the transfer of information specific, even if we
are still receiving things through the main thread.
Signed-off-by: Juan Quintela
--
We split when we create the main channel and where we start the main
migration thread, so we wait for the creation of the other threads.
On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> scripts/qapi2texi.py| 22 --
> tests/qapi-schema/doc-good.json | 2 +-
> tests/qapi-schema/doc-good.out | 2 +-
> tests/qapi-s
On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster wrote:
> Replace flags @enum_member, @allow_optional by string @meta:
> 'member-enum' implies @enum_member, 'member-struct' implies
> @allow_optional.
>
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> scripts/qapi.py
Each time that we sync the bitmap, it is a possiblity that we receive
a page that is being processed by a different thread. We fix this
problem just making sure that we wait for all receiving threads to
finish its work before we procedeed with the next stage.
We are low on page flags, so we use a
On Mon, Oct 2, 2017 at 5:25 PM, Markus Armbruster wrote:
> Signed-off-by: Markus Armbruster
Reviewed-by: Marc-André Lureau
> ---
> scripts/qapi.py | 13 +
> 1 file changed, 5 insertions(+), 8 deletions(-)
>
> diff --git a/scripts/qapi.py b/scripts/qapi.py
> index 208010c241..8f9c
From: "Collin L. Walling"
If we fail to set a proper TOD clock on the target system, this can
already result in some problematic cases. We print several warn messages
on source and target in that case.
If kvm fails to set a nonzero epoch index, then we must ultimately fail
the migration as this
We switch for sending the page number to send real pages.
Signed-off-by: Juan Quintela
--
Remove the HACK bit, now we have the function that calculates the size
of a page exported.
Rename multifd_pages{_now}, to sent pages
Remove multifd pages field, it is the same than normal pages
---
migrat
The last last remaining z14 item on my queue.
v1->v2:
- split patches
- fix white spaces (also fixup kvm_s390_set_clock)
- single phrase error message
- use strerror
Collin L. Walling (2):
s390/kvm: Support for get/set of extended TOD-Clock for guest
s390/kvm: make TOD setting failures fatal
1 - 100 of 310 matches
Mail list logo
