[Qemu-devel] [RFC 1/5] pci: Rename root bus initialization functions for clarity

2017-10-03 Thread David Gibson
pci_bus_init(), pci_bus_new_inplace(), pci_bus_new() and pci_register_bus() are misleadingly named. They're not used for initializing *any* PCI bus, but only for a root PCI bus. Non-root buses - i.e. ones under a logical PCI to PCI bridge - are instead created with a direct qbus_create_inplace()

[Qemu-devel] [RFC 3/5] pci: Fold pci_bus.h into pci.h

2017-10-03 Thread David Gibson
include/hw/pci/pci_bus.h is now very small and can only safely be included after hw/pci/pci.h. So, just fold it into pci.h. Signed-off-by: David Gibson --- hw/acpi/pcihp.c | 1 - hw/i386/acpi-build.c| 1 - hw/i386/amd_iommu.h | 1 - hw/i386

[Qemu-devel] [RFC 4/5] pci: Simplify pci_bus_is_root()

2017-10-03 Thread David Gibson
pci_bus_is_root() currently relies on a method in the PCIBusClass. But it's always known if a PCI bus is a root bus when we create it, so using a dynamic method is overkill. This replaces it with an IS_ROOT bit in a new flags field, which is set on root buses and otherwise clear. As a bonus this

Re: [Qemu-devel] [PATCH 10/38] m68k: an5206: use generic cpu_model parsing

2017-10-03 Thread Thomas Huth
On 02.10.2017 11:07, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > CC: h...@tuxfamily.org > CC: laur...@vivier.eu > --- > hw/m68k/an5206.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/m68k/an5206.c b/hw/m68k/an5206.c > index 9002c46..0cedc54 10

Re: [Qemu-devel] [PATCH 0/3] blockjobs: add explicit job culling

2017-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2017 06:15, John Snow wrote: For jobs that complete when a monitor isn't looking, there's no way to tell what the job's final return code was. We need to allow jobs to remain in the list until queried for reliable management. This is an RFC; tests are on the way. (Tested only manually via

Re: [Qemu-devel] [RFC PATCH qemu v2] ppc/spapr: Receive and store device tree blob from SLOF

2017-10-03 Thread David Gibson
On Tue, Oct 03, 2017 at 07:48:27PM +1100, Alexey Kardashevskiy wrote: > On 03/10/17 17:40, David Gibson wrote: > > On Tue, Oct 03, 2017 at 04:17:01PM +1100, Alexey Kardashevskiy wrote: > >> SLOF receives a device tree and updates it with various properties > >> before switching to the guest kernel

Re: [Qemu-devel] [PATCH 11/38] m68k: mcf5208: use generic cpu_model parsing

2017-10-03 Thread Thomas Huth
On 02.10.2017 11:07, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > CC: laur...@vivier.eu > CC: h...@tuxfamily.org > --- > hw/m68k/mcf5208.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/m68k/mcf5208.c b/hw/m68k/mcf5208.c > index b9dde75..cfac845

Re: [Qemu-devel] [PATCH v4 14/23] qemu-img: Speed up compare on pre-allocated larger file

2017-10-03 Thread Vladimir Sementsov-Ogievskiy
13.09.2017 19:03, Eric Blake wrote: Compare the following images with all-zero contents: $ truncate --size 1M A $ qemu-img create -f qcow2 -o preallocation=off B 1G $ qemu-img create -f qcow2 -o preallocation=metadata C 1G On my machine, the difference is noticeable for pre-patch speeds, with mo

[Qemu-devel] [Bug 1321464] Re: qemu/block/qcow2.c:1942: possible performance problem ?

2017-10-03 Thread Thomas Huth
Thanks for reporting this, but it looks like the related code has been removed a while ago (there is no more "pad_buf" in qcow.c or qcow2.c), so closing this ticket. If you still can reproduce the (same or similar) problem with the latest version of QEMU, please open a new ticket instead. ** Chang

[Qemu-devel] [PATCH] hw/block/onenand: Remove dead code block

2017-10-03 Thread Thomas Huth
The condition of the for-loop makes sure that b is always smaller than s->blocks, so the "if (b >= s->blocks)" statement is completely superfluous here. Buglink: https://bugs.launchpad.net/qemu/+bug/1715007 Signed-off-by: Thomas Huth --- hw/block/onenand.c | 4 1 file changed, 4 deletions(-

Re: [Qemu-devel] [PATCH v1.1 DRAFT] nbd: Minimal structured read for client

2017-10-03 Thread Vladimir Sementsov-Ogievskiy
Eric? 27.09.2017 18:10, Vladimir Sementsov-Ogievskiy wrote: Minimal implementation: drop most of additional error information. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi! Here is a draft of how to refactor reply-payload receiving if you don't like my previous simple (but not flexibl

Re: [Qemu-devel] [PATCH v3 0/9] virtio: enhance virtio_error messages

2017-10-03 Thread Ladi Prosek
On Thu, Sep 14, 2017 at 7:59 AM, Ladi Prosek wrote: > On Fri, Jul 21, 2017 at 5:21 PM, Stefan Hajnoczi wrote: >> On Mon, Jul 17, 2017 at 10:11:43AM +0200, Ladi Prosek wrote: >>> Output like "Virtqueue size exceeded" is not much useful in identifying the >>> culprit. This series beefs up virtio_er

[Qemu-devel] [Bug 1660035] Re: hw/timer/altera_timer.c:207: bad size in memset ?

2017-10-03 Thread Thomas Huth
This problem should have been fixed with QEMU v2.10.0: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=cc16ee9d4ecec35ea04e ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https:

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-03 Thread Paolo Bonzini
On 26/09/2017 00:19, Eric Blake wrote: >> +/* here we deal with successful structured reply */ >> +switch (s->reply.type) { >> +QEMUIOVector sub_qiov; >> +case NBD_SREP_TYPE_OFFSET_DATA: > This is putting a LOT of smarts directly into the receive routine. > Here's where I was pr

[Qemu-devel] [PATCH] target/ppc: Remove unused PPC 460 and 460F definitions

2017-10-03 Thread Thomas Huth
We don't have any 460 or 460F CPUs in QEMU, so the init functions are just dead code. Let's simply remove them (translate_init.c is already big enough without them). Signed-off-by: Thomas Huth --- target/ppc/translate_init.c | 217 1 file changed, 217

Re: [Qemu-devel] [Qemu-trivial] [PATCH] hw/block/onenand: Remove dead code block

2017-10-03 Thread Laurent Vivier
On 03/10/2017 11:57, Thomas Huth wrote: > The condition of the for-loop makes sure that b is always smaller > than s->blocks, so the "if (b >= s->blocks)" statement is completely > superfluous here. > > Buglink: https://bugs.launchpad.net/qemu/+bug/1715007 > Signed-off-by: Thomas Huth > --- > hw

[Qemu-devel] [PULL 3/6] linux-headers: sync against v4.14-rc1

2017-10-03 Thread Paolo Bonzini
From: Alexey Perevalov Signed-off-by: Alexey Perevalov Message-Id: <1506085187-24259-2-git-send-email-a.pereva...@samsung.com> Signed-off-by: Paolo Bonzini --- include/standard-headers/asm-x86/hyperv.h| 19 ++--- include/standard-headers/linux/pci_regs.h| 42 ---

[Qemu-devel] [PULL 2/6] iothread: Make iothread_stop() idempotent

2017-10-03 Thread Paolo Bonzini
From: Eduardo Habkost Currently, iothread_stop_all() makes all iothread objects unsafe to be destroyed, because qemu_thread_join() ends up being called twice. To fix this, make iothread_stop() idempotent by checking thread->stopped. Fixes the following crash: qemu-system-x86_64 -object iothr

[Qemu-devel] [PULL 0/6] Misc patches for 2017-10-03

2017-10-03 Thread Paolo Bonzini
The following changes since commit ab161529261928ae7f3556e3220829c34b2686ec: Merge remote-tracking branch 'remotes/dgilbert/tags/pull-migration-20170927a' into staging (2017-09-27 22:44:51 +0100) are available in the git repository at: git://github.com/bonzini/qemu.git tags/for-upstream f

[Qemu-devel] [PULL 1/6] scsi: Ignore executable for in-tree builds

2017-10-03 Thread Paolo Bonzini
From: Eric Blake The new qemu-pr-helper (commit b855f8d17) should not be checked in, even when doing in-tree builds. Signed-off-by: Eric Blake Message-Id: <20170926151421.14557-1-ebl...@redhat.com> Signed-off-by: Paolo Bonzini --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a

[Qemu-devel] [PULL 4/6] kvm: check KVM_CAP_SYNC_MMU with kvm_vm_check_extension()

2017-10-03 Thread Paolo Bonzini
From: Greg Kurz On a server-class ppc host, this capability depends on the KVM type, ie, HV or PR. If both KVM are present in the kernel, we will always get the HV specific value, even if we explicitely requested PR on the command line. This can have an impact if we're using hugepages or a ballo

[Qemu-devel] [PULL 5/6] kvm: check KVM_CAP_NR_VCPUS with kvm_vm_check_extension()

2017-10-03 Thread Paolo Bonzini
From: Greg Kurz On a modern server-class ppc host with the following CPU topology: Architecture: ppc64le Byte Order:Little Endian CPU(s):32 On-line CPU(s) list: 0,8,16,24 Off-line CPU(s) list: 1-7,9-15,17-23,25-31 Thread(s) per core:1 If both KVM PR a

[Qemu-devel] [PULL 6/6] kvmclock: use the updated system_timer_msr

2017-10-03 Thread Paolo Bonzini
From: Jim Somerville Fixes e2b6c17 (kvmclock: update system_time_msr address forcibly) which makes a call to get the latest value of the address stored in system_timer_msr, but then uses the old address anyway. Signed-off-by: Jim Somerville Message-Id: <59b67db0bd15a46ab47c3aa657c81a4c11f168ea

Re: [Qemu-devel] [PATCH 22/38] xtensa: cleanup cpu type name composition

2017-10-03 Thread Igor Mammedov
On Mon, 2 Oct 2017 17:35:39 -0300 Philippe Mathieu-Daudé wrote: > On 10/02/2017 06:08 AM, Igor Mammedov wrote: > > use new XTENSA_CPU_TYPE_NAME to compose CPU type name > > to bring xtensa in line with all other targets that > > will similar macro. > > > > Signed-off-by: Igor Mammedov > > --- >

[Qemu-devel] [Bug 1318474] Re: QEMU update causes Windows reactivation

2017-10-03 Thread Thomas Huth
How did you start QEMU with the new version here? You might need to specify the correct machine type with the new version to avoid that the guest sees different hardware (e.g. with the "-machine pc-i440fx-2.0" option). ** Changed in: qemu Status: New => Incomplete -- You received this bug

[Qemu-devel] [Bug 700276] Re: QEMU crashed when GDB request a big size variable information

2017-10-03 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

2017-10-03 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1321684] Re: block_stream command stalls

2017-10-03 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

[Qemu-devel] [Bug 1327608] Re: monitor socked path is cut a 105 characters

2017-10-03 Thread Thomas Huth
Triaging old bug tickets... can you still reproduce this issue with the latest version of QEMU? Or could we close this ticket nowadays? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QE

Re: [Qemu-devel] [Xen-devel] [PATCH] migration, xen: Fix block image lock issue on live migration

2017-10-03 Thread Roger Pau Monné
On Mon, Oct 02, 2017 at 04:30:58PM +, Anthony PERARD wrote: > When doing a live migration of a Xen guest with libxl, the images for > block devices are locked by the original QEMU process, and this prevent > the QEMU at the destination to take the lock and the migration fail. > > From QEMU poi

Re: [Qemu-devel] [Xen-devel] [PATCH] migration, xen: Fix block image lock issue on live migration

2017-10-03 Thread Anthony PERARD
On Tue, Oct 03, 2017 at 12:33:37PM +0100, Roger Pau Monné wrote: > On Mon, Oct 02, 2017 at 04:30:58PM +, Anthony PERARD wrote: > > When doing a live migration of a Xen guest with libxl, the images for > > block devices are locked by the original QEMU process, and this prevent > > the QEMU at th

Re: [Qemu-devel] [PATCH 07/43] windbg: added chardev

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov wrote: > Added chardev for listening to windbg. Target device is a parameter in the > '-windbg' option. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub.c | 26 ++

Re: [Qemu-devel] [PATCH v3 5/6] s390x/css: activate ChannelSubSys migration

2017-10-03 Thread Thomas Huth
On 11.07.2017 16:54, Halil Pasic wrote: > Turn on migration for the channel subsystem for the next machine. For > legacy machines we still have to do things the old way. > > Signed-off-by: Halil Pasic > Reviewed-by: Cornelia Huck > --- > hw/s390x/css.c | 5 + > hw/s390x/s390-vi

Re: [Qemu-devel] [PATCH 08/43] windbg: hook to wrmsr operation

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov wrote: > Inserted hook to wrmsr operation. Windows Kernel put address on KPCR struct > to fs/gs (x32/x64) register. Needs catch this moment and allow windbg server > handle packets. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgal

Re: [Qemu-devel] [PATCH 01/38] qom: add helper type_init_from_array()

2017-10-03 Thread Igor Mammedov
On Mon, 2 Oct 2017 16:24:04 -0300 Eduardo Habkost wrote: > On Mon, Oct 02, 2017 at 11:07:43AM +0200, Igor Mammedov wrote: > > it will help to remove code duplication in places > > that currently open code registration of several > > types. > > > > Signed-off-by: Igor Mammedov > > --- > > I'm go

Re: [Qemu-devel] [PATCH 09/43] windbg: handler of fs/gs register

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov wrote: > Added handler of fs/gs register. It tries to find and check KPCR and version > address. > > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |

[Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S]()

2017-10-03 Thread Igor Mammedov
it will help to remove code duplication in places that currently open code registration of static type[s] and remove necessity to declare function for type_init() to call, when only static types need to be registered. Signed-off-by: Igor Mammedov --- I'm going to use it for CPU types in followup

Re: [Qemu-devel] [PATCH 00/43] Windbg supporting

2017-10-03 Thread Mihail Abakumov
Stefan Hajnoczi писал 2017-10-02 22:43: On Tue, Sep 26, 2017 at 02:04:06PM +0300, Mihail Abakumov wrote: We made the debugger module WinDbg (like GDB) for QEMU. This is the replacement of the remote stub in Windows kernel. Used for remote Windows kernel debugging without debugging mode. How d

Re: [Qemu-devel] [PATCH 15/43] windbg: sized data buffer

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov wrote: > Defined useful sized data buffer. It contains pointer to data and size of > this data. Also, defined some macroses for init and free. "macros" instead of "macroses", same in patch 31. > Signed-off-by: Mihail Abakumov > Signed-off-by: Pa

Re: [Qemu-devel] [PATCH 15/43] windbg: sized data buffer

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov wrote: > Defined useful sized data buffer. It contains pointer to data and size of > this data. Also, defined some macroses for init and free. "macros" instead of "macroses", same in patch 31. > Signed-off-by: Mihail Abakumov > Signed-off-by: Pa

Re: [Qemu-devel] [PATCH 19/43] windbg: implemented windbg_process_control_packet

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:05 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub.c | 26 +- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/windbgstub.c b/

Re: [Qemu-devel] [PATCH 22/43] windbg: implemented kd_api_read_virtual_memory and kd_api_read_virtual_memory

2017-10-03 Thread Ladi Prosek
nit: The subject line has "kd_api_read_virtual_memory" twice in it. Was probably meant to be [PATCH 22/43] windbg: implemented kd_api_read_virtual_memory and kd_api_write_virtual_memory On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pa

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2017 13:07, Paolo Bonzini wrote: On 26/09/2017 00:19, Eric Blake wrote: +/* here we deal with successful structured reply */ +switch (s->reply.type) { +QEMUIOVector sub_qiov; +case NBD_SREP_TYPE_OFFSET_DATA: This is putting a LOT of smarts directly into the receive rou

Re: [Qemu-devel] [Bug 1327608] Re: monitor socked path is cut a 105 characters

2017-10-03 Thread Eric Blake
On 10/03/2017 05:47 AM, Thomas Huth wrote: > Triaging old bug tickets... can you still reproduce this issue with the > latest version of QEMU? Or could we close this ticket nowadays? This may be fixed by: commit ad9579aaa16d5b385922d49edac2c96c79bcfb62 Author: Daniel P. Berrange Date: Thu May

Re: [Qemu-devel] [PATCH] hw/gen_pcie_root_port: properly set

2017-10-03 Thread Marcel Apfelbaum
On 03/10/2017 0:49, Laszlo Ersek wrote: On 10/02/17 12:31, Marcel Apfelbaum wrote: IO_LIMIT and IO_BASE registers should not be writable if gen_pcie_root_port's io-reserve property is set to 0. The COMMAND register should have the IO flag read only. Signed-off-by: Marcel Apfelbaum --- hw/pc

Re: [Qemu-devel] [PATCH 26/43] windbg: implemented windbg_read_context

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub-utils.c | 90 > +++- > 1 file changed, 89 insertions(+), 1 deletion(

Re: [Qemu-devel] [PATCH 28/43] windbg: implemented windbg_read_ks_regs

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:06 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub-utils.c | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/windbgstub-u

[Qemu-devel] [PATCH v4 0/2] virtio: introduce `info virtio' hmp command

2017-10-03 Thread Jan Dakinevich
v4: * Implement `query-virtio' QMP * Split the work into QMP and HMP parts v3: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07565.html v2: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07527.html v1: http://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg07247.html

[Qemu-devel] [PATCH v4 2/2] virtio: add `info virtio' HMP command

2017-10-03 Thread Jan Dakinevich
The command prints data from `query-virtio' QMP in human-readable format. Cc: Denis V. Lunev Signed-off-by: Jan Dakinevich --- hmp-commands-info.hx | 14 ++ hmp.c| 79 hmp.h| 1 + 3 files changed, 94 i

[Qemu-devel] [PATCH v4 1/2] virtio: introduce `query-virtio' QMP command

2017-10-03 Thread Jan Dakinevich
The command is intended for gathering virtio information such as status, feature bits, negotiation status. It is convenient and useful for debug purpose. The commands returns generic virtio information for virtio such as common feature names and status bits names and information for all attached t

Re: [Qemu-devel] [PULL 0/5] Docker testing patches

2017-10-03 Thread Peter Maydell
On 29 September 2017 at 04:18, Fam Zheng wrote: > The following changes since commit ab161529261928ae7f3556e3220829c34b2686ec: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20170927a' into staging (2017-09-27 > 22:44:51 +0100) > > are available in the git repository

Re: [Qemu-devel] [PATCH 33/43] windbg: implemented windbg_hw_breakpoint_insert and windbg_hw_breakpoint_remove

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > windbgstub-utils.c | 60 > > 1 file changed, 60 insertions(+) > > diff --g

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2017 13:07, Paolo Bonzini wrote: On 26/09/2017 00:19, Eric Blake wrote: +/* here we deal with successful structured reply */ +switch (s->reply.type) { +QEMUIOVector sub_qiov; +case NBD_SREP_TYPE_OFFSET_DATA: This is putting a LOT of smarts directly into the receive rou

Re: [Qemu-devel] [PATCH 06/38] lm32: cleanup cpu type name composition

2017-10-03 Thread Michael Walle
Am 2017-10-02 11:07, schrieb Igor Mammedov: introduce LM32_CPU_TYPE_NAME macro and consistently use it to construct cpu type names. While at it replace dynamic cpu type name composition with static data. Signed-off-by: Igor Mammedov --- CC: mich...@walle.cc --- target/lm32/cpu.h | 3 +++ targ

Re: [Qemu-devel] [PATCH 08/38] lm32: lm32_boards: use generic cpu_model parsing

2017-10-03 Thread Michael Walle
Am 2017-10-02 11:07, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov --- CC: mich...@walle.cc --- hw/lm32/lm32_boards.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) Acked-by: Michael Walle

Re: [Qemu-devel] [PATCH 07/38] lm32: milkymist: use generic cpu_model parsing

2017-10-03 Thread Michael Walle
Am 2017-10-02 11:07, schrieb Igor Mammedov: Signed-off-by: Igor Mammedov --- CC: mich...@walle.cc --- hw/lm32/milkymist.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) Acked-by: Michael Walle

Re: [Qemu-devel] [RFC 24/29] vhost+postcopy: Lock around set_mem_table

2017-10-03 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Maxime Coquelin (maxime.coque...@redhat.com) wrote: > > > > > > On 06/28/2017 09:00 PM, Dr. David Alan Gilbert (git) wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > **HACK - better solution needed ** > > > We have the situation wh

Re: [Qemu-devel] [PULL 0/5] Ui 20170929 patches

2017-10-03 Thread Peter Maydell
On 29 September 2017 at 11:21, Gerd Hoffmann wrote: > The following changes since commit ab161529261928ae7f3556e3220829c34b2686ec: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20170927a' into staging (2017-09-27 > 22:44:51 +0100) > > are available in the git reposit

Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S]()

2017-10-03 Thread Philippe Mathieu-Daudé
Hi Igor, On 10/03/2017 09:14 AM, Igor Mammedov wrote: > it will help to remove code duplication in places > that currently open code registration of static > type[s] and remove necessity to declare function > for type_init() to call, when only static types > need to be registered. > > Signed-off-

Re: [Qemu-devel] [PATCH 09/38] m68k: cleanup cpu type name composition

2017-10-03 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:07 AM, Igor Mammedov wrote: > use new M68K_CPU_TYPE_NAME to compose CPU type names > and get rid of intermediate M68kCPUInfo/register_cpu_type() > which is replaced by static TypeInfo array. > > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > CC: laur.

Re: [Qemu-devel] [PATCH 10/38] m68k: an5206: use generic cpu_model parsing

2017-10-03 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:07 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > CC: h...@tuxfamily.org > CC: laur...@vivier.eu > --- > hw/m68k/an5206.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/m68k/an5206.c b/hw

Re: [Qemu-devel] [PATCH 11/38] m68k: mcf5208: use generic cpu_model parsing

2017-10-03 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:07 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > CC: laur...@vivier.eu > CC: h...@tuxfamily.org > --- > hw/m68k/mcf5208.c | 7 ++- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/hw/m68k/mcf5208.c b/

Re: [Qemu-devel] [PATCH 23/38] xtensa: sim: use generic cpu_model parsing

2017-10-03 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:08 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > CC: jcmvb...@gmail.com > --- > hw/xtensa/sim.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/hw/xtensa/sim.c b/hw/xtensa/sim.c > index b35

Re: [Qemu-devel] [PATCH 22/38] xtensa: cleanup cpu type name composition

2017-10-03 Thread Philippe Mathieu-Daudé
On 10/03/2017 07:37 AM, Igor Mammedov wrote: > On Mon, 2 Oct 2017 17:35:39 -0300 > Philippe Mathieu-Daudé wrote: > >> On 10/02/2017 06:08 AM, Igor Mammedov wrote: >>> use new XTENSA_CPU_TYPE_NAME to compose CPU type name >>> to bring xtensa in line with all other targets that >>> will similar mac

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-03 Thread Vladimir Sementsov-Ogievskiy
03.10.2017 15:58, Vladimir Sementsov-Ogievskiy wrote: 03.10.2017 13:07, Paolo Bonzini wrote: On 26/09/2017 00:19, Eric Blake wrote: +    /* here we deal with successful structured reply */ +    switch (s->reply.type) { +    QEMUIOVector sub_qiov; +    case NBD_SREP_TYPE_OFFSET_DATA: This i

Re: [Qemu-devel] [PATCHv2] dma/i82374: avoid double creation of i82374 device

2017-10-03 Thread Eduardo Habkost
On Mon, Oct 02, 2017 at 02:50:07PM +0200, Paolo Bonzini wrote: > On 29/09/2017 21:31, Eduardo Habkost wrote: > >> -void DMA_init(ISABus *bus, int high_page_enable) > >> +void DMA_init(ISABus *bus, int high_page_enable, Error **errp) > > > > If you make the function return a boolean to indicate suc

Re: [Qemu-devel] [PATCH 24/38] xtensa: lx60/lx200/ml605/kc705: use generic cpu_model parsing

2017-10-03 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:08 AM, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov Reviewed-by: Philippe Mathieu-Daudé > --- > CC: jcmvb...@gmail.com > --- > hw/xtensa/xtfpga.c | 11 +-- > 1 file changed, 5 insertions(+), 6 deletions(-) > > diff --git a/hw/xtensa/xtfpga.c b/hw/xtensa/xtfpga.

Re: [Qemu-devel] [PATCH 12/38] moxie: fix qemu-system-moxie failing to start with CLI "-cpu MoxieLite"

2017-10-03 Thread Philippe Mathieu-Daudé
On 10/02/2017 06:07 AM, Igor Mammedov wrote: > It 'works' with default CPU only because of bug in > moxie_cpu_class_by_name() where it treats cpu_model > as type name and default cpu_model also happens to be > type name. But specifying explicitly cpu on CLI, > ex: '-cpu MoxieLite', makes QEMU fail

Re: [Qemu-devel] [PATCH v4 4/9] disas: Support the Capstone disassembler library

2017-10-03 Thread Philippe Mathieu-Daudé
On 10/02/2017 10:51 PM, Richard Henderson wrote: > On 10/02/2017 02:45 PM, Philippe Mathieu-Daudé wrote: >> On 10/02/2017 03:34 PM, Richard Henderson wrote: >>> On 10/02/2017 09:36 AM, Philippe Mathieu-Daudé wrote: Maybe some defines like: #define LARGEST_TARGET_INSTR_SIZE 32 >>

[Qemu-devel] [RFH PATCH 00/10] i386: hvf: miscellaneous cleanups

2017-10-03 Thread Paolo Bonzini
This is an initial set of (untested!) cleanups for the HVF code. If anyone could pick them up, I think they represent the bare minimum that has to be done before we can commit HVF support to master. It's by no means the end, but the existing MMU code in target/i386 could definitely stand a rewrite,

[Qemu-devel] [PATCH 06/10] i386: hvf: abort on decoding error

2017-10-03 Thread Paolo Bonzini
Rather than unsupported situations, some VM_PANIC calls actually are caused by internal errors. Convert them to just abort. Signed-off-by: Paolo Bonzini --- target/i386/hvf/hvf.c | 2 +- target/i386/hvf/x86_emu.c | 10 -- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PATCH 04/10] i386: hvf: remove more dead emulator code

2017-10-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target/i386/hvf/hvf.c| 2 -- target/i386/hvf/x86.h| 5 - target/i386/hvf/x86_decode.c | 22 +++--- target/i386/hvf/x86_emu.c| 25 - target/i386/hvf/x86_flags.c | 10 -- target/i386/hvf/x86_

[Qemu-devel] [PATCH 02/10] i386: hvf: header cleanup

2017-10-03 Thread Paolo Bonzini
Remove inclusions of system headers and avoid "pragma once". Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86.h| 8 +++- target/i386/hvf/x86_decode.h | 9 - target/i386/hvf/x86_descr.h | 5 - 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/target/i38

[Qemu-devel] [PATCH 01/10] i386: hvf: move all hvf files in the same directory

2017-10-03 Thread Paolo Bonzini
Just call it hvf/, no need for the "utils" suffix. Signed-off-by: Paolo Bonzini --- target/i386/Makefile.objs| 2 +- target/i386/cpu.h| 2 +- target/i386/{hvf-utils => hvf}/Makefile.objs | 1 + target/i386/{hvf-utils => hvf}/README.md | 0

[Qemu-devel] [PATCH 03/10] i386: hvf: unify register enums between HVF and the rest

2017-10-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target/i386/cpu.h| 60 +++--- target/i386/hvf/vmx.h| 10 +-- target/i386/hvf/x86.c| 10 +-- target/i386/hvf/x86.h| 145 +-- target/i386/hvf/x86_decode.c | 80 --

[Qemu-devel] [PATCH 05/10] i386: hvf: remove ZERO_INIT macro

2017-10-03 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- target/i386/hvf/x86.c| 3 ++- target/i386/hvf/x86_decode.c | 3 +-- target/i386/hvf/x86_gen.h| 2 -- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/target/i386/hvf/x86.c b/target/i386/hvf/x86.c index ca0ec2968a..8002a41d30 100644 --- a/

Re: [Qemu-devel] [PATCH v4 00/14] add support for Hypervisor.framework in QEMU

2017-10-03 Thread Paolo Bonzini
On 13/09/2017 11:05, Sergio Andres Gomez Del Real wrote: > > Changes in v4: > (1) Use g_new0 instead of g_malloc. > (2) hvf TODO's in cpu.c explained: in-kernel irqchip. > (3) Introduce ins_len field in patch where actually used. > (4) Remove outdated comment "/* Definition of

[Qemu-devel] [PATCH 09/10] i386: hvf: simplify and fix in/out handling

2017-10-03 Thread Paolo Bonzini
Reading a 32-bit port should clear the upper 32-bits of the register. Signed-off-by: Paolo Bonzini --- target/i386/hvf/hvf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/i386/hvf/hvf.c b/target/i386/hvf/hvf.c index 5194b94591..35e39afefd 100644 --- a/target/

Re: [Qemu-devel] [PATCH 38/43] windbg: implemented kd_api_read_physical_memory and kd_api_write_physical_memory

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |2 ++ > windbgstub-utils.c | 28 > windbgstub.c

Re: [Qemu-devel] [PATCH] hw/arm/xlnx-zynqmp: Mark the "xlnx, zynqmp" device with user_creatable = false

2017-10-03 Thread Peter Maydell
On 26 September 2017 at 16:51, Thomas Huth wrote: > The device uses serial_hds in its realize function and thus can't be > used twice. Apart from that, the comma in its name makes it quite hard > to use for the user anyway, since a comma is normally used to separate > the device name from its prop

[Qemu-devel] [PATCH 10/10] i386: hvf: cleanup x86_gen.h

2017-10-03 Thread Paolo Bonzini
This only includes VM_PANIC now. No need to include it from headers. Signed-off-by: Paolo Bonzini --- target/i386/hvf-utils/panic.h | 45 +++ target/i386/hvf/x86.h | 1 - target/i386/hvf/x86_decode.c | 3 +-- target/i386/hvf/x86_emu.c | 2

Re: [Qemu-devel] [PATCH 41/43] windbg: implemented kd_api_search_memory

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:07 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |1 + > windbgstub-utils.c | 30 ++ > windbgstub.c

Re: [Qemu-devel] [PATCH 42/43] windbg: implemented kd_api_fill_memory

2017-10-03 Thread Ladi Prosek
On Tue, Sep 26, 2017 at 1:08 PM, Mihail Abakumov wrote: > Signed-off-by: Mihail Abakumov > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Dmitriy Koltunov > --- > include/exec/windbgstub-utils.h |1 + > windbgstub-utils.c | 36 > windbgs

Re: [Qemu-devel] [PATCH v4 1/2] virtio: introduce `query-virtio' QMP command

2017-10-03 Thread Eric Blake
On 10/03/2017 07:47 AM, Jan Dakinevich wrote: > The command is intended for gathering virtio information such as status, > feature bits, negotiation status. It is convenient and useful for debug > purpose. > > The commands returns generic virtio information for virtio such as > common feature name

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-03 Thread Paolo Bonzini
On 03/10/2017 14:26, Vladimir Sementsov-Ogievskiy wrote: > 03.10.2017 13:07, Paolo Bonzini wrote: >> On 26/09/2017 00:19, Eric Blake wrote: +    /* here we deal with successful structured reply */ +    switch (s->reply.type) { +    QEMUIOVector sub_qiov; +    case NBD_SREP_T

Re: [Qemu-devel] [Qemu-block] [PATCH 8/8] nbd: Minimal structured read for client

2017-10-03 Thread Paolo Bonzini
On 03/10/2017 15:35, Vladimir Sementsov-Ogievskiy wrote: >>> >>> In the end this probably means that you have a read_chunk_header >>> function and a read_chunk function.  READ has a loop that calls >>> read_chunk_header followed by direct reading into the QEMUIOVector, >>> while everyone else calls

Re: [Qemu-devel] [PULL 0/3] Usb 20170929 patches

2017-10-03 Thread Peter Maydell
On 29 September 2017 at 12:00, Gerd Hoffmann wrote: > The following changes since commit ab161529261928ae7f3556e3220829c34b2686ec: > > Merge remote-tracking branch > 'remotes/dgilbert/tags/pull-migration-20170927a' into staging (2017-09-27 > 22:44:51 +0100) > > are available in the git reposit

Re: [Qemu-devel] [RFC v2 1/2] machine: Add a valid_cpu_types property

2017-10-03 Thread Eduardo Habkost
On Thu, Sep 21, 2017 at 04:41:50PM -0700, Alistair Francis wrote: > Signed-off-by: Alistair Francis > --- > > RFC v2: > - Rebase on Igor's cpu_type work > - Use object_class_dynamic_cast() > - Use a NULL terminated cahr** list > - Do the check before the machine_class init() is called > > >

[Qemu-devel] [PATCH] hw/ppc: use 0 instead of fdt_path_offset(fdt, "/")

2017-10-03 Thread Greg Kurz
The offset of the root node is guaranteed to be 0. This doesn't fix anything, it's just trivial cleanup of the two remaining places where this was done under hw/ppc. Signed-off-by: Greg Kurz --- hw/ppc/pnv.c |3 +-- hw/ppc/spapr.c |3 +-- 2 files changed, 2 insertions(+), 4 deletions(

Re: [Qemu-devel] [PATCH 00/43] Windbg supporting

2017-10-03 Thread Ladi Prosek
Hi, On Tue, Sep 26, 2017 at 1:04 PM, Mihail Abakumov wrote: > We made the debugger module WinDbg (like GDB) for QEMU. This is the > replacement of the remote stub in Windows kernel. Used for remote Windows > kernel debugging without debugging mode. > > WinDbg is a multipurpose debugger for the

Re: [Qemu-devel] [PATCH] qom: add helpers REGISTER_STATIC_TYPE[S]()

2017-10-03 Thread Eduardo Habkost
On Tue, Oct 03, 2017 at 02:14:46PM +0200, Igor Mammedov wrote: > it will help to remove code duplication in places > that currently open code registration of static > type[s] and remove necessity to declare function > for type_init() to call, when only static types > need to be registered. > > Sig

Re: [Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

2017-10-03 Thread Martin Röh
Hi, the ticket can be close. All works fine with actual opensuse tumbleweed and qemu 2.10.0 :-) Best regards Martin Am 03.10.2017 um 12:42 schrieb Thomas Huth: > Triaging old bug tickets... can you still reproduce this issue with the > latest version of QEMU? Or could we close this ticket nowa

Re: [Qemu-devel] [PATCH v4 1/2] virtio: introduce `query-virtio' QMP command

2017-10-03 Thread Jan Dakinevich
On 10/03/2017 05:02 PM, Eric Blake wrote: > On 10/03/2017 07:47 AM, Jan Dakinevich wrote: >> The command is intended for gathering virtio information such as status, >> feature bits, negotiation status. It is convenient and useful for debug >> purpose. >> >> The commands returns generic virtio in

Re: [Qemu-devel] [PATCH] hw/ppc: use 0 instead of fdt_path_offset(fdt, "/")

2017-10-03 Thread Cédric Le Goater
On 10/03/2017 04:13 PM, Greg Kurz wrote: > The offset of the root node is guaranteed to be 0. > > This doesn't fix anything, it's just trivial cleanup of the two > remaining places where this was done under hw/ppc. > > Signed-off-by: Greg Kurz Looks good to me. Reviewed-by: Cédric Le Goater

[Qemu-devel] [Bug 1714750] Re: 2.10.0 cannot be installed on case-insensitive file system

2017-10-03 Thread Peter Maydell
Update: Sam Protsenko has kindly written and submitted a u-boot patch which resolves the filename clash: https://lists.denx.de/pipermail/u-boot/2017-September/307910.html -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.l

Re: [Qemu-devel] [PATCH 0/3] blockjobs: add explicit job culling

2017-10-03 Thread John Snow
On 10/03/2017 05:20 AM, Vladimir Sementsov-Ogievskiy wrote: > 03.10.2017 06:15, John Snow wrote: >> For jobs that complete when a monitor isn't looking, there's no way to >> tell what the job's final return code was. We need to allow jobs to >> remain in the list until queried for reliable manage

Re: [Qemu-devel] [RFC 4/5] pci: Simplify pci_bus_is_root()

2017-10-03 Thread Eduardo Habkost
On Tue, Oct 03, 2017 at 08:14:22PM +1100, David Gibson wrote: > pci_bus_is_root() currently relies on a method in the PCIBusClass. > But it's always known if a PCI bus is a root bus when we create it, so > using a dynamic method is overkill. > > This replaces it with an IS_ROOT bit in a new flags

[Qemu-devel] [Bug 1327608] Re: monitor socked path is cut a 105 characters

2017-10-03 Thread Daniel Berrange
There's actually two bugs here. First QEMU was truncating the UNIX, but because it used 'snprintf', QEMU truncated it at 107 characters and then added a trailing NUL, instead of truncating at 108 characters and not having a NUL (which is perfectly fine for AF_UNIX) Second though if you look at th

Re: [Qemu-devel] [PATCH 09/38] m68k: cleanup cpu type name composition

2017-10-03 Thread Laurent Vivier
Le 02/10/2017 à 11:07, Igor Mammedov a écrit : > use new M68K_CPU_TYPE_NAME to compose CPU type names > and get rid of intermediate M68kCPUInfo/register_cpu_type() > which is replaced by static TypeInfo array. > > Signed-off-by: Igor Mammedov > --- > CC: laur...@vivier.eu > --- > target/m68k/cpu

Re: [Qemu-devel] [PATCH v16 4/5] mm: support reporting free page blocks

2017-10-03 Thread Michal Hocko
On Sat 30-09-17 12:05:53, Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's > responsibility to either detect or preve

  1   2   3   >