[Qemu-devel] [Bug 1718719] Re: qemu can't capture keys properly under wayland

2017-09-22 Thread ChristianEhrhardt
I wanted to write steps to reproduce, which should be as simple as: $ wget http://cdimage.ubuntu.com/daily-live/current/artful-desktop-amd64.iso $ qemu-system-x86_64 -m 512 -boot d -cdrom artful-desktop-amd64.iso But that works for me as seen in the attached video. @Mathieu - can you elaborate how

[Qemu-devel] [PATCH v2] arm: Fix SMC reporting to EL2 when QEMU provides PSCI

2017-09-22 Thread Jan Kiszka
From: Jan Kiszka This properly forwards SMC events to EL2 when PSCI is provided by QEMU itself and, thus, ARM_FEATURE_EL3 is off. Found and tested with the Jailhouse hypervisor. Solution based on suggestions by Peter Maydell. Signed-off-by: Jan Kiszka --- Changes in v2: - implemented Peter's

Re: [Qemu-devel] [PATCH] seccomp: Don't include libseccomp from QEMU header

2017-09-22 Thread Jan Kiszka
On 2017-09-20 10:36, Fam Zheng wrote: > The only prototype doesn't need anything from the lib header, and not > including it here allows files that include this header, for example > vl.c, to compile without the libseccomp cflags. > > The breakage is since c3883e1f93 for environments where `pkg-co

Re: [Qemu-devel] [PATCH] tests/boot-sector: Increase timeout to 600 seconds

2017-09-22 Thread Thomas Huth
On 22.09.2017 08:21, Philippe Mathieu-Daudé wrote: > Hi Thomas, > > On 09/22/2017 12:06 AM, Thomas Huth wrote: >> If QEMU has been compiled with the flags --enable-tcg-interpreter and >> --enable-debug, the guest is running incredibly slow. The pxe boot test > > There already is a qtest_get_arch(

Re: [Qemu-devel] [PATCH 1/1] s390x/ais: for 2.10 stable: disable ais facility

2017-09-22 Thread Cornelia Huck
On Fri, 22 Sep 2017 08:47:41 +0200 Christian Borntraeger wrote: > On 09/21/2017 10:26 PM, Michael Roth wrote: > > Quoting Michael Roth (2017-09-21 11:50:28) > >> Quoting Cornelia Huck (2017-09-21 10:21:42) > >>> On Thu, 21 Sep 2017 17:14:46 +0200 > >>> Christian Borntraeger wrote: > >>> >

Re: [Qemu-devel] [PATCH 04/17] imx_fec: Change queue flushing heuristics

2017-09-22 Thread Jason Wang
On 2017年09月19日 03:50, Andrey Smirnov wrote: In current implementation, packet queue flushing logic seem to suffer from a deadlock like scenario if a packet is received by the interface before before Rx ring is initialized by Guest's driver. Consider the following sequence of events: 1.

Re: [Qemu-devel] need to resurrect no-lock option?

2017-09-22 Thread Kevin Wolf
Am 21.09.2017 um 15:18 hat Daniel P. Berrange geschrieben: > On Thu, Sep 21, 2017 at 01:43:17PM +0100, Daniel P. Berrange wrote: > > On Thu, Sep 21, 2017 at 01:33:20PM +0100, Stefan Hajnoczi wrote: > > > On Wed, Sep 20, 2017 at 11:26:11AM +0200, Christian Ehrhardt wrote: > > > > Hi, > > > > this mi

Re: [Qemu-devel] [PATCH 2/3] memory: seek FlatView sharing candidates among children subregions

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 06:45, Alexey Kardashevskiy wrote: > On 21/09/17 23:57, Paolo Bonzini wrote: >> On 21/09/2017 15:39, Alexey Kardashevskiy wrote: >>> On 21/09/17 22:07, Paolo Bonzini wrote: A container can be used instead of an alias to allow switching between multiple subregions. In this c

Re: [Qemu-devel] [RFC v4 06/16] virtio-iommu: Register attached devices

2017-09-22 Thread Bharat Bhushan
> -Original Message- > From: Eric Auger [mailto:eric.au...@redhat.com] > Sent: Tuesday, September 19, 2017 1:17 PM > To: eric.auger@gmail.com; eric.au...@redhat.com; > peter.mayd...@linaro.org; alex.william...@redhat.com; m...@redhat.com; > qemu-...@nongnu.org; qemu-devel@nongnu.org;

Re: [Qemu-devel] [PATCH 08/17] imx_fec: Add support for multiple Tx DMA rings

2017-09-22 Thread Jason Wang
On 2017年09月19日 03:50, Andrey Smirnov wrote: More recent version of the IP block support more than one Tx DMA ring, so add the code implementing that feature. Cc: Peter Maydell Cc: Jason Wang Cc:qemu-devel@nongnu.org Cc:qemu-...@nongnu.org Cc:yurov...@gmail.com Signed-off-by: Andrey Smirnov ---

[Qemu-devel] [PULL 0/1] s390x bugfix (needed for stable)

2017-09-22 Thread Cornelia Huck
The following changes since commit 0a8066f0c068f1e318a1aacd7864fc00e455a37b: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170921' into staging (2017-09-21 17:42:27 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-201

[Qemu-devel] [PULL 1/1] s390x/ais: for 2.10 stable: disable ais facility

2017-09-22 Thread Cornelia Huck
From: Christian Borntraeger The migration interface for ais was introduced with kernel 4.13 but the capability itself had been active since 4.12. As migration support is considered necessary lets disable ais in the 2.10 stable version. A proper fix and re-enablement will be done for qemu 2.11. S

Re: [Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

2017-09-22 Thread Cornelia Huck
On Thu, 21 Sep 2017 15:50:28 -0300 Eduardo Habkost wrote: > On Tue, Sep 19, 2017 at 10:55:53AM +0200, Thomas Huth wrote: > > Historically we've marked all devices as hotpluggable by default. However, > > most devices are not hotpluggable, and you also need a HotplugHandler to > > support these de

[Qemu-devel] [PATCH] usb: Fix usb-host build

2017-09-22 Thread Jan Kiszka
From: Jan Kiszka This reverts the incorrect commit 2041649f0b04 (these are machine-independent objects) and fixes the name of the config var. Signed-off-by: Jan Kiszka --- hw/usb/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/Makefile.objs b/hw/usb/Mak

Re: [Qemu-devel] [PATCH v3 2/2] virtio-iommu: vfio integration with virtio-iommu

2017-09-22 Thread Bharat Bhushan
> -Original Message- > From: Auger Eric [mailto:eric.au...@redhat.com] > Sent: Monday, September 18, 2017 1:18 PM > To: Bharat Bhushan ; > eric.auger@gmail.com; peter.mayd...@linaro.org; > alex.william...@redhat.com; m...@redhat.com; qemu-...@nongnu.org; > qemu-devel@nongnu.org > Cc:

[Qemu-devel] [PULL 01/36] docker: ensure NOUSER for travis images

2017-09-22 Thread Fam Zheng
From: Alex Bennée While adding the current user is a useful default behaviour for creating new images it is not appropriate for Travis which already has a default user. Signed-off-by: Alex Bennée Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-Id: <20170725133425

[Qemu-devel] [PULL 02/36] docker: docker.py make --no-cache skip checksum test

2017-09-22 Thread Fam Zheng
From: Alex Bennée If you invoke with NOCACHE=1 we pass --no-cache in the argv to docker.py but may still not force a rebuild if the dockerfile checksum hasn't changed. By testing for its presence we can force builds without having to manually remove the docker image. Signed-off-by: Alex Bennée

[Qemu-devel] [PULL v5 00/36] Build and test automation patches

2017-09-22 Thread Fam Zheng
The following changes since commit 0a8066f0c068f1e318a1aacd7864fc00e455a37b: Merge remote-tracking branch 'remotes/pmaydell/tags/pull-target-arm-20170921' into staging (2017-09-21 17:42:27 +0100) are available in the git repository at: git://github.com/famz/qemu.git tags/build-and-test-auto

[Qemu-devel] [PULL 10/36] docker: Use unconfined security profile

2017-09-22 Thread Fam Zheng
Some by default blocked syscalls are required to run tests for example userfaultfd. Reviewed-by: Kashyap Chamarthy Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-4-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/docker/Makefile

[Qemu-devel] [PULL 03/36] docker: don't install device-tree-compiler build-deps in travis.docker

2017-09-22 Thread Fam Zheng
From: Alex Bennée Installing the device-tree-compiler build-deps is a little extreme. We only actually need the binary so include it with the other packages. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20170725133425.436-6-alex.ben...@linaro.org> Reviewed-by: P

[Qemu-devel] [PULL 06/36] docker: Enable features explicitly in test-full

2017-09-22 Thread Fam Zheng
Also avoid "set -e". Signed-off-by: Fam Zheng Message-Id: <20170907141245.31946-3-f...@redhat.com> Reviewed-by: Eric Blake --- tests/docker/test-full | 82 ++ 1 file changed, 76 insertions(+), 6 deletions(-) diff --git a/tests/docker/test-full b/

[Qemu-devel] [PULL 07/36] tests/docker: Clean up paths

2017-09-22 Thread Fam Zheng
The 'run' script already creats src, build and install directories under $TEST_DIR, use it in common.rc. Also the tests always run from $QEMU_SRC/tests/docker, so use a relative $CMD string. Message-Id: <20170817035721.11064-1-f...@redhat.com> Signed-off-by: Fam Zheng --- tests/docker/common.rc

[Qemu-devel] [PULL 15/36] buildsys: Move sdl cflags/libs to per object

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-3-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- audio/Makefile.objs | 1 + configure | 2 +- ui/Makefile.objs| 1 + 3 files changed, 3 insertions(+), 1 deletio

[Qemu-devel] [PULL 04/36] docker: reduce noise when building travis.docker

2017-09-22 Thread Fam Zheng
From: Alex Bennée Set the DEBIAN_FRONTEND and locale env vars to stop apt complaining so much as we build the image. Suggested-by: Philippe Mathieu-Daudé Signed-off-by: Alex Bennée Message-Id: <20170725133425.436-7-alex.ben...@linaro.org> Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philipp

[Qemu-devel] [PULL 12/36] docker: Add test-block

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-6-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/docker/test-block | 21 + 1 file changed, 21 insertions(+) create mode 100755 tests/docker/test-block diff --g

[Qemu-devel] [PULL 05/36] docker: Update ubuntu image

2017-09-22 Thread Fam Zheng
Base on the newer ubuntu-lts (16.06) and include more packages for better build coverage. Signed-off-by: Fam Zheng Message-Id: <20170907141245.31946-2-f...@redhat.com> --- tests/docker/dockerfiles/ubuntu.docker | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/tests

[Qemu-devel] [PULL 18/36] buildsys: Move libusb cflags/libs to per object

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-9-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 4 ++-- hw/usb/Makefile.objs | 5 + 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PULL 19/36] buildsys: Move usb redir cflags/libs to per object

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-10-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 4 ++-- hw/usb/Makefile.objs | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/c

[Qemu-devel] [PULL 08/36] docker: Fix return code of build_qemu()

2017-09-22 Thread Fam Zheng
Without "set -e", the "&&" makes sure that the return code reflects the result status, and that make only runs if configure succeeds. Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-2-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tes

[Qemu-devel] [PULL 21/36] buildsys: Move rdma libs to per object

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907084230.26493-1-f...@redhat.com> Reviewed-by: Juan Quintela Reviewed-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert Signed-off-by: Fam Zheng --- configure | 2 +- migration/Makefile.objs | 1 + 2 files changed, 2 insertions(+), 1 de

[Qemu-devel] [PULL 09/36] docker: Add test_fail and prep_fail

2017-09-22 Thread Fam Zheng
They both print a message and exit, but with different status code so distinguish real test errors from env preparation failures. Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-3-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/d

[Qemu-devel] [PULL 11/36] docker: Add nettle-devel to fedora image

2017-09-22 Thread Fam Zheng
The LUKS cases in qemu-iotests requires this. Reviewed-by: Kashyap Chamarthy Signed-off-by: Fam Zheng Message-Id: <20170905025614.579-5-f...@redhat.com> Reviewed-by: Stefan Hajnoczi Based-on: 20170905021201.25684-1-f...@redhat.com --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file change

[Qemu-devel] [PULL 24/36] qemu.py: Add "wait()" method

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi Reviewed-by: Alex Bennée --- scripts/qemu.py | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/qemu.py b/scripts/qemu.py index 5e02dd8e78..2b5c2accb5 100644 --- a/scripts/qemu.py +++ b/scripts/qemu.py @@ -215,6 +215,13 @@ cl

[Qemu-devel] [PULL 23/36] gitignore: Ignore vm test images

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- .gitignore | 1 + tests/.gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.gitignore b/.gitignore index cf65316863..40acfcb9e2 100644 --- a/.gitignore +++ b/.gitignore @@ -52,6 +52,7 @@ /vscclient /vhost-user-scsi /fsde

[Qemu-devel] [PULL 13/36] vl: Don't include vde header

2017-09-22 Thread Fam Zheng
Nothing in vl.c uses anything from the vde package, do remove the unnecessary include. Signed-off-by: Fam Zheng Message-Id: <20170907083552.17725-2-f...@redhat.com> Reviewed-by: Jason Wang Signed-off-by: Fam Zheng --- vl.c | 4 1 file changed, 4 deletions(-) diff --git a/vl.c b/vl.c inde

[Qemu-devel] [PULL 14/36] buildsys: Move vde libs to per object

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907083552.17725-3-f...@redhat.com> Reviewed-by: Jason Wang Signed-off-by: Fam Zheng --- configure | 3 +-- net/Makefile.objs | 2 ++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index cb0f7ed0ab..956ab367

[Qemu-devel] [PULL 25/36] scripts: Add archive-source.sh

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- scripts/archive-source.sh | 51 +++ 1 file changed, 51 insertions(+) create mode 100755 scripts/archive-source.sh diff --git a/scripts/archive-source.sh b/scripts/archive-source.sh new file mode 10

[Qemu-devel] [PULL 29/36] tests: Add FreeBSD image

2017-09-22 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Tested-by: Philippe Mathieu-Daudé --- tests/vm/freebsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/freebsd diff --git

[Qemu-devel] [PULL 16/36] buildsys: Move audio libs to per object

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-5-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- audio/Makefile.objs | 5 + configure | 15 ++- 2 files changed, 15 insertions(+), 5 deletions(-)

[Qemu-devel] [PULL 30/36] tests: Add NetBSD image

2017-09-22 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski --- tests/vm/netbsd | 42 ++ 1 file changed, 42 insertions(+) create mode 100755 tests/vm/netbsd diff --git a/tes

[Qemu-devel] [PULL 20/36] buildsys: Move brlapi libs to per object

2017-09-22 Thread Fam Zheng
baum.o already receives the sdl cflags in its per object variable, do the same for brlapi libs to avoid cluttering libs_softmmu. Signed-off-by: Fam Zheng Message-Id: <20170907084700.952-1-f...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Signed-off-by: Fam Zhen

[Qemu-devel] [PULL 28/36] tests: Add ubuntu.i386 image

2017-09-22 Thread Fam Zheng
This adds a 32bit guest. The official LTS cloud image is downloaded and initialized with cloud-init. Signed-off-by: Fam Zheng --- tests/vm/ubuntu.i386 | 89 1 file changed, 89 insertions(+) create mode 100755 tests/vm/ubuntu.i386 diff --git

[Qemu-devel] [PULL 17/36] buildsys: Move libcacard cflags/libs to per object

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Message-Id: <20170907082918.7299-8-f...@redhat.com> Reviewed-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Fam Zheng --- configure| 4 ++-- hw/usb/Makefile.objs | 6 -- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git

Re: [Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

2017-09-22 Thread Thomas Huth
On 21.09.2017 20:50, Eduardo Habkost wrote: > On Tue, Sep 19, 2017 at 10:55:53AM +0200, Thomas Huth wrote: >> Historically we've marked all devices as hotpluggable by default. However, >> most devices are not hotpluggable, and you also need a HotplugHandler to >> support these devices. So if the us

[Qemu-devel] [PULL 31/36] tests: Add OpenBSD image

2017-09-22 Thread Fam Zheng
The image is prepared following instructions as in: https://wiki.qemu.org/Hosts/BSD Signed-off-by: Fam Zheng --- tests/vm/openbsd | 43 +++ 1 file changed, 43 insertions(+) create mode 100755 tests/vm/openbsd diff --git a/tests/vm/openbsd b/tests/vm/ope

[Qemu-devel] [PULL 34/36] tests: Add README for vm tests

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/vm/README | 89 + 1 file changed, 89 insertions(+) create mode 100644 tests/vm/README diff --git a/tests/vm/README b/tests/vm/README new file mode 100644 index 00..ae53dce6ee --- /dev/null +++ b/t

[Qemu-devel] [PULL 33/36] MAINTAINERS: Add tests/vm entry

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Stefan Hajnoczi --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 13c1ac65b7..762e37bfd6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1905,6 +1905,7 @@ S: Maintained F: .travis.yml F: .shippable.yml F: t

[Qemu-devel] [PULL 22/36] MAINTAINERS: Fix subsystem name for "Build and test automation"

2017-09-22 Thread Fam Zheng
From: Eduardo Habkost The subsystem name for the "Build test automation" section is "-", because an actual subsystem name line is missing: $ ./scripts/get_maintainer.pl -f tests/docker/docker.py "Alex Bennée" (maintainer:-...) Fam Zheng (maintainer

Re: [Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

2017-09-22 Thread Thomas Huth
On 22.09.2017 09:38, Cornelia Huck wrote: > On Thu, 21 Sep 2017 15:50:28 -0300 > Eduardo Habkost wrote: > >> On Tue, Sep 19, 2017 at 10:55:53AM +0200, Thomas Huth wrote: >>> Historically we've marked all devices as hotpluggable by default. However, >>> most devices are not hotpluggable, and you a

[Qemu-devel] [PULL 36/36] docker: Drop 'set -e' from run script

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng --- tests/docker/run | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/tests/docker/run b/tests/docker/run index 52b76e443d..c8f940de15 100755 --- a/tests/docker/run +++ b/tests/docker/run @@ -1,4 +1,4 @@ -#!/bin/bash -e +#!/bin/bash # # Docker

[Qemu-devel] [PULL 26/36] tests: Add a test key pair

2017-09-22 Thread Fam Zheng
This will be used by setup test user ssh. Signed-off-by: Fam Zheng Reviewed-by: Eric Blake --- tests/keys/README | 6 ++ tests/keys/id_rsa | 27 +++ tests/keys/id_rsa.pub | 1 + 3 files changed, 34 insertions(+) create mode 100644 tests/keys/README create

Re: [Qemu-devel] [PATCH] seccomp: Don't include libseccomp from QEMU header

2017-09-22 Thread Eduardo Otubo
On Fri, Sep 22, 2017 at 09:09:27AM +0200, Jan Kiszka wrote: > On 2017-09-20 10:36, Fam Zheng wrote: > > The only prototype doesn't need anything from the lib header, and not > > including it here allows files that include this header, for example > > vl.c, to compile without the libseccomp cflags.

[Qemu-devel] [PULL 27/36] tests: Add vm test lib

2017-09-22 Thread Fam Zheng
This is the common code to implement a "VM test" to 1) Download and initialize a pre-defined VM that has necessary dependencies to build QEMU and SSH access. 2) Archive $SRC_PATH to a .tar file. 3) Boot the VM, and pass the source tar file to the guest. 4) SSH into the VM, untar the s

[Qemu-devel] [PATCH] net: fix check for number of parameters to -netdev socket

2017-09-22 Thread Jens Freimann
Since commit 0f8c289ad "net: fix -netdev socket,fd= for UDP sockets" we allow more than one parameter for -netdev socket. But now we run into an assert when no parameter at all is specified > qemu-system-x86_64 -netdev socket socket.c:729: net_init_socket: Assertion `sock->has_udp' failed. Change

[Qemu-devel] [PULL 32/36] Makefile: Add rules to run vm tests

2017-09-22 Thread Fam Zheng
Reviewed-by: Alex Bennée Tested-by: Alex Bennée Signed-off-by: Fam Zheng --- Makefile | 2 ++ configure | 2 +- tests/vm/Makefile.include | 42 ++ 3 files changed, 45 insertions(+), 1 deletion(-) create mode 100644 test

[Qemu-devel] [PULL 35/36] docker: Use archive-source.py

2017-09-22 Thread Fam Zheng
Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée --- tests/docker/Makefile.include | 14 ++ tests/docker/run | 8 +--- 2 files changed, 3 insertions(+), 19 deletions(-) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index 2bed4c0e00..0e

Re: [Qemu-devel] [PULL 00/18] Migration PULL request

2017-09-22 Thread Juan Quintela
Peter Xu wrote: > On Thu, Sep 21, 2017 at 04:29:04PM -0700, no-re...@patchew.org wrote: > > [...] > >> /var/tmp/patchew-tester-tmp-b0y2ycie/src/util/bitmap.c: In function >> ‘bitmap_to_from_le’: >> /var/tmp/patchew-tester-tmp-b0y2ycie/src/util/bitmap.c:383:6: error: >> "__WORD_SIZE" is not defin

Re: [Qemu-devel] [PATCH] net: fix check for number of parameters to -netdev socket

2017-09-22 Thread Jason Wang
On 2017年09月22日 16:04, Jens Freimann wrote: Since commit 0f8c289ad "net: fix -netdev socket,fd= for UDP sockets" we allow more than one parameter for -netdev socket. But now we run into an assert when no parameter at all is specified qemu-system-x86_64 -netdev socket socket.c:729: net_init_so

Re: [Qemu-devel] [PATCH] qemu.py: Call logging.basicConfig() automatically

2017-09-22 Thread Lukáš Doktor
Dne 21.9.2017 v 18:22 Eduardo Habkost napsal(a): > Not all scripts using qemu.py configure the Python logging > module, and end up generating a "No handlers could be found for > logger" message instead of actual log messages. > > To avoid requiring every script using qemu.py to configure > logging

[Qemu-devel] [PATCH/RFC 2/3] s390x/ais: enable ais when migration is available

2017-09-22 Thread Christian Borntraeger
Instead of unconditionally enabling the KVM AIS capability in the kvm arch init function, do this in the flic realize function when we know if migration is available. This requires to initialize flic before the CPUs. Signed-off-by: Christian Borntraeger --- hw/intc/s390_flic.c | 11

[Qemu-devel] [PATCH/RFC 0/3] ais fixups for 2.11

2017-09-22 Thread Christian Borntraeger
Conny, this seem to work on KVM (needs more testing and review). Can you check what happens with TCG? Patch 1 is the known base patch, Patch 2 fixes the ais detection to be based on the flic interfaces Patch 3 disables ais for all compat machines <= 2.10 Christian Borntraeger (3): s390x/ais:

[Qemu-devel] [PATCH/RFC 1/3] s390x/ais: disable ais facility as it is broken

2017-09-22 Thread Christian Borntraeger
The migration interface for ais was introduced with kernel 4.13 but the capability itself had been active since 4.12. As migration support is considered necessary lets disable ais in the 2.10 stable version. A proper fix and re-enablement will be done for qemu 2.11. Signed-off-by: Christian Borntr

Re: [Qemu-devel] [PULL 00/18] Migration PULL request

2017-09-22 Thread Thomas Huth
On 22.09.2017 10:25, Juan Quintela wrote: > Peter Xu wrote: >> On Thu, Sep 21, 2017 at 04:29:04PM -0700, no-re...@patchew.org wrote: >> >> [...] >> >>> /var/tmp/patchew-tester-tmp-b0y2ycie/src/util/bitmap.c: In function >>> ‘bitmap_to_from_le’: >>> /var/tmp/patchew-tester-tmp-b0y2ycie/src/util/bi

[Qemu-devel] [PATCH/RFC 3/3] s390x/ais: disable ais for compat machines

2017-09-22 Thread Christian Borntraeger
With newer kernels that do support the ais feature (4.13) a qemu 2.11 will not only enable the ais feature for the 2.11 machine, but also for a <=2.10 compat machine. As this feature is not available in QEMU <=2.9 (and QEMU 2.10.1), this guest will fail to migrate back to an older qemu like 2.9 wit

Re: [Qemu-devel] [PULL 00/18] Migration PULL request

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 09:25, Juan Quintela wrote: > Peter Xu wrote: >> On Thu, Sep 21, 2017 at 04:29:04PM -0700, no-re...@patchew.org wrote: >> >> [...] >> >>> /var/tmp/patchew-tester-tmp-b0y2ycie/src/util/bitmap.c: In function >>> ‘bitmap_to_from_le’: >>> /var/tmp/patchew-tester-tmp-b0y2ycie/

Re: [Qemu-devel] [PATCH v10 07/10] migration: calculate vCPU blocktime on dst side

2017-09-22 Thread Alexey Perevalov
On 09/21/2017 02:57 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch whe

[Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Peter Xu
IOThread is a general framework that contains IO loop environment and a real thread behind. It's also good to be used internally inside qemu. Provide some helpers for it to create iothreads to be used internally. Signed-off-by: Peter Xu --- include/sysemu/iothread.h | 8 iothread.c

[Qemu-devel] [PATCH 3/3] iothread: delay the context release to finalize

2017-09-22 Thread Peter Xu
When gcontext is used with iothread, the context will be destroyed during iothread_stop(). That's not good since sometimes we would like to keep the resources until iothread is destroyed, but we may want to stop the thread before that point. Delay the destruction of gcontext to iothread finalize.

[Qemu-devel] [PATCH 0/3] iothread: allow to create internal iothreads

2017-09-22 Thread Peter Xu
When trying to support monitor OOB (out-of-band) commands, I found that the monitor IO thread I did looks just like iothread. It would be best if I can use iothread directly. However it seems that it was mostly used by "-object iothread" before but not friendly to internal usages. This series tr

[Qemu-devel] [PATCH 2/3] iothread: export iothread_stop()

2017-09-22 Thread Peter Xu
So that internal iothread users can explicitly stop one iothread without destroying it. Since at it, fix iothread_stop() to allow re-entrance. Before this patch we may call iothread_stop() twice on single iothread, while that may not be correct since qemu_thread_join() is not allowed to run twice

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > IOThread is a general framework that contains IO loop environment and a > real thread behind. It's also good to be used internally inside qemu. > Provide some helpers for it to create iothreads to be used internally. > > Signed-off-by: P

Re: [Qemu-devel] [RFC v2 15/33] migration: pass MigrationState to migrate_init()

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Let the callers take the object, then pass it to migrate_init(). > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 7 ++- > migration/migration.h | 2 +- > migration/savevm.c| 5 - > 3 files chan

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Peter Xu
On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > > IOThread is a general framework that contains IO loop environment and a > > real thread behind. It's also good to be used internally inside qemu. > > Provide some hel

[Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

2017-09-22 Thread Thomas Huth
Historically we've marked all devices as hotpluggable by default. However, most devices are not hotpluggable, and you also need a HotplugHandler to support these devices. So if the user tries to "device_add" or "device_del" such a non-hotpluggable device during runtime, either nothing really usable

Re: [Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_watch_poll

2017-09-22 Thread Peter Xu
On Thu, Sep 21, 2017 at 04:11:33PM +0200, Paolo Bonzini wrote: > On 21/09/2017 08:35, Peter Xu wrote: > > It was only passed in by chr_update_read_handlers(). However when > > reconnect, we'll lose that context information. So if a chardev was > > running on another context (rather than the defau

Re: [Qemu-devel] [PATCH] seccomp: Don't include libseccomp from QEMU header

2017-09-22 Thread Peter Maydell
On 22 September 2017 at 08:54, Eduardo Otubo wrote: > On Fri, Sep 22, 2017 at 09:09:27AM +0200, Jan Kiszka wrote: >> On 2017-09-20 10:36, Fam Zheng wrote: >> > The only prototype doesn't need anything from the lib header, and not >> > including it here allows files that include this header, for ex

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: > On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > > > IOThread is a general framework that contains IO loop environment and a > > > real thread behind. It's

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 11:36, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: >> On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: >>> On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: IOThread is a general framework that contains IO loop

[Qemu-devel] [PATCH v2 1/2] qcow2: fix return error code in qcow2_truncate()

2017-09-22 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/qcow2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 2174a84d1f..8a4311d338 100644 --- a/block/qcow2.c +++ b/block/qcow2.

[Qemu-devel] [PATCH v2 0/2] Truncate the tail of the image file in qcow2 shrinking

2017-09-22 Thread Pavel Butsykin
Now after shrinking the qcow2 image, at the end of the image file, there might be a tail that probably will never be used. Although it will not bring any tangible benefit, we can cut the tail if it is. Yes, it will not free up disk space, but if the blocks were be allocated sequentially and the ima

[Qemu-devel] [PATCH v2 2/2] qcow2: truncate the tail of the image file after shrinking the image

2017-09-22 Thread Pavel Butsykin
Now after shrinking the image, at the end of the image file, there might be a tail that probably will never be used. So we can find the last used cluster and cut the tail. Signed-off-by: Pavel Butsykin --- block/qcow2-refcount.c | 22 ++ block/qcow2.c | 23 ++

Re: [Qemu-devel] [PATCH] qemu.py: Call logging.basicConfig() automatically

2017-09-22 Thread Kevin Wolf
Am 22.09.2017 um 10:37 hat Lukáš Doktor geschrieben: > But we should focus on fixing all the entry points (either initialize > from all of them, or force-create the root logger based on the > entry-point requirements). Kevin, could you please share the exact > reproducer? I used a custom file impor

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 11:38:31AM +0200, Paolo Bonzini wrote: > On 22/09/2017 11:36, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: > >> On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: > >>> On Fri, Sep 22, 2017 at 04:56:10PM +0800, Pete

Re: [Qemu-devel] [PATCH v2 0/2] Truncate the tail of the image file in qcow2 shrinking

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 12:39:24PM +0300, Pavel Butsykin wrote: > Now after shrinking the qcow2 image, at the end of the image file, there might > be a tail that probably will never be used. Although it will not bring any > tangible benefit, we can cut the tail if it is. Yes, it will not free up di

Re: [Qemu-devel] [RFC v2 16/33] migration: rebuild channel on source

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > This patch detects the "resume" flag of migration command, rebuild the > channels only if the flag is set. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > migration/migration.c | 92 > ++--

Re: [Qemu-devel] [PATCH] atomic: update documentation

2017-09-22 Thread Alex Bennée
Paolo Bonzini writes: > Signed-off-by: Paolo Bonzini Reviewed-by: Alex Bennée > --- > docs/devel/atomics.txt | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/docs/devel/atomics.txt b/docs/devel/atomics.txt > index 3ef5d85b1b..048e5f23cb 100644 > --- a/d

Re: [Qemu-devel] [RFC v2 17/33] migration: new state "postcopy-recover"

2017-09-22 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Introducing new migration state "postcopy-recover". If a migration > procedure is paused and the connection is rebuilt afterward > successfully, we'll switch the source VM state from "postcopy-paused" to > the new state "postcopy-recover", then we'll do the r

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-22 Thread David Gibson
On Thu, Sep 21, 2017 at 09:42:26AM +0200, Igor Mammedov wrote: > On Thu, 21 Sep 2017 08:04:55 +0200 > Cédric Le Goater wrote: > > > On 09/21/2017 05:54 AM, Nikunj A Dadhania wrote: > > > David Gibson writes: > > > > > >> On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: > >

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-22 Thread David Gibson
On Thu, Sep 21, 2017 at 08:04:55AM +0200, Cédric Le Goater wrote: > On 09/21/2017 05:54 AM, Nikunj A Dadhania wrote: > > David Gibson writes: > > > >> On Wed, Sep 20, 2017 at 12:48:55PM +0530, Nikunj A Dadhania wrote: > >>> David Gibson writes: > >>> > On Wed, Sep 20, 2017 at 12:10:48PM +05

Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 11:16:34AM +0200, Thomas Huth wrote: > Historically we've marked all devices as hotpluggable by default. However, > most devices are not hotpluggable, and you also need a HotplugHandler to > support these devices. So if the user tries to "device_add" or "device_del" > such a

Re: [Qemu-devel] [PATCH] ppc/pnv: fix cores per chip for multiple cpus

2017-09-22 Thread David Gibson
On Fri, Sep 22, 2017 at 08:07:06AM +0200, Cédric Le Goater wrote: > On 09/22/2017 08:00 AM, Nikunj A Dadhania wrote: > > David Gibson writes: > > > > > > As smp_thread defaults to 1 in vl.c, similarly smp_cores also has the > > default value of 1 in vl.c. In powernv, we were setting n

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 11:43, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 11:38:31AM +0200, Paolo Bonzini wrote: >> On 22/09/2017 11:36, Daniel P. Berrange wrote: >>> On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: On Fri, Sep 22, 2017 at 10:04:33AM +0100, Daniel P. Berrange wrote: >>

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 12:14:04PM +0200, Paolo Bonzini wrote: > On 22/09/2017 11:43, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 11:38:31AM +0200, Paolo Bonzini wrote: > >> On 22/09/2017 11:36, Daniel P. Berrange wrote: > >>> On Fri, Sep 22, 2017 at 05:14:30PM +0800, Peter Xu wrote: > >>

Re: [Qemu-devel] [PATCH v2 3/3] block/throttle.c: add bdrv_co_drain_begin/end callbacks

2017-09-22 Thread Stefan Hajnoczi
On Thu, Sep 21, 2017 at 04:17:07PM +0300, Manos Pitsidianakis wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Manos Pitsidianakis > --- > block/throttle.c | 18 ++ > 1 file changed, 18 insertions(+) Reviewed-by: Stefan Hajnoczi

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Stefan Hajnoczi
On Fri, Sep 22, 2017 at 04:56:10PM +0800, Peter Xu wrote: > IOThread is a general framework that contains IO loop environment and a > real thread behind. It's also good to be used internally inside qemu. > Provide some helpers for it to create iothreads to be used internally. > > Signed-off-by: P

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 12:18:44PM +0200, Paolo Bonzini wrote: > On 22/09/2017 12:16, Stefan Hajnoczi wrote: > > I suggest adding internal IOThreads alongside user-created IOThreads > > instead of hiding them. IOThread also needs a bool user_created field > > and a UserCreatableClass->can_be_delet

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 12:16, Stefan Hajnoczi wrote: > I suggest adding internal IOThreads alongside user-created IOThreads > instead of hiding them. IOThread also needs a bool user_created field > and a UserCreatableClass->can_be_deleted() function: > > static bool iothread_can_be_deleted(UserCreatable

Re: [Qemu-devel] [PATCH] migration: disable auto-converge during bulk block migration

2017-09-22 Thread Stefan Hajnoczi
On Thu, Sep 21, 2017 at 02:32:32PM +0200, Peter Lieven wrote: > auto-converge and block migration currently do not play well together. > During block migration the auto-converge logic detects that ram > migration makes no progress and thus throttles down the vm until > it nearly stalls completely.

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Paolo Bonzini
On 22/09/2017 12:20, Daniel P. Berrange wrote: > On Fri, Sep 22, 2017 at 12:18:44PM +0200, Paolo Bonzini wrote: >> On 22/09/2017 12:16, Stefan Hajnoczi wrote: >>> I suggest adding internal IOThreads alongside user-created IOThreads >>> instead of hiding them. IOThread also needs a bool user_create

Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

2017-09-22 Thread Daniel P. Berrange
On Fri, Sep 22, 2017 at 12:26:16PM +0200, Paolo Bonzini wrote: > On 22/09/2017 12:20, Daniel P. Berrange wrote: > > On Fri, Sep 22, 2017 at 12:18:44PM +0200, Paolo Bonzini wrote: > >> On 22/09/2017 12:16, Stefan Hajnoczi wrote: > >>> I suggest adding internal IOThreads alongside user-created IOThre

  1   2   3   4   >