Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

2017-09-18 Thread Fam Zheng
On Mon, 09/18 08:44, Kevin Wolf wrote: > > > > > +self._qemu_full_args = (self._wrapper + [self._binary] + > > > > > +self._base_args() + self._args) > > > > > > > > The parentheses seem superfluous. With those removed: > > > > > > > > Reviewed-by:

Re: [Qemu-devel] [PATCH 1/6] qemu-io: Reset qemuio_blk permissions before each command

2017-09-18 Thread Fam Zheng
On Fri, 09/15 12:10, Kevin Wolf wrote: > qemu-io provides a 'reopen' command that allows switching from writable > to read-only access. We need to make sure that we don't try to keep > write permissions to a BlockBackend that becomes read-only, otherwise > things are going to fail. > > command() a

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 10:22:43AM +0100, Dr. David Alan Gilbert wrote: > * Fam Zheng (f...@redhat.com) wrote: > > On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > > > * Fam Zheng (f...@redhat.com) wrote: > > > > On Fri, 09/15 16:03, Peter Xu wrote: > > > > > On Fri, Sep 15, 2017 at 01:44:03PM

Re: [Qemu-devel] [PATCH RFC v2 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-18 Thread Christian Borntraeger
On 09/15/2017 06:39 PM, Cornelia Huck wrote: > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > registering the s390 pci host bridge conditional on presense > of the zpci facility bit. Sadly, that breaks migration from > machines that did not use the cpu model (2.7 and previous). >

[Qemu-devel] [Bug 838974] Re: Confusing error report for missing vde support

2017-09-18 Thread Thomas Huth
I think this has been fixed by this commit here: https://git.qemu.org/?p=qemu.git;a=commitdiff;h=d139e9a6cf01b8c31f59 ... so closing this ticket now. ** Changed in: qemu Status: New => Fix Released -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 01:34:24PM -0500, Eric Blake wrote: > On 09/14/2017 09:59 PM, Peter Xu wrote: > > On Thu, Sep 14, 2017 at 04:33:34PM +0100, Stefan Hajnoczi wrote: > >> On Thu, Sep 14, 2017 at 03:50:35PM +0800, Peter Xu wrote: > >>> diff --git a/docs/devel/qapi-code-gen.txt b/docs/devel/qapi

Re: [Qemu-devel] [PATCH 6/6] block: Fix permissions after bdrv_reopen()

2017-09-18 Thread Fam Zheng
On Fri, 09/15 12:10, Kevin Wolf wrote: > If we switch between read-only and read-write, the permissions that > image format drivers need on bs->file change, too. Make sure to update > the permissions during bdrv_reopen(). > > Signed-off-by: Kevin Wolf > --- > include/block/block.h | 1 + > bloc

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Igor Mammedov
On Mon, 18 Sep 2017 11:54:50 +0800 Dou Liyang wrote: > At 09/15/2017 06:05 PM, Dou Liyang wrote: > > Hi Daniel, > > > > At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: > >> On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: > >>> In QEMU, if we enable NUMA and have nodes, QEMU will

Re: [Qemu-devel] [PATCH 6/6] block: Fix permissions after bdrv_reopen()

2017-09-18 Thread Kevin Wolf
Am 18.09.2017 um 09:37 hat Fam Zheng geschrieben: > On Fri, 09/15 12:10, Kevin Wolf wrote: > > If we switch between read-only and read-write, the permissions that > > image format drivers need on bs->file change, too. Make sure to update > > the permissions during bdrv_reopen(). > > > > Signed-off

Re: [Qemu-devel] [PATCH] target/s390x/kvm: Fix problem when running with SELinux under z/VM

2017-09-18 Thread Christian Borntraeger
On 09/15/2017 04:36 PM, Thomas Huth wrote: > On 29.03.2017 16:25, Christian Borntraeger wrote: >> On 03/29/2017 04:21 PM, Thomas Huth wrote: >>> On 24.03.2017 10:39, Christian Borntraeger wrote: On 03/24/2017 10:26 AM, Thomas Huth wrote: > When running QEMU with KVM under z/VM, the memor

[Qemu-devel] [PATCH] seccomp: Fix build

2017-09-18 Thread Jan Kiszka
From: Jan Kiszka vl.c includes seccomp.h, thus requires the related CFLAGS as well. Signed-off-by: Jan Kiszka --- Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.objs b/Makefile.objs index d9cf7ad791..4f1488d65d 100644 --- a/Makefile.objs +++ b/Makefi

Re: [Qemu-devel] [PATCH RFC v2 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-18 Thread Christian Borntraeger
On 09/18/2017 09:33 AM, Christian Borntraeger wrote: > > > On 09/15/2017 06:39 PM, Cornelia Huck wrote: >> d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made >> registering the s390 pci host bridge conditional on presense >> of the zpci facility bit. Sadly, that breaks migration from >

Re: [Qemu-devel] [PATCH v3 2/2] virtio-iommu: vfio integration with virtio-iommu

2017-09-18 Thread Auger Eric
Hi Bharat, On 21/08/2017 12:48, Bharat Bhushan wrote: > This RFC patch allows virtio-iommu protection for PCI > device-passthrough. > > MSI region is mapped by current version of virtio-iommu driver. > This uses VFIO extension of map/unmap notification when an area > of memory is mappedi/unmapped

Re: [Qemu-devel] [PATCH RFC v2 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-18 Thread Cornelia Huck
On Mon, 18 Sep 2017 09:33:23 +0200 Christian Borntraeger wrote: > On 09/15/2017 06:39 PM, Cornelia Huck wrote: > > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > > registering the s390 pci host bridge conditional on presense > > of the zpci facility bit. Sadly, that breaks migrati

Re: [Qemu-devel] [PATCH 0/6] block: Fix permissions after ro/rw reopen

2017-09-18 Thread Fam Zheng
On Fri, 09/15 12:10, Kevin Wolf wrote: > bdrv_reopen() can switch nodes between read-only and read-write modes. > This has implications for the required permissions on their child nodes. > For example, a qcow2 node requests write permissions on bs->file only if > it is writable itself. > > This me

[Qemu-devel] [PATCH] arm: Fix SMC reporting to EL2 when QEMU provides PSCI

2017-09-18 Thread Jan Kiszka
From: Jan Kiszka This properly forwards SMC events to EL2 when PSCI is provided by QEMU itself and, thus, ARM_FEATURE_EL3 is off. Found and tested with the Jailhouse hypervisor. Signed-off-by: Jan Kiszka --- target/arm/helper.c| 2 +- target/arm/op_helper.c | 8 target/arm/psci.c

Re: [Qemu-devel] [RFC 14/15] qmp: support out-of-band (oob) execution

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 04:55:51PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > Having "allow-oob" to true for a command does not mean that this command > > will always be run in out-of-band mode. The out-of-band quick path will > > only be executed if we specif

Re: [Qemu-devel] [RFC 15/15] qmp: let migrate-incoming allow out-of-band

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 05:09:28PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > So it can get rid of being run on main thread. > > > > Signed-off-by: Peter Xu > > --- > > qapi/migration.json | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > >

Re: [Qemu-devel] [PATCH RFC v2 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-18 Thread Cornelia Huck
On Mon, 18 Sep 2017 09:47:00 +0200 Christian Borntraeger wrote: > On 09/18/2017 09:33 AM, Christian Borntraeger wrote: > > > > > > On 09/15/2017 06:39 PM, Cornelia Huck wrote: > >> d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > >> registering the s390 pci host bridge condition

Re: [Qemu-devel] [PATCH 0/6] block: Fix permissions after ro/rw reopen

2017-09-18 Thread Kevin Wolf
Am 18.09.2017 um 09:51 hat Fam Zheng geschrieben: > On Fri, 09/15 12:10, Kevin Wolf wrote: > > bdrv_reopen() can switch nodes between read-only and read-write modes. > > This has implications for the required permissions on their child nodes. > > For example, a qcow2 node requests write permissions

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Dou Liyang
At 09/18/2017 03:40 PM, Igor Mammedov wrote: On Mon, 18 Sep 2017 11:54:50 +0800 Dou Liyang wrote: At 09/15/2017 06:05 PM, Dou Liyang wrote: Hi Daniel, At 09/15/2017 04:40 PM, Daniel P. Berrange wrote: On Fri, Sep 15, 2017 at 04:33:18PM +0800, Dou Liyang wrote: In QEMU, if we enable NUMA

Re: [Qemu-devel] Trying to use ccid-card-emulated

2017-09-18 Thread Patrick Vacek
Hello Marc-André, Thanks for your message! On 14.09.2017 00:13, Marc-André Lureau wrote: > Hi Patrick > > On Wed, Sep 6, 2017 at 5:04 PM Patrick Vacek > mailto:patr...@advancedtelematic.com>> > wrote: > > Hello, > > I'm trying to emulate a smartcard. I found section 4 of docs/ccid.txt, >

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-18 Thread Christian Borntraeger
On 09/15/2017 09:27 AM, Cornelia Huck wrote: > On Thu, 14 Sep 2017 18:50:29 +0200 > Halil Pasic wrote: > >> On 09/14/2017 04:26 PM, Cornelia Huck wrote: >>> On Wed, 13 Sep 2017 15:27:51 +0200 >>> Halil Pasic wrote: > +static Property ccw_tester_properties[] = { +DEFINE_PROP_UINT

Re: [Qemu-devel] [PATCH] seccomp: Fix build

2017-09-18 Thread Peter Maydell
On 18 September 2017 at 08:46, Jan Kiszka wrote: > From: Jan Kiszka > > vl.c includes seccomp.h, thus requires the related CFLAGS as well. > > Signed-off-by: Jan Kiszka > --- > Makefile.objs | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile.objs b/Makefile.objs >

Re: [Qemu-devel] [PATCH RFC v2 1/1] s390x/ccw: create s390 phb for compat reasons as well

2017-09-18 Thread Christian Borntraeger
On 09/18/2017 10:07 AM, Cornelia Huck wrote: > On Mon, 18 Sep 2017 09:47:00 +0200 > Christian Borntraeger wrote: > >> On 09/18/2017 09:33 AM, Christian Borntraeger wrote: >>> >>> >>> On 09/15/2017 06:39 PM, Cornelia Huck wrote: d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 01:14:47PM +0200, Marc-André Lureau wrote: > Hi > > On Thu, Sep 14, 2017 at 9:46 PM, Peter Xu wrote: > > On Thu, Sep 14, 2017 at 07:53:15PM +0100, Dr. David Alan Gilbert wrote: > >> * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > >> > Hi > >> > > >> > On Thu, Sep

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-18 Thread Cornelia Huck
On Mon, 18 Sep 2017 10:30:32 +0200 Christian Borntraeger wrote: > On 09/15/2017 09:27 AM, Cornelia Huck wrote: > > On Thu, 14 Sep 2017 18:50:29 +0200 > > Halil Pasic wrote: > > > >> On 09/14/2017 04:26 PM, Cornelia Huck wrote: > >>> On Wed, 13 Sep 2017 15:27:51 +0200 > >>> Halil Pasic wrot

[Qemu-devel] [PATCH v3] s390x/ccw: create s390 phb for compat reasons as well

2017-09-18 Thread Cornelia Huck
d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made registering the s390 pci host bridge conditional on presense of the zpci facility bit. Sadly, that breaks migration from machines that did not use the cpu model (2.7 and previous). Create the s390 phb for pre-cpu model machines as well:

Re: [Qemu-devel] [PATCH v3] s390x/ccw: create s390 phb for compat reasons as well

2017-09-18 Thread Christian Borntraeger
On 09/18/2017 10:55 AM, Cornelia Huck wrote: > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > registering the s390 pci host bridge conditional on presense > of the zpci facility bit. Sadly, that breaks migration from > machines that did not use the cpu model (2.7 and previous). >

Re: [Qemu-devel] [PATCH v3] s390x/ccw: create s390 phb for compat reasons as well

2017-09-18 Thread Cornelia Huck
On Mon, 18 Sep 2017 10:58:47 +0200 Christian Borntraeger wrote: > On 09/18/2017 10:55 AM, Cornelia Huck wrote: > > d32bd032d8 ("s390x/ccw: create s390 phb conditionally") made > > registering the s390 pci host bridge conditional on presense > > of the zpci facility bit. Sadly, that breaks migrati

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Igor Mammedov
On Fri, 15 Sep 2017 16:33:18 +0800 Dou Liyang wrote: > In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table > for transfering NUMA configuration to the guest. So, the maximum memory in > SRAT can be used to determine whether to use the swiotlb for IOMMU or not. > However, if

Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

2017-09-18 Thread Dou Liyang
Hi Igor, At 09/18/2017 05:08 PM, Igor Mammedov wrote: On Fri, 15 Sep 2017 16:33:18 +0800 Dou Liyang wrote: In QEMU, if we enable NUMA and have nodes, QEMU will build ACPI SRAT table for transfering NUMA configuration to the guest. So, the maximum memory in SRAT can be used to determine whethe

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 04:17:07PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Fri, Sep 15, 2017 at 01:29:13PM +0100, Daniel P. Berrange wrote: > > > On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Alan Gilbert wrote: > > > > * Daniel P. Berrange

Re: [Qemu-devel] [PATCH v8 03/13] scripts: Add archive-source.sh

2017-09-18 Thread Alex Bennée
Fam Zheng writes: > Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée > --- > scripts/archive-source.sh | 33 + > 1 file changed, 33 insertions(+) > create mode 100755 scripts/archive-source.sh > > diff --git a/scripts/archive-source.sh b/scripts/archive-sou

Re: [Qemu-devel] [PATCH v5 08/12] char: convert the escc device to keycodemapdb

2017-09-18 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 02:32:14PM -0400, Programmingkid wrote: > Sorry but I saw this error when I tried your patches: > > OBJCui/cocoa.o > CC ui/curses.o > ui/input-keymap.c:17:10: fatal error: 'ui/input-keymap-qcode-to-sun.c' file > not > found > #include "ui/input-keymap-qc

Re: [Qemu-devel] [PATCH v2 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

2017-09-18 Thread Peter Xu
On Fri, Sep 15, 2017 at 05:04:35PM +0200, Mohammed Gamal wrote: > Starting qemu with > qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu > leads to a segfault. The code assume PCI bus is present and > tries to access the bus structure without checking. > > The patch series moves the error c

Re: [Qemu-devel] [PATCH v8 13/13] docker: Use archive-source.py

2017-09-18 Thread Alex Bennée
Fam Zheng writes: > Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée > --- > tests/docker/Makefile.include | 15 ++- > tests/docker/run | 8 +--- > 2 files changed, 3 insertions(+), 20 deletions(-) > > diff --git a/tests/docker/Makefile.include b/tests/docker/

Re: [Qemu-devel] [RFC v2 16/32] vhost+postcopy: Send address back to qemu

2017-09-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Sep 13, 2017 at 01:15:32PM +0100, Dr. David Alan Gilbert wrote: > > * Peter Xu (pet...@redhat.com) wrote: > > > On Tue, Sep 12, 2017 at 06:15:13PM +0100, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > > > On Thu, Aug

Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error

2017-09-18 Thread Stefan Hajnoczi
On Mon, Sep 18, 2017 at 07:25:24AM +0200, Kevin Wolf wrote: > Python requires parentheses around multiline expression. This fixes the > breakage of all Python-based qemu-iotests cases that was introduced in > commit dab91d9aa0. > > Signed-off-by: Kevin Wolf > --- > > Eduardo, I think I'm going t

Re: [Qemu-devel] [PATCH 6/6] block: Fix permissions after bdrv_reopen()

2017-09-18 Thread Kevin Wolf
Am 15.09.2017 um 21:06 hat Eric Blake geschrieben: > On 09/15/2017 05:10 AM, Kevin Wolf wrote: > > If we switch between read-only and read-write, the permissions that > > image format drivers need on bs->file change, too. Make sure to update > > the permissions during bdrv_reopen(). > > > > Signed

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-09-18 Thread Pavel Butsykin
On 15.09.2017 20:09, Paolo Bonzini wrote: On 07/07/2017 16:21, Pavel Butsykin wrote: We should guarantee that RAM will not be modified while VM has a stopped state, otherwise it can lead to negative consequences during post-copy migration. In RUN_STATE_FINISH_MIGRATE step, it's expected that RAM

[Qemu-devel] [PATCH] scripts/qemu.py: fix continuation

2017-09-18 Thread Alex Bennée
Commit dab91d9aa00e41ee680524e4f6e99a1e7fe12eb2 broke the invocation by dropping the surrounding braces. I'm not sure how this could have worked, maybe some pythons are more forgiving? Signed-off-by: Alex Bennée CC: Amador Pahim CC: Fam Zheng CC: Eduardo Habkost --- scripts/qemu.py | 4 ++--

Re: [Qemu-devel] [PATCH] qom/cpu: move cpu_model null check to cpu_class_by_name()

2017-09-18 Thread Igor Mammedov
On Sun, 17 Sep 2017 20:28:42 -0300 Philippe Mathieu-Daudé wrote: > and clean every implementation. > > Suggested-by: Eduardo Habkost > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Igor Mammedov > --- > Based-on: 20170917232010.14183-7-f4...@amsat.org > > qom/cpu.c | 7 ++

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts

2017-09-18 Thread Stefan Hajnoczi
On Fri, Sep 15, 2017 at 09:38:32PM -0300, Eduardo Habkost wrote: > On Fri, Sep 15, 2017 at 08:17:18PM -0400, John Snow wrote: > > > > > > On 09/15/2017 07:07 PM, Eduardo Habkost wrote: > > > Cleber and I are volunteering to review and queue patches for the > > > Python scripts and modules in scri

Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error

2017-09-18 Thread Alex Bennée
Kevin Wolf writes: > Python requires parentheses around multiline expression. This fixes the > breakage of all Python-based qemu-iotests cases that was introduced in > commit dab91d9aa0. > > Signed-off-by: Kevin Wolf Heh, just sent an identical patch. Reviewed-by: Alex Bennée Tested-by: Alex

Re: [Qemu-devel] [PATCH v8 12/13] tests: Add README for vm tests

2017-09-18 Thread Alex Bennée
Fam Zheng writes: > Signed-off-by: Fam Zheng > --- > tests/vm/README | 85 > + > 1 file changed, 85 insertions(+) > create mode 100644 tests/vm/README > > diff --git a/tests/vm/README b/tests/vm/README > new file mode 100644 > index 000

Re: [Qemu-devel] [PULL 14/15] qemu.py: improve message on negative exit code

2017-09-18 Thread Daniel P. Berrange
On Fri, Sep 15, 2017 at 08:37:38PM -0300, Eduardo Habkost wrote: > From: Amador Pahim > > The current message shows 'self._args', which contains only part of the > options used in the Qemu command line. > > This patch makes the qemu full args list an instance variable and then > uses it in the n

Re: [Qemu-devel] [PATCH v7 0/4] Add shrink image for qcow2

2017-09-18 Thread Pavel Butsykin
On 16.09.2017 17:56, Max Reitz wrote: On 2017-08-22 01:31, John Snow wrote: On 08/17/2017 05:15 AM, Pavel Butsykin wrote: This patch add shrinking of the image file for qcow2. As a result, this allows us to reduce the virtual image size and free up space on the disk without copying the image.

Re: [Qemu-devel] [libvirt] libvirt/QEMU/SEV interaction

2017-09-18 Thread Daniel P. Berrange
On Mon, Sep 18, 2017 at 11:43:57AM +0200, Erik Skultety wrote: > [...] > > > > > > > > c) what existing communicate interface can be used between libvirt > > > and qemu > > > > to get the measurement ? can we add a new qemu monitor command > > > > 'get_sev_measurement' to get the meas

Re: [Qemu-devel] [Qemu devel v9 PATCH 4/5] msf2: Add Smartfusion2 SoC

2017-09-18 Thread sundeep subbaraya
Hi Philippe, On Mon, Sep 18, 2017 at 6:38 AM, Philippe Mathieu-Daudé wrote: > On 09/15/2017 01:59 PM, Subbaraya Sundeep wrote: > >> Smartfusion2 SoC has hardened Microcontroller subsystem >> and flash based FPGA fabric. This patch adds support for >> Microcontroller subsystem in the SoC. >> >> S

Re: [Qemu-devel] [Qemu-arm] [PATCH v7 13/20] hw/arm/smmuv3: Implement IOMMU memory region replay callback

2017-09-18 Thread Tomasz Nowicki
Hi Eric, On 15.09.2017 16:50, Auger Eric wrote: Hi, On 15/09/2017 12:42, tn wrote: Hi Eric, On 15.09.2017 09:30, Auger Eric wrote: Hi Tomasz, On 14/09/2017 16:43, Tomasz Nowicki wrote: On 14.09.2017 16:31, Tomasz Nowicki wrote: Hi Eric, On 14.09.2017 11:27, Linu Cherian wrote: Hi Eric,

Re: [Qemu-devel] [Qemu-block] [PATCH] throttle: Assert that bkt->max is valid in throttle_compute_wait()

2017-09-18 Thread Kevin Wolf
Am 13.09.2017 um 10:28 hat Alberto Garcia geschrieben: > If bkt->max == 0 and bkt->burst_length > 1 then we could have a > division by 0 in throttle_do_compute_wait(). That configuration is > however not permitted and is already detected by throttle_is_valid(), > but let's assert it in throttle_com

Re: [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit

2017-09-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 10:22:43AM +0100, Dr. David Alan Gilbert wrote: > > * Fam Zheng (f...@redhat.com) wrote: > > > On Fri, 09/15 09:42, Dr. David Alan Gilbert wrote: > > > > * Fam Zheng (f...@redhat.com) wrote: > > > > > On Fri, 09/15 16:03, Peter Xu wrot

Re: [Qemu-devel] [Qemu-block] [PATCH 00/18] block/mirror: Add active-sync mirroring

2017-09-18 Thread Stefan Hajnoczi
On Sat, Sep 16, 2017 at 04:02:45PM +0200, Max Reitz wrote: > On 2017-09-14 17:42, Stefan Hajnoczi wrote: > > On Wed, Sep 13, 2017 at 08:18:52PM +0200, Max Reitz wrote: > >> There may be a couple of things to do on top of this series: > >> - Allow switching between active and passive mode at runtime

Re: [Qemu-devel] [PATCH v3 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

2017-09-18 Thread Cornelia Huck
On Fri, 15 Sep 2017 10:40:32 -0400 Farhan Ali wrote: > Wire up the virtio-gpu device for the CCW bus. The virtio-gpu > is a virtio-1 device, so disable revision 0. > > Signed-off-by: Farhan Ali > Acked-by: Christian Borntraeger > Reviewed-by: Halil Pasic > Reviewed-by: Thomas Huth > --- > h

Re: [Qemu-devel] [Qemu-block] [PATCH 15/18] block/mirror: Add active mirroring

2017-09-18 Thread Stefan Hajnoczi
On Sat, Sep 16, 2017 at 03:58:01PM +0200, Max Reitz wrote: > On 2017-09-14 17:57, Stefan Hajnoczi wrote: > > On Wed, Sep 13, 2017 at 08:19:07PM +0200, Max Reitz wrote: > >> This patch implements active synchronous mirroring. In active mode, the > >> passive mechanism will still be in place and is

Re: [Qemu-devel] [PULL 22/24] target-arm: ensure all cross vCPUs TLB flushes complete

2017-09-18 Thread Alex Bennée
Dmitry Osipenko writes: > On 17.09.2017 16:22, Alex Bennée wrote: >> >> Dmitry Osipenko writes: >> >>> On 24.02.2017 14:21, Alex Bennée wrote: Previously flushes on other vCPUs would only get serviced when they exited their TranslationBlocks. While this isn't overly problematic it >>>

Re: [Qemu-devel] [PATCH V5 01/10] specs/qcow2: add compress format extension

2017-09-18 Thread Peter Lieven
Am 11.09.2017 um 16:22 schrieb Kevin Wolf: Am 25.07.2017 um 16:41 hat Peter Lieven geschrieben: Signed-off-by: Peter Lieven --- docs/interop/qcow2.txt | 51 +- roms/ipxe | 2 +- 2 files changed, 51 insertions(+), 2 deletions(-)

[Qemu-devel] [PATCH v3 1/2] x86_iommu: Move machine check to x86_iommu_realize()

2017-09-18 Thread Mohammed Gamal
Instead of having the same error checks in vtd_realize() and amdvi_realize(), move that over to the generic x86_iommu_realize(). Signed-off-by: Mohammed Gamal --- hw/i386/amd_iommu.c | 10 +- hw/i386/intel_iommu.c | 10 +- hw/i386/x86-iommu.c | 12 3 files change

[Qemu-devel] [PATCH v3 0/2] x86_iommu: Fix segfault when starting on non-PCI machines

2017-09-18 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. The patch series moves the error checks from vtd_realize() and amdvi_realize() to the generic x86_iommu_realiz

Re: [Qemu-devel] [PATCH v8 05/13] tests: Add vm test lib

2017-09-18 Thread Alex Bennée
Fam Zheng writes: > This is the common code to implement a "VM test" to > > 1) Download and initialize a pre-defined VM that has necessary > dependencies to build QEMU and SSH access. > > 2) Archive $SRC_PATH to a .tar file. > > 3) Boot the VM, and pass the source tar file to the guest.

[Qemu-devel] [PATCH v3 2/2] x86_iommu: check if machine has PCI bus

2017-09-18 Thread Mohammed Gamal
Starting qemu with qemu-system-x86_64 -S -M isapc -device {amd|intel}-iommu leads to a segfault. The code assume PCI bus is present and tries to access the bus structure without checking. Since Intel VT-d and AMDVI should only work with PCI, add a check for PCI bus and return error if not present.

[Qemu-devel] [PATCH qemu v3 01/13] memory: Postpone flatview and dispatch tree building till all devices are added

2017-09-18 Thread Alexey Kardashevskiy
Most devices use at least one address space and every time a new address space is added, flat views and dispatch trees are rebuild for all address spaces. This is not a problem for a relatively small amount of devices but even 50 virtio-pci devices use more than 8GB of RAM. What happens that on ev

[Qemu-devel] [PATCH qemu v3 03/13] memory: Open code FlatView rendering

2017-09-18 Thread Alexey Kardashevskiy
We are going to share FlatView's between AddressSpace's and per-AS memory listeners won't suite the purpose anymore so open code the dispatch tree rendering. Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * inlined & simplified address_space_update_flatview --- include/exec/memory-internal

[Qemu-devel] [PATCH qemu v3 06/13] memory: Remove AddressSpace pointer from AddressSpaceDispatch

2017-09-18 Thread Alexey Kardashevskiy
AS in ASD is only used to pass AS from mem_begin() to register_subpage() to store it in MemoryRegionSection, we can do this directly now. Signed-off-by: Alexey Kardashevskiy --- exec.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index 6b021

[Qemu-devel] [PATCH qemu v3 00/13] memory: Reduce memory use

2017-09-18 Thread Alexey Kardashevskiy
This was inspired by https://bugzilla.redhat.com/show_bug.cgi?id=1481593 Previous versions: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01559.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg04069.html This patchset tries to reduce amount of memory used by FlatVi

Re: [Qemu-devel] [Qemu devel v9 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

2017-09-18 Thread sundeep subbaraya
Hi Philippe, On Mon, Sep 18, 2017 at 6:31 AM, Philippe Mathieu-Daudé wrote: > Hi Sundeep, Peter, > > > On 09/15/2017 01:59 PM, Subbaraya Sundeep wrote: > >> Added Sytem register block of Smartfusion2. >> This block has PLL registers which are accessed by guest. >> >> Signed-off-by: Subbaraya Sun

[Qemu-devel] [PATCH qemu v3 04/13] memory: Move FlatView allocation to a helper

2017-09-18 Thread Alexey Kardashevskiy
This moves a FlatView allocation and initialization to a helper. While we are nere, replace g_new with g_new0 to not to bother if we add new fields in the future. Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * s/flatview_alloc/flatview_new/ --- memory.c | 16 1 file chan

[Qemu-devel] [PATCH qemu v3 07/13] memory: Switch memory from using AddressSpace to FlatView

2017-09-18 Thread Alexey Kardashevskiy
FlatView's will be shared between AddressSpace's and subpage_t and MemoryRegionSection cannot store AS anymore, hence this change. In particular, for: typedef struct subpage_t { MemoryRegion iomem; -AddressSpace *as; +FlatView *fv; hwaddr base; uint16_t sub_section[]; } s

[Qemu-devel] [PATCH qemu v3 08/13] memory: Cleanup after switching to FlatView

2017-09-18 Thread Alexey Kardashevskiy
We store AddressSpaceDispatch* in FlatView anyway so there is no need to carry it from mem_add() to register_subpage/register_multipage. Signed-off-by: Alexey Kardashevskiy --- exec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/exec.c b/exec.c index b5610

[Qemu-devel] [PATCH qemu v3 13/13] memory: Add flat views to HMP "info mtree"

2017-09-18 Thread Alexey Kardashevskiy
This adds a new switch to "info mtree" to print dispatch tree internals. Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * reimplemented as there is no more global FlatView list --- Example: aik@fstn1-p1:~$ echo "info mtree -f -d" | nc localhost 3 QEMU 2.10.50 monitor - type 'help' fo

[Qemu-devel] [PATCH qemu v3 11/13] memory: Share FlatView's and dispatch trees between address spaces

2017-09-18 Thread Alexey Kardashevskiy
This allows sharing flat views between address spaces when the same root memory region is used when creating a new address space. Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * got rid of global and per-AS lists of FlatView objects --- I could also make all empty FlatViews (view->nr==0

[Qemu-devel] [PATCH qemu v3 10/13] memory: Store physical root MR in FlatView

2017-09-18 Thread Alexey Kardashevskiy
Address spaces get to keep a root MR (alias or not) but FlatView stores the actual MR as this is going to be used later on to decide whether to share a particular FlatView or not. Signed-off-by: Alexey Kardashevskiy --- memory.c | 27 ++- 1 file changed, 22 insertions(+),

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Marc-André Lureau
Hi On Mon, Sep 18, 2017 at 10:37 AM, Peter Xu wrote: > On Fri, Sep 15, 2017 at 01:14:47PM +0200, Marc-André Lureau wrote: >> Hi >> >> On Thu, Sep 14, 2017 at 9:46 PM, Peter Xu wrote: >> > On Thu, Sep 14, 2017 at 07:53:15PM +0100, Dr. David Alan Gilbert wrote: >> >> * Marc-André Lureau (marcandre

[Qemu-devel] [PATCH qemu v3 09/13] memory: Rename mem_begin/mem_commit/mem_add helpers

2017-09-18 Thread Alexey Kardashevskiy
This renames some helper to reflect better what they do. Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * s/flatview_mem_add/flatview_add_to_dispatch/ * s/phys_page_compact_all/address_space_dispatch_compact/ * s/address_space_dispatch_alloc/address_space_dispatch_new/ --- include/exec/mem

[Qemu-devel] [PATCH qemu v3 12/13] memory: Get rid of address_space_init_shareable

2017-09-18 Thread Alexey Kardashevskiy
Since FlatViews are shared now and ASes not, this gets rid of address_space_init_shareable(). Signed-off-by: Alexey Kardashevskiy --- Changes: v3: * now removes @malloced and @ref_count, used to be in the previos patch --- include/exec/memory.h | 19 --- include/hw/arm/armv7m.h

[Qemu-devel] [PATCH qemu v3 02/13] exec: Explicitely export target AS from address_space_translate_internal

2017-09-18 Thread Alexey Kardashevskiy
This is not so mechanical change in order to move to shared FlatViews so make it a separate patch. The first argument of address_space_do_translate() will become a FlatView, however since address_space_get_iotlb_entry() still wants AS, hence this change. Signed-off-by: Alexey Kardashevskiy --- e

[Qemu-devel] [PATCH qemu v3 05/13] memory: Move AddressSpaceDispatch from AddressSpace to FlatView

2017-09-18 Thread Alexey Kardashevskiy
As we are going to share FlatView's between AddressSpace's, and AddressSpaceDispatch is a structure to perform quick lookup in FlatView, this moves ASD to FlatView. After previosly open coded ASD rendering, we can also remove as->next_dispatch as the new FlatView pointer is stored on a stack and s

Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error

2017-09-18 Thread Peter Maydell
On 18 September 2017 at 06:25, Kevin Wolf wrote: > Python requires parentheses around multiline expression. This fixes the > breakage of all Python-based qemu-iotests cases that was introduced in > commit dab91d9aa0. > > Signed-off-by: Kevin Wolf > --- > > Eduardo, I think I'm going to include th

Re: [Qemu-devel] [PATCH v3 1/2] virtio-gpu: Handle endian conversion

2017-09-18 Thread Gerd Hoffmann
On Fri, 2017-09-15 at 10:40 -0400, Farhan Ali wrote: > Virtio GPU code currently only supports litte endian format, > and so using the Virtio GPU device on a big endian machine > does not work. > > Let's fix it by supporting the correct host cpu byte order. > > Signed-off-by: Farhan Ali Reviewe

Re: [Qemu-devel] [PATCH v3 2/2] virtio-gpu-ccw: Create a virtio gpu device for the ccw bus

2017-09-18 Thread Gerd Hoffmann
Hi, > Gerd, if the first patch looks good to you, I can take both patches > through the s390 tree. Yes, please. Just sent a reviewed-by for patch #1. thanks, Gerd

Re: [Qemu-devel] [Qemu devel v9 PATCH 2/5] msf2: Microsemi Smartfusion2 System Register block

2017-09-18 Thread Peter Maydell
On 18 September 2017 at 11:17, sundeep subbaraya wrote: > Hi Philippe, > > On Mon, Sep 18, 2017 at 6:31 AM, Philippe Mathieu-Daudé > wrote: >> >> Hi Sundeep, Peter, >> >> >> On 09/15/2017 01:59 PM, Subbaraya Sundeep wrote: >>> >>> Added Sytem register block of Smartfusion2. >>> This block has PLL

Re: [Qemu-devel] [PATCH qemu v3 00/13] memory: Reduce memory use

2017-09-18 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH qemu v3 00/13] memory: Reduce memory use Message-id: 20170918101709.30421-1-...@ozlabs.ru Type: s

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Fri, Sep 15, 2017 at 04:17:07PM +0100, Dr. David Alan Gilbert wrote: > > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > > On Fri, Sep 15, 2017 at 01:29:13PM +0100, Daniel P. Berrange wrote: > > > > On Fri, Sep 15, 2017 at 01:19:56PM +0100, Dr. David Al

[Qemu-devel] [PATCH] softfloat: rename make_float[x80|128]_init to const_float[x80|128]

2017-09-18 Thread Laurent Vivier
We already have const_float16(), const_float32() and const_float64(), so rename make_floatx80_init() and make_float128_init() as const_floatx80() and const_float128(). Redefine make_floatx80() and make_float128() as make_float16(), make_float32() and make_float64() using a variable and not only a

Re: [Qemu-devel] [PATCH V5 01/10] specs/qcow2: add compress format extension

2017-09-18 Thread Kevin Wolf
Am 18.09.2017 um 12:09 hat Peter Lieven geschrieben: > Am 11.09.2017 um 16:22 schrieb Kevin Wolf: > > Am 25.07.2017 um 16:41 hat Peter Lieven geschrieben: > > > Signed-off-by: Peter Lieven > > > --- > > > docs/interop/qcow2.txt | 51 > > > +- > > >

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Mon, Sep 18, 2017 at 10:37 AM, Peter Xu wrote: > > On Fri, Sep 15, 2017 at 01:14:47PM +0200, Marc-André Lureau wrote: > >> Hi > >> > >> On Thu, Sep 14, 2017 at 9:46 PM, Peter Xu wrote: > >> > On Thu, Sep 14, 2017 at 07:53:15PM +

Re: [Qemu-devel] [PATCH] qom/cpu: move cpu_model null check to cpu_class_by_name()

2017-09-18 Thread Laurent Vivier
Le 18/09/2017 à 01:28, Philippe Mathieu-Daudé a écrit : > and clean every implementation. > > Suggested-by: Eduardo Habkost > Signed-off-by: Philippe Mathieu-Daudé > --- > Based-on: 20170917232010.14183-7-f4...@amsat.org Reviewed-by: Laurent Vivier

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Marc-André Lureau
Hi On Mon, Sep 18, 2017 at 12:55 PM, Dr. David Alan Gilbert wrote: > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: >> Hi >> >> On Mon, Sep 18, 2017 at 10:37 AM, Peter Xu wrote: >> > On Fri, Sep 15, 2017 at 01:14:47PM +0200, Marc-André Lureau wrote: >> >> Hi >> >> >> >> On Thu, Sep 14,

Re: [Qemu-devel] [PATCH v9 0/8] calculate blocktime for postcopy live migration

2017-09-18 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This is 9th version. > > The rationale for that idea is following: > vCPU could suspend during postcopy live migration until faulted > page is not copied into kernel. Downtime on source side it's a value - > time interval since source turn vCPU

[Qemu-devel] [PULL 2/2] audio: intel-hda: do not use old_mmio accesses

2017-09-18 Thread Gerd Hoffmann
From: Matt Parker intel-hda is currently using the old_mmio accessors for io. This updates the device to use .read and .write accessors instead. Signed-off-by: Matt Parker Message-id: 20170827192038.28930-1-mtpa...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/audio/intel-hda.c | 58 +

[Qemu-devel] [PULL 1/2] wm8750: add record buffer underrun check

2017-09-18 Thread Gerd Hoffmann
Reported-by: niuguoxi...@huawei.com Signed-off-by: Gerd Hoffmann Message-id: 20170901131409.6712-1-kra...@redhat.com --- hw/audio/wm8750.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/audio/wm8750.c b/hw/audio/wm8750.c index f8b5bebfc2..d2bf2e1da1 100644 --- a/hw/au

[Qemu-devel] [PULL 0/2] Audio 20170918 patches

2017-09-18 Thread Gerd Hoffmann
The following changes since commit f75637badd76ae0f3bd51a128e1a2da0d2bb1d6b: qemu.py: Fix syntax error (2017-09-18 11:32:22 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/audio-20170918-pull-request for you to fetch changes up to

Re: [Qemu-devel] [RFC 00/15] QMP: out-of-band (OOB) execution support

2017-09-18 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > Hi > > On Mon, Sep 18, 2017 at 12:55 PM, Dr. David Alan Gilbert > wrote: > > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > >> Hi > >> > >> On Mon, Sep 18, 2017 at 10:37 AM, Peter Xu wrote: > >> > On Fri, Sep 15, 2017 at 01:14:

Re: [Qemu-devel] [PATCH v8 10/13] Makefile: Add rules to run vm tests

2017-09-18 Thread Alex Bennée
Fam Zheng writes: > Signed-off-by: Fam Zheng Reviewed-by: Alex Bennée Tested-by: Alex Bennée > --- > Makefile | 2 ++ > configure | 2 +- > tests/vm/Makefile.include | 42 ++ > 3 files changed, 45 insertions(+), 1 d

Re: [Qemu-devel] [PULL 14/15] qemu.py: improve message on negative exit code

2017-09-18 Thread Eduardo Habkost
On Mon, Sep 18, 2017 at 10:44:00AM +0100, Daniel P. Berrange wrote: > On Fri, Sep 15, 2017 at 08:37:38PM -0300, Eduardo Habkost wrote: > > From: Amador Pahim > > > > The current message shows 'self._args', which contains only part of the > > options used in the Qemu command line. > > > > This pa

Re: [Qemu-devel] [PATCH 01/10] target/i386: Convert to disas_set_info hook

2017-09-18 Thread Alex Bennée
Richard Henderson writes: > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > disas.c | 22 ++ > monitor.c | 21 - > target/i386/cpu.c | 12 > target/i386/translate.c | 8 +--- > 4

Re: [Qemu-devel] [PATCH] qemu.py: Fix syntax error

2017-09-18 Thread Eduardo Habkost
On Mon, Sep 18, 2017 at 07:25:24AM +0200, Kevin Wolf wrote: > Python requires parentheses around multiline expression. This fixes the > breakage of all Python-based qemu-iotests cases that was introduced in > commit dab91d9aa0. > > Signed-off-by: Kevin Wolf > --- > > Eduardo, I think I'm going t

Re: [Qemu-devel] [PATCH 0/6] block: Fix permissions after ro/rw reopen

2017-09-18 Thread Fam Zheng
On Mon, 09/18 10:11, Kevin Wolf wrote: > > 2) Don't change the prototypes at all, just change .bdrv_reopen_prepare > > contract > > so that after it returns, .bdrv_child_perm/.bdrv_check_perm should comply > > to the > > new state that would be commited once .bdrv_reopen_commit() is called, or >

Re: [Qemu-devel] [PATCH 02/10] target/ppc: Convert to disas_set_info hook

2017-09-18 Thread Alex Bennée
Richard Henderson writes: > Cc: qemu-...@nongnu.org > Signed-off-by: Richard Henderson Reviewed-by: Alex Bennée > --- > disas.c | 33 - > monitor.c | 5 - > target/ppc/translate.c | 5 + > target/ppc/transl

  1   2   3   4   >