Re: [Qemu-devel] [PATCH for 2.10 v2 0/6] Various docker fixes

On Tue, 07/25 14:34, Alex Bennée wrote: > Hi, > > Phillipe pointed out a few anomalies with the travis.docker image > during review which has led to a couple more patches. As they are bug > fixes I didn't race to get a pull-req out today for hard-freeze. I > will roll a pull-req by the end of the

Re: [Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH

On 31.08.2017 08:38, Cornelia Huck wrote: > On Thu, 31 Aug 2017 07:51:17 +0200 > Thomas Huth wrote: > >> On 30.08.2017 18:36, Halil Pasic wrote: >>> The function ioinst_handle_xsch is presenting cc 2 when it's supposed to >>> present cc 1 and the other way around, because css_do_xsch has the erro

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

On Wed, Aug 30, 2017 at 03:07:38PM +0100, Daniel P. Berrange wrote: > On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez Del Real wrote: > > diff --git a/target/i386/hvf-utils/x86.c b/target/i386/hvf-utils/x86.c > > new file mode 100644 > > index 00..e3db2c9c8b > > --- /dev/null

Re: [Qemu-devel] [PATCH v2 11/17] MAINTAINERS: add missing entries for throttling infra

On Wed 30 Aug 2017 11:55:17 PM CEST, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > Reviewed-by: Stefan Hajnoczi Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH 3/9] s390x/css: be more consistent if broken beyond repair

On 31.08.2017 08:10, Thomas Huth wrote: > On 30.08.2017 18:36, Halil Pasic wrote: >> If we detect that the internally manged state of the subchannel >> is broken beyond repair while in do_subchannel_work in case of >> virtual we just abort the operation and pretend all went well, >> while in case o

Re: [Qemu-devel] [PATCH v2 1/7] block/ssh: don't call libssh2_init() in block_init()

On Wed, Aug 30, 2017 at 02:40:16PM -0500, Eric Blake wrote: > On 08/30/2017 11:56 AM, Jeff Cody wrote: > > We don't need libssh2 failure to be fatal (we could just opt to not > > register the driver on failure). But, it is probably a good idea to > > avoid external library calls during the block_i

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

On 30.08.2017 18:36, Halil Pasic wrote: > According to the POP a start subchannel instruction (SSCH) returning with > cc 1 implies that the subchannel was status pending when SSCH executed. > > Due to a somewhat confusing error handling, where error codes are mapped > to cc value, sane looking err

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez Del Real wrote: > This file begins tracking the files that will be the code base for HVF > support in QEMU. This code base is part of Google's QEMU version of > their Android emulator, and can be found at > https://android.googlesource.c

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

YANIV LAVI (YANIV DARY) SENIOR TECHNICAL PRODUCT MANAGER Red Hat Israel Ltd. 34 Jerusalem Road, Building A, 1st floor Ra'anana, Israel 4350109 yl...@redhat.comT: +972-9-7692306/8272306 F: +972-9-7692223IM: ylavi TRIED. TESTED. TRUSTED

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented cpu models

On 30.08.2017 15:24, Igor Mammedov wrote: > Remove cpu models that aren't implemented and are not > compiled/tested since they are under TODO ifdef > which isn't defined in sources. > > If someone really needs a removed model he/she should add > as regular one with corresponding implementation. >

Re: [Qemu-devel] [PATCH v2 04/13] hvf: run hvf code through checkpatch.pl and fix style issues

On Wed, Aug 30, 2017 at 03:26:53AM -0500, Sergio Andres Gomez Del Real wrote: > @@ -900,6 +904,9 @@ void cpu_synchronize_all_states(void) > > CPU_FOREACH(cpu) { > cpu_synchronize_state(cpu); > +if (hvf_enabled()) { > +hvf_cpu_synchronize_state(cpu); > +}

Re: [Qemu-devel] [PATCH v2 07/13] apic: add function to apic that will be used by hvf

On Wed, Aug 30, 2017 at 03:26:56AM -0500, Sergio Andres Gomez Del Real wrote: > This commit adds the function apic_get_highest_priority_irr to > apic.c and exports it through the interface in apic.h for use by hvf. > > Signed-off-by: Sergio Andres Gomez Del Real > --- > hw/intc/apic.c |

Re: [Qemu-devel] [PATCH v2 09/13] hvf: refactor cpuid code

On Wed, Aug 30, 2017 at 03:26:58AM -0500, Sergio Andres Gomez Del Real wrote: > @@ -613,6 +614,15 @@ static uint32_t xsave_area_size(uint64_t mask) > return ret; > } > > +static inline bool accel_uses_host_cpuid(void) > +{ > +if (kvm_enabled() || hvf_enabled()) { > +return true;

Re: [Qemu-devel] [PATCH v2 10/13] hvf: implement vga dirty page tracking

On Wed, Aug 30, 2017 at 03:26:59AM -0500, Sergio Andres Gomez Del Real wrote: > +static void hvf_log_start(MemoryListener *listener, > + MemoryRegionSection *section, int old, int new) > +{ > +if (old != 0) > +return; QEMU coding style uses curly braces even wh

[Qemu-devel] [PULL for-2.10 00/15] Block patches

The following changes since commit 248b23735645f7cbb503d9be6f5bf825f2a603ab: Update version for v2.10.0-rc4 release (2017-08-24 17:34:26 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to 3e4c705212abfe8c9

[Qemu-devel] [PULL for-2.10 01/15] nvme: Fix get/set number of queues feature, again

From: Dan Aloni The number of queues that should be return by the admin command should: 1) Only mention the number of non-admin queues. 2) It is zero-based, meaning that '0 == one non-admin queue', '1 == two non-admin queues', and so forth. Because our `num_queues` means the number of

[Qemu-devel] [PULL for-2.10 11/15] scripts: add argparse module for Python 2.6 compatibility

The minimum Python version supported by QEMU is 2.6. The argparse standard library module was only added in Python 2.7. Many scripts would like to use argparse because it supports command-line sub-commands. This patch adds argparse. See the top of argparse.py for details. Suggested-by: Daniel

[Qemu-devel] [PULL for-2.10 03/15] throttle: Update the throttle_fix_bucket() documentation

From: Alberto Garcia The way the throttling algorithm works is that requests start being throttled once the bucket level exceeds the burst limit. When we get there the bucket leaks at the level set by the user (bkt->avg), and that leak rate is what prevents guest I/O from exceeding the desired li

[Qemu-devel] [PULL for-2.10 02/15] throttle: Fix wrong variable name in the header documentation

From: Alberto Garcia The level of the burst bucket is stored in bkt.burst_level, not bkt.burst_length. Signed-off-by: Alberto Garcia Reviewed-by: Manos Pitsidianakis Message-id: 49aab2711d02f285567f3b3b13a113847af33812.1503580370.git.be...@igalia.com Signed-off-by: Stefan Hajnoczi --- inclu

[Qemu-devel] [PULL for-2.10 09/15] oslib-posix: Print errors before aborting on qemu_alloc_stack()

From: Eduardo Habkost If QEMU is running on a system that's out of memory and mmap() fails, QEMU aborts with no error message at all, making it hard to debug the reason for the failure. Add perror() calls that will print error information before aborting. Signed-off-by: Eduardo Habkost Reviewe

[Qemu-devel] [PULL for-2.10 04/15] throttle: Make throttle_is_valid() a bit less verbose

From: Alberto Garcia Use a pointer to the bucket instead of repeating cfg->buckets[i] all the time. This makes the code more concise and will help us expand the checks later and save a few line breaks. Signed-off-by: Alberto Garcia Message-id: 763ffc40a26b17d54cf93f5a999e4656049fcf0c.150358037

[Qemu-devel] [PULL for-2.10 06/15] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types

From: Alberto Garcia Both the throttling limits set with the throttling.iops-* and throttling.bps-* options and their QMP equivalents defined in the BlockIOThrottle struct are integer values. Those limits are also reported in the BlockDeviceInfo struct and they are integers there as well. There

[Qemu-devel] [PULL for-2.10 05/15] throttle: Remove throttle_fix_bucket() / throttle_unfix_bucket()

From: Alberto Garcia The throttling code can change internally the value of bkt->max if it hasn't been set by the user. The problem with this is that if we want to retrieve the original value we have to undo this change first. This is ugly and unnecessary: this patch removes the throttle_fix_buck

[Qemu-devel] [PULL for-2.10 14/15] qemu-doc: Add UUID support in initiator name

From: Fred Rolland Update doc with the usage of UUID for initiator name. Related-To: https://bugzilla.redhat.com/1006468 Signed-off-by: Fred Rolland Message-id: 20170823084830.30500-1-froll...@redhat.com Signed-off-by: Stefan Hajnoczi --- qemu-doc.texi | 5 +++-- 1 file changed, 3 insertions(

[Qemu-devel] [PULL for-2.10 08/15] throttle: Test the valid range of config values

From: Alberto Garcia Signed-off-by: Alberto Garcia Message-id: a57dd6274e1b6dc9c28769fec4c7ea543be5c5e3.1503580370.git.be...@igalia.com Signed-off-by: Stefan Hajnoczi --- tests/test-throttle.c | 77 +++ 1 file changed, 77 insertions(+) diff --g

[Qemu-devel] [PULL for-2.10 15/15] qcow2: allocate cluster_cache/cluster_data on demand

Most qcow2 files are uncompressed so it is wasteful to allocate (32 + 1) * cluster_size + 512 bytes upfront. Allocate s->cluster_cache and s->cluster_data when the first read operation is performance on a compressed cluster. The buffers are freed in .bdrv_close(). .bdrv_open() no longer has any

[Qemu-devel] [PULL for-2.10 07/15] throttle: Make burst_length 64bit and add range checks

From: Alberto Garcia LeakyBucket.burst_length is defined as an unsigned integer but the code never checks for overflows and it only makes sure that the value is not 0. In practice this means that the user can set something like throttling.iops-total-max-length=4294967300 despite being larger tha

[Qemu-devel] [PULL for-2.10 10/15] misc: Remove unused Error variables

From: Alberto Garcia There's a few cases which we're passing an Error pointer to a function only to discard it immediately afterwards without checking it. In these cases we can simply remove the variable and pass NULL instead. Signed-off-by: Alberto Garcia Reviewed-by: Philippe Mathieu-Daudé R

[Qemu-devel] [PULL for-2.10 13/15] tests: migration/guestperf Python 2.6 argparse compatibility

Add the scripts/ directory to sys.path so Python 2.6 will be able to import argparse. Cc: Daniel P. Berrange Signed-off-by: Stefan Hajnoczi Acked-by: John Snow Acked-by: Fam Zheng Message-id: 20170825155732.15665-4-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/migration/guestp

[Qemu-devel] [PULL for-2.10 12/15] docker.py: Python 2.6 argparse compatibility

Add the scripts/ directory to sys.path so Python 2.6 will be able to import argparse. Cc: Fam Zheng Signed-off-by: Stefan Hajnoczi Acked-by: John Snow Acked-by: Fam Zheng Message-id: 20170825155732.15665-3-stefa...@redhat.com Signed-off-by: Stefan Hajnoczi --- tests/docker/docker.py | 4 +++-

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented cpu models

On Thu, 31 Aug 2017 09:58:45 +0200 Thomas Huth wrote: > On 30.08.2017 15:24, Igor Mammedov wrote: > > Remove cpu models that aren't implemented and are not > > compiled/tested since they are under TODO ifdef > > which isn't defined in sources. > > > > If someone really needs a removed model he/s

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 8/8] ppc: remove non implemented cpu models

On 31.08.2017 10:35, Igor Mammedov wrote: > On Thu, 31 Aug 2017 09:58:45 +0200 > Thomas Huth wrote: > >> On 30.08.2017 15:24, Igor Mammedov wrote: >>> Remove cpu models that aren't implemented and are not >>> compiled/tested since they are under TODO ifdef >>> which isn't defined in sources. >>>

Re: [Qemu-devel] [PULL for-2.10 00/15] Block patches

Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170831082210.8362-1-stefa...@redhat.com Subject: [Qemu-devel] [PULL for-2.10 00/15] Block patches Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --one

Re: [Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH

On Thu, 31 Aug 2017 09:32:49 +0200 Thomas Huth wrote: > On 31.08.2017 08:38, Cornelia Huck wrote: > > On Thu, 31 Aug 2017 07:51:17 +0200 > > Thomas Huth wrote: > > > >> On 30.08.2017 18:36, Halil Pasic wrote: > >>> The function ioinst_handle_xsch is presenting cc 2 when it's supposed to > >

Re: [Qemu-devel] [PATCH v2 04/14] qlit: remove compound literals

Marc-André Lureau writes: > Hi > > - Original Message - >> Marc-André Lureau writes: >> >> > Hi >> > >> > - Original Message - >> >> Marc-André Lureau writes: >> >> >> >> > They are not considered constant expressions in C, producing an error >> >> > when compiling a const QLi

Re: [Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH

On 08/31/2017 07:51 AM, Thomas Huth wrote: > On 30.08.2017 18:36, Halil Pasic wrote: >> The function ioinst_handle_xsch is presenting cc 2 when it's supposed to >> present cc 1 and the other way around, because css_do_xsch has the error >> codes mixed up. Fixing the error codes also fixes the pri

Re: [Qemu-devel] [PATCH v1 04/11] s390x: get rid of s390-virtio.c

On 30.08.2017 19:05, David Hildenbrand wrote: > It is a leftover from the days where we had still the !ccw virtio > machine. As this one is long gone, let's move everything to > s390-virtio-ccw.c. > > Cornelia Huck > Signed-off-by: David Hildenbrand > --- [...] > diff --git a/hw/s390x/s390-virti

Re: [Qemu-devel] [RFC v2 0/8] monitor: allow per-monitor thread

On Thu, Aug 31, 2017 at 11:31:55AM +0800, Peter Xu wrote: > Before getting to an conclusion, just want to make sure we have got a > consensus on that at least we should start to move the monitor command > handling into a separate thread rather than main thread, am I correct? Certainly agree on tha

Re: [Qemu-devel] [PATCH v2 04/14] qlit: remove compound literals

Hi On Thu, Aug 31, 2017 at 10:43 AM Markus Armbruster wrote: > Marc-André Lureau writes: > > > Hi > > > > - Original Message - > >> Marc-André Lureau writes: > >> > >> > Hi > >> > > >> > - Original Message - > >> >> Marc-André Lureau writes: > >> >> > >> >> > They are not cons

Re: [Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH

On 31.08.2017 11:09, Halil Pasic wrote: > > > On 08/31/2017 07:51 AM, Thomas Huth wrote: >> On 30.08.2017 18:36, Halil Pasic wrote: >>> The function ioinst_handle_xsch is presenting cc 2 when it's supposed to >>> present cc 1 and the other way around, because css_do_xsch has the error >>> codes m

Re: [Qemu-devel] [PATCH] io: add new qio_channel_{readv, writev, read, write}_all functions

On Wed, Aug 30, 2017 at 02:34:59PM -0500, Eric Blake wrote: > On 08/30/2017 08:56 AM, Daniel P. Berrange wrote: > > These functions wait until they are able to read / write the full > > requested data buffer(s). > > > > Hmm, sounds like the NBD code would benefit from using this in a > followup p

Re: [Qemu-devel] [PATCH v2 11/13] hvf: move fields from CPUState to CPUX86State

On Wed, Aug 30, 2017 at 03:27:00AM -0500, Sergio Andres Gomez Del Real wrote: > @@ -1187,11 +1190,15 @@ typedef struct CPUX86State { > int32_t interrupt_injected; > uint8_t soft_interrupt; > uint8_t has_error_code; > +uint32_t ins_len; This field seems unused in this patch? > @

Re: [Qemu-devel] [PATCH v2 15/17] MAINTAINERS: add missing Cryptography entry

On Wed, Aug 30, 2017 at 06:55:21PM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 0b77590dc8..7a0c00550e 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @

Re: [Qemu-devel] [PATCH 2/9] s390x: fix invalid use of cc 1 for SSCH

On Wed, 30 Aug 2017 18:36:02 +0200 Halil Pasic wrote: > According to the POP a start subchannel instruction (SSCH) returning with > cc 1 implies that the subchannel was status pending when SSCH executed. > > Due to a somewhat confusing error handling, where error codes are mapped > to cc value,

Re: [Qemu-devel] [PATCH v1 05/11] s390x: rename s390-virtio.h to s390-virtio-hcall.h

On 30.08.2017 19:05, David Hildenbrand wrote: > The only interface left, so let's properly rename it. > > Signed-off-by: David Hildenbrand > --- > hw/s390x/s390-virtio-ccw.c | 2 +- > hw/s390x/s390-virtio-hcall.c| 2 +- > hw/s390x/{s390-virtio.h => s390-v

Re: [Qemu-devel] [PATCH v2 00/13] add support for Hypervisor.framework in QEMU

On Wed, Aug 30, 2017 at 03:26:49AM -0500, Sergio Andres Gomez Del Real wrote: > > Changes in v2: > (1) Removed legacy option "-enable-hvf" in favor of "-M accel=hvf" > (2) Added missing copyright headers; replace fprintfs for error_report; > improved commit description. > (

Re: [Qemu-devel] [PATCH 3/9] s390x/css: be more consistent if broken beyond repair

On Wed, 30 Aug 2017 18:36:03 +0200 Halil Pasic wrote: > If we detect that the internally manged state of the subchannel > is broken beyond repair while in do_subchannel_work in case of > virtual we just abort the operation and pretend all went well, > while in case of pass-through we honor the si

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

Hi On Thu, Aug 31, 2017 at 7:20 AM Thomas Huth wrote: > On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote: > > Suggested-by: Peter Maydell > > Signed-off-by: Philippe Mathieu-Daudé > > --- > > include/hw/char/serial.h | 1 + > > hw/char/serial.c | 13 + > > 2 files change

Re: [Qemu-devel] [PATCH v1 11/11] target/s390x: use program_interrupt() in per_check_exception()

On 30.08.2017 19:06, David Hildenbrand wrote: > I am not sure if we are handling ilen the right way here. ilen should > always match the instruction triggering the exception. This is relevant > for per exceptions triggered via EXECUTE instructions. The ilen to be > indicated has to match the EXECUT

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

On 31.08.2017 11:36, Marc-André Lureau wrote: > Hi > > On Thu, Aug 31, 2017 at 7:20 AM Thomas Huth > wrote: > > On 31.08.2017 05:53, Philippe Mathieu-Daudé wrote: > > Suggested-by: Peter Maydell > > > Signed-off-by: Phili

[Qemu-devel] [PATCH v2] io: add new qio_channel_{readv, writev, read, write}_all functions

These functions wait until they are able to read / write the full requested data buffer(s). Signed-off-by: Daniel P. Berrange --- Changed in v2: - Remove 'coroutine_fn' annotation (Stefan) - Fix docs typos (Eric) - Remove bogus error overwriting (Eric) include/io/channel.h | 90

Re: [Qemu-devel] [PATCH v7 07/11] qemu.py: include debug information on launch error

Dne 18.8.2017 v 19:05 Amador Pahim napsal(a): > When launching a VM, if an exception happens and the VM is not > initiated, it might be useful to see the qemu command line and > the qemu command output. > > This patch creates that message. Notice that self._iolog needs to be > cleaned up in the be

[Qemu-devel] [PATCH] io: fix typo in docs comment for qio_channel_read

Signed-off-by: Daniel P. Berrange --- include/io/channel.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/io/channel.h b/include/io/channel.h index db9bb022a1..54f3dc252f 100644 --- a/include/io/channel.h +++ b/include/io/channel.h @@ -299,7 +299,7 @@ ssize_t qio_chan

Re: [Qemu-devel] [PATCH 4/9] s390x: refactor error handling for SSCH and RSCH

On Wed, 30 Aug 2017 18:36:04 +0200 Halil Pasic wrote: > Simplify the error handling of the SSCH and RSCH handler avoiding > arbitrary and cryptic error codes being mapped to what a subchannel is > supposed to do. Let the code detecting the condition tell how it's to be > handled in a less ambigu

Re: [Qemu-devel] [PATCH 0/9]

On Wed, 30 Aug 2017 18:36:00 +0200 Halil Pasic wrote: > This series has a character of a refactoring, as the initial motivation > was improving readability and reducing complexity. But you reduced the cover letter subject too much ;) > > Despite of the original intent the tree first patches bu

Re: [Qemu-devel] [PULL 0/1] slirp updates

On 28 August 2017 at 00:05, Samuel Thibault wrote: > warning: redirection vers https://people.debian.org/~sthibault/qemu.git/ > The following changes since commit 04d74e07b4542aad5aa4ad03951b38b767f5314a: > > slirp: fix clearing ifq_so from pending packets (2017-08-26 01:04:12 +0200) > > are ava

Re: [Qemu-devel] [PATCH 1/9] s390x/css: fix cc handling for XSCH

On 08/31/2017 10:42 AM, Cornelia Huck wrote: > On Thu, 31 Aug 2017 09:32:49 +0200 > Thomas Huth wrote: > >> On 31.08.2017 08:38, Cornelia Huck wrote: >>> On Thu, 31 Aug 2017 07:51:17 +0200 >>> Thomas Huth wrote: >>> On 30.08.2017 18:36, Halil Pasic wrote: > The function ioinst_ha

Re: [Qemu-devel] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

On 29 August 2017 at 01:13, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.9.1: > > https://github.com/mdroth/qemu/commits/stable-2.9-staging > > The release is planned for 2017-09-07: > > http://wiki.qemu.org/Planning/2.9 > > Please respond here

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On 31 August 2017 at 07:35, Markus Armbruster wrote: > So, first we'll invest in work-arounds to make both 2 and 3 work. Once > 2 is gone, we can invest some more to clean them up. Which probably > won't happen, so we'll continue to carry work-arounds that no longer > make sense. > > I maintain

Re: [Qemu-devel] [PATCH 1/7] serial: add serial_chr_nonnull() to use the null backend when none provided

On 31 August 2017 at 04:53, Philippe Mathieu-Daudé wrote: > Suggested-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/char/serial.h | 1 + > hw/char/serial.c | 13 + > 2 files changed, 14 insertions(+) > > diff --git a/include/hw/char/serial.h b

[Qemu-devel] [PULL 00/29] Code cleanup patches

The following changes since commit 1201d308519f1e915866d7583d5136d03cc1d384: slirp: fix clearing ifq_so from pending packets (2017-08-30 23:14:34 +0100) are available in the git repository at: https://github.com/elmarco/qemu.git tags/tidy-pull-request for you to fetch changes up to e4d67e4f

[Qemu-devel] [PULL 01/29] i386: use ROUND_UP macro

I used the clang-tidy qemu-round check (with the option OnlyAlignUp) to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Juan Quintela Acked-by: Eduardo Habkost Reviewed-by: Richard Henderson --- target/i386/arch_dump.c | 16

Re: [Qemu-devel] [Qemu-discuss] Accessing a shared folder

Hello again, For the command     mount -t 9p -o trans=virtio Downloads /media/Downloads inside the Centos-7 guest, I get this error mount: unknown filesystem type '9p' Any thought? Regards, Mahmood

[Qemu-devel] [PULL 05/29] i8254: use QEMU_ALIGN_DOWN

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/timer/i8254_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[Qemu-devel] [PULL 02/29] vnc: use QEMU_ALIGN_DOWN

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- ui/vnc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ui/vnc.c b/ui/vnc.c index 651cbb8606.

[Qemu-devel] [PULL 04/29] vhost: use QEMU_ALIGN_DOWN

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Michael S. Tsirkin Reviewed-by: Richard Henderson --- hw/virtio/vhost.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/

[Qemu-devel] [PULL 07/29] dmg: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Hajnoczi Reviewed-by: Richard Henderson --- block/dmg.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/dmg.c

[Qemu-devel] [PULL 03/29] vhdx: use QEMU_ALIGN_DOWN

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Richard Henderson --- block/vhdx-log.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/vhdx-l

[Qemu-devel] [PULL 06/29] pcspk: use QEMU_ALIGN_DOWN

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- hw/audio/pcspk.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/audio/pcspk.c b/hw/audio/pcspk.c i

[Qemu-devel] [PULL 12/29] ui: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- ui/cursor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/cu

[Qemu-devel] [PULL 14/29] virtio-gpu: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/display/virtio-gpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[Qemu-devel] [PULL 10/29] vvfat: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Richard Henderson --- block/vvfat.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vvfat

[Qemu-devel] [PULL 08/29] qcow2: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Richard Henderson --- block/qcow2-cluster.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/q

[Qemu-devel] [PULL 15/29] monitor: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Acked-by: Dr. David Alan Gilbert Reviewed-by: Richard Henderson --- monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/monito

[Qemu-devel] [PULL 11/29] vnc: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- ui/vnc-enc-tight.c | 2 +- ui/vnc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/vn

[Qemu-devel] [PULL 19/29] q35: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- hw/pci-host/q35.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/pci-host/q35.c b/hw/pci-host/q35.

[Qemu-devel] [PULL 09/29] vpc: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Eric Blake Reviewed-by: Richard Henderson --- block/vpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/vpc.c b

[Qemu-devel] [PULL 17/29] virtio-serial: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Amit Shah --- hw/char/virtio-serial-bus.c | 8 1 file changed, 4 i

[Qemu-devel] [PULL 25/29] decnumber: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- libdecnumber/decNumber.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libdecnumber/decNumber.c b/li

[Qemu-devel] [PULL 18/29] piix: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/pci-host/piix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Qemu-devel] [PULL 13/29] vga: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Richard Henderson --- hw/display/vga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/display/vga.c b/hw/display/vga.c i

[Qemu-devel] [PULL 21/29] msix: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- hw/pci/msix.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[Qemu-devel] [PULL 22/29] ppc: use DIV_ROUND_UP

I used the clang-tidy qemu-round check to generate the fix: https://github.com/elmarco/clang-tools-extra Signed-off-by: Marc-André Lureau Acked-by: David Gibson Reviewed-by: Richard Henderson --- target/ppc/mem_helper.c | 2 +- target/ppc/translate.c | 2 +- 2 files changed, 2 insertions(+),

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Thu, Aug 31, 2017 at 11:27:15AM +0100, Peter Maydell wrote: > On 31 August 2017 at 07:35, Markus Armbruster wrote: > > So, first we'll invest in work-arounds to make both 2 and 3 work. Once > > 2 is gone, we can invest some more to clean them up. Which probably > > won't happen, so we'll cont

[Qemu-devel] [PULL 26/29] i386: introduce ELF_NOTE_SIZE macro

Factour out a common pattern to compute the ELF note size. Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Reviewed-by: Richard Henderson --- target/i386/arch_dump.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/target/i386/arch_dump.c

Re: [Qemu-devel] [PATCH 0/9]

On 08/31/2017 12:04 PM, Cornelia Huck wrote: > On Wed, 30 Aug 2017 18:36:00 +0200 > Halil Pasic wrote: > >> This series has a character of a refactoring, as the initial motivation >> was improving readability and reducing complexity. > > But you reduced the cover letter subject too much ;) No

[Qemu-devel] [PULL 28/29] test-iov: replace g_malloc()+memcpy() with g_memdup()

I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson --- tests/test-iov.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/test

Re: [Qemu-devel] [Qemu-discuss] Accessing a shared folder

On 31 August 2017 at 11:34, Mahmood via Qemu-devel wrote: > Hello again, > For the command > > mount -t 9p -o trans=virtio Downloads /media/Downloads > > inside the Centos-7 guest, I get this error > > mount: unknown filesystem type '9p' > > Any thought? That's an issue with your guest OS (pr

[Qemu-devel] [PULL 29/29] eepro100: replace g_malloc()+memcpy() with g_memdup()

I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau Reviewed-by: Stefan Weil Reviewed-by: Jason Wang Reviewed-by: Richard Henderson --- hw/net/eepro100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On Thu, Aug 31, 2017 at 11:55:18AM +0100, Peter Maydell wrote: > On 31 August 2017 at 11:47, Daniel P. Berrange wrote: > > If we can update to python 2.7 as our minimum, then supporting py2 > > and py3 gets simpler, avoiding some of the nastier hacks, even > > without that though it isn't too hard

[Qemu-devel] [PULL 27/29] i386: replace g_malloc()+memcpy() with g_memdup()

I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau Reviewed-by: Eduardo Habkost Reviewed-by: Richard Henderson --- hw/i386/multiboot.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/i386/multib

[Qemu-devel] [PATCH v2 2/4] block: use BDRV_SECTOR_SIZE in crypto driver

Signed-off-by: Daniel P. Berrange --- block/crypto.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/block/crypto.c b/block/crypto.c index cc8afe0e0d..e63f094379 100644 --- a/block/crypto.c +++ b/block/crypto.c @@ -392,16 +392,16 @@ block_cry

[Qemu-devel] [PATCH v2 1/4] block: use 1 MB bounce buffers for crypto instead of 16KB

Using 16KB bounce buffers creates a significant performance penalty for I/O to encrypted volumes on storage which high I/O latency (rotating rust & network drives), because it triggers lots of fairly small I/O operations. On tests with rotating rust, and cache=none|directsync, write speed increase

[Qemu-devel] [PATCH v2 4/4] block: convert qcrypto_block_encrypt|decrypt to take bytes offset

Instead of sector offset, take the bytes offset when encrypting or decrypting data. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 8 block/qcow.c | 7 +-- block/qcow2-cluster.c | 8 +++- block/qcow2.c | 4 ++-- crypto/block-luks.c| 12

Re: [Qemu-devel] [PATCH] scripts: Support building with Python 3

On 31 August 2017 at 11:47, Daniel P. Berrange wrote: > If we can update to python 2.7 as our minimum, then supporting py2 > and py3 gets simpler, avoiding some of the nastier hacks, even > without that though it isn't too hard. Unfortunately RHEL6 is what's holding us to retaining 2.6 support, a

[Qemu-devel] [PATCH v2 0/4] block: improve luks driver perf & switch to byte APIs

This series includes a previously posted patch that improves performance of the luks crypto driver: https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg00781.html And then adds three patches that switch over to use byte based APIs for I/O, rather than the legacy sector based APIs. Daniel

[Qemu-devel] [PATCH v2 3/4] block: convert crypto driver to bdrv_co_preadv|pwritev

Make the crypto driver implement the bdrv_co_preadv|pwritev callbacks, and also use bdrv_co_preadv|pwritev for I/O with the protocol driver beneath. Signed-off-by: Daniel P. Berrange --- block/crypto.c | 103 + 1 file changed, 53 insertion

[Qemu-devel] [PATCH v2 1/3] docker: Use unconfined security profile

Some by default blocked syscalls are required to run tests for example userfaultfd. Signed-off-by: Fam Zheng --- tests/docker/Makefile.include | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include index aaab1a4208..8ded838b20 100644 ---

[Qemu-devel] [PATCH v2 2/3] docker: Add nettle-devel to fedora image

The LUKS cases in qemu-iotests requires this. Signed-off-by: Fam Zheng --- tests/docker/dockerfiles/fedora.docker | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/docker/dockerfiles/fedora.docker b/tests/docker/dockerfiles/fedora.docker index 4eaa8ed2a5..27e8201c54 100644 --- a/tests/d

[Qemu-devel] [PATCH v2 3/3] docker: Add test-block

Signed-off-by: Fam Zheng --- tests/docker/test-block | 21 + 1 file changed, 21 insertions(+) create mode 100755 tests/docker/test-block diff --git a/tests/docker/test-block b/tests/docker/test-block new file mode 100755 index 00..20ef70538f --- /dev/null +++ b/tests

  1   2   3   >