[Qemu-devel] [Bug 1713408] [NEW] qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

2017-08-28 Thread R.Nageswara Sastry
Public bug reported: # ppc64-softmmu/qemu-system-ppc64 --nographic -vga none -machine pseries,accel=kvm,kvm-type=HV -m size=20g -device virtio-blk- pci,drive=rootdisk -drive file=/home/nasastry/avocado-fvt-wrapper/data /avocado- vt/images/pegas-1.0-ppc64le.qcow2,if=none,cache=none,id=rootdisk,form

[Qemu-devel] [Bug 1713408] Re: qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

2017-08-28 Thread R.Nageswara Sastry
3308 static const CPUArchIdList *spapr_possible_cpu_arch_ids(MachineState *machine) 3309 { 3310 int i; 3311 int spapr_max_cores = max_cpus / smp_threads; << max_cpus is -ve and spapr_max_cores will also be -ve ... 3321 3322 machine->possible_cpus = g_malloc0(sizeof(CPUArchIdLis

[Qemu-devel] [Bug 1713408] Re: qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

2017-08-28 Thread R.Nageswara Sastry
The above I am referring from hw/ppc/spapr.c -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1713408 Title: qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

Re: [Qemu-devel] S390 bios breaks in qemu 2.10.rc3

2017-08-28 Thread Christian Borntraeger
On 08/25/2017 10:29 AM, Cornelia Huck wrote: > On Fri, 25 Aug 2017 10:21:58 +0200 > Christian Borntraeger wrote: > >> On 08/25/2017 09:20 AM, Cornelia Huck wrote: > >>> OK, to recap: >>> >>> - the current pre-built bios seems fine >>> - rebuilding the bios may yield a version that fails on som

Re: [Qemu-devel] [PATCH v2] [WIP] [RFC ]Add initial 9pfs support for Windows hosts v2

2017-08-28 Thread Michael Fritscher
Good day, only a short announcement: Sorry for the very long delay :-( But I'm working on this again. The biggest issue seems to be the *at stuff. I'll try to workaround this via getting the directories' path from the file descriptor with the /proc (as it is already done in the 9pfs_utils) - lucki

Re: [Qemu-devel] [PATCHv4 01/03] qemu-iothread: IOThread supports theGMainContext event loop

2017-08-28 Thread wang.yong155
>Hi Wang Yong,>>To make the discussion easier, please try to fix your email >client to:>>1) set In-Reply-To: header when replying>2) use plain text instead >of html>3) use monospace fonts to view and compose a reply>4) avoid attaching >the original email in the end, just reply inline>5) maybe, u

[Qemu-devel] [PATCH 2/4] s390x/pci: remove idx from msix msg data

2017-08-28 Thread Yi Min Zhao
PCIDevcie pointer has been a parameter of kvm_arch_fixup_msi_route(). So we don't need to store zpci idx in msix message data to find out the specific zpci device. Instead, we could use pci device id to find its corresponding zpci device. Signed-off-by: Yi Min Zhao --- hw/s390x/s390-pci-bus.c |

[Qemu-devel] [PATCH 0/4] four zpci patches

2017-08-28 Thread Yi Min Zhao
This patch set contains four small zpci patches to fixup different issues. 1) fixup calculation of msix boundary 2) remove zpci idx from msix message, instead we could use PCIDevice's id to find zpci device in kvm_arch_fixup_msi_route() 3) fixup ind_offset calculation for adapter interrupt routi

[Qemu-devel] [PATCH 3/4] s390x/pci: fixup ind_offset of msix routing entry

2017-08-28 Thread Yi Min Zhao
The aibvo of zpci device should be constant after issued mpcifc registering irqs instruction. Each msix vector should offset from the aibvo. But for flic adapter interrupt, we should use the absolute offset within the aibv. So let's use the aibvo+vector to fixup msix routing entry. Signed-off-by:

[Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-28 Thread Yi Min Zhao
The function trap_msix() is to check if pcistg instruction would access msix table entries. The correct boundary condition should be [table_offset, table_offset+entries*entry_size). But the current condition calculated misses the last entry. So let's fixup it. Acked-by: Dong Jia Shi Reviewed-by:

[Qemu-devel] [PATCH 4/4] s390x/pci: add iommu replay callback

2017-08-28 Thread Yi Min Zhao
Let's introduce iommu replay callback for s390 pci iommu memory region. Currently we don't need any dma mapping replay. So let it return directly. This implementation will avoid meaningless loops calling translation callback. Reviewed-by: Pierre Morel Reviewed-by: Halil Pasic Signed-off-by: Yi M

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-28 Thread Peter Xu
On Fri, Aug 25, 2017 at 10:14:12AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Thu, Aug 24, 2017 at 07:37:32AM +0800, Fam Zheng wrote: > > > On Wed, 08/23 18:44, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > > > Introducing

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Cornelia Huck
On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali wrote: > On 08/25/2017 10:04 AM, Cornelia Huck wrote: > > On Fri, 25 Aug 2017 09:24:46 -0400 > > Farhan Ali wrote: > > > >> The commit 198c0d1f9df8c4 s390x/css: check ccw address validity > >> exposes an alignment issue in ccw bios. > >> > >> Accor

Re: [Qemu-devel] [RFC v2 4/8] QAPI: new QMP command option "without-bql"

2017-08-28 Thread Peter Xu
On Fri, Aug 25, 2017 at 10:06:27AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Wed, Aug 23, 2017 at 06:44:12PM +0100, Dr. David Alan Gilbert wrote: > > > > [...] > > > > > > +Most of the commands require the Big QEMU Lock (BQL) be held during > > > > +execu

[Qemu-devel] [PATCH 1/1] s390/mm: avoid empty zero pages for KVM guests to avoid postcopy hangs

2017-08-28 Thread Christian Borntraeger
Right now there is a potential hang situation for postcopy migrations, if the guest is enabling storage keys on the target system during the postcopy process. For storage key virtualization, we have to forbid the empty zero page as the storage key is a property of the physical page frame. As we e

[Qemu-devel] [PATCH 0/1] kernel fix for s390 postcopy hang

2017-08-28 Thread Christian Borntraeger
Andrea, David, here is a patch that fixes my postcopy hang (https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg04129.html) unless there are better ideas or complains, this will go via Martins tree. Christian Borntraeger (1): s390/mm: avoid empty zero pages for KVM guests to avoid postco

Re: [Qemu-devel] [RFC v2 8/8] migration: add incoming mgmt lock

2017-08-28 Thread Peter Xu
On Fri, Aug 25, 2017 at 10:34:56AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Wed, Aug 23, 2017 at 07:01:35PM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > Now at least migrate_incoming can be run in parallel. Let'

Re: [Qemu-devel] [PATCH 4/5] pci: Add INTERFACE_LEGACY_PCI_DEVICE to legacy PCI devices

2017-08-28 Thread Alberto Garcia
On Fri 25 Aug 2017 09:39:22 PM CEST, Eduardo Habkost wrote: > CCing maintainers of affected devices (sorry for not CCing you > before). >> diff --git a/hw/ipack/tpci200.c b/hw/ipack/tpci200.c >> index 4dfa6b3..e380378 100644 >> --- a/hw/ipack/tpci200.c >> +++ b/hw/ipack/tpci200.c >> @@ -646,6 +646

[Qemu-devel] [Bug 1713328] Re: Unable to C-a in -nographic if -serial telnet

2017-08-28 Thread Thomas Huth
Well, with your "-serial" setup, you've put the guest serial console on the telnet port, so there is nothing to switch on the host console here via the CTRL-a c key combination, i.e. this is the expected behavior. What exactly were you trying to do here? Access the serial console via two ways, one

Re: [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event

2017-08-28 Thread Peter Xu
On Fri, Aug 25, 2017 at 04:51:29PM +0100, Dr. David Alan Gilbert wrote: [...] > > PS, in migration_incoming_get_current() we do > > mis_current.state = MIGRATION_STATUS_NONE; > > memset(&mis_current, 0, sizeof(MigrationIncomingState)); > > > > and the first line there is pointles

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2] spapr: fallback to raw mode if best compat mode cannot be set during CAS

2017-08-28 Thread Greg Kurz
On Thu, 17 Aug 2017 13:23:50 +0200 Greg Kurz wrote: > KVM PR doesn't allow to set a compat mode. This causes ppc_set_compat_all() > to fail and we return H_HARDWARE to the guest right away. > > This is excessive: even if we favor compat mode since commit 152ef803ceb19, > we should at least fallb

Re: [Qemu-devel] [PATCH 1/2] migration: Reset rather than destroy main_thread_load_event

2017-08-28 Thread Peter Xu
On Fri, Aug 25, 2017 at 03:19:39PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > migration_incoming_state_destroy doesn't really destroy, it cleans up. > After a loadvm it's called, but the loadvm command can be run twice, > and so destroying an init-once mutex b

Re: [Qemu-devel] [PATCH 2/2] snapshot/tests: Try loadvm twice

2017-08-28 Thread Peter Xu
On Fri, Aug 25, 2017 at 03:19:40PM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > It's legal to loadvm twice, modify the existing save/loadvm test > to do it twice. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu (a question below though) > -

Re: [Qemu-devel] Qemu 2.10 rc4 build issue on BE (luigi burdo)

2017-08-28 Thread Igor Mammedov
On Mon, 28 Aug 2017 06:13:03 + luigi burdo wrote: > Hi, > > this is the log that was attached in my email. > > i will test only i386 softmmu when will return at home > > thanks > > Luigi > > > ./configure > --target-list=ppc64-softmmu,ppc-softmmu,x86_64-softmmu,arm-softmmu,i386-softmmu

Re: [Qemu-devel] Qemu 2.10 rc4 build issue on BE (luigi burdo)

2017-08-28 Thread luigi burdo
Hi Igor, below errors look like corrupted source files > i ust dowloaded the compressed file from qemu website,unzipped with tar from console (like i usually did) and run configure and make. can be the file of rc4 from qemu website not right and need a repack? Luigi

[Qemu-devel] [Bug 1713434] [NEW] prom-env-test test aborted and core dumped

2017-08-28 Thread R.Nageswara Sastry
Public bug reported: On ppc64le architecture machine the following test case Aborted and Core dumped. # tests/prom-env-test --quiet --keep-going -m=quick --GTestLogFD=6 ** ERROR:tests/libqtest.c:628:qtest_get_arch: assertion failed: (qemu != NULL) Aborted (core dumped) Steps to re-produce: clone

Re: [Qemu-devel] [Qemu-ppc] Qemu 2.10 rc4 build issue on BE

2017-08-28 Thread Thomas Huth
On 27.08.2017 18:56, luigi burdo wrote: > Hi all, > > the last rc4 from the qemu website fail in build in some parts on BE > hardware. > > attached on this email there is the configure and the build log hope it > helps > > > My machine is : PowerMac G5 Quad . > > Distro is Ferdora 25 PPC64. I

Re: [Qemu-devel] Qemu 2.10 rc4 build issue on BE (luigi burdo)

2017-08-28 Thread Igor Mammedov
On Mon, 28 Aug 2017 09:14:48 + luigi burdo wrote: > Hi Igor, > > > below errors look like corrupted source files > > > > > > i ust dowloaded the compressed file from qemu website,unzipped with tar from > console (like i usually did) and run configure and make. > > can be the file of

Re: [Qemu-devel] [PATCH v9 4/6] block: convert ThrottleGroup to object with QOM

2017-08-28 Thread Alberto Garcia
On Fri 25 Aug 2017 03:20:26 PM CEST, Manos Pitsidianakis wrote: > ThrottleGroup is converted to an object. This will allow the future > throttle block filter drive easy creation and configuration of throttle > groups in QMP and cli. Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH] slirp: fix clearing ifq_so from pending packets

2017-08-28 Thread P J P
Hello Samuel, +-- On Sat, 26 Aug 2017, Samuel Thibault wrote --+ | So Wjjzhang and PJP, can you confirm that this fixes your uses? Yes, I confirm the patch fixes the use-after-free issue. Thank you so much. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-28 Thread Thomas Huth
When running tests directly, you've got to specify the QEMU binary like this: QTEST_QEMU_BINARY=ppc64-softmmu/qemu-system-ppc64 tests/prom-env-test --quiet --keep-going -m=quick But the abort() is indeed ugly here and I think we should print out a user-friendly error message instead. ** Changed

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-08-28 Thread Marc-André Lureau
Hi On Mon, Aug 28, 2017 at 5:05 AM, Peter Xu wrote: > On Fri, Aug 25, 2017 at 04:07:34PM +, Marc-André Lureau wrote: >> On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert >> wrote: >> >> > * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: >> > > Hi >> > > >> > > On Wed, Aug 23, 201

[Qemu-devel] [PATCH v15 0/5] Virtio-balloon Enhancement

2017-08-28 Thread Wei Wang
This patch series enhances the existing virtio-balloon with the following new features: 1) fast ballooning: transfer ballooned pages between the guest and host in chunks using sgs, instead of one by one; and 2) free page block reporting: a new virtqueue to report guest free pages to the host. The

[Qemu-devel] [PATCH v15 1/5] lib/xbitmap: Introduce xbitmap

2017-08-28 Thread Wei Wang
From: Matthew Wilcox The eXtensible Bitmap is a sparse bitmap representation which is efficient for set bits which tend to cluster. It supports up to 'unsigned long' worth of bits, and this commit adds the bare bones -- xb_set_bit(), xb_clear_bit() and xb_test_bit(). Signed-off-by: Matthew Wilc

[Qemu-devel] [PATCH v15 2/5] lib/xbitmap: add xb_find_next_bit() and xb_zero()

2017-08-28 Thread Wei Wang
xb_find_next_bit() is used to find the next "1" or "0" bit in the given range. xb_zero() is used to zero the given range of bits. Signed-off-by: Wei Wang Cc: Andrew Morton Cc: Matthew Wilcox Cc: Michal Hocko Cc: Michael S. Tsirkin --- include/linux/xbitmap.h | 3 +++ lib/xbitmap.c

[Qemu-devel] [PATCH v15 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-08-28 Thread Wei Wang
Add a new feature, VIRTIO_BALLOON_F_SG, which enables the transfer of balloon (i.e. inflated/deflated) pages using scatter-gather lists to the host. The implementation of the previous virtio-balloon is not very efficient, because the balloon pages are transferred to the host one by one. Here is th

[Qemu-devel] [PATCH v15 5/5] virtio-balloon: VIRTIO_BALLOON_F_CTRL_VQ

2017-08-28 Thread Wei Wang
Add a new vq, ctrl_vq, to handle commands between the host and guest. With this feature, we will be able to have the control plane and data plane separated. In other words, the control related data of each feature will be sent via the ctrl_vq cmds, meanwhile each feature may have its own data plane

[Qemu-devel] [PATCH v15 4/5] mm: support reporting free page blocks

2017-08-28 Thread Wei Wang
This patch adds support to walk through the free page blocks in the system and report them via a callback function. Some page blocks may leave the free list after zone->lock is released, so it is the caller's responsibility to either detect or prevent the use of such pages. One use example of this

Re: [Qemu-devel] [PATCH] vga: stop passing pointers to vga_draw_line* functions

2017-08-28 Thread P J P
+-- On Fri, 25 Aug 2017, Gerd Hoffmann wrote --+ | > Do we have the actual number? | Not yet, pjp still busy getting one, but will be filled for the final | version of the patch. CVE-2017-13672. -> https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg04684.html CVE-2017-13673. -> https://l

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-28 Thread R.Nageswara Sastry
The actual failure was the following LINKtests/test-hmp GTESTER check-qtest-ppc64 ** ERROR:tests/prom-env-test.c:42:check_guest_memory: assertion failed (signature == MAGIC): (0x7c7f1b78 == 0xcafec0de) GTester: last random seed: R02Sfb567618f7c703a032934c0c11e263c6 make: *** [check-qtest-

[Qemu-devel] [PATCH] tests/libqtest: Use a proper error message if QTEST_QEMU_BINARY is missing

2017-08-28 Thread Thomas Huth
The user can currently still cause an abort() if running certain tests (like the prom-env-test) without setting the QTEST_QEMU_BINARY first. A similar problem has been fixed with commit 7c933ad61b8f3f51337 already, but forgot to also take care of the qtest_get_arch() function, so let's introduce a

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-28 Thread Thomas Huth
The "ERROR:tests/prom-env-test.c:42:check_guest_memory" error is a timeout error... is it reproducible? Was the host you're testing on very loaded at that point in time? -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.lau

Re: [Qemu-devel] [PATCH v2 01/54] qapi: fix type_seen key error

2017-08-28 Thread Markus Armbruster
Marc-André Lureau writes: > On Fri, Aug 25, 2017 at 2:57 PM Eduardo Habkost wrote: > >> On Fri, Aug 25, 2017 at 08:02:26AM +0200, Markus Armbruster wrote: >> > Conflicts with Eduardo's "[PATCH v2] qapi: Fix error handling code on >> > alternate conflict". >> > Message-Id: <20170717180926.14924-1

Re: [Qemu-devel] [PATCH 0/3] iotests: clean up resources using context managers

2017-08-28 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Fri, Aug 25, 2017 at 03:32:29PM +0800, Fam Zheng wrote: >> On Thu, 08/24 19:04, Stefan Hajnoczi wrote: >> > On Thu, Aug 24, 2017 at 04:38:43PM +0800, Fam Zheng wrote: >> > > On Thu, 08/24 08:21, Stefan Hajnoczi wrote: >> > > > Tests should declare resources upfront in

[Qemu-devel] [Bug 1713408] Re: qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

2017-08-28 Thread R.Nageswara Sastry
** Patch added: "0001-cpu-don-t-allow-negative-max_cpus.patch" https://bugs.launchpad.net/qemu/+bug/1713408/+attachment/4940056/+files/0001-cpu-don-t-allow-negative-max_cpus.patch -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. ht

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-08-28 Thread Markus Armbruster
Marc-André Lureau writes: > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert > wrote: > >> * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: >> > Hi >> > >> > On Wed, Aug 23, 2017 at 8:52 AM Peter Xu wrote: >> > >> > > Firstly, introduce Monitor.use_thread, and set it for monitors t

Re: [Qemu-devel] Qemu 2.10 rc4 build issue on BE (luigi burdo)

2017-08-28 Thread luigi burdo
Ok igor, i will download and build again and report Luigi Da: Igor Mammedov Inviato: lunedì 28 agosto 2017 11:32 A: luigi burdo Cc: Programmingkid; qemu-...@nongnu.org; qemu-devel@nongnu.org qemu-devel Oggetto: Re: [Qemu-devel] Qemu 2.10 rc4 build issue on BE (

Re: [Qemu-devel] [Qemu-ppc] Qemu 2.10 rc4 build issue on BE

2017-08-28 Thread luigi burdo
Hi Thomas, i will check again and report. Luigi In your log there is: But if you have a look at the freshly unpacked sources, that line clearly reads "goto out;" and not "gCto out;" ... so it looks like something messed up your sources very badly. Can you reproduce this problem when starting

Re: [Qemu-devel] [PATCH 04/14] qlit: remove needless type cast

2017-08-28 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Fri, Aug 25, 2017 at 8:20 AM Markus Armbruster wrote: > >> Marc-André Lureau writes: >> >> > And misc code style fix. >> > >> > Signed-off-by: Marc-André Lureau >> > --- >> > include/qapi/qmp/qlit.h | 8 >> > 1 file changed, 4 insertions(+), 4 de

Re: [Qemu-devel] [PATCH v2 06/16] qapi-schema: Collect char device stuff in qapi/char.json

2017-08-28 Thread Markus Armbruster
Marc-André Lureau writes: > On Thu, Aug 24, 2017 at 9:24 PM Markus Armbruster wrote: > >> Cc: Paolo Bonzini >> Cc: Marc-André Lureau >> Signed-off-by: Markus Armbruster >> > > Reviewed-by: Marc-André Lureau [...] >> diff --git a/qapi/event.json b/qapi/event.json >> index 9c6126d..b9aa6ed 100

Re: [Qemu-devel] [PATCH v2 09/16] qapi-schema: Collect migration stuff in qapi/migration.json

2017-08-28 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Cc: Juan Quintela >> Cc: Dr. David Alan Gilbert >> Signed-off-by: Markus Armbruster > > > Two thoughts: > a) Do you actually want that as migration/migration.json? I'd prefer to keep the QAPI schema togethe

Re: [Qemu-devel] [PATCH 00/47] add missing entries in MAINTAINERS

2017-08-28 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > Hi, > > I first prepared this series thinking about 2.10 but then realized if someone > is calling ./scripts/get_maintainer.pl he better is using an updated git > clone :) > > Distribs do provide docs/ files in /usr/share/doc/qemu* but not the > MAINTAINERS file s

Re: [Qemu-devel] [PATCH v2 11/16] qapi-schema: Collect TPM stuff in qapi/tpm.json

2017-08-28 Thread Markus Armbruster
Marc-André Lureau writes: > On Thu, Aug 24, 2017 at 9:23 PM Markus Armbruster wrote: > >> Sadly, we don't have a TPM maintainer, not even a MAINTAINERS entry. >> Create one, and mark it orphaned. >> >> > This is also proposed in: > http://patchew.org/QEMU/20170728053610.15770-1-f4...@amsat.org/

[Qemu-devel] [PATCH] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-28 Thread Kashyap Chamarthy
This is the follow-up patch that was discussed[*] as part of feedback to qemu-iotest 194. Changes in this patch: - Supply 'job-id' parameter to `drive-mirror` invocation. - Issue `block-job-cancel` command on the source QEMU to gracefully complete the mirroring operation. - Stop the N

Re: [Qemu-devel] [PATCH v2 15/16] qapi-schema: Move queries from common.json to qapi-schema.json

2017-08-28 Thread Markus Armbruster
Marc-André Lureau writes: > Hi > > On Thu, Aug 24, 2017 at 9:20 PM Markus Armbruster wrote: > >> query-version and query-commands are in common.json for no good >> reason. Several similar queries are in qapi-schema.json. Move them >> there. > > I suppose it was initially meant to be shared wit

[Qemu-devel] [PATCH] tests: fix incorrect size_t format in benchmark-crypto

2017-08-28 Thread Philippe Mathieu-Daudé
$ make check-speed tests/benchmark-crypto-hash.c: In function 'test_hash_speed': tests/benchmark-crypto-hash.c:44:5: error: format '%ld' expects argument of type 'long int', but argument 2 has type 'size_t' [-Werror=format=] g_print("Testing chunk_size %ld bytes ", chunk_size);

Re: [Qemu-devel] [PATCH v3 1/7] block: skip implicit nodes in snapshots, blockjobs

2017-08-28 Thread Alberto Garcia
On Fri 25 Aug 2017 03:23:26 PM CEST, Manos Pitsidianakis wrote: > +static inline BlockDriverState *child_bs(BlockDriverState *bs) > +{ > +BlockDriverState *backing = backing_bs(bs); > +BlockDriverState *file = file_bs(bs); > +assert(!(file && backing)); > +return backing ?: file; >

Re: [Qemu-devel] [PATCH v3 3/7] block: require job-id when device is a node name

2017-08-28 Thread Alberto Garcia
On Fri 25 Aug 2017 03:23:28 PM CEST, Manos Pitsidianakis wrote: > With implicit filter nodes on the top of the graph it is not possible > to generate job-ids with the name of the device in block_job_create() > anymore, since the job's bs will not be a child_root. Reviewed-by: Alberto Garcia Bert

[Qemu-devel] [Bug 1713408] Re: qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

2017-08-28 Thread Thomas Huth
Please don't add patches to the bug tracker, post them to the qemu-devel (and qemu-ppc in this case) mailing list instead. You even don't have to join the mailing lists if you don't like to, posting to them is allowed for everybody. See https://www.qemu.org/contribute/report-a-bug/ and http://wiki.

[Qemu-devel] [Bug 1713408] Re: qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

2017-08-28 Thread Thomas Huth
Looking at your patch, I think you should also check for "<= 0" instead of just "< 0" ... since maxcpus = 0 also does not make much sense. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1713408 Title:

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-08-28 Thread Marc-André Lureau
Hi On Mon, Aug 28, 2017 at 1:08 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert < > dgilb...@redhat.com> > > wrote: > > > >> * Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > >> > Hi > >> > > >> > On Wed, Aug 23, 2017

[Qemu-devel] [PATCH v2] vga: stop passing pointers to vga_draw_line* functions

2017-08-28 Thread Gerd Hoffmann
Instead pass around the address (aka offset into vga memory). Add vga_read_* helper functions which apply vbe_size_mask to the address, to make sure the address stays within the valid range, similar to the cirrus blitter fixes (commits ffaf857778 and 026aeffcb4). Impact: DoS for privileged guest

[Qemu-devel] [PATCH v2] vga: fix display update region calculation (split screen)

2017-08-28 Thread Gerd Hoffmann
vga display update mis-calculated the region for the dirty bitmap snapshot in case split screen mode is used. This can trigger an assert in cpu_physical_memory_snapshot_get_dirty(). Impact: DoS for privileged guest users. Fixes: CVE-2017-13673 Fixes: fec5e8c92becad223df9d972770522f64aafdb72 Cc:

Re: [Qemu-devel] [PATCH v3 4/7] block: remove legacy I/O throttling

2017-08-28 Thread Alberto Garcia
On Fri 25 Aug 2017 03:23:29 PM CEST, Manos Pitsidianakis wrote: > This commit removes all I/O throttling from block/block-backend.c. In > order to support the existing interface, it is changed to use the > block/throttle.c filter driver. > > The throttle filter node that is created by the legacy in

[Qemu-devel] [PATCH v2 3/3] qxl_unpack_chunks: codestyle fixups

2017-08-28 Thread Gerd Hoffmann
--- hw/display/qxl-render.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index b2c98f90c0..90e0865618 100644 --- a/hw/display/qxl-render.c +++ b/hw/display/qxl-render.c @@ -215,14 +215,17 @@ static void qxl_unpack_ch

[Qemu-devel] [PATCH v2 2/3] qxl: add support for chunked cursors.

2017-08-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/qxl-render.c | 33 ++--- 1 file changed, 26 insertions(+), 7 deletions(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index e1b3f05ecb..b2c98f90c0 100644 --- a/hw/display/qxl-render.c +++ b/hw/display/qxl-

[Qemu-devel] [PATCH v2 0/3] qxl: add support for chunked cursors.

2017-08-28 Thread Gerd Hoffmann
This series adds support for unpacking qxl chunks, and uses it to support chunked cursor images. Windows guest drivers seem to use that when in HiDPI mode. Also drop (broken) support for mono cursors. [ v2: codestyle fixes ] Gerd Hoffmann (3): qxl: drop mono cursor support qxl: add support

[Qemu-devel] [PATCH v2 1/3] qxl: drop mono cursor support

2017-08-28 Thread Gerd Hoffmann
The chunk size sanity check in qxl_render_cursor works for SPICE_CURSOR_TYPE_ALPHA cursors only. So support for SPICE_CURSOR_TYPE_MONO cursors must be broken for ages without anyone noticing. Most likely it simply isn't used any more by guest drivers. Drop the dead code. Signed-off-by: Gerd Hoff

[Qemu-devel] [PATCH v3 1/2] qxl: drop mono cursor support

2017-08-28 Thread Gerd Hoffmann
The chunk size sanity check in qxl_render_cursor works for SPICE_CURSOR_TYPE_ALPHA cursors only. So support for SPICE_CURSOR_TYPE_MONO cursors must be broken for ages without anyone noticing. Most likely it simply isn't used any more by guest drivers. Drop the dead code. Signed-off-by: Gerd Hoff

[Qemu-devel] [PATCH v3 2/2] qxl: add support for chunked cursors.

2017-08-28 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/qxl-render.c | 36 +--- 1 file changed, 29 insertions(+), 7 deletions(-) diff --git a/hw/display/qxl-render.c b/hw/display/qxl-render.c index e1b3f05ecb..90e0865618 100644 --- a/hw/display/qxl-render.c +++ b/hw/display/q

[Qemu-devel] [PATCH v3 0/2] qxl: add support for chunked cursors.

2017-08-28 Thread Gerd Hoffmann
This series adds support for unpacking qxl chunks, and uses it to support chunked cursor images. Windows guest drivers seem to use that when in HiDPI mode. Also drop (broken) support for mono cursors. [ v2: codestyle fixes ] [ v3: actually squash the codestyle fixes ... ] Gerd Hoffmann (2): q

Re: [Qemu-devel] [RFC v2 2/8] monitor: allow monitor to create thread to poll

2017-08-28 Thread Peter Xu
On Mon, Aug 28, 2017 at 12:11:38PM +0200, Marc-André Lureau wrote: > Hi > > On Mon, Aug 28, 2017 at 5:05 AM, Peter Xu wrote: > > On Fri, Aug 25, 2017 at 04:07:34PM +, Marc-André Lureau wrote: > >> On Fri, Aug 25, 2017 at 5:33 PM Dr. David Alan Gilbert > >> > >> wrote: > >> > >> > * Marc-And

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 04:22 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali wrote: On 08/25/2017 10:04 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 09:24:46 -0400 Farhan Ali wrote: The commit 198c0d1f9df8c4 s390x/css: check ccw address validity exposes an alignment issue i

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Cornelia Huck
On Mon, 28 Aug 2017 08:56:42 -0400 Farhan Ali wrote: > On 08/28/2017 04:22 AM, Cornelia Huck wrote: > > On Fri, 25 Aug 2017 11:05:30 -0400 > > Farhan Ali wrote: > > > >> On 08/25/2017 10:04 AM, Cornelia Huck wrote: > >>> On Fri, 25 Aug 2017 09:24:46 -0400 > >>> Farhan Ali wrote: > >>> > >

[Qemu-devel] [PATCH v2] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Seeteena Thoufeek
---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the following command with maxcpus argument as negative number ppc64-softmmu/qemu-system-ppc64 --nographic -vga none -machine pseries,accel=kvm,kvm-type=HV -m size=200g -device virtio

Re: [Qemu-devel] [PATCH v2] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v2] qemu crashes when a negative number used for 'maxcpus' Message-id: 1503924917-12687-1-git-send-email-s1see...@linux.vnet.ibm.com === TEST SCRIPT BEGIN =

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 09:06 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 08:56:42 -0400 Farhan Ali wrote: On 08/28/2017 04:22 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali wrote: On 08/25/2017 10:04 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 09:24:46 -0400 Farhan Ali

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Christian Borntraeger
On 08/28/2017 03:18 PM, Farhan Ali wrote: > > > On 08/28/2017 09:06 AM, Cornelia Huck wrote: >> On Mon, 28 Aug 2017 08:56:42 -0400 >> Farhan Ali wrote: >> >>> On 08/28/2017 04:22 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali wrote: > On 08/25/2017

Re: [Qemu-devel] [PATCH v15 4/5] mm: support reporting free page blocks

2017-08-28 Thread Michal Hocko
On Mon 28-08-17 18:08:32, Wei Wang wrote: > This patch adds support to walk through the free page blocks in the > system and report them via a callback function. Some page blocks may > leave the free list after zone->lock is released, so it is the caller's > responsibility to either detect or preve

Re: [Qemu-devel] [PATCH 3/5] pci: Add INTERFACE_PCIE_DEVICE to all PCIe devices

2017-08-28 Thread Eduardo Habkost
On Sun, Aug 27, 2017 at 11:35:56AM +0300, Marcel Apfelbaum wrote: > Hi Eduardo, > > On 24/08/2017 1:14, Eduardo Habkost wrote: > > Change all devices that set is_express=1 to implement > > INTERFACE_PCIE_DEVICE. > > > > Can this interface *replace* is_express field? It can, but it has to be don

Re: [Qemu-devel] [PATCH] tests: fix incorrect size_t format in benchmark-crypto

2017-08-28 Thread Marc-André Lureau
On Mon, Aug 28, 2017 at 1:38 PM Philippe Mathieu-Daudé wrote: > $ make check-speed > tests/benchmark-crypto-hash.c: In function 'test_hash_speed': > tests/benchmark-crypto-hash.c:44:5: error: format '%ld' expects argument > of type 'long int', but argument 2 has type 'size_t' [-Werror=forma

[Qemu-devel] [Bug 1713408] Re: qemu crashes with "GLib-ERROR **: gmem.c" error when a negative value passed to "maxcpus"

2017-08-28 Thread R.Nageswara Sastry
Sure will do the changes and update. Seems one of my colleague did it already (sent patch to devel list) https://lists.nongnu.org/archive/html/qemu-devel/2017-08/msg05345.html I will pass your review comments to her for modification. Thanks for your review. -- You received this bug notification

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-28 Thread R.Nageswara Sastry
Host was not loaded at that time. And can be re-producable all the times GTESTER check-qtest-ppc64 ** ERROR:tests/prom-env-test.c:42:check_guest_memory: assertion failed (signature == MAGIC): (0x7c7f1b78 == 0xcafec0de) GTester: last random seed: R02S5625099e4ad7700238a4e83dbd6576e0 this is wit

Re: [Qemu-devel] [PATCH v3 5/7] block/throttle-groups.c: remove throttle-groups list

2017-08-28 Thread Alberto Garcia
On Fri 25 Aug 2017 03:23:30 PM CEST, Manos Pitsidianakis wrote: > @@ -1957,12 +1957,18 @@ void blk_io_limits_enable(BlockBackend *blk, const > char *group, Error **errp) > BlockDriverState *bs = blk_bs(blk), *throttle_node; > QDict *options = qdict_new(); > Error *local_err = NULL;

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 09:24 AM, Christian Borntraeger wrote: On 08/28/2017 03:18 PM, Farhan Ali wrote: On 08/28/2017 09:06 AM, Cornelia Huck wrote: On Mon, 28 Aug 2017 08:56:42 -0400 Farhan Ali wrote: On 08/28/2017 04:22 AM, Cornelia Huck wrote: On Fri, 25 Aug 2017 11:05:30 -0400 Farhan Ali

[Qemu-devel] [PATCH v3] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Seeteena Thoufeek
---Steps to Reproduce--- When passed a negative number to 'maxcpus' parameter, Qemu aborts with a core dump. Run the following command with maxcpus argument as negative number ppc64-softmmu/qemu-system-ppc64 --nographic -vga none -machine pseries,accel=kvm,kvm-type=HV -m size=200g -device virtio

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Cornelia Huck
On Mon, 28 Aug 2017 09:52:08 -0400 Farhan Ali wrote: > On 08/28/2017 09:24 AM, Christian Borntraeger wrote: > > > > > > > > On 08/28/2017 03:18 PM, Farhan Ali wrote: > >> > >> > >> On 08/28/2017 09:06 AM, Cornelia Huck wrote: > >>> On Mon, 28 Aug 2017 08:56:42 -0400 > >>> Farhan Ali wrote: >

Re: [Qemu-devel] [PATCH v15 4/5] mm: support reporting free page blocks

2017-08-28 Thread Michal Hocko
On Mon 28-08-17 15:33:26, Michal Hocko wrote: > On Mon 28-08-17 18:08:32, Wei Wang wrote: > > This patch adds support to walk through the free page blocks in the > > system and report them via a callback function. Some page blocks may > > leave the free list after zone->lock is released, so it is t

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 10:05 AM, Cornelia Huck wrote: It's the alignment of the CCW which causes the problem. The exact error message when starting the guest was: ! No virtio device found ! Since it worked for SCSI and CDL, and failed for LDL disks on that particular system, we are not really sure w

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Halil Pasic
On 08/28/2017 04:15 PM, Farhan Ali wrote: > > > On 08/28/2017 10:05 AM, Cornelia Huck wrote: > It's the alignment of the CCW which causes the problem. > > The exact error message when starting the guest was: > > ! No virtio device found ! > > Since it worked for SCSI

[Qemu-devel] [Bug 1713434] Re: prom-env-test test aborted and core dumped

2017-08-28 Thread Thomas Huth
That works for me - no problems with tests/prom-env-test on a POWER8 little endian system here. What host system are you using? Could you also check what happens if you run QEMU directly like this, and post the console output here: ppc64-softmmu/qemu-system-ppc64 -nographic -M pseries,accel=tcg -n

Re: [Qemu-devel] [PATCH v3] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Fam Zheng
Hi Seeteena, thanks for sending the patch and fixing the coding style! I suggest to change subject to "vl: exit if maxcpus is negative". The subject of a patch email is going to be the summary of the commit message when applied, therefore it should be worded to summarize the change. Commonly there

Re: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1

2017-08-28 Thread Farhan Ali
On 08/28/2017 10:19 AM, Halil Pasic wrote: On 08/28/2017 04:15 PM, Farhan Ali wrote: On 08/28/2017 10:05 AM, Cornelia Huck wrote: It's the alignment of the CCW which causes the problem. The exact error message when starting the guest was: ! No virtio device found ! Since it worked for

[Qemu-devel] How to best handle the reoccurring of rom changes breaking cross version migrations?

2017-08-28 Thread Christian Ehrhardt
Hi, migration issues due to rom changes seem to occur over and over in past years [1], [2],[3],[4],[5]. >From the past I know several workarounds (like just truncating to the bigger size) but all have various deficiencies. But OTOH rom's will always change due to fixes in them. And recently I foun

Re: [Qemu-devel] [PATCH v3] qemu crashes when a negative number used for 'maxcpus'

2017-08-28 Thread Bharata B Rao
Seeteena, On Mon, Aug 28, 2017 at 7:23 PM, Seeteena Thoufeek < s1see...@linux.vnet.ibm.com> wrote: > ---Steps to Reproduce--- > > When passed a negative number to 'maxcpus' parameter, Qemu aborts > with a core dump. > > Run the following command with maxcpus argument as negative number > > ppc64-

[Qemu-devel] [PATCH] tpm: lookup cancel path under tpm device class

2017-08-28 Thread Marc-André Lureau
Since Linux 4.0 (commit 313d21eeab9282e), tpm devices have their own device class "tpm" and the cancel path must be looked up under /sys/class/tpm/ instead of /sys/class/misc/. Signed-off-by: Marc-André Lureau --- hw/tpm/tpm_passthrough.c | 36 ++-- 1 file changed

Re: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile

2017-08-28 Thread Cédric Le Goater
On 08/23/2017 01:53 PM, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Compiler gets confused with the size of the struct, so move form >> g_new0() to g_malloc0(). >> >> I *think* that the problem is in gcc (or glib for that matter), but >> the documentation of the

Re: [Qemu-devel] [PATCH 1/4] s390x/pci: fixup trap_msix()

2017-08-28 Thread Cornelia Huck
On Mon, 28 Aug 2017 10:04:44 +0200 Yi Min Zhao wrote: > The function trap_msix() is to check if pcistg instruction would access > msix table entries. The correct boundary condition should be > [table_offset, table_offset+entries*entry_size). But the current > condition calculated misses the last

Re: [Qemu-devel] [PATCH] qemu-iotests: Extend non-shared storage migration test (194)

2017-08-28 Thread Eric Blake
On 08/28/2017 06:29 AM, Kashyap Chamarthy wrote: > This is the follow-up patch that was discussed[*] as part of feedback to > qemu-iotest 194. > > Changes in this patch: > > - Supply 'job-id' parameter to `drive-mirror` invocation. > > - Issue `block-job-cancel` command on the source QEMU to

[Qemu-devel] GSOC Report: Moving I/O throttling and write notifiers into block filter drivers

2017-08-28 Thread Manos Pitsidianakis
This is a GSOC project summary required for the project's final submission. As part of GSOC 2017, I took the project of moving two hard coded block layer features into filter drivers. I/O Throttling is implemented in block/throttle.c and before write notifiers are split into a driver for each u

  1   2   3   4   >