Re: [Qemu-devel] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 06:49, Fam Zheng wrote: >> + * Persistent reservation manager that talks to qemu-mpath-helper > s/qemu-mpath-helper/qemu-pr-helper/ Oops, you got a glimpse into the history of the patches. :) (it was first designed for multipath only, then decided that generic PR support would be bo

Re: [Qemu-devel] [PATCH 07/10] io: add qio_channel_read/write_all

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 07:08, Fam Zheng wrote: > On Tue, 08/22 15:18, Paolo Bonzini wrote: >> It is pretty common to read a fixed-size buffer from a socket. Add a >> function that does this, either with multiple reads (on blocking sockets) >> or by yielding if called from a coroutine. >> >> Cc: Daniel P. B

Re: [Qemu-devel] [PATCH 06/10] scsi, file-posix: add support for persistent reservation management

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 06:13, Fam Zheng wrote: > On Tue, 08/22 15:18, Paolo Bonzini wrote: >> diff --git a/docs/pr-manager.rst b/docs/pr-manager.rst > > Is docs/interop/persistent-reservation-manager.rst better? (Move to interop/ > and > de-abbreviate) ... > >> new file mode 100644 >> index 00..b

Re: [Qemu-devel] [PATCH for-2.10] boot-serial-test: prefer tcg accelerator

2017-08-23 Thread Cornelia Huck
On Wed, 23 Aug 2017 10:29:07 +1000 David Gibson wrote: > On Tue, Aug 22, 2017 at 01:48:15PM +0200, Cornelia Huck wrote: > > On Tue, 22 Aug 2017 21:20:46 +1000 > > David Gibson wrote: > > > > > Obviously it's not a thing to fix right now, but I've really been > > > thinking that none of the te

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread Christian Ehrhardt
On Wed, Aug 23, 2017 at 8:53 AM, Christian Borntraeger < borntrae...@de.ibm.com> wrote: > KVM guests on s390 need a different page table layout than normal > processes (2kb page table + 2kb page status extensions vs 2kb page table > only). As of today this has to be enabled via the vm.allocate_pgs

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread Thomas Huth
On 23.08.2017 08:55, Christian Borntraeger wrote: > > > On 08/23/2017 08:53 AM, Christian Borntraeger wrote: >> KVM guests on s390 need a different page table layout than normal >> processes (2kb page table + 2kb page status extensions vs 2kb page table >> only). As of today this has to be enable

Re: [Qemu-devel] [PATCH 10/10] scsi: add persistent reservation manager using qemu-pr-helper

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 06:49, Fam Zheng wrote: >> + >> +/* A simple feature negotation protocol, even though there is >> + * no optional feature right now. >> + */ >> +if (pr_manager_helper_read(pr_mgr, &flags, sizeof(flags), errp) < 0) { > Not returning the return value of pr_manager_helper

[Qemu-devel] make check speed (was: Re: [PATCH for-2.10] boot-serial-test: prefer tcg accelerator)

2017-08-23 Thread Thomas Huth
On 23.08.2017 09:16, Cornelia Huck wrote: > On Wed, 23 Aug 2017 10:29:07 +1000 > David Gibson wrote: > >> On Tue, Aug 22, 2017 at 01:48:15PM +0200, Cornelia Huck wrote: >>> On Tue, 22 Aug 2017 21:20:46 +1000 >>> David Gibson wrote: >>> Obviously it's not a thing to fix right now, but I'v

[Qemu-devel] 答复: Re: [PATCHv4 01/03] qemu-iothread: IOThread supports theGMainContext event loop

2017-08-23 Thread wang.yong155
>> diff --git a/iothread.c b/iothread.c>> index beeb870..fb1c55b 100644>> --- >> a/iothread.c>> +++ b/iothread.c>> @@ -57,6 +57,20 @@ static void >> *iothread_run(void *opaque)>> >> while >> (!atomic_read(&iothread->stopping)) {>> aio_poll(iothread->ctx, >> true)>> +>> +i

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread David Hildenbrand
On 23.08.2017 08:53, Christian Borntraeger wrote: > KVM guests on s390 need a different page table layout than normal > processes (2kb page table + 2kb page status extensions vs 2kb page table > only). As of today this has to be enabled via the vm.allocate_pgste > sysctl. > > Newer kernels (>= 4.1

Re: [Qemu-devel] [PATCH v2 06/54] qapi: introduce qapi_enum_lookup()

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > This will help with the introduction of a new structure to handle > enum lookup. > > Signed-off-by: Marc-André Lureau > --- [...] > 45 files changed, 206 insertions(+), 122 deletions(-) Hmm. > diff --git a/include/qapi/util.h b/include/qapi/util.h > index 7436ed815

Re: [Qemu-devel] make check speed

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 09:49, Thomas Huth wrote: > While we're at it: I'd like to have a "make check-fast", too. Sometimes > the normal "make check" is already too slow, e.g. while developing new > patches, I sometimes just want to do a very quick sanity test to see > whether I broke some basic things or no

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread Thomas Huth
On 23.08.2017 10:00, David Hildenbrand wrote: > On 23.08.2017 08:53, Christian Borntraeger wrote: >> KVM guests on s390 need a different page table layout than normal >> processes (2kb page table + 2kb page status extensions vs 2kb page table >> only). As of today this has to be enabled via the vm.

[Qemu-devel] [Bug 1711602] Re: --copy-storage-all failing with qemu 2.10

2017-08-23 Thread Dr. David Alan Gilbert
OK, yeh that's the same symptom I saw - it's that final failure that causes bdrv_inactivate_all to return a failure and fail the source migration. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1711602

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 10:06, Thomas Huth wrote: > On 23.08.2017 10:00, David Hildenbrand wrote: >> On 23.08.2017 08:53, Christian Borntraeger wrote: >>> KVM guests on s390 need a different page table layout than normal >>> processes (2kb page table + 2kb page status extensions vs 2kb page table >>> only).

Re: [Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

2017-08-23 Thread Igor Mammedov
On Tue, 22 Aug 2017 18:43:43 -0300 Philippe Mathieu-Daudé wrote: > 9e047b982452 "piix4: add acpi pci hotplug support" introduced a new property > 'use_acpi_pci_hotplug' for pc-1.7 and older machines. > c24d5e0b91d1 "convert ACPI PCI hotplug to use hotplug-handler API" added the > qbus hotplug han

Re: [Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

2017-08-23 Thread Igor Mammedov
On Wed, 23 Aug 2017 08:04:06 +0200 Thomas Huth wrote: > On 23.08.2017 07:40, Thomas Huth wrote: > > On 23.08.2017 02:10, Philippe Mathieu-Daudé wrote: > >> On 08/22/2017 07:42 PM, Michael S. Tsirkin wrote: > >>> On Tue, Aug 22, 2017 at 06:43:43PM -0300, Philippe Mathieu-Daudé wrote: >

Re: [Qemu-devel] make check speed

2017-08-23 Thread Thomas Huth
On 23.08.2017 10:01, Paolo Bonzini wrote: > On 23/08/2017 09:49, Thomas Huth wrote: >> While we're at it: I'd like to have a "make check-fast", too. Sometimes >> the normal "make check" is already too slow, e.g. while developing new >> patches, I sometimes just want to do a very quick sanity test t

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread Cornelia Huck
On Wed, 23 Aug 2017 10:16:27 +0200 Paolo Bonzini wrote: > On 23/08/2017 10:06, Thomas Huth wrote: > > On 23.08.2017 10:00, David Hildenbrand wrote: > >> On 23.08.2017 08:53, Christian Borntraeger wrote: > >>> @@ -6522,6 +6527,20 @@ if test "$target_linux_user" = "yes" -o > >>> "$target_bsd_

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-23 Thread Igor Mammedov
On Tue, 22 Aug 2017 11:24:10 +0800 Dou Liyang wrote: > As QEMU supports the memory-less node, it is possible that there is > no RAM in the first numa node(also be called as node0). eg: > ... \ > -m 128,slots=3,maxmem=1G \ > -numa node -numa node,mem=128M \ > > But, this makes it hard for Q

Re: [Qemu-devel] 答复: Re: [PATCHv4 01/03] qemu-iothread: IOThread supports theGMainContext event loop

2017-08-23 Thread Fam Zheng
Hi Wang Yong, To make the discussion easier, please try to fix your email client to: 1) set In-Reply-To: header when replying 2) use plain text instead of html 3) use monospace fonts to view and compose a reply 4) avoid attaching the original email in the end, just reply inline 5) maybe, use "Re:

[Qemu-devel] [PATCH 2/2] tests: Make acpid test compile

2017-08-23 Thread Juan Quintela
Compiler gets confused with the size of the struct, so move form g_new0() to g_malloc0(). I *think* that the problem is in gcc (or glib for that matter), but the documentation of the g_new0 states that 1sts first argument is an struct type, and uint32_t is not an struct type. Signed-off-by: Juan

[Qemu-devel] [PATCH 0/2] Fix tests on recent gcc

2017-08-23 Thread Juan Quintela
Hi On Fedora 26 (gcc-7.1.1 and glib2 2.52.3) tests don't compile. In file included from /usr/include/string.h:639:0, from /mnt/kvm/qemu/cleanup/include/qemu/osdep.h:69, from /mnt/kvm/qemu/cleanup/tests/test-iov.c:1: In function ‘memcpy’, inlined from ‘iov_fro

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread Christian Borntraeger
On 08/23/2017 09:28 AM, Christian Ehrhardt wrote: > > > On Wed, Aug 23, 2017 at 8:53 AM, Christian Borntraeger > mailto:borntrae...@de.ibm.com>> wrote: > > KVM guests on s390 need a different page table layout than normal > processes (2kb page table + 2kb page status extensions vs 2kb

[Qemu-devel] [PATCH 1/2] tests: Use real size for iov tests

2017-08-23 Thread Juan Quintela
We were using -1 instead of the real size because the functions check what is bigger, size in bytes or the size of the iov. Recent gcc's barf at this. Signed-off-by: Juan Quintela --- tests/test-iov.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-iov.c b

Re: [Qemu-devel] [PATCH v3 4/5] target/ppc: Handle NMI guest exit

2017-08-23 Thread David Gibson
On Mon, Aug 21, 2017 at 06:00:52PM +0530, Aravinda Prasad wrote: > > > On Thursday 17 August 2017 07:27 AM, David Gibson wrote: > > On Wed, Aug 16, 2017 at 02:42:39PM +0530, Aravinda Prasad wrote: > >> Memory error such as bit flips that cannot be corrected > >> by hardware are passed on to the k

[Qemu-devel] [PATCH] MAINTAINERS: Update mail address for COLO Proxy

2017-08-23 Thread Zhang Chen
My Fujitsu mail account will be disabled soon, update the mail info to my private mail. Signed-off-by: Zhang Chen --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ccee28b..3b530a7 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -15

Re: [Qemu-devel] make check speed

2017-08-23 Thread Fam Zheng
On Wed, 08/23 10:35, Thomas Huth wrote: > Is it safe nowadays to run "make check -j4" for example? Last time I > tried (maybe 1 or 2 years ago), there were still issues since some tests > were using hard-coded temporary file names, so the parallel tests were > disturbing each other, for example...

Re: [Qemu-devel] [PATCH v7 6/6] qemu-iotests: add 184 for throttle filter driver

2017-08-23 Thread Alberto Garcia
On Tue 22 Aug 2017 12:15:35 PM CEST, Manos Pitsidianakis wrote: > Signed-off-by: Manos Pitsidianakis Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] Persistent bitmaps for non-qcow2 formats

2017-08-23 Thread Vladimir Sementsov-Ogievskiy
22.08.2017 22:07, John Snow wrote: Well, we knew we'd want this sooner or later. I've got some pings downstream over whether or not we support persistent bitmaps for non-qcow2 formats. Currently: no, we don't. We tried two different ideas for storage agnostic bitmap persistence: (1) Using qco

Re: [Qemu-devel] [PATCH v2 07/54] tpm: simplify driver registration & lookup

2017-08-23 Thread Markus Armbruster
Note: cc'ing the code's author. Marc-André Lureau writes: > Make be_drivers[n] match order of TpmType enum. > > Use qapi_enum_parse() in tpm_get_backend_driver. > > Signed-off-by: Marc-André Lureau > --- > include/sysemu/tpm_backend.h | 2 +- > tpm.c| 42 --

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread Christian Borntraeger
On 08/23/2017 10:39 AM, Cornelia Huck wrote: > On Wed, 23 Aug 2017 10:16:27 +0200 > Paolo Bonzini wrote: > >> On 23/08/2017 10:06, Thomas Huth wrote: >>> On 23.08.2017 10:00, David Hildenbrand wrote: On 23.08.2017 08:53, Christian Borntraeger wrote: > > @@ -6522,6 +6527,20 @@ if t

Re: [Qemu-devel] [PATCH 11/15] ppc: Add 460EX embedded CPU

2017-08-23 Thread BALATON Zoltan
On Wed, 23 Aug 2017, David Gibson wrote: On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: Despite its name it is a 440 core CPU As I recall 460 was supposed to be a 440 with SMP support. Except they screwed up the cache coherence, so it's basically unusable for SMP (at least wi

Re: [Qemu-devel] make check speed

2017-08-23 Thread Fam Zheng
On Wed, 08/23 16:52, Fam Zheng wrote: > On Wed, 08/23 10:35, Thomas Huth wrote: > > Is it safe nowadays to run "make check -j4" for example? Last time I > > tried (maybe 1 or 2 years ago), there were still issues since some tests > > were using hard-coded temporary file names, so the parallel tests

Re: [Qemu-devel] [PATCH 1/2 v3] xenfb: Use Input Handlers directly

2017-08-23 Thread Owen Smith
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 22 August 2017 00:12 > To: Owen Smith > Cc: qemu-devel@nongnu.org; xen-de...@lists.xenproject.org; > sstabell...@kernel.org; Anthony Perard > Subject: Re: [PATCH 1/2 v3] xenfb: Use Input Handlers direc

Re: [Qemu-devel] [PATCH v2] configure: enable --s390-pgste linker option

2017-08-23 Thread Cornelia Huck
On Wed, 23 Aug 2017 11:05:59 +0200 Christian Borntraeger wrote: > On 08/23/2017 10:39 AM, Cornelia Huck wrote: > > On Wed, 23 Aug 2017 10:16:27 +0200 > > Paolo Bonzini wrote: > > > >> On 23/08/2017 10:06, Thomas Huth wrote: > >>> On 23.08.2017 10:00, David Hildenbrand wrote: > On 2

Re: [Qemu-devel] make check speed

2017-08-23 Thread Paolo Bonzini
On 23/08/2017 10:35, Thomas Huth wrote: >> If you have a many-core machine, of course, there's no simpler solution >> than throwing more CPUs at it. :) > Is it safe nowadays to run "make check -j4" for example? Last time I > tried (maybe 1 or 2 years ago), there were still issues since some tests >

Re: [Qemu-devel] [PATCH v2 08/54] hmp: use qapi_enum_parse() in hmp_migrate_set_capability

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > hmp.c | 24 +++- > 1 file changed, 11 insertions(+), 13 deletions(-) > > diff --git a/hmp.c b/hmp.c > index 29e42ab661..4ba50e8e26 100644 > --- a/hmp.c > +++ b/hmp.c > @@ -1544,23 +1544,21 @@ void hmp_migra

Re: [Qemu-devel] [PATCH v2 09/54] hmp: use qapi_enum_parse() in hmp_migrate_set_parameter

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > hmp.c | 139 > -- > 1 file changed, 68 insertions(+), 71 deletions(-) > > diff --git a/hmp.c b/hmp.c > index 4ba50e8e26..ccc58e6d88 100644 > --- a/hmp.c > +++ b/

Re: [Qemu-devel] [PATCH v4 09/10] s390x/kvm: msi route fixup for non-pci

2017-08-23 Thread Cornelia Huck
On Mon, 21 Aug 2017 17:30:58 +0200 Halil Pasic wrote: > On 08/21/2017 05:17 PM, Thomas Huth wrote: > > On 21.08.2017 17:10, Halil Pasic wrote: > > [...] > >> The situation is just complicated by the fact that there is code which > >> relies on assert(true) asserting for correctness (e.g. virtio

Re: [Qemu-devel] [PATCH v2 10/54] block: use qemu_enum_parse() in blkdebug_debug_breakpoint

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > This slightly change the error report message from "Invalid event > name" to "Invalid parameter". Actually from qemu-system-x86_64: LOCATION: Invalid event name "VALUE" to qemu-system-x86_64: LOCATION: invalid parameter value: VALUE Let's get that exactly

Re: [Qemu-devel] [PATCH v2 06/54] qapi: introduce qapi_enum_lookup()

2017-08-23 Thread Marc-André Lureau
Hi - Original Message - > Marc-André Lureau writes: > > > This will help with the introduction of a new structure to handle > > enum lookup. > > > > Signed-off-by: Marc-André Lureau > > --- > [...] > > 45 files changed, 206 insertions(+), 122 deletions(-) > > Hmm. > > > diff --git a/

Re: [Qemu-devel] [PATCH 13/15] ppc4xx: Add more PLB registers

2017-08-23 Thread BALATON Zoltan
On Wed, 23 Aug 2017, David Gibson wrote: On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: These registers are present in 440 SoCs (and maybe in others too) and U-Boot accesses them when printing register info. We don't emulate these but add them to avoid crashing when they are rea

[Qemu-devel] [PATCH v3] configure: enable --s390-pgste linker option

2017-08-23 Thread Christian Borntraeger
KVM guests on s390 need a different page table layout than normal processes (2kb page table + 2kb page status extensions vs 2kb page table only). As of today this has to be enabled via the vm.allocate_pgste sysctl. Newer kernels (>= 4.12) on s390 check for an S390_PGSTE program header and enable t

Re: [Qemu-devel] [PATCH v2 53/54] qapi: make query-cpu-model-expansion depend on s390 or x86

2017-08-23 Thread Marc-André Lureau
Hi - Original Message - > On Tue, Aug 22, 2017 at 03:22:54PM +0200, Marc-André Lureau wrote: > > Signed-off-by: Marc-André Lureau > > --- > > qapi-schema.json | 4 +++- > > include/sysemu/arch_init.h | 3 --- > > monitor.c

Re: [Qemu-devel] [PATCH v4 02/10] kvm: remove hard dependency on pci

2017-08-23 Thread Pierre Morel
On 22/08/2017 11:04, Cornelia Huck wrote: On Mon, 21 Aug 2017 18:02:12 +0200 Pierre Morel wrote: On 21/08/2017 11:16, Cornelia Huck wrote: The msi routing code in kvm calls some pci functions: provide some stubs to enable builds without pci. Also, to make this more obvious, guard them via a

Re: [Qemu-devel] Why I got "timeout" while using qga socket to connect VM?

2017-08-23 Thread Sameeh Jubran
Hi Sam, >From the command line I assume that you are running CentOS-7-x86_64, did you install the guest agent on the VM? Can you see that it is running? What do you mean by blocked? On Wed, Aug 23, 2017 at 5:34 AM, Sam wrote: > Hi all, > > I start VM using command like this: > > -chardev socke

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-23 Thread BALATON Zoltan
On Wed, 23 Aug 2017, David Gibson wrote: On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. This is not a full implementation yet with a lot of components still missing but enough to start a Linux kernel and the

Re: [Qemu-devel] [PATCH v2 11/54] quorum: use qapi_enum_parse() in quorum_open

2017-08-23 Thread Markus Armbruster
Alberto Garcia writes: > On Tue 22 Aug 2017 03:22:12 PM CEST, Marc-André Lureau wrote: > >> @@ -925,7 +908,13 @@ static int quorum_open(BlockDriverState *bs, QDict >> *options, int flags, >> goto exit; >> } >> >> -ret = parse_read_pattern(qemu_opt_get(opts, QUORUM_OPT_READ_PA

Re: [Qemu-devel] [PATCH 1/2] tests: Use real size for iov tests

2017-08-23 Thread Peter Xu
On Wed, Aug 23, 2017 at 10:39:00AM +0200, Juan Quintela wrote: > We were using -1 instead of the real size because the functions check > what is bigger, size in bytes or the size of the iov. Recent gcc's > barf at this. > > Signed-off-by: Juan Quintela > --- > tests/test-iov.c | 8 > 1

Re: [Qemu-devel] [PULL 0/7] ppc-for-2.10 queue 20170823

2017-08-23 Thread Peter Maydell
qemu.git tags/ppc-for-2.10-20170823 > > for you to fetch changes up to 1f98e55385d11da1dc0de6440e66f19d191d2a1b: > > hw/ppc/spapr_iommu: Fix crash when removing the "spapr-tce-table" device > (2017-08-22 21:26:46 +1000) > > -

Re: [Qemu-devel] [PATCH v2 11/54] quorum: use qapi_enum_parse() in quorum_open

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > block/quorum.c | 27 --- > 1 file changed, 8 insertions(+), 19 deletions(-) > > diff --git a/block/quorum.c b/block/quorum.c > index d04da4f430..e4271caa7a 100644 > --- a/block/quorum.c > +++ b/block/qu

[Qemu-devel] KVM call for agenda for 2017-08-29

2017-08-23 Thread Juan Quintela
Hi Please, send any topic that you are interested in covering. At the end of Monday I will send an email with the agenda or the cancellation of the call, so hurry up. After discussions on the QEMU Summit, we are going to have always open a KVM call where you can add topics. Call details: By

Re: [Qemu-devel] [PATCH 1/2] tests: Use real size for iov tests

2017-08-23 Thread Juan Quintela
Peter Xu wrote: > On Wed, Aug 23, 2017 at 10:39:00AM +0200, Juan Quintela wrote: >> We were using -1 instead of the real size because the functions check >> what is bigger, size in bytes or the size of the iov. Recent gcc's >> barf at this. >> >> Signed-off-by: Juan Quintela >> --- >> tests/te

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-23 Thread François Revol
Le 23/08/2017 à 13:12, BALATON Zoltan a écrit : >> What's the connection with mips_malta? > > The board's firmware wants to see SPD EEPROMs of the connected memory > while initialising the memory controller. This is why we need to > implement SDRAM controller, I2C and SPD EEPROMs. MIPS malta board

Re: [Qemu-devel] [PATCH 2/2] tests: Make acpid test compile

2017-08-23 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Compiler gets confused with the size of the struct, so move form > g_new0() to g_malloc0(). > > I *think* that the problem is in gcc (or glib for that matter), but > the documentation of the g_new0 states that 1sts first argument is an > struct type,

Re: [Qemu-devel] [PATCH v2 11/54] quorum: use qapi_enum_parse() in quorum_open

2017-08-23 Thread Alberto Garcia
On Wed 23 Aug 2017 01:24:09 PM CEST, Markus Armbruster wrote: >> static int quorum_open(BlockDriverState *bs, QDict *options, int flags, >> Error **errp) >> { >> @@ -925,7 +908,13 @@ static int quorum_open(BlockDriverState *bs, QDict >> *options, int flags, >> go

Re: [Qemu-devel] make check speed

2017-08-23 Thread Lukáš Doktor
Dne 23.8.2017 v 10:35 Thomas Huth napsal(a): > On 23.08.2017 10:01, Paolo Bonzini wrote: >> On 23/08/2017 09:49, Thomas Huth wrote: >>> While we're at it: I'd like to have a "make check-fast", too. Sometimes >>> the normal "make check" is already too slow, e.g. while developing new >>> patches, I s

Re: [Qemu-devel] make check speed

2017-08-23 Thread Thomas Huth
On 23.08.2017 13:51, Lukáš Doktor wrote: > Dne 23.8.2017 v 10:35 Thomas Huth napsal(a): >> On 23.08.2017 10:01, Paolo Bonzini wrote: >>> On 23/08/2017 09:49, Thomas Huth wrote: While we're at it: I'd like to have a "make check-fast", too. Sometimes the normal "make check" is already too s

Re: [Qemu-devel] [PATCH v2 12/54] qapi: change enum lookup structure

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > Store the length in the lookup table, i.e. change it from > const char *const[] to struct { int n, const char *const s[] }. > > The following conditional enum entry change will create "hole" > elements in the generated lookup array, that should be skipped. The commit

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-23 Thread Dou Liyang
Hi Igor, At 08/23/2017 04:40 PM, Igor Mammedov wrote: On Tue, 22 Aug 2017 11:24:10 +0800 Dou Liyang wrote: As QEMU supports the memory-less node, it is possible that there is no RAM in the first numa node(also be called as node0). eg: ... \ -m 128,slots=3,maxmem=1G \ -numa node -numa no

Re: [Qemu-devel] make check speed

2017-08-23 Thread Lukáš Doktor
Dne 23.8.2017 v 14:01 Thomas Huth napsal(a): > On 23.08.2017 13:51, Lukáš Doktor wrote: >> Dne 23.8.2017 v 10:35 Thomas Huth napsal(a): >>> On 23.08.2017 10:01, Paolo Bonzini wrote: On 23/08/2017 09:49, Thomas Huth wrote: > While we're at it: I'd like to have a "make check-fast", too. Some

Re: [Qemu-devel] [PATCH for-2.10???] fix build failure in nbd_read_reply_entry()

2017-08-23 Thread Peter Maydell
On 17 August 2017 at 17:14, Igor Mammedov wrote: > travis builds fail at HEAD at rc3 master with > > block/nbd-client.c: In function ‘nbd_read_reply_entry’: > block/nbd-client.c:110:8: error: ‘ret’ may be used uninitialized in this > function [-Werror=uninitialized] > > fix it by initializing

Re: [Qemu-devel] make check speed

2017-08-23 Thread Cornelia Huck
On Wed, 23 Aug 2017 10:35:43 +0200 Thomas Huth wrote: > True. And I just learned that you can also already set the SPEED > variable to either "quick" or "slow" and that we're already using > g_test_quick() and g_test_slow() in a couple of places to check this. So > the framework for running quick

Re: [Qemu-devel] [PATCH v3] configure: enable --s390-pgste linker option

2017-08-23 Thread Cornelia Huck
On Wed, 23 Aug 2017 12:16:23 +0200 Christian Borntraeger wrote: > KVM guests on s390 need a different page table layout than normal > processes (2kb page table + 2kb page status extensions vs 2kb page table > only). As of today this has to be enabled via the vm.allocate_pgste > sysctl. > > Newer

Re: [Qemu-devel] [PATCH v3] configure: enable --s390-pgste linker option

2017-08-23 Thread David Hildenbrand
On 23.08.2017 14:31, Cornelia Huck wrote: > On Wed, 23 Aug 2017 12:16:23 +0200 > Christian Borntraeger wrote: > >> KVM guests on s390 need a different page table layout than normal >> processes (2kb page table + 2kb page status extensions vs 2kb page table >> only). As of today this has to be ena

Re: [Qemu-devel] [PATCH v3] configure: enable --s390-pgste linker option

2017-08-23 Thread Christian Borntraeger
On 08/23/2017 02:31 PM, Cornelia Huck wrote: > On Wed, 23 Aug 2017 12:16:23 +0200 > Christian Borntraeger wrote: > >> KVM guests on s390 need a different page table layout than normal >> processes (2kb page table + 2kb page status extensions vs 2kb page table >> only). As of today this has to b

Re: [Qemu-devel] make check speed

2017-08-23 Thread Thomas Huth
On 23.08.2017 13:51, Lukáš Doktor wrote: [...] > and all ERROR lines: > > ERROR:tests/prom-env-test.c:42:check_guest_memory: assertion failed > (signature == MAGIC): (0x == 0xcafec0de) This test uses a timeout of 120 s, see check_guest_memory() in tests/prom-env-test.c ... that's a l

Re: [Qemu-devel] [PATCH v2 13/54] qapi: drop the sentinel in enum array

2017-08-23 Thread Markus Armbruster
Marc-André Lureau writes: > Now that all usages have been converted to user lookup helpers. I don't think you got them all: $ git-grep -F _lookup. tests/test-qobject-input-visitor.c:for (i = 0; i < EnumOne_lookup.size; i++) { tests/test-qobject-input-visitor.c:v = visi

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-23 Thread Igor Mammedov
On Wed, 23 Aug 2017 20:12:51 +0800 Dou Liyang wrote: > Hi Igor, > > At 08/23/2017 04:40 PM, Igor Mammedov wrote: > > On Tue, 22 Aug 2017 11:24:10 +0800 > > Dou Liyang wrote: > > > >> As QEMU supports the memory-less node, it is possible that there is > >> no RAM in the first numa node(also be

Re: [Qemu-devel] [PATCH 07/26] qapi: add 'if' condition on top-level schema elements

2017-08-23 Thread Eduardo Habkost
On Tue, Aug 22, 2017 at 06:52:19PM +0200, Markus Armbruster wrote: > Marc-André Lureau writes: [...] > >>> +def func_wrapper(self, *args, **kwargs): > >>> +funcname = self.__class__.__name__ + '.' + func.__name__ > >>> +ifcond = args[-1] > >>> +save = {} > >>> +

Re: [Qemu-devel] [PATCH v2 5/6] block: add iotest 191 for legacy throttling interface

2017-08-23 Thread Alberto Garcia
On Wed 09 Aug 2017 04:02:55 PM CEST, Manos Pitsidianakis wrote: > Check that the implicit throttle filter driver node, used for > compatibility with the legacy throttling interface on the BlockBackend > level, works. > > Signed-off-by: Manos Pitsidianakis Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCH v2 00/54] qapi: add #if pre-processor conditions to generated code

2017-08-23 Thread Markus Armbruster
PATCH 01 is a bug fix I'll apply it to qapi-next right away. PATCH 02-05 changes qmp-introspect.c's data structure from plain string to recursive structure, in preparation of the real QAPI work that starts in PATCH 15. PATCH 03 needs splitting. Apart from that, I only asked for minor tweaks, I t

Re: [Qemu-devel] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-23 Thread BALATON Zoltan
On Wed, 23 Aug 2017, François Revol wrote: Le 23/08/2017 à 13:12, BALATON Zoltan a écrit : What's the connection with mips_malta? The board's firmware wants to see SPD EEPROMs of the connected memory while initialising the memory controller. This is why we need to implement SDRAM controller, I

Re: [Qemu-devel] [PATCH for-2.10] numa: Move numa_legacy_auto_assign_ram to pc-i440fx-2.9

2017-08-23 Thread Igor Mammedov
On Fri, 18 Aug 2017 16:09:43 -0300 Eduardo Habkost wrote: > The 'm->numa_auto_assign_ram = numa_legacy_auto_assign_ram;' line > was supposed to be in pc_i440fx_2_9_machine_options() (see commit > 3bfe5716 "numa: equally distribute memory on nodes"), but the > merge commit adb354dd ("Merge remote-

Re: [Qemu-devel] make check speed

2017-08-23 Thread Lukáš Doktor
Dne 23.8.2017 v 14:35 Thomas Huth napsal(a): > On 23.08.2017 13:51, Lukáš Doktor wrote: > [...] >> and all ERROR lines: >> >> ERROR:tests/prom-env-test.c:42:check_guest_memory: assertion failed >> (signature == MAGIC): (0x == 0xcafec0de) > > This test uses a timeout of 120 s, see chec

Re: [Qemu-devel] [PATCH v2 53/54] qapi: make query-cpu-model-expansion depend on s390 or x86

2017-08-23 Thread Eduardo Habkost
On Wed, Aug 23, 2017 at 06:21:16AM -0400, Marc-André Lureau wrote: > Hi > > - Original Message - > > On Tue, Aug 22, 2017 at 03:22:54PM +0200, Marc-André Lureau wrote: > > > Signed-off-by: Marc-André Lureau > > > --- > > > qapi-schema.json | 4 +++- > > > include/s

Re: [Qemu-devel] [Qemu-ppc] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-23 Thread Daniel Henrique Barboza
On 08/22/2017 09:24 PM, David Gibson wrote: On Tue, Aug 22, 2017 at 08:50:44PM -0300, Daniel Henrique Barboza wrote: On 08/18/2017 01:14 AM, David Gibson wrote: On Thu, Aug 17, 2017 at 06:31:28PM -0300, Daniel Henrique Barboza wrote: On 08/17/2017 04:52 AM, David Gibson wrote: On Tue, Aug

[Qemu-devel] [Bug 1712564] [NEW] loadvm fails twice in sequence

2017-08-23 Thread Dr. David Alan Gilbert
Public bug reported: 13:38:23) shorne_: Hello, I was doing some testing with migrations for my OpenRISC SMP patch set, I noticed something that looks like a bug, wondering if someone else wants to confirm (13:38:47) shorne_: Basically, calling loadvm 2 times causes crash (13:38:54) shorne_:m

[Qemu-devel] [PATCH 3/3] Add manpage for QEMU Backup Tool

2017-08-23 Thread Ishani Chugh
qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The following commit is an initial implementation of manpage list

[Qemu-devel] [PATCH 0/3] QEMU Backup Tool

2017-08-23 Thread Ishani Chugh
This patch series is intended to introduce QEMU Backup tool. qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. This

[Qemu-devel] [PATCH 2/3] Test for full Backup

2017-08-23 Thread Ishani Chugh
This patch is the test for full backup implementation in Backup tool. The test employs two basic substests: 1) Backing up an empty guest and comparing it with base image. 2) Writing a pattern to the guest, creating backup and comparing with the base image. Signed-off-by: Ishani Chugh --- test

Re: [Qemu-devel] [PATCH for-2.11 03/27] sparc: convert cpu features to qdev properties

2017-08-23 Thread Eduardo Habkost
On Mon, Aug 21, 2017 at 01:03:07PM +0200, Igor Mammedov wrote: > On Fri, 18 Aug 2017 15:24:04 -0300 > Eduardo Habkost wrote: > > > On Fri, Aug 18, 2017 at 12:08:35PM +0200, Igor Mammedov wrote: > > > SPARC is the last target that uses legacy way of parsing > > > and initializing cpu features, dro

[Qemu-devel] [PATCH 1/3] backup: QEMU Backup Tool

2017-08-23 Thread Ishani Chugh
qemu-backup will be a command-line tool for performing full and incremental disk backups on running VMs. It is intended as a reference implementation for management stack and backup developers to see QEMU's backup features in action. The tool writes details of guest in a configuration file and the

Re: [Qemu-devel] [PATCH for-2.10-rc4?] acpi: pcihp: fix use-after-free for machines previous pc-1.7 compat

2017-08-23 Thread Michael S. Tsirkin
On Wed, Aug 23, 2017 at 07:40:39AM +0200, Thomas Huth wrote: > On 23.08.2017 02:10, Philippe Mathieu-Daudé wrote: > > On 08/22/2017 07:42 PM, Michael S. Tsirkin wrote: > >> On Tue, Aug 22, 2017 at 06:43:43PM -0300, Philippe Mathieu-Daudé wrote: > >>> 9e047b982452 "piix4: add acpi pci hotplug suppor

[Qemu-devel] [PATCH v2] xen: Emit RTC_CHANGE upon TIMEOFFSET ioreq

2017-08-23 Thread Ross Lagerwall
When the guest writes to the RTC, Xen emulates it and broadcasts a TIMEOFFSET ioreq. Emit an RTC_CHANGE QMP event to all QMP monitors when this happens rather than ignoring it so that something useful can be done with the information. This is the same event that QEMU generates when it emulates the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 15/15] ppc: Add aCube Sam460ex board

2017-08-23 Thread luigi burdo
Hi Zoltan, >So I chose to >use the sii3112 by default. right chooice because internal sata on sam460 had issue and wont boot os4,morphos... only the cdrom was booting if i remember good from internal sata 0. personally when i had a Sam460ex i was using a sii3114 or internal micro sd for boot.

Re: [Qemu-devel] [PATCH v4 2/2] ACPI/unit-test: Add a new testcase for RAM allocation in numa node

2017-08-23 Thread Dou Liyang
Hi Igor, At 08/23/2017 08:45 PM, Igor Mammedov wrote: On Wed, 23 Aug 2017 20:12:51 +0800 Dou Liyang wrote: Hi Igor, At 08/23/2017 04:40 PM, Igor Mammedov wrote: On Tue, 22 Aug 2017 11:24:10 +0800 Dou Liyang wrote: As QEMU supports the memory-less node, it is possible that there is no RAM

Re: [Qemu-devel] [Qemu-block] [RFC PATCH 31/56] block: Make throttle byte rates and sizes unsigned in QAPI/QMP

2017-08-23 Thread Alberto Garcia
On Mon 07 Aug 2017 04:45:35 PM CEST, Markus Armbruster wrote: > Sizes and byte rates should use QAPI type 'size' (uint64_t). > BlockIOThrottle and BlockDeviceInfo members @bps, @bps_rd, @bps_wr, > @bps_max, @bps_rd_max, @bps_wr_max, @iops_size are 'int' (int64_t). > qmp_block_set_io_throttle() and

[Qemu-devel] [PATCH for-2.10 1/4] block-backend: Refactor inactivate check

2017-08-23 Thread Fam Zheng
The logic will be fixed (extended), move it to a separete function. Signed-off-by: Fam Zheng --- block/block-backend.c | 19 ++- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/block/block-backend.c b/block/block-backend.c index e9798e897d..a3984d2bec 100644 --- a/

[Qemu-devel] [PATCH for-2.10 0/4] block: Fix non-shared storage migration

2017-08-23 Thread Fam Zheng
This fixes the issue reported as https://bugs.launchpad.net/bugs/1711602 Fam Zheng (3): block-backend: Refactor inactivate check block-backend: Allow more "can inactivate" cases mirror: Mark target BB as "force allow inactivate" Stefan Hajnoczi (1): block: Update open_flags after ->inacti

[Qemu-devel] [PATCH for-2.10 2/4] block-backend: Allow more "can inactivate" cases

2017-08-23 Thread Fam Zheng
These two conditions corresponds to mirror job's source and target, which need to be allowed as they are part of the non-shared storage migration workflow: failing to inactivate either will result in a failure during migration completion. Signed-off-by: Fam Zheng --- block/block-backend.c

[Qemu-devel] [PATCH for-2.10 4/4] block: Update open_flags after ->inactivate() callback

2017-08-23 Thread Fam Zheng
From: Stefan Hajnoczi In the ->inactivate() callbacks, permissions are updated, which typically involves a recursive check of the whole graph. Setting BDRV_O_INACTIVE right before doing that creates a state that bdrv_is_writable() returns false, which causes permission update failure. Reorder th

[Qemu-devel] [PATCH for-2.10 3/4] mirror: Mark target BB as "force allow inactivate"

2017-08-23 Thread Fam Zheng
Signed-off-by: Fam Zheng --- block/mirror.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/block/mirror.c b/block/mirror.c index c9a6a3ca86..429751b9fe 100644 --- a/block/mirror.c +++ b/block/mirror.c @@ -1134,6 +1134,7 @@ static void mirror_start_job(const ch

Re: [Qemu-devel] [PATCH 11/15] ppc: Add 460EX embedded CPU

2017-08-23 Thread David Gibson
On Wed, Aug 23, 2017 at 11:08:16AM +0200, BALATON Zoltan wrote: > On Wed, 23 Aug 2017, David Gibson wrote: > > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > > > Despite its name it is a 440 core CPU > > > > As I recall 460 was supposed to be a 440 with SMP support. Except > >

[Qemu-devel] [PATCH] virtio-input: send rel-wheel events for wheel buttons

2017-08-23 Thread Gerd Hoffmann
qemu uses wheel-up/down button events for mouse wheel input, however linux applications typically want REL_WHEEL events. This fixes wheel with linux guests. Tested with X11/wayland, and windows virtio-input driver. Based on a patch from Marc. Added property to enable/disable wheel axis. TODO: add

Re: [Qemu-devel] [PATCH 04/15] ehci: Add ppc4xx-ehci for the USB 2.0 controller in embedded PPC SoCs

2017-08-23 Thread Gerd Hoffmann
On Mon, 2017-08-21 at 14:18 +1000, David Gibson wrote: > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > > Some PPC SoCs have an EHCI with OHCI companion USB controller. Add > > a > > new type for this similar to types used for other embedded SoCs. > > > > Signed-off-by: BALATON

Re: [Qemu-devel] [PATCH 03/15] ohci: Allow sysbus version to be used as a companion

2017-08-23 Thread Gerd Hoffmann
On Mon, 2017-08-21 at 14:10 +1000, David Gibson wrote: > On Sun, Aug 20, 2017 at 07:23:05PM +0200, BALATON Zoltan wrote: > 1;4803;0c> Some PPC SoCs have an EHCI with OHCI companion USB > controller. To > > emulate this allow the sysbus version of OHCI to be used as a > > companion. > > > > Signed-

Re: [Qemu-devel] [PATCH v2 53/54] qapi: make query-cpu-model-expansion depend on s390 or x86

2017-08-23 Thread Marc-André Lureau
Hi - Original Message - > On Wed, Aug 23, 2017 at 06:21:16AM -0400, Marc-André Lureau wrote: > > Hi > > > > - Original Message - > > > On Tue, Aug 22, 2017 at 03:22:54PM +0200, Marc-André Lureau wrote: > > > > Signed-off-by: Marc-André Lureau > > > > --- > > > > qapi-schema.json

[Qemu-devel] [PATCH] qemu-iotests: add 194 non-shared storage migration test

2017-08-23 Thread Stefan Hajnoczi
Non-shared storage migration with NBD and drive-mirror is currently not tested by qemu-iotests. This test case covers the basic migration scenario. Signed-off-by: Stefan Hajnoczi Based-on: <20170823134242.12080-1-f...@redhat.com> --- tests/qemu-iotests/194| 73 ++

  1   2   3   4   >