[Qemu-devel] Fwd: Installing QEMU-KVM from Source

2017-08-18 Thread Tushar Bhardwaj
Respected Sir, I readied yours articles which is highly informative. I have installed Qemu-KVM using virt-manager, and there is no folder to track migration.c code. Please tell me how to install QEMU-KVM using source code so that I can do the required changes in migration code. -- "Purity and S

Re: [Qemu-devel] [PATCH] hw/ppc/spapr: Fix segfault when instantiating a 'pc-dimm' without 'memdev'

2017-08-18 Thread Thomas Huth
On 18.08.2017 03:25, David Gibson wrote: > On Thu, Aug 17, 2017 at 08:33:10PM +0200, Thomas Huth wrote: >> QEMU currently crashes when trying to use a 'pc-dimm' on the pseries >> machine without specifying its 'memdev' property. Let's add a sanity >> check to the pre_plug handler to fix this issue.

Re: [Qemu-devel] Fwd: Installing QEMU-KVM from Source

2017-08-18 Thread Fam Zheng
On Fri, 08/18 12:38, Tushar Bhardwaj wrote: > Respected Sir, > > I readied yours articles which is highly informative. I have installed > Qemu-KVM using virt-manager, and there is no folder to track migration.c > code. Please tell me how to install QEMU-KVM using source code so that I > can do the

Re: [Qemu-devel] [PATCH v14 3/5] virtio-balloon: VIRTIO_BALLOON_F_SG

2017-08-18 Thread Wei Wang
On 08/18/2017 10:22 AM, Michael S. Tsirkin wrote: +static void send_balloon_page_sg(struct virtio_balloon *vb, +struct virtqueue *vq, +void *addr, +uint32_t size) +{ + unsigned int len; + i

Re: [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list

2017-08-18 Thread Cornelia Huck
On Thu, 17 Aug 2017 16:02:00 +0200 Thomas Huth wrote: > On 17.08.2017 10:41, Cornelia Huck wrote: > > On Thu, 17 Aug 2017 08:25:09 +0200 > > Thomas Huth wrote: > > > >> With some small modifications, we can also use the the netfilter, > >> the fiter-mirror and the filter-redirector tests on s

Re: [Qemu-devel] [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-18 Thread Wei Wang
On 08/18/2017 10:28 AM, Michael S. Tsirkin wrote: On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: Add a new vq to report hints of guest free pages to the host. Signed-off-by: Wei Wang Signed-off-by: Liang Li --- drivers/virtio/virtio_balloon.c | 167 +++

Re: [Qemu-devel] [PATCH v14 5/5] virtio-balloon: VIRTIO_BALLOON_F_FREE_PAGE_VQ

2017-08-18 Thread Wei Wang
On 08/18/2017 10:13 AM, Michael S. Tsirkin wrote: On Thu, Aug 17, 2017 at 11:26:56AM +0800, Wei Wang wrote: Add a new vq to report hints of guest free pages to the host. Please add some text here explaining the report_free_page_signal thing. I also really think we need some kind of ID in the

Re: [Qemu-devel] [Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

2017-08-18 Thread Alex Bennée
John Arbuckle writes: > Using '-cpu 486' gets past the assertion error. I guess Windows NT 4.0 > is not compatible with newer Intel processors. It might be related. The assertion error is caused by the fact an exception has occurred and processor is trying to dump a stack frame that overlaps fr

Re: [Qemu-devel] RFH: difference in read-only mapped bios.bin - memory corruption?

2017-08-18 Thread Philipp Hahn
Hello, Am 15.08.2017 um 13:25 schrieb Laszlo Ersek: > On 08/14/17 20:39, Dr. David Alan Gilbert wrote: >> * Philipp Hahn (h...@univention.de) wrote: >>> I'm currently investigating a problem, were a Linux VM does not reboot >>> and gets stuck in the SeaBIOS reboot code: >>> >>> I'm using SeaBIOS-1

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-18 Thread Artyom Tarasenko
On Fri, Aug 18, 2017 at 6:31 AM, Programmingkid wrote: > >> On Aug 15, 2017, at 6:27 PM, Paolo Bonzini wrote: >> >> On 15/08/2017 20:46, Programmingkid wrote: >>> On Aug 14, 2017, at 2:51 AM, Paolo Bonzini wrote: On 13/08/2017 21:13, Programmingkid wrote: > Lately I found out

Re: [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list

2017-08-18 Thread Thomas Huth
On 18.08.2017 09:54, Cornelia Huck wrote: > On Thu, 17 Aug 2017 16:02:00 +0200 > Thomas Huth wrote: > >> On 17.08.2017 10:41, Cornelia Huck wrote: [...] >>> I'm wondering if we could unify selection of the network device >>> somehow. There's probably two cases: >>> - Test a specific device. This

Re: [Qemu-devel] [PATCH v5 5/6] block: add throttle block filter driver

2017-08-18 Thread Alberto Garcia
On Fri 18 Aug 2017 05:10:18 AM CEST, Manos Pitsidianakis wrote: > block/throttle.c uses existing I/O throttle infrastructure inside a > block filter driver. I/O operations are intercepted in the filter's > read/write coroutines, and referred to block/throttle-groups.c > > The driver can be used wit

Re: [Qemu-devel] RFH: difference in read-only mapped bios.bin - memory corruption?

2017-08-18 Thread Dr. David Alan Gilbert
* Philipp Hahn (h...@univention.de) wrote: > Hello, > > Am 15.08.2017 um 13:25 schrieb Laszlo Ersek: > > On 08/14/17 20:39, Dr. David Alan Gilbert wrote: > >> * Philipp Hahn (h...@univention.de) wrote: > >>> I'm currently investigating a problem, were a Linux VM does not reboot > >>> and gets stuc

Re: [Qemu-devel] [Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

2017-08-18 Thread Peter Maydell
On 18 August 2017 at 09:40, Alex Bennée wrote: > > John Arbuckle writes: > >> Using '-cpu 486' gets past the assertion error. I guess Windows NT 4.0 >> is not compatible with newer Intel processors. > > It might be related. The assertion error is caused by the fact an > exception has occurred and

Re: [Qemu-devel] [PATCH v5 5/6] block: add throttle block filter driver

2017-08-18 Thread Manos Pitsidianakis
On Fri, Aug 18, 2017 at 10:23:09AM +0200, Alberto Garcia wrote: On Fri 18 Aug 2017 05:10:18 AM CEST, Manos Pitsidianakis wrote: block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and refer

Re: [Qemu-devel] [RFC PATCH 11/12] ppc4xx: Export ECB and PLB emulation

2017-08-18 Thread David Gibson
On Mon, Aug 14, 2017 at 01:06:42PM +0200, BALATON Zoltan wrote: > On Mon, 14 Aug 2017, David Gibson wrote: > > On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > > > These devices are found in some other ppc4xx cores too. > > Thanks for the quick review, hope more will follow for ot

Re: [Qemu-devel] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board

2017-08-18 Thread David Gibson
On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. > This is not a full implementation yet with a lot of components still > missing but enough to start a Linux kernel and the U-Boot firmware. > > Signed-off-by:

Re: [Qemu-devel] [PATCH v5 5/6] block: add throttle block filter driver

2017-08-18 Thread Alberto Garcia
On Fri 18 Aug 2017 11:07:22 AM CEST, Manos Pitsidianakis wrote: >>> The driver can be used with the syntax >>> -drive driver=throttle,file.filename=foo.qcow2, \ >>> limits.iops-total=...,throttle-group=bar >> >>I had understood that we would get rid of the limits.* options in this >>driver

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 09/12] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-18 Thread luigi burdo
hi Balaton, i can help with amigaos4 for sam . i can test it on P5040 book3e and on G5 quad book3s machine. note sam for boot amigaos need a special modified version of uboot that is available on acube website it is a firmware update. without modified uboot will be not posdible auto boot amigaos.

[Qemu-devel] [PATCH] scsi-bus: correct responses for INQUIRY and REQUEST SENSE

2017-08-18 Thread Hannes Reinecke
According to SPC-3 INQUIRY and REQUEST SENSE should return GOOD even on unsupported LUNS. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-bus.c | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/hw/scsi/scsi-bus.c b/hw/scsi/scsi-bus.c index e364410

[Qemu-devel] [PATCH] s390x: wire up diag288 in tcg

2017-08-18 Thread Cornelia Huck
Make the diag288 watchdog useable via tcg as well. Signed-off-by: Cornelia Huck --- target/s390x/misc_helper.c | 8 1 file changed, 8 insertions(+) diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index d23ffcd890..80a13a1b66 100644 --- a/target/s390x/misc_helper.c

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Igor Mammedov
On Fri, 18 Aug 2017 04:40:02 +0300 "Michael S. Tsirkin" wrote: > On Thu, Aug 17, 2017 at 05:23:46PM +0100, Anthony PERARD wrote: > > This means that the function will be call and the property > > acpi-pcihp-bsel will be set even if ACPI build is disable. > > > > To do PCI passthrough with Xen, t

Re: [Qemu-devel] [PATCH for-2.10 v3 2/3] hw/acpi: Move acpi_set_pci_info to pcihp

2017-08-18 Thread Igor Mammedov
On Thu, 17 Aug 2017 17:23:46 +0100 Anthony PERARD wrote: > This means that the function will be call and the property > acpi-pcihp-bsel will be set even if ACPI build is disable. s/call/called/ s/disable/disabled/ Maybe something along this lines: HW part of APCI PCI hotplug in QEMU depends on

Re: [Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name() to cc_helper.c

2017-08-18 Thread David Hildenbrand
On 17.08.2017 11:22, David Hildenbrand wrote: > While at it, move the translations into the function. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cc_helper.c | 48 > > target/s390x/cpu.h | 48 > +--

Re: [Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name() to cc_helper.c

2017-08-18 Thread Thomas Huth
On 18.08.2017 11:59, David Hildenbrand wrote: > On 17.08.2017 11:22, David Hildenbrand wrote: >> While at it, move the translations into the function. >> >> Signed-off-by: David Hildenbrand >> --- >> target/s390x/cc_helper.c | 48 >> >> target/s39

[Qemu-devel] [PATCH v4 1/5] ppc: spapr: Register and handle HCALL to receive updated RTAS region

2017-08-18 Thread Aravinda Prasad
Receive updates from SLOF about the updated rtas-base. A separate patch for SLOF [1] adds functionality to invoke a private HCALL whenever OS issues instantiate-rtas with a new rtas-base. This is required as QEMU needs to know the updated rtas-base as it allocates error reporting structure in RTAS

[Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2017-08-18 Thread Aravinda Prasad
This series of patches adds support for FWNMI in PowerKVM guests. Memory error such as bit flips that cannot be corrected by hardware is passed on to the kernel for handling by raising machine check exception (an NMI). Upon such machine check exception, if the address in error belongs to guest the

[Qemu-devel] [PATCH v4 3/5] Wrapper function to wait on condition for the main loop mutex

2017-08-18 Thread Aravinda Prasad
Introduce a wrapper function to wait on condition for the main loop mutex. This function atomically releases the main loop mutex and causes the calling thread to block on the condition. Signed-off-by: Aravinda Prasad --- cpus.c |5 + include/qemu/main-loop.h |8

Re: [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images

2017-08-18 Thread Xie Changlong
在 5/5/2017 12:52 AM, Kevin Wolf 写道: +/* Returns whether the image file can be written to right now */ +bool bdrv_is_writable(BlockDriverState *bs) +{ +return !bdrv_is_read_only(bs) && !(bs->open_flags & BDRV_O_INACTIVE); +} + This commit use BDRV_O_INACTIVE to judge whether the image fil

[Qemu-devel] [PATCH v4 4/5] target/ppc: Handle NMI guest exit

2017-08-18 Thread Aravinda Prasad
Memory error such as bit flips that cannot be corrected by hardware are passed on to the kernel for handling. If the memory address in error belongs to guest then guest kernel is responsible for taking suitable action. Patch [1] enhances KVM to exit guest with exit reason set to KVM_EXIT_NMI in suc

[Qemu-devel] [PATCH v4 2/5] ppc: spapr: Handle "ibm, nmi-register" and "ibm, nmi-interlock" RTAS calls

2017-08-18 Thread Aravinda Prasad
This patch adds support in QEMU to handle "ibm,nmi-register" and "ibm,nmi-interlock" RTAS calls. The machine check notification address is saved when the OS issues "ibm,nmi-register" RTAS call. This patch also handles the case when multiple processors experience machine check at or about the same

[Qemu-devel] [PATCH for-2.11 03/27] sparc: convert cpu features to qdev properties

2017-08-18 Thread Igor Mammedov
SPARC is the last target that uses legacy way of parsing and initializing cpu features, drop legacy approach and convert features to properties so that SPARC could as minimum benefit from generic cpu_generic_init(), common with x86 +-feat parser PS: the main purpose is to remove legacy way of cpu

[Qemu-devel] [PATCH v4 5/5] ppc: spapr: Enable FWNMI capability

2017-08-18 Thread Aravinda Prasad
Enable the KVM capability KVM_CAP_PPC_FWNMI so that the KVM causes guest exit with NMI as exit reason when it encounters a machine check exception on the address belonging to a guest. Without this capability enabled, KVM redirects machine check exceptions to guest's 0x200 vector. Signed-off-by: Ar

[Qemu-devel] [PATCH for-2.11 01/27] sparc: convert cpu models to SPARC cpu subclasses

2017-08-18 Thread Igor Mammedov
QOMfy cpu models handling introducing propper cpu types for each cpu model. Signed-off-by: Igor Mammedov --- with this and conversion of features to properties, it would be possible to replace cpu_sparc_init() with cpu_generic_init() and reuse common -cpu handling infrastructure. CC: Mark Cave-A

[Qemu-devel] [PATCH for-2.11 07/27] sparc: replace custom cpu feature parsing with cpu_legacy_parse_featurestr()

2017-08-18 Thread Igor Mammedov
with features converted to properties we can reuse shared with x86 cpu_legacy_parse_featurestr() for features parsing and drop legacy parser that manipulated CPU directly. With that in place and sparc_cpu_parse_features() providing generic CPUClass::parse_features callback, the cpu_sparc_init() wi

[Qemu-devel] [PATCH for-2.11 00/27] complete cpu QOMification and remove cpu_FOO_init() helpers

2017-08-18 Thread Igor Mammedov
ChangeLog: * rebase on top of rc3 * drop MIPS CPU QOMifying patches as it's superseeded by another series: "[PATCH 0/8] QOMify MIPS cpu" https://lists.gnu.org/archive/html/qemu-devel/2017-08/msg03041.html * new patch to hide plus/minus features handling inside of feature parsing:

[Qemu-devel] [PATCH for-2.11 12/27] m68k: replace cpu_m68k_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
call register_m68k_insns() at realize time which makes cpu_m68k_init() typical object creation function. As result we can replace it with cpu_generic_init() which does the same job, reducing code duplication a bit. Signed-off-by: Igor Mammedov Tested-by: Thomas Huth Acked-by: Laurent Vivier ---

[Qemu-devel] [PATCH for-2.11 05/27] target-i386: cpu: convert plus/minus properties to global properties

2017-08-18 Thread Igor Mammedov
Since (commit d4a606b3 i386: Don't override -cpu options on -cpu host/max) it became possible to delete hack where it was necessary to postpone applying plus/minus features to realize time after max_features were applied to keep legacy +-feat override semantics. with above commit it's possible to

[Qemu-devel] [PATCH for-2.11 04/27] sparc: move adhoc CPUSPARCState initialization to realize time

2017-08-18 Thread Igor Mammedov
SPARCCPU::env was initialized from previosuly set properties (with help of sparc_cpu_parse_features) in cpu_sparc_register(). However there is not reason to keep it there as this task is typically done at realize time. So move post properties initialization into sparc_cpu_realizefn, which brings cp

[Qemu-devel] [PATCH for-2.11 09/27] s390x: replace cpu_s390x_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
cpu_s390x_init() is used only *-user targets indirectly via cpu_init() macro and has a hack to assign ids to created cpus (I'm not sure if 'id' really matters to *-user emulation). So to on safe side, instead of having custom wrapper to do numbering replace it with cpu_generic_init() and use S390C

[Qemu-devel] [PATCH for-2.11 06/27] x86: extract legacy cpu features format parser

2017-08-18 Thread Igor Mammedov
Move cpu_model +-feat parsing into a separate file so that it could be reused later for parsing similar format of sparc target Signed-off-by: Igor Mammedov --- CC: Richard Henderson CC: Eduardo Habkost CC: Mark Cave-Ayland CC: Artyom Tarasenko CC: Philippe Mathieu-Daudé --- include/qom/cpu.

[Qemu-devel] [PATCH for-2.11 10/27] alpha: replace cpu_alpha_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
cpu_alpha_init() used to provide default fallback if invalid (i.e. non existent) cpu_model were provided. dp264 machine provides its own default so sole user of fallback is [bsd|linux]-user targets which specifies 'any' cpu model that fallbacks to "ev67" in cpu_alpha_init(). Push fallback handling

[Qemu-devel] [PATCH for-2.11 02/27] sparc: embed sparc_def_t into CPUSPARCState

2017-08-18 Thread Igor Mammedov
Make CPUSPARCState::def embedded so it would be allocated as part of cpu instance and we won't have to worry about cleaning def pointer up mannualy on cpu destruction. Signed-off-by: Igor Mammedov --- Embedded CPUSPARCState::def also needed for follow up patch to use its fields with static qdev p

[Qemu-devel] [PATCH for-2.11 11/27] hppa: replace cpu_hppa_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
drop custom cpu_hppa_init() in favor of cpu_generic_init(), to make cpu_generic_init() work all we need is to provide cc->class_by_name callback that would resolve any cpu_model to the sole TYPE_HPPA_CPU to match current behaviour. Signed-off-by: Igor Mammedov Acked-by: Richard Henderson --- te

[Qemu-devel] [PATCH for-2.11 13/27] microblaze: replace cpu_mb_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
cpu_mb_init() always falls back to TYPE_MICROBLAZE_CPU object regardless of cpu_model. Put fallback logic into mb_cpu_class_by_name() which would translate any cpu_model into TYPE_MICROBLAZE_CPU class and replace cpu_mb_init() with cpu_generic_init(). Signed-off-by: Igor Mammedov Reviewed-by: Phi

[Qemu-devel] [PATCH for-2.11 08/27] sparc: replace cpu_sparc_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov --- CC: Fabien Chouteau CC: Mark Cave-Ayland CC: Artyom Tarasenko --- target/sparc/cpu.h | 3 +-- hw/sparc/leon3.c | 2 +- hw/sparc/sun4m.c | 2 +- hw/sparc64/sparc64.c | 2 +- target/sparc

[Qemu-devel] [PATCH for-2.11 14/27] nios2: replace cpu_nios2_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
cpu_nios2_init() always falls back to TYPE_NIOS2_CPU object regardless of cpu_model. Put fallback logic into nios2_cpu_class_by_name() which would translate any cpu_model into TYPE_NIOS2_CPU class and replace cpu_nios2_init() with cpu_generic_init() Signed-off-by: Igor Mammedov Reviewed-by: Phili

[Qemu-devel] [PATCH for-2.11 18/27] sh4: replace cpu_sh4_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target/sh4/cpu.h | 3 +-- hw/sh4/r2d.c | 2 +- hw/sh4/shix.c| 2 +- target/sh4/cpu.c | 5 - 4 files changed, 3 insertions(+), 9 deletions(-) diff --git a/t

[Qemu-devel] [PATCH for-2.11 15/27] tilegx: replace cpu_tilegx_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
cpu_tilegx_init() always falls back to TYPE_TILEGX_CPU object regardless of cpu_model. Put fallback logic into tilegx_cpu_class_by_name() which would translate any cpu_model into TYPE_TILEGX_CPU class and replace cpu_tilegx_init() with cpu_generic_init(). Signed-off-by: Igor Mammedov Reviewed-by:

[Qemu-devel] [PATCH for-2.11 23/27] moxie: replace cpu_moxie_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target/moxie/cpu.h | 3 +-- hw/moxie/moxiesim.c | 2 +- target/moxie/cpu.c | 5 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/target/moxie/cpu.

[Qemu-devel] [PATCH for-2.11 16/27] xtensa: replace cpu_xtensa_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
call xtensa_irq_init() at realize time which makes cpu_xtensa_init() like generic cpu creation function. As result we can replace it with cpu_generic_init() which does the same job, reducing code duplication a bit. Signed-off-by: Igor Mammedov --- CC: Max Filippov --- target/xtensa/cpu.h|

[Qemu-devel] [PATCH for-2.11 19/27] arm: replace cpu_arm_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Andrew Jones --- target/arm/cpu.h| 3 +-- hw/arm/musicpal.c | 2 +- hw/arm/omap1.c | 2 +- hw/arm/omap2.c | 2 +- hw/arm/pxa2xx.c | 4 ++-- hw/arm/strongarm.c | 2 +-

[Qemu-devel] [PATCH for-2.11 17/27] tricore: replace cpu_tricore_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target/tricore/cpu.h | 4 +--- hw/tricore/tricore_testboard.c | 2 +- target/tricore/helper.c| 5 - 3 files changed, 2 insertions(+), 9 deletions(

[Qemu-devel] [PATCH for-2.11 20/27] cris: replace cpu_cris_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target/cris/cpu.h| 3 +-- hw/cris/axis_dev88.c | 2 +- target/cris/cpu.c| 5 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/target/cris/cp

[Qemu-devel] [PATCH for-2.11 27/27] fix build failure in nbd_read_reply_entry()

2017-08-18 Thread Igor Mammedov
travis builds fail at HEAD at rc3 master with block/nbd-client.c: In function ‘nbd_read_reply_entry’: block/nbd-client.c:110:8: error: ‘ret’ may be used uninitialized in this function [-Werror=uninitialized] fix it by initializing 'ret' to 0 Signed-off-by: Igor Mammedov --- block/nbd-clie

[Qemu-devel] [PATCH for-2.11 22/27] lm32: replace cpu_lm32_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Acked-by: Michael Walle Reviewed-by: Eduardo Habkost --- target/lm32/cpu.h | 3 +-- hw/lm32/lm32_boards.c | 4 ++-- hw/lm32/milkymist.c | 2 +- target/lm32/helper.c | 5 - 4 files changed,

[Qemu-devel] [PATCH for-2.11 21/27] x86: replace cpu_x86_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target/i386/cpu.h | 3 +-- target/i386/cpu.c | 5 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/target/i386/cpu.h b/target/i386/cpu.h index 051867

[Qemu-devel] [PATCH for-2.11 24/27] openrisc: replace cpu_openrisc_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Acked-by: Stafford Horne Reviewed-by: Eduardo Habkost --- target/openrisc/cpu.h | 4 +--- hw/openrisc/openrisc_sim.c | 2 +- target/openrisc/cpu.c | 5 - 3 files changed, 2 insertions(+)

Re: [Qemu-devel] [Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

2017-08-18 Thread Alex Bennée
Peter Maydell writes: > On 18 August 2017 at 09:40, Alex Bennée wrote: >> >> John Arbuckle writes: >> >>> Using '-cpu 486' gets past the assertion error. I guess Windows NT 4.0 >>> is not compatible with newer Intel processors. >> >> It might be related. The assertion error is caused by the fa

[Qemu-devel] [PATCH for-2.11 26/27] ppc: replace cpu_ppc_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Acked-by: David Gibson Reviewed-by: Hervé Poussineau Reviewed-by: Eduardo Habkost --- target/ppc/cpu.h| 3 +-- hw/ppc/e500.c | 3 ++- hw/ppc/mac_newworld.c | 3 ++- hw

[Qemu-devel] [PATCH for-2.11 25/27] unicore32: replace uc32_cpu_init() with cpu_generic_init()

2017-08-18 Thread Igor Mammedov
it's just a wrapper, drop it and use cpu_generic_init() directly Signed-off-by: Igor Mammedov Reviewed-by: Eduardo Habkost --- target/unicore32/cpu.h| 4 +--- hw/unicore32/puv3.c | 2 +- target/unicore32/helper.c | 5 - 3 files changed, 2 insertions(+), 9 deletions(-) diff --git

Re: [Qemu-devel] [Bug 1706296] Re: Booting NT 4 disk causes /home/rjones/d/qemu/cpus.c:1580:qemu_mutex_lock_iothread: assertion failed: (!qemu_mutex_iothread_locked())

2017-08-18 Thread Peter Maydell
On 18 August 2017 at 11:23, Alex Bennée wrote: > Peter Maydell writes: >> On 18 August 2017 at 09:40, Alex Bennée wrote: >>> It might be related. The assertion error is caused by the fact an >>> exception has occurred and processor is trying to dump a stack frame that >>> overlaps from RAM into

Re: [Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2017-08-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 150305073858.13788.4068645609072927349.stgit@aravinda Subject: [Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests === TEST SCRIPT BE

Re: [Qemu-devel] [PATCH v4 0/5] target-ppc/spapr: Add FWNMI support in QEMU for PowerKVM guests

2017-08-18 Thread David Gibson
On Fri, Aug 18, 2017 at 03:36:44PM +0530, Aravinda Prasad wrote: > This series of patches adds support for FWNMI in PowerKVM guests. > > Memory error such as bit flips that cannot be corrected > by hardware is passed on to the kernel for handling > by raising machine check exception (an NMI). Upon

Re: [Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name() to cc_helper.c

2017-08-18 Thread Cornelia Huck
On Fri, 18 Aug 2017 12:04:14 +0200 Thomas Huth wrote: > On 18.08.2017 11:59, David Hildenbrand wrote: > > On 17.08.2017 11:22, David Hildenbrand wrote: > >> While at it, move the translations into the function. > >> > >> Signed-off-by: David Hildenbrand > >> --- > >> target/s390x/cc_helper.c

[Qemu-devel] [PATCH] s390x/tcg: specification exception for unknown diag

2017-08-18 Thread Cornelia Huck
While the PoP is silent on the issue, z/VM documentation states that unknown diagnose codes trigger a specification exception. We already do that when running with kvm, so change tcg to do so as well. Signed-off-by: Cornelia Huck --- This is on top of "s390x: wire up diag288 in tcg". --- targe

Re: [Qemu-devel] [RFC PATCH 09/12] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-18 Thread François Revol
Hi, Le 18/08/2017 à 03:53, David Gibson a écrit : > On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: > > You know I'm going to say it, right: needs a commit message. > > What's a "plb-pcix", and what's an example of a 440 SoCs which has it. IIRC that's the PCI(express) controller

Re: [Qemu-devel] [Qemu-ppc] [RFC PATCH 09/12] ppc440: Add emulation of plb-pcix controller found in some 440 SoCs

2017-08-18 Thread François Revol
Hi, Le 18/08/2017 à 11:30, luigi burdo a écrit : > hi Balaton, i can help with amigaos4 for sam . i can test it on P5040 > book3e and on G5 quad book3s machine. note sam for boot amigaos need > a special modified version of uboot that is available on acube > website it is a firmware update. withou

Re: [Qemu-devel] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board

2017-08-18 Thread François Revol
Le 18/08/2017 à 08:10, David Gibson a écrit : > On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote: >> Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC. >> This is not a full implementation yet with a lot of components still >> missing but enough to start a Linux k

Re: [Qemu-devel] [PATCH] s390x/tcg: specification exception for unknown diag

2017-08-18 Thread Thomas Huth
On 18.08.2017 13:00, Cornelia Huck wrote: > While the PoP is silent on the issue, z/VM documentation states > that unknown diagnose codes trigger a specification exception. > We already do that when running with kvm, so change tcg to do so > as well. I just tried on a z/VM guest what happens if I

Re: [Qemu-devel] [PATCH v2 for-2.11 0/2] Improvements for the pxe tester

2017-08-18 Thread Cornelia Huck
On Tue, 15 Aug 2017 17:27:55 +0200 Cornelia Huck wrote: > On Fri, 11 Aug 2017 07:57:54 +0200 > Thomas Huth wrote: > > > The first patch improves the buffer handling in the pxe tester a > > little bit by allocating a separate buffer on the heap for each > > architecture. This also gets rid of th

Re: [Qemu-devel] [PATCH] s390x/tcg: specification exception for unknown diag

2017-08-18 Thread Cornelia Huck
On Fri, 18 Aug 2017 13:26:15 +0200 Thomas Huth wrote: > On 18.08.2017 13:00, Cornelia Huck wrote: > > While the PoP is silent on the issue, z/VM documentation states > > that unknown diagnose codes trigger a specification exception. > > We already do that when running with kvm, so change tcg to d

Re: [Qemu-devel] [RFC PATCH 0/9] TCG Vector types and example conversion

2017-08-18 Thread Kirill Batuzov
On Thu, 17 Aug 2017, Alex Bennée wrote: > Hi, > > With upcoming work on SVE I've been looking at the way we implement > vector registers in QEMU's TCG. The current orthodoxy is to decompose > the vector into a series of TCG registers, often calling a helper > function the calculation of each el

[Qemu-devel] [PATCH v3 for-2.11 03/18] target/s390x: simplify ri_allowed()

2017-08-18 Thread David Hildenbrand
Only used in KVM and there is no reason why it shouldn't be allowed for tcg - it is simply not available. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 1c7af39..3

[Qemu-devel] [PATCH v3 for-2.11 04/18] target/s390x: simplify gs_allowed()

2017-08-18 Thread David Hildenbrand
No need for kvm_enabled() as this function is only called from KVM and there is no reason why it shouldn't be allowed for tcg. It is simply not available under tcg. Also, there is no need to check for the machine type anymore. Just like ri_enabled(), we can directly use the stored flag, which resu

[Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h

2017-08-18 Thread David Hildenbrand
... now featuring even more cleanups. cpu.h is accessed outside of target/s390x. It should only contain what is expected to be accessed outside of this folder. Therefore, create internal.h and move a lot to that file. In addition, introduce kvm-stub.c and kvm_390x.h for kvm specific functions. Ho

[Qemu-devel] [PATCH v3 for-2.11 01/18] s390x/kvm: drop KVMState parameter from s390_get_memslot_count()

2017-08-18 Thread David Hildenbrand
Not needed at that point. Signed-off-by: David Hildenbrand --- hw/s390x/sclp.c| 2 +- target/s390x/cpu.h | 8 target/s390x/kvm.c | 4 ++-- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/s390x/sclp.c b/hw/s390x/sclp.c index 9253dbb..8dd1109 100644 --- a/hw/s390x/sc

[Qemu-devel] [PATCH v3 for-2.11 02/18] s390x/kvm: drop KVMState parameter from kvm_s390_set_mem_limit()

2017-08-18 Thread David Hildenbrand
Not needed at that point. Also drop it from kvm_s390_query_mem_limit() we call in kvm_s390_set_mem_limit(). Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 7 +++ target/s390x/kvm.c | 12 ++-- 2 files changed, 9 insertions(+), 10 deletions(-) diff --git a/target/s390x/cpu

[Qemu-devel] [PATCH v3 for-2.11 06/18] s390x/cpumodel: factor out determination of default model name

2017-08-18 Thread David Hildenbrand
Now we can drop inclusion of "sysemu/kvm.h" from "s390-virtio.c". Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio.c| 7 +-- target/s390x/cpu.h| 1 + target/s390x/cpu_models.c | 8 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/hw/s390x/s390-vir

[Qemu-devel] [PATCH v3 for-2.11 05/18] target/s390x: no need to pass kvm_state to savevm_gtod handlers

2017-08-18 Thread David Hildenbrand
Let's avoid any KVM stuff in s390-virtio-ccw.c. This parameter is simply ignored. Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index 3e9b455..f19fab5 100

[Qemu-devel] [PATCH v3 for-2.11 08/18] target/s390x: move gtod_*() declarations to s390-virtio.h

2017-08-18 Thread David Hildenbrand
Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio.h | 2 ++ target/s390x/cpu.h | 3 --- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/hw/s390x/s390-virtio.h b/hw/s390x/s390-virtio.h index f2377a3..ca97fd6 100644 --- a/hw/s390x/s390-virtio.h +++ b/hw/s390x/s390-virtio.

[Qemu-devel] [PATCH v3 for-2.11 10/18] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c

2017-08-18 Thread David Hildenbrand
Only used in that file. Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 14 -- target/s390x/excp_helper.c | 14 ++ 2 files changed, 14 insertions(+), 14 deleti

[Qemu-devel] [PATCH v3 for-2.11 09/18] target/s390x: move cc_name() to helper.c

2017-08-18 Thread David Hildenbrand
While at it, move the translations into the function and properly pass enum cc_op as parameter. We can't move it to cc_helper.c as this would break --disable-tcg. Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- t

[Qemu-devel] [PATCH v3 for-2.11 07/18] s390x: drop inclusion of sysemu/kvm.h from some files

2017-08-18 Thread David Hildenbrand
s390-stattrib.c needs definition of TARGET_PAGE_SIZE, solve it via cpu.h. Signed-off-by: David Hildenbrand --- hw/s390x/s390-stattrib.c | 2 +- hw/s390x/sclp.c | 1 - hw/s390x/sclpcpu.c | 1 - target/s390x/arch_dump.c | 1 - 4 files changed, 1 insertion(+), 4 deletions(-) diff --

[Qemu-devel] [PATCH v3 for-2.11 14/18] target/s390x: introduce internal.h

2017-08-18 Thread David Hildenbrand
cpu.h should only contain what really has to be accessed outside of target/s390x/. Add internal.h which can only be used inside target/s390x/. Move everything that isn't fast enough to run away and restructure it right away. We'll move all kvm_* stuff later. Minor style fixes to avoid checkpatch

[Qemu-devel] [PATCH v3 for-2.11 17/18] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-18 Thread David Hildenbrand
Let's do it just like the other architectures. Introduce kvm-stub.c for stubs and kvm_s390x.h for the declarations. Change license to GPL2+ and keep copyright notice. As we are dropping the sysemu/kvm.h include from cpu.h, fix up includes. Suggested-by: Thomas Huth Reviewed-by: Richard Henderso

[Qemu-devel] [PATCH v3 for-2.11 16/18] s390x: avoid calling kvm_ functions outside of target/s390x/

2017-08-18 Thread David Hildenbrand
Let's just introduce an helper. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 4 +--- target/s390x/cpu.c | 7 +++ target/s390x/cpu.h | 1 + 3 files changed, 9 in

[Qemu-devel] [PATCH v3 for-2.11 15/18] target/s390x: move a couple of functions to cpu.c

2017-08-18 Thread David Hildenbrand
Prepare to move more stuff (especially KVM related) from cpu.h to internal.h. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Hildenbrand --- target/s390x/cpu.c | 79 target/s390x

[Qemu-devel] [PATCH v3 for-2.11 12/18] target/s390x: move s390_do_cpu_reset() to diag.c

2017-08-18 Thread David Hildenbrand
Only used in that file. Also drop the comment, not really needed. Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 7 --- target/s390x/diag.c | 7 +++ 2 files changed, 7 insertions(+)

Re: [Qemu-devel] [PATCH v2 3/3] s390x: wire up diag288 in tcg

2017-08-18 Thread Thomas Huth
On 18.08.2017 13:48, Cornelia Huck wrote: > Make the diag288 watchdog useable via tcg as well. > > Signed-off-by: Cornelia Huck > --- > target/s390x/misc_helper.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c > index 5a1eba0

[Qemu-devel] [PATCH v2 0/3] s390x: diag-related things

2017-08-18 Thread Cornelia Huck
...which are a fix in tcg for diag handling and diag288 watchdog changes. v1->v2: just reorder patches for less churn [Thomas] Cornelia Huck (2): s390x/tcg: specification exception for unknown diag s390x: wire up diag288 in tcg Thomas Huth (1): watchdog/wdt_diag288: Mark diag288 watchdog a

[Qemu-devel] [PATCH v3 for-2.11 18/18] target/s390x: cleanup cpu.h

2017-08-18 Thread David Hildenbrand
Let's reshuffle the function prototypes so we get a cleaner outline of the files. Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 137 ++--- 1 file changed, 68 insertion

[Qemu-devel] [PATCH v3 for-2.11 11/18] target/s390x: move psw_key_valid() to mem_helper.c

2017-08-18 Thread David Hildenbrand
Only used in that file. Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/cpu.h| 11 --- target/s390x/mem_helper.c | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-)

[Qemu-devel] [PATCH v2 1/3] s390x/tcg: specification exception for unknown diag

2017-08-18 Thread Cornelia Huck
While the PoP is silent on the issue, z/VM documentation states that unknown diagnose codes trigger a specification exception. We already do that when running with kvm, so change tcg to do so as well. Signed-off-by: Cornelia Huck --- target/s390x/misc_helper.c | 2 +- 1 file changed, 1 insertion

[Qemu-devel] [PATCH v2 2/3] watchdog/wdt_diag288: Mark diag288 watchdog as non-hotpluggable

2017-08-18 Thread Cornelia Huck
From: Thomas Huth QEMU currently aborts when the user tries to hot-unplug a diag288 device: $ qemu-system-s390x -nographic -nodefaults -S -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add diag288,id=x (qemu) device_del x ** ERROR:qemu/qdev-monitor.c:872:qdev

[Qemu-devel] [PATCH v3 for-2.11 13/18] target/s390x: move get_per_in_range() to misc_helper.c

2017-08-18 Thread David Hildenbrand
Only used in that file. Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 11 --- target/s390x/misc_helper.c | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-)

[Qemu-devel] [PATCH v2 3/3] s390x: wire up diag288 in tcg

2017-08-18 Thread Cornelia Huck
Make the diag288 watchdog useable via tcg as well. Signed-off-by: Cornelia Huck --- target/s390x/misc_helper.c | 4 1 file changed, 4 insertions(+) diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c index 5a1eba02ab..34d730ba73 100644 --- a/target/s390x/misc_helper.c +++

Re: [Qemu-devel] [PATCH v3 for-2.11 00/18] target/s390x: cleanup cpu.h

2017-08-18 Thread David Hildenbrand
s/PATCH v3/PATCH v2/g :] -- Thanks, David

Re: [Qemu-devel] [PATCH v2 1/3] s390x/tcg: specification exception for unknown diag

2017-08-18 Thread Thomas Huth
On 18.08.2017 13:48, Cornelia Huck wrote: > While the PoP is silent on the issue, z/VM documentation states > that unknown diagnose codes trigger a specification exception. > We already do that when running with kvm, so change tcg to do so > as well. > > Signed-off-by: Cornelia Huck > --- > targ

Re: [Qemu-devel] [PATCH 5/6] block: Fix write/resize permissions for inactive images

2017-08-18 Thread Fam Zheng
On Fri, 08/18 18:06, Xie Changlong wrote: > The root casue is when we run replication in secondary, vmstate changes to > RUN_STATE_INMIGRATE, then blockdev_init() sets bdrv_flags |= > BDRV_O_INACTIVE. So the whole chain become readonly. I've tried on my side, > but it seems not easy to fix it. I wo

  1   2   3   >