Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema

2017-08-17 Thread Markus Armbruster
Copying our resident VNC maintainer^Wodd fixer Gerd. Also copying Dan for QCryptoCipherAlgorithm. Gerd, Dan, this patch is about making VNC support visible in query-qmp-schema, by having the QAPI generators generate suitable ifdeffery. Bonus: no need for QMP command stubs for !defined(CONFIG_VNC

Re: [Qemu-devel] [PATCH 00/17] nbd client refactoring and fixing

2017-08-17 Thread Vladimir Sementsov-Ogievskiy
17.08.2017 00:21, Eric Blake wrote: On 08/04/2017 10:14 AM, Vladimir Sementsov-Ogievskiy wrote: A bit more refactoring and fixing before BLOCK_STATUS series. I've tried to make individual patches simple enough, so there are a lot of them. Is your BLOCK_STATUS series something that is in good en

Re: [Qemu-devel] [PATCH 17/26] qapi: add conditions to SPICE type/commands/events on the schema

2017-08-17 Thread Markus Armbruster
Copying our resident SPICE maintainer Gerd. Marc-André Lureau writes: > Add #if defined(CONFIG_SPICE) in generated code, and adjust the > qmp/hmp code accordingly. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 28 ++-- > qapi/event.json | 12 -

Re: [Qemu-devel] [PATCH 1/6] tests: Run filter-redirector and -mirror test only on POSIX systems

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 08:25:08 +0200 Thomas Huth wrote: > This way we can get rid of the ugly #ifdefs in the code which makes > it easier to extend later. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 8 > tests/test-filter-mirror.c | 5 - > tests/tes

Re: [Qemu-devel] [PATCH 2/6] tests: Add network filter tests to the check-qtest-s390x list

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 08:25:09 +0200 Thomas Huth wrote: > With some small modifications, we can also use the the netfilter, > the fiter-mirror and the filter-redirector tests on s390x. s/fiter/filter/ > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 3 +++ > tests/test-

Re: [Qemu-devel] [PATCH 17/26] qapi: add conditions to SPICE type/commands/events on the schema

2017-08-17 Thread Markus Armbruster
Markus Armbruster writes: [...] > Check for completeness by reviewing the case insensitive occurrences of > SPICE in the schema not covered by your patch: > > * add_client > > Same rationale as for VNC (see my review of PATCH 16). Good. Hmm, there's a difference to VNC, in qmp_add_client():

Re: [Qemu-devel] [PATCH 3/6] tests: Enable the drive_del test also on s390x

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 08:25:10 +0200 Thomas Huth wrote: > By using the "virtio-xxx" device name aliases instead of the > "virtio-xxx-pci" names, we can use this test on s390x, too, > to check that adding and deleting also works fine with the > virtio-ccw bus. I don't think we should leak the alias

[Qemu-devel] [Bug 1711316] [NEW] fbsd strip(1) segfaults on aarch64

2017-08-17 Thread Gergely Czuczy
Public bug reported: Hello, During port builds ld.lld(devel/boost-libs, www/node), and strip (textproc/libxml2 on xmlcatalog) are segfaulting. On physical boxes these things do work, as they should: root@build-aarch64:~ # strip xmlcatalog Segmentation fault (core dumped) All the cores fail at t

Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema

2017-08-17 Thread Markus Armbruster
Gerd, can we delete the vnc_init_func() stub? Things still compile for me when I do. diff --git a/include/ui/console.h b/include/ui/console.h index 7262bef..2c3b2cd 100644 --- a/include/ui/console.h +++ b/include/ui/console.h @@ -484,11 +484,6 @@ static inline QemuOpts *vnc_parse(const char *str,

Re: [Qemu-devel] [PATCH 4/6] tests: Introduce generic device hot-plug/hot-unplug functions

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 08:25:11 +0200 Thomas Huth wrote: > A lot of tests provide code for adding and removing a device via the > device_add and device_del QMP commands. Maintaining this code in so > many places is cumbersome and error-prone (some of the code parts > check the responses in an incorr

Re: [Qemu-devel] [PATCH 5/6] tests: Add qvirtio_(un)plug_device_test wrapper functions

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 08:25:12 +0200 Thomas Huth wrote: > To support hot-plugging tests with virtio-ccw later, the current > tests should become independent from PCI specific functions. Thus > let's add some proper wrapper function for virtio device hot-plugging > and -unplugging first. > It also s

Re: [Qemu-devel] [PATCH 6/6] tests: Enable the simple virtio tests on s390x, too

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 08:25:13 +0200 Thomas Huth wrote: > Most of the simple virtio test can be used on virtio-ccw on > s390x, too, by simply using the bus-independent alias names > of the devices instead of the device names ending in "-pci". > Hot-plugging can also be tested here - we just have to

Re: [Qemu-devel] [PATCH for-2.11 0/6] Enable more qtests for s390x

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 08:25:07 +0200 Thomas Huth wrote: > We currently do not have many tests enabled for QEMU on s390x yet, > so this series reworks some of the tests to be also usable on s390x > to get some extended test coverage there. More coverage on s390x is certainly desirable. I'm wonderin

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable

2017-08-17 Thread David Hildenbrand
On 16.08.2017 07:30, Thomas Huth wrote: > The s390-ipl device can not be created by the user, since it is meant only > to be instantiated once internally to load the ROMs and kernel. If the user > tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with > a "ROM images must be l

[Qemu-devel] [PATCH v7 0/4] Add shrink image for qcow2

2017-08-17 Thread Pavel Butsykin
This patch add shrinking of the image file for qcow2. As a result, this allows us to reduce the virtual image size and free up space on the disk without copying the image. Image can be fragmented and shrink is done by punching holes in the image file. # ./qemu-img create -f qcow2 image.qcow2 4G Fo

[Qemu-devel] [PATCH v7 1/4] qemu-img: add --shrink flag for resize

2017-08-17 Thread Pavel Butsykin
The flag is additional precaution against data loss. Perhaps in the future the operation shrink without this flag will be blocked for all formats, but for now we need to maintain compatibility with raw. Signed-off-by: Pavel Butsykin Reviewed-by: Max Reitz --- qemu-img-cmds.hx | 4 ++-- q

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 11:05:35 +0200 David Hildenbrand wrote: > On 16.08.2017 07:30, Thomas Huth wrote: > > The s390-ipl device can not be created by the user, since it is meant only > > to be instantiated once internally to load the ROMs and kernel. If the user > > tries to do a "device_add s390-

[Qemu-devel] [PATCH v7 2/4] qcow2: add qcow2_cache_discard

2017-08-17 Thread Pavel Butsykin
Whenever l2/refcount table clusters are discarded from the file we can automatically drop unnecessary content of the cache tables. This reduces the chance of eviction useful cache data and eliminates inconsistent data in the cache with the data in the file. Signed-off-by: Pavel Butsykin Reviewed-

[Qemu-devel] [PATCH v7 3/4] qcow2: add shrink image support

2017-08-17 Thread Pavel Butsykin
This patch add shrinking of the image file for qcow2. As a result, this allows us to reduce the virtual image size and free up space on the disk without copying the image. Image can be fragmented and shrink is done by punching holes in the image file. Signed-off-by: Pavel Butsykin Reviewed-by: Ma

[Qemu-devel] [PATCH v7 4/4] qemu-iotests: add shrinking image test

2017-08-17 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin Reviewed-by: Max Reitz --- tests/qemu-iotests/163 | 170 + tests/qemu-iotests/163.out | 5 ++ tests/qemu-iotests/group | 1 + 3 files changed, 176 insertions(+) create mode 100644 tests/qemu-iotests/163 create

Re: [Qemu-devel] [PATCH 19/26] build-sys: move qapi variables in qapi.mak

2017-08-17 Thread Markus Armbruster
We don't move in qapi.mak we move *into* qapi.mak. While we're talking: use a more common tag, and start the phrase with a capital letter: "Makefile: Move qapi variables into qapi.mak". Commit message then still misses the most important part: why? Marc-André Lureau writes: > Signed-off-by: Ma

[Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name() to cc_helper.c

2017-08-17 Thread David Hildenbrand
While at it, move the translations into the function. Signed-off-by: David Hildenbrand --- target/s390x/cc_helper.c | 48 target/s390x/cpu.h | 48 +--- 2 files changed, 49 insertions(+), 47 deletio

[Qemu-devel] [PATCH v1 for-2.11 05/10] target/s390x: move get_per_in_range() to misc_helper.c

2017-08-17 Thread David Hildenbrand
Only used in that file. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 11 --- target/s390x/misc_helper.c | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index d8bc134..ca10f0a 100644 --- a/targ

Re: [Qemu-devel] [Qemu-block] [PATCH v6 0/4] Add shrink image for qcow2

2017-08-17 Thread Pavel Butsykin
On 17.08.2017 00:07, John Snow wrote: Over a month with no replies and we're nearing the next QEMU release. If this patchset is still applicable, can you rebase and resend for 2.11? Thanks for digging up these patches :) I've sent the rebased version. --js On 07/14/2017 11:37 AM, Pavel Butsy

[Qemu-devel] [PATCH v1 for-2.11 02/10] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c

2017-08-17 Thread David Hildenbrand
Only used in that file. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 14 -- target/s390x/excp_helper.c | 14 ++ 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index 3e798ef..6567cfa 100644 ---

[Qemu-devel] [PATCH v1 for-2.11 07/10] target/s390x: move a couple of functions to cpu.c

2017-08-17 Thread David Hildenbrand
Prepare to move more stuff (especially KVM related) from cpu.h to internal.h. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- target/s390x/cpu.c | 79 target/s390x/cpu.h | 89 ++---

[Qemu-devel] [PATCH v1 for-2.11 04/10] target/s390x: move s390_do_cpu_reset() to diag.c

2017-08-17 Thread David Hildenbrand
Only used in that file. Also drop the comment, not really needed. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 7 --- target/s390x/diag.c | 7 +++ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index 42d4ac0..d8bc134 1

[Qemu-devel] [PATCH v1 for-2.11 00/10] target/s390x: cleanup cpu.h

2017-08-17 Thread David Hildenbrand
cpu.h is accessed outside of target/s390x. It should only contain what is expected to be accessed outside of this folder. Therefore, create internal.h and move a lot to that file. In addition, introduce kvm-stub.c and kvm_390x.h for kvm specific functions. Let's see what compilers think about this

[Qemu-devel] [PATCH v1 for-2.11 03/10] target/s390x: move psw_key_valid() to mem_helper.c

2017-08-17 Thread David Hildenbrand
Only used in that file. Signed-off-by: David Hildenbrand --- target/s390x/cpu.h| 11 --- target/s390x/mem_helper.c | 11 +++ 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h index 6567cfa..42d4ac0 100644 --- a/target

[Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread David Hildenbrand
Let's do it just like the other architectures. Introduce kvm-stub.c for stubs and kvm_s390x.h for the declarations. Add a fake declaration of struct kvm_s390_irq so we don't need other ugly CONFIG_KVM checks. Change license to GPL2+ and keep copyright notice. Suggested-by: Thomas Huth Signed-of

[Qemu-devel] [PATCH v1 for-2.11 06/10] target/s390x: introduce internal.h

2017-08-17 Thread David Hildenbrand
cpu.h should only contain what really has to be accessed outside of target/s390x/. Add internal.h which can only be used inside target/s390x/. Move everything that isn't fast enough to run away and restructure it right away. We'll move all kvm_* stuff later. Minor style fixes to avoid checkpatch

[Qemu-devel] [PATCH v1 for-2.11 08/10] s390x: avoid calling kvm_ functions outside of target/s390x/

2017-08-17 Thread David Hildenbrand
Let's just introduce an helper. Reviewed-by: Richard Henderson Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand --- hw/s390x/s390-virtio-ccw.c | 4 +--- target/s390x/cpu.c | 7 +++ target/s390x/cpu.h | 1 + 3 files changed, 9 insertions(+), 3 deletions(-) diff --g

Re: [Qemu-devel] [PATCH 18/26] qapi: add conditions to REPLICATION type/commands on the schema

2017-08-17 Thread Markus Armbruster
Marc-André Lureau writes: > Add #if defined(CONFIG_REPLICATION) in generated code, and adjust the > code accordingly. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 12 > migration/colo.c | 14 ++ > monitor.c| 5 - > 3 files changed, 10 ins

[Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h

2017-08-17 Thread David Hildenbrand
Let's reshuffle the function prototypes so we get a cleaner outline of the files. Reviewed-by: Richard Henderson Signed-off-by: David Hildenbrand --- target/s390x/cpu.h | 140 ++--- 1 file changed, 69 insertions(+), 71 deletions(-) diff --git a/t

Re: [Qemu-devel] [PATCH 16/26] qapi: add conditions to VNC type/commands/events on the schema

2017-08-17 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > >> Add #if defined(CONFIG_VNC) in generated code, and adjust the > >> qmp/hmp code accordingly. > >> > >> Signed-off-by: Marc-André Lureau > > > >>

Re: [Qemu-devel] [PATCH 1/6] tests: Run filter-redirector and -mirror test only on POSIX systems

2017-08-17 Thread David Hildenbrand
On 17.08.2017 08:25, Thomas Huth wrote: > This way we can get rid of the ugly #ifdefs in the code which makes > it easier to extend later. > > Signed-off-by: Thomas Huth Reviewed-by: David Hildenbrand -- Thanks, David

Re: [Qemu-devel] [PATCH for-2.11] intel_iommu: fix missing BQL in pt fast path

2017-08-17 Thread Paolo Bonzini
On 17/08/2017 07:56, Peter Xu wrote: > In vtd_switch_address_space() we did the memory region switch, however > it's possible that the caller of it has not taken the BQL at all. Make > sure we have it. > > CC: Paolo Bonzini > CC: Jason Wang > CC: Michael S. Tsirkin > Signed-off-by: Peter Xu >

Re: [Qemu-devel] [PATCH 3/6] tests: Enable the drive_del test also on s390x

2017-08-17 Thread David Hildenbrand
On 17.08.2017 10:53, Cornelia Huck wrote: > On Thu, 17 Aug 2017 08:25:10 +0200 > Thomas Huth wrote: > >> By using the "virtio-xxx" device name aliases instead of the >> "virtio-xxx-pci" names, we can use this test on s390x, too, >> to check that adding and deleting also works fine with the >> vir

Re: [Qemu-devel] [PATCH 4/6] tests: Introduce generic device hot-plug/hot-unplug functions

2017-08-17 Thread David Hildenbrand
On 17.08.2017 08:25, Thomas Huth wrote: > A lot of tests provide code for adding and removing a device via the > device_add and device_del QMP commands. Maintaining this code in so > many places is cumbersome and error-prone (some of the code parts > check the responses in an incorrect way, for exa

Re: [Qemu-devel] [PATCH 1/6] tests: Run filter-redirector and -mirror test only on POSIX systems

2017-08-17 Thread Zhang Chen
On 08/17/2017 02:25 PM, Thomas Huth wrote: This way we can get rid of the ugly #ifdefs in the code which makes it easier to extend later. Signed-off-by: Thomas Huth Reviewed-by: Zhang Chen It's better for my code. Thanks Zhang Chen --- tests/Makefile.include | 8 te

Re: [Qemu-devel] [PATCH RFC v2 01/10] gitignore: Ignore vm test images

2017-08-17 Thread Stefan Hajnoczi
On Thu, Aug 17, 2017 at 10:47:37AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > .gitignore | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH RFC v2 03/10] qemu.py: Add "wait()" method

2017-08-17 Thread Stefan Hajnoczi
On Thu, Aug 17, 2017 at 10:47:39AM +0800, Fam Zheng wrote: > Signed-off-by: Fam Zheng > --- > scripts/qemu.py | 7 +++ > 1 file changed, 7 insertions(+) It would be nice to unify this with shutdown() but it's okay for now. Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signa

Re: [Qemu-devel] [PATCH RFC v2 02/10] qemu.py: Add variable vga type

2017-08-17 Thread Stefan Hajnoczi
On Thu, Aug 17, 2017 at 10:47:38AM +0800, Fam Zheng wrote: > Some guests behave differently when no VGA is detected. Add a variable > to allow override the "none" default. > > Signed-off-by: Fam Zheng > --- > scripts/qemu.py | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by:

Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib

2017-08-17 Thread Fam Zheng
> +self._args = [ \ > +"-nodefaults", "-enable-kvm", "-m", "2G", > +"-smp", os.environ.get("J", "4"), "-cpu", "host", Forgot to change "J" to a command argument. Will fix when dropping RFC. Fam

Re: [Qemu-devel] [Qemu-arm] [PATCH 4/8] boards.h: Define new flag ignore_memory_transaction_failures

2017-08-17 Thread Peter Maydell
On 5 August 2017 at 11:13, Peter Maydell wrote: > On 4 August 2017 at 20:23, Richard Henderson > wrote: >> On 08/04/2017 11:09 AM, Philippe Mathieu-Daudé wrote: >>> Since create_unimplemented_device() register overlapped with low priority, >>> why >>> not register it as default device directly,

Re: [Qemu-devel] [PATCH v3 1/5] ppc: spapr: Register and handle HCALL to receive updated RTAS region

2017-08-17 Thread Nikunj A Dadhania
David Gibson writes: > On Wed, Aug 16, 2017 at 02:42:13PM +0530, Aravinda Prasad wrote: >> Receive updates from SLOF about the updated rtas-base. >> A separate patch for SLOF [1] adds functionality to invoke >> a private HCALL whenever OS issues instantiate-rtas with >> a new rtas-base. >> >> Th

[Qemu-devel] [PATCH] scsi-block: Add qdev error properties

2017-08-17 Thread Fam Zheng
This makes the werror/rerror options available on the scsi-block device, to allow user specify error handling policy in the same way as scsi-hd etc. Signed-off-by: Fam Zheng --- hw/scsi/scsi-disk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c inde

Re: [Qemu-devel] [PATCH] hw/arm: use defined type name instead of hard-coded string

2017-08-17 Thread Peter Maydell
On 31 July 2017 at 13:09, Peter Maydell wrote: > On 27 July 2017 at 14:48, Philippe Mathieu-Daudé wrote: >> On 07/27/2017 09:36 AM, Peter Maydell wrote: >>> >>> On 17 July 2017 at 14:30, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- Hi Peter, t

Re: [Qemu-devel] [PATCH v2 0/4] ARM: KVM: Enable in-kernel PMU with user space gic

2017-08-17 Thread Peter Maydell
On 8 August 2017 at 14:23, Andrew Jones wrote: > > Peter, > > ping? I've applied this to target-arm.next ready for the first 2.11 ARM pullreq. Sorry for the delay, I'd put not-for-2.10 patch review onto the back burner since I knew nothing was going to go into master til after the release... tha

[Qemu-devel] [PATCH 1/2] hmp: Missing handle_errors

2017-08-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" hmp_info_memdev && hmp_info_memory_devices were missing hmp_handle_error calls. Add them. Signed-off-by: Dr. David Alan Gilbert --- hmp.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hmp.c b/hmp.c index 10400386e0..dc6cf7d583 100644 --- a/hmp.c +++ b/hm

[Qemu-devel] [PATCH 2/2] hmp: Fix unknown command for subtable

2017-08-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" (qemu) info foo unknown command: 'foo' fix this to: (qemu) info foo unknown command: 'info foo' Reported-by: Markus Armbruster Signed-off-by: Dr. David Alan Gilbert --- monitor.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/monitor

[Qemu-devel] [PATCH 0/2 for 2.11] Minor HMP fixes

2017-08-17 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" A couple of minor HMP fixes Dr. David Alan Gilbert (2): hmp: Missing handle_errors hmp: Fix unknown command for subtable hmp.c | 2 ++ monitor.c | 7 --- 2 files changed, 6 insertions(+), 3 deletions(-) -- 2.13.5

Re: [Qemu-devel] [PATCH for 2.11 v2 0/2] wdt_aspeed: Support reset width patterns

2017-08-17 Thread Peter Maydell
On 9 August 2017 at 07:28, Andrew Jeffery wrote: > Hello, > > These two patches add support for the reset width configuration register in > the > Aspeed watchdog. Initially this was just one patch[1], but I've reworked it as > two to explicitly support the varying capabilities between Aspeed SoC

Re: [Qemu-devel] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-17 Thread David Gibson
On Tue, Aug 15, 2017 at 05:28:46PM -0300, Daniel Henrique Barboza wrote: > This patch is a follow up on the discussions that started with > Laurent's patch series "spapr: disable hotplugging without OS" [1] > and discussions made at patch "spapr: reset DRCs on migration > pre_load" [2]. > > At thi

Re: [Qemu-devel] [PATCH 02/28] mips: MIPSCPU model subclasses

2017-08-17 Thread Igor Mammedov
On Thu, 17 Aug 2017 00:38:59 -0300 Philippe Mathieu-Daudé wrote: > Hi Igor, > > On 07/15/2017 06:48 PM, Philippe Mathieu-Daudé wrote: > > On 07/14/2017 10:51 AM, Igor Mammedov wrote: > >> Register separate QOM types for each mips cpu model, > >> so it would be possible to reuse generic CPU cre

Re: [Qemu-devel] [PATCH 4/6] tests: Introduce generic device hot-plug/hot-unplug functions

2017-08-17 Thread Thomas Huth
On 17.08.2017 11:53, David Hildenbrand wrote: > On 17.08.2017 08:25, Thomas Huth wrote: >> A lot of tests provide code for adding and removing a device via the >> device_add and device_del QMP commands. Maintaining this code in so >> many places is cumbersome and error-prone (some of the code parts

[Qemu-devel] [PATCHv3 03/03] colo-compare: Update the COLO document to add the IOThread configuration

2017-08-17 Thread Wang yong
From: Wang Yong Update colo-proxy.txt,add IOThread configuration. Later we have to configure IOThread,if not COLO can not work. Signed-off-by: Wang Yong Signed-off-by: Wang Guang --- docs/colo-proxy.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/colo-proxy.txt

[Qemu-devel] [PATCHv3 00/03] Replace the COLO comparing thread with IOThread

2017-08-17 Thread Wang yong
From: Wang Yong It's a good idea to use IOThread instead of COLO comparing thread. comparing thread can be completely replaced by IOThread, so this idea came. This series of updates mainly include IOThread supports the GMainContext event loop, then the old packet regularly check and primary/seco

[Qemu-devel] [PATCHv3 01/03] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-17 Thread Wang yong
From: Wang Yong IOThread uses AioContext event loop and does not run a GMainContext. Therefore,chardev cannot work in IOThread,such as the chardev is used for colo-compare packets reception. This patch makes the IOThread run the GMainContext event loop, chardev and IOThread can work together. S

Re: [Qemu-devel] [PATCH v1 for-2.11 01/10] target/s390x: move cc_name() to cc_helper.c

2017-08-17 Thread Thomas Huth
On 17.08.2017 11:22, David Hildenbrand wrote: > While at it, move the translations into the function. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cc_helper.c | 48 > > target/s390x/cpu.h | 48 > +--

[Qemu-devel] [PATCHv3 02/03] colo-compare: Use IOThread to Check old packet regularly and Process pactkets of the primary

2017-08-17 Thread Wang yong
From: Wang Yong Remove the task which check old packet in the comparing thread, then use IOthread context timer to handle it. Process pactkets in the IOThread which arrived over the socket. we use iothread_get_g_main_context to create a new g_main_loop in the IOThread.then the packets from the p

Re: [Qemu-devel] [PATCH v1 for-2.11 02/10] target/s390x: move cpu_mmu_idx_to_asc() to excp_helper.c

2017-08-17 Thread Thomas Huth
On 17.08.2017 11:22, David Hildenbrand wrote: > Only used in that file. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 14 -- > target/s390x/excp_helper.c | 14 ++ > 2 files changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Thomas Huth

Re: [Qemu-devel] Guest init virtio-serial port failed randomly, qemu-kvm report error about guest failure in adding device virtio-serial0.0

2017-08-17 Thread Dr. David Alan Gilbert
* 皮智 (pizhi0...@gmail.com) wrote: > Hi,I meet a problem with vm(windows10), my environment is qemu-kvm-2.3, > virtio-win-0.1.126, host(centos7.2), guest(windows10). > I add four virtio-serial port to vm, if I hard reboot the vm(windows10), it > may happen as follows randomly: I'm not too sure how

Re: [Qemu-devel] [PATCH v7 3/4] qcow2: add shrink image support

2017-08-17 Thread Eric Blake
On 08/17/2017 04:15 AM, Pavel Butsykin wrote: > This patch add shrinking of the image file for qcow2. As a result, this allows > us to reduce the virtual image size and free up space on the disk without > copying the image. Image can be fragmented and shrink is done by punching > holes > in the im

Re: [Qemu-devel] [PATCH v1 for-2.11 04/10] target/s390x: move s390_do_cpu_reset() to diag.c

2017-08-17 Thread Thomas Huth
On 17.08.2017 11:22, David Hildenbrand wrote: > Only used in that file. Also drop the comment, not really needed. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 7 --- > target/s390x/diag.c | 7 +++ > 2 files changed, 7 insertions(+), 7 deletions(-) Reviewed-by: Thom

Re: [Qemu-devel] [PATCH v1 for-2.11 03/10] target/s390x: move psw_key_valid() to mem_helper.c

2017-08-17 Thread Thomas Huth
On 17.08.2017 11:22, David Hildenbrand wrote: > Only used in that file. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h| 11 --- > target/s390x/mem_helper.c | 11 +++ > 2 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH v1 for-2.11 05/10] target/s390x: move get_per_in_range() to misc_helper.c

2017-08-17 Thread Thomas Huth
On 17.08.2017 11:22, David Hildenbrand wrote: > Only used in that file. > > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 11 --- > target/s390x/misc_helper.c | 11 +++ > 2 files changed, 11 insertions(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [Qemu-devel] [PATCH 1/2] hmp: Missing handle_errors

2017-08-17 Thread Eric Blake
On 08/17/2017 05:42 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > hmp_info_memdev && hmp_info_memory_devices were missing > hmp_handle_error calls. Add them. > > Signed-off-by: Dr. David Alan Gilbert > --- > hmp.c | 2 ++ > 1 file changed, 2 insertions(+) Revie

Re: [Qemu-devel] [PATCH 2/2] hmp: Fix unknown command for subtable

2017-08-17 Thread Eric Blake
On 08/17/2017 05:42 AM, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > (qemu) info foo > unknown command: 'foo' > > fix this to: > (qemu) info foo > unknown command: 'info foo' > > Reported-by: Markus Armbruster > Signed-off-by: Dr. David Alan Gilbert > --- > monito

Re: [Qemu-devel] [PATCH 02/28] mips: MIPSCPU model subclasses

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 07:53 AM, Igor Mammedov wrote: On Thu, 17 Aug 2017 00:38:59 -0300 Philippe Mathieu-Daudé wrote: Hi Igor, On 07/15/2017 06:48 PM, Philippe Mathieu-Daudé wrote: On 07/14/2017 10:51 AM, Igor Mammedov wrote: Register separate QOM types for each mips cpu model, so it would be possi

Re: [Qemu-devel] [PATCH 4/6] tests: Introduce generic device hot-plug/hot-unplug functions

2017-08-17 Thread David Hildenbrand
On 17.08.2017 12:57, Thomas Huth wrote: > On 17.08.2017 11:53, David Hildenbrand wrote: >> On 17.08.2017 08:25, Thomas Huth wrote: >>> A lot of tests provide code for adding and removing a device via the >>> device_add and device_del QMP commands. Maintaining this code in so >>> many places is cumb

[Qemu-devel] [PATCH v2] spapr: fallback to raw mode if best compat mode cannot be set during CAS

2017-08-17 Thread Greg Kurz
KVM PR doesn't allow to set a compat mode. This causes ppc_set_compat_all() to fail and we return H_HARDWARE to the guest right away. This is excessive: even if we favor compat mode since commit 152ef803ceb19, we should at least fallback to raw mode if the guest supports it. This patch modifies c

[Qemu-devel] [Bug 821078] Re: virtio-serial-bus: Unexpected port id

2017-08-17 Thread Dr. David Alan Gilbert
This looks like https://bugzilla.redhat.com/show_bug.cgi?id=819412 which is about the same age. ** Bug watch added: Red Hat Bugzilla #819412 https://bugzilla.redhat.com/show_bug.cgi?id=819412 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed

Re: [Qemu-devel] [PATCH RFC v2 07/10] tests: Add NetBSD image

2017-08-17 Thread Kamil Rytarowski
On 17.08.2017 04:47, Fam Zheng wrote: > The image is prepared following instructions as in: > > https://wiki.qemu.org/Hosts/BSD > > Signed-off-by: Fam Zheng Reviewed-by: Kamil Rytarowski > --- > tests/vm/netbsd | 45 + > 1 file changed, 45 insertio

Re: [Qemu-devel] [PATCH v1 for-2.11 00/10] target/s390x: cleanup cpu.h

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 06:22 AM, David Hildenbrand wrote: cpu.h is accessed outside of target/s390x. It should only contain what is expected to be accessed outside of this folder. Therefore, create internal.h and move a lot to that file. In addition, introduce kvm-stub.c and kvm_390x.h for kvm specific fu

Re: [Qemu-devel] [PATCH 21/26] build-sys: make qemu qapi objects per-target

2017-08-17 Thread Markus Armbruster
Marc-André Lureau writes: > The qapi schema has per-target definitions. Move qapi objects in the > per-target build, so they can be configured at compile time. Suggest something like: QAPI can't do target-specific conditionals (the symbols are poisoned), and the work-around is to preten

Re: [Qemu-devel] [PATCH] scsi-block: Add qdev error properties

2017-08-17 Thread Paolo Bonzini
On 17/08/2017 12:28, Fam Zheng wrote: > This makes the werror/rerror options available on the scsi-block device, > to allow user specify error handling policy in the same way as scsi-hd > etc. > > Signed-off-by: Fam Zheng I'm not sure this is enough, because you would only obey the rerror/werror

Re: [Qemu-devel] [PATCHv3 01/03] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-17 Thread Paolo Bonzini
On 17/08/2017 12:58, Wang yong wrote: > From: Wang Yong > > IOThread uses AioContext event loop and does not run a GMainContext. > Therefore,chardev cannot work in IOThread,such as the chardev is > used for colo-compare packets reception. > > This patch makes the IOThread run the GMainContext ev

Re: [Qemu-devel] [PATCH 04/26] qapi: generate a literal qobject for introspection

2017-08-17 Thread Markus Armbruster
Marc-André Lureau writes: > Replace the generated json string with a literal qobject. The later is > easier to deal with, at run time, as well as compile time: #if blocks > can be more easily added than in a json string. > > Signed-off-by: Marc-André Lureau [...] > diff --git a/tests/test-qobjec

Re: [Qemu-devel] [PATCH 07/26] qapi: add 'if' condition on top-level schema elements

2017-08-17 Thread Markus Armbruster
Marc-André Lureau writes: > Add 'if' c-preprocessor condition on top-level schema elements: > struct, enum, union, alternate, command, event. > > Variants objects types are created outside of #if blocks, since they > may be shared by various types. Even if unused, this shouldn't be an > issue, si

Re: [Qemu-devel] [PATCH for-2.9?] configure: Remove unused code (found by shellcheck)

2017-08-17 Thread Philippe Mathieu-Daudé
On 03/28/2017 03:49 PM, Stefan Weil wrote: smartcard_cflags is no longer needed since commit 0b22ef0f57a8910d849602bef0940edcd0553d2c. leftover from afd347ab387 Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé --- This is a very old patch which I just found in my patch q

Re: [Qemu-devel] [PATCH 22/26] qapi: make rtc-reset-reinjection depend on TARGET_I386

2017-08-17 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json | 3 ++- > monitor.c| 10 -- > 2 files changed, 2 insertions(+), 11 deletions(-) > > diff --git a/qapi-schema.json b/qapi-schema.json > index 2f4528c769..2361c13fc8 100644 > --- a/qapi-schema.

Re: [Qemu-devel] [PATCH v1 for-2.11 06/10] target/s390x: introduce internal.h

2017-08-17 Thread Thomas Huth
On 17.08.2017 11:22, David Hildenbrand wrote: > cpu.h should only contain what really has to be accessed outside of > target/s390x/. Add internal.h which can only be used inside target/s390x/. > > Move everything that isn't fast enough to run away and restructure it > right away. We'll move all kv

Re: [Qemu-devel] [PATCH] scsi-block: Add qdev error properties

2017-08-17 Thread Fam Zheng
On Thu, 08/17 13:44, Paolo Bonzini wrote: > On 17/08/2017 12:28, Fam Zheng wrote: > > This makes the werror/rerror options available on the scsi-block device, > > to allow user specify error handling policy in the same way as scsi-hd > > etc. > > > > Signed-off-by: Fam Zheng > > I'm not sure thi

Re: [Qemu-devel] [PATCH 23/26] qapi: make s390 commands depend on TARGET_S390X

2017-08-17 Thread Markus Armbruster
Marc-André Lureau writes: > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json| 10 +++--- > include/sysemu/arch_init.h | 6 -- > monitor.c | 14 -- > qmp.c | 14

Re: [Qemu-devel] [PATCH] scsi-block: Add qdev error properties

2017-08-17 Thread Paolo Bonzini
On 17/08/2017 14:03, Fam Zheng wrote: > On Thu, 08/17 13:44, Paolo Bonzini wrote: >> On 17/08/2017 12:28, Fam Zheng wrote: >>> This makes the werror/rerror options available on the scsi-block device, >>> to allow user specify error handling policy in the same way as scsi-hd >>> etc. >>> >>> Signed-

Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread David Hildenbrand
>> +#include "qemu/osdep.h" >> +#include "qemu-common.h" >> +#include "cpu.h" >> +#include "kvm_s390x.h" > > here goes the: > > struct kvm_s390_irq {}; As we don't have a stub using kvm_s390_irq, I guess I can just drop this for now. [...] > > change by > > typedef struct kvm_s390_irq kvm_s3

Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib

2017-08-17 Thread Stefan Hajnoczi
On Thu, Aug 17, 2017 at 10:47:40AM +0800, Fam Zheng wrote: > +self._args = [ \ > +"-nodefaults", "-enable-kvm", "-m", "2G", > +"-smp", os.environ.get("J", "4"), "-cpu", "host", I suggested making -j a command-line argument and constructor argument instead of using a

Re: [Qemu-devel] [PATCH RFC v2 04/10] tests: Add vm test lib

2017-08-17 Thread Paolo Bonzini
On 17/08/2017 14:21, Stefan Hajnoczi wrote: >> +guest = QEMUMachine(binary=os.environ.get("QEMU", >> "qemu-system-x86_64"), >> +args=args) >> +guest._vga = "std" > _vga is a protected field. We don't inherit from QEMUMachine so it > shouldn't be accesse

Re: [Qemu-devel] [PATCH 26/26] qapi: make query-cpu-definitions depend on specific targets

2017-08-17 Thread Markus Armbruster
Marc-André Lureau writes: > It depends on TARGET_PPC || TARGET_ARM || TARGET_I386 || TARGET_S390X. > > Signed-off-by: Marc-André Lureau > --- > qapi-schema.json| 4 +++- > include/sysemu/arch_init.h | 2 -- > monitor.c | 22 -- > qmp.c

Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread Thomas Huth
On 17.08.2017 13:40, Philippe Mathieu-Daudé wrote: > Hi David, > > On 08/17/2017 06:22 AM, David Hildenbrand wrote: >> Let's do it just like the other architectures. Introduce kvm-stub.c >> for stubs and kvm_s390x.h for the declarations. >> >> Add a fake declaration of struct kvm_s390_irq so we do

Re: [Qemu-devel] [PULL 7/7] hw/misc/mmio_interface: Return after error_setg() to avoid crash

2017-08-17 Thread KONRAD Frederic
On 08/14/2017 01:55 PM, Peter Maydell wrote: On 14 August 2017 at 12:52, Thomas Huth wrote: On 14.08.2017 13:45, Peter Maydell wrote: It seems like it should be an error to permit this to be created from the command line at all That's also what thought first ... but the commit message of

Re: [Qemu-devel] [PATCH v1 for-2.11 10/10] target/s390x: cleanup cpu.h

2017-08-17 Thread Thomas Huth
On 17.08.2017 11:22, David Hildenbrand wrote: > Let's reshuffle the function prototypes so we get a cleaner outline > of the files. > > Reviewed-by: Richard Henderson > Signed-off-by: David Hildenbrand > --- > target/s390x/cpu.h | 140 > ++--- >

Re: [Qemu-devel] [PATCH 26/26] qapi: make query-cpu-definitions depend on specific targets

2017-08-17 Thread Marc-André Lureau
Hi On Thu, Aug 17, 2017 at 2:30 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > It depends on TARGET_PPC || TARGET_ARM || TARGET_I386 || TARGET_S390X. > > > > Signed-off-by: Marc-André Lureau > > --- > > qapi-schema.json| 4 +++- > > include/sysemu/arch_init.h | 2

Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread Philippe Mathieu-Daudé
On 08/17/2017 09:35 AM, Thomas Huth wrote: On 17.08.2017 13:40, Philippe Mathieu-Daudé wrote: Hi David, On 08/17/2017 06:22 AM, David Hildenbrand wrote: Let's do it just like the other architectures. Introduce kvm-stub.c for stubs and kvm_s390x.h for the declarations. Add a fake declaration o

Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 14:35:53 +0200 Thomas Huth wrote: > On 17.08.2017 13:40, Philippe Mathieu-Daudé wrote: > > Hi David, > > > > On 08/17/2017 06:22 AM, David Hildenbrand wrote: > >> Let's do it just like the other architectures. Introduce kvm-stub.c > >> for stubs and kvm_s390x.h for the decl

Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread David Hildenbrand
On 17.08.2017 14:48, Cornelia Huck wrote: > On Thu, 17 Aug 2017 14:35:53 +0200 > Thomas Huth wrote: > >> On 17.08.2017 13:40, Philippe Mathieu-Daudé wrote: >>> Hi David, >>> >>> On 08/17/2017 06:22 AM, David Hildenbrand wrote: Let's do it just like the other architectures. Introduce kvm-st

Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread David Hildenbrand
On 17.08.2017 14:35, Thomas Huth wrote: > On 17.08.2017 13:40, Philippe Mathieu-Daudé wrote: >> Hi David, >> >> On 08/17/2017 06:22 AM, David Hildenbrand wrote: >>> Let's do it just like the other architectures. Introduce kvm-stub.c >>> for stubs and kvm_s390x.h for the declarations. >>> >>> Add a

[Qemu-devel] [PATCH] follow-up path - " qcow2: add shrink image support"

2017-08-17 Thread Pavel Butsykin
Signed-off-by: Pavel Butsykin --- qapi/block-core.json | 5 + 1 file changed, 5 insertions(+) diff --git a/qapi/block-core.json b/qapi/block-core.json index d6172bfe15..c55cd0c8db 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2479,6 +2479,11 @@ # # Trigger events support

Re: [Qemu-devel] [PATCH v1 for-2.11 09/10] s390x/kvm: move KVM declarations and stubs to separate files

2017-08-17 Thread Cornelia Huck
On Thu, 17 Aug 2017 14:53:08 +0200 David Hildenbrand wrote: > On 17.08.2017 14:48, Cornelia Huck wrote: > > On Thu, 17 Aug 2017 14:35:53 +0200 > > Thomas Huth wrote: > > > >> On 17.08.2017 13:40, Philippe Mathieu-Daudé wrote: > >>> Hi David, > >>> > >>> On 08/17/2017 06:22 AM, David Hildenb

  1   2   3   >