[Qemu-devel] [PATCH v2 2/2] block: add filter driver to block/write-threshold.c

2017-08-15 Thread Manos Pitsidianakis
With runtime insertion and removal of filters, write-threshold.c can provide more flexible deliveries of BLOCK_WRITE_THRESHOLD events. After the event trigger, the filter nodes are no longer useful and must be removed. The existing write-threshold cannot be easily converted to using the filter driv

[Qemu-devel] [PATCH v2 0/2] add internal backup job and write-threshold filter drivers

2017-08-15 Thread Manos Pitsidianakis
This is part of my GSOC project, which is refactoring hardcoded block layer features into filter drivers. Block filter drivers are inserted into the graph only when a feature is needed. This makes the block layer more modular and reuses the block driver abstraction that is already present. Before

[Qemu-devel] [PATCH v2 1/2] block: use internal filter node in backup

2017-08-15 Thread Manos Pitsidianakis
block/backup.c currently uses before write notifiers on the targeted node. We can create a filter node instead to intercept write requests for the backup job on the BDS level, instead of the BlockBackend level. This is part of deprecating before write notifiers, which are hard coded into the block

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
On Mon, Aug 14, 2017 at 05:39:08PM +0100, Daniel P. Berrange wrote: > On Mon, Aug 14, 2017 at 05:21:40PM +0100, Stefan Hajnoczi wrote: > > The SystemTap flight recorder mode no longer works with simpletrace.stp > > because > > the event ID mapping records are emitted the first time an event fires.

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
On Mon, Aug 14, 2017 at 09:45:19AM -0700, no-re...@patchew.org wrote: > === OUTPUT BEGIN === > Checking PATCH 1/2: trace: use static event ID mapping in simpletrace.stp... > Checking PATCH 2/2: simpletrace: fix flight recorder --no-header option... > ERROR: line over 90 characters > #39: FILE: scri

Re: [Qemu-devel] [PATCH] ppc: fix ppc_set_compat() with KVM PR

2017-08-15 Thread Greg Kurz
On Tue, 15 Aug 2017 11:40:34 +1000 Suraj Jitindar Singh wrote: > On Mon, 2017-08-14 at 19:49 +0200, Greg Kurz wrote: > > When running in KVM PR mode, kvmppc_set_compat() always fail because > > the > > current PR implementation doesn't handle KVM_REG_PPC_ARCH_COMPAT. Now > > that > > the machine

Re: [Qemu-devel] [PATCH v6 4/7] qemu.py: improve message on negative exit code

2017-08-15 Thread Markus Armbruster
Amador Pahim writes: > The current message shows 'self._args', which contains only part of the > options used in the qemu command line. > > This patch makes the qemu full args list an instance variable and then > uses it in the negative exit code message. > > Signed-off-by: Amador Pahim > --- >

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Thomas Huth
On 15.08.2017 10:01, Thomas Huth wrote: > On 15.08.2017 09:03, Cornelia Huck wrote: >> On Tue, 15 Aug 2017 07:02:10 +0200 >> Thomas Huth wrote: >> >>> On 14.08.2017 22:44, Eric Farman wrote: How often does one really do a "make clean" ? Rather infrequently, as I only stumbled on this to

Re: [Qemu-devel] [PATCH for-2.10 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
On Mon, Aug 14, 2017 at 05:39:08PM +0100, Daniel P. Berrange wrote: > On Mon, Aug 14, 2017 at 05:21:40PM +0100, Stefan Hajnoczi wrote: > > The SystemTap flight recorder mode no longer works with simpletrace.stp > > because > > the event ID mapping records are emitted the first time an event fires.

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Cornelia Huck
On Tue, 15 Aug 2017 10:26:18 +0200 Thomas Huth wrote: > On 15.08.2017 10:01, Thomas Huth wrote: > > On 15.08.2017 09:03, Cornelia Huck wrote: > >> On Tue, 15 Aug 2017 07:02:10 +0200 > >> Thomas Huth wrote: > >> > >>> On 14.08.2017 22:44, Eric Farman wrote: > How often does one really

Re: [Qemu-devel] [RFC 5/6] migration: store listen task tag

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 02:17:06PM +0800, Peter Xu wrote: > Store the task tag for migration types: tcp/unix/fd/exec in current > MigrationIncomingState struct. > > For defered migration, no need to store task tag since there is no task > running in the main loop at all. For RDMA, let's mark it as

Re: [Qemu-devel] [PATCH v3 00/12] Convert over to use keycodemapdb

2017-08-15 Thread Daniel P. Berrange
On Mon, Aug 14, 2017 at 02:46:22PM -0400, Programmingkid wrote: > Sorry but there appears to be an issue with your patchset. I ran this command: > > ./configure --target-list=ppc-softmmu,i386-softmmu > > Then saw this error message: > > error: pathspec 'ui/keycodemapdb' did not match any file(s

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Thomas Huth
On 15.08.2017 10:32, Cornelia Huck wrote: > On Tue, 15 Aug 2017 10:26:18 +0200 > Thomas Huth wrote: [...] >> The parameter -R disables the built-in variables, so RM can indeed not >> work here. Sorry, I wasn't aware of that setting yet, so your patch is >> indeed the right fix here (or we should m

[Qemu-devel] [PATCH for-2.10 v2 0/2] trace: fix simpletrace.stp flight recorder mode

2017-08-15 Thread Stefan Hajnoczi
v2: * Don't emit event ID mapping records in simpletrace.stp [Daniel Berrange] The SystemTap flight recorder mode no longer works with simpletrace.stp because the event ID mapping records are emitted the first time an event fires. Chances are, the event ID mapping record will not be in ring buffe

[Qemu-devel] [PATCH for-2.10 v2 1/2] trace: use static event ID mapping in simpletrace.stp

2017-08-15 Thread Stefan Hajnoczi
This is a partial revert of commit 7f1b588f20d027730676e627713ae3bbf6baab04 ("trace: emit name <-> ID mapping in simpletrace header"), which broke the SystemTap flight recorder because event mapping records may not be present in the ring buffer when the trace is analyzed. This means simpletrace.py

[Qemu-devel] [PATCH for-2.10 v2 2/2] simpletrace: fix flight recorder --no-header option

2017-08-15 Thread Stefan Hajnoczi
The simpletrace.py script can pretty-print flight recorder ring buffers. These are not full simpletrace binary trace files but just the end of a trace file. There is no header and the event ID mapping information is often unavailable since the ring buffer may have filled up and discarded event ID

Re: [Qemu-devel] [PATCH 4/4] docker: add centos7 image

2017-08-15 Thread Fam Zheng
On Fri, 07/28 20:33, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/centos7.docker | 31 +++ > 1 file changed, 31 insertions(+) > create mode 100644 tests/docker/dockerfiles/centos7.docker > > diff --git a/tests

Re: [Qemu-devel] [PATCH v6 6/7] qemu.py: cleanup and improve launch()/shutdown()

2017-08-15 Thread Markus Armbruster
Amador Pahim writes: > launch() is currently taking care of a number of flows, each one if its > own exception treatment, depending on the VM state and the files > creation state. > > This patch makes launch() more resilient, off-loading the core calls to > the new _launch() and calling shutdown(

Re: [Qemu-devel] [PATCH for-2.10 v2 1/2] trace: use static event ID mapping in simpletrace.stp

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 09:44:29AM +0100, Stefan Hajnoczi wrote: > This is a partial revert of commit > 7f1b588f20d027730676e627713ae3bbf6baab04 ("trace: emit name <-> ID > mapping in simpletrace header"), which broke the SystemTap flight > recorder because event mapping records may not be present

Re: [Qemu-devel] [RFC 5/6] migration: store listen task tag

2017-08-15 Thread Peter Xu
On Tue, Aug 15, 2017 at 09:37:14AM +0100, Daniel P. Berrange wrote: > On Tue, Aug 15, 2017 at 02:17:06PM +0800, Peter Xu wrote: > > Store the task tag for migration types: tcp/unix/fd/exec in current > > MigrationIncomingState struct. > > > > For defered migration, no need to store task tag since

Re: [Qemu-devel] [PATCH for-2.10 v2 2/2] simpletrace: fix flight recorder --no-header option

2017-08-15 Thread Daniel P. Berrange
On Tue, Aug 15, 2017 at 09:44:30AM +0100, Stefan Hajnoczi wrote: > The simpletrace.py script can pretty-print flight recorder ring buffers. > These are not full simpletrace binary trace files but just the end of a > trace file. There is no header and the event ID mapping information is > often una

Re: [Qemu-devel] [PATCH v6 7/7] qemu.py: include debug information on launch error

2017-08-15 Thread Markus Armbruster
Amador Pahim writes: > When launching a VM, if an exception happens and the VM is not > initiated, it is useful to see the qemu command line that was executed > and the output of that command. > > Before this patch: > > >>> import qemu > >>> vm = qemu.QEMUMachine('qemu-system-aarch64', de

[Qemu-devel] [PATCH v5 05/10] qemu.py: Use custom exceptions rather than Exception

2017-08-15 Thread Lukáš Doktor
The naked Exception should not be widely used. It makes sense to be a bit more specific and use better-suited custom exceptions. As a benefit we can store the full reply in the exception in case someone needs it when catching the exception. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost

[Qemu-devel] [PATCH v5 04/10] qemu.py: Simplify QMP key-conversion

2017-08-15 Thread Lukáš Doktor
The QMP key conversion consist of '_'s to be replaced with '-'s, which can easily be done by a single `str.replace` method which is faster and does not require `string` module import. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost --- scripts/qemu.py | 5 + 1 file changed, 1 inser

[Qemu-devel] [PATCH v5 07/10] qmp.py: Use object-based class for QEMUMonitorProtocol

2017-08-15 Thread Lukáš Doktor
There is no need to define QEMUMonitorProtocol as old-style class. Signed-off-by: Lukáš Doktor Reviewed-by: Eduardo Habkost --- scripts/qmp/qmp-shell | 4 ++-- scripts/qmp/qmp.py| 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/scripts/qmp/qmp-shell b/scripts/qmp/qmp-sh

<    1   2   3