[Qemu-devel] [PATCH v2 for-2.10 0/3] Fixup logic for exclusive pair

2017-08-15 Thread Richard Henderson
In reviewing my previous patch, Peter pointed out that it is CONSTRAINED UNPREDICTABLE what happens when you mix the number of registers in a LDX[PR] + STX[RP] pair. So most of the bug that I thought that I was fixing isn't a bug at all. That said, the patch does still fix a real bug wrt single-c

[Qemu-devel] [PATCH v2 for-2.10 1/3] target/arm: Correct exclusive store cmpxchg memop mask

2017-08-15 Thread Richard Henderson
From: Alistair Francis When we perform the atomic_cmpxchg operation we want to perform the operation on a pair of 32-bit registers. Previously we were just passing the register size in which was set to MO_32. This would result in the high register to be ignored. To fix this issue we hardcode the

[Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Richard Henderson
From: Alistair Francis Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update the memops used for the load to match that of the store. This adds the alignment requirement to the memops. Reviewed-by: Edgar E. Iglesias Signed-off-by: Alistair Francis

[Qemu-devel] [PULL for 2.10-rc3 0/7] NBD changes for 2.10-rc3

2017-08-15 Thread Eric Blake
The following changes since commit 47025a0193f1f910300adfa443305ccf8482ef87: qxl: call qemu_spice_display_init_common for secondary devices (2017-08-15 15:04:51 +0100) are available in the git repository at: git://repo.or.cz/qemu/ericb.git tags/pull-nbd-2017-08-15 for you to fetch changes

[Qemu-devel] [PULL 2/7] qemu-iotests: step clock after each test iteration

2017-08-15 Thread Eric Blake
From: Stefan Hajnoczi The 093 throttling test submits twice as many requests as the throttle limit in order to ensure that we reach the limit. The remaining requests are left in-flight at the end of each test iteration. Commit 452589b6b47e8dc6353df257fc803dfc1383bed8 ("vl.c/exit: pause cpus bef

[Qemu-devel] [PULL 1/7] nbd: Fix trace message for disconnect

2017-08-15 Thread Eric Blake
NBD_CMD_DISC is a disconnect request, not a data discard request. Signed-off-by: Eric Blake Message-Id: <20170811015749.20365-1-ebl...@redhat.com> Reviewed-by: Stefan Hajnoczi --- nbd/common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nbd/common.c b/nbd/common.c index

[Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Eric Blake
When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting in the client hanging when it never rea

[Qemu-devel] [PULL 3/7] stubs: Add vm state change handler stubs

2017-08-15 Thread Eric Blake
From: Fam Zheng They will be used by BlockBackend code in block-obj-y, which doesn't always get linked with common-obj-y. Add stubs to keep ld happy. Signed-off-by: Fam Zheng Message-Id: <20170815130740.31229-2-f...@redhat.com> Signed-off-by: Eric Blake --- stubs/change-state-handler.c | 14 +

[Qemu-devel] [PULL 5/7] block-backend: Defer shared_perm tightening migration completion

2017-08-15 Thread Eric Blake
From: Fam Zheng As in the case of nbd_export_new(), bdrv_invalidate_cache() can be called when migration is still in progress. In this case we are not ready to tighten the shared permissions fenced by blk->disable_perm. Defer to a VM state change handler. Signed-off-by: Fam Zheng Message-Id: <

[Qemu-devel] [PULL 4/7] nbd: Fix order of bdrv_set_perm and bdrv_invalidate_cache

2017-08-15 Thread Eric Blake
From: Kevin Wolf The "inactive" state of BDS affects whether the permissions can be granted, we must call bdrv_invalidate_cache before bdrv_set_perm to support "-incoming defer" case. Reported-by: Christian Ehrhardt Signed-off-by: Fam Zheng Message-Id: <20170815130740.31229-3-f...@redhat.com>

[Qemu-devel] [PULL 6/7] iotests: Add non-shared storage migration case 192

2017-08-15 Thread Eric Blake
From: Fam Zheng Signed-off-by: Fam Zheng Message-Id: <20170815130740.31229-5-f...@redhat.com> Tested-by: Eric Blake Signed-off-by: Eric Blake --- tests/qemu-iotests/192 | 63 ++ tests/qemu-iotests/192.out | 7 ++ tests/qemu-iotests/group

Re: [Qemu-devel] [PATCH v2 for-2.11 2/2] tests/pxe: Check virtio-net-ccw on s390x

2017-08-15 Thread Cornelia Huck
On Fri, 11 Aug 2017 07:57:56 +0200 Thomas Huth wrote: > Now that we've got a firmware that can do TFTP booting on s390x (i.e. > the pc-bios/s390-netboot.img), we can enable the PXE tester for this > architecture, too. > > Signed-off-by: Thomas Huth > --- > tests/Makefile.include | 1 + > test

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Eric Blake
On 08/15/2017 09:57 AM, Richard Henderson wrote: > From: Alistair Francis > > Acording to the ARM ARM exclusive loads require the same allignment as s/Acording/According/ s/allignmnet/alignment/ > exclusive stores. Let's update the memops used for the load to match > that of the store. This add

Re: [Qemu-devel] [PATCH v2 for-2.11 0/2] Improvements for the pxe tester

2017-08-15 Thread Cornelia Huck
On Fri, 11 Aug 2017 07:57:54 +0200 Thomas Huth wrote: > The first patch improves the buffer handling in the pxe tester a > little bit by allocating a separate buffer on the heap for each > architecture. This also gets rid of the huge pre-initialized > array in the tester, shrinking the size of th

Re: [Qemu-devel] [PATCH v2 for-2.10 1/3] target/arm: Correct exclusive store cmpxchg memop mask

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 11:57 AM, Richard Henderson wrote: From: Alistair Francis When we perform the atomic_cmpxchg operation we want to perform the operation on a pair of 32-bit registers. Previously we were just passing the register size in which was set to MO_32. This would result in the high registe

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-08-15 Thread Vadim Galitsyn
Hi Guys, Thank you for the input! > "hotunpluggable" is ugly. What about just "pluggable"? Markus, I think "pluggable" is a bit misleading here. Some people can take it like a maximum amount of memory that can be hot-added to a guest (i.e., difference between static memory size and value specif

Re: [Qemu-devel] [PATCH v5 3/3] hmp: introduce 'info memory-size-summary' command

2017-08-15 Thread Vadim Galitsyn
Hi Eric, Thank you for the input. I will update it with the next version. Btw, most of HMP "info *" commands use '-' instead of '_' in names =) Best regards, Vadim On Fri, Jul 28, 2017 at 8:27 PM, Eric Blake wrote: > On 07/28/2017 07:10 AM, Vadim Galitsyn wrote: > > This command is an equivale

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Richard Henderson
On 08/14/2017 08:33 AM, Cornelia Huck wrote: > On Mon, 14 Aug 2017 17:34:15 +0300 > "Michael S. Tsirkin" wrote: > >> Speed up tests on host systems with kvm support. >> In particular, this fixes tests with --disable-tcg. >> >> Cc: Paolo Bonzini >> Cc: Thomas Huth >> Cc: Laurent Vivier >> Sugge

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Vladimir Sementsov-Ogievskiy
15.08.2017 18:09, Eric Blake wrote: When we switched NBD to use coroutines for qemu 2.9 (in particular, commit a12a712a), we introduced a regression: if a server sends us garbage (such as a corrupted magic number), we quit the read loop but do not stop sending further queued commands, resulting i

[Qemu-devel] [PATCH] PCI: PCIe access should always be little endian

2017-08-15 Thread Matt Redfearn
PCIe busses are always little endian, so set the endianness of the memory region to little endian rather than native such that operations work as expected on big endian targets. Signed-off-by: Matt Redfearn --- hw/pci/pcie_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Philippe Mathieu-Daudé
Hi Richard, On 08/15/2017 11:57 AM, Richard Henderson wrote: From: Alistair Francis Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update the memops used for the load to match that of the store. This adds the alignment requirement to the memops.

Re: [Qemu-devel] [PATCH] target-i386/cpu: Add new EYPC CPU model

2017-08-15 Thread Brijesh Singh
Hi Eduardo, On 08/15/2017 06:35 AM, Eduardo Habkost wrote: Hi, Thanks for the patch. On Mon, Aug 14, 2017 at 10:52:17AM -0500, Brijesh Singh wrote: Add a new base CPU model called 'EPYC' to model processors from AMD EPYC family (which includes EPYC 76xx,75xx,74xx,73xx and 72xx). I suggest

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-08-15 Thread Igor Mammedov
On Tue, 15 Aug 2017 17:43:00 +0200 Vadim Galitsyn wrote: > Hi Guys, > > Thank you for the input! > > > "hotunpluggable" is ugly. What about just "pluggable"? > > Markus, I think "pluggable" is a bit misleading here. Some people can take > it like a maximum amount of memory that can be hot-a

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 16:56, Philippe Mathieu-Daudé wrote: > Hi Richard, > > On 08/15/2017 11:57 AM, Richard Henderson wrote: >> >> From: Alistair Francis >> >> Acording to the ARM ARM exclusive loads require the same allignment as >> exclusive stores. Let's update the memops used for the load to

Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable

2017-08-15 Thread Thomas Huth
On 15.08.2017 16:30, Peter Maydell wrote: > The mmio-interface device is not something we want to allow > users to create on the command line: > * it is intended as an implementation detail of the memory >subsystem, which gets created and deleted by that >subsystem on demand; it makes no s

Re: [Qemu-devel] [PATCH v2 for-2.10 1/3] target/arm: Correct exclusive store cmpxchg memop mask

2017-08-15 Thread Alistair Francis
On Tue, Aug 15, 2017 at 8:41 AM, Philippe Mathieu-Daudé wrote: > On 08/15/2017 11:57 AM, Richard Henderson wrote: >> >> From: Alistair Francis >> >> When we perform the atomic_cmpxchg operation we want to perform the >> operation on a pair of 32-bit registers. Previously we were just passing >> t

Re: [Qemu-devel] [RFC v4 02/13] qapi: qobject_compare() helper

2017-08-15 Thread Eric Blake
On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > The helper function will be useful when writing support code to > deal with device slot information. > > TODO: documentation is incomplete and unclear, needs to be > improved. > > Signed-off-by: Eduardo Habkost > --- > include/qapi/util.h| 39

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Richard Henderson
On 08/15/2017 08:56 AM, Philippe Mathieu-Daudé wrote: >> @@ -1885,7 +1886,7 @@ static void gen_load_exclusive(DisasContext *s, int rt, >> int rt2, >> tcg_gen_mov_i64(cpu_reg(s, rt2), cpu_exclusive_high); >> } >> } else { >> -memop |= size; >> +memop |=

[Qemu-devel] How to implement different endian accesses per MMU page?

2017-08-15 Thread Mark Cave-Ayland
Hi all, Working through an incorrect endian issue on qemu-system-sparc64, it has become apparent that at least one OS makes use of the IE (Invert Endian) bit in the SPARCv9 MMU TTE to map PCI memory space without the programmer having to manually endian-swap accesses. In other words, to quote the

[Qemu-devel] [RFC PATCH 0/2] tests: avoid kvm accel when it is not accessible

2017-08-15 Thread Philippe Mathieu-Daudé
This series reduce warnings when kvm is not accessible: - kernel without kvm: # make check-qtest-x86_64 GTESTER check-qtest-x86_64 Could not access KVM kernel module: No such device qemu-system-x86_64: failed to initialize KVM: No such device qemu-system-x86_64: Back to tcg

[Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Philippe Mathieu-Daudé
only warn once about it. - kernel without kvm: # make check-qtest-x86_64 GTESTER check-qtest-x86_64 Could not access KVM kernel module: No such device qemu-system-x86_64: failed to initialize KVM: No such device qemu-system-x86_64: Back to tcg accelerator - tests ran as use

[Qemu-devel] [PATCH 2/2] tests: use qtest_accel()

2017-08-15 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- tests/bios-tables-test.c | 2 +- tests/boot-serial-test.c | 5 +++-- tests/postcopy-test.c| 10 ++ tests/pxe-test.c | 5 +++-- tests/vmgenid-test.c | 4 ++-- 5 files changed, 15 insertions(+), 11 deletions(-) diff --git a/test

Re: [Qemu-devel] [PULL 7/7] nbd-client: Fix regression when server sends garbage

2017-08-15 Thread Eric Blake
On 08/15/2017 10:50 AM, Vladimir Sementsov-Ogievskiy wrote: > 15.08.2017 18:09, Eric Blake wrote: >> When we switched NBD to use coroutines for qemu 2.9 (in particular, >> commit a12a712a), we introduced a regression: if a server sends us >> garbage (such as a corrupted magic number), we quit the r

[Qemu-devel] [PATCH v3] target-i386/cpu: Add new EPYC CPU model

2017-08-15 Thread Brijesh Singh
Add a new base CPU model called 'EPYC' to model processors from AMD EPYC family (which includes EPYC 76xx,75xx,74xx, 73xx and 72xx). The following features bits have been added/removed compare to Opteron_G5 Added: monitor, movbe, rdrand, mmxext, ffxsr, rdtscp, cr8legacy, osvw, fsgsbase, bm

Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 17:16, Thomas Huth wrote: > On 15.08.2017 16:30, Peter Maydell wrote: >> The mmio-interface device is not something we want to allow >> users to create on the command line: >> * it is intended as an implementation detail of the memory >>subsystem, which gets created and d

Re: [Qemu-devel] [PATCH v2 for-2.10 0/3] Fixup logic for exclusive pair

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 15:57, Richard Henderson wrote: > In reviewing my previous patch, Peter pointed out that it is > CONSTRAINED UNPREDICTABLE what happens when you mix the number > of registers in a LDX[PR] + STX[RP] pair. So most of the bug > that I thought that I was fixing isn't a bug at all

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 01:14 PM, Peter Maydell wrote: On 15 August 2017 at 16:56, Philippe Mathieu-Daudé wrote: Hi Richard, On 08/15/2017 11:57 AM, Richard Henderson wrote: From: Alistair Francis Acording to the ARM ARM exclusive loads require the same allignment as exclusive stores. Let's update t

Re: [Qemu-devel] [PATCH v2 for-2.10 3/3] target/arm: Require alignment for load exclusive

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 01:32 PM, Richard Henderson wrote: On 08/15/2017 08:56 AM, Philippe Mathieu-Daudé wrote: @@ -1885,7 +1886,7 @@ static void gen_load_exclusive(DisasContext *s, int rt, int rt2, tcg_gen_mov_i64(cpu_reg(s, rt2), cpu_exclusive_high); } } else { -

Re: [Qemu-devel] [PULL for 2.10-rc3 0/7] NBD changes for 2.10-rc3

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 16:09, Eric Blake wrote: > The following changes since commit 47025a0193f1f910300adfa443305ccf8482ef87: > > qxl: call qemu_spice_display_init_common for secondary devices (2017-08-15 > 15:04:51 +0100) > > are available in the git repository at: > > git://repo.or.cz/qemu/e

Re: [Qemu-devel] [RFC v4 02/13] qapi: qobject_compare() helper

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 11:16:57AM -0500, Eric Blake wrote: > On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > > The helper function will be useful when writing support code to > > deal with device slot information. > > > > TODO: documentation is incomplete and unclear, needs to be > > improved. >

Re: [Qemu-devel] How to implement different endian accesses per MMU page?

2017-08-15 Thread Richard Henderson
[CC Peter re MemTxAttrs below] On 08/15/2017 09:38 AM, Mark Cave-Ayland wrote: > Working through an incorrect endian issue on qemu-system-sparc64, it has > become apparent that at least one OS makes use of the IE (Invert Endian) > bit in the SPARCv9 MMU TTE to map PCI memory space without the > pr

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Eric Blake
On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: > only warn once about it. > > - kernel without kvm: > > # make check-qtest-x86_64 > GTESTER check-qtest-x86_64 > Could not access KVM kernel module: No such device > qemu-system-x86_64: failed to initialize KVM: No such devi

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 03:13 PM, Eric Blake wrote: On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: only warn once about it. - kernel without kvm: # make check-qtest-x86_64 GTESTER check-qtest-x86_64 Could not access KVM kernel module: No such device qemu-system-x86_64: faile

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Peter Maydell
On 15 August 2017 at 19:27, Philippe Mathieu-Daudé wrote: > On 08/15/2017 03:13 PM, Eric Blake wrote: >> >> On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: >>> >>> only warn once about it. >>> >>> - kernel without kvm: >>> >>> # make check-qtest-x86_64 >>>GTESTER check-qtest-x86

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Eric Blake
On 08/15/2017 01:27 PM, Philippe Mathieu-Daudé wrote: > On 08/15/2017 03:13 PM, Eric Blake wrote: >> On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: >>> only warn once about it. >>> >>> - kernel without kvm: >>> >>> # make check-qtest-x86_64 >>>GTESTER check-qtest-x86_64 >>>

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-15 Thread Programmingkid
> On Aug 14, 2017, at 2:51 AM, Paolo Bonzini wrote: > > On 13/08/2017 21:13, Programmingkid wrote: >> Lately I found out that Windows NT 4.0 seems to work well with the >> 486 and pentium processors. Using "-cpu 486" made installing it >> actually work. Now I am seeing another issue. When I boot

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Eric Blake
On 08/15/2017 01:40 PM, Eric Blake wrote: > On 08/15/2017 01:27 PM, Philippe Mathieu-Daudé wrote: >> On 08/15/2017 03:13 PM, Eric Blake wrote: >>> On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: only warn once about it. - kernel without kvm: # make check-qtest-x8

Re: [Qemu-devel] [RFC v4 00/13] qmp: query-device-slots command

2017-08-15 Thread Eric Blake
On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > Changelog > - > > Changes v3 -> v4: > * New compact representation of slot sets. > * New generic code to automatically merge similar slots > into a single entry in the command output while keeping > implementations of the method simpler.

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 03:40 PM, Eric Blake wrote: On 08/15/2017 01:27 PM, Philippe Mathieu-Daudé wrote: On 08/15/2017 03:13 PM, Eric Blake wrote: On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: only warn once about it. - kernel without kvm: # make check-qtest-x86_64 GTESTER check

Re: [Qemu-devel] [RFC PATCH 1/2] libqtest: add qtest_accel() to avoid warnings when kvm is not available

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 03:39 PM, Peter Maydell wrote: On 15 August 2017 at 19:27, Philippe Mathieu-Daudé wrote: On 08/15/2017 03:13 PM, Eric Blake wrote: On 08/15/2017 11:39 AM, Philippe Mathieu-Daudé wrote: only warn once about it. - kernel without kvm: # make check-qtest-x86_64 GTE

Re: [Qemu-devel] [PATCH for-2.10 v2 1/2] hw/acpi: Call acpi_set_pci_info when no ACPI tables needed

2017-08-15 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 02:07:51PM +0200, Igor Mammedov wrote: > On Tue, 15 Aug 2017 12:15:48 +0100 > Anthony PERARD wrote: > > > To do PCI passthrough with Xen, the property acpi-pcihp-bsel needs to be > > set, but this was done only when ACPI tables are built which is not > > needed for a Xen g

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-15 Thread Programmingkid
> On Aug 14, 2017, at 3:18 AM, Mark Cave-Ayland > wrote: > > On 14/08/17 07:51, Paolo Bonzini wrote: > >> On 13/08/2017 21:13, Programmingkid wrote: >>> Lately I found out that Windows NT 4.0 seems to work well with the >>> 486 and pentium processors. Using "-cpu 486" made installing it >>> ac

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Michael S. Tsirkin
On Tue, Aug 15, 2017 at 08:47:35AM -0700, Richard Henderson wrote: > On 08/14/2017 08:33 AM, Cornelia Huck wrote: > > On Mon, 14 Aug 2017 17:34:15 +0300 > > "Michael S. Tsirkin" wrote: > > > >> Speed up tests on host systems with kvm support. > >> In particular, this fixes tests with --disable-tc

Re: [Qemu-devel] [RFC v4 00/13] qmp: query-device-slots command

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 01:57:50PM -0500, Eric Blake wrote: > On 08/14/2017 04:57 PM, Eduardo Habkost wrote: > > Changelog > > - > > > > Changes v3 -> v4: > > * New compact representation of slot sets. > > * New generic code to automatically merge similar slots > > into a single entry in

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Richard Henderson
On 08/15/2017 12:28 PM, Michael S. Tsirkin wrote: >> Ouch. This is the only real smoke test we have for the tcg backend for the >> host. While it is still going to test tcg for whatever machines do not run >> natively on the host, I can't help think we've lost testing. >> >> Can we use accel=tcg:

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Thomas Huth
On 15.08.2017 17:47, Richard Henderson wrote: > On 08/14/2017 08:33 AM, Cornelia Huck wrote: >> On Mon, 14 Aug 2017 17:34:15 +0300 >> "Michael S. Tsirkin" wrote: >> >>> Speed up tests on host systems with kvm support. >>> In particular, this fixes tests with --disable-tcg. >>> >>> Cc: Paolo Bonzin

Re: [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 10:10:12AM +0200, Markus Armbruster wrote: > Please spell "Python" with a capital "P" (it's a proper name). > > Amador Pahim writes: > > > Let's provide extra control and flexibility by using python logging > > system instead of print and/or sys.std*.write(). > > > > Sign

Re: [Qemu-devel] [PATCH] tests: switch tests to accel=kvm:tcg

2017-08-15 Thread Philippe Mathieu-Daudé
On 08/15/2017 12:47 PM, Richard Henderson wrote: On 08/14/2017 08:33 AM, Cornelia Huck wrote: On Mon, 14 Aug 2017 17:34:15 +0300 "Michael S. Tsirkin" wrote: Speed up tests on host systems with kvm support. In particular, this fixes tests with --disable-tcg. Cc: Paolo Bonzini Cc: Thomas Huth

Re: [Qemu-devel] [PATCH for-2.11 v2 1/5] qmp-shell: Use optparse module

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 10:56:07AM +0100, Daniel P. Berrange wrote: > On Tue, Aug 15, 2017 at 11:47:28AM +0200, Markus Armbruster wrote: > > Eduardo Habkost writes: > > > > > It makes command-line parsing and generation of help text much > > > simpler. > > > > There's really no excuse for parsin

[Qemu-devel] [PATCH v2] net: rtl8139: do not use old_mmio accesses

2017-08-15 Thread Matt Parker
Both io and memory use the same mmio functions in the rtl8139 device. This patch removes the separate MemoryRegionOps and old_mmio accessors for memory, and replaces it with an alias to the io memory region. Signed-off-by: Matt Parker --- hw/net/rtl8139.c | 53 +++

[Qemu-devel] [PATCH] hw/ppc: disable hotplug before CAS is completed

2017-08-15 Thread Daniel Henrique Barboza
This patch is a follow up on the discussions that started with Laurent's patch series "spapr: disable hotplugging without OS" [1] and discussions made at patch "spapr: reset DRCs on migration pre_load" [2]. At this moment, we do not support CPU/memory hotplug in early boot stages, before CAS. The

Re: [Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

2017-08-15 Thread Eduardo Habkost
On Tue, Aug 15, 2017 at 12:03:53PM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > Suggest to insert here: > > If additional arguments QMP-COMMAND ARG=VAL... are given, run just > that QMP command instead of the REPL. > > Question: is this limited to simple arguments? If no,

[Qemu-devel] [ANNOUNCE] QEMU 2.10.0-rc3 is now available

2017-08-15 Thread Michael Roth
Hello, On behalf of the QEMU Team, I'd like to announce the availability of the fourth release candidate for the QEMU 2.10 release. This release is meant for testing purposes and should not be used in a production environment. http://download.qemu-project.org/qemu-2.10.0-rc3.tar.xz http://do

Re: [Qemu-devel] [PATCH v3 1/1] PPC: KVM: Support machine option to set VSMT mode

2017-08-15 Thread Greg Kurz
On Tue, 15 Aug 2017 14:42:21 +1000 Sam Bobroff wrote: > KVM now allows writing to KVM_CAP_PPC_SMT which has previously been > read only. Doing so causes KVM to act, for that VM, as if the host's > SMT mode was the given value. This is particularly important on Power > 9 systems because their defa

Re: [Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-15 Thread Eric Blake
On 08/15/2017 02:45 AM, Manos Pitsidianakis wrote: > block-insert-node and its pair command block-remove-node provide runtime > insertion and removal of filter nodes. > > block-insert-node takes a (parent, child) and (node, child) pair of > edges and unrefs the (parent, child) BdrvChild relationsh

Re: [Qemu-devel] Help with Windows NT 4.0

2017-08-15 Thread Paolo Bonzini
On 15/08/2017 20:46, Programmingkid wrote: > >> On Aug 14, 2017, at 2:51 AM, Paolo Bonzini wrote: >> >> On 13/08/2017 21:13, Programmingkid wrote: >>> Lately I found out that Windows NT 4.0 seems to work well with the >>> 486 and pentium processors. Using "-cpu 486" made installing it >>> actuall

Re: [Qemu-devel] [PATCH for-2.10] mmio-interface: Mark as not user creatable

2017-08-15 Thread Edgar E. Iglesias
On Tue, Aug 15, 2017 at 06:16:22PM +0200, Thomas Huth wrote: > On 15.08.2017 16:30, Peter Maydell wrote: > > The mmio-interface device is not something we want to allow > > users to create on the command line: > > * it is intended as an implementation detail of the memory > >subsystem, which g

[Qemu-devel] [PATCH v2] hw/acpi: Select an node with memory for mapping memory hole to

2017-08-15 Thread Dou Liyang
Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ Guest reports "No NUMA configuration fo

[Qemu-devel] [PATCH v3] hw/acpi-build: Fix SRAT memory building when there is no memory in node0

2017-08-15 Thread Dou Liyang
Currently, Using the fisrt node without memory on the machine makes QEMU unhappy. With this example command line: ... \ -m 1024M,slots=4,maxmem=32G \ -numa node,nodeid=0 \ -numa node,mem=1024M,nodeid=1 \ -numa node,nodeid=2 \ -numa node,nodeid=3 \ Guest reports "No NUMA configuration fo

Re: [Qemu-devel] [PATCH v2 0/4] i386/kvm: advertise Hyper-V frequency MSRs

2017-08-15 Thread Konrad Rzeszutek Wilk
On Tue, Aug 08, 2017 at 09:50:53PM -0300, Marcelo Tosatti wrote: > On Mon, Aug 07, 2017 at 10:56:59AM +0200, Ladi Prosek wrote: > > This is the QEMU part of the changes required for nested Hyper-V to read > > timestamps with RDTSC + TSC page. Without exposing the frequency MSRs, > > Windows with th

Re: [Qemu-devel] [PATCH qemu v4 1/3] spapr_iommu: Realloc guest visible TCE table when hot(un)plugging vfio-pci

2017-08-15 Thread Alexey Kardashevskiy
On 09/08/17 17:33, David Gibson wrote: > On Mon, Jul 24, 2017 at 08:48:45PM +1000, Alexey Kardashevskiy wrote: >> On 24/07/17 15:53, David Gibson wrote: >>> On Thu, Jul 20, 2017 at 05:22:29PM +1000, Alexey Kardashevskiy wrote: This replaces g_malloc() with spapr_tce_alloc_table() as this is >>

[Qemu-devel] Crash when deleting the diag288 watchdog

2017-08-15 Thread Thomas Huth
Hi, I recently noticed that QEMU abort()s if you try to remove the diag288 watchdog. For example: $ qemu-system-s390x -nographic -nodefaults -S -monitor stdio QEMU 2.9.92 monitor - type 'help' for more information (qemu) device_add diag288,id=x (qemu) device_del x ** ERROR:/home/thuth/devel/qemu

[Qemu-devel] [PATCH] hw/s390x/ipl: The s390-ipl device is not hot-pluggable

2017-08-15 Thread Thomas Huth
The s390-ipl device can not be created by the user, since it is meant only to be instantiated once internally to load the ROMs and kernel. If the user tries to do a "device_add s390-ipl" via the monitor later, QEMU aborts with a "ROM images must be loaded at startup" error message. Signed-off-by:

Re: [Qemu-devel] a tiny tool for checking and repairing damaged qcow2 image

2017-08-15 Thread Markus Armbruster
Cc'ing QCOW2 maintainer. ÕÅÓÑ¼Ó writes: > Hi, > > I want to introduce a tiny tool(https://github.com/zhangyoujia/qcow2-dump) > for checking and repairing damaged qcow2 image. > > I met many damaged qcow2 images when I work. > > It does't always work by using the qemu-img command to check and re

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-08-15 Thread Markus Armbruster
Vadim Galitsyn writes: > Hi Guys, > > Thank you for the input! > >> "hotunpluggable" is ugly. What about just "pluggable"? > > Markus, I think "pluggable" is a bit misleading here. Some people can take > it like a maximum amount of memory that can be hot-added to a guest (i.e., > difference betw

[Qemu-devel] [PATCH v3 1/2] pc: add 2.11 machine type

2017-08-15 Thread Lan Tianyu
Signed-off-by: Lan Tianyu --- hw/i386/pc_piix.c| 14 +++--- hw/i386/pc_q35.c | 14 +++--- include/hw/compat.h | 3 +++ include/hw/i386/pc.h | 3 +++ 4 files changed, 28 insertions(+), 6 deletions(-) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c index 11b4336..e99e

[Qemu-devel] [PATCH v3 2/2] x86: Increase max vcpu number to 8192

2017-08-15 Thread Lan Tianyu
For HPC usage case, it will create a huge VM with vcpus number as same as host cpus and this requires more vcpus support in a single VM. This patch is to increase max vcpu number from 288 to 8192 which is current default maximum cpu number for Linux kernel. Signed-off-by: Lan Tianyu --- hw/i386/

Re: [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system

2017-08-15 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Aug 15, 2017 at 10:10:12AM +0200, Markus Armbruster wrote: >> Please spell "Python" with a capital "P" (it's a proper name). >> >> Amador Pahim writes: >> >> > Let's provide extra control and flexibility by using python logging >> > system instead of print and

[Qemu-devel] ask a question

2017-08-15 Thread 皮智
Hi,I meet a problem with vm, my environment is qemu-kvm-2.3, virtio-win-0.1.126, host(centos7.2), guest(windows10). libvirt xml has four virtio-serial channel as follows:

Re: [Qemu-devel] [PATCH for-2.11 v2 4/5] qmp-shell: Accept QMP command as argument

2017-08-15 Thread Markus Armbruster
Eduardo Habkost writes: > On Tue, Aug 15, 2017 at 12:03:53PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> Suggest to insert here: >> >> If additional arguments QMP-COMMAND ARG=VAL... are given, run just >> that QMP command instead of the REPL. >> >> Question: is this l

[Qemu-devel] [PATCH] x86: Skip check apic_id_limit for Xen

2017-08-15 Thread Lan Tianyu
Xen vIOMMU device model will be in Xen hypervisor. Skip vIOMMU check for Xen here when vcpu number is more than 255. Signed-off-by: Lan Tianyu --- hw/i386/pc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/pc.c b/hw/i386/pc.c index 5943539..fc17885 100644 --- a/hw/i

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Cornelia Huck
On Tue, 15 Aug 2017 07:02:10 +0200 Thomas Huth wrote: > On 14.08.2017 22:44, Eric Farman wrote: > > How often does one really do a "make clean" ? Rather infrequently, > > as I only stumbled on this today. > > > > Perhaps I have missed the RM variable somewhere, as I see similar syntax > > in so

Re: [Qemu-devel] qemu guest agent support 'guest-exec'

2017-08-15 Thread Tomáš Golembiovský
On Mon, 31 Jul 2017 08:29:32 + "Hu, Robert" wrote: > Hi, > > From $qemu_src/qga/ code, guest-exec should be supported. > But from $qemu_src/scripts/qmp/qemu-ga-client output, it is not supported, on > client side. Why didn't implement on client side? or any configuration I > missed? qemu-

Re: [Qemu-devel] [PATCH] Makefile: Let "make check-help" work without running ./configure

2017-08-15 Thread Fam Zheng
On Thu, 08/10 08:59, Philippe Mathieu-Daudé wrote: > Hi Fam, > > thank for fixing this :) > > I think as a bugfix it should enter 2.10 > (maybe through Alex's Travis series, CC'ing him) Since Alex hasn't replied, I'll send a pull request for -rc3. > > On 08/10/2017 05:50 AM, Fam Zheng wrote: >

Re: [Qemu-devel] [PATCH 1/1] pc-bios/s390-ccw: Use rm command during make clean

2017-08-15 Thread Cornelia Huck
On Mon, 14 Aug 2017 22:44:50 +0200 Eric Farman wrote: > This reverts what I think was an accidental change that replaced > the "rm -f" command with an undefined variable RM, and causes the > "make clean" command to fail for a s390 target: > > make[1]: Entering directory '/usr/src/qemu/build/pc-b

Re: [Qemu-devel] [PATCH v2 for 2.10] block/nbd-client: always return EIO on and after the first io channel error

2017-08-15 Thread Vladimir Sementsov-Ogievskiy
14.08.2017 19:22, Eric Blake wrote: On 08/14/2017 02:39 AM, Vladimir Sementsov-Ogievskiy wrote: 12.08.2017 01:28, Eric Blake wrote: On 08/08/2017 10:26 AM, Vladimir Sementsov-Ogievskiy wrote: Initial review, I'm still playing with this one, and will reply again on Monday. Do not communicate

Re: [Qemu-devel] [PATCH v2 5/5] Convert single line fprintf() to warn_report()

2017-08-15 Thread Markus Armbruster
Paolo, there's a Make puzzle for you below. Alistair Francis writes: > On Mon, Aug 14, 2017 at 6:34 AM, Markus Armbruster wrote: >> PATCH 3/5 has the exact same subject. Why are the two separate? > > You are right, that is a mess. > > This one doesn't check for newlines at the end while the ea

[Qemu-devel] [PULL for-2.10 1/1] pc-bios/s390-ccw: Use rm command during make clean

2017-08-15 Thread Cornelia Huck
From: Eric Farman This reverts a change that replaced the "rm -f" command with the undefined variable RM (expected to be set by make), and causes the "make clean" command to fail for a s390 target: make[1]: Entering directory '/usr/src/qemu/build/pc-bios/s390-ccw' rm -f *.timestamp *.o *.d *.img

[Qemu-devel] [PULL for-2.10 0/1] bugfix for s390x

2017-08-15 Thread Cornelia Huck
The following changes since commit 83c3a1f61673ef554facf4d6d29ed56c5a219f9d: xlnx-qspi: add a property for mmio-execution (2017-08-14 14:17:18 +0100) are available in the git repository at: git://github.com/cohuck/qemu tags/s390x-20170815 for you to fetch changes up to

[Qemu-devel] [PATCH v2] qemu-iothread: IOThread supports the GMainContext event loop

2017-08-15 Thread Wang yong
From: Wang Yong IOThread uses AioContext event loop and does not run a GMainContext. Therefore,chardev cannot work in IOThread,such as the chardev is used for colo-compare packets reception. This patch makes the IOThread run the GMainContext event loop, chardev and IOThread can work together. S

Re: [Qemu-devel] [PATCH 04/28] sparc: convert cpu models to SPARC cpu subclasses

2017-08-15 Thread Igor Mammedov
On Mon, 14 Aug 2017 18:24:31 +0200 Artyom Tarasenko wrote: > Hi Igor, > > On Mon, Aug 14, 2017 at 9:56 AM, Igor Mammedov wrote: > > On Fri, 14 Jul 2017 15:51:55 +0200 > > Igor Mammedov wrote: > > > >> QOMfy cpu models handling introducing propper cpu types > >> for each cpu model. > >> > >>

Re: [Qemu-devel] [PATCH 1/2] block: use internal filter node in backup

2017-08-15 Thread Vladimir Sementsov-Ogievskiy
15.08.2017 09:19, Manos Pitsidianakis wrote: block/backup.c currently uses before write notifiers on the targeted node. We can create a filter node instead to intercept write requests for the backup job on the BDS level, instead of the BlockBackend level. Hi Manos! Looks interesting but what

[Qemu-devel] [PATCH RFC] block: add block-insert-node QMP command

2017-08-15 Thread Manos Pitsidianakis
block-insert-node and its pair command block-remove-node provide runtime insertion and removal of filter nodes. block-insert-node takes a (parent, child) and (node, child) pair of edges and unrefs the (parent, child) BdrvChild relationship and creates a new (parent, node) child with the same BdrvC

Re: [Qemu-devel] [PATCH v5 2/3] qmp: introduce query-memory-size-summary command

2017-08-15 Thread Igor Mammedov
On Fri, 28 Jul 2017 14:10:43 +0200 Vadim Galitsyn wrote: > Command above provides the following memory information in bytes: > > * base-memory - size of "base" memory specified with command line option -m. > > * hotunpluggable-memory - amount of memory that was hot-plugged. > If target

Re: [Qemu-devel] [PATCH 1/2] block: use internal filter node in backup

2017-08-15 Thread Manos Pitsidianakis
On Tue, Aug 15, 2017 at 10:44:15AM +0300, Vladimir Sementsov-Ogievskiy wrote: 15.08.2017 09:19, Manos Pitsidianakis wrote: block/backup.c currently uses before write notifiers on the targeted node. We can create a filter node instead to intercept write requests for the backup job on the BDS leve

Re: [Qemu-devel] [PATCH v4] hmp, qmp: introduce memory-size-summary commands

2017-08-15 Thread Igor Mammedov
On Mon, 14 Aug 2017 16:32:40 +0200 Markus Armbruster wrote: > Vadim Galitsyn writes: > > > Hi Guys, > > > > This thread is a continuation of discussion from: > > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg01565.html > > > > I will post changes list here in cover letter. > >

Re: [Qemu-devel] [PATCH 0/4] docker: improve code coverage on CentOS images

2017-08-15 Thread Fam Zheng
On Fri, 07/28 20:33, Philippe Mathieu-Daudé wrote: > This series installs more packages to docker images to extend CI code > coverage. > > Debian already have those but these images are only used on Shippable. > Extending CentOS images could improve patchew, and local user not custom to > Debian.

Re: [Qemu-devel] [PATCH] numa: Add a check whether the node0 has memory or not

2017-08-15 Thread Igor Mammedov
On Tue, 15 Aug 2017 09:26:46 +0800 Dou Liyang wrote: > Hi Eduardo, > > At 08/14/2017 08:44 PM, Eduardo Habkost wrote: > > On Mon, Aug 14, 2017 at 06:11:11PM +0800, Dou Liyang wrote: > >> Currently, Using the fisrt node without memory on the machine makes > >> QEMU unhappy. With this example co

Re: [Qemu-devel] [PATCH for-2.10 0/1] Fix "make clean" for s390 target

2017-08-15 Thread Thomas Huth
On 15.08.2017 09:03, Cornelia Huck wrote: > On Tue, 15 Aug 2017 07:02:10 +0200 > Thomas Huth wrote: > >> On 14.08.2017 22:44, Eric Farman wrote: >>> How often does one really do a "make clean" ? Rather infrequently, >>> as I only stumbled on this today. >>> >>> Perhaps I have missed the RM varia

Re: [Qemu-devel] [PATCH v6 3/7] qemu.py: use python logging system

2017-08-15 Thread Markus Armbruster
Please spell "Python" with a capital "P" (it's a proper name). Amador Pahim writes: > Let's provide extra control and flexibility by using python logging > system instead of print and/or sys.std*.write(). > > Signed-off-by: Amador Pahim How exactly does this change error messages? Is logging

<    1   2   3   >