[Qemu-devel] [PATCH for-2.11] rcu: init globals only once

2017-08-08 Thread Peter Xu
We were calling rcu_init_complete() twice in the child processes when fork happened. However the pthread library does not really suggest to do it that way: http://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread_mutex_init.html "Attempting to initialise an already initialised mutex results in u

Re: [Qemu-devel] [PATCH f0r 2.11] runstate/migrate: Two more transitions

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > There's a race if someone does a 'stop' near the end of migrate; > the migration process goes through two runstates: > 'finish migrate' > 'postmigrate' > > If the user issues a 'stop' between the two we end up with

Re: [Qemu-devel] [PATCH] target/i386: set rip_offset for some SSE4.1 instructions

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 02:43, Joseph Myers wrote: > When emulating various SSE4.1 instructions such as pinsrd, the address > of a memory operand is computed without allowing for the 8-bit > immediate operand located after the memory operand, meaning that the > memory operand uses the wrong address in the ca

Re: [Qemu-devel] [PATCH for 2.11] vga/migration: Update memory map in post_load

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > After migration the chain4 alias mapping added by 80763888 (in 2011) > might be missing, since there's no call to vga_update_memory_access > in the post_load after the registers are updated. Add it back. > > Signed-off-by

Re: [Qemu-devel] [PATCH f0r 2.11] runstate/migrate: Two more transitions

2017-08-08 Thread Peter Xu
On Tue, Aug 08, 2017 at 09:02:54AM +0200, Juan Quintela wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > There's a race if someone does a 'stop' near the end of migrate; > > the migration process goes through two runstates: > > 'finish migrate' > >

Re: [Qemu-devel] [PATCH] tests/pxe: Check virtio-net-ccw on s390x

2017-08-08 Thread Cornelia Huck
On Tue, 8 Aug 2017 07:19:54 +0200 Thomas Huth wrote: > On 07.08.2017 22:35, Michael S. Tsirkin wrote: > > On Thu, Aug 03, 2017 at 03:30:19PM +0200, Thomas Huth wrote: > >> Now that we've got a firmware that can do TFTP booting on s390x (i.e. > >> the pc-bios/s390-netboot.img), we can enable the

Re: [Qemu-devel] [PATCH for-2.11] rcu: init globals only once

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 09:00, Peter Xu wrote: > We were calling rcu_init_complete() twice in the child processes when > fork happened. However the pthread library does not really suggest to do > it that way: > > http://pubs.opengroup.org/onlinepubs/7908799/xsh/pthread_mutex_init.html > > "Attempting to in

Re: [Qemu-devel] [PATCH for-2.10 0/5] block: bdrv_reopen() fixes

2017-08-08 Thread Kevin Wolf
Am 03.08.2017 um 17:02 hat Kevin Wolf geschrieben: > This is the first part of some fixes to bdrv_reopen(), which seems > reasonable enough to merge for 2.10. > > There is much more wrong with bdrv_reopen() currently, especially with > respect to op blocker permissions (basically the required perm

[Qemu-devel] [Bug 1318746] Re: qemu Windows 7 BSOD when using hv-time

2017-08-08 Thread Thomas Huth
Triaging old bug tickets ... can you still reproduce this issue with the latest version of QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/131

Re: [Qemu-devel] [PATCH for-2.11] rcu: init globals only once

2017-08-08 Thread Peter Xu
On Tue, Aug 08, 2017 at 09:26:43AM +0200, Paolo Bonzini wrote: > On 08/08/2017 09:00, Peter Xu wrote: > > We were calling rcu_init_complete() twice in the child processes when > > fork happened. However the pthread library does not really suggest to do > > it that way: > > > > http://pubs.opengrou

Re: [Qemu-devel] Bug#864718: fsdev emulation security_model=none not handling mode 000

2017-08-08 Thread Michael Tokarev
I'm forwarding this upstream. It looks like the same issue is present in 2.10-tobe. 13.06.2017 16:01, Sjoerd Simons wrote: > Package: qemu-system > Version: 1:2.8+dfsg-6 > Severity: normal > > Hey, > > For $reasons i'm exposing /boot over a filesystem share with the host system, > fsdev is setup

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

2017-08-08 Thread Markus Armbruster
Cleber Rosa writes: > On 07/21/2017 08:33 AM, Stefan Hajnoczi wrote: >> On Thu, Jul 20, 2017 at 11:47:27PM -0400, Cleber Rosa wrote: >>> This is a follow up to a previous discussion about reported failures when >>> running some qemu-iotests. Turns out the failures were due to missing >>> librari

Re: [Qemu-devel] [PATCH 0/3] build configuration query tool and conditional (qemu-io)test skip

2017-08-08 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Wed, Jul 26, 2017 at 02:24:02PM -0400, Cleber Rosa wrote: >> >> >> On 07/26/2017 01:58 PM, Stefan Hajnoczi wrote: >> > On Tue, Jul 25, 2017 at 12:16:13PM -0400, Cleber Rosa wrote: >> >> On 07/25/2017 11:49 AM, Stefan Hajnoczi wrote: >> >>> On Fri, Jul 21, 2017 at 10

Re: [Qemu-devel] About virtio device hotplug in Q35! 【外域邮件.谨慎查阅】

2017-08-08 Thread Bob Chen
Plus: 1 GB hugepages neither improved bandwidth nor latency. Results remained the same. 2017-08-08 9:44 GMT+08:00 Bob Chen : > 1. How to test the KVM exit rate? > > 2. The switches are separate devices of PLX Technology > > # lspci -s 07:08.0 -nn > 07:08.0 PCI bridge [0604]: PLX Technology, Inc.

Re: [Qemu-devel] [PATCH for-2.11] rcu: init globals only once

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 09:49, Peter Xu wrote: > On Tue, Aug 08, 2017 at 09:26:43AM +0200, Paolo Bonzini wrote: >> On 08/08/2017 09:00, Peter Xu wrote: >>> We were calling rcu_init_complete() twice in the child processes when >>> fork happened. However the pthread library does not really suggest to do >>> it

Re: [Qemu-devel] [PATCH 2/2] loader: Ignore zero-sized ELF segments

2017-08-08 Thread Hua Yanghao
Tested-by: Hua Yanghao On Mon, Aug 7, 2017 at 4:39 PM, Peter Maydell wrote: > Some ELF files have program headers that specify segments that > are of zero size. Ignore them, rather than trying to create > zero-length ROM blobs for them, because the zero-length blob > can falsely trigger the over

Re: [Qemu-devel] [PATCH 2/4] qcow: Check failure of bdrv_getlength() and bdrv_truncate()

2017-08-08 Thread Kevin Wolf
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben: > This also requires changing the return type of get_cluster_offset() > and adjusting all callers. > > Use osdep.h macros instead of open-coded rounding while in the > area. > > Reported-by: Markus Armbruster > Signed-off-by: Eric Blake > --- >

Re: [Qemu-devel] [PATCH 1/4] vpc: Check failure of bdrv_getlength()

2017-08-08 Thread Kevin Wolf
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben: > vpc_open() was checking for bdrv_getlength() failure in one, but > not the other, location. > > Reported-by: Markus Armbruster > Signed-off-by: Eric Blake > --- > block/vpc.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) >

Re: [Qemu-devel] [PATCH 3/4] qcow2: Drop debugging dump_refcounts()

2017-08-08 Thread Kevin Wolf
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben: > It's been #if 0'd since its introduction in 2006, commit 585f8587. > We can revive dead code if we need it, but in the meantime, it has > bit-rotted (for example, not checking for failure in bdrv_getlength()). > > Signed-off-by: Eric Blake Rev

Re: [Qemu-devel] [PATCH 4/4] qcow2: Check failure of bdrv_getlength()

2017-08-08 Thread Kevin Wolf
Am 07.08.2017 um 22:30 hat Eric Blake geschrieben: > qcow2_co_pwritev_compressed() should not call bdrv_truncate() > if determining the size failed. > > Reported-by: Markus Armbruster > Signed-off-by: Eric Blake Reviewed-by: Kevin Wolf

Re: [Qemu-devel] [PATCH v5 03/17] qio: Create new qio_channel_{readv, writev}_all

2017-08-08 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Mon, Jul 17, 2017 at 03:42:24PM +0200, Juan Quintela wrote: >> The functions waits until it is able to write the full iov. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> Add tests. >> --- >> include/io/channel.h | 46 + >>

Re: [Qemu-devel] [PATCH v5 04/17] migration: Add multifd capability

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan Gilbert > > Note you need to update this; you need to add the > DEFINE_PROP_MIG_CAP in migration_properties[] Done, it was sent before I integrated the

Re: [Qemu-devel] [PATCH] iotests: fix 185

2017-08-08 Thread Vladimir Sementsov-Ogievskiy
07.08.2017 18:57, Kevin Wolf wrote: Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben: 185 iotest is broken. How to test: i=0; while ./check -qcow2 -nocache 185; do ((i+=1)); echo N = $i; \ done; echo N = $i finished for me like this: 185 2s ... - output mismatch (see 1

Re: [Qemu-devel] [PATCH v5 05/17] migration: Create x-multifd-threads parameter

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Indicates the number of threads that we would create. By default we >> create 2 threads. >> >> Signed-off-by: Juan Quintela >> Reviewed-by: Dr. David Alan Gilbert > > Also needs updating DEFINE_PROP stuff - and i

Re: [Qemu-devel] [PATCH for 2.10 v3 4/6] docker: docker.py make --no-cache skip checksum test

2017-08-08 Thread Alex Bennée
Fam Zheng writes: > On Mon, 08/07 16:39, Alex Bennée wrote: >> If you invoke with NOCACHE=1 we pass --no-cache in the argv to >> docker.py but may still not force a rebuild if the dockerfile checksum >> hasn't changed. By testing for its presence we can force builds >> without having to manually

Re: [Qemu-devel] [PATCH] iotests: fix 185

2017-08-08 Thread Kevin Wolf
Am 08.08.2017 um 10:42 hat Vladimir Sementsov-Ogievskiy geschrieben: > 07.08.2017 18:57, Kevin Wolf wrote: > > Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben: > > > 185 iotest is broken. > > > > > > How to test: > > > > i=0; while ./check -qcow2 -nocache 185; do ((i+=1)); echo

Re: [Qemu-devel] [PATCH for 2.10 v3 1/6] docker: ensure NOUSER for travis images

2017-08-08 Thread Alex Bennée
Fam Zheng writes: > On Mon, 08/07 16:39, Alex Bennée wrote: >> While adding the current user is a useful default behaviour for >> creating new images it is not appropriate for Travis which already has >> a default user. > > Target docker-travis@travis will not have NOUSER=1 automatically, right?

Re: [Qemu-devel] [PATCH v5 07/17] migration: Create multifd migration threads

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Creation of the threads, nothing inside yet. >> >> Signed-off-by: Juan Quintela >> +MultiFDSendParams *p = &multifd_send_state->params[i]; >> + >> +qemu_mutex_lock(&p->mutex); >> +p->quit =

Re: [Qemu-devel] [PATCH] iotests: fix 185

2017-08-08 Thread Vladimir Sementsov-Ogievskiy
08.08.2017 11:53, Kevin Wolf wrote: Am 08.08.2017 um 10:42 hat Vladimir Sementsov-Ogievskiy geschrieben: 07.08.2017 18:57, Kevin Wolf wrote: Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben: 185 iotest is broken. How to test: i=0; while ./check -qcow2 -nocache 185; do ((i+

Re: [Qemu-devel] [PATCH] iotests: fix 185

2017-08-08 Thread Vladimir Sementsov-Ogievskiy
08.08.2017 12:04, Vladimir Sementsov-Ogievskiy wrote: 08.08.2017 11:53, Kevin Wolf wrote: Am 08.08.2017 um 10:42 hat Vladimir Sementsov-Ogievskiy geschrieben: 07.08.2017 18:57, Kevin Wolf wrote: Am 07.08.2017 um 16:16 hat Vladimir Sementsov-Ogievskiy geschrieben: 185 iotest is broken. How to

Re: [Qemu-devel] [PATCH for-2.10 1/2] target/ppc: Implement TIDR

2017-08-08 Thread Cédric Le Goater
On 08/08/2017 08:08 AM, David Gibson wrote: > This adds a trivial implementation of the TIDR register added in > POWER9. This isn't particularly important to qemu directly - it's > used by accelerator modules that we don't emulate. > > However, since qemu isn't aware of it, its state is not synch

Re: [Qemu-devel] [PATCH v4 0/9] s390x: zPCI detangling

2017-08-08 Thread Cornelia Huck
On Fri, 4 Aug 2017 16:59:34 +0200 Cornelia Huck wrote: > On Fri, 4 Aug 2017 13:29:37 +0200 > Cornelia Huck wrote: > > > Next version, not so many changes from v3. > > > > As you might have guessed, the goals are still the same: > > - Being able to disable PCI support in a build completely. >

Re: [Qemu-devel] [for-2.10 PATCH 3/3] spapr: error out if PHB fails to setup PCI DRCs

2017-08-08 Thread Greg Kurz
On Tue, 8 Aug 2017 16:16:36 +1000 David Gibson wrote: > On Mon, Aug 07, 2017 at 07:25:03PM +0200, Greg Kurz wrote: > > It is currently possible to start QEMU with two PHBs without using the > > index property: > > > > -device spapr-pci-host-bridge,id=pci1,\ > > buid

Re: [Qemu-devel] [PATCH for-2.10 2/2] target/ppc: Add stub implementation of the PSSCR

2017-08-08 Thread Cédric Le Goater
On 08/08/2017 08:08 AM, David Gibson wrote: > The PSSCR register added in POWER9 controls certain power saving mode > behaviours. Mostly, it's not relevant to TCG, however because qemu > doesn't know about it yet, it doesn't synchronize the state with KVM, > and thus it doesn't get migrated. > >

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-08 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jul 17, 2017 at 03:42:30PM +0200, Juan Quintela wrote: > > [...] > >> int multifd_load_setup(void) >> { >> int thread_count; >> -uint8_t i; >> >> if (!migrate_use_multifd()) { >> return 0; >> } >> thread_count = migrate_multifd_threads

Re: [Qemu-devel] [PATCH 0/5] ui: keymap fixes for 2.10

2017-08-08 Thread Markus Armbruster
Just back from the signed-vs-unsigned swamp, still catching up, sorry for the delay... Eric Blake writes: > On 07/26/2017 07:09 AM, no-re...@patchew.org wrote: >> Hi, >> >> This series failed build test on s390x host. Please find the details below. >> >> Message-id: 20170726115637.21558-1-kra.

Re: [Qemu-devel] [Qemu-block] [PATCH] block: document semanatics of bdrv_co_preadv|pwritev

2017-08-08 Thread Daniel P. Berrange
On Tue, Aug 08, 2017 at 10:39:29AM +0800, Fam Zheng wrote: > On Fri, 08/04 16:49, Daniel P. Berrange wrote: > > This is odd. In the bdrv_aligned_readv() it looks very much like > > we'll reference qiov->niov, if bytes != 0, so if qiov was NULL we > > would crash. > > It doesn't make sense if read

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc: Only set PCR in kvm if actually in a compat mode

2017-08-08 Thread Greg Kurz
On Tue, 8 Aug 2017 16:21:06 +1000 David Gibson wrote: [...] > > > > > > > > Does it make sense at all to use compat mode with KVM_PR since it > > > > requires hypervisor privilege, that we're supposed not to have ? > > > > > > Uh.. what? Availability of the PCR is a question of the guest >

Re: [Qemu-devel] [PATCH v5 03/17] qio: Create new qio_channel_{readv, writev}_all

2017-08-08 Thread Daniel P. Berrange
On Tue, Aug 08, 2017 at 10:40:08AM +0200, Juan Quintela wrote: > "Daniel P. Berrange" wrote: > > On Mon, Jul 17, 2017 at 03:42:24PM +0200, Juan Quintela wrote: > >> The functions waits until it is able to write the full iov. > >> > >> Signed-off-by: Juan Quintela > >> > >> -- > >> > >> Add tes

Re: [Qemu-devel] [PATCH v4 0/9] s390x: zPCI detangling

2017-08-08 Thread Thomas Huth
On 08.08.2017 11:15, Cornelia Huck wrote: > On Fri, 4 Aug 2017 16:59:34 +0200 > Cornelia Huck wrote: > >> On Fri, 4 Aug 2017 13:29:37 +0200 >> Cornelia Huck wrote: >> >>> Next version, not so many changes from v3. >>> >>> As you might have guessed, the goals are still the same: >>> - Being able

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We create new channels for each new thread created. We only send through >> them a character to be sure that we are creating the channels in the >> right order. > > That text is out of date isn't it? oops, fixed.

Re: [Qemu-devel] [PATCH v5 05/17] migration: Create x-multifd-threads parameter

2017-08-08 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Indicates the number of threads that we would create. By default we > >> create 2 threads. > >> > >> Signed-off-by: Juan Quintela > >> Reviewed-by: Dr. David Alan

Re: [Qemu-devel] [PATCH v4 0/9] s390x: zPCI detangling

2017-08-08 Thread Cornelia Huck
On Tue, 8 Aug 2017 11:29:50 +0200 Thomas Huth wrote: > On 08.08.2017 11:15, Cornelia Huck wrote: > > On Fri, 4 Aug 2017 16:59:34 +0200 > > Cornelia Huck wrote: > > > >> On Fri, 4 Aug 2017 13:29:37 +0200 > >> Cornelia Huck wrote: > >> > >>> Next version, not so many changes from v3. > >>>

Re: [Qemu-devel] [Qemu-block] [PATCH for-2.10] block/nfs: fix mutex assertion in nfs_file_close()

2017-08-08 Thread Stefan Hajnoczi
On Mon, Aug 07, 2017 at 06:29:09PM -0400, Jeff Cody wrote: > Commit c096358e747e88fc7364e40e3c354ee0bb683960 introduced assertion > checks for when qemu_mutex() functions are called without the > corresponding qemu_mutex_init() having initialized the mutex. > > This uncovered a latent bug in qemu'

Re: [Qemu-devel] [PATCH v5 09/17] migration: Start of multiple fd work

2017-08-08 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We create new channels for each new thread created. We only send through > >> them a character to be sure that we are creating the channels in the > >> right order.

Re: [Qemu-devel] [PATCH for-2.10] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types

2017-08-08 Thread Stefan Hajnoczi
On Mon, Aug 07, 2017 at 07:15:29PM +0300, Alberto Garcia wrote: > Both the throttling limits set with the throttling.iops-* and > throttling.bps-* options and their QMP equivalents defined in the > BlockIOThrottle struct are integer values. > > Those limits are also reported in the BlockDeviceInfo

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

2017-08-08 Thread Kevin Wolf
Am 04.08.2017 um 13:46 hat Paolo Bonzini geschrieben: > On 04/08/2017 11:58, Stefan Hajnoczi wrote: > >> the root cause of this bug is related to this as well: > >> https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg02945.html > >> > >> From commit 99723548 we started assuming (incorrectly?)

Re: [Qemu-devel] [PULL 0/2] virtio: fix for rc2

2017-08-08 Thread Peter Maydell
On 7 August 2017 at 22:40, Michael S. Tsirkin wrote: > The following changes since commit e6a74868d92f858ac33915b6772999d7de2fd288: > > build-sys: add --disable-vhost-user (2017-08-03 15:55:41 +0300) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/virt/kvm/mst/qemu

Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 06:36:21PM -0300, Eduardo Habkost wrote: > It makes command-line parsing and generation of help text much > simpler. > > Signed-off-by: Eduardo Habkost > --- > scripts/qmp/qmp-shell | 61 > +-- > 1 file changed, 20 insertio

Re: [Qemu-devel] [PATCH for-2.11 2/5] qmp-shell: Pass split cmdargs to __build_cmd()

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 06:36:22PM -0300, Eduardo Habkost wrote: > This will allow us to implement a method to run a command that is > already split in a list. > > Signed-off-by: Eduardo Habkost > --- > scripts/qmp/qmp-shell | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) Revie

Re: [Qemu-devel] [PATCH for-2.11 3/5] qmp-shell: execute_cmdargs() method

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 06:36:23PM -0300, Eduardo Habkost wrote: > This will allow us to execute a command that was already split in > a list. > > Signed-off-by: Eduardo Habkost > --- > scripts/qmp/qmp-shell | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajno

Re: [Qemu-devel] [PATCH for-2.11 1/5] qmp-shell: Use argparse module

2017-08-08 Thread Daniel P. Berrange
On Tue, Aug 08, 2017 at 11:07:21AM +0100, Stefan Hajnoczi wrote: > On Fri, Aug 04, 2017 at 06:36:21PM -0300, Eduardo Habkost wrote: > > It makes command-line parsing and generation of help text much > > simpler. > > > > Signed-off-by: Eduardo Habkost > > --- > > scripts/qmp/qmp-shell | 61 > > +

Re: [Qemu-devel] [PATCH for-2.11 4/5] qmp-shell: Accept QMP command as argument

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 06:36:24PM -0300, Eduardo Habkost wrote: > This is useful for testing QMP commands in scripts. > > Example usage, combined with 'jq' for filtering the results: > > $ ./scripts/qmp/qmp-shell /tmp/qmp qom-list path=/ | jq -r .return[].name > machine > type > chardevs

Re: [Qemu-devel] [PATCH for-2.11 5/5] Remove scripts/qmp/qmp

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 06:36:25PM -0300, Eduardo Habkost wrote: > The only purpose of scripts/qmp/qmp was the ability to run QMP > commands non-interactively. Now it is possible to run qmp-shell > non-interactively by providing a QMP command a command-line > argument, making scripts/qmp/qmp obsol

Re: [Qemu-devel] [Qemu-block] [PATCH] block/null: Remove 'filename' option

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 04:43:54PM +0200, Kevin Wolf wrote: > This option was only added to allow 'null-co://' and 'null-aio://' as > filenames, its value never served any actual purpose and was ignored. > Nevertheless it was accepted as '-drive driver=null,filename=foo'. > > The correct way to en

Re: [Qemu-devel] [Qemu-block] [PATCH v2] qemu-img: Clarify about relative backing file options

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 10:36:58PM +0800, Fam Zheng wrote: > It's not too surprising when a user specifies the backing file relative > to the current working directory instead of the top layer image. This > causes error when they differ. Though the error message has enough > information to infer th

Re: [Qemu-devel] [Qemu-block] [PATCH v3] block: document semanatics of bdrv_co_preadv|pwritev

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 03:08:26PM +0100, Daniel P. Berrange wrote: > Signed-off-by: Daniel P. Berrange > --- > > - Clarify that @bytes matches @qiov total size (Kevin) > > include/block/block_int.h | 31 +++ > 1 file changed, 31 insertions(+) Reviewed-by: Stefan H

Re: [Qemu-devel] [PATCH for-2.10] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types

2017-08-08 Thread Alberto Garcia
On Tue 08 Aug 2017 12:00:30 PM CEST, Stefan Hajnoczi wrote: > On Mon, Aug 07, 2017 at 07:15:29PM +0300, Alberto Garcia wrote: >> Both the throttling limits set with the throttling.iops-* and >> throttling.bps-* options and their QMP equivalents defined in the >> BlockIOThrottle struct are integer v

Re: [Qemu-devel] [PATCH] iotests: fix 185

2017-08-08 Thread Vladimir Sementsov-Ogievskiy
08.08.2017 12:04, Vladimir Sementsov-Ogievskiy wrote: 08.08.2017 12:04, Vladimir Sementsov-Ogievskiy wrote: 08.08.2017 11:53, Kevin Wolf wrote: Am 08.08.2017 um 10:42 hat Vladimir Sementsov-Ogievskiy geschrieben: 07.08.2017 18:57, Kevin Wolf wrote: Am 07.08.2017 um 16:16 hat Vladimir Sementso

Re: [Qemu-devel] [PATCH for-2.10 1/2] target/ppc: Implement TIDR

2017-08-08 Thread Greg Kurz
On Tue, 8 Aug 2017 11:13:03 +0200 Cédric Le Goater wrote: > On 08/08/2017 08:08 AM, David Gibson wrote: > > This adds a trivial implementation of the TIDR register added in > > POWER9. This isn't particularly important to qemu directly - it's > > used by accelerator modules that we don't emulate

Re: [Qemu-devel] [PATCH for-2.10] throttle: Make LeakyBucket.avg and LeakyBucket.max integer types

2017-08-08 Thread Alberto Garcia
On Tue 08 Aug 2017 12:17:12 PM CEST, Alberto Garcia wrote: > I was under the impression that Markus wanted to change the QAPI types > of the throttling fields in BlockDeviceInfo for 2.10 as well, so this > patch is relevant. I just saw that his series is still an RFC, so we can leave this patch f

[Qemu-devel] Qemu and 32 PCIe devices

2017-08-08 Thread Marcin Juszkiewicz
Hello Few days ago I had an issue with getting PCIe hotplug working on AArch64 machine. Enabled PCI hotplug in kernel and then got hit by some issues. Out setup is a bunch of aarch64 servers and we use OpenStack to provide access to arm64 systems. OpenStack uses libvirt to control VMs and allows

Re: [Qemu-devel] [PATCH v5 17/17] migration: Flush receive queue

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Each time that we sync the bitmap, it is a possiblity that we receive >> a page that is being processed by a different thread. We fix this >> problem just making sure that we wait for all receiving threads to >> fin

Re: [Qemu-devel] [PATCH v4 0/9] s390x: zPCI detangling

2017-08-08 Thread Thomas Huth
On 08.08.2017 11:46, Cornelia Huck wrote: > On Tue, 8 Aug 2017 11:29:50 +0200 > Thomas Huth wrote: > >> On 08.08.2017 11:15, Cornelia Huck wrote: >>> On Fri, 4 Aug 2017 16:59:34 +0200 >>> Cornelia Huck wrote: >>> On Fri, 4 Aug 2017 13:29:37 +0200 Cornelia Huck wrote: >

[Qemu-devel] [RFC] docs/devel/loads-stores.rst: Document our various load and store APIs

2017-08-08 Thread Peter Maydell
QEMU has a wide selection of different functions for doing loads and stores; provide some overview documentation of what they do and how to pick which one to use. Signed-off-by: Peter Maydell --- This is currently a work in progress, with many TODO points. Some of the formatting is a bit inconsis

Re: [Qemu-devel] [PATCH for-2.10 2/2] target/ppc: Add stub implementation of the PSSCR

2017-08-08 Thread Greg Kurz
On Tue, 8 Aug 2017 11:19:58 +0200 Cédric Le Goater wrote: > On 08/08/2017 08:08 AM, David Gibson wrote: > > The PSSCR register added in POWER9 controls certain power saving mode > > behaviours. Mostly, it's not relevant to TCG, however because qemu > > doesn't know about it yet, it doesn't synch

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 12:02, Kevin Wolf wrote: > Am 04.08.2017 um 13:46 hat Paolo Bonzini geschrieben: >> On 04/08/2017 11:58, Stefan Hajnoczi wrote: the root cause of this bug is related to this as well: https://lists.gnu.org/archive/html/qemu-devel/2017-07/msg02945.html From commit 99

Re: [Qemu-devel] [PATCH for-2.10] block/nfs: fix mutex assertion in nfs_file_close()

2017-08-08 Thread Peter Lieven
Am 08.08.2017 um 00:29 schrieb Jeff Cody: Commit c096358e747e88fc7364e40e3c354ee0bb683960 introduced assertion checks for when qemu_mutex() functions are called without the corresponding qemu_mutex_init() having initialized the mutex. This uncovered a latent bug in qemu's nfs driver - in nfs_cli

Re: [Qemu-devel] [PATCH 3/3] maint: Include bug-reporting info in --help output.

2017-08-08 Thread Markus Armbruster
Eric Blake writes: > These days, many programs are including a bug-reporting address, > or better yet, a link to the project web site, at the tail of > their --help output. However, we were not very consistent at > doing so: only qemu-nbd and qemu-qa mentioned anything, with the > latter pointin

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.10 1/2] target/ppc: Implement TIDR

2017-08-08 Thread Thomas Huth
On 08.08.2017 08:08, David Gibson wrote: > This adds a trivial implementation of the TIDR register added in > POWER9. This isn't particularly important to qemu directly - it's > used by accelerator modules that we don't emulate. > > However, since qemu isn't aware of it, its state is not synchron

Re: [Qemu-devel] [PATCH 3/3] maint: Include bug-reporting info in --help output.

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 13:06, Markus Armbruster wrote: > Eric Blake writes: > >> These days, many programs are including a bug-reporting address, >> or better yet, a link to the project web site, at the tail of >> their --help output. However, we were not very consistent at >> doing so: only qemu-nbd and

Re: [Qemu-devel] [PATCH v5 16/17] migration: Transfer pages over new channels

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We switch for sending the page number to send real pages. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> Remove the HACK bit, now we have the function that calculates the size >> of a page exported. >> --- >>

Re: [Qemu-devel] [RFC PATCH 03/56] monitor: Rewrite comment describing HMP .args_type

2017-08-08 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Signed-off-by: Markus Armbruster > --- > monitor.c | 75 > +++ > 1 file changed, 47 insertions(+), 28 deletions(-) > > diff --git a/monitor.c b/monitor.c > index e0f8801..8b54ba1 100644

Re: [Qemu-devel] [PATCH v5 17/17] migration: Flush receive queue

2017-08-08 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> Each time that we sync the bitmap, it is a possiblity that we receive > >> a page that is being processed by a different thread. We fix this > >> problem just makin

Re: [Qemu-devel] [PATCH v5 14/17] migration: Delay the start of reception on main channel

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> When we start multifd, we will want to delay the main channel until >> the others are created. >> >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 23 ++- >> 1 file changed, 14

Re: [Qemu-devel] [PATCH v5 14/17] migration: Delay the start of reception on main channel

2017-08-08 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jul 17, 2017 at 03:42:35PM +0200, Juan Quintela wrote: >> When we start multifd, we will want to delay the main channel until >> the others are created. >> >> Signed-off-by: Juan Quintela >> --- >> migration/migration.c | 23 ++- >> 1 file changed,

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-08 Thread Alberto Garcia
On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: >>> Awkward question for a v7, but here goes anyway: why is IOThrottle >>> worth its very own .json file? >> I feel this is a common throttle structure that is used by block >> devices as well as fsdev, so moved to a separate file. > I'm

Re: [Qemu-devel] colo-compare: segfault and assert on colo_compare_finalize

2017-08-08 Thread Hailiang Zhang
Hi, Did you test this branch https://github.com/coloft/qemu/tree/colo-for-qemu-2.10-2017-4-22 ? This seems to be an already known problem, I'm not quite sure, it may be fixed by this patch b19456dd0ea4eb418ad093f092adbb882be13054 char: Fix removing wrong GSource that be found by fd_in_tag We

Re: [Qemu-devel] [PATCH v5 16/17] migration: Transfer pages over new channels

2017-08-08 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We switch for sending the page number to send real pages. > >> > >> Signed-off-by: Juan Quintela > >> > >> -- > >> > >> Remove the HACK bit, now we have the func

Re: [Qemu-devel] [PATCH v5 17/17] migration: Flush receive queue

2017-08-08 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jul 17, 2017 at 03:42:38PM +0200, Juan Quintela wrote: >> Each time that we sync the bitmap, it is a possiblity that we receive >> a page that is being processed by a different thread. We fix this >> problem just making sure that we wait for all receiving threads to >> f

Re: [Qemu-devel] [PATCH v5 13/17] migration: Create thread infrastructure for multifd recv side

2017-08-08 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jul 17, 2017 at 03:42:34PM +0200, Juan Quintela wrote: >> +static void multifd_recv_page(uint8_t *address, uint16_t fd_num) >> +{ >> +int thread_count; >> +MultiFDRecvParams *p; >> +static multifd_pages_t pages; >> +static bool once; >> + >> +if (!onc

Re: [Qemu-devel] [RFC] docs/devel/loads-stores.rst: Document our various load and store APIs

2017-08-08 Thread Richard Henderson
On 08/08/2017 03:44 AM, Peter Maydell wrote: > QEMU has a wide selection of different functions for doing > loads and stores; provide some overview documentation of > what they do and how to pick which one to use. > > Signed-off-by: Peter Maydell > --- > This is currently a work in progress, with

Re: [Qemu-devel] [Qemu-ppc] [PATCH for-2.10 2/2] target/ppc: Add stub implementation of the PSSCR

2017-08-08 Thread Thomas Huth
On 08.08.2017 08:08, David Gibson wrote: > The PSSCR register added in POWER9 controls certain power saving mode > behaviours. Mostly, it's not relevant to TCG, however because qemu > doesn't know about it yet, it doesn't synchronize the state with KVM, > and thus it doesn't get migrated. > > To

Re: [Qemu-devel] [PATCH v5 13/17] migration: Create thread infrastructure for multifd recv side

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We make the locking and the transfer of information specific, even if we >> are still receiving things through the main thread. >> >> Signed-off-by: Juan Quintela >> --- >> migration/ram.c | 68 >> +++

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-08 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Mon, Jul 17, 2017 at 03:42:32PM +0200, Juan Quintela wrote: >> We now send several pages at a time each time that we wakeup a thread. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> Use iovec's insead of creating the equivalent. >> --- >> migration/ram.c | 4

Re: [Qemu-devel] [PATCH] vl.c/exit: pause cpus before closing block devices

2017-08-08 Thread Kevin Wolf
Am 08.08.2017 um 13:04 hat Paolo Bonzini geschrieben: > On 08/08/2017 12:02, Kevin Wolf wrote: > > Am 04.08.2017 um 13:46 hat Paolo Bonzini geschrieben: > >> On 04/08/2017 11:58, Stefan Hajnoczi wrote: > the root cause of this bug is related to this as well: > https://lists.gnu.org/archiv

Re: [Qemu-devel] [RFC] docs/devel/loads-stores.rst: Document our various load and store APIs

2017-08-08 Thread Paolo Bonzini
On 08/08/2017 12:44, Peter Maydell wrote: > +``cpu_{ld,st}_*`` > +~ > + > +These functions operate on a guest virtual address. Be aware > +that these functions may cause a guest CPU exception to be > +taken (eg for an alignment fault or MMU fault) which will > +result in guest CPU s

Re: [Qemu-devel] [PATCH for-2.10] block/nfs: fix mutex assertion in nfs_file_close()

2017-08-08 Thread Kevin Wolf
Am 08.08.2017 um 00:29 hat Jeff Cody geschrieben: > Commit c096358e747e88fc7364e40e3c354ee0bb683960 introduced assertion > checks for when qemu_mutex() functions are called without the > corresponding qemu_mutex_init() having initialized the mutex. > > This uncovered a latent bug in qemu's nfs dri

Re: [Qemu-devel] [Qemu-block] Unchecked blk_getlength() in device models and board code

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 04:01:18PM +0200, Markus Armbruster wrote: > blk_getlength() can fail. I figure the following need fixing: > > hw/arm/musicpal.c: musicpal_init() Seems okay: flash_size = blk_getlength(blk); if (flash_size != 8*1024*1024 && flash_size != 16*1024*1024 && flash_size !=

Re: [Qemu-devel] [Qemu-block] Unchecked blk_getlength() in device models and board code

2017-08-08 Thread Peter Maydell
On 8 August 2017 at 13:04, Stefan Hajnoczi wrote: > On Fri, Aug 04, 2017 at 04:01:18PM +0200, Markus Armbruster wrote: >> blk_getlength() can fail. I figure the following need fixing: >> >> hw/arm/musicpal.c: musicpal_init() > > Seems okay: > > flash_size = blk_getlength(blk); > if (flash_size !=

Re: [Qemu-devel] [PATCH v5 11/17] migration: Really use multiple pages at a time

2017-08-08 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> We now send several pages at a time each time that we wakeup a thread. >> >> Signed-off-by: Juan Quintela >> >> -- >> >> Use iovec's insead of creating the equivalent. >> --- >> migration/ram.c | 46

[Qemu-devel] [PATCH for-2.10] target/mips: remove MIPS16 ASE from 4Km

2017-08-08 Thread Philippe Mathieu-Daudé
MIPS32 4Km does not support the MIPS16 instruction set, see: MIPS32 4K Processor Core Family Software UM (MD00016 Rev 01.18) Signed-off-by: Philippe Mathieu-Daudé --- probably incorrect copy/paste from 8d162c2b68db72623a507069fda0e35ccd1c6b85 target/mips/translate_init.c | 2 +- 1 file chan

[Qemu-devel] [PATCH 1/1] 9pfs: fix and simplify dependencies

2017-08-08 Thread Cornelia Huck
We want to compile the 9pfs code iff virtfs is enabled and a virtio transport is available (not only pci!). Let's make the generated CONFIG_VIRTFS statement depend on either CONFIG_VIRTIO_PCI or (new) CONFIG_VIRTIO_CCW. The Makefiles for fsdev/ and hw/9pfs/ can then depend on CONFIG_VIRTFS directl

[Qemu-devel] [PATCH 0/1] fixup 9pfs dependencies

2017-08-08 Thread Cornelia Huck
During my work on cleaning up the pci dependencies on s390x (see my "s390x: zPCI detangling" patch series), I noticed that the 9pfs code is only built if CONFIG_PCI is set. There's really nothing in there that should depend on CONFIG_PCI (it is really transport-agnostic); we do want to make sure th

[Qemu-devel] [PATCH] virtio-blk: handle blk_getlength() errors

2017-08-08 Thread Stefan Hajnoczi
If blk_getlength() fails in virtio_blk_update_config() consider the disk image length to be 0 bytes. Signed-off-by: Stefan Hajnoczi --- hw/block/virtio-blk.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index b750bd8b53..a16

Re: [Qemu-devel] [PATCH v8 0/5] hypertrace: Lightweight guest-to-QEMU trace channel

2017-08-08 Thread Stefan Hajnoczi
On Fri, Aug 04, 2017 at 09:32:25PM +0300, Lluís Vilanova wrote: > Stefan Hajnoczi writes: > > > On Sun, Jul 30, 2017 at 05:08:18PM +0300, Lluís Vilanova wrote: > >> The hypertrace channel allows guest code to emit events in QEMU (the host) > >> using > >> its tracing infrastructure (see "docs/tra

[Qemu-devel] [Bug 1708462] Re: Support Python 3 to build

2017-08-08 Thread Stefan Hajnoczi
Python 2 EOL is in 2020 so there is a fair amount of time. QEMU is transitioning to support both Python 2.6+ and 3 but most Python code has not been converted yet. You are welcome to contribute patches: https://wiki.qemu.org/index.php/Contribute/SubmitAPatch -- You received this bug notificatio

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-08 Thread Pradeep Jagadeesh
On 8/8/2017 1:30 PM, Alberto Garcia wrote: On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: Awkward question for a v7, but here goes anyway: why is IOThrottle worth its very own .json file? I feel this is a common throttle structure that is used by block devices as well as fsdev, s

Re: [Qemu-devel] [PATCH v3] build-sys: add --disable-vhost-user

2017-08-08 Thread Marc-André Lureau
Hi On Sun, Aug 6, 2017 at 11:19 PM Paolo Bonzini wrote: > On 05/08/2017 09:39, Thomas Huth wrote: > >> +CONFIG_VHOST_USER_SCSI=$(and $(CONFIG_VHOST_USER),$(CONFIG_LINUX)) > > I have to say that I don't really like using $(and ...) in our makefiles > > like this. You rely on the fact that the con

Re: [Qemu-devel] [PATCH v4 01/10] qemu.py: Pylint/style fixes

2017-08-08 Thread Stefan Hajnoczi
On Wed, Jul 26, 2017 at 04:42:17PM +0200, Lukáš Doktor wrote: > No actual code changes, just several pylint/style fixes and docstring > clarifications. > > Signed-off-by: Lukáš Doktor > --- > scripts/qemu.py | 76 > - > 1 file changed, 53

  1   2   3   4   >