Re: [Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-07-23 Thread Matwey V. Kornilov
2017-02-08 11:49 GMT+03:00 Paolo Bonzini : >> Does qemu follow recommendations from section 4.3? > > All that QEMU does is initialize MSR values and QEMU is talking to KVM, > not to the processor; KVM in turn talks to the host kernel's perf > subsystem. > > It's the host kernel's perf subsystem tha

Re: [Qemu-devel] [PATCH] vhost-user: fix watcher need be removed when vhost-user hotplug

2017-07-23 Thread Marc-André Lureau
Hi On Sun, Jul 23, 2017 at 4:12 AM, Michael S. Tsirkin wrote: > On Sat, Jul 22, 2017 at 09:24:27AM +, Marc-André Lureau wrote: >> >> >> On Sat, Jul 22, 2017 at 2:35 AM Michael S. Tsirkin wrote: >> >> On Fri, Jul 21, 2017 at 11:19:04AM +, Marc-André Lureau wrote: >> > Hi >> >

Re: [Qemu-devel] [Bug 1661386] Re: Assertion `ret == cpu->kvm_msr_buf->nmsrs' failed

2017-07-23 Thread Matwey V. Kornilov
2017-07-23 12:54 GMT+03:00 Matwey V. Kornilov : > 2017-02-08 11:49 GMT+03:00 Paolo Bonzini : >>> Does qemu follow recommendations from section 4.3? >> >> All that QEMU does is initialize MSR values and QEMU is talking to KVM, >> not to the processor; KVM in turn talks to the host kernel's perf >> s

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-23 Thread Michael S. Tsirkin
On Sun, Jul 23, 2017 at 01:15:42AM +0300, Aleksandr Bezzubikov wrote: > To enable hotplugging of a newly created pcie-pci-bridge, > we need to tell firmware (SeaBIOS in this case) Presumably, EFI would need to support this too? > to reserve > additional buses for pcie-root-port, that allows us to

Re: [Qemu-devel] [PULL 5/6] console: remove do_safe_dpy_refresh

2017-07-23 Thread Paolo Bonzini
On 18/07/2017 15:56, Laurent Vivier wrote: > On 18/07/2017 15:07, Laurent Vivier wrote: >> On 21/06/2017 15:23, Gerd Hoffmann wrote: >>> Drop the temporary workaround for the broken display updates. >>> All display adapters are updated, so this should be safe without >>> causing regressions. >> >>

[Qemu-devel] [Bug 1089005] Re: Qemu does not shutdown with vnc enabled on OS X

2017-07-23 Thread Rida Shamasneh
the issue is still there i am using 2.9.50 i want to stop a running process when i press ctrl-c and not stop the whole qemu -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1089005 Title: Qemu does no

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-23 Thread Rik van Riel
On Sat, 2017-07-22 at 12:34 -0700, Dan Williams wrote: > On Fri, Jul 21, 2017 at 8:58 AM, Stefan Hajnoczi > wrote: > > > > Maybe the NVDIMM folks can comment on this idea. > > I think it's unworkable to use the flush hints as a guest-to-host > fsync mechanism. That mechanism was designed to flush

Re: [Qemu-devel] [PATCH 1/5] Makefile: clean: Clean exe files

2017-07-23 Thread Philippe Mathieu-Daudé
Hi Sameeh, On 07/05/2017 04:54 AM, Sameeh Jubran wrote: From: Sameeh Jubran Clean exe files such as qemu-ga.exe Signed-off-by: Sameeh Jubran --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index 16a0430..22d29d6 100644 --- a/Makefile +++ b/Makefile @@

Re: [Qemu-devel] [RFC PATCH v2 5/6] hw/pci: add bus_reserve property to pcie-root-port

2017-07-23 Thread Marcel Apfelbaum
On 23/07/2017 15:22, Michael S. Tsirkin wrote: On Sun, Jul 23, 2017 at 01:15:42AM +0300, Aleksandr Bezzubikov wrote: To enable hotplugging of a newly created pcie-pci-bridge, we need to tell firmware (SeaBIOS in this case) Hi Michael, Presumably, EFI would need to support this too? Sure

Re: [Qemu-devel] [PATCH] qemu-iotests: add a "how to" to ./README

2017-07-23 Thread Philippe Mathieu-Daudé
On 07/21/2017 12:51 PM, Stefan Hajnoczi wrote: On Fri, Jul 21, 2017 at 07:16:34AM -0500, Eric Blake wrote: On 07/21/2017 04:34 AM, Stefan Hajnoczi wrote: There is not much getting started documentation for qemu-iotests. This patch explains how to create a new test and covers the overall testin

Re: [Qemu-devel] [Qemu-arm] [RFC PATCH for 2.11 01/23] softfloat: move existing softfloat2a into versioned directory

2017-07-23 Thread Philippe Mathieu-Daudé
Even if some people ever object to use SoftFloat3c and your series, this patch fits well for mainline. On 07/20/2017 12:04 PM, Alex Bennée wrote: This is a precursor to importing SoftFloat3c into the QEMU source tree. As the two versions of SoftFloat present different APIs the hope is to select

Re: [Qemu-devel] [Qemu-block] [PATCH] block: check BlockDriverState object before dereference

2017-07-23 Thread Paolo Bonzini
On 21/07/2017 17:47, Stefan Hajnoczi wrote: > Hmm...BlockDriverState still has bdrv_is_inserted() even though > BlockBackend->root can be NULL? CCing Markus in case he has thoughts on > the BB/BDS split. > > I find it weird that block-backend.c calls bdrv_inc_in_flight() and then > bdrv_co_flush(

Re: [Qemu-devel] [PULL 40/41] vhost-user-scsi: Introduce vhost-user-scsi host device

2017-07-23 Thread Paolo Bonzini
On 18/07/2017 18:32, Marc-André Lureau wrote: > > > On Thu, Jun 15, 2017 at 1:20 PM Paolo Bonzini > wrote: > > From: Felipe Franciosi mailto:fel...@nutanix.com>> > > This commit introduces a vhost-user device for SCSI. This is based > on the existing vho

Re: [Qemu-devel] [PATCH 19/29] disas: use QEMU_IS_ALIGNED macro

2017-07-23 Thread Paolo Bonzini
On 18/07/2017 16:43, Thomas Huth wrote: > On 18.07.2017 13:07, Marc-André Lureau wrote: >> Hi >> >> On Mon, Jul 17, 2017 at 11:09 PM, Philippe Mathieu-Daudé >> wrote: >>> Applied using the Coccinelle semantic patch >>> scripts/coccinelle/use_osdep.cocci > [...] >>> diff --git a/disas.c b/disas.c

[Qemu-devel] [Bug 1295587] Re: Temporal freeze and slowdown while using emulated sb16

2017-07-23 Thread Blake Lee
Is there any fix or workaround for this bug? Some old games won't use the AC97 and require SB16. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1295587 Title: Temporal freeze and slowdown while usin

Re: [Qemu-devel] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-07-23 Thread Marcel Apfelbaum
On 23/07/2017 1:15, Aleksandr Bezzubikov wrote: On PCI init PCI bridges may need some extra info about bus number to reserve, IO, memory and prefetchable memory limits. QEMU can provide this with special vendor-specific PCI capability. Sizes of limits match ones from PCI Type 1 Configuration Spa

Re: [Qemu-devel] [RFC PATCH v2 2/6] hw/i386: allow SHPC for Q35 machine

2017-07-23 Thread Marcel Apfelbaum
On 23/07/2017 1:15, Aleksandr Bezzubikov wrote: Unmask previously masked SHPC feature in _OSC method. Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6b7bade..0d

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-23 Thread Dan Williams
[ adding Ross and Jan ] On Sun, Jul 23, 2017 at 7:04 AM, Rik van Riel wrote: > On Sat, 2017-07-22 at 12:34 -0700, Dan Williams wrote: >> On Fri, Jul 21, 2017 at 8:58 AM, Stefan Hajnoczi > > wrote: >> > >> > Maybe the NVDIMM folks can comment on this idea. >> >> I think it's unworkable to use the

Re: [Qemu-devel] [RFC PATCH v2 1/4] pci: refactor pci_find_capapibilty to get bdf as the first argument instead of the whole pci_device

2017-07-23 Thread Marcel Apfelbaum
Hi Alexandr, On 23/07/2017 1:11, Aleksandr Bezzubikov wrote: Refactor pci_find_capability function to get bdf instead of a whole pci_device* as the only necessary field for this function is still bdf. It greatly helps when we have bdf but not pci_device. You can drop the last sentence. Other t

Re: [Qemu-devel] [RFC PATCH v2 2/4] pci: add RedHat vendor ID

2017-07-23 Thread Marcel Apfelbaum
On 23/07/2017 1:11, Aleksandr Bezzubikov wrote: Signed-off-by: Aleksandr Bezzubikov --- src/hw/pci_ids.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/hw/pci_ids.h b/src/hw/pci_ids.h index 4ac73b4..db2e694 100644 --- a/src/hw/pci_ids.h +++ b/src/hw/pci_ids.h @@ -2263,6 +2263,8 @@

Re: [Qemu-devel] [RFC PATCH v2 3/4] pci: add QEMU-specific PCI capability structure

2017-07-23 Thread Alexander Bezzubikov
2017-07-23 5:44 GMT+03:00 Michael S. Tsirkin : > On Sun, Jul 23, 2017 at 01:11:49AM +0300, Aleksandr Bezzubikov wrote: > > On PCI init PCI bridge devices may need some > > extra info about bus number to reserve, IO, memory and > > prefetchable memory limits. QEMU can provide this > > with special

Re: [Qemu-devel] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-07-23 Thread Alexander Bezzubikov
2017-07-23 18:57 GMT+03:00 Marcel Apfelbaum : > On 23/07/2017 1:15, Aleksandr Bezzubikov wrote: > >> On PCI init PCI bridges may need some >> extra info about bus number to reserve, IO, memory and >> prefetchable memory limits. QEMU can provide this >> with special vendor-specific PCI capability.

Re: [Qemu-devel] [RFC PATCH v2 4/6] hw/pci: introduce bridge-only vendor-specific capability to provide some hints to firmware

2017-07-23 Thread Marcel Apfelbaum
On 23/07/2017 19:19, Alexander Bezzubikov wrote: 2017-07-23 18:57 GMT+03:00 Marcel Apfelbaum >: On 23/07/2017 1:15, Aleksandr Bezzubikov wrote: On PCI init PCI bridges may need some extra info about bus number to reserve, IO, memory and pref

Re: [Qemu-devel] [RFC PATCH v2 1/4] pci: refactor pci_find_capapibilty to get bdf as the first argument instead of the whole pci_device

2017-07-23 Thread Kevin O'Connor
On Sun, Jul 23, 2017 at 01:11:47AM +0300, Aleksandr Bezzubikov wrote: > Refactor pci_find_capability function to get bdf instead of > a whole pci_device* as the only necessary field for this function > is still bdf. > It greatly helps when we have bdf but not pci_device. > > Signed-off-by: Aleksa

Re: [Qemu-devel] >256 Virtio-net-pci hotplug Devices

2017-07-23 Thread Marcel Apfelbaum
On 22/07/2017 2:57, Kinsella, Ray wrote: Hi Marcel Hi Ray, On 21/07/2017 01:33, Marcel Apfelbaum wrote: On 20/07/2017 3:44, Kinsella, Ray wrote: That's strange. Please ensure the virtio devices are working in virtio 1.0 mode (disable-modern=0,disable-legacy=1). Let us know any problems yo

Re: [Qemu-devel] [RFC PATCH v2 3/4] pci: add QEMU-specific PCI capability structure

2017-07-23 Thread Kevin O'Connor
On Sun, Jul 23, 2017 at 01:11:49AM +0300, Aleksandr Bezzubikov wrote: > On PCI init PCI bridge devices may need some > extra info about bus number to reserve, IO, memory and > prefetchable memory limits. QEMU can provide this > with special vendor-specific PCI capability. > > This capability is in

Re: [Qemu-devel] [RFC PATCH v2 4/4] pci: enable RedHat PCI bridges to reserve additional buses on PCI init

2017-07-23 Thread Alexander Bezzubikov
2017-07-23 5:49 GMT+03:00 Michael S. Tsirkin : > On Sun, Jul 23, 2017 at 01:11:50AM +0300, Aleksandr Bezzubikov wrote: > > In case of Red Hat PCI bridges reserve additional buses, which number is > provided > > in a vendor-specific capability. > > > > Signed-off-by: Aleksandr Bezzubikov > > --- >

Re: [Qemu-devel] [RFC PATCH v2 3/4] pci: add QEMU-specific PCI capability structure

2017-07-23 Thread Alexander Bezzubikov
2017-07-23 19:30 GMT+03:00 Kevin O'Connor : > On Sun, Jul 23, 2017 at 01:11:49AM +0300, Aleksandr Bezzubikov wrote: > > On PCI init PCI bridge devices may need some > > extra info about bus number to reserve, IO, memory and > > prefetchable memory limits. QEMU can provide this > > with special ven

Re: [Qemu-devel] [RFC PATCH v2 2/6] hw/i386: allow SHPC for Q35 machine

2017-07-23 Thread Alexander Bezzubikov
2017-07-23 18:59 GMT+03:00 Marcel Apfelbaum : > On 23/07/2017 1:15, Aleksandr Bezzubikov wrote: > >> Unmask previously masked SHPC feature in _OSC method. >> >> Signed-off-by: Aleksandr Bezzubikov >> --- >> hw/i386/acpi-build.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> dif

Re: [Qemu-devel] [PATCH v2 3/5] target/s390x: Rework program_interrupt() and related functions

2017-07-23 Thread Richard Henderson
On 07/21/2017 04:45 AM, Thomas Huth wrote: +static void tcg_s390_program_interrupt(CPUS390XState *env, uint32_t code, + int ilen) +{ +trigger_pgm_exception(env, code, ilen); +#ifdef CONFIG_TCG +cpu_loop_exit(CPU(s390_env_get_cpu(env))); +#endif +} +

Re: [Qemu-devel] [PATCH v2 4/5] target/s390x: Move exception-related functions to a new excp_helper.c file

2017-07-23 Thread Richard Henderson
On 07/21/2017 04:45 AM, Thomas Huth wrote: These functions can not be compiled with --disable-tcg. But since we need the other functions from helper.c in the non-tcg build, we can also not simply remove helper.c from the non-tcg builds. Thus the problematic functions have to be moved into a separ

Re: [Qemu-devel] [PATCH v2 5/5] target/s390x: Add remaining switches to compile with --disable-tcg

2017-07-23 Thread Richard Henderson
On 07/21/2017 07:45 AM, Thomas Huth wrote: Adding some CONFIG_TCG tests to be finally able to compile QEMU on s390x also without TCG. Signed-off-by: Thomas Huth --- target/s390x/Makefile.objs | 6 +++--- target/s390x/cpu.c | 4 2 files changed, 7 insertions(+), 3 deletions(-)

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-23 Thread Rik van Riel
On Sun, 2017-07-23 at 09:01 -0700, Dan Williams wrote: > [ adding Ross and Jan ] > > On Sun, Jul 23, 2017 at 7:04 AM, Rik van Riel > wrote: > > > > The goal is to increase density of guests, by moving page > > cache into the host (where it can be easily reclaimed). > > > > If we assume the gues

Re: [Qemu-devel] [RFC PATCH v2 4/4] pci: enable RedHat PCI bridges to reserve additional buses on PCI init

2017-07-23 Thread Alexander Bezzubikov
By the way, any ideas on how to avoid 'bus overstealing' would be greatly appreciated. Static BIOS variable isn't applicable since its value isn't saved across reboots. 2017-07-23 19:43 GMT+03:00 Alexander Bezzubikov : > 2017-07-23 5:49 GMT+03:00 Michael S. Tsirkin : > >> On Sun, Jul 23, 2017 at

Re: [Qemu-devel] [PATCH 00/11] Make memory_region_init_ram() and friends handle migration

2017-07-23 Thread Peter Maydell
On 22 July 2017 at 05:47, Philippe Mathieu-Daudé wrote: > I'm seeing memleaks using the malta machine, they come from the > smbus_eeprom_init() in hw/i2c/smbus_eeprom.c which does: > > uint8_t *eeprom_buf = g_malloc0(8 * 256); /* XXX: make this persistent > */ (This isn't actually a leak beca

Re: [Qemu-devel] [PATCH 1/5] Makefile: clean: Clean exe files

2017-07-23 Thread Peter Maydell
On 5 July 2017 at 08:54, Sameeh Jubran wrote: > From: Sameeh Jubran > > Clean exe files such as qemu-ga.exe > > Signed-off-by: Sameeh Jubran > --- > Makefile | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Makefile b/Makefile > index 16a0430..22d29d6 100644 > --- a/Makefile > +++ b/Mak

Re: [Qemu-devel] >256 Virtio-net-pci hotplug Devices

2017-07-23 Thread Kevin O'Connor
On Sun, Jul 23, 2017 at 07:28:01PM +0300, Marcel Apfelbaum wrote: > On 22/07/2017 2:57, Kinsella, Ray wrote: > > When scaling up to 512 Virtio-net devices SeaBIOS appears to really slow > > down when configuring PCI Config space - haven't manage to get this to > > work yet. If there is a slowdown

[Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-23 Thread Hua Yanghao
>From 84f25a8e4269f44255a8037837fdaa6e5404b76e Mon Sep 17 00:00:00 2001 From: Hua Yanghao Date: Sun, 23 Jul 2017 21:48:21 +0200 Subject: [PATCH] hw/core/loader: do not check for regions overlap There is a use case where regions are overlapped on purpose. It should be up to the linker to check for

Re: [Qemu-devel] KVM "fake DAX" flushing interface - discussion

2017-07-23 Thread Dan Williams
On Sun, Jul 23, 2017 at 11:10 AM, Rik van Riel wrote: > On Sun, 2017-07-23 at 09:01 -0700, Dan Williams wrote: >> [ adding Ross and Jan ] >> >> On Sun, Jul 23, 2017 at 7:04 AM, Rik van Riel >> wrote: >> > >> > The goal is to increase density of guests, by moving page >> > cache into the host (whe

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-23 Thread Peter Maydell
On 23 July 2017 at 21:04, Hua Yanghao wrote: > From 84f25a8e4269f44255a8037837fdaa6e5404b76e Mon Sep 17 00:00:00 2001 > From: Hua Yanghao > Date: Sun, 23 Jul 2017 21:48:21 +0200 > Subject: [PATCH] hw/core/loader: do not check for regions overlap > > There is a use case where regions are overlappe

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-23 Thread Hua Yanghao
> (I'm not sure why you end up with overlapping > program segments here since the bss segment ought > to be marked NOLOAD and ignored by QEMU. But I've > definitely seen overlapping segments myself where > the segments overlapping both are marked as LOAD.) Looks like qemu is not ignoring NOLOAD sec

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-23 Thread Peter Maydell
On 23 July 2017 at 21:58, Hua Yanghao wrote: >> (1) does this change give the right behaviour for >> which of the two overlapping segment is honoured? >> (I *think* the correct answer is that the second >> segment in the program header table should be >> loaded second, ie its definition of the mem

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-23 Thread Hua Yanghao
> Suppose we have these two segments: > SEGMENT 1: start 0x1000, end 0x2fff, data all 0xff > SEGMENT 2: start 0x2000, end 0x3fff, data all 0x00 > > Clearly for the memory 0x1000..0x1fff we want the 0xff > data, and for 0x3000..0x3fff we want 0x00. > But for the memory 0x2000..0x2fff which is in >

Re: [Qemu-devel] [PATCH] hw/core/loader: do not check for regions overlap

2017-07-23 Thread Peter Maydell
On 23 July 2017 at 23:11, Hua Yanghao wrote: >> Suppose we have these two segments: >> SEGMENT 1: start 0x1000, end 0x2fff, data all 0xff >> SEGMENT 2: start 0x2000, end 0x3fff, data all 0x00 >> >> Clearly for the memory 0x1000..0x1fff we want the 0xff >> data, and for 0x3000..0x3fff we want 0x0

[Qemu-devel] About virtio device hotplug in Q35!

2017-07-23 Thread Zhong Yang
Hello all, When we did virtio device hotplug in Q35 platform, which always failed in hotplug. Would you please tell me how to configure VM to make virtio device hotplug work in Q35 platform? Many thanks! Regards, Yang zhong

Re: [Qemu-devel] Can I mount encrypt qcow2?

2017-07-23 Thread 陳培泓
I check to the newest version of qemu. and do the cmds to install followed by the documents in github: > mkdir build > cd build > ../configure > make and it show nothing errors​ It's the version when I enter qemu-img --help: and I execute encrypt format(luks) to the qcow2 file: ​ always shows

Re: [Qemu-devel] [Qemu-ppc] [FIX PATCH v2] spapr: Fix QEMU abort during memory unplug

2017-07-23 Thread David Gibson
On Fri, Jul 21, 2017 at 08:23:02AM -0300, Daniel Henrique Barboza wrote: > > > On 07/21/2017 03:57 AM, David Gibson wrote: > > On Fri, Jul 21, 2017 at 10:21:06AM +0530, Bharata B Rao wrote: > > > Commit 0cffce56 (hw/ppc/spapr.c: adding pending_dimm_unplugs to > > > sPAPRMachineState) introduced a

Re: [Qemu-devel] Unified Datagram Socket Transport

2017-07-23 Thread Jason Wang
On 2017年07月21日 12:25, Anton Ivanov wrote: On 21/07/17 04:55, Jason Wang wrote: On 2017年07月21日 03:12, anton.iva...@cambridgegreys.com wrote: Hi all, This addresses comments so far except Eric's suggestion to use InetSocketAddressBase. If I understand correctly its intended use, it will no

Re: [Qemu-devel] [PATCH v1 0/6] target/s390x: tcg improvments + MSA functions

2017-07-23 Thread Richard Henderson
On 07/21/2017 05:56 AM, David Hildenbrand wrote: 1. smaller pgm irq instruction length fixes I think maybe we should add insn length data to the unwind data, so that we can have env->int_pgm_ilen set to the right value whenever cpu_restore_state is called. r~

Re: [Qemu-devel] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

2017-07-23 Thread David Gibson
On Fri, Jul 21, 2017 at 06:21:31PM +1000, Benjamin Herrenschmidt wrote: > On Fri, 2017-07-21 at 17:50 +1000, David Gibson wrote: > > On Wed, Jul 19, 2017 at 02:02:18PM +1000, Benjamin Herrenschmidt wrote: > > > On Wed, 2017-07-19 at 13:08 +1000, David Gibson wrote: > > > > > > > > I'm somewhat unc

Re: [Qemu-devel] [PATCH 1/3] Unified Datagram Socket Transport

2017-07-23 Thread Jason Wang
On 2017年07月22日 01:50, Anton Ivanov wrote: [snip] +NetUnifiedState *s = (NetUnifiedState *) us; +L2TPV3TunnelParams *p = (L2TPV3TunnelParams *) s->params; How about embedding NetUnifiedState into this structure and keep using NetL2TPV3State? Then: - 's' could be kept and lots of

Re: [Qemu-devel] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

2017-07-23 Thread Alexey Kardashevskiy
On 24/07/17 13:28, David Gibson wrote: > On Fri, Jul 21, 2017 at 06:21:31PM +1000, Benjamin Herrenschmidt wrote: >> On Fri, 2017-07-21 at 17:50 +1000, David Gibson wrote: >>> On Wed, Jul 19, 2017 at 02:02:18PM +1000, Benjamin Herrenschmidt wrote: On Wed, 2017-07-19 at 13:08 +1000, David Gibson

Re: [Qemu-devel] [PATCH 3/3] Unified Datagram Socket Transport - raw support

2017-07-23 Thread Jason Wang
On 2017年07月22日 02:50, Anton Ivanov wrote: [snip] +"-netdev raw,id=str,ifname=ifname\n" +"configure a network backend with ID 'str' connected to\n" +"an Ethernet interface named ifname via raw socket.\n" +"This backend does not

Re: [Qemu-devel] [RFC PATCH 06/26] ppc/xive: introduce a XIVE interrupt source model

2017-07-23 Thread David Gibson
On Wed, Jul 05, 2017 at 07:13:19PM +0200, Cédric Le Goater wrote: > This is very similar to the current ICS_SIMPLE model in XICS. We try > to reuse the ICS model because the sPAPR machine is tied to the > XICSFabric interface and should be using a common framework to switch > from one controller mo

Re: [Qemu-devel] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE interrupt source

2017-07-23 Thread David Gibson
On Wed, Jul 05, 2017 at 07:13:20PM +0200, Cédric Le Goater wrote: > Each interrupt source is associated with a 2-bit state machine called > an Event State Buffer (ESB). It is controlled by MMIO to trigger > events. > > See code for more details on the states. > > Signed-off-by: Cédric Le Goater

Re: [Qemu-devel] [PATCH v1 3/6] target/s390x: implement spm (SET PROGRAM MASK)

2017-07-23 Thread Richard Henderson
On 07/21/2017 05:56 AM, David Hildenbrand wrote: +tcg_gen_extrl_i64_i32(cc, o->in1); +tcg_gen_shri_i32(cc, cc, 28); +tcg_gen_andi_i32(cc, cc, 0x3ul); +tcg_gen_mov_i32(cc_op, cc); +tcg_temp_free_i32(cc); +set_cc_static(s); tcg_gen_extrl_i64_i32(cc_op, o->in1); tcg_gen_e

Re: [Qemu-devel] [PATCH v1 4/6] target/s390x: move wrap_address to cpu.h

2017-07-23 Thread Richard Henderson
On 07/21/2017 05:56 AM, David Hildenbrand wrote: Signed-off-by: David Hildenbrand --- target/s390x/cpu.h| 14 ++ target/s390x/mem_helper.c | 14 -- 2 files changed, 14 insertions(+), 14 deletions(-) Reviewed-by: Richard Henderson Although another header, pr

Re: [Qemu-devel] >256 Virtio-net-pci hotplug Devices

2017-07-23 Thread Kinsella, Ray
So as it turns out at 512 devices, it is nothing to do SeaBIOS, it was the Kernel again. It is taking quite a while to startup, a little over two hours (7489 seconds). The main culprits appear to be enumerating/initializing the PCI Express ports and enabling interrupts. The PCI Express Root Po

Re: [Qemu-devel] [RFC PATCH 08/26] ppc/xive: add flags to the XIVE interrupt source

2017-07-23 Thread David Gibson
On Wed, Jul 05, 2017 at 07:13:21PM +0200, Cédric Le Goater wrote: > These flags define some characteristics of the source : > > - XIVE_SRC_H_INT_ESB the Event State Buffer are controlled with a >specific hcall H_INT_ESB What's the other option? > - XIVE_SRC_LSI

Re: [Qemu-devel] [RFC PATCH 09/26] ppc/xive: add an overall memory region for the ESBs

2017-07-23 Thread David Gibson
On Wed, Jul 05, 2017 at 07:13:22PM +0200, Cédric Le Goater wrote: > Each source adds its own ESB mempry region to the overall ESB memory > region of the controller. It will be mapped in the CPU address space > when XIVE is activated. > > The default mapping address for the ESB memory region is the

Re: [Qemu-devel] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

2017-07-23 Thread Benjamin Herrenschmidt
On Mon, 2017-07-24 at 13:28 +1000, David Gibson wrote: > > So yes, in PAPR there's an "allocator" because the hypervisor will > > create a guest "virtual" (or logical to use PAPR terminology) interrupt > > number space, in order to represents the various interrupts into the > > guest. > > Ok, but

Re: [Qemu-devel] About virtio device hotplug in Q35!

2017-07-23 Thread Marcel Apfelbaum
On 24/07/2017 4:47, Zhong Yang wrote: Hello all, Hi, When we did virtio device hotplug in Q35 platform, which always failed in hotplug. Can we please see the QEMU command line and the description of the hotplug steps? Would you please tell me how to configure VM to make virtio device h

Re: [Qemu-devel] [RFC PATCH 10/26] ppc/xive: record interrupt source MMIO address for hcalls

2017-07-23 Thread David Gibson
On Wed, Jul 05, 2017 at 07:13:23PM +0200, Cédric Le Goater wrote: > The address of the MMIO page through which the Event State Buffer is > controlled is returned to the guest by the H_INT_GET_SOURCE_INFO hcall. > > Signed-off-by: Cédric Le Goater > --- > hw/intc/xive.c| 3 +++ > include/

Re: [Qemu-devel] [RFC PATCH 11/26] ppc/xics: introduce a print_info() handler to the ICS and ICP objects

2017-07-23 Thread David Gibson
On Wed, Jul 05, 2017 at 07:13:24PM +0200, Cédric Le Goater wrote: > This handler will be used to customize the ouput of the XIVE interrupt > source and presenter objects. I'm not really happy with this without having a clear idea of where this is heading - are you trying to share ICP and or ICS ob

[Qemu-devel] [GIT PULL for qemu-pseries] pseries: Update SLOF firmware image

2017-07-23 Thread Alexey Kardashevskiy
The following changes since commit 91939262ffcd3c85ea6a4793d3029326eea1d649: configure: Drop ancient Solaris 9 and earlier support (2017-07-21 15:04:05 +0100) are available in the git repository at: g...@github.com:aik/qemu.git tags/qemu-slof-20170724 for you to fetch changes up to 9f58186

Re: [Qemu-devel] [RFC PATCH 04/26] ppc/xive: introduce a skeleton for the XIVE interrupt controller model

2017-07-23 Thread David Gibson
On Mon, Jul 24, 2017 at 03:04:05PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2017-07-24 at 13:28 +1000, David Gibson wrote: > > > So yes, in PAPR there's an "allocator" because the hypervisor will > > > create a guest "virtual" (or logical to use PAPR terminology) interrupt > > > number space,

Re: [Qemu-devel] [PATCH qemu v4 1/3] spapr_iommu: Realloc guest visible TCE table when hot(un)plugging vfio-pci

2017-07-23 Thread David Gibson
On Thu, Jul 20, 2017 at 05:22:29PM +1000, Alexey Kardashevskiy wrote: > This replaces g_malloc() with spapr_tce_alloc_table() as this is > the standard way of allocating tables and this allows moving the table > back to KVM when unplugging a VFIO PCI device and VFIO TCE acceleration > support is no

Re: [Qemu-devel] [RFC PATCH 06/26] ppc/xive: introduce a XIVE interrupt source model

2017-07-23 Thread Alexey Kardashevskiy
On 24/07/17 14:02, David Gibson wrote: > On Wed, Jul 05, 2017 at 07:13:19PM +0200, Cédric Le Goater wrote: >> This is very similar to the current ICS_SIMPLE model in XICS. We try >> to reuse the ICS model because the sPAPR machine is tied to the >> XICSFabric interface and should be using a common

[Qemu-devel] [Device passthrough] Is there a way to passthrough PCIE switch/bridge ?

2017-07-23 Thread Bob Chen
- Bob

Re: [Qemu-devel] [RFC PATCH 13/26] ppc/xive: introduce a XIVE interrupt presenter model

2017-07-23 Thread David Gibson
On Wed, Jul 05, 2017 at 07:13:26PM +0200, Cédric Le Goater wrote: > Just like the interrupt source model, we try to reuse the ICP model > because the sPAPR machine is tied to the XICSFabric interface and > should be using a common framework to switch from one controller model > to another: XICS <->

Re: [Qemu-devel] [RFC PATCH 09/26] ppc/xive: add an overall memory region for the ESBs

2017-07-23 Thread Benjamin Herrenschmidt
On Mon, 2017-07-24 at 14:49 +1000, David Gibson wrote: > On Wed, Jul 05, 2017 at 07:13:22PM +0200, Cédric Le Goater wrote: > > Each source adds its own ESB mempry region to the overall ESB memory > > region of the controller. It will be mapped in the CPU address space > > when XIVE is activated. >

Re: [Qemu-devel] Unified Datagram Socket Transport

2017-07-23 Thread Anton Ivanov
That is an option as well. I am travelling this week and will get back to this first thing next week. A. On 24 July 2017 05:17:25 CEST, Jason Wang wrote: > > >On 2017年07月21日 12:25, Anton Ivanov wrote: >> >> >> On 21/07/17 04:55, Jason Wang wrote: >>> >>> >>> On 2017年07月21日 03:12, anton.iva...@

Re: [Qemu-devel] [PULL 6/9] Convert error_report() to warn_report()

2017-07-23 Thread Markus Armbruster
Markus Armbruster writes: > Kevin Wolf writes: > >> Am 13.07.2017 um 15:27 hat Markus Armbruster geschrieben: >>> From: Alistair Francis >>> >>> Convert all uses of error_report("warning:"... to use warn_report() >>> instead. This helps standardise on a single method of printing warnings >>> t

Re: [Qemu-devel] [RFC PATCH 14/26] ppc/xive: add MMIO handlers to the XIVE interrupt presenter model

2017-07-23 Thread David Gibson
On Wed, Jul 05, 2017 at 07:13:27PM +0200, Cédric Le Goater wrote: > The Thread Interrupt Management Area for the OS is mostly used to > acknowledge interrupts and set the CPPR of the CPU. > > The TIMA is mapped at the same address for each CPU. 'current_cpu' is > used to retrieve the targeted inte

Re: [Qemu-devel] [RFC PATCH 09/26] ppc/xive: add an overall memory region for the ESBs

2017-07-23 Thread David Gibson
On Mon, Jul 24, 2017 at 04:09:31PM +1000, Benjamin Herrenschmidt wrote: > On Mon, 2017-07-24 at 14:49 +1000, David Gibson wrote: > > On Wed, Jul 05, 2017 at 07:13:22PM +0200, Cédric Le Goater wrote: > > > Each source adds its own ESB mempry region to the overall ESB memory > > > region of the contr

Re: [Qemu-devel] [PATCH 3/3] qemu-iotests: require CONFIG_LINUX_AIO for test 087

2017-07-23 Thread Jing Liu
Hi Cleber, On 2017/7/21 上午11:47, Cleber Rosa wrote: One of the "sub-"tests of test 087 requires CONFIG_LINUX_AIO. As a PoC/RFC, this goes the easy route and skips the test as a whole when that feature is missing. Other approaches include splitting the test and adding extra filtering. Signed-

Re: [Qemu-devel] [PATCH] pc: acpi: force FADT rev1 for old i440fx machine types

2017-07-23 Thread Igor Mammedov
On Sat, 22 Jul 2017 02:40:46 +0300 "Michael S. Tsirkin" wrote: > On Fri, Jul 21, 2017 at 12:10:48PM +0200, Igor Mammedov wrote: > > On Fri, 21 Jul 2017 10:49:55 +0100 > > "Daniel P. Berrange" wrote: > > > > > On Fri, Jul 21, 2017 at 11:32:11AM +0200, Igor Mammedov wrote: > > > > w2k used to

Re: [Qemu-devel] [RFC PATCH 07/26] ppc/xive: add MMIO handlers to the XIVE interrupt source

2017-07-23 Thread Alexey Kardashevskiy
On 06/07/17 03:13, Cédric Le Goater wrote: > Each interrupt source is associated with a 2-bit state machine called > an Event State Buffer (ESB). It is controlled by MMIO to trigger > events. > > See code for more details on the states. > > Signed-off-by: Cédric Le Goater > --- > hw/intc/xive.c

Re: [Qemu-devel] Improving QMP test coverage

2017-07-23 Thread Markus Armbruster
Cleber Rosa writes: > On 07/21/2017 11:33 AM, Stefan Hajnoczi wrote: >>> Output testing style delegates checking ouput to diff. I rather like it >>> when text output is readily available. It is when testing QMP. A >>> non-trivial example using this style could be useful, as discussing >>> idea