Re: [Qemu-devel] Code source modifying

2017-07-11 Thread Ormaetxea Xabier
Hi Peter, One last question if possible :) I've changed the idea of "connecting the virtual and real worlds" to an easy (and ugly) way. I will use the decode function, where every single execution is translated from assembly language to binary code. There, comparing each assembly code with the

Re: [Qemu-devel] [PATCH v3 3/4] xen/mapcache: introduce xen_replace_cache_entry()

2017-07-11 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 11 July 2017 00:40 > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > Cc: Igor Druzhinin ; sstabell...@kernel.org; > Anthony Perard ; Paul Durrant > ; pbonz...@redhat.com > Subject: [PATCH v3 3/4] xen/mapcache: introduce > xen_r

Re: [Qemu-devel] [PATCH v3 4/4] xen: don't use xenstore to save/restore physmap anymore

2017-07-11 Thread Paul Durrant
> -Original Message- > From: Igor Druzhinin > Sent: 11 July 2017 00:40 > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > Cc: Igor Druzhinin ; sstabell...@kernel.org; > Anthony Perard ; Paul Durrant > ; pbonz...@redhat.com > Subject: [PATCH v3 4/4] xen: don't use xenstore to save

Re: [Qemu-devel] [PATCH v3 05/10] pc-bios/s390-ccw: Move byteswap functions to a separate header

2017-07-11 Thread Christian Borntraeger
On 07/10/2017 05:32 PM, Thomas Huth wrote: > We'll need them in code that is not related to bootmap.h, so > they should reside in an independent header. > > Signed-off-by: Thomas Huth Reviewed-by: Christian Borntraeger > --- > pc-bios/s390-ccw/bootmap.c | 1 + > pc-bios/s390-ccw/bootmap.h |

Re: [Qemu-devel] [PATCH v3 00/10] Implement network booting directly into the s390-ccw BIOS

2017-07-11 Thread Christian Borntraeger
On 07/10/2017 05:32 PM, Thomas Huth wrote: > It's already possible to do a network boot of an s390x guest with an > external netboot image based on a Linux installation, but it would > be much more convenient if the s390-ccw firmware supported network > booting right out of the box, without the nee

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-11 Thread Thomas Huth
On 10.07.2017 19:47, Eduardo Habkost wrote: > (CCing libvir-list) > > On Mon, Jul 10, 2017 at 07:45:54PM +0300, Michael S. Tsirkin wrote: >> On Mon, Jul 10, 2017 at 10:59:43AM -0300, Eduardo Habkost wrote: >>> On Mon, Jul 10, 2017 at 10:42:26AM +0300, Marcel Apfelbaum wrote: On 07/07/2017 21:

Re: [Qemu-devel] [PATCH v3 01/10] pc-bios/s390-ccw: Move libc functions to separate header

2017-07-11 Thread Cornelia Huck
On Mon, 10 Jul 2017 17:32:31 +0200 Thomas Huth wrote: > The upcoming netboot code will use the libc from SLOF. To be able > to still use s390-ccw.h there, the libc related functions in this > header have to be moved to a different location. > And while we're at it, remove the duplicate memcpy() f

Re: [Qemu-devel] [PATCH v3 03/10] pc-bios/s390-ccw: Move virtio-block related functions into a separate file

2017-07-11 Thread Cornelia Huck
On Mon, 10 Jul 2017 17:32:33 +0200 Thomas Huth wrote: > The netboot code is going to link against the code from virtio.c, too, so > we've got to move the virtio-block and -scsi related code out of the way. > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/Makefile| 2 +- > pc-b

Re: [Qemu-devel] [PATCH v6 1/2] bitmaps.md: Convert to rST; move it into 'interop' dir

2017-07-11 Thread Kashyap Chamarthy
On Mon, Jul 10, 2017 at 09:36:50PM -0500, Eric Blake wrote: > On 07/10/2017 03:15 AM, Kashyap Chamarthy wrote: [...] > > Signed-off-by: Kashyap Chamarthy > > Reviewed-by: John Snow > > --- > > > --- > > docs/devel/bitmaps.md| 505 -- > > docs/intero

Re: [Qemu-devel] [PATCH v3 05/10] pc-bios/s390-ccw: Move byteswap functions to a separate header

2017-07-11 Thread Cornelia Huck
On Mon, 10 Jul 2017 17:32:35 +0200 Thomas Huth wrote: > We'll need them in code that is not related to bootmap.h, so > they should reside in an independent header. > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/bootmap.c | 1 + > pc-bios/s390-ccw/bootmap.h | 26 --

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-11 Thread Marcel Apfelbaum
On 11/07/2017 10:48, Thomas Huth wrote: On 10.07.2017 19:47, Eduardo Habkost wrote: (CCing libvir-list) On Mon, Jul 10, 2017 at 07:45:54PM +0300, Michael S. Tsirkin wrote: On Mon, Jul 10, 2017 at 10:59:43AM -0300, Eduardo Habkost wrote: On Mon, Jul 10, 2017 at 10:42:26AM +0300, Marcel Apfelba

Re: [Qemu-devel] [PATCH] test-i386: Make x86 test program compile on clang

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 00:13, Theodore Dubois wrote: > I don’t believe so, I haven’t been able to find it in the bug database. This is now https://bugs.llvm.org/show_bug.cgi?id=33741. Paolo > ~Theodore > >> On Jul 10, 2017, at 2:48 PM, Paolo Bonzini wrote: >> >> On 10/07/2017 22:57, Theodore Dubois wro

Re: [Qemu-devel] [PATCH 21/22] tcg: enable per-thread TCG for softmmu

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 00:13, Emilio G. Cota wrote: > On Mon, Jul 10, 2017 at 17:33:07 -0400, Paolo Bonzini wrote: >> >>> I agree that it would be nice to have the same mechanism for all. >>> >>> The main hurdle I see is how to allow for concurrent code generation while >>> minimizing flushes of the single,

Re: [Qemu-devel] [PATCH v14 15/21] qom: support non-scalar properties with -object

2017-07-11 Thread Markus Armbruster
Manos Pitsidianakis writes: > Is there a specific reason this patch wasn't finished? If I'm not > wrong using non-scalar properties with -object is still not possible, > yet would be a very useful feature for drivers with UserCreatable > objects. > > Archive link since this is an old patch: > htt

[Qemu-devel] [PATCH] build: add -Wexpansion-to-defined

2017-07-11 Thread Paolo Bonzini
This warning is included in -Wall by clang, but not by GCC (which only enables it for -Wextra). Include it in the list of warnings we enable to minimize the differences between the compilers: Signed-off-by: Paolo Bonzini --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-11 Thread Gerd Hoffmann
Hi, > Concerning QEMU, could we maybe simply emit a warning a la > >  "you did not specify a machine type with the -M option, so you are >   currently running the the 'pc' machine type. Please note that > future >   versions of QEMU might use the 'q35' machine type instead. If you >   require t

[Qemu-devel] [PATCH] build: disable Xen on ARM

2017-07-11 Thread Paolo Bonzini
While ARM could present the xenpv machine, it does not and trying to enable it breaks compilation. Fixes: 3b6b75506de44c5070639943c30a0ad5850f5d02 Reported-by: Alex Bennée Signed-off-by: Paolo Bonzini --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index a

Re: [Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn

2017-07-11 Thread Kevin Wolf
Am 10.07.2017 um 18:58 hat Paolo Bonzini geschrieben: > QED's bdrv_invalidate_cache implementation would like to reuse functions > that acquire/release the metadata locks. Call it from coroutine context > to simplify the logic. > > Signed-off-by: Paolo Bonzini > diff --git a/block/qcow2.c b/blo

Re: [Qemu-devel] [PATCH v2 4/5] target/arm: use DISAS_JUMP for ISB handling

2017-07-11 Thread Alex Bennée
Richard Henderson writes: > On 07/10/2017 09:21 AM, Alex Bennée wrote: >> -s->is_jmp = DISAS_UPDATE; >> +gen_a64_set_pc_im(s->pc); >> +s->is_jmp = DISAS_JUMP; > > Better would be gen_goto_tb. The destination is known, so there's no > need to go through lookup_and_goto_pt

Re: [Qemu-devel] [PATCH 1/5] qcow2: make qcow2_do_open a coroutine_fn

2017-07-11 Thread Kevin Wolf
Am 10.07.2017 um 18:58 hat Paolo Bonzini geschrieben: > It is called from qcow2_invalidate_cache in coroutine context, so always > load metadata from a coroutine. > --- > block/qcow2.c | 45 - > 1 file changed, 40 insertions(+), 5 deletions(-) Missing S

Re: [Qemu-devel] [PATCH V2] chardev: fix parallel device can't be reconnect

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 13:47, Peng Hao wrote: > Parallel device don't register be->chr_can_read function, but remote > disconnect event is handled in chr_read.So connected parallel device > can not detect remote disconnect event. The chardevs with chr_can_read=NULL > has the same problem. > > Signed-off-by

Re: [Qemu-devel] [PATCH 1/5] qcow2: make qcow2_do_open a coroutine_fn

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 10:28, Kevin Wolf wrote: > Am 10.07.2017 um 18:58 hat Paolo Bonzini geschrieben: >> It is called from qcow2_invalidate_cache in coroutine context, so always >> load metadata from a coroutine. >> --- >> block/qcow2.c | 45 - >> 1 file change

Re: [Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 10:24, Kevin Wolf wrote: > Am 10.07.2017 um 18:58 hat Paolo Bonzini geschrieben: >> QED's bdrv_invalidate_cache implementation would like to reuse functions >> that acquire/release the metadata locks. Call it from coroutine context >> to simplify the logic. >> >> Signed-off-by: Paolo

[Qemu-devel] [PULL 1/2] trace: Fix early setting of events with the "vcpu" property

2017-07-11 Thread Stefan Hajnoczi
From: Lluís Vilanova Events with the "vcpu" property need to be set globally (i.e., as if they didn't have that property) while we have not yet created any vCPU. Signed-off-by: Lluís Vilanova Message-id: 149838891852.10366.11525912227070211356.st...@frigg.lan Signed-off-by: Stefan Hajnoczi ---

[Qemu-devel] [PULL 0/2] Tracing patches

2017-07-11 Thread Stefan Hajnoczi
The following changes since commit 6b06e3e49eb8c91cc286c16d6bf3181ac296f33d: Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2017-07-10-v2' into staging (2017-07-10 16:12:47 +0100) are available in the git repository at: git://github.com/stefanha/qemu.git tags/tracing-pull-request

Re: [Qemu-devel] [PATCH v10 0/7] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches

2017-07-11 Thread Stefan Hajnoczi
On Thu, Jun 29, 2017 at 03:13:30PM +0300, Lluís Vilanova wrote: > Optimizes tracing of events with the 'tcg' and 'vcpu' properties (e.g., memory > accesses), making it feasible to statically enable them by default on all QEMU > builds. Last patch shows that overheads are completely eliminated in va

[Qemu-devel] [PULL 2/2] backends: remove empty trace-events file

2017-07-11 Thread Stefan Hajnoczi
From: "Daniel P. Berrange" The content of the backends/trace-events file was entirely removed in commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6 Author: Marc-André Lureau Date: Mon May 29 12:39:42 2017 +0400 char: move char devices to chardev/ Leaving the empty file around, causes

Re: [Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn

2017-07-11 Thread Kevin Wolf
Am 11.07.2017 um 10:33 hat Paolo Bonzini geschrieben: > On 11/07/2017 10:24, Kevin Wolf wrote: > > Am 10.07.2017 um 18:58 hat Paolo Bonzini geschrieben: > >> QED's bdrv_invalidate_cache implementation would like to reuse functions > >> that acquire/release the metadata locks. Call it from coroutin

Re: [Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 10:39, Kevin Wolf wrote: > Can you just add a comment to this effect to qcow2/qed_do_open() then? Good point. >>> Or maybe the cleaner way would be bdrv_drained_begin/end() around >>> everything directly in bdrv_co_invalidate_cache(). > > Should we do this anyway? Or assert that no

Re: [Qemu-devel] [PATCH v3 06/10] pc-bios/s390-ccw: Add code for virtio feature negotiation

2017-07-11 Thread Cornelia Huck
On Mon, 10 Jul 2017 17:32:36 +0200 Thomas Huth wrote: > The upcoming virtio-net driver needs to negotiate some features, > so we need the possibility to do this in the core virtio code. > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/s390-ccw.h | 2 ++ > pc-bios/s390-ccw/virtio-b

Re: [Qemu-devel] [PATCH v3 08/10] pc-bios/s390-ccw: Add core files for the network bootloading program

2017-07-11 Thread Cornelia Huck
On Mon, 10 Jul 2017 17:32:38 +0200 Thomas Huth wrote: > This is just a preparation for the next steps: Add a makefile and a > stripped down copy of pc-bios/s390-ccw/main.c as a basis for the network > bootloader program, linked against the libc from SLOF already (which we > will need for SLOF's l

Re: [Qemu-devel] [PATCH v3 05/10] pc-bios/s390-ccw: Move byteswap functions to a separate header

2017-07-11 Thread Thomas Huth
On 11.07.2017 09:59, Cornelia Huck wrote: > On Mon, 10 Jul 2017 17:32:35 +0200 > Thomas Huth wrote: > >> We'll need them in code that is not related to bootmap.h, so >> they should reside in an independent header. >> >> Signed-off-by: Thomas Huth >> --- >> pc-bios/s390-ccw/bootmap.c | 1 + >>

Re: [Qemu-devel] [PATCH v3 09/10] pc-bios/s390-ccw: Add virtio-net driver code

2017-07-11 Thread Cornelia Huck
On Mon, 10 Jul 2017 17:32:39 +0200 Thomas Huth wrote: > The driver provides the recv() and send() functions which will > be required by SLOF's libnet code for receiving and sending > packets. > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/netboot.mak | 2 +- > pc-bios/s390-ccw/virt

Re: [Qemu-devel] [RFC PATCH 03/26] target/ppc/POWER9: add POWERPC_EXCP_POWER9

2017-07-11 Thread Cédric Le Goater
On 07/10/2017 11:00 PM, Benjamin Herrenschmidt wrote: > On Mon, 2017-07-10 at 14:49 +0200, Cédric Le Goater wrote: >> On 07/10/2017 12:26 PM, David Gibson wrote: >>> On Wed, Jul 05, 2017 at 07:13:16PM +0200, Cédric Le Goater wrote: Prepare ground for the new exception model XIVE of POWER9. >>>

Re: [Qemu-devel] [PATCH v3 10/10] pc-bios/s390-ccw: Link libnet into the netboot image and do the TFTP load

2017-07-11 Thread Cornelia Huck
On Mon, 10 Jul 2017 17:32:40 +0200 Thomas Huth wrote: > Most of the code has been taken from SLOF's netload.c file. Now we > can finally load an image via TFTP and execute the downloaded kernel. > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/netboot.mak | 12 ++- > pc-bios/s390-ccw/n

Re: [Qemu-devel] [PULL 0/9] migration queue

2017-07-11 Thread Peter Maydell
On 10 July 2017 at 18:10, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The following changes since commit 6b06e3e49eb8c91cc286c16d6bf3181ac296f33d: > > Merge remote-tracking branch 'remotes/ericb/tags/pull-nbd-2017-07-10-v2' > into staging (2017-07-10 16:12:47 +0100

Re: [Qemu-devel] [PATCH 3/5] block: convert bdrv_invalidate_cache callback to coroutine_fn

2017-07-11 Thread Kevin Wolf
Am 11.07.2017 um 10:41 hat Paolo Bonzini geschrieben: > On 11/07/2017 10:39, Kevin Wolf wrote: > > Can you just add a comment to this effect to qcow2/qed_do_open() then? > > Good point. > > >>> Or maybe the cleaner way would be bdrv_drained_begin/end() around > >>> everything directly in bdrv_co_

Re: [Qemu-devel] [PATCH v3 05/10] pc-bios/s390-ccw: Move byteswap functions to a separate header

2017-07-11 Thread Cornelia Huck
On Tue, 11 Jul 2017 10:52:24 +0200 Thomas Huth wrote: > On 11.07.2017 09:59, Cornelia Huck wrote: > > On Mon, 10 Jul 2017 17:32:35 +0200 > > Thomas Huth wrote: > > > >> We'll need them in code that is not related to bootmap.h, so > >> they should reside in an independent header. > >> > >> Sig

Re: [Qemu-devel] [PATCH 1/5] qcow2: make qcow2_do_open a coroutine_fn

2017-07-11 Thread Kevin Wolf
Am 11.07.2017 um 10:34 hat Paolo Bonzini geschrieben: > On 11/07/2017 10:28, Kevin Wolf wrote: > > Am 10.07.2017 um 18:58 hat Paolo Bonzini geschrieben: > >> It is called from qcow2_invalidate_cache in coroutine context, so always > >> load metadata from a coroutine. > >> --- > >> block/qcow2.c |

Re: [Qemu-devel] [PATCH 1/5] qcow2: make qcow2_do_open a coroutine_fn

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 11:07, Kevin Wolf wrote: > Am 11.07.2017 um 10:34 hat Paolo Bonzini geschrieben: >> On 11/07/2017 10:28, Kevin Wolf wrote: >>> Am 10.07.2017 um 18:58 hat Paolo Bonzini geschrieben: It is called from qcow2_invalidate_cache in coroutine context, so always load metadata from a

Re: [Qemu-devel] [PATCH] build: add -Wexpansion-to-defined

2017-07-11 Thread Stefan Hajnoczi
On Tue, Jul 11, 2017 at 10:10:33AM +0200, Paolo Bonzini wrote: > This warning is included in -Wall by clang, but not by GCC (which only > enables it for -Wextra). Include it in the list of warnings we enable > to minimize the differences between the compilers: > > Signed-off-by: Paolo Bonzini >

Re: [Qemu-devel] [PATCH V2] chardev: fix parallel device can't be reconnect

2017-07-11 Thread Daniel P. Berrange
On Tue, Jul 11, 2017 at 10:30:14AM +0200, Paolo Bonzini wrote: > On 11/07/2017 13:47, Peng Hao wrote: > > Parallel device don't register be->chr_can_read function, but remote > > disconnect event is handled in chr_read.So connected parallel device > > can not detect remote disconnect event. The cha

Re: [Qemu-devel] Disparity between host and guest CPU utilization during disk IO benchmark

2017-07-11 Thread Stefan Hajnoczi
On Mon, Jul 10, 2017 at 05:27:15PM +, Nagarajan, Padhu (HPE Storage) wrote: > Posted this in qemu-discuss and did not get a response. Hoping that someone > here might be able to offer insights. > > I was running an 8K random-read fio benchmark inside the guest with > iodepth=32. The device u

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/1] block: fix shadowed variable in bdrv_co_pdiscard

2017-07-11 Thread Stefan Hajnoczi
On Mon, Jul 10, 2017 at 06:05:59PM +0300, Denis V. Lunev wrote: > We've had a shadowed 'ret' variable, which risks returning the wrong > value, introduced in commit b9c64947. > > Signed-off-by: Denis V. Lunev > Reviewed-by: Fam Zheng > CC: Stefan Hajnoczi > CC: Kevin Wolf > CC: Eric Blake > -

Re: [Qemu-devel] [Qemu-block] [PATCH] commit: Add NULL check for overlay_bs

2017-07-11 Thread Stefan Hajnoczi
On Mon, Jul 10, 2017 at 01:45:25PM +0200, Kevin Wolf wrote: > I can't see how overlay_bs could become NULL with the current code, but > other code in this function already checks it and we can make Coverity > happy with this check, so let's add it. > > Signed-off-by: Kevin Wolf > --- > block/com

Re: [Qemu-devel] [PATCH] virtio-serial: add enable_backend callback

2017-07-11 Thread Laurent Vivier
On 10/07/2017 18:39, Michael S. Tsirkin wrote: > On Mon, Jul 10, 2017 at 04:13:54PM +0200, Laurent Vivier wrote: >>> static void virtconsole_realize(DeviceState *dev, Error **errp) >>> { >>> VirtIOSerialPort *port = VIRTIO_SERIAL_PORT(dev); >>> @@ -233,6 +253,7 @@ static void virtserialport_

[Qemu-devel] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder

2017-07-11 Thread Thomas Huth
The header is only used by accel/tcg/cputlb.c so we can move it to the accel/tcg/ folder, too. Signed-off-by: Thomas Huth --- Note: This patch should be applied after Philippe's "MAINTAINERS: update TCG entries" patch here: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg06529.html

[Qemu-devel] 答复: Re: [PATCH V2] chardev: fix parallel device can't be reconnect

2017-07-11 Thread peng.hao2
发件人: 收件人:彭浩10096742 抄送人: 王业超10154425 日 期 :2017年07月11日 16:31 主 题 :Re: [PATCH V2] chardev: fix parallel device can't be reconnect On 11/07/2017 13:47, Peng Hao wrote: > Parallel device don't register be->chr_can_read function, but remote > disconnect event is handled in chr_read.So connected

Re: [Qemu-devel] [Qemu-trivial] [PATCH] trivial: Move softmmu_template.h to the accel/tcg/ folder

2017-07-11 Thread Laurent Vivier
On 11/07/2017 11:31, Thomas Huth wrote: > The header is only used by accel/tcg/cputlb.c so we can > move it to the accel/tcg/ folder, too. > > Signed-off-by: Thomas Huth > --- > Note: This patch should be applied after Philippe's "MAINTAINERS: > update TCG entries" patch here: > https://lists.

Re: [Qemu-devel] [PATCH] hxtool: remove dead -q option

2017-07-11 Thread Stefan Hajnoczi
On Fri, Jul 07, 2017 at 05:46:46PM +0200, Paolo Bonzini wrote: > This was used to extract .txt documentation for QMP. This was > changed to use the QAPI schema instead, so zap it. > > Signed-off-by: Paolo Bonzini > --- > scripts/hxtool | 46 +- > 1 fi

Re: [Qemu-devel] [PATCH] commit: Add NULL check for overlay_bs

2017-07-11 Thread Kevin Wolf
Am 10.07.2017 um 14:09 hat Peter Maydell geschrieben: > On 10 July 2017 at 12:45, Kevin Wolf wrote: > > I can't see how overlay_bs could become NULL with the current code, but > > other code in this function already checks it and we can make Coverity > > happy with this check, so let's add it. > >

Re: [Qemu-devel] About the trace framework

2017-07-11 Thread Xie Changlong
在 7/11/2017 9:33 AM, Wang Dong 写道: On 07/10/2017 01:24 PM, Xie Changlong wrote: 在 7/9/2017 5:57 PM, Wang Dong 写道: Hi, I am new to QEMU. But I got some problem so that I want to figure it out. So I try to debug qemu to see what happened. And I found trace framework. I think this will hel

Re: [Qemu-devel] [PATCH v3 02/10] pc-bios/s390-ccw: Move ebc2asc to sclp.c

2017-07-11 Thread David Hildenbrand
On 10.07.2017 17:32, Thomas Huth wrote: > We will later need this array in a file that we will link to the > netboot code, too. Since there is some ebcdic conversion done > in sclp_get_loadparm_ascii(), the sclp.c file seems to be a good > candidate. > > Acked-by: Cornelia Huck > Signed-off-by: T

Re: [Qemu-devel] [Qemu-block] [PATCH 11/11] block/snapshot: do not take AioContext lock

2017-07-11 Thread Stefan Hajnoczi
On Mon, Jul 10, 2017 at 06:27:27PM +0200, Paolo Bonzini wrote: > On 10/07/2017 18:24, Stefan Hajnoczi wrote: > > On Thu, Jul 06, 2017 at 06:38:28PM +0200, Paolo Bonzini wrote: > >> Snapshots are only created/destroyed/loaded under the BQL, while no > >> other I/O is happening. Snapshot information

Re: [Qemu-devel] [Qemu-block] [PATCH 03/11] util: use RCU accessors for notifiers

2017-07-11 Thread Stefan Hajnoczi
On Mon, Jul 10, 2017 at 06:06:32PM +0200, Paolo Bonzini wrote: > On 10/07/2017 17:52, Stefan Hajnoczi wrote: > > On Thu, Jul 06, 2017 at 06:38:20PM +0200, Paolo Bonzini wrote: > >> void notifier_list_notify(NotifierList *list, void *data) > >> { > >> Notifier *notifier, *next; > >> > >> -

Re: [Qemu-devel] [PATCH v3 03/10] pc-bios/s390-ccw: Move virtio-block related functions into a separate file

2017-07-11 Thread David Hildenbrand
On 10.07.2017 17:32, Thomas Huth wrote: > The netboot code is going to link against the code from virtio.c, too, so > we've got to move the virtio-block and -scsi related code out of the way. > > Signed-off-by: Thomas Huth > --- > pc-bios/s390-ccw/Makefile| 2 +- > pc-bios/s390-ccw/mai

Re: [Qemu-devel] [PATCH 1/2] block: rename .bdrv_create() to .bdrv_co_create()

2017-07-11 Thread Kevin Wolf
Am 05.07.2017 um 12:22 hat Stefan Hajnoczi geschrieben: > BlockDriver->bdrv_create() has been called from coroutine context since > commit 5b7e1542cfa41a281af9629d31cef03704d976e6 ("block: make > bdrv_create adopt coroutine"). > > Make this explicit by renaming to .bdrv_co_create() and add the > c

Re: [Qemu-devel] [PATCH v3 04/10] pc-bios/s390-ccw: Add a write() function for stdio

2017-07-11 Thread David Hildenbrand
On 10.07.2017 17:32, Thomas Huth wrote: > The stdio functions from the SLOF libc need a write() function for > printing text to stdout/stderr. Let's implement this function by > refactoring the code from sclp_print(). > > Acked-by: Cornelia Huck > Signed-off-by: Thomas Huth > --- > pc-bios/s390

Re: [Qemu-devel] [Qemu-block] [PATCH 11/11] block/snapshot: do not take AioContext lock

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 11:43, Stefan Hajnoczi wrote: >>> >>> 1. Must be called under BQL? >>> 2. Can I/O requests be in flight? >>> 3. Is it thread-safe? >>> >>> Otherwise it will be a nightmare to modify the code since these >>> constraints are not enforced by the compiler and undocumented. >> Good point.

Re: [Qemu-devel] [PATCH 2/2] qcow2: make qcow2_co_create2() a coroutine_fn

2017-07-11 Thread Kevin Wolf
Am 05.07.2017 um 12:22 hat Stefan Hajnoczi geschrieben: > qcow2_create2() calls qemu_co_mutex_lock(). Only a coroutine_fn may > call another coroutine_fn. > > Rename the function (the block layer API is now called > .bdrv_co_create()) and add coroutine_fn. It is always called from > coroutine co

Re: [Qemu-devel] 答复: Re: [PATCH V2] chardev: fix parallel device can't be reconnect

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 11:33, peng.h...@zte.com.cn wrote: >>> +if (qemu_chr_null_be_can_read(chr)) { >>> +size = tcp_chr_recv(chr, (void *)buf, CHR_READ_BUF_LEN) >> >> It would be better not to destroy data in the channel, because the >> device could set handlers later. > > This device do not re

Re: [Qemu-devel] [PATCH] build: disable Xen on ARM

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 09:23, Paolo Bonzini wrote: > While ARM could present the xenpv machine, it does not and trying to enable > it breaks compilation. > > Fixes: 3b6b75506de44c5070639943c30a0ad5850f5d02 > Reported-by: Alex Bennée > Signed-off-by: Paolo Bonzini > --- > configure | 1 - > 1 file c

Re: [Qemu-devel] [PATCH] build: disable Xen on ARM

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 11:53, Peter Maydell wrote: > On 11 July 2017 at 09:23, Paolo Bonzini wrote: >> While ARM could present the xenpv machine, it does not and trying to enable >> it breaks compilation. >> >> Fixes: 3b6b75506de44c5070639943c30a0ad5850f5d02 >> Reported-by: Alex Bennée >> Signed-off-by: P

[Qemu-devel] [PATCH v2] build: disable Xen on ARM

2017-07-11 Thread Paolo Bonzini
While ARM could present the xenpv machine, it does not and trying to enable it breaks compilation. Revert to the previous test which only looked at $target_name, not $cpu. Fixes: 3b6b75506de44c5070639943c30a0ad5850f5d02 Reported-by: Alex Bennée Signed-off-by: Paolo Bonzini --- configure | 6 ++

Re: [Qemu-devel] Modular hardware emulation

2017-07-11 Thread Stefan Hajnoczi
On Wed, Jul 05, 2017 at 05:56:51PM +, Tom Cook wrote: > I'm using qemu to emulate a certain fruit-flavoured single-board computer - > which is fantastic for testing changes configuration, by the way. > > We have a bit of custom hardware attached to that single-board computer - > essentially an

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Edgar E. Iglesias
On Mon, Jul 10, 2017 at 04:11:29PM +0100, Peter Maydell wrote: > On 30 June 2017 at 14:45, Edgar E. Iglesias wrote: > > From: "Edgar E. Iglesias" > > > > Extend PAR format determination to handle more cases. > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target/arm/helper.c | 30 +

Re: [Qemu-devel] [PATCH v2 6/7] scripts/dump-guest-memory.py: add vmcoreinfo

2017-07-11 Thread Marc-André Lureau
Hi - Original Message - > On 07/06/17 12:16, Marc-André Lureau wrote: > > Add vmcoreinfo ELF note if vmcoreinfo device is ready. > > > > To help the python script, add a little global vmcoreinfo_gdb > > structure, that is populated with vmcoreinfo_gdb_update(). > > > > Signed-off-by: Mar

Re: [Qemu-devel] [PATCH v3 4/6] block/nvme: Implement .bdrv_dma_map and .bdrv_dma_unmap

2017-07-11 Thread Stefan Hajnoczi
On Mon, Jul 10, 2017 at 05:09:25PM +0200, Paolo Bonzini wrote: > On 10/07/2017 16:59, Stefan Hajnoczi wrote: > >> +static void nvme_dma_map(BlockDriverState *bs, void *host, size_t size) > >> +{ > >> +BDRVNVMeState *s = bs->opaque; > >> + > >> +nvme_vfio_dma_map(s->vfio, host, size, false,

Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap

2017-07-11 Thread Stefan Hajnoczi
On Mon, Jul 10, 2017 at 05:08:56PM +0200, Paolo Bonzini wrote: > On 10/07/2017 17:07, Stefan Hajnoczi wrote: > > On Wed, Jul 05, 2017 at 09:36:32PM +0800, Fam Zheng wrote: > >> Allow block driver to map and unmap a buffer for later I/O, as a > >> performance > >> hint. > > The name blk_dma_map() i

Re: [Qemu-devel] [Qemu-block] [PATCH 0/2] block: make .bdrv_create() a coroutine_fn

2017-07-11 Thread Stefan Hajnoczi
On Wed, Jul 05, 2017 at 06:26:05AM -0400, Marc-André Lureau wrote: > > > - Original Message - > > The BlockDriver->bdrv_create() function is always called from coroutine > > context. These patches rename it and clean up qcow2 code that is currently > > calling CoMutex functions outside c

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 11:03, Edgar E. Iglesias wrote: > On Mon, Jul 10, 2017 at 04:11:29PM +0100, Peter Maydell wrote: >> So this kind of worries me, because what it's coded as is "determine >> whether architecturally we should be returning a 64-bit or 32-bit >> PAR format", but what the code below i

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-11 Thread Stefan Hajnoczi
On Thu, Jul 06, 2017 at 11:41:56AM +0100, Daniel P. Berrange wrote: > On Thu, Jul 06, 2017 at 11:30:43AM +0100, Stefan Hajnoczi wrote: > > On Wed, Jul 05, 2017 at 12:07:57PM +0100, Daniel P. Berrange wrote: > > > On Wed, Jul 05, 2017 at 10:14:23AM +0200, Thomas Huth wrote: > > > > Hi, > > > > > >

Re: [Qemu-devel] [PATCH 1/3] hw/arm/virt: add pmu interrupt state

2017-07-11 Thread Peter Maydell
On 1 July 2017 at 17:47, Andrew Jones wrote: > Mimicking gicv3-maintenance-interrupt, add the PMU's interrupt to > CPU state. > > Signed-off-by: Andrew Jones Reviewed-by: Peter Maydell thanks -- PMM

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Edgar E. Iglesias
On Tue, Jul 11, 2017 at 11:14:04AM +0100, Peter Maydell wrote: > On 11 July 2017 at 11:03, Edgar E. Iglesias wrote: > > On Mon, Jul 10, 2017 at 04:11:29PM +0100, Peter Maydell wrote: > >> So this kind of worries me, because what it's coded as is "determine > >> whether architecturally we should be

Re: [Qemu-devel] [Qemu-block] [PATCH v3 3/6] block: Introduce bdrv_dma_map and bdrv_dma_unmap

2017-07-11 Thread Paolo Bonzini
On 11/07/2017 12:05, Stefan Hajnoczi wrote: > On Mon, Jul 10, 2017 at 05:08:56PM +0200, Paolo Bonzini wrote: >> On 10/07/2017 17:07, Stefan Hajnoczi wrote: >>> On Wed, Jul 05, 2017 at 09:36:32PM +0800, Fam Zheng wrote: Allow block driver to map and unmap a buffer for later I/O, as a perf

[Qemu-devel] [PATCH v3 0/7] KASLR kernel dump support

2017-07-11 Thread Marc-André Lureau
Recent linux kernels enable KASLR to randomize phys/virt memory addresses. This series aims to provide enough information in qemu dumps so that crash utility can work with randomized kernel too (it hasn't been tested on other archs than x86 though, help welcome). The vmcoreinfo device is an emulat

[Qemu-devel] [PATCH v3 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-11 Thread Marc-André Lureau
This compat property sole function is to prevent the device from being instantiated. Instead of requiring an extra compat property, check if fw_cfg has DMA enabled. fw_cfg is a built-in device that is initialized very early by the machine init code. We have at least one other device that also ass

[Qemu-devel] [PATCH v3 2/7] acpi: add vmcoreinfo device

2017-07-11 Thread Marc-André Lureau
The VM coreinfo (vmcoreinfo) device is an emulated device which exposes a 4k memory range to the guest to store various informations useful to debug the guest OS. (it is greatly inspired by the VMGENID device implementation) This is an early-boot alternative to the qemu-ga VMDUMP_INFO event propos

[Qemu-devel] [PATCH v3 3/7] tests: add simple vmcoreinfo test

2017-07-11 Thread Marc-André Lureau
This test is based off vmgenid test from Ben Warren . It simply checks the vmcoreinfo ACPI device is present and that the memory region associated can be read. Signed-off-by: Marc-André Lureau --- tests/vmcoreinfo-test.c | 127 tests/Makefile.incl

[Qemu-devel] [PATCH v3 5/7] kdump: add vmcoreinfo ELF note

2017-07-11 Thread Marc-André Lureau
kdump header provides offset and size of the vmcoreinfo ELF note, append it if available. crash-7.1.9 was the first version that started looking in the vmcoreinfo data for phys_base instead of in the kdump_sub_header. Signed-off-by: Marc-André Lureau Reviewed-by: Laszlo Ersek --- dump.c | 20 +

[Qemu-devel] [PATCH v3 4/7] dump: add vmcoreinfo ELF note

2017-07-11 Thread Marc-André Lureau
Read the vmcoreinfo ELF PT_NOTE from guest memory when vmcoreinfo device provides the location, and write it as an ELF note in the dump. There are now 2 possible sources of phys_base information. (1) arch guessed value from cpu_get_dump_info() (2) vmcoreinfo ELF note NUMBER(phys_base)= field

[Qemu-devel] [PULL 2/4] aspeed: Register all watchdogs

2017-07-11 Thread Peter Maydell
From: Joel Stanley The ast2400 contains two and the ast2500 contains three watchdogs. Add this information to the AspeedSoCInfo and realise the correct number of watchdogs for that each SoC type. Signed-off-by: Joel Stanley Reviewed-by: Cédric Le Goater Tested-by: Cédric Le Goater Signed-off-

[Qemu-devel] [PULL 4/4] target-arm: v7M: ignore writes to CONTROL.SPSEL from Thread mode

2017-07-11 Thread Peter Maydell
For v7M, writes to the CONTROL register are only permitted for privileged code. However even if the code is privileged, the write must not affect the SPSEL bit in the CONTROL register if the CPU is in Thread mode (as documented in the pseudocode for the MSR instruction). Implement this, instead of

[Qemu-devel] [PULL 0/4] target-arm queue

2017-07-11 Thread Peter Maydell
to staging (2017-07-10 18:13:03 +0100) are available in the git repository at: git://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20170711 for you to fetch changes up to 792dac309c8660306557ba058b8b5a6a75ab3c1f: target-arm: v7M: ignore writes to CONTROL.SPSEL from Thread

[Qemu-devel] [PATCH v3 6/7] scripts/dump-guest-memory.py: add vmcoreinfo

2017-07-11 Thread Marc-André Lureau
Add vmcoreinfo ELF note if vmcoreinfo device is ready. To help the python script, add a little global vmcoreinfo_gdb structure, that is populated with vmcoreinfo_gdb_update(). Signed-off-by: Marc-André Lureau --- scripts/dump-guest-memory.py | 46 hw

[Qemu-devel] [PULL 1/4] hw/misc: Add Exynos4210 Pseudo Random Number Generator

2017-07-11 Thread Peter Maydell
From: Krzysztof Kozlowski Add emulation for Exynos4210 Pseudo Random Number Generator which could work on fixed seeds or with seeds provided by True Random Number Generator block inside the SoC. Implement only the fixed seeds part of it in polling mode (no interrupts). Emulation tested with two

[Qemu-devel] [PATCH v3 7/7] MAINTAINERS: add Dump maintainers

2017-07-11 Thread Marc-André Lureau
Proposing myself, since I have some familiarity with the code now. Signed-off-by: Marc-André Lureau Acked-by: Laszlo Ersek --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9529c9484c..9cff1bee46 100644 --- a/MAINTAINERS +++ b/MAINTAINE

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Edgar E. Iglesias
On Tue, Jul 11, 2017 at 11:14:04AM +0100, Peter Maydell wrote: > On 11 July 2017 at 11:03, Edgar E. Iglesias wrote: > > On Mon, Jul 10, 2017 at 04:11:29PM +0100, Peter Maydell wrote: > >> So this kind of worries me, because what it's coded as is "determine > >> whether architecturally we should be

[Qemu-devel] [PULL 3/4] ARM: KVM: Enable in-kernel timers with user space gic

2017-07-11 Thread Peter Maydell
From: Alexander Graf When running with KVM enabled, you can choose between emulating the gic in kernel or user space. If the kernel supports in-kernel virtualization of the interrupt controller, it will default to that. If not, if will default to user space emulation. Unfortunately when running

Re: [Qemu-devel] [PATCH v11 0/6] trace: [tcg] Optimize per-vCPU tracing states with separate TB caches

2017-07-11 Thread Stefan Hajnoczi
On Tue, Jul 04, 2017 at 10:30:13AM +0200, Lluís Vilanova wrote: > Optimizes tracing of events with the 'tcg' and 'vcpu' properties (e.g., memory > accesses), making it feasible to statically enable them by default on all QEMU > builds. Last patch shows that overheads are completely eliminated in va

Re: [Qemu-devel] [PATCH v1 2/2] target-arm: Extend PAR format determination

2017-07-11 Thread Peter Maydell
On 11 July 2017 at 11:38, Edgar E. Iglesias wrote: > Another way could also be to have get_phys_addr() fill in generic > fields in the FaultInfo struct and then have a faultinfo_to_fsr > mapping function to populate FSR/PAR. Do you see any issues with that? Yes, that's probably better. It's how t

Re: [Qemu-devel] [PATCH v9 0/7] trace: Optimize per-vCPU TCG tracing states

2017-07-11 Thread Stefan Hajnoczi
On Mon, Jul 10, 2017 at 01:07:44PM +0100, Stefan Hajnoczi wrote: > On Mon, Jun 26, 2017 at 06:04:34PM -0400, Emilio G. Cota wrote: > > v8: https://lists.gnu.org/archive/html/qemu-devel/2017-06/msg02335.html > > > > Changes from v8: > > > > - Rebased on top of the current tracing tree -- the one t

[Qemu-devel] [PATCH 3/7] hw/arm/mps2: Add UARTs

2017-07-11 Thread Peter Maydell
Add the UARTs to the MPS2 board models. Unfortunately the details of the wiring of the interrupts through various OR gates differ between AN511 and AN385 so this can't be purely a data-driven difference. Signed-off-by: Peter Maydell --- hw/arm/mps2.c | 86 +++

[Qemu-devel] [PATCH 2/7] hw/char/cmsdk-apb-uart.c: Implement CMSDK APB UART

2017-07-11 Thread Peter Maydell
Implement a model of the simple "APB UART" provided in the Cortex-M System Design Kit (CMSDK). Signed-off-by: Peter Maydell --- hw/char/Makefile.objs| 1 + include/hw/char/cmsdk-apb-uart.h | 78 hw/char/cmsdk-apb-uart.c | 390 ++

[Qemu-devel] [PATCH 0/7] ARM: implement MPS2 board (with 2 FPGA flavours)

2017-07-11 Thread Peter Maydell
This patchseries adds support for the ARM MPS2/MPS2+ dev board: The MPS2 and MPS2+ dev boards are FPGA based (the 2+ has a bigger FPGA but is otherwise the same as the 2). Since the CPU itself and most of the devices are in the FPGA, the details of the board as seen by the guest depend significant

[Qemu-devel] [PATCH 5/7] hw/arm/mps2: Add timers

2017-07-11 Thread Peter Maydell
Add the CMSDK APB timers to the MPS2 board. Signed-off-by: Peter Maydell --- hw/arm/mps2.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c index 1b60b12..b1a0df9 100644 --- a/hw/arm/mps2.c +++ b/hw/arm/mps2.c @@ -33,6 +33,7 @@ #include "sysemu/sysemu.h" #i

[Qemu-devel] [PATCH 7/7] hw/arm/mps2: Add SCC

2017-07-11 Thread Peter Maydell
Add the SCC to the MPS2 board models. Signed-off-by: Peter Maydell --- hw/arm/mps2.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c index b1a0df9..3dd61fe 100644 --- a/hw/arm/mps2.c +++ b/hw/arm/mps2.c @@ -34,6 +34,7 @@ #inclu

[Qemu-devel] [PATCH 6/7] hw/misc/mps2_scc: Implement MPS2 Serial Communication Controller

2017-07-11 Thread Peter Maydell
Implement a model of the Serial Communication Controller (SCC) found in MPS2 FPGA images. The primary purpose of this device is to communicate with the Motherboard Configuration Controller (MCC) which is located on the MPS board itself, outside the FPGA image. This is used for programming the MPS

[Qemu-devel] [PATCH 1/7] hw/arm/mps2: Implement skeleton mps2-an385 and mps2-an511 board models

2017-07-11 Thread Peter Maydell
Model the ARM MPS2/MPS2+ FPGA based development board. The MPS2 and MPS2+ dev boards are FPGA based (the 2+ has a bigger FPGA but is otherwise the same as the 2). Since the CPU itself and most of the devices are in the FPGA, the details of the board as seen by the guest depend significantly on the

[Qemu-devel] [PATCH 4/7] hw/char/cmsdk-apb-timer: Implement CMSDK APB timer device

2017-07-11 Thread Peter Maydell
Implement a model of the simple timer device found in the CMSDK. Signed-off-by: Peter Maydell --- hw/timer/Makefile.objs | 1 + include/hw/timer/cmsdk-apb-timer.h | 59 + hw/timer/cmsdk-apb-timer.c | 253 + default-configs/arm-so

  1   2   3   4   5   6   >