Re: [Qemu-devel] [PATCH] vnc: Set default kbd delay to 10ms

2017-07-06 Thread Alexander Graf
On 05.07.17 10:42, Markus Armbruster wrote: Alexander Graf writes: The default keyboard delay time in the input layer is 10ms. I don't know Do you mean "is 1ms"? Yes, of course :). Sorry. Alex how that number came to be, but empirical tests on some OpenQA driven ARM systems show th

Re: [Qemu-devel] [PATCH v8 2/4] net/socket: Convert several helper functions to Error

2017-07-06 Thread Markus Armbruster
Mao Zhongyi writes: > Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and > net_socket_fd_init() use the function such as fprintf(), perror() to > report an error message. > > Now, convert these functions to Error. > > Cc: jasow...@redhat.com > Cc: arm...@redhat.com > Cc: berra..

[Qemu-devel] [PULL 4/8] s390x: fix realize inheritance for kvm-flic

2017-07-06 Thread Christian Borntraeger
From: Halil Pasic Commit f6f4ce4211 ("s390x: add property adapter_routes_max_batch", 2016-12-09) introduces a common realize (intended to be common for all the subclasses) for flic, but fails to make sure the kvm-flic which had its own is actually calling this common realize. This omission fortu

[Qemu-devel] [PULL 8/8] hw/s390x/ipl: Fix endianness problem with netboot_start_addr

2017-07-06 Thread Christian Borntraeger
From: Thomas Huth The start address has to be stored in big endian byte order in the iplb.ccw block for the guest. Signed-off-by: Thomas Huth Message-Id: <1499268345-12552-1-git-send-email-th...@redhat.com> Reviewed-by: Cornelia Huck Signed-off-by: Christian Borntraeger --- hw/s390x/ipl.c |

[Qemu-devel] [PULL 5/8] s390x/MAINTAINERS: Update my email address

2017-07-06 Thread Christian Borntraeger
From: Cornelia Huck Signed-off-by: Cornelia Huck Message-Id: <20170704092215.13742-2-coh...@redhat.com> Signed-off-by: Christian Borntraeger --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 839f7ca..4e17216 100644 --- a

[Qemu-devel] [PULL 3/8] s390x: fix error propagation in kvm-flic's realize

2017-07-06 Thread Christian Borntraeger
From: Halil Pasic >From the moment it was introduced by commit a2875e6f98 ("s390x/kvm: implement floating-interrupt controller device", 2013-07-16) the kvm-flic is not making realize fail properly in case it's impossible to create the KVM device which basically serves as a backend and is absolute

[Qemu-devel] [PULL 1/8] s390x: vmstatify config migration for virtio-ccw

2017-07-06 Thread Christian Borntraeger
From: Halil Pasic Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for flexibility (extending using subsections) and for fun. To achieve this we need to hack the config_vector, which is VirtIODevice (that is common virtio) state, in the middle of the VirtioCcwDevice state repres

[Qemu-devel] [PULL 6/8] s390x: return unavailable features via query-cpu-definitions

2017-07-06 Thread Christian Borntraeger
From: Viktor Mihajlovski The response for query-cpu-definitions didn't include the unavailable-features field, which is used by libvirt to figure out whether a certain cpu model is usable on the host. The unavailable features are now computed by obtaining the host CPU model and comparing it agai

Re: [Qemu-devel] [PATCH v8 4/4] net/socket: Improve -net socket error reporting

2017-07-06 Thread Markus Armbruster
Mao Zhongyi writes: > When -net socket fails, it first reports a specific error, then > a generic one, like this: > > $ qemu-system-x86_64 -net socket, > qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, > mcast= or udp= is required > qemu-system-x86_64: -net so

[Qemu-devel] [PULL 2/8] s390x/3270: fix instruction interception handler

2017-07-06 Thread Christian Borntraeger
From: Dong Jia Shi Commit bab482d7405f ("s390x/css: ccw translation infrastructure") introduced instruction interception handler for different types of subchannels. For emulated 3270 devices, we should assign the virtual subchannel handler to them during device realization process, or 3270 will n

[Qemu-devel] [PULL 7/8] virtio-scsi-ccw: use ioeventfd even when KVM is disabled

2017-07-06 Thread Christian Borntraeger
From: QingFeng Hao This patch is based on a similar patch from Stefan Hajnoczi - commit c324fd0a39c ("virtio-pci: use ioeventfd even when KVM is disabled") Do not check kvm_eventfds_enabled() when KVM is disabled since it always returns 0. Since commit 8c56c1a592b5092d91da8d8943c1d6462a6f (

[Qemu-devel] [Bug 1702621] [NEW] colo: secondary vm crash during loadvm

2017-07-06 Thread pork-prince
Public bug reported: Following document 'COLO-FT.txt', I test colo feature on my hosts. It seems goes well. But after a while the secondary vm crash. The stack is as follows: #0 0x7f191456dc37 in raise () from /lib/x86_64-linux-gnu/libc.so.6 #1 0x7f1914571028 in abort () from /lib/x86_

[Qemu-devel] [PULL 0/8] s390x/kvm/migration: fixes, enhancements and cleanups

2017-07-06 Thread Christian Borntraeger
u.git tags/s390x-20170706 for you to fetch changes up to 1045e3cdafaf1218d9f771080ba5c9d4f64346e4: hw/s390x/ipl: Fix endianness problem with netboot_start_addr (2017-07-05 19:46:30 +0200) s390x/kvm/migration: fixes, enhanc

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-07-06 Thread Fam Zheng
On Thu, 07/06 00:16, no-re...@patchew.org wrote: > /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c: In > function ‘virtio_crypto_instance_init’: > /var/tmp/patchew-tester-tmp-s55a7o8g/src/hw/virtio/virtio-crypto.c:918:30: > error: passing argument 5 of ‘object_property_add_link

Re: [Qemu-devel] [PATCH] ppc/kvm: have the "family" CPU alias to point to TYPE_HOST_POWERPC_CPU

2017-07-06 Thread David Gibson
On Wed, Jul 05, 2017 at 10:49:52AM +0200, Greg Kurz wrote: > When running KVM on POWER, we allow the user to pass "-cpu POWERx" instead > of "-cpu host". This is achieved by patching the ppc_cpu_aliases[] array > so that "POWERx" points to the CPU class with the same PVR as the host CPU. > This cau

Re: [Qemu-devel] [PATCH] ppc/kvm: have the "family" CPU alias to point to TYPE_HOST_POWERPC_CPU

2017-07-06 Thread Greg Kurz
On Thu, 6 Jul 2017 17:32:33 +1000 David Gibson wrote: > On Wed, Jul 05, 2017 at 10:49:52AM +0200, Greg Kurz wrote: > > When running KVM on POWER, we allow the user to pass "-cpu POWERx" instead > > of "-cpu host". This is achieved by patching the ppc_cpu_aliases[] array > > so that "POWERx" point

[Qemu-devel] [Bug 1702621] Re: colo: secondary vm crash during loadvm

2017-07-06 Thread pork-prince
The qemu version is 2.9.0 release. The 'irq_count' and 'irq_state' are sent by private vm, and loaded by secondary vm. When they sent by private vm, they maybe not in a consistent state. So sometimes 'bus->irq_count[i]' becomes '-1' on secondary vm. I deleted the assertions and then tested it se

Re: [Qemu-devel] [PATCH] hmp: Update info vnc

2017-07-06 Thread Daniel P. Berrange
On Wed, Jul 05, 2017 at 05:33:24PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Jul 05, 2017 at 03:43:02PM +0100, Dr. David Alan Gilbert (git) > > wrote: > > > From: "Dr. David Alan Gilbert" > > > > > > The QMP query-vnc interfaces have gai

Re: [Qemu-devel] [PATCH 12/17] migration: add postcopy migration of dirty bitmaps

2017-07-06 Thread Vladimir Sementsov-Ogievskiy
06.07.2017 00:46, John Snow wrote: On 07/05/2017 05:24 AM, Vladimir Sementsov-Ogievskiy wrote: 16.02.2017 16:04, Fam Zheng wrote: +dbms->node_name = bdrv_get_node_name(bs); +if (!dbms->node_name || dbms->node_name[0] == '\0') { +dbms->node_name = bdrv_ge

Re: [Qemu-devel] [PATCH v8 4/4] net/socket: Improve -net socket error reporting

2017-07-06 Thread Mao Zhongyi
Hi, Markus On 07/06/2017 03:24 PM, Markus Armbruster wrote: Mao Zhongyi writes: When -net socket fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net socket, qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, mcast=

Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 08:15:54AM +0200, Markus Armbruster wrote: > Alistair Francis writes: > > > This patch converts the existing error_vreport() function into a generic > > qmesg_vreport() function that takes an enum describing the > > information to be reported. > > > > As part of this chang

Re: [Qemu-devel] [PATCH v2.1 3/4] doc: add item for "-M enforce-config-section"

2017-07-06 Thread Greg Kurz
On Thu, 6 Jul 2017 10:08:41 +0800 Peter Xu wrote: > It's never documented, and now we have one more parameter for it (which > obsoletes this one). Document it properly. > > Although now when enforce-config-section is set, it'll override the > other "-global" parameter, that is not necessarily a

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread John Paul Adrian Glaubitz
Hi! Wow, great to see that there is actually now support for handling gUSA in qemu-user on sh4. I wonder whether this will help resolve the lock-up issues on qemu-sh4-user when building Debian packages for sh4. The lockups occur fairly often when any process uses multi-threading. Would this help

Re: [Qemu-devel] The maximum limit of virtual network device

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 06:20:54AM +, Wu, Jiaxin wrote: > Hello experts, > > We know QEMU has the capability to create the multiple network devices in one > QEMU guest with the -device syntax. But I met the below failure when I'm > trying to create more than 30 virtual devices with the each

Re: [Qemu-devel] [PATCH v2 1/2] scripts: use build_ prefix for string not piped through cgen()

2017-07-06 Thread Markus Armbruster
Marc-André Lureau writes: > Suggested by Markus Armbruster: Replacing the line above with ... > The gen_ prefix is awkward. Generated C should go through cgen() > exactly once (see commit 1f9a7a1). The common way to get this wrong is > passing a foo=gen_foo() keyword argument to mcgen(). I'd

Re: [Qemu-devel] [PATCH v1 0/3] Windows runtime improvements

2017-07-06 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v1 0/3] Windows runtime improvements Type: series Message-id: cover.1498756113.git.alistair.fran...@xilinx.com === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total

Re: [Qemu-devel] The maximum limit of virtual network device

2017-07-06 Thread Laszlo Ersek
Hi Jiaxin, it's nice to see a question from you on qemu-devel! :) On 07/06/17 08:20, Wu, Jiaxin wrote: > Hello experts, > > We know QEMU has the capability to create the multiple network devices > in one QEMU guest with the -device syntax. But I met the below failure > when I'm trying to create m

Re: [Qemu-devel] [PATCH] backends: remove empty trace-events file

2017-07-06 Thread Stefan Hajnoczi
On Thu, Jun 29, 2017 at 05:20:46PM +0100, Daniel P. Berrange wrote: > The content of the backends/trace-events file was entirely > removed in > > commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6 > Author: Marc-André Lureau > Date: Mon May 29 12:39:42 2017 +0400 > > char: move char dev

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread Laurent Vivier
Le 06/07/2017 à 10:10, John Paul Adrian Glaubitz a écrit : > Hi! > > Wow, great to see that there is actually now support for handling gUSA > in qemu-user on sh4. I wonder whether this will help resolve the > lock-up issues on qemu-sh4-user when building Debian packages for > sh4. > > The lockups

Re: [Qemu-devel] qemu_system_reset_request() broken w.r.t BQL locking regime

2017-07-06 Thread Alex Bennée
Paolo Bonzini writes: > On 05/07/2017 18:14, Peter Maydell wrote: >>> - Guest resets board, writing to some hw address (e.g. >>> arm_sysctl_write) >>> - This triggers qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET) >>> - We exit iowrite and drop the BQL >>> - vl.c schedules qem

Re: [Qemu-devel] [PATCH v2.1 3/4] doc: add item for "-M enforce-config-section"

2017-07-06 Thread Peter Xu
On Thu, Jul 06, 2017 at 10:09:19AM +0200, Greg Kurz wrote: > On Thu, 6 Jul 2017 10:08:41 +0800 > Peter Xu wrote: > > > It's never documented, and now we have one more parameter for it (which > > obsoletes this one). Document it properly. > > > > Although now when enforce-config-section is set,

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default

2017-07-06 Thread Stefan Hajnoczi
On Mon, Jul 03, 2017 at 01:40:57PM -0500, Eric Blake wrote: > On 07/03/2017 10:56 AM, Eric Blake wrote: > > On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote: > >> The following functions fail if bs->drv does not implement them: > > One other suggestion: most patches in the tree use 'topic: Capita

Re: [Qemu-devel] [PATCH v2 2/2] qapi: add location comment for generated types

2017-07-06 Thread Markus Armbruster
Marc-André Lureau writes: > This may help to find where the origin of the type was declared in the > json (when greping isn't easy enough). > > Generates the following kind of C comment before types: > > /* /home/elmarco/src/qemu/qapi/introspect.json:94 */ > typedef struct SchemaInfo SchemaIn

Re: [Qemu-devel] [PATCH v2 6/6] nbd: use generic trace subsystem instead of TRACE macro

2017-07-06 Thread Vladimir Sementsov-Ogievskiy
05.07.2017 18:29, Paolo Bonzini wrote: On 21/06/2017 17:34, Vladimir Sementsov-Ogievskiy wrote: Starting from this patch to enable traces use -trace option of qemu or -T, --trace option of qemu-img, qemu-io and qemu-nbd. For qemu traces also can be managed by qmp commands trace-event-{get,set}-

Re: [Qemu-devel] [PATCH 1/3] include/hw/boards.h: Document memory_region_allocate_system_memory()

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 05:18, Philippe Mathieu-Daudé wrote: > Hi Peter, Paolo, > > On 07/04/2017 02:02 PM, Peter Maydell wrote: >> Add a documentation comment for memory_region_allocate_system_memory(). >> >> In particular, the reason for this function's existence and the >> requirement on board code to

[Qemu-devel] [PATCH v8 0/4] Improve error reporting

2017-07-06 Thread Mao Zhongyi
v8: * PATCH 02 & 04 -resetting the error message for the user to read. [Markus Armbruster] -fix the indentation and commit message. [Markus Armbruster] v7: * PATCH 01 -fix the error message.[Daniel P. Berrange] -adjust the indentation problem.[Eric Blake] * PATCH 03 -print a

[Qemu-devel] [PATCH v8 3/4] net/net: Convert parse_host_port() to Error

2017-07-06 Thread Mao Zhongyi
Cc: berra...@redhat.com Cc: kra...@redhat.com Cc: pbonz...@redhat.com Cc: jasow...@redhat.com Cc: arm...@redhat.com Cc: ebl...@redhat.com Signed-off-by: Mao Zhongyi Reviewed-by: Markus Armbruster --- include/qemu/sockets.h | 3 ++- net/net.c | 22 +- net/socket.

[Qemu-devel] [PATCH v8 1/4] net/socket: Don't treat odd socket type as SOCK_STREAM

2017-07-06 Thread Mao Zhongyi
In net_socket_fd_init(), the 'default' case is odd: it warns, then continues as if the socket type was SOCK_STREAM. The comment explains "this could be a eg. a pty", but that makes no sense. If @fd really was a pty, getsockopt() would fail with ENOTSOCK. If @fd was a socket, but neither SOCK_DGRAM

[Qemu-devel] [PATCH v8 2/4] net/socket: Convert several helper functions to Error

2017-07-06 Thread Mao Zhongyi
Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init() use the function such as fprintf(), perror() to report an error message. Now, convert these functions to Error. Cc: jasow...@redhat.com Cc: arm...@redhat.com Cc: berra...@redhat.com Signed-off-by: Mao Zhongy

[Qemu-devel] [PATCH v8 4/4] net/socket: Improve -net socket error reporting

2017-07-06 Thread Mao Zhongyi
When -net socket fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net socket, qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, mcast= or udp= is required qemu-system-x86_64: -net socket: Device 'socket' could not be

Re: [Qemu-devel] Managing architectural restrictions with -device and libvirt

2017-07-06 Thread Marcel Apfelbaum
On 05/07/2017 21:05, Markus Armbruster wrote: Mark Cave-Ayland writes: On 05/07/17 16:46, Markus Armbruster wrote: I've been working on a patchset that brings the sun4u machine on qemu-system-sparc64 much closer to a real Ultra 5, however due to various design restrictions I need to be able

Re: [Qemu-devel] [PATCH v2 6/6] nbd: use generic trace subsystem instead of TRACE macro

2017-07-06 Thread Paolo Bonzini
On 06/07/2017 10:45, Vladimir Sementsov-Ogievskiy wrote: >>> +do_nbd_trip_read(uint32_t len) "Read %" PRIu32" byte(s)" >> This one is good. > > why do you like this and do not like nbd_trip_write_zeros? I'm not sure I understand: this one is after blk_pread returns. It tells you that the socke

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread John Paul Adrian Glaubitz
On Thu, Jul 06, 2017 at 10:35:15AM +0200, Laurent Vivier wrote: > This is a patch series proposed by Richard, it is not included in qemu > at the moment: > > http://lists.nongnu.org/archive/html/qemu-devel/2017-07/msg01196.html Aye, awesome! > I think it would be interesting if you generate a qe

Re: [Qemu-devel] [Qemu-block] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default

2017-07-06 Thread Stefan Hajnoczi
On Thu, Jun 29, 2017 at 09:43:18PM +0300, Manos Pitsidianakis wrote: > diff --git a/block.c b/block.c > index 69439628..9e8d34ad 100644 > --- a/block.c > +++ b/block.c > @@ -494,6 +494,8 @@ int bdrv_probe_blocksizes(BlockDriverState *bs, > BlockSizes *bsz) > > if (drv && drv->bdrv_probe_blo

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread John Paul Adrian Glaubitz
On Thu, Jul 06, 2017 at 10:35:15AM +0200, Laurent Vivier wrote: > I think it would be interesting if you generate a qemu binary with it > and use it in your buildds to test it. > > I guess the series can be pulled directly from Richard's branch: > > git://github.com/rth7680/qemu.git tgt-sh4 Pull

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread Laurent Vivier
Le 06/07/2017 à 11:13, John Paul Adrian Glaubitz a écrit : > On Thu, Jul 06, 2017 at 10:35:15AM +0200, Laurent Vivier wrote: >> I think it would be interesting if you generate a qemu binary with it >> and use it in your buildds to test it. >> >> I guess the series can be pulled directly from Richar

Re: [Qemu-devel] The maximum limit of virtual network device

2017-07-06 Thread Marcel Apfelbaum
On 06/07/2017 11:31, Laszlo Ersek wrote: Hi Jiaxin, it's nice to see a question from you on qemu-devel! :) On 07/06/17 08:20, Wu, Jiaxin wrote: Hello experts, We know QEMU has the capability to create the multiple network devices in one QEMU guest with the -device syntax. But I met the below

Re: [Qemu-devel] [PATCH] hmp: Update info vnc

2017-07-06 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@redhat.com) wrote: > > > - Original Message - > > From: "Dr. David Alan Gilbert" > > > > The QMP query-vnc interfaces have gained a lot more information that > > the HMP interfaces hasn't got yet. Update it. > > > > Note the output format has chang

Re: [Qemu-devel] [PATCH v2 2/3] block: use defaults of bdrv_* callbacks in raw

2017-07-06 Thread Stefan Hajnoczi
On Thu, Jun 29, 2017 at 09:43:19PM +0300, Manos Pitsidianakis wrote: > Now that passing the call to bs->file is the default for some bdrv_* > callbacks, remove the duplicate implementations in block/raw-format.c > > Signed-off-by: Manos Pitsidianakis > --- > block/raw-format.c | 32 +

Re: [Qemu-devel] DIRTY_MEMORY_BLOCK_SIZE;

2017-07-06 Thread Stefan Hajnoczi
On Wed, Jul 05, 2017 at 05:06:41PM +0100, Dr. David Alan Gilbert wrote: > * Stefan Hajnoczi (stefa...@redhat.com) wrote: > > On Fri, Jun 30, 2017 at 12:26:10PM +0100, Dr. David Alan Gilbert wrote: > > > * ali saeedi (ali.saeed...@gmail.com) wrote: > > > > Hello > > > > what does 'DIRTY_MEMORY_BLOCK

Re: [Qemu-devel] The maximum limit of virtual network device

2017-07-06 Thread Laszlo Ersek
On 07/06/17 11:24, Marcel Apfelbaum wrote: > On 06/07/2017 11:31, Laszlo Ersek wrote: >> > Now, I would normally recommend sticking with i440fx for simplicity. >> However, each PCI bridge requires 4KB of IO space (meaning (1 + 5) * 4KB >> = 24KB), and OVMF on the i440fx does not support that much

Re: [Qemu-devel] Page Block word

2017-07-06 Thread Stefan Hajnoczi
On Fri, Jun 30, 2017 at 04:31:30PM +0430, ali saeedi wrote: > what is the difference between word, page and block in qemu? The meaning of these terms depends on the context. It's not possible to answer since you didn't give any context. It's like asking, "What is the meaning of 'element' in QEMU

Re: [Qemu-devel] [Qemu-ppc] [PATCH 0/5] spapr: DRC cleanups (part VI)

2017-07-06 Thread David Gibson
On Wed, Jul 05, 2017 at 05:41:40PM -0500, Michael Roth wrote: > Quoting Daniel Henrique Barboza (2017-07-05 16:53:57) > > > > > > On 07/05/2017 08:04 AM, David Gibson wrote: > > > On Tue, Jul 04, 2017 at 06:13:31PM -0300, Daniel Henrique Barboza wrote: > > >> I just tested this patch set on top o

Re: [Qemu-devel] [PATCH v2 3/4] xen/mapcache: introduce xen_replace_cache_entry()

2017-07-06 Thread Paul Durrant
> -Original Message- > > > > > > > > The problem really comes down to defining > xenforeignmemory_map2() in > > > terms of xenforeignmemory_map(). It basically can't be safely done. > Could > > > you define xenforeignmemory_map2() as abort() in the compat case > > > instead? > > > > > > > >

Re: [Qemu-devel] [PATCH] hmp: Update info vnc

2017-07-06 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Jul 05, 2017 at 05:33:24PM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Wed, Jul 05, 2017 at 03:43:02PM +0100, Dr. David Alan Gilbert (git) > > > wrote: > > > > From: "Dr. David Alan

[Qemu-devel] [PATCH v2] hmp: Update info vnc

2017-07-06 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" The QMP query-vnc interfaces have gained a lot more information that the HMP interfaces hasn't got yet. Update it. Note the output format has changed, but this is HMP so that's OK. In particular, this now includes client information for reverse connections: -vnc

Re: [Qemu-devel] [PATCH 7/7] MAINTAINERS: add Dump maintainers

2017-07-06 Thread Marc-André Lureau
Hi - Original Message - > On 06/29/17 15:23, Marc-André Lureau wrote: > > Proposing myself, since I have some familiarity with the code now. > > > > Signed-off-by: Marc-André Lureau > > --- > > MAINTAINERS | 7 +++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/MAINTAINER

Re: [Qemu-devel] [Qemu-block] [PATCH 2/2] block: remove timer canceling in throttle_config()

2017-07-06 Thread Stefan Hajnoczi
On Sun, Jul 02, 2017 at 01:06:46PM +0300, Manos Pitsidianakis wrote: > throttle_config() cancels the timers of the calling BlockBackend. This > doesn't make sense because other BlockBackends in the group remain > untouched. There's no need to cancel the timers in the one specific > BlockBackend so

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: add clock_type field to ThrottleGroup

2017-07-06 Thread Stefan Hajnoczi
On Sun, Jul 02, 2017 at 01:06:45PM +0300, Manos Pitsidianakis wrote: > Clock type in throttling is currently inferred by the ThrottleTimer's > clock type even though it is a per-ThrottleGroup property; it doesn't > make sense to have different clock types in the same group. Moving this > to a field

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Jean-Philippe Brucker
On 05/07/17 09:49, Bharat Bhushan wrote:>>> Also when setup msi-route kvm_irqchip_add_msi_route() we needed to >> provide the translated address. >>> According to my understanding this is required because kernel does no go >> through viommu translation when generating interrupt, no? >> >> yes this

Re: [Qemu-devel] [PATCH 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Marc-André Lureau
Hi On Wed, Jul 5, 2017 at 2:07 AM, Laszlo Ersek wrote: > On 06/29/17 15:23, Marc-André Lureau wrote: >> kdump header provides offset and size of the vmcoreinfo ELF note, >> append it if available. >> >> Signed-off-by: Marc-André Lureau >> --- >> dump.c | 48 +

Re: [Qemu-devel] [PATCH] qemu-thread: Assert locks are initialized before using

2017-07-06 Thread Stefan Hajnoczi
On Tue, Jul 04, 2017 at 08:23:25PM +0800, Fam Zheng wrote: > Not all platforms check whether a lock is initialized before used. In > particular Linux seems to be more permissive than OSX. > > Check initialization state explicitly in our code to catch such bugs > earlier. > > Signed-off-by: Fam Z

Re: [Qemu-devel] [PATCH v2] hmp: Update info vnc

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 10:55:45AM +0100, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > The QMP query-vnc interfaces have gained a lot more information that > the HMP interfaces hasn't got yet. Update it. > > Note the output format has changed, but this is HMP so that'

[Qemu-devel] [PATCH v2 0/7] KASLR kernel dump support

2017-07-06 Thread Marc-André Lureau
Recent linux kernels enable KASLR to randomize phys/virt memory addresses. This series aims to provide enough information in qemu dumps so that crash utility can work with randomized kernel too (it hasn't been tested on other archs than x86 though, help welcome). The vmcoreinfo device is an emulat

[Qemu-devel] [PATCH v2 1/7] vmgenid: replace x-write-pointer-available hack

2017-07-06 Thread Marc-André Lureau
This compat property sole function is to prevent the device from being instantiated. Instead of requiring an extra compat property, check if fw_cfg has DMA enabled. fw_cfg is a built-in device that is initialized very early by the machine init code. We have at least one other device that also ass

[Qemu-devel] [PATCH v2 7/7] MAINTAINERS: add Dump maintainers

2017-07-06 Thread Marc-André Lureau
Proposing myself, since I have some familiarity with the code now. Signed-off-by: Marc-André Lureau --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 839f7ca063..ba17ce5b85 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1272,6 +1272,15 @

[Qemu-devel] [PATCH v2 4/7] dump: add vmcoreinfo ELF note

2017-07-06 Thread Marc-André Lureau
Read the vmcoreinfo ELF PT_NOTE from guest memory when vmcoreinfo device provides the location, and write it as an ELF note in the dump. There are now 2 possible sources of phys_base information. (1) arch guessed value from cpu_dump_info_get() (2) vmcoreinfo ELF note NUMBER(phys_base)= field

[Qemu-devel] [PATCH v2 5/7] kdump: add vmcoreinfo ELF note

2017-07-06 Thread Marc-André Lureau
kdump header provides offset and size of the vmcoreinfo ELF note, append it if available. Signed-off-by: Marc-André Lureau --- dump.c | 20 1 file changed, 20 insertions(+) diff --git a/dump.c b/dump.c index f699198204..dd416ad271 100644 --- a/dump.c +++ b/dump.c @@ -839,6

[Qemu-devel] [PATCH v2 2/7] acpi: add vmcoreinfo device

2017-07-06 Thread Marc-André Lureau
The VM coreinfo (vmcoreinfo) device is an emulated device which exposes a 4k memory range to the guest to store various informations useful to debug the guest OS. (it is greatly inspired by the VMGENID device implementation) This is an early-boot alternative to the qemu-ga VMDUMP_INFO event propos

[Qemu-devel] [PATCH v2 3/7] tests: add simple vmcoreinfo test

2017-07-06 Thread Marc-André Lureau
This test is based off vmgenid test from Ben Warren . It simply checks the vmcoreinfo ACPI device is present and that the memory region associated can be read. Signed-off-by: Marc-André Lureau --- tests/vmcoreinfo-test.c | 130 tests/Makefile.incl

[Qemu-devel] [PATCH v2 6/7] scripts/dump-guest-memory.py: add vmcoreinfo

2017-07-06 Thread Marc-André Lureau
Add vmcoreinfo ELF note if vmcoreinfo device is ready. To help the python script, add a little global vmcoreinfo_gdb structure, that is populated with vmcoreinfo_gdb_update(). Signed-off-by: Marc-André Lureau --- scripts/dump-guest-memory.py | 40 hw/acp

Re: [Qemu-devel] [PATCH 7/7] MAINTAINERS: add Dump maintainers

2017-07-06 Thread Laszlo Ersek
On 07/06/17 11:54, Marc-André Lureau wrote: > Hi > > - Original Message - >> On 06/29/17 15:23, Marc-André Lureau wrote: >>> Proposing myself, since I have some familiarity with the code now. >>> >>> Signed-off-by: Marc-André Lureau >>> --- >>> MAINTAINERS | 7 +++ >>> 1 file changed

Re: [Qemu-devel] [PATCH 4/7] dump: add vmcoreinfo ELF note

2017-07-06 Thread Laszlo Ersek
On 07/05/17 23:52, Marc-André Lureau wrote: > Hi > > On Wed, Jul 5, 2017 at 1:48 AM, Laszlo Ersek wrote: >> On 06/29/17 15:23, Marc-André Lureau wrote: >>> @@ -258,6 +280,8 @@ static void write_elf64_notes(WriteCoreDumpFunction f, >>> DumpState *s, >>> return; >>> } >>>

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Stefan Hajnoczi
On Wed, Jul 05, 2017 at 12:07:57PM +0100, Daniel P. Berrange wrote: > On Wed, Jul 05, 2017 at 10:14:23AM +0200, Thomas Huth wrote: > > Hi, > > > > On 05.07.2017 08:57, Chao Peng wrote: > > > > > > Q35 has been in QEMU for quite a while. Compared to the current default > > > i440FX, Q35 is probab

Re: [Qemu-devel] [PATCH v4 04/21] stream: Drop reached_end for stream_complete()

2017-07-06 Thread Kevin Wolf
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > stream_complete() skips the work of rewriting the backing file if > the job was cancelled, if data->reached_end is false, or if there > was an error detected (non-zero data->ret) during the streaming. > But note that in stream_run(), data->reache

Re: [Qemu-devel] [PATCH v4 05/21] stream: Switch stream_run() to byte-based

2017-07-06 Thread Kevin Wolf
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Change the internal > loop iteration of streaming to track by bytes instead of sectors > (although we are still guaranteed that we iter

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 11:30:43AM +0100, Stefan Hajnoczi wrote: > On Wed, Jul 05, 2017 at 12:07:57PM +0100, Daniel P. Berrange wrote: > > On Wed, Jul 05, 2017 at 10:14:23AM +0200, Thomas Huth wrote: > > > Hi, > > > > > > On 05.07.2017 08:57, Chao Peng wrote: > > > > > > > > Q35 has been in QEMU

Re: [Qemu-devel] [PATCH v4 08/21] mirror: Switch MirrorBlockJob to byte-based

2017-07-06 Thread Kevin Wolf
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Continue by converting an > internal structure (no semantic change), and all references to the > buffer size. > > Add an assertion tha

Re: [Qemu-devel] [PULL 00/42] Misc changes for 2017-07-05

2017-07-06 Thread Peter Maydell
On 5 July 2017 at 08:14, Paolo Bonzini wrote: > The following changes since commit 0c7a8b9baa744ae4323bb46cb4fe942355beaa85: > > Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging > (2017-07-04 11:17:02 +0100) > > are available in the git repository at: > > > git://gith

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Daniel P. Berrange
On Wed, Jul 05, 2017 at 08:22:00PM +0800, Fam Zheng wrote: > On Wed, 07/05 13:58, Thomas Huth wrote: > > On 05.07.2017 13:44, Fam Zheng wrote: > > > On Wed, 07/05 12:04, Daniel P. Berrange wrote: > > >> While you can say people should just add '-M pc' that isn't a nice > > >> user experiance, becau

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Peter Maydell
On 6 July 2017 at 11:49, Daniel P. Berrange wrote: > eg if we killed the default, currently QEMU would say something like > >qemu-system-x86_64: No machine specified, and there is no default >Use -machine help to list supported machines Incidentally I really should get round to figuring o

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Thomas Huth
On 06.07.2017 12:49, Daniel P. Berrange wrote: [...] > This avoids the user having problems with guest ABI silently changing > behind their back, or migration suddenly failing to load vm state, For proper migration, you've got to specify the right versioned machine type anyway, so that should not

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 01:00:53PM +0200, Thomas Huth wrote: > On 06.07.2017 12:49, Daniel P. Berrange wrote: > [...] > > This avoids the user having problems with guest ABI silently changing > > behind their back, or migration suddenly failing to load vm state, > > For proper migration, you've go

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread John Paul Adrian Glaubitz
an.org/~glaubitz/chroots/unstable-sh4-20150315.tar.gz > [2] https://people.debian.org/~glaubitz/chroots/unstable-sh4-20170706.tgz -- .''`. John Paul Adrian Glaubitz : :' : Debian Developer - glaub...@debian.org `. `' Freie Universitaet Berlin - glaub...@physik.fu-ber

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Thomas Huth
On 06.07.2017 13:06, Daniel P. Berrange wrote: > On Thu, Jul 06, 2017 at 01:00:53PM +0200, Thomas Huth wrote: >> On 06.07.2017 12:49, Daniel P. Berrange wrote: >> [...] >>> This avoids the user having problems with guest ABI silently changing >>> behind their back, or migration suddenly failing to

Re: [Qemu-devel] change x86 default machine type to Q35?

2017-07-06 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Jul 06, 2017 at 01:00:53PM +0200, Thomas Huth wrote: > > On 06.07.2017 12:49, Daniel P. Berrange wrote: > > [...] > > > This avoids the user having problems with guest ABI silently changing > > > behind their back, or migration suddenly fa

Re: [Qemu-devel] [PATCH v4 11/21] mirror: Switch mirror_cow_align() to byte-based

2017-07-06 Thread Kevin Wolf
Am 05.07.2017 um 23:08 hat Eric Blake geschrieben: > We are gradually converting to byte-based interfaces, as they are > easier to reason about than sector-based. Convert another internal > function (no semantic change), and add mirror_clip_bytes() as a > counterpart to mirror_clip_sectors(). Som

[Qemu-devel] [Bug 1702621] Re: colo: secondary vm crash during loadvm

2017-07-06 Thread Dr. David Alan Gilbert
I haven't tried COLO for a while; I've got a note I hit a similar error in the past - I think I came to the conclusion it was the e1000 that was unhappy - probably sending an interrupt after it had stopped. Try a different NIC. I flipped to using a virtio-net at one point (but I think I had t

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Bharat Bhushan
> -Original Message- > From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] > Sent: Thursday, July 06, 2017 3:33 PM > To: Bharat Bhushan ; Auger Eric > ; eric.auger@gmail.com; > peter.mayd...@linaro.org; alex.william...@redhat.com; m...@redhat.com; > qemu-...@nongnu.org;

Re: [Qemu-devel] Managing architectural restrictions with -device and libvirt

2017-07-06 Thread Markus Armbruster
Marcel Apfelbaum writes: > On 05/07/2017 21:05, Markus Armbruster wrote: >> Mark Cave-Ayland writes: [...] >>> It seems like limiting the size of the bus would solve the majority of >>> the problem. I've had a quick look around pci.c and while I can see that >>> the PCIBus creation functions tak

Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting

2017-07-06 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Thu, Jul 06, 2017 at 08:15:54AM +0200, Markus Armbruster wrote: >> Alistair Francis writes: >> >> > This patch converts the existing error_vreport() function into a generic >> > qmesg_vreport() function that takes an enum describing the >> > information to be r

Re: [Qemu-devel] [RFC v3 2/3] qemu-error: Implement a more generic error reporting

2017-07-06 Thread Daniel P. Berrange
On Thu, Jul 06, 2017 at 01:27:15PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, Jul 06, 2017 at 08:15:54AM +0200, Markus Armbruster wrote: > >> Alistair Francis writes: > >> > >> > This patch converts the existing error_vreport() function into a generic > >> > qm

Re: [Qemu-devel] [RFC v2 0/8] VIRTIO-IOMMU device

2017-07-06 Thread Jean-Philippe Brucker
On 06/07/17 12:24, Bharat Bhushan wrote: > > >> -Original Message- >> From: Jean-Philippe Brucker [mailto:jean-philippe.bruc...@arm.com] >> Sent: Thursday, July 06, 2017 3:33 PM >> To: Bharat Bhushan ; Auger Eric >> ; eric.auger@gmail.com; >> peter.mayd...@linaro.org; alex.william...@

Re: [Qemu-devel] [PULL 0/8] s390x/kvm/migration: fixes, enhancements and cleanups

2017-07-06 Thread Peter Maydell
:05:30 +0100) > > are available in the git repository at: > > git://github.com/borntraeger/qemu.git tags/s390x-20170706 > > for you to fetch changes up to 1045e3cdafaf1218d9f771080ba5c9d4f64346e4: > > hw/s390x/ipl: Fix endianness proble

[Qemu-devel] [PATCH v6 00/13] chardevice hotswap

2017-07-06 Thread Anton Nefedov
Changed in v6: - patch 3: chr_lock mutex removed (as discussed, thread safety can be left to the front-ends, and the front-ends currently supported are good as is). - patch 5 now includes related changes for serial and virtio-serial - patch 13 commit message extended Changed i

[Qemu-devel] [PATCH v6 02/13] char: add backend hotswap handler

2017-07-06 Thread Anton Nefedov
Frontends should have an interface to setup the handler of a backend change. The interface will be used in the next commits Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-André Lureau --- include/chardev/char-fe.h | 5 + backends/rng-egd.c

[Qemu-devel] [PATCH v6 03/13] char: chardevice hotswap

2017-07-06 Thread Anton Nefedov
This patch adds a possibility to change a char device without a frontend removal. Ideally, it would have to happen transparently to a frontend, i.e. frontend would continue its regular operation. However, backends are not stateless and are set up by the frontends via qemu_chr_fe_<> functions, and

Re: [Qemu-devel] [PATCH 05/11] linux-user/sh4: Notice gUSA regions during signal delivery

2017-07-06 Thread Laurent Vivier
Le 06/07/2017 à 02:23, Richard Henderson a écrit : > We translate gUSA regions atomically in a parallel context. > But in a serial context a gUSA region may be interrupted. > In that case, restart the region as the kernel would. > > Signed-off-by: Richard Henderson > --- > linux-user/signal.c |

[Qemu-devel] [PATCH v6 01/13] char: move QemuOpts->ChardevBackend translation to a separate func

2017-07-06 Thread Anton Nefedov
parse function will be used by the following patch Signed-off-by: Anton Nefedov --- chardev/char.c | 81 -- 1 file changed, 51 insertions(+), 30 deletions(-) diff --git a/chardev/char.c b/chardev/char.c index 2b679a2..839eff6 100644 --- a/

[Qemu-devel] [PATCH v6 04/13] char: forbid direct chardevice access for hotswap devices

2017-07-06 Thread Anton Nefedov
qemu_chr_fe_get_driver() is unsafe, frontends with hotswap support should not access CharDriver ptr directly as CharDriver might change. Signed-off-by: Anton Nefedov Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Marc-André Lureau --- include/chardev/char-fe.h | 10 ++ chardev/

  1   2   3   4   >