On Mon, Jul 03, 2017 at 10:44:08AM +0800, Peter Xu wrote:
> [Peter collected Eduardo's patch comment and formatted into patch]
>
> Suggested-by: Eduardo Habkost
> Signed-off-by: Peter Xu
Reviewed-by: Eduardo Habkost
--
Eduardo
The sPAPR machine always create a default PHB during initialization, even
if -nodefaults was passed on the command line. This forces the user to
rely on -global if she wants to set properties of the default PHB, such
as numa_node.
This patch introduces a new machine create-default-phb property to
On Mon, Jul 03, 2017 at 10:44:05AM +0800, Peter Xu wrote:
> MigrateState object is not ready at that time, so we'll get an
> assertion. Use qemu_global_option() instead.
>
> Reported-by: Eduardo Habkost
> Suggested-by: Eduardo Habkost
> Fixes: 3df663e ("migration: move only_migratable to Migrati
On 07/03/2017 11:54 AM, Greg Kurz wrote:
QEMU shouldn't abort if spapr_add_lmbs()->spapr_drc_attach() fails.
Let's propagate the error instead, like it is done everywhere else
where spapr_drc_attach() is called.
Signed-off-by: Greg Kurz
---
Changes in v2: - added rollback code
---
hw/ppc/sp
On Mon, Jul 03, 2017 at 10:44:07AM +0800, Peter Xu wrote:
> It's never documented, and now we have one more parameter for it (which
> means this one can be obsolete in the future). Document it properly.
>
> Although now when enforce-config-section is set, it'll override the
> other "-global" param
On Wed, Jun 28, 2017 at 01:53:20PM +0800, Wei Wang wrote:
> Use is_power_of_2(), and remove trailing "." from error_setg().
>
> Signed-off-by: Wei Wang
Reviewed-by: Michael S. Tsirkin
> ---
> hw/net/virtio-net.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/h
On Mon, Jul 03, 2017 at 05:49:26PM +0100, Dr. David Alan Gilbert wrote:
> * Alexey (a.pereva...@samsung.com) wrote:
> >
> > Hello, David!
> >
> > Thank for you patch set.
> >
> > On Wed, Jun 28, 2017 at 08:00:18PM +0100, Dr. David Alan Gilbert (git)
> > wrote:
> > > From: "Dr. David Alan Gilber
On Tue, Jun 27, 2017 at 02:16:46PM +0800, Mao Zhongyi wrote:
> This series mainly implements the conversions of pci-bridge devices
> i82801b11, io3130_upstream/downstream and so on to realize(). Naturally
> part of error messages need to be converted to Error, then propagate
> to its callers via th
On Wed, Jun 28, 2017 at 08:00:21PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Utility to give the offset of a host pointer within a RAMBlock
> (assuming we already know it's in that RAMBlock)
>
> Signed-off-by: Dr. David Alan Gilbert
> ---
> exec.c
On 07/03/2017 11:12 AM, Eric Blake wrote:
> On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote:
>> bdrv_co_get_block_status_from_file() and
>> bdrv_co_get_block_status_from_backing() set *file to bs->file and
>> bs->backing respectively, so that bdrv_co_get_block_status() can recurse
>> to them. Fut
On Wed, Jun 28, 2017 at 08:00:18PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Hi,
> This is a RFC/WIP series that enables postcopy migration
> with shared memory to a vhost-user process.
> It's based off current-head + Juan's load_cleanup series, and
> Alexe
On 07/03/2017 09:40 AM, Peter Maydell wrote:
Since these are defined by system registers, I can imagine there can only be
a few pages for which this fine grained handling might apply any any one
time. This would certainly be preferable to reducing the effectiveness of
the entire TLB by a factor o
On 07/03/2017 09:23 AM, Laurent Vivier wrote:
Since f3218a8 ("softfloat: add floatx80 constants")
floatx80_infinity is defined but never used.
This patch updates floatx80 functions to use
this definition.
This allows to define a different default Infinity
value on m68k: the m68k FPU defines inf
On 06/29/17 15:23, Marc-André Lureau wrote:
> This compat property sole function is to prevent the device from being
> instantiated. Instead of requiring an extra compat property, check if
> fw_cfg has DMA enabled.
>
> This has the additional benefit of handling other cases properly, like:
>
>
POSIX says that backslashes in the arguments to 'echo', as well as
any use of 'echo -n' and 'echo -e', are non-portable; it recommends
people should favor 'printf' instead. This is definitely true where
we do not control which shell is running (such as in makefile snippets
or in documentation exam
On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote:
> This compat property sole function is to prevent the device from being
> instantiated. Instead of requiring an extra compat property, check if
> fw_cfg has DMA enabled.
>
> This has the additional benefit of handling other cases
On 06/27/2017 02:24 PM, Eric Blake wrote:
> We are gradually moving away from sector-based interfaces, towards
> byte-based. In the common case, allocation is unlikely to ever use
> values that are not naturally sector-aligned, but it is possible
> that byte-based values will let us be more precis
On Mon, Jul 03, 2017 at 12:51:45PM -0500, Eric Blake wrote:
On 07/03/2017 11:12 AM, Eric Blake wrote:
On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote:
bdrv_co_get_block_status_from_file() and
bdrv_co_get_block_status_from_backing() set *file to bs->file and
bs->backing respectively, so that b
On 03/07/2017 19:34, Michael S. Tsirkin wrote:
On Mon, Jul 03, 2017 at 02:27:11PM +0200, Igor Mammedov wrote:
On Fri, 30 Jun 2017 10:25:05 +0300
Marcel Apfelbaum wrote:
[...]
So for the modern systems not supporting PCI ACPI hotplug
we don't need pci-bridges anyway, but for the older ones
th
On Mon, Jul 03, 2017 at 08:06:33PM +0200, Laszlo Ersek wrote:
> On 06/29/17 15:23, Marc-André Lureau wrote:
> > This compat property sole function is to prevent the device from being
> > instantiated. Instead of requiring an extra compat property, check if
> > fw_cfg has DMA enabled.
> >
> > This
On Mon, Jul 03, 2017 at 09:26:33PM +0300, Marcel Apfelbaum wrote:
> On 03/07/2017 19:34, Michael S. Tsirkin wrote:
> > On Mon, Jul 03, 2017 at 02:27:11PM +0200, Igor Mammedov wrote:
> > > On Fri, 30 Jun 2017 10:25:05 +0300
> > > Marcel Apfelbaum wrote:
> > >
> > > [...]
> > > >
> > > > So for th
On 07/03/2017 01:24 PM, Manos Pitsidianakis wrote:
>> In fact, my rebase fallout is to completely delete
>> bdrv_co_get_block_status_from_file(). Why? Because blkdebug is the only
>> client, but I want to enhance blkdebug to add in-place assert()ions that
>> the values passed by the block layer a
On 07/03/17 20:27, Eduardo Habkost wrote:
> On Mon, Jul 03, 2017 at 08:06:33PM +0200, Laszlo Ersek wrote:
>> On 06/29/17 15:23, Marc-André Lureau wrote:
>>> This compat property sole function is to prevent the device from being
>>> instantiated. Instead of requiring an extra compat property, check
On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote:
> This compat property sole function is to prevent the device from being
> instantiated. Instead of requiring an extra compat property, check if
> fw_cfg has DMA enabled.
>
> This has the additional benefit of handling other cases
On 07/03/2017 10:56 AM, Eric Blake wrote:
> On 06/29/2017 01:43 PM, Manos Pitsidianakis wrote:
>> The following functions fail if bs->drv does not implement them:
One other suggestion: most patches in the tree use 'topic: Capital',
while yours used 'topic: lowercase'. It's probably worth posting
On Mon, Jul 03, 2017 at 09:38:52PM +0300, Michael S. Tsirkin wrote:
> On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote:
> > This compat property sole function is to prevent the device from being
> > instantiated. Instead of requiring an extra compat property, check if
> > fw_cfg ha
This is a very annoying bug, and it is still not solved after 2.7 years.
Last versions tested and affected by this bug:
KVM host qemu version 2.9.0
KVM host Linux version 4.9.6 x86_64
Please fix this.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is su
* Michael S. Tsirkin (m...@redhat.com) wrote:
> On Fri, Jun 30, 2017 at 05:31:39PM +0100, Dr. David Alan Gilbert wrote:
> > * Christian Borntraeger (borntrae...@de.ibm.com) wrote:
> > > On 04/26/2017 01:45 PM, Christian Borntraeger wrote:
> > >
> > > >> Hmm, I have a theory, if the flags field has
On 07/03/2017 09:23 AM, Laurent Vivier wrote:
+long double floatx80_to_ldouble(floatx80 val)
+{
+long double mantissa;
+int32_t exp;
+uint8_t sign;
+
+if (floatx80_is_infinity(val)) {
+if (floatx80_is_neg(val)) {
+return -__builtin_infl();
+}
+r
On 07/03/2017 09:23 AM, Laurent Vivier wrote:
Use libm functions fmodl() and remainderl().
The quotient byte of the FPSR is updated with
the result of the operation.
Signed-off-by: Laurent Vivier
---
target/m68k/cpu.h| 1 +
target/m68k/fpu_helper.c | 35 ++
On 07/03/2017 12:11 PM, Richard Henderson wrote:
if (floatx80_to_ldouble(&d, val))) {
d = sinl(d);
val = ldouble_to_floatx80(d, status);
} else {
status->float_exception_flags |= float_flag_invalid;
val = floatx80_default_nan(status);
}
Blah. I didn't mean default_
On Wed, Jun 28, 2017 at 10:37:59AM +0800, Wei Wang wrote:
> This patch enables the virtio-net tx queue size to be configurable
> between 256 (the default queue size) and 1024 by the user when the
> vhost-user backend is used.
>
> Currently, the maximum tx queue size for other backends is 512 due
>
On 07/03/2017 09:23 AM, Laurent Vivier wrote:
+void HELPER(fgetman)(CPUM68KState *env, FPReg *res, FPReg *val)
+{
+if (floatx80_is_infinity(val->d)) {
+res->d = floatx80_default_nan(NULL);
+/* FIXME: set the OPERR bit int he FPSR */
+return;
+}
+if (floatx80_is
Current code segfaults when no nic peer is specified.
Fix it up - fall back to default queue size.
Fixes: 526e8fa8b872 ("virtio-net: enable configurable tx queue size")
Cc: Wei Wang
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 28
1 file changed, 20 i
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
This will be useful when the functions are called, early in the configure
process, to filter out targets that do not support hardware acceleration.
Signed-off-by: Paolo Bonzini
---
configure | 90 ++---
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
Check for unsupported targets in target_list, and print an
error early in the configuration process.
Signed-off-by: Paolo Bonzini
---
configure | 65 ++-
1 file changed, 43 insertions(+),
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
This lets you build without TCG (hardware accelerationor qtest only). When
this flag is passed to configure, it will automatically filter out the target
list to only those that support KVM or Xen or HAX.
Signed-off-by: Anthony Liguori
Signed-off-by:
From: Wei Wang
This patch enables the virtio-net tx queue size to be configurable
between 256 (the default queue size) and 1024 by the user when the
vhost-user backend is used.
Currently, the maximum tx queue size for other backends is 512 due
to the following limitations:
- QEMU backend: the QE
From: Thomas Huth
This way the bridge shows up in the correct section of the
"-device help" text.
Signed-off-by: Thomas Huth
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
Reviewed-by: David Gibson
Reviewed-by: Marcel Apfelbaum
---
hw/pci-bridge/dec.c | 2 ++
1 file chan
From: Mao Zhongyi
On success, pci_add_capability2() returns a positive value. On
failure, it sets an error and return a negative value.
pci_add_capability() laboriously checks this behavior. No other
caller does. Drop the checks from pci_add_capability().
Cc: m...@redhat.com
Cc: mar...@redhat.c
From: Mao Zhongyi
pci_add_capability returns a strictly positive value on success,
correct asserts.
Cc: dmi...@daynix.com
Cc: jasow...@redhat.com
Cc: kra...@redhat.com
Cc: alex.william...@redhat.com
Cc: arm...@redhat.com
Cc: mar...@redhat.com
Signed-off-by: Mao Zhongyi
Reviewed-by: Marcel Apfel
The following changes since commit fd479c60f5766f7fb247ad146b9e3c33d03d2055:
Merge remote-tracking branch 'remotes/rth/tags/pull-tcg-20170603' into
staging (2017-07-03 09:54:32 +0100)
are available in the git repository at:
git://git.kernel.org/pub/scm/virt/kvm/mst/qemu.git tags/for_upstrea
From: Mao Zhongyi
In order to propagate error message better, convert shpc_init() to
Error also convert the pci_bridge_dev_initfn() to realize.
Cc: m...@redhat.com
Cc: mar...@redhat.com
Cc: arm...@redhat.com
Signed-off-by: Mao Zhongyi
Reviewed-by: Marcel Apfelbaum
Reviewed-by: Michael S. Tsirk
From: Mao Zhongyi
Convert i82801b11, io3130_upstream, io3130_downstream and
pcie_root_port devices to realize.
Cc: m...@redhat.com
Cc: mar...@redhat.com
Cc: arm...@redhat.com
Signed-off-by: Mao Zhongyi
Reviewed-by: Marcel Apfelbaum
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsi
From: Mao Zhongyi
Comments for pci_add_capability2() to explain the return
value. This may help to make a correct return value check
for its callers.
Cc: m...@redhat.com
Cc: mar...@redhat.com
Cc: arm...@redhat.com
Signed-off-by: Mao Zhongyi
Reviewed-by: Marcel Apfelbaum
Reviewed-by: Michael S.
From: Ladi Prosek
The VT-d spec (section 6.5.2) prescribes software to zero the
Invalidation Queue Tail Register before enabling the VTD_GCMD_QIE
Global Command Register bit. Windows Server 2012 R2 and possibly
other older Windows versions violate the protocol and set a
non-zero queue tail first,
From: Mao Zhongyi
Add Error argument for pci_add_capability() to leverage the errp
to pass info on errors. This way is helpful for its callers to
make a better error handling when moving to 'realize'.
Cc: pbonz...@redhat.com
Cc: r...@twiddle.net
Cc: ehabk...@redhat.com
Cc: m...@redhat.com
Cc: ja
From: Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov
Reviewed-by: Igor Mammedov
Reviewed-by: Michael S. Tsirkin
Signed-off-by: Michael S. Tsirkin
---
hw/i386/acpi-build.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
inde
From: Mao Zhongyi
When the function no success value to transmit, it usually make the
function return void. It has turned out not to be a success, because
it means that the extra local_err variable and error_propagate() will
be needed. It leads to cumbersome code, therefore, transmit success/
fai
From: Mao Zhongyi
In assigned_device_pci_cap_init(), first, error messages are filled
to a local_err variable, then through error_propagate() pass to
the parameter of errp. It leads to cumbersome code. In order to
avoid the extra local_err and error_propagate(), drop it and use
errp instead.
Cc:
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
-extern int tcg_tb_size;
+extern unsigned long tcg_tb_size;
size_t would be more natural.
I don't think we support any hosts for which sizeof(size_t) != sizeof(unsigned
long), but perhaps
unsigned lomg tmp;
if (qemu_strtoul(optarg
From: Mao Zhongyi
After the patch 'Make errp the last parameter of pci_add_capability()',
pci_add_capability() and pci_add_capability2() now do exactly the same.
So drop the wrapper pci_add_capability() of pci_add_capability2(), then
replace the pci_add_capability2() with pci_add_capability() eve
From: Maxime Coquelin
This patch fixes a crash that happens when vhost-user iommu
support is enabled and vhost-user socket is closed.
When it happens, if an IOTLB invalidation notification is sent
by the IOMMU, vhost_ops's NULL pointer is dereferenced.
Signed-off-by: Maxime Coquelin
Reviewed-b
Am 27.06.2017 um 17:04 schrieb Eric Blake:
> On 06/27/2017 09:49 AM, Peter Lieven wrote:
>
>> Before I continue, can you please give feedback on the following spec
>> change:
>>
>> diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
>> index 80cdfd0..f1428e9 100644
>> --- a/docs/interop/qc
From: Mark Cave-Ayland
The setting of the FW_CFG_VERSION_DMA bit is the same across both the
TYPE_FW_CFG_MEM and TYPE_FW_CFG_IO devices, so unify the logic in
fw_cfg_init1().
Signed-off-by: Mark Cave-Ayland
Reviewed-by: Laszlo Ersek
Reviewed-by: Eduardo Habkost
Reviewed-by: Philippe Mathieu-D
From: Ben Warren
The following tests are implemented:
* test that a GUID passed in by command line is propagated to the guest.
Read the GUID from guest memory
* test that the "auto" argument to the GUID generates a valid GUID, as
seen by the guest.
* test that a GUID passed in can be queried
Current code segfaults when no nic peer is specified.
Fix it up - fall back to default queue size.
Fixes: 9b02e1618cf26a ("virtio-net: enable configurable tx queue size")
Cc: Wei Wang
Signed-off-by: Michael S. Tsirkin
---
hw/net/virtio-net.c | 28
1 file changed, 20
From: Mark Cave-Ayland
As indicated by Laszlo it is a QOM bug for the realize() method to actually
map the device. Set up the IO regions within fw_cfg_io_realize() and defer
the mapping with sysbus_add_io() to the caller, as already done in
fw_cfg_init_mem_wide().
This makes the iobase and dma_i
Le 03/07/2017 à 21:26, Richard Henderson a écrit :
> On 07/03/2017 09:23 AM, Laurent Vivier wrote:
>> +void HELPER(fgetman)(CPUM68KState *env, FPReg *res, FPReg *val)
>> +{
>> +if (floatx80_is_infinity(val->d)) {
>> +res->d = floatx80_default_nan(NULL);
>> +/* FIXME: set the OPE
From: Peter Xu
Migration is broken after the vfio integration work:
qemu-kvm: AHCI: Failed to start FIS receive engine: bad FIS receive buffer
address
qemu-kvm: Failed to load ich9_ahci:ahci
qemu-kvm: error while loading state for instance 0x0 of device
':00:1f.2/ich9_ahci'
qemu-kvm: load
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
From: Yang Zhong
Need to disable the tcg related code in the vl.c if the
disable-tcg option is added into ./configure command.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
vl.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletio
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
From: Yang Zhong
Move tcg_handle_interrupt() from translate-common.c to
accel/tcg/tcg-all.c.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
accel/tcg/Makefile.objs | 2 +-
accel/tcg/tcg-all.c | 32 +++
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
From: Yang Zhong
Change the tcg_enabled() and make sure user build still enable tcg
even x86 softmmu disable tcg.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
accel/tcg/cpu-exec-common.c | 2 ++
accel/tcg/tcg-all.c | 1 -
ac
From: Maxime Coquelin
If the backend sends a request just before closing the socket,
the aio dispatcher might schedule its reading after the vhost
device has been cleaned, leading to a NULL pointer dereference
in slave_read();
vhost_user_cleanup() already closes the socket but it is not
enough,
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
From: Yang Zhong
translate-all.c will be disabled if tcg is disabled in the build,
so page_size_init() function and related variables will be moved
to exec.c file.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
accel/tcg/translate-all.c
On 01/07/17 01:06, Stefano Stabellini wrote:
> On Fri, 30 Jun 2017, Igor Druzhinin wrote:
>> Dummys are simple anonymous mappings that are placed instead
>> of regular foreign mappings in certain situations when we need
>> to postpone the actual mapping but still have to give a
>> memory region to
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
From: Yang Zhong
If tcg is disabled, the functions in tcg-stub.c file will be called.
This file is target-independent file, do not include any platform
related stub functions into this file.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
We dropped some dead code, update extected table binaries.
Fixes: 4d7e7f2702912 ("hw/acpi: remove dead acpi code")
Signed-off-by: Michael S. Tsirkin
---
tests/acpi-test-data/q35/DSDT| Bin 7824 -> 7782 bytes
tests/acpi-test-data/q35/DSDT.bridge | Bin 7841 -> 7799 bytes
tests/acpi-test-d
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
accel/tcg/translate-all.c | 5 +
hmp-commands-info.hx | 4
monitor.c | 2 ++
3 files changed, 11 insertions(+)
Reviewed-by: Richard Henderson
r~
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
hw/i386/kvmvapic.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson
r~
On Mon, Jul 03, 2017 at 03:50:52PM -0300, Eduardo Habkost wrote:
> On Mon, Jul 03, 2017 at 09:38:52PM +0300, Michael S. Tsirkin wrote:
> > On Thu, Jun 29, 2017 at 03:23:04PM +0200, Marc-André Lureau wrote:
> > > This compat property sole function is to prevent the device from being
> > > instantiat
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
Signed-off-by: Paolo Bonzini
---
bsd-user/main.c | 1 -
include/exec/exec-all.h | 4
tcg/tcg.h | 4
3 files changed, 4 insertions(+), 5 deletions(-)
Reviewed-by: Richard Henderson
r~
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
--- a/include/exec/helper-proto.h
+++ b/include/exec/helper-proto.h
@@ -28,7 +28,9 @@ dh_ctype(ret) HELPER(name) (dh_ctype(t1), dh_ctype(t2),
dh_ctype(t3), \
#include "helper.h"
#include "trace/generated-helpers.h"
+#ifdef CONFIG_TCG
#includ
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
From: Yang Zhong
Add the CONFIG_TCG for frontend and backend's files in the related
Makefiles.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
Makefile.target | 4 ++--
accel/Makefile.objs | 2 +-
2 files changed, 3 insertions(+),
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
Adding assertions fixes link errors.
Signed-off-by: Paolo Bonzini
---
exec.c | 3 +++
1 file changed, 3 insertions(+)
Reviewed-by: Richard Henderson
r~
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
@@ -1302,10 +1332,12 @@ void cpu_report_tpr_access(CPUX86State *env, TPRAccess
access)
env->tpr_access_type = access;
cpu_interrupt(cs, CPU_INTERRUPT_TPR);
-} else {
+} else if (tcg_enabled()) {
cpu_restore_st
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
From: Yang Zhong
Move cpu_get_fp80()/cpu_set_fp80() from fpu_helper.c to
machine.c because fpu_helper.c will be disabled if tcg is
disabled in the build.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
target/i386/cpu.h| 2 --
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
+static inline void cpu_set_mxcsr(CPUX86State *env, uint32_t mxcsr)
+{
+env->mxcsr = mxcsr;
+if (tcg_enabled()) {
+tcg_update_mxcsr(env);
I'd prefer update_mxcsr_status for this new name.
+}
+}
+
+static inline void cpu_set_fpuc
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
This function calls tlb_set_page_with_attrs, which is not available
when TCG is disabled. Move it to excp_helper.c.
Signed-off-by: Paolo Bonzini
---
target/i386/excp_helper.c | 343 +
target/i386/helper.
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
@@ -215,10 +215,12 @@ void breakpoint_handler(CPUState *cs)
if (cs->watchpoint_hit) {
if (cs->watchpoint_hit->flags & BP_CPU) {
cs->watchpoint_hit = NULL;
-if (check_hw_breakpoints(env, false)) {
-
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
From: Yang Zhong
Add the CONFIG_TCG for frontend and backend's files in the related
Makefiles.
Signed-off-by: Yang Zhong
Signed-off-by: Paolo Bonzini
---
target/i386/Makefile.objs | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
di
On 07/03/2017 09:34 AM, Paolo Bonzini wrote:
--disable-tcg will almost certainly fail to compile on non-x86 platforms,
so issue a warning.
Signed-off-by: Paolo Bonzini
---
configure | 7 +++
1 file changed, 7 insertions(+)
Reviewed-by: Richard Henderson
r~
On 07/03/2017 12:50 PM, Laurent Vivier wrote:
fmove.x #0x0ABCDEF12345,%fp0
fgetman.x %fp0,%fp6
fp02.1518178707571747286191852003521627e-4938 (raw
0x0abcdef12345)
fp61.34103012886691431049257516861 (raw
0x3f
On 01/07/17 01:08, Stefano Stabellini wrote:
> On Fri, 30 Jun 2017, Igor Druzhinin wrote:
>> This new call is trying to update a requested map cache entry
>> according to the changes in the physmap. The call is searching
>> for the entry, unmaps it, tries to translate the address and
>> maps again
On Mon, 3 Jul 2017, Igor Druzhinin wrote:
> On 01/07/17 01:06, Stefano Stabellini wrote:
> > On Fri, 30 Jun 2017, Igor Druzhinin wrote:
> >> Dummys are simple anonymous mappings that are placed instead
> >> of regular foreign mappings in certain situations when we need
> >> to postpone the actual m
On 06/30/2017 07:36 AM, Pranith Kumar wrote:
This patch enables the indirect jump path using an LDR (literal)
instruction. It will be interesting to test and see which performs
better among the two paths.
CC: Alex Bennée
Reviewed-by: Richard Henderson
Signed-off-by: Pranith Kumar
Applied al
On 07/01/2017 03:44 PM, Peter Maydell wrote:
On 1 July 2017 at 23:35, Richard Henderson wrote:
Perhaps it ought to be telling me to use %x to force Xn in spite of the
type?
You always get Xn anyway, regardless of the type.
For us, I think the right thing to do is make 'ctr' be a uint64_t,
be
On 07/02/2017 06:18 AM, Aurelien Jarno wrote:
+if (!s390_has_feat(s->insn->fac == S390_FEAT_EXTENDED_TRANSLATION_3
+ ? S390_FEAT_ETF3_ENH : S390_FEAT_ETF2_ENH)) {
+m3 = 0;
+}
This doesn't look correct to me. The well-formedness checking is part of
ETF3_ENH
On 07/02/2017 09:32 AM, Aurelien Jarno wrote:
This patchset should fix the bug #1701821 reported by Bruno Haible,
which makes the gnulib testsuite to fail for single precision libm
tests.
Aurelien Jarno (2):
target/sh4: do not check for PR bit for fabs instruction
target/sh4: do not use a
Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
flexibility (extending using subsections) and for fun.
To achieve this we need to hack the config_vector, which is VirtIODevice
(that is common virtio) state, in the middle of the VirtioCcwDevice state
representation. This is s
On 07/02/2017 01:28 PM, Aurelien Jarno wrote:
This patchset should fix the bug#1701821 reported by Bruno Haible,
which makes the gnulib testsuite to fail for single precision libm
tests or for tests relying on unordered comparisons.
It also fixes an inversion of cause and flag bits in the FPSCR
Am Mon, 3 Jul 2017 23:34:14 +0200
schrieb Halil Pasic :
> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
> flexibility (extending using subsections) and for fun.
>
> To achieve this we need to hack the config_vector, which is
> VirtIODevice (that is common virtio) state, i
Tried it on Win7 Enterprise SP1 - SHPC works well, _OSC patches aren't
necessary (since pci-bridge has its own controller, I suppose).
On Linux guests it works when adding device from CLI with -device, but OS
seems to fail detecting the device when I add it with device_add from
monitor.
Also there
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
function (no semantic change).
Signed-off-by: Eric Blake
---
v2: new patch
---
block/io.c | 42 +-
1 file changed, 21 ins
Not all callers care about which BDS owns the mapping for a given
range of the file. In particular, bdrv_is_allocated() cares more
about finding the largest run of allocated data from the guest
perspective, whether or not that data is consecutive from the
host perspective. Therefore, doing subseq
There are patches floating around to add NBD_CMD_BLOCK_STATUS,
but NBD wants to report status on byte granularity (even if the
reporting will probably be naturally aligned to sectors or even
much higher levels). I've therefore started the task of
converting our block status code to report at a byt
We are gradually converting to byte-based interfaces, as they are
easier to reason about than sector-based. Convert another internal
type (no semantic change), and rename it to match the corresponding
public function rename.
Signed-off-by: Eric Blake
---
v2: rebase to earlier changes
---
block
From: Manos Pitsidianakis
bdrv_co_get_block_status_from_file() and
bdrv_co_get_block_status_from_backing() set *file to bs->file and
bs->backing respectively, so that bdrv_co_get_block_status() can recurse
to them. Future block drivers won't have to duplicate code to implement
this.
Reviewed-by:
Not all callers care about which BDS owns the mapping for a given
range of the file. This patch merely simplifies the callers by
consolidating the logic in the common call point, while guaranteeing
a non-NULL file to all the driver callbacks, for no semantic change.
The only caller that does not c
Any device that has request_alignment greater than 512 should be
unable to report status at a finer granularity; it may also be
simpler for such devices to be guaranteed that the block layer
has rounded things out to the granularity boundary (the way the
block layer already rounds all other I/O out
201 - 300 of 351 matches
Mail list logo
