Re: [Qemu-devel] [PATCH] softfloat: define floatx80_default_inf

2017-06-29 Thread Philippe Mathieu-Daudé
On Thu, Jun 29, 2017 at 4:04 PM, Laurent Vivier wrote: > Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daudé > --- > fpu/softfloat-specialize.h | 10 ++ > fpu/softfloat.c| 38 ++ > include/fpu/softfloat.h| 8 +++- >

Re: [Qemu-devel] [PATCH v6 09/10] migration: merge enforce_config_section somewhat

2017-06-29 Thread Eduardo Habkost
On Thu, Jun 29, 2017 at 11:00:13AM +0800, Peter Xu wrote: > On Thu, Jun 29, 2017 at 12:42:56AM +0200, Juan Quintela wrote: > > Eduardo Habkost wrote: > > > > > > > > So, this is a case where a user-provided config option (-machine > > > enforce-config-section) should trigger a different default i

Re: [Qemu-devel] [PATCH v2 2/6] nbd/server: use errp instead of LOG

2017-06-29 Thread Eric Blake
On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: > Move to modern errp scheme from just LOGging errors. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 268 > +++ > 1 file changed, 161 insertions(+), 107 d

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Alex Williamson
On Thu, 29 Jun 2017 09:33:19 +0100 "Daniel P. Berrange" wrote: > On Wed, Jun 28, 2017 at 07:24:55PM -0500, Michael Roth wrote: > > Hi everyone. Hoping to get some feedback on this approach, or some > > alternatives proposed below, to the following issue: > > > > Currently libvirt immediately att

Re: [Qemu-devel] [PATCH v2 3/6] nbd/server: add errp to nbd_send_reply()

2017-06-29 Thread Eric Blake
On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/server.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > @@ -1266,8 +1267,8 @@ reply: > local_err = NULL; > } > > -if (nbd_co_s

Re: [Qemu-devel] TPM status

2017-06-29 Thread Stefan Berger
On 06/27/2017 12:32 PM, Laszlo Ersek wrote: Looks great to me, thank you! Two requests in addition to the above remarks: - can you provide command line options / examples wherever appropriate? I didn't add it because we describe that on this page here: http://download.qemu.org/qemu-doc.html

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Alex Williamson
On Thu, 29 Jun 2017 13:22:44 -0500 Michael Roth wrote: > Quoting Daniel P. Berrange (2017-06-29 03:33:19) > > On Wed, Jun 28, 2017 at 07:24:55PM -0500, Michael Roth wrote: > > > Hi everyone. Hoping to get some feedback on this approach, or some > > > alternatives proposed below, to the followin

Re: [Qemu-devel] [PATCH v2 4/6] nbd/common: nbd_tls_handshake: remove extra TRACE

2017-06-29 Thread Eric Blake
On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: > Error is propagated to the caller, TRACE is not needed. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/common.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) Reviewed-by: Eric Blake > > diff --git a/nbd/c

Re: [Qemu-devel] [PATCH v2 5/6] nbd/client: refactor TRACE of NBD_MAGIC

2017-06-29 Thread Eric Blake
On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: > We are going to switch from TRACE macro to trace points, > this TRACE complicates things, this patch simplifies it. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > nbd/client.c | 15 --- > 1 file changed, 4 inserti

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Alex Williamson
On Thu, 29 Jun 2017 14:50:15 -0400 Laine Stump wrote: > On 06/28/2017 08:24 PM, Michael Roth wrote: > > Hi everyone. Hoping to get some feedback on this approach, or some > > alternatives proposed below, to the following issue: > > > > Currently libvirt immediately attempts to rebind a managed d

[Qemu-devel] [RFC v2 2/3] qemu-error: Implement a more generic error reporting

2017-06-29 Thread Alistair Francis
This patch removes the exisinting error_vreport() function and replaces it with a more generic vreport() function that takes an enum describing the information to be reported. As part of this change a report() function is added as well with the same capability. To maintain full compatibility the

[Qemu-devel] [RFC v2 0/3] Implement a warning_report function

2017-06-29 Thread Alistair Francis
QEMU currently has a standard method to report errors with error_repot(). This ensure a sane and standard format when printing errors. This series is attempting to extend this functionality for warnings and information as well. At the moment only one error is being converted, I wanted to get the i

[Qemu-devel] [RFC v2 1/3] util/qemu-error: Rename error_print_loc() to be more generic

2017-06-29 Thread Alistair Francis
Rename the error_print_loc() function in preparation for using it to print warnings as well. Signed-off-by: Alistair Francis Reviewed-by: Philippe Mathieu-Daudé --- util/qemu-error.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/qemu-error.c b/util/qemu-error.c i

[Qemu-devel] [RFC v2 3/3] char-socket: Report TCP socket waiting as information

2017-06-29 Thread Alistair Francis
When QEMU is waiting for a TCP socket connection it reports that message as an error. This isn't an error it is just informaiton so let's change the report to use report() instead. Signed-off-by: Alistair Francis --- chardev/char-socket.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) d

Re: [Qemu-devel] [PATCH 0/3] AHCI: re-privatize ahci headers

2017-06-29 Thread John Snow
On 06/23/2017 06:09 PM, John Snow wrote: > As reported by Philippe Mathieu-Daudé, including AHCI headers can > quickly pull in more dependencies than is sane. To remedy this, > split the AHCI headers into public and private areas as best as we > can and move the private information back into hw/i

Re: [Qemu-devel] [RFC v1 4/4] util/oslib-win32: Recursivly pass the timeout

2017-06-29 Thread Paolo Bonzini
> On Thu, Jun 29, 2017 at 5:34 AM, Paolo Bonzini wrote: > > On 28/06/2017 01:57, Alistair Francis wrote: > > I'm not sure I agree with this change, which is effectively delaying the > > processing of events. The question to me is which handles are > > triggering so fast that QEMU effectively busy

Re: [Qemu-devel] [PATCH] block: fix bs->file leak in bdrv_new_open_driver()

2017-06-29 Thread Manos Pitsidianakis
On Thu, Jun 29, 2017 at 03:57:49PM +0200, Kevin Wolf wrote: Am 29.06.2017 um 14:07 hat Manos Pitsidianakis geschrieben: On Thu, Jun 29, 2017 at 01:18:24PM +0200, Kevin Wolf wrote: >Am 29.06.2017 um 08:03 hat Manos Pitsidianakis geschrieben: >>bdrv_open_driver() is called in two places, bdrv_new_

Re: [Qemu-devel] [PATCH v2 6/6] nbd: use generic trace subsystem instead of TRACE macro

2017-06-29 Thread Eric Blake
On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: > Starting from this patch to enable traces use -trace option of qemu or > -T, --trace option of qemu-img, qemu-io and qemu-nbd. For qemu traces > also can be managed by qmp commands trace-event-{get,set}-state. Maybe: Let NBD use the tr

[Qemu-devel] [RFC 2/7] translate-all: add out_size field to TranslationBlock

2017-06-29 Thread Emilio G. Cota
This paves the way for upcoming work: we need tb->out_size for tb_find_pc to work with a binary search tree. Note that due to the cacheline padding we are using, for hosts with 64-byte cache lines this will not waste any additional memory. Using a s16 would be ideal, since that would plug an exist

[Qemu-devel] [RFC 0/7] tcg: parallel code generation (Work in Progress)

2017-06-29 Thread Emilio G. Cota
This is a request for comments as well as a request for help :-) I've been experimenting with making TCGContext per-thread, so that we can run most of tcg_gen_code in parallel. I've made some progress, but haven't yet got it to work. My guess is that the TCG stack is still global instead of per-v

[Qemu-devel] [RFC 4/7] translate-all: report correct avg host TB size

2017-06-29 Thread Emilio G. Cota
Since commit 6e3b2bfd6 ("tcg: allocate TB structs before the corresponding translated code") we are not fully utilizing code_gen_buffer for translated code, and therefore are incorrectly reporting the amount of translated code as well as the average host TB size. Address this by: - Making the cons

[Qemu-devel] [RFC 3/7] translate-all: use a binary search tree to track TBs in TBContext

2017-06-29 Thread Emilio G. Cota
This is a prerequisite for having threads generate code on separate buffers, which will help scalability when booting multiple cores under MTTCG. Note that tb_free does not free space in the code_gen_buffer anymore, since we cannot easily know whether the tb is the last one inserted in code_gen_bu

[Qemu-devel] [RFC 5/7] tcg: take tb_ctx out of TCGContext

2017-06-29 Thread Emilio G. Cota
Before TCGContext is made thread-local. Signed-off-by: Emilio G. Cota --- include/exec/tb-context.h | 2 ++ tcg/tcg.h | 2 -- accel/tcg/cpu-exec.c | 2 +- accel/tcg/translate-all.c | 57 --- linux-user/main.c | 6 ++---

[Qemu-devel] [RFC 1/7] exec-all: fix typos in TranslationBlock's documentation

2017-06-29 Thread Emilio G. Cota
Signed-off-by: Emilio G. Cota --- include/exec/exec-all.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/exec/exec-all.h b/include/exec/exec-all.h index 724ec73..35a75f1 100644 --- a/include/exec/exec-all.h +++ b/include/exec/exec-all.h @@ -338,7 +338,7 @@ struct

[Qemu-devel] [RFC 7/7] [XXX] translate-all: generate TCG code without holding tb_lock

2017-06-29 Thread Emilio G. Cota
Generate new TBs without holding tb_lock, which should increase scalability when running MTTCG for workloads that generate a lot of code (e.g. booting linux). XXX: Doesn't work :-) See the commit log from the previous patch. Signed-off-by: Emilio G. Cota --- accel/tcg/cpu-exec.c | 8 +

[Qemu-devel] [RFC 6/7] [XXX] tcg: make TCGContext thread-local for softmmu

2017-06-29 Thread Emilio G. Cota
This will allow us to generate TCG code in parallel. User-mode is kept out of this: contention due to concurrent translation is more commonly found in full-system mode (e.g. booting a many-core guest). XXX: For now, only convert arm/a64, since these are the only guests that have proper MTTCG supp

Re: [Qemu-devel] [PATCH v3 00/11] make dirty-bitmap byte-based

2017-06-29 Thread John Snow
On 06/29/2017 11:11 AM, Eric Blake wrote: > On 06/29/2017 03:28 AM, Vladimir Sementsov-Ogievskiy wrote: >> Hi! >> >> Can we apply my "[PATCH v22 00/30] qcow2: persistent dirty bitmaps" >> first? It was already near to the victory a week ago, but I had to >> rebase it on new Paolo's patches. > >

Re: [Qemu-devel] [RFC v2 2/3] qemu-error: Implement a more generic error reporting

2017-06-29 Thread Eric Blake
On 06/29/2017 02:42 PM, Alistair Francis wrote: > This patch removes the exisinting error_vreport() function and replaces it s/exisinting/existing/ > with a more generic vreport() function that takes an enum describing the > information to be reported. > > As part of this change a report() funct

Re: [Qemu-devel] [RFC v2 3/3] char-socket: Report TCP socket waiting as information

2017-06-29 Thread Eric Blake
On 06/29/2017 02:42 PM, Alistair Francis wrote: > When QEMU is waiting for a TCP socket connection it reports that message as > an error. This isn't an error it is just informaiton so let's change the > report to use report() instead. > > Signed-off-by: Alistair Francis > --- > > chardev/char-s

Re: [Qemu-devel] [RFC 5/5] vifo: introduce new VFIO ioctl VFIO_DEVICE_PCI_GET_DIRTY_BITMAP

2017-06-29 Thread Alex Williamson
On Thu, 29 Jun 2017 00:10:59 + "Tian, Kevin" wrote: > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > Sent: Thursday, June 29, 2017 12:00 AM > > Thanks Kevin. So really it's not really a dirty bitmap, it's just a > > bitmap of pages that the device has access to and may have

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Michael Roth
Quoting Laine Stump (2017-06-29 13:50:15) > On 06/28/2017 08:24 PM, Michael Roth wrote: > > Hi everyone. Hoping to get some feedback on this approach, or some > > alternatives proposed below, to the following issue: > > > > Currently libvirt immediately attempts to rebind a managed device back to

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Michael Roth
Quoting Alex Williamson (2017-06-29 14:28:11) > On Thu, 29 Jun 2017 09:33:19 +0100 > "Daniel P. Berrange" wrote: > > > On Wed, Jun 28, 2017 at 07:24:55PM -0500, Michael Roth wrote: > > > Hi everyone. Hoping to get some feedback on this approach, or some > > > alternatives proposed below, to the f

Re: [Qemu-devel] [PATCH v22 00/30] qcow2: persistent dirty bitmaps

2017-06-29 Thread John Snow
On 06/28/2017 08:05 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > There is a new update of qcow2-bitmap series - v22. > > web: > https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v22 > git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v22) >

Re: [Qemu-devel] [RFC v1 4/4] util/oslib-win32: Recursivly pass the timeout

2017-06-29 Thread Alistair Francis
On Thu, Jun 29, 2017 at 12:47 PM, Paolo Bonzini wrote: >> On Thu, Jun 29, 2017 at 5:34 AM, Paolo Bonzini wrote: >> > On 28/06/2017 01:57, Alistair Francis wrote: >> > I'm not sure I agree with this change, which is effectively delaying the >> > processing of events. The question to me is which h

Re: [Qemu-devel] [PATCH v4 2/2] bitmaps.md: Convert to rST; move it into 'interop' dir

2017-06-29 Thread John Snow
On 06/28/2017 10:58 AM, Kashyap Chamarthy wrote: > This is part of the on-going effort to convert QEMU upstream > documentation syntax to reStructuredText (rST). > > The conversion to rST was done using: > > $ pandoc -f markdown -t rst bitmaps.md -o bitmaps.rst > > Then, make a couple of s

[Qemu-devel] [PATCH v6 0/3] qemu-ga: add guest-get-osinfo command

2017-06-29 Thread Tomáš Golembiovský
v6: - fixed the documentation comment in schema - disguising os-release as key-value file (thanks Marc-André) - dropped dependency on gio - improved error handling - added test v5: - fixed build failure with older glib - fixed coding style issues - fixed one log string This is a continuation of t

[Qemu-devel] [PATCH v6 1/3] qemu-ga: add guest-get-osinfo command

2017-06-29 Thread Tomáš Golembiovský
Add a new 'guest-get-osinfo' command for reporting basic information of the guest operating system. This includes machine architecture, version and release of the kernel and several fields from os-release file if it is present (as defined in [1]). [1] https://www.freedesktop.org/software/systemd/m

[Qemu-devel] [PATCH v6 2/3] test-qga: pass environemnt to qemu-ga

2017-06-29 Thread Tomáš Golembiovský
Modify fixture_setup() to pass environemnt variables to spawned qemu-ga instance. Signed-off-by: Tomáš Golembiovský --- tests/test-qga.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/test-qga.c b/tests/test-qga.c index c77f241036..631b98639a 100644 --- a/tests

[Qemu-devel] [PATCH v6 3/3] test-qga: add test for guest-get-osinfo

2017-06-29 Thread Tomáš Golembiovský
Add test for guest-get-osinfo command. Qemu-ga was modified to accept QGA_OS_RELEASE environment variable. If the variable is defined it is interpreted as path to the os-release file and it is parsed instead of the default paths. Signed-off-by: Tomáš Golembiovský --- qga/commands-posix.c | 13 +

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: add bdrv_get_format_alloc_stat format interface

2017-06-29 Thread John Snow
On 06/29/2017 02:59 AM, Vladimir Sementsov-Ogievskiy wrote: > 29.06.2017 03:15, John Snow wrote: >> >> Alright, let me see if I have this straight... >> >> used-data: Normal data. We are standing on terra-firma. >> used-zero: Data that is defined to be zeroes in some way. >> >> (Does not necessari

Re: [Qemu-devel] [PATCH v9 06/26] target: [tcg, i386] Port to DisasContextBase

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 14:23:07 +0300, Lluís Vilanova wrote: > Emilio G Cota writes: > > > On Sun, Jun 25, 2017 at 12:07:57 +0300, Lluís Vilanova wrote: > >> Incrementally paves the way towards using the generic instruction > >> translation > >> loop. > >> > >> Signed-off-by: Lluís Vilanova >

[Qemu-devel] [PATCH RFC 4/6] hw/acpi: prepare pci hotplug IO for ich9

2017-06-29 Thread Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index c99dbcc..e434efe 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -135,12 +135,6 @@ stati

[Qemu-devel] [PATCH RFC 2/6] hw/acpi: simplify dsdt building code

2017-06-29 Thread Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 59 +++- 1 file changed, 26 insertions(+), 33 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 6fce967..b0dcd34 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i38

[Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

2017-06-29 Thread Aleksandr Bezzubikov
The series adds hotplug support to legacy PCI buses for Q35 machines. The ACPI hotplug code is emitted if at least one legacy pci-bridge is present. This series is mostly based on past Marcel's series https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg05681.html, but rebased on current mast

[Qemu-devel] [PATCH RFC 1/6] hw/acpi: remove dead acpi code

2017-06-29 Thread Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index afcadac..6fce967 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -1912,16 +1912,6 @@ build_dsdt(GArray *tab

[Qemu-devel] [PATCH RFC 3/6] hw/acpi: fix pcihp io initialization

2017-06-29 Thread Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index b0dcd34..c99dbcc 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acpi-build.c @@ -129,17 +129,18 @@ static vo

[Qemu-devel] [PATCH RFC 6/6] hw/ich9: enable acpi pci hotplug

2017-06-29 Thread Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov --- hw/acpi/ich9.c | 31 +++ hw/isa/lpc_ich9.c | 12 include/hw/acpi/ich9.h | 4 include/hw/i386/pc.h | 7 ++- 4 files changed, 53 insertions(+), 1 deletion(-) diff --git a/hw/acpi/ich9.c b/hw/

[Qemu-devel] [PATCH RFC 5/6] hw/acpi: extend acpi pci hotplug support for pci express

2017-06-29 Thread Aleksandr Bezzubikov
Signed-off-by: Aleksandr Bezzubikov --- hw/i386/acpi-build.c | 47 +++ 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index e434efe..8bbece5 100644 --- a/hw/i386/acpi-build.c +++ b/hw/i386/acp

Re: [Qemu-devel] [PATCH v10 1/7] exec: [tcg] Refactor flush of per-CPU virtual TB cache

2017-06-29 Thread Emilio G. Cota
On Thu, Jun 29, 2017 at 15:17:32 +0300, Lluís Vilanova wrote: > The function is reused in later patches. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson > --- > accel/tcg/cputlb.c|2 +- > accel/tcg/translate-all.c | 15 ++- > include/exec/exec-all.h

Re: [Qemu-devel] [PATCH v10 3/7] trace: [tcg] Delay changes to dynamic state when translating

2017-06-29 Thread Emilio G. Cota
On Thu, Jun 29, 2017 at 15:25:36 +0300, Lluís Vilanova wrote: > This keeps consistency across all decisions taken during translation > when the dynamic state of a vCPU is changed in the middle of translating > some guest code. > > Signed-off-by: Lluís Vilanova > Reviewed-by: Richard Henderson >

Re: [Qemu-devel] [PATCH v10 4/7] exec: [tcg] Use different TBs according to the vCPU's dynamic tracing state

2017-06-29 Thread Emilio G. Cota
On Thu, Jun 29, 2017 at 15:29:38 +0300, Lluís Vilanova wrote: > Every vCPU now uses a separate set of TBs for each set of dynamic > tracing event state values. Each set of TBs can be used by any number of > vCPUs to maximize TB reuse when vCPUs have the same tracing state. > > This feature is late

Re: [Qemu-devel] [PATCH v10 7/7] trace: [trivial] Statically enable all guest events

2017-06-29 Thread Emilio G. Cota
On Thu, Jun 29, 2017 at 15:41:44 +0300, Lluís Vilanova wrote: > The existing optimizations makes it feasible to have them available on all > builds. (snip) > Signed-off-by: Lluís Vilanova > --- > trace-events |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Emilio G.

Re: [Qemu-devel] [PATCH v11 01/29] Pass generic CPUState to gen_intermediate_code()

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:20:42 +0300, Lluís Vilanova wrote: > Needed to implement a target-agnostic gen_intermediate_code() in the > future. > > Signed-off-by: Lluís Vilanova > Reviewed-by: David Gibson > Reviewed-by: Richard Henderson > --- (snip) > -void gen_intermediate_code(CPUAlphaState

Re: [Qemu-devel] [PATCH v11 02/29] cpu-exec: Avoid global variables in icount-related functions

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:24:44 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- (snip) > @@ -62,14 +62,14 @@ static void gen_tb_end(TranslationBlock *tb, int > num_insns) > static inline void gen_io_start(void) > { > TCGv_i32 tmp = tcg_const_i32(1); > -tcg_gen_st_i3

Re: [Qemu-devel] [PATCH v11 03/29] target: [tcg] Use a generic enum for DISAS_ values

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:28:46 +0300, Lluís Vilanova wrote: > Used later. An enum makes expected values explicit and bounds the value space > of > switches. > > Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] TPM status

2017-06-29 Thread Javier Martinez Canillas
On 06/29/2017 06:09 PM, Stefan Berger wrote: > On 06/29/2017 08:39 AM, Javier Martinez Canillas wrote: [snip] >> >>> = TPM backend devices = >>> >>> The TPM implementation is split into two parts. The one part is the hardware >>> interface, such as the TPM TIS interface described earlier, and the

Re: [Qemu-devel] [PATCH RFC 0/6] q35: add acpi pci hotplug support

2017-06-29 Thread Michael S. Tsirkin
On Fri, Jun 30, 2017 at 12:55:56AM +0300, Aleksandr Bezzubikov wrote: > The series adds hotplug support to legacy PCI buses for Q35 machines. > The ACPI hotplug code is emitted if at least one legacy pci-bridge is present. > > This series is mostly based on past Marcel's series > https://lists.gn

Re: [Qemu-devel] [PATCH RFC 3/6] hw/acpi: fix pcihp io initialization

2017-06-29 Thread Michael S. Tsirkin
On Fri, Jun 30, 2017 at 12:55:59AM +0300, Aleksandr Bezzubikov wrote: > Signed-off-by: Aleksandr Bezzubikov Any data on what is wrong with the current code? Pls include this in commit log. > --- > hw/i386/acpi-build.c | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --

Re: [Qemu-devel] [PATCH RFC 1/6] hw/acpi: remove dead acpi code

2017-06-29 Thread Michael S. Tsirkin
On Fri, Jun 30, 2017 at 12:55:57AM +0300, Aleksandr Bezzubikov wrote: > Signed-off-by: Aleksandr Bezzubikov I agree it seems unused. I'm not sure why do we have this code. Igor? > --- > hw/i386/acpi-build.c | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/hw/i386/acpi-build

Re: [Qemu-devel] [PATCH RFC 4/6] hw/acpi: prepare pci hotplug IO for ich9

2017-06-29 Thread Michael S. Tsirkin
On Fri, Jun 30, 2017 at 12:56:00AM +0300, Aleksandr Bezzubikov wrote: > Signed-off-by: Aleksandr Bezzubikov Add more explanation in commit log please. > --- > hw/i386/acpi-build.c | 13 +++-- > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i

Re: [Qemu-devel] [PATCH RFC 5/6] hw/acpi: extend acpi pci hotplug support for pci express

2017-06-29 Thread Michael S. Tsirkin
On Fri, Jun 30, 2017 at 12:56:01AM +0300, Aleksandr Bezzubikov wrote: > Signed-off-by: Aleksandr Bezzubikov Which means what exactly? > --- > hw/i386/acpi-build.c | 47 +++ > 1 file changed, 31 insertions(+), 16 deletions(-) > > diff --git a/hw/i386/

Re: [Qemu-devel] [PATCH RFC 6/6] hw/ich9: enable acpi pci hotplug

2017-06-29 Thread Michael S. Tsirkin
On Fri, Jun 30, 2017 at 12:56:02AM +0300, Aleksandr Bezzubikov wrote: > Signed-off-by: Aleksandr Bezzubikov This commit log is where you describe what works and what doesn't so people can figure it out from git log. > --- > hw/acpi/ich9.c | 31 +++ > hw/isa/l

Re: [Qemu-devel] [PATCH v5 3/5] virtio-9p: break device if buffers are misconfigured

2017-06-29 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 10:44:30PM +0200, Greg Kurz wrote: > The 9P protocol is transport agnostic: if the guest misconfigured the > buffers, the best we can do is to set the broken flag on the device. > > Since virtio_pdu_vmarshal() may be called by several active PDUs, we > check if the transpor

Re: [Qemu-devel] [PATCH v5 2/5] virtio-9p: message header is 7-byte long

2017-06-29 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 10:44:21PM +0200, Greg Kurz wrote: > The 9p spec at http://man.cat-v.org/plan_9/5/intro reads: > > "Each 9P message begins with a four-byte size field specify- > ing the length in bytes of the complete message including > the four bytes of the size field itself. The n

Re: [Qemu-devel] [PATCH v11 05/29] target/i386: [tcg] Port to DisasContextBase

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:36:50 +0300, Lluís Vilanova wrote: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota

Re: [Qemu-devel] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode

2017-06-29 Thread Michael S. Tsirkin
On Wed, Jun 28, 2017 at 07:47:18PM +0100, Stefan Hajnoczi wrote: > This patch series fixes qemu-iotests 068. Since commit > ea4f3cebc4e0224605ab9dd9724aa4e7768fe372 ("qemu-iotests: 068: test iothread > mode") the test case has attempted to use dataplane without -M accel=kvm. > Although QEMU is cap

Re: [Qemu-devel] [RFC v2 3/3] char-socket: Report TCP socket waiting as information

2017-06-29 Thread Alistair Francis
On Thu, Jun 29, 2017 at 1:48 PM, Eric Blake wrote: > On 06/29/2017 02:42 PM, Alistair Francis wrote: >> When QEMU is waiting for a TCP socket connection it reports that message as >> an error. This isn't an error it is just informaiton so let's change the >> report to use report() instead. >> >> S

Re: [Qemu-devel] [PATCH v11 06/29] target/i386: [tcg] Refactor init_disas_context

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:40:52 +0300, Lluís Vilanova wrote: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > --- > target/i386/translate.c | 43 --- > 1 file changed, 24 inserti

Re: [Qemu-devel] [PATCH v11 04/29] target: [tcg] Add generic translation framework

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:32:48 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- > accel/tcg/Makefile.objs |1 > accel/tcg/translator.c| 153 > + > include/exec/gen-icount.h |2 - > include/exec/translator.h | 104 ++

Re: [Qemu-devel] [PATCH v11 07/29] target/i386: [tcg] Refactor init_globals

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:44:54 +0300, Lluís Vilanova wrote: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > --- > target/i386/translate.c | 29 + > 1 file changed, 17 insertions(+), 12 del

Re: [Qemu-devel] [PATCH v11 08/29] target/i386: [tcg] Refactor insn_start

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:48:56 +0300, Lluís Vilanova wrote: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] [PATCH v11 09/29] target/i386: [tcg] Refactor breakpoint_check

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:52:58 +0300, Lluís Vilanova wrote: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > --- > target/i386/translate.c | 59 > ++- > 1 file changed, 48

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: add bdrv_get_format_alloc_stat format interface

2017-06-29 Thread John Snow
On 06/06/2017 12:26 PM, Vladimir Sementsov-Ogievskiy wrote: > The function should collect statistics, about used/unused by top-level > format driver space (in its .file) and allocation status > (data/zero/discarded/after-eof) of corresponding areas in this .file. > > Signed-off-by: Vladimir Seme

[Qemu-devel] [PATCH v3 3/3] tcg/aarch64: Enable indirect jump path using LDR (literal)

2017-06-29 Thread Pranith Kumar
This patch enables the indirect jump path using an LDR (literal) instruction. It will be interesting to test and see which performs better among the two paths. CC: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 42

[Qemu-devel] [PATCH v3 1/3] tcg/aarch64: Introduce and use long branch to register

2017-06-29 Thread Pranith Kumar
We can use a branch to register instruction for exit_tb for offsets greater than 128MB. CC: Alex Bennée Reviewed-by: Richard Henderson Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tcg/aarch64/

[Qemu-devel] [PATCH v3 0/3] Relax code buffer size limitation on aarch64 hosts

2017-06-29 Thread Pranith Kumar
Hello, The following patches enable us to relax the 128MB code buffer size limitation on ARM64 hosts. Patch 2 increases this limitation to 3GB, even though ADRP+ADD can address 4GB of pc-relative addresses to give us some slack. Patch 3 uses LDR (literal) to load the address, allowing us to remo

Re: [Qemu-devel] [PATCH v11 10/29] target/i386: [tcg] Refactor translate_insn

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:57:00 +0300, Lluís Vilanova wrote: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova > --- > target/i386/translate.c | 72 > +++ > 1 file changed, 48

[Qemu-devel] [PATCH v3 2/3] tcg/aarch64: Use ADRP+ADD to compute target address

2017-06-29 Thread Pranith Kumar
We use ADRP+ADD to compute the target address for goto_tb. This patch introduces the NOP instruction which is used to align the above instruction pair so that we can use one atomic instruction to patch the destination offsets. CC: Richard Henderson CC: Alex Bennée Signed-off-by: Pranith Kumar -

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: add bdrv_get_format_alloc_stat format interface

2017-06-29 Thread Eric Blake
On 06/29/2017 07:27 PM, John Snow wrote: > > > On 06/06/2017 12:26 PM, Vladimir Sementsov-Ogievskiy wrote: >> The function should collect statistics, about used/unused by top-level >> format driver space (in its .file) and allocation status >> (data/zero/discarded/after-eof) of corresponding area

Re: [Qemu-devel] [PATCH v11 11/29] target/i386: [tcg] Refactor tb_stop

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 16:01:02 +0300, Lluís Vilanova wrote: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] [PATCH v11 12/29] target/i386: [tcg] Refactor disas_log

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 16:05:04 +0300, Lluís Vilanova wrote: > Incrementally paves the way towards using the generic instruction translation > loop. > > Signed-off-by: Lluís Vilanova Reviewed-by: Emilio G. Cota E.

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: add bdrv_get_format_alloc_stat format interface

2017-06-29 Thread John Snow
On 06/29/2017 08:45 PM, Eric Blake wrote: > On 06/29/2017 07:27 PM, John Snow wrote: >> >> >> On 06/06/2017 12:26 PM, Vladimir Sementsov-Ogievskiy wrote: >>> The function should collect statistics, about used/unused by top-level >>> format driver space (in its .file) and allocation status >>> (da

Re: [Qemu-devel] TPM status

2017-06-29 Thread Stefan Berger
On 06/29/2017 07:12 PM, Javier Martinez Canillas wrote: On 06/29/2017 06:09 PM, Stefan Berger wrote: On 06/29/2017 08:39 AM, Javier Martinez Canillas wrote: [snip] = TPM backend devices = The TPM implementation is split into two parts. The one part is the hardware interface, such as the TPM

Re: [Qemu-devel] [PATCH v11 13/29] target/i386: [tcg] Port to generic translation framework

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 16:09:06 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- Reviewed-by: Emilio G. Cota Tested-by: Emilio G. Cota BTW have you tested icount mode? Minor nits below. > target/i386/translate.c | 120 > +++ >

Re: [Qemu-devel] [Qemu-block] [PATCH v3 1/3] block: add bdrv_get_format_alloc_stat format interface

2017-06-29 Thread Eric Blake
On 06/29/2017 07:54 PM, John Snow wrote: >> Not necessarily an error, if it corresponds to a section that the guest >> has done a TRIM operation on, but where we did not have the means to >> punch a hole in the protocol layer. The semantics of guest TRIM is that >> the data can no longer be reli

Re: [Qemu-devel] [PATCH v11 04/29] target: [tcg] Add generic translation framework

2017-06-29 Thread Emilio G. Cota
On Wed, Jun 28, 2017 at 15:32:48 +0300, Lluís Vilanova wrote: > Signed-off-by: Lluís Vilanova > --- (snip) > /** > * DisasJumpType: > * @DISAS_NEXT: Next instruction in program order. > @@ -33,6 +65,78 @@ typedef enum DisasJumpType { > DISAS_TARGET_9, > DISAS_TARGET_10, > DISAS

Re: [Qemu-devel] [PATCH v22 10/30] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-06-29 Thread Max Reitz
On 2017-06-28 14:05, Vladimir Sementsov-Ogievskiy wrote: > It will be needed in following commits for persistent bitmaps. > If bitmap is loaded from read-only storage (and we can't mark it > "in use" in this storage) corresponding BdrvDirtyBitmap should be > read-only. > > Signed-off-by: Vladimir

Re: [Qemu-devel] [PATCH v22 11/30] qcow2: autoloading dirty bitmaps

2017-06-29 Thread Eric Blake
On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: > Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They > are loaded when the image is opened and become BdrvDirtyBitmaps for the > corresponding drive. > > Extra data in bitmaps is not supported for now. > > Signed-off

Re: [Qemu-devel] [PATCH v22 17/30] block: introduce persistent dirty bitmaps

2017-06-29 Thread Eric Blake
On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: > New field BdrvDirtyBitmap.persistent means, that bitmap should be saved > by format driver in .bdrv_close and .bdrv_inactivate. No format driver > supports it for now. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > --- > block/dirt

Re: [Qemu-devel] [PATCH v22 06/30] block/dirty-bitmap: add deserialize_ones func

2017-06-29 Thread Eric Blake
On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: > Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for > qcow2 bitmap loading, to handle unallocated bitmap parts, marked as > all-ones. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Kevin Wolf > Revie

Re: [Qemu-devel] [PATCH v22 06/30] block/dirty-bitmap: add deserialize_ones func

2017-06-29 Thread Eric Blake
On 06/29/2017 08:55 PM, Eric Blake wrote: > On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: >> Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for >> qcow2 bitmap loading, to handle unallocated bitmap parts, marked as >> all-ones. >> >> + * hbitmap_deserialize_ones >

Re: [Qemu-devel] [PATCH v6 04/10] migration: let MigrationState be a qdev

2017-06-29 Thread Max Reitz
On 2017-06-27 06:10, Peter Xu wrote: > Let the old man "MigrationState" join the object family. Direct benefit > is that we can start to use all the property features derived from > current QDev, like: HW_COMPAT_* bits, command line setup for migration > parameters (so will never need to set them u

Re: [Qemu-devel] [PATCH v22 19/30] qcow2: add persistent dirty bitmaps support

2017-06-29 Thread Eric Blake
On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: > Store persistent dirty bitmaps in qcow2 image. > > Signed-off-by: Vladimir Sementsov-Ogievskiy > Reviewed-by: Max Reitz > --- > block/qcow2-bitmap.c | 475 > +++ > block/qcow2.c

Re: [Qemu-devel] [PATCH v22 19/30] qcow2: add persistent dirty bitmaps support

2017-06-29 Thread Max Reitz
On 2017-06-30 04:18, Eric Blake wrote: > On 06/28/2017 07:05 AM, Vladimir Sementsov-Ogievskiy wrote: >> Store persistent dirty bitmaps in qcow2 image. >> >> Signed-off-by: Vladimir Sementsov-Ogievskiy >> Reviewed-by: Max Reitz >> --- >> block/qcow2-bitmap.c | 475 >>

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Laine Stump
On 06/29/2017 03:44 PM, Alex Williamson wrote: > On Thu, 29 Jun 2017 14:50:15 -0400 > Laine Stump wrote: > >> On 06/28/2017 08:24 PM, Michael Roth wrote: >>> Hi everyone. Hoping to get some feedback on this approach, or some >>> alternatives proposed below, to the following issue: >>> >>> Current

Re: [Qemu-devel] [PATCH v22 00/30] qcow2: persistent dirty bitmaps

2017-06-29 Thread Max Reitz
On 2017-06-28 14:05, Vladimir Sementsov-Ogievskiy wrote: > Hi all! > > There is a new update of qcow2-bitmap series - v22. Thank you for all the work. After resolving some conflicts with the qcow2 LUKS series (and after bisecting some unrelated iotest 055 breakage), I've applied this series to m

Re: [Qemu-devel] [PATCH] iotests: Add test for dataplane mirroring

2017-06-29 Thread Max Reitz
On 2017-06-29 12:10, Kevin Wolf wrote: > Am 29.06.2017 um 01:23 hat Max Reitz geschrieben: >> Signed-off-by: Max Reitz >> --- >> Depends on Stefan's "virtio: use ioeventfd in TCG and qtest mode" series >> to work at all, and on "mirror: Fix inconsistent backing AioContext for >> after mirroring" (

Re: [Qemu-devel] [PATCH v4 1/2] iotests: Use absolute paths for executables

2017-06-29 Thread Max Reitz
On 2017-06-29 20:52, Eric Blake wrote: > On 06/21/2017 08:30 AM, Max Reitz wrote: >> A user may specify a relative path for accessing qemu, qemu-img, etc. >> through environment variables ($QEMU_PROG and friends) or a symlink. >> >> If a test decides to change its working directory, relative paths

Re: [Qemu-devel] [PATCH V3 0/3] COLO-compare: Make COLO-compare support remote COLO-frame

2017-06-29 Thread Zhang Chen
On 06/29/2017 06:36 PM, Dr. David Alan Gilbert wrote: * Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: This series focus on COLO-proxy remote colo-frame support. Xen COLO-frame is the first user. We add a new chardev socket in colo-compare as the way of communicate with remote COLO-frame. A

[Qemu-devel] [PATCH v2] iotests: Add test for dataplane mirroring

2017-06-29 Thread Max Reitz
Signed-off-by: Max Reitz --- v2: - Use test number which (I hope) no currently pending patch is trying to use [Kevin] - Write 42 bytes instead of 64 so it looks less like a mistake - Mark the test as quick (because it is) git-backport-diff output against v1: Key: [] : patches are identica

<    1   2   3   4   5   >