Re: [Qemu-devel] [PATCH v2] Add chardev-send-break monitor command

2017-06-29 Thread Marc-André Lureau
On Tue, Jun 27, 2017 at 9:46 PM Eric Blake wrote: > On 06/11/2017 02:48 AM, Stefan Fritsch wrote: > > Sending a break on a serial console can be useful for debugging the > > guest. But not all chardev backends support sending breaks (only telnet > > and mux do). The chardev-send-break command all

Re: [Qemu-devel] [PATCH V2] monitor: Add -a (all) option to info registers

2017-06-29 Thread Dr. David Alan Gilbert
* Suraj Jitindar Singh (sjitindarsi...@gmail.com) wrote: > The info registers command in the qemu monitor is used to dump register > values. > > Currently this command uses the monitor cpu (which can be set by the > user) as the cpu for whose registers will be dumped. Sometimes it is > useful to s

Re: [Qemu-devel] [PATCH 1/3] travis: install more library dependencies

2017-06-29 Thread Peter Maydell
On 14 June 2017 at 17:49, Paolo Bonzini wrote: > This patch and patch 2 are > useful, but I think I'd rather get full coverage, either with Shippable > or by keeping on doing manual builds, than to rush things and switch to > CI when it's not ready. I agree with this, so is there a path forwards

Re: [Qemu-devel] [PATCH v2 07/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-29 Thread Igor Mammedov
On Thu, 29 Jun 2017 16:10:20 +0300 Roman Kagan wrote: > On Thu, Jun 29, 2017 at 01:53:29PM +0200, Igor Mammedov wrote: > > On Thu, 29 Jun 2017 12:53:27 +0300 > > Roman Kagan wrote: > > > > > On Wed, Jun 28, 2017 at 04:47:43PM +0200, Igor Mammedov wrote: > > > > On Wed, 21 Jun 2017 19:24:08

Re: [Qemu-devel] [PATCH v2] Add chardev-send-break monitor command

2017-06-29 Thread Dr. David Alan Gilbert
* Marc-André Lureau (marcandre.lur...@gmail.com) wrote: > On Tue, Jun 27, 2017 at 9:46 PM Eric Blake wrote: > > > On 06/11/2017 02:48 AM, Stefan Fritsch wrote: > > > Sending a break on a serial console can be useful for debugging the > > > guest. But not all chardev backends support sending break

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2017 05:46 AM, Thomas Huth wrote:>> I figured out MAINTAINERS was unsync, so added patches 1-4, they are not really tci-related. Since they are not related to TCI at all, please submit these as separate series. Ok. Patches 5,6 are trivial fixes to let the codebase quite sane if the

Re: [Qemu-devel] [PATCH v2] Add chardev-send-break monitor command

2017-06-29 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 06/11/2017 02:48 AM, Stefan Fritsch wrote: > > Sending a break on a serial console can be useful for debugging the > > guest. But not all chardev backends support sending breaks (only telnet > > and mux do). The chardev-send-break command allows to send

[Qemu-devel] [PATCH v2 0/5] MAINTAINERS: update TCG/KVM/Xen/TCI/Unimplemented device

2017-06-29 Thread Philippe Mathieu-Daudé
As requested by Thomas Huth, I separated these patches from my previous series "removal of tci (tcg interpreter)". TCG/KVM/Xen/TCI related files were moved in commits a9ded601..244f1441, update MAINTAINERS to match the new paths. Also add an entry for the "Unimplemented" device and voluntary myse

[Qemu-devel] [PATCH v2 2/5] MAINTAINERS: update KVM entries

2017-06-29 Thread Philippe Mathieu-Daudé
moved in 92229a57 to accel/ Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 06006fc7df..86a08c5aac 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -273,8 +273,8 @@ Overall M: Paolo Bonzini

[Qemu-devel] [PATCH v2 1/5] MAINTAINERS: update TCG entries

2017-06-29 Thread Philippe Mathieu-Daudé
moved in a9ded601..244f1441 to accel/ Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 839f7ca063..06006fc7df 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -84,14 +84,10 @@ M: Paolo Bonz

[Qemu-devel] [PATCH v2 3/5] MAINTAINERS: update Xen entries

2017-06-29 Thread Philippe Mathieu-Daudé
moved in 56e2cd24..28b99f47 to hw/xen/ and hw/i386/xen/ Signed-off-by: Philippe Mathieu-Daudé Acked-by: Anthony PERARD --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 86a08c5aac..530293044b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -323,7 +

[Qemu-devel] [PATCH v2 5/5] MAINTAINERS: add entry for "Unimplemented" device

2017-06-29 Thread Philippe Mathieu-Daudé
Also voluntary myself as reviewer Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 9bad523060..890c25f0a1 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1155,6 +1155,13 @@ F: docs/specs/vmgenid.txt F

[Qemu-devel] [PATCH v2 4/5] MAINTAINERS: update TCI entry

2017-06-29 Thread Philippe Mathieu-Daudé
moved in 244f1441 to tcg/ Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 530293044b..9bad523060 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1654,7 +1654,7 @@ TCI target M: Stefan Weil

Re: [Qemu-devel] [Qemu-ppc] [PATCH] target/ppc/cpu-models: set POWER9_v1.0 as POWER9 DD1

2017-06-29 Thread Eric Blake
[meta-comment] On 06/29/2017 01:44 AM, Thomas Huth wrote: ... >> On 22.06.2017 13:26, Laurent Vivier wrote: >>> CPU_POWERPC_POWER9_DD1 is 0x004E0100, so this As a reminder, 14 levels of > quoting is a bit much. It's not only acceptable, but encouraged, to trim replies

Re: [Qemu-devel] [PATCH v2 14/23] hyperv: qom-ify SynIC

2017-06-29 Thread Igor Mammedov
On Wed, 21 Jun 2017 19:24:15 +0300 Roman Kagan wrote: > Make Hyper-V SynIC a device which is attached as a child to X86CPU. For > now it only makes SynIC visibile in the qom hierarchy, and maintains its > internal fields in sync with the respecitve msrs of the parent cpu (the > fields will be us

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Paolo Bonzini
On 29/06/2017 10:46, Thomas Huth wrote: >> Patches 7,8 are the removal, marked RFC... let's debate! > ... but NACK for a direct removal. Common sense is to make obsolete > features as deprecated first and then wait for 2 public releases before > the final removal, so that users still have a chanc

[Qemu-devel] [PATCH v6 2/6] qmp: Create IOThrottle structure

2017-06-29 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Greg Kurz Reviewed-by: Eric Blake --- qapi/blo

[Qemu-devel] [PATCH v6 4/6] hmp: create a throttle initialization function

2017-06-29 Thread Pradeep Jagadeesh
This patch creates a throttle initialization function to maximize the code reusability. The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh --- hmp.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/hmp.c b/hmp.c index 8c72c58..220d301

[Qemu-devel] [PATCH v6 1/6] throttle: factor out duplicate code

2017-06-29 Thread Pradeep Jagadeesh
This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Alberto Garcia --- blockdev.c | 44 +-- fsdev/qemu-fsdev-throttle.c | 44 ++--

Re: [Qemu-devel] [PATCH v3 00/11] make dirty-bitmap byte-based

2017-06-29 Thread Eric Blake
On 06/29/2017 03:28 AM, Vladimir Sementsov-Ogievskiy wrote: > Hi! > > Can we apply my "[PATCH v22 00/30] qcow2: persistent dirty bitmaps" > first? It was already near to the victory a week ago, but I had to > rebase it on new Paolo's patches. Sure, I can rebase on top of yours (I've already rebas

[Qemu-devel] [PATCH v6 0/6] fsdev: qmp interface for io throttling

2017-06-29 Thread Pradeep Jagadeesh
These patches provide the qmp interface, to query the io throttle status of the all fsdev devices that are present in a vm. also, it provides an interface to set the io throttle parameters of a fsdev to a required value. some of the patches also remove the duplicate code that was present in block

[Qemu-devel] [PATCH v6 6/6] fsdev: QMP interface for throttling

2017-06-29 Thread Pradeep Jagadeesh
This patch introduces qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh --- Makefile| 4 +++ fsdev/qemu-fsdev

[Qemu-devel] [PATCH v6 5/6] fsdev: hmp interface for throttling

2017-06-29 Thread Pradeep Jagadeesh
This patch introduces hmp interfaces for the fsdev devices. Signed-off-by: Pradeep Jagadeesh --- hmp-commands-info.hx | 18 ++ hmp-commands.hx | 19 +++ hmp.c| 66 hmp.h| 4 4

Re: [Qemu-devel] [PATCH v1 2/3] arm: fix the armv7m reset state

2017-06-29 Thread Peter Maydell
On 29 June 2017 at 10:28, KONRAD Frederic wrote: > This fixes an odd bug when a ROM is present somewhere and an alias @0x > is pointing to the ROM. The "if (rom)" test fails and we don't get a valid > reset > state. QEMU later crashes with an exception because the ARMv7-M starts with > t

[Qemu-devel] [PATCH 3/6] throttle: move out function to reuse the code

2017-06-29 Thread Pradeep Jagadeesh
This patch move out the throttle code to util/throttle.c to maximize the reusability of the code.The same code is also used by fsdev. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 53 +++- include/qemu/throttle-options.h | 4 +++ util/thr

[Qemu-devel] [PATCH v3] hw/unimp: add missing include

2017-06-29 Thread Philippe Mathieu-Daudé
inlined create_unimplemented_device() calls sysbus_mmio_map_overlap(). Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Eric Blake --- This is a patch from my previous series "various easy cleanups". v3: - Add Eric Blake R-b v2: - Address review feedback from Eric Blake v1: - Add missing i

Re: [Qemu-devel] [PATCH v2 00/23] hyperv fixes and enhancements

2017-06-29 Thread Igor Mammedov
On Wed, 21 Jun 2017 19:24:01 +0300 Roman Kagan wrote: > This series applies miscellaneous fixes and enhancements to Hyper-V > emulation code in QEMU, and lays out the ground for VMBus devices. Series is a big random mix of cleanup/refactoring/new features which is hard to review due to mixed con

Re: [Qemu-devel] [PATCH] ui/cocoa.m: Fix compatibility issue with Mac OS 10.9 and under

2017-06-29 Thread Peter Maydell
On 28 June 2017 at 20:37, Programmingkid wrote: > The [NSEvent modifierFlags] method returns an NSEventModifierFlags type value > in Mac OS 10.10. It use to be of type NSUInteger. Replacing > NSEventModifierFlags with NSUInteger allows for the cooca.m file to be > compiled on older versions of

Re: [Qemu-devel] [PATCH v3] ARM: KVM: Enable in-kernel timers with user space gic

2017-06-29 Thread Peter Maydell
On 27 June 2017 at 16:35, Alexander Graf wrote: > When running with KVM enabled, you can choose between emulating the > gic in kernel or user space. If the kernel supports in-kernel virtualization > of the interrupt controller, it will default to that. If not, if will > default to user space emula

Re: [Qemu-devel] [PATCH v2 4/5] MAINTAINERS: update TCI entry

2017-06-29 Thread Stefan Weil
Am 29.06.2017 um 17:03 schrieb Philippe Mathieu-Daudé: > moved in 244f1441 to tcg/ > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 530293044b..9bad523060 100644 > --- a/MAINTAI

Re: [Qemu-devel] [PATCH 08/11] qed: introduce bdrv_qed_init_state

2017-06-29 Thread Eric Blake
On 06/29/2017 08:27 AM, Paolo Bonzini wrote: > This will be used in the next patch, which will call bdrv_qed_do_open > with a CoMutex taken. bdrv_qed_init_state provides a nice place to > initialize it. > > Signed-off-by: Paolo Bonzini > --- > RFC->v2: new > > block/qed.c | 15

Re: [Qemu-devel] [PATCHv7 0/6] fw_cfg: qdev-related tidy-ups

2017-06-29 Thread Gabriel L. Somlo
On Thu, Jun 29, 2017 at 03:07:14PM +0100, Mark Cave-Ayland wrote: > As part of some ongoing sun4u work, I need to be able to wire the fw_cfg > IO interface to a separate IO space by instantiating the qdev device instead > of calling fw_cfg_init_io(). This patchset brings FW_CFG_IO in line with > FW

Re: [Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-06-29 Thread Igor Mammedov
On Thu, 29 Jun 2017 15:45:04 +0200 Paolo Bonzini wrote: > On 29/06/2017 13:14, Igor Mammedov wrote: > > link's check callback is supposed to verify/permit setting it, > > however currently nothing restricts it from misusing it > > and modifying target object from within. > > Make sure that readon

Re: [Qemu-devel] [RISU PATCH v5 07/13] risu: paramterise send/receive functions

2017-06-29 Thread Alex Bennée
Peter Maydell writes: > On 19 June 2017 at 11:46, Alex Bennée wrote: >> This is a precursor to record/playback support. Instead of passing the >> socket fd we now pass helper functions for reading/writing and >> responding. This will allow us to do the rest of the record/playback >> cleanly out

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Thomas Huth
On 29.06.2017 17:06, Paolo Bonzini wrote: > > > On 29/06/2017 10:46, Thomas Huth wrote: >>> Patches 7,8 are the removal, marked RFC... let's debate! >> ... but NACK for a direct removal. Common sense is to make obsolete >> features as deprecated first and then wait for 2 public releases before >>

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Paolo Bonzini
On 29/06/2017 17:46, Thomas Huth wrote: >> TCI is enabled only with a specific configure argument if your machine >> is not supported by TCG. This would break _build_ configurations, not >> user configurations. It's a remote possibility that users are building >> their own QEMU, with TCI enable

Re: [Qemu-devel] [PATCH v2 1/5] MAINTAINERS: update TCG entries

2017-06-29 Thread Thomas Huth
On 29.06.2017 17:03, Philippe Mathieu-Daudé wrote: > moved in a9ded601..244f1441 to accel/ > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 6 +- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 839f7ca063..06006fc7df 100644

Re: [Qemu-devel] [PATCH v2 2/5] MAINTAINERS: update KVM entries

2017-06-29 Thread Thomas Huth
On 29.06.2017 17:03, Philippe Mathieu-Daudé wrote: > moved in 92229a57 to accel/ > > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 06006fc7df..86a08c5aac 100644 > --- a/MAINTAI

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Thomas Huth
On 29.06.2017 17:47, Paolo Bonzini wrote: > > > On 29/06/2017 17:46, Thomas Huth wrote: >>> TCI is enabled only with a specific configure argument if your machine >>> is not supported by TCG. This would break _build_ configurations, not >>> user configurations. It's a remote possibility that us

Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] block: pass bdrv_* methods to bs->file by default

2017-06-29 Thread Eric Blake
On 06/29/2017 09:05 AM, Stefan Hajnoczi wrote: > On Wed, Jun 28, 2017 at 01:46:15AM +0300, Manos Pitsidianakis wrote: >> The following functions fail if bs->drv does not implement them: >> >> bdrv_probe_blocksizes >> bdrv_probe_geometry >> bdrv_truncate >> bdrv_has_zero_init >> bdrv_get_info >> bdr

Re: [Qemu-devel] [PULL 0/8] 9pfs patches for 2.10 20170629

2017-06-29 Thread Peter Maydell
On 29 June 2017 at 14:43, Greg Kurz wrote: > The following changes since commit 464588675455afda2899e20a0b120e4075de50c7: > > Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170627-tag' > into staging (2017-06-29 11:45:01 +0100) > > are available in the git repository at: > > htt

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Daniel P. Berrange
On Thu, Jun 29, 2017 at 05:46:26PM +0200, Thomas Huth wrote: > On 29.06.2017 17:06, Paolo Bonzini wrote: > > > > > > On 29/06/2017 10:46, Thomas Huth wrote: > >>> Patches 7,8 are the removal, marked RFC... let's debate! > >> ... but NACK for a direct removal. Common sense is to make obsolete > >>

Re: [Qemu-devel] TPM status

2017-06-29 Thread Stefan Berger
On 06/29/2017 08:39 AM, Javier Martinez Canillas wrote: Hello Stefan, Thanks a lot for the summary, it's very informative. I've a question below. On 06/27/2017 06:12 PM, Stefan Berger wrote: QEMU TPM Device === = Guest-side Hardware Interface = The QEMU TPM emulation implements

Re: [Qemu-devel] [PATCH 2/3] scripts/run-coverity-scan: Script to run Coverity Scan build

2017-06-29 Thread Eric Blake
On 06/13/2017 10:54 AM, Peter Maydell wrote: > Add a new script to automate the process of running the Coverity > Scan build tools and uploading the resulting tarball to the > website. This is primarily intended to be driven from Travis, > but it can be run locally (if you are a maintainer of the >

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Peter Maydell
On 29 June 2017 at 17:07, Daniel P. Berrange wrote: > The flipside is that even if we delete it, if someone does suddenly > care, the code is still there in git & easy to undelete again. Given > that we believe there are zero users, it is known broken in many > ways, and TCG provides a working alt

Re: [Qemu-devel] [PATCH 2/3] scripts/run-coverity-scan: Script to run Coverity Scan build

2017-06-29 Thread Peter Maydell
On 29 June 2017 at 17:12, Eric Blake wrote: > Thankfully, I didn't see any bashisms, so you appeared to have stuck to > portable /bin/sh code. My /bin/sh is dash, which catches at least some of the more obvious bashisms. thanks -- PMM

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Thomas Huth
On 29.06.2017 18:07, Daniel P. Berrange wrote: > On Thu, Jun 29, 2017 at 05:46:26PM +0200, Thomas Huth wrote: >> On 29.06.2017 17:06, Paolo Bonzini wrote: >>> >>> >>> On 29/06/2017 10:46, Thomas Huth wrote: > Patches 7,8 are the removal, marked RFC... let's debate! ... but NACK for a direc

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2017 12:47 PM, Paolo Bonzini wrote: On 29/06/2017 17:46, Thomas Huth wrote: TCI is enabled only with a specific configure argument if your machine is not supported by TCG. This would break _build_ configurations, not user configurations. It's a remote possibility that users are buildi

[Qemu-devel] [PATCH] backends: remove empty trace-events file

2017-06-29 Thread Daniel P. Berrange
The content of the backends/trace-events file was entirely removed in commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6 Author: Marc-André Lureau Date: Mon May 29 12:39:42 2017 +0400 char: move char devices to chardev/ Leaving the empty file around, causes tracetool to generate an emp

Re: [Qemu-devel] [PATCH v2 1/3] tcg/aarch64: Introduce and use long branch to register

2017-06-29 Thread Richard Henderson
On 06/29/2017 12:52 AM, Pranith Kumar wrote: We can use a branch to register instruction for exit_tb for offsets greater than 128MB. CC: Richard Henderson CC: Alex Bennée Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 15 +-- 1 file changed, 13 insertions(+), 2 de

Re: [Qemu-devel] [PATCH] backends: remove empty trace-events file

2017-06-29 Thread Eric Blake
On 06/29/2017 11:20 AM, Daniel P. Berrange wrote: > The content of the backends/trace-events file was entirely > removed in > > commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6 > Author: Marc-André Lureau > Date: Mon May 29 12:39:42 2017 +0400 > > char: move char devices to chardev/ >

Re: [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64

2017-06-29 Thread Eric Blake
On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote: > remove some copy/paste leftover, code seems sane. > > > Signed-off-by: Philippe Mathieu-Daudé > > Signed-off-by: Philippe Mathieu-Daudé Double-sob seems odd. > --- > tcg/tci.c | 1 - > 1 file changed, 1 deletion(-) > Otherwise, Revi

[Qemu-devel] [PULL 1/2] monitor: Add -a (all) option to info registers

2017-06-29 Thread Dr. David Alan Gilbert (git)
From: Suraj Jitindar Singh The info registers command in the qemu monitor is used to dump register values. Currently this command uses the monitor cpu (which can be set by the user) as the cpu for whose registers will be dumped. Sometimes it is useful to see the registers for all cpus and curren

[Qemu-devel] [PULL 0/2] hmp queue

2017-06-29 Thread Dr. David Alan Gilbert (git)
/dagrh/qemu.git tags/pull-hmp-20170629 for you to fetch changes up to bd1d5ad9f9a1347d6f4338f294253617c565c89a: Add chardev-send-break monitor command (2017-06-29 17:14:11 +0100)

[Qemu-devel] [PULL 2/2] Add chardev-send-break monitor command

2017-06-29 Thread Dr. David Alan Gilbert (git)
From: Stefan Fritsch Sending a break on a serial console can be useful for debugging the guest. But not all chardev backends support sending breaks (only telnet and mux do). The chardev-send-break command allows to send a break even if using other backends. Signed-off-by: Stefan Fritsch Acked-b

Re: [Qemu-devel] [RFC v1 3/4] util/oslib-win32: Fix up if conditional

2017-06-29 Thread Alistair Francis
On Thu, Jun 29, 2017 at 5:25 AM, Paolo Bonzini wrote: > > > On 28/06/2017 01:57, Alistair Francis wrote: >> Signed-off-by: Alistair Francis >> Acked-by: Edgar E. Iglesias >> --- >> >> util/oslib-win32.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/util/oslib-win32

Re: [Qemu-devel] [Qemu-trivial] [PATCH] backends: remove empty trace-events file

2017-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2017 01:20 PM, Daniel P. Berrange wrote: The content of the backends/trace-events file was entirely removed in commit 6b10e573d15ef82dbc5c5b3726028e6642e134f6 Author: Marc-André Lureau Date: Mon May 29 12:39:42 2017 +0400 char: move char devices to chardev/ Leaving th

Re: [Qemu-devel] [RFC v1 4/4] util/oslib-win32: Recursivly pass the timeout

2017-06-29 Thread Alistair Francis
On Thu, Jun 29, 2017 at 5:34 AM, Paolo Bonzini wrote: > > > On 28/06/2017 01:57, Alistair Francis wrote: >> +/* We only found one and we are waiting on more then one. Let's try >> + * again. >> */ >> -if (timeout == 0 && nhandles > 1) { >> +if (nhandles >

Re: [Qemu-devel] [PATCH v2 2/3] tcg/aarch64: Use ADRP+ADD to compute target address

2017-06-29 Thread Richard Henderson
On 06/29/2017 12:52 AM, Pranith Kumar wrote: We use ADRP+ADD to compute the target address for goto_tb. This patch introduces the NOP instruction which is used to align the above instruction pair so that we can use one atomic instruction to patch the destination offsets. CC: Richard Henderson C

Re: [Qemu-devel] [RFC v1 2/4] util/oslib-win32: Remove invalid check

2017-06-29 Thread Alistair Francis
On Thu, Jun 29, 2017 at 6:32 AM, Paolo Bonzini wrote: > On 28/06/2017 01:57, Alistair Francis wrote: >> There is no way nhandles can be zero in this section so that part of the >> if statement will always be false. Let's just remove it to make the code >> easier to read. >> >> Signed-off-by: Alist

Re: [Qemu-devel] [PATCH v3 3/3] tcg/aarch64: Enable indirect jump path using LDR (literal)

2017-06-29 Thread Richard Henderson
On 06/29/2017 12:52 AM, Pranith Kumar wrote: This patch enables the indirect jump path using an LDR (literal) instruction. It will be interesting to test and see which performs better among the two paths. CC: Richard Henderson CC: Alex Bennée Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-ta

Re: [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64

2017-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2017 01:29 PM, Eric Blake wrote: On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Double-sob seems odd. eh you never know... I need to improve my mailing skills :| --- tcg/tci.c | 1 - 1 file c

Re: [Qemu-devel] [PATCH v1 2/3] arm: fix the armv7m reset state

2017-06-29 Thread KONRAD Frederic
On 06/29/2017 05:14 PM, Peter Maydell wrote: On 29 June 2017 at 10:28, KONRAD Frederic wrote: This fixes an odd bug when a ROM is present somewhere and an alias @0x is pointing to the ROM. The "if (rom)" test fails and we don't get a valid reset state. QEMU later crashes with an excep

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Stefan Weil
Am 29.06.2017 um 17:47 schrieb Paolo Bonzini: > > > On 29/06/2017 17:46, Thomas Huth wrote: >>> TCI is enabled only with a specific configure argument if your machine >>> is not supported by TCG. This would break _build_ configurations, not >>> user configurations. It's a remote possibility tha

Re: [Qemu-devel] [PATCH v1 2/3] arm: fix the armv7m reset state

2017-06-29 Thread Peter Maydell
On 29 June 2017 at 17:41, KONRAD Frederic wrote: > On 06/29/2017 05:14 PM, Peter Maydell wrote: >> This is awkward, because in the "we have a ROM but it's not been >> copied into memory yet" case, the only thing we have is the >> rom->addr, which is the address which the user's ROM blob said >> it

Re: [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64

2017-06-29 Thread Stefan Weil
Am 29.06.2017 um 18:29 schrieb Eric Blake: > On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote: >> remove some copy/paste leftover, code seems sane. >> > >> >> Signed-off-by: Philippe Mathieu-Daudé >> >> Signed-off-by: Philippe Mathieu-Daudé > > Double-sob seems odd. Maybe that double SOB c

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Peter Maydell
On 29 June 2017 at 17:45, Stefan Weil wrote: > TCI was never meant to be used for production, so I think > my approach was acceptable. I think perhaps this is at the root of some of the difference in perspective here -- I tend to the view that given that QEMU is a production codebase, we should n

Re: [Qemu-devel] TPM status

2017-06-29 Thread Stefan Berger
On 06/29/2017 10:07 AM, Javier Martinez Canillas wrote: Hello Stefan, On 06/28/2017 10:57 PM, Stefan Berger wrote: On 06/28/2017 12:44 PM, Laszlo Ersek wrote: On 06/28/17 17:22, Peter Jones wrote: On Tue, Jun 27, 2017 at 12:12:50PM -0400, Stefan Berger wrote: [snip] To support measurements

Re: [Qemu-devel] [PULL 0/8] 9pfs patches for 2.10 20170629

2017-06-29 Thread Greg Kurz
On Thu, 29 Jun 2017 17:00:51 +0100 Peter Maydell wrote: > On 29 June 2017 at 14:43, Greg Kurz wrote: > > The following changes since commit 464588675455afda2899e20a0b120e4075de50c7: > > > > Merge remote-tracking branch 'remotes/sstabellini/tags/xen-20170627-tag' > > into staging (2017-06-29 1

Re: [Qemu-devel] [PATCH RESEND 5/8] tcg/tci: enable bswap16_i64

2017-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2017 01:52 PM, Stefan Weil wrote: Am 29.06.2017 um 18:29 schrieb Eric Blake: On 06/28/2017 08:02 PM, Philippe Mathieu-Daudé wrote: remove some copy/paste leftover, code seems sane. Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Double-sob seems od

Re: [Qemu-devel] [RFC 00/15] Error API: Flag errors in *errp even if errors are being ignored

2017-06-29 Thread Eduardo Habkost
On Thu, Jun 29, 2017 at 03:18:05PM +0100, Daniel P. Berrange wrote: > On Thu, Jun 29, 2017 at 03:39:58PM +0200, Paolo Bonzini wrote: > > On 28/06/2017 11:05, Markus Armbruster wrote: > > > If foo() additionally returned an indication of success, you could write > > > > > > if (!foo(arg, errp

Re: [Qemu-devel] [PATCH v4 1/7] target/m68k: add fscc.

2017-06-29 Thread Richard Henderson
On 06/28/2017 01:42 PM, Laurent Vivier wrote: use DisasCompare with FPU conditions in fscc and fbcc. Signed-off-by: Laurent Vivier --- target/m68k/translate.c | 210 ++-- 1 file changed, 131 insertions(+), 79 deletions(-) Reviewed-by: Richard Hend

[Qemu-devel] [PATCH v1 1/3] util/aio-win32: Only select on what we are actually waiting for

2017-06-29 Thread Alistair Francis
Signed-off-by: Alistair Francis Acked-by: Edgar E. Iglesias --- Changes since RFC: - Include more bitmasks for the select call util/aio-win32.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/util/aio-win32.c b/util/aio-win32.c index bca496a47a..d6d5e02f00 10

[Qemu-devel] [PATCH v1 0/3] Windows runtime improvements

2017-06-29 Thread Alistair Francis
Changes since RFC: - Remove controversial timeout increate patch (util/oslib-win32: Recursivly pass the timeout) from the series - Small adjustments based on comments - Change from RFC to patch series Original cover letter: At Xilinx we have started to run our fork of QEMU on Windows and ar

[Qemu-devel] [PATCH v1 3/3] util/oslib-win32: Remove if conditional

2017-06-29 Thread Alistair Francis
The original ready < nhandles - 1 can be re-written as ready + 1 < nhandles which is the same confition that we are checking on the first itteration of the for loop. This means we can remove the if statement and let the for loop check the code. This also has the side effect of removing an invalid

[Qemu-devel] [PATCH v1 2/3] util/oslib-win32: Remove invalid check

2017-06-29 Thread Alistair Francis
There is no way nhandles can be zero in this section so that part of the if statement will always be false. Let's just remove it to make the code easier to read. Signed-off-by: Alistair Francis Acked-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Fam Zheng --- util/os

Re: [Qemu-devel] [PATCH v1 1/3] util/aio-win32: Only select on what we are actually waiting for

2017-06-29 Thread Philippe Mathieu-Daudé
On 06/29/2017 02:16 PM, Alistair Francis wrote: Signed-off-by: Alistair Francis Acked-by: Edgar E. Iglesias Reviewed-by: Philippe Mathieu-Daudé --- Changes since RFC: - Include more bitmasks for the select call util/aio-win32.c | 13 ++--- 1 file changed, 10 insertions(+), 3

Re: [Qemu-devel] [PATCH v2 07/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-29 Thread Roman Kagan
On Thu, Jun 29, 2017 at 04:39:00PM +0200, Igor Mammedov wrote: > On Thu, 29 Jun 2017 16:10:20 +0300 > Roman Kagan wrote: > > > On Thu, Jun 29, 2017 at 01:53:29PM +0200, Igor Mammedov wrote: > > > On Thu, 29 Jun 2017 12:53:27 +0300 > > > Roman Kagan wrote: > > > > > > > On Wed, Jun 28, 2017 at

Re: [Qemu-devel] [RFC 00/15] Error API: Flag errors in *errp even if errors are being ignored

2017-06-29 Thread Daniel P. Berrange
On Thu, Jun 29, 2017 at 02:09:39PM -0300, Eduardo Habkost wrote: > On Thu, Jun 29, 2017 at 03:18:05PM +0100, Daniel P. Berrange wrote: > > On Thu, Jun 29, 2017 at 03:39:58PM +0200, Paolo Bonzini wrote: > > > On 28/06/2017 11:05, Markus Armbruster wrote: > > > > If foo() additionally returned an ind

Re: [Qemu-devel] [RFC 00/15] Error API: Flag errors in *errp even if errors are being ignored

2017-06-29 Thread Eduardo Habkost
On Thu, Jun 29, 2017 at 06:38:50PM +0100, Daniel P. Berrange wrote: > On Thu, Jun 29, 2017 at 02:09:39PM -0300, Eduardo Habkost wrote: > > On Thu, Jun 29, 2017 at 03:18:05PM +0100, Daniel P. Berrange wrote: > > > On Thu, Jun 29, 2017 at 03:39:58PM +0200, Paolo Bonzini wrote: > > > > On 28/06/2017 1

Re: [Qemu-devel] [PATCH v2 14/23] hyperv: qom-ify SynIC

2017-06-29 Thread Roman Kagan
On Thu, Jun 29, 2017 at 05:05:46PM +0200, Igor Mammedov wrote: > On Wed, 21 Jun 2017 19:24:15 +0300 > Roman Kagan wrote: > > +static void synic_realize(DeviceState *dev, Error **errp) > > +{ > > +Object *obj = OBJECT(dev); > > +SynICState *synic = SYNIC(dev); > > + > > +synic->cpu = X8

Re: [Qemu-devel] [PATCH v2 00/23] hyperv fixes and enhancements

2017-06-29 Thread Roman Kagan
On Thu, Jun 29, 2017 at 05:20:30PM +0200, Igor Mammedov wrote: > On Wed, 21 Jun 2017 19:24:01 +0300 > Roman Kagan wrote: > > > This series applies miscellaneous fixes and enhancements to Hyper-V > > emulation code in QEMU, and lays out the ground for VMBus devices. > > Series is a big random mix

[Qemu-devel] [PATCH] specs: Describe the TPM support in QEMU

2017-06-29 Thread Stefan Berger
This patch adds a description of the current TPM support in QEMU to the specs. Several public specs are referenced via their landing page on the trustedcomputinggroup.org website. Signed-off-by: Stefan Berger --- docs/specs/tpm.txt | 98 ++ 1

Re: [Qemu-devel] [RFC 00/15] Error API: Flag errors in *errp even if errors are being ignored

2017-06-29 Thread Daniel P. Berrange
On Thu, Jun 29, 2017 at 02:47:34PM -0300, Eduardo Habkost wrote: > On Thu, Jun 29, 2017 at 06:38:50PM +0100, Daniel P. Berrange wrote: > > On Thu, Jun 29, 2017 at 02:09:39PM -0300, Eduardo Habkost wrote: > > > On Thu, Jun 29, 2017 at 03:18:05PM +0100, Daniel P. Berrange wrote: > > > > On Thu, Jun 2

Re: [Qemu-devel] [PATCH] specs: Describe the TPM support in QEMU

2017-06-29 Thread Eric Blake
On 06/29/2017 01:00 PM, Stefan Berger wrote: > This patch adds a description of the current TPM support in QEMU > to the specs. > > Several public specs are referenced via their landing page on the > trustedcomputinggroup.org website. > > Signed-off-by: Stefan Berger > --- > docs/specs/tpm.txt

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Stefan Weil
Am 29.06.2017 um 03:02 schrieb Philippe Mathieu-Daudé: > There have been some comments on the ML about the usefulness of tci. > > https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg04551.html > > Peter Maydell> I'd prefer we just got rid of it. > > https://lists.nongnu.org/archive/htm

Re: [Qemu-devel] [PATCH] specs: Describe the TPM support in QEMU

2017-06-29 Thread Stefan Berger
On 06/29/2017 02:07 PM, Eric Blake wrote: On 06/29/2017 01:00 PM, Stefan Berger wrote: This patch adds a description of the current TPM support in QEMU to the specs. Several public specs are referenced via their landing page on the trustedcomputinggroup.org website. Signed-off-by: Stefan Berge

[Qemu-devel] disas: Disassembler disagrees with translator over instruction decoding

2017-06-29 Thread Philippe Mathieu-Daudé
I got this "Disassembler disagrees with translator over instruction decoding" message asking to get reported here. What happens here is coreboot incorrectly emits a Pentium2 instruction while I'm running qemu with a Pentium cpu. I didn't know what to expect but got this error message, then qem

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Michael Roth
Quoting Daniel P. Berrange (2017-06-29 03:33:19) > On Wed, Jun 28, 2017 at 07:24:55PM -0500, Michael Roth wrote: > > Hi everyone. Hoping to get some feedback on this approach, or some > > alternatives proposed below, to the following issue: > > > > Currently libvirt immediately attempts to rebind

Re: [Qemu-devel] disas: Disassembler disagrees with translator over instruction decoding

2017-06-29 Thread Peter Maydell
On 29 June 2017 at 19:20, Philippe Mathieu-Daudé wrote: > I got this "Disassembler disagrees with translator over instruction > decoding" message asking to get reported here. > > What happens here is coreboot incorrectly emits a Pentium2 instruction while > I'm running qemu with a Pentium cpu. I d

[Qemu-devel] [PATCH v2 0/3] block: block driver callbacks fixes

2017-06-29 Thread Manos Pitsidianakis
This series makes implementing some of the bdrv_* callbacks easier for block drivers by passing requests to bs->file if bs->drv doesn't implement it instead of failing, and adding default bdrv_co_get_block_status() implementations. This is based against Kevin Wolf's block branch, commit 0dd2ec6bc4

[Qemu-devel] [PATCH v2 2/3] block: use defaults of bdrv_* callbacks in raw

2017-06-29 Thread Manos Pitsidianakis
Now that passing the call to bs->file is the default for some bdrv_* callbacks, remove the duplicate implementations in block/raw-format.c Signed-off-by: Manos Pitsidianakis --- block/raw-format.c | 32 +--- 1 file changed, 1 insertion(+), 31 deletions(-) diff --git

[Qemu-devel] [PATCH v2 1/3] block: pass bdrv_* methods to bs->file by default

2017-06-29 Thread Manos Pitsidianakis
The following functions fail if bs->drv does not implement them: bdrv_probe_blocksizes bdrv_probe_geometry bdrv_truncate bdrv_has_zero_init bdrv_get_info bdrv_media_changed bdrv_eject bdrv_lock_medium bdrv_co_ioctl Instead, the call should be passed to bs->file if it exists, to allow filter drive

Re: [Qemu-devel] [PATCH v2 1/6] nbd/server: nbd_negotiate: return 1 on NBD_OPT_ABORT

2017-06-29 Thread Eric Blake
On 06/21/2017 10:34 AM, Vladimir Sementsov-Ogievskiy wrote: > Separate case when client sent NBD_OPT_ABORT from other errors. Commit messages are best written in imperative tense (you can supply an implicit "apply this patch in order to" prefix in front of the message, and it should still generall

[Qemu-devel] [PATCH v2 3/3] block: add default implementations for bdrv_co_get_block_status()

2017-06-29 Thread Manos Pitsidianakis
bdrv_co_get_block_status_from_file() and bdrv_co_get_block_status_from_backing() set *file to bs->file and bs->backing respectively, so that bdrv_co_get_block_status() can recurse to them. Future block drivers won't have to duplicate code to implement this. Reviewed-by: Stefan Hajnoczi Signed-off

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Laine Stump
On 06/28/2017 08:24 PM, Michael Roth wrote: > Hi everyone. Hoping to get some feedback on this approach, or some > alternatives proposed below, to the following issue: > > Currently libvirt immediately attempts to rebind a managed device back to the > host driver when it receives a DEVICE_DELETED

Re: [Qemu-devel] [PATCH v4 1/2] iotests: Use absolute paths for executables

2017-06-29 Thread Eric Blake
On 06/21/2017 08:30 AM, Max Reitz wrote: > A user may specify a relative path for accessing qemu, qemu-img, etc. > through environment variables ($QEMU_PROG and friends) or a symlink. > > If a test decides to change its working directory, relative paths will > cease to work, however. Work around t

Re: [Qemu-devel] [RFC 00/29] postcopy+vhost-user/shared ram

2017-06-29 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (git) (dgilb...@redhat.com) wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is a RFC/WIP series that enables postcopy migration > with shared memory to a vhost-user process. > It's based off current-head + Juan's load_cleanup series, and > Alexey's bitmap series

[Qemu-devel] [PATCH] softfloat: define floatx80_default_inf

2017-06-29 Thread Laurent Vivier
Signed-off-by: Laurent Vivier --- fpu/softfloat-specialize.h | 10 ++ fpu/softfloat.c| 38 ++ include/fpu/softfloat.h| 8 +++- 3 files changed, 43 insertions(+), 13 deletions(-) diff --git a/fpu/softfloat-specialize.h b/fpu/softflo

Re: [Qemu-devel] [RFC PATCH 1/3] vmstate: error hint for failed equal checks

2017-06-29 Thread Eric Blake
On 06/14/2017 08:51 AM, Halil Pasic wrote: [apologies for the delayed response, and also adding Markus] >> >> One reason I choose error_report_err is to be consistent about hint >> reporting (the other one is that was what Connie suggested). I do >> not understand why do we omit hints if QMP, bu

<    1   2   3   4   5   >