Re: [Qemu-devel] [PATCH v1] s390x/cpumodel: allow to enable "idtes" feature for TCG

2017-06-29 Thread Thomas Huth
On 28.06.2017 19:02, David Hildenbrand wrote: > On 28.06.2017 16:21, Thomas Huth wrote: >> On 27.06.2017 18:10, David Hildenbrand wrote: >>> STFL bit 4 and 5 are just indications to the guest, which TLB entries an >>> IDTE call will clear. These are performance indicators for the guest. >>> >>> STF

[Qemu-devel] [PATCH 0/2] Pending MTTCG patches

2017-06-29 Thread Pranith Kumar
Hello, Please find these two pending MTTCG fixes I have in my repo. I've reworked the async_safe_* patch according to pbonzini's suggestion. Thanks, Pranith Kumar (2): Revert "exec.c: Fix breakpoint invalidation race" mttcg/i386: Patch instruction using async_safe_* framework exec.c

[Qemu-devel] [PATCH v3 1/2] Revert "exec.c: Fix breakpoint invalidation race"

2017-06-29 Thread Pranith Kumar
Now that we have proper locking after MTTCG patches have landed, we can revert the commit. This reverts commit a9353fe897ca2687e5b3385ed39e3db3927a90e0. CC: Peter Maydell CC: Alex Bennée Signed-off-by: Pranith Kumar --- exec.c | 25 +++-- 1 file changed, 19 insertions(+),

[Qemu-devel] [PATCH v3 2/2] mttcg/i386: Patch instruction using async_safe_* framework

2017-06-29 Thread Pranith Kumar
In mttcg, calling pause_all_vcpus() during execution from the generated TBs causes a deadlock if some vCPU is waiting for exclusive execution in start_exclusive(). Fix this by using the aync_safe_* framework instead of pausing vcpus for patching instructions. CC: Paolo Bonzini CC: Peter Maydell

Re: [Qemu-devel] [Qemu-block] [RFC] QMP design: Fixing query-block and friends

2017-06-29 Thread Markus Armbruster
John Snow writes: > On 06/28/2017 03:15 AM, Markus Armbruster wrote: >> John Snow writes: >> >>> On 06/27/2017 12:31 PM, Kevin Wolf wrote: Hi, I haven't really liked query-block for a long time, but now that blockdev-add and -blockdev have settled, it might finally be the ti

Re: [Qemu-devel] [PATCH v6 3/4] net/net: Convert parse_host_port() to Error

2017-06-29 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Jun 28, 2017 at 09:24:58AM -0500, Eric Blake wrote: >> On 06/28/2017 08:23 AM, Daniel P. Berrange wrote: >> > On Wed, Jun 28, 2017 at 09:08:49PM +0800, Mao Zhongyi wrote: >> >> diff --git a/include/qemu/sockets.h b/include/qemu/sockets.h >> >> index 5c326db.

Re: [Qemu-devel] [PATCH v6 4/4] net/socket: Improve -net socket error reporting

2017-06-29 Thread Markus Armbruster
Mao Zhongyi writes: > Hi, Daniel > > On 06/28/2017 09:27 PM, Daniel P. Berrange wrote: >> On Wed, Jun 28, 2017 at 09:08:50PM +0800, Mao Zhongyi wrote: >>> When -net socket fails, it first reports a specific error, then >>> a generic one, like this: >>> >>> $ qemu-system-x86_64 -net socket, >>

Re: [Qemu-devel] [RFC v1 2/3] util/qemu-error: Add a warning_report() function

2017-06-29 Thread Markus Armbruster
"Daniel P. Berrange" writes: > On Wed, Jun 28, 2017 at 09:16:45AM -0700, Alistair Francis wrote: >> On Wed, Jun 28, 2017 at 2:04 AM, Daniel P. Berrange >> wrote: >> > On Tue, Jun 27, 2017 at 01:45:45PM -0700, Alistair Francis wrote: >> >> Add a functino which can be used similarly to error_repo

Re: [Qemu-devel] [PATCH v6 6/8] vmdk: New functions to assist allocating multiple clusters

2017-06-29 Thread Ashijeet Acharya
On Tue, Jun 27, 2017 at 1:32 PM, Fam Zheng wrote: > On Mon, 06/05 13:22, Ashijeet Acharya wrote: >> +/* >> + * vmdk_handle_alloc >> + * >> + * Allocate new clusters for an area that either is yet unallocated or >> needs a >> + * copy on write. If *cluster_offset is non_zero, clusters are only >>

[Qemu-devel] [PATCH v2 0/3] Relax code buffer size limitation on aarch64 hosts

2017-06-29 Thread Pranith Kumar
Hello, The following patches enable us to relax the 128MB code buffer size limitation on ARM64 hosts. Patch 2 increases this limitation to 3GB, even though ADRP+ADD can address 4GB of pc-relative addresses to give us some slack. Patch 3 uses LDR (literal) to load the address, allowing us to remo

[Qemu-devel] [PATCH v2 2/3] tcg/aarch64: Use ADRP+ADD to compute target address

2017-06-29 Thread Pranith Kumar
We use ADRP+ADD to compute the target address for goto_tb. This patch introduces the NOP instruction which is used to align the above instruction pair so that we can use one atomic instruction to patch the destination offsets. CC: Richard Henderson CC: Alex Bennée Signed-off-by: Pranith Kumar -

[Qemu-devel] [PATCH v3 3/3] tcg/aarch64: Enable indirect jump path using LDR (literal)

2017-06-29 Thread Pranith Kumar
This patch enables the indirect jump path using an LDR (literal) instruction. It will be interesting to test and see which performs better among the two paths. CC: Richard Henderson CC: Alex Bennée Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 42 -

[Qemu-devel] [PATCH v2 1/3] tcg/aarch64: Introduce and use long branch to register

2017-06-29 Thread Pranith Kumar
We can use a branch to register instruction for exit_tb for offsets greater than 128MB. CC: Richard Henderson CC: Alex Bennée Signed-off-by: Pranith Kumar --- tcg/aarch64/tcg-target.inc.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tcg/aarch64/tcg-targe

Re: [Qemu-devel] [RFC PATCH 00/14] Implement network booting directly into the s390-ccw BIOS

2017-06-29 Thread Thomas Huth
On 28.06.2017 17:02, Viktor Mihajlovski wrote: > On 28.06.2017 12:56, Thomas Huth wrote: >> On 28.06.2017 10:02, Thomas Huth wrote: >>> On 28.06.2017 09:28, Viktor Mihajlovski wrote: On 27.06.2017 23:40, Thomas Huth wrote: [...] >>> - Is it OK to require loading an .INS file first? Or

Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type

2017-06-29 Thread Laurent Vivier
Le 28/06/2017 à 22:44, Khem Raj a écrit : > The ucontext_t type had a tag struct ucontext until now > but newer glibc will drop it so we need to adjust and use > the exposed type instead I didn't find in glib git tree the commit dropping the struct tags for ucontext. Could you point it out? Thank

[Qemu-devel] [PATCH v2 0/7] qdev: Introduce DEFINE_PROP_LINK

2017-06-29 Thread Fam Zheng
v2: Create a new header for link properties. [Paolo] Don't wrap, use PropertyInfo.create() (much better diffstat, yay!). [Paolo] Link properties of devices created with object_property_add_link() are not reflected in HMP "info qtree". For example, whether a virtio-blk device has an iothrea

[Qemu-devel] [PATCH v2 2/7] qom: Handle property lookup failure in object_resolve_link

2017-06-29 Thread Fam Zheng
Since we have made object_set_link_property a public function, it is possible that it will be called with a nonexistent property name. Let's survive this error case and report error to avoid segfault in the future. Signed-off-by: Fam Zheng --- qom/object.c | 5 - 1 file changed, 4 insertion

[Qemu-devel] [PATCH v2 6/7] virtio-scsi: Use DEFINE_PROP_LINK

2017-06-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/scsi/virtio-scsi-dataplane.c | 2 +- hw/scsi/virtio-scsi.c | 15 --- hw/virtio/virtio-pci.c | 2 -- include/hw/virtio/virtio-scsi.h | 2 +- 4 files changed, 6 insertions(+), 15 deletions(-) diff --git a/hw/scsi/virtio-scsi-datapla

[Qemu-devel] [PATCH v2 3/7] qdev: Introduce PropertyInfo.create

2017-06-29 Thread Fam Zheng
This allows property implementation to provide a specialized property creation method. Update conditions guarding property types accordingly. Signed-off-by: Fam Zheng --- hw/core/qdev.c | 31 +++ include/hw/qdev-core.h | 1 + 2 files changed, 20 insertions(+

[Qemu-devel] [PATCH v2 1/7] qom: Make link property API public

2017-06-29 Thread Fam Zheng
The get/set pair and the struct will be reused by qdev link prop, make them public. Signed-off-by: Fam Zheng --- include/qom/link-property.h | 31 +++ qom/object.c| 19 +++ 2 files changed, 38 insertions(+), 12 deletions(-) create mode

[Qemu-devel] [PATCH v2 4/7] qdev: Introduce DEFINE_PROP_LINK

2017-06-29 Thread Fam Zheng
This property can be used to replace the object_property_add_link in device code, to add a link to other objects, which is a common pattern. Signed-off-by: Fam Zheng --- hw/core/qdev-properties.c| 16 include/hw/qdev-core.h | 5 + include/hw/qdev-properties.h | 11

[Qemu-devel] [PATCH v2 5/7] virtio-blk: Use DEFINE_PROP_LINK

2017-06-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/block/dataplane/virtio-blk.c | 2 +- hw/block/virtio-blk.c | 7 +++ hw/virtio/virtio-pci.c | 2 -- include/hw/virtio/virtio-blk.h | 2 +- 4 files changed, 5 insertions(+), 8 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/blo

[Qemu-devel] [PATCH v2 7/7] virtio-rng: Use DEFINE_PROP_LINK

2017-06-29 Thread Fam Zheng
Signed-off-by: Fam Zheng --- hw/virtio/virtio-pci.c | 2 -- hw/virtio/virtio-rng.c | 16 include/hw/virtio/virtio-rng.h | 2 +- 3 files changed, 5 insertions(+), 15 deletions(-) diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c index eb03ba5..0938db4

Re: [Qemu-devel] [RFC PATCH 00/14] Implement network booting directly into the s390-ccw BIOS

2017-06-29 Thread Viktor Mihajlovski
On 29.06.2017 09:58, Thomas Huth wrote: > On 28.06.2017 17:02, Viktor Mihajlovski wrote: >> On 28.06.2017 12:56, Thomas Huth wrote: >>> On 28.06.2017 10:02, Thomas Huth wrote: On 28.06.2017 09:28, Viktor Mihajlovski wrote: > On 27.06.2017 23:40, Thomas Huth wrote: > [...] - Is

Re: [Qemu-devel] [PATCH v6 3/3] migration: add bitmap for received page

2017-06-29 Thread Alexey
On Thu, Jun 29, 2017 at 11:28:02AM +0800, Peter Xu wrote: > On Wed, Jun 28, 2017 at 08:49:32AM -0400, Alexey Perevalov wrote: > > [...] > > > @@ -2324,8 +2352,14 @@ static int ram_load_setup(QEMUFile *f, void *opaque) > > [1] > > > > > static int ram_load_cleanup(void *opaque) > > { > > +

Re: [Qemu-devel] [RFC PATCH 00/14] Implement network booting directly into the s390-ccw BIOS

2017-06-29 Thread Thomas Huth
On 28.06.2017 10:59, Thomas Huth wrote: > On 28.06.2017 09:43, Christian Borntraeger wrote: >> Interesting work, thanks for giving it a ry. >> >> On 06/27/2017 01:48 PM, Thomas Huth wrote: >>> It's already possible to do a network boot of an s390x guest with an >>> external netboot image (based on

Re: [Qemu-devel] [PATCH v2] xenfb: remove xen_init_display "temporary" hack

2017-06-29 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 28 June 2017 19:37 > To: xen-de...@lists.xenproject.org; qemu-devel@nongnu.org > Cc: sstabell...@kernel.org; peter.mayd...@linaro.org; Anthony Perard > ; kra...@redhat.com; Paul Durrant > > Subject: [PA

Re: [Qemu-devel] [PATCH v3 00/11] make dirty-bitmap byte-based

2017-06-29 Thread Vladimir Sementsov-Ogievskiy
Hi! Can we apply my "[PATCH v22 00/30] qcow2: persistent dirty bitmaps" first? It was already near to the victory a week ago, but I had to rebase it on new Paolo's patches. 28.06.2017 20:55, Eric Blake wrote: There are patches floating around to add NBD_CMD_BLOCK_STATUS, but NBD wants to rep

Re: [Qemu-devel] [PATCH 1/6] libqos: fix typo in virtio.h QVirtQueue->used comment

2017-06-29 Thread Fam Zheng
On Wed, 06/28 19:47, Stefan Hajnoczi wrote: > Signed-off-by: Stefan Hajnoczi > --- > tests/libqos/virtio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/libqos/virtio.h b/tests/libqos/virtio.h > index 3397a08..829de5e 100644 > --- a/tests/libqos/virtio.h > +++ b/

Re: [Qemu-devel] [RFC PATCH 0/5] hotplug: fix premature rebinding of VFIO devices to host

2017-06-29 Thread Daniel P. Berrange
On Wed, Jun 28, 2017 at 07:24:55PM -0500, Michael Roth wrote: > Hi everyone. Hoping to get some feedback on this approach, or some > alternatives proposed below, to the following issue: > > Currently libvirt immediately attempts to rebind a managed device back to the > host driver when it receives

Re: [Qemu-devel] [RFC PATCH 7/8] tcg/tci: time to remove it :(

2017-06-29 Thread Daniel P. Berrange
On Wed, Jun 28, 2017 at 10:02:59PM -0300, Philippe Mathieu-Daudé wrote: > "./configure --disable-tcg-interpreter" generates a warning: > ./configure: --disable-tcg-interpreter is obsolete, Experimental TCG > interpreter has been removed" > > "./configure --enable-tcg-interpreter" generates an e

Re: [Qemu-devel] [PATCH 2/6] libqos: add virtio used ring support

2017-06-29 Thread Fam Zheng
On Wed, 06/28 19:47, Stefan Hajnoczi wrote: > Existing tests do not touch the virtqueue used ring. Instead they poll > the virtqueue ISR register and peek into their request's device-specific > status field. > > It turns out that the virtqueue ISR register can be set to 1 more than > once for a s

Re: [Qemu-devel] [RFC PATCH 00/14] Implement network booting directly into the s390-ccw BIOS

2017-06-29 Thread Christian Borntraeger
On 06/29/2017 10:17 AM, Thomas Huth wrote: > On 28.06.2017 10:59, Thomas Huth wrote: >> On 28.06.2017 09:43, Christian Borntraeger wrote: >>> Interesting work, thanks for giving it a ry. >>> >>> On 06/27/2017 01:48 PM, Thomas Huth wrote: It's already possible to do a network boot of an s390x g

Re: [Qemu-devel] [PATCH 3/6] tests: fix virtio-scsi-test ISR dependence

2017-06-29 Thread Fam Zheng
On Wed, 06/28 19:47, Stefan Hajnoczi wrote: > Use the new used ring APIs instead of assuming ISR being set means the > request has completed. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng

Re: [Qemu-devel] Getting rid of xen_init_display() (and its dubious call into main_loop_wait())

2017-06-29 Thread Paul Durrant
> -Original Message- > From: Stefano Stabellini [mailto:sstabell...@kernel.org] > Sent: 28 June 2017 19:20 > To: Peter Maydell > Cc: Stefano Stabellini ; QEMU Developers de...@nongnu.org>; Anthony Perard ; Gerd > Hoffmann ; Paul Durrant ; > xen-de...@lists.xenproject.org > Subject: Re: Ge

Re: [Qemu-devel] [RFC PATCH 0/8] removal of tci (tcg interpreter)

2017-06-29 Thread Thomas Huth
Hi Philippe, On 29.06.2017 03:02, Philippe Mathieu-Daudé wrote: > There have been some comments on the ML about the usefulness of tci. > > https://lists.nongnu.org/archive/html/qemu-devel/2017-06/msg04551.html > > Peter Maydell> I'd prefer we just got rid of it. > > https://lists.nongnu.org/

Re: [Qemu-devel] [PATCH v6 7/8] vmdk: Update metadata for multiple clusters

2017-06-29 Thread Ashijeet Acharya
On Tue, Jun 27, 2017 at 1:34 PM, Fam Zheng wrote: > On Mon, 06/05 13:22, Ashijeet Acharya wrote: >> @@ -1876,6 +1942,13 @@ static int vmdk_pwritev(BlockDriverState *bs, >> uint64_t offset, >> offset += n_bytes; >> bytes_done += n_bytes; >> >> +while (m_data->next != NULL

Re: [Qemu-devel] [PATCH 4/6] tests: fix virtio-blk-test ISR dependence

2017-06-29 Thread Fam Zheng
On Wed, 06/28 19:47, Stefan Hajnoczi wrote: > Use the new used ring APIs instead of assuming ISR being set means the > request has completed. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH 5/6] tests: fix virtio-net-test ISR dependence

2017-06-29 Thread Fam Zheng
On Wed, 06/28 19:47, Stefan Hajnoczi wrote: > Use the new used ring APIs instead of assuming ISR being set means the > request has completed. > > Signed-off-by: Stefan Hajnoczi Reviewed-by: Fam Zheng

Re: [Qemu-devel] [PATCH 6/6] virtio-pci: use ioeventfd even when KVM is disabled

2017-06-29 Thread Fam Zheng
On Wed, 06/28 19:47, Stefan Hajnoczi wrote: > Old kvm.ko versions only supported a tiny number of ioeventfds so > virtio-pci avoids ioeventfds when kvm_has_many_ioeventfds() returns 0. > > Do not check kvm_has_many_ioeventfds() when KVM is disabled since it > always returns 0. Since commit 8c56c1

Re: [Qemu-devel] [PATCH] replace struct ucontext with ucontext_t type

2017-06-29 Thread Peter Maydell
On 28 June 2017 at 21:44, Khem Raj wrote: > The ucontext_t type had a tag struct ucontext until now > but newer glibc will drop it so we need to adjust and use > the exposed type instead If true this seems like a bug in glibc to break existing working programs, and it should be fixed there... th

Re: [Qemu-devel] [PATCH v5 3/5] virtio-9p: break device if buffers are misconfigured

2017-06-29 Thread Greg Kurz
On Wed, 28 Jun 2017 22:44:30 +0200 Greg Kurz wrote: > The 9P protocol is transport agnostic: if the guest misconfigured the > buffers, the best we can do is to set the broken flag on the device. > > Since virtio_pdu_vmarshal() may be called by several active PDUs, we > check if the transport isn

[Qemu-devel] [Bug 1700380] Re: commit snapshot image got Permission denied error

2017-06-29 Thread Thomas Huth
Closing, according to comment #2 ** Changed in: qemu Status: New => Invalid -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1700380 Title: commit snapshot image got Permission denied error S

Re: [Qemu-devel] [RFC v1 1/4] util/aio-win32: Only select on what we are actually waiting for

2017-06-29 Thread Fam Zheng
On Tue, 06/27 16:57, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Acked-by: Edgar E. Iglesias > --- > > util/aio-win32.c | 13 ++--- > 1 file changed, 10 insertions(+), 3 deletions(-) > > diff --git a/util/aio-win32.c b/util/aio-win32.c > index bca496a47a..949979c2f5 100

[Qemu-devel] [PATCH v7 1/8] vmdk: Move vmdk_find_offset_in_cluster() to the top

2017-06-29 Thread Ashijeet Acharya
Move the existing vmdk_find_offset_in_cluster() function to the top of the driver. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index a9bd22b..22

[Qemu-devel] [PATCH v7 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-06-29 Thread Ashijeet Acharya
Previously posted series patches: v1 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg02044.html v2 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg05080.html v3 - http://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg00074.html v4 - http://lists.nongnu.org/archive/htm

[Qemu-devel] [PATCH v7 7/8] vmdk: Update metadata for multiple clusters

2017-06-29 Thread Ashijeet Acharya
Include a next pointer in VmdkMetaData struct to point to the previous allocated L2 table. Modify vmdk_L2update to start updating metadata for allocation of multiple clusters at once. Signed-off-by: Ashijeet Acharya --- block/vmdk.c | 128 ++---

[Qemu-devel] [PATCH v7 2/8] vmdk: Rename get_whole_cluster() to vmdk_perform_cow()

2017-06-29 Thread Ashijeet Acharya
Rename the existing function get_whole_cluster() to vmdk_perform_cow() as its sole purpose is to perform COW for the first and the last allocated clusters if needed. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 23 ++- 1 file changed, 14 insertio

[Qemu-devel] [PATCH v7 3/8] vmdk: Rename get_cluster_offset() to vmdk_get_cluster_offset()

2017-06-29 Thread Ashijeet Acharya
Rename the existing get_cluster_offset() to vmdk_get_cluster_offset() and update name in all the callers accordingly. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) d

[Qemu-devel] [PATCH v7 6/8] vmdk: New functions to assist allocating multiple clusters

2017-06-29 Thread Ashijeet Acharya
Introduce two new helper functions handle_alloc() and vmdk_alloc_cluster_offset(). handle_alloc() helps to allocate multiple clusters at once starting from a given offset on disk and performs COW if necessary for first and last allocated clusters. vmdk_alloc_cluster_offset() helps to return the off

[Qemu-devel] [PATCH v7 4/8] vmdk: Factor out metadata loading code out of vmdk_get_cluster_offset()

2017-06-29 Thread Ashijeet Acharya
Move the cluster tables loading code out of the existing vmdk_get_cluster_offset() function and implement it in separate get_cluster_table() and vmdk_l2load() functions. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 153 ---

[Qemu-devel] [PATCH v7 5/8] vmdk: Set maximum bytes allocated in one cycle

2017-06-29 Thread Ashijeet Acharya
Set the maximum bytes allowed to get allocated at once to be not more than the extent size boundary to handle writes at two separate extents appropriately. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-

[Qemu-devel] [PATCH v1 1/3] add memory_region_get_offset_within_address_space

2017-06-29 Thread KONRAD Frederic
This is helpful in the next patch to know if a rom is pointed by an alias. Signed-off-by: KONRAD Frederic --- include/exec/memory.h | 10 ++ memory.c | 22 -- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/include/exec/memory.h b/include/

[Qemu-devel] [PATCH v1 3/3] armv7m_systick: abort instead of locking on a bad rate

2017-06-29 Thread KONRAD Frederic
This helps the board developer by asserting that system_clock_rate is not null. Using systick with a zero rate will lead to a deadlock so better showing the error. Signed-off-by: KONRAD Frederic --- hw/timer/armv7m_systick.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/timer/armv7m_

[Qemu-devel] [PATCH v7 8/8] vmdk: Make vmdk_get_cluster_offset() return cluster offset only

2017-06-29 Thread Ashijeet Acharya
vmdk_alloc_clusters() introduced earlier now handles the task of allocating clusters and performing COW when needed. Thus we can change vmdk_get_cluster_offset() to stick to the sole purpose of returning cluster offset using sector number. Update the changes at all call sites. Signed-off-by: Ashij

Re: [Qemu-devel] [RFC v1 2/4] util/oslib-win32: Remove invalid check

2017-06-29 Thread Fam Zheng
On Tue, 06/27 16:57, Alistair Francis wrote: > There is no way nhandles can be zero in this section so that part of the > if statement will always be false. Let's just remove it to make the code > easier to read. > > Signed-off-by: Alistair Francis > Acked-by: Edgar E. Iglesias > --- > > util/

[Qemu-devel] [PATCH v1 0/3] Some armv7m fixes

2017-06-29 Thread KONRAD Frederic
Hi, While playing with armv7m, I found two little bugs: - When there is an alias @0x to a flash memory the cpu state isn't reset correctly which leads later to an exception as ARM instruction-set is used. Presumably this bug might be present with the netduino2 board. - If the d

[Qemu-devel] [PATCH v1 2/3] arm: fix the armv7m reset state

2017-06-29 Thread KONRAD Frederic
This fixes an odd bug when a ROM is present somewhere and an alias @0x is pointing to the ROM. The "if (rom)" test fails and we don't get a valid reset state. QEMU later crashes with an exception because the ARMv7-M starts with the ARM instruction set. (eg: PC & 0x01 is 0). This patch uses

Re: [Qemu-devel] [RFC v1 3/4] util/oslib-win32: Fix up if conditional

2017-06-29 Thread Fam Zheng
On Tue, 06/27 16:57, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Acked-by: Edgar E. Iglesias > --- > > util/oslib-win32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/oslib-win32.c b/util/oslib-win32.c > index 7ec0f8e083..a015e1ac96 100644 > ---

Re: [Qemu-devel] [RFC v1 4/4] util/oslib-win32: Recursivly pass the timeout

2017-06-29 Thread Fam Zheng
On Tue, 06/27 16:57, Alistair Francis wrote: > Signed-off-by: Alistair Francis > Acked-by: Edgar E. Iglesias > --- > > util/oslib-win32.c | 21 + > 1 file changed, 17 insertions(+), 4 deletions(-) > > diff --git a/util/oslib-win32.c b/util/oslib-win32.c > index a015e1ac96..

[Qemu-devel] [PATCH v7 0/4] Improve error reporting

2017-06-29 Thread Mao Zhongyi
v7: * PATCH 01 -fix the error message.[Daniel P. Berrange] -adjust the Indentation problem.[Eric Blake] * PATCH 03 -print a generic message when gethostbyname() failed in parse_host_port(), drop the misleading ": unkonwn host" part.[Markus Armbruster] v6: * PATCH 02 -rename

[Qemu-devel] [PATCH v7 3/4] net/net: Convert parse_host_port() to Error

2017-06-29 Thread Mao Zhongyi
Cc: berra...@redhat.com Cc: kra...@redhat.com Cc: pbonz...@redhat.com Cc: jasow...@redhat.com Cc: arm...@redhat.com Cc: ebl...@redhat.com Signed-off-by: Mao Zhongyi --- include/qemu/sockets.h | 3 ++- net/net.c | 22 +- net/socket.c | 19 ++-

[Qemu-devel] [PATCH v7 2/4] net/socket: Convert several helper functions to Error

2017-06-29 Thread Mao Zhongyi
Currently, net_socket_mcast_create(), net_socket_fd_init_dgram() and net_socket_fd_init() use the function such as fprintf(), perror() to report an error message. Now, convert these functions to Error. Cc: jasow...@redhat.com Cc: arm...@redhat.com Cc: berra...@redhat.com Signed-off-by: Mao Zhongy

[Qemu-devel] [PATCH v7 4/4] net/socket: Improve -net socket error reporting

2017-06-29 Thread Mao Zhongyi
When -net socket fails, it first reports a specific error, then a generic one, like this: $ qemu-system-x86_64 -net socket, qemu-system-x86_64: -net socket: exactly one of fd=, listen=, connect=, mcast= or udp= is required qemu-system-x86_64: -net socket: Device 'socket' could not be

[Qemu-devel] [PATCH v7 1/4] net/socket: Don't treat odd socket type as SOCK_STREAM

2017-06-29 Thread Mao Zhongyi
In net_socket_fd_init(), the 'default' case is odd: it warns, then continues as if the socket type was SOCK_STREAM. The comment explains "this could be a eg. a pty", but that makes no sense. If @fd really was a pty, getsockopt() would fail with ENOTSOCK. If @fd was a socket, but neither SOCK_DGRAM

Re: [Qemu-devel] SPARC64 supported processors

2017-06-29 Thread Artyom Tarasenko
Hi Pasha, On Tue, Jun 27, 2017 at 7:59 PM, Pasha Tatashin wrote: > Hi, > > I am trying to evaluate the current qemu support for sparc64 processors. > First, it seems -smp is not supported for any processor, is this correct? > When I set -smp greater than 1, I am getting: > > qemu-system-sparc64:

Re: [Qemu-devel] [PATCH 0/6] virtio: use ioeventfd in TCG and qtest mode

2017-06-29 Thread Kevin Wolf
Am 28.06.2017 um 21:38 hat Eric Blake geschrieben: > On 06/28/2017 01:47 PM, Stefan Hajnoczi wrote: > > This patch series fixes qemu-iotests 068. Since commit > > ea4f3cebc4e0224605ab9dd9724aa4e7768fe372 ("qemu-iotests: 068: test iothread > > mode") the test case has attempted to use dataplane wit

Re: [Qemu-devel] [PATCH v5 1/5] throttle: factor out duplicate code

2017-06-29 Thread Pradeep Jagadeesh
On 6/22/2017 4:38 PM, Markus Armbruster wrote: Pradeep Jagadeesh writes: This patch factor out the duplicate throttle code that was present in block and fsdev devices. Signed-off-by: Pradeep Jagadeesh --- blockdev.c | 44 +--- fsdev/qemu-

Re: [Qemu-devel] [PATCH v2 07/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-29 Thread Roman Kagan
On Wed, Jun 28, 2017 at 04:47:43PM +0200, Igor Mammedov wrote: > On Wed, 21 Jun 2017 19:24:08 +0300 > Roman Kagan wrote: > > > Hyper-V identifies vCPUs by Virtual Processor (VP) index which can be > > queried by the guest via HV_X64_MSR_VP_INDEX msr. It is defined by the > > spec as a sequential

Re: [Qemu-devel] SPARC64 supported processors

2017-06-29 Thread Artyom Tarasenko
Hi Mark, On Thu, Jun 29, 2017 at 8:57 AM, Mark Cave-Ayland wrote: > On 27/06/17 18:59, Pasha Tatashin wrote: > > Hi Pasha, > >> Hi, >> >> I am trying to evaluate the current qemu support for sparc64 processors. >> First, it seems -smp is not supported for any processor, is this >> correct? When

Re: [Qemu-devel] [PATCH v4 11/13] virtio-console: chardev hotswap support

2017-06-29 Thread Marc-André Lureau
Hi Looks good, but please write something in the commit message about what needs to be done for be-change (what this patch does). thanks - Original Message - > Signed-off-by: Anton Nefedov > Reviewed-by: Vladimir Sementsov-Ogievskiy > CC: Amit Shah > --- > hw/char/virtio-console.c |

Re: [Qemu-devel] [PATCH v4 00/13] chardevice hotswap

2017-06-29 Thread Marc-André Lureau
Hi, The series looks good to me. You could try to ping the subsystem maintainers to get their reviews (serial/virtio/hmp). Paolo, would you like to take the series then? thanks - Original Message - > Changed in v4: > - rebased on top of the latest chardev changes > - remarks appli

Re: [Qemu-devel] [PATCH] iotests: Add test for dataplane mirroring

2017-06-29 Thread Kevin Wolf
Am 29.06.2017 um 01:23 hat Max Reitz geschrieben: > Signed-off-by: Max Reitz > --- > Depends on Stefan's "virtio: use ioeventfd in TCG and qtest mode" series > to work at all, and on "mirror: Fix inconsistent backing AioContext for > after mirroring" (in my block branch) so it does not fail. > ---

Re: [Qemu-devel] [PATCH V3 0/3] COLO-compare: Make COLO-compare support remote COLO-frame

2017-06-29 Thread Dr. David Alan Gilbert
* Zhang Chen (zhangchen.f...@cn.fujitsu.com) wrote: > This series focus on COLO-proxy remote colo-frame support. > Xen COLO-frame is the first user. We add a new chardev socket > in colo-compare as the way of communicate with remote COLO-frame. > And remote COLO-frame notify colo-proxy part depend

Re: [Qemu-devel] [PATCH v4 3/5] migration: Create load_setup()/cleanup() methods

2017-06-29 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert" wrote: > > * Juan Quintela (quint...@redhat.com) wrote: > >> We need to do things at load time and at cleanup time. > >> > >> Signed-off-by: Juan Quintela > >> > >> -- > >> > >> Move the printing of the error message so we

Re: [Qemu-devel] [PATCH 3/8] MAINTAINERS: update Xen entry

2017-06-29 Thread Anthony PERARD
On Wed, Jun 28, 2017 at 10:02:55PM -0300, Philippe Mathieu-Daudé wrote: > moved in 56e2cd24..28b99f47 to accel/ That is not accurate, files have been moved to hw/i386/xen/ as written in both commits messages. Beside that: Acked-by: Anthony PERARD > Signed-off-by: Philippe Mathieu-Daudé > --- >

Re: [Qemu-devel] [PATCH v2 4/7] qdev: Introduce DEFINE_PROP_LINK

2017-06-29 Thread Igor Mammedov
On Thu, 29 Jun 2017 16:04:49 +0800 Fam Zheng wrote: > This property can be used to replace the object_property_add_link in > device code, to add a link to other objects, which is a common pattern. > > Signed-off-by: Fam Zheng > --- > hw/core/qdev-properties.c| 16 > includ

Re: [Qemu-devel] [PATCH] linux-user: Put PPC AT_IGNOREPPC auxv entries in the right place

2017-06-29 Thread Peter Maydell
On 27 June 2017 at 19:05, Richard Henderson wrote: > On 06/27/2017 09:49 AM, Peter Maydell wrote: >> >> The 32-bit PPC auxv is a bit complicated because in the >> mists of time it used to be 16-aligned rather than directly >> after the environment. Older glibc versions had code to >> try to probe

[Qemu-devel] [PATCH V2 3/8] block/qcow2: parse compress create options

2017-06-29 Thread Peter Lieven
this adds parsing and validation for the compress create options. They are only validated but not yet used. Signed-off-by: Peter Lieven --- block/qcow2.c | 56 +-- block/qcow2.h | 9 include/block/block_int.h | 2 ++

[Qemu-devel] [PATCH V2 8/8] block/qcow2: add lzo compress format

2017-06-29 Thread Peter Lieven
Signed-off-by: Peter Lieven --- block/qcow2-cluster.c | 15 +++ block/qcow2.c | 26 +- block/qcow2.h | 1 + configure | 2 +- qapi/block-core.json | 14 -- qemu-img.texi | 1 + 6 files changed, 55 insertions(+

[Qemu-devel] [PATCH V2 4/8] qemu-img: add documentation for compress settings

2017-06-29 Thread Peter Lieven
Signed-off-by: Peter Lieven --- qemu-img.texi | 21 + 1 file changed, 21 insertions(+) diff --git a/qemu-img.texi b/qemu-img.texi index 5b925ec..430f0b9 100644 --- a/qemu-img.texi +++ b/qemu-img.texi @@ -621,6 +621,27 @@ file which is COW and has data blocks already, it could

[Qemu-devel] [PATCH V2 0/8] add Qcow2 compress format extension

2017-06-29 Thread Peter Lieven
this adds a create option for Qcow2 images to specify the compression format and level for compressed clusters. The series adds 2 algorithms to choose from: zlib and lzo. zlib is the current default, but with unoptimal settings. If no compress.format option is specified the old zlib with the old pa

[Qemu-devel] [PATCH V2 2/8] qapi: add compress parameters to Qcow2 Blockdev options

2017-06-29 Thread Peter Lieven
Signed-off-by: Peter Lieven --- qapi/block-core.json | 44 +++- 1 file changed, 43 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index f85c223..1574ffb 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@

[Qemu-devel] [PATCH V2 1/8] docs: add compress format extension to qcow2 spec

2017-06-29 Thread Peter Lieven
Signed-off-by: Peter Lieven --- docs/interop/qcow2.txt | 43 ++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt index 80cdfd0..c01daf3 100644 --- a/docs/interop/qcow2.txt +++ b/docs/interop/qcow

[Qemu-devel] [PATCH V2 7/8] block/qcow2: start using the compress format extension

2017-06-29 Thread Peter Lieven
we now pass the parameters to the zlib compressor if the extension is present and use the old default values if the extension is absent. Signed-off-by: Peter Lieven --- block/qcow2-cluster.c | 58 ++- block/qcow2.c | 57

[Qemu-devel] [PATCH V2 6/8] block/qcow2: optimize qcow2_co_pwritev_compressed

2017-06-29 Thread Peter Lieven
if we specify exactly one iov of s->cluster_size bytes we can avoid the bounce buffer. Signed-off-by: Peter Lieven --- block/qcow2.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/block/qcow2.c b/block/qcow2.c index 39a8afc..0a7202a 100644 --- a/block/qcow2.c ++

[Qemu-devel] [PATCH V2 5/8] block/qcow2: read and write the compress format extension

2017-06-29 Thread Peter Lieven
we now read the extension on open and write it on update, but do not yet use it. Signed-off-by: Peter Lieven --- block/qcow2.c | 100 ++ block/qcow2.h | 23 +++--- 2 files changed, 104 insertions(+), 19 deletions(-) diff --git a/b

[Qemu-devel] Questions about GPU passthrough + multiple PCIE switches on host

2017-06-29 Thread Bob Chen
Hi folks, I have 8 GPU cards needed to passthrough to 1 vm. These cards are placed at 2 PCIE switches on host server, in case there might be bandwidth limit within a single bus. So what is the correct QEMU bus parameter if I want to achieve the best performance. The QEMU's pcie.0/1 parameter cou

Re: [Qemu-devel] [PATCH v2 4/7] qdev: Introduce DEFINE_PROP_LINK

2017-06-29 Thread Fam Zheng
On Thu, 06/29 12:40, Igor Mammedov wrote: > On Thu, 29 Jun 2017 16:04:49 +0800 > Fam Zheng wrote: > > > This property can be used to replace the object_property_add_link in > > device code, to add a link to other objects, which is a common pattern. > > > > Signed-off-by: Fam Zheng > > --- > >

[Qemu-devel] [PATCH] qom: enforce readonly nature of link's check callback

2017-06-29 Thread Igor Mammedov
link's check callback is supposed to verify/permit setting it, however currently nothing restricts it from misusing it and modifying target object from within. Make sure that readonly semantics are checked by compiler to prevent callback's misuse. Signed-off-by: Igor Mammedov --- Fam, it probabl

Re: [Qemu-devel] [RISU PATCH v6 00/10] Record/replay patches

2017-06-29 Thread Peter Maydell
On 21 June 2017 at 16:42, Alex Bennée wrote: > Hi Peter, > > Re-based with review comments addressed and tags added where > appropriate. > > Alex Bennée (10): > README: document the coding style used for risu > build-all-archs: support cross building via docker > risu: a bit more verbosity w

Re: [Qemu-devel] [PATCH] block: fix bs->file leak in bdrv_new_open_driver()

2017-06-29 Thread Kevin Wolf
Am 29.06.2017 um 08:03 hat Manos Pitsidianakis geschrieben: > bdrv_open_driver() is called in two places, bdrv_new_open_driver() and > bdrv_open_common(). In the latter, failure cleanup in is in its caller, > bdrv_open_inherit(), which unrefs the bs->file of the failed driver open > if it exists. L

Re: [Qemu-devel] [Qemu-block] [PATCH v4 1/2] live-block-ops.txt: Rename, rewrite, and improve it

2017-06-29 Thread Alberto Garcia
On Wed 28 Jun 2017 10:33:49 PM CEST, Eric Blake wrote: >>> +Disk image backing chain notation >>> +- >> [...] >>> +.. important:: >>> +The base disk image can be raw format; however, all the overlay >>> +files must be of QCOW2 format. >> >> This is not qui

Re: [Qemu-devel] [PATCH v4 3/5] migration: Create load_setup()/cleanup() methods

2017-06-29 Thread Dr. David Alan Gilbert
* Dr. David Alan Gilbert (dgilb...@redhat.com) wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > "Dr. David Alan Gilbert" wrote: > > > * Juan Quintela (quint...@redhat.com) wrote: > > >> We need to do things at load time and at cleanup time. > > >> > > >> Signed-off-by: Juan Quintela > >

Re: [Qemu-devel] [PATCH 3/8] MAINTAINERS: update Xen entry

2017-06-29 Thread Paolo Bonzini
On 29/06/2017 03:02, Philippe Mathieu-Daudé wrote: > moved in 56e2cd24..28b99f47 to accel/ Actually to hw/. I can certainly queue patches 1-4 immediately, thanks. Paolo > Signed-off-by: Philippe Mathieu-Daudé > --- > MAINTAINERS | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/MAINT

Re: [Qemu-devel] [PATCH v2 3/3] tests: Add a tester for HMP commands

2017-06-29 Thread Dr. David Alan Gilbert
* Eric Blake (ebl...@redhat.com) wrote: > On 03/30/2017 02:50 AM, Thomas Huth wrote: > > HMP commands do not get any automatic testing yet, so on certain > > QEMU machines, some HMP commands were causing crashes in the past. > > Thus we should test HMP commands in our test suite, too, to avoid > >

Re: [Qemu-devel] [PATCH v2 4/7] qdev: Introduce DEFINE_PROP_LINK

2017-06-29 Thread Paolo Bonzini
On 29/06/2017 10:04, Fam Zheng wrote: > +#define DEFINE_PROP_LINK(_name, _state, _field, _type, _check, _flags) {\ > +.name = (_name),\ > +.info = &(qdev_prop_link), \ > +.offset = offseto

Re: [Qemu-devel] [PATCH v2 07/23] hyperv: ensure VP index equal to QEMU cpu_index

2017-06-29 Thread Igor Mammedov
On Thu, 29 Jun 2017 12:53:27 +0300 Roman Kagan wrote: > On Wed, Jun 28, 2017 at 04:47:43PM +0200, Igor Mammedov wrote: > > On Wed, 21 Jun 2017 19:24:08 +0300 > > Roman Kagan wrote: > > > > > Hyper-V identifies vCPUs by Virtual Processor (VP) index which can be > > > queried by the guest via H

Re: [Qemu-devel] [PATCH 3/8] MAINTAINERS: update Xen entry

2017-06-29 Thread Philippe Mathieu-Daudé
On Thu, Jun 29, 2017 at 7:39 AM, Anthony PERARD wrote: > On Wed, Jun 28, 2017 at 10:02:55PM -0300, Philippe Mathieu-Daudé wrote: >> moved in 56e2cd24..28b99f47 to accel/ > > That is not accurate, files have been moved to hw/i386/xen/ as written > in both commits messages. Oops hopefully you notic

[Qemu-devel] [PATCH 0/3] Qemu: Add Xen vIOMMU interrupt remapping function support

2017-06-29 Thread Lan Tianyu
This patchset is to deal with MSI interrupt remapping request when guest updates MSI registers. Chao Gao (3): i386/msi: Correct mask of destination ID in MSI address xen-pt: bind/unbind interrupt remapping format MSI msi: Handle remappable format interrupt request configure

  1   2   3   4   5   >