Applied to -trivial, thanks!
/mjt
On 27.06.17 14:37, Andrew Jones wrote:
On Mon, Jun 26, 2017 at 11:30:56PM +0200, Alexander Graf wrote:
When running with KVM enabled, you can choose between emulating the
gic in kernel or user space. If the kernel supports in-kernel virtualization
of the interrupt controller, it will default t
13.06.2017 21:00, Thomas Huth wrote:
> The configure script prefers pkg-config over sdl-config, but
> the "--static-libs" parameter only exists for the latter. With
> pkg-config, "--static --libs" have to be used instead.
Applied to -trivial, thanks!
/mjt
On Mon, Jun 26, 2017 at 07:58:32PM +0300, Manos Pitsidianakis wrote:
> On Mon, Jun 26, 2017 at 03:52:34PM +0100, Stefan Hajnoczi wrote:
> > On Fri, Jun 23, 2017 at 03:46:56PM +0300, Manos Pitsidianakis wrote:
> > > +static bool throttle_group_exists(const char *name)
> > > +{
> > > +ThrottleGro
Applied to -trivial (with commit typo fix), thanks!
/mjt
On Tue, Jun 27, 2017 at 01:45:07AM +0300, Manos Pitsidianakis wrote:
> On Mon, Jun 26, 2017 at 04:44:44PM +0100, Stefan Hajnoczi wrote:
> > On Fri, Jun 23, 2017 at 03:46:59PM +0300, Manos Pitsidianakis wrote:
> > > -void blk_io_limits_disable(BlockBackend *blk)
> > > +void blk_io_limits_disable(Blo
When running with KVM enabled, you can choose between emulating the
gic in kernel or user space. If the kernel supports in-kernel virtualization
of the interrupt controller, it will default to that. If not, if will
default to user space emulation.
Unfortunately when running in user mode gic emulat
On 06/23/2017 07:46 AM, Manos Pitsidianakis wrote:
> This is needed to configure throttle filter driver nodes with QAPI.
>
> Signed-off-by: Manos Pitsidianakis
> ---
> qapi/block-core.json | 19 ++-
> 1 file changed, 18 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/block-co
Am 27.06.2017 um 14:53 schrieb Eric Blake:
On 06/27/2017 07:34 AM, Peter Lieven wrote:
this adds support for optimized zlib settings which almost
Start sentences with a capital.
tripples the compression speed while maintaining about
s/tripples/triples/
the same compressed size.
Signed-off
On Tue, Jun 27, 2017 at 02:34:10PM +0200, Peter Lieven wrote:
> this adds support for optimized zlib settings which almost
> tripples the compression speed while maintaining about
> the same compressed size.
>
> Signed-off-by: Peter Lieven
> ---
> block/qcow2-cluster.c | 3 ++-
> block/qcow2.c
Applied to -trivial, thanks!
/mjt
On Tue, Jun 27, 2017 at 02:34:07PM +0200, Peter Lieven wrote:
> this patch adds a new compression_algorithm option when creating qcow2 images.
> The current default for the compresison algorithm is zlib and zlib will be
> used when this option is omitted (like before).
>
> If the option is specifi
On Tue, Jun 27, 2017 at 03:08:43PM +0200, Alexander Graf wrote:
> When running with KVM enabled, you can choose between emulating the
> gic in kernel or user space. If the kernel supports in-kernel virtualization
> of the interrupt controller, it will default to that. If not, if will
> default to u
Am 27.06.2017 um 15:16 schrieb Daniel P. Berrange:
On Tue, Jun 27, 2017 at 02:34:10PM +0200, Peter Lieven wrote:
this adds support for optimized zlib settings which almost
tripples the compression speed while maintaining about
the same compressed size.
Signed-off-by: Peter Lieven
---
block/q
Am 27.06.2017 um 15:20 schrieb Daniel P. Berrange:
On Tue, Jun 27, 2017 at 02:34:07PM +0200, Peter Lieven wrote:
this patch adds a new compression_algorithm option when creating qcow2 images.
The current default for the compresison algorithm is zlib and zlib will be
used when this option is omit
Applied to trivial, thanks!
/mjt
23.06.2017 19:45, Philippe Mathieu-Daudé wrote:
> fprintf(stderr) is how errors are reported in this file.
Applied to -trivial (with typo fix), thanks!
/mjt
Applied to -trivial, thanks!
/mjt
Applied to -trivial, thanks!
/mjt
On Tue, Jun 27, 2017 at 01:45:40PM +0100, Stefan Hajnoczi wrote:
On Mon, Jun 26, 2017 at 07:26:41PM +0300, Manos Pitsidianakis wrote:
On Mon, Jun 26, 2017 at 03:30:55PM +0100, Stefan Hajnoczi wrote:
> > +bs->file = bdrv_open_child(NULL, options, "file",
> > +
Applied to -trivial, thanks!
/mjt
On Tue, Jun 27, 2017 at 06:15:37AM -0500, Eric Blake wrote:
> On 06/26/2017 11:10 PM, Peter Xu wrote:
> > One less global variable, and it does only matter with migration.
> >
> > We keep the old "--only-migratable" option, but also now we support:
> >
> > -global migration.only-migratable=true
On Tue, Jun 27, 2017 at 03:23:19PM +0200, Peter Lieven wrote:
> Am 27.06.2017 um 15:16 schrieb Daniel P. Berrange:
> > On Tue, Jun 27, 2017 at 02:34:10PM +0200, Peter Lieven wrote:
> > > this adds support for optimized zlib settings which almost
> > > tripples the compression speed while maintainin
23.06.2017 06:17, Li Ping wrote:
> The caller of SetupDiGetClassDevs must delete the returned device information
> set when it is no longer needed by calling SetupDiDestroyDeviceInfoList.
Applied to -trivial, with s/QEMU Guest Agent/qga-win32/ in the Subject.
/mjt
27.06.2017 15:52, Paolo Bonzini wrote:
On 27/06/2017 11:47, Vladimir Sementsov-Ogievskiy wrote:
bdrv_enable_dirty_bitmap - writes to the list, it changes 'disabled'
field. So it requires both BQL and dirty_bitmap_mutex? But the comment
says only about BQL.
This one is interesting. There could
On 27/06/2017 15:51, Vladimir Sementsov-Ogievskiy wrote:
>>>
>>> bdrv_create_dirty_bitmap(...)
>>>
>>> bdrv_dirty_bitmaps_lock(bs)
>>>
>>> bitmap = bdrv_find_dirty_bitmap(bs, name)
>>>
>>>
>>>
>>> bdrv_dirty_bitmaps_unlock(bs)
>>>
>>> - because we can't now trust the pointer returned by
>>> bdr
On Tue, Jun 27, 2017 at 03:00:10PM +0200, Alexander Graf wrote:
> > > +/* XXX PMU IRQ is missing */
> >
> > So I was wondering why you chose not to wire up the PMU in order to finish
>
> Because the PMU IRQ is only available from the machine file, so it'll need
> some more plumbing to get
On Wed, 14 Jun 2017 17:21:06 +0200
Vadim Galitsyn wrote:
> Commands above provide the following memory information in bytes:
>
> * base-memory - amount of static memory specified
> with '-m' option at the start of the QEMU process.
>
> * hot-plug-memory - amount of memory that was hot-p
On 06/27/2017 09:05 AM, Igor Mammedov wrote:
> On Wed, 14 Jun 2017 17:21:06 +0200
> Vadim Galitsyn wrote:
>
>> +void hmp_info_memory(Monitor *mon, const QDict *qdict)
>> +{
>> +Error *err = NULL;
>> +MemoryInfo *info = qmp_query_memory(&err);
>> +if (info) {
>> +monitor_print
27.06.2017 16:58, Paolo Bonzini wrote:
On 27/06/2017 15:51, Vladimir Sementsov-Ogievskiy wrote:
bdrv_create_dirty_bitmap(...)
bdrv_dirty_bitmaps_lock(bs)
bitmap = bdrv_find_dirty_bitmap(bs, name)
bdrv_dirty_bitmaps_unlock(bs)
- because we can't now trust the pointer returned by
bdrv_crea
On 27/06/2017 16:20, Vladimir Sementsov-Ogievskiy wrote:
> I'm likely not right, but for me introducing this mutex looks like dirty
> bitmaps may be accessed from concurrent threads. So for me it looks
> strange that only accessors are protected by the mutex and not the whole
> transactions.
The
On 06/26/17 13:56 +0100, Stefan Hajnoczi wrote:
> On Mon, Jun 26, 2017 at 10:05:01AM +0800, Haozhong Zhang wrote:
> > On 06/23/17 10:55 +0100, Stefan Hajnoczi wrote:
> > > On Fri, Jun 23, 2017 at 08:13:13AM +0800, haozhong.zh...@intel.com wrote:
> > > > On 06/22/17 15:08 +0100, Stefan Hajnoczi wrot
On Tue, Jun 27, 2017 at 03:59:51PM +0200, Andrew Jones wrote:
> On Tue, Jun 27, 2017 at 03:00:10PM +0200, Alexander Graf wrote:
> > > > +/* XXX PMU IRQ is missing */
> > >
> > > So I was wondering why you chose not to wire up the PMU in order to finish
> >
> > Because the PMU IRQ is only
On Tue, Jun 27, 2017 at 05:03:31PM +0800, Peter Xu wrote:
> Patch 1: fixes a very rare PT path issue on iova value. It didn't
> break anything since it's merely not touched (only if when IOMMU
> enabled, then set one device to PT), but still better fix it.
Pls Cc HMP/QMP maintainers on interface p
27.06.2017 17:26, Paolo Bonzini wrote:
On 27/06/2017 16:20, Vladimir Sementsov-Ogievskiy wrote:
I'm likely not right, but for me introducing this mutex looks like dirty
bitmaps may be accessed from concurrent threads. So for me it looks
strange that only accessors are protected by the mutex and
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20170626123510.20134-1-berra...@redhat.com
Type: series
Subject: [Qemu-devel] [PATCH v6 0/5] Improve I/O tests coverage of LUKS driver
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
On Tue, Jun 27, 2017 at 12:10:13PM +0800, Peter Xu wrote:
[...]
> +
> +static const TypeInfo migration_type = {
> +.name = TYPE_MIGRATION,
> +.parent = TYPE_DEVICE,
As TYPE_MIGRATION isn't really a device and we're using TYPE_DEVICE just
to reuse the global property system, maybe we should
On 27/06/2017 16:43, Vladimir Sementsov-Ogievskiy wrote:
>> The write side is invoked under the 'big QEMU lock' so there cannot be
>> two concurrent writes.
>>
>> A bitmap can be written to after bdrv_find_dirty_bitmap returns, but
>> only if _you_ tell another thread about the bitmap you've just
Am 27.06.2017 um 14:49 schrieb Eric Blake:
On 06/27/2017 07:34 AM, Peter Lieven wrote:
this patch adds a new compression_algorithm option when creating qcow2 images.
The current default for the compresison algorithm is zlib and zlib will be
s/compresison/compression/
used when this option is
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH] xsave_helper: pull xsave and xrstor out of kvm.c
into helper function
Type: series
Message-id: 20170626200832.11058-1-sergio.g.delr...@gmail.com
=== TEST SCRIPT BEGIN =
On Tue, 06/27 07:43, no-re...@patchew.org wrote:
> Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
> Traceback (most recent call last):
> File "./patchew-cli", line 430, in test_one
> git_clone_repo(clone, r["repo"], r["head"], logf)
> File "./patchew-cli", line 48, in git_clone_repo
>
On Tue, Jun 27, 2017 at 12:10:10PM +0800, Peter Xu wrote:
[...]
> diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
> index 1e5c928..4ab4359 100644
> --- a/include/hw/qdev-properties.h
> +++ b/include/hw/qdev-properties.h
> @@ -208,6 +208,29 @@ void error_set_from_qdev_prop_e
On Tue, Jun 27, 2017 at 12:10:11PM +0800, Peter Xu wrote:
> Introduce this new field for the accelerator classes so that each
> specific accelerator in the future can register its own global
> properties to be used further by the system. It works just like how the
> old machine compatible propertie
On Tue, Jun 27, 2017 at 12:10:12PM +0800, Peter Xu wrote:
> It's not that clear on how the global properties are registered to
> global_props (and also its priority relationship). Let's provide a
> single function to be called in main() for that, with comment to explain
> it a bit.
>
> Signed-off
On Tue, Jun 27, 2017 at 12:10:13PM +0800, Peter Xu wrote:
> Let the old man "MigrationState" join the object family. Direct benefit
> is that we can start to use all the property features derived from
> current QDev, like: HW_COMPAT_* bits, command line setup for migration
> parameters (so will nev
On 06/27/2017 09:49 AM, Peter Lieven wrote:
>>
>
> Before I continue, can you please give feedback on the following spec
> change:
>
> diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
> index 80cdfd0..f1428e9 100644
> --- a/docs/interop/qcow2.txt
> +++ b/docs/interop/qcow2.txt
> @@ -
On 06/27/2017 09:55 AM, Eduardo Habkost wrote:
>> + *
>> + * The property values set using this function must be always valid and
>> + * never report setter errors, as they property have
>
> Typo (my fault, sorry). It should be "the property have", or "the
> property will have".
>
"the propert
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Subject: [Qemu-devel] [PATCH v2] main_loop: Make main_loop_wait() return void
Message-id: 1498487280-17836-1-git-
On 26.06.2017 20:47, Max Reitz wrote:
On 2017-06-26 17:23, Pavel Butsykin wrote:
[]
Is there any guarantee that in the future this will not change? Because
in this case it can be a potential danger.
Since this behavior is not documented anywhere, there is no guarantee.
I can add a comment.
The 32-bit PPC auxv is a bit complicated because in the
mists of time it used to be 16-aligned rather than directly
after the environment. Older glibc versions had code to
try to probe for whether it needed alignment or not:
https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/p
On 06/27/2017 02:46 AM, Alex Bennée wrote:
Richard Henderson writes:
At the same time, drop the TCGContext argument and use tcg_ctx instead.
Signed-off-by: Richard Henderson
---
tcg/tcg.c | 15 ---
tcg/tcg.h | 7 ++-
2 files changed, 10 insertions(+), 12 deletions(-)
d
Hi,
I haven't really liked query-block for a long time, but now that
blockdev-add and -blockdev have settled, it might finally be the time to
actually do something about it. In fact, if used together with these
modern interfaces, our query commands are simply broken, so we have to
fix something.
Hi Thomas,
This is really interesting :)
On 06/27/2017 07:48 AM, Thomas Huth wrote:
It's already possible to do a network boot of an s390x guest with an
external netboot image (based on a Linux installation), but it would
be much more convenient if the s390-ccw firmware supported network
bootin
On Tue, Jun 27, 2017 at 06:05:55PM +0200, Alberto Garcia wrote:
On Mon 26 Jun 2017 06:58:32 PM CEST, Manos Pitsidianakis wrote:
On Mon, Jun 26, 2017 at 03:52:34PM +0100, Stefan Hajnoczi wrote:
On Fri, Jun 23, 2017 at 03:46:56PM +0300, Manos Pitsidianakis wrote:
+static bool throttle_group_exis
On 23 January 2017 at 02:17, Richard Henderson wrote:
> HPPA is a (the) stack-grows-up target, and supporting that requires
> rearranging how we compute addresses while laying out the initial
> program stack. In addition, hppa32 requires 64-byte stack alignment
> so parameterize that as well.
>
On 06/27/2017 11:31 AM, Kevin Wolf wrote:
> Hi,
>
> I haven't really liked query-block for a long time, but now that
> blockdev-add and -blockdev have settled, it might finally be the time to
> actually do something about it. In fact, if used together with these
> modern interfaces, our query comm
On 06/14/2017 09:51 AM, Laszlo Ersek wrote:
Hi Stefan,
the MAINTAINERS file doesn't seem to cover any of the TPM-related files
in the tree:
backends/tpm.c
hw/tpm/
include/hw/acpi/tpm.h
include/sysemu/tpm*
tpm.c
but I have a gut feeling that you are semi-officially maintaining TP
I find this patch aesthetically very nice :)
On Tue, 27 Jun 2017 00:03:25 +0200
Laurent Vivier wrote:
> fmovecr moves a floating point constant from the
> FPU ROM to a floating point register.
>
> Signed-off-by: Laurent Vivier
> Reviewed-by: Richard Henderson
> ---
> target/m68k/fpu_helper.c
On 06/27/2017 01:57 AM, Alex Bennée wrote:
-/* Note this unsigned test catches TCG_CALL_ARG_DUMMY too. */
-if (arg < nb_globals) {
This test is gone but
-dir = dir_temps[arg];
-if (dir != 0 && temp_state[arg] == TS_DEAD) {
-
On 06/06/2017 07:26 AM, Kevin Wolf wrote:
> Am 05.06.2017 um 22:38 hat Eric Blake geschrieben:
>> I found a crasher and some odd behavior while rebasing my
>> bdrv_get_block_status series, so I figured I'd get these things
>> fixed first. This is based on top of Max's block branch.
>>
>> Available
On 06/27/2017 01:47 AM, Alex Bennée wrote:
Richard Henderson writes:
Signed-off-by: Richard Henderson
---
tcg/tcg.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tcg/tcg.h b/tcg/tcg.h
index 3b35344..6c357e7 100644
--- a/tcg/tcg.h
+++ b/tcg/tcg.h
@@ -730,7 +730,7 @@ e
From: KONRAD Frederic
This introduces a special callback which allows to run code from some MMIO
devices.
SysBusDevice with a MemoryRegion which implements the request_ptr callback will
be notified when the guest try to execute code from their offset. Then it will
be able to eg: pre-load some co
On 23.06.2017 18:05, Aurelien Jarno wrote:
> On 2017-06-19 17:03, Richard Henderson wrote:
>> Changes since v2:
>> * Dropped the enforcement of PGM_OPERATION for insns for
>> which the feature bit is set. There's no agreement on
>> exactly how to do this yet.
>> * Add implementations o
From: KONRAD Frederic
This replaces env1 and page_index variables by env and index
so we can use VICTIM_TLB_HIT macro later.
Reviewed-by: Richard Henderson
Reviewed-by: Edgar E. Iglesias
Signed-off-by: KONRAD Frederic
Signed-off-by: Edgar E. Iglesias
---
accel/tcg/cputlb.c | 18 +---
On 06/27/17 18:12, Stefan Berger wrote:
> On 06/14/2017 09:51 AM, Laszlo Ersek wrote:
>> Hi Stefan,
>>
>> the MAINTAINERS file doesn't seem to cover any of the TPM-related files
>> in the tree:
>>
>>backends/tpm.c
>>hw/tpm/
>>include/hw/acpi/tpm.h
>>include/sysemu/tpm*
>>tpm.c
>
STFL bit 4 and 5 are just indications to the guest, which TLB entries an
IDTE call will clear. These are performance indicators for the guest.
STFL bit 4:
INVALIDATE DAT TABLE ENTRY (IDTE) performs
the invalidation-and-clearing operation by
selectively clearing TLB segment-table entrie
From: KONRAD Frederic
This just moves the code before VICTIM_TLB_HIT macro definition
so we can use it.
Reviewed-by: Richard Henderson
Reviewed-by: Edgar E. Iglesias
Signed-off-by: KONRAD Frederic
Signed-off-by: Edgar E. Iglesias
---
accel/tcg/cputlb.c | 70 +++--
From: KONRAD Frederic
This introduces mmio_interface object which contains a MemoryRegion
and can be hotplugged/hotunplugged.
Reviewed-by: Edgar E. Iglesias
Signed-off-by: KONRAD Frederic
Signed-off-by: Edgar E. Iglesias
---
hw/misc/Makefile.objs| 1 +
hw/misc/mmio_interface.c
On Mon 26 Jun 2017 06:58:32 PM CEST, Manos Pitsidianakis wrote:
> On Mon, Jun 26, 2017 at 03:52:34PM +0100, Stefan Hajnoczi wrote:
>>On Fri, Jun 23, 2017 at 03:46:56PM +0300, Manos Pitsidianakis wrote:
>>> +static bool throttle_group_exists(const char *name)
>>> +{
>>> +ThrottleGroup *iter;
>>>
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 1498554219-4942-1-git-send-email-pet...@redhat.com
Subject: [Qemu-devel] [PATCH 0/8] VT-d: some enhancements on iotlb and tools
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=ba
From: KONRAD Frederic
We need to pass a pointer to a MemoryRegion for mmio_interface.
So this just adds that.
Reviewed-by: Edgar E. Iglesias
Signed-off-by: KONRAD Frederic
Signed-off-by: Edgar E. Iglesias
---
include/hw/qdev-properties.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/
Block driver documentation is available in qemu-doc.html. It would be
convenient to have documentation for formats, protocols, and filter
drivers in a man page.
Extract the relevant part of qemu-doc.html into a new file called
docs/qemu-block-drivers.texi. This file can also be built as a
stand-
On 27.06.2017 13:48, Thomas Huth wrote:
> It's already possible to do a network boot of an s390x guest with an
> external netboot image (based on a Linux installation), but it would
> be much more convenient if the s390-ccw firmware supported network
> booting right out of the box, without the need
On 27.06.2017 13:48, Thomas Huth wrote:
> To be able to use some more advanced libc functions in the s390-ccw
> firmware, like printf() and malloc(), we need a better libc here.
> This patch adds the C library from the SLOF firmware (taken from
> the SLOF commit ID 62674aabe20612a9786fa03e87cf6916b
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/sheepdog.c | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/block/sheepdog.c b/block/sheepdog.c
index 08d7b11e9d..a6013f0f17 100644
--- a/block/sheepdog.c
+++ b/block/sheepdog.c
@@ -390,
From: KONRAD Frederic
This allows to execute from the lqspi area.
When the request_ptr is called the device loads 1024bytes from the SPI device.
Then this code can be executed by the guest.
Tested-by: Edgar E. Iglesias
Reviewed-by: Edgar E. Iglesias
Signed-off-by: KONRAD Frederic
Signed-off-
27.06.2017 17:26, Paolo Bonzini wrote:
On 27/06/2017 16:20, Vladimir Sementsov-Ogievskiy wrote:
I'm likely not right, but for me introducing this mutex looks like dirty
bitmaps may be accessed from concurrent threads. So for me it looks
strange that only accessors are protected by the mutex and
On 06/27/2017 01:39 AM, Alex Bennée wrote:
+/* If true, the temp is saved across both basic blocks and
+ translation blocks. */
+unsigned int temp_global:1;
+/* If true, the temp is saved across basic blocks but dead
+ at the end of translation blocks. If false, the temp
From: "Edgar E. Iglesias"
Hi,
Paolo suggested offline that we send a pull request for this series.
Here it is, I've run it through my testsuite + tested the LQSPI testcase
on Zynq.
Cheers,
Edgar
ChangeLog:
v1 -> v2:
* Add EI RB line to patch #6
* Remove changelogs from commit messages
* Add E
On Fri, Jun 23, 2017 at 11:54:52AM +0100, Peter Maydell wrote:
> On 14 June 2017 at 18:45, Edgar E. Iglesias wrote:
> > From: "Edgar E. Iglesias"
> >
> > Hi,
> >
> > Paolo suggested offline that we send a pull request for this series.
> > Here it is, I've run it through my testsuite + tested the
Haozhong Zhang wrote:
Hi
I am trying to see what is going on.
>>
>
> I managed to reproduce this bug. After bisect between good v2.8.0 and
> bad edf8bc984, it looks a regression introduced by
> 6b6712efccd "ram: Split dirty bitmap by RAMBlock"
> This commit may result in guest crash
27.06.2017 18:31, Vladimir Sementsov-Ogievskiy wrote:
27.06.2017 17:26, Paolo Bonzini wrote:
On 27/06/2017 16:20, Vladimir Sementsov-Ogievskiy wrote:
I'm likely not right, but for me introducing this mutex looks like
dirty
bitmaps may be accessed from concurrent threads. So for me it looks
st
This will let the callback take a CoMutex in the next patch.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/io.c| 42 +-
block/qed.c | 6 +++---
include/block/block_int.h | 2 +-
3 files changed, 37 ins
On 27.06.2017 13:48, Thomas Huth wrote:
> It's already possible to do a network boot of an s390x guest with an
> external netboot image (based on a Linux installation), but it would
> be much more convenient if the s390-ccw firmware supported network
> booting right out of the box, without the need
Anyone can explain what is the blocking problem for this target to be pulled
upstream?
I apologize for bothering but I don't have the workflow clear in my mind.
thanks,
Anichang
> Original Message
> Subject: Re: [PATCH RFC v19 00/13] QEMU AVR 8 bit cores
> Local Time: June 22, 2
The coroutine may run in a different AioContext, causing the
fd handler to busy wait. Fix this by resetting the handler
in restart_coroutine, before the coroutine is restarted.
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/ssh.c | 24 +---
1 file chang
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/vpc.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/block/vpc.c b/block/vpc.c
index 4240ba9d1c..0ff686540a 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -496,
On 06/22/2017 07:17 AM, Stefan Hajnoczi wrote:
> Block driver documentation is available in qemu-doc.html. It would be
> convenient to have documentation for formats, protocols, and filter
> drivers in a man page.
>
> Extract the relevant part of qemu-doc.html into a new file called
> docs/qemu-b
The VirtualBox driver is using a mutex to order all allocating writes,
but it is not protecting accesses to the bitmap because they implicitly
happen under the AioContext mutex. Change this to use a CoRwlock
explicitly.
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo B
On 27/06/2017 17:32, Vladimir Sementsov-Ogievskiy wrote:
- we protect inserting into list from other threads, but what prevent
creating bitmap with the same name from other thread after
bdrv_find_dirty_bitmap() and before bdrv_dirty_bitmaps_lock() ?
>>> It's like a read-w
These functions are more efficient in the presence of contention.
qemu_co_rwlock_downgrade also guarantees not to block, which may
be useful in some algorithms too.
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
include/qemu/coroutine.h | 18 +++
Am 27.06.2017 um 17:04 schrieb Eric Blake:
On 06/27/2017 09:49 AM, Peter Lieven wrote:
Before I continue, can you please give feedback on the following spec
change:
diff --git a/docs/interop/qcow2.txt b/docs/interop/qcow2.txt
index 80cdfd0..f1428e9 100644
--- a/docs/interop/qcow2.txt
+++ b/doc
Richard Henderson writes:
> On 06/25/2017 01:59 AM, Lluís Vilanova wrote:
[...]
>> +
>> +/* Early exit before breakpoint checks */
>> +if (unlikely(db->is_jmp != DJ_NEXT)) {
>> +break;
>> +}
> This must be done at the end of the loop, not at the beginning of th
On Mon, Jun 26, 2017 at 11:28 AM, Peter Maydell
wrote:
...
On Tue, Jun 27, 2017 at 12:06 PM, wrote:
36h in the queue?
> /tmp/qemu-test/src/tests/test-char.c: In function ‘main_loop’:
> /tmp/qemu-test/src/tests/test-char.c:29: error: void value not ignored as it
> ought to be
Reviewed-by: Eric Blake
Reviewed-by: Stefan Hajnoczi
Signed-off-by: Paolo Bonzini
---
block/qcow2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/qcow2.c b/block/qcow2.c
index 2f94f0326e..70d3f4a18e 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -1741,8 +1741,
From: KONRAD Frederic
get_page_addr_code(..) does a cpu_ldub_code to fill the tlb:
This can lead to some side effects if a device is mapped at this address.
So this patch replaces the cpu_memory_ld by a tlb_fill.
Reviewed-by: Richard Henderson
Reviewed-by: Edgar E. Iglesias
Signed-off-by: KON
On Mon, Jun 26, 2017 at 12:12:18PM -0700, Stefano Stabellini wrote:
> On Mon, 26 Jun 2017, Jan Beulich wrote:
> > >>> Stefano Stabellini 06/23/17 8:43 PM >>>
> > >On Fri, 23 Jun 2017, Jan Beulich wrote:
> > >> >>> On 22.06.17 at 20:52, wrote:
> > >> > I am happy to write the code and/or the commi
Aurélien or Peter, could you ACK this one?
Thanks,
Laurent
Le 27/06/2017 à 00:03, Laurent Vivier a écrit :
> Add a function to round a floatx80 to the defined precision
> (floatx80_rounding_precision)
>
> Signed-off-by: Laurent Vivier
> Reviewed-by: Richard Henderson
> ---
> fpu/softfloat.c
On 27 June 2017 at 17:59, Philippe Mathieu-Daudé
wrote:
> On Mon, Jun 26, 2017 at 11:28 AM, Peter Maydell
> wrote:
> ...
> On Tue, Jun 27, 2017 at 12:06 PM, wrote:
>> /tmp/qemu-test/src/tests/test-char.c: In function ‘main_loop’:
>> /tmp/qemu-test/src/tests/test-char.c:29: error: void value not
When running with KVM enabled, you can choose between emulating the
gic in kernel or user space. If the kernel supports in-kernel virtualization
of the interrupt controller, it will default to that. If not, if will
default to user space emulation.
Unfortunately when running in user mode gic emulat
101 - 200 of 320 matches
Mail list logo
