Re: [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h

2017-06-23 Thread Markus Armbruster
Peter Maydell writes: > On 22 June 2017 at 18:03, Juan Quintela wrote: >> Greg Kurz wrote: >>> On Thu, 22 Jun 2017 17:14:08 +0100 >>> Peter Maydell wrote: >>> On 22 June 2017 at 17:06, Greg Kurz wrote: > Function types cannot reside in the same sorted list as opaque types > si

Re: [Qemu-devel] [PATCH] Separate function types from opaque types in include/qemu/typedefs.h

2017-06-23 Thread Markus Armbruster
Peter Maydell writes: > On 22 June 2017 at 19:08, Thomas Huth wrote: >> On 22.06.2017 19:50, Dr. David Alan Gilbert wrote: >>> Could do; I'm just not finding tiny header files with one or >>> two entries each that useful. > > Well, it means that the bulk of code that doesn't care about the > typ

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

2017-06-23 Thread Mark Cave-Ayland
On 21/06/17 14:23, Eduardo Habkost wrote: > I now have a v7 patchset ready to go (currently hosted at > https://github.com/mcayland/qemu/tree/fwcfg7 for the curious). Laszlo, > I've currently left off your Tested-by tag since I'm not sure it's still > valid for less-than-trivial ch

Re: [Qemu-devel] [PATCH v3] live-block-ops.txt: Rename, rewrite, and improve it

2017-06-23 Thread Kashyap Chamarthy
On Thu, Jun 22, 2017 at 10:13:03AM -0400, John Snow wrote: > On 06/22/2017 04:56 AM, Kashyap Chamarthy wrote: > > On Wed, Jun 21, 2017 at 06:49:02PM -0400, John Snow wrote: [...] > > Yes, I was thinking of this, too -- just link to the 'bitmaps' document. > > > > A quick side question here: Sinc

Re: [Qemu-devel] [PATCH] xen/disk: don't leak stack data via response ring

2017-06-23 Thread Jan Beulich
>>> On 22.06.17 at 20:52, wrote: > On Thu, 22 Jun 2017, Jan Beulich wrote: >> >>> On 21.06.17 at 20:46, wrote: >> > On Wed, 21 Jun 2017, Jan Beulich wrote: >> >> >>> On 20.06.17 at 23:48, wrote: >> >> > On Tue, 20 Jun 2017, Jan Beulich wrote: >> >> >> @@ -36,13 +33,7 @@ struct blkif_x86_32_reque

Re: [Qemu-devel] BUG: KASAN: use-after-free in free_old_xmit_skbs

2017-06-23 Thread Jason Wang
On 2017年06月23日 02:53, Michael S. Tsirkin wrote: On Thu, Jun 22, 2017 at 08:15:58AM +0200, jean-philippe menil wrote: 2017-06-06 1:52 GMT+02:00 Michael S. Tsirkin : On Mon, Jun 05, 2017 at 05:08:25AM +0300, Michael S. Tsirkin wrote: > On Mon, Jun 05, 2017 at 12:48:53AM +0200, Jean-Ph

Re: [Qemu-devel] [PULL 0/5] M68k for 2.10 patches

2017-06-23 Thread Peter Maydell
On 21 June 2017 at 22:00, Laurent Vivier wrote: > The following changes since commit 8dfaf23ae1f2273a9730a9b309cc8471269bb524: > > tcg/tci: fix tcg-interpreter build (2017-06-20 18:39:15 +0100) > > are available in the git repository at: > > git://github.com/vivier/qemu-m68k.git tags/m68k-for-

Re: [Qemu-devel] [PATCH 31/31] eepro100: replace g_malloc()+memcpy() with g_memdup()

2017-06-23 Thread Jason Wang
On 2017年06月22日 21:09, Stefan Weil wrote: Am 22.06.2017 um 14:42 schrieb Marc-André Lureau: I found these pattern via grepping the source tree. I don't have a coccinelle script for it! Signed-off-by: Marc-André Lureau --- hw/net/eepro100.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletio

Re: [Qemu-devel] BUG: KASAN: use-after-free in free_old_xmit_skbs

2017-06-23 Thread Jean-Philippe Menil
On 06/23/2017 10:43 AM, Jason Wang wrote: On 2017年06月23日 02:53, Michael S. Tsirkin wrote: On Thu, Jun 22, 2017 at 08:15:58AM +0200, jean-philippe menil wrote: 2017-06-06 1:52 GMT+02:00 Michael S. Tsirkin : On Mon, Jun 05, 2017 at 05:08:25AM +0300, Michael S. Tsirkin wrote: > On Mon

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-23 Thread Peter Maydell
On 15 June 2017 at 16:15, Edgar E. Iglesias wrote: > On Thu, Jun 15, 2017 at 04:04:56PM +0100, Peter Maydell wrote: >> The difference here is that the clock objects themselves have >> internal state. That's not necessarily a bad idea, but it does >> mean that something's got to migrate that state

Re: [Qemu-devel] NVDIMM live migration broken?

2017-06-23 Thread Stefan Hajnoczi
On Fri, Jun 23, 2017 at 08:13:13AM +0800, haozhong.zh...@intel.com wrote: > On 06/22/17 15:08 +0100, Stefan Hajnoczi wrote: > > I tried live migrating a guest with NVDIMM on qemu.git/master (edf8bc984): > > > > $ qemu -M accel=kvm,nvdimm=on -m 1G,slots=4,maxmem=8G -cpu host \ > > -objec

Re: [Qemu-devel] [PATCH 07/31] dmg: use DIV_ROUND_UP

2017-06-23 Thread Stefan Hajnoczi
On Thu, Jun 22, 2017 at 02:41:40PM +0200, Marc-André Lureau wrote: > I used the clang-tidy qemu-round check to generate the fix: > https://github.com/elmarco/clang-tools-extra > > Signed-off-by: Marc-André Lureau > --- > block/dmg.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Review

Re: [Qemu-devel] [PATCH v7 7/9] pci: Convert shpc_init() to Error

2017-06-23 Thread Marcel Apfelbaum
On 22/06/2017 11:14, Mao Zhongyi wrote: In order to propagate error message better, convert shpc_init() to Error also convert the pci_bridge_dev_initfn() to realize. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- v7: * drop the !local_err assert i

Re: [Qemu-devel] [PATCH v9 13/20] qcow2: add support for LUKS encryption format

2017-06-23 Thread Daniel P. Berrange
On Wed, Jun 21, 2017 at 04:59:02PM +0200, Max Reitz wrote: > On 2017-06-21 16:46, Max Reitz wrote: > > On 2017-06-21 16:42, Max Reitz wrote: > >> On 2017-06-19 19:34, Daniel P. Berrange wrote: > >>> This adds support for using LUKS as an encryption format > >>> with the qcow2 file, using the new en

Re: [Qemu-devel] [PATCH v9 09/20] qcow: convert QCow to use QCryptoBlock for encryption

2017-06-23 Thread Daniel P. Berrange
On Wed, Jun 21, 2017 at 04:29:02PM +0200, Max Reitz wrote: > On 2017-06-19 19:34, Daniel P. Berrange wrote: > > This converts the qcow driver to make use of the QCryptoBlock > > APIs for encrypting image content. This is only wired up to > > permit use of the legacy QCow encryption format. Users wh

Re: [Qemu-devel] [PATCH v9 07/20] block: deprecate "encryption=on" in favor of "encrypt.format=aes"

2017-06-23 Thread Daniel P. Berrange
On Tue, Jun 20, 2017 at 04:07:49PM +0200, Alberto Garcia wrote: > On Tue 20 Jun 2017 02:02:06 PM CEST, Daniel P. Berrange wrote: > >> > +if (encryptfmt) { > >> > +buf = qemu_opt_get_del(opts, BLOCK_OPT_ENCRYPT); > >> > +if (buf != NULL) { > >> > +g_free(buf); > >> >

Re: [Qemu-devel] [PATCH v3 3/3] migration: add bitmap for received page

2017-06-23 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch adds ability to track down already received > pages, it's necessary for calculation vCPU block time in > postcopy migration feature, maybe for restore after > postcopy migration failure. > Also it's necessary to solve shared memory is

[Qemu-devel] [PATCH v4 1/4] tests: Add test-listen - a stress test for QEMU socket listen

2017-06-23 Thread Knut Omang
There's a potential race condition between multiple bind()'s attempting to bind to the same port, which occasionally allows more than one bind to succeed against the same port. When a subsequent listen() call is made with the same socket only one will succeed. The current QEMU code does however n

[Qemu-devel] [PATCH v4 3/4] sockets: factor out a new try_bind() function

2017-06-23 Thread Knut Omang
Another refactoring step to prepare for the problem exposed by the test-listen test. This time simplify and reorganize the IPv6 specific extra measures and move it out of the for loop to increase code readability. No semantic changes. Signed-off-by: Knut Omang --- util/qemu-sockets.c | 69 +

[Qemu-devel] [PATCH v4 0/4] Unit test+fix for problem with QEMU handling of multiple bind()s to the same port

2017-06-23 Thread Knut Omang
This series contains: * a unit test that exposes a race condition which causes QEMU to fail to find a port even when there is plenty of available ports. * a refactor of the qemu-sockets inet_listen_saddr() function to better handle this situation. Changes from v3: * Test changes: Add missing l

[Qemu-devel] [PATCH v4 2/4] sockets: factor out create_fast_reuse_socket

2017-06-23 Thread Knut Omang
First refactoring step to prepare for fixing the problem exposed with the test-listen test in the previous commit Signed-off-by: Knut Omang --- util/qemu-sockets.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/util/qemu-sockets.c b/util/qemu-socket

[Qemu-devel] [PATCH v4 4/4] sockets: Handle race condition between binds to the same port

2017-06-23 Thread Knut Omang
If an offset of ports is specified to the inet_listen_saddr function(), and two or more processes tries to bind from these ports at the same time, occasionally more than one process may be able to bind to the same port. The condition is detected by listen() but too late to avoid a failure. This fu

[Qemu-devel] [PULL 4/7] sdl2: add assert to make coverity happy

2017-06-23 Thread Gerd Hoffmann
There is a loop a few lines up counting consoles and setting sdl2_num_outputs accordingly, so con ptr can't be NULL there. Signed-off-by: Gerd Hoffmann Message-id: 20170621122234.12751-1-kra...@redhat.com Signed-off-by: Gerd Hoffmann --- ui/sdl2.c | 1 + 1 file changed, 1 insertion(+) diff --g

[Qemu-devel] [PULL 6/7] ps2: add ps2_reset_queue

2017-06-23 Thread Gerd Hoffmann
Factor out ps2 queue reset to a separate function. No functional change. Signed-off-by: Gerd Hoffmann Message-id: 20170606112105.13331-3-kra...@redhat.com --- hw/input/ps2.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/hw/input/ps2.c b/hw/input/ps2.c index

[Qemu-devel] [PULL 5/7] ps2: add and use PS2State typedef

2017-06-23 Thread Gerd Hoffmann
Cleanup: Create and use a typedef for PS2State and stop passing void pointers. No functional change. Signed-off-by: Gerd Hoffmann Message-id: 20170606112105.13331-2-kra...@redhat.com --- include/hw/input/ps2.h | 4 ++-- include/qemu/typedefs.h | 1 + hw/input/ps2.c | 12 +---

[Qemu-devel] [PULL 0/7] Ui and input 20170623 patches

2017-06-23 Thread Gerd Hoffmann
The following changes since commit e18a639164e162b3a4f078ab60606cd2f163d934: Merge remote-tracking branch 'remotes/kraxel/tags/usb-20170621-pull-request' into staging (2017-06-22 15:09:48 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/ui-and-inpu

[Qemu-devel] [PULL 3/7] hid: Reset kbd modifiers on reset

2017-06-23 Thread Gerd Hoffmann
From: Alexander Graf When resetting the keyboard, we need to reset not just the pending keystrokes, but also any pending modifiers. Otherwise there's a race when we're getting reset while running an escape sequence (modifier 0x100). Cc: qemu-sta...@nongnu.org Signed-off-by: Alexander Graf Messa

[Qemu-devel] [PULL 2/7] input: Decrement queue count on kbd delay

2017-06-23 Thread Gerd Hoffmann
From: Alexander Graf Delays in the input layer are special cased input events. Every input event is accounted for in a global intput queue count. The special cased delays however did not get removed from the queue, leading to queue overruns and thus silent key drops after typing quite a few chara

[Qemu-devel] [PATCH] mips/malta: load the initrd at the end of the low memory

2017-06-23 Thread Aurelien Jarno
Currently the malta board is loading the initrd just after the kernel. This doesn't work for kaslr enabled kernels, as the initrd ends-up being overwritten. Move the initrd at the end of the low memory, that should leave a sufficient gap for kaslr. Signed-off-by: Aurelien Jarno --- hw/mips/mips

[Qemu-devel] [PULL 7/7] ps2: reset queue in ps2_reset_keyboard

2017-06-23 Thread Gerd Hoffmann
When the guest resets the keyboard also clear the queue. It is highly unlikely that the guest is still interested in the events stuck in the queue, and it avoids confusing the guest in case the queue is full and the ACK can't be queued up. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=137258

[Qemu-devel] [PULL 1/7] keymaps: add tracing

2017-06-23 Thread Gerd Hoffmann
Drop commented debug logging, add trace points instead. Also cleanup parser code a bit, the key name is copied into a new variable instead of patching the input line, that way we can log the unmodified line. Signed-off-by: Gerd Hoffmann Message-id: 20170606134736.26080-1-kra...@redhat.com --- u

Re: [Qemu-devel] Commit 77af8a2b9 breaks (mac)OS X 10.11.6

2017-06-23 Thread Phil Dennis-Jordan
Hi, Apologies for the late reply, I've been away. On 20 June 2017 at 01:06, BALATON Zoltan wrote: >> I can (still) boot off my 10.11.0 installer iso image, and >> successfully upgraded from 10.11.4 to 10.11.6, with the latter >> continuing to boot without problems. > > I had Clover with unpatche

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-06-23 Thread Peter Maydell
On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Hi, > > Paolo suggested offline that we send a pull request for this series. > Here it is, I've run it through my testsuite + tested the LQSPI testcase > on Zynq. > > Cheers, > Edgar > > The following changes since

Re: [Qemu-devel] [PATCH v3 01/18] target/s390x: Map existing FAC_* names to S390_FEAT_* names

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > The FAC_ names were placeholders prior to the introduction > of the current facility modeling. > > Signed-off-by: Richard Henderson > --- > target/s390x/translate.c | 59 > > 1 file changed, 29 inse

Re: [Qemu-devel] [PULL 00/01] seccomp branch queue

2017-06-23 Thread Peter Maydell
On 22 June 2017 at 09:33, Eduardo Otubo wrote: > The following changes since commit 8dfaf23ae1f2273a9730a9b309cc8471269bb524: > > tcg/tci: fix tcg-interpreter build (2017-06-20 18:39:15 +0100) > > are available in the git repository at: > > https://github.com/otubo/qemu.git tags/pull-seccomp-2

Re: [Qemu-devel] [PATCH v3 02/18] target/s390x: change PSW_SHIFT_KEY

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > From: David Hildenbrand > > Such shifts are usually used to easily extract the PSW KEY from the PSW > mask, so let's avoid the confusing offset of 4. > > Reviewed-by: Thomas Huth > Signed-off-by: David Hildenbrand > Message-Id: <20170614133819.18

Re: [Qemu-devel] [PATCH v3 05/18] target/s390x: Mark FPSEH facility as available

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > This facility bit includes DFP-rounding, FPR-GR-transfer, > FPS-sign-handling, and IEEE-exception-simulation. We do > support all of these. > > Signed-off-by: Richard Henderson > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion

Re: [Qemu-devel] [PATCH v3 07/18] target/s390x: Implement load-and-zero-rightmost-byte insns

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 4 > target/s390x/translate.c | 7 +++ > 2 files changed, 11 insertions(+) > > diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def > index 60d244f..20

Re: [Qemu-devel] [PATCH v3 08/18] target/s390x: Mark STFLE_53 facility as available

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > This facility bit includes load-on-condition-2 and > load-and-zero-rightmost-byte. > > Signed-off-by: Richard Henderson > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Aurelien Jarno -- Aurelien Jarno

Re: [Qemu-devel] [PATCH v3 10/18] target/s390x: Implement processor-assist insn

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 3 +++ > target/s390x/translate.c | 1 + > 2 files changed, 4 insertions(+) Reviewed-by: Aurelien Jarno -- Aurelien Jarno GPG: 4096R/1DDD8C9B aurel.

Re: [Qemu-devel] [PATCH v3 06/18] target/s390x: Implement load-on-condition-2 insns

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 9 + > target/s390x/insn-format.def | 1 + > target/s390x/translate.c | 18 +++--- > 3 files changed, 25 insertions(+), 3 deletions(-) Reviewed-by: Au

Re: [Qemu-devel] [PATCH v3 09/18] target/s390x: Implement execution-hint insns

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Signed-off-by: Richard Henderson > --- > target/s390x/insn-data.def | 9 + > target/s390x/translate.c | 5 - > 2 files changed, 13 insertions(+), 1 deletion(-) Reviewed-by: Aurelien Jarno -- Aurelien Jarno

Re: [Qemu-devel] [PATCH v3 12/18] target/s390x: Finish implementing ETF2-ENH

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > Missed the proper alignment in TRTO/TRTT, and ignoring the M3 > field for all TRXX insns without ETF2-ENH. > > Signed-off-by: Richard Henderson > --- > target/s390x/mem_helper.c | 11 ++- > target/s390x/translate.c | 5 +++-- > 2 files ch

Re: [Qemu-devel] [PATCH v3 11/18] target/s390x: Mark STFLE_49 facility as available

2017-06-23 Thread Aurelien Jarno
On 2017-06-19 17:03, Richard Henderson wrote: > This facility bit includes execution-hint, load-and-trap, > miscellaneous-instruction-extensions and processor-assist. > > Signed-off-by: Richard Henderson > --- > target/s390x/cpu_models.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Aure

Re: [Qemu-devel] [PATCH] target/i386: fix interrupt CPL error when using ist in x86-64

2017-06-23 Thread Paolo Bonzini
On 21/06/2017 16:21, Wu Xiang wrote: > In do_interrupt64(), when interrupt stack table(ist) is enabled > and the the target code segment is conforming(e2 & DESC_C_MASK), the > old implementation always set new CPL to 0, and SS.RPL to 0. > > This is incorrect for when CPL3 code access a CPL0 conf

Re: [Qemu-devel] [PATCH v4 0/3] Add memfd memory backend

2017-06-23 Thread Eduardo Habkost
On Thu, Jun 22, 2017 at 11:58:14AM +0200, David Hildenbrand wrote: > On 21.06.2017 16:02, Marc-André Lureau wrote: > > Add a new Linux-specific memory backend, similar to hostmem-file, > > except that it doesn't need file path. It also try to enforce memory > > sealing if available. It is thus slig

Re: [Qemu-devel] [PATCH v2 1/2] docs: document deprecated features in appendix

2017-06-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > The deprecation of features in QEMU is totally adhoc currently, > with no way for the user to get a list of what is deprecated > in each release. This adds an appendix to the doc that records > when each deprecation[1] was made and provides text explaining > what to

Re: [Qemu-devel] [PATCH v2 2/2] docs: document support lifetime for features

2017-06-23 Thread Markus Armbruster
"Daniel P. Berrange" writes: > There is currently no explicit guidance on the duration of support > for features such as versioned machine types, which have a finite > useful lifespan. Thus apps / users cannot predict how much time > they might be able to use a feature for, before it is removed (

Re: [Qemu-devel] [PATCH v2 1/2] docs: document deprecated features in appendix

2017-06-23 Thread Daniel P. Berrange
On Fri, Jun 23, 2017 at 01:44:46PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > The deprecation of features in QEMU is totally adhoc currently, > > with no way for the user to get a list of what is deprecated > > in each release. This adds an appendix to the doc that recor

Re: [Qemu-devel] [PATCHv6 3/5] fw_cfg: move assert() and linking of fw_cfg device to the machine into instance_init()

2017-06-23 Thread Eduardo Habkost
On Fri, Jun 23, 2017 at 09:12:01AM +0100, Mark Cave-Ayland wrote: > On 21/06/17 14:23, Eduardo Habkost wrote: > > > I now have a v7 patchset ready to go (currently hosted at > > https://github.com/mcayland/qemu/tree/fwcfg7 for the curious). Laszlo, > > I've currently left off your Test

Re: [Qemu-devel] [PATCH v2 2/2] docs: document support lifetime for features

2017-06-23 Thread Daniel P. Berrange
On Fri, Jun 23, 2017 at 01:48:34PM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > There is currently no explicit guidance on the duration of support > > for features such as versioned machine types, which have a finite > > useful lifespan. Thus apps / users cannot predict ho

Re: [Qemu-devel] [PATCH v2 2/2] docs: document support lifetime for features

2017-06-23 Thread Peter Maydell
On 23 June 2017 at 12:48, Markus Armbruster wrote: > "Daniel P. Berrange" writes: >> +The supported lifetime for machine types is 12 releases, which is >> +equivalent to 4 years worth of previous QEMU releases. >> + > > Do we have consensus on this? Peter? I don't have an opinion personally bec

Re: [Qemu-devel] [PULL 0/7] Ui and input 20170623 patches

2017-06-23 Thread Peter Maydell
available in the git repository at: > > git://git.kraxel.org/qemu tags/ui-and-input-20170623-pull-request > > for you to fetch changes up to 6e24ee0c1e4b6c0c9c748acab77ecd113c942a4d: > > ps2: reset queue

Re: [Qemu-devel] [PULL v1 0/7] MMIO Exec pull request

2017-06-23 Thread KONRAD Frederic
Le 06/23/2017 à 12:54 PM, Peter Maydell a écrit : On 14 June 2017 at 18:45, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Hi, Paolo suggested offline that we send a pull request for this series. Here it is, I've run it through my testsuite + tested the LQSPI testcase on Zynq. Cheers,

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-23 Thread KONRAD Frederic
Le 06/23/2017 à 11:51 AM, Peter Maydell a écrit : On 15 June 2017 at 16:15, Edgar E. Iglesias wrote: On Thu, Jun 15, 2017 at 04:04:56PM +0100, Peter Maydell wrote: The difference here is that the clock objects themselves have internal state. That's not necessarily a bad idea, but it does mea

Re: [Qemu-devel] [PATCH 12/23] hyperv: make HvSintRoute reference-counted

2017-06-23 Thread Eduardo Habkost
On Wed, Jun 14, 2017 at 07:23:56PM +0300, Roman Kagan wrote: > On Wed, Jun 14, 2017 at 10:53:25AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 06, 2017 at 09:19:37PM +0300, Roman Kagan wrote: > > > Multiple entities (e.g. VMBus devices) can use the same SINT route. To > > > make their lives easie

Re: [Qemu-devel] [RFC] virtio-mem: paravirtualized memory

2017-06-23 Thread Stefan Hajnoczi
On Wed, Jun 21, 2017 at 02:32:48PM +0200, David Hildenbrand wrote: > On 21.06.2017 13:08, Stefan Hajnoczi wrote: > > On Mon, Jun 19, 2017 at 12:26:52PM +0200, David Hildenbrand wrote: > >> On 19.06.2017 12:08, Stefan Hajnoczi wrote: > >>> On Fri, Jun 16, 2017 at 04:20:02PM +0200, David Hildenbrand

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-23 Thread Peter Maydell
On 23 June 2017 at 13:38, KONRAD Frederic wrote: > Le 06/23/2017 à 11:51 AM, Peter Maydell a écrit : >> As an aside, I still find it very odd that you get a clock >> object for both an input clock and an output clock. I feel >> like we should have one end owns the clock object and the >> other jus

[Qemu-devel] [PATCH RFC v3 4/8] block: convert ThrottleGroup to object with QOM

2017-06-23 Thread Manos Pitsidianakis
ThrottleGroup is converted to an object to allow easy runtime configuration of throttling filter nodes in the BDS graph using QOM. Signed-off-by: Manos Pitsidianakis --- block/throttle-groups.c | 351 include/qemu/throttle.h | 4 + 2 files chang

[Qemu-devel] [PATCH RFC v3 2/8] block: Add aio_context field in ThrottleGroupMember

2017-06-23 Thread Manos Pitsidianakis
timer_cb() needs to know about the current Aio context of the throttle request that is woken up. In order to make ThrottleGroupMember backend agnostic, this information is stored in an aio_context field instead of accessing it from BlockBackend. Signed-off-by: Manos Pitsidianakis --- block/block

[Qemu-devel] [PULL 1/3] applesmc: cosmetic whitespace and indentation cleanup

2017-06-23 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Signed-off-by: Gabriel Somlo Reviewed-by: Alexander Graf Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Phil Dennis-Jordan Message-id: 1497639316-22202-2-git-send-email-gso...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/misc/applesmc.c | 98 +

[Qemu-devel] [PATCH RFC v3 5/8] block: add BlockDevOptionsThrottle to QAPI

2017-06-23 Thread Manos Pitsidianakis
This is needed to configure throttle filter driver nodes with QAPI. Signed-off-by: Manos Pitsidianakis --- qapi/block-core.json | 19 ++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/qapi/block-core.json b/qapi/block-core.json index f85c2235c7..1d4afafe8c 100644

[Qemu-devel] [PULL 0/3] Queue/misc patches

2017-06-23 Thread Gerd Hoffmann
The following changes since commit 4c8c1cc544dbd5e2564868e61c5037258e393832: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.10-pull-request' into staging (2017-06-22 19:01:58 +0100) are available in the git repository at: git://git.kraxel.org/qemu tags/queue/misc-pull-request

[Qemu-devel] [PULL 3/3] applesmc: fix port i/o access width

2017-06-23 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" Set access width of all AppleSMC i/o regions to 1 byte, since they all represent 8-bit-wide ports. Signed-off-by: Gabriel Somlo Reviewed-by: Alexander Graf Message-id: 1497639316-22202-4-git-send-email-gso...@gmail.com Signed-off-by: Gerd Hoffmann --- hw/misc/applesm

[Qemu-devel] [PULL 2/3] applesmc: implement error status port

2017-06-23 Thread Gerd Hoffmann
From: "Gabriel L. Somlo" As of release 10.12.4, OS X (Sierra) refuses to boot unless the AppleSMC supports an additional I/O port, expected to provide an error status code. Update the [cmd|data]_write() and data_read() methods to implement the required state machine, and add I/O region & methods

[Qemu-devel] [PATCH RFC v3 0/8] I/O Throtting block filter driver

2017-06-23 Thread Manos Pitsidianakis
This patch series adds a filter driver that uses the existing I/O throttle code. Throttle groups can be then created and managed with QOM. The 'remove legacy I/O throttling' patch replaces existing interface (command line, qmp, hmp) to use the throttle filter transparently so as to not break backw

[Qemu-devel] [PATCH RFC v3 6/8] block: add options parameter to bdrv_new_open_driver()

2017-06-23 Thread Manos Pitsidianakis
Allow passing a QDict *options parameter to bdrv_new_open_driver() so that it can be used if a driver needs it upon creation. The previous behaviour (empty bs->options and bs->explicit_options) remains when options is NULL. Signed-off-by: Manos Pitsidianakis --- block.c | 13 ++

[Qemu-devel] [PATCH RFC v3 8/8] block: add throttle block filter driver interface tests

2017-06-23 Thread Manos Pitsidianakis
Signed-off-by: Manos Pitsidianakis --- tests/qemu-iotests/184 | 144 + tests/qemu-iotests/184.out | 31 ++ tests/qemu-iotests/group | 1 + 3 files changed, 176 insertions(+) create mode 100755 tests/qemu-iotests/184 create mode 100644

[Qemu-devel] [PATCH RFC v3 7/8] block: remove legacy I/O throttling

2017-06-23 Thread Manos Pitsidianakis
This commit removes all I/O throttling from block/block-backend.c. In order to support the existing interface, it is changed to use the block/throttle.c filter driver. The throttle filter node that is created by the legacy interface is stored in a 'throttle_node' field in the BlockBackendPublic of

[Qemu-devel] [PATCH RFC v3 3/8] block: add throttle block filter driver

2017-06-23 Thread Manos Pitsidianakis
block/throttle.c uses existing I/O throttle infrastructure inside a block filter driver. I/O operations are intercepted in the filter's read/write coroutines, and referred to block/throttle-groups.c The driver can be used with the command -drive driver=throttle,file.filename=foo.qcow2,iops-total=.

[Qemu-devel] [PATCH RFC v3 1/8] block: move ThrottleGroup membership to ThrottleGroupMember

2017-06-23 Thread Manos Pitsidianakis
This commit gathers ThrottleGroup membership details from BlockBackendPublic into ThrottleGroupMember and refactors existing code to use the structure. Signed-off-by: Manos Pitsidianakis --- block/block-backend.c | 66 + block/qapi.c| 8 +- block/throttle

[Qemu-devel] [RFC 1/3] qemu-ga: add support for events

2017-06-23 Thread Tomáš Golembiovský
Events can play an integral role when monitoring internal state of the guest OS. This patch adds the core functionality for adding events to QEMU Guest Agent. Signed-off-by: Tomáš Golembiovský --- Makefile | 7 +- qga/Makefile.objs | 2 +- qga/channel-posix.c| 8 +++

[Qemu-devel] [RFC 2/3] qemu-ga: add simple event reporting memory statistics

2017-06-23 Thread Tomáš Golembiovský
work in progress Signed-off-by: Tomáš Golembiovský --- qga/main.c | 19 --- qga/qapi-event.json | 16 2 files changed, 32 insertions(+), 3 deletions(-) diff --git a/qga/main.c b/qga/main.c index f16abb5cbb..a9586e7513 100644 --- a/qga/main.c +++ b/qga/m

[Qemu-devel] [RFC 0/3] qemu-ga: support for sending events

2017-06-23 Thread Tomáš Golembiovský
This is just a draft, or a request for comments if you will. This patch sets drafts the support of sending events by QEMU Guest Agent. Events can plan important role in monitoring of the guest OS behaviour. The range of use cases ranges from events important for scheduling, e.g. memory and CPU usa

[Qemu-devel] [RFC 3/3] qemu-ga: add support for periodic command runner

2017-06-23 Thread Tomáš Golembiovský
This adds a support for periodicaly triggering arbitrary command reporting its output. Signed-off-by: Tomáš Golembiovský --- qga/main.c | 26 ++ qga/qapi-event.json | 17 + 2 files changed, 43 insertions(+) diff --git a/qga/main.c b/qga/main.c in

Re: [Qemu-devel] [PATCH] sdl2: add assert to make coverity happy

2017-06-23 Thread Stefan Hajnoczi
On Wed, Jun 21, 2017 at 02:22:34PM +0200, Gerd Hoffmann wrote: > There is a loop a few lines up counting consoles and setting > sdl2_num_outputs accordingly, so con ptr can't be NULL there. > > Signed-off-by: Gerd Hoffmann > --- > ui/sdl2.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: S

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-23 Thread KONRAD Frederic
Le 06/23/2017 à 02:47 PM, Peter Maydell a écrit : On 23 June 2017 at 13:38, KONRAD Frederic wrote: Le 06/23/2017 à 11:51 AM, Peter Maydell a écrit : As an aside, I still find it very odd that you get a clock object for both an input clock and an output clock. I feel like we should have one e

Re: [Qemu-devel] [PATCH] target/ppc/cpu-models: set POWER9_v1.0 as POWER9 DD1

2017-06-23 Thread David Gibson
On Thu, Jun 22, 2017 at 01:31:24PM +0200, Thomas Huth wrote: > On 22.06.2017 13:26, Laurent Vivier wrote: > > CPU_POWERPC_POWER9_DD1 is 0x004E0100, so this is the POWER9 v1.0. > > > > When we run qemu on a POWER9 DD1 host, we must use either > > "-cpu host" or "-cpu POWER9", but in the latter case

Re: [Qemu-devel] [RFC 0/3] qemu-ga: support for sending events

2017-06-23 Thread Marc-André Lureau
Hi On Fri, Jun 23, 2017 at 3:03 PM Tomáš Golembiovský wrote: > This is just a draft, or a request for comments if you will. > > This patch sets drafts the support of sending events by QEMU Guest Agent. > Events can plan important role in monitoring of the guest OS behaviour. The > range of use c

Re: [Qemu-devel] [PATCH v2 06/21] travis: Add config to do a Coverity Scan upload

2017-06-23 Thread Philippe Mathieu-Daudé
On 06/22/2017 06:56 AM, Alex Bennée wrote:[...] I think this is waiting on a fix I mention when reviewing Peter's original patches. Ok! I'll wait or drop the Coverity part.

Re: [Qemu-devel] [PATCH v2 07/21] travis: update sudo-enabled Trusty images

2017-06-23 Thread Philippe Mathieu-Daudé
On 06/22/2017 06:58 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: see https://blog.travis-ci.com/2017-06-19-trusty-updates-2017-Q2 Signed-off-by: Philippe Mathieu-Daudé The way I read that blog post is group: edge is for testing things still work but you probably don't want to mer

Re: [Qemu-devel] [PATCH v4 1/4] net/socket: Drop the odd 'default' case and comment

2017-06-23 Thread Markus Armbruster
Mao Zhongyi writes: > In the net_socket_fd_init(), the 'default' case and comment is odd. > If @fd really was a pty, getsockopt() would fail with ENOTSOCK. If > @fd was a socket, but neither SOCK_DGRAM nor SOCK_STREAM. It should > not be treated as if it was SOCK_STREAM. > > If there is a genuine

Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Server cpu model

2017-06-23 Thread Eduardo Habkost
On Wed, Jun 21, 2017 at 01:29:34PM +0800, Boqun Feng (Intel) wrote: > Introduce Skylake-Server cpu mode which inherits the features from > Skylake-Client and supports some additional features that are: AVX512, > CWLB and PGPE1GB. I will fix this to "CLWB" when applying the patch. > > Signed-off-

Re: [Qemu-devel] [PATCH v2 13/21] travis: improve ccache use

2017-06-23 Thread Philippe Mathieu-Daudé
On 06/22/2017 07:22 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Signed-off-by: Philippe Mathieu-Daudé Can you expand the commit message to breifly explain what all these extra settings change. What is CCACHE_SLOPINESS and ccache -s doing? I'm pretty sure I wrote something here

Re: [Qemu-devel] [PATCH v2 14/21] travis: dump config.log if ./configure script fails

2017-06-23 Thread Philippe Mathieu-Daudé
On 06/22/2017 07:23 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: [...] - - ./configure ${CONFIG} + - ./configure ${CONFIG} || cat config.log Won't the explicit || mean the job will keep trying even if config is broken? Should it be || cat config.log && false? Yes, you right. I

Re: [Qemu-devel] [PATCH v5 00/24] docker/shippable: cross-build mipsel and powerpc targets

2017-06-23 Thread Philippe Mathieu-Daudé
On 06/21/2017 11:15 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: This patchset add 2 more architectures to the cross-build farm. There is still some issue trying to cross-build mips64el-softmmu, it seems the cross tools use the system outdated libfdt instead of the one checkouted in

Re: [Qemu-devel] [PATCH v3 00/10] Clock framework API.

2017-06-23 Thread Peter Maydell
On 23 June 2017 at 14:07, KONRAD Frederic wrote: > Le 06/23/2017 à 02:47 PM, Peter Maydell a écrit : >> Each device "owns" its output clock objects, but input >> clocks are just pointers to the clock object owned by the >> device at the other end. In the board you wire up CI1 to C1, >> and CI2 to

Re: [Qemu-devel] [PATCH v3] ui/cocoa.m: add Speed menu

2017-06-23 Thread Peter Maydell
On 21 June 2017 at 16:19, Peter Maydell wrote: > On 14 June 2017 at 04:17, Programmingkid wrote: >> Programs running inside of QEMU can sometimes use more CPU time than is >> really >> needed. To solve this problem, we just need to throttle the virtual CPU. This >> feature will stop laptops from

Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Server cpu model

2017-06-23 Thread Paolo Bonzini
On 23/06/2017 15:38, Eduardo Habkost wrote: > On Wed, Jun 21, 2017 at 01:29:34PM +0800, Boqun Feng (Intel) wrote: >> Introduce Skylake-Server cpu mode which inherits the features from >> Skylake-Client and supports some additional features that are: AVX512, >> CWLB and PGPE1GB. > > I will fix th

Re: [Qemu-devel] [PATCH v4 2/4] net/net: Convert parse_host_port() to Error

2017-06-23 Thread Markus Armbruster
Mao Zhongyi writes: > Cc: berra...@redhat.com > Cc: kra...@redhat.com > Cc: pbonz...@redhat.com > Cc: jasow...@redhat.com > Cc: arm...@redhat.com > Signed-off-by: Mao Zhongyi > --- > include/qemu/sockets.h | 2 +- > net/net.c | 21 - > net/socket.c |

Re: [Qemu-devel] [PATCH] target/ppc/cpu-models: set POWER9_v1.0 as POWER9 DD1

2017-06-23 Thread Laurent Vivier
On 23/06/2017 11:21, David Gibson wrote: > On Thu, Jun 22, 2017 at 01:31:24PM +0200, Thomas Huth wrote: >> On 22.06.2017 13:26, Laurent Vivier wrote: >>> CPU_POWERPC_POWER9_DD1 is 0x004E0100, so this is the POWER9 v1.0. >>> >>> When we run qemu on a POWER9 DD1 host, we must use either >>> "-cpu hos

[Qemu-devel] TARGET_PAGE_BITS

2017-06-23 Thread ali saeedi
Hello What does TARGET_PAGE_BITS mean in qemu code? thanks a lot

Re: [Qemu-devel] [PATCH v4] Add manpage for QEMU Backup Tool

2017-06-23 Thread Stefan Hajnoczi
On Thu, Jun 22, 2017 at 11:43:02PM +0530, Ishani Chugh wrote: I'm happy with the overall command-line interface. A few minor comments below. > qemu-backup will be a command-line tool for performing full and incremental > disk backups on running VMs. It is intended as a reference implementation

Re: [Qemu-devel] [PATCH v4 2/4] net/net: Convert parse_host_port() to Error

2017-06-23 Thread Markus Armbruster
Markus Armbruster writes: > Mao Zhongyi writes: > >> Cc: berra...@redhat.com >> Cc: kra...@redhat.com >> Cc: pbonz...@redhat.com >> Cc: jasow...@redhat.com >> Cc: arm...@redhat.com >> Signed-off-by: Mao Zhongyi >> --- >> include/qemu/sockets.h | 2 +- >> net/net.c | 21 ++

Re: [Qemu-devel] TARGET_PAGE_BITS

2017-06-23 Thread Alex Bennée
ali saeedi writes: > Hello > What does TARGET_PAGE_BITS mean in qemu code? It's the page size of the target. e.g. TARGET_PAGE_BITS 12 1 << 12 = 4096 = 4k pages > thanks a lot -- Alex Bennée

[Qemu-devel] [PATCH 1/1] vmstate: error hint for failed equal checks

2017-06-23 Thread Halil Pasic
In some cases a failing VMSTATE_*_EQUAL does not mean we detected a bug, but it's actually the best we can do. Especially in these cases a verbose error message is required. Let's introduce infrastructure for specifying a error hint to be used if equal check fails. Let's do this by adding a parame

Re: [Qemu-devel] TARGET_PAGE_BITS

2017-06-23 Thread ali saeedi
thank you for answer So. why do we have right shift in qemu by "TARGET_PAGE_BITS" ? for exampe in below code, what does it mean? static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, ram_addr_t length) { unsigned long en

Re: [Qemu-devel] TARGET_PAGE_BITS

2017-06-23 Thread Peter Maydell
On 23 June 2017 at 16:02, ali saeedi wrote: > thank you for answer > So. why do we have right shift in qemu by "TARGET_PAGE_BITS" ? for exampe > in below code, what does it mean? > > static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, >

Re: [Qemu-devel] [PATCH] target-i386: add Skylake-Server cpu model

2017-06-23 Thread Eduardo Habkost
On Fri, Jun 23, 2017 at 04:06:57PM +0200, Paolo Bonzini wrote: [...] > > I believe we should add the same comment about XSAVES from > > Skylake-Cliente here, for consistency: > > > > /* Missing: XSAVES (not supported by some Linux versions, > > * including v4.1 to v4.6). > > It's

Re: [Qemu-devel] [PULL 0/3] Queue/misc patches

2017-06-23 Thread Peter Maydell
On 23 June 2017 at 13:48, Gerd Hoffmann wrote: > The following changes since commit 4c8c1cc544dbd5e2564868e61c5037258e393832: > > Merge remote-tracking branch > 'remotes/vivier/tags/m68k-for-2.10-pull-request' into staging (2017-06-22 > 19:01:58 +0100) > > are available in the git repository a

  1   2   3   >