Re: [Qemu-devel] [RISU PATCH v5 09/13] risu: add simple trace and replay support

On 19 June 2017 at 11:46, Alex Bennée wrote: > This adds a very dumb and easily breakable trace and replay support. In > --master mode the various risu ops trigger a write of register/memory > state into a binary file which can be played back to an apprentice. > Currently there is no validation of

Re: [Qemu-devel] [PATCH v3 06/13] kvm: let kvm use AccelState.global_props

On Tue, Jun 20, 2017 at 09:55:03PM +0800, Peter Xu wrote: > On Mon, Jun 19, 2017 at 01:14:03PM -0300, Eduardo Habkost wrote: > > On Mon, Jun 19, 2017 at 08:49:41PM +0800, Peter Xu wrote: > > > Let KVM be the first user of the new AccelState.global_props field. > > > Basically kvm accel only contain

Re: [Qemu-devel] [RISU PATCH v5 04/13] build-all-archs: support --static flag

On 19 June 2017 at 11:46, Alex Bennée wrote: > Signed-off-by: Alex Bennée > > --- > v5 > - swap with docker patch so later can be dropped if not wanted > --- Applied to master, thanks. -- PMM

Re: [Qemu-devel] [PATCH v9 07/20] block: deprecate "encryption=on" in favor of "encrypt.format=aes"

On Tue 20 Jun 2017 02:02:06 PM CEST, Daniel P. Berrange wrote: >> > +if (encryptfmt) { >> > +buf = qemu_opt_get_del(opts, BLOCK_OPT_ENCRYPT); >> > +if (buf != NULL) { >> > +g_free(buf); >> >> If you use qemu_opt_get() instead then you don't need "buf" at all, >> do

Re: [Qemu-devel] [RISU PATCH v5 05/13] build-all-archs: support cross building via docker

On 19 June 2017 at 11:46, Alex Bennée wrote: > If we want to link to any other libraries we might find using simple > cross toolchains doesn't work so well. One way around this is to use a > dockerised cross-toolchain which then won't clash with your host > system. If the user specifies --use-dock

Re: [Qemu-devel] [PATCH v2] hmp, qmp: introduce "info memory" and "query-memory" commands

"Dr. David Alan Gilbert" writes: > * Vadim Galitsyn (vadim.galit...@profitbricks.com) wrote: >> Hi Dave, >> >> Thank you for the feedback! >> >> > I think you need to use the PRIu64 macros rather than 'lu' for the types >> > of the ints there to keep it portable. >> >> Agree, patch v3 will inc

Re: [Qemu-devel] [RISU PATCH v5 13/13] new: run_risu.sh script

On 19 June 2017 at 11:46, Alex Bennée wrote: > A simple script to work through running all of a bunch of files with > record/playback traces. Dumps a summary and the number of failed tests > at the end. > > Signed-off-by: Alex Bennée > > --- > v5 > - author, license, usage header > v3 > - twe

Re: [Qemu-devel] [RISU PATCH v5 12/13] new: record_traces.sh helper script

On 19 June 2017 at 11:46, Alex Bennée wrote: > A simple script to run through a bunch of binaries and generate their > trace files. > > Signed-off-by: Alex Bennée > > --- > v5 > - author, license and usage header > v3 > - allow overriding of RISU binary > --- > record_traces.sh | 32

Re: [Qemu-devel] [RISU PATCH v5 10/13] risu: handle trace through stdin/stdout

On 19 June 2017 at 11:46, Alex Bennée wrote: > Trace files can get quite large so it would be useful to be able to > just capture the trace stream with stdin/stdout for processing in a > pipe line. The sort of case where this is useful is for building > static binaries where zlib support is missin

Re: [Qemu-devel] [RISU PATCH v5 11/13] risu: add support compressed tracefiles

On 19 June 2017 at 11:46, Alex Bennée wrote: > This uses the magic of zlib's gzread/write interface to wrap the > tracefile in compression. The code changes are tiny. I spent more time > messing about with the configure/linker stuff to auto-detect bits. > > As you need decent multi-arch support or

Re: [Qemu-devel] [RISU PATCH v5 03/13] all: fix up code consitency

On 20 June 2017 at 14:13, Peter Maydell wrote: > Something seems to have gone wrong in this file -- note the extra indent > of {} blocks after "case 0:". The others are all fine though so I'll > just fix this locally. ...fixed up version applied to risu master. thanks -- PMM

Re: [Qemu-devel] [Qemu-ppc] [PATCH] spapr/ppc: fix backward migration to QEMU 2.9

On Tue, 20 Jun 2017 15:08:47 +0200 Laurent Vivier wrote: > On 19/06/2017 19:05, Greg Kurz wrote: > > Commit c783b0012708 ("ppc: Rework CPU compatibility testing across > > migration") added a subsection to the vmstate description of CPUs. > > This subsection is sent when the CPU compat_pvr field

Re: [Qemu-devel] [PATCH v4 0/7] Reduce the number of I/O ops when doing COW

Am 19.06.2017 um 15:40 hat Alberto Garcia geschrieben: > Hi all, > > here's a patch series that rewrites the copy-on-write code in the > qcow2 driver to reduce the number of I/O operations. > > This is version v4, please refer to the original e-mail for a complete > description: > > https://list

Re: [Qemu-devel] [PATCH] qcow2: Use offset_into_cluster() and offset_to_l2_index()

Am 20.06.2017 um 15:01 hat Alberto Garcia geschrieben: > We already have functions for doing these calculations, so let's use > them instead of doing everything by hand. This makes the code a bit > more readable. > > Signed-off-by: Alberto Garcia Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH 2/2] risu_reginfo_arm.c: Move orphan comment to risu.h.

Move an orphan comment that describes the reginfo structure into risu.h, and expand it a little. Signed-off-by: Peter Maydell --- risu.h | 5 + risu_reginfo_arm.c | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/risu.h b/risu.h index 3fbeda8..70c2184 1006

[Qemu-devel] [PATCH 1/2] risu_reginfo_arm.c: Fix handling of size values in sigframe

The code in reginfo_init_vfp() to parse the signal frame was mishandling the size counts: * the size includes the bytes for the magic and size fields, so the code to skip forward over unknown or undersize blocks was adding 4 more than it should * the size is in bytes but the "is this block

[Qemu-devel] [PATCH risu 0/2] risu: Fix handling of ARM sigframe

This patchset has two patches: the major one fixes bugs in our code for parsing the VFP parts of the ARM signal frame structures. These weren't causing a practical problem because of the way the kernel happens to lay out the sigframe, but I noticed them while looking at the code for another reason.

Re: [Qemu-devel] [PATCH v5 0/1] 9pfs: local: Add support for custom fmode/dmode in 9ps mapped security modes

On Tue, 20 Jun 2017 01:37:17 +0200 Tobias Schramm wrote: > Hi Greg, > > thank you for your hints on improving this patch. I've implemented them all > in this version. > > In the last version of the patch I moved the path check down because I moved > the g_strdup and tried to keep all operations

Re: [Qemu-devel] [PATCH] xen-platform: Cleanup network infrastructure when emulated NICs are unplugged

On Mon, Jun 19, 2017 at 09:19:45AM +0100, Ross Lagerwall wrote: > When the guest unplugs the emulated NICs, call net_cleanup() to cleanup > the network infrastructure in QEMU as it is not needed anymore. Most > importantly, this allows the tap interfaces which QEMU holds open to be > closed and rem

Re: [Qemu-devel] [RISU PATCH v5 05/13] build-all-archs: support cross building via docker

Peter Maydell writes: > On 19 June 2017 at 11:46, Alex Bennée wrote: >> If we want to link to any other libraries we might find using simple >> cross toolchains doesn't work so well. One way around this is to use a >> dockerised cross-toolchain which then won't clash with your host >> system. I

Re: [Qemu-devel] [RISU PATCH v5 13/13] new: run_risu.sh script

Peter Maydell writes: > On 19 June 2017 at 11:46, Alex Bennée wrote: >> A simple script to work through running all of a bunch of files with >> record/playback traces. Dumps a summary and the number of failed tests >> at the end. >> >> Signed-off-by: Alex Bennée >> >> --- >> v5 >> - author,

Re: [Qemu-devel] [RISU PATCH v5 10/13] risu: handle trace through stdin/stdout

Peter Maydell writes: > On 19 June 2017 at 11:46, Alex Bennée wrote: >> Trace files can get quite large so it would be useful to be able to >> just capture the trace stream with stdin/stdout for processing in a >> pipe line. The sort of case where this is useful is for building >> static binari

Re: [Qemu-devel] [PATCH 1/2] risu_reginfo_arm.c: Fix handling of size values in sigframe

Peter Maydell writes: > The code in reginfo_init_vfp() to parse the signal frame > was mishandling the size counts: > * the size includes the bytes for the magic and size fields, >so the code to skip forward over unknown or undersize blocks >was adding 4 more than it should > * the siz

Re: [Qemu-devel] [PULL 00/41] Misc patches for 2017-06-15

On 15 June 2017 at 11:52, Paolo Bonzini wrote: > The following changes since commit 3f0602927b120a480b35dcf58cf6f95435b3ae91: > > Merge remote-tracking branch > 'remotes/pmaydell/tags/pull-target-arm-20170613' into staging (2017-06-13 > 15:49:07 +0100) > > are available in the git repository a

Re: [Qemu-devel] [PATCH 2/2] risu_reginfo_arm.c: Move orphan comment to risu.h.

Peter Maydell writes: > Move an orphan comment that describes the reginfo structure > into risu.h, and expand it a little. > > Signed-off-by: Peter Maydell > --- > risu.h | 5 + > risu_reginfo_arm.c | 5 - > 2 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/

Re: [Qemu-devel] [RISU PATCH v5 12/13] new: record_traces.sh helper script

Peter Maydell writes: > On 19 June 2017 at 11:46, Alex Bennée wrote: >> A simple script to run through a bunch of binaries and generate their >> trace files. >> >> Signed-off-by: Alex Bennée >> >> --- >> v5 >> - author, license and usage header >> v3 >> - allow overriding of RISU binary >>

Re: [Qemu-devel] [PATCH v5 1/1] 9pfs: local: Add support for custom fmode/dmode in 9ps mapped security modes

On Tue, 20 Jun 2017 01:37:18 +0200 Tobias Schramm wrote: > In mapped security modes, files are created with very restrictive > permissions (600 for files and 700 for directories). This makes > file sharing between virtual machines and users on the host rather > complicated. Imagine eg. a group of

Re: [Qemu-devel] [PATCH v3] hw/misc: Add Exynos4210 Pseudo Random Number Generator

On 25 April 2017 at 19:06, Krzysztof Kozlowski wrote: > Add emulation for Exynos4210 Pseudo Random Number Generator which could > work on fixed seeds or with seeds provided by True Random Number > Generator block inside the SoC. > > Implement only the fixed seeds part of it in polling mode (no > i

Re: [Qemu-devel] [PULL v2 00/41] QAPI patches for 2017-06-09

Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1497962468-22936-1-git-send-email-arm...@redhat.com Subject: [Qemu-devel] [PULL v2 00/41] QAPI patches for 2017-06-09 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 tot

Re: [Qemu-devel] [PATCH 1/2] risu_reginfo_arm.c: Fix handling of size values in sigframe

On 20 June 2017 at 16:03, Alex Bennée wrote: > > Peter Maydell writes: > >> The code in reginfo_init_vfp() to parse the signal frame >> was mishandling the size counts: >> * the size includes the bytes for the magic and size fields, >>so the code to skip forward over unknown or undersize blo

Re: [Qemu-devel] [PATCH v3] hw/misc: Add Exynos4210 Pseudo Random Number Generator

On Tue, Jun 20, 2017 at 04:34:57PM +0100, Peter Maydell wrote: > On 25 April 2017 at 19:06, Krzysztof Kozlowski wrote: > > Add emulation for Exynos4210 Pseudo Random Number Generator which could > > work on fixed seeds or with seeds provided by True Random Number > > Generator block inside the SoC

Re: [Qemu-devel] [PATCH v5 1/5] throttle: factor out duplicate code

On Mon, 19 Jun 2017 09:11:32 -0400 Pradeep Jagadeesh wrote: > This patch factor out the duplicate throttle code that was present in > block and fsdev devices. > > Signed-off-by: Pradeep Jagadeesh > --- I guess this patch can be applied right away. Cc'ing Markus (maintainer of blockdev.c) >

[Qemu-devel] [PATCH v1 3/8] target-microblaze: Add CPU versions 9.4, 9.5 and 9.6

From: "Edgar E. Iglesias" Add CPU versions 9.4, 9.5 and 9.6. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 4bc77df..982cb61 100644 --- a/target/microblaze/cpu.c +++ b/t

[Qemu-devel] [PATCH v1 2/8] target-microblaze: Don't hard code 0xb as initial MB version

From: "Edgar E. Iglesias" Don't hard code 0xb as initial MB version. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index af70faa..4bc77df 100644 --- a/target/m

[Qemu-devel] [PATCH v1 0/8] target-microblaze: Misc configurability

From: "Edgar E. Iglesias" Fixes and a few additional properties to control the configuration of the CPU. The property names are taken from the device-tree bindings. Cheers, Edgar Edgar E. Iglesias (8): target-microblaze: Correct bit shift for the PVR0 version field target-microblaze: Don't

[Qemu-devel] [PATCH v1 7/8] target-microblaze: Introduce a use-msr-instr property

From: "Edgar E. Iglesias" Introduce a use-msr-instr property making msr instructions optional. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 5 +++-- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 files changed, 5 insertions(+), 3 deletions(

[Qemu-devel] [PATCH v1 5/8] target-microblaze: Introduce a use-div property

From: "Edgar E. Iglesias" Introduce a use-div property making division instructions optional. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 9 + target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 files changed, 7 insertions(+), 5 deletio

[Qemu-devel] [PATCH v1 1/8] target-microblaze: Correct bit shift for the PVR0 version field

From: "Edgar E. Iglesias" Correct bit shift for the PVR0 version field. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 2 +- target/microblaze/cpu.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 3d5

[Qemu-devel] [PATCH v1 6/8] target-microblaze: Introduce a use-hw-mul property

From: "Edgar E. Iglesias" Introduce a use-div property making multiplication instructions optional. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 12 target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 5 ++--- 3 files changed, 11 insertio

Re: [Qemu-devel] [PATCH v5 3/5] qmp: refactor duplicate code

On Mon, 19 Jun 2017 09:11:34 -0400 Pradeep Jagadeesh wrote: > This patch factor out the duplicate qmp throttle interface code > that was present in both block and fsdev device files. > The text is obviously wrong. I don't see any duplicate code below. It is more something like: let's factor ou

[Qemu-devel] [PATCH v1 4/8] target-microblaze: Introduce a use-barrel property

From: "Edgar E. Iglesias" Introduce a use-barrel property making barrel shifter instructions optional. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 9 + target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 2 +- 3 files changed, 7 insertions(+),

Re: [Qemu-devel] [PATCH 1/5] spapr: Leave DR-indicator management to the guest

On Tue, 20 Jun 2017 09:53:28 +0800 David Gibson wrote: > The DR-indicator is essentially a "virtual LED" attached to a hotpluggable > device, which the guest can set to various states for the attention of > the operator or management layers. > > It's mostly guest managed, except that we once-off

[Qemu-devel] [PATCH v1 4/7] target-microblaze: dec_barrel: Plug TCG temp leak

From: "Edgar E. Iglesias" Plug TCG temp leak. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 504ed88..6ee4885 100644 --- a/target/microblaze/translate.c +

Re: [Qemu-devel] [PATCH v3] Add manpage for QEMU Backup Tool

On Mon, Jun 19, 2017 at 9:14 PM, Ishani Chugh wrote: > qemu-backup will be a command-line tool for performing full and incremental > disk backups on running > VMs. It is intended as a reference implementation for management stack and > backup developers to > see QEMU's backup features in action

Re: [Qemu-devel] [PATCH v11 6/6] virtio-balloon: VIRTIO_BALLOON_F_CMD_VQ

On Fri, Jun 09, 2017 at 06:41:41PM +0800, Wei Wang wrote: > - if (!virtqueue_indirect_desc_table_add(vq, desc, num)) { > + if (!virtqueue_indirect_desc_table_add(vq, desc, *num)) { > virtqueue_kick(vq); > - wait_event(vb->acked, virtqueue_get_buf(vq, &len)); > -

[Qemu-devel] [PATCH v1 1/7] target-microblaze: dec_barrel: Use bool instead of unsigned int

From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translat

[Qemu-devel] [PATCH v1 7/7] target-microblaze: Add CPU version 10.0

From: "Edgar E. Iglesias" Add CPU version 10.0. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/microblaze/cpu.c b/target/microblaze/cpu.c index 6e27c3c..f85ff01 100644 --- a/target/microblaze/cpu.c +++ b/target/microblaze

[Qemu-devel] [PATCH v1 5/7] target-microblaze: dec_barrel: Add BSEFI

From: "Edgar E. Iglesias" Add support for BSEFI. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 36 1 file changed, 24 insertions(+), 12 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 6ee

[Qemu-devel] [PATCH v1 8/8] target-microblaze: Introduce a use-pcmp-instr property

From: "Edgar E. Iglesias" Introduce a use-pcmp-instr property making pcmp instructions optional. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 5 +++-- target/microblaze/cpu.h | 1 + target/microblaze/translate.c | 6 +++--- 3 files changed, 7 insertions(+), 5 dele

[Qemu-devel] [PATCH v1 0/7] target-microblaze: Add support for BSXFI

From: "Edgar E. Iglesias" Add support for bitfield extract and deposit instructions. Cheers, Edgar Edgar E. Iglesias (7): target-microblaze: dec_barrel: Use bool instead of unsigned int target-microblaze: dec_barrel: Use extract32 target-microblaze: dec_barrel: Add braces around if-statem

[Qemu-devel] [PATCH v1 3/7] target-microblaze: dec_barrel: Add braces around if-statements

From: "Edgar E. Iglesias" Add braces around if-statements. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index e

Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/5] spapr: Leave DR-indicator management to the guest

On 20/06/2017 03:53, David Gibson wrote: > The DR-indicator is essentially a "virtual LED" attached to a hotpluggable > device, which the guest can set to various states for the attention of > the operator or management layers. > > It's mostly guest managed, except that we once-off set it to > ACT

Re: [Qemu-devel] [PULL v4 00/23] Docker and block patches

On 16 June 2017 at 02:08, Fam Zheng wrote: > The following changes since commit edf8bc98424d62035d5e4c0f39542722d72d7979: > > Merge remote-tracking branch 'remotes/rth/tags/pull-s390-20170613' into > staging (2017-06-15 13:45:15 +0100) > > are available in the git repository at: > > git://git

Re: [Qemu-devel] [PATCH v5 2/5] qmp: Create IOThrottle structure

On Mon, 19 Jun 2017 09:11:33 -0400 Pradeep Jagadeesh wrote: > This patch enables qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep

Re: [Qemu-devel] [PATCH v5 00/24] docker/shippable: cross-build mipsel and powerpc targets

Philippe Mathieu-Daudé writes: > This patchset add 2 more architectures to the cross-build farm. > > There is still some issue trying to cross-build mips64el-softmmu, it seems the > cross tools use the system outdated libfdt instead of the one checkouted in > the > dtc submodule. I disabled thi

[Qemu-devel] [PATCH v1 6/7] target-microblaze: dec_barrel: Add BSIFI

From: "Edgar E. Iglesias" Add support for BSIFI. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/target/microblaze/translate.c b/target/microblaze/translate.c index 4a8ab22..743b66f 100644 ---

Re: [Qemu-devel] [PATCH 3/3] xen-disk: use an IOThread per instance

> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: 20 June 2017 17:08 > To: Paul Durrant ; xen-de...@lists.xenproject.org; > qemu-devel@nongnu.org; qemu-bl...@nongnu.org > Cc: Anthony Perard ; Kevin Wolf > ; Stefano Stabellini ;

Re: [Qemu-devel] [PATCH v3] hw/misc: Add Exynos4210 Pseudo Random Number Generator

On 20 June 2017 at 16:44, Krzysztof Kozlowski wrote: > On Tue, Jun 20, 2017 at 04:34:57PM +0100, Peter Maydell wrote: >> Some of these lines are slightly overlong. > > Breaking lines does not make much sense, so I could just get rid of > EXYNOS4210 prefix. It is a local define so maybe there is no

[Qemu-devel] [PATCH v1 2/7] target-microblaze: dec_barrel: Use extract32

From: "Edgar E. Iglesias" Use extract32 instead of opencoding the shifting and masking. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/microblaze/translate.c b/target/microb

Re: [Qemu-devel] [PATCH 3/3] xen-disk: use an IOThread per instance

On 20/06/2017 15:47, Paul Durrant wrote: > This patch allocates an IOThread object for each xen_disk instance and > sets the AIO context appropriately on connect. This allows processing > of I/O to proceed in parallel. > > The patch also adds tracepoints into xen_disk to make it possible to > foll

[Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

fix regression from commit 244f144134: $ make subdir-arm-softmmu make[1]: *** No rule to make target 'tci.o', needed by 'qemu-system-arm'. Stop. Makefile:328: recipe for target 'subdir-arm-softmmu' failed make: *** [subdir-arm-softmmu] Error 2 Signed-off-by: Philippe Mathieu-Dau

Re: [Qemu-devel] [PATCH 2/5] spapr: Uniform DRC reset paths

On Tue, 20 Jun 2017 09:53:29 +0800 David Gibson wrote: > DRC objects have a regular device reset method. However, it only gets > called in the usual way for PCI DRCs. Because of where CPU and LMB DRCs > are in the QOM tree, their device reset method isn't automatically called. > So, the machine

[Qemu-devel] Instruction tracing

Hello! I was wondering if its possible to get an instruction trace of the process running on the guest OS in the VM including the instructions executed during system calls. Can someone please give me some pointers regarding how this could be implemented. Cheers, Nayan Deshmukh

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Mon, 2017-06-12 at 07:10 -0700, Dave Hansen wrote: > The hypervisor is going to throw away the contents of these pages, > right?  As soon as the spinlock is released, someone can allocate a > page, and put good data in it.  What keeps the hypervisor from > throwing > away good data? That looks

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On 20.06.2017 18:44, Rik van Riel wrote: > On Mon, 2017-06-12 at 07:10 -0700, Dave Hansen wrote: > >> The hypervisor is going to throw away the contents of these pages, >> right? As soon as the spinlock is released, someone can allocate a >> page, and put good data in it. What keeps the hypervis

Re: [Qemu-devel] [PATCH 3/5] spapr: Add DRC release method

On Tue, 20 Jun 2017 09:53:30 +0800 David Gibson wrote: > At the moment, spapr_drc_release() has an ugly switch on the DRC type to > call the right, device-specific release function. This cleans it up by > doing that via a proper QOM method. > > It's still arguably an abstraction violation for t

Re: [Qemu-devel] [PATCH 03/11] travis: use yes/no variable to enable/disable tests

On 06/17/2017 05:06 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: having the command to run in the variable make scripts harder to manage. I'm not sure this adds much over the TEST_CMD not set == don't run we had before. I don't like it neither but had trouble expanding commands i

[Qemu-devel] [Bug 1699277] [NEW] qemu-system-s390x: asserts while booting Debian Stretch installer

Public bug reported: QEMU 2.9.0 (Arch Linux) asserts when I try to install Debian Stretch. Steps to reproduce: wget http://ftp.debian.org/debian/dists/stretch/main/installer-s390x/current/images/generic/initrd.debian wget http://ftp.debian.org/debian/dists/stretch/main/installer-s390x/current/

Re: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build Message-id: 20170620163009.21764-1-f4...@amsat.org Type: seri

Re: [Qemu-devel] Tracing guest virtual addresses

On Tue, Jun 20, 2017 at 14:02:02 +0300, Lluís Vilanova wrote: > Jayanto Minocha writes: > > > Hi, > > I think there have been a few threads on the mailing list regarding tracing > > guest virtual addresses for load and store instructions, but I have been > > unable to get it to work. I am trying t

Re: [Qemu-devel] [PATCH v3 15/18] target/s390x: Implement SRSTU

On 06/20/2017 01:27 AM, David Hildenbrand wrote: 2. We must not overwrite bit 0-31 in 24/31 bit mode: (PoP page 3-6) Unless specifically stated to the contrary, the follow- ing definition applies in this publication: whenever the machine generates and provides to the program a 24-bit or 31-bit a

Re: [Qemu-devel] [PATCH v1 1/3] target/s390x: Indicate and check for local tlb clearing

On 06/20/2017 05:35 AM, David Hildenbrand wrote: +if (s390_has_feat(S390_FEAT_LOCAL_TLB_CLEARING) && (m4 & 1)) { Surely better to let m4 == 0 without local-tlb-clearing during translate. r~

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, 2017-06-20 at 18:49 +0200, David Hildenbrand wrote: > On 20.06.2017 18:44, Rik van Riel wrote: > > Nitesh Lal (on the CC list) is working on a way > > to efficiently batch recently freed pages for > > free page hinting to the hypervisor. > > > > If that is done efficiently enough (eg. wit

Re: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

On 06/20/2017 02:17 PM, no-re...@patchew.org wrote: === OUTPUT BEGIN === [...] CC aarch64-softmmu/target/arm/cpu64.o cc: Internal error: Killed (program cc1) This is odd... Please submit a full bug report. See for instructions. make[1]: *** [targ

Re: [Qemu-devel] [PATCH v1 5/7] target-microblaze: dec_barrel: Add BSEFI

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: +if (e) { +tcg_gen_extract_i32(cpu_R[dc->rd], cpu_R[dc->ra], imm_s, imm_w); You'll want to validate imm_s and imm_w lest you trigger the asserts in tcg_gen_extract_i32. r~

Re: [Qemu-devel] [PATCH v1 1/7] target-microblaze: dec_barrel: Use bool instead of unsigned int

On 06/20/2017 09:08 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Use bool instead of unsigned int to represent flags. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Richar

Re: [Qemu-devel] [PATCH v1 2/7] target-microblaze: dec_barrel: Use extract32

On 06/20/2017 09:08 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Use extract32 instead of opencoding the shifting and masking. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Review

Re: [Qemu-devel] [PATCH v1 3/7] target-microblaze: dec_barrel: Add braces around if-statements

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add braces around if-statements. No functional change. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) Reviewed-by: Richard Henderson

Re: [Qemu-devel] [PATCH v1 4/7] target-microblaze: dec_barrel: Plug TCG temp leak

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Plug TCG temp leak. Signed-off-by: Edgar E. Iglesias --- target/microblaze/translate.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v1 6/7] target-microblaze: dec_barrel: Add BSIFI

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: +int width = imm_w - imm_s + 1; + +if (width == 0 || imm_w <= imm_s) { The width == 0 check is redundant; the imm_w <= imm_s check is wrong. It should be <. If imm_w >= imm_s, as per the proper check, then width must be >= 1.

Re: [Qemu-devel] [PATCH v1 6/7] target-microblaze: dec_barrel: Add BSIFI

On Tue, Jun 20, 2017 at 10:48:22AM -0700, Richard Henderson wrote: > On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: > >+int width = imm_w - imm_s + 1; > >+ > >+if (width == 0 || imm_w <= imm_s) { > > The width == 0 check is redundant; the imm_w <= imm_s check is wrong. It > shou

Re: [Qemu-devel] [PATCH v1 7/7] target-microblaze: Add CPU version 10.0

On 06/20/2017 09:09 AM, Edgar E. Iglesias wrote: From: "Edgar E. Iglesias" Add CPU version 10.0. Signed-off-by: Edgar E. Iglesias --- target/microblaze/cpu.c | 1 + 1 file changed, 1 insertion(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 1/8] include/exec/poison: Add missing TARGET defines

On 06/19/2017 10:52 PM, Thomas Huth wrote: Since we've got some new CPU targets in QEMU during the last months and years, we've got some new TARGET_xxx defines now which should be marked as poisoned for common code. Signed-off-by: Thomas Huth --- include/exec/poison.h | 16 1

Re: [Qemu-devel] [PATCH v3 2/8] include/exec/poison: Mark some CONFIG defines as poisoned, too

On 06/19/2017 10:52 PM, Thomas Huth wrote: These are defined in config-target.h and thus should never be used in common code. Signed-off-by: Thomas Huth --- include/exec/poison.h | 21 + 1 file changed, 21 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 5/8] cpu: Introduce a wrapper for tlb_flush() that can be used in common code

On 06/19/2017 10:52 PM, Thomas Huth wrote: Commit 1f5c00cfdb8114c ("qom/cpu: move tlb_flush to cpu_common_reset") moved the call to tlb_flush() from the target-specific reset handlers into the common code qom/cpu.c file, and protected the call with "#ifdef CONFIG_SOFTMMU" to avoid that it is call

Re: [Qemu-devel] [PATCH v3 6/8] include/exec/poison: Mark CONFIG_SOFTMMU as poisoned

On 06/19/2017 10:52 PM, Thomas Huth wrote: CONFIG_SOFTMMU should never be used in common code, so mark it as poisoned, too. Signed-off-by: Thomas Huth --- include/exec/poison.h | 1 + include/qom/cpu.h | 8 2 files changed, 9 insertions(+) Reviewed-by: Richard Henderson r~

Re: [Qemu-devel] [PATCH v3 8/8] hw/misc/edu: Compile the edu device as common object

On 06/19/2017 10:52 PM, Thomas Huth wrote: edu.c does not contain any target-specific code, so we can put it into common-obj-y to compile it only once for all targets. Signed-off-by: Thomas Huth Isn't CONFIG_EDU defined by the target, via pci.conf? Would it ever be set generically? r~

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, Jun 20, 2017 at 06:49:33PM +0200, David Hildenbrand wrote: > On 20.06.2017 18:44, Rik van Riel wrote: > > On Mon, 2017-06-12 at 07:10 -0700, Dave Hansen wrote: > > > >> The hypervisor is going to throw away the contents of these pages, > >> right? As soon as the spinlock is released, some

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, Jun 20, 2017 at 01:29:00PM -0400, Rik van Riel wrote: > On Tue, 2017-06-20 at 18:49 +0200, David Hildenbrand wrote: > > On 20.06.2017 18:44, Rik van Riel wrote: > > > > Nitesh Lal (on the CC list) is working on a way > > > to efficiently batch recently freed pages for > > > free page hinti

[Qemu-devel] [PATCH v14] migration: spapr: migrate pending_events of spapr state

v14: - several changes made in spapr_events.c to allow for a minimal VMSD to be migrated. Please check the commit message of the patch for more information. This is the next version of the v13 that was sent a month ago. You can check out the v13 discussions here: https://lists.nongnu.org/archive

[Qemu-devel] [PATCH v14] migration: spapr: migrate pending_events of spapr state

In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target so that the hotplug event can be finished on the

Re: [Qemu-devel] [PATCH] tcg/tci: fix tcg-interpreter build

On 20 June 2017 at 17:30, Philippe Mathieu-Daudé wrote: > fix regression from commit 244f144134: > > $ make subdir-arm-softmmu > make[1]: *** No rule to make target 'tci.o', needed by 'qemu-system-arm'. > Stop. > Makefile:328: recipe for target 'subdir-arm-softmmu' failed > make:

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On 20.06.2017 20:17, Michael S. Tsirkin wrote: > On Tue, Jun 20, 2017 at 06:49:33PM +0200, David Hildenbrand wrote: >> On 20.06.2017 18:44, Rik van Riel wrote: >>> On Mon, 2017-06-12 at 07:10 -0700, Dave Hansen wrote: >>> The hypervisor is going to throw away the contents of these pages,

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

On Tue, Jun 20, 2017 at 08:54:29PM +0200, David Hildenbrand wrote: > On 20.06.2017 20:17, Michael S. Tsirkin wrote: > > On Tue, Jun 20, 2017 at 06:49:33PM +0200, David Hildenbrand wrote: > >> On 20.06.2017 18:44, Rik van Riel wrote: > >>> On Mon, 2017-06-12 at 07:10 -0700, Dave Hansen wrote: > >>>

Re: [Qemu-devel] [PATCH v11 4/6] mm: function to offer a page block on the free list

>> IMHO even simply writing all-zeros to all free pages before starting >> migration (or even when freeing a page) would be a cleaner interface >> than this (because it atomically works with the entity the host cares >> about for migration). But yes, performance is horrible that's why I am >> not

Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/5] spapr: Uniform DRC reset paths

On 20/06/2017 03:53, David Gibson wrote: > DRC objects have a regular device reset method. However, it only gets > called in the usual way for PCI DRCs. Because of where CPU and LMB DRCs > are in the QOM tree, their device reset method isn't automatically called. > So, the machine manually regist

Re: [Qemu-devel] [Qemu-ppc] [PATCH 3/5] spapr: Add DRC release method

On 20/06/2017 03:53, David Gibson wrote: > At the moment, spapr_drc_release() has an ugly switch on the DRC type to > call the right, device-specific release function. This cleans it up by > doing that via a proper QOM method. > > It's still arguably an abstraction violation for the DRC code to c

Re: [Qemu-devel] [Qemu-ppc] [PATCH 4/5] spapr: Remove unnecessary differences between hotplug and coldplug paths

On 20/06/2017 03:53, David Gibson wrote: > spapr_drc_attach() has a 'coldplug' parameter which sets the DRC into > configured state initially, instead of the usual ISOLATED/UNUSABLE state. > It turns out this is unnecessary: although coldplugged devices do need to > be in CONFIGURED state once the

Re: [Qemu-devel] [Qemu-ppc] [PATCH 5/5] spapr: Use unplug_request for PCI hot unplug

On 20/06/2017 03:53, David Gibson wrote: > AIUI, ->unplug_request in the HotplugHandler is used for "soft" > unplug, where acknowledgement from the guest is required before > completing the unplug, whereas ->unplug is used for "hard" unplug > where qemu unilaterally removes the device, and the gues

Re: [Qemu-devel] [PATCH 3/5] spapr: Add DRC release method

Quoting Greg Kurz (2017-06-20 11:51:45) > On Tue, 20 Jun 2017 09:53:30 +0800 > David Gibson wrote: > > > At the moment, spapr_drc_release() has an ugly switch on the DRC type to > > call the right, device-specific release function. This cleans it up by > > doing that via a proper QOM method. > >

<    1   2   3   >