From: "sochin.jiang"
Supplement the omitted 'disk size' bytes information when using
'qemu-img info',it is useful in some occasion. Anyhow, it looks
strange that 'virtual size' has bytes while actual 'disk size'
does not.
Signed-off-by: sochin.jiang
---
block/qapi.c | 5 +++--
1 file ch
06.06.2017 09:54, Markus Armbruster wrote:
[ ./configure --disable-linux-user --disable-system --static ]
> I haven't, but here's a quick guess on what we need to squash into the
> patch:
>
> diff --git a/Makefile b/Makefile
> index c830d7a..2ef5a78 100644
> --- a/Makefile
> +++ b/Makefile
> @@
On Fri, Jun 02, 2017 at 06:55:30PM +0100, Dr. David Alan Gilbert wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
> > To make things easier, I just moved it to populate_ram_info().
>
> Blk is not RAM; better to create a separate function.
Agree...
Maybe rename populate_ram_info() into more
Paolo Bonzini writes:
> On 05/06/2017 15:10, Peter Maydell wrote:
>> I perpetually get confused about qdev properties vs QOM object
>> properties.
>>
>> Why do we have both of these APIs?
>> How do they interact?
>
> qdev properties are just a wrapper around QOM object properties, taking
> care
This is v2 of patch series
https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg05919.html.
Changes in v2:
* Patch 2: use major/minor numbers of device and sysfs to check
whether a backend file refers to DAX device. (Dan & Stefan)
* Patch 3: set ACPI_NFIT_MEM_NOT_ARMED bit of state flags in
If a vNVDIMM device is not backed by a DAX device and its "restrict"
option is enabled, bit 3 of state flags in its region mapping
structure will be set, in order to notify the guest of the lack of
write persistence guarantee. Once this bit is set, the guest OS may
mark the vNVDIMM device as read-o
Applications in Linux guest that use device-dax never trigger flush
that can be trapped by KVM/QEMU. Meanwhile, if the host backend is not
device-dax, QEMU cannot guarantee the persistence of guest writes.
Before solving this flushing problem, QEMU should warn users if the
host backend is not devic
A DAX device may require a page size different than getpagesize().
Signed-off-by: Haozhong Zhang
---
include/qemu/osdep.h | 10 ++
util/mmap-alloc.c| 6 ++
util/osdep.c | 23 +++
3 files changed, 39 insertions(+)
diff --git a/include/qemu/osdep.h b/i
Signed-off-by: Haozhong Zhang
---
hw/mem/nvdimm.c | 2 +-
include/hw/mem/nvdimm.h | 3 +++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
index db896b0bb6..a9b0863f20 100644
--- a/hw/mem/nvdimm.c
+++ b/hw/mem/nvdimm.c
@@ -66,7 +66,7 @@ out:
Hi Philippe,
On Wed, May 31, 2017 at 11:34 AM, Philippe Mathieu-Daudé
wrote:
> Hi Subbaraya,
>
>
> On 05/16/2017 12:38 PM, Subbaraya Sundeep wrote:
>
>> Emulated Emcraft's Smartfusion2 System On Module starter
>> kit.
>>
>> Signed-off-by: Subbaraya Sundeep
>> ---
>> hw/arm/Makefile.objs | 1 +
Michael Roth writes:
> check-qom-proplist originally added tests for verifying that
> object-creation helpers object_new_with_{props,propv} behaved in
> similar fashion to the "traditional" method involving setting each
> individual property separately after object creation rather than
> via a si
The following changes since commit 199e19ee538eb61fd08b1c1ee5aa838ebdcc968e:
Merge remote-tracking branch 'remotes/mjt/tags/trivial-patches-fetch' into
staging (2017-06-05 15:28:12 +0100)
are available in the git repository at:
git://repo.or.cz/qemu/armbru.git tags/pull-misc-2017-06-06
for
From: Michael Roth
check-qom-proplist originally added tests for verifying that
object-creation helpers object_new_with_{props,propv} behaved in
similar fashion to the "traditional" method involving setting each
individual property separately after object creation rather than
via a single call.
Hi Alistair,
On Wed, May 31, 2017 at 4:03 AM, Alistair Francis
wrote:
> On Sun, May 28, 2017 at 10:17 PM, sundeep subbaraya
> wrote:
> > Hi Alistair,
> >
> > On Sat, May 27, 2017 at 5:18 AM, Alistair Francis
> > wrote:
> >>
> >> On Tue, May 16, 2017 at 8:38 AM, Subbaraya Sundeep
> >> wrote:
>
Signed-off-by: Markus Armbruster
Message-Id: <1494327362-30727-3-git-send-email-arm...@redhat.com>
Acked-by: Paolo Bonzini
---
tests/virtio-scsi-test.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
index 8b0f77a..eff71df 1
From: Michael Roth
Currently objects specified on the command-line are only partially
cleaned up when 'object_del' is issued in either HMP or QMP: the
object itself is fully finalized, but the QemuOpts are not removed.
This results in the following behavior:
x86_64-softmmu/qemu-system-x86_64 -
Say "SCSI except scsi-generic" instead of "scsi-disk", because
scsi-disk could mean either scsi-disk.c (which is correct) or device
model scsi-disk (which would be incorrect).
Signed-off-by: Markus Armbruster
Message-Id: <1494327362-30727-2-git-send-email-arm...@redhat.com>
Acked-by: Paolo Bonzin
Update nvme header to catch up with kernel.
Most of the newly added members are from 1.2 and 1.3 spec, while the
status code is only kept the same with kernel (around 1.1 spec).
The major update is to add Scatter Gather List related macros and
members, for later SGL support implementation.
Signed
Hi Philippe,
On Wed, May 31, 2017 at 11:13 AM, Philippe Mathieu-Daudé
wrote:
> Hi Subbaraya,
>
> So far so good!
>
>
> On 05/16/2017 12:38 PM, Subbaraya Sundeep wrote:
>
>> Smartfusion2 SoC has hardened Microcontroller subsystem
>> and flash based FPGA fabric. This patch adds support for
>> Micr
Check PRP or SGL for Data Transfer(PSDT) flag for admin and read/write
commands.
For NVMe-over-PCIE, admin sq entry should not set SGL bits.
and rw sq entry PSDT flag should not be set beyond controller support.
Although currently either linux kernel NVMe-over-PCIE host driver uses
SGL nor qemu n
On Fri, Jun 02, 2017 at 12:08:09AM +0200, Juan Quintela wrote:
> We shouldn't be using memory later than that.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
> ---
> migration/migration.c | 2 --
> migration/ram.c | 5 +++--
> migration/ram.h | 1 -
> 3 files changed, 3 in
On Fri, Jun 02, 2017 at 12:08:10AM +0200, Juan Quintela wrote:
> It was only used by XBZRLE anyways.
>
> Signed-off-by: Juan Quintela
Reviewed-by: Peter Xu
> ---
> migration/ram.c | 11 ++-
> 1 file changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/migration/ram.c b/migration
On Mon, Jun 05, 2017 at 01:34:45PM +0100, Dr. David Alan Gilbert wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
> > RAM Statistics need to survive migration to make info migrate work, so we
> > need to store them outside of RAMState. As we already have an struct
> > with those fields, just
Initialize remote communication socket and make a handshack with remote
colo-frame.
Then use this way to notify remote colo-frame do checkpoint.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 32
1 file changed, 32 insertions(+)
diff --git a/net/colo-compar
Add chardev handler to get remote colo-frame's notify, Xen colo is the first
user.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 39 +--
1 file changed, 37 insertions(+), 2 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 6f8c439.
This series focus on COLO-proxy remote colo-frame support.
Xen COLO-frame is the first user. We add a new chardev socket
in colo-compare as the way of communicate with remote COLO-frame.
And remote COLO-frame notify colo-proxy part depend on this serise:
https://lists.nongnu.org/archive/html/qemu-d
We add the "notify_dev=chardevID" parameter. colo-compare can connect with
remote colo-frame through chardev socket, Xen colo-frame is the first user.
We can notify colo-frame do checkpoint events.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 20
qemu-options.hx| 4
On Fri, Jun 02, 2017 at 12:08:13AM +0200, Juan Quintela wrote:
> We create the variable while we are at migration and we remove it
> after migration.
>
> Signed-off-by: Juan Quintela
> ---
> migration/ram.c | 52
> 1 file changed, 32 insertion
On 06/05/2017 10:39 PM, Pranith Kumar wrote:
Is there any reason not to use sysconf(_SC_LEVEL1_DCACHE_LINESIZE)?
That's an excellent idea. In fact... see reply to 3/3.
r~
On 06/02/2017 04:05 PM, Halil Pasic wrote:
> Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
> flexibility (extending using subsections) and for fun.
>
> To achieve this we need to hack the config_vector, which is VirtIODevice
> (that is common virtio) state, in the middle of
On 06/05/2017 03:49 PM, Emilio G. Cota wrote:
+TranslationBlock *tcg_tb_alloc(TCGContext *s)
+{
+void *aligned;
+
+aligned = (void *)ROUND_UP((uintptr_t)s->code_gen_ptr,
QEMU_CACHELINE_SIZE);
+if (unlikely(aligned + sizeof(TranslationBlock) > s->code_gen_highwater)) {
+return
On 05/31/2017 09:34 PM, David Hildenbrand wrote:
> Let's also properly forward that bit. It should always be set. I
> verified it under z/VM, it seems to be always set there. For now,
> zKVM guests never get that bit set when the CPU model is active.
>
> The PoP mentiones, that z800 + z900 (HW gen
A third batch of cleanups to the DRC code. This continues to clear
away relatively simple cruft, to get a clearer look at the fundamental
state handling.
David Gibson (7):
spapr: Clean up DR entity sense handling
spapr: Abolish DRC get_name method
spapr: Assign DRC names from owners
spapr
DRC classes have an entity_sense method to determine (in a specific PAPR
sense) the presence or absence of a device plugged into a DRC. However,
we only have one implementation of the method, which explicitly tests for
different DRC types. This changes it to instead have different method
implemen
In theory the RTAS set-indicator call can be used for a number of
"indicators" defined by PAPR. In practice the only ones we're ever likely
to implement are those used for Dynamic Reconfiguration (i.e. hotplug).
Because of this, the current implementation determines the associated DRC
object, befo
There are 3 types of "indicator" associated with hotplug in the PAPR spec
the "allocation state", "isolation state" and "DR-indicator". The first
two are intimately tied to the various state transitions associated with
hotplug. The DR-indicator, however, is different and simpler.
It's basically
DRConnectorClass has a get_name method, however:
* There's only one implementation, and only ever likely to be one
* There's exactly one caller, which is (now) local
* The implementation is trivial
So just open-code what we need.
Signed-off-by: David Gibson
---
hw/ppc/spapr_drc.c
With some combinations of migration and hotplug we can lost temporary state
indicating how many DRCs (guest side hotplug handles) are still connected
to a DIMM object in the process of removal. When we hit that situation
spapr_recover_pending_dimm_state() is used to scan more extensively and
work
At present, spapr_dr_connector_new assigns a name to the drc based on its
type and ID. The few places the DRC name are used, however, are supposed
to give some sort of human-useful information to correlate guest-side
problems with host-side resources (for PCI devices it's supposed to be
a physical
DRC objects have attach & detach methods, but there's only one
implementation. Although there are some differences in its behaviour for
different DRC types, the overall structure is the same, so while we might
want different method implementations for some parts, we're unlikely to
want them for th
On 06/02/2017 07:28 PM, Halil Pasic wrote:
[...]
> Maybe integrating some of the discussion from above into the commit
> message would be helpful.
applied with the following patch description
Currently, under z/VM on a 0x2827, QEMU will detect a 0x2828 if no
IBC value is provided. QEMU will simp
On 06.06.2017 10:39, Christian Borntraeger wrote:
> On 06/02/2017 07:28 PM, Halil Pasic wrote:
> [...]
>> Maybe integrating some of the discussion from above into the commit
>> message would be helpful.
>
> applied with the following patch description
Just wanted to ask you to do that :) Thanks!
Hi,
> Any plan to replace properties defined as data by properties defined
> in
> code will be a hard sell with me. I think we should go back to data
> unless the problem at hand *requires* code.
There *are* some cases which require code, specifically QOM properties
which are writable after re
Temperatures can be changed from the monitor with :
(qemu) qom-set /machine/unattached/device[2] temperature0 12000
Signed-off-by: Cédric Le Goater
---
hw/arm/aspeed.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/arm/aspeed.c b/hw/arm/aspeed.c
index e824ea87a9af..155e
Largely inspired by the TMP105 temperature sensor, here is a model for
the TMP42{1,2,3} temperature sensors.
Specs can be found here :
http://www.ti.com/lit/gpn/tmp421
Signed-off-by: Cédric Le Goater
---
Changes since v1:
- made tmp421_info an abstract class.
- added a class size
Hello,
This series fixes issues in the TMP421 model previously sent and adds
such a device to the palmetto machine.
Thanks,
C.
Cédric Le Goater (2):
hw/misc: add a TMP42{1,2,3} device model
aspeed: add a temp sensor device on I2C bus 3
default-configs/arm-softmmu.mak | 1 +
hw/arm/aspee
When a timer is enabled before a reload value is set, the controller
waits for a reload value to be set before starting decrementing. This
fix tries to cover that case by changing the timer expiry only when
a reload value is valid.
Signed-off-by: Cédric Le Goater
---
hw/timer/aspeed_timer.c | 37
On 5 June 2017 at 17:52, Richard Henderson wrote:
> This contains several patches to fix compilation on ilp32 abis on
> 64-bit hosts, such as sparcv8plus and x32. It also contains the
> goto_ptr feature proposed by Emilio Cota.
>
>
> r~
>
>
> The following changes since commit 199e19ee538eb61fd08
> Your change makes a lot of sense, but ain't easy to understand IMHO.
>
> Maybe integrating some of the discussion from above into the commit
> message would be helpful. Especially this assumption that the client code
> is fine with getting a more recent GA version (and anything influenced by
> i
On 5 June 2017 at 18:01, Max Filippov wrote:
> Hi Peter,
>
> please pull my current target/xtensa queue:
>
> The following changes since commit c6e84fbd447a51e1161d74d71566a5f67b47eac5:
>
> Merge remote-tracking branch 'remotes/mst/tags/for_upstream' into staging
> (2017-06-02 17:46:22 +0100)
>
05.06.2017 18:06, Eric Blake wrote:
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
nbd/client.c | 26 +-
1 file changed, 17 insertions(+), 9 deletions(-)
diff --git a/nbd/client.c b/nbd/client.c
index 3d155
05.06.2017 18:23, Eric Blake wrote:
[adding Stefan as trace maintainer]
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote:
Signed-off-by: Vladimir Sementsov-Ogievskiy
---
Makefile.objs | 1 +
nbd/client.c | 77
nbd/n
I'll update this (with removed 11-13) after "nbd refactoring part 1"
pushed (actually, the first part of these series).
05.06.2017 18:23, Eric Blake wrote:
[adding Stefan as trace maintainer]
On 05/30/2017 09:30 AM, Vladimir Sementsov-Ogievskiy wrote:
[...]
--
Best regards,
Vladimir
Adding Peter Maydell in the cc and removing Claudio Fontana (It fails
sending to that address)
Bruno.
2017-06-02 14:07 GMT+01:00 Bruno Dominguez :
> There was no possibility to add specific cxx flags using the configure
> file. So A new entrance has been created to support it.
>
> Duplication of
On Fri, Jun 02, 2017 at 02:07:26PM +0100, Bruno Dominguez wrote:
> There was no possibility to add specific cxx flags using the configure
> file. So A new entrance has been created to support it.
>
> Duplication of information in configure and rules.mak. Taking
> QEMU_CFLAGS and add them to QEMU_C
Pavel Dovgalyuk writes:
> Alex,
>
> Do you have newer fixed version of these patches?
I was waiting to see if there where any other review comments for the
rest of the RFC series before re-spinning.
>
> Pavel Dovgalyuk
>
>
>> -Original Message-
>> From: Alex Bennée [mailto:alex.ben...@
2017-06-06 10:28 GMT+01:00 Stefan Hajnoczi :
> On Fri, Jun 02, 2017 at 02:07:26PM +0100, Bruno Dominguez wrote:
>> There was no possibility to add specific cxx flags using the configure
>> file. So A new entrance has been created to support it.
>>
>> Duplication of information in configure and rule
On 2 June 2017 at 17:08, Alex Bennée wrote:
> These are generated by the build-all-arches script.
>
> Signed-off-by: Alex Bennée
> ---
> .gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.gitignore b/.gitignore
> index fc84419..fca9128 100644
> --- a/.gitignore
> +++ b/.gitigno
On Thu, Jun 01, 2017 at 03:55:44PM -0400, Emilio G. Cota wrote:
> On Fri, Jan 13, 2017 at 21:48:09 +0100, Lluís Vilanova wrote:
> (snip)
> > To handle both issues, this series integrates the dynamic tracing event
> > state
> > into the TB hashing function, so that vCPUs tracing different events wi
On 2 June 2017 at 17:08, Alex Bennée wrote:
> Before this is could seem a little quite when running as you had no
> indication stuff was happening (or how fast). I only dump on the master
> side as I want to minimise the amount of qemu logs to sift through.
>
> Signed-off-by: Alex Bennée
>
> --
>
On 2 June 2017 at 17:08, Alex Bennée wrote:
> This is a precursor to record/playback support. Instead of passing the
> socket fd we now pass helper functions for reading/writing and
> responding. This will allow us to do the rest of the record/playback
> cleanly outside of the main worker function
Peter Maydell writes:
> On 2 June 2017 at 17:08, Alex Bennée wrote:
>> This is a precursor to record/playback support. Instead of passing the
>> socket fd we now pass helper functions for reading/writing and
>> responding. This will allow us to do the rest of the record/playback
>> cleanly outs
Let the old man "MigrationState" join the object family. Direct benefit
is that we can start to use all the property features derived from
current QDev, like: HW_COMPAT_* bits, command line setup for migration
parameters (so will never need to set them up each time using HMP/QMP,
this is really, re
Removing two callers of global_state_set_optional() since now we can use
HW_COMPAT_2_3. However there is still one more caller (xen_init), so we
still need to keep the function until it disappears.
Signed-off-by: Peter Xu
---
hw/i386/pc_piix.c | 1 -
hw/ppc/spapr.c | 1 -
include/hw/compa
Move it into MigrationState, with a property binded to it.
Same trick played with HW_COMPAT_2_3.
Signed-off-by: Peter Xu
---
hw/i386/pc_piix.c | 1 -
hw/ppc/spapr.c| 1 -
include/hw/compat.h | 4
include/migration/migration.h | 2 ++
migration/migratio
I picked this topic out as suggested by Juan. Also I did what Juan has
suggested in previous discussions that I moved lots of global
parameters into MigrationState, and let them be properties. Then we
can use HW_COMPAT_* and "-global migration.xxx=xxx" formular.
If without xen_init(), we can remov
One less global variable, and it does only matter with migration.
We keep the old "--only-migratable" option, but also now we support:
-global migration.only-migratable=true
Currently still keep the old interface.
Signed-off-by: Peter Xu
---
include/migration/migration.h | 3 +++
include/sy
Put it into MigrationState then we can use the properties to specify
whether to enable storing global state.
Signed-off-by: Peter Xu
---
include/migration/migration.h | 6 ++
migration/migration.c | 21 +
2 files changed, 23 insertions(+), 4 deletions(-)
diff --
On Thu, 2017-06-01 at 09:29 +0100, Daniel P. Berrange wrote:
> This series aims to fix a lot of bugs related to handling of IPv4 /
> IPv6
> dual stack.
>
> - The VNC server mistakenly listened on two separate ports 5900+5901
> when the to= parameter was given
> - IPv6 sockets are accepting IP
It was in SaveState but now moved to MigrationState altogether. Again,
using HW_COMPAT_2_3 for old PC/SPAPR machines but still we'll have to
keep savevm_skip_configuration() since used by xen_init().
Signed-off-by: Peter Xu
---
hw/i386/pc_piix.c | 1 -
hw/ppc/spapr.c
On Tue, Jun 6, 2017 at 10:45 AM, Bruno Dominguez
wrote:
> 2017-06-06 10:28 GMT+01:00 Stefan Hajnoczi :
>> On Fri, Jun 02, 2017 at 02:07:26PM +0100, Bruno Dominguez wrote:
>>> @@ -1489,37 +1498,6 @@ if test "$bogus_os" = "yes"; then
>>> error_exit "Unrecognized host OS $targetos"
>>> fi
>>>
>
In semihosting mode QEMU allows guest to read and write host file
descriptors directly, including descriptors 0..2, a.k.a. stdin, stdout
and stderr. Sometimes it's desirable to have semihosting console
controlled by -serial option, e.g. to connect it to network.
Add semihosting console to xtensa-s
rth/tags/pull-tcg-20170605' into
staging (2017-06-05 18:03:43 +0100)
are available in the git repository at:
git://github.com/OSLL/qemu-xtensa.git tags/20170606-xtensa
for you to fetch changes up to dd7b952b793e341c905355581a21cdbaa8b13c31:
target/xtensa: handle unknown registers in gdb
In case the configure script finds both SDL 1.2 and SDL 2.x installed
it still prefers SDL 1.2. Prefer SDL 2.x instead.
Signed-off-by: Gerd Hoffmann
---
configure | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index b75b9c57c0..44c773a5cd 10
Hi,
High time to use new versions (gtk3 and SDL2) by default. This patch
series switches over qemu to prefer the newer versions and adds a
deprecation warning for the old versions.
Note that qemu uses the new versions automatically for quite a while
already in case the older isn't installed.
Signed-off-by: Gerd Hoffmann
---
configure | 6 ++
1 file changed, 6 insertions(+)
diff --git a/configure b/configure
index 41c213b378..5af180c57d 100755
--- a/configure
+++ b/configure
@@ -5251,6 +5251,12 @@ if test "$gtkabi" = "2.0"; then
echo "WARNING: Please consider using gtk3 inst
In case the configure script finds both gtk2 and gtk3 installed it
still prefers gtk2 over gtk3. Prefer gtk3 instead.
Signed-off-by: Gerd Hoffmann
---
configure | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/configure b/configure
index 13e040d28c..b75b9c57c0
Signed-off-by: Gerd Hoffmann
---
configure | 6 ++
1 file changed, 6 insertions(+)
diff --git a/configure b/configure
index 44c773a5cd..41c213b378 100755
--- a/configure
+++ b/configure
@@ -5245,6 +5245,12 @@ if test "$supported_os" = "no"; then
echo "us upstream at qemu-devel@nongnu.or
On Tue, Jun 6, 2017 at 2:54 PM Gerd Hoffmann wrote:
> Hi,
>
> High time to use new versions (gtk3 and SDL2) by default. This patch
> series switches over qemu to prefer the newer versions and adds a
> deprecation warning for the old versions.
>
> Note that qemu uses the new versions automatica
Signed-off-by: Gerd Hoffmann
---
ui/egl-headless.c | 67 ++-
1 file changed, 17 insertions(+), 50 deletions(-)
diff --git a/ui/egl-headless.c b/ui/egl-headless.c
index d8d800f8a6..809bfde99c 100644
--- a/ui/egl-headless.c
+++ b/ui/egl-headless.
Add a collection of egl_fb_*() helper functions to manage and use opengl
framebuffers, which is a common pattern in UI code with opengl support.
Signed-off-by: Gerd Hoffmann
---
include/ui/egl-helpers.h | 14 ++
ui/egl-helpers.c | 69 ++
Signed-off-by: Gerd Hoffmann
---
include/ui/sdl2.h | 8 ++--
ui/sdl2-gl.c | 38 --
2 files changed, 14 insertions(+), 32 deletions(-)
diff --git a/include/ui/sdl2.h b/include/ui/sdl2.h
index aaf226c2c0..454367ac84 100644
--- a/include/ui/sdl2.h
+++ b
This is a followup to
v1: https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg02390.html
The goal is to clarify to users & app developers what they can expect
from QEMU in terms of feature lifecycle & any deprecation policy should
it be neccessary to remove features.
Changed in v2:
- Sp
The deprecation of features in QEMU is totally adhoc currently,
with no way for the user to get a list of what is deprecated
in each release. This adds an appendix to the doc that records
when each deprecation[1] was made and provides text explaining
what to use instead.
Signed-off-by: Daniel P. B
Michael Tokarev writes:
> 06.06.2017 09:54, Markus Armbruster wrote:
>
> [ ./configure --disable-linux-user --disable-system --static ]
>
>> I haven't, but here's a quick guess on what we need to squash into the
>> patch:
>>
>> diff --git a/Makefile b/Makefile
>> index c830d7a..2ef5a78 100644
>>
Hi,
All UIs with opengl support have simliar code to handle opengl
framebuffers. Create some helpers and put them into use to reduce
code duplication.
Gerd Hoffmann (4):
egl-helpers: add helpers to handle opengl framebuffers
egl-headless: use framebuffer helper functions.
sdl2: use frame
Signed-off-by: Gerd Hoffmann
---
include/ui/gtk.h | 4 ++--
ui/gtk-egl.c | 38 --
ui/gtk-gl-area.c | 26 +++---
3 files changed, 17 insertions(+), 51 deletions(-)
diff --git a/include/ui/gtk.h b/include/ui/gtk.h
index ca9a2268de..2f7b7
There is currently no explicit guidance on the duration of support
for features such as versioned machine types, which have a finite
useful lifespan. Thus apps / users cannot predict how much time
they might be able to use a feature for, before it is removed (if
ever).
This adds a new appendix tha
Signed-off-by: Gerd Hoffmann
---
include/ui/spice-display.h | 2 ++
ui/spice-core.c| 1 +
ui/spice-display.c | 3 ++-
3 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/include/ui/spice-display.h b/include/ui/spice-display.h
index 184d4c373a..4ba9444dba 100644
--- a
Am 05.06.2017 um 15:55 hat Peter Maydell geschrieben:
> Coverity points out that the code path in qcow_create() for
> the magic "fat:" backing file name leaks the memory used to
> store the filename (CID 1307771). Free the memory before
> we overwrite the pointer.
>
> Signed-off-by: Peter Maydell
Cleanup: Create and use a typedef for PS2State and stop passing void
pointers. No functional change.
Signed-off-by: Gerd Hoffmann
---
include/hw/input/ps2.h | 4 ++--
include/qemu/typedefs.h | 1 +
hw/input/ps2.c | 12 +---
3 files changed, 8 insertions(+), 9 deletions(-)
d
When the guest resets the keyboard also clear the queue. It is highly
unlikely that the guest is still interested in the events stuck in the
queue, and it avoids confusing the guest in case the queue is full and
the ACK can't be queued up.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=137258
Factor out ps2 queue reset to a separate function.
No functional change.
Signed-off-by: Gerd Hoffmann
---
hw/input/ps2.c | 15 ++-
1 file changed, 10 insertions(+), 5 deletions(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index 37f8cb842e..2416b58cc0 100644
--- a/hw/input/ps2.c
+
Hi,
Patches 1+2 are small cleanups and refactorings,
patch 3 is the actual fix.
cheers,
Gerd
Gerd Hoffmann (3):
ps2: add and use PS2State typedef
ps2: add ps2_reset_queue
ps2: reset queue in ps2_reset_keyboard
include/hw/input/ps2.h | 4 ++--
include/qemu/typedefs.h | 1 +
hw/inpu
Add Error argument for pci_add_capability() to leverage the errp
to pass info on errors. This way is helpful for its callers to
make a better error handling when moving to 'realize'.
Cc: pbonz...@redhat.com
Cc: r...@twiddle.net
Cc: ehabk...@redhat.com
Cc: m...@redhat.com
CC: dmi...@daynix.com
Cc:
The pci-birdge device i82801b11 and io3130_upstream/downstream
still implements the old PCIDeviceClass .init() through *_init()
instead of the new .realize(). All devices need to be converted
to .realize(). So convert it and rename it to *_realize().
Cc: m...@redhat.com
Cc: mar...@redhat.com
Cc: a
On success, pci_add_capability2() returns a positive value. On
failure, it sets an error and return a negative value.
pci_add_capability() laboriously checks this behavior. No other
caller does. Drop the checks from pci_add_capability().
Cc: m...@redhat.com
Cc: mar...@redhat.com
Signed-off-by: Ma
Comments for pci_add_capability2() to explain the return
value. This may help to make a correct return value check
for its callers.
Cc: m...@redhat.com
Cc: mar...@redhat.com
Cc: arm...@redhat.com
Suggested-by: Markus Armbruster
Signed-off-by: Mao Zhongyi
---
hw/pci/pci.c | 6 ++
1 file chan
pci_add_capability returns a strictly positive value on success,
correct asserts.
Cc: dmi...@daynix.com
Cc: jasow...@redhat.com
Cc: kra...@redhat.com
Cc: alex.william...@redhat.com
Cc: arm...@redhat.com
Signed-off-by: Mao Zhongyi
---
hw/net/e1000e.c | 2 +-
hw/net/eepro100.c | 2 +-
hw/usb/hcd
It reports a code style problem(ERROR: "foo * bar" should be "foo *bar")
when running checkpatch.pl. So fix it to conform to the coding standards.
Cc: jasow...@redhat.com
Cc: arm...@redhat.com
Signed-off-by: Mao Zhongyi
---
hw/net/eepro100.c | 62 +++--
1 - 100 of 410 matches
Mail list logo
