Re: [Qemu-devel] [PULL 00/69] target/s390x tcg patches

2017-06-04 Thread Aurelien Jarno
On 2017-06-04 10:34, Richard Henderson wrote: > The queue has gotten overlong. This includes my unwinding patches, > the execute rewrite, and Aurelien's flushing out of missing Z insns. > > It does *not* include Aurelian's final patch to bump the base tcg > cpu to z800. David Hildenbrand had obj

Re: [Qemu-devel] [PULL 00/69] target/s390x tcg patches

2017-06-04 Thread Aurelien Jarno
On 2017-06-04 11:32, no-re...@patchew.org wrote: > Hi, > > This series failed build test on s390x host. Please find the details below. > > Subject: [Qemu-devel] [PULL 00/69] target/s390x tcg patches > Message-id: 20170604173509.29684-1-...@twiddle.net > Type: series > [snip] > /var/tmp/patchew

[Qemu-devel] [PATCH v4 0/3] target/s390x: implement loads/store quadword

2017-06-04 Thread Aurelien Jarno
This patchset implements the LOAD PAIR FROM QUADWORD and STORE PAIR TO QUADWORD instructions. The corresponding patches have been in my previous patchset and the pull request from Richard, but they failed to build on a host without atomic128 support. This new version fixes that. It has to be appli

[Qemu-devel] [PATCH v4 1/3] target/s390x: implement LOAD PAIR FROM QUADWORD

2017-06-04 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 27 +++ target/s390x/translate.c | 7 +++ 4 files changed, 37 insertions(+) diff --git a/target/s390x/helper.h b/target/s390x/helpe

[Qemu-devel] [PATCH v4 3/3] target/s390x: check alignment in CDSG in the !CONFIG_ATOMIC128 case

2017-06-04 Thread Aurelien Jarno
The CDSG instruction requires a 16-byte alignement, as expressed in the MO_ALIGN_16 passed to helper_atomic_cmpxchgo_be_mmu. In the non parallel case, use check_alignment to enforce this. Signed-off-by: Aurelien Jarno --- target/s390x/mem_helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --

[Qemu-devel] [PATCH v4 2/3] target/s390x: implement STORE PAIR TO QUADWORD

2017-06-04 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 24 target/s390x/translate.c | 6 ++ 4 files changed, 33 insertions(+) diff --git a/target/s390x/helper.h b/target/s390x/helper.h

Re: [Qemu-devel] [PATCH] gitignore: Ignore vim per-project config and clang complete

2017-06-04 Thread Qu Wenruo
At 06/02/2017 10:57 PM, Eric Blake wrote: On 06/01/2017 11:08 PM, Qu Wenruo wrote: Since we have already ignored ctags, ignoring .clangcomplete for vim-clang_completion is quite reasonable for me. (Not to mention vim-clang_completion provides better and more accurate completion and definition

[Qemu-devel] [PATCH] monitor: Add -a (all) option to info registers

2017-06-04 Thread Suraj Jitindar Singh
The info registers command in the qemu monitor is used to dump register values. Currently this command uses the monitor cpu (which can be set by the user) as the cpu for whose registers will be dumped. Sometimes it is useful to see the registers for all cpus and currently this requires setting the

[Qemu-devel] [PATCH] target/ppc: Fixup set_spr error in h_register_process_table

2017-06-04 Thread Suraj Jitindar Singh
set_spr is used in the function h_register_process_table() to update the LPCR_GTSE and LPCR_UPRT values based on the flags passed by the guest. The set_spr function takes the last two arguments mask and value used to mask and set the value of the spr respectively. The current call site passes thes

Re: [Qemu-devel] [PATCH] target-ppc: Fix openpic timer read register offset

2017-06-04 Thread David Gibson
On Fri, Jun 02, 2017 at 04:32:59AM -0700, Aaron Larson wrote: > > openpic_tmr_read() is incorrectly computing register offset of the > TCCR, TBCR, TVPR, and TDR registers when accessing the open pic timer > registers. Specifically the offset of timer registers for > openpic_tmr_read() is not acco

Re: [Qemu-devel] [PATCH] target/ppc: Fixup set_spr error in h_register_process_table

2017-06-04 Thread David Gibson
On Mon, Jun 05, 2017 at 10:49:51AM +1000, Suraj Jitindar Singh wrote: > set_spr is used in the function h_register_process_table() to update the > LPCR_GTSE and LPCR_UPRT values based on the flags passed by the guest. > The set_spr function takes the last two arguments mask and value used to > mask

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-06-04 Thread Michael S. Tsirkin
On Sun, Jun 04, 2017 at 06:34:45PM +0800, Wei Wang wrote: > On 05/26/2017 01:57 AM, Michael S. Tsirkin wrote: > > > > I think that's a very valid point. Linux isn't currently optimized to > > handle packets in device BAR. > > There are several issues here and you do need to address them in the > >

Re: [Qemu-devel] [PATCH 1/3] exec: add page_mask for address_space_do_translate

2017-06-04 Thread Peter Xu
On Fri, Jun 02, 2017 at 07:45:05PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 02, 2017 at 07:50:52PM +0800, Peter Xu wrote: > > The function is originally used for address_space_translate() and what > > we care about most is (xlat, plen) range. However for iotlb requests, we > > don't really ca

Re: [Qemu-devel] [PATCH 2/3] exec: simplify address_space_get_iotlb_entry

2017-06-04 Thread Peter Xu
On Fri, Jun 02, 2017 at 07:49:58PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 02, 2017 at 07:50:53PM +0800, Peter Xu wrote: > > This patch let address_space_get_iotlb_entry() to use the newly > > introduced page_mask parameter in address_space_do_translate(). Then we > > will be sure the IOTLB

Re: [Qemu-devel] [PATCH v2 5/6] pci: Make errp the last parameter of pci_add_capability()

2017-06-04 Thread Mao Zhongyi
Hi, Eduardo On 06/03/2017 01:45 AM, Eduardo Habkost wrote: On Fri, Jun 02, 2017 at 03:54:41PM +0800, Mao Zhongyi wrote: Add Error argument for pci_add_capability() to leverage the errp to pass info on errors. This way is helpful for its callers to make a better error handling when moving to 're

Re: [Qemu-devel] [PATCH v2 1/1] s390x: vmstatify config migration for virtio-ccw

2017-06-04 Thread Dong Jia Shi
* Halil Pasic [2017-06-02 16:05:31 +0200]: Hi Halil, Sorry for the late show up. I just found some nits, which could be ignored for me. > Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for > flexibility (extending using subsections) and for fun. > > To achieve this we need t

Re: [Qemu-devel] [PATCH 3/3] vhost: iommu: cache static mapping if there is

2017-06-04 Thread Peter Xu
On Fri, Jun 02, 2017 at 06:45:05PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 02, 2017 at 07:50:54PM +0800, Peter Xu wrote: > > This patch pre-heat vhost iotlb cache when passthrough mode enabled. > > > > Sometimes, even if user specified iommu_platform for vhost devices, > > IOMMU might still

Re: [Qemu-devel] [PATCH 0/3] exec: further refine address_space_get_iotlb_entry()

2017-06-04 Thread Peter Xu
On Fri, Jun 02, 2017 at 05:51:07PM +0300, Michael S. Tsirkin wrote: > On Fri, Jun 02, 2017 at 07:50:51PM +0800, Peter Xu wrote: > > With the patch applied: > > > > [PATCH v3] exec: fix address_space_get_iotlb_entry page mask > > (already in Paolo's pull request but not yet merged) > > > > Now

[Qemu-devel] [PATCHv2 1/5] spapr: Introduce DRC subclasses

2017-06-04 Thread David Gibson
Currently we only have a single QOM type for all DRCs, but lots of places where we switch behaviour based on the DRC's PAPR defined type. This is a poor use of our existing type system. So, instead create QOM subclasses for each PAPR defined DRC type. We also introduce intermediate subclasses for

Re: [Qemu-devel] [PATCH] Revert "Change net/socket.c to use socket_*() functions" again

2017-06-04 Thread Jason Wang
On 2017年05月06日 00:23, Daniel P. Berrange wrote: This reverts commit 883e4f7624e10b98d16d9adaffb8b1795664d899. This code changed net/socket.c from using socket()+connect(), to using socket_connect(). In theory this is great, but in practice this has completely broken the ability to connect the

Re: [Qemu-devel] [PATCH 3/3] vhost: iommu: cache static mapping if there is

2017-06-04 Thread Jason Wang
On 2017年06月05日 11:15, Peter Xu wrote: On Fri, Jun 02, 2017 at 06:45:05PM +0300, Michael S. Tsirkin wrote: On Fri, Jun 02, 2017 at 07:50:54PM +0800, Peter Xu wrote: This patch pre-heat vhost iotlb cache when passthrough mode enabled. Sometimes, even if user specified iommu_platform for vhost

[Qemu-devel] [PATCH v5 2/8] vmdk: Rename get_whole_cluster() to vmdk_perform_cow()

2017-06-04 Thread Ashijeet Acharya
Rename the existing function get_whole_cluster() to vmdk_perform_cow() as its sole purpose is to perform COW for the first and the last allocated clusters if needed. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 23 ++- 1 file changed, 14 insertio

[Qemu-devel] [PATCH v5 0/8] Optimize VMDK I/O by allocating multiple clusters

2017-06-04 Thread Ashijeet Acharya
Previously posted series patches: v1 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg02044.html v2 - http://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg05080.html v3 - http://lists.nongnu.org/archive/html/qemu-devel/2017-04/msg00074.html v4 - http://lists.nongnu.org/archive/htm

[Qemu-devel] [PATCH v5 6/8] vmdk: New functions to assist allocating multiple clusters

2017-06-04 Thread Ashijeet Acharya
Introduce two new helper functions handle_alloc() and vmdk_alloc_cluster_offset(). handle_alloc() helps to allocate multiple clusters at once starting from a given offset on disk and performs COW if necessary for first and last allocated clusters. vmdk_alloc_cluster_offset() helps to return the off

[Qemu-devel] [PATCH v5 1/8] vmdk: Move vmdk_find_offset_in_cluster() to the top

2017-06-04 Thread Ashijeet Acharya
Move the existing vmdk_find_offset_in_cluster() function to the top of the driver. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index a9bd22b..22

[Qemu-devel] [PATCH v5 3/8] vmdk: Rename get_cluster_offset() to vmdk_get_cluster_offset()

2017-06-04 Thread Ashijeet Acharya
Rename the existing get_cluster_offset() to vmdk_get_cluster_offset() and update name in all the callers accordingly. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 46 +++--- 1 file changed, 23 insertions(+), 23 deletions(-) d

[Qemu-devel] [PATCH v5 7/8] vmdk: Update metadata for multiple clusters

2017-06-04 Thread Ashijeet Acharya
Include a next pointer in VmdkMetaData struct to point to the previous allocated L2 table. Modify vmdk_L2update to start updating metadata for allocation of multiple clusters at once. Signed-off-by: Ashijeet Acharya --- block/vmdk.c | 128 ++---

[Qemu-devel] [PATCH v5 5/8] vmdk: Set maximum bytes allocated in one cycle

2017-06-04 Thread Ashijeet Acharya
Set the maximum bytes allowed to get allocated at once to be not more than the extent size boundary to handle writes at two separate extents appropriately. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-

[Qemu-devel] [PATCH v5 4/8] vmdk: Factor out metadata loading code out of vmdk_get_cluster_offset()

2017-06-04 Thread Ashijeet Acharya
Move the cluster tables loading code out of the existing vmdk_get_cluster_offset() function and implement it in separate get_cluster_table() and vmdk_l2load() functions. Signed-off-by: Ashijeet Acharya Reviewed-by: Fam Zheng --- block/vmdk.c | 153 ---

[Qemu-devel] [PATCH v5 8/8] vmdk: Make vmdk_get_cluster_offset() return cluster offset only

2017-06-04 Thread Ashijeet Acharya
vmdk_alloc_clusters() introduced earlier now handles the task of allocating clusters and performing COW when needed. Thus we can change vmdk_get_cluster_offset() to stick to the sole purpose of returning cluster offset using sector number. Update the changes at all call sites. Signed-off-by: Ashij

Re: [Qemu-devel] [PATCH V6 02/10] migration: pass MigrationIncomingState* into migration check functions

2017-06-04 Thread Alexey Perevalov
On 05/31/2017 08:54 PM, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: That tiny refactoring is necessary to be able to set UFFD_FEATURE_THREAD_ID while requesting features, and then to create downtime context in case when kernel supports it. Signed-off-by: Al

Re: [Qemu-devel] [PATCH v5 6/8] vmdk: New functions to assist allocating multiple clusters

2017-06-04 Thread Ashijeet Acharya
On Mon, Jun 5, 2017 at 11:23 AM, Ashijeet Acharya wrote: > Introduce two new helper functions handle_alloc() and > vmdk_alloc_cluster_offset(). handle_alloc() helps to allocate multiple > clusters at once starting from a given offset on disk and performs COW > if necessary for first and last alloc

Re: [Qemu-devel] [PATCH V6 06/10] migration: add postcopy blocktime ctx into MigrationIncomingState

2017-06-04 Thread Alexey Perevalov
On 05/24/2017 06:31 AM, Peter Xu wrote: On Tue, May 23, 2017 at 02:31:07PM +0300, Alexey Perevalov wrote: This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case when this feature is provided by kernel. PostcopyBlocktimeContext is incapsulated inside postcopy-ram.c, due to i

Re: [Qemu-devel] [PATCH v5 6/8] vmdk: New functions to assist allocating multiple clusters

2017-06-04 Thread Fam Zheng
On Mon, 06/05 11:37, Ashijeet Acharya wrote: > On Mon, Jun 5, 2017 at 11:23 AM, Ashijeet Acharya > wrote: > > Introduce two new helper functions handle_alloc() and > > vmdk_alloc_cluster_offset(). handle_alloc() helps to allocate multiple > > clusters at once starting from a given offset on disk a

<    1   2