Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-30 Thread Marc-André Lureau
Hi On Thu, May 11, 2017 at 6:30 PM Markus Armbruster wrote: > Marc-André Lureau writes: > > > > + * > > + * This work is licensed under the terms of the GNU LGPL, version 2.1 > or later. > > + * See the COPYING.LIB file in the top-level directory. > > + */ > > + > > +#ifndef QNUM_H > > +#define

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
30.05.2017 09:50, Vladimir Sementsov-Ogievskiy wrote: Thank you for this scenario. Hmm. So, as I need guarantee that image and bitmap are unchanged, bdrv_set_dirty should return error and fail the whole write. Ok? No, bad idea. As bdrv_set_dirty is called after write completed. 29.05.2017

Re: [Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

2017-05-30 Thread Thomas Huth
On 30.05.2017 07:20, Markus Armbruster wrote: > Thomas Huth writes: > >> We likely do not want to carry these legacy -drive options along forever. >> Let's emit a deprecation warning for the -drive options that have a >> replacement with the -device option, so that the (hopefully few) remaining >

Re: [Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
30.05.2017 10:31, Vladimir Sementsov-Ogievskiy wrote: 30.05.2017 09:50, Vladimir Sementsov-Ogievskiy wrote: Thank you for this scenario. Hmm. So, as I need guarantee that image and bitmap are unchanged, bdrv_set_dirty should return error and fail the whole write. Ok? No, bad idea. As bdrv_se

Re: [Qemu-devel] sharing directories with Windows guest - virtio pci p9 on Windows

2017-05-30 Thread Thomas Huth
On 30.05.2017 08:22, Behrooz Shabani wrote: [...] > Any information on how to have a shared storage between different running > VMs that would not require `-net user` is very much appreciated as well. If you need the storage just for transferring files, you could also try the "-device usb-mtp" ...

Re: [Qemu-devel] [PATCHv4 0/5] Clean up compatibility mode handling

2017-05-30 Thread Greg Kurz
On Tue, 30 May 2017 16:18:52 +1000 David Gibson wrote: > On Tue, May 30, 2017 at 01:14:16AM +0200, Greg Kurz wrote: > > On Fri, 26 May 2017 15:23:14 +1000 > > David Gibson wrote: > > > > [...] > > > > > > > > > Changes since v3: > > > * Backwards compatible -cpu handling now removes compa

[Qemu-devel] [PATCH 22/25] block/dirty-bitmap: add bdrv_remove_persistent_dirty_bitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Interface for removing persistent bitmap from its storage. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 18 ++ include/block/block_int.h| 3 +++ include/block/dirty-bitmap.h | 3 +++ 3 files c

[Qemu-devel] [PATCH 19/25] qmp: add autoload parameter to block-dirty-bitmap-add

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Optional. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- blockdev.c | 18 -- qapi/block-core.json | 6 +- 2 files changed, 21 insertions(+), 3 deletions(-) diff --git

[Qemu-devel] [PATCH 14/25] block/dirty-bitmap: add bdrv_dirty_bitmap_next()

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include/block/dirty-bitmap.h | 3 +++ 2 files changed, 10 insertions(+) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index c9b809e4b9..a3b8a1ea64

[Qemu-devel] [PATCH 03/25] hbitmap: improve dirty iter

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Make dirty iter resistant to resetting bits in corresponding HBitmap. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- include/qemu/hbitmap.h | 26 -- util/hbitmap.c | 23 ++- 2 files changed, 26 i

[Qemu-devel] [PATCH 01/25] specs/qcow2: fix bitmap granularity qemu-specific note

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow --- docs/specs/qcow2.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/specs/qcow2.txt b/docs/specs/qcow2.txt index 80cdfd0e91..dda53dd2a3 100644 --- a/docs/specs/qcow2.txt +++ b/docs/specs/qcow2.txt

[Qemu-devel] [PATCH 17/25] qcow2: add .bdrv_can_store_new_dirty_bitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_can_store_new_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: John Snow Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 51 +++ block/qcow2.c| 2 ++ block/qcow2.h| 4 3 files

[Qemu-devel] [PATCH 23/25] qcow2: add .bdrv_remove_persistent_dirty_bitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Realize .bdrv_remove_persistent_dirty_bitmap interface. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/qcow2-bitmap.c | 41 + block/qcow2.c| 1 + block/qcow2.h| 3 +++ 3 files changed

[Qemu-devel] [PATCH 09/25] block/dirty-bitmap: add readonly field to BdrvDirtyBitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
It will be needed in following commits for persistent bitmaps. If bitmap is loaded from read-only storage (and we can't mark it "in use" in this storage) corresponding BdrvDirtyBitmap should be read-only. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/dirty-bitmap.c | 28 +

[Qemu-devel] [PATCH 16/25] block: add bdrv_can_store_new_dirty_bitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
This will be needed to check some restrictions before making bitmap persistent in qmp-block-dirty-bitmap-add (this functionality will be added by future patch) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block.c | 22 +

[Qemu-devel] [PATCH 18/25] qmp: add persistent flag to block-dirty-bitmap-add

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Add optional 'persistent' flag to qmp command block-dirty-bitmap-add. Default is false. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- blockdev.c | 18 +- qapi/block-core.json | 8 +++-

[Qemu-devel] [PATCH 11/25] block/dirty-bitmap: add autoload field to BdrvDirtyBitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Mirror AUTO flag from Qcow2 bitmap in BdrvDirtyBitmap. This will be needed in future, to save this flag back to Qcow2 for persistent bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 15 +++ block/q

[Qemu-devel] [PATCH 05/25] block: fix bdrv_dirty_bitmap_granularity signature

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Make getter signature const-correct. This allows other functions with const dirty bitmap parameter use bdrv_dirty_bitmap_granularity(). Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Kevin Wolf --- block/dirty-bitmap.c | 2 +- i

[Qemu-devel] [PATCH 04/25] tests: add hbitmap iter test

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Test that hbitmap iter is resistant to bitmap resetting. Signed-off-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Denis V. Lunev Reviewed-by: Max Reitz Reviewed-by: John Snow --- tests/test-hbitmap.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/tests/test-hbitmap

[Qemu-devel] [PATCH 12/25] block: bdrv_close: release bitmaps after drv->bdrv_close

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Release bitmaps after 'if (bs->drv) { ... }' block. This will allow format driver to save persistent bitmaps, which will appear in following commits. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[Qemu-devel] [PATCH 02/25] specs/qcow2: do not use wording 'bitmap header'

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
A bitmap directory entry is sometimes called a 'bitmap header'. This patch leaves only one name - 'bitmap directory entry'. The name 'bitmap header' creates misunderstandings with 'qcow2 header' and 'qcow2 bitmap header extension' (which is extension of qcow2 header) Signed-off-by: Vladimir Sement

[Qemu-devel] [PATCH v19 00/25] qcow2: persistent dirty bitmaps

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Hi all! There is a new update of qcow2-bitmap series - v19. web: https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v19 git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap-v19) v19: rebased on master 05: move 'sign-off' over 'reviewed-by's 08: error_r

[Qemu-devel] [PATCH 13/25] block: introduce persistent dirty bitmaps

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
New field BdrvDirtyBitmap.persistent means, that bitmap should be saved by format driver in .bdrv_close and .bdrv_inactivate. No format driver supports it for now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/dirty-bitmap.c | 26 ++

[Qemu-devel] [PATCH 24/25] qmp: block-dirty-bitmap-remove: remove persistent

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Remove persistent bitmap from the storage on block-dirty-bitmap-remove. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- blockdev.c | 10 ++ qapi/block-core.json | 3 ++- 2 files changed, 12 insertions(+), 1 deletion(-) diff --gi

[Qemu-devel] [PATCH 25/25] block: release persistent bitmaps on inactivate

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
We should release them here to reload on invalidate cache. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block.c | 4 block/dirty-bitmap.c | 29 +++-- include/block/dirty-bitmap.h | 1 + 3 files changed, 28 insertions(+), 6 deletions(

[Qemu-devel] [PATCH 06/25] block/dirty-bitmap: add deserialize_ones func

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Add bdrv_dirty_bitmap_deserialize_ones() function, which is needed for qcow2 bitmap loading, to handle unallocated bitmap parts, marked as all-ones. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Kevin Wolf Reviewed-by: John Snow --- block/dirty-bitmap.c | 7 +++ include

[Qemu-devel] [PATCH 20/25] qmp: add x-debug-block-dirty-bitmap-sha256

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/dirty-bitmap.c | 5 + blockdev.c | 29 + include/block/dirty-bitmap.h | 2 ++ include/qemu/hbitmap.h | 8 qapi/block-co

[Qemu-devel] [PATCH 3/3] qemu-bridge-helper: Take ACL file gid into account

2017-05-30 Thread Michal Privoznik
There's a problem with the way we currently parse ACL files. The problem is, the bridge helper has usually SUID flag set and thus runs as root in which case all the ACL files are parsed (/etc/qemu/bridge.conf and all other files it includes). Therefore, if there's say bob.conf owned by root:bob and

[Qemu-devel] [PATCH 15/25] qcow2: add persistent dirty bitmaps support

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Store persistent dirty bitmaps in qcow2 image. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow2-bitmap.c | 475 +++ block/qcow2.c| 9 + block/qcow2.h| 1 + 3 files changed, 485 insertions(+) d

[Qemu-devel] [PATCH 08/25] qcow2: add bitmaps extension

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Add bitmap extension as specified in docs/specs/qcow2.txt. For now, just mirror extension header into Qcow2 state and check constraints. Also, calculate refcounts for qcow2 bitmaps, to not break qemu-img check. For now, disable image resize if it has bitmaps. It will be fixed later. Signed-off-by

[Qemu-devel] [PATCH 21/25] iotests: test qcow2 persistent dirty bitmap

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- tests/qemu-iotests/165 | 105 + tests/qemu-iotests/165.out | 5 +++ tests/qemu-iotests/group | 1 + 3 files changed, 111 insertions(+) create mode 100755 tests/qemu-iotes

[Qemu-devel] [PATCH 07/25] qcow2-refcount: rename inc_refcounts() and make it public

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
This is needed for the following patch, which will introduce refcounts checking for qcow2 bitmaps. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz Reviewed-by: John Snow --- block/qcow2-refcount.c | 53 ++ block/qcow2.h

Re: [Qemu-devel] [PULL 0/1] Silence "make check" warnings on NUMA test

2017-05-30 Thread Stefan Hajnoczi
On Tue, May 23, 2017 at 07:44:53AM -0300, Eduardo Habkost wrote: > The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: > > Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging > (2017-05-18 13:36:15 +0100) > > are available in the git repository

Re: [Qemu-devel] [PATCH v2 02/29] target/s390x: remove some Linux assumptions from IPTE

2017-05-30 Thread Thomas Huth
On 29.05.2017 21:24, Aurelien Jarno wrote: > Signed-off-by: Aurelien Jarno > --- > target/s390x/cpu.h| 2 ++ > target/s390x/mem_helper.c | 17 ++--- > target/s390x/mmu_helper.c | 4 +--- > 3 files changed, 13 insertions(+), 10 deletions(-) > > diff --git a/target/s390x/cpu.

[Qemu-devel] [PATCH v2 2/3] migration: loadvm handlers are not used

2017-05-30 Thread Juan Quintela
So we remove all traces of them. Signed-off-by: Juan Quintela --- include/migration/migration.h | 5 - include/migration/vmstate.h | 2 -- include/qemu/typedefs.h | 1 - migration/migration.c | 2 -- migration/savevm.c| 26 -- 5 files c

[Qemu-devel] [PATCH 10/25] qcow2: autoloading dirty bitmaps

2017-05-30 Thread Vladimir Sementsov-Ogievskiy
Auto loading bitmaps are bitmaps in Qcow2, with the AUTO flag set. They are loaded when the image is opened and become BdrvDirtyBitmaps for the corresponding drive. Extra data in bitmaps is not supported for now. Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Max Reitz --- block/qcow

[Qemu-devel] [PATCH v2 0/3] Remove of loadvm handlers

2017-05-30 Thread Juan Quintela
Hi Changes from v1 - store load_version_id field to SaveStateHandler - Adjust everything to use it Thanks to Laurent to point that to me. Please Review. [v1] We just have a loadvm handlers that are a new list only used in a single place. Just move everything to use the savevm_handlers (yes, it

[Qemu-devel] [PATCH v2 1/3] migration: Use savevm_handlers instead of loadvm copy

2017-05-30 Thread Juan Quintela
There is no reason for having the loadvm_handlers at all. There is only one use, and we can use the savevm handlers. We will remove the loadvm handlers on a following patch. Signed-off-by: Juan Quintela --- migration/savevm.c | 29 - 1 file changed, 16 insertions(+)

[Qemu-devel] [PATCH 0/3] Fix qemu-bridge-helper with SUID

2017-05-30 Thread Michal Privoznik
For more description see patch 3. Long story short, if the bridge helper runs with SUID, the mechanism we rely on (DAC denying access to ACL files) does not work. Michal Privoznik (3): qemu-bridge-helper: Reverse return value setting logic qemu-bridge-helper: Reverse return value setting logic

[Qemu-devel] [PATCH v2 3/3] migration: Remove section_id parameter from vmstate_load

2017-05-30 Thread Juan Quintela
Everything else assumes that we always load a device from its own savevm handler. Signed-off-by: Juan Quintela --- migration/savevm.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/migration/savevm.c b/migration/savevm.c index 14af5ad..e5dd7ef 100644 --- a/migrati

[Qemu-devel] [PATCH 2/3] qemu-bridge-helper: Reverse return value setting logic in parse_acl_file

2017-05-30 Thread Michal Privoznik
Just like in the previous commit, it's better to have just a single point of exit from a function as we can have cleanup code just once instead of copying it all over the place. Signed-off-by: Michal Privoznik --- qemu-bridge-helper.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deleti

[Qemu-devel] [PATCH 1/3] qemu-bridge-helper: Reverse return value setting logic

2017-05-30 Thread Michal Privoznik
Instead of initializing the return value @ret to a success value and then having to reset it to failure value in every error path, we can do the opposite. Initialize the value to failure value and then set it to success value only after we've succeeded in all we've attempted. Signed-off-by: Michal

Re: [Qemu-devel] [PULL 00/18] ppc-for-2.10 queue 20170525

2017-05-30 Thread Stefan Hajnoczi
On Thu, May 25, 2017 at 01:51:14PM +1000, David Gibson wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repository at:

Re: [Qemu-devel] [PULL 0/9] QAPI patches for 2017-05-23

2017-05-30 Thread Stefan Hajnoczi
On Tue, May 23, 2017 at 02:30:29PM +0200, Markus Armbruster wrote: > The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: > > Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging > (2017-05-18 13:36:15 +0100) > > are available in the git repositor

[Qemu-devel] [PATCH 1/1] coroutine-lock: do not touch coroutine after another one has been entered

2017-05-30 Thread Roman Pen
Submission of requests on linux aio is a bit tricky and can lead to requests completions on submission path: 44713c9e8547 ("linux-aio: Handle io_submit() failure gracefully") 0ed93d84edab ("linux-aio: process completions from ioq_submit()") That means that any coroutine which has been yielded in

[Qemu-devel] [PATCH] virtio-serial-bus: Unset hotplug handler when unrealize

2017-05-30 Thread Ladi Prosek
Virtio serial device controls the lifetime of virtio-serial-bus and virtio-serial-bus links back to the device via its hotplug-handler property. This extra ref-count prevents the device from getting finalized, leaving the VirtIODevice memory listener registered and leading to use-after-free later o

Re: [Qemu-devel] [PATCH v2 03/29] target/s390x: implement local-TLB-clearing in IPTE

2017-05-30 Thread Thomas Huth
On 29.05.2017 21:24, Aurelien Jarno wrote: > And at the same time make IPTE SMP aware. > > Signed-off-by: Aurelien Jarno > --- > target/s390x/helper.h | 2 +- > target/s390x/mem_helper.c | 19 --- > target/s390x/translate.c | 6 +- > 3 files changed, 18 insertions(+),

Re: [Qemu-devel] [PATCH v2 14/29] target/s390x: improve 24-bit and 31-bit addresses read

2017-05-30 Thread Thomas Huth
On 29.05.2017 21:24, Aurelien Jarno wrote: > Improve fix_address to also handle the 24-bit mode. Rename fix_address > to wrap_address to better explain what is changed. > > Replace the calls to get_address with x2 = 0 and b2 = 0 by > call to wrap_address, leading to the removal of this function. R

Re: [Qemu-devel] [PATCHv4 2/5] migration: Mark CPU states dirty before incoming migration/loadvm

2017-05-30 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Mon, May 29, 2017 at 10:46:05PM +0200, Greg Kurz wrote: > > On Fri, 26 May 2017 15:23:16 +1000 > > David Gibson wrote: > > > > > As a rule, CPU internal state should never be updated when > > > !cpu->kvm_vcpu_dirty (or the HAX equivalent).

Re: [Qemu-devel] [PATCH 1/2] nvdimm: warn if the backend is not a DAX device

2017-05-30 Thread Stefan Hajnoczi
On Fri, May 26, 2017 at 10:24:37AM +0800, Haozhong Zhang wrote: > Applications in Linux guest that use device-dax never trigger flush > that can be trapped by KVM/QEMU. Meanwhile, if the host backend is not > device-dax, QEMU cannot guarantee the persistence of guest writes. > Before solving this f

Re: [Qemu-devel] [PATCH 2/2] hostmem-file: add an attribute 'align' to set its alignment

2017-05-30 Thread Stefan Hajnoczi
On Fri, May 26, 2017 at 10:24:38AM +0800, Haozhong Zhang wrote: > file_ram_alloc() currently maps the backend file via mmap to a virtual > address aligned to the value returned by qemu_fd_getpagesize(). When a > DAX device (e.g. /dev/dax0.0) is used as the backend file, its kernel > mmap implementa

Re: [Qemu-devel] [PATCH v7 19/20] qcow2: report encryption specific image information

2017-05-30 Thread Daniel P. Berrange
On Mon, May 29, 2017 at 11:53:01AM +0200, Markus Armbruster wrote: > "Daniel P. Berrange" writes: > > > On Thu, May 25, 2017 at 02:52:30PM -0500, Eric Blake wrote: > >> On 05/25/2017 11:38 AM, Daniel P. Berrange wrote: > >> > Currently 'qemu-img info' reports a simple "encrypted: yes" > >> > fiel

Re: [Qemu-devel] [PATCH v2 29/29] target/s390x: update maximum TCG model to z800

2017-05-30 Thread Thomas Huth
On 29.05.2017 21:24, Aurelien Jarno wrote: > At the same time fix the TCG version of get_max_cpu_model to return the > maximum model like on KVM. Remove the long-displacement facility from > the additional features as it is included in the z800. > > Signed-off-by: Aurelien Jarno > --- > target/s

Re: [Qemu-devel] [PATCH] msi: remove return code for msi_init()

2017-05-30 Thread Paolo Bonzini
> Note that a board that doesn't support MSI can take MSI-capable devices > just fine. Only the broken boards can't. > > Obviously, broken boards should be fixed. Once they all are, we can > (and should!) remove msi_nonbroken. That only works if we know what the broken boards are. Right now,

Re: [Qemu-devel] [PATCH v2 1/3] migration: Use savevm_handlers instead of loadvm copy

2017-05-30 Thread Laurent Vivier
On 30/05/2017 10:37, Juan Quintela wrote: > There is no reason for having the loadvm_handlers at all. There is > only one use, and we can use the savevm handlers. > > We will remove the loadvm handlers on a following patch. > > Signed-off-by: Juan Quintela Reviewed-by: Laurent Vivier > --- >

Re: [Qemu-devel] [PULL 00/22] Docker and block patches

2017-05-30 Thread Stefan Hajnoczi
On Fri, May 26, 2017 at 03:52:24PM +0800, Fam Zheng wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [RESEND PATCH 1/2] nvdimm: warn if the backend is not a DAX device

2017-05-30 Thread Daniel P. Berrange
On Fri, May 26, 2017 at 08:25:20AM -0700, Dan Williams wrote: > On Fri, May 26, 2017 at 7:38 AM, Daniel P. Berrange > wrote: > > On Thu, May 25, 2017 at 08:34:23PM -0700, Dan Williams wrote: > >> On Thu, May 25, 2017 at 7:32 PM, Haozhong Zhang > >> wrote: > >> > Applications in Linux guest that

Re: [Qemu-devel] [PULL v3 00/22] Misc patches for 2017-05-19

2017-05-30 Thread Stefan Hajnoczi
On Fri, May 26, 2017 at 04:38:23PM +0200, Paolo Bonzini wrote: > The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: > > Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging > (2017-05-18 13:36:15 +0100) > > are available in the git repository at

Re: [Qemu-devel] risugen: test only instructions that begin with the letter F

2017-05-30 Thread Peter Maydell
On 4 May 2017 at 20:39, G 3 wrote: > I'm trying to test all the floating point instructions only. They tend to > begin with the letter f. Is there a way to have risugen only use > instructions that begin with the letter F? Yes, use the --pattern option with a suitable regular expression. (in this

Re: [Qemu-devel] [PATCH v2] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

2017-05-30 Thread Thomas Huth
On 10.05.2017 17:34, Thomas Huth wrote: > We don't want to carry along old machine types forever. If we are able to > remove the pc machines up to 0.13 one day for example, this would allow > us to eventually kill the code for rombar=0 (i.e. where QEMU copies ROM > BARs directly to low memory). Eve

Re: [Qemu-devel] [Qemu-block] [PULL 00/12] Block patches

2017-05-30 Thread Stefan Hajnoczi
On Fri, May 26, 2017 at 03:23:52PM -0400, Jeff Cody wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 05:50:36PM +0200, Kevin Wolf wrote: > After writing this, my gut feeling is that -object might well be worth > it. Yes, a real -object would be cleanest. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PULL 0/3] slirp updates

2017-05-30 Thread Stefan Hajnoczi
On Sat, May 27, 2017 at 11:46:15PM +0200, Samuel Thibault wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repository a

Re: [Qemu-devel] 'blank' address space for unknown arm peripherals?

2017-05-30 Thread Peter Maydell
On 7 May 2017 at 01:23, Marty Plummer wrote: > Its my understanding that for creating machine definitions for qemu one > uses what amount to 'drivers' or 'hardware simulations'. I was wondering > if there was what amounted to a blank or raw memory area one could use > as a placeholder for a periph

Re: [Qemu-devel] [PATCH 1/1] coroutine-lock: do not touch coroutine after another one has been entered

2017-05-30 Thread Fam Zheng
On Tue, 05/30 10:53, Roman Pen wrote: > Submission of requests on linux aio is a bit tricky and can lead to > requests completions on submission path: > > 44713c9e8547 ("linux-aio: Handle io_submit() failure gracefully") > 0ed93d84edab ("linux-aio: process completions from ioq_submit()") > > That

Re: [Qemu-devel] [PULL 00/22] Docker and block patches

2017-05-30 Thread Fam Zheng
On Tue, 05/30 10:19, Stefan Hajnoczi wrote: > On Fri, May 26, 2017 at 03:52:24PM +0800, Fam Zheng wrote: > > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into > > staging (2017-05-23 15:01:31 +

Re: [Qemu-devel] [PATCH 1/1] coroutine-lock: do not touch coroutine after another one has been entered

2017-05-30 Thread Paolo Bonzini
On 30/05/2017 10:53, Roman Pen wrote: > The fix is obvious: use temporal queue and do not touch coroutine after > first qemu_coroutine_enter() is invoked. > > The issue is quite rare and happens every ~12 hours on very high IO load > (building linux kernel with -j512 inside guest) when IO thrott

Re: [Qemu-devel] [PULL 00/22] Docker and block patches

2017-05-30 Thread Paolo Bonzini
On 30/05/2017 11:33, Fam Zheng wrote: > On Tue, 05/30 10:19, Stefan Hajnoczi wrote: >> On Fri, May 26, 2017 at 03:52:24PM +0800, Fam Zheng wrote: >>> The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: >>> >>> Merge remote-tracking branch 'jasowang/tags/net-pull-request

Re: [Qemu-devel] [PATCH v2 2/3] migration: loadvm handlers are not used

2017-05-30 Thread Laurent Vivier
On 30/05/2017 10:37, Juan Quintela wrote: > So we remove all traces of them. > > Signed-off-by: Juan Quintela Reviewed-by: Laurent Vivier > --- > include/migration/migration.h | 5 - > include/migration/vmstate.h | 2 -- > include/qemu/typedefs.h | 1 - > migration/migration.c

Re: [Qemu-devel] [PATCH v2 3/3] migration: Remove section_id parameter from vmstate_load

2017-05-30 Thread Laurent Vivier
On 30/05/2017 10:37, Juan Quintela wrote: > Everything else assumes that we always load a device from its own > savevm handler. > > Signed-off-by: Juan Quintela Reviewed-by: Laurent Vivier > --- > migration/savevm.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff

Re: [Qemu-devel] Throttling groups vs filter nodes

2017-05-30 Thread Kevin Wolf
[ Cc: qemu-block - noticed only now that it's missing ] Am 29.05.2017 um 22:57 hat Manos Pitsidianakis geschrieben: > On Mon, May 29, 2017 at 05:05:17PM +0200, Alberto Garcia wrote: > >On Sat 27 May 2017 09:56:03 AM CEST, Stefan Hajnoczi wrote: > >>A quirk in the current implementation is that the

Re: [Qemu-devel] Future of SoftFloat use in QEMU

2017-05-30 Thread Peter Maydell
On 9 May 2017 at 02:56, Richard Henderson wrote: > Another possibility is the code that's shared between the linux kernel > (include/math-emu) and glibc (soft-fp). The glibc version has support for > f16 while the kernel doesn't. But the glibc version is LGPL 2.1, which I'd > expect to be ok. >

Re: [Qemu-devel] [PULL 00/13] pci, virtio, vhost: fixes

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 03:18:30AM +0300, Michael S. Tsirkin wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repositor

Re: [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 11:05:29AM +0200, Greg Kurz wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [PULL 0/9] usb patch queue

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 03:09:47PM +0200, Gerd Hoffmann wrote: > Hi, > > Here comes the usb patch queue. As usual some bugfixes, legacy options > and hmp commands are deprecated, xhci is splitted so nec-xhci can have > its own config option. > > please pull, > Gerd > > The following changes

Re: [Qemu-devel] [Qemu-block] [PULL 00/15] Block layer patches

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 05:06:39PM +0200, Kevin Wolf wrote: > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging > (2017-05-23 15:01:31 +0100) > > are available in the git repository at: >

Re: [Qemu-devel] [PATCH] simpletrace: Improve the error message if event is not declared

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 01:30:04PM -0300, Jose Ricardo Ziviani wrote: > Today, if we use a trace-event file which does not declare an event > existing in the log file we'll get the following error: > > $ scripts/simpletrace.py trace-events trace-68508 > Traceback (most recent call last): > File

Re: [Qemu-devel] sharing directories with Windows guest - virtio pci p9 on Windows

2017-05-30 Thread Behrooz Shabani
Thanks Thomas. A question though: is it gonna be writable by guest? I'm asking because what I found about this feature mentioned that it's readonly ATM. http://events.linuxfoundation.org/sites/events/files/slides/Qemu_USB.pdf https://lists.gnu.org/archive/html/qemu-devel/2014-04/msg03466.html On

Re: [Qemu-devel] [PATCH 2/3] hw/intc/arm_gicv3_cpuif: Don't let BPR be set below its minimum

2017-05-30 Thread Peter Maydell
On 14 May 2017 at 06:31, Philippe Mathieu-Daudé wrote: > On 04/26/2017 02:13 PM, Peter Maydell wrote: >> +minval = (grp == GICV3_G1NS) ? GIC_MIN_BPR_NS : GIC_MIN_BPR; >> +if (value < minval) { >> +value = minval; >> +} >> + > > > which is: > > if (grp == GICV3_G1NS) { >

Re: [Qemu-devel] sparc64 linux-user status

2017-05-30 Thread Artyom Tarasenko
On Thu, May 25, 2017 at 9:56 AM, Laurent Vivier wrote: > Le 22/05/2017 à 15:45, Alex Bennée a écrit : >> Hi, >> >> While looking at some of the docker cross-build patches I thought I'd >> checkout if I could still bootstrap some Debian linux-user images. I >> made some tweaks to allow debootstrap

Re: [Qemu-devel] [PULL 1/5] target/sh4: log unauthorized accesses using qemu_log_mask

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 09:30:12PM +0200, Aurelien Jarno wrote: > qemu_log_mask() is preferred over fprintf() for logging errors. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > target/sh4/helper.c | 2 +- > 1 file changed, 1 ins

Re: [Qemu-devel] [PATCH 01/12] migration: Introduce announce parameters

2017-05-30 Thread Juan Quintela
Vladislav Yasevich wrote: > Add parameters that control RARP/GARP announcement timeouts. > The parameters structure is added to the QAPI and a qmp command > is added to set/get the parameter data. > > Based on work by "Dr. David Alan Gilbert" > > Signed-off-by: Vladislav Yasevich Hi > diff --g

Re: [Qemu-devel] [PATCH 1/1] coroutine-lock: do not touch coroutine after another one has been entered

2017-05-30 Thread Roman Penyaev
On Tue, May 30, 2017 at 11:35 AM, Paolo Bonzini wrote: > > > On 30/05/2017 10:53, Roman Pen wrote: >> The fix is obvious: use temporal queue and do not touch coroutine after >> first qemu_coroutine_enter() is invoked. >> >> The issue is quite rare and happens every ~12 hours on very high IO load >

Re: [Qemu-devel] [PATCH 02/12] migration: Introduce announcement timer

2017-05-30 Thread Juan Quintela
Vladislav Yasevich wrote: > Introdec an annoucement timer structure and initialization to > be used by for self-annoucement. > > Based on the work by Germano Veit Michel > > Signed-off-by: Vlad Yasevich Please, pretty please, create them in net/somewhere, or at least create include/migration/n

Re: [Qemu-devel] sparc64 linux-user status

2017-05-30 Thread Alex Bennée
Mark Cave-Ayland writes: > On 22/05/17 14:45, Alex Bennée wrote: > >> Hi, >> >> While looking at some of the docker cross-build patches I thought I'd >> checkout if I could still bootstrap some Debian linux-user images. I >> made some tweaks to allow debootstrap to bootstrap from Debian's ports

Re: [Qemu-devel] [PATCH] virtio-serial-bus: Unset hotplug handler when unrealize

2017-05-30 Thread Paolo Bonzini
On 30/05/2017 10:59, Ladi Prosek wrote: > Virtio serial device controls the lifetime of virtio-serial-bus and > virtio-serial-bus links back to the device via its hotplug-handler > property. This extra ref-count prevents the device from getting > finalized, leaving the VirtIODevice memory listene

[Qemu-devel] [PATCH v2 1/1] coroutine-lock: do not touch coroutine after another one has been entered

2017-05-30 Thread Roman Pen
Submission of requests on linux aio is a bit tricky and can lead to requests completions on submission path: 44713c9e8547 ("linux-aio: Handle io_submit() failure gracefully") 0ed93d84edab ("linux-aio: process completions from ioq_submit()") That means that any coroutine which has been yielded in

Re: [Qemu-devel] [PATCH 03/12] migration: Switch to using announcement timer

2017-05-30 Thread Juan Quintela
Vladislav Yasevich wrote: > Switch qemu_announce_self and virtio annoucements to use > the announcement timer framework. This makes sure that both > timers use the same timeouts and number of annoucement attempts > > Based on work by Dr. David Alan Gilbert > > Signed-off-by: Vladislav Yasevich

[Qemu-devel] [RFC] QEMU 2.10 release schedule

2017-05-30 Thread Stefan Hajnoczi
Here is a first stab at the next release schedule: Beginning of development phase: 2017-04-20 Soft feature freeze: 2017-07-18 -rc0: 2017-07-25 -rc1: 2017-08-01 -rc2: 2017-08-08 -rc3: 2017-08-15 -rc4: 2017-08-22 Thoughts? Stefan

Re: [Qemu-devel] [PATCH 06/12] qmp: Expose qemu_announce_self as a qmp command

2017-05-30 Thread Juan Quintela
Vladislav Yasevich wrote: > Add a qmp command that can trigger guest announcements. > > Based on work of Germano Veit Michel > > Signed-off-by: Vladislav Yasevich > --- > migration/savevm.c | 14 ++ > qapi-schema.json | 19 +++ > 2 files changed, 33 insertions(+) >

Re: [Qemu-devel] [PATCH 07/12] migration: Allow for a limited number of announce timers

2017-05-30 Thread Juan Quintela
Vladislav Yasevich wrote: > We currently create a new announcement timer every time > qemu_announce_self() is called. Since this is now a qmp > command, this can lead to abuse. Limit the number of > timers that are created. Give QMP interface and migration > process 1 timer each. This way, QM

Re: [Qemu-devel] [PATCH 08/12] announce_timer: Add ability to reset an existing

2017-05-30 Thread Juan Quintela
Vladislav Yasevich wrote: > It is now potentially possible to issue annouce-self command in a tight > loop. Instead of doing nother, we can reset the timeout pararameters, nother? > static void qemu_announce_self_once(void *opaque) > { > AnnounceTimer *timer = (AnnounceTimer *)opaque; >

Re: [Qemu-devel] [PULL 2/5] target/sh4: fix reset when using a kernel and an initrd

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 09:30:13PM +0200, Aurelien Jarno wrote: > When a masked exception happens, the SH4 CPU generates a non-masked > reset exception, which then jumps to the reset vector at address > 0xA000. While this is emulated correctly in QEMU, this does not > work when using a kernel a

Re: [Qemu-devel] [PULL 1/5] target/sh4: log unauthorized accesses using qemu_log_mask

2017-05-30 Thread Stefan Hajnoczi
On Mon, May 29, 2017 at 09:30:12PM +0200, Aurelien Jarno wrote: > qemu_log_mask() is preferred over fprintf() for logging errors. > > Reviewed-by: Philippe Mathieu-Daudé > Reviewed-by: Richard Henderson > Signed-off-by: Aurelien Jarno > --- > target/sh4/helper.c | 2 +- > 1 file changed, 1 ins

Re: [Qemu-devel] [PATCH 09/12] hmp: add announce paraters info/set

2017-05-30 Thread Juan Quintela
Vladislav Yasevich wrote: > Add HMP command to control and read annoucment parameters. > > Signed-off-by: Vladislav Yasevich Reviewed-by: Juan Quintela > + cleanup: > +if (err) { > +error_report_err(err); > +} > +} My understanding is that this the "cool way" to spell this n

Re: [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525

2017-05-30 Thread Greg Kurz
On Tue, 30 May 2017 10:42:12 +0100 Stefan Hajnoczi wrote: > On Mon, May 29, 2017 at 11:05:29AM +0200, Greg Kurz wrote: > > The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60: > > > > Merge remote-tracking branch 'jasowang/tags/net-pull-request' into > > staging (2017-

Re: [Qemu-devel] EL2\EL3 support for Aarch64

2017-05-30 Thread Peter Maydell
On 19 May 2017 at 14:29, Alex Bennée wrote: > > Sergey Smolov writes: > >> Hello, List! >> >> Could you tell me, what is the current state for EL2\EL3 (Aarch64)? >> Whether they are fully supported, or not? >> Am I need to use any command line options to enable them for Aarch64 >> assembler progr

Re: [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525

2017-05-30 Thread Daniel P. Berrange
On Tue, May 30, 2017 at 12:21:12PM +0200, Greg Kurz wrote: > On Tue, 30 May 2017 10:42:12 +0100 > Stefan Hajnoczi wrote: > > > On Mon, May 29, 2017 at 11:05:29AM +0200, Greg Kurz wrote: > > > The following changes since commit > > > 9964e96dccf7f7c936ee854a795415d19b60: > > > > > > Merge

Re: [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525

2017-05-30 Thread Greg Kurz
On Tue, 30 May 2017 11:26:22 +0100 "Daniel P. Berrange" wrote: > On Tue, May 30, 2017 at 12:21:12PM +0200, Greg Kurz wrote: > > On Tue, 30 May 2017 10:42:12 +0100 > > Stefan Hajnoczi wrote: > > > > > On Mon, May 29, 2017 at 11:05:29AM +0200, Greg Kurz wrote: > > > > The following changes si

Re: [Qemu-devel] [PATCH v2] hw/i386: Deprecate the machines pc-0.10 to pc-1.2

2017-05-30 Thread Gerd Hoffmann
Hi, > > v2: > >  - Deprecate machines up to pc-1.2 > > > >  hw/i386/pc_piix.c | 9 + > >  1 file changed, 9 insertions(+) > > > > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > > index 9f102aa..aace378 100644 > > --- a/hw/i386/pc_piix.c > > +++ b/hw/i386/pc_piix.c > > @@ -38,6 +38

  1   2   3   4   5   >