Hi
- Original Message -
> Hi Marc-André,
>
> On 05/09/2017 08:33 AM, Marc-André Lureau wrote:
> > Only the console handle shouldn't be closed, however, the "file" handle
> > should.
>
> Correct.
>
> >
> > Signed-off-by: Marc-André Lureau
> > ---
> > chardev/char-win.h | 5 ++---
>
Igor Mammedov writes:
> On Fri, 26 May 2017 16:29:25 +0800
> Mao Zhongyi wrote:
>
>> ioh3420_interrupts_init() and its callers, rp_realize() and
>> pci_qdev_realize() fill error message to local_err, then
>> propagate it to errp by error_porpagate(), which's not necessary.
>> So eliminate it and
Initialize IGD quirks a bit earlier since we're going to support IGD
stolen memory under both primary mode (legacy mode) and secondary mode
and we need one extra memory region from IGD quirks.
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/pci-quirks.c | 30 +-
This patch series are aim to refine the IGD stolen memory support in QEMU.
Some features of Intel HW relies on the stolen memory to work, but some of
registers used to indicate the base address of stolen memory can only be
programmed once after system is powered-up. This will cause problems if
the
This patch introduces device descriptions for Intel platforms. Most of
the Intel device definitions come from i915.
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/Makefile.objs| 2 +-
hw/vfio/intel-platform.c | 366 +++
hw/vfio/in
We still keep using VM dedicated memory for isolation to support IGD
stolen in the guest. Becuase of the PA of the stolen memory can not be
moved after the system is powered-up, we wish the PA of the guest stolen
memory can sit in the same PA of host. A new memory region is allocated,
and the memor
This patch introduces device descriptions for Intel platforms. Most of
the Intel device definitions come from i915.
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/Makefile.objs| 2 +-
hw/vfio/intel-platform.c | 366 +++
hw/vfio/in
Clear the whole GGTT page tables after the quirk is initialized. Obtain
the total size of GGTT and the entry size of one GGTT entry from
intel_device_info().
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/pci-quirks.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(
Remove extra quirks, old definitions and functions. Once the new Intel
platform definition is introduced, and the PA of guest stolen memory
equals to the PA of host stolen memory, they are not necessary anymore.
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/pci-quirks.c | 209 ++
We still keep using VM dedicated memory for isolation to support IGD
stolen in the guest. Becuase of the PA of the stolen memory can not be
moved after the system is powered-up, we wish the PA of the guest stolen
memory can sit in the same PA of host. A new memory region is allocated,
and the memor
This patch series are aim to refine the IGD stolen memory support in QEMU.
Some features of Intel HW relies on the stolen memory to work, but some of
registers used to indicate the base address of stolen memory can only be
programmed once after system is powered-up. This will cause problems if
the
Initialize IGD quirks a bit earlier since we're going to support IGD
stolen memory under both primary mode (legacy mode) and secondary mode
and we need one extra memory region from IGD quirks.
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/pci-quirks.c | 30 +-
Also setup IGD stolen memory under secondary mode as some HW functions
might need the stolen memory anyway.
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/pci-quirks.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/hw/vfio/pci-quirks.c b/h
Clear the whole GGTT page tables after the quirk is initialized. Obtain
the total size of GGTT and the entry size of one GGTT entry from
intel_device_info().
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/pci-quirks.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(
Also setup IGD stolen memory under secondary mode as some HW functions
might need the stolen memory anyway.
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/pci-quirks.c | 18 +++---
1 file changed, 11 insertions(+), 7 deletions(-)
diff --git a/hw/vfio/pci-quirks.c b/h
Hi Alex:
This the RFC patch of my ides in previous email. Could you shed
some lights here? :)
Thanks,
Zhi.
On 05/30/17 01:30, Zhi Wang wrote:
This patch series are aim to refine the IGD stolen memory support in QEMU.
Some features of Intel HW relies on the stolen memory to work, but some
Remove extra quirks, old definitions and functions. Once the new Intel
platform definition is introduced, and the PA of guest stolen memory
equals to the PA of host stolen memory, they are not necessary anymore.
Suggested-by: Xiong Zhang
Signed-off-by: Zhi Wang
---
hw/vfio/pci-quirks.c | 209 ++
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Subject: [Qemu-devel] [RFC 0/6] Refine IGD stolen memory support in VFIO
Message-id: 1496079043-26694-1-git-send-email-zhi.a.w...@intel.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=ba
Hi,
This is the last batch of patches I have pending for chardev for
now. They are mostly windows and headers related, and various small
improvements.
Comments welcome,
Thanks
v2:
- rename skip_free->keep_open, all->write_all
- add a patch moving char devices to chardev/
- patch reordering to re
win_chr_read_poll() is always used before win_chr_read().
We can easily fold win_chr_readfile() too.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
chardev/char-win.h | 2 +-
chardev/char-win.c | 35 +--
2 files changed, 10 insertions(+
Those 2 functions are specific to serial chardev, make it more clear.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
chardev/char-win.h| 2 +-
chardev/char-serial.c | 2 +-
chardev/char-win.c| 8
3 files changed, 6 insertions(+), 6 deletions(-)
diff -
The "len" argument can be passed directly to win_chr_read()
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
chardev/char-win.h | 1 -
chardev/char-win.c | 16 +++-
2 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/chardev/char-win.h b/chardev/
Those are apparently unnecessary includes.
Signed-off-by: Marc-André Lureau
---
hw/arm/bcm2835_peripherals.c | 1 -
hw/char/imx_serial.c | 1 -
hw/display/xenfb.c | 1 -
hw/i386/xen/xen-hvm.c| 1 -
hw/mips/mips_fulong2e.c | 1 -
hw/mips/mips_malta.c | 1 -
Signed-off-by: Marc-André Lureau
---
include/chardev/char-parallel.h | 20 +++-
include/chardev/char-serial.h | 22 ++
include/chardev/char.h | 36
backends/wctablet.c | 2 +-
hw/arm/strongarm.c
hcom is the name of the file handle, regardless of the actual chardev
driver (serial, file, console etc..). Rename it to be more explicit.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
chardev/char-win.h | 2 +-
chardev/char-pipe.c | 10 +-
chardev/char-win.
Only the console handle shouldn't be closed, however, the "file" handle
should.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
chardev/char-win.h | 5 ++---
chardev/char-console.c | 2 +-
chardev/char-file.c| 2 +-
chardev/char-win.c | 12
4
Suggested by Paolo Bonizini during series review.
Signed-off-by: Marc-André Lureau
---
{backends => chardev}/baum.c | 0
{backends => chardev}/msmouse.c | 0
spice-qemu-char.c => chardev/spice.c | 2 +-
{backends => chardev}/testdev.c | 0
{backends => chardev}/wctablet.c
Avoid accessing CharBackend directly, use qemu_chr_be_* methods instead.
be->chr_read should exists if qemu_chr_be_can_write() is true.
(use qemu_chr_be_write(), _impl() bypasses replay)
Signed-off-by: Marc-André Lureau
Reviewed-by: Andrzej Zaborowski
---
hw/bt/hci-csr.c | 9 +++--
1 file
Move all the fronted struct and methods to a seperate unit. This avoids
accidentally mixing backend and frontend calls, and helps with readibilty.
Make qemu_chr_replay() a macro shared by both char and char-fe.
Export qemu_chr_write(), and use a macro for qemu_chr_write_all()
(nb: yes, CharBacke
qemu_chr_fe_write() is similar to qemu_chr_write_all(): the later write
all with a chardev backend.
Make qemu_chr_write() and qemu_chr_fe_write_buffer() take an 'all'
argument. If false, handle 'partial' write the way qemu_chr_fe_write()
use to, and call qemu_chr_write() from qemu_chr_fe_write().
So they are all in one place. The following patch will move serial &
parallel declarations to the respective headers.
Signed-off-by: Marc-André Lureau
---
{chardev => include/chardev}/char-fd.h| 2 +-
{chardev => include/chardev}/char-io.h| 2 +-
{chardev => include/chardev}/ch
This simplifies removing a backend for a frontend user (no need to
retrive the associated driver and seperate delete call etc).
NB: many frontends have questionable handling of ending a chardev. They
should probably delete the backend to prevent broken reusage.
Signed-off-by: Marc-André Lureau
-
There is no clear reason to have those functions associated with
frontend.
Signed-off-by: Marc-André Lureau
Reviewed-by: Philippe Mathieu-Daudé
---
chardev/char.c | 15 +++
1 file changed, 7 insertions(+), 8 deletions(-)
diff --git a/chardev/char.c b/chardev/char.c
index 3d5316166e
Marc-André Lureau writes:
> Hi
>
> On Fri, May 26, 2017 at 9:49 AM Kamil Rytarowski wrote:
>
>> Currently ivshmem requires eventfd() which is Linux specific.
>> Do not and build it unconditionally on every Linux/BSD/Solaris.
>>
>>
> I think it should be able to use pipe fallback from event_notif
Hi,
This series failed automatic build test. Please find the testing commands and
their output below. If you have docker installed, you can probably reproduce it
locally.
Type: series
Subject: [Qemu-devel] [RFC 0/6] Refine IGD stolen memory support in VFIO
Message-id: 1496079043-26694-1-git-send-
The following changes since commit 9964e96dccf7f7c936ee854a795415d19b60:
Merge remote-tracking branch 'jasowang/tags/net-pull-request' into staging
(2017-05-23 15:01:31 +0100)
are available in the git repository at:
https://github.com/gkurz/qemu.git tags/for-upstream
for you to fetch c
These bits aren't related to the transport so let's move them to the core
code.
Signed-off-by: Greg Kurz
Reviewed-by: Stefano Stabellini
---
hw/9pfs/9p.c | 8 +++-
hw/9pfs/9p.h | 2 +-
hw/9pfs/virtio-9p-device.c | 8 +---
hw/9pfs/xen-9p-backend.c | 6 +-
Since chroot() doesn't change the current directory, it is indeed a good
practice to chdir() to the target directory and then then chroot(), or
to chroot() to the target directory and then chdir("/").
The current code does neither of them actually. Let's go for the latter.
This doesn't fix any se
When trying to remove a file from a directory, both created in non-mapped
mode, the file remains and EBADF is returned to the guest.
This is a regression introduced by commit "df4938a6651b 9pfs: local:
unlinkat: don't follow symlinks" when fixing CVE-2016-9602. It changed the
way we unlink the met
Only pdu_complete() needs to notify the client that a request has completed.
Signed-off-by: Greg Kurz
Reviewed-by: Stefano Stabellini
---
hw/9pfs/9p.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c
index b3048371a8ee..a25d31e62f1c 100644
--
When using the mapped-file security, credentials are stored in a metadata
directory located in the parent directory. This is okay for all paths with
the notable exception of the root path, since we don't want and probably
can't create a metadata directory above the virtfs directory on the host.
Th
These v9fs_co_name_to_path() call sites have always been around. I guess
no care was taken to check the return value because the name_to_path
operation could never fail at the time. This is no longer true: the
handle and synth backends can already fail this operation, and so will the
local backend
The code only uses well known format strings. An unknown format token is a
bug.
Signed-off-by: Greg Kurz
Reviewed-by: Stefano Stabellini
---
fsdev/9p-iov-marshal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fsdev/9p-iov-marshal.c b/fsdev/9p-iov-marshal.c
index 1d16f
The logic to open a path currently sits between local_open_nofollow() and
the relative_openat_nofollow() helper, which has no other user.
For the sake of clarity, this patch moves all the code of the helper into
its unique caller. While here we also:
- drop the code to skip leading "/" because the
The utimensat() and futimens() syscalls have been around for ages (ie,
glibc 2.6 and linux 2.6.22), and the decision was already taken to
switch to utimensat() anyway when fixing CVE-2016-9602 in 2.9.
Signed-off-by: Greg Kurz
Reviewed-by: Eric Blake
---
fsdev/virtfs-proxy-helper.c | 3 ++-
hw/9
On Fri, 26 May 2017 11:58:14 -0300
Eduardo Habkost wrote:
> On Tue, May 23, 2017 at 05:44:03PM +0200, Igor Mammedov wrote:
> > On Tue, 23 May 2017 11:48:54 -0300
> > Eduardo Habkost wrote:
> >
> > > On Tue, May 23, 2017 at 04:38:49PM +0200, Igor Mammedov wrote:
> > > > Do the same as we did
When using the mapped-file security mode, the creds of a path /foo/bar
are stored in the /foo/.virtfs_metadata/bar file. This is okay for all
paths unless they end with '.' or '..', because we cannot create the
corresponding file in the metadata directory.
This patch ensures that '.' and '..' are
Now that 9pfs and virtfs-proxy-helper have been converted to utimensat(),
we don't need to keep qemu_utimens() anymore.
Signed-off-by: Greg Kurz
Reviewed-by: Eric Blake
---
configure | 22 --
include/sysemu/os-posix.h | 11 ---
util/oslib-posix.c
Hi all,
Linaro is looking for a full-time engineer to work on QEMU, primarily
focused on emulating aspects of the ARM architecture.
Feel free to apply to the position or forward this to anyone you know
who has experience working with QEMU and experience with modeling
computer architecture.
The o
Hi,
This series failed build test on s390x host. Please find the details below.
Message-id: 1496048740-26578-1-git-send-email-gr...@kaod.org
Subject: [Qemu-devel] [PULL 00/11] 9pfs patches for 2.10 20170525
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
# Testing script will be invoked under
On 28.05.2017 07:18, Rob Landley wrote:
> You can't boot a kernel under -cpu 486 since that commit (hangs
> producing no output) because it added a bios image that won't run on
> anything short of pentium II.
>
> You can try the run-emulator.sh script in
> http://landley.net/aboriginal/downloads/b
Eduardo Habkost writes:
> On Tue, May 23, 2017 at 04:52:47PM +0200, Markus Armbruster wrote:
>> Beware, my review is rather superficial.
>>
>> Eduardo Habkost writes:
>>
>> > Test code to check if we can crash QEMU using -device. It will
>> > test all accel/machine/device combinations by defau
Peter Xu writes:
> On Mon, May 15, 2017 at 09:14:33PM +0800, Peter Xu wrote:
>> MSI should be supported by all interrupt controllers. Switching the old
>> check for msi_nonbroken into assertion. Do similar thing to
>> pci_add_capability2() below that. Then time to remove *errp.
>>
>> Since msi_i
"Daniel P. Berrange" writes:
> On Thu, May 25, 2017 at 02:52:30PM -0500, Eric Blake wrote:
>> On 05/25/2017 11:38 AM, Daniel P. Berrange wrote:
>> > Currently 'qemu-img info' reports a simple "encrypted: yes"
>> > field. This is not very useful now that qcow2 can support
>> > multiple encryption
On Mon, May 29, 2017 at 11:42:35AM +0200, Markus Armbruster wrote:
> Peter Xu writes:
>
> > On Mon, May 15, 2017 at 09:14:33PM +0800, Peter Xu wrote:
> >> MSI should be supported by all interrupt controllers. Switching the old
> >> check for msi_nonbroken into assertion. Do similar thing to
> >>
On Mon, May 29, 2017 at 11:22:14AM +0200, Thomas Huth wrote:
> On 28.05.2017 07:18, Rob Landley wrote:
> > You can't boot a kernel under -cpu 486 since that commit (hangs
> > producing no output) because it added a bios image that won't run on
> > anything short of pentium II.
> >
> > You can try
On Sat, 27 May 2017 10:32:33 +0800
Li Zhang wrote:
> On Fri, May 26, 2017 at 7:21 PM, Igor Mammedov wrote:
> > On Fri, 26 May 2017 17:21:05 +0800
> > Li Zhang wrote:
> >
> >> From: Li Zhang
> >>
> >> virt machine doesn't support hot_add_cpu interface. This patchset is to
> >> implement
> >>
Do an update of system_time_msr address every time before reading
the value of tsc_timestamp from guest's kvmclock page.
There is no other code paths which ensure that qemu has an up-to-date
value of system_time_msr. So, force this update on guest's tsc_timestamp
reading.
This bug causes effect o
On Fri, 26 May 2017 14:16:30 +1000
David Gibson wrote:
> On Thu, May 04, 2017 at 12:07:47PM +0200, Greg Kurz wrote:
> > On Thu, 27 Apr 2017 17:28:43 +1000
> > David Gibson wrote:
> >
> > > Migrating between different CPU versions is a bit complicated for ppc.
> > > A long time ago, we ensured
On 2017-05-26 10:10, Richard Henderson wrote:
> On 05/25/2017 02:05 PM, Aurelien Jarno wrote:
> > +uint32_t HELPER(trXX)(CPUS390XState *env, uint32_t r1, uint32_t r2,
> > + uint32_t sizes)
> > +{
> > +uintptr_t ra = GETPC();
> > +int dsize = (sizes & 1) ? 1 : 2;
> > +
On 29.05.2017 12:14, Richard W.M. Jones wrote:
> On Mon, May 29, 2017 at 11:22:14AM +0200, Thomas Huth wrote:
>> On 28.05.2017 07:18, Rob Landley wrote:
>>> You can't boot a kernel under -cpu 486 since that commit (hangs
>>> producing no output) because it added a bios image that won't run on
>>> a
On 2017-05-26 09:35, Richard Henderson wrote:
> On 05/25/2017 02:05 PM, Aurelien Jarno wrote:
> > +} else if (srclen > ssize) {
> > b = cpu_ldub_data_ra(env, src, ra) & 0x0f;
> > -src--;
> > -srclen--;
> > +src -= ssize;
> > +src
On 26/05/2017 22:21, Kevin Wolf wrote:
> The qed block driver is one of the last remaining block drivers that use the
> AIO callback style interfaces. This series converts it to the coroutine model
> that other drivers are using and removes some AIO functions from the block
> layer API afterwards.
On 25.05.2017 23:05, Aurelien Jarno wrote:
> Now that the extended-translation facility 2 has been fully implemented,
> it's possible to emulated a most a z800 CPU with TCG.
>
> Signed-off-by: Aurelien Jarno
> ---
> target/s390x/cpu_models.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletio
Marcel Apfelbaum writes:
> On 27/05/2017 9:58, Mao Zhongyi wrote:
>>
>>
>> On 05/26/2017 10:08 PM, Marcel Apfelbaum wrote:
>>>
>>>
>>> On 26/05/2017 15:15, Mao Zhongyi wrote:
The pci-birdge device i82801b11 still implements the old
PCIDeviceClass .init() through i82801b11_bridge_init()
Eduardo Habkost writes:
> On Tue, May 23, 2017 at 04:23:08PM +0200, Markus Armbruster wrote:
>> Eduardo Habkost writes:
>>
>> > Keep the Popen object around to we can query its exit code later.
>> >
>> > To keep the existing 'self._popen is None' checks working, add a
>> > is_running() method,
On Fri, 26 May 2017 13:06:30 -0300
Eduardo Habkost wrote:
> On Tue, May 23, 2017 at 04:38:48PM +0200, Igor Mammedov wrote:
> > It fixes/add missing _PXM object for non mapped CPU (x86)
> > and missing fdt node (virt-arm).
> >
> > It ensures that possible_cpus contains complete mapping if
> > num
On Fri, 26 May 2017 11:58:14 -0300
Eduardo Habkost wrote:
> On Tue, May 23, 2017 at 05:44:03PM +0200, Igor Mammedov wrote:
> > On Tue, 23 May 2017 11:48:54 -0300
> > Eduardo Habkost wrote:
> >
> > > On Tue, May 23, 2017 at 04:38:49PM +0200, Igor Mammedov wrote:
> > > > Do the same as we did
We have to make the address in the old PSW point at the next
instruction, as addressing exceptions are suppressing and not
nullifying.
I assume that there are a lot of other broken cases (as most instructions
we care about are suppressing) - all trigger_pgm_exception() specifying
and explicit numb
On Fri, 26 May 2017 15:25:22 -0300
Eduardo Habkost wrote:
> On Tue, May 23, 2017 at 04:38:50PM +0200, Igor Mammedov wrote:
> > Move vcpu's assocciated numa_node field out of generic CPUState
> > into inherited classes that actually care about cpu<->numa mapping,
> > i.e: ARMCPU, PowerPCCPU, X86CP
Peter Xu writes:
> On Mon, May 29, 2017 at 11:42:35AM +0200, Markus Armbruster wrote:
>> Peter Xu writes:
>>
>> > On Mon, May 15, 2017 at 09:14:33PM +0800, Peter Xu wrote:
>> >> MSI should be supported by all interrupt controllers. Switching the old
>> >> check for msi_nonbroken into assertion.
On Fri, 2017-05-26 at 16:38 -0700, Ian McKellar wrote:
> I had two problems with QEMU on macOS:
> 1) Sometimes when alt-tabbing to QEMU it would act as if the 'a' key
> was pressed so I'd get 'a'.
> 2) Using Sikuli to programatically send keys to the QEMU window text
> like "f
On Thu, 2017-05-25 at 12:50 +, Marc-André Lureau wrote:
>
>
> On Thu, May 11, 2017 at 6:16 AM Jonathon Jongsma > wrote:
> > Although the Qemu and spice flags currently have the same value, it
> > seems more correct to pass the spice flag values to
> > spice_server_kbd_leds(), especially cons
On Mon, 2017-05-22 at 14:33 +0200, Ladi Prosek wrote:
> PORT_STAT_C_SUSPEND should be set even on host-initiated wake-up,
> i.e. on ClearPortFeature(PORT_SUSPEND). Windows is known to not
> work properly otherwise.
>
> Side note, since PORT_ENABLE looks similar and might appear to
> have the same
This fixes an assertion failure that was triggered by qemu-iotests 129
on some CI host, while the same test case didn't seem to fail on other
hosts.
Essentially the problem is that the blk_unref(s->target) in
mirror_exit() doesn't necessarily mean that the BlockBackend goes away
immediately. It is
On 05/26/2017 10:04 PM, Eric Blake wrote:
> If a non-NBD client connects to qemu-nbd, we would end up with
> a SIGSEGV in nbd_cilent_put() because we were trying to
> unregister the client's association to the export, even though
> we skipped inserting the client into that list. Easy trigger
> in
On 29/05/2017 14:18, Kevin Wolf wrote:
> This fixes an assertion failure that was triggered by qemu-iotests 129
> on some CI host, while the same test case didn't seem to fail on other
> hosts.
>
> Essentially the problem is that the blk_unref(s->target) in
> mirror_exit() doesn't necessarily me
On Fri, 26 May 2017 13:59:09 +
Marc-André Lureau wrote:
> Hi
>
> On Thu, May 4, 2017 at 5:41 PM Igor Mammedov wrote:
>
> > On Tue, 02 May 2017 19:03:15 +
> > Marc-André Lureau wrote:
> >
> > > Hi
> > >
> > > On Tue, May 2, 2017 at 11:17 AM Igor Mammedov
> > wrote:
> > >
> > >
On 2017-05-26 08:32, Richard Henderson wrote:
> On 05/25/2017 02:04 PM, Aurelien Jarno wrote:
> > -if (srclen) {
> > -v1 = cpu_ldub_data_ra(env, src, ra);
> > +if (*srclen) {
> > +v1 = cpu_ldub_data_ra(env, *src, ra);
> > }
> > -if (destlen)
From: Thomas Huth
The '-usbdevice' option is considered as deprecated nowadays and
we might want to remove these options in a future version of QEMU.
So mark this options as deprecated in the documenation and print out
a warning if it is used to tell the user what to use instead.
While we're at i
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1452512
Signed-off-by: Gerd Hoffmann
Message-id: 20170523084635.20062-1-kra...@redhat.com
---
hw/usb/core.c | 8
1 file changed, 8 insertions(+)
diff --git a/hw/usb/core.c b/hw/usb/core.c
index 45fa00c517..241ae66b15 100644
--- a/hw/usb
From: Ladi Prosek
PORT_STAT_C_SUSPEND should be set even on host-initiated wake-up,
i.e. on ClearPortFeature(PORT_SUSPEND). Windows is known to not
work properly otherwise.
Side note, since PORT_ENABLE looks similar and might appear to
have the same issue: According to 11.24.2.7.2.2 C_PORT_ENABL
ehci registers ehci_frame_timer as both timer and bottom half, which
turned out to be a bad idea as it can be called as bottom half then
while it is running as timer, and it isn't prepared to handle recursive
calls.
Change the timer func to just schedule the bottom half to avoid this.
Fixes: http
branch 'jasowang/tags/net-pull-request' into staging
(2017-05-23 15:01:31 +0100)
are available in the git repository at:
git://git.kraxel.org/qemu tags/pull-usb-20170529-1
for you to fetch changes up to 3bfecee2cb71f21cd39d6183f18b446c01917573:
ehci: fix frame timer invocation. (
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1451189
Signed-off-by: Gerd Hoffmann
Message-id: 20170517103313.8459-2-kra...@redhat.com
---
default-configs/pci.mak | 1 +
hw/usb/Makefile.objs| 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/default-configs/pci.mak b/de
From: Thomas Huth
The commands 'device_add' and 'device_del' should be used
nowadays instead.
Signed-off-by: Thomas Huth
Reviewed-by: Paolo Bonzini
Reviewed-by: Dr. David Alan Gilbert
Message-id: 1495175803-12830-1-git-send-email-th...@redhat.com
Signed-off-by: Gerd Hoffmann
---
vl.c
In case the frame timer doesn't run for a while due to the host being
busy skipped_uframes can become big enough that UFRAME_TIMER_NS *
skipped_uframes overflows. Which in turn throws off all subsequent
ehci frame timer calculations.
Reported-by: 李林 <8610...@163.com>
Signed-off-by: Gerd Hoffmann
Moved structs and defines to hcd-xhci.h.
Move nec controller variant to hcd-xhci-nec.c.
No functional changes.
Signed-off-by: Gerd Hoffmann
Message-id: 20170517103313.8459-1-kra...@redhat.com
---
hw/usb/hcd-xhci.h | 226 +++
hw/usb/hcd-xhci-nec.c |
From: Thomas Huth
Coverity complains about the current code, so let's get rid of
the now unneeded while loop and simply always emit "unrecognized
serial USB option" for all unsupported options.
Signed-off-by: Thomas Huth
Reviewed-by: Paolo Bonzini
Message-id: 1495177204-16808-1-git-send-email-
Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
flexibility (extending using subsections) and for fun.
To achieve this we need to hack the config_vector, which is VirtIODevice
(that is common virtio) state, in the middle of the VirtioCcwDevice state
representation. This some
On Fri, 26 May 2017 12:46:25 -0300
Eduardo Habkost wrote:
> On Wed, May 10, 2017 at 01:29:50PM +0200, Igor Mammedov wrote:
> [...]
> > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > index 2482c63..420c8c4 100644
> > --- a/hw/core/machine.c
> > +++ b/hw/core/machine.c
> > @@ -389,6 +389,10
On Mon, May 29, 2017 at 01:45:36PM +0200, Igor Mammedov wrote:
> On Fri, 26 May 2017 13:06:30 -0300
> Eduardo Habkost wrote:
>
> > On Tue, May 23, 2017 at 04:38:48PM +0200, Igor Mammedov wrote:
> > > It fixes/add missing _PXM object for non mapped CPU (x86)
> > > and missing fdt node (virt-arm).
On 2017-05-29 14:18, Kevin Wolf wrote:
> This fixes an assertion failure that was triggered by qemu-iotests 129
> on some CI host, while the same test case didn't seem to fail on other
> hosts.
>
> Essentially the problem is that the blk_unref(s->target) in
> mirror_exit() doesn't necessarily mean
On Mon, May 29, 2017 at 03:12:45PM +0200, Igor Mammedov wrote:
> On Fri, 26 May 2017 12:46:25 -0300
> Eduardo Habkost wrote:
>
> > On Wed, May 10, 2017 at 01:29:50PM +0200, Igor Mammedov wrote:
> > [...]
> > > diff --git a/hw/core/machine.c b/hw/core/machine.c
> > > index 2482c63..420c8c4 100644
On Mon, May 29, 2017 at 01:49:04PM +0300, Denis Plotnikov wrote:
> Do an update of system_time_msr address every time before reading
> the value of tsc_timestamp from guest's kvmclock page.
>
> There is no other code paths which ensure that qemu has an up-to-date
> value of system_time_msr. So, fo
On Thu 25 May 2017 06:38:48 PM CEST, "Daniel P. Berrange"
wrote:
> Now that all encryption keys must be provided upfront via
> the QCryptoSecret API and associated block driver properties
> there is no need for any explicit encryption handling APIs
> in the block layer. Encryption can be handled
On Mon, 29 May 2017 10:36:47 -0300
Eduardo Habkost wrote:
> On Mon, May 29, 2017 at 03:12:45PM +0200, Igor Mammedov wrote:
> > On Fri, 26 May 2017 12:46:25 -0300
> > Eduardo Habkost wrote:
> >
> > > On Wed, May 10, 2017 at 01:29:50PM +0200, Igor Mammedov wrote:
> > > [...]
> > > > diff --gi
On Thu 25 May 2017 06:38:51 PM CEST, "Daniel P. Berrange"
wrote:
> Expand the image format docs to cover the new options for
> the qcow, qcow2 and luks disk image formats
>
> Signed-off-by: Daniel P. Berrange
Reviewed-by: Alberto Garcia
Berto
Turn on migration for the channel subsystem for the next machine. For
legacy machines we still have to do things the old way.
Signed-off-by: Halil Pasic
---
hw/s390x/css.c | 5 +
hw/s390x/s390-virtio-ccw.c | 9 -
hw/s390x/virtio-ccw.c | 1 -
include/hw/s390x/css.h
Let's vmstatify virtio_ccw_save_config and virtio_ccw_load_config for
flexibility (extending using subsections) and for fun.
To achieve this we need to hack the config_vector, which is VirtIODevice
(that is common virtio) state, in the middle of the VirtioCcwDevice state
representation. This some
1 - 100 of 216 matches
Mail list logo
