Re: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-22 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing Me

Re: [Qemu-devel] [PATCH v2 5/5] tests: add functional test validating ipv4/ipv6 address flag handling

2017-05-22 Thread Eric Blake
On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: > The semantics around handling ipv4=on|off & ipv6=on|off are quite > subtle to understand in combination with the various hostname addresses > and backend types. Introduce a massive test matrix that launches QEMU > and validates the ability to conn

[Qemu-devel] [Bug 1300021] Re: after loadvm the system clock isn't current time

2017-05-22 Thread Thomas Huth
Triaging old bug tickets ... Which version of QEMU did you use here? Can you still reproduce the problem with the latest version of QEMU? How did you start QEMU? Did you specify the -rtc parameter? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because

[Qemu-devel] [Bug 1297487] Re: MTU not honored in virtio vnet

2017-05-22 Thread Thomas Huth
Did anybody ever tried to reproduce this bug with upstream QEMU? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1297487 Title: MTU not honored i

Re: [Qemu-devel] [PATCH V5 8/9] migration: add postcopy total blocktime into query-migrate

2017-05-22 Thread Eric Blake
On 05/12/2017 08:31 AM, Alexey Perevalov wrote: > Postcopy total blocktime is available on destination side only. > But query-migrate was possible only for source. This patch > adds ability to call query-migrate on destination. To distinguish > src/dst, state of the MigrationState is using, query-m

Re: [Qemu-devel] [PATCH V5 8/9] migration: add postcopy total blocktime into query-migrate

2017-05-22 Thread Eric Blake
On 05/19/2017 02:23 PM, Dr. David Alan Gilbert wrote: > * Alexey Perevalov (a.pereva...@samsung.com) wrote: >> Postcopy total blocktime is available on destination side only. >> But query-migrate was possible only for source. This patch >> adds ability to call query-migrate on destination. To disti

Re: [Qemu-devel] [PATCH V5 5/9] migration: introduce postcopy-blocktime capability

2017-05-22 Thread Eric Blake
On 05/12/2017 08:31 AM, Alexey Perevalov wrote: > Right now it could be used on destination side to > enable vCPU blocktime calculation for postcopy live migration. > vCPU blocktime - it's time since vCPU thread was put into > interruptible sleep, till memory page was copied and thread awake. > >

[Qemu-devel] [PATCH 3/4] tests/qapi-schema: Avoid 'str' in alternate test cases

2017-05-22 Thread Markus Armbruster
The next commit is going to make alternate members of type 'str' conflict with other scalar types. Would break a few test cases that don't actually require 'str'. Flip them from 'str' to 'bool' or 'EnumOne'. Signed-off-by: Markus Armbruster --- tests/qapi-schema/alternate-clash.json |

[Qemu-devel] [PATCH 1/4] qobject-input-visitor: Reject non-finite numbers with keyval

2017-05-22 Thread Markus Armbruster
The QObject input visitor can produce only finite numbers when its input comes out of the JSON parser, because the the JSON parser implements RFC 7159, which provides no syntax for infinity and NaN. However, it can produce infinity and NaN when its input comes out of keyval_parse(), because we par

[Qemu-devel] [PATCH 2/4] qapi: Document visit_type_any() issues with keyval input

2017-05-22 Thread Markus Armbruster
It's already documented in keyval.c (commit 0ee9ae7), but visitor.h can use a note, too. Signed-off-by: Markus Armbruster --- include/qapi/visitor.h | 4 1 file changed, 4 insertions(+) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index b0e233d..4721c39 100644 --- a/include

Re: [Qemu-devel] [PATCH V5 5/9] migration: introduce postcopy-blocktime capability

2017-05-22 Thread Alexey
On Mon, May 22, 2017 at 11:20:13AM -0500, Eric Blake wrote: > On 05/12/2017 08:31 AM, Alexey Perevalov wrote: > > Right now it could be used on destination side to > > enable vCPU blocktime calculation for postcopy live migration. > > vCPU blocktime - it's time since vCPU thread was put into > > in

[Qemu-devel] [PATCH 0/4] qapi: Handle some keyval fallout

2017-05-22 Thread Markus Armbruster
Markus Armbruster (4): qobject-input-visitor: Reject non-finite numbers with keyval qapi: Document visit_type_any() issues with keyval input tests/qapi-schema: Avoid 'str' in alternate test cases qapi: Reject alternates that can't work with keyval_parse() include/qapi/visitor.h

[Qemu-devel] [PATCH 4/4] qapi: Reject alternates that can't work with keyval_parse()

2017-05-22 Thread Markus Armbruster
Alternates are sum types like unions, but use the JSON type on the wire / QType in QObject instead of an explicit tag. That's why we require alternate members to have distinct QTypes. The recently introduced keyval_parse() (commit d454dbe) can only produce string scalars. The qobject_input_visit

Re: [Qemu-devel] [PATCH v3 22/24] shippable: add mipsel target

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .shippable.yml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/.shippable.yml b/.shippable.yml > index aad66ec5ec..75c2895a21 100644 > --- a/.shippable.yml > +++ b/.shippable.

Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking

2017-05-22 Thread Kamil Rytarowski
On 22.05.2017 08:28, Markus Armbruster wrote: > Kamil Rytarowski writes: > >> Hello, >> >> Excuse me for delay, I missed this mail. > > No problem. > >> Please see in-line. >> >> On 17.05.2017 09:28, Markus Armbruster wrote: >>> Kamil Rytarowski writes: >>> ivshmem-server makes use of the

Re: [Qemu-devel] [PATCH v2 5/5] tests: add functional test validating ipv4/ipv6 address flag handling

2017-05-22 Thread Daniel P. Berrange
On Mon, May 22, 2017 at 11:00:26AM -0500, Eric Blake wrote: > On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: > > The semantics around handling ipv4=on|off & ipv6=on|off are quite > > subtle to understand in combination with the various hostname addresses > > and backend types. Introduce a massiv

Re: [Qemu-devel] [PATCH 03/17] tests: remove alt num-int cases

2017-05-22 Thread Markus Armbruster
Marc-André Lureau writes: > There are no real users of this case, and it's going to be invalid after > merging of QFloat and QInt use the same QNum type in the following patch. Invalid because our alternate code is insufficiently sophisticated. In other words fixable. See "[PATCH 4/4] qapi: Re

Re: [Qemu-devel] [PATCH 3/3] numa: silence incomplete mapping warning under qtest

2017-05-22 Thread Eduardo Habkost
On Mon, May 22, 2017 at 09:58:36AM +0200, Igor Mammedov wrote: > On Thu, 18 May 2017 15:20:39 -0300 > Eduardo Habkost wrote: > > > On Thu, May 18, 2017 at 10:09:31AM +0200, Igor Mammedov wrote: > > > Suggested-by: Markus Armbruster > > > Signed-off-by: Igor Mammedov > > > > Where exactly is

Re: [Qemu-devel] [PATCH] vhost_net: do not expose MTU feature bit to kernel backend

2017-05-22 Thread Michael S. Tsirkin
On Sat, May 20, 2017 at 10:06:58AM +0200, Maxime Coquelin wrote: > This patch removes MTU from the list of features supported by > the kernel backend, so that vhost kernel backend does not have > to advertise it to be negotiated. > > Cc: Aaron Conole > Suggested-by: Michael S. Tsirkin > Signed-o

Re: [Qemu-devel] [PATCH v2 5/5] tests: add functional test validating ipv4/ipv6 address flag handling

2017-05-22 Thread Eric Blake
On 05/22/2017 11:56 AM, Daniel P. Berrange wrote: > On Mon, May 22, 2017 at 11:00:26AM -0500, Eric Blake wrote: >> On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: >>> The semantics around handling ipv4=on|off & ipv6=on|off are quite >>> subtle to understand in combination with the various hostnam

Re: [Qemu-devel] [PATCH v0 0/6] move the tcg files into tcg directory.

2017-05-22 Thread Zhong Yang
O Fri, May 19, 2017 at 05:14:19PM -0500, Eric Blake wrote: > On 05/19/2017 02:30 AM, Yang Zhong wrote: > > Move the tcg relative files into tcg directory, which will make > > the code more clean in qemu. > > Titling a patch series v0 is a bit unusual (typically, the first version > is untitled, an

Re: [Qemu-devel] [PATCH v3 4/4] migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all()

2017-05-22 Thread Eric Blake
On 05/22/2017 08:57 AM, Stefan Hajnoczi wrote: > blk/bdrv_drain_all() only takes effect for a single instant and then > resumes block jobs, guest devices, and other external clients like the > NBD server. This can be handy when performing a synchronous drain > before terminating the program, for e

Re: [Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

2017-05-22 Thread Michael S. Tsirkin
On Mon, May 22, 2017 at 02:58:56PM +0200, Igor Mammedov wrote: > On Mon, 22 May 2017 14:01:15 +0300 > Evgeny Yakovlev wrote: > > > On 22.05.2017 13:35, Igor Mammedov wrote: > > > On Mon, 22 May 2017 12:50:30 +0300 > > > Evgeny Yakovlev wrote: > > > > > >> When running windows 2016 server guest

Re: [Qemu-devel] [PATCH 1/4] qobject-input-visitor: Reject non-finite numbers with keyval

2017-05-22 Thread Eric Blake
On 05/22/2017 11:42 AM, Markus Armbruster wrote: > The QObject input visitor can produce only finite numbers when its > input comes out of the JSON parser, because the the JSON parser > implements RFC 7159, which provides no syntax for infinity and NaN. > > However, it can produce infinity and NaN

Re: [Qemu-devel] [PATCH 2/4] qapi: Document visit_type_any() issues with keyval input

2017-05-22 Thread Eric Blake
On 05/22/2017 11:42 AM, Markus Armbruster wrote: > It's already documented in keyval.c (commit 0ee9ae7), but visitor.h > can use a note, too. > > Signed-off-by: Markus Armbruster > --- > include/qapi/visitor.h | 4 > 1 file changed, 4 insertions(+) Reviewed-by: Eric Blake -- Eric Blake,

Re: [Qemu-devel] [PATCH 3/4] tests/qapi-schema: Avoid 'str' in alternate test cases

2017-05-22 Thread Eric Blake
On 05/22/2017 11:42 AM, Markus Armbruster wrote: > The next commit is going to make alternate members of type 'str' > conflict with other scalar types. Would break a few test cases that > don't actually require 'str'. Flip them from 'str' to 'bool' or > 'EnumOne'. > > Signed-off-by: Markus Armbr

[Qemu-devel] [PATCH 1/1] Improve Cocoa modifier key handling

2017-05-22 Thread Ian McKellar via Qemu-devel
I had two problems with QEMU on macOS: 1) Sometimes when alt-tabbing to QEMU it would act as if the 'a' key was pressed so I'd get 'a'. 2) Using Sikuli to programatically send keys to the QEMU window text like "foo_bar" would come out as "fooa-bar". They looked similar and af

[Qemu-devel] [PATCH 0/2] block: Fix backing paths for filenames with colons

2017-05-22 Thread Max Reitz
See here: $ ./qemu-img create -f qcow2 backing.qcow2 64M Formatting 'backing.qcow2', fmt=qcow2 size=67108864 encryption=off cluster_size=65536 lazy_refcounts=off refcount_bits=16 $ ./qemu-img create -f qcow2 -b backing.qcow2 ./top:image.qcow2 qemu-img: ./top:image.qcow2: Could not open './top:b

[Qemu-devel] [PATCH 1/2] block: Fix backing paths for filenames with colons

2017-05-22 Thread Max Reitz
path_combine() naturally tries to preserve a protocol prefix. However, it recognizes such a prefix by scanning for the first colon; which is different from what path_has_protocol() does: There only is a protocol prefix if there is a colon before the first slash. A protocol prefix that is not recog

[Qemu-devel] [PATCH 2/2] iotests: Add test for colon handling

2017-05-22 Thread Max Reitz
Signed-off-by: Max Reitz --- I apologize for the patch title for sounding a bit squishy. But I like it so I won't change it. --- tests/qemu-iotests/126 | 76 ++ tests/qemu-iotests/126.out | 16 ++ tests/qemu-iotests/group | 1 + 3 files c

Re: [Qemu-devel] [PATCH 4/4] qapi: Reject alternates that can't work with keyval_parse()

2017-05-22 Thread Eric Blake
On 05/22/2017 11:42 AM, Markus Armbruster wrote: > Alternates are sum types like unions, but use the JSON type on the > wire / QType in QObject instead of an explicit tag. That's why we > require alternate members to have distinct QTypes. > > The recently introduced keyval_parse() (commit d454dbe

Re: [Qemu-devel] [PATCH 2/2] iotests: Add test for colon handling

2017-05-22 Thread Eric Blake
On 05/22/2017 01:07 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > I apologize for the patch title for sounding a bit squishy. But I like > it so I won't change it. That was a mental image I did not need. ;) > --- > tests/qemu-iotests/126 | 76 > +++

Re: [Qemu-devel] [PATCH 1/2] block: Fix backing paths for filenames with colons

2017-05-22 Thread Eric Blake
On 05/22/2017 01:07 PM, Max Reitz wrote: > path_combine() naturally tries to preserve a protocol prefix. However, > it recognizes such a prefix by scanning for the first colon; which is > different from what path_has_protocol() does: There only is a protocol > prefix if there is a colon before the

[Qemu-devel] [PATCH v13] migration: spapr: migrate pending_events of spapr state

2017-05-22 Thread Daniel Henrique Barboza
v13: - rebased with dgibson/ppc-for-2.10 - patch 1 removed from the series (already applied at ppc-for-2.10) - data_size is now being calculated by using the extended_length field inside rtas_event_log_queue v12: - patch 2: added a switch statement to get the proper data_size based on the log_type

[Qemu-devel] [PATCH v13] migration: spapr: migrate pending_events of spapr state

2017-05-22 Thread Daniel Henrique Barboza
From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration is started. In this case the pending_events of spapr state need be transmitted to the target so that the hotplug event ca

Re: [Qemu-devel] [PATCH v1 01/13] qcow2: alloc space for COW in one chunk

2017-05-22 Thread Eric Blake
On 05/19/2017 04:34 AM, Anton Nefedov wrote: > From: "Denis V. Lunev" > > Currently each single write operation can result in 3 write operations > if guest offsets are not cluster aligned. One write is performed for the > real payload and two for COW-ed areas. Thus the data possibly lays > non-co

Re: [Qemu-devel] [PATCH v1 02/13] qcow2: is_zero_sectors(): return true if area is outside of backing file

2017-05-22 Thread Eric Blake
On 05/19/2017 04:34 AM, Anton Nefedov wrote: > in such case, bdrv_get_block_status() shall return 0, *nr == 0 Sounds better as s/shall/will/ > > iotest 154 updated accordingly: write-zeroes tail alignment can be detected > as zeroes now, so pwrite_zeroes succeeds > > Signed-off-by: Anton Nefedo

Re: [Qemu-devel] [PATCH v1 02/13] qcow2: is_zero_sectors(): return true if area is outside of backing file

2017-05-22 Thread Eric Blake
On 05/22/2017 02:12 PM, Eric Blake wrote: >> +++ b/block/qcow2.c >> @@ -2482,7 +2482,7 @@ static bool is_zero_sectors(BlockDriverState *bs, >> int64_t start, >> int64_t res; >> >> if (start + count > bs->total_sectors) { >> -count = bs->total_sectors - start; >> +count

Re: [Qemu-devel] [PATCH v1 03/13] qcow2: do not COW the empty areas

2017-05-22 Thread Eric Blake
On 05/19/2017 04:34 AM, Anton Nefedov wrote: > If COW area of the newly allocated cluster is zeroes, there is no reason > to write zero sectors in perform_cow() again now as whole clusters are > zeroed out in single chunks by handle_alloc_space(). But that's only true if you can guarantee that han

Re: [Qemu-devel] [PATCH v1 04/13] qcow2: preallocation at image expand

2017-05-22 Thread Eric Blake
On 05/19/2017 04:34 AM, Anton Nefedov wrote: > From: "Denis V. Lunev" > > This patch adds image preallocation at expand to provide better locality > of QCOW2 image file and optimize this procedure for some distributed > storages where this procedure is slow. > > Image expand requests have to be

[Qemu-devel] [PATCH v11 0/5] migration/ppc: migrating DRC and ccs_list

2017-05-22 Thread Daniel Henrique Barboza
v11: - rebased with dgibson/ppc-for-2.10 branch - patch 1: * use PCDIMMDevice* as index of pending_dimm_unplugs list instead of using its uint64_t address; * spapr_del_lmbs() function was merged with spapr_memory_unplug_request(); * wherever applicable, retrieve the machine by using Hot

[Qemu-devel] [PATCH v11 2/5] hw/ppc: removing drc->detach_cb and drc->detach_cb_opaque

2017-05-22 Thread Daniel Henrique Barboza
The pointer drc->detach_cb is being used as a way of informing the detach() function inside spapr_drc.c which cb to execute. This information can also be retrieved simply by checking drc->type and choosing the right callback based on it. In this context, detach_cb is redundant information that must

[Qemu-devel] [PATCH v11 1/5] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

2017-05-22 Thread Daniel Henrique Barboza
The LMB DRC release callback, spapr_lmb_release(), uses an opaque parameter, a sPAPRDIMMState struct that stores the current LMBs that are allocated to a DIMM (nr_lmbs). After each call to this callback, the nr_lmbs is decremented by one and, when it reaches zero, the callback proceeds with the qde

[Qemu-devel] [PATCH v11 3/5] hw/ppc: migrating the DRC state of hotplugged devices

2017-05-22 Thread Daniel Henrique Barboza
In pseries, a firmware abstraction called Dynamic Reconfiguration Connector (DRC) is used to assign a particular dynamic resource to the guest and provide an interface to manage configuration/removal of the resource associated with it. In other words, DRC is the 'plugged state' of a device. Before

[Qemu-devel] [PATCH v11 5/5] migration: spapr: migrate ccs_list in spapr state

2017-05-22 Thread Daniel Henrique Barboza
From: Jianjun Duan ccs_list in spapr state maintains the device tree related information on the rtas side for hotplugged devices. In racing situations between hotplug events and migration operation, a rtas hotplug event could be migrated from the source guest to target guest, or the source guest

[Qemu-devel] [PATCH v11 4/5] hw/ppc/spapr.c: recover pending LMB unplug info in spapr_lmb_release

2017-05-22 Thread Daniel Henrique Barboza
When a LMB hot unplug starts, the current DRC LMB status is stored at spapr->pending_dimm_unplugs QTAILQ. This queue isn't migrated, thus if a migration occurs in the middle of a LMB unplug the spapr_lmb_release callback will lost track of the LMB unplug progress. This patch implements a new recov

Re: [Qemu-devel] [PATCH v1 11/13] qcow2-cluster: make handle_dependencies() logic easier to follow

2017-05-22 Thread Eric Blake
On 05/19/2017 04:34 AM, Anton Nefedov wrote: > Avoid complicated nested conditions; return or continue asap instead. > The logic is not changed. > > Signed-off-by: Anton Nefedov > Signed-off-by: Denis V. Lunev > --- > block/qcow2-cluster.c | 45 ++--- > 1

[Qemu-devel] [PATCH v2 3/3] iotests: Add test for colon handling

2017-05-22 Thread Max Reitz
Signed-off-by: Max Reitz --- tests/qemu-iotests/126 | 105 + tests/qemu-iotests/126.out | 23 ++ tests/qemu-iotests/group | 1 + 3 files changed, 129 insertions(+) create mode 100755 tests/qemu-iotests/126 create mode 100644 tests/qem

[Qemu-devel] [PATCH v2 0/3] block: Fix backing paths for filenames with colons

2017-05-22 Thread Max Reitz
There are (at least) two issues with filenames that contain colons when trying to use relative backing filenames with them, for each of which there is a patch in this series. The first patch fixes an issue in the general block layer (path_combine() does not have the same opinion on what constitute

[Qemu-devel] [PATCH v2 2/3] block/file-*: *_parse_filename() and colons

2017-05-22 Thread Max Reitz
The file drivers' *_parse_filename() implementations just strip the optional protocol prefix off the filename. However, for e.g. "file:foo:bar", this would lead to "foo:bar" being stored as the BDS's filename which looks like it should be managed using the "foo" protocol. This is especially trouble

[Qemu-devel] [PATCH v2 1/3] block: Fix backing paths for filenames with colons

2017-05-22 Thread Max Reitz
path_combine() naturally tries to preserve a protocol prefix. However, it recognizes such a prefix by scanning for the first colon; which is different from what path_has_protocol() does: There only is a protocol prefix if there is a colon before the first slash. A protocol prefix that is not recog

Re: [Qemu-devel] [PATCH v2 2/3] block/file-*: *_parse_filename() and colons

2017-05-22 Thread Eric Blake
On 05/22/2017 02:52 PM, Max Reitz wrote: > The file drivers' *_parse_filename() implementations just strip the > optional protocol prefix off the filename. However, for e.g. > "file:foo:bar", this would lead to "foo:bar" being stored as the BDS's > filename which looks like it should be managed usi

Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for colon handling

2017-05-22 Thread Eric Blake
On 05/22/2017 02:52 PM, Max Reitz wrote: > Signed-off-by: Max Reitz > --- > tests/qemu-iotests/126 | 105 > + > tests/qemu-iotests/126.out | 23 ++ > tests/qemu-iotests/group | 1 + > 3 files changed, 129 insertions(+) > create mode 1

Re: [Qemu-devel] [PATCH v2 3/3] iotests: Add test for colon handling

2017-05-22 Thread Max Reitz
On 2017-05-22 22:06, Eric Blake wrote: > On 05/22/2017 02:52 PM, Max Reitz wrote: >> Signed-off-by: Max Reitz >> --- >> tests/qemu-iotests/126 | 105 >> + >> tests/qemu-iotests/126.out | 23 ++ >> tests/qemu-iotests/group | 1 + >> 3 f

Re: [Qemu-devel] [PATCH 3/4] block: Simplify use of BDRV_BLOCK_RAW.

2017-05-22 Thread Eric Blake
On 05/18/2017 09:32 PM, Eric Blake wrote: Not sure why I included a trailing dot in the subject line; a maintainer can remove that if desired. > The lone caller that cares about a return of BDRV_BLOCK_RAW > completely replaces the return value, so there is no point in > passing BDRV_BLOCK_DATA.

[Qemu-devel] [PATCH] qemu-doc: Add hyperlinks to further license information

2017-05-22 Thread Thomas Huth
Add a link to the GPLv2 and a link to the LICENSE file in the QEMU repository to fix the two TODO items in this appendix. Signed-off-by: Thomas Huth --- qemu-doc.texi | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/qemu-doc.texi b/qemu-doc.texi index de0cc30..b0bfd84

[Qemu-devel] [PATCH] qemu-doc: Move the qemu-ga description into a separate chapter

2017-05-22 Thread Thomas Huth
The qemu-ga description is currently a subsection of the Disk Images chapter - which does not make much sense since the qemu-ga is not directly related to disk images. So let's move this information into a separate chapter instead. Signed-off-by: Thomas Huth --- qemu-doc.texi | 13 +++--

[Qemu-devel] [PATCH v2 12/13] vvfat: handle KANJI lead byte 0xe5

2017-05-22 Thread Hervé Poussineau
Specification: "FAT: General overview of on-disk format" v1.03, page 23 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 5376659010..53e8faa54c 100644 --- a/block/vvfat.c +++ b/block/

[Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode

2017-05-22 Thread Hervé Poussineau
Hi, This patchset fixes some of issues I encountered when trying to use vvfat, and fixes bug #1599539: https://bugs.launchpad.net/qemu/+bug/1599539 Patch 1 fixes a crash when using 'qemu-img convert'. Patches 2 to 6 are code cleanup. No functionnal changes. Patches 7 to 13 fix problems detected

[Qemu-devel] [PATCH v2 03/13] vvfat: fix typos

2017-05-22 Thread Hervé Poussineau
Signed-off-by: Hervé Poussineau --- block/vvfat.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index d3afb731b6..8b5f53ad26 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @@ -404,9 +404,9 @@ static void init_mbr(BDRVVVFATState *s, int c

[Qemu-devel] [PATCH v2 08/13] vvfat: correctly create long names for non-ASCII filenames

2017-05-22 Thread Hervé Poussineau
Assume that input filename is encoded as UTF-8, so correctly create UTF-16 encoding. Signed-off-by: Hervé Poussineau --- block/vvfat.c | 38 ++ 1 file changed, 18 insertions(+), 20 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index d4664c531b..d34

[Qemu-devel] [PATCH v2 11/13] vvfat: limit number of entries in root directory in FAT12/FAT16

2017-05-22 Thread Hervé Poussineau
FAT12/FAT16 root directory is two sectors in size, which allows only 512 directory entries. Prevent QEMU startup if too much files exist, instead of overflowing root directory. Also introduce variable root_entries, which will be required for FAT32. Fixes: https://bugs.launchpad.net/qemu/+bug/15

[Qemu-devel] [PATCH v2 13/13] vvfat: change OEM name to 'MSWIN4.1'

2017-05-22 Thread Hervé Poussineau
According to specification: "'MSWIN4.1' is the recommanded setting, because it is the setting least likely to cause compatibility problems. If you want to put something else in here, that is your option, but the result may be that some FAT drivers might not recognize the volume." Specification: "F

[Qemu-devel] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert

2017-05-22 Thread Hervé Poussineau
- bs->total_sectors is the number of sectors of the whole disk - s->sector_count is the number of sectors of the FAT partition This fixes the following assert in qemu-img map: qemu-img.c:2641: get_block_status: Assertion `nb_sectors' failed. This also fixes an infinite loop in qemu-img convert.

[Qemu-devel] [PATCH v2 07/13] vvfat: always create . and .. entries at first and in that order

2017-05-22 Thread Hervé Poussineau
readdir() doesn't always return . and .. entries at first and in that order. This leads to not creating them at first in the directory, which raises some errors on file system checking utilities like MS-DOS Scandisk. Specification: "FAT: General overview of on-disk format" v1.03, page 25 Fixes: h

[Qemu-devel] [PATCH v2 06/13] vvfat: fix field names in FAT12/FAT16 and FAT32 boot sectors

2017-05-22 Thread Hervé Poussineau
Specification: "FAT: General overview of on-disk format" v1.03, pages 11-13 Signed-off-by: Hervé Poussineau --- block/vvfat.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index e694d82df4..c1034cdd1f 100644 --- a/block/vv

[Qemu-devel] [PATCH v2 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir

2017-05-22 Thread Hervé Poussineau
- offset_to_bootsector is the number of sectors up to FAT bootsector - offset_to_fat is the number of sectors up to first File Allocation Table - offset_to_root_dir is the number of sectors up to root directory sector Replace first_sectors_number - 1 by offset_to_bootsector. Replace first_sectors_

[Qemu-devel] [PATCH v2 10/13] vvfat: correctly generate numeric-tail of short file names

2017-05-22 Thread Hervé Poussineau
More specifically: - try without numeric-tail only if LFN didn't have invalid short chars - start at ~1 (instead of ~0) - handle case if numeric tail is more than one char (ie > 10) Windows 9x Scandisk doesn't see anymore mismatches between short file names and long file names for non-ASCII filena

Re: [Qemu-devel] [Qemu-block] [PATCH v2 01/13] vvfat: fix qemu-img map and qemu-img convert

2017-05-22 Thread Eric Blake
On 05/22/2017 04:11 PM, Hervé Poussineau wrote: > - bs->total_sectors is the number of sectors of the whole disk > - s->sector_count is the number of sectors of the FAT partition > > This fixes the following assert in qemu-img map: > qemu-img.c:2641: get_block_status: Assertion `nb_sectors' failed

[Qemu-devel] [PATCH v2 04/13] vvfat: rename useless enumeration values

2017-05-22 Thread Hervé Poussineau
MODE_FAKED and MODE_RENAMED are not and were never used. Signed-off-by: Hervé Poussineau --- block/vvfat.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/block/vvfat.c b/block/vvfat.c index 8b5f53ad26..6a36d4f7fa 100644 --- a/block/vvfat.c +++ b/block/vvfat.c @

[Qemu-devel] [PATCH v2 09/13] vvfat: correctly create base short names for non-ASCII filenames

2017-05-22 Thread Hervé Poussineau
More specifically, create short name from filename and change blacklist of invalid chars to whitelist of valid chars. Windows 9x also now correctly see long file names of filenames containing a space, but Scandisk still complains about mismatch between SFN and LFN. Specification: "FAT: General o

[Qemu-devel] [PATCH v2 02/13] vvfat: replace tabs by 8 spaces

2017-05-22 Thread Hervé Poussineau
This was a complete mess. On 2299 indented lines: - 1329 were with spaces only - 617 with tabulations only - 353 with spaces and tabulations Signed-off-by: Hervé Poussineau --- block/vvfat.c | 2054 - 1 file changed, 1027 insertions(+), 102

Re: [Qemu-devel] [PATCH v8 14/21] (SQUASHED) move doc to schema

2017-05-22 Thread Eric Blake
On 01/13/2017 08:41 AM, Marc-André Lureau wrote: > qmp-commands: move 'add_client' doc to schema > Sadly, the squashed version introduced some documentation regressions. For example, the documentation for blockdev-snapshot (got merged as commit 3282eca4): > @@ -983,9 +1193,31 @@ > # > # Genera

[Qemu-devel] [PATCH] qapi: Fix some blockdev-add documentation regressions

2017-05-22 Thread Eric Blake
In the process of getting rid of docs/qmp-commands.txt, we managed to regress on any text that changed after the point where the move was first branched and when the move actually occurred. For example, commit 3282eca for blockdev-snapshot re-added the extra "options" layer which had been cleaned

Re: [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode

2017-05-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20170522211205.14265-1-hpous...@reactos.org Subject: [Qemu-devel] [PATCH v2 00/13] vvfat: misc fixes for read-only mode Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 t

Re: [Qemu-devel] [PATCH V2] migration: expose qemu_announce_self() via qmp

2017-05-22 Thread Germano Veit Michel
Ohh, sorry. I don't know how or why, but I missed all your replies (this was archived in gmail) Below is qmp-net-test.c, It's just a copy and paste of what Markus suggested. I could try doing it with a socket (virtio-net-test.c) as Jason suggested but I'm afraid I won't have time this week as supp

Re: [Qemu-devel] [PATCH 2/2] hw/arm: Integrate ADC model into Aspeed SoC

2017-05-22 Thread Alistair Francis
On Fri, May 19, 2017 at 5:26 PM, Andrew Jeffery wrote: > Signed-off-by: Andrew Jeffery The connections look good to me. I'll have a look at V2 of your first patch. Reviewed-by: Alistair Francis Thanks, Alistair > --- > hw/arm/aspeed_soc.c | 15 +++ > include/hw/arm/asp

[Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues.

2017-05-22 Thread John Bradley via Qemu-devel
>From 468b7c74d36b1e9d56ca014531301f0485254866 Mon Sep 17 00:00:00 2001 From: John Bradley Date: Fri, 19 May 2017 00:01:07 +0100 Subject: [PATCH] [PATCH V2] GDummyPanel Fix formatingissues. Add inital discussion of protocol version. Add code to connect with https://github.com/flypie/GDummyPanel

Re: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues.

2017-05-22 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 56fa8a79-fa90-4adc-aa0e-0527c9d96698@ONE.local Subject: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingi

Re: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues.

2017-05-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 56fa8a79-fa90-4adc-aa0e-0527c9d96698@ONE.local Subject: [Qemu-devel] [PATCH] [PATCH V2] GDummyPanel Fix formatingissues. Type: series === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1

Re: [Qemu-devel] [PATCH 1/4] target/arm: optimize aarch32 rev16

2017-05-22 Thread Richard Henderson
On 05/16/2017 04:01 PM, Aurelien Jarno wrote: Use the same mask to avoid having to load two different constants, as suggested by Richard Henderson. Signed-off-by: Aurelien Jarno --- target/arm/translate.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) Reviewed-by: Richard Hende

Re: [Qemu-devel] [PATCH 2/4] target/arm: simplify and optimize aarch64 rev16

2017-05-22 Thread Richard Henderson
On 05/16/2017 04:01 PM, Aurelien Jarno wrote: Instead of byteswapping individual 16-bit words one by one, work on the whole register at the same time using shifts and mask. This is the same strategy than the aarch32 version of rev16 and is much more efficient in the case sf=1. Signed-off-by: Aur

Re: [Qemu-devel] [PATCH 3/4] target/cris: optimize swap

2017-05-22 Thread Richard Henderson
On 05/16/2017 04:01 PM, Aurelien Jarno wrote: Use the same mask to avoid having to load two different constants, as suggest by Richard Henderson. Also use one less temp. Signed-off-by: Aurelien Jarno --- target/cris/translate.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletion

[Qemu-devel] [PATCH] Add code to connect to external panel, for ARM

2017-05-22 Thread John Bradley via Qemu-devel
>From 9256c1450557ed67b4328761ab80b4e80be26e3e Mon Sep 17 00:00:00 2001 From: John Bradley Date: Tue, 23 May 2017 01:43:32 +0100 Subject: [PATCH] Add code to connect to external panel, for ARM Has no effect if panel not found. GDummyPanel Fix formating issues. Add inital discussion of protocol

Re: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM

2017-05-22 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Type: series Subject: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM Message-id: 1da30c06-46bd-47fa-b0ef-

Re: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM

2017-05-22 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH] Add code to connect to external panel, for ARM Message-id: 1da30c06-46bd-47fa-b0ef-886ea9ab84e5@ONE.local === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n

Re: [Qemu-devel] [PATCH 4/4] target/mips: optimize WSBH, DSBH and DSHD

2017-05-22 Thread Richard Henderson
On 05/16/2017 04:01 PM, Aurelien Jarno wrote: Use the same mask to avoid having to load two different constants, as suggested by Richard Henderson. Signed-off-by: Aurelien Jarno --- target/mips/translate.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) Reviewed-by

Re: [Qemu-devel] [PATCH v2] e1000e: Fix ICR "Other" causes clear logic

2017-05-22 Thread Jason Wang
On 2017年05月22日 19:26, Sameeh Jubran wrote: This commit fixes a bug which causes the guest to hang. The bug was observed upon a "receive overrun" (bit #6 of the ICR register) interrupt which could be triggered post migration in a heavy traffic environment. Even though the "receive overrun" bit

[Qemu-devel] [PATCH V2] Add code to connect to external panel, for ARM

2017-05-22 Thread John Bradley via Qemu-devel
>From 5f5c186162ef5f56872095318106e9fe360ae310 Mon Sep 17 00:00:00 2001 From: John Bradley Date: Tue, 23 May 2017 01:43:32 +0100 Subject: [PATCH] Add code to connect to external panel, for ARM Has no effect if panel not found. GDummyPanel Fix formating issues. Add inital discussion of protocol

Re: [Qemu-devel] [PATCH v2 00/11] Preparation for block job mutex

2017-05-22 Thread Jeff Cody
On Mon, May 08, 2017 at 04:12:59PM +0200, Paolo Bonzini wrote: > These are a bunch of cleanups and patches extracted from the AioContext > lock removal series. As a general theme, the patches reorganize > blockjob.c to follow the blockjob.h/blockjob_int.h separation more > closely. For this reaso

Re: [Qemu-devel] [virtio-dev] Re: [PATCH RFC] virtio-net: enable configurable tx queue size

2017-05-22 Thread Jason Wang
On 2017年05月22日 19:52, Wei Wang wrote: On 05/20/2017 04:42 AM, Michael S. Tsirkin wrote: On Fri, May 19, 2017 at 10:32:19AM +0800, Wei Wang wrote: This patch enables the virtio-net tx queue size to be configurable between 256 (the default queue size) and 1024 by the user. The queue size specif

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-22 Thread Jason Wang
On 2017年05月22日 19:46, Wang, Wei W wrote: On Monday, May 22, 2017 10:28 AM, Jason Wang wrote: On 2017年05月19日 23:33, Stefan Hajnoczi wrote: On Fri, May 19, 2017 at 11:10:33AM +0800, Jason Wang wrote: On 2017年05月18日 11:03, Wei Wang wrote: On 05/17/2017 02:22 PM, Jason Wang wrote: On 2017年05月1

Re: [Qemu-devel] A problem of IRQchip in QEMU and KVM for ARM

2017-05-22 Thread Li Zhang
Any idea? Thanks. On Fri, May 19, 2017 at 1:46 PM, Li Zhang wrote: > > Hi, > > I am looking into QEMU code in ARM recently and trying to add add_hot_cpu in > QEMU for ARM, > but it doesn't work when enabling KVM. It reports error: > > "kvm_init_vcpu failed: Device or resourc busy." > > By debu

Re: [Qemu-devel] [PATCH 0/7] KVM: MMU: fast write protect

2017-05-22 Thread Xiao Guangrong
Ping... Sorry to disturb, just make this patchset not be missed. :) On 05/04/2017 03:06 PM, Paolo Bonzini wrote: On 04/05/2017 05:36, Xiao Guangrong wrote: Great. As there is no conflict between these two patchsets except dirty ring pages takes benefit from write-protect-all, i think they

[Qemu-devel] [PULL 1/9] net/tap: Replace tap-haiku.c and tap-aix.c by a generic tap-stub.c

2017-05-22 Thread Jason Wang
From: Thomas Huth The files tap-haiku.c and tap-aix.c are identical (except one line of error message). We should avoid such code duplication, so replace these by a generic tap-stub.c file instead. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Jason Wang --- n

[Qemu-devel] [PULL 0/9] Net patches

2017-05-22 Thread Jason Wang
The following changes since commit 56821559f0ba682fe6b367815572e6f974d329ab: Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) are available in the git repository at: https://github.com/jasowang/qemu.git tags/net-pull-request for you to

[Qemu-devel] [PULL 4/9] COLO-compare: Improve tcp compare trace event readability

2017-05-22 Thread Jason Wang
From: Zhang Chen Because of previous patch's trace arguments over the limit of UST backend, so I rewrite the patch. Signed-off-by: Zhang Chen Signed-off-by: Jason Wang --- net/colo-compare.c | 33 ++--- net/trace-events | 3 +-- 2 files changed, 23 insertions(+)

[Qemu-devel] [PULL 5/9] hmp / net: Mark host_net_add/remove as deprecated

2017-05-22 Thread Jason Wang
From: Thomas Huth The netdev_add and netdev_del commands should be used nowadays instead. Signed-off-by: Thomas Huth Signed-off-by: Jason Wang --- hmp-commands.hx | 8 net/net.c | 13 + 2 files changed, 17 insertions(+), 4 deletions(-) diff --git a/hmp-commands.hx

[Qemu-devel] [PULL 2/9] net/dump: Issue a warning for the deprecated "-net dump"

2017-05-22 Thread Jason Wang
From: Thomas Huth Network dumping should be done with "-object filter-dump" nowadays. Using "-net dump" via the VLAN mechanism is considered as deprecated and might be removed in a future release. So warn the users now to inform them to user the filter-dump method instead. Signed-off-by: Thomas

[Qemu-devel] [PULL 3/9] virtio-net: fix wild pointer when remove virtio-net queues

2017-05-22 Thread Jason Wang
From: Yunjian Wang The tx_bh or tx_timer will free in virtio_net_del_queue() function, when removing virtio-net queues if the guest doesn't support multiqueue. But it might be still referenced by virtio_net_set_status(), which needs to be set NULL. And also the tx_waiting needs to be set zero to

<    1   2   3   >