Re: [Qemu-devel] [PATCH 2/3] numa: move default mapping init to machine

2017-05-22 Thread Igor Mammedov
On Thu, 18 May 2017 15:50:58 -0300 Eduardo Habkost wrote: > On Thu, May 18, 2017 at 10:09:30AM +0200, Igor Mammedov wrote: > > there is no need use cpu_index_to_instance_props() for setting > > default cpu -> node mapping. Generic machine code can do it > > without cpu_index by just enabling alre

Re: [Qemu-devel] [PATCH risu] ppc64: Fix patterns for rotate doubleword instructions

2017-05-22 Thread Nikunj A Dadhania
Sandipan Das writes: > The patterns for the following instructions are fixed: > * Rotate Left Doubleword then Clear Right (rldcr[.]) > * Rotate Left Doubleword Immediate then Clear Right (rldicr[.]) > * Rotate Left Doubleword Immediate then Mask Insert (rldimi[.]) > > Signed-off-by: Sandipan D

[Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM

2017-05-22 Thread Gonglei (Arei)
Hi Paolo, I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0. Replication Steps: 1. I created a CentOS 7 with 4U8G using Qemu-2.3.0, # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}' 16932864 # grep kvm_kvzalloc /proc/vmallocinfo 0xc900205c700

Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM

2017-05-22 Thread Gonglei (Arei)
Attaching the backtrace [call kvm_set_user_memory_region() twice]: In the KVM side: [3287581.559570] gonglei: vzalloc, size=10485760 [3287581.564108] CPU: 19 PID: 3240 Comm: qemu-system-x86 Tainted: G OE --- 3.10.0-327.44.58.25_6.x86_64 #1 [3287581.575761] Hardware name: To

Re: [Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types

2017-05-22 Thread Markus Armbruster
Eduardo Habkost writes: > On Thu, May 18, 2017 at 01:59:53PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > Currently there's no way for QMP clients to get a list of device types >> > that are really usable with -device. This information would be useful >> > for management

Re: [Qemu-devel] [PATCH v2 4/4] spapr: fix migration of ICP objects from/to older QEMU

2017-05-22 Thread Cédric Le Goater
On 05/22/2017 04:30 AM, David Gibson wrote: > On Fri, May 19, 2017 at 12:32:27PM +0200, Greg Kurz wrote: >> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under >> sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This >> is an improvement since we no longer allocate I

Re: [Qemu-devel] [PATCH] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-22 Thread Markus Armbruster
Thomas Huth writes: > When you currently try to run a test directly from the command line > without setting the QTEST_QEMU_BINARY environment variable first, > you are presented with an unhelpful assertion message like this: > > ERROR:tests/libqtest.c:163:qtest_init_without_qmp_handshake: > ass

Re: [Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-22 Thread Markus Armbruster
Greg Kurz writes: > On Sat, 20 May 2017 16:45:09 +1000 > David Gibson wrote: > >> On Fri, May 19, 2017 at 12:32:12PM +0200, Greg Kurz wrote: >> > If the user explicitely asked for kernel-irqchip support and "xics-kvm" >> > initialization fails, we shouldn't fallback to emulated "xics" as we >> >

Re: [Qemu-devel] [PATCH V5 7/9] migration: calculate vCPU blocktime on dst side

2017-05-22 Thread Alexey Perevalov
On 05/19/2017 10:05 PM, Dr. David Alan Gilbert wrote: * Alexey (a.pereva...@samsung.com) wrote: On Tue, May 16, 2017 at 12:34:16PM +0100, Dr. David Alan Gilbert wrote: * Alexey Perevalov (a.pereva...@samsung.com) wrote: This patch provides blocktime calculation per vCPU, as a summary and as a

Re: [Qemu-devel] [PATCH v4 1/3] net/rocker: Remove the dead error handling

2017-05-22 Thread Mao Zhongyi
On 05/22/2017 02:35 PM, Markus Armbruster wrote: Mao Zhongyi writes: Hi, Markus Thanks for review and sorry for replying late, I was on the weekend. No need to apologize for the weekend. I hope you enjoyed it :) On 05/19/2017 02:24 PM, Markus Armbruster wrote: Mao Zhongyi writes: Th

Re: [Qemu-devel] [PATCH v3 03/24] docker: rebuild image if 'extra files' checksum does not match

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/docker.py | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) Hmm odd what bracnh did you cut this from. git apply-mbox keeps falling over: Applying: docker: rebuild image if 'ext

Re: [Qemu-devel] [PATCH 3/3] numa: silence incomplete mapping warning under qtest

2017-05-22 Thread Igor Mammedov
On Thu, 18 May 2017 15:20:39 -0300 Eduardo Habkost wrote: > On Thu, May 18, 2017 at 10:09:31AM +0200, Igor Mammedov wrote: > > Suggested-by: Markus Armbruster > > Signed-off-by: Igor Mammedov > > Where exactly is the test code that triggers those messages and > requires this patch? I would l

Re: [Qemu-devel] [PATCH RFC 1/6] io: only allow return path for socket typed

2017-05-22 Thread Daniel P. Berrange
On Fri, May 19, 2017 at 07:41:34PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Fri, May 19, 2017 at 03:33:12PM +0100, Dr. David Alan Gilbert wrote: > > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > > > shutdown() is safe, in that it st

Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM

2017-05-22 Thread Paolo Bonzini
On 22/05/2017 09:04, Gonglei (Arei) wrote: > Hi Paolo, > > I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0. > > Replication Steps: > > 1. I created a CentOS 7 with 4U8G using Qemu-2.3.0, > > # grep kvm_kvzalloc /proc/vmallocinfo | awk '{total+=$2}; END {print total}' >

Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM

2017-05-22 Thread Daniel P. Berrange
On Mon, May 22, 2017 at 10:27:59AM +0200, Paolo Bonzini wrote: > > > On 22/05/2017 09:04, Gonglei (Arei) wrote: > > Hi Paolo, > > > > I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0. > > > > Replication Steps: > > > > 1. I created a CentOS 7 with 4U8G using Qemu-2.3.0,

Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM

2017-05-22 Thread Gonglei (Arei)
> -Original Message- > From: kvm-ow...@vger.kernel.org [mailto:kvm-ow...@vger.kernel.org] On > Behalf Of Daniel P. Berrange > Sent: Monday, May 22, 2017 4:32 PM > To: Paolo Bonzini > Cc: Gonglei (Arei); qemu-devel@nongnu.org; k...@vger.kernel.org > Subject: Re: [Qemu-devel] [RFC] memory co

Re: [Qemu-devel] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

2017-05-22 Thread Greg Kurz
On Mon, 22 May 2017 12:04:13 +1000 David Gibson wrote: > On Fri, May 19, 2017 at 12:32:20PM +0200, Greg Kurz wrote: > > For historical reasons, we compute CPU device-tree ids with a non-trivial > > logic. This patch consolidate the logic in a single helper to be used > > in various places where i

Re: [Qemu-devel] [PATCH v2 2/4] spapr: fix error reporting in xics_system_init()

2017-05-22 Thread David Gibson
On Mon, May 22, 2017 at 09:41:48AM +0200, Markus Armbruster wrote: > Greg Kurz writes: > > > On Sat, 20 May 2017 16:45:09 +1000 > > David Gibson wrote: > > > >> On Fri, May 19, 2017 at 12:32:12PM +0200, Greg Kurz wrote: > >> > If the user explicitely asked for kernel-irqchip support and "xics-kv

Re: [Qemu-devel] [Qemu-block] [PATCH v2 00/11] Preparation for block job mutex

2017-05-22 Thread Stefan Hajnoczi
On Sun, May 21, 2017 at 03:17:50PM +0200, Paolo Bonzini wrote: > Ping? I think this should go through Jeff's tree. Stefan signature.asc Description: PGP signature

Re: [Qemu-devel] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

2017-05-22 Thread Greg Kurz
On Mon, 22 May 2017 12:12:46 +1000 David Gibson wrote: > On Mon, May 22, 2017 at 12:04:13PM +1000, David Gibson wrote: > > On Fri, May 19, 2017 at 12:32:20PM +0200, Greg Kurz wrote: > > > For historical reasons, we compute CPU device-tree ids with a non-trivial > > > logic. This patch consolida

Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM

2017-05-22 Thread Paolo Bonzini
On 22/05/2017 10:32, Daniel P. Berrange wrote: > On Mon, May 22, 2017 at 10:27:59AM +0200, Paolo Bonzini wrote: >> >> >> On 22/05/2017 09:04, Gonglei (Arei) wrote: >>> Hi Paolo, >>> >>> I found that the latest Qemu eat 2 time memory in KVM since Qemu-2.3.0. >>> >>> Replication Steps: >>> >>> 1. I c

Re: [Qemu-devel] [PULL] Update OpenBIOS images

2017-05-22 Thread Stefan Hajnoczi
On Fri, May 19, 2017 at 05:11:56PM +0100, Mark Cave-Ayland wrote: > Hi Stefan, > > This update contains the OpenBIOS VGA driver updates required to enable Ben's > QemuMacDrivers > for Mac guests. Please pull. > > > ATB, > > Mark. > > > The following changes since commit 56821559f0ba682fe6b36

Re: [Qemu-devel] How to pass intercepted mouse move x and y from host to a virtual machine running in Qemu

2017-05-22 Thread Stefan Hajnoczi
On Sat, May 20, 2017 at 10:44:23AM +0300, Alexander Syvak wrote: > Hi, guys! > > There exists a manually written virtual USB device registered as Qemu type. > > It reads 5 bytes > > - x and y of a mouse move, x and y of scrolling, and buttons state - > > from mouse.fifo but there is no code in

[Qemu-devel] [PATCH] change CPU container node _HID to compatible PNP0A05

2017-05-22 Thread Evgeny Yakovlev
This change is a workaround for win2016 problem with qemu CPU container ACPI nodes: https://bugzilla.redhat.com/show_bug.cgi?id=1377155#c31 It seems to work properly on all tested windows versions (2008 and later) however we're not sure what side effects this change may have. So any comments are w

[Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

2017-05-22 Thread Evgeny Yakovlev
When running windows 2016 server guests we have encountered a problem with ACPI representation of CPU devices. This windows version contains a hidinterrupt.sys driver which looks for ACPI device node with _HID set to "ACPI0010" and "ACPI0011". ACPI0010 is also a valid id for CPU container device wh

Re: [Qemu-devel] [PATCH v3 01/24] docker: let _copy_with_mkdir() sub_path argument be optional

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/docker.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/docker.py b/tests/docker/docker.py > index 8747f6a440..6ddc6e4c2a 100755 > ---

Re: [Qemu-devel] [PATCH v3 02/24] docker: add --include-files argument to 'build' command

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/Makefile.include | 5 - > tests/docker/docker.py| 12 +--- > 2 files changed, 13 insertions(+), 4 deletions(-) > > diff --git a/tests/docker/Makefile.inc

Re: [Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

2017-05-22 Thread Igor Mammedov
On Mon, 22 May 2017 12:50:30 +0300 Evgeny Yakovlev wrote: > When running windows 2016 server guests we have encountered a problem > with ACPI representation of CPU devices. This windows version contains a > hidinterrupt.sys driver which looks for ACPI device node with _HID set > to "ACPI0010" and

Re: [Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

2017-05-22 Thread Evgeny Yakovlev
On 22.05.2017 13:35, Igor Mammedov wrote: On Mon, 22 May 2017 12:50:30 +0300 Evgeny Yakovlev wrote: When running windows 2016 server guests we have encountered a problem with ACPI representation of CPU devices. This windows version contains a hidinterrupt.sys driver which looks for ACPI devi

Re: [Qemu-devel] [PATCH] e1000e: Fix a bug where guest hangs upon migration

2017-05-22 Thread Sameeh Jubran
On Mon, May 22, 2017 at 5:46 AM, Jason Wang wrote: > > > On 2017年05月19日 22:04, Sameeh Jubran wrote: > >> On Fri, May 19, 2017 at 9:25 AM, Jason Wang wrote: >> >> >>> On 2017年05月17日 19:46, Sameeh Jubran wrote: >>> >>> The bug was caused by the "receive overrun" (bit #6 of the ICR register) i

[Qemu-devel] [PATCH v2] e1000e: Fix ICR "Other" causes clear logic

2017-05-22 Thread Sameeh Jubran
This commit fixes a bug which causes the guest to hang. The bug was observed upon a "receive overrun" (bit #6 of the ICR register) interrupt which could be triggered post migration in a heavy traffic environment. Even though the "receive overrun" bit (#6) is masked out by the IMS register (refer

[Qemu-devel] [Bug 1527765] Re: sh4: ghc randomly segfaults on qemu-sh4-static

2017-05-22 Thread John Paul Adrian Glaubitz
Just tested with the latest git snapshot of qemu, still no improvement: ... checking for gfind... no checking for find... /usr/bin/find checking for sort... /usr/bin/sort checking for GHC Git commit id... given 4986837f8168cacf95c24fecc84d7b36c47f3c11 checking version of ghc... 8.0.1 ghc: pthread_

Re: [Qemu-devel] [PATCH 1/1] qcow2: handle cluster leak happening with a guest TRIM command

2017-05-22 Thread Eric Blake
On 05/21/2017 09:21 AM, Denis V. Lunev wrote: > qemu-img create -f qcow2 1.img 64G > qemu-io -c "write -P 0x32 0 64k" 1.img > results in > 324 -rw-r--r-- 1 den den 393216 May 21 16:48 1.img > Subsequent > qemu-io -c "write -z 0 64k" 1.img > qemu-io -c "write -P 0x32 0 64k" 1.img > results

Re: [Qemu-devel] [virtio-dev] Re: [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-22 Thread Wang, Wei W
On Monday, May 22, 2017 10:28 AM, Jason Wang wrote: > On 2017年05月19日 23:33, Stefan Hajnoczi wrote: > > On Fri, May 19, 2017 at 11:10:33AM +0800, Jason Wang wrote: > >> On 2017年05月18日 11:03, Wei Wang wrote: > >>> On 05/17/2017 02:22 PM, Jason Wang wrote: > On 2017年05月17日 14:16, Jason Wang wrote

Re: [Qemu-devel] [virtio-dev] Re: [PATCH RFC] virtio-net: enable configurable tx queue size

2017-05-22 Thread Wei Wang
On 05/20/2017 04:42 AM, Michael S. Tsirkin wrote: On Fri, May 19, 2017 at 10:32:19AM +0800, Wei Wang wrote: This patch enables the virtio-net tx queue size to be configurable between 256 (the default queue size) and 1024 by the user. The queue size specified by the user should be power of 2. Se

Re: [Qemu-devel] [PATCH 1/1] qcow2: handle cluster leak happening with a guest TRIM command

2017-05-22 Thread Denis V. Lunev
On 05/22/2017 02:37 PM, Eric Blake wrote: > On 05/21/2017 09:21 AM, Denis V. Lunev wrote: >> qemu-img create -f qcow2 1.img 64G >> qemu-io -c "write -P 0x32 0 64k" 1.img >> results in >> 324 -rw-r--r-- 1 den den 393216 May 21 16:48 1.img >> Subsequent >> qemu-io -c "write -z 0 64k" 1.img >>

Re: [Qemu-devel] [PATCH v2 4/4] migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all()

2017-05-22 Thread Kevin Wolf
Am 19.05.2017 um 12:32 hat Stefan Hajnoczi geschrieben: > blk/bdrv_drain_all() only takes effect for a single instant and then > resumes block jobs, guest devices, and other external clients like the > NBD server. This can be handy when performing a synchronous drain > before terminating the progr

Re: [Qemu-devel] Migration downtime more than 5s when migrating guest with massive disks

2017-05-22 Thread Paolo Bonzini
On 20/05/2017 02:46, Yang Hongyang wrote: >>> How about do O(1) for stopping stage of live migration? >>> Because the cpu is stopped in this phase, it wouldn't cause >>> side effects IMHO, right? >> O(1) update is probably not quite possible, but it's possible to do one >> O(n) update. We trie

[Qemu-devel] [PATCH] usb-hub: set PORT_STAT_C_SUSPEND on host-initiated wake-up

2017-05-22 Thread Ladi Prosek
PORT_STAT_C_SUSPEND should be set even on host-initiated wake-up, i.e. on ClearPortFeature(PORT_SUSPEND). Windows is known to not work properly otherwise. Side note, since PORT_ENABLE looks similar and might appear to have the same issue: According to 11.24.2.7.2.2 C_PORT_ENABLE: "This bit is s

Re: [Qemu-devel] Migration downtime more than 5s when migrating guest with massive disks

2017-05-22 Thread Yang Hongyang
On 2017/5/22 20:26, Paolo Bonzini wrote: > > > On 20/05/2017 02:46, Yang Hongyang wrote: How about do O(1) for stopping stage of live migration? Because the cpu is stopped in this phase, it wouldn't cause side effects IMHO, right? >>> O(1) update is probably not quite possible,

Re: [Qemu-devel] [PATCH v4 0/8] Provide support for the software TPM emulator

2017-05-22 Thread Valluri, Amarnath
Gentle request to review this patchset > -Original Message- > From: Valluri, Amarnath > Sent: Tuesday, May 16, 2017 10:58 AM > To: qemu-devel@nongnu.org > Cc: Valluri, Amarnath > Subject: [Qemu-devel][PATCH v4 0/8] Provide support for the software TPM > emulator > > Briefly, Theses set o

[Qemu-devel] Offset

2017-05-22 Thread ali saeedi
Hello what is the difference between offset is available in 'PageSearchStatus' struct and offset in 'RamBlock' struct in Ram.c File? thanks a lot

[Qemu-devel] TARGET_PAGE_BITS

2017-05-22 Thread ali saeedi
Hello What is TARGET_PAGE_BITS in ram.c? thanks a lot

Re: [Qemu-devel] [PATCH] acpi: change CPU container node _HID to compatible PNP0A05

2017-05-22 Thread Igor Mammedov
On Mon, 22 May 2017 14:01:15 +0300 Evgeny Yakovlev wrote: > On 22.05.2017 13:35, Igor Mammedov wrote: > > On Mon, 22 May 2017 12:50:30 +0300 > > Evgeny Yakovlev wrote: > > > >> When running windows 2016 server guests we have encountered a problem > >> with ACPI representation of CPU devices. T

Re: [Qemu-devel] [PATCH 1/3] numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr

2017-05-22 Thread Eduardo Habkost
On Mon, May 22, 2017 at 08:39:31AM +0200, Igor Mammedov wrote: > On Thu, 18 May 2017 15:19:13 -0300 > Eduardo Habkost wrote: > > > On Thu, May 18, 2017 at 10:09:29AM +0200, Igor Mammedov wrote: > > > Signed-off-by: Igor Mammedov > > > --- > > > include/sysemu/numa.h | 1 + > > > hw/arm/virt.c

Re: [Qemu-devel] [PATCH] cpus: reset throttle_thread_scheduled after sleep

2017-05-22 Thread Jason J. Herne
On 05/19/2017 05:29 PM, Felipe Franciosi wrote: Currently, the throttle_thread_scheduled flag is reset back to 0 before sleeping (as part of the throttling logic). Given that throttle_timer (well, any timer) may tick with a slight delay, it so happens that under heavy throttling (ie. close or on

Re: [Qemu-devel] [PATCH 1/1] qcow2: handle cluster leak happening with a guest TRIM command

2017-05-22 Thread Eric Blake
On 05/22/2017 06:56 AM, Denis V. Lunev wrote: >> >> >> As it is, your patch doesn't apply to master. And even if it did, your >> patch breaks semantics - we CANNOT discard clusters that must read back >> as zeroes. >> > Can you pls give some details why the cluster can not be > discarded? This is

Re: [Qemu-devel] [PATCH risu] ppc64: Fix patterns for rotate doubleword instructions

2017-05-22 Thread G 3
On May 22, 2017, at 4:32 AM, qemu-devel-requ...@nongnu.org wrote: Message: 2 Date: Mon, 22 May 2017 12:33:29 +0530 From: Nikunj A Dadhania To: Sandipan Das Cc: qemu-devel@nongnu.org, peter.mayd...@linaro.org, jos...@linux.vnet.ibm.com Subject: Re: [Qemu-devel] [PATCH risu] ppc64: Fix

Re: [Qemu-devel] TARGET_PAGE_BITS

2017-05-22 Thread Thomas Huth
On 22.05.2017 14:54, ali saeedi wrote: > Hello > What is TARGET_PAGE_BITS in ram.c? 12, on average, see: grep TARGET_PAGE_BITS target/*/cpu.h > thanks a lot You're welcome. Thomas

Re: [Qemu-devel] [PATCH 2/3] numa: move default mapping init to machine

2017-05-22 Thread Eduardo Habkost
On Mon, May 22, 2017 at 09:04:03AM +0200, Igor Mammedov wrote: > On Thu, 18 May 2017 15:50:58 -0300 > Eduardo Habkost wrote: > > On Thu, May 18, 2017 at 10:09:30AM +0200, Igor Mammedov wrote: [...] > > > > > +default_mapping = !i; /* i == 0 : no explicit mapping provided by > > > user */ > >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

2017-05-22 Thread Greg Kurz
On Mon, 22 May 2017 10:59:50 +0200 Greg Kurz wrote: > On Mon, 22 May 2017 12:04:13 +1000 > David Gibson wrote: > > > On Fri, May 19, 2017 at 12:32:20PM +0200, Greg Kurz wrote: > > > For historical reasons, we compute CPU device-tree ids with a non-trivial > > > logic. This patch consolidate t

Re: [Qemu-devel] [PATCH v3 03/24] docker: rebuild image if 'extra files' checksum does not match

2017-05-22 Thread Philippe Mathieu-Daudé
Hi Alex, On 05/22/2017 04:55 AM, Alex Bennée wrote: Philippe Mathieu-Daudé writes: Signed-off-by: Philippe Mathieu-Daudé --- tests/docker/docker.py | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) Hmm odd what bracnh did you cut this from. git apply-mbox keeps falli

Re: [Qemu-devel] [PATCH 1/3] numa: consolidate cpu_preplug fixups/checks for pc/arm/spapr

2017-05-22 Thread Igor Mammedov
On Mon, 22 May 2017 09:58:45 -0300 Eduardo Habkost wrote: > On Mon, May 22, 2017 at 08:39:31AM +0200, Igor Mammedov wrote: > > On Thu, 18 May 2017 15:19:13 -0300 > > Eduardo Habkost wrote: > > > > > On Thu, May 18, 2017 at 10:09:29AM +0200, Igor Mammedov wrote: > > > > Signed-off-by: Igor M

[Qemu-devel] bitmap

2017-05-22 Thread ali saeedi
Hi does this code 'atomic_rcu_read(&migration_bitmap_rcu)->bmap' return bitmap of dirty blocks or bitmap of pages? thanks a lot

Re: [Qemu-devel] [PATCH v2 4/4] migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all()

2017-05-22 Thread Stefan Hajnoczi
On Mon, May 22, 2017 at 02:17:35PM +0200, Kevin Wolf wrote: > Am 19.05.2017 um 12:32 hat Stefan Hajnoczi geschrieben: > > blk/bdrv_drain_all() only takes effect for a single instant and then > > resumes block jobs, guest devices, and other external clients like the > > NBD server. This can be hand

Re: [Qemu-devel] [PATCH v3 03/24] docker: rebuild image if 'extra files' checksum does not match

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Hi Alex, > > On 05/22/2017 04:55 AM, Alex Bennée wrote: >> >> Philippe Mathieu-Daudé writes: >> >>> Signed-off-by: Philippe Mathieu-Daudé >>> --- >>> tests/docker/docker.py | 15 --- >>> 1 file changed, 12 insertions(+), 3 deletions(-) >> >> Hmm od

Re: [Qemu-devel] [PATCH] block: Tweak error message related to qemu-img convert

2017-05-22 Thread Max Reitz
On 2017-05-20 00:07, Eric Blake wrote: > On 05/19/2017 08:30 AM, Max Reitz wrote: >> On 2017-05-08 19:13, Eric Blake wrote: >>> When converting a 1.1 image down to 0.10, qemu-iotests 060 forces >>> a contrived failure where allocating a cluster used to replace a >>> zero cluster reads unaligned dat

[Qemu-devel] sparc64 linux-user status

2017-05-22 Thread Alex Bennée
Hi, While looking at some of the docker cross-build patches I thought I'd checkout if I could still bootstrap some Debian linux-user images. I made some tweaks to allow debootstrap to bootstrap from Debian's ports to see if I could get the SPARC64 file-system up and running: https://github.com/s

Re: [Qemu-devel] [PATCH v3 04/24] docker: add 'apt-fake' script which generate fake debian packages

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian-apt-fake.sh | 46 > + > 1 file changed, 46 insertions(+) > create mode 100755 tests/docker/dockerfiles/debian-apt-fake.sh > >

Re: [Qemu-devel] [PATCH v3 05/24] docker: install ca-certificates package in base image

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Resolve SSL verification issue at shippable container's git_sync stage: > > shippable logs: > -- > git_sync > - ssh-agent bash -c 'ssh-add /tmp/ssh/01_deploy; git clone > https://github.com/philmd/qemu.git /root/src/github.com/philmd/qemu' > Identity

Re: [Qemu-devel] [PATCH v3 06/24] docker: create deb-src entry and setup Emdebian in the same layer

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian.docker | 12 +--- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/tests/docker/dockerfiles/debian.docker > b/tests/docker/docke

Re: [Qemu-devel] [PATCH v3 07/24] docker: use better regex to generate deb-src entries

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian.docker | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/docker/dockerfiles/debian.docker > b/tests/docker/dockerfiles/debian

Re: [Qemu-devel] [RFC] qmp: Return 'user_creatable' & 'hotpluggable' fields on qom-list-types

2017-05-22 Thread Eduardo Habkost
On Mon, May 22, 2017 at 09:17:58AM +0200, Markus Armbruster wrote: > Eduardo Habkost writes: > > > On Thu, May 18, 2017 at 01:59:53PM +0200, Markus Armbruster wrote: > >> Eduardo Habkost writes: > >> > >> > Currently there's no way for QMP clients to get a list of device types > >> > that are r

[Qemu-devel] [PATCH v3 2/4] block: use BDRV_POLL_WHILE() in bdrv_rw_vmstate()

2017-05-22 Thread Stefan Hajnoczi
Calling aio_poll() directly may have been fine previously, but this is the future, man! The difference between an aio_poll() loop and BDRV_POLL_WHILE() is that BDRV_POLL_WHILE() releases the AioContext around aio_poll(). This allows the IOThread to run fd handlers or BHs to complete the request.

[Qemu-devel] [PATCH v3 4/4] migration: use bdrv_drain_all_begin/end() instead bdrv_drain_all()

2017-05-22 Thread Stefan Hajnoczi
blk/bdrv_drain_all() only takes effect for a single instant and then resumes block jobs, guest devices, and other external clients like the NBD server. This can be handy when performing a synchronous drain before terminating the program, for example. Monitor commands usually need to quiesce I/O a

[Qemu-devel] [PATCH v3 3/4] migration: avoid recursive AioContext locking in save_vmstate()

2017-05-22 Thread Stefan Hajnoczi
AioContext was designed to allow nested acquire/release calls. It uses a recursive mutex so callers don't need to worry about nesting...or so we thought. BDRV_POLL_WHILE() is used to wait for block I/O requests. It releases the AioContext temporarily around aio_poll(). This gives IOThreads a ch

[Qemu-devel] [PATCH v3 0/4] block: fix 'savevm' hang with -object iothread

2017-05-22 Thread Stefan Hajnoczi
v3: * Add missing bdrv_drain_all_end() in error code paths [Kevin] v2: * New patch to use bdrv_drain_all_begin/end() in savevm/loadvm [Kevin] (All other patches unchanged) The 'savevm' command hangs when -object iothread is used. See patches for details, but basically the vmstate read/write

Re: [Qemu-devel] [PATCH v3 10/24] docker: use eatmydata in debian arm64 image

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian-arm64-cross.docker | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker > b/

Re: [Qemu-devel] [PATCH v2 4/4] spapr: fix migration of ICP objects from/to older QEMU

2017-05-22 Thread David Gibson
On Mon, May 22, 2017 at 09:20:42AM +0200, Cédric Le Goater wrote: > On 05/22/2017 04:30 AM, David Gibson wrote: > > On Fri, May 19, 2017 at 12:32:27PM +0200, Greg Kurz wrote: > >> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > >> sPAPRCPUCore") moved ICP objects from the mac

[Qemu-devel] [PATCH v3 1/4] block: count bdrv_co_rw_vmstate() requests

2017-05-22 Thread Stefan Hajnoczi
Call bdrv_inc/dec_in_flight() for vmstate reads/writes. This seems unnecessary at first glance because vmstate reads/writes are done synchronously while the guest is stopped. But we need the bdrv_wakeup() in bdrv_dec_in_flight() so the main loop sees request completion. Besides, it's cleaner to c

Re: [Qemu-devel] [PATCH v3 08/24] docker: use eatmydata, install common build packages in base image

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > The common build packages are: build-essential clang git bison flex > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian.docker | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git

Re: [Qemu-devel] [PATCH v3 09/24] docker: use eatmydata in debian armhf image

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian-armhf-cross.docker | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker > b/

Re: [Qemu-devel] [PATCH v3 12/24] docker: add extra libs to arm64 target to extend codebase coverage

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian-arm64-cross.docker | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/docker/dockerfiles/debian-arm64-cross.docker > b/tests/dock

Re: [Qemu-devel] [PATCH v3 14/24] docker: add mipsel build target

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/Makefile.include | 3 ++ > .../docker/dockerfiles/debian-mipsel-cross.docker | 41 > ++ > 2 files changed, 44 insertions(+) > cre

Re: [Qemu-devel] [PATCH v3 11/24] docker: add extra libs to armhf target to extend codebase coverage

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian-armhf-cross.docker | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/tests/docker/dockerfiles/debian-armhf-cross.docker > b/tests/dock

Re: [Qemu-devel] [PATCH v3 13/24] docker: add extra libs to s390x target to extend codebase coverage

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > tests/docker/dockerfiles/debian-s390x-cross.docker | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/tests/docker/dockerfiles/debian-s390x-cross.docker > b/tests/docke

Re: [Qemu-devel] [PATCH v3 15/24] docker: add powerpc build target

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/Makefile.include | 4 +-- > .../docker/dockerfiles/debian-powerpc-cross.docker | 40 > ++ > 2 files changed, 42 insertions(+), 2 deletions(-) > create mode 10

Re: [Qemu-devel] [PATCH v3 17/24] shippable: build using all available cpus

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > As of this commit: > > $ echo "container proc:" `getconf _NPROCESSORS_ONLN` `getconf > _NPROCESSORS_CONF` > container proc: 2 2 > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .shippable.yml | 2 +- > 1 file changed, 1 insertion(+

Re: [Qemu-devel] [PATCH v3 19/24] shippable: be verbose while building docker images

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .shippable.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.shippable.yml b/.shippable.yml > index 46adfa030f..fe360f85cb 100644 > --- a/.shippable.yml > +++

Re: [Qemu-devel] [PATCH v3 18/24] shippable: do not initialize submodules automatically

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > instead do it in the 'ci' target when needed. > > for mips64el-softmmu target: > use dtc submodule if distrib packages are too old. > > example with outdated libfdt on mips64el-softmmu target (required is >= > 1.4.2): > # dpkg-query --showformat='${Version}\n'

Re: [Qemu-devel] [PATCH v3 20/24] shippable: add armeb-linux-user target

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .shippable.yml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/.shippable.yml b/.shippable.yml > index fe360f85cb..2070c4d827 100644 > --- a/.shippable.yml > +++

Re: [Qemu-devel] [PATCH v3 21/24] shippable: add powerpc target

2017-05-22 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Alex Bennée > --- > .shippable.yml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/.shippable.yml b/.shippable.yml > index 2070c4d827..aad66ec5ec 100644 > --- a/.shippable.yml > +++ b/.shippable.y

Re: [Qemu-devel] [PATCH v3 1/4] ACPI: Add APEI GHES Table Generation support

2017-05-22 Thread Laszlo Ersek
Keeping some context: On 05/12/17 23:00, Laszlo Ersek wrote: > On 04/30/17 07:35, Dongjiu Geng wrote: >> This implements APEI GHES Table by passing the error cper info >> to the guest via a fw_cfg_blob. After a CPER info is added, an >> SEA/SEI exception will be injected into the guest OS. >> >> B

Re: [Qemu-devel] [PATCH 0/2] get rid of qemu_utimens()

2017-05-22 Thread Eric Blake
On 05/19/2017 09:50 AM, Greg Kurz wrote: > It is currently only used by 9pfs and virtfs-proxy-helper. This series convert > them to utimensat() and futimens(). > > -- > Greg > > --- > > Greg Kurz (2): > 9pfs: assume utimensat() and futimens() are present > util: drop old utimensat()

[Qemu-devel] [PATCH risu v2] ppc64: Fix patterns for rotate doubleword instructions

2017-05-22 Thread Sandipan Das
The patterns for the following instructions are fixed: * Rotate Left Doubleword then Clear Right (rldcr[.]) * Rotate Left Doubleword Immediate then Clear Right (rldicr[.]) * Rotate Left Doubleword Immediate then Mask Insert (rldimi[.]) The first instruction has a typo. For the other two instruc

[Qemu-devel] [PATCH risu] ppc64: Fix patterns for rotate doubleword instructions

2017-05-22 Thread Sandipan Das
The patterns for the following instructions are fixed: * Rotate Left Doubleword then Clear Right (rldcr[.]) * Rotate Left Doubleword Immediate then Clear Right (rldicr[.]) * Rotate Left Doubleword Immediate then Mask Insert (rldimi[.]) Signed-off-by: Sandipan Das --- ppc64.risu | 10 +

Re: [Qemu-devel] [Qemu-arm] [PATCH 1/2] hw/adc: Add basic Aspeed ADC model

2017-05-22 Thread Ryan Chen
In ASPEED SoC chip, all register access have following rule. Most of controller write access is only support 32bit access. Read is support 8bits/16bits/32bits. Best Regards, Ryan 信驊科技股份有限公司 ASPEED Technology Inc. 2F,No.15,Industry East Road 4.,Hsinchu Science Park, Hsinchu City 30077, Taiwan

Re: [Qemu-devel] [PATCH v2 3/4] target/ppc: consolidate CPU device-tree id computation in helper

2017-05-22 Thread Greg Kurz
On Mon, 22 May 2017 12:12:46 +1000 David Gibson wrote: > On Mon, May 22, 2017 at 12:04:13PM +1000, David Gibson wrote: > > On Fri, May 19, 2017 at 12:32:20PM +0200, Greg Kurz wrote: > > > For historical reasons, we compute CPU device-tree ids with a non-trivial > > > logic. This patch consolida

Re: [Qemu-devel] [PATCH risu] ppc64: Fix patterns for rotate doubleword instructions

2017-05-22 Thread Sandipan Das
On Monday 22 May 2017 12:33 PM, Nikunj A Dadhania wrote: > Sandipan Das writes: > >> The patterns for the following instructions are fixed: >> * Rotate Left Doubleword then Clear Right (rldcr[.]) >> * Rotate Left Doubleword Immediate then Clear Right (rldicr[.]) >> * Rotate Left Doubleword Imm

Re: [Qemu-devel] [PATCH v2 4/4] spapr: fix migration of ICP objects from/to older QEMU

2017-05-22 Thread Greg Kurz
On Mon, 22 May 2017 19:15:36 +1000 David Gibson wrote: [...] > > > > > > Hrm. I dislike code for the core object directly reaching into the > > > machine to check the compat flag here (and a bunch of other places > > > below). I can think of a few possible ways of avoiding this: > > > > > > 1)

Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM

2017-05-22 Thread Gonglei (Arei)
> -Original Message- > From: Paolo Bonzini [mailto:paolo.bonz...@gmail.com] On Behalf Of Paolo > Bonzini > Sent: Monday, May 22, 2017 5:17 PM > To: Daniel P. Berrange > Cc: Gonglei (Arei); qemu-devel@nongnu.org; k...@vger.kernel.org > Subject: Re: [Qemu-devel] [RFC] memory consumption of Q

Re: [Qemu-devel] [PATCH v2 1/5] sockets: ensure we can bind to both ipv4 & ipv6 separately

2017-05-22 Thread Eric Blake
On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: > When binding to an IPv6 socket we currently force the > IPV6_V6ONLY flag to off. This means that the IPv6 socket > will accept both IPv4 & IPv6 sockets when QEMU is launched > with something like > > -vnc :::1 > > While this is good for that c

Re: [Qemu-devel] [RFC] memory consumption of Qemu is twice as much as the previous version in KVM

2017-05-22 Thread Paolo Bonzini
On 22/05/2017 17:11, Gonglei (Arei) wrote: >> These are kernel allocations done by KVM when it gets the >> KVM_SET_USER_MEMORY_REGION ioctl; of course the two memory maps >> point to >> the same userspace mmap-ed area. > > Oh? What's the mmapd-ed area you pointed? I mean the MAP_ANON pages that

Re: [Qemu-devel] [PATCH v2 2/5] sockets: don't block IPv4 clients when listening on "::"

2017-05-22 Thread Eric Blake
On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: > When inet_parse() parses the hostname, it is forcing the > has_ipv6 && ipv6 flags if the address contains a ":". This > means that if the user had set the ipv4=on flag, to try to > restrict the listener to just ipv4, an error would not have > been

Re: [Qemu-devel] [PATCH v2 3/5] sockets: ensure we don't accept IPv4 clients when IPv4 is disabled

2017-05-22 Thread Eric Blake
On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: > Currently if you disable listening on IPv4 addresses, via the > CLI flag ipv4=off, we still mistakenly accept IPv4 clients via > the IPv6 listener socket due to IPV6_V6ONLY flag being unset. > > We must ensure IPV6_V6ONLY is always set if ipv4=of

Re: [Qemu-devel] [PATCH v2 4/5] io: preserve ipv4/ipv6 flags when resolving InetSocketAddress

2017-05-22 Thread Eric Blake
On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: > The original InetSocketAddress struct may have has_ipv4 and > has_ipv6 fields set, which will control both the ai_family > used during DNS resolution, and later use of the V6ONLY > flag. > > Currently the standalone DNS resolver code drops the >

Re: [Qemu-devel] [PATCH v2 1/5] sockets: ensure we can bind to both ipv4 & ipv6 separately

2017-05-22 Thread Daniel P. Berrange
On Mon, May 22, 2017 at 10:26:09AM -0500, Eric Blake wrote: > On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: > > When binding to an IPv6 socket we currently force the > > IPV6_V6ONLY flag to off. This means that the IPv6 socket > > will accept both IPv4 & IPv6 sockets when QEMU is launched > > w

Re: [Qemu-devel] [PATCH v2 2/5] sockets: don't block IPv4 clients when listening on "::"

2017-05-22 Thread Daniel P. Berrange
On Mon, May 22, 2017 at 10:30:55AM -0500, Eric Blake wrote: > On 05/19/2017 01:03 PM, Daniel P. Berrange wrote: > > When inet_parse() parses the hostname, it is forcing the > > has_ipv6 && ipv6 flags if the address contains a ":". This > > means that if the user had set the ipv4=on flag, to try to

[Qemu-devel] [PATCH v2] tests/libqtest: Print error instead of aborting when env variable is missing

2017-05-22 Thread Thomas Huth
When you currently try to run a test directly from the command line without setting the QTEST_QEMU_BINARY environment variable first, you are presented with an unhelpful assertion message like this: ERROR:tests/libqtest.c:163:qtest_init_without_qmp_handshake: assertion failed: (qemu_binary != NU

Re: [Qemu-devel] bitmap

2017-05-22 Thread Stefan Hajnoczi
On Mon, May 22, 2017 at 06:00:12PM +0430, ali saeedi wrote: > does this code 'atomic_rcu_read(&migration_bitmap_rcu)->bmap' return bitmap > of dirty blocks or bitmap of pages? This code changed recently. Please refer to qemu.git/master when asking questions on qemu-devel. I think you're asking a

  1   2   3   >