Re: [Qemu-devel] [PATCH v8 13/13] MAINTAINERS: Add vfio-ccw maintainer

2017-05-18 Thread Cornelia Huck
On Wed, 17 May 2017 02:48:13 +0200 Dong Jia Shi wrote: > Add Cornelia Huck as the vfio-ccw maintainer. > > Acked-by: Alex Williamson > Signed-off-by: Dong Jia Shi > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index efdec47319.

Re: [Qemu-devel] [PATCH 0/5] Remove old MigrationParams

2017-05-18 Thread Juan Quintela
"Dr. David Alan Gilbert" wrote: > * Juan Quintela (quint...@redhat.com) wrote: >> Hi >> >> Changes from v4: >> - make suggested logic change by eric >> - remove extra space in error message >> - allow migrate_set_capability block off when block migration is complied off >> (eric request) > > Ha

Re: [Qemu-devel] [PATCH v8 00/13] basic channel IO passthrough infrastructure based on vfio

2017-05-18 Thread Cornelia Huck
On Wed, 17 May 2017 02:48:00 +0200 Dong Jia Shi wrote: > The patch series introduce a basic channel I/O passthrough > infrastructure based on vfio. > - Focus on supporting dasd-eckd(cu_type/dev_type = 0x3990/0x3390) as > the target device. > - Support new qemu parameters in the style of: >

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Aurelien Jarno
On 2017-05-18 13:39, Thomas Huth wrote: > TEST BLOCK was likely once used to execute basic memory > tests, but nowadays it's just a (slow) way to clear a page. > > Signed-off-by: Thomas Huth > --- > v2: > - Use DEF_HELPER_FLAGS_2 instead for DEF_HELPER_2 for returning CC value > - Convert real

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Aurelien Jarno
On 2017-05-18 14:59, Thomas Huth wrote: > On 18.05.2017 14:23, David Hildenbrand wrote: > > > >> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c > >> index f6e5bce..de0ecd4 100644 > >> --- a/target/s390x/mem_helper.c > >> +++ b/target/s390x/mem_helper.c > >> @@ -20,6 +20,7 @@ >

Re: [Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine conversion, remove aio_poll

2017-05-18 Thread Richard W.M. Jones
On Mon, May 15, 2017 at 12:00:52PM +0200, Paolo Bonzini wrote: > Compared to v2, this silences checkpatch and correctly destroy the mutex on > exiting from curl_open with an error. FWIW I hit the curl bug again and tested the current patch series, and it also fixes the bug (as expected). Rich. -

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-18 Thread Gonglei (Arei)
> > On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: > >> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > >> Sent: Wednesday, May 17, 2017 6:18 AM > >> > >> > >> On 05/16/2017 04:52 AM, Gonglei (Arei) wrote: > On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > >> From: Halil Pasic [mail

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Thomas Huth
On 18.05.2017 14:00, Paolo Bonzini wrote: > > > On 12/05/2017 14:21, Gerd Hoffmann wrote: >> From: Thomas Huth >> >> When starting QEMU with the legacy USB serial device like this: >> >> qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio >> >> it currently aborts since the vendorid prop

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

2017-05-18 Thread Juan Quintela
Peter Xu wrote: > On Wed, May 17, 2017 at 05:47:50PM +0200, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> include/migration/migration.h | 1 + >> include/migration/qemu-file.h | 4 >> migration/channel.c | 1 + >> migration/colo.c | 1 + >> migrat

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Thomas Huth
On 18.05.2017 15:20, Aurelien Jarno wrote: > On 2017-05-18 14:59, Thomas Huth wrote: >> On 18.05.2017 14:23, David Hildenbrand wrote: >>> diff --git a/target/s390x/mem_helper.c b/target/s390x/mem_helper.c index f6e5bce..de0ecd4 100644 --- a/target/s390x/mem_helper.c +++ b/target

Re: [Qemu-devel] [PATCH v4 4/4] fsdev: QMP interface for throttling

2017-05-18 Thread Pradeep Jagadeesh
On 5/17/2017 7:09 PM, Eric Blake wrote: On 05/17/2017 11:29 AM, Greg Kurz wrote: First point: is fsdev a Linux-only feature, or can it be compiled on BSD? If it is Linux-only, then compiling a stub for Windows will still leave BSD broken, and your #ifdef is wrong. Fixing compilation on mingw

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Paolo Bonzini
On 18/05/2017 15:22, Thomas Huth wrote: > On 18.05.2017 14:00, Paolo Bonzini wrote: >> >> >> On 12/05/2017 14:21, Gerd Hoffmann wrote: >>> From: Thomas Huth >>> >>> When starting QEMU with the legacy USB serial device like this: >>> >>> qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Thomas Huth
On 18.05.2017 15:20, Aurelien Jarno wrote: > On 2017-05-18 13:39, Thomas Huth wrote: >> TEST BLOCK was likely once used to execute basic memory >> tests, but nowadays it's just a (slow) way to clear a page. >> >> Signed-off-by: Thomas Huth >> --- >> v2: >> - Use DEF_HELPER_FLAGS_2 instead for DE

Re: [Qemu-devel] [PATCH v3 0/5] mc146818rtc: fix Windows VM clock faster

2017-05-18 Thread Xiao Guangrong
On 05/18/2017 03:52 PM, Paolo Bonzini wrote: Looks great. Thanks for following up quickly on the reviews. Paolo, if it is okay to you, could you please consider to merge this patchset? ;) Yes, I've already queued it, but I don't have many patches so I am delaying the pull request a bit (

Re: [Qemu-devel] [PATCH v3 0/5] mc146818rtc: fix Windows VM clock faster

2017-05-18 Thread Paolo Bonzini
On 18/05/2017 15:38, Xiao Guangrong wrote: >>> >> >> Yes, I've already queued it, but I don't have many patches so I am >> delaying the pull request a bit (until at least I have time to test >> vhost-user-scsi...). >> > > Very glad to know it. I should check your git tree before raise this > kin

Re: [Qemu-devel] [RFC PATCH V2 0/2] Qemu: Add Xen vIOMMU interrupt remapping function.

2017-05-18 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [RFC PATCH V2 0/2] Qemu: Add Xen vIOMMU interrupt remapping function. Type: series Message-id: 1495085580-10631-1-git-send-email-tianyu@intel.com === TEST SCRIPT BEGIN ===

[Qemu-devel] [PATCH] spapr: ensure core_slot isn't NULL in spapr_core_unplug()

2017-05-18 Thread Greg Kurz
If we go that far on the path of hot-removing a core and we find out that the core-id is invalid, then we have a serious bug. Let's make it explicit with an assert() instead of dereferencing a NULL pointer. This fixes Coverity issue CID 1375404. Signed-off-by: Greg Kurz --- hw/ppc/spapr.c |

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Thomas Huth
On 18.05.2017 15:35, Paolo Bonzini wrote: > > > On 18/05/2017 15:22, Thomas Huth wrote: >> On 18.05.2017 14:00, Paolo Bonzini wrote: >>> >>> >>> On 12/05/2017 14:21, Gerd Hoffmann wrote: From: Thomas Huth When starting QEMU with the legacy USB serial device like this: q

Re: [Qemu-devel] [PATCH V5 2/9] migration: pass ptr to MigrationIncomingState into migration ufd_version_check & postcopy_ram_supported_by_host

2017-05-18 Thread Eric Blake
On 05/12/2017 08:31 AM, Alexey Perevalov wrote: Long subject line. Try to keep things in the subject around 60 characters or less, in part so that 'git shortlog --oneline -30' still fits in an 80-column screen. Maybe: migration: Refactor use of MigrationIncomingState pointer > That tiny refacto

Re: [Qemu-devel] [PATCH 03/10] s390x/css: add vmstate entities for css

2017-05-18 Thread Halil Pasic
On 05/15/2017 08:01 PM, Dr. David Alan Gilbert wrote: > * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: >> >> >> On 05/08/2017 06:45 PM, Dr. David Alan Gilbert wrote: >>> * Halil Pasic (pa...@linux.vnet.ibm.com) wrote: As a preparation for switching to a vmstate based migration let us i

Re: [Qemu-devel] [PATCH 2/5] 9pfs: local: resolve special directories in paths

2017-05-18 Thread Eric Blake
On 05/18/2017 03:41 AM, Greg Kurz wrote: > [...] +} else if (!strcmp(name, "..")) { +if (!strcmp(dir_path->data, ".")) { +/* ".." relative to the root is "." */ +v9fs_path_sprintf(target, "."); +} else { +

[Qemu-devel] [PATCH v3] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Thomas Huth
TEST BLOCK was likely once used to execute basic memory tests, but nowadays it is just a (slow) way to clear a page. Signed-off-by: Thomas Huth --- v3: - Use TCG_CALL_NO_RWG instead of TCG_CALL_NO_WG - Use potential_page_fault() since the helper can generate an exception v2: - Use DEF_HELPE

Re: [Qemu-devel] [PATCH 3/5] 9pfs: local: simplify file opening

2017-05-18 Thread Eric Blake
On 05/09/2017 04:23 AM, Greg Kurz wrote: > On Fri, 5 May 2017 12:01:55 -0500 > Eric Blake wrote: > >> On 05/05/2017 09:37 AM, Greg Kurz wrote: >>> All paths in the virtfs directory now start with "./" (except the virtfs >>> root itself which is exactly "."). >>> >>> We hence don't need to skip le

Re: [Qemu-devel] [PATCH 1/4] split the tcg accelerator from accel.c file

2017-05-18 Thread Eric Blake
On 05/18/2017 02:14 PM, Yang Zhong wrote: > there are two accelerators in qemu, kvm and tcg. kvm > accelerator is defined in kvm-all.c, but tcg accelerator > is defined in accel.c file. we split tcg accelerator from > accel.c file and create one new accel directory,which will space after comma in

Re: [Qemu-devel] [PATCH 1/2] exec: Create include for target_page_size()

2017-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > That is the only function that we need from exec.c, and having to > include the whole sysemu.h for this. > > Signed-off-by: Juan Quintela > --- > exec.c | 1 + > include/exec/target_page.h | 20 > include/sy

Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC

2017-05-18 Thread Eric Blake
On 05/18/2017 04:54 AM, Niels de Vos wrote: > Add missing support for "preallocation=falloc" to the Gluster block > driver. This change bases its logic on that of block/file-posix.c and > removed the gluster_supports_zerofill() and qemu_gluster_zerofill() > functiond in favour of #ifdef checks in a

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-18 Thread Daniel Henrique Barboza
On 05/18/2017 01:30 AM, David Gibson wrote: On Wed, May 17, 2017 at 05:31:44PM -0300, Daniel Henrique Barboza wrote: On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: On 05/16/2017 01:25 AM, David Gibson wrote: On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote:

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

2017-05-18 Thread Maxime Coquelin
Hi Michael, On 05/18/2017 09:35 AM, Maxime Coquelin wrote: On 05/17/2017 06:41 PM, Michael S. Tsirkin wrote: On Fri, May 12, 2017 at 01:21:18PM +0200, Maxime Coquelin wrote: On 05/11/2017 07:33 PM, Michael S. Tsirkin wrote: On Thu, May 11, 2017 at 02:32:43PM +0200, Maxime Coquelin wrote:

Re: [Qemu-devel] [PATCH 2/5] migration: Create block capability

2017-05-18 Thread Eric Blake
On 05/18/2017 06:18 AM, Juan Quintela wrote: > Create one capability for block migration and one parameter for > incremental block migration. > > Signed-off-by: Juan Quintela > > --- > Reviewed-by: Eric Blake -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266

Re: [Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable

2017-05-18 Thread Eric Blake
On 05/18/2017 06:18 AM, Juan Quintela wrote: > From: "Dr. David Alan Gilbert" > > Many users now prefer to use drive_mirror over NBD as an > alternative to the older migrate -b option; drive_mirror is > more complex to setup but gives you more options (e.g. only > migrating some of the disks if s

Re: [Qemu-devel] [PATCH] qcow2: add allocated-size to image specific info

2017-05-18 Thread Kevin Wolf
Am 18.05.2017 um 14:22 hat Denis V. Lunev geschrieben: > On 05/18/2017 03:10 PM, Kevin Wolf wrote: > > Am 18.05.2017 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: > >> 18.05.2017 13:25, Kevin Wolf wrote: > >>> Am 18.05.2017 um 12:09 hat Vladimir Sementsov-Ogievskiy geschrieben: > Show

Re: [Qemu-devel] [PATCH] trivial: Remove unneeded ifndef in memory.h

2017-05-18 Thread Laurent Vivier
On 18/05/2017 12:36, Juan Quintela wrote: > All the file is surounded already by #ifndef CONFIG_USER_ONLY. > > Signed-off-by: Juan Quintela > --- > include/exec/memory.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 99e0f54..6b5b

Re: [Qemu-devel] [PATCH] spapr: ensure core_slot isn't NULL in spapr_core_unplug()

2017-05-18 Thread Igor Mammedov
On Thu, 18 May 2017 15:58:31 +0200 Greg Kurz wrote: > If we go that far on the path of hot-removing a core and we find out that > the core-id is invalid, then we have a serious bug. > > Let's make it explicit with an assert() instead of dereferencing a NULL > pointer. > > This fixes Coverity is

Re: [Qemu-devel] [Qemu-trivial] [PATCH] altera_timer: fix incorrect memset

2017-05-18 Thread Laurent Vivier
On 18/05/2017 12:33, Paolo Bonzini wrote: > Use sizeof instead of ARRAY_SIZE, fixing -Wmemset-elt-size with recent > GCC versions. > > Signed-off-by: Paolo Bonzini > --- > hw/timer/altera_timer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/timer/altera_timer.c b/

Re: [Qemu-devel] [PATCH 2/2] migration: Make savevm.c target independent

2017-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > It only needed TARGET_PAGE_SIZE/BITS/BITS_MIN values, so just export > them from exec.h > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > --- > Makefile.target| 2 +- > exec.c | 9 + >

Re: [Qemu-devel] [PATCH] qcow2: add allocated-size to image specific info

2017-05-18 Thread Denis V. Lunev
On 05/18/2017 05:54 PM, Kevin Wolf wrote: > Am 18.05.2017 um 14:22 hat Denis V. Lunev geschrieben: >> On 05/18/2017 03:10 PM, Kevin Wolf wrote: >>> Am 18.05.2017 um 13:04 hat Vladimir Sementsov-Ogievskiy geschrieben: 18.05.2017 13:25, Kevin Wolf wrote: > Am 18.05.2017 um 12:09 hat Vladimir

Re: [Qemu-devel] [PATCH 15/17] Use uint property getter/setter where appropriate

2017-05-18 Thread Markus Armbruster
Marc-André Lureau writes: > All those property usages are associated with unsigned integers, so use > appropriate getter/setter. "Usages"? I think this is a question of whether the property value is signed or unsigned. I guess "those properties are" would work. How did you find the ones that

Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC

2017-05-18 Thread Niels de Vos
On Thu, May 18, 2017 at 09:30:53AM -0500, Eric Blake wrote: > On 05/18/2017 04:54 AM, Niels de Vos wrote: > > Add missing support for "preallocation=falloc" to the Gluster block > > driver. This change bases its logic on that of block/file-posix.c and > > removed the gluster_supports_zerofill() and

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

2017-05-18 Thread Michael S. Tsirkin
On Thu, May 18, 2017 at 04:45:23PM +0200, Maxime Coquelin wrote: > Hi Michael, > > On 05/18/2017 09:35 AM, Maxime Coquelin wrote: > > > > > > On 05/17/2017 06:41 PM, Michael S. Tsirkin wrote: > > > On Fri, May 12, 2017 at 01:21:18PM +0200, Maxime Coquelin wrote: > > > > > > > > On 05/11/2017 07

Re: [Qemu-devel] [PATCH 16/17] RFC: qdict: add uint

2017-05-18 Thread Markus Armbruster
Marc-André Lureau writes: > Similar to int support, add uint support. > > Note this is RFC because this is currently unused in qemu, I haven't > found a good user for it yet (kaslr qemu-ga code did use it though). > > Signed-off-by: Marc-André Lureau Do we think future use is reasonably likely?

[Qemu-devel] [PATCH v2 1/2] exec: Create include for target_page_size()

2017-05-18 Thread Juan Quintela
That is the only function that we need from exec.c, and having to include the whole sysemu.h for this. Signed-off-by: Juan Quintela --- /me leans to be less sloppy with copyright notices thanks Dave --- exec.c | 1 + include/exec/target_page.h | 19 +++ inc

[Qemu-devel] [PATCH v2 0/2] Make migration/savevm.c target independent

2017-05-18 Thread Juan Quintela
Hi Changes for v2 - Make copyright notice correct (dave) Please, review. [v1] Only reason that ram.c is compiled by target is because it use TARGET_PAGE_BITS. As we already have a function to export TARGET_PAGE_SIZE, do the same. After this, we can make it target independent. Juan Quintela (2

Re: [Qemu-devel] KVM call for 2017-05-23

2017-05-18 Thread Juan Quintela
Juan Quintela wrote: > Hi Gentle remainder that call is next week Thanks, Juan. > > Please, send any topic that you are interested in covering. > > At the end of Monday I will send an email with the agenda or the > cancellation of the call, so hurry up. > > After discussions on the QEMU Summit,

[Qemu-devel] [PATCH v2 2/2] migration: Make savevm.c target independent

2017-05-18 Thread Juan Quintela
It only needed TARGET_PAGE_SIZE/BITS/BITS_MIN values, so just export them from exec.h Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert --- Makefile.target| 2 +- exec.c | 9 + include/exec/target_page.h | 2 ++ mi

Re: [Qemu-devel] [PATCH v3] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Richard Henderson
On 05/18/2017 07:19 AM, Thomas Huth wrote: TEST BLOCK was likely once used to execute basic memory tests, but nowadays it is just a (slow) way to clear a page. Signed-off-by: Thomas Huth --- v3: - Use TCG_CALL_NO_RWG instead of TCG_CALL_NO_WG - Use potential_page_fault() since the helper

Re: [Qemu-devel] [PATCH 00/17] qobject/qapi: add uint type

2017-05-18 Thread Markus Armbruster
Marc-André Lureau writes: > Hi, > > In previously sent series "[PATCH 00/21] WIP: dump: add kaslr support > (for after 2.9)", I proposed changes to accept uint64 values from > json, by adding a QUint type. During review, it was suggested to > introduce a QNum type to hold various number represent

Re: [Qemu-devel] [PATCH v2] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Richard Henderson
On 05/18/2017 06:20 AM, Aurelien Jarno wrote: +DEF_HELPER_FLAGS_2(testblock, TCG_CALL_NO_WG, i32, env, i64) As the helper does not read any values from the global, you can even use TCG_CALL_NO_RWG. By throwing an exception, we imply a read of all values along the exception path. r~

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

2017-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 + > include/migration/qemu-file.h | 4 > migration/channel.c | 1 + > migration/colo.c | 1 + > migration/migration.c | 1 + > migration/

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

2017-05-18 Thread Daniel P. Berrange
On Thu, May 18, 2017 at 04:44:08PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > Signed-off-by: Juan Quintela > > --- > > include/migration/migration.h | 1 + > > include/migration/qemu-file.h | 4 > > migration/channel.c | 1 + > > migr

Re: [Qemu-devel] [PATCH 3/5] 9pfs: local: simplify file opening

2017-05-18 Thread Greg Kurz
On Thu, 18 May 2017 09:23:07 -0500 Eric Blake wrote: > On 05/09/2017 04:23 AM, Greg Kurz wrote: > > On Fri, 5 May 2017 12:01:55 -0500 > > Eric Blake wrote: > > > >> On 05/05/2017 09:37 AM, Greg Kurz wrote: > >>> All paths in the virtfs directory now start with "./" (except the virtfs > >>>

[Qemu-devel] qemu-system-sh4 -M r2d serial is broken.

2017-05-18 Thread Rob Landley
Serial input hangs after the first character in the 4.11 kernel: http://www.spinics.net/lists/linux-sh/msg51183.html Because they enabled support for a buffer size thing QEMU doesn't emulate right: http://www.spinics.net/lists/linux-sh/msg51189.html Rob

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

2017-05-18 Thread Juan Quintela
"Daniel P. Berrange" wrote: > On Thu, May 18, 2017 at 04:44:08PM +0100, Dr. David Alan Gilbert wrote: >> OK, similar copyright - but slightly different problem. >> These two lines come from include/migration/qemu-file.h; >> they were both added by Daniel in a9cfeb33bb23a81. >> The qemu-file.h hea

[Qemu-devel] [PATCH 1/1] target/arm: clear PMUVER field of AA64DFR0 when vPMU=off

2017-05-18 Thread Wei Huang
The PMUv3 driver of linux kernel (in arch/arm64/kernel/perf_event.c) relies on the PMUVER field of id_aa64dfr0_el1 to decide if PMU support is present or not. This patch clears the PMUVER field under TCG mode when vPMU=off. Without it, PMUv3 will init insider guest VMs even with vPMU=off. This patc

Re: [Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-18 Thread Gerd Hoffmann
Hi, > >> Feel free to send an additional cleanup patch ... otherwise, I'd say let > >> it bitrot for another year and we then remove it completely together > >> with all the other "-usbdevice" functions... > > > > Well, Coverity reports it so I'd rather keep it clean... It will be clean once r

[Qemu-devel] [PATCH v5 0/9] Migration mini-cleanup

2017-05-18 Thread Juan Quintela
Hi Changes from v3 Only copyright notices: included the diff to make it easier to see: - channel.{c,h} -> goes to Daniel Berrange - qemu-file-channel.h -> same one than qemu-file-channel.c I hope this is ok now. Thanks, Juan. diff --git a/migration/channel.c b/migration/channel.c index fed85

[Qemu-devel] [PATCH 8/9] migration: Remove vmstate.h from migration.h

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Philippe Mathieu-Daudé --- Minor rearrangements due to rebase --- include/migration/migration.h | 1 - migration/block.c | 1 + migration/colo-comm.c | 1 + migration/migration.c | 1 + m

[Qemu-devel] [PATCH 4/9] migration: Remove migration.h from colo.h

2017-05-18 Thread Juan Quintela
migration.h is not included in any includes now. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/colo.h | 1 - migration/colo-comm.c| 3 ++- migration/colo.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/migration/colo.h b/inc

[Qemu-devel] [PATCH 5/9] migration: Move qjson.h to migration/

2017-05-18 Thread Juan Quintela
It is only used for migration code. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- migration/qjson.c| 2 +- {include/migration => migration}/qjson.h | 0 migration/vmstate.c | 2 +- 3 files changed, 2 insertions(+), 2 deletions(

[Qemu-devel] [PATCH 1/9] migration: Create migration/xbzrle.h

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 4 migration/ram.c | 1 + migration/xbzrle.c| 2 +- migration/xbzrle.h| 21 + tests/test-xbzrle.c | 2 +- 5 files changed, 24 insert

[Qemu-devel] [PATCH 6/9] migration: Split vmstate-types.c from vmstate.c

2017-05-18 Thread Juan Quintela
Now one just has the interperter, and the other has the basic types. Once there, add copyright boilerplate. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu -- Use GPL v2 or later. Detected by David. --- migration/Makefile.objs | 2 +- migration/vmstate-types.c | 661 ++

[Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

2017-05-18 Thread Juan Quintela
Create an include for its exported functions. Signed-off-by: Juan Quintela --- Add proper header --- include/migration/migration.h | 7 - migration/Makefile.objs | 2 +- migration/channel.c | 69 +++ migration/channel.h | 2

[Qemu-devel] [PATCH 9/9] migration: migration.h was not needed

2017-05-18 Thread Juan Quintela
This files don't use any function from migration.h, so drop it. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Peter Xu --- block/qed.c | 1 - hw/i386/pc_q35.c| 1 - hw/virtio/vhost-user.c | 1 - hw/virtio/vhost-vsock.c | 1 - hw/virtio/virti

[Qemu-devel] [PATCH 7/9] migration: Remove qemu-file.h from vmstate.h

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- minor rearangements due to the rebase --- include/hw/hw.h | 1 + include/migration/vmstate.h | 3 --- migration/block.c | 1 + migration/colo.c| 1 + migration/postcopy-ram.c| 1 + migrati

[Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 + include/migration/qemu-file.h | 4 migration/channel.c | 1 + migration/colo.c | 1 + migration/migration.c | 1 + migration/qemu-file-channel.c | 1 + migration/qemu-file-channel.h | 3

[Qemu-devel] EL2\EL3 support for Aarch64

2017-05-18 Thread Sergey Smolov
Hello, List! Could you tell me, what is the current state for EL2\EL3 (Aarch64)? Whether they are fully supported, or not? Am I need to use any command line options to enable them for Aarch64 assembler programs simulation? Thanks in advance! -- Sincerely yours, Sergey Smolov Institute for Sys

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-18 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-05-18 09:33:58) > > > On 05/18/2017 01:30 AM, David Gibson wrote: > > On Wed, May 17, 2017 at 05:31:44PM -0300, Daniel Henrique Barboza wrote: > >> > >> On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: > >>> > >>> On 05/16/2017 01:25 AM, David Gibson wr

Re: [Qemu-devel] [PATCH 1/4] split the tcg accelerator from accel.c file

2017-05-18 Thread Eric Blake
On 05/18/2017 02:14 PM, Yang Zhong wrote: Your system clock is way off. From the headers: > Received: from yangzhon-virtual.bj.intel.com ([10.238.145.52]) > by fmsmga002.fm.intel.com with ESMTP; 18 May 2017 04:17:51 -0700 > Date: Fri, 19 May 2017 03:14:52 +0800 Your computer claimed to ma

Re: [Qemu-devel] [PATCH v2 1/2] exec: Create include for target_page_size()

2017-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > That is the only function that we need from exec.c, and having to > include the whole sysemu.h for this. > > Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert > > --- > > /me leans to be less sloppy with copyright notices > thanks

Re: [Qemu-devel] Add Markus Armbrusters code for Broadcom Perhiperals for ARM.

2017-05-18 Thread John Bradley via Qemu-devel
HI, No worries about Yesterday. I decided to take a different approach. I'll put that stuff in that relates to GDummyPanel flypie/GDummyPanel first I sent the patch to the list a copy is here. 0001-PATCH-V-2-GDummyPanel-Fix-formatingissues.patch | | | | || | | | ||

Re: [Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

2017-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Create an include for its exported functions. > > Signed-off-by: Juan Quintela > > --- > Add proper header > --- > include/migration/migration.h | 7 - > migration/Makefile.objs | 2 +- > migration/channel.c | 69 > ++

Re: [Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

2017-05-18 Thread Daniel P. Berrange
On Thu, May 18, 2017 at 05:40:54PM +0100, Dr. David Alan Gilbert wrote: > * Juan Quintela (quint...@redhat.com) wrote: > > Create an include for its exported functions. > > > > Signed-off-by: Juan Quintela > > > > --- > > Add proper header > > --- > > include/migration/migration.h | 7 - >

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-18 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-05-17 15:31:44) > > > On 05/16/2017 09:04 AM, Daniel Henrique Barboza wrote: > > > > > > On 05/16/2017 01:25 AM, David Gibson wrote: > >> On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote: > >>> From: Jianjun Duan > >>> > >>> In racing

Re: [Qemu-devel] [PATCH 3/9] migration: Export qemu-file-channel.c functions in its own file

2017-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > include/migration/migration.h | 1 + > include/migration/qemu-file.h | 4 > migration/channel.c | 1 + > migration/colo.c | 1 + > migration/migration.c | 1 + > migration/

Re: [Qemu-devel] [PATCH 2/9] migration: Split migration/channel.c for channel operations

2017-05-18 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Create an include for its exported functions. > > Signed-off-by: Juan Quintela Other than needing to fix the GPLv2 to be GPLv2 or later, Reviewed-by: Dr. David Alan Gilbert > --- > Add proper header > --- > include/migration/migration.h | 7 -

[Qemu-devel] [PULL 03/18] hmp: Use visitor api for hmp_migrate_set_parameter()

2017-05-18 Thread Juan Quintela
We only use it for int64 at this point, I am not able to find a way to parse an int with MiB units. Signed-off-by: Juan Quintela Reviewed-by: Markus Armbruster --- hmp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hmp.c b/hmp.c index 3dceaf8..83e45c8 100644 --

[Qemu-devel] [PULL 00/18] Migration pull request

2017-05-18 Thread Juan Quintela
commit 56821559f0ba682fe6b367815572e6f974d329ab: Merge remote-tracking branch 'dgilbert/tags/pull-hmp-20170517' into staging (2017-05-18 13:36:15 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170518 for you to fetch cha

[Qemu-devel] [PULL 02/18] postcopy: Require RAMBlocks that are whole pages

2017-05-18 Thread Juan Quintela
From: "Dr. David Alan Gilbert" It turns out that it's legal to create a VM with RAMBlocks that aren't a multiple of the pagesize in use; e.g. a 1025M main memory using 2M host pages. That breaks postcopy's atomic placement of pages, so disallow it. Signed-off-by: Dr. David Alan Gilbert Reviewe

[Qemu-devel] [PULL 06/18] migration: Remove old MigrationParams

2017-05-18 Thread Juan Quintela
Not used anymore after moving block migration to use capabilities. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: zhanghailiang Reviewed-by: Peter Xu --- include/migration/migration.h | 10 ++ include/migration/vmstate.h | 1 - include/qemu/typedefs.h

[Qemu-devel] [PULL 01/18] migration: Fix non-multiple of page size migration

2017-05-18 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Unfortunately it's legal to create a VM with a RAM size that's not a multiple of the underlying host page or huge page size. Recently I'd changed things to always send host sized pages, and that breaks if we have say a 1025MB guest on 2MB hugepages. Unfortunately w

[Qemu-devel] [PULL 04/18] migration: Create block capability

2017-05-18 Thread Juan Quintela
Create one capability for block migration and one parameter for incremental block migration. Signed-off-by: Juan Quintela Reviewed-by: Eric Blake --- - address all Markus comments - use Markus and Eric text descriptions - change logic another time - improve text messages --- hmp.c

[Qemu-devel] [PULL 05/18] migration: Remove use of old MigrationParams

2017-05-18 Thread Juan Quintela
We have change in the previous patch to use migration capabilities for it. Notice that we continue using the old command line flags from migrate command from the time being. Remove the set_params method as now it is empty. For savevm, one can't do a: savevm -b/-i foo but now one can do: migra

[Qemu-devel] [PULL 07/18] block migration: Allow compile time disable

2017-05-18 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Many users now prefer to use drive_mirror over NBD as an alternative to the older migrate -b option; drive_mirror is more complex to setup but gives you more options (e.g. only migrating some of the disks if some of them are shared). Allow the large chunk of block

[Qemu-devel] [PULL 09/18] migration: Split migration/channel.c for channel operations

2017-05-18 Thread Juan Quintela
Create an include for its exported functions. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- Add proper header --- include/migration/migration.h | 7 - migration/Makefile.objs | 2 +- migration/channel.c | 66 +

[Qemu-devel] [PATCH 11/11] migration: Move include/migration/block.h into migration/

2017-05-18 Thread Juan Quintela
All functions were internal, except blk_mig_init() that is exported in misc.h now. Signed-off-by: Juan Quintela --- include/migration/misc.h | 8 migration/block.c| 3 ++- {include/migration => migration}/block.h | 2 -- migration/colo.c

[Qemu-devel] [PULL 08/18] migration: Create migration/xbzrle.h

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- include/migration/migration.h | 4 migration/ram.c | 1 + migration/xbzrle.c| 2 +- migration/xbzrle.h| 21 + tests/test-xbzrle.c | 2 +- 5 files changed, 24 insert

[Qemu-devel] [PATCH 00/11] Another cleanup of includes

2017-05-18 Thread Juan Quintela
Hi This series: - make all migration methods export its functions in its own header - move block.h into migration/ - create migration/savevm.h for functions exported in savevm.c - create migration/ram.h for functions from ram.c - split qemu-file.h into it an qemu-file-types.h only the last one i

[Qemu-devel] [PATCH v4] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Thomas Huth
TEST BLOCK was likely once used to execute basic memory tests, but nowadays it's just a (slow) way to clear a page. Signed-off-by: Thomas Huth --- v4: - Switched TCG_CALL_NO_RWG back to TCG_CALL_NO_WG as indicated by Richard v3: - Use TCG_CALL_NO_RWG instead of TCG_CALL_NO_WG - Use potentia

[Qemu-devel] [PATCH 10/11] migration: Export ram.c functions in its own file

2017-05-18 Thread Juan Quintela
All functions are internal except for ram_mig_init(). Create migration/misc.h for this kind of functions. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 38 --- include/migration/misc.h | 21 + migration

[Qemu-devel] [PATCH 01/11] migration: Create savevm.h for functions exported from savevm.c

2017-05-18 Thread Juan Quintela
This removes last trace of migration functions from sysemu/sysemu.h. Signed-off-by: Juan Quintela --- include/sysemu/sysemu.h | 47 --- migration/colo.c | 1 + migration/migration.c| 1 + migration/postcopy-ram.c | 1 + migration/savevm

[Qemu-devel] [PATCH 08/11] migration: Export rdma.c functions in its own file

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 4 migration/migration.c | 1 + migration/rdma.c | 1 + migration/rdma.h | 25 + 4 files changed, 27 insertions(+), 4 deletions(-) create mode 100644 migration/rdma.

[Qemu-devel] [PATCH 02/11] migration: Remove unneeded includes of migration/vmstate.h

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Philippe Mathieu-Daudé --- hw/core/qdev.c | 1 - include/hw/acpi/memory_hotplug.h | 1 - include/hw/acpi/pcihp.h | 1 - include/hw/pci/shpc.h| 1 - include/net/net.h| 1 - target/alpha/cpu.c

Re: [Qemu-devel] [PATCH v4] target/s390x: Add support for the TEST BLOCK instruction

2017-05-18 Thread Richard Henderson
On 05/18/2017 10:26 AM, Thomas Huth wrote: TEST BLOCK was likely once used to execute basic memory tests, but nowadays it's just a (slow) way to clear a page. Signed-off-by: Thomas Huth --- v4: - Switched TCG_CALL_NO_RWG back to TCG_CALL_NO_WG as indicated by Richard v3: - Use TCG_CALL_

[Qemu-devel] [PATCH 03/11] migration: Split qemu-file.h

2017-05-18 Thread Juan Quintela
Split the file into public and internal interfaces. I have to rename the external one because we can't have two include files with the same name in the same directory. Build system gets confused. The only exported functions are the ones that handle basic types. Signed-off-by: Juan Quintela ---

[Qemu-devel] [PATCH 04/11] migration: Export exec.c functions in its own file

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 4 migration/exec.c | 1 + migration/exec.h | 26 ++ migration/migration.c | 1 + 4 files changed, 28 insertions(+), 4 deletions(-) create mode 100644 migration/exec

[Qemu-devel] [PATCH 05/11] migration: Export fd.c functions in its own file

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 4 migration/fd.c| 1 + migration/fd.h| 23 +++ migration/migration.c | 1 + 4 files changed, 25 insertions(+), 4 deletions(-) create mode 100644 migration/fd.h d

[Qemu-devel] [PATCH 06/11] migration: Export socket.c functions in its own file

2017-05-18 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 8 migration/migration.c | 1 + migration/socket.c| 1 + migration/socket.h| 28 4 files changed, 30 insertions(+), 8 deletions(-) create mode 100644 migratio

[Qemu-devel] [PATCH 07/11] migration: Export tls.c functions in its own file

2017-05-18 Thread Juan Quintela
Just for the functions exported from tls.c. Notice that we can't remove the migration/migration.h include from tls.c because it access directly MigrationState for the tls params. Signed-off-by: Juan Quintela --- include/migration/migration.h | 10 -- migration/channel.c | 1 +

[Qemu-devel] [PATCH 09/11] migration: Create include for migration snapshots

2017-05-18 Thread Juan Quintela
Start removing migration code from sysemu/sysemu.h. Signed-off-by: Juan Quintela --- hmp.c| 5 +++-- include/block/block_int.h| 4 ++-- include/migration/snapshot.h | 20 include/sysemu/sysemu.h | 3 --- migration/savevm.c | 5 +

Re: [Qemu-devel] [PATCH 1/1] s390x/css: catch section mismatch on load

2017-05-18 Thread Dr. David Alan Gilbert
* Halil Pasic (pa...@linux.vnet.ibm.com) wrote: > Prior to the virtio-ccw-2.7 machine (and commit 2a79eb1a), our virtio > devices residing under the virtual-css bus do not have qdev_path based > migration stream identifiers (because their qdev_path is NULL). The ids > are instead generated when the

Re: [Qemu-devel] [PATCH v2] gluster: add support for PREALLOC_MODE_FALLOC

2017-05-18 Thread Jeff Cody
On Thu, May 18, 2017 at 11:54:22AM +0200, Niels de Vos wrote: > Add missing support for "preallocation=falloc" to the Gluster block > driver. This change bases its logic on that of block/file-posix.c and > removed the gluster_supports_zerofill() and qemu_gluster_zerofill() > functiond in favour of

<    1   2   3   >