Re: [Qemu-devel] [RFC PATCH v1 4/6] spapr: Consolidate HPT freeing code into a routine

2017-05-17 Thread David Gibson
On Wed, May 17, 2017 at 09:19:20AM +0530, Bharata B Rao wrote: > Consolidate the code that frees HPT into a separate routine > spapr_free_hpt() as the same chunk of code is called from two places. > > Signed-off-by: Bharata B Rao Applied to ppc-for-2.10. This is a good clean up in its own right

Re: [Qemu-devel] [PULL 19/48] spapr: allocate the ICPState object from under sPAPRCPUCore

2017-05-17 Thread David Gibson
On Wed, May 17, 2017 at 07:50:42AM +0200, Cédric Le Goater wrote: > On 05/16/2017 06:10 PM, Greg Kurz wrote: > > On Tue, 16 May 2017 17:18:27 +0200 > > Cédric Le Goater wrote: > > > >> On 05/16/2017 02:55 PM, Laurent Vivier wrote: > >>> On 16/05/2017 14:50, Cédric Le Goater wrote: > On 05/

Re: [Qemu-devel] [RFC PATCH v1 1/6] migration: Fix unregister_savevm()

2017-05-17 Thread David Gibson
On Wed, May 17, 2017 at 09:19:17AM +0530, Bharata B Rao wrote: > In unregister_savevm(), free se->compat only if it was allocated earlier. > > Signed-off-by: Bharata B Rao I don't think this is necessary. If se->compat was never allocated, then it should be NULL (since se is allocated with g_ne

Re: [Qemu-devel] [RFC PATCH v1 2/6] migration: Introduce unregister_savevm_live()

2017-05-17 Thread David Gibson
On Wed, May 17, 2017 at 09:19:18AM +0530, Bharata B Rao wrote: > Introduce a new function unregister_savevm_live() to unregister the vmstate > handlers registered via register_savevm_live(). > > register_savevm() allocates SaveVMHandlers while register_savevm_live() > gets passed with SaveVMHandle

Re: [Qemu-devel] [RFC PATCH v1 6/6] spapr: Fix migration of Radix guests

2017-05-17 Thread David Gibson
On Wed, May 17, 2017 at 09:19:22AM +0530, Bharata B Rao wrote: > Fix migration of radix guests by ensuring that we issue > KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. > > Reported-by: Nageswara R Sastry > Signed-off-by: Bharata B Rao > --- > hw/ppc/spapr.c | 15 +

Re: [Qemu-devel] [PATCH v3] net/rocker: Convert to realize

2017-05-17 Thread Markus Armbruster
Mao Zhongyi writes: > Hi, Markus > > On 05/16/2017 11:29 PM, Markus Armbruster wrote: >> Mao Zhongyi writes: >> >>> The rocker device still implements the old PCIDeviceClass .init() >>> instead of the new .realize(). All devices need to be converted to >>> .realize(). >> >> Thanks for chipping i

Re: [Qemu-devel] [RFC PATCH v1 5/6] spapr: Unregister HPT savevm handlers for radix guests

2017-05-17 Thread David Gibson
On Wed, May 17, 2017 at 09:19:21AM +0530, Bharata B Rao wrote: > HPT gets created by default and later when the guest turns out to be > a radix guest, the HPT is destroyed when guest does H_REGISTER_PROC_TBL > hcall. I don't think that's entirely accurate. At least in some KVM configurations, we

Re: [Qemu-devel] [RFC PATCH v1 6/6] spapr: Fix migration of Radix guests

2017-05-17 Thread Bharata B Rao
On Wed, May 17, 2017 at 05:00:49PM +1000, David Gibson wrote: > On Wed, May 17, 2017 at 09:19:22AM +0530, Bharata B Rao wrote: > > Fix migration of radix guests by ensuring that we issue > > KVM_PPC_CONFIGURE_V3_MMU for radix case post migration. > > > > Reported-by: Nageswara R Sastry > > Signed

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-17 Thread Maxime Coquelin
On 05/17/2017 07:57 AM, Peter Xu wrote: On Wed, May 17, 2017 at 12:23:42PM +0800, Peter Xu wrote: On Tue, May 16, 2017 at 06:51:03PM +0200, Maxime Coquelin wrote: Hi Peter, On 05/16/2017 03:24 PM, Maxime Coquelin wrote: On 05/15/2017 10:50 AM, Peter Xu wrote: The problem is that, address

Re: [Qemu-devel] [PATCH v1] target/s390x: Add support for the TEST BLOCK instruction

2017-05-17 Thread Thomas Huth
On 16.05.2017 15:42, Aurelien Jarno wrote: > On 2017-05-16 11:28, Thomas Huth wrote: >> TEST BLOCK was likely once used to execute basic memory >> tests, but nowadays it's just a (slow) way to clear a page. >> >> Signed-off-by: Thomas Huth >> --- >> target/s390x/helper.h | 1 + >> target/s3

Re: [Qemu-devel] [RFC PATCH v1 5/6] spapr: Unregister HPT savevm handlers for radix guests

2017-05-17 Thread Bharata B Rao
On Wed, May 17, 2017 at 04:59:33PM +1000, David Gibson wrote: > On Wed, May 17, 2017 at 09:19:21AM +0530, Bharata B Rao wrote: > > HPT gets created by default and later when the guest turns out to be > > a radix guest, the HPT is destroyed when guest does H_REGISTER_PROC_TBL > > hcall. > > I don't

Re: [Qemu-devel] [RFC PATCH v1 6/6] spapr: Fix migration of Radix guests

2017-05-17 Thread David Gibson
On Wed, May 17, 2017 at 12:45:39PM +0530, Bharata B Rao wrote: > On Wed, May 17, 2017 at 05:00:49PM +1000, David Gibson wrote: > > On Wed, May 17, 2017 at 09:19:22AM +0530, Bharata B Rao wrote: > > > Fix migration of radix guests by ensuring that we issue > > > KVM_PPC_CONFIGURE_V3_MMU for radix ca

Re: [Qemu-devel] [RFC PATCH v1 2/6] migration: Introduce unregister_savevm_live()

2017-05-17 Thread Bharata B Rao
On Wed, May 17, 2017 at 04:45:44PM +1000, David Gibson wrote: > On Wed, May 17, 2017 at 09:19:18AM +0530, Bharata B Rao wrote: > > Introduce a new function unregister_savevm_live() to unregister the vmstate > > handlers registered via register_savevm_live(). > > > > register_savevm() allocates Sav

Re: [Qemu-devel] [RFC PATCH v1 5/6] spapr: Unregister HPT savevm handlers for radix guests

2017-05-17 Thread David Gibson
On Wed, May 17, 2017 at 12:48:21PM +0530, Bharata B Rao wrote: > On Wed, May 17, 2017 at 04:59:33PM +1000, David Gibson wrote: > > On Wed, May 17, 2017 at 09:19:21AM +0530, Bharata B Rao wrote: > > > HPT gets created by default and later when the guest turns out to be > > > a radix guest, the HPT i

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-17 Thread Paolo Bonzini
On 17/05/2017 09:17, Maxime Coquelin wrote: > > > On 05/17/2017 07:57 AM, Peter Xu wrote: >> On Wed, May 17, 2017 at 12:23:42PM +0800, Peter Xu wrote: >>> On Tue, May 16, 2017 at 06:51:03PM +0200, Maxime Coquelin wrote: Hi Peter, On 05/16/2017 03:24 PM, Maxime Coquelin wrote: >>>

Re: [Qemu-devel] [PATCH] ivshmem-server: Detect and use if there is required -lrt linking

2017-05-17 Thread Markus Armbruster
Kamil Rytarowski writes: > ivshmem-server makes use of the POSIX shared memory object interfaces. > This library is provided on NetBSD in -lrt (POSIX Real-time Library). > Add ./configure check if there is needed -lrt linking for shm_open() > and if so use it. Introduce new configure generated va

Re: [Qemu-devel] 答复: Re: [RFC] virtio-fc: draft idea of virtual fibre channel HBA

2017-05-17 Thread Paolo Bonzini
On 17/05/2017 08:01, Hannes Reinecke wrote: > On 05/16/2017 06:22 PM, Paolo Bonzini wrote: >> On 16/05/2017 17:22, Hannes Reinecke wrote: >>> iSCSI has its 'iqn' string, which is defined to be a 256-byte string. >>> Hence the number >>> And if we're updating virtio anyway, we could as well updat

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-17 Thread Jay Zhou
On 2017/5/17 13:47, Wanpeng Li wrote: Hi Zhoujian, 2017-05-17 10:20 GMT+08:00 Zhoujian (jay) : Hi Wanpeng, On 11/05/2017 14:07, Zhoujian (jay) wrote: -* Scan sptes if dirty logging has been stopped, dropping those -* which can be collapsed into a single large-page spte. Lat

Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-17 Thread Kashyap Chamarthy
On Mon, May 15, 2017 at 02:39:40PM +0200, Kevin Wolf wrote: > This adds a small test for the image streaming error path for failing > block_job_create(), which would have found the null pointer dereference > in commit a170a91f. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/030 | 4

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-17 Thread Paolo Bonzini
> Recently, I have tested the performance before migration and after migration > failure > using spec cpu2006 https://www.spec.org/cpu2006/, which is a standard > performance > evaluation tool. > > These are the steps: > == > (1) the version of kmod is 4.4.11(with slightly modified) and the

Re: [Qemu-devel] [PATCH v3] net/rocker: Convert to realize

2017-05-17 Thread Mao Zhongyi
Hi, Markus On 05/17/2017 03:04 PM, Markus Armbruster wrote: Mao Zhongyi writes: On 05/16/2017 11:29 PM, Markus Armbruster wrote: Mao Zhongyi writes: The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .real

[Qemu-devel] QEMU master is broken (was: [PATCH 6/6] opengl: add egl-headless display)

2017-05-17 Thread Thomas Huth
Hi, I can not compile git master anymore on my RHEL 7.3 installation ... I think it is due to this patch here. I now get: CC ui/egl-headless.o /home/thuth/devel/qemu/ui/egl-headless.c: In function ‘egl_headless_init’: /home/thuth/devel/qemu/ui/egl-headless.c:142:5: error: implicit declar

[Qemu-devel] [Bug 1691379] [NEW] NetBSD evbmips64el port installation doesn't work with qemu-system-mips64el.

2017-05-17 Thread Utkarsh Anand
Public bug reported: I successfully installed the NetBSD evbmips64el port on gxemul but was unable to install it on qemu. Trying to boot it on qemu takes me to the 'db>' prompt. Here's the output and backtrace: panic: pcib_isa_intr_string: bogus isa irq 0x0 kernel: breakpoint trap Stopped in pid

Re: [Qemu-devel] [PATCH] qapi-schema: Remove obsolete note from ObjectTypeInfo

2017-05-17 Thread Markus Armbruster
Eduardo Habkost writes: > The "This command is experimental" note in ObjectTypeInfo is obsolete > since 2012. Commit 5192082097549c5b3aa7c913c6853d97a68172cb removed the > warning from the qom-list-types command documentation, but we forgot to > remove the warning from ObjectTypeInfo. > > Signed

Re: [Qemu-devel] [PULL 23/29] numa: use possible_cpus for not mapped CPUs check

2017-05-17 Thread Markus Armbruster
Eduardo Habkost writes: > From: Igor Mammedov > > and remove corresponding part in numa.c that uses > node_cpu bitmaps. > > Signed-off-by: Igor Mammedov > Reviewed-by: David Gibson > Reviewed-by: Andrew Jones > Message-Id: <1494415802-227633-16-git-send-email-imamm...@redhat.com> > Signed-off

Re: [Qemu-devel] [Bug 1691379] [NEW] NetBSD evbmips64el port installation doesn't work with qemu-system-mips64el.

2017-05-17 Thread Thomas Huth
On 17.05.2017 09:52, Utkarsh Anand wrote: > Public bug reported: > > I successfully installed the NetBSD evbmips64el port on gxemul but was > unable to install it on qemu. Trying to boot it on qemu takes me to the > 'db>' prompt. Here's the output and backtrace: > > panic: pcib_isa_intr_string: b

[Qemu-devel] [PATCH] ui: egl-headless requires dmabuf support

2017-05-17 Thread Gerd Hoffmann
Reported-by: Thomas Huth Signed-off-by: Gerd Hoffmann --- ui/Makefile.objs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/Makefile.objs b/ui/Makefile.objs index aac6ae8bef..3369451285 100644 --- a/ui/Makefile.objs +++ b/ui/Makefile.objs @@ -33,7 +33,7 @@ common-obj-y += s

[Qemu-devel] [RESEND PATCH] virtio: allow broken device to notify guest

2017-05-17 Thread Greg Kurz
According to section 2.1.2 of the virtio-1 specification: "The device SHOULD set DEVICE_NEEDS_RESET when it enters an error state that a reset is needed. If DRIVER_OK is set, after it sets DEVICE_NEEDS_RESET, the device MUST send a device configuration change notification to the driver." Commit "

Re: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode

2017-05-17 Thread Paolo Bonzini
On 16/05/2017 23:42, Kevin O'Connor wrote: > > As for adding a new SeaBIOS build option to compile out support for > A20 - that seems like a very small optimization that would risk memory > corruption and hard to diagnose crashes. SeaBIOS runs natively on > real hardware (with coreboot and as a

Re: [Qemu-devel] [PATCH] ui: egl-headless requires dmabuf support

2017-05-17 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH] ui: egl-headless requires dmabuf support Type: series Message-id: 20170517081332.25811-1-kra...@

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-17 Thread Wanpeng Li
2017-05-17 15:43 GMT+08:00 Paolo Bonzini : >> Recently, I have tested the performance before migration and after migration >> failure >> using spec cpu2006 https://www.spec.org/cpu2006/, which is a standard >> performance >> evaluation tool. >> >> These are the steps: >> == >> (1) the versio

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-17 Thread Peter Xu
On Wed, May 17, 2017 at 09:26:25AM +0200, Paolo Bonzini wrote: > > > On 17/05/2017 09:17, Maxime Coquelin wrote: > > > > > > On 05/17/2017 07:57 AM, Peter Xu wrote: > >> On Wed, May 17, 2017 at 12:23:42PM +0800, Peter Xu wrote: > >>> On Tue, May 16, 2017 at 06:51:03PM +0200, Maxime Coquelin wro

[Qemu-devel] [Bug 1181796] Re: Qemu locks up when incoming serial fills up

2017-05-17 Thread Thomas Huth
I think there have been quite a lot of fixes during the last releases of QEMU in this area ... could you please try again to see whether you can still reproduce this problem with the latest version of QEMU (currently v2.9.0)? ** Changed in: qemu Status: New => Incomplete -- You received t

Re: [Qemu-devel] [RFC v1 5/9] virtio-crypto: update header file

2017-05-17 Thread Gonglei (Arei)
> > -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Tuesday, May 16, 2017 11:43 PM > To: Gonglei (Arei) > Cc: qemu-devel@nongnu.org; m...@redhat.com; Huangweidong (C); > pa...@linux.vnet.ibm.com; Luonengjun; cornelia.h...@de.ibm.com; > Linqiangmin; xin.z...@i

Re: [Qemu-devel] [PATCH 11/17] object: use more specific property type names

2017-05-17 Thread Markus Armbruster
Marc-André Lureau writes: > Use the actual unsigned integer type name (this should't break since > property type aren't directly accessed from outside it seems). I'm not sure I understand the parenthesis. Do you mean changing the type names is safe because they're used only in a certain way? W

Re: [Qemu-devel] [RFC 0/2] pseries: Correct behaviour change for older machine types

2017-05-17 Thread Andrea Bolognani
On Wed, 2017-05-17 at 16:35 +1000, David Gibson wrote: > 152ef80 "pseries: Rewrite CAS PVR compatibility logic" incorrectly > introduced a guest-visible behaviour change into existing versioned > machine type.  Patch 2/2 corrects this change, while 1/2 is a > preliminary clean up to make that easie

Re: [Qemu-devel] [RFC 1/2] pseries: Split CAS PVR negotiation out into a separate function

2017-05-17 Thread Laurent Vivier
On 17/05/2017 08:35, David Gibson wrote: > Guests of the qemu machine type go through a feature negotiation process > known as "client architecture support" (CAS) during early boot. This does > a number of things, one of which is finding a CPU compatibility mode which > can be supported by both gu

[Qemu-devel] [PATCH v2] exec: abstract address_space_do_translate()

2017-05-17 Thread Peter Xu
This function is an abstraction helper for address_space_translate() and address_space_get_iotlb_entry(). It does the lookup of address into memory region section, then do proper IOMMU translation if necessary. With that, refactor the two existing functions a bit to use it. This fixes a potential

Re: [Qemu-devel] [PULL 23/29] numa: use possible_cpus for not mapped CPUs check

2017-05-17 Thread Igor Mammedov
On Wed, 17 May 2017 10:07:18 +0200 Markus Armbruster wrote: > Eduardo Habkost writes: > > > From: Igor Mammedov > > > > and remove corresponding part in numa.c that uses > > node_cpu bitmaps. > > > > Signed-off-by: Igor Mammedov > > Reviewed-by: David Gibson > > Reviewed-by: Andrew Jones >

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Gonglei (Arei)
> From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Wednesday, May 17, 2017 6:18 AM > > > On 05/16/2017 04:52 AM, Gonglei (Arei) wrote: > >> > >> On 05/13/2017 03:16 AM, Gonglei (Arei) wrote: > >>> > From: Halil Pasic [mailto:pa...@linux.vnet.ibm.com] > Sent: Friday, May 12, 2

Re: [Qemu-devel] [virtio-dev] [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

2017-05-17 Thread Gonglei (Arei)
> > > On Sat, Apr 22, 2017 at 02:23:50PM +0800, Gonglei wrote: > > +Dataq requests for both session and stateless modes are as follows: > > + > > +\begin{lstlisting} > > +struct virtio_crypto_op_data_req_mux { > > +struct virtio_crypto_op_header header; > > + > > +union { > > +stru

Re: [Qemu-devel] [RFC 2/2] pseries: Restore PVR negotiation logic for pre-2.9 machine types

2017-05-17 Thread Laurent Vivier
On 17/05/2017 08:35, David Gibson wrote: > "pseries" guests go through a hypervisor<->guest feature negotiation during > early boot. Part of this is finding a CPU compatibility mode which works > for both. > > In 152ef80 "pseries: Rewrite CAS PVR compatibility logic" this logic was > changed to s

Re: [Qemu-devel] [PATCH] Memory: use memory address space for cpu-memory

2017-05-17 Thread Igor Mammedov
On Tue, 16 May 2017 15:15:23 -0700 Anthony Xu wrote: > If cpu-memory address space is same as memory address space, > use memory address space for cpu-memory address space. > > any memory region change causeaddress space to rebuild PhysPageMap, > rebuilding PhysPageMap is very expensive. > > re

Re: [Qemu-devel] [Qemu devel v5 PATCH 0/5] Add support for Smartfusion2 SoC

2017-05-17 Thread sundeep subbaraya
Hi Philippe, On Wed, May 17, 2017 at 9:57 AM, Philippe Mathieu-Daudé wrote: > Hi Sundeep, > > This patchset is way cleaner! > I had a fast look and I like it, I'll try to make some time soon to review > details and test it. Thank you > > Is your work interested on U-Boot or more focused in

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Halil Pasic
On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: By the way, I'm having a hard time understing how is the requirement form >> http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-260 004 (2.4.4 Message Framing) satisfied by this code. Could you explain this

Re: [Qemu-devel] [PULL 19/48] spapr: allocate the ICPState object from under sPAPRCPUCore

2017-05-17 Thread Greg Kurz
On Wed, 17 May 2017 07:50:42 +0200 Cédric Le Goater wrote: > On 05/16/2017 06:10 PM, Greg Kurz wrote: > > On Tue, 16 May 2017 17:18:27 +0200 > > Cédric Le Goater wrote: > > > >> On 05/16/2017 02:55 PM, Laurent Vivier wrote: > >>> On 16/05/2017 14:50, Cédric Le Goater wrote: > On 05

Re: [Qemu-devel] [Qemu-ppc] [PULL 19/48] spapr: allocate the ICPState object from under sPAPRCPUCore

2017-05-17 Thread Greg Kurz
On Wed, 17 May 2017 16:37:52 +1000 David Gibson wrote: [...] > > >> > > >> Greg is looking at re-adding the ICPState array because of a > > >> migration issue with older machines. We might need to do so > > >> unconditionally ... > > >> > > > > > > That would be a pity to carry on with the pr

Re: [Qemu-devel] [RFC PATCH v1 1/6] migration: Fix unregister_savevm()

2017-05-17 Thread Bharata B Rao
On Wed, May 17, 2017 at 04:43:00PM +1000, David Gibson wrote: > On Wed, May 17, 2017 at 09:19:17AM +0530, Bharata B Rao wrote: > > In unregister_savevm(), free se->compat only if it was allocated earlier. > > > > Signed-off-by: Bharata B Rao > > I don't think this is necessary. If se->compat wa

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Gonglei (Arei)
> > On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: > By the way, I'm having a hard time understing how is the requirement > form > > >> > http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-260 > 004 > (2.4.4 Message Framing) satisfied by this code. Could

[Qemu-devel] [PATCH 2/2] xhci: add CONFIG_USB_XHCI_NEC option

2017-05-17 Thread Gerd Hoffmann
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1451189 Signed-off-by: Gerd Hoffmann --- default-configs/pci.mak | 1 + hw/usb/Makefile.objs| 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/default-configs/pci.mak b/default-configs/pci.mak index 60dc6510ec..3bbeb62d9a 1

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Halil Pasic
On 05/17/2017 12:13 PM, Gonglei (Arei) wrote: >> >> On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: >> By the way, I'm having a hard time understing how is the requirement >> form >> >> http://docs.oasis-open.org/virtio/virtio/v1.0/cs04/virtio-v1.0-cs04.html#x1-260 >> 004 >> (2

[Qemu-devel] [PATCH 1/2] xhci: split into multiple files

2017-05-17 Thread Gerd Hoffmann
Moved structs and defines to hcd-xhci.h. Move nec controller variant to hcd-xhci-nec.c. No functional changes. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.h | 226 +++ hw/usb/hcd-xhci-nec.c | 63 + hw/usb/hcd-xhci.c | 238 +---

Re: [Qemu-devel] [PATCH 12/17] qdev: use int and uint properties as appropriate

2017-05-17 Thread Markus Armbruster
Marc-André Lureau writes: > Use unsigned type for various properties. > > Signed-off-by: Marc-André Lureau > --- > include/hw/qdev-core.h | 5 +++- > include/hw/qdev-properties.h | 67 > ++-- > hw/block/fdc.c | 54 +--

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Cornelia Huck
On Wed, 17 May 2017 12:33:20 +0200 Halil Pasic wrote: > On 05/17/2017 12:13 PM, Gonglei (Arei) wrote: > >> > >> On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: > >> By the way, I'm having a hard time understing how is the requirement > >> form > >> > > >> http://docs.oasis-open.org/vir

[Qemu-devel] [PATCH v4 1/3] net/rocker: Remove the dead error handling

2017-05-17 Thread Mao Zhongyi
The function of_dpa_world_alloc is a wrapper around world_alloc(), which returns null only when g_malloc0(size_t size) does. But g_malloc0() also is a wrapper around g_malloc0_n(1, size) that ignore the fact that g_malloc0() of 0 bytes, it doesn't returns null. So the error handling is dead. Simila

[Qemu-devel] [PATCH v4 0/3] Convert to realize and fix error handling

2017-05-17 Thread Mao Zhongyi
v4: * Patch 1 is following Markus's suggestion that remove the dead error handling. * Patch 2 is separate from patch 1 to plug the memory leak in the v3. * Patch 3 is based on the patch 1 in the v3. Meanwhile, dorp the superfluous prefix "rocker:" and adjust the commit message. v3: * Following

[Qemu-devel] [PATCH v4 3/3] net/rocker: Convert to realize()

2017-05-17 Thread Mao Zhongyi
The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). .init() reports errors with fprintf() and return 0 on success, negative number on failure. Meanwhile, when -device rocker fails, it first report a specif

[Qemu-devel] [PATCH v4 2/3] net/rocker: Plug memory leak in pci_rocker_init()

2017-05-17 Thread Mao Zhongyi
pci_rocker_init() leaks a World when the name more than 9 chars, then return a negative value directly, doesn't make a correct cleanup. So add a new goto label to fix it. Cc: jasow...@redhat.com Cc: j...@resnulli.us Cc: f4...@amsat.org Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- hw/net/

[Qemu-devel] [PULL 1/7] migration: Fix regression with compression threads

2017-05-17 Thread Juan Quintela
Compression threads got broken on commit commit 247956946651ae0280f7b1ea88bb6237dd01c231 Author: Juan Quintela Date: Tue Mar 21 11:45:01 2017 +0100 ram: reorganize last_sent_block On do_compress_ram_page() we use a different QEMUFile than the migration one. We need to pass it the

[Qemu-devel] [PULL 3/7] ram: Rename RAM_SAVE_FLAG_COMPRESS to RAM_SAVE_FLAG_ZERO

2017-05-17 Thread Juan Quintela
Reflects better what it does now, and avoid confussions with RAM_SAVE_FLAG_COMPRESS_PAGE. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- migration/ram.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 995d1f

[Qemu-devel] [PULL 0/7] Migration pull request

2017-05-17 Thread Juan Quintela
cdece0467c7cf8e3f4b3c3f0b13bf2c4fea9: block/win32: fix 'ret not initialized' warning (2017-05-16 15:34:18 +0100) are available in the git repository at: git://github.com/juanquintela/qemu.git tags/migration/20170517 for you to fetch changes up to 1bfe5f0586083747f1602931713111

[Qemu-devel] [PULL 2/7] migration: Pass Error ** argument to {save, load}_vmstate

2017-05-17 Thread Juan Quintela
This way we use the "normal" way of printing errors for hmp commands. Signed-off-by: Juan Quintela Suggested-by: Paolo Bonzini Reviewed-by: Peter Xu Reviewed-by: Laurent Vivier --- hmp.c| 9 +++-- include/sysemu/sysemu.h | 4 ++-- migration/savevm.c | 51 +

[Qemu-devel] [PULL 5/7] migration: Move page_cache.c to migration/

2017-05-17 Thread Juan Quintela
It is only used by migration, so move it there. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- Makefile.objs | 1 - migration/Makefile.objs | 2 +- page_cache.c => migration/page_cache.c| 0 {include/migration =

[Qemu-devel] [PULL 4/7] migration: Create migration/blocker.h

2017-05-17 Thread Juan Quintela
This allows us to remove lots of includes of migration/migration.h Signed-off-by: Juan Quintela Reviewed-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert --- block/qcow.c | 2 +- block/vdi.c | 2 +- block/vhdx.c | 2 +- block/vmdk.c

[Qemu-devel] [PULL 7/7] migration: Move check_migratable() into qdev.c

2017-05-17 Thread Juan Quintela
The function is only used once, and nothing else in migration knows about objects. Create the function vmstate_device_is_migratable() in savem.c that really do the bit that is related with migration. Signed-off-by: Juan Quintela Reviewed-by: Peter Xu --- hw/core/qdev.c| 20

[Qemu-devel] [PULL 6/7] migration: Move postcopy stuff to postcopy-ram.c

2017-05-17 Thread Juan Quintela
Yes, we don't have a good place to put that stuff. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 26 -- migration/migration.c | 18 -- migration/postcopy-ram.c | 18 ++ mi

Re: [Qemu-devel] [PATCH v2 07/12] dirty-bitmap: Change bdrv_get_dirty_count() to report bytes

2017-05-17 Thread Juan Quintela
Eric Blake wrote: > Thanks to recent cleanups, all callers were scaling a return value > of sectors into bytes; do the scaling internally instead. > > Signed-off-by: Eric Blake > Reviewed-by: John Snow > Reviewed-by: Juan Quintela

Re: [Qemu-devel] [PATCH v2 08/12] dirty-bitmap: Change bdrv_get_dirty() to take bytes

2017-05-17 Thread Juan Quintela
Eric Blake wrote: > Half the callers were already scaling bytes to sectors; the other > half can eventually be simplified to use byte iteration. Both > callers were already using the result as a bool, so make that > explicit. Making the change also makes it easier for a future > dirty-bitmap pat

[Qemu-devel] [PATCH] e1000e: Fix a bug where guest hangs upon migration

2017-05-17 Thread Sameeh Jubran
The bug was caused by the "receive overrun" (bit #6 of the ICR register) interrupt which would be triggered post migration in a heavy traffic environment. Even though the "receive overrun" bit (#6) is masked out by the IMS register (refer to the log below) the driver still receives an interrupt

Re: [Qemu-devel] [RFC PATCH v2 0/8] s390x: Enable virtio-scsi boot from /dev/sgX

2017-05-17 Thread Cornelia Huck
On Tue, 16 May 2017 15:44:43 +0200 Christian Borntraeger wrote: > On 05/10/2017 05:53 PM, Eric Farman wrote: > > Today, trying to boot a guest from a SCSI LUN on s390x yields the following: > > > > virtio-blk = OK > > virtio-scsi and /dev/sdX = OK > > virtio-scsi and /dev/sgX

Re: [Qemu-devel] [PATCH] iotests: 147: Don't test inet6 if not available

2017-05-17 Thread Kevin Wolf
Am 17.05.2017 um 04:13 hat Fam Zheng geschrieben: > On Fri, 05/05 18:21, Fam Zheng wrote: > > This is the case in our docker tests, as we use --net=none there. Skip > > this method. > > Ping. Is this patch okay? I thought you might want to respond to Dan's comment. If you don't plan to make the c

Re: [Qemu-devel] [PATCH v2 09/12] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes

2017-05-17 Thread Juan Quintela
Eric Blake wrote: > Some of the callers were already scaling bytes to sectors; others > can be easily converted to pass byte offsets, all in our shift > towards a consistent byte interface everywhere. Making the change > will also make it easier to write the hold-out callers to use byte > rather

Re: [Qemu-devel] [PATCH v2] virtio: Move memory_listener_unregister to .unrealize

2017-05-17 Thread Fam Zheng
On Wed, 05/17 02:58, Paolo Bonzini wrote: > The child property is deleted when bus_unparent calls object_unparent: > > while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) { > DeviceState *dev = kid->child; > object_unparent(OBJECT(dev)); > } > > and in turn bus_unparent i

Re: [Qemu-devel] [Qemu-block] [RFC PATCH] qemu-io: add drain/undrain cmd

2017-05-17 Thread Stefan Hajnoczi
On Mon, May 15, 2017 at 12:02:43PM +0200, Peter Lieven wrote: > I would like to add a feature to Qemu to drain all traffic from a block so > that > I can take external snaphosts without the risk to that in the middle of a > write > operation. Its meant for cases where where QGA freeze/thaw is not

Re: [Qemu-devel] [Qemu-block] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-17 Thread Stefan Hajnoczi
On Mon, May 15, 2017 at 02:39:40PM +0200, Kevin Wolf wrote: > This adds a small test for the image streaming error path for failing > block_job_create(), which would have found the null pointer dereference > in commit a170a91f. > > Signed-off-by: Kevin Wolf > --- > tests/qemu-iotests/030 | 4

Re: [Qemu-devel] [PATCH] iotests: 147: Don't test inet6 if not available

2017-05-17 Thread Fam Zheng
On Wed, 05/17 13:59, Kevin Wolf wrote: > Am 17.05.2017 um 04:13 hat Fam Zheng geschrieben: > > On Fri, 05/05 18:21, Fam Zheng wrote: > > > This is the case in our docker tests, as we use --net=none there. Skip > > > this method. > > > > Ping. Is this patch okay? > > I thought you might want to re

Re: [Qemu-devel] [PATCH] e1000e: Fix a bug where guest hangs upon migration

2017-05-17 Thread Dmitry Fleytman
> On 17 May 2017, at 14:46 PM, Sameeh Jubran wrote: > > The bug was caused by the "receive overrun" (bit #6 of the ICR register) > interrupt > which would be triggered post migration in a heavy traffic environment. Even > though the > "receive overrun" bit (#6) is masked out by the IMS registe

Re: [Qemu-devel] [PATCH] iotests: 147: Don't test inet6 if not available

2017-05-17 Thread Daniel P. Berrange
On Wed, May 17, 2017 at 08:10:51PM +0800, Fam Zheng wrote: > On Wed, 05/17 13:59, Kevin Wolf wrote: > > Am 17.05.2017 um 04:13 hat Fam Zheng geschrieben: > > > On Fri, 05/05 18:21, Fam Zheng wrote: > > > > This is the case in our docker tests, as we use --net=none there. Skip > > > > this method. >

Re: [Qemu-devel] [PATCH] iotests: 147: Don't test inet6 if not available

2017-05-17 Thread Fam Zheng
On Fri, 05/05 11:41, Daniel P. Berrange wrote: > On Fri, May 05, 2017 at 06:21:53PM +0800, Fam Zheng wrote: > > This is the case in our docker tests, as we use --net=none there. Skip > > this method. > > > > Signed-off-by: Fam Zheng > > --- > > tests/qemu-iotests/147 | 7 +++ > > 1 file chan

Re: [Qemu-devel] [PATCH] iotests: 147: Don't test inet6 if not available

2017-05-17 Thread Kevin Wolf
Am 05.05.2017 um 12:21 hat Fam Zheng geschrieben: > This is the case in our docker tests, as we use --net=none there. Skip > this method. > > Signed-off-by: Fam Zheng Thanks, applied to the block branch. Kevin

[Qemu-devel] [PATCH v2] ui: egl-headless requires dmabuf support

2017-05-17 Thread Gerd Hoffmann
Reported-by: Thomas Huth Signed-off-by: Gerd Hoffmann --- vl.c | 4 ++-- ui/Makefile.objs | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/vl.c b/vl.c index 5c9b40eb1c..2d7aeec186 100644 --- a/vl.c +++ b/vl.c @@ -2129,7 +2129,7 @@ static DisplayType select_displ

Re: [Qemu-devel] [PATCH] gluster: add support for PREALLOC_MODE_FALLOC

2017-05-17 Thread Niels de Vos
On Tue, May 16, 2017 at 11:42:37AM -0400, Jeff Cody wrote: > On Mon, May 15, 2017 at 09:11:36PM +0200, Niels de Vos wrote: > > Add missing support for "preallocation=falloc" to the Gluster block > > driver. This change bases its logic on that of block/file-posix.c and > > removed the gluster_suppor

Re: [Qemu-devel] [PATCH v4] qemu-img: Check for backing image if specified during create

2017-05-17 Thread Max Reitz
On 2017-05-16 10:17, Kevin Wolf wrote: > Am 15.05.2017 um 21:17 hat Max Reitz geschrieben: >> On 2017-05-15 20:41, Max Reitz wrote: >>> On 2017-05-12 21:47, John Snow wrote: On 05/12/2017 03:46 PM, Eric Blake wrote: > On 05/12/2017 01:07 PM, Max Reitz wrote: >> On 2017-05-11

[Qemu-devel] [PATCH v2] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-17 Thread Stefan Hajnoczi
The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit file so GDB either loads qemu-gdb.py automatically or prints a message informing the user how to enable them (some systems disable ./.gdbinit loading for security reasons). Symlink .gdbinit and the scripts directory in order

Re: [Qemu-devel] [PATCH] oslib: strip trailing '\n' from error_setg() string argument

2017-05-17 Thread Stefan Hajnoczi
On Mon, May 15, 2017 at 09:11:49PM -0300, Philippe Mathieu-Daudé wrote: > spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/oslib-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Please send multi-patch se

Re: [Qemu-devel] [PATCH v2] virtio: Move memory_listener_unregister to .unrealize

2017-05-17 Thread Paolo Bonzini
On 17/05/2017 14:00, Fam Zheng wrote: > On Wed, 05/17 02:58, Paolo Bonzini wrote: >> The child property is deleted when bus_unparent calls object_unparent: >> >> while ((kid = QTAILQ_FIRST(&bus->children)) != NULL) { >> DeviceState *dev = kid->child; >> object_unparent(OBJECT(

Re: [Qemu-devel] [Qemu-block] [PULL 0/8] Block patches for curl

2017-05-17 Thread Stefan Hajnoczi
On Tue, May 16, 2017 at 11:54:12AM -0400, Jeff Cody wrote: > The following changes since commit 3a8760664d5c1a1a93c9012bdb8ac07ab8fd4b0d: > > Merge tag 'tracing-pull-request' into staging (2017-05-12 10:39:35 -0400) > > are available in the git repository at: > > git://github.com/codyprime/q

Re: [Qemu-devel] [PATCH] nvme: Add support for Controller Memory Buffers

2017-05-17 Thread Kevin Wolf
Am 17.05.2017 um 04:22 hat Stephen Bates geschrieben: > > Awesome, this looks great! > > > > Acked-by: Keith Busch > > Thanks Keith! > > I still seem to be having issues getting my patches onto the qemu-* > mailing lists. Does anyone have any idea how I go about rectifying > that? This mail se

Re: [Qemu-devel] [PULL 0/4] please pull xen-20170516-tag

2017-05-17 Thread Stefan Hajnoczi
On Tue, May 16, 2017 at 12:19:26PM -0700, Stefano Stabellini wrote: > The following changes since commit cdece0467c7cf8e3f4b3c3f0b13bf2c4fea9: > > block/win32: fix 'ret not initialized' warning (2017-05-16 15:34:18 +0100) > > are available in the git repository at: > > git://xenbits.xen.

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-17 Thread Halil Pasic
On 05/17/2017 01:10 PM, Cornelia Huck wrote: > On Wed, 17 May 2017 12:33:20 +0200 > Halil Pasic wrote: > >> On 05/17/2017 12:13 PM, Gonglei (Arei) wrote: On 05/17/2017 11:12 AM, Gonglei (Arei) wrote: By the way, I'm having a hard time understing how is the requirement fo

Re: [Qemu-devel] [RESEND PATCH] virtio: allow broken device to notify guest

2017-05-17 Thread Stefan Hajnoczi
On Wed, May 17, 2017 at 10:17:51AM +0200, Greg Kurz wrote: > According to section 2.1.2 of the virtio-1 specification: > > "The device SHOULD set DEVICE_NEEDS_RESET when it enters an error state that > a reset is needed. If DRIVER_OK is set, after it sets DEVICE_NEEDS_RESET, > the device MUST send

Re: [Qemu-devel] [PATCH] qemu-iotests: Test streaming with missing job ID

2017-05-17 Thread Jeff Cody
On Mon, May 15, 2017 at 02:39:40PM +0200, Kevin Wolf wrote: > This adds a small test for the image streaming error path for failing > block_job_create(), which would have found the null pointer dereference > in commit a170a91f. > > Signed-off-by: Kevin Wolf > --- Reviewed-by: Jeff Cody > tes

[Qemu-devel] [PULL 00/22] x86 and machine queue, 2017-05-17

2017-05-17 Thread Eduardo Habkost
The following changes since commit 599c9cb641cc484876d5bb92189d09ba27bbfdfd: Merge remote-tracking branch 'sstabellini/tags/xen-20170516-tag' into staging (2017-05-17 14:03:35 +0100) are available in the git repository at: git://github.com/ehabkost/qemu.git tags/x86-and-machine-pull-request

[Qemu-devel] [PULL 01/22] qdev: Replace cannot_instantiate_with_device_add_yet with !user_creatable

2017-05-17 Thread Eduardo Habkost
cannot_instantiate_with_device_add_yet was introduced by commit efec3dd631d94160288392721a5f9c39e50fb2bc to replace no_user. It was supposed to be a temporary measure. When it was introduced, we had 54 cannot_instantiate_with_device_add_yet=true lines in the code. Today (3 years later) this number

[Qemu-devel] [PULL 10/22] sysbus-ahci: Remove user_creatable flag

2017-05-17 Thread Eduardo Habkost
The sysbus-ahci devices are supposed to be created and wired by code from other devices, like calxeda_init() and xlnx_zynqmp_realize(), and won't work with -device. Remove the user_creatable flag from the device class. Cc: John Snow Cc: qemu-bl...@nongnu.org Cc: Rob Herring Cc: Peter Maydell Cc

Re: [Qemu-devel] [PATCH v2 09/12] dirty-bitmap: Change bdrv_[re]set_dirty_bitmap() to use bytes

2017-05-17 Thread Eric Blake
On 05/17/2017 06:59 AM, Juan Quintela wrote: > Eric Blake wrote: >> Some of the callers were already scaling bytes to sectors; others >> can be easily converted to pass byte offsets, all in our shift >> towards a consistent byte interface everywhere. Making the change >> will also make it easier

[Qemu-devel] [PULL 03/22] xen-backend: Remove FIXME comment about user_creatable flag

2017-05-17 Thread Eduardo Habkost
xen-backend can be plugged/unplugged dynamically when using the Xen accelerator, so keep the user_creatable flag on the device class and remove the FIXME comment. Cc: Juergen Gross , Cc: Peter Maydell , Cc: Thomas Huth Cc: sstabell...@kernel.org Cc: Markus Armbruster , Cc: Marcel Apfelbaum , Cc:

[Qemu-devel] [PULL 12/22] isabus-bridge: Remove user_creatable flag

2017-05-17 Thread Eduardo Habkost
isabus-bridge needs to be created by isa_bus_new(), and won't work with -device, as it won't create the TYPE_ISA_BUS bus itself. Remove the user_creatable flag from the device class. Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost Message

[Qemu-devel] [PULL 04/22] iommu: Remove FIXME comment about user_creatable=true

2017-05-17 Thread Eduardo Habkost
amd-iommu and intel-iommu are really meant to be used with -device, so they need user_creatable=true. Remove the FIXME comment. Cc: Marcel Apfelbaum Cc: "Michael S. Tsirkin" Reviewed-by: Marcel Apfelbaum Acked-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost Message-Id: <20170503203604.314

[Qemu-devel] [PULL 19/22] virtio-mmio: Remove user_creatable flag

2017-05-17 Thread Eduardo Habkost
virtio-mmio needs to be wired and mapped by other device or board code, and won't work with -device. Remove the user_creatable flag from the device class. Cc: Laszlo Ersek Cc: Marcel Apfelbaum Cc: Peter Maydell Cc: Shannon Zhao Cc: "Michael S. Tsirkin" Reviewed-by: Laszlo Ersek Acked-by: Mar

  1   2   3   >