Re: [Qemu-devel] [virtio-dev] Re: [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-16 Thread Wei Wang
On 05/16/2017 02:46 PM, Jason Wang wrote: On 2017年05月12日 16:35, Wei Wang wrote: This patch series implements vhost-pci, which is a point-to-point based inter-vm communication solution. The QEMU side implementation includes the vhost-user extension, vhost-pci device emulation and management, a

Re: [Qemu-devel] [Qemu-trivial] [PATCH] oslib: strip trailing '\n' from error_setg() string argument

2017-05-16 Thread Laurent Vivier
On 16/05/2017 02:11, Philippe Mathieu-Daudé wrote: > spotted by Coccinelle script scripts/coccinelle/err-bad-newline.cocci > > Signed-off-by: Philippe Mathieu-Daudé > --- > util/oslib-posix.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/util/oslib-posix.c b/util/osli

[Qemu-devel] [PATCH v2] virtio: Move memory_listener_unregister to .unrealize

2017-05-16 Thread Fam Zheng
This is noticed while working on RHBZ 1449031, and fixes the reported crash which happens when plugging back a virtio-scsi device after unplugging it. The root cause of the crash is not obvious here, but the change regardlessly makes sense so it's proposed here: the listener was registered in .rea

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-16 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> Eric Blake wrote: > > Or is the proposal that we are also going to simplify the QMP 'migrate' command to get rid of crufty parameters? >>> >>> I didn't read it that way, but I would not oppose O:-) >>> >

Re: [Qemu-devel] [PATCH] sockets: Plug memory leak in socket_address_flatten()

2017-05-16 Thread Markus Armbruster
Eric Blake writes: > On 05/15/2017 11:39 AM, Markus Armbruster wrote: >> socket_address_flatten() leaks a SocketAddress when its argument is >> null. Happens when opening a ChardevBackend of type 'udp' that is >> configured without a local address. Screwed up in commit bd269ebc due >> to last m

[Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning

2017-05-16 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- block/file-win32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/file-win32.c b/block/file-win32.c index 1a35dbabf2..8f14f0bdcd 100644 --- a/block/file-win32.c +++ b/block/file-win32.c @@ -346,6 +346,7 @@ static int raw_open(BlockDriverState *bs, QDict

Re: [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning

2017-05-16 Thread Stefan Weil
Am 16.05.2017 um 09:42 schrieb Gerd Hoffmann: Signed-off-by: Gerd Hoffmann --- block/file-win32.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block/file-win32.c b/block/file-win32.c index 1a35dbabf2..8f14f0bdcd 100644 --- a/block/file-win32.c +++ b/block/file-win32.c @@ -346,6 +346,7 @@

[Qemu-devel] [PATCH v4 1/8] tpm-backend: Remove unneeded member variable from backend class

2017-05-16 Thread Amarnath Valluri
TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class member. The only possible reason for keeping in TPMBackend was, to get the backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is present. Signed-off-by: Amarnath Valluri --- hw/tpm/tpm_passthro

[Qemu-devel] [PATCH v4 7/8] tpm-passthrough: move reusable code to utils

2017-05-16 Thread Amarnath Valluri
Signed-off-by: Amarnath Valluri --- hw/tpm/tpm_passthrough.c | 64 hw/tpm/tpm_util.c| 25 +++ hw/tpm/tpm_util.h| 4 +++ 3 files changed, 34 insertions(+), 59 deletions(-) diff --git a/hw/tpm/tpm_passthrough.c b/hw/

[Qemu-devel] [PATCH v4 3/8] tpm-backend: Initialize and free data members in it's own methods

2017-05-16 Thread Amarnath Valluri
Initialize and free TPMBackend data members in it's own instance_init() and instance_finalize methods. Took the opportunity to remove unneeded destroy() method from TpmDriverOps interface as TPMBackend is a Qemu Object, we can use object_unref() inplace of tpm_backend_destroy() to free the backend

[Qemu-devel] [PATCH v4 5/8] tmp backend: Add new api to read backend TpmInfo

2017-05-16 Thread Amarnath Valluri
TPM configuration options are backend implementation details and shall not be part of base TPMBackend object, and these shall not be accessed directly outside of the class, hence added a new interface method, get_tpm_options() to TPMDriverOps., which shall be implemented by the derived classes to r

[Qemu-devel] [PATCH v4 4/8] tpm-backend: Made few interface methods optional

2017-05-16 Thread Amarnath Valluri
This allows backend implementations left optional interface methods. For mandatory methods assertion checks added. Took the opportunity to remove unused methods: tpm_backend_get_type() tpm_backend_get_desc() Signed-off-by: Amarnath Valluri --- backends/tpm.c | 36 +

[Qemu-devel] [PATCH v4 2/8] tpm-backend: Move thread handling inside TPMBackend

2017-05-16 Thread Amarnath Valluri
Move thread handling inside TPMBackend, this way backend implementations need not to maintain their own thread life cycle, instead they needs to implement 'handle_request()' class method that always been called from a thread. This change made tpm_backend_int.h kind of useless, hence removed it. S

[Qemu-devel] [PATCH v4 6/8] tpm-backend: Move realloc_buffer() implementation to tpm-tis model

2017-05-16 Thread Amarnath Valluri
buffer reallocation is very unlikely to be backend specific. Hence move inside the tis. Signed-off-by: Amarnath Valluri --- backends/tpm.c | 9 - hw/tpm/tpm_passthrough.c | 12 hw/tpm/tpm_tis.c | 14 -- include/sysemu/tpm_backend.h

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-16 Thread Juan Quintela
Markus Armbruster wrote: > Juan Quintela writes: ... >> As qmp command is asynchronous, you can think that -d is *always* on in >> QMP O:-) > > Yes. The existence of "detach" in QMP is owed to limitations of early > QMP infrastructure. It's flagged as "invalid" and "should not be > used" sinc

[Qemu-devel] [PATCH v4 0/8] Provide support for the software TPM emulator

2017-05-16 Thread Amarnath Valluri
Briefly, Theses set of patches introduces: - new TPM backend driver to support software TPM emulators(swtpm(1)). - and few supported fixes/enhancements/cleanup to existing tpm backend code. The similar idea was initiated earliar(2) by Stefan Berger(CCed) with slightly different approach, u

Re: [Qemu-devel] [PATCH] block/win32: fix 'ret not initialized' warning

2017-05-16 Thread Fam Zheng
On Tue, 05/16 09:52, Stefan Weil wrote: > Am 16.05.2017 um 09:42 schrieb Gerd Hoffmann: > > Signed-off-by: Gerd Hoffmann > > --- > > block/file-win32.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/block/file-win32.c b/block/file-win32.c > > index 1a35dbabf2..8f14f0bdcd 100644 >

[Qemu-devel] [PATCH v4 8/8] tpm: Added support for TPM emulator

2017-05-16 Thread Amarnath Valluri
This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface. Swtpm uses two unix sockets, one for plain TPM commands and responses, and one for out-of-band control messages. The swtpm and associated tools can be found h

Re: [Qemu-devel] [PATCH v2] virtio: Move memory_listener_unregister to .unrealize

2017-05-16 Thread Fam Zheng
On Tue, 05/16 15:24, Fam Zheng wrote: > The root cause of the crash is not obvious here, but the change > regardlessly makes sense so it's proposed here: the listener was > registered in .realize(), so do the cleanup in the matching .unrealize() > rather than the .finalize() callback. Actually it

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

2017-05-16 Thread Miltiadis Hatzimihail
​I ve seen that I ve accidentally dropped the list from the email.. So for fstps for the 32bit - how does this patch look? diff --git a/arch/x86/kvm/emulate.c b/arch/x86/kvm/emulate.c index a252081d..83b0fd2 100644 --- a/arch/x86/kvm/emulate.c +++ b/arch/x86/kvm/emulate.c @@ -1139,6 +1139,27

Re: [Qemu-devel] [PATCH v4] qemu-img: Check for backing image if specified during create

2017-05-16 Thread Kevin Wolf
Am 15.05.2017 um 21:17 hat Max Reitz geschrieben: > On 2017-05-15 20:41, Max Reitz wrote: > > On 2017-05-12 21:47, John Snow wrote: > >> > >> > >> On 05/12/2017 03:46 PM, Eric Blake wrote: > >>> On 05/12/2017 01:07 PM, Max Reitz wrote: > On 2017-05-11 20:27, John Snow wrote: > > Fixes: htt

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-16 Thread Maxime Coquelin
On 05/12/2017 04:21 PM, Maxime Coquelin wrote: On 05/11/2017 08:25 PM, Michael S. Tsirkin wrote: On Thu, May 11, 2017 at 02:32:46PM +0200, Maxime Coquelin wrote: This patch specifies and implements the master/slave communication to support device IOTLB in slave. The vhost_iotlb_msg structu

Re: [Qemu-devel] [PATCH v9 4/4] qemu-img: copy *key-secret opts when opening newly created files

2017-05-16 Thread Daniel P. Berrange
On Mon, May 15, 2017 at 07:43:15PM +0200, Max Reitz wrote: > On 2017-05-15 16:04, Daniel P. Berrange wrote: > > The qemu-img dd/convert commands will create an image file and > > then try to open it. Historically it has been possible to open > > new files without passing any options. With encrypted

Re: [Qemu-devel] [PATCH] fix mingw build failure

2017-05-16 Thread Daniel P. Berrange
On Tue, May 16, 2017 at 07:24:39AM +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > --- > crypto/random-platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/crypto/random-platform.c b/crypto/random-platform.c > index 0eddb915b7..92eed0ee78 100644 > ---

Re: [Qemu-devel] 答复: Re: [RFC] virtio-fc: draft idea of virtual fibre channel HBA

2017-05-16 Thread Paolo Bonzini
> Maybe a union with an overall size of 256 byte (to hold the iSCSI iqn > string), which for FC carries the WWPN and the WWNN? That depends on how you would like to do controller passthrough in general. iSCSI doesn't have the 64-bit target ID, and doesn't have (AFAIK) hot-plug/hot-unplug support

Re: [Qemu-devel] [PATCH RESEND V2 0/3] Optimize filter-mirror and filter-rewriter

2017-05-16 Thread Zhang Chen
On 05/16/2017 02:48 PM, Jason Wang wrote: On 2017年05月15日 14:18, Zhang Chen wrote: Fix some duplicate codes and remove unused codes. v2: Address Eric's comment on patch 3. Zhang Chen (3): net/filter-mirror.c: Remove duplicate check code. net/filter-mirror.c: Rename filter_mirror_send(

Re: [Qemu-devel] [PATCH] hw/net/rocker/rocker: Convert pci device .init() to .realize()

2017-05-16 Thread Mao Zhongyi
Hi, Jason On 05/16/2017 02:45 PM, Jason Wang wrote: On 2017年05月12日 16:35, Mao Zhongyi wrote: Convert pci device .init() to .realize(). Also improve -device rocker error reporting. Because when -device rocker fails, it first reports a specific error, then a generic one, like this: $ x86

Re: [Qemu-devel] [PATCH v9 2/5] shutdown: Prepare for use of an enum in reset/shutdown_request

2017-05-16 Thread Markus Armbruster
Eric Blake writes: > We want to track why a guest was shutdown; in particular, being able > to tell the difference between a guest request (such as ACPI request) > and host request (such as SIGINT) will prove useful to libvirt. > Since all requests eventually end up changing shutdown_requested in

Re: [Qemu-devel] [PATCH v9 3/5] shutdown: Preserve shutdown cause through replay

2017-05-16 Thread Markus Armbruster
Eric Blake writes: > With the recent addition of ShutdownCause, we want to be able to pass > a cause through any shutdown request, and then faithfully replay that > cause when later replaying the same sequence. The easiest way is to > expand the reply event mechanism to track a series of values

Re: [Qemu-devel] [PATCH v9 4/5] shutdown: Add source information to SHUTDOWN and RESET

2017-05-16 Thread Markus Armbruster
Eric Blake writes: > Time to wire up all the call sites that request a shutdown or > reset to use the enum added in the previous patch. > > It would have been less churn to keep the common case with no > arguments as meaning guest-triggered, and only modified the > host-triggered code paths, via

Re: [Qemu-devel] [PATCH v9 5/5] shutdown: Expose bool cause in SHUTDOWN and RESET events

2017-05-16 Thread Markus Armbruster
Eric Blake writes: > Libvirt would like to be able to distinguish between a SHUTDOWN > event triggered solely by guest request and one triggered by a > SIGTERM or other action on the host. While qemu_kill_report() was > already able to give different output to stderr based on whether a > shutdow

Re: [Qemu-devel] [Qemu-arm] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

2017-05-16 Thread Geert Martin Ijewski
Am 16.05.2017 um 02:01 schrieb John Bradley via Qemu-devel: Hi, The XML files in the base are not in the patch. They where net beans files. I can easily get it into 3 files, one large at 91KB but contains only new files and so is easy to read. Could be smaller but seems pointless. I think wha

Re: [Qemu-devel] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

2017-05-16 Thread Geert Martin Ijewski
Am 14.05.2017 um 02:42 schrieb John Bradley via Qemu-devel: From 7f74f048f135d9c9c230a9e90f72451c841c6d35 Mon Sep 17 00:00:00 2001 From: John Bradley Date: Sat, 13 May 2017 23:07:47 +0100 Subject: [PATCH] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu The files add

Re: [Qemu-devel] [PATCH] nbd: strict nbd_wr_syncv

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
15.05.2017 12:43, Vladimir Sementsov-Ogievskiy wrote: 12.05.2017 19:30, Paolo Bonzini wrote: On 12/05/2017 17:57, Vladimir Sementsov-Ogievskiy wrote: 12.05.2017 18:46, Paolo Bonzini wrote: On 12/05/2017 16:17, Vladimir Sementsov-Ogievskiy wrote: nbd_wr_syncv is called either from coroutine or

Re: [Qemu-devel] [PATCH v2] virtio: Move memory_listener_unregister to .unrealize

2017-05-16 Thread Paolo Bonzini
On 16/05/2017 10:07, Fam Zheng wrote: > On Tue, 05/16 15:24, Fam Zheng wrote: >> The root cause of the crash is not obvious here, but the change >> regardlessly makes sense so it's proposed here: the listener was >> registered in .realize(), so do the cleanup in the matching .unrealize() >> rathe

[Qemu-devel] [PATCH v1] target/s390x: Add support for the TEST BLOCK instruction

2017-05-16 Thread Thomas Huth
TEST BLOCK was likely once used to execute basic memory tests, but nowadays it's just a (slow) way to clear a page. Signed-off-by: Thomas Huth --- target/s390x/helper.h | 1 + target/s390x/insn-data.def | 2 ++ target/s390x/mem_helper.c | 12 target/s390x/translate.c | 10

Re: [Qemu-devel] [PATCH] nbd: strict nbd_wr_syncv

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
16.05.2017 12:10, Vladimir Sementsov-Ogievskiy wrote: 15.05.2017 12:43, Vladimir Sementsov-Ogievskiy wrote: 12.05.2017 19:30, Paolo Bonzini wrote: On 12/05/2017 17:57, Vladimir Sementsov-Ogievskiy wrote: 12.05.2017 18:46, Paolo Bonzini wrote: On 12/05/2017 16:17, Vladimir Sementsov-Ogievskiy

[Qemu-devel] [PATCH 3/5] nbd: add errp parameter to nbd_wr_syncv()

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
Will be used in following patch to provide actual error message in some cases. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 4 ++-- include/block/nbd.h | 3 ++- nbd/common.c| 12 +--- nbd/nbd-internal.h | 4 ++-- 4 files changed, 11 insertions(+), 12

[Qemu-devel] [PATCH 5/5] nbd/client.c: use errp instead of LOG

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
Move to modern errp scheme from just LOGging errors. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd-client.c | 7 ++- include/block/nbd.h | 5 +++-- nbd/client.c| 26 ++ qemu-nbd.c | 3 ++- 4 files changed, 25 insertions(+), 16 deletion

[Qemu-devel] [PATCH 0/5] nbd: error path refactoring

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
Hi all. There are several patches, as preparation for v2 of my NBD BLOCK_STATUS series. patch 0001 was sent earlier and unchanged here. Vladimir Sementsov-Ogievskiy (5): nbd: strict nbd_wr_syncv nbd: read_sync and friends: return 0 on success nbd: add errp parameter to nbd_wr_syncv() nbd:

[Qemu-devel] [PATCH 1/5] nbd: strict nbd_wr_syncv

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
nbd_wr_syncv is called either from coroutine or from client negotiation code, when socket is in blocking mode. So, -EAGAIN is impossible. Furthermore, EAGAIN is confusing, as, what to read/write again? With EAGAIN as a return code we don't know how much data is already read or written by the funct

[Qemu-devel] [PATCH 2/5] nbd: read_sync and friends: return 0 on success

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
functions read_sync, drop_sync, write_sync, and also nbd_negotiate_write, nbd_negotiate_read, nbd_negotiate_drop_sync returns number of processed bytes. But what this number can be, except requested number of bytes? Actually, underlying nbd_wr_syncv function returns a value >= 0 and != requested_b

[Qemu-devel] [PATCH 4/5] nbd: add errp to read_sync, write_sync and drop_sync

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
There a lot of calls of these functions, which already have errp, which they are filling themselves. On the other hand, nbd_wr_syncv has errp parameter too, so it would be great to connect them. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 76 +++--

Re: [Qemu-devel] [PATCH V5 3/9] migration: fix hardcoded function name in error report

2017-05-16 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Signed-off-by: Alexey Perevalov Reviewed-by: Dr. David Alan Gilbert > --- > migration/postcopy-ram.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c > index 4c8

Re: [Qemu-devel] [PATCH] nbd: strict nbd_wr_syncv

2017-05-16 Thread Paolo Bonzini
On 16/05/2017 11:32, Vladimir Sementsov-Ogievskiy wrote: > 16.05.2017 12:10, Vladimir Sementsov-Ogievskiy wrote: >> 15.05.2017 12:43, Vladimir Sementsov-Ogievskiy wrote: >>> I mean, make negotiation behave like normal nbd communication, >>> non-blocking socket + yield.. So, some other coroutines

Re: [Qemu-devel] [Qemu-ppc] [PATCH 6/6] spapr: fix migration of ICP objects from/to older QEMU

2017-05-16 Thread Greg Kurz
On Mon, 15 May 2017 13:40:04 +0200 Greg Kurz wrote: > Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under > sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This > is an improvement since we no longer allocate ICP objects that will > never be used. But it has the s

Re: [Qemu-devel] [PATCH 0/5] nbd: error path refactoring

2017-05-16 Thread Paolo Bonzini
On 16/05/2017 11:45, Vladimir Sementsov-Ogievskiy wrote: > Hi all. There are several patches, as preparation for v2 of my > NBD BLOCK_STATUS series. > > patch 0001 was sent earlier and unchanged here. Thanks, applied. I suppose that if we can remove nbd_negotiate_read/write/drop it's also easy

Re: [Qemu-devel] [PATCH 1/4] exec: simplify phys_page_find() params

2017-05-16 Thread Paolo Bonzini
On 16/05/2017 04:53, David Gibson wrote: > On Mon, May 15, 2017 at 04:50:57PM +0800, Peter Xu wrote: >> It really only plays with the dispatchers, so the parameter list does >> not need that complexity. This helps for readability at least. >> >> Signed-off-by: Peter Xu > > Reviewed-by: David Gi

Re: [Qemu-devel] [PATCH] nbd: strict nbd_wr_syncv

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
16.05.2017 12:51, Paolo Bonzini wrote: On 16/05/2017 11:32, Vladimir Sementsov-Ogievskiy wrote: 16.05.2017 12:10, Vladimir Sementsov-Ogievskiy wrote: 15.05.2017 12:43, Vladimir Sementsov-Ogievskiy wrote: I mean, make negotiation behave like normal nbd communication, non-blocking socket + yiel

Re: [Qemu-devel] [PATCH 0/5] nbd: error path refactoring

2017-05-16 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH 0/5] nbd: error path refactoring Type: series Message-id: 20170516094533.6160-1-vsement...@virtuo

Re: [Qemu-devel] [PATCH] nbd: strict nbd_wr_syncv

2017-05-16 Thread Paolo Bonzini
On 16/05/2017 12:16, Vladimir Sementsov-Ogievskiy wrote: > 16.05.2017 12:51, Paolo Bonzini wrote: >> >> On 16/05/2017 11:32, Vladimir Sementsov-Ogievskiy wrote: >>> 16.05.2017 12:10, Vladimir Sementsov-Ogievskiy wrote: 15.05.2017 12:43, Vladimir Sementsov-Ogievskiy wrote: > I mean, make

[Qemu-devel] [Bug 1286253] Re: virtio-net acceleration features not set when plugged into backend dynamically

2017-05-16 Thread Thomas Huth
Which version of QEMU did you use here? Can you still reproduce this problem with the latest version of QEMU (currently v2.9)? ** Changed in: qemu Status: New => Incomplete -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https

Re: [Qemu-devel] [PATCH V5 4/9] migration: split ufd_version_check onto receive/request features part

2017-05-16 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This modification is necessary for userfault fd features which are > required to be requested from userspace. > UFFD_FEATURE_THREAD_ID is a one of such "on demand" feature, which will > be introduced in the next patch. > > QEMU need to use sepa

Re: [Qemu-devel] [PATCH V5 5/9] migration: introduce postcopy-blocktime capability

2017-05-16 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > Right now it could be used on destination side to > enable vCPU blocktime calculation for postcopy live migration. > vCPU blocktime - it's time since vCPU thread was put into > interruptible sleep, till memory page was copied and thread awake. >

Re: [Qemu-devel] [PATCH] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-16 Thread Stefan Hajnoczi
On Mon, May 15, 2017 at 03:17:28PM +0100, Alex Bennée wrote: > > Stefan Hajnoczi writes: > > > The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit > > file so GDB either loads qemu-gdb.py automatically or prints a message > > informing the user how to enable them (some syste

Re: [Qemu-devel] [PATCH v18 1/2] virtio-crypto: Add virtio crypto device specification

2017-05-16 Thread Halil Pasic
On 05/16/2017 05:48 AM, Gonglei (Arei) wrote: [..] >>> +\begin{itemize*} >>> +\item The device MUST set the \field{session_id} field to a unique session >> identifier when the device finishes processing session creation. >> >> I guess only if successfull (that is status == VIRTIO_CRYPTO_OK). >>

Re: [Qemu-devel] [PATCH] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-16 Thread Daniel P. Berrange
On Tue, May 16, 2017 at 11:45:56AM +0100, Stefan Hajnoczi wrote: > On Mon, May 15, 2017 at 03:17:28PM +0100, Alex Bennée wrote: > > > How would it work for out-of-tree builds? > > ./.gdbinit assumes your current working directory is the root of the > QEMU source tree. If gdb is launched outside

Re: [Qemu-devel] [PATCH] .gdbinit: load QEMU sub-commands when gdb starts

2017-05-16 Thread Markus Armbruster
Stefan Hajnoczi writes: > On Mon, May 15, 2017 at 03:17:28PM +0100, Alex Bennée wrote: >> >> Stefan Hajnoczi writes: >> >> > The scripts/qemu-gdb.py file is not easily discoverable. Add a .gdbinit >> > file so GDB either loads qemu-gdb.py automatically or prints a message >> > informing the u

[Qemu-devel] [PATCH v2] nbd/client.c: use errp instead of LOG

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
Move to modern errp scheme from just LOGging errors. Signed-off-by: Vladimir Sementsov-Ogievskiy --- v2: fix automatic build test. fix nbd_init stub when __linux__ macro is not defined block/nbd-client.c | 7 ++- include/block/nbd.h | 5 +++-- nbd/client.c| 30 +

[Qemu-devel] [PATCH 1/5] hmp: Use visitor api for hmp_migrate_set_parameter()

2017-05-16 Thread Juan Quintela
We only use it for int64 at this point, I am not able to find a way to parse an int with MiB units. Signed-off-by: Juan Quintela --- hmp.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hmp.c b/hmp.c index b9dd933..acbbc5c 100644 --- a/hmp.c +++ b/hmp.c @@ -29,6 +

[Qemu-devel] [PATCH v4 0/5] Remove old MigrationParams

2017-05-16 Thread Juan Quintela
changes from v3 - patch 1 included again. We have a 'block' capability and a 'block_incremental' parameter Make Dave happy: rename shared into incremental Make Eric and Markus happy: block: off -> no block migration, we don't care about block_incremental value blo

[Qemu-devel] [PATCH 5/5] block migration: Allow compile time disable

2017-05-16 Thread Juan Quintela
From: "Dr. David Alan Gilbert" Many users now prefer to use drive_mirror over NBD as an alternative to the older migrate -b option; drive_mirror is more complex to setup but gives you more options (e.g. only migrating some of the disks if some of them are shared). Allow the large chunk of block

[Qemu-devel] [PATCH 3/5] migration: Remove use of old MigrationParams

2017-05-16 Thread Juan Quintela
We have change in the previous patch to use migration capabilities for it. Notice that we continue using the old command line flags from migrate command from the time being. Remove the set_params method as now it is empty. Signed-off-by: Juan Quintela --- - Maintain shared/enabled dependency (

Re: [Qemu-devel] [PATCH v4 0/6] COLO block replication supports shared disk case

2017-05-16 Thread 吴志勇
HI, Hai Liang Is there recently any plan to post libvirt support for COLO feature? Regards, Zhi Yong Wu At 2017-04-12 22:05:15, "zhanghailiang" wrote: >COLO block replication doesn't support the shared disk case, >Here we try to implement it and this is the 4th version. > >Please review an

[Qemu-devel] [PATCH 4/5] migration: Remove old MigrationParams

2017-05-16 Thread Juan Quintela
Not used anymore after moving block migration to use capabilities. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert Reviewed-by: zhanghailiang Reviewed-by: Peter Xu --- include/migration/migration.h | 10 ++ include/migration/vmstate.h | 1 - include/qemu/typedefs.h

Re: [Qemu-devel] [PATCH 0/5] nbd: error path refactoring

2017-05-16 Thread Vladimir Sementsov-Ogievskiy
16.05.2017 13:00, Paolo Bonzini wrote: On 16/05/2017 11:45, Vladimir Sementsov-Ogievskiy wrote: Hi all. There are several patches, as preparation for v2 of my NBD BLOCK_STATUS series. patch 0001 was sent earlier and unchanged here. Thanks, applied. I suppose that if we can remove nbd_negotia

[Qemu-devel] [PATCH 2/5] migration: Create block capability

2017-05-16 Thread Juan Quintela
Create one capability for block migration and one parameter for incremental block migration. Signed-off-by: Juan Quintela --- hmp.c | 13 +++ include/migration/block.h | 2 + include/migration/migration.h | 7 migration/migration.c | 88

Re: [Qemu-devel] [PATCH] scripts/qmp/qom-set: fix the value argument passed to srv.command()

2017-05-16 Thread Markus Armbruster
Greg Kurz writes: > When invoking the script with -s, we end up passing a bogus value > to QEMU: > > $ ./scripts/qmp/qom-set -s /var/tmp/qmp-sock-exp /machine.accel kvm > {} > $ ./scripts/qmp/qom-get -s /var/tmp/qmp-sock-exp /machine.accel > /var/tmp/qmp-sock-exp > > This happens because sys.argv

Re: [Qemu-devel] [PATCH V5 7/9] migration: calculate vCPU blocktime on dst side

2017-05-16 Thread Dr. David Alan Gilbert
* Alexey Perevalov (a.pereva...@samsung.com) wrote: > This patch provides blocktime calculation per vCPU, > as a summary and as a overlapped value for all vCPUs. > > This approach was suggested by Peter Xu, as an improvements of > previous approch where QEMU kept tree with faulted page address and

Re: [Qemu-devel] [PATCH] block: Use QDict helpers for --force-share

2017-05-16 Thread Markus Armbruster
Eric Blake writes: > Fam's addition of --force-share in commits 459571f7 and 335e9937 > were developed prior to the addition of QDict scalar insertion > macros, but merged after the general cleanup in commit 46f5ac20. > Patch created mechanically by rerunning: > > spatch --sp-file scripts/coccin

Re: [Qemu-devel] [PATCH v9 0/5] event: Add source information to SHUTDOWN

2017-05-16 Thread Markus Armbruster
Applied to qapi-next, thanks!

Re: [Qemu-devel] [PULL 19/48] spapr: allocate the ICPState object from under sPAPRCPUCore

2017-05-16 Thread Laurent Vivier
On 26/04/2017 09:00, David Gibson wrote: > From: Cédric Le Goater > > Today, all the ICPs are created before the CPUs, stored in an array > under the sPAPR machine and linked to the CPU when the core threads > are realized. This modeling brings some complexity when a lookup in > the array is requ

Re: [Qemu-devel] [Qemu-ppc] [PATCH v10] migration: spapr: migrate pending_events of spapr state

2017-05-16 Thread Daniel Henrique Barboza
On 05/16/2017 01:25 AM, David Gibson wrote: On Mon, May 15, 2017 at 10:10:52AM -0300, Daniel Henrique Barboza wrote: From: Jianjun Duan In racing situations between hotplug events and migration operation, a rtas hotplug event could have not yet be delivered to the source guest when migration

Re: [Qemu-devel] [PATCH v2] virtio: Move memory_listener_unregister to .unrealize

2017-05-16 Thread Fam Zheng
On Tue, 05/16 11:23, Paolo Bonzini wrote: > > > On 16/05/2017 10:07, Fam Zheng wrote: > > On Tue, 05/16 15:24, Fam Zheng wrote: > >> The root cause of the crash is not obvious here, but the change > >> regardlessly makes sense so it's proposed here: the listener was > >> registered in .realize(),

Re: [Qemu-devel] [PATCH 1/5] hmp: Use visitor api for hmp_migrate_set_parameter()

2017-05-16 Thread Markus Armbruster
Juan Quintela writes: > We only use it for int64 at this point, I am not able to find a way to > parse an int with MiB units. Use the string input visitor and visit_type_size() to parse with unit suffixes. The problem is hmp_migrate_set_parameter() wants "no suffix" to mean "mebibytes", which t

[Qemu-devel] [PATCH v3] net/rocker: Convert to realize

2017-05-16 Thread Mao Zhongyi
The rocker device still implements the old PCIDeviceClass .init() instead of the new .realize(). All devices need to be converted to .realize(). .init() reports errors with fprintf() and return 0 on success, negative number on failure. Meanwhile, when -device rocker fails, it first report a specif

Re: [Qemu-devel] [PATCH] sockets: ensure we can bind to both ipv4 & ipv6 separately

2017-05-16 Thread Daniel P. Berrange
On Fri, Apr 28, 2017 at 01:15:53PM +0100, Daniel P. Berrange wrote: > When binding to an IPv6 socket we currently force the > IPV6_V6ONLY flag to off. This means that the IPv6 socket > will accept both IPv4 & IPv6 sockets when QEMU is launched > with something like > > -vnc :::1 > > While this

Re: [Qemu-devel] [PATCH v2] virtio: Move memory_listener_unregister to .unrealize

2017-05-16 Thread Paolo Bonzini
On 16/05/2017 14:25, Fam Zheng wrote: > You are right. Having had another look, I think it's because of this: > VirtIODevice is an embeded member of VirtIOSCSIPCI therefore it is never > "finalized" through QOM reference directly. Am I right? What I would expect is: virtio_instance_init_common

Re: [Qemu-devel] [PULL 19/48] spapr: allocate the ICPState object from under sPAPRCPUCore

2017-05-16 Thread Cédric Le Goater
On 05/16/2017 02:03 PM, Laurent Vivier wrote: > On 26/04/2017 09:00, David Gibson wrote: >> From: Cédric Le Goater >> >> Today, all the ICPs are created before the CPUs, stored in an array >> under the sPAPR machine and linked to the CPU when the core threads >> are realized. This modeling brings

Re: [Qemu-devel] [PULL 19/48] spapr: allocate the ICPState object from under sPAPRCPUCore

2017-05-16 Thread Laurent Vivier
On 16/05/2017 14:50, Cédric Le Goater wrote: > On 05/16/2017 02:03 PM, Laurent Vivier wrote: >> On 26/04/2017 09:00, David Gibson wrote: >>> From: Cédric Le Goater >>> >>> Today, all the ICPs are created before the CPUs, stored in an array >>> under the sPAPR machine and linked to the CPU when the

Re: [Qemu-devel] [Qemu-block] [PATCH 01/13] vvfat: fix qemu-img map and qemu-img convert

2017-05-16 Thread Kevin Wolf
Am 15.05.2017 um 22:42 hat Eric Blake geschrieben: > On 05/15/2017 03:31 PM, Hervé Poussineau wrote: > > - bs->total_sectors is the number of sectors of the whole disk > > - s->sector_count is the number of sectors of the FAT partition I wonder if we should rename s->sector_count into something li

Re: [Qemu-devel] [PATCH 03/13] vvfat: fix typos

2017-05-16 Thread Kevin Wolf
Am 15.05.2017 um 22:31 hat Hervé Poussineau geschrieben: > Signed-off-by: Hervé Poussineau > --- > block/vvfat.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/block/vvfat.c b/block/vvfat.c > index 002bd86e42..57f2489689 100644 > --- a/block/vvfat.c > +++ b/bloc

Re: [Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

2017-05-16 Thread Michael S. Tsirkin
On Tue, May 16, 2017 at 10:19:24AM +0200, Maxime Coquelin wrote: > > > On 05/12/2017 04:21 PM, Maxime Coquelin wrote: > > > > > > On 05/11/2017 08:25 PM, Michael S. Tsirkin wrote: > > > On Thu, May 11, 2017 at 02:32:46PM +0200, Maxime Coquelin wrote: > > > > This patch specifies and implements

Re: [Qemu-devel] [PATCH 0/4] exec: address space translation cleanups

2017-05-16 Thread Maxime Coquelin
On 05/15/2017 10:50 AM, Peter Xu wrote: The problem is that, address_space_get_iotlb_entry() shares a lot with address_space_translate(). This patch tries to abstract the shared elements. Originally, this work is derived from discussion from VT-d passthrough series discussions [1]. But for sur

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 1/6] hw/ppc/spapr.c: adding pending_dimm_unplugs to sPAPRMachineState

2017-05-16 Thread Daniel Henrique Barboza
On 05/12/2017 03:04 AM, David Gibson wrote: On Fri, May 05, 2017 at 05:47:41PM -0300, Daniel Henrique Barboza wrote: The LMB DRC release callback, spapr_lmb_release(), uses an opaque parameter, a sPAPRDIMMState struct that stores the current LMBs that are allocated to a DIMM (nr_lmbs). After e

Re: [Qemu-devel] [PATCH] sockets: ensure we can bind to both ipv4 & ipv6 separately

2017-05-16 Thread Gerd Hoffmann
Hi, > Separately from this patch, I noticed one further possible > problem, > > Currently, the ipv4=on|off/ipv6=on|off settings are only > used to determine what getaddrinfo results we request/use. > > This leads to the somewhat odd situation where if you set > ipv4=off,ipv6=on, QEMU won't be

Re: [Qemu-devel] [PATCH 01/18] block: access copy_on_read with atomic ops

2017-05-16 Thread Stefan Hajnoczi
On Thu, May 11, 2017 at 04:41:51PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > v1->v2: use atomic_fetch_dec [Stefan] > > block.c | 6 -- > block/io.c| 8 > blockdev.c| 2 +- > include/block/block_int

Re: [Qemu-devel] [PATCH] sockets: ensure we can bind to both ipv4 & ipv6 separately

2017-05-16 Thread Daniel P. Berrange
On Tue, May 16, 2017 at 03:29:51PM +0200, Gerd Hoffmann wrote: > Hi, > > > Separately from this patch, I noticed one further possible > > problem, > > > > Currently, the ipv4=on|off/ipv6=on|off settings are only > > used to determine what getaddrinfo results we request/use. > > > > This leads

Re: [Qemu-devel] [PATCH v1] target/s390x: Add support for the TEST BLOCK instruction

2017-05-16 Thread Aurelien Jarno
On 2017-05-16 11:28, Thomas Huth wrote: > TEST BLOCK was likely once used to execute basic memory > tests, but nowadays it's just a (slow) way to clear a page. > > Signed-off-by: Thomas Huth > --- > target/s390x/helper.h | 1 + > target/s390x/insn-data.def | 2 ++ > target/s390x/mem_helpe

Re: [Qemu-devel] [RFC PATCH v2 0/8] s390x: Enable virtio-scsi boot from /dev/sgX

2017-05-16 Thread Christian Borntraeger
On 05/10/2017 05:53 PM, Eric Farman wrote: > Today, trying to boot a guest from a SCSI LUN on s390x yields the following: > > virtio-blk = OK > virtio-scsi and /dev/sdX = OK > virtio-scsi and /dev/sgX = FAIL > > Example of the failing scenario: > > /usr/bin/qemu-system-s390

Re: [Qemu-devel] [Qemu-ppc] [PATCH v9 3/6] hw/ppc: migrating the DRC state of hotplugged devices

2017-05-16 Thread Daniel Henrique Barboza
On 05/12/2017 03:11 AM, David Gibson wrote: On Fri, May 05, 2017 at 05:47:43PM -0300, Daniel Henrique Barboza wrote: In pseries, a firmware abstraction called Dynamic Reconfiguration Connector (DRC) is used to assign a particular dynamic resource to the guest and provide an interface to manage

Re: [Qemu-devel] [PATCH 05/18] block: access wakeup with atomic ops

2017-05-16 Thread Stefan Hajnoczi
On Thu, May 11, 2017 at 04:41:55PM +0200, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- > v1->v2: add comment [Fam] > > block/io.c| 3 ++- > block/nfs.c | 4 +++- > block/sheepdog.c | 3 ++- > include/block/block.h | 5 +++-- > inclu

Re: [Qemu-devel] [PATCH 07/18] throttle-groups: only start one coroutine from drained_begin

2017-05-16 Thread Stefan Hajnoczi
On Thu, May 11, 2017 at 04:41:57PM +0200, Paolo Bonzini wrote: > Starting all waiting coroutines from bdrv_drain_all is unnecessary; > throttle_group_co_io_limits_intercept calls schedule_next_request as > soon as the coroutine restarts, which in turn will restart the next > request if possible. >

Re: [Qemu-devel] [PATCH] sockets: ensure we can bind to both ipv4 & ipv6 separately

2017-05-16 Thread Gerd Hoffmann
On Di, 2017-05-16 at 14:35 +0100, Daniel P. Berrange wrote: > On Tue, May 16, 2017 at 03:29:51PM +0200, Gerd Hoffmann wrote: > > Hi, > > > > > Separately from this patch, I noticed one further possible > > > problem, > > > > > > Currently, the ipv4=on|off/ipv6=on|off settings are only > > > us

Re: [Qemu-devel] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

2017-05-16 Thread John Bradley via Qemu-devel
"I think that should be #ifdef _WIN32. Maybe in the far future QEMU could also be compiled with Visual Studio or any other windows compiler" The reason for doing it this way is that MINGW64, which is the dev platform I uses on Windows10, does not include a port of the GNU Socket library so I have

Re: [Qemu-devel] [Qemu-arm] Changes to Broadcom(BCM) files and Raspberry Pi files. Addition of PanelEmu

2017-05-16 Thread John Bradley via Qemu-devel
The idea of an RFC is good, but with it I would like to have a demo. Something with no mass implementation to worry about and this would be it. I should also add a version number to the initialisation of the protocol to increase robustness, between versions. I'll call this one V 0.  John Bradley

Re: [Qemu-devel] [PATCH 05/13] vvfat: introduce offset_to_bootsector, offset_to_fat and offset_to_root_dir

2017-05-16 Thread Kevin Wolf
Am 15.05.2017 um 22:31 hat Hervé Poussineau geschrieben: > - offset_to_bootsector is the number of sectors up to FAT bootsector > - offset_to_fat is the number of sectors up to first File Allocation Table > - offset_to_root_dir is the number of sectors up to root directory sector Hm... These names

[Qemu-devel] [Bug 1691109] Re: qemu-kvm not working as nested inside ESX 6.0

2017-05-16 Thread fxpester
** Also affects: openstack-community Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1691109 Title: qemu-kvm not working as nested inside ESX 6.0 Status i

Re: [Qemu-devel] [PATCH] SMM: disable smram region if smm is disabled

2017-05-16 Thread Paolo Bonzini
On 16/05/2017 03:21, Anthony Xu wrote: > when smm is disabled, smram is not used, so disable it > > Signed-off-by: Anthony Xu What is the benefit? Paolo

[Qemu-devel] [Bug 1691109] [NEW] qemu-kvm not working as nested inside ESX 6.0

2017-05-16 Thread fxpester
Public bug reported: ESX 6.0 (virt bits exposed) - Ubuntu 16.04 + qemu-kvm 1:2.8+dfsg- 3ubuntu2~cloud0 - CirrOS launched by OpenStack (devstack master) VM will start with -machine = 'pc-i440fx-zesty' and will stuck in "booting from hard disk" to fix it you can manually change -machine to 'pc-i

  1   2   3   >