Luiz Capitulino writes:
> On Fri, 12 May 2017 08:30:36 +0200
> Markus Armbruster wrote:
>
>> Question for Luiz...
>>
>> Marc-André Lureau writes:
>>
>> [...]
>> > diff --git a/tests/check-qnum.c b/tests/check-qnum.c
>> > new file mode 100644
>> > index 00..d08d35e85a
>> > --- /dev/nul
Philippe Mathieu-Daudé writes:
> Hi Markus,
>
> On 05/11/2017 06:03 AM, Markus Armbruster wrote:
>> Philippe Mathieu-Daudé writes:
>>
>>> Ok I just understood Richard explanation, so this patch is WRONG and I
>>> need to get some real rest :(
>>
>> Ha! Get some sleep; we'll still be around in t
"Dr. David Alan Gilbert" writes:
> I notice this pair of patches doesn't seem to have gone anywhere.
> WHile it's labelled as a monitor fix, it's all QOM stuff, so I don't
> think it should be going via me.
It's somewhere between QOM and QemuOpts. Andreas, please have a look.
Feel free to ask m
Marc-André Lureau writes:
> In order to store integer values superior to INT64_MAX, add a u64
> internal representation.
>
> Signed-off-by: Marc-André Lureau
> ---
> include/qapi/qmp/qnum.h | 4
> qobject/qnum.c | 49 +++
> tests/check-
On 05/15/2017 11:28 AM, Jason Wang wrote:
On 2017年05月12日 09:41, Zhang Chen wrote:
In this patch, if vnet_hdr=on we change the send packet format from
struct {int size; const uint8_t buf[];} to {int size; int
vnet_hdr_len; const uint8_t buf[];}.
make other module(like colo-compare) know how
On 05/15/2017 11:31 AM, Jason Wang wrote:
On 2017年05月12日 09:41, Zhang Chen wrote:
We add the vnet_hdr option for filter-redirector, default is disable.
If you use virtio-net-pci net driver, please enable it.
We need a better commit log here to explain e.g why we need this option.
OK. I w
On 05/15/2017 12:02 PM, Jason Wang wrote:
On 2017年05月12日 09:41, Zhang Chen wrote:
Address Jason Wang's comments add vnet header length to SocketReadState.
Better to use "Suggested-by" instead of this :).
I got it~
We add a flag to dicide whether net_fill_rstate() to read
struct {int
On 05/15/2017 12:03 PM, Jason Wang wrote:
On 2017年05月12日 09:41, Zhang Chen wrote:
We add the vnet_hdr option for colo-compare, default is disable.
If you use virtio-net-pci net driver, please enable it.
You can use it for example:
-object
colo-compare,id=comp0,primary_in=compare0-0,secondar
On 05/15/2017 12:05 PM, Jason Wang wrote:
On 2017年05月12日 09:41, Zhang Chen wrote:
We can use this property flush and send packet with vnet_hdr_len.
Signed-off-by: Zhang Chen
Then I think it's not necessary to store vnet_hdr_len in SocketReadState?
Do you means we keep the patch 05/12 i
On 05/15/2017 12:11 PM, Jason Wang wrote:
On 2017年05月12日 09:41, Zhang Chen wrote:
COLO-Proxy just focus on packet payload, So we skip vnet header.
Signed-off-by: Zhang Chen
---
net/colo-compare.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/net/colo-c
On 05/15/2017 12:12 PM, Jason Wang wrote:
On 2017年05月12日 09:41, Zhang Chen wrote:
We add the vnet_hdr option for filter-rewriter, default is disable.
If you use virtio-net-pci net driver, please enable it.
You can use it for example:
-object filter-rewriter,id=rew0,netdev=hn0,queue=all,vnet_
On 2017年05月15日 14:56, Zhang Chen wrote:
On 05/15/2017 11:24 AM, Jason Wang wrote:
On 2017年05月14日 05:24, Philippe Mathieu-Daudé wrote:
Hi Zhang
On 05/11/2017 10:41 PM, Zhang Chen wrote:
Add vnet_hdr_len and using_vnet_hdr arguments in NetClientState
that make othermodule get real vnet_hd
On 05/15/2017 04:06 PM, Jason Wang wrote:
On 2017年05月15日 14:56, Zhang Chen wrote:
On 05/15/2017 11:24 AM, Jason Wang wrote:
On 2017年05月14日 05:24, Philippe Mathieu-Daudé wrote:
Hi Zhang
On 05/11/2017 10:41 PM, Zhang Chen wrote:
Add vnet_hdr_len and using_vnet_hdr arguments in NetClien
On 2017年05月15日 16:03, Zhang Chen wrote:
On 05/15/2017 12:05 PM, Jason Wang wrote:
On 2017年05月12日 09:41, Zhang Chen wrote:
We can use this property flush and send packet with vnet_hdr_len.
Signed-off-by: Zhang Chen
Then I think it's not necessary to store vnet_hdr_len in
SocketReadSta
Eduardo Habkost writes:
> cannot_instantiate_with_device_add_yet was introduced by commit
> efec3dd631d94160288392721a5f9c39e50fb2bc to replace no_user. It was
> supposed to be a temporary measure.
>
> When it was introduced, we had 54
> cannot_instantiate_with_device_add_yet=true lines in the co
For transitioning back to userspace after the interrupt.
Suggested-by: Richard Henderson
Signed-off-by: Nikunj A Dadhania
---
target/ppc/excp_helper.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index a6bcb47..9cb2123 100644
--- a/t
Stefano or Anthony, please review.
Eduardo Habkost writes:
> xen-backend can be plugged/unplugged dynamically when using the
> Xen accelerator, so keep the user_creatable flag on the device
> class and remove the FIXME comment.
>
> Cc: Juergen Gross ,
> Cc: Peter Maydell ,
> Cc: Thomas Huth
> C
The problem is that, address_space_get_iotlb_entry() shares a lot with
address_space_translate(). This patch tries to abstract the
shared elements.
Originally, this work is derived from discussion from VT-d passthrough
series discussions [1]. But for sure we can just see this series as a
standalon
It really only plays with the dispatchers, so the parameter list does
not need that complexity. This helps for readability at least.
Signed-off-by: Peter Xu
---
exec.c | 13 ++---
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/exec.c b/exec.c
index eac6085..1d76c63 100644
This is MMIO-specific tunes on the size. Let's skip it for non-MMIO
translations.
Signed-off-by: Peter Xu
---
exec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/exec.c b/exec.c
index 0adae94..32e5394 100644
--- a/exec.c
+++ b/exec.c
@@ -455,7 +455,7 @@ address_space_trans
It is not easy for people to know "what this parameter does" before
knowing "what is subpage". Let's use "is_mmio" to make it easier to
understand.
Signed-off-by: Peter Xu
---
exec.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/exec.c b/exec.c
index 1d76c63..0adae9
This function is an abstraction helper for address_space_translate() and
address_space_get_iotlb_entry(). It does the lookup of address into
memory region section, then do proper IOMMU translation if necessary.
With that, refactor the two existing functions a bit to use it.
Signed-off-by: Peter Xu
On Fri, May 12, 2017 at 03:25:08PM +1000, David Gibson wrote:
> On Thu, May 11, 2017 at 05:36:03PM +0800, Peter Xu wrote:
> > On Thu, May 11, 2017 at 11:56:38AM +1000, David Gibson wrote:
> > > On Wed, May 10, 2017 at 04:01:47PM +0800, Peter Xu wrote:
> > > > This function has an assumption that we
On 15/05/2017 10:50, Peter Xu wrote:
> It is not easy for people to know "what this parameter does" before
> knowing "what is subpage". Let's use "is_mmio" to make it easier to
> understand.
>
> Signed-off-by: Peter Xu
Maybe invert the direction and call it for_iotlb?
Paolo
> ---
> exec.c |
On 15/05/2017 10:50, Peter Xu wrote:
> This is MMIO-specific tunes on the size. Let's skip it for non-MMIO
> translations.
Can you explain this better? This is not specific to MMIO, in fact it's
for RAM...
Paolo
> Signed-off-by: Peter Xu
> ---
> exec.c | 2 +-
> 1 file changed, 1 insertion(
On Fri, 05/12 19:37, Max Reitz wrote:
> On 2017-05-11 16:32, Kevin Wolf wrote:
> > From: Fam Zheng
> >
> > Signed-off-by: Fam Zheng
> > Signed-off-by: Kevin Wolf
> > ---
> > qemu-img-cmds.hx | 36 ++--
> > 1 file changed, 18 insertions(+), 18 deletions(-)
> >
>
On Sat 13 May 2017 12:45:36 AM CEST, Kashyap Chamarthy wrote:
> Try to perform intermediate streaming (pull clusters from 'disk1.qcow2'
> into 'b.qcow2':
>
> (QEMU) block-stream device=#block832 base=disk1.qcow2
>
>
> Result
> --
>
> QEMU crashes with SIGSEGV:
I see the problem, I'll send
* Dmitry Fleytman (dmi...@daynix.com) wrote:
> Hello Dave,
Hi Dmitry,
Thanks for the reply.
> We are trying to reproduce this issue on our systems but with no luck so far…
Note our QE hit this with both a Win8.1 and a win2012r2 guest - although
the 2012r2 is reported to have recoverd after a f
Ping for comments, thanks.
On 05/11/2017 12:57 PM, Wei Wang wrote:
The current implementation may change the packet layout when
vnet_hdr needs an endianness swap. The layout change causes
one more iov to be added to the iov[] passed from the guest, which
is a barrier to making the TX queue size
On Mon, May 15, 2017 at 11:04:52AM +0200, Paolo Bonzini wrote:
>
>
> On 15/05/2017 10:50, Peter Xu wrote:
> > This is MMIO-specific tunes on the size. Let's skip it for non-MMIO
> > translations.
>
> Can you explain this better? This is not specific to MMIO, in fact it's
> for RAM...
Yes, I mi
On Fri, May 12, 2017 at 06:53:44PM +0200, Kevin Wolf wrote:
> Am 12.05.2017 um 15:42 hat Stefan Hajnoczi geschrieben:
> > On Thu, May 11, 2017 at 05:38:40PM -0400, Rik van Riel wrote:
> > > On Thu, 2017-05-11 at 14:17 -0400, Stefan Hajnoczi wrote:
> > > > On Wed, May 10, 2017 at 09:26:00PM +0530, P
Eduardo Habkost writes:
> commit 33cd52b5d7b9adfd009e95f07e6c64dd88ae2a31 unset
> cannot_instantiate_with_device_add_yet in TYPE_SYSBUS, making all
> sysbus devices appear on "-device help" and lack the "no-user"
> flag in "info qdm".
>
> To fix this, we can set user_creatable=false by default on
The code that tries to reopen a BlockDriverState in stream_start()
when the creation of a new block job fails crashes because it attempts
to dereference a pointer that is known to be NULL.
This is a regression introduced in a170a91fd3eab6155da39e740381867e,
likely because the code was copied from
Eric Blake wrote:
> On 05/11/2017 11:32 AM, Juan Quintela wrote:
>> Those two capabilities were added through the command line. Notice that
>> we just created them. This is just the boilerplate.
>>
>> Signed-off-by: Juan Quintela
>> Reviewed-by: Eric Blake
>>
>> --
>>
>> Make migrate_set_bl
12.05.2017 19:30, Paolo Bonzini wrote:
On 12/05/2017 17:57, Vladimir Sementsov-Ogievskiy wrote:
12.05.2017 18:46, Paolo Bonzini wrote:
On 12/05/2017 16:17, Vladimir Sementsov-Ogievskiy wrote:
nbd_wr_syncv is called either from coroutine or from client negotiation
code, when socket is in block
* Juan Quintela (quint...@redhat.com) wrote:
> Eric Blake wrote:
> > On 05/11/2017 11:32 AM, Juan Quintela wrote:
> >> Those two capabilities were added through the command line. Notice that
> >> we just created them. This is just the boilerplate.
> >>
> >> Signed-off-by: Juan Quintela
> >> Re
Eric Blake wrote:
> On 05/12/2017 05:55 AM, Juan Quintela wrote:
@@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool
blk,
}
if (has_inc && inc) {
+migrate_set_block_enabled(s, true);
migrate_set_block_shared(s,
ping...
What about this?
03.05.2017 15:25, Vladimir Sementsov-Ogievskiy wrote:
Hi all!
There is a new update of qcow2-bitmap series - v18.
web:
https://src.openvz.org/users/vsementsov/repos/qemu/browse?at=qcow2-bitmap-v18
git: https://src.openvz.org/scm/~vsementsov/qemu.git (tag qcow2-bitmap
curl_clean_state should only be called after all AIOCBs have been
completed. This is not so obvious for the call from curl_detach_aio_context,
so assert that.
Cc: qemu-sta...@nongnu.org
Reviewed-by: Jeff Cody
Signed-off-by: Paolo Bonzini
---
block/curl.c | 5 +
1 file changed, 5 insertions
Compared to v2, this silences checkpatch and correctly destroy the mutex on
exiting from curl_open with an error.
Paolo
Paolo Bonzini (7):
curl: strengthen assertion in curl_clean_state
curl: never invoke callbacks with s->mutex held
curl: avoid recursive locking of BDRVCURLState mutex
cu
The curl driver has a ugly hack where, if it cannot find an empty CURLState,
it just uses aio_poll to wait for one to be empty. This is probably
buggy when used together with dataplane, and the simplest way to fix it
is to use coroutines instead.
A more immediate effect of the bug however is that
If curl_easy_init fails, a CURLState is left with s->in_use = 1. Split
curl_init_state in two, so that we can distinguish the two failures and
call curl_clean_state if needed.
While at it, simplify curl_find_state, removing a dummy loop. The
aio_poll loop is moved to the sole caller that needs i
This is pretty simple. The bottom half goes away because, unlike
bdrv_aio_readv, coroutine-based read can return immediately without
yielding. However, for simplicity I kept the former bottom half
handler in a separate function.
Reviewed-by: Jeff Cody
Signed-off-by: Paolo Bonzini
---
block/cu
All curl callbacks go through curl_multi_do, and hence are called with
s->mutex held. Note that with comments, and make curl_read_cb drop the
lock before invoking the callback.
Likewise for curl_find_buf, where the callback can be invoked by the
caller.
Cc: qemu-sta...@nongnu.org
Reviewed-by: Je
On Fri, May 12, 2017 at 12:55:22PM +0200, Juan Quintela wrote:
> Peter Xu wrote:
> > On Thu, May 11, 2017 at 06:32:27PM +0200, Juan Quintela wrote:
>
> >> @@ -1214,9 +1218,6 @@ void qmp_migrate(const char *uri, bool has_blk, bool
> >> blk,
> >> MigrationParams params;
> >> const char *
This is in preparation for the conversion from bdrv_aio_readv to
bdrv_co_preadv, and it also requires changing some of the size_t values
to uint64_t. This was broken before for disks > 2TB, but now it would
break at 4GB.
Reviewed-by: Jeff Cody
Signed-off-by: Paolo Bonzini
---
block/curl.c | 44
Hi Block developers,
I would like to add a feature to Qemu to drain all traffic from a block so that
I can take external snaphosts without the risk to that in the middle of a write
operation. Its meant for cases where where QGA freeze/thaw is not available.
For me its enough to have this through
Instead, put the CURLAIOCB on a wait list and yield; curl_clean_state will
wake the corresponding coroutine.
Because of CURL's callback-based structure, we cannot easily convert
everything to CoMutex/CoQueue; keeping the QemuMutex is simpler. However,
CoQueue is a simple wrapper around a linked l
Am 15.05.2017 um 11:34 hat Alberto Garcia geschrieben:
> The code that tries to reopen a BlockDriverState in stream_start()
> when the creation of a new block job fails crashes because it attempts
> to dereference a pointer that is known to be NULL.
>
> This is a regression introduced in a170a91fd
On Fri, May 12, 2017 at 05:54:48PM +0200, Juan Quintela wrote:
> We have change in the previous patch to use migration capabilities for
> it. Notice that we continue using the old command line flags from
> migrate command from the time being. Remove the set_params method as
> now it is empty.
>
On Fri, May 12, 2017 at 05:54:49PM +0200, Juan Quintela wrote:
> Not used anymore after moving block migration to use capabilities.
>
> Signed-off-by: Juan Quintela
> Reviewed-by: Dr. David Alan Gilbert
> Reviewed-by: zhanghailiang
Reviewed-by: Peter Xu
On Fri, May 12, 2017 at 01:11:02PM +0100, Jean-Philippe Brucker wrote:
> Hi Yi,
>
> On 26/04/17 11:12, Liu, Yi L wrote:
> > From: "Liu, Yi L"
> >
> > This patch adds VFIO_IOMMU_TLB_INVALIDATE to propagate IOMMU TLB
> > invalidate request from guest to host.
> >
> > In the case of SVM virtualiza
It got lost in commit a8d16f9ca "qemu-img: Update documentation for -U".
Reported-by: Max Reitz
Signed-off-by: Fam Zheng
---
qemu-img-cmds.hx | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
index e5bc28f..469ec12 100644
--- a/qemu-img-
On Fri, 05/12 19:41, Max Reitz wrote:
> The fun is increased by the fact that the locking series has
> (inadvertently) removed the -B documentation from convert, so there is
> another conflict looming in the future...
Sorry about the mistake there..
I've posted a patch for that:
[Qemu-devel] [PA
* Juan Quintela (quint...@redhat.com) wrote:
> Eric Blake wrote:
> > On 05/12/2017 05:55 AM, Juan Quintela wrote:
> @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk,
> bool blk,
> }
>
> if (has_inc && inc) {
> +migrate_set_bloc
In case the frame timer doesn't run for a while due to the host being
busy skipped_uframes can become big enough that UFRAME_TIMER_NS *
skipped_uframes overflows. Which in turn throws off all subsequent
ehci frame timer calculations.
Reported-by: 李林 <8610...@163.com>
Signed-off-by: Gerd Hoffmann
On Mon, 05/15 12:02, Peter Lieven wrote:
> Hi Block developers,
>
> I would like to add a feature to Qemu to drain all traffic from a block so
> that
> I can take external snaphosts without the risk to that in the middle of a
> write
> operation. Its meant for cases where where QGA freeze/thaw i
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH v3 0/7] curl: locking cleanups/fixes, coroutine
conversion, remove aio_poll
Message-id: 20170515100059.15795-1-pbonz...@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
"Dr. David Alan Gilbert" wrote:
D> * Juan Quintela (quint...@redhat.com) wrote:
>> There are functions only used by migration code.
>
> That's only mostly true; see the current 'integrate colo frame with
> block replication and net compare' series (posted 22nd April).
> That adds colo_handle_shutd
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> Now one just has the interperter, and the other has the basic types.
>> Once there, add copyright boilerplate.
>>
>> Signed-off-by: Juan Quintela
>
> I think this is generally OK, but as discussed on IRC, I think
>
On Fri, May 12, 2017 at 03:58:43PM -0600, Alex Williamson wrote:
> On Wed, 26 Apr 2017 18:12:04 +0800
> "Liu, Yi L" wrote:
>
> > From: "Liu, Yi L"
> >
> > This patch adds VFIO_IOMMU_TLB_INVALIDATE to propagate IOMMU TLB
> > invalidate request from guest to host.
> >
> > In the case of SVM virt
On Fri, May 12, 2017 at 03:59:14PM -0600, Alex Williamson wrote:
> On Wed, 26 Apr 2017 18:11:58 +0800
> "Liu, Yi L" wrote:
>
> > From: Jacob Pan
> >
> > Virtual IOMMU was proposed to support Shared Virtual Memory (SVM) use
> > case in the guest:
> > https://lists.gnu.org/archive/html/qemu-devel
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> This files don't use any function from migration.h, so drop it.
>>
>> Signed-off-by: Juan Quintela
>> ---
>> block/qed.c | 1 -
>> hw/i386/pc_q35.c| 1 -
>> hw/virtio/vhost-user.c | 1 -
>> hw
Am 15.05.2017 um 12:50 schrieb Fam Zheng:
On Mon, 05/15 12:02, Peter Lieven wrote:
Hi Block developers,
I would like to add a feature to Qemu to drain all traffic from a block so that
I can take external snaphosts without the risk to that in the middle of a write
operation. Its meant for cases
QEMU should exit if the user explicitely asked for kernel-irqchip support
and "xics-kvm" initialization fails.
The changelog of commit 34f2af3d3edf ("spapr: Clean up misuse of qdev_init()
in xics-kvm creation") reads:
While there, improve the error message when we can't satisfy an
explici
The spapr_ics_create() function handles errors in a rather convoluted
way, with two local Error * variables. Moreover, failing to parent the
ICS object to the machine should be considered as a bug but it is
currently ignored.
This patch addresses both issues.
Signed-off-by: Greg Kurz
---
hw/ppc
Recent work on XICS broke migration of older machine types. The target
fails with:
qemu-system-ppc64: Unknown savevm section or instance 'icp/server' 1
qemu-system-ppc64: load of migration failed: Invalid argument
This happens because the current code no longer pre-allocates ICP objects
at machin
Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under
sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This
is an improvement since we no longer allocate ICP objects that will
never be used. But it has the side-effect of breaking migration of
older machine types from o
This function only does hypercall and RTAS-call registration, and thus
never returns an error. This patch adapt the prototype to reflect that.
Signed-off-by: Greg Kurz
---
hw/intc/xics_spapr.c |3 +--
hw/ppc/spapr.c|2 +-
include/hw/ppc/xics.h |2 +-
3 files changed, 3 inser
The xics_system_init() function passes its errp argument to xics_kvm_init().
If the call fails and the user requested in-kernel irqchip, it then ends up
passing a NULL Error * to error_reportf_err() and the error message is
silently dropped.
Passing an errp argument is generally wrong, unless you
While here we introduce a single error path to avoid code duplication.
Signed-off-by: Greg Kurz
---
hw/ppc/spapr_cpu_core.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/hw/ppc/spapr_cpu_core.c b/hw/ppc/spapr_cpu_core.c
index 4389ef4c2aef..63d160f7e010 10
On 05/15/2017 01:39 PM, Greg Kurz wrote:
> QEMU should exit if the user explicitely asked for kernel-irqchip support
> and "xics-kvm" initialization fails.
>
> The changelog of commit 34f2af3d3edf ("spapr: Clean up misuse of qdev_init()
> in xics-kvm creation") reads:
>
> While there, improve
On 05/15/2017 01:39 PM, Greg Kurz wrote:
> The xics_system_init() function passes its errp argument to xics_kvm_init().
> If the call fails and the user requested in-kernel irqchip, it then ends up
> passing a NULL Error * to error_reportf_err() and the error message is
> silently dropped.
>
> Pas
Hi Julien,
On 05/05/2017 09:57 AM, Julien Duponchelle wrote:
Otherwise for image like CISCO IOSv you got a lot
of warning on the console preventing you to use
the VM because it's slow down the machine.
This fix:
https://bugs.launchpad.net/qemu/+bug/1673722
Signed-off-by: Julien Duponchelle
-
Hi Subbaraya,
+if (value & TIMER_MODE) {
+qemu_log_mask(LOG_UNIMP, "64-bit mode not supported\n");
No need of trailing '\n', be more specific, something like:
qemu_log_mask(LOG_UNIMP, TYPE_MSF2_TIMER ": 64-bit mode not
supported");
I mistaken with error_report(), qem
On Mon, 05/15 13:26, Peter Lieven wrote:
> Am 15.05.2017 um 12:50 schrieb Fam Zheng:
> > On Mon, 05/15 12:02, Peter Lieven wrote:
> > > Hi Block developers,
> > >
> > > I would like to add a feature to Qemu to drain all traffic from a block
> > > so that
> > > I can take external snaphosts withou
Am 15.05.2017 um 13:53 schrieb Fam Zheng:
On Mon, 05/15 13:26, Peter Lieven wrote:
Am 15.05.2017 um 12:50 schrieb Fam Zheng:
On Mon, 05/15 12:02, Peter Lieven wrote:
Hi Block developers,
I would like to add a feature to Qemu to drain all traffic from a block so that
I can take external snapho
On 05/15/2017 01:39 PM, Greg Kurz wrote:
> The spapr_ics_create() function handles errors in a rather convoluted
> way, with two local Error * variables. Moreover, failing to parent the
> ICS object to the machine should be considered as a bug but it is
> currently ignored.
I am not sure what shou
On 05/15/2017 01:39 PM, Greg Kurz wrote:
> While here we introduce a single error path to avoid code duplication.
>
> Signed-off-by: Greg Kurz
> ---
> hw/ppc/spapr_cpu_core.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/hw/ppc/spapr_cpu_core.c b/hw
On Mon, 15 May 2017 13:59:33 +0200
Cédric Le Goater wrote:
> On 05/15/2017 01:39 PM, Greg Kurz wrote:
> > The spapr_ics_create() function handles errors in a rather convoluted
> > way, with two local Error * variables. Moreover, failing to parent the
> > ICS object to the machine should be consid
On 05/15/2017 01:39 PM, Greg Kurz wrote:
> This function only does hypercall and RTAS-call registration, and thus
> never returns an error. This patch adapt the prototype to reflect that.
>
> Signed-off-by: Greg Kurz
Reviewed-by: Cédric Le Goater
> ---
> hw/intc/xics_spapr.c |3 +--
> hw
On 14/05/17 11:12, Liu, Yi L wrote:
> On Fri, May 12, 2017 at 01:11:02PM +0100, Jean-Philippe Brucker wrote:
>> Hi Yi,
>>
>> On 26/04/17 11:12, Liu, Yi L wrote:
>>> From: "Liu, Yi L"
>>>
>>> This patch adds VFIO_IOMMU_TLB_INVALIDATE to propagate IOMMU TLB
>>> invalidate request from guest to host.
* Eric Blake (ebl...@redhat.com) wrote:
> On 05/03/2017 05:42 AM, Dr. David Alan Gilbert (git) wrote:
> > From: "Dr. David Alan Gilbert"
> >
> > Many users now prefer to use drive_mirror over NBD as an
> > alternative to the older migrate -b option; drive_mirror is
> > more complex to setup but g
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine
types
Message-id: 149484833874.20089.4164801378197848306.st...@bahia.lan
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/ba
On Mon, May 15, 2017 at 11:03:49AM +0200, Paolo Bonzini wrote:
>
>
> On 15/05/2017 10:50, Peter Xu wrote:
> > It is not easy for people to know "what this parameter does" before
> > knowing "what is subpage". Let's use "is_mmio" to make it easier to
> > understand.
> >
> > Signed-off-by: Peter X
On Mon, 15 May 2017 14:02:34 +0200
Cédric Le Goater wrote:
> On 05/15/2017 01:39 PM, Greg Kurz wrote:
> > While here we introduce a single error path to avoid code duplication.
> >
> > Signed-off-by: Greg Kurz
> > ---
> > hw/ppc/spapr_cpu_core.c | 16
> > 1 file changed, 8 i
On Mon, 15 May 2017 05:13:34 -0700 (PDT)
no-re...@patchew.org wrote:
> Hi,
>
> This series seems to have some coding style problems. See output below for
> more information:
>
> Subject: [Qemu-devel] [PATCH 0/6] spapr/xics: fix migration of older machine
> types
> Message-id: 149484833874.20089
On 05/15/2017 01:40 PM, Greg Kurz wrote:
> Commit 5bc8d26de20c ("spapr: allocate the ICPState object from under
> sPAPRCPUCore") moved ICP objects from the machine to CPU cores. This
> is an improvement since we no longer allocate ICP objects that will
> never be used. But it has the side-effect of
On Mon, 05/15 13:58, Peter Lieven wrote:
> Am 15.05.2017 um 13:53 schrieb Fam Zheng:
> > On Mon, 05/15 13:26, Peter Lieven wrote:
> > > Am 15.05.2017 um 12:50 schrieb Fam Zheng:
> > > > On Mon, 05/15 12:02, Peter Lieven wrote:
> > > > > Hi Block developers,
> > > > >
> > > > > I would like to add
Am 15.05.2017 um 14:28 schrieb Fam Zheng:
On Mon, 05/15 13:58, Peter Lieven wrote:
Am 15.05.2017 um 13:53 schrieb Fam Zheng:
On Mon, 05/15 13:26, Peter Lieven wrote:
Am 15.05.2017 um 12:50 schrieb Fam Zheng:
On Mon, 05/15 12:02, Peter Lieven wrote:
Hi Block developers,
I would like to add a
On Mon, May 15, 2017 at 12:34:24PM +0300, Alberto Garcia wrote:
> The code that tries to reopen a BlockDriverState in stream_start()
> when the creation of a new block job fails crashes because it attempts
> to dereference a pointer that is known to be NULL.
>
> This is a regression introduced in
This adds a small test for the image streaming error path for failing
block_job_create(), which would have found the null pointer dereference
in commit a170a91f.
Signed-off-by: Kevin Wolf
---
tests/qemu-iotests/030 | 4
tests/qemu-iotests/030.out | 4 ++--
2 files changed, 6 insertions(
On 2017/5/15 19:04, Juan Quintela wrote:
"Dr. David Alan Gilbert" wrote:
D> * Juan Quintela (quint...@redhat.com) wrote:
There are functions only used by migration code.
That's only mostly true; see the current 'integrate colo frame with
block replication and net compare' series (posted 22nd A
On Mon 15 May 2017 02:39:40 PM CEST, Kevin Wolf wrote:
> This adds a small test for the image streaming error path for failing
> block_job_create(), which would have found the null pointer dereference
> in commit a170a91f.
>
> Signed-off-by: Kevin Wolf
> ---
> tests/qemu-iotests/030 | 4
On Mon, 05/15 14:32, Peter Lieven wrote:
> Am 15.05.2017 um 14:28 schrieb Fam Zheng:
> > On Mon, 05/15 13:58, Peter Lieven wrote:
> > > Am 15.05.2017 um 13:53 schrieb Fam Zheng:
> > > > On Mon, 05/15 13:26, Peter Lieven wrote:
> > > > > Am 15.05.2017 um 12:50 schrieb Fam Zheng:
> > > > > > On Mon,
On Thu, May 04, 2017 at 09:14:58PM -0500, Eric Blake wrote:
> As mentioned in my 'qcow2 zero-cluster tweaks' cover letter
> https://lists.gnu.org/archive/html/qemu-devel/2017-05/msg00722.html
> I hit a case where we were not fully optimizing a write-zeroes
> operation when we have a backing file th
On Thu, May 04, 2017 at 09:15:00PM -0500, Eric Blake wrote:
> When we have a BSD with unallocated clusters, but asking the status
s/BSD/BDS/
signature.asc
Description: PGP signature
On Wed, May 10, 2017 at 10:07:58PM +0300, Michael S. Tsirkin wrote:
> The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb:
>
> Merge remote-tracking branch 'armbru/tags/pull-qapi-2017-05-04-v3' into
> staging (2017-05-09 15:49:14 -0400)
>
> are available in the git repo
Am 15.05.2017 um 14:52 schrieb Fam Zheng:
On Mon, 05/15 14:32, Peter Lieven wrote:
Am 15.05.2017 um 14:28 schrieb Fam Zheng:
On Mon, 05/15 13:58, Peter Lieven wrote:
Am 15.05.2017 um 13:53 schrieb Fam Zheng:
On Mon, 05/15 13:26, Peter Lieven wrote:
Am 15.05.2017 um 12:50 schrieb Fam Zheng:
Am 15.05.2017 um 14:52 hat Fam Zheng geschrieben:
> On Mon, 05/15 14:32, Peter Lieven wrote:
> > Am 15.05.2017 um 14:28 schrieb Fam Zheng:
> > > On Mon, 05/15 13:58, Peter Lieven wrote:
> > > > Am 15.05.2017 um 13:53 schrieb Fam Zheng:
> > > > > On Mon, 05/15 13:26, Peter Lieven wrote:
> > > > > >
1 - 100 of 302 matches
Mail list logo
