Re: [Qemu-devel] [PATCH v4 5/6] replication: Implement block replication for shared disk case

2017-05-12 Thread Hailiang Zhang
On 2017/5/12 3:15, Stefan Hajnoczi wrote: On Wed, Apr 12, 2017 at 10:05:20PM +0800, zhanghailiang wrote: @@ -612,6 +644,16 @@ static void replication_do_checkpoint(ReplicationState *rs, Error **errp) error_propagate(errp, local_err); break; } +

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread Julia Lawall
On Fri, 12 May 2017, Philippe Mathieu-Daudé wrote: > Hi Julia, > > Sorry I planed to send you another mail but sent this mail to QEMU list first. > > > I don't think I have seen earlier versions of this script. Are you > > proposing it to be added to the kernel? If so, it should be put in an >

Re: [Qemu-devel] [PATCHv3 2/4] pseries: Move CPU compatibility property to machine

2017-05-12 Thread David Gibson
On Thu, May 04, 2017 at 08:50:47PM +0200, Greg Kurz wrote: > On Thu, 04 May 2017 19:09:11 +0200 > Andrea Bolognani wrote: > > > On Thu, 2017-04-27 at 17:28 +1000, David Gibson wrote: > > > @@ -2480,6 +2480,10 @@ static void spapr_machine_initfn(Object *obj) > > >  

Re: [Qemu-devel] [Qemu-block] [PATCH v4 0/6] COLO block replication supports shared disk case

2017-05-12 Thread Hailiang Zhang
On 2017/5/12 3:17, Stefan Hajnoczi wrote: On Wed, Apr 12, 2017 at 10:05:15PM +0800, zhanghailiang wrote: COLO block replication doesn't support the shared disk case, Here we try to implement it and this is the 4th version. Please review and any commits are welcomed. Cc: Dr. David Alan Gilbert

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

2017-05-12 Thread Miltiadis Hatzimihail
I ve tried the same today using a 32-bit Guest OS and the illegal instruction this time is fstps %(ecx) Is it a similar case to the movss one? (the previous Guest I was using was 64 bit). Also, I had to start QEMU using the following command line options: qemu -cpu host,-sse2 because one my pr

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-12 Thread Markus Armbruster
Luiz, there's a lone question for you further down. Search for your name. Marc-André Lureau writes: > We would like to use a same QObject type to represent numbers, whether > they are int, uint, or floats. getters will allow some compatibility > between the various types if the number fits othe

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 0/4] Clean up compatibility mode handling

2017-05-12 Thread David Gibson
On Thu, May 04, 2017 at 09:22:37PM +0200, Greg Kurz wrote: > On Thu, 04 May 2017 16:32:59 +0200 > Andrea Bolognani wrote: > > > On Thu, 2017-04-27 at 17:28 +1000, David Gibson wrote: > > > This is a rebased and revised version of my patches revising CPU > > > compatiblity mode handling on ppc, la

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread SF Markus Elfring via Qemu-devel
> Even for 6 functions, I would suggest to write out the function names in > the pattern matching code rather than using regular expressions. If the > names are explicit, then Coccinelle can do some filtering, either based on > an index made with idutils or glimpse (see the coccinelle scripts > di

Re: [Qemu-devel] [Qemu-block] [PATCH 02/18] block: access quiesce_counter with atomic ops

2017-05-12 Thread Alberto Garcia
On Thu 11 May 2017 04:41:52 PM CEST, Paolo Bonzini wrote: > Reviewed-by: Stefan Hajnoczi > Signed-off-by: Paolo Bonzini > --- Reviewed-by: Alberto Garcia Berto

Re: [Qemu-devel] [PATCHv6 1/5] pseries: Stubs for HPT resizing

2017-05-12 Thread Laurent Vivier
On 12/05/2017 07:04, David Gibson wrote: > This introduces stub implementations of the H_RESIZE_HPT_PREPARE and > H_RESIZE_HPT_COMMIT hypercalls which we hope to add in a PAPR > extension to allow run time resizing of a guest's hash page table. It > also adds a new machine property for controlling

Re: [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

2017-05-12 Thread Pradeep Jagadeesh
On 5/11/2017 9:50 AM, Greg Kurz wrote: On Wed, 10 May 2017 04:41:22 -0400 Pradeep Jagadeesh wrote: This patch factor out the duplicate qmp throttle interface code that was present in both block and fsdev device files. There isn't any duplicated code at this stage since you have changed the

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-12 Thread Xiao Guangrong
On 05/11/2017 08:24 PM, Paolo Bonzini wrote: On 11/05/2017 14:07, Zhoujian (jay) wrote: -* Scan sptes if dirty logging has been stopped, dropping those -* which can be collapsed into a single large-page spte. Later -* page faults will create the large-page sptes. +

[Qemu-devel] errors which can't backing storage for guest RAM with -mem-path

2017-05-12 Thread heavybird
Hi all I found it can't backup the guest RAM when i run simple ram test code with errors which can't backing storage for guest RAM with integratorcp, the commander is: qemu-system-arm -M integratorcp -m 1 -semihosting -nographic -mem-path mem.txt -kernel build/emu_ram_test.elf i wrote the pa

[Qemu-devel] [Bug 1690322] [NEW] errors which can't backing storage for guest RAM with -mem-path

2017-05-12 Thread js yu
Public bug reported: I found it can't backup the guest RAM when i run simple ram test code with errors which can't backing storage for guest RAM with integratorcp, the commander is: qemu-system-arm -M integratorcp -m 1 -semihosting -nographic -mem-path mem.txt -kernel build/emu_ram_test.elf i w

Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 0/4] Clean up compatibility mode handling

2017-05-12 Thread Andrea Bolognani
On Fri, 2017-05-12 at 17:33 +1000, David Gibson wrote: > > The goal of this series is indeed to switch from raw to architected but I > > agree that it shouldn't affect existing machine types. This probably calls > > for some compat prop. >  > So, I have mixed feelings about this. >  > 1. Yes, the s

[Qemu-devel] [PATCH] hw/net/rocker/rocker: Convert pci device .init() to .realize()

2017-05-12 Thread Mao Zhongyi
Convert pci device .init() to .realize(). Also improve -device rocker error reporting. Because when -device rocker fails, it first reports a specific error, then a generic one, like this: $ x86_64-softmmu/qemu-system-x86_64 -device rocker,name=qemu-rocker rocker: name too long; please shor

Re: [Qemu-devel] [PATCHv6 3/5] pseries: Enable HPT resizing for 2.10

2017-05-12 Thread Laurent Vivier
On 12/05/2017 07:04, David Gibson wrote: > We've now implemented a PAPR extensions which allows PAPR guests (i.e. > "pseries" machine type) to resize their hash page table during runtime. > > However, that extension is only enabled if explicitly chosen on the > command line. This patch enables it

Re: [Qemu-devel] [PATCH v2] tests: Add [+-]feature and feature=on|off test cases

2017-05-12 Thread Igor Mammedov
On Mon, 8 May 2017 15:32:05 -0300 Eduardo Habkost wrote: > Add test code to ensure features are enabled/disabled correctly in the > command-line. The test case use the "feature-words" and > "filtered-features" properties to check if the features were > enabled/disabled correctly. > > Signed-off

[Qemu-devel] [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-12 Thread Wei Wang
This patch series implements vhost-pci, which is a point-to-point based inter-vm communication solution. The QEMU side implementation includes the vhost-user extension, vhost-pci device emulation and management, and inter-VM notification. v1->v2 changes: 1) inter-VM notification support; 2) vhost-

[Qemu-devel] [PATCH v2 02/16] vl: add the vhost-pci-slave command line option

2017-05-12 Thread Wei Wang
An example of the QEMU command to create a vhost-pci-slave is: -chardev socket,id=slave1,server,wait=off,path=${PATH_SLAVE1} -vhost-pci-slave socket,chardev=slave1 The master can connect to the slave as usual: -chardev socket,id=sock2,path=${PATH_SLAVE1} -netdev type=vhost-user,id=net2,chardev=soc

[Qemu-devel] [PATCH v2 03/16] vhost-pci-slave: create a vhost-user slave to support vhost-pci

2017-05-12 Thread Wei Wang
Signed-off-by: Wei Wang --- hw/virtio/Makefile.objs | 1 + hw/virtio/vhost-pci-slave.c | 597 include/hw/virtio/vhost-pci-slave.h | 61 include/hw/virtio/vhost-user.h | 13 + 4 files changed, 672 insertions(+) create mode 100

[Qemu-devel] [PATCH v2 01/16] vhost-user: share the vhost-user protocol related structures

2017-05-12 Thread Wei Wang
Put the vhost-user protocol related data structures to vhost-user.h, so that they can be used in other implementations (e.g. a slave implementation). Signed-off-by: Wei Wang --- hw/virtio/vhost-user.c | 89 +--- include/hw/virtio/vhost-user.h | 93

[Qemu-devel] [PATCH v2 06/16] virtio: add inter-vm notification support

2017-05-12 Thread Wei Wang
This patch enables the assign of an already allocated eventfd to a notifier. In this case, QEMU creates a new eventfd for the notifier only when the notifier's fd equals to -1. Otherwise, it means that the notifier has been assigned a vaild fd. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c

[Qemu-devel] [PATCH v2 07/16] vhost-user: send device id to the slave

2017-05-12 Thread Wei Wang
Send virtio device id to the slave to indicate the device type. Signed-off-by: Wei Wang --- hw/net/vhost_net.c| 1 + hw/virtio/vhost-user.c| 20 include/hw/virtio/vhost.h | 1 + 3 files changed, 22 insertions(+) diff --git a/hw/net/vhost_net.c b/hw/net/vhost_n

[Qemu-devel] [PATCH v2 04/16] vhost-pci-net: add vhost-pci-net

2017-05-12 Thread Wei Wang
Add the vhost-pci-net device emulation. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c | 248 + hw/virtio/vhost-pci-slave.c| 5 + include/hw/virtio/vhost-pci-net.h | 34 include/standard-headers/linux/vh

[Qemu-devel] [PATCH v2 11/16] vhost-user: add asynchronous read for the vhost-user master

2017-05-12 Thread Wei Wang
Enable the vhost-user master to asynchronously receive messages from the slave. The vhost_user_asyn_read and vhost_user_can_read stub functions are defined for platforms that do not support the use of virtio. Signed-off-by: Wei Wang --- hw/virtio/Makefile.objs| 6 +++--- hw/virtio/vhost

[Qemu-devel] [PATCH v2 05/16] vhost-pci-net-pci: add vhost-pci-net-pci

2017-05-12 Thread Wei Wang
Signed-off-by: Wei Wang --- hw/net/Makefile.objs| 2 +- hw/net/vhost-pci-net.c | 6 hw/virtio/virtio-pci.c | 54 + hw/virtio/virtio-pci.h | 14 include/hw/pci/pci.h

[Qemu-devel] [PATCH v2 08/16] vhost-user: send guest physical address of virtqueues to the slave

2017-05-12 Thread Wei Wang
In the vhost-pci case, the slave needs the master side guest physical address, rather than the qemu virtual address. Signed-off-by: Wei Wang --- hw/virtio/vhost.c | 63 --- include/hw/virtio/vhost.h | 2 ++ 2 files changed, 45 insertions(+), 2

[Qemu-devel] [PATCH v2 14/16] vhost-pci-slave: add support to delete a vhost-pci device

2017-05-12 Thread Wei Wang
Signed-off-by: Wei Wang --- hw/virtio/vhost-pci-slave.c | 41 + 1 file changed, 41 insertions(+) diff --git a/hw/virtio/vhost-pci-slave.c b/hw/virtio/vhost-pci-slave.c index a7d3c8d..cde122c 100644 --- a/hw/virtio/vhost-pci-slave.c +++ b/hw/virtio/vhost-pc

[Qemu-devel] [PATCH v2 09/16] vhost-user: send VHOST_USER_SET_VHOST_PCI_START/STOP

2017-05-12 Thread Wei Wang
The master requests the slave to create or destroy a vhost-pci device. Signed-off-by: Wei Wang --- hw/net/vhost_net.c| 36 hw/virtio/vhost-user.c| 17 + include/hw/virtio/vhost-backend.h | 2 ++ include/net/vhost_n

[Qemu-devel] [PATCH v2 10/16] vhost-pci-net: send the negotiated feature bits to the master

2017-05-12 Thread Wei Wang
The slave device actively sends the negotiated feature bits to the master. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c | 18 ++ hw/virtio/vhost-pci-slave.c | 22 ++ include/hw/virtio/vhost-pci-slave.h | 2 ++ 3 files changed, 42 in

[Qemu-devel] [PATCH v2 15/16] vhost-pci-net: tell the driver that it is ready to send packets

2017-05-12 Thread Wei Wang
If the remote device on the other side doesn't need to be reset, set bit 0 of the device status register to allow the driver to send out the packets. Signed-off-by: Wei Wang --- hw/net/vhost-pci-net.c | 20 1 file changed, 20 insertions(+) diff --git a/hw/net/vhost-pci-net.

[Qemu-devel] [PATCH v2 16/16] vl: enable vhost-pci-slave

2017-05-12 Thread Wei Wang
Enable the use of vhost-pci. The init and cleanup stub functions are added for the platforms that do not support the use of virtio. Signed-off-by: Wei Wang --- hw/virtio/vhost-stub.c | 11 +++ vl.c | 24 2 files changed, 35 insertions(+) diff -

[Qemu-devel] [PATCH v2 12/16] vhost-user: handling VHOST_USER_SET_FEATURES

2017-05-12 Thread Wei Wang
If the featuer bits sent by the slave are not equal to the ones that were sent by the master, perform a reset of the master device. Signed-off-by: Wei Wang --- hw/net/vhost_net.c | 2 ++ hw/virtio/vhost-user.c | 24 hw/virtio/virtio-pci.c | 20

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-12 Thread Hailiang Zhang
On 2017/5/12 16:09, Xiao Guangrong wrote: On 05/11/2017 08:24 PM, Paolo Bonzini wrote: On 11/05/2017 14:07, Zhoujian (jay) wrote: -* Scan sptes if dirty logging has been stopped, dropping those -* which can be collapsed into a single large-page spte. Later -* page fau

Re: [Qemu-devel] [PATCH v2 11/16] vhost-user: add asynchronous read for the vhost-user master

2017-05-12 Thread Wei Wang
On 05/12/2017 04:35 PM, Wei Wang wrote: Enable the vhost-user master to asynchronously receive messages from the slave. The vhost_user_asyn_read and vhost_user_can_read stub functions are defined for platforms that do not support the use of virtio. Signed-off-by: Wei Wang After the secondary

[Qemu-devel] [PATCH v2 13/16] vhost-pci-slave: add "reset_virtio"

2017-05-12 Thread Wei Wang
After the vhost-pci-net device being hotplugged to the VM, the device uses the features bits that have been negotiated with the remote virtio device to negotiate with the driver. If the driver accepts a subset of the feature bits, it implies that the vhost-pci-net can only suppoort a subset of the

Re: [Qemu-devel] [PATCH v2 00/16] Vhost-pci for inter-VM communication

2017-05-12 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1494578148-102868-1-git-send-email-wei.w.w...@intel.com Subject: [Qemu-devel] [PATCH v2 00/16] Vhost-pci for inter

Re: [Qemu-devel] [PATCH v8 2/3] utils: provide size_to_str()

2017-05-12 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > Moving the algorithm from print_type_size() into size_to_str() so that > other component can also leverage it. With that, refactor > print_type_size(). > > The assert() in that logic is removed though, since even UINT64_MAX > would not overflow. > > Signed-

Re: [Qemu-devel] [PATCH v4] qemu-doc: Update to use the new way of attaching USB devices

2017-05-12 Thread Gerd Hoffmann
On Mo, 2017-05-08 at 17:13 +0200, Thomas Huth wrote: > The preferred way of adding USB devices is via "-device" and > "device_add" nowadays, so let's start to get rid of "-usbdevice" > and "usb_add" in the documentation. While we're at it, also > add the new USB devices there which have been added

[Qemu-devel] [PATCH 1/4] scsi: make default command timeout user-settable

2017-05-12 Thread Hannes Reinecke
Per default any SCSI commands are sent with an infinite timeout, which essentially disables any command abort mechanism on the host and causes the guest to stall. This patch adds a new option 'timeout' for scsi-generic and scsi-disk which allows the user to set the timeout value to something sensib

[Qemu-devel] [RFC PATCH 0/4] Virtio command timeouts (qemu part)

2017-05-12 Thread Hannes Reinecke
Hi all, we've run into a really awkward customer situation where the guest would hang forever due to an SG_IO ioctl on the host not returning. Looking into it we found that qemu will submit direct I/O requests with an _infinite_ timeout (well, actually UINT_MAX, which due to a kernel bug gets tran

Re: [Qemu-devel] [PATCH 1/2] tests: check-qom-proplist: add checks for cmdline-created objects

2017-05-12 Thread Dr. David Alan Gilbert
I notice this pair of patches doesn't seem to have gone anywhere. WHile it's labelled as a monitor fix, it's all QOM stuff, so I don't think it should be going via me. Dave * Michael Roth (mdr...@linux.vnet.ibm.com) wrote: > check-qom-proplist originally added tests for verifying that > object-cr

[Qemu-devel] [PATCH 3/4] scsi: per-request timeouts

2017-05-12 Thread Hannes Reinecke
Add a 'timeout' value per request to allow to specify individual per-request timeouts. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-bus.c | 1 + hw/scsi/scsi-disk.c| 15 +++ hw/scsi/scsi-generic.c | 12 include/hw/scsi/scsi.h | 1 + 4 files changed, 21 inser

[Qemu-devel] [PATCH 2/4] scsi: use host default timeouts for SCSI commands

2017-05-12 Thread Hannes Reinecke
Instead of disabling command aborts by setting the command timeout to infinity we should be setting it to '0' per default, allowing the host to fall back to its default values. Signed-off-by: Hannes Reinecke --- hw/scsi/scsi-disk.c| 3 +-- hw/scsi/scsi-generic.c | 2 +- 2 files changed, 2 in

[Qemu-devel] [PATCH 4/4] virtio: implement VIRTIO_SCSI_F_TIMEOUT feature

2017-05-12 Thread Hannes Reinecke
Implement a handler for the VIRTIO_SCSI_F_TIMEOUT feature, which allows to pass in the assigned command timeout in seconds or minutes. This allows to specify a timeout up to 3 hours. Signed-off-by: Hannes Reinecke --- hw/scsi/virtio-scsi.c| 16 include/st

[Qemu-devel] [PATCH] xhci: relax link check

2017-05-12 Thread Ladi Prosek
The strict td link limit added by commit "05f43d4 xhci: limit the number of link trbs we are willing to process" causes problems with Windows guests. Let's raise the limit. This change is analogous to: commit ab6b1105a2259c7072905887f71caa850ce63190 Author: Gerd Hoffmann Date: Tue Mar 7

Re: [Qemu-devel] [PATCH 0/1] target/arm: add data cache invalidation cp15 instruction to cortex-r5

2017-05-12 Thread Luc MICHEL
ping The patchwork link: https://patchwork.ozlabs.org/patch/756408/ Thanks, -- Luc On 04/28/2017 02:56 PM, Luc MICHEL wrote: > This patch adds the cp15, CRn=15, opc1=0, CRm=5, opc2=0 coprocessor > instruction > to the cortex-r5. As stated in the TRM, this instruction invalidates > all the > da

Re: [Qemu-devel] [PATCH] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-12 Thread Gerd Hoffmann
On Do, 2017-05-04 at 09:41 +0200, Thomas Huth wrote: > When starting QEMU with the legacy USB serial device like this: > > qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio > > it currently aborts since the vendorid property does not exist > anymore (it has been removed by commit f29783

[Qemu-devel] [PATCH v2] blockdev: Print a warning for legacy drive options that belong to -device

2017-05-12 Thread Thomas Huth
We likely do not want to carry these legacy -drive options along forever. Let's emit a deprecation warning for the -drive options that have a replacement with the -device option, so that the (hopefully few) remaining users are aware of this and can adapt their scripts / behaviour accordingly. Sign

Re: [Qemu-devel] [RFC PATCH 5/8] VFIO: Add new IOTCL for PASID Table bind propagation

2017-05-12 Thread Liu, Yi L
On Wed, Apr 26, 2017 at 06:12:02PM +0800, Liu, Yi L wrote: > From: "Liu, Yi L" Hi Alex, In this patchset, I'm trying to add two new IOCTL cmd for Shared Virtual Memory virtualization. One for binding guest PASID Table and one for iommu tlb invalidation from guest. ARM has similar requirement on

Re: [Qemu-devel] [RFC PATCH 6/8] VFIO: do pasid table binding

2017-05-12 Thread Liu, Yi L
On Tue, May 09, 2017 at 03:55:20PM +0800, Xiao Guangrong wrote: > > > On 04/26/2017 06:12 PM, Liu, Yi L wrote: > >From: "Liu, Yi L" > > > >This patch adds IOCTL processing in vfio_iommu_type1 for > >VFIO_IOMMU_SVM_BIND_TASK. Binds the PASID table bind by > >calling iommu_ops->bind_pasid_table to

Re: [Qemu-devel] [PATCH 2/3] migration: Remove use of old MigrationParams

2017-05-12 Thread Juan Quintela
Peter Xu wrote: > On Thu, May 11, 2017 at 06:32:27PM +0200, Juan Quintela wrote: >> @@ -1214,9 +1218,6 @@ void qmp_migrate(const char *uri, bool has_blk, bool >> blk, >> MigrationParams params; >> const char *p; >> >> -params.blk = has_blk && blk; >> -params.shared = has_inc

Re: [Qemu-devel] [RFC PATCH v3 1/5] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

2017-05-12 Thread SF Markus Elfring via Qemu-devel
> +print " candidate", "IS" if is_optimizable else "is NOT", > "optimizable" I suggest to increase your software development attention also for another detail here. This information display is using the channel “sys.stdout”. How do you think about to use the function “sys.stderr.write”

Re: [Qemu-devel] [RFC v1 6/9] virtio-crypto: rework virtio_crypto_handle_request

2017-05-12 Thread Halil Pasic
On 05/08/2017 01:38 PM, Gonglei wrote: > According to the new spec, we should use different > requst structure to store the data request based > on whether VIRTIO_CRYPTO_F_MUX_MODE feature bit is > negotiated or not. > > In this patch, we havn't supported stateless mode > yet. The device reporte

Re: [Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

2017-05-12 Thread Maxime Coquelin
On 05/11/2017 07:33 PM, Michael S. Tsirkin wrote: On Thu, May 11, 2017 at 02:32:43PM +0200, Maxime Coquelin wrote: Vhost-kernel backend need to receive IOTLB entries for rings information early, but vhost-user need the same information earlier, before VHOST_USER_SET_VRING_ADDR is sent. Weird

Re: [Qemu-devel] [RFC v1 8/9] virtio-crypto: add host feature bits support

2017-05-12 Thread Cornelia Huck
On Fri, 12 May 2017 00:55:23 + "Gonglei (Arei)" wrote: > > > > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > > Sent: Thursday, May 11, 2017 11:05 PM > > Subject: Re: [RFC v1 8/9] virtio-crypto: add host feature bits support > > > > On Mon, 8 May 2017 19:38:23 +0800 > > Gonglei wro

Re: [Qemu-devel] [PATCH 1/1] s390x/css: catch section mismatch on load

2017-05-12 Thread Halil Pasic
On 05/11/2017 01:02 PM, Cornelia Huck wrote: > On Wed, 10 May 2017 17:12:09 +0200 > Halil Pasic wrote: > >> Prior to the virtio-ccw-2.7 machine (and commit 2a79eb1a), our virtio >> devices residing under the virtual-css bus do not have qdev_path based >> migration stream identifiers (because th

[Qemu-devel] [PATCH V4 9/9] migration: postcopy_blocktime documentation

2017-05-12 Thread Alexey Perevalov
Signed-off-by: Alexey Perevalov --- docs/migration.txt | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/migration.txt b/docs/migration.txt index 1b940a8..d0f5a6d 100644 --- a/docs/migration.txt +++ b/docs/migration.txt @@ -402,6 +402,16 @@ will now cause the transition from pr

[Qemu-devel] [PATCH V4 5/9] migration: introduce postcopy-blocktime capability

2017-05-12 Thread Alexey Perevalov
Right now it could be used on destination side to enable vCPU blocktime calculation for postcopy live migration. vCPU blocktime - it's time since vCPU thread was put into interruptible sleep, till memory page was copied and thread awake. Signed-off-by: Alexey Perevalov --- include/migration/migr

[Qemu-devel] [PATCH V4 6/9] migration: add postcopy vcpu blocktime context into MigrationIncomingState

2017-05-12 Thread Alexey Perevalov
This patch adds request to kernel space for UFFD_FEATURE_THREAD_ID, in case when this feature is provided by kernel. PostcopyBlocktimeContext is incapsulated inside postcopy-ram.c, due to it's postcopy only feature. Also it defines PostcopyBlocktimeContext's instance live time. Information from Po

[Qemu-devel] [PATCH V4 8/9] migration: add postcopy total blocktime into query-migrate

2017-05-12 Thread Alexey Perevalov
Postcopy total blocktime is available on destination side only. But query-migrate was possible only for source. This patch adds ability to call query-migrate on destination. To distinguish src/dst, state of the MigrationState is using, query-migrate prepares MigrationInfo for source machine only in

[Qemu-devel] [PATCH V4 7/9] migration: calculate vCPU blocktime on dst side

2017-05-12 Thread Alexey Perevalov
This patch provides blocktime calculation per vCPU, as a summary and as a overlapped value for all vCPUs. This approach was suggested by Peter Xu, as an improvements of previous approch where QEMU kept tree with faulted page address and cpus bitmask in it. Now QEMU is keeping array with faulted pa

[Qemu-devel] [PATCH V4 3/9] migration: fix hardcoded function name in error report

2017-05-12 Thread Alexey Perevalov
Signed-off-by: Alexey Perevalov --- migration/postcopy-ram.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/postcopy-ram.c b/migration/postcopy-ram.c index fbccc53..b6eccaf 100644 --- a/migration/postcopy-ram.c +++ b/migration/postcopy-ram.c @@ -67,7 +67,7 @@ static

[Qemu-devel] [PATCH V4 2/9] migration: pass ptr to MigrationIncomingState into migration ufd_version_check & postcopy_ram_supported_by_host

2017-05-12 Thread Alexey Perevalov
That tiny refactoring is necessary to be able to set UFFD_FEATURE_THREAD_ID while requesting features, and then to create downtime context in case when kernel supports it. Signed-off-by: Alexey Perevalov --- migration/migration.c| 2 +- migration/postcopy-ram.c | 10 +- migration/po

[Qemu-devel] [PATCH V4 1/9] userfault: add pid into uffd_msg & update UFFD_FEATURE_*

2017-05-12 Thread Alexey Perevalov
This commit duplicates header of "userfaultfd: provide pid in userfault msg" into linux kernel. Signed-off-by: Alexey Perevalov --- linux-headers/linux/userfaultfd.h | 5 + 1 file changed, 5 insertions(+) diff --git a/linux-headers/linux/userfaultfd.h b/linux-headers/linux/userfaultfd.h in

[Qemu-devel] [PATCH V4 0/9] calculate blocktime for postcopy live migration

2017-05-12 Thread Alexey Perevalov
The rationale for that idea is following: vCPU could suspend during postcopy live migration until faulted page is not copied into kernel. Downtime on source side it's a value - time interval since source turn vCPU off, till destination start runnig vCPU. But that value was proper value for precopy

[Qemu-devel] [PATCH V4 4/9] migration: split ufd_version_check onto receive/request features part

2017-05-12 Thread Alexey Perevalov
This modification is necessary for userfault fd features which are required to be requested from userspace. UFFD_FEATURE_THREAD_ID is a one of such "on demand" feature, which will be introduced in the next patch. QEMU need to use separate userfault file descriptor, due to userfault context has int

[Qemu-devel] [PULL 06/10] egl-helpers: add missing error check

2017-05-12 Thread Gerd Hoffmann
Code didn't check for qemu_egl_init_dpy_mesa() failures, add it. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170505104101.30589-5-kra...@redhat.com --- ui/egl-helpers.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/ui/egl-helpers.c

[Qemu-devel] [PULL 02/10] ui: input-linux: Add absolute event support

2017-05-12 Thread Gerd Hoffmann
From: Philippe Voinov This patch adds support for absolute pointer events to the input-linux subsystem. This support was omitted from the original input-linux patch, however most of the code required for it is already in place. Support for absolute events is especially useful for guests with vga

[Qemu-devel] [PULL 07/10] egl: explicitly ask for core context

2017-05-12 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann Message-id: 20170505104101.30589-6-kra...@redhat.com --- ui/egl-context.c | 7 --- ui/egl-helpers.c | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ui/egl-context.c b/ui/egl-context.c index 3a02b68d1a..2161969abe 100644 --- a/ui/egl-context.c

[Qemu-devel] [PULL 00/10] ui patch queue

2017-05-12 Thread Gerd Hoffmann
-2017-05-04-v3' into staging (2017-05-09 15:49:14 -0400) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-ui-20170512-1 for you to fetch changes up to 7c9209e7bfb8c09ab5a4cadaa84928d146874a05: vnc: replace hweight_long() with ctpopl() (2017-05-12 12:3

[Qemu-devel] [PULL 03/10] virtio-gpu: move virtio_gpu_gl_block

2017-05-12 Thread Gerd Hoffmann
Move to virtio-gpu-3d.c where all the other virgl code lives too. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Message-id: 20170505104101.30589-2-kra...@redhat.com --- include/hw/virtio/virtio-gpu.h | 1 + hw/display/virtio-gpu-3d.c | 16 hw/display/vir

[Qemu-devel] [PULL 04/10] egl-helpers: drop support for gles and debug logging

2017-05-12 Thread Gerd Hoffmann
Leftover from the early opengl days. Unused now, so delete the dead code. Signed-off-by: Gerd Hoffmann Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Marc-André Lureau Message-id: 20170505104101.30589-3-kra...@redhat.com --- include/ui/egl-helpers.h | 2 +- ui/egl-helpers.c | 52 +++

[Qemu-devel] [PULL 10/10] vnc: replace hweight_long() with ctpopl()

2017-05-12 Thread Gerd Hoffmann
From: Cédric Le Goater ctpopl() has a better implementation than hweight_long() and ui/vnc.c being the last user of hweight_long(), we can simply remove it. Signed-off-by: Cédric Le Goater Reviewed-by: Peter Maydell Message-id: 1489415605-13105-1-git-send-email-...@kaod.org Signed-off-by: Gerd

[Qemu-devel] [PULL 09/10] vnc: simple clean up

2017-05-12 Thread Gerd Hoffmann
From: Wei Qi It is unnecessary to assign 'packed_bytes' to 'estimated_bytes', because 'estimated_bytes' unused after assignment. Signed-off-by: Wei Qi Reviewed-by: Sahid Orentino Ferdjaoui Signed-off-by: Gerd Hoffmann --- ui/vnc-enc-zrle.c | 1 - 1 file changed, 1 deletion(-) diff --git a/

[Qemu-devel] [PULL 05/10] egl-helpers: fix display init for x11

2017-05-12 Thread Gerd Hoffmann
When running on gtk we need X11 platform not mesa platform. Create separate functions for mesa and x11 so we can keep the egl #ifdef mess local to egl-helpers.c Fixes: 0ea1523fb6703aa0dcd65e66b59e96fec028e60a Signed-off-by: Gerd Hoffmann Message-id: 20170505104101.30589-4-kra...@redhat.com --- i

[Qemu-devel] [PULL 01/10] ui: Support non-zero minimum values for absolute input axes

2017-05-12 Thread Gerd Hoffmann
From: Philippe Voinov This patch refactors ui/input.c to support absolute axis minimum values other than 0. All dependent calls to qemu_input_queue_abs have been updated to explicitly supply 0 as the axis minimum value. Signed-off-by: Philippe Voinov Message-id: 20170505133952.29885-1-philippev

[Qemu-devel] [PULL 08/10] opengl: add egl-headless display

2017-05-12 Thread Gerd Hoffmann
Add egl-headless user interface. It doesn't provide a real user interface, it only provides opengl support using drm render nodes. It will copy back the bits rendered by the guest using virgl back to a DisplaySurface and kick the usual display update code paths, so spice and vnc and screendump can

[Qemu-devel] [Bug 1689003] Re: USB passthrough should not fail if SET CONFIGURATION fails

2017-05-12 Thread Manfred Härtel
The attached simple program, compiled as a library, loaded by LD_PRELOAD before starting QEMU, avoids the problem by faking success of libusb_set_configuration(), as a workaround. ** Attachment added: "usbnosetconf.c" https://bugs.launchpad.net/qemu/+bug/1689003/+attachment/4875574/+files/usbn

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

2017-05-12 Thread Paolo Bonzini
On 12/05/2017 09:26, Miltiadis Hatzimihail wrote: > I ve tried the same today using a 32-bit Guest OS and the illegal > instruction this time is > > fstps %(ecx) > > Is it a similar case to the movss one? (the previous Guest I was using > was 64 bit). Yes, it is. Paolo > Also, I had to start

Re: [Qemu-devel] [RFC PATCH 7/8] VFIO: Add new IOCTL for IOMMU TLB invalidate propagation

2017-05-12 Thread Jean-Philippe Brucker
Hi Yi, On 26/04/17 11:12, Liu, Yi L wrote: > From: "Liu, Yi L" > > This patch adds VFIO_IOMMU_TLB_INVALIDATE to propagate IOMMU TLB > invalidate request from guest to host. > > In the case of SVM virtualization on VT-d, host IOMMU driver has > no knowledge of caching structure updates unless th

Re: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode

2017-05-12 Thread Paolo Bonzini
On 12/05/2017 01:55, Xu, Anthony wrote: > Hi Paolo, > > In KVM mode, seems A20 is ignored. > Do you see any potential issue here? No; recent processors don't have A20 at all. Paolo > > Anthony > > >> -Original Message- >> From: Kevin O'Connor [mailto:ke...@koconnor.net] >> Sent: T

[Qemu-devel] [PULL 5/6] xhci: relax link check

2017-05-12 Thread Gerd Hoffmann
From: Ladi Prosek The strict td link limit added by commit "05f43d4 xhci: limit the number of link trbs we are willing to process" causes problems with Windows guests. Let's raise the limit. This change is analogous to: commit ab6b1105a2259c7072905887f71caa850ce63190 Author: Gerd Hoffmann

[Qemu-devel] [PULL 3/6] xhci: fix logging

2017-05-12 Thread Gerd Hoffmann
From: Ladi Prosek slotid and epid were deleted from XHCITransfer in commit d6fcb29. Also deleting one unused forward declaration. Signed-off-by: Ladi Prosek Message-id: 20170511125314.24549-2-lpro...@redhat.com Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-xhci.c | 7 ++- 1 file changed, 2

[Qemu-devel] [PULL 0/6] usb patch queue

2017-05-12 Thread Gerd Hoffmann
9 15:49:14 -0400) are available in the git repository at: git://git.kraxel.org/qemu tags/pull-usb-20170512-1 for you to fetch changes up to aa612b364ecbe1dc034efcabb04526f24e56c145: hw/usb/dev-serial: Do not try to set vendorid or productid properties (2017-05-12 12:3

[Qemu-devel] [PULL 2/6] usb-redir: fix stack overflow in usbredir_log_data

2017-05-12 Thread Gerd Hoffmann
Don't reinvent a broken wheel, just use the hexdump function we have. Impact: low, broken code doesn't run unless you have debug logging enabled. Reported-by: 李强 Signed-off-by: Gerd Hoffmann Message-id: 20170509110128.27261-1-kra...@redhat.com --- hw/usb/redirect.c | 13 + 1 file c

[Qemu-devel] [PULL 4/6] usb-hub: clear PORT_STAT_SUSPEND on wakeup

2017-05-12 Thread Gerd Hoffmann
From: Ladi Prosek The spec says: Suspend: (PORT_SUSPEND) This field indicates whether or not the device on this port is suspended. Setting this field causes the device to suspend by not propagating bus traffic downstream. This field may be reset by a request or by resume signaling from t

[Qemu-devel] [PULL 6/6] hw/usb/dev-serial: Do not try to set vendorid or productid properties

2017-05-12 Thread Gerd Hoffmann
From: Thomas Huth When starting QEMU with the legacy USB serial device like this: qemu-system-x86_64 -usbdevice serial:vendorid=0x1234:stdio it currently aborts since the vendorid property does not exist anymore (it has been removed by commit f29783f72ea77dfbd7ea0c9): Unexpected error in obj

[Qemu-devel] [PULL 1/6] qemu-doc: Update to use the new way of attaching USB devices

2017-05-12 Thread Gerd Hoffmann
From: Thomas Huth The preferred way of adding USB devices is via "-device" and "device_add" nowadays, so let's start to get rid of "-usbdevice" and "usb_add" in the documentation. While we're at it, also add the new USB devices there which have been added to QEMU during the last years, and get ri

Re: [Qemu-devel] ehci: fix "int" overflow for calculation ehci->last_run_ns

2017-05-12 Thread Mark Cave-Ayland
On 10/05/17 09:57, 李林 wrote: > If we experience large delays between echi timer callbacks (i.e. because > other periodic handlers have taken a lot of time to complete) we get a lot of > skipped frames which then delay ehci timer callback. > Then we will calculation ehci->last_run_ns,but skip

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-12 Thread Luiz Capitulino
On Fri, 12 May 2017 08:30:36 +0200 Markus Armbruster wrote: > Question for Luiz... > > Marc-André Lureau writes: > > [...] > > diff --git a/tests/check-qnum.c b/tests/check-qnum.c > > new file mode 100644 > > index 00..d08d35e85a > > --- /dev/null > > +++ b/tests/check-qnum.c > > @@ -0

[Qemu-devel] [PATCH 03/16] linux-user: fix ssetmask() system call

2017-05-12 Thread Miloš Stojanović
Fix the ssetmask() system call by removing the invocation of sigorset(). The ssetmask() system call should replace the old signal mask with the new and return the old mask. It shouldn't combine the old and the new mask with sigorset(). Fetching the old mask for sigorset() is also no longer needed.

[Qemu-devel] [PATCH 11/16] [RFC] linux-user: add target_sigdelset() and target_sigorset()

2017-05-12 Thread Miloš Stojanović
Add two inline functions that work with the signal set of the target. target_sigdelset() removes a signal from target_sigset_t. target_sigorset() creates a union of two target_sigset_t. These functions will be used for introducing support for tracking the target signal set. Functions for emptying

[Qemu-devel] [PATCH 14/16] [RFC] linux-user: add functionality for tracking target signal mask

2017-05-12 Thread Miloš Stojanović
Add support for tracking the larger target signal mask in system calls sigprocmask()/rt_sigprocmask(), sigsuspend()/rt_sigsuspend(), sgetmask()/ssetmask() and in functions do_sigreturn(), do_rt_sigreturn(), handle_pending_signal(), process_pending_signals(). Add a new function do_target_sigprocmask

[Qemu-devel] [PATCH 12/16] [RFC] linux-user: fix sigismember() check

2017-05-12 Thread Miloš Stojanović
Fix copying between the host and target signal sets for the case when the target set is larger than the host set. sigismember() returns 1 if the specified signal number is a member of the specified signal set, but it can also return -1 if an error occurs (e.g. an out of range signal number is spec

[Qemu-devel] [PATCH 08/16] linux-user: fix inconsistent spaces in print_siginfo() output

2017-05-12 Thread Miloš Stojanović
This patch improves the consistentcy of the output from print_siginfo() by removing spaces around the equal sign of si_pid, si_uid, si_timer1, si_timer2, si_band, si_fd, si_addr, si_status and si_sigval. This way they match si_signo and ci_code. Host strace was used as a reference for this chage.

[Qemu-devel] [PATCH 05/16] linux-user: fix argument type declaration of rt_sigqueinfo() syscall

2017-05-12 Thread Miloš Stojanović
Change the type of the first argument of rt_sigqueinfo() from int to pid_t in the syscall declaration to match specifications of the system call. Proper spacing is added to satisfy checkpatch.pl. Signed-off-by: Miloš Stojanović --- linux-user/syscall.c | 2 +- 1 file changed, 1 insertion(+), 1

[Qemu-devel] [PATCH 02/16] linux-user: add tkill(), tgkill() and rt_sigqueueinfo() strace

2017-05-12 Thread Miloš Stojanović
Improve strace support for syscall tkill(), tgkill() and rt_sigqueueinfo() by implementing print functions that match arguments types of the system calls and add them to the corresponding starce.list entry. tkill: Prior to this commit, typical strace output used to look like this: 4886 tkill(4886,

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

2017-05-12 Thread Luiz Capitulino
On Fri, 12 May 2017 09:37:50 +0200 Markus Armbruster wrote: > Luiz, there's a lone question for you further down. Search for your > name. I could not a question, can you paste it here? > > Marc-André Lureau writes: > > > We would like to use a same QObject type to represent numbers, whether

  1   2   3   >