Re: [Qemu-devel] [PATCH] blockdev: Print a warning for legacy drive options that belong to -device

On 11.05.2017 08:45, Markus Armbruster wrote: > Thomas Huth writes: > >> On 10.05.2017 17:55, Paolo Bonzini wrote: >>> >>> >>> On 10/05/2017 17:50, Thomas Huth wrote: We likely do not want to carry these legacy -drive options along forever. Let's emit a deprecation warning for the -driv

[Qemu-devel] Guest SIGILL when different IO is implemented

I am trying to develop a simple PCI device and I am setting up 3 BARs. The last BAR is a DDR and I ve tried 2 different implementations: one with memory_region_init_io and one with memory_region_init_ram. I ve got a small program that declares a buffer and does float operations in the following fa

Re: [Qemu-devel] [PATCH v2 1/3] visitor: Add 'supported_qtypes' parameter to visit_start_alternate()

Eduardo Habkost writes: > On Wed, May 10, 2017 at 03:16:56PM +0200, Markus Armbruster wrote: >> Eduardo Habkost writes: >> >> > This will allow visitors to make decisions based on the supported qtypes >> > of a given alternate type. The new parameter can replace the old >> > 'promote_int' argum

Re: [Qemu-devel] [PATCH] hw/i386: Deprecate the machines pc-0.10 to pc-0.15

Paolo Bonzini writes: > On 10/05/2017 16:47, Thomas Huth wrote: >>> So while we can delete pc-0.12, we can't delete associated features needed >>> by pc-0.12, without complicating RHEL's ability to create its back-compat >>> machine types. Downstream would have to un-delete the features. >> >> So

Re: [Qemu-devel] [PATCH] blockdev: Print a warning for legacy drive options that belong to -device

On 10.05.2017 17:50, Thomas Huth wrote: > We likely do not want to carry these legacy -drive options along forever. > Let's emit a deprecation warning for the -drive options that have a > replacement with the -device option, so that the (hopefully few) remaining > users are aware of this and can ad

Re: [Qemu-devel] [PATCH RESEND V3 5/6] migration: calculate downtime on dst side

On Thu, May 11, 2017 at 12:56:55PM +0800, Peter Xu wrote: > On Wed, May 10, 2017 at 04:58:59PM +0100, Daniel P. Berrange wrote: > > On Wed, May 10, 2017 at 06:46:50PM +0300, Alexey wrote: > > > On Tue, May 09, 2017 at 10:44:34AM +0100, Daniel P. Berrange wrote: > > > > On Tue, May 09, 2017 at 10:40

Re: [Qemu-devel] [PATCH] hw/i386: Deprecate the machines pc-0.10 to pc-0.15

"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Thomas Huth writes: >> >> > On 10.05.2017 11:08, Daniel P. Berrange wrote: >> >> On Wed, May 10, 2017 at 08:48:53AM +0200, Thomas Huth wrote: >> [...] >> >> Also unless we're going to get more serious about aut

Re: [Qemu-devel] [PATCH] hw/i386: Deprecate the machines pc-0.10 to pc-0.15

On 11.05.2017 09:06, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 10/05/2017 16:47, Thomas Huth wrote: So while we can delete pc-0.12, we can't delete associated features needed by pc-0.12, without complicating RHEL's ability to create its back-compat machine types. Dow

Re: [Qemu-devel] [PATCH] hw/i386: Deprecate the machines pc-0.10 to pc-0.15

"Dr. David Alan Gilbert" writes: > * Daniel P. Berrange (berra...@redhat.com) wrote: >> On Wed, May 10, 2017 at 03:51:25PM +0100, Dr. David Alan Gilbert wrote: >> > * Daniel P. Berrange (berra...@redhat.com) wrote: >> > > If we deprecate in this release (~Aug/Sep 2017), and kill in the next >> >

Re: [Qemu-devel] [PATCH] maintainers: Add myself as linux-user reviewer

On Wed, May 10, 2017 at 05:39:50PM +0200, Laurent Vivier wrote: > I volunteer to review linux-user patches. > Adding myself will help to not miss some of them. > > Signed-off-by: Laurent Vivier Acked-by: Riku Voipio > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a

Re: [Qemu-devel] [PATCH 0/2] cg3/tcx: make display updates thread safe

On Mi, 2017-05-10 at 21:52 +0100, Mark Cave-Ayland wrote: > Now the previous fixes/cleanups have been applied, it is a fairly trivial > exercise to make cg3/tcx display updates thread safe. > > Gerd, do you want to take these patches via your vga queue? Can do that, I have some more pending patch

Re: [Qemu-devel] [PATCH v2 3/3] kvm: irqchip: skip update msi when disabled

On 11/05/2017 04:56, Peter Xu wrote: >> @@ -3510,12 +3511,16 @@ static void kvm_update_msi_routes_all(void *private, >> bool global, >> int cnt = 0; >> MSIRouteEntry *entry; >> MSIMessage msg; >> +PCIDevice *dev; >> + >> /* TODO: explicit route update */ >> QLIST_FOR

Re: [Qemu-devel] [PATCH v4 3/4] qmp: refactor duplicate code

On Wed, 10 May 2017 04:41:22 -0400 Pradeep Jagadeesh wrote: > This patch factor out the duplicate qmp throttle interface code > that was present in both block and fsdev device files. > There isn't any duplicated code at this stage since you have changed the patch ordering. Also, this patch is

Re: [Qemu-devel] [PATCH] blockdev: use drained_begin/end for qmp_block_resize

On 10/05/2017 19:39, John Snow wrote: > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1447551 > > If one tries to issue a block_resize while a guest is busy > accessing the disk, it is possible that qemu may deadlock > when invoking aio_poll from both the main loop and the iothread. > > Re

Re: [Qemu-devel] [PATCH v2 3/3] kvm: irqchip: skip update msi when disabled

On Thu, May 11, 2017 at 09:48:52AM +0200, Paolo Bonzini wrote: > > > On 11/05/2017 04:56, Peter Xu wrote: > >> @@ -3510,12 +3511,16 @@ static void kvm_update_msi_routes_all(void > >> *private, bool global, > >> int cnt = 0; > >> MSIRouteEntry *entry; > >> MSIMessage msg; > >> +

Re: [Qemu-devel] [PATCH v2 2/3] Check the return value of fcntl in qemu_set_cloexec

On 09/05/2017 21:04, Stefano Stabellini wrote: > Assert that the return value is not an error. This issue was found by > Coverity. > > CID: 1374831 > > Signed-off-by: Stefano Stabellini > CC: gr...@kaod.org > CC: pbonz...@redhat.com > CC: Eric Blake Queued, thanks. Paolo > --- > util/osli

Re: [Qemu-devel] [PATCH RESEND V3 5/6] migration: calculate downtime on dst side

* Alexey (a.pereva...@samsung.com) wrote: > On Tue, May 09, 2017 at 08:01:01PM +0100, Dr. David Alan Gilbert wrote: > > * Alexey (a.pereva...@samsung.com) wrote: > > > On Tue, May 09, 2017 at 10:40:34AM +0100, Dr. David Alan Gilbert wrote: > > > > * Peter Xu (pet...@redhat.com) wrote: > > > > > On

Re: [Qemu-devel] [PATCH v3 10/12] intel_iommu: support passthrough (PT)

On 2017年05月10日 16:01, Peter Xu wrote: Hardware support for VT-d device passthrough. Although current Linux can live with iommu=pt even without this, but this is faster than when using software passthrough. Signed-off-by: Peter Xu --- hw/i386/intel_iommu.c | 210

Re: [Qemu-devel] [PATCH v3 12/12] vhost: iommu: cache static mapping if there is

On 2017年05月10日 16:01, Peter Xu wrote: This patch pre-heat vhost iotlb cache when passthrough mode enabled. Sometimes, even if user specified iommu_platform for vhost devices, IOMMU might still be disabled. One case is passthrough mode in VT-d implementation. We can detect this by observing iom

Re: [Qemu-devel] [PATCH 5/8] target/m68k: optimize bcd_flags() using extract op

Le 10/05/2017 à 22:05, Philippe Mathieu-Daudé a écrit : > Applied using Coccinelle script. > > Signed-off-by: Philippe Mathieu-Daudé > --- > target/m68k/translate.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/target/m68k/translate.c b/target/m68k/translate.c > ind

Re: [Qemu-devel] [Qemu-ppc] [PATCH 7/8] target/ppc: optimize various functions using extract op

On 11/05/2017 02:41, David Gibson wrote: > On Wed, May 10, 2017 at 05:05:34PM -0300, Philippe Mathieu-Daudé wrote: >> Applied using Coccinelle script. >> >> Signed-off-by: Philippe Mathieu-Daudé > > Reviewed-by: David Gibson David, look at Nikunj's comments: only the two first changes are corre

Re: [Qemu-devel] [PATCH v3 10/12] intel_iommu: support passthrough (PT)

On Thu, May 11, 2017 at 04:31:40PM +0800, Jason Wang wrote: > > > On 2017年05月10日 16:01, Peter Xu wrote: > >Hardware support for VT-d device passthrough. Although current Linux can > >live with iommu=pt even without this, but this is faster than when using > >software passthrough. > > > >Signed-of

Re: [Qemu-devel] [PATCH v3 12/12] vhost: iommu: cache static mapping if there is

On Thu, May 11, 2017 at 04:35:21PM +0800, Jason Wang wrote: > > > On 2017年05月10日 16:01, Peter Xu wrote: > >This patch pre-heat vhost iotlb cache when passthrough mode enabled. > > > >Sometimes, even if user specified iommu_platform for vhost devices, > >IOMMU might still be disabled. One case is

Re: [Qemu-devel] [RFC PATCH v2] coccinelle: add a script to optimize tcg op using tcg_gen_extract()

Philippe Mathieu-Daudé writes: > Ok I just understood Richard explanation, so this patch is WRONG and I > need to get some real rest :( Ha! Get some sleep; we'll still be around in the morning ;) > On 05/10/2017 08:52 PM, Philippe Mathieu-Daudé wrote: >> Apply this script using: >> >> $ docker

Re: [Qemu-devel] [PATCH] blockdev: use drained_begin/end for qmp_block_resize

Am 10.05.2017 um 19:39 hat John Snow geschrieben: > Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1447551 > > If one tries to issue a block_resize while a guest is busy > accessing the disk, it is possible that qemu may deadlock > when invoking aio_poll from both the main loop and the iothrea

Re: [Qemu-devel] [PATCH] hw/i386: Deprecate the machines pc-0.10 to pc-0.15

On Wed, May 10, 2017 at 06:15:39PM +0200, Paolo Bonzini wrote: > > > On 10/05/2017 16:47, Thomas Huth wrote: > >> So while we can delete pc-0.12, we can't delete associated features needed > >> by pc-0.12, without complicating RHEL's ability to create its back-compat > >> machine types. Downstrea

Re: [Qemu-devel] [PATCH RFC] docs: document support lifetime and deprecation policy

On Wed, May 10, 2017 at 12:39:02PM -0400, Stefan Hajnoczi wrote: > On Wed, May 10, 2017 at 12:15:35PM +0100, Daniel P. Berrange wrote: > > The deprecation of features in QEMU is totally adhoc currently, > > with no way for the user to get a list of what is deprecated > > in each release. There is a

Re: [Qemu-devel] [PATCH v3 04/12] memory: fix address_space_get_iotlb_entry()

On Thu, May 11, 2017 at 11:56:38AM +1000, David Gibson wrote: > On Wed, May 10, 2017 at 04:01:47PM +0800, Peter Xu wrote: > > This function has an assumption that we will definitely call translate() > > once (or say, the addr will be located inside one IOMMU memory region), > > otherwise an empty I

Re: [Qemu-devel] [PATCH v2] qemu-img: Check for backing image if specified during create

Am 09.05.2017 um 20:09 hat John Snow geschrieben: > Or, rather, force the open of a backing image if one was specified > for creation. Using a similar -unsafe option as rebase, allow qemu-img > to ignore the backing file validation if possible. > > It may not always be possible, as in the existing

Re: [Qemu-devel] [PATCH v17 23/23] tests: Add POSIX image locking test case 182

Am 02.05.2017 um 18:35 hat Fam Zheng geschrieben: > Signed-off-by: Fam Zheng > --- > tests/qemu-iotests/182 | 73 > ++ > tests/qemu-iotests/182.out | 8 + > tests/qemu-iotests/group | 1 + > 3 files changed, 82 insertions(+) > create mode

[Qemu-devel] [PATCH V2] Revert "hw/pci: disable pci-bridge's shpc by default"

This reverts commit dc0ae767700c156894e36fab89a745a2dc4173de. Disabling the shpc controller has an undesired side effect. The PCI bridge remains with no attached devices at boot time, and the guest operating systems do not allocate any resources for it, leaving the bridge unusable. Note that the b

Re: [Qemu-devel] [PATCH V2] Revert "hw/pci: disable pci-bridge's shpc by default"

- Original Message - > From: "Marcel Apfelbaum" > To: qemu-devel@nongnu.org > Cc: mar...@redhat.com, m...@redhat.com, pbonz...@redhat.com, > ler...@redhat.com, dgilb...@redhat.com > Sent: Thursday, May 11, 2017 1:25:29 PM > Subject: [Qemu-devel] [PATCH V2] Revert "hw/pci: disable pci-br

Re: [Qemu-devel] [PATCH V2] Revert "hw/pci: disable pci-bridge's shpc by default"

On 11/05/2017 12:25, Marcel Apfelbaum wrote: > This reverts commit dc0ae767700c156894e36fab89a745a2dc4173de. > > Disabling the shpc controller has an undesired side effect. > The PCI bridge remains with no attached devices at boot time, > and the guest operating systems do not allocate any resou

Re: [Qemu-devel] [PATCH 1/1] s390x/css: catch section mismatch on load

On Wed, 10 May 2017 17:12:09 +0200 Halil Pasic wrote: > Prior to the virtio-ccw-2.7 machine (and commit 2a79eb1a), our virtio > devices residing under the virtual-css bus do not have qdev_path based > migration stream identifiers (because their qdev_path is NULL). The ids > are instead generated

Re: [Qemu-devel] [RFC PATCH v1 0/9] BQL and Replay Lock changes

> From: Alex Bennée [mailto:alex.ben...@linaro.org] > Pavel Dovgalyuk writes: > > > Guest Windows XP doesn't boot with these patches. > > I'm guessing there is hardware attached to that machine? Only mouse, keyboard and hdd. > Did the asserts catch double locking? No, they didn't. The emula

Re: [Qemu-devel] [PATCH v17 23/23] tests: Add POSIX image locking test case 182

On Thu, 05/11 12:08, Kevin Wolf wrote: > Am 02.05.2017 um 18:35 hat Fam Zheng geschrieben: > > Signed-off-by: Fam Zheng > > --- > > tests/qemu-iotests/182 | 73 > > ++ > > tests/qemu-iotests/182.out | 8 + > > tests/qemu-iotests/group | 1 +

[Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode

Ignore env->a20_mask when running in system management mode. Reported-by: Anthony Xu Signed-off-by: Paolo Bonzini --- target/i386/arch_memory_mapping.c | 18 + target/i386/cpu.h | 9 + target/i386/helper.c | 42 +-

[Qemu-devel] [PATCH] configure: Remove -lxencall for Xen detection

QEMU does not depends on libxencall, it was added because it was a missing link dependency of libxendevicemodel, but now the later should be built properly. Signed-off-by: Anthony PERARD --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode

Hi, This series failed build test on s390x host. Please find the details below. Message-id: 1494502528-12670-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [PATCH] target/i386: enable A20 automatically in system management mode Type: series === TEST SCRIPT BEGIN === #!/bin/bash # Te

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

On 11/05/2017 09:00, Miltiadis Hatzimihail wrote: > > The interesting thing is that in the ram case the test is passing, but in > the io is failing. Also, if I try this without KVM, it passes in both cases. Yes, in the RAM case KVM is not invoked at all. > So I ve done some reading and for the

Re: [Qemu-devel] [PATCH 01/17] qdev: remove PropertyInfo.qtype field

Cc Paolo, because I have a question for him at the end. Eric Blake writes: > On 05/09/2017 12:35 PM, Marc-André Lureau wrote: >> Remove dependency on qapi qtype, replace a field by a few helper >> functions to determine the default value type (introduced in commit >> 4f2d3d7). >> >> Signed-off-

Re: [Qemu-devel] [PATCH 01/17] qdev: remove PropertyInfo.qtype field

On 11/05/2017 13:59, Markus Armbruster wrote: > > What I don't like is enumerating PropertyInfo in helpers. A relatively > straightforward way to avoid this would be moving the part of > qdev_property_add_static() that varies between properties into a new > PropertyInfo method. Assumes that *a

Re: [Qemu-devel] [PATCH v6 2/3] utils: provide size_to_str()

On Wed, May 10, 2017 at 01:34:18PM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Moving the algorithm from print_type_size() into size_to_str() so that > > other component can also leverage it. With that, refactor > > print_type_size(). > > > > Signed-off-by: Peter Xu > > --- > > inc

[Qemu-devel] [PATCH v7 0/4] ramblock: add hmp command "info ramblock"

v7: - patch 1: removed Dave's r-b since the patch conflicted during rebase - patch 2: add r-b for Markus, with the nice function comment that provided [Markus] - patch 3: add r-b for Dave - patch 4 (new): added new patch to remove assert in size_to_str(), assuming that would be better. v6 - pa

[Qemu-devel] [PATCH v7 1/4] ramblock: add RAMBLOCK_FOREACH()

So that it can simplifies the iterators. Signed-off-by: Peter Xu --- exec.c | 22 +++--- include/exec/ramlist.h | 5 + migration/ram.c| 13 +++-- 3 files changed, 23 insertions(+), 17 deletions(-) diff --git a/exec.c b/exec.c index eac6085..5

[Qemu-devel] [PATCH v7 3/4] ramblock: add new hmp command "info ramblock"

To dump information about ramblocks. It looks like: (qemu) info ramblock Block NamePSize Offset Used Total /objects/mem2 MiB 0x 0x8000 0x8000 vga.vram4 KiB 0x00

[Qemu-devel] [PATCH v7 2/4] utils: provide size_to_str()

Moving the algorithm from print_type_size() into size_to_str() so that other component can also leverage it. With that, refactor print_type_size(). Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu --- include/qemu-common.h| 1 + qapi/string-output-visitor.c | 22 ++---

[Qemu-devel] [PATCH v7 4/4] utils: remove assert in size_to_str()

It's not very safe to assert in size_to_str(). Let's be inclusive. It naturally allows negative values. Now it won't even limit on the size, as long as double would allow. Signed-off-by: Peter Xu --- util/cutils.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/util

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

On 11/05/2017 14:07, Zhoujian (jay) wrote: > -* Scan sptes if dirty logging has been stopped, dropping those > -* which can be collapsed into a single large-page spte. Later > -* page faults will create the large-page sptes. > +* Reset each vcpu's mmu, then page f

[Qemu-devel] [PATCH 2/6] vhost: rework IOTLB messaging

This patch reworks IOTLB messaging to prepare for vhost-user device IOTLB support. IOTLB messages handling is extracted from vhost-kernel backend, so that only the messages transport remains backend specifics. Signed-off-by: Maxime Coquelin --- hw/virtio/vhost-backend.c | 135 ++

[Qemu-devel] [PATCH 0/6] vhost-user: Specify and implement device IOTLB support

This series aims at specifying ans implementing the protocol update required to support device IOTLB with user backends. In this first non-RFC version, IOTLB messages forging and parsing have been extracted from the backend implementation; so that both user and kernel backends share as most code a

[Qemu-devel] [PATCH 4/6] vhost-user: add vhost_user to hold the chr

From: Marc-André Lureau Next patches will add more fields to the structure Signed-off-by: Marc-André Lureau Signed-off-by: Maxime Coquelin --- hw/virtio/vhost-user.c | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vho

[Qemu-devel] [PATCH 3/6] vhost: Update rings information for IOTLB earlier

Vhost-kernel backend need to receive IOTLB entries for rings information early, but vhost-user need the same information earlier, before VHOST_USER_SET_VRING_ADDR is sent. This patch also trigger IOTLB miss for all rings informations for robustness, even if in practice these adresses are on the sa

[Qemu-devel] [PATCH 5/6] vhost-user: add slave-req-fd support

From: Marc-André Lureau Learn to give a socket to the slave to let him make requests to the master. Signed-off-by: Marc-André Lureau Signed-off-by: Maxime Coquelin --- docs/specs/vhost-user.txt | 32 +++- hw/virtio/vhost-user.c| 127 ++

[Qemu-devel] [PATCH 1/6] vhost: propagate errors in vhost_device_iotlb_miss()

Some backends might want to know when things went wrong. Signed-off-by: Maxime Coquelin --- hw/virtio/vhost.c | 15 ++- include/hw/virtio/vhost.h | 2 +- 2 files changed, 11 insertions(+), 6 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index 0001e60..3693

[Qemu-devel] [PATCH 6/6] spec/vhost-user spec: Add IOMMU support

This patch specifies and implements the master/slave communication to support device IOTLB in slave. The vhost_iotlb_msg structure introduced for kernel backends is re-used, making the design close between the two backends. An exception is the use of the secondary channel to enable the slave to s

[Qemu-devel] e1000e migration

Hi Dmitry, Have you seen any problems with e1000e migration under windows? I've got a repeatable case where after migration with e1000e windows hangs/almost hangs. I'm seeing the e1000e generate interrupts at a very very high rate (maybe ~1000 second ish?) after migration. Some versions of q

Re: [Qemu-devel] [PATCH 03/17] tests: remove alt num-int cases

Eric Blake writes: > On 05/09/2017 12:35 PM, Marc-André Lureau wrote: >> There are no real users of this case, and it's going to be invalid after >> merging of QFloat and QInt use the same QNum type in the following patch. >> >> Signed-off-by: Marc-André Lureau >> --- >> tests/test-keyval.c

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

Thanks Paolo that worked! Btw, this line ​ + GP(SrcMem | DstReg | ModRM | Mov, &pfx_0f_10_0f_11), + GP(SrcReg | DstMem | ModRM | Mov, &pfx_0f_10_0f_11), -N, N, N, N, N, N, N, N, + N, N, N, N, N, N, I think it has 2 extra Ns (not removed from your change?). Those instru

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

On 11/05/2017 14:40, Miltiadis Hatzimihail wrote: > Thanks Paolo that worked! > > Btw, this line > > ​ > + GP(SrcMem | DstReg | ModRM | Mov, &pfx_0f_10_0f_11), > + GP(SrcReg | DstMem | ModRM | Mov, &pfx_0f_10_0f_11), > -N, N, N, N, N, N, N, N, > + N, N, N, N, N, N, >

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

That's great thanks for the clarification. Is this patch going to make it to the mainline at some point? Miltiadis Hatzimihail On Thu, May 11, 2017 at 1:44 PM, Paolo Bonzini wrote: > > > On 11/05/2017 14:40, Miltiadis Hatzimihail wrote: > > Thanks Paolo that worked! > > > > Btw, this line >

[Qemu-devel] [PATCH 0/2] usb-hub: clear PORT_STAT_SUSPEND on wakeup

Two small usb patches. Patch 2 fixes a problem with xhci on Windows, patch 1 addresses a minor code issue I found when debugging it. Ladi Prosek (2): xhci: fix logging usb-hub: clear PORT_STAT_SUSPEND on wakeup hw/usb/dev-hub.c | 1 + hw/usb/hcd-xhci.c | 7 ++- 2 files changed,

[Qemu-devel] [PATCH 2/2] usb-hub: clear PORT_STAT_SUSPEND on wakeup

The spec says: Suspend: (PORT_SUSPEND) This field indicates whether or not the device on this port is suspended. Setting this field causes the device to suspend by not propagating bus traffic downstream. This field may be reset by a request or by resume signaling from the device attached t

[Qemu-devel] [PATCH 1/2] xhci: fix logging

slotid and epid were deleted from XHCITransfer in commit d6fcb29. Also deleting one unused forward declaration. Signed-off-by: Ladi Prosek --- hw/usb/hcd-xhci.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c index a2d3143..d3d47bf

Re: [Qemu-devel] [PATCH v6 07/18] block: deprecate "encryption=on" in favour of "encrypt.format=aes"

On Tue 25 Apr 2017 05:38:47 PM CEST, Daniel P. Berrange wrote: > Historically the qcow & qcow2 image formats supported a property > "encryption=on" to enable their built-in AES encryption. We'll > soon be supporting LUKS for qcow2, so need a more general purpose > way to enable encryption, with a c

[Qemu-devel] order of dirtying pages in vm live migration iterations

Hi Is it possible to have the order of dirtying pages in every iteration of vm live migration? thanks a lot

Re: [Qemu-devel] Future of SoftFloat use in QEMU

Hi, We've got a task coming up to implement half-precision floating point (FP16) for ARMv8.2. As you know pretty much all our floating point in QEMU is handled by our internal fork of John R. Hauser's BSD SoftFloat library. Our current implementation is based on version 2a which doesn't suppor

Re: [Qemu-devel] [PATCH v7 1/4] ramblock: add RAMBLOCK_FOREACH()

* Peter Xu (pet...@redhat.com) wrote: > So that it can simplifies the iterators. > > Signed-off-by: Peter Xu Reviewed-by: Dr. David Alan Gilbert > --- > exec.c | 22 +++--- > include/exec/ramlist.h | 5 + > migration/ram.c| 13 +++-- > 3 fi

Re: [Qemu-devel] [PATCH v7 2/4] utils: provide size_to_str()

* Peter Xu (pet...@redhat.com) wrote: > Moving the algorithm from print_type_size() into size_to_str() so that > other component can also leverage it. With that, refactor > print_type_size(). > > Reviewed-by: Markus Armbruster > Signed-off-by: Peter Xu > --- > include/qemu-common.h| 1

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

On 11/05/2017 14:47, Miltiadis Hatzimihail wrote: > That's great thanks for the clarification. > > Is this patch going to make it to the mainline at some point? Not exactly as is, because it has a small defect (it always reads 16 bytes from memory), but something like that will. Paolo

Re: [Qemu-devel] Guest SIGILL when different IO is implemented

Ok many thanks for your help. ​Milton On Thu, May 11, 2017 at 2:11 PM, Paolo Bonzini wrote: > > > On 11/05/2017 14:47, Miltiadis Hatzimihail wrote: > > That's great thanks for the clarification. > > > > Is this patch going to make it to the mainline at some point? > > Not exactly as is, because

Re: [Qemu-devel] [PATCH 0/6] vhost-user: Specify and implement device IOTLB support

Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Subject: [Qemu-devel] [PATCH 0/6] vhost-user: Specify and implement device IOTLB support Message-id: 20170511123246.31308-1-m

Re: [Qemu-devel] [PATCH v3 00/18] numa: add '-numa cpu' option

On Wed, May 10, 2017 at 01:29:44PM +0200, Igor Mammedov wrote: [...] > Igor Mammedov (18): > numa: move source of default CPUs to NUMA node mapping into boards > spapr: add node-id property to sPAPR core > pc: add node-id property to CPU > virt-arm: add node-id property to CPU > numa: add

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-11 20:24 GMT+08:00 Paolo Bonzini : > > > On 11/05/2017 14:07, Zhoujian (jay) wrote: >> -* Scan sptes if dirty logging has been stopped, dropping those >> -* which can be collapsed into a single large-page spte. Later >> -* page faults will create the large-page spte

Re: [Qemu-devel] [PATCH 4/7] curl: split curl_find_state/curl_init_state

On 10/05/2017 19:26, Max Reitz wrote: >> +if (curl_init_state(s, state) < 0) { >> +curl_clean_state(state); > > We could also initialize state to NULL and call curl_clean_state() under > out: if state != NULL. Then again, it would only save us two > curl_clean_state() instances... >

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

2017-05-11 21:43 GMT+08:00 Wanpeng Li : > 2017-05-11 20:24 GMT+08:00 Paolo Bonzini : >> >> >> On 11/05/2017 14:07, Zhoujian (jay) wrote: >>> -* Scan sptes if dirty logging has been stopped, dropping those >>> -* which can be collapsed into a single large-page spte. Later >>> -

Re: [Qemu-devel] [RFC PATCH v2 0/8] s390x: Enable virtio-scsi boot from /dev/sgX

On Wed, 10 May 2017 17:53:51 +0200 Eric Farman wrote: > Today, trying to boot a guest from a SCSI LUN on s390x yields the following: > > virtio-blk = OK > virtio-scsi and /dev/sdX = OK > virtio-scsi and /dev/sgX = FAIL > > Example of the failing scenario: > > /usr/bin/qem

[Qemu-devel] help! usb wifi device lost, even crash!

Hi, Here some usb wifi devices connect to host through an usb hub on centos linux release 7.2.1511. Execute "lsusb": Bus 002 Device 005: ID 0557:2419 ATEN International Co., Ltd Bus 002 Device 004: ID 0557:7000 ATEN International Co., Ltd Hub Bus 002 Device 003:

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

Hi all, After applying the patch below, the time which memory_global_dirty_log_stop() function takes is down to milliseconds of a 4T memory guest, but I'm not sure whether this patch will trigger other problems. Does this patch make sense? diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c inde

Re: [Qemu-devel] [PATCH v2] tests: Add [+-]feature and feature=on|off test cases

On Mon, 8 May 2017 15:32:05 -0300 Eduardo Habkost wrote: > Add test code to ensure features are enabled/disabled correctly in the > command-line. The test case use the "feature-words" and > "filtered-features" properties to check if the features were > enabled/disabled correctly. > > Signed-off

Re: [Qemu-devel] [PATCH v6 09/18] qcow: convert QCow to use QCryptoBlock for encryption

On Tue 25 Apr 2017 05:38:49 PM CEST, Daniel P. Berrange wrote: > @@ -181,8 +188,39 @@ static int qcow_open(BlockDriverState *bs, QDict > *options, int flags, [...] > +crypto_opts = block_crypto_open_opts_init( > +Q_CRYPTO_BLOCK_FORMAT_QCOW, encryptopts, &local_err); >

Re: [Qemu-devel] [PATCH v6 09/18] qcow: convert QCow to use QCryptoBlock for encryption

On Thu, May 11, 2017 at 04:05:59PM +0200, Alberto Garcia wrote: > On Tue 25 Apr 2017 05:38:49 PM CEST, Daniel P. Berrange wrote: > > @@ -181,8 +188,39 @@ static int qcow_open(BlockDriverState *bs, QDict > > *options, int flags, > [...] > > +crypto_opts = block_crypto_open_opts_init(

Re: [Qemu-devel] [PATCH] mirror: add sync mode incremental to drive-mirror and blockdev-mirror

2017-05-10 17:05 GMT+02:00 Denis V. Lunev : > On 05/10/2017 05:00 PM, Stefan Hajnoczi wrote: > > On Wed, May 10, 2017 at 03:25:31PM +0200, Denis V. Lunev wrote: > >> On 05/09/2017 06:52 PM, Stefan Hajnoczi wrote: > >>> On Mon, May 08, 2017 at 05:07:18PM -0400, John Snow wrote: > On 05/08/2017

Re: [Qemu-devel] About QEMU BQL and dirty log switch in Migration

Hi Wanpeng, > 2017-05-11 21:43 GMT+08:00 Wanpeng Li : > > 2017-05-11 20:24 GMT+08:00 Paolo Bonzini : > >> > >> > >> On 11/05/2017 14:07, Zhoujian (jay) wrote: > >>> -* Scan sptes if dirty logging has been stopped, dropping > those > >>> -* which can be collapsed into a single large

Re: [Qemu-devel] [PATCH] mirror: add sync mode incremental to drive-mirror and blockdev-mirror

On 05/11/2017 04:16 PM, Daniel Kučera wrote: > > 2017-05-10 17:05 GMT+02:00 Denis V. Lunev >: > > On 05/10/2017 05:00 PM, Stefan Hajnoczi wrote: > > On Wed, May 10, 2017 at 03:25:31PM +0200, Denis V. Lunev wrote: > >> On 05/09/2017 06:52 PM, Stefan Hajnoczi wrot

Re: [Qemu-devel] [PATCH v6 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

On Tue 25 Apr 2017 05:38:51 PM CEST, Daniel P. Berrange wrote: > +switch (s->crypt_method_header) { > +case QCOW_CRYPT_NONE: > +if (encryptfmt) { > +error_setg(errp, "No encryption in image header, but options " > + "specified format '%s'", encryptf

Re: [Qemu-devel] [PATCH 04/17] qapi: merge QInt and QFloat in QNum

Marc-André Lureau writes: > We would like to use a same QObject type to represent numbers, whether > they are int, uint, or floats. getters will allow some compatibility Please start your sentence with a capital letter ... > between the various types if the number fits other representations ..

[Qemu-devel] [PULL 00/58] Block layer patches

The following changes since commit 76d20ea0f1b26ebd5da2f5fb2fdf3250cde887bb: Merge remote-tracking branch 'armbru/tags/pull-qapi-2017-05-04-v3' into staging (2017-05-09 15:49:14 -0400) are available in the git repository at: git://repo.or.cz/qemu/kevin.git tags/for-upstream for you to fet

[Qemu-devel] [PULL 01/58] block: Make bdrv_perm_names public

From: Fam Zheng It can be used outside of block.c for making user friendly messages. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block.c | 2 +- include/block/block.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/block.c b/block.c index a45b9b5

[Qemu-devel] [PULL 02/58] block: Add, parse and store "force-share" option

From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block.c | 17 + include/block/block.h | 1 + include/block/block_int.h | 1 + qapi/block-core.json | 3 +++ 4 files changed, 22 insertions(+) diff --git a/block.c b/block.c ind

[Qemu-devel] [PULL 05/58] qemu-img: Update documentation for -U

From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-img-cmds.hx | 36 ++-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx index bf4ce59..e5bc28f 100644 --- a/qemu-img-cmds.hx +++ b/qemu

[Qemu-devel] [PULL 08/58] iotests: 046: Prepare for image locking

From: Fam Zheng The qemu-img info command is executed while VM is running, add -U option to avoid the image locking error. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/046 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/046 b

[Qemu-devel] [PULL 03/58] block: Respect "force-share" in perm propagating

From: Fam Zheng Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- block.c | 32 1 file changed, 24 insertions(+), 8 deletions(-) diff --git a/block.c b/block.c index 31d6d0b..1e00e31 100644 --- a/block.c +++ b/block.c @@ -1465,6 +1465,22 @@ static int bdr

[Qemu-devel] [PULL 07/58] iotests: 030: Prepare for image locking

From: Fam Zheng qemu-img and qemu-io commands when guest is running need "-U" option, add it. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- tests/qemu-iotests/030 | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/tests/qemu-iotests/030 b/tests/qem

[Qemu-devel] [PULL 04/58] qemu-img: Add --force-share option to subcommands

From: Fam Zheng This will force the opened images to allow sharing all permissions with other programs. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-img.c | 153 ++--- 1 file changed, 117 insertions(+), 36 deletions(-) di

[Qemu-devel] [PULL 09/58] iotests: 055: Don't attach the target image already for drive-backup

From: Fam Zheng Double attach is not a valid usage of the target image, drive-backup will open the blockdev itself so skip the add_drive call in this case. Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/055 | 32 ++

[Qemu-devel] [PULL 06/58] qemu-io: Add --force-share option

From: Fam Zheng Add --force-share/-U to program options and -U to open subcommand. Signed-off-by: Fam Zheng Signed-off-by: Kevin Wolf --- qemu-io.c | 42 ++ 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/qemu-io.c b/qemu-io.c index ed0e2

[Qemu-devel] [PULL 28/58] migration: Unify block node activation error handling

Migration code activates all block driver nodes on the destination when the migration completes. It does so by calling bdrv_invalidate_cache_all() and blk_resume_after_migration(). There is one code path for precopy and one for postcopy migration, resulting in four function calls, which used to hav

[Qemu-devel] [PULL 12/58] iotests: 091: Quit QEMU before checking image

From: Fam Zheng Signed-off-by: Fam Zheng Reviewed-by: Max Reitz Signed-off-by: Kevin Wolf --- tests/qemu-iotests/091 | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/qemu-iotests/091 b/tests/qemu-iotests/091 index 32bbd56..10ac4a8 100755 --- a/tests/qemu-iotests/091 +++ b/tests/qem

[Qemu-devel] [PULL 10/58] iotests: 085: Avoid image locking conflict

From: Fam Zheng In the case where we test the expected error when a blockdev-snapshot target already has a backing image, the backing chain is opened multiple times. This will be a problem when we use image locking, so use a different backing file that is not already open. Signed-off-by: Fam Zhe

  1   2   3   4   >