Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

On 05/09/2017 01:36 PM, Jason Wang wrote: On 2017年05月09日 12:03, Zhang Chen wrote: On 05/09/2017 10:40 AM, Jason Wang wrote: On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen wrote: On 05/02/2017 12:53 PM, Jason Wa

Re: [Qemu-devel] [PATCH v5 06/10] qobject: Use simpler QDict/QList scalar insertion macros

Alberto Garcia writes: > On Fri 28 Apr 2017 10:33:36 AM CEST, Markus Armbruster wrote: >>> v5: rebase to master (Coccinelle found a couple new spots), squash 3 >>> patches into 1, adjust R-b to only list Markus (while there were other >>> reviews on the pre-squashed patches, Markus was the only o

Re: [Qemu-devel] [PATCH v4 1/1] slirp: add SOCKS5 support

Le 08/05/2017 à 22:09, Samuel Thibault a écrit : > Hello, > > Laurent Vivier, on sam. 06 mai 2017 15:19:44 +0200, wrote: >>> Laurent Vivier, on sam. 06 mai 2017 00:48:33 +0200, wrote: @@ -617,6 +622,10 @@ void slirp_pollfds_poll(GArray *pollfds, int select_error)

Re: [Qemu-devel] [PATCH 08/11] hw/sparc: use ARRAY_SIZE() macro

Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sparc64/sun4u.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/sparc64/sun4u.c b/hw/sparc64/sun4u.c > index d347b6616d..525d6f44a0 100644 > --- a/hw/sparc64/sun4u.c > +++ b/hw/sparc64

Re: [Qemu-devel] [PATCH 01/11] hw/net: removed obsolete comments

Philippe Mathieu-Daudé writes: > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/net/pcnet-pci.c | 10 -- > 1 file changed, 10 deletions(-) > > diff --git a/hw/net/pcnet-pci.c b/hw/net/pcnet-pci.c > index 0acf8a4879..bdb533436e 100644 > --- a/hw/net/pcnet-pci.c > +++ b/hw/net/pcnet-pc

Re: [Qemu-devel] [PULL v2 00/28] QAPI patches for 2017-05-04

Eric Blake writes: > On 05/08/2017 01:09 PM, Eric Blake wrote: >> On 05/08/2017 11:42 AM, Stefan Hajnoczi wrote: >>> On Fri, May 05, 2017 at 08:34:42AM +0200, Markus Armbruster wrote: [v2]: Fix trailing space, note tweaks to PATCH 12 properly in the commit message The followi

Re: [Qemu-devel] [PATCH v7 13/13] MAINTAINERS: Add vfio-ccw maintainer

On Tue, 9 May 2017 09:41:43 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2017-05-08 11:09:27 +0200]: > > > On Mon, 8 May 2017 13:29:27 +0800 > > Dong Jia Shi wrote: > > > > > * Cornelia Huck [2017-05-05 14:20:14 +0200]: > > > > > > > On Fri, 5 May 2017 04:03:52 +0200 > > > > Dong Jia Shi

Re: [Qemu-devel] migration: add incremental drive-mirror and blockdev-mirror with dirtymap

2017-05-08 19:29 GMT+02:00 John Snow : > > > On 05/04/2017 03:45 AM, Daniel Kučera wrote: > > > > 2017-05-04 1:44 GMT+02:00 John Snow > >: > > > > > > > > On 05/03/2017 03:56 AM, Daniel Kučera wrote: > > > Hi all, > > > > > > this patch adds possibility to

Re: [Qemu-devel] [PATCH V3 05/10] net/net.c: Add vnet header length to SocketReadState

On 2017年05月09日 14:59, Zhang Chen wrote: On 05/09/2017 01:36 PM, Jason Wang wrote: On 2017年05月09日 12:03, Zhang Chen wrote: On 05/09/2017 10:40 AM, Jason Wang wrote: On 2017年05月08日 11:47, Zhang Chen wrote: On 05/03/2017 06:42 PM, Jason Wang wrote: On 2017年05月03日 11:43, Zhang Chen

Re: [Qemu-devel] [PATCH v2 05/21] docker: compact debian base

Fam Zheng writes: > On Mon, 05/08 19:17, Philippe Mathieu-Daudé wrote: >> - install common/basic tools at once >> - use eatmydata and remove apt cache to save space >> - add bison and flex and git >> - create deb-src entry and setup Emdebian in the same layer >> >> Signed-off-by: Philippe Mathie

Re: [Qemu-devel] [PATCH] Mark legacy option '-no-kvm' as deprecated

Thomas Huth writes: > On 08.05.2017 11:40, Daniel P. Berrange wrote: >> On Mon, May 08, 2017 at 11:14:00AM +0200, Thomas Huth wrote: >>> On 08.05.2017 10:42, Markus Armbruster wrote: "Daniel P. Berrange" writes: > On Fri, May 05, 2017 at 03:48:37PM +0100, Stefan Hajnoczi wrote: >>>

Re: [Qemu-devel] [RFC PATCH 6/8] VFIO: do pasid table binding

On 04/26/2017 06:12 PM, Liu, Yi L wrote: From: "Liu, Yi L" This patch adds IOCTL processing in vfio_iommu_type1 for VFIO_IOMMU_SVM_BIND_TASK. Binds the PASID table bind by calling iommu_ops->bind_pasid_table to link the whole PASID table to pIOMMU. For VT-d, it is linking the guest PASID tab

Re: [Qemu-devel] [PATCH] hw/xtensa: sim: use g_string/g_new

Max Filippov writes: > Replace malloc/free/sprintf with g_string/g_string_printf/g_string_free. > Replace g_malloc with g_new when allocating the MemoryRegion to get more > type safety. > > Suggested-by: Alex Bennée > Signed-off-by: Max Filippov > --- > hw/xtensa/sim.c | 10 +- > 1 fil

Re: [Qemu-devel] [PATCH v2 05/21] docker: compact debian base

On Tue, 05/09 08:46, Alex Bennée wrote: > > Fam Zheng writes: > > > On Mon, 05/08 19:17, Philippe Mathieu-Daudé wrote: > >> - install common/basic tools at once > >> - use eatmydata and remove apt cache to save space > >> - add bison and flex and git > >> - create deb-src entry and setup Emdebia

[Qemu-devel] [PULL v3 09/28] block: Simplify bdrv_append_temp_snapshot() logic

From: Eric Blake Noticed while checking Coccinelle results. Naming a label 'out:' when it is only used on error paths is weird. Also, we had some dead stores to 'ret'. Meanwhile we know that snapshot_options is NULL on success and that QDECREF(NULL) is safe. So merge the two exit paths into on

[Qemu-devel] [PULL v3 05/28] coccinelle: Add script to remove useless QObject casts

From: Eric Blake We have macros in place to make it less verbose to add a subtype of QObject to both QDict and QList. While we have made cleanups like this in the past (see commit fcfcd8ffc, for example), having it be automated by Coccinelle makes it easier to maintain. The script is separate fr

[Qemu-devel] [PULL v3 10/28] QemuOpts: Simplify qemu_opts_to_qdict()

From: Eric Blake Noticed while investigating Coccinelle cleanups. There is no need for a temporary variable when we can use the new macro to do the same thing with less typing. Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus Armbruster Message-Id: <2017042721

[Qemu-devel] [PULL v3 04/28] pci: Reduce scope of error injection

From: Eric Blake No one outside of pcie_aer.h was using error injection; mark them static for internal use. Signed-off-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael S. Tsirkin Reviewed-by: Marcel Apfelbaum Reviewed-by: Markus Armbruster Message-Id: <20170427215821.

[Qemu-devel] [PULL v3 07/28] qobject: Add helper macros for common scalar insertions

From: Eric Blake Rather than making lots of callers wrap a scalar in a QInt, QString, or QBool, provide helper macros that do the wrapping automatically. Update the Coccinelle script to make mass conversions easy, although the conversion itself will be done as a separate patches to ease review a

[Qemu-devel] [PULL v3 15/28] qapi: New QAPI_CLONE_MEMBERS()

QAPI_CLONE() returns a newly allocated QAPI object. Inconvenient when we want to clone into an existing object. QAPI_CLONE_MEMBERS() does exactly that. Signed-off-by: Markus Armbruster Message-Id: <1493192202-3184-4-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake --- include/qapi/cl

[Qemu-devel] [PULL v3 00/28] QAPI patches for 2017-05-04

[v3]: Rebase & resolve semantic conflicts, with help from Eric Blake [v2]: Fix trailing space, note tweaks to PATCH 12 properly in the commit message The following changes since commit dd1559bb267becbb838de41132ef60771d183e5d: Merge remote-tracking branch 'elmarco/tags/chr-tests-pull-request'

[Qemu-devel] [PULL v3 11/28] fdc-test: Avoid deprecated 'change' command

From: Eric Blake Use the preferred blockdev-change-medium command instead. Also, use of 'device' is deprecated; adding an explicit id on the command line lets us use 'id' for both blockdev-change-medium and eject. Signed-off-by: Eric Blake Reviewed-by: John Snow Reviewed-by: Markus Armbruster

[Qemu-devel] [PULL v3 01/28] tests/check-qdict: Fix missing brackets

From: "Dr. David Alan Gilbert" Gcc 7 (on Fedora 26) spotted odd use of integers instead of a boolean; it's got a point. Signed-off-by: Dr. David Alan Gilbert Message-Id: <20170406154107.9178-1-dgilb...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Markus

[Qemu-devel] [PULL v3 19/28] sockets: Delete unused helper socket_address_crumple()

Signed-off-by: Markus Armbruster Message-Id: <1493192202-3184-8-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake [Commit message typo fixed] --- include/qemu/sockets.h | 11 --- util/qemu-sockets.c| 31 --- 2 files changed, 42 deletions(-) diff -

[Qemu-devel] [PULL v3 22/28] qapi: Document intended use of @name within alternate visits

Signed-off-by: Markus Armbruster Message-Id: <1493282486-28338-4-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- include/qapi/visitor.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/include/qapi/visitor.h b/include/qapi/visitor.h index 1a1b620..b0

[Qemu-devel] [PULL v3 20/28] qmp: Improve QMP dispatch error messages

Signed-off-by: Markus Armbruster Reviewed-by: Eric Blake Message-Id: <1493282486-28338-2-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau Reviewed-by: Philippe Mathieu-Daudé --- qapi/qmp-dispatch.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[Qemu-devel] [PULL v3 02/28] test-keyval: fix leaks

From: Marc-André Lureau Spotted by ASAN. Signed-off-by: Marc-André Lureau Message-Id: <20170503223846.6559-2-marcandre.lur...@redhat.com> Reviewed-by: Eric blake Signed-off-by: Markus Armbruster --- tests/test-keyval.c | 4 1 file changed, 4 insertions(+) diff --git a/tests/test-keyval

[Qemu-devel] [PULL v3 13/28] sockets: Prepare vsock_parse() for flattened SocketAddress

I'm going to flatten SocketAddress: rename SocketAddress to SocketAddressLegacy, SocketAddressFlat to SocketAddress, eliminate SocketAddressLegacy except in external interfaces. vsock_parse() returns a newly allocated VsockSocketAddress. Lift the allocation from vsock_parse() into its caller sock

[Qemu-devel] [PULL v3 08/28] qobject: Use simpler QDict/QList scalar insertion macros

From: Eric Blake We now have macros in place to make it less verbose to add a scalar to QDict and QList, so use them. Patch created mechanically via: spatch --sp-file scripts/coccinelle/qobject.cocci \ --macro-file scripts/cocci-macro-file.h --dir . --in-place then touched up manually to f

[Qemu-devel] [PULL v3 21/28] qobject-input-visitor: Document full_name_nth()

Signed-off-by: Markus Armbruster Message-Id: <1493282486-28338-3-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau --- qapi/qobject-input-visitor.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/qapi/qobject-input-visitor.c b/qapi/qobject-input-visitor.c index 86

[Qemu-devel] [PULL v3 06/28] qobject: Drop useless QObject casts

From: Eric Blake We have macros in place to make it less verbose to add a subtype of QObject to both QDict and QList. While we have made cleanups like this in the past (see commit fcfcd8ffc, for example), having it be automated by Coccinelle makes it easier to maintain. Patch created mechanicall

[Qemu-devel] [PULL v3 03/28] pci: Use struct instead of QDict to pass back parameters

From: Eric Blake It's simpler to just use a C struct than it is to bundle things into a QDict in one function just to pull them back out in the caller. Plus, doing this gets rid of one more user of dynamic JSON through qobject_from_jsonf(), as well as a memory leak of the QDict. While cleaning

[Qemu-devel] [PULL v3 25/28] qmp-shell: add -N option to skip negotiate

From: Marc-André Lureau qemu-ga doesn't have negotiate phase. Signed-off-by: Marc-André Lureau Message-Id: <20170504125432.21653-2-marcandre.lur...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- scripts/qmp/qmp-shell | 11 +++ 1 file changed, 7 insertions(+)

[Qemu-devel] [PULL v3 27/28] qmp-shell: don't show version greeting if unavailable

From: Marc-André Lureau qemu-ga doesn't have greeting. Signed-off-by: Marc-André Lureau Message-Id: <20170504125432.21653-4-marcandre.lur...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- scripts/qmp/qmp-shell | 3 +++ 1 file changed, 3 insertions(+) diff --git a/s

[Qemu-devel] [PULL v3 26/28] qmp-shell: Cope with query-commands error

From: Marc-André Lureau qemu-ga doesn't implement it. Signed-off-by: Marc-André Lureau Message-Id: <20170504125432.21653-3-marcandre.lur...@redhat.com> Reviewed-by: Eric Blake [Commit message tweaked] Signed-off-by: Markus Armbruster --- scripts/qmp/qmp-shell | 5 - 1 file changed, 4 ins

[Qemu-devel] [PULL v3 17/28] sockets: Rename SocketAddressFlat to SocketAddress

Signed-off-by: Markus Armbruster Message-Id: <1493192202-3184-6-git-send-email-arm...@redhat.com> Reviewed-by: Eric Blake Reviewed-by: Prasanna Kumar Kalever --- block/gluster.c| 48 block/nbd.c| 26 +-

[Qemu-devel] [PULL v3 28/28] qmp-shell: improve help

From: Marc-André Lureau Describe the arguments & fix the tool name. Signed-off-by: Marc-André Lureau Message-Id: <20170504125432.21653-5-marcandre.lur...@redhat.com> Reviewed-by: Eric Blake Signed-off-by: Markus Armbruster --- scripts/qmp/qmp-shell | 6 +- 1 file changed, 5 insertions(+)

[Qemu-devel] [PULL v3 16/28] sockets: Rename SocketAddress to SocketAddressLegacy

The next commit will rename SocketAddressFlat to SocketAddress, and the commit after that will replace most uses of SocketAddressLegacy by SocketAddress, replacing most of this commit's renames right back. Note that checkpatch emits a few "line over 80 characters" warnings. The long lines are all

[Qemu-devel] [Bug 1689499] [NEW] copy-storage-all/inc does not easily converge with load going on

Public bug reported: Hi, for now this is more a report to discuss than a "bug", but I wanted to be sure if there are things I might overlook. I'm regularly testing the qemu's we have in Ubuntu which currently are 2.0, 2.5, 2.6.1, 2.8 plus a bunch of patches. And for all sorts of verification ups

[Qemu-devel] [PULL v3 24/28] qmp-shell: add persistent command history

From: John Snow Use the existing readline history function we are utilizing to provide persistent command history across instances of qmp-shell. This assists entering debug commands across sessions that may be interrupted by QEMU sessions terminating, where the qmp-shell has to be relaunched. S

Re: [Qemu-devel] [PATCH v2 1/6] target/s390x: Implement STORE FACILITIES LIST EXTENDED

On 2017-05-08 08:17, Richard Henderson wrote: > At the same time, improve STORE FACILITIES LIST > so that we don't hard-code the list for all cpus. > > Signed-off-by: Richard Henderson > --- > target/s390x/helper.h | 2 ++ > target/s390x/insn-data.def | 2 ++ > target/s390x/misc_helper.c

[Qemu-devel] [PULL v3 14/28] sockets: Prepare inet_parse() for flattened SocketAddress

I'm going to flatten SocketAddress: rename SocketAddress to SocketAddressLegacy, SocketAddressFlat to SocketAddress, eliminate SocketAddressLegacy except in external interfaces. inet_parse() returns a newly allocated InetSocketAddress. Lift the allocation from inet_parse() into its caller socket_

[Qemu-devel] [PATCH 1/3] target/s390x: mask the SIGP order_code using SIGP_ORDER_MASK

For that move the definition from kvm.c to cpu.h Signed-off-by: Aurelien Jarno --- target/s390x/cpu.h | 3 +++ target/s390x/kvm.c | 2 -- target/s390x/misc_helper.c | 3 +-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h ind

[Qemu-devel] [PULL v3 12/28] test-qga: Actually test 0xff sync bytes

From: Eric Blake Commit 62c39b3 introduced test-qga, and at face value, appears to be testing the 'guest-sync' behavior that is recommended for guests in sending 0xff to QGA to force the parser to reset. But this aspect of the test has never actually done anything: the qmp_fd() call chain conver

Re: [Qemu-devel] [PATCH] block: Simplify BDRV_BLOCK_RAW recursion

On Thu, 05/04 12:37, Eric Blake wrote: > Since we are already in coroutine context during the body of > bdrv_co_get_block_status(), we can shave off a few layers of > wrappers when recursing to query the protocol when a format driver > returned BDRV_BLOCK_RAW. > > Note that we are already using th

[Qemu-devel] [PATCH 0/3] target/s390x: misc patches

Those are just random patches I have written while trying to get a MTTCG version of qemu/s390x. I just send them to avoid duplicated work. Aurelien Jarno (3): target/s390x: mask the SIGP order_code using SIGP_ORDER_MASK target/s390x: fix SIGNAL PROCESSOR return value target/s390x: implement

[Qemu-devel] [PULL v3 23/28] qobject-input-visitor: Catch misuse of end_struct vs. end_list

Signed-off-by: Markus Armbruster Message-Id: <1493282486-28338-5-git-send-email-arm...@redhat.com> Reviewed-by: Marc-André Lureau [More elaborate assertions for clarity] --- qapi/qobject-input-visitor.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/qa

[Qemu-devel] [PATCH 2/3] target/s390x: fix SIGNAL PROCESSOR return value

The SIGNAL PROCESSOR helper returns its value through the CC register. set_cc_static should be called just after the helper. Signed-off-by: Aurelien Jarno --- target/s390x/translate.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index 55

Re: [Qemu-devel] [PATCH v7 07/13] vfio/ccw: vfio based subchannel passthrough driver

Hi, On 05/05/2017 04:03, Dong Jia Shi wrote: > From: Xiao Feng Ren > > We use the IOMMU_TYPE1 of VFIO to realize the subchannels > passthrough, implement a vfio based subchannels passthrough > driver called "vfio-ccw". > > Support qemu parameters in the style of: > "-device vfio-ccw,sysfsdev=$m

[Qemu-devel] [PATCH 3/3] target/s390x: implement serialization in BRANCH CONDITION

Signed-off-by: Aurelien Jarno --- target/s390x/translate.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/target/s390x/translate.c b/target/s390x/translate.c index c58c27f8e9..2f07ce2be9 100644 --- a/target/s390x/translate.c +++ b/target/s390x/translate.c @@ -1517,6 +1517,21

Re: [Qemu-devel] [RFC PATCH 03/20] intel_iommu: add "svm" option

On Mon, May 08, 2017 at 07:20:34PM +0800, Peter Xu wrote: > On Mon, May 08, 2017 at 10:38:09AM +, Liu, Yi L wrote: > > On Thu, 27 Apr 2017 18:53:17 +0800 > > Peter Xu wrote: > > > > > On Wed, Apr 26, 2017 at 06:06:33PM +0800, Liu, Yi L wrote: > > > > Expose "Shared Virtual Memory" to guest by

[Qemu-devel] [PULL v3 18/28] sockets: Limit SocketAddressLegacy to external interfaces

SocketAddressLegacy is a simple union, and simple unions are awkward: they have their variant members wrapped in a "data" object on the wire, and require additional indirections in C. SocketAddress is the equivalent flat union. Convert all users of SocketAddressLegacy to SocketAddress, except for

Re: [Qemu-devel] [PATCH v7 09/13] vfio/ccw: get irqs info and set the eventfd fd

* Auger Eric [2017-05-09 10:21:15 +0200]: Hi Eric, > Hi, > > On 05/05/2017 04:03, Dong Jia Shi wrote: > > vfio-ccw resorts to the eventfd mechanism to communicate with userspace. > > We fetch the irqs info via the ioctl VFIO_DEVICE_GET_IRQ_INFO, > > register a event notifier to get the eventfd

Re: [Qemu-devel] [PATCH v7 06/13] s390x/css: device support for s390-ccw passthrough

Hi On 05/05/2017 04:03, Dong Jia Shi wrote: > In order to support subchannels pass-through, we introduce a s390 > subchannel device called "s390-ccw" to hold the real subchannel info. > The s390-ccw devices inherit from the abstract CcwDevice which connect > to the existing virtual-css-bus. > > S

Re: [Qemu-devel] [PATCH v7 08/13] vfio/ccw: get io region info

Hi, On 05/05/2017 04:03, Dong Jia Shi wrote: > vfio-ccw provides an MMIO region for I/O operations. We fetch its > information via ioctls here, then we can use it performing I/O > instructions and retrieving I/O results later on. > > Signed-off-by: Dong Jia Shi Reviewed-by: Eric Auger Thanks

Re: [Qemu-devel] [PATCH v7 09/13] vfio/ccw: get irqs info and set the eventfd fd

Hi, On 05/05/2017 04:03, Dong Jia Shi wrote: > vfio-ccw resorts to the eventfd mechanism to communicate with userspace. > We fetch the irqs info via the ioctl VFIO_DEVICE_GET_IRQ_INFO, > register a event notifier to get the eventfd fd which is sent > to kernel via the ioctl VFIO_DEVICE_SET_IRQS, t

Re: [Qemu-devel] [PATCH RESEND V3 5/6] migration: calculate downtime on dst side

On Mon, May 08, 2017 at 12:08:07PM +0300, Alexey wrote: > On Mon, May 08, 2017 at 02:29:06PM +0800, Peter Xu wrote: > > On Fri, Apr 28, 2017 at 02:11:19PM +0300, Alexey Perevalov wrote: > > > On 04/28/2017 01:00 PM, Peter Xu wrote: > > > >On Fri, Apr 28, 2017 at 09:57:37AM +0300, Alexey Perevalov w

Re: [Qemu-devel] [PATCH 2/5] 9pfs: local: resolve special directories in paths

On Fri, 5 May 2017 11:59:15 -0500 Eric Blake wrote: > On 05/05/2017 09:37 AM, Greg Kurz wrote: > > When using the mapped-file security mode, the creds of a path /foo/bar > > are stored in the /foo/.virtfs_metadata/bar file. This is okay for all > > paths unless they end with '.' or '..', because

Re: [Qemu-devel] [PATCH] Revert "target-ppc/kvm: Enable in-kernel TCE acceleration for multi-tce"

On 09/05/17 15:22, David Gibson wrote: > On Tue, May 09, 2017 at 07:25:51AM +1000, Alexey Kardashevskiy wrote: >> On 09/05/17 06:17, Jose Ricardo Ziviani wrote: >>> This reverts commit 3dc410ae83e6cb76c81ea30a05d62596092b3165. >>> >>> Booting a radix guest in Power9 with that commit throws a host k

Re: [Qemu-devel] [PATCH qemu v6] memory/iommu: QOM'fy IOMMU MemoryRegion

On Fri, May 05, 2017 at 08:19:30PM +1000, Alexey Kardashevskiy wrote: > This defines new QOM object - IOMMUMemoryRegion - with MemoryRegion > as a parent. > > This moves IOMMU-related fields from MR to IOMMU MR. However to avoid > dymanic QOM casting in fast path (address_space_translate, etc), >

Re: [Qemu-devel] [PATCH 1/3] target/s390x: mask the SIGP order_code using SIGP_ORDER_MASK

On 09.05.2017 10:27, Aurelien Jarno wrote: > For that move the definition from kvm.c to cpu.h > > Signed-off-by: Aurelien Jarno > --- > target/s390x/cpu.h | 3 +++ > target/s390x/kvm.c | 2 -- > target/s390x/misc_helper.c | 3 +-- > 3 files changed, 4 insertions(+), 4 deletions(-

Re: [Qemu-devel] [PATCH 3/5] 9pfs: local: simplify file opening

On Fri, 5 May 2017 12:01:55 -0500 Eric Blake wrote: > On 05/05/2017 09:37 AM, Greg Kurz wrote: > > All paths in the virtfs directory now start with "./" (except the virtfs > > root itself which is exactly "."). > > > > We hence don't need to skip leading '/' characters anymore, nor to handle > >

Re: [Qemu-devel] [PATCH 4/5] 9pfs: local: metadata file for the VirtFS root

On Fri, 5 May 2017 12:11:14 -0500 Eric Blake wrote: > On 05/05/2017 09:37 AM, Greg Kurz wrote: > > When using the mapped-file security, credentials are stored in a metadata > > directory located in the parent directory. This is okay for all paths with > > the notable exception of the root path, s

[Qemu-devel] [PATCH 1/4] curl: strengthen assertion in curl_clean_state

curl_clean_state should only be called after all AIOCBs have been completed. This is not so obvious for the call from curl_detach_aio_context, so assert that. Cc: qemu-sta...@nongnu.org Cc: jc...@redhat.com Signed-off-by: Paolo Bonzini --- block/curl.c | 5 + 1 file changed, 5 insertions(+)

[Qemu-devel] [PATCH 4/4] curl: improve search for unused CURLState

The main change here is to pull the search loop to a new function, making it easier to switch from aio_poll to BDRV_POLL_WHILE. However, the "for (j...)" loop is also dead (there is no other read of "j" outside the loop), so remove it. Cc: jc...@redhat.com Cc: qemu-sta...@nongnu.org Signed-off-by

[Qemu-devel] [PATCH 0/4] curl: locking cleanups and fixes

This is the full version of the simple patch: @@ -473,7 +475,9 @@ break; } if (!state) { +qemu_mutex_unlock(&s->mutex); aio_poll(bdrv_get_aio_context(bs), true); +qemu_mutex_lock(&s->mutex); } } while(!state); that

[Qemu-devel] [PATCH 2/4] curl: never invoke callbacks with s->mutex held

All curl callbacks go through curl_multi_do, and hence are called with s->mutex held. Note that with comments, and make curl_read_cb drop the lock before invoking the callback. Likewise for curl_find_buf, where the callback can be invoked by the caller. Cc: qemu-sta...@nongnu.org Cc: jc...@redha

[Qemu-devel] [PATCH 3/4] curl: avoid recursive locking of BDRVCURLState mutex

The curl driver has a ugly hack where, if it cannot find an empty CURLState, it just uses aio_poll to wait for one to be empty. This is probably buggy when used together with dataplane, and a fix is in the next patch. A more immediate effect of the bug however is that it can cause a recursive cal

Re: [Qemu-devel] [PATCH 5/5] 9pfs: local: forbid client access to metadata

On Fri, 5 May 2017 12:13:52 -0500 Eric Blake wrote: > On 05/05/2017 09:37 AM, Greg Kurz wrote: > > When using the mapped-file security mode, we shouldn't let the client > > mess with the metadata. The current code already hides it but the > > client can still access the metadata through several o

Re: [Qemu-devel] [PATCH RESEND V3 5/6] migration: calculate downtime on dst side

* Peter Xu (pet...@redhat.com) wrote: > On Mon, May 08, 2017 at 12:08:07PM +0300, Alexey wrote: > > On Mon, May 08, 2017 at 02:29:06PM +0800, Peter Xu wrote: > > > On Fri, Apr 28, 2017 at 02:11:19PM +0300, Alexey Perevalov wrote: > > > > On 04/28/2017 01:00 PM, Peter Xu wrote: > > > > >On Fri, Apr

[Qemu-devel] [PATCH 2/2] docs/qdev-device-use.txt: update section Default Devices

Resynchronize the table of default device suppressions with vl.c's default_list[]. Signed-off-by: Markus Armbruster --- docs/qdev-device-use.txt | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/docs/qdev-device-use.txt b/docs/qdev-device-use.txt index caf779b..f9f9eaa

Re: [Qemu-devel] [PATCH v7 3/4] qemu-img: introduce --target-image-opts for 'convert' command

On Wed, May 03, 2017 at 09:50:49PM +0200, Max Reitz wrote: > On 02.05.2017 16:47, Daniel P. Berrange wrote: > > The '--image-opts' flag indicates whether the source filename > > includes options. The target filename has to remain in the > > plain filename format though, since it needs to be passed

[Qemu-devel] [PATCH 0/2] docs: Minor updates around ide-drive

Markus Armbruster (2): docs qemu-doc: Avoid ide-drive, it's deprecated docs/qdev-device-use.txt: update section Default Devices docs/bootindex.txt | 2 +- docs/qdev-device-use.txt | 13 +++-- qemu-options.hx | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-) --

Re: [Qemu-devel] [PATCH 0/5] 9pfs: local: fix metadata of mapped-file security mode

On Mon, 8 May 2017 17:33:43 +0200 Leo Gaspard wrote: > Greg, > > I just tested on 2.9.0 with the 5 patches applied, and it appears to > work on my setup, thanks! > > Just a side note: .virtfs_metadata_root is set as u=rwx on the host file > system (the "ret = fchmod(map_fd, 0700);" line in patc

[Qemu-devel] [PATCH 1/2] docs qemu-doc: Avoid ide-drive, it's deprecated

Suggested-by: Thomas Huth Signed-off-by: Markus Armbruster --- docs/bootindex.txt | 2 +- docs/qdev-device-use.txt | 4 ++-- qemu-options.hx | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/bootindex.txt b/docs/bootindex.txt index b9a8ba1..6937862 100644

Re: [Qemu-devel] [PATCH RESEND V3 5/6] migration: calculate downtime on dst side

On Tue, May 09, 2017 at 10:40:34AM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Mon, May 08, 2017 at 12:08:07PM +0300, Alexey wrote: > > > On Mon, May 08, 2017 at 02:29:06PM +0800, Peter Xu wrote: > > > > On Fri, Apr 28, 2017 at 02:11:19PM +0300, Alexey Pereva

Re: [Qemu-devel] [PATCH 0/2] docs: Minor updates around ide-drive

I mis-pasted cc: Thomas. Sorry for the inconvenience.

[Qemu-devel] [PATCH v8 1/4] qemu-img: add support for --object with 'dd' command

The qemu-img dd command added --image-opts support, but missed the corresponding --object support. This prevented passing secrets (eg auth passwords) needed by certain disk images. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- qemu

[Qemu-devel] [PATCH v8 0/4] Improve convert and dd commands

Update to v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05699.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg00728.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg04391.html v4: https://lists.gnu.org/archive/html/qemu-devel/2017-04/msg021

[Qemu-devel] [PATCH v8 4/4] qemu-img: copy *key-secret opts when opening newly created files

The qemu-img dd/convert commands will create an image file and then try to open it. Historically it has been possible to open new files without passing any options. With encrypted files though, the *key-secret options are mandatory, so we need to provide those options when opening the newly created

[Qemu-devel] [PATCH v8 2/4] qemu-img: fix --image-opts usage with dd command

The --image-opts flag can only be used to affect the parsing of the source image. The target image has to be specified in the traditional style regardless, since it needs to be passed to the bdrv_create() API which does not support the new style opts. Reviewed-by: Fam Zheng Reviewed-by: Max Reitz

[Qemu-devel] [PATCH v8 3/4] qemu-img: introduce --target-image-opts for 'convert' command

The '--image-opts' flag indicates whether the source filename includes options. The target filename has to remain in the plain filename format though, since it needs to be passed to bdrv_create(). When using --skip-create though, it would be possible to use image-opts syntax. This adds --target-im

Re: [Qemu-devel] [PATCH 1/2] docs qemu-doc: Avoid ide-drive, it's deprecated

On 09.05.2017 11:41, Markus Armbruster wrote: > Suggested-by: Thomas Huth > Signed-off-by: Markus Armbruster > --- > docs/bootindex.txt | 2 +- > docs/qdev-device-use.txt | 4 ++-- > qemu-options.hx | 2 +- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/docs/

Re: [Qemu-devel] [Qemu-ppc] Floating point unit bugs

On Tue, 9 May 2017, Aurelien Jarno wrote: | main.c: In function 'print_fpscr_settings': | main.c:73:26: warning: suggest parentheses around comparison in operand of '&' [-Wparentheses] | if ((fpscr >> i) & 0x1 == 1) { | ^ Actually the compiler is correct here

Re: [Qemu-devel] [PATCH 2/2] docs/qdev-device-use.txt: update section Default Devices

On 09.05.2017 11:41, Markus Armbruster wrote: > Resynchronize the table of default device suppressions with vl.c's > default_list[]. > > Signed-off-by: Markus Armbruster > --- > docs/qdev-device-use.txt | 9 + > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/docs/qdev-

Re: [Qemu-devel] [PATCH 1/3] hw/block: Introduce rotational qdev property

Am 06.05.2017 um 14:43 hat Aurelien Jarno geschrieben: > The Linux kernel uses different I/O scheduler depending if the block > device is a rotational device or not. Also it uses rotational devices > to add entropy to the random pool. > > This patch add a rotational qdev property so that the block

Re: [Qemu-devel] [PATCH 0/4] curl: locking cleanups and fixes

No I'm afraid this patch series does not fix the bug. The stack trace is below. Rich. Thread 4 (Thread 0x7f8595cf1700 (LWP 11235)): #0 0x7f86348e6700 in do_futex_wait () at /lib64/libpthread.so.0 #1 0x7f86348e6813 in __new_sem_wait_slow () at /lib64/libpthread.so.0 #2 0x5610e4585

[Qemu-devel] [PATCH RFC] target/s390x: improve SIGP to add SMP support

This patch adds *very rough* SMP support to the s390x target, and make it possible to use MTTCG, when used with the various atomic patches posted on the mailing list. I haven't done any advanced test, so there is certainly more atomic issues to fix. Anyway this patch is nothing more than a way to

[Qemu-devel] [PATCH] vga: fix display update region calculation

vga display update mis-calculated the region for the dirty bitmap snapshot in case the scanlines are padded. This can triggere an assert in cpu_physical_memory_snapshot_get_dirty(). Fixes: fec5e8c92becad223df9d972770522f64aafdb72 Reported-by: Kevin Wolf Reported-by: 李强 Signed-off-by: Gerd Hoffm

[Qemu-devel] [Bug 1689499] Re: copy-storage-all/inc does not easily converge with load going on

Interesting. That's quite a big difference, so if you could bisect it down it would be interesting to figure out where the change occurred. What happens if you just make it a 'disk' workload without the memory stress? What network interface (1G/10G etc) are you migrating over and what bandwidth

[Qemu-devel] [PATCH 1/2] block: Clarify documentation of BlockInfo member io-status

Say "SCSI except scsi-generic" instead of "scsi-disk", because scsi-disk could mean either scsi-disk.c (which is correct) or device model scsi-disk (which would be incorrect). Signed-off-by: Markus Armbruster --- qapi/block-core.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH 0/2] scsi: Minor cleanups around scsi-disk

Markus Armbruster (2): block: Clarify documentation of BlockInfo member io-status virtio-scsi-test: Use scsi-hd instead of legacy scsi-disk qapi/block-core.json | 3 ++- tests/virtio-scsi-test.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) -- 2.7.4

[Qemu-devel] [PATCH 2/2] virtio-scsi-test: Use scsi-hd instead of legacy scsi-disk

Signed-off-by: Markus Armbruster --- tests/virtio-scsi-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c index 0eabd56..27ef7c0 100644 --- a/tests/virtio-scsi-test.c +++ b/tests/virtio-scsi-test.c @@ -149,7 +149,7 @@ sta

Re: [Qemu-devel] [PATCH 0/2] scsi: Minor cleanups around scsi-disk

On 09/05/2017 12:56, Markus Armbruster wrote: > Markus Armbruster (2): > block: Clarify documentation of BlockInfo member io-status > virtio-scsi-test: Use scsi-hd instead of legacy scsi-disk > > qapi/block-core.json | 3 ++- > tests/virtio-scsi-test.c | 2 +- > 2 files changed, 3 inser

[Qemu-devel] [PATCH] usb-redir: fix stack overflow in usbredir_log_data

Don't reinvent a broken wheel, just use the hexdump function we have. Impact: low, broken code doesn't run unless you have debug logging enabled. Reported-by: 李强 Signed-off-by: Gerd Hoffmann --- hw/usb/redirect.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a

[Qemu-devel] [PATCH] sm501: make display updates thread safe

Signed-off-by: Gerd Hoffmann --- hw/display/sm501.c | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/hw/display/sm501.c b/hw/display/sm501.c index 2094adbc9c..9d254ef2e1 100644 --- a/hw/display/sm501.c +++ b/hw/display/sm501.c @@ -1414,6 +1414,7 @@

[Qemu-devel] [PATCH v3 2/2] i386: expose "TCGTCGTCGTCG" in the 0x40000000 CPUID leaf

Currently when running KVM, we expose "KVMKVMKVM\0\0\0" in the 0x4000 CPUID leaf. Other hypervisors (VMWare, HyperV, Xen, BHyve) all do the same thing, which leaves TCG as the odd one out. The CPUID signature is used by software to detect which virtual environment they are running in and (pote

[Qemu-devel] [PATCH v3 0/2] Support CPUID signature for TCG

This enables report of a signature in CPUID for the TCG interpretor. Changed in v3: - Simplify CPU limit code still further (Eduardo) Changed in v2: - Rewrite the way we bounds check / cap the CPUID index to use a flat switch, instead of nested ifs (Eduardo) - Add a 'tcg-cpuid' property t

[Qemu-devel] [PATCH v3 1/2] i386: rewrite way CPUID index is validated

Change the nested if statements into a flat format, to make it clearer what validation / capping is being performed on different CPUID index values. Signed-off-by: Daniel P. Berrange --- target/i386/cpu.c | 35 +++ 1 file changed, 15 insertions(+), 20 deletions(-)

Re: [Qemu-devel] [PATCH v4 2/2] ramblock: add new hmp command "info ramblock"

On Mon, May 08, 2017 at 08:21:33PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > To dump information about ramblocks. It looks like: > > > > (qemu) info ramblock > > Block NamePSize Offset Used > > Total

  1   2   3   4   >