Re: [Qemu-devel] What is the best commit for record-replay?

2017-04-25 Thread Igor R
>> Hi, >> >> I'm trying to use the deterministic record/replay feature, and I would >> like to know which commit I should take to get it work. >> In RC0 it seems to be broken. I tried pre-MTTCG commit 2421f381dc, as > Can you retry with the latest rc? There were some fixes regarding rr since > rc

Re: [Qemu-devel] [PATCH 1/2] qemu-img: make sure contain the consecutive number of zero bytes

2017-04-25 Thread Eric Blake
On 04/24/2017 08:50 PM, 858585 jemmy wrote: > On Mon, Apr 24, 2017 at 10:43 PM, Eric Blake wrote: >> On 04/23/2017 09:33 AM, jemmy858...@gmail.com wrote: >>> From: Lidong Chen >>> >>> is_allocated_sectors_min don't guarantee to contain the >>> consecutive number of zero bytes. this patch fixes th

Re: [Qemu-devel] [RFC v2 2/6] pci: Move pci_bus_init() logic to pci_bus_new_inplace()

2017-04-25 Thread Eduardo Habkost
On Wed, Apr 19, 2017 at 09:31:57PM +0300, Marcel Apfelbaum wrote: > On 04/19/2017 01:17 AM, Eduardo Habkost wrote: > > Instead of having 3 separate functions, just make pci_bus_new() a > > wrapper that allocates the object and calls pci_bus_new_inplace(). > > > > Cc: "Michael S. Tsirkin" > > Cc:

Re: [Qemu-devel] [PATCH v2 9/9] tpm: Added support for TPM emulator

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: This change introduces a new TPM backend driver that can communicate with swtpm(software TPM emulator) using unix domain socket interface. Swtpm uses two unix sockets, one for plain TPM commands and responses, and one for out-of-band control messag

[Qemu-devel] [PATCH v1 0/8] Refactor DMG driver to have chunk size independence

2017-04-25 Thread Ashijeet Acharya
This series helps to provide chunk size independence for DMG driver to prevent denial-of-service in cases where untrusted files are being accessed by the user. This task is mentioned on the public block ToDo Here -> http://wiki.qemu.org/ToDo/Block/DmgChunkSizeIndependence Patch 1 introduces a new

[Qemu-devel] [PATCH v1 1/8] dmg: Introduce a new struct to cache random access points

2017-04-25 Thread Ashijeet Acharya
We need to cache the random access point while performing partial decompression so that we can resume decompression from that point onwards in our next sequential read request. Introduce a new struct DMGReadState which will help us do this. Signed-off-by: Ashijeet Acharya --- block/dmg.h | 10 ++

[Qemu-devel] [PATCH v1 4/8] dmg: Refactor and prepare dmg_read_chunk() to cache random access points

2017-04-25 Thread Ashijeet Acharya
Refactor dmg_read_chunk() to start making use of the new DMGReadState structure and do chunk and sector related calculations based on it. Add a new argument "DMGReadState *drs" to it. Signed-off-by: Ashijeet Acharya --- block/dmg.c | 153 --

[Qemu-devel] [PATCH v1 2/8] dmg: New function to help us cache random access point

2017-04-25 Thread Ashijeet Acharya
Introduce a new cache_access_point() function which will help us first cache a random access point inside a compressed stream and then keep updating it according to our requirement at appropriate times. Signed-off-by: Ashijeet Acharya --- block/dmg.c | 18 ++ 1 file changed, 18 i

[Qemu-devel] [PATCH v1 3/8] dmg: Limit the output buffer size to a max of 2MB

2017-04-25 Thread Ashijeet Acharya
The size of the output buffer is limited to a maximum of 2MB so that QEMU doesn't end up allocating huge amounts of memory while decompressing compressed input streams. 2MB is an appropriate size because "qemu-img convert" has the same I/O buffer size and the most important use case for DMG files

[Qemu-devel] [PATCH v1 5/8] dmg: Handle zlib compressed chunks

2017-04-25 Thread Ashijeet Acharya
Set the output buffer size to be equal to the size of number of sectors stored in @sectors_read. Start inflating to a max output buffer size of 2MB and cache our access point to aid random access later if required. Signed-off-by: Ashijeet Acharya --- block/dmg.c | 48

[Qemu-devel] [PATCH v1 8/8] dmg: Remove the error messages to allow wild images

2017-04-25 Thread Ashijeet Acharya
We have refactored the DMG driver to accept and process images irrespective of their chunk sizes since we now have limit of 2MB on our output buffer size. Thus QEMU will not allocate huge amounts of memory no matter what the chunk size is. Remove the error messages to prevent denial-of-service in

[Qemu-devel] [PATCH v1 6/8] dmg: Handle bz2 compressed/raw/zeroed chunks

2017-04-25 Thread Ashijeet Acharya
We do not need to cache the access point for these chunks but need to update our various supporting variables like chunk, sectors_read etc. to keep maintaining our code structure. Call cache_access_point() after reading chunks of these types. Signed-off-by: Ashijeet Acharya --- block/dmg.c | 18

Re: [Qemu-devel] [PATCH 1/2] qemu-img: make sure contain the consecutive number of zero bytes

2017-04-25 Thread Max Reitz
On 25.04.2017 03:50, 858585 jemmy wrote: > On Mon, Apr 24, 2017 at 10:43 PM, Eric Blake wrote: >> On 04/23/2017 09:33 AM, jemmy858...@gmail.com wrote: >>> From: Lidong Chen >>> >>> is_allocated_sectors_min don't guarantee to contain the >>> consecutive number of zero bytes. this patch fixes this

[Qemu-devel] [PATCH v1 7/8] dmg: Refactor dmg_co_preadv() to start reading multiple sectors

2017-04-25 Thread Ashijeet Acharya
At the moment, dmg_co_preadv() reads one sector at a time. Make it read multiple sectors at a time depending on the number of sectors stored in "drs->sectors_read". This does not provide any significant optimization in the I/O process of DMG but is still a nicer way. Adjust the 'data' variable dep

Re: [Qemu-devel] [PATCH] tcg/i386: Do not display HT warning for TCG

2017-04-25 Thread Eduardo Habkost
On Fri, Apr 21, 2017 at 11:38:30AM +0200, Paolo Bonzini wrote: > > > On 20/04/2017 20:42, Eduardo Habkost wrote: > >> -smp 4,threads=4 shows 4 cores > > This means 1 socket with 1 core, 4 threads per core. But if > > vendor ID is AMD, guests will probably ignore the hyperthreading > > info and tr

Re: [Qemu-devel] [PATCH] RFC: vmcoreinfo device

2017-04-25 Thread Eduardo Habkost
On Mon, Apr 24, 2017 at 05:03:55PM +0400, Marc-André Lureau wrote: [...] > diff --git a/include/hw/compat.h b/include/hw/compat.h > index 5d5be91daf..d0c9b71902 100644 > --- a/include/hw/compat.h > +++ b/include/hw/compat.h > @@ -135,6 +135,10 @@ > .driver = "vmgenid",\ > .prope

Re: [Qemu-devel] [PATCH v3 3/3] vfio-pci: process non fatal error of AER

2017-04-25 Thread Michael S. Tsirkin
On Tue, Mar 28, 2017 at 08:55:04PM -0600, Alex Williamson wrote: > On Wed, 29 Mar 2017 02:59:34 +0300 > "Michael S. Tsirkin" wrote: > > > On Tue, Mar 28, 2017 at 10:12:25AM -0600, Alex Williamson wrote: > > > On Tue, 28 Mar 2017 21:49:17 +0800 > > > Cao jin wrote: > > > > > > > On 03/25/2017

Re: [Qemu-devel] [PATCH] RFC: vmcoreinfo device

2017-04-25 Thread Michael S. Tsirkin
On Tue, Apr 25, 2017 at 05:29:20PM -0300, Eduardo Habkost wrote: > On Mon, Apr 24, 2017 at 05:03:55PM +0400, Marc-André Lureau wrote: > [...] > > diff --git a/include/hw/compat.h b/include/hw/compat.h > > index 5d5be91daf..d0c9b71902 100644 > > --- a/include/hw/compat.h > > +++ b/include/hw/compat.

Re: [Qemu-devel] [PATCH v4] qga: Add support network interface statistics in

2017-04-25 Thread Michael Roth
Quoting ZhiPeng Lu (2017-04-25 03:12:20) > we can get the network interface statistics inside a virtual machine by > guest-network-get-interfaces command. it is very useful for us to monitor > and analyze network traffic. > > Signed-off-by: ZhiPeng Lu > Signed-off-by: Daniel P. Berrange > --- >

Re: [Qemu-devel] [PATCH v5 1/1] qga: Add 'guest-get-users' command

2017-04-25 Thread Michael Roth
Quoting Vinzenz 'evilissimo' Feenstra (2017-04-19 04:26:15) > From: Vinzenz Feenstra > > A command that will list all currently logged in users, and the time > since when they are logged in. > > Examples: > > virsh # qemu-agent-command F25 '{ "execute": "guest-get-users" }' > {"return":[{"login

Re: [Qemu-devel] [PATCH v6 1/1] qga: Add `guest-get-timezone` command

2017-04-25 Thread Michael Roth
Quoting Vinzenz 'evilissimo' Feenstra (2017-04-19 05:52:58) > From: Vinzenz Feenstra > > Adds a new command `guest-get-timezone` reporting the currently > configured timezone on the system. The information on what timezone is > currently is configured is useful in case of Windows VMs where the >

[Qemu-devel] [PATCH v4] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs

2017-04-25 Thread Geert Martin Ijewski
If no crypto library is included in the build, QEMU uses qcrypto_random_bytes() to generate random data. That function tried to open /dev/urandom or /dev/random and if opening both files failed it errored out. Those files obviously do not exist on windows, so there the code uses CryptGenRandom().

Re: [Qemu-devel] [PATCH v4] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs

2017-04-25 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Subject: [Qemu-devel] [PATCH v4] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs Type: series Message-id: 1493157212-22070-1-git-send-email-gm.ijew...@web.de === TEST SCRIPT BEGIN === #

[Qemu-devel] [PATCH 03/41] migration: Remove MigrationState from migration_channel_incomming()

2017-04-25 Thread Juan Quintela
All callers were calling migrate_get_current(), so do it inside the function. Signed-off-by: Juan Quintela --- migration/channel.c | 5 +++-- migration/channel.h | 3 +-- migration/exec.c| 2 +- migration/fd.c | 2 +- migration/socket.c | 3 +-- migration/tls.c | 2 +- 6 files chan

[Qemu-devel] [PATCH 00/41] Migration cleanup

2017-04-25 Thread Juan Quintela
Hi In this second version: - Move inclnude files to migration/ instead of include/migration/ - Split misc patches to other series - Split MigrationParams to other series - Split HMP commands to other series - Make migration.h private - Create include/migration/misc.h for functions that don't belon

[Qemu-devel] [PATCH 06/41] migration: Move colo.h to migration/

2017-04-25 Thread Juan Quintela
There are functions only used by migration code. Signed-off-by: Juan Quintela --- MAINTAINERS | 2 +- migration/colo-comm.c | 2 +- migration/colo-failover.c | 2 +- {include/migration => migration}/colo.h | 0 migration/migration.c

[Qemu-devel] [PATCH 07/41] migration: Move failover.h to migration/colo-failover.h

2017-04-25 Thread Juan Quintela
This file is internal for migration/colo code. Signed-off-by: Juan Quintela --- MAINTAINERS | 2 +- migration/colo-failover.c | 2 +- include/migration/failover.h => migration/colo-failover.h | 0 migration/colo.c

[Qemu-devel] [PATCH 02/41] migration: Split migration/channel.c for channel operations

2017-04-25 Thread Juan Quintela
Create an include for its exported functions. Signed-off-by: Juan Quintela --- include/migration/migration.h | 7 - migration/Makefile.objs | 2 +- migration/channel.c | 69 +++ migration/channel.h | 25 mig

[Qemu-devel] [PATCH 01/41] migration: Create migration/blocker.h

2017-04-25 Thread Juan Quintela
This allows us to remove lots of includes of migration/migration.h Signed-off-by: Juan Quintela --- block/qcow.c | 2 +- block/vdi.c | 2 +- block/vhdx.c | 2 +- block/vmdk.c |

[Qemu-devel] [PATCH 16/41] migration: Rename {save, load}_vmstate to {save, load}_snapshot

2017-04-25 Thread Juan Quintela
It reflects what they do. And make it easier to not confuse with vmstate_{save,load}_state. Signed-off-by: Juan Quintela --- hmp.c| 4 ++-- include/block/block_int.h| 4 ++-- include/migration/snapshot.h | 4 ++-- migration/savevm.c | 4 ++-- replay/replay-

[Qemu-devel] [PATCH 08/41] migration: Move page_cache.c to migration/

2017-04-25 Thread Juan Quintela
It is only used by migration, so move it there. Signed-off-by: Juan Quintela --- Makefile.objs | 1 - migration/Makefile.objs | 2 +- page_cache.c => migration/page_cache.c| 0 {include/migration => migration}/page_cache.h | 0 tests/

[Qemu-devel] [PATCH 04/41] migration: Export qemu-file-channel.c functions in its own file

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 + include/migration/qemu-file.h | 4 migration/channel.c | 1 + migration/colo.c | 1 + migration/migration.c | 1 + migration/qemu-file-channel.c | 1 + migration/qemu-file-channel.h | 2

[Qemu-devel] [PATCH 09/41] migration: Move qjson.h to migration/

2017-04-25 Thread Juan Quintela
It is only used for migration code. Signed-off-by: Juan Quintela --- migration/qjson.c| 2 +- {include/migration => migration}/qjson.h | 0 migration/vmstate.c | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename {include/migration => migr

[Qemu-devel] [PATCH 15/41] migration: Create include for migration snapshots

2017-04-25 Thread Juan Quintela
Start removing migration code from sysemu/sysemu.h. Signed-off-by: Juan Quintela --- hmp.c| 1 + include/migration/snapshot.h | 20 include/sysemu/sysemu.h | 3 --- migration/savevm.c | 1 + replay/replay-snapshot.c | 1 + vl.c

[Qemu-devel] [PATCH 12/41] migration: Remove qemu-file.h from vmstate.h

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- minor rearangements due to the rebase Signed-off-by: Juan Quintela --- include/hw/hw.h | 1 + include/migration/vmstate.h | 3 --- migration/block.c | 1 + migration/colo.c| 1 + migration/p

[Qemu-devel] [PATCH 20/41] migration: Export exec.c functions in its own file

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 4 migration/exec.c | 1 + migration/exec.h | 20 migration/migration.c | 1 + 4 files changed, 22 insertions(+), 4 deletions(-) create mode 100644 migration/exec.h di

[Qemu-devel] [PATCH 14/41] migration: migration.h was not needed

2017-04-25 Thread Juan Quintela
This files don't use any function from migration.h, so drop it. Signed-off-by: Juan Quintela --- block/qed.c | 1 - hw/i386/pc_q35.c| 1 - hw/virtio/vhost-user.c | 1 - hw/virtio/vhost-vsock.c | 1 - hw/virtio/virtio.c | 1 - monitor.c | 1 - 6 files chang

[Qemu-devel] [PATCH 05/41] migration: Remove migration.h from colo.h

2017-04-25 Thread Juan Quintela
migration.h is not included in any includes now. Signed-off-by: Juan Quintela --- include/migration/colo.h | 1 - migration/colo-comm.c| 3 ++- migration/colo.c | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/include/migration/colo.h b/include/migration/colo.h i

[Qemu-devel] [PATCH 11/41] migration: Split vmstate-types.c from vmstate.c

2017-04-25 Thread Juan Quintela
Now one just has the interperter, and the other has the basic types. Once there, add copyright boilerplate. Signed-off-by: Juan Quintela --- migration/Makefile.objs | 2 +- migration/vmstate-types.c | 676 ++ migration/vmstate.c | 669 ++-

[Qemu-devel] [PATCH 19/41] migration: Remove unneeded includes of migration/vmstate.h

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/core/qdev.c | 1 - include/hw/acpi/memory_hotplug.h | 1 - include/hw/acpi/pcihp.h | 1 - include/hw/pci/shpc.h| 1 - include/net/net.h| 1 - target/alpha/cpu.c | 1 - target/hppa/cpu.c

[Qemu-devel] [PATCH 24/41] migration: Export ram.c functions in its own file

2017-04-25 Thread Juan Quintela
All functions are internal except for ram_mig_init(). Create migration/misc.h for this kind of functions. Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert --- include/migration/migration.h | 39 -- include/migration/misc.h | 21 +

[Qemu-devel] [PATCH 10/41] migration: Move postcopy-ram.h to migration/

2017-04-25 Thread Juan Quintela
It is internal to migration, not intended for other users. Signed-off-by: Juan Quintela --- migration/migration.c | 2 +- migration/postcopy-ram.c| 2 +- {include/migration => migration}/postcopy-ram.h | 0 migration/ram.c

[Qemu-devel] [PATCH 17/41] migration: Create savevm.h for functions exported from savevm.c

2017-04-25 Thread Juan Quintela
This removes last trace of migration functions from sysemu/sysemu.h. Signed-off-by: Juan Quintela --- include/sysemu/sysemu.h | 47 --- migration/colo.c | 1 + migration/migration.c| 1 + migration/postcopy-ram.c | 1 + migration/savevm

[Qemu-devel] [PATCH 30/41] migration: Move dump_vmsate_json_to_file() to misc.h

2017-04-25 Thread Juan Quintela
It was not from vmstate.c to start with. Signed-off-by: Juan Quintela --- include/migration/misc.h| 4 include/migration/vmstate.h | 2 -- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/include/migration/misc.h b/include/migration/misc.h index 45ef9c9..21a9182 100644 ---

[Qemu-devel] [PATCH 13/41] migration: Remove vmstate.h from migration.h

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela Reviewed-by: Dr. David Alan Gilbert -- Minor rearrangements due to rebase Signed-off-by: Juan Quintela --- include/migration/migration.h | 1 - migration/block.c | 1 + migration/colo-comm.c | 1 + migration/migration.c | 1 + migratio

[Qemu-devel] [PATCH 27/41] migration: Move self_announce_delay() to misc.h

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/net/virtio-net.c | 1 + include/migration/misc.h| 10 ++ include/migration/vmstate.h | 10 -- migration/savevm.c | 1 + 4 files changed, 12 insertions(+), 10 deletions(-) diff --git a/hw/net/virtio-net.c b/hw/net/virtio-n

[Qemu-devel] [PATCH 22/41] migration: Export socket.c functions in its own file

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 8 migration/migration.c | 1 + migration/socket.c| 1 + migration/socket.h| 25 + 4 files changed, 27 insertions(+), 8 deletions(-) create mode 100644 migration/s

[Qemu-devel] [PATCH 31/41] migration: Move postcopy stuff to postcopy-ram.c

2017-04-25 Thread Juan Quintela
Yes, we don't have a good place to put that stuff. Signed-off-by: Juan Quintela --- include/migration/migration.h | 25 - migration/migration.c | 18 -- migration/postcopy-ram.c | 18 ++ migration/postcopy-ram.h | 26 +

[Qemu-devel] [PATCH 18/41] migration: Split qemu-file.h

2017-04-25 Thread Juan Quintela
Split the file into public and internal interfaces. I have to rename the external one because we can't have two include files with the same name in the same directory. Build system gets confused. The only exported functions are the ones that handle basic types. Signed-off-by: Juan Quintela ---

[Qemu-devel] [PATCH 29/41] migration: loadvm_free_handlers is only used in migration/

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/vmstate.h | 2 -- migration/savevm.h | 2 ++ 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h index 6b7031f..afa43ac 100644 --- a/include/migration/vmstate.h +++ b/i

[Qemu-devel] [PATCH 23/41] migration: Export tls.c functions in its own file

2017-04-25 Thread Juan Quintela
Just for the functions exported from tls.c. Notice that we can't remove the migration/migration.h include from tls.c because it access directly MigrationState for the tls params. Signed-off-by: Juan Quintela --- include/migration/migration.h | 10 -- migration/channel.c | 1 +

[Qemu-devel] [PATCH 32/41] migration: Move constants to savevm.h

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 15 --- migration/savevm.h| 15 +++ migration/vmstate.c | 1 + tests/test-vmstate.c | 1 + 4 files changed, 17 insertions(+), 15 deletions(-) diff --git a/include/migration/m

[Qemu-devel] [PATCH 34/41] migration: ram_control_* are implemented in qemu_file

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 18 -- migration/qemu-file.h | 17 + 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/include/migration/migration.h b/include/migration/migration.h index 9884be6..7bd87f8 10064

[Qemu-devel] [PATCH 21/41] migration: Export fd.c functions in its own file

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 4 migration/fd.c| 1 + migration/fd.h| 20 migration/migration.c | 1 + 4 files changed, 22 insertions(+), 4 deletions(-) create mode 100644 migration/fd.h diff

[Qemu-devel] [PATCH 25/41] migration: Export rdma.c functions in its own file

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/migration.h | 4 migration/migration.c | 1 + migration/rdma.c | 1 + migration/rdma.h | 22 ++ 4 files changed, 24 insertions(+), 4 deletions(-) create mode 100644 migration/rdma.h

[Qemu-devel] [PATCH 39/41] exec: Create include for target_page_size()

2017-04-25 Thread Juan Quintela
That is the only function that we need from exec.c, and having to include the whole sysemu.h for this. Signed-off-by: Juan Quintela --- exec.c | 1 + include/exec/target_page.h | 20 include/sysemu/sysemu.h| 1 - migration/migration.c | 1 + m

[Qemu-devel] [PATCH 33/41] migration: Commands are only used inside migration.c

2017-04-25 Thread Juan Quintela
So, move them there. Notice that we export functions that send commands, not the command themselves. Signed-off-by: Juan Quintela --- include/migration/migration.h | 15 -- migration/migration.c | 46 +++ 2 files changed, 29 insertions

[Qemu-devel] [PATCH 28/41] migration: Split registration functions from vmstate.h

2017-04-25 Thread Juan Quintela
They are indpendent, and nowadays almost every device register things with qdev->vmsd. Signed-off-by: Juan Quintela --- hw/net/vmxnet3.c | 1 + hw/ppc/spapr.c | 1 + hw/s390x/s390-skeys.c| 1 + hw/s390x/s390-virtio-ccw.c | 1 + include/migration/register.h

[Qemu-devel] [PATCH 26/41] migration: Move include/migration/block.h into migration/

2017-04-25 Thread Juan Quintela
All functions were internal, except blk_mig_init() that is exported in misc.h now. Signed-off-by: Juan Quintela --- include/migration/misc.h | 4 migration/block.c| 3 ++- {include/migration => migration}/block.h | 1 - migration/migration.c

[Qemu-devel] [PATCH 38/41] migration: Move migration.h to migration/

2017-04-25 Thread Juan Quintela
Nothing uses it outside of migration.h Signed-off-by: Juan Quintela --- migration/block.c| 2 +- migration/channel.c | 2 +- migration/colo-comm.c| 2 +- migration/colo.c | 2 +- migration/ex

[Qemu-devel] [PATCH 35/41] migration: create global_state.c

2017-04-25 Thread Juan Quintela
It don't belong anywhere else, just the global state where everybody can stick other things. Signed-off-by: Juan Quintela --- hw/i386/pc_piix.c| 1 + hw/ppc/spapr.c | 1 + include/migration/global_state.h | 26 +++ include/migration/migration.h| 4

[Qemu-devel] [PATCH 40/41] migration: Make savevm.c target independent

2017-04-25 Thread Juan Quintela
It only needed TARGET_PAGE_SIZE/BITS/BITS_MIN values, so just export them from exec.h Signed-off-by: Juan Quintela --- Makefile.target| 2 +- exec.c | 9 + include/exec/target_page.h | 2 ++ migration/Makefile.objs| 2 +- migration/savevm.c

[Qemu-devel] [PATCH 41/41] migration: Remove unneeded includes

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- include/migration/misc.h | 2 ++ migration/block.c | 6 -- migration/colo-failover.c | 2 ++ migration/colo.c | 2 -- migration/colo.h | 3 --- migration/exec.c | 2 -- migration/fd.c| 2 -- migration/global_stat

[Qemu-devel] [PATCH 36/41] migration: Move more exported functions to migration/misc.h

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/i386/pc_piix.c | 2 +- hw/ppc/spapr.c| 2 +- include/migration/migration.h | 6 -- include/migration/misc.h | 6 ++ migration/migration.c | 1 + qdev-monitor.c| 2 +- vl.c

Re: [Qemu-devel] [PATCH v4] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs

2017-04-25 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 1493157212-22070-1-git-send-email-gm.ijew...@web.de Subject: [Qemu-devel] [PATCH v4] crypto: qcrypto_random_bytes(

[Qemu-devel] [PATCH 37/41] migration: Move last funtions to misc.h

2017-04-25 Thread Juan Quintela
After this, nothing outside of migration uses migration.h Signed-off-by: Juan Quintela --- include/migration/migration.h | 7 --- include/migration/misc.h | 8 +++- ui/spice-core.c | 2 +- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/include/migration

Re: [Qemu-devel] [PATCH 1/4] migration: alternative way to set instance_id in SaveStateEntry

2017-04-25 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-04-24 17:08:25) > From: Jianjun Duan > > In QOM (QEMU Object Model) migrated objects are identified with instance_id > which is calculated automatically using their path in the QOM composition > tree. For some objects, this path could change from source to ta

[Qemu-devel] [PATCH v5] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto libs

2017-04-25 Thread Geert Martin Ijewski
If no crypto library is included in the build, QEMU uses qcrypto_random_bytes() to generate random data. That function tried to open /dev/urandom or /dev/random and if opening both files failed it errored out. Those files obviously do not exist on windows, so there the code uses CryptGenRandom().

[Qemu-devel] [PATCH 03/26] audio: Remove YM3526 support

2017-04-25 Thread Juan Quintela
It was never compiled in. Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 4 ++-- hw/audio/fmopl.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 29f6d3c..1e05efc 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -981,7

[Qemu-devel] [PATCH 02/26] audio: remove Y8950 configuration

2017-04-25 Thread Juan Quintela
Include file has never been on qemu and it has been undefined from the very beginning. Signed-off-by: Juan Quintela --- hw/audio/Makefile.objs | 2 - hw/audio/fmopl.c | 146 - hw/audio/fmopl.h | 20 --- 3 files changed, 168 dele

[Qemu-devel] [PATCH 00/26] Audio Cleanup

2017-04-25 Thread Juan Quintela
Hi This are an old series that were hidden on my harddisk. To give you one idea, I had a patch to remove this: commit 8307c294a355bbf3c5352e00877365b0cda66d52 Author: Nutan Shinde Date: Wed Oct 7 22:02:54 2015 +0530 Remove macros IO_READ_PROTO and IO_WRITE_PROTO And somebody else remove

[Qemu-devel] [PATCH 01/26] adlib: Remove support for YMF262

2017-04-25 Thread Juan Quintela
Notice that the code was supposed to be in the file ymf262.h, that has never been on qemu source tree. Signed-off-by: Juan Quintela --- hw/audio/adlib.c | 45 + 1 file changed, 1 insertion(+), 44 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/a

[Qemu-devel] [PATCH 07/26] audio: remove UINT32

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 14 +++--- hw/audio/fmopl.h | 17 - 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 3d14b45..47754e8 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -122,

[Qemu-devel] [PATCH 13/26] audio: Remove type field

2017-04-25 Thread Juan Quintela
It was not used anymore as now there is only one type of devices. Signed-off-by: Juan Quintela --- hw/audio/adlib.c | 2 +- hw/audio/fmopl.c | 20 hw/audio/fmopl.h | 7 +-- 3 files changed, 10 insertions(+), 19 deletions(-) diff --git a/hw/audio/adlib.c b/hw/audio/adl

[Qemu-devel] [PATCH 04/26] audio: YM3812 was always defined

2017-04-25 Thread Juan Quintela
So, remove the ifdefs. Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 4 hw/audio/fmopl.h | 4 2 files changed, 8 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 1e05efc..282662a 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -30,8 +30,6 @@ * Licens

[Qemu-devel] [PATCH 05/26] audio: Remove UINT8

2017-04-25 Thread Juan Quintela
uint8_t has existed since . all this century? Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 8 hw/audio/fmopl.h | 39 --- 2 files changed, 24 insertions(+), 23 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 282662a..3d

[Qemu-devel] [PATCH 08/26] audio: Remove INT8

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h index b52f039..bede671 100644 --- a/hw/audio/fmopl.h +++ b/hw/audio/fmopl.h @@ -10,7 +10,6 @@ /* compiler dependence */ #ifndef OSD_CPU_H #define OSD_CPU_H -

[Qemu-devel] [PATCH 17/26] audio: GUSword is uint16_t

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/gusemu.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/audio/gusemu.h b/hw/audio/gusemu.h index 1c1a63c..69dadef 100644 --- a/hw/audio/gusemu.h +++ b/hw/audio/gusemu.h @@ -28,11 +28,9 @@ /* data types (need to be adjusted if neither a VC6 nor a

[Qemu-devel] [PATCH 19/26] audio: GUSsample is int16_t

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/gus.c | 2 +- hw/audio/gusemu.h | 12 +--- hw/audio/gusemu_hal.c | 2 +- hw/audio/gusemu_mixer.c | 8 4 files changed, 7 insertions(+), 17 deletions(-) diff --git a/hw/audio/gus.c b/hw/audio/gus.c index 3d08a65..ec103

[Qemu-devel] [PATCH 06/26] audio: remove UINT16

2017-04-25 Thread Juan Quintela
More modernitation. Signed-off-by: Juan Quintela --- hw/audio/fmopl.h | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h index 3df8942..1891a22 100644 --- a/hw/audio/fmopl.h +++ b/hw/audio/fmopl.h @@ -10,7 +10,6 @@ /* compiler dependence */ #ifndef OSD_CPU_H

[Qemu-devel] [PATCH 20/26] audio: OPLSetIRQHandler is not used anywhere

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 5 - hw/audio/fmopl.h | 1 - 2 files changed, 6 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 48db828..f91e700 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -1141,11 +1141,6 @@ void OPLSetTimerHandler(FM_OPL

[Qemu-devel] [PATCH 09/26] audio: remove INT16

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 2 +- hw/audio/fmopl.h | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 47754e8..ebd3dbb 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -984,7 +984,7 @@ static void OPL_

[Qemu-devel] [PATCH 10/26] audio: Remove INT32

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 42 +- hw/audio/fmopl.h | 54 -- 2 files changed, 45 insertions(+), 51 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index ebd3dbb..8f93

[Qemu-devel] [PATCH 18/26] audio: GUSword is uint16_t

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/gusemu_hal.c | 14 +++--- hw/audio/gusemu_mixer.c | 8 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/hw/audio/gusemu_hal.c b/hw/audio/gusemu_hal.c index 444a2bb..3dd7239 100644 --- a/hw/audio/gusemu_hal.c +++ b/hw/au

[Qemu-devel] [PATCH 22/26] audio: IRQHandler is not used anymore

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 4 hw/audio/fmopl.h | 2 -- 2 files changed, 6 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 694a77b..5b8a884 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -260,8 +260,6 @@ static inline void OPL_STATUS_SET(

[Qemu-devel] [PATCH 11/26] audio: Unfold OPLSAMPLE

2017-04-25 Thread Juan Quintela
It was used only once, and now it was always int16_t. Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 2 +- hw/audio/fmopl.h | 11 --- 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 8f935f6..b1cb4b4 100644 --- a/hw/audio/fmop

[Qemu-devel] [PATCH 23/26] audio: UpdateHandler is not used anymore

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 2 -- hw/audio/fmopl.h | 2 -- 2 files changed, 4 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 5b8a884..99d09c5 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -1147,7 +1147,6 @@ int OPLWrite(FM_OPL *OPL,int a,int

[Qemu-devel] [PATCH 12/26] audio: Remove Unused OPL_TYPE_*

2017-04-25 Thread Juan Quintela
Since we removed the previous unused devices, they are not used anymore. Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 16 hw/audio/fmopl.h | 3 --- 2 files changed, 19 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index b1cb4b4..9171001 100644 --- a/hw/a

[Qemu-devel] [PATCH 26/26] audio: Use ARRAY_SIZE from qemu/osdep.h

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index dc9043c..202f752 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -34,15 +34,11 @@ #include //#include "driver.h"

Re: [Qemu-devel] [PATCH 2/4] hw/ppc: migrating the DRC state of hotplugged devices

2017-04-25 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-04-24 17:08:26) > In pseries, a firmware abstraction called Dynamic Reconfiguration > Connector (DRC) is used to assign a particular dynamic resource > to the guest and provide an interface to manage configuration/removal > of the resource associated with it. I

[Qemu-devel] [PATCH 14/26] audio: Remove unused fields

2017-04-25 Thread Juan Quintela
These were used for the remove stuff. Signed-off-by: Juan Quintela --- hw/audio/fmopl.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h index df790a0..8730ead 100644 --- a/hw/audio/fmopl.h +++ b/hw/audio/fmopl.h @@ -76,12 +76,6 @@ typedef struct fm_op

[Qemu-devel] [PATCH 16/26] audio: remove GUSchar

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/gusemu.h | 2 -- hw/audio/gusemu_mixer.c | 8 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/hw/audio/gusemu.h b/hw/audio/gusemu.h index 3a69222..1c1a63c 100644 --- a/hw/audio/gusemu.h +++ b/hw/audio/gusemu.h @@ -30,10 +30,8

[Qemu-devel] [PATCH 15/26] audio: GUSbyte is uint8_t

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/gusemu.h | 6 ++--- hw/audio/gusemu_hal.c | 58 - hw/audio/gusemu_mixer.c | 4 ++-- 3 files changed, 33 insertions(+), 35 deletions(-) diff --git a/hw/audio/gusemu.h b/hw/audio/gusemu.h index 9aec

Re: [Qemu-devel] [PATCH 4/4] migration: spapr: migrate pending_events of spapr state

2017-04-25 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-04-24 17:08:28) > From: Jianjun Duan > > In racing situations between hotplug events and migration operation, > a rtas hotplug event could have not yet be delivered to the source > guest when migration is started. In this case the pending_events of > spapr st

[Qemu-devel] [PATCH 21/26] audio: OPLSetUpdateHandler is not used anywhere

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 6 +- hw/audio/fmopl.h | 1 - 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index f91e700..694a77b 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -1141,11 +1141,7 @@ void OPLSetTim

[Qemu-devel] [PATCH 24/26] audio: Remove unused typedefs

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.h | 4 1 file changed, 4 deletions(-) diff --git a/hw/audio/fmopl.h b/hw/audio/fmopl.h index 8410275..f89af08 100644 --- a/hw/audio/fmopl.h +++ b/hw/audio/fmopl.h @@ -4,10 +4,6 @@ #include typedef void (*OPL_TIMERHANDLER)(int channel,doub

Re: [Qemu-devel] [PATCH] RFC: vmcoreinfo device

2017-04-25 Thread Eduardo Habkost
On Tue, Apr 25, 2017 at 11:35:23PM +0300, Michael S. Tsirkin wrote: > On Tue, Apr 25, 2017 at 05:29:20PM -0300, Eduardo Habkost wrote: > > On Mon, Apr 24, 2017 at 05:03:55PM +0400, Marc-André Lureau wrote: > > [...] > > > diff --git a/include/hw/compat.h b/include/hw/compat.h > > > index 5d5be91daf

[Qemu-devel] [PATCH 25/26] audio: un-export OPLResetChip

2017-04-25 Thread Juan Quintela
Signed-off-by: Juan Quintela --- hw/audio/fmopl.c | 2 +- hw/audio/fmopl.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/audio/fmopl.c b/hw/audio/fmopl.c index 99d09c5..dc9043c 100644 --- a/hw/audio/fmopl.c +++ b/hw/audio/fmopl.c @@ -1036,7 +1036,7 @@ void YM3812UpdateOn

Re: [Qemu-devel] [PATCH 3/4] migration: spapr: migrate ccs_list in spapr state

2017-04-25 Thread Michael Roth
Quoting Daniel Henrique Barboza (2017-04-24 17:08:27) > From: Jianjun Duan > > ccs_list in spapr state maintains the device tree related > information on the rtas side for hotplugged devices. In racing > situations between hotplug events and migration operation, a rtas > hotplug event could be mi

[Qemu-devel] [PULL 8/8] qga: Add `guest-get-timezone` command

2017-04-25 Thread Michael Roth
From: Vinzenz Feenstra Adds a new command `guest-get-timezone` reporting the currently configured timezone on the system. The information on what timezone is currently is configured is useful in case of Windows VMs where the offset of the hardware clock is required to have the same offset. This c

<    1   2   3   4   5   >