Re: [Qemu-devel] [PATCH 1/9] Add ppc.risu file

2017-04-25 Thread G 3
On Apr 25, 2017, at 9:16 AM, Eric Blake wrote: On 04/24/2017 10:17 PM, G 3 wrote: Add the ppc.risu file. It defines the format for various PowerPC instructions. Your emails are missing In-Reply-To and References headers, which means you posted 10 top-level threads instead of 9 replies to

Re: [Qemu-devel] [PATCH for-2.10 05/23] numa: move source of default CPUs to NUMA node mapping into boards

2017-04-25 Thread Andrew Jones
On Wed, Mar 22, 2017 at 02:32:30PM +0100, Igor Mammedov wrote: > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 0cbcbc1..8748d25 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c > @@ -1554,6 +1554,16 @@ static void virt_set_gic_version(Object *obj, const > char *value, Error **errp) > }

[Qemu-devel] QEMU travis builds: can we move the preseed tarball to qemu.org ?

2017-04-25 Thread Peter Maydell
Hi; a recent travis build failure made me notice that our .travis.yml config references a preseed tarball from here: http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz I think this is a bit less than ideal -- we should really be hosting this on qemu.org. Can we arrange to move it

Re: [Qemu-devel] [PATCH RFC] target/openrisc: Support non-busy idle state using PMR SPR

2017-04-25 Thread Richard Henderson
On 04/25/2017 04:18 PM, Stafford Horne wrote: On Tue, Apr 25, 2017 at 12:11:00PM +0200, Richard Henderson wrote: On 04/23/2017 11:54 PM, Stafford Horne wrote: The OpenRISC architecture has the Power Management Register (PMR) special purpose register to manage cpu power states. The interesting

Re: [Qemu-devel] [PATCH v2 11/13] tcx: remove primitives for non-32-bit surfaces

2017-04-25 Thread Peter Maydell
On 21 April 2017 at 09:28, Mark Cave-Ayland wrote: > As all surfaces in QEMU are now either shared or 32-bit ARGB regardless of > the guest depth, remove all non-32-bit primitives from tcx_update_display() > and consequence their implementation which are no longer required. > > Signed-off-by: Mark

Re: [Qemu-devel] [PATCH v2 01/13] cg3: remove TARGET_PAGE_SIZE rounding on dirty page detection

2017-04-25 Thread Peter Maydell
On 21 April 2017 at 09:28, Mark Cave-Ayland wrote: > This was an artifact from very early versions of the code from before the > memory API and is no longer needed. > > Signed-off-by: Mark Cave-Ayland > Reviewed-by: Gerd Hoffmann > --- > hw/display/cg3.c |6 ++ > 1 file changed, 2 inser

Re: [Qemu-devel] QEMU travis builds: can we move the preseed tarball to qemu.org ?

2017-04-25 Thread Daniel P. Berrange
On Tue, Apr 25, 2017 at 03:51:17PM +0100, Peter Maydell wrote: > Hi; a recent travis build failure made me notice that our .travis.yml > config references a preseed tarball from here: > http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz > > I think this is a bit less than ideal -

Re: [Qemu-devel] [PULL 10/11] block: Fix bdrv_co_flush early return

2017-04-25 Thread Peter Maydell
On 11 April 2017 at 13:26, Fam Zheng wrote: > bdrv_inc_in_flight and bdrv_dec_in_flight are mandatory for > BDRV_POLL_WHILE to work, even for the shortcut case where flush is > unnecessary. Move the if block to below bdrv_dec_in_flight, and BTW fix > the variable declaration position. > > Signed-o

Re: [Qemu-devel] [PATCH v2] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-25 Thread Laszlo Ersek
On 04/24/17 22:45, Igor Mammedov wrote: > Since 2.7 commit (b2a575a Add optionrom compatible with fw_cfg DMA version) > regressed migration during firmware exection time by > abusing fwcfg.dma_enabled property to decide loading > dma version of option rom AND by mistake disabling DMA > for 2.6 and

Re: [Qemu-devel] [PULL 0/4] hmp queue

2017-04-25 Thread Peter Maydell
On 25 April 2017 at 15:07, Thomas Huth wrote: > So another idea: Could you start the test in verbose mode like this: > > V=2 QTEST_QEMU_BINARY=aarch64-softmmu/qemu-system-aarch64 tests/test-hmp manooth$ V=2 QTEST_QEMU_BINARY='aarch64-softmmu/qemu-system-aarch64' tests/test-hmp /aarch64/hmp/n810:

Re: [Qemu-devel] [PATCH for-2.10 05/23] numa: move source of default CPUs to NUMA node mapping into boards

2017-04-25 Thread Igor Mammedov
On Tue, 25 Apr 2017 16:48:30 +0200 Andrew Jones wrote: > On Wed, Mar 22, 2017 at 02:32:30PM +0100, Igor Mammedov wrote: > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > > index 0cbcbc1..8748d25 100644 > > --- a/hw/arm/virt.c > > +++ b/hw/arm/virt.c > > @@ -1554,6 +1554,16 @@ static void virt_set_

Re: [Qemu-devel] [PULL 0/4] hmp queue

2017-04-25 Thread Peter Maydell
On 25 April 2017 at 16:05, Peter Maydell wrote: > info jit > qemu: qemu_mutex_lock: Invalid argument Repro without the qtest machinery: $ lldb -- ./aarch64-softmmu/qemu-system-aarch64 -M n810 -s -S -monitor stdio -machine accel=qtest then run and type 'info jit' at the monitor prompt. B

Re: [Qemu-devel] QEMU travis builds: can we move the preseed tarball to qemu.org ?

2017-04-25 Thread Alex Bennée
Peter Maydell writes: > Hi; a recent travis build failure made me notice that our .travis.yml > config references a preseed tarball from here: > http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz > > I think this is a bit less than ideal -- we should really be hosting > this on

[Qemu-devel] qemu-io aborts at quit after reopen

2017-04-25 Thread Fam Zheng
Hi Kevin, This happens both on master and on your block-next tree: $ qemu-io -f raw null-co:// -c 'reopen -r' Unexpected error in bdrv_check_perm() at /stor/work/qemu/block.c:1437: Block node is read-only Aborted It seems bs->read_only and perms go out of sync when bdrv_reopen()

Re: [Qemu-devel] [PATCH for 2.9 v3 10/10] block: Fix bdrv_co_flush early return

2017-04-25 Thread Kevin Wolf
Am 10.04.2017 um 17:05 hat Fam Zheng geschrieben: > bdrv_inc_in_flight and bdrv_dec_in_flight are mandatory for > BDRV_POLL_WHILE to work, even for the shortcut case where flush is > unnecessary. Move the if block to below bdrv_dec_in_flight, and BTW fix > the variable declaration position. > > Si

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Laurent Vivier
On 25/04/2017 12:24, Juan Quintela wrote: > This way we use the "normal" way of printing errors for hmp commands. > > -- > Paolo suggestion "Suggested-by" tag? > > Signed-off-by: Juan Quintela > --- > hmp.c| 9 +++-- > include/sysemu/sysemu.h | 4 ++-- > migration/s

Re: [Qemu-devel] QEMU travis builds: can we move the preseed tarball to qemu.org ?

2017-04-25 Thread Alex Bennée
Daniel P. Berrange writes: > On Tue, Apr 25, 2017 at 03:51:17PM +0100, Peter Maydell wrote: >> Hi; a recent travis build failure made me notice that our .travis.yml >> config references a preseed tarball from here: >> http://people.linaro.org/~alex.bennee/qemu-submodule-git-seed.tar.xz >> >> I t

Re: [Qemu-devel] [PATCH v2] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-25 Thread Igor Mammedov
On Tue, 25 Apr 2017 17:01:21 +0200 Laszlo Ersek wrote: > On 04/24/17 22:45, Igor Mammedov wrote: > > Since 2.7 commit (b2a575a Add optionrom compatible with fw_cfg DMA version) > > regressed migration during firmware exection time by > > abusing fwcfg.dma_enabled property to decide loading > > dm

Re: [Qemu-devel] [PATCH v1 2/3] cpus: dump TLB flush counts as trace event

2017-04-25 Thread Alex Bennée
Paolo Bonzini writes: > On 11/04/2017 18:50, Alex Bennée wrote: >> This can be pre-processed later from the trace file. > > What about skipping this patch, and instead adding five trace points > > trace_tlb_flush_self(int vcpu) > trace_tlb_flush_async_schedule(int from, int to) > trace_tlb_flush

Re: [Qemu-devel] QEMU travis builds: can we move the preseed tarball to qemu.org ?

2017-04-25 Thread Daniel P. Berrange
On Tue, Apr 25, 2017 at 04:24:18PM +0100, Alex Bennée wrote: > > Daniel P. Berrange writes: > > > On Tue, Apr 25, 2017 at 03:51:17PM +0100, Peter Maydell wrote: > >> Hi; a recent travis build failure made me notice that our .travis.yml > >> config references a preseed tarball from here: > >> htt

Re: [Qemu-devel] [PULL 0/4] hmp queue

2017-04-25 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 25 April 2017 at 16:05, Peter Maydell wrote: > > info jit > > qemu: qemu_mutex_lock: Invalid argument > > Repro without the qtest machinery: > > $ lldb -- ./aarch64-softmmu/qemu-system-aarch64 -M n810 -s -S -monitor > stdio -machine

[Qemu-devel] [PATCH v3] pc/fwcfg: unbreak migration from qemu-2.5 and qemu-2.6 during firmware boot

2017-04-25 Thread Igor Mammedov
Since 2.7 commit (b2a575a Add optionrom compatible with fw_cfg DMA version) regressed migration during firmware exection time by abusing fwcfg.dma_enabled property to decide loading dma version of option rom AND by mistake disabling DMA for 2.6 and earlier globally instead of only for option rom.

[Qemu-devel] [PATCH v6 00/18]Convert QCow[2] to QCryptoBlock & add LUKS support

2017-04-25 Thread Daniel P. Berrange
Previously posted: v1: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg00201.html v2: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05147.html v3: https://lists.gnu.org/archive/html/qemu-devel/2017-01/msg05671.html v4: https://lists.gnu.org/archive/html/qemu-devel/2017-02/m

[Qemu-devel] [PATCH v6 01/18] block: expose crypto option names / defs to other drivers

2017-04-25 Thread Daniel P. Berrange
The block/crypto.c defines a set of QemuOpts that provide parameters for encryption. This will also be needed by the qcow/qcow2 integration, so expose the relevant pieces in a new block/crypto.h header. Some helper methods taking QemuOpts are changed to take QDict to simplify usage in other places.

[Qemu-devel] [PATCH v6 02/18] block: add ability to set a prefix for opt names

2017-04-25 Thread Daniel P. Berrange
When integrating the crypto support with qcow/qcow2, we don't want to use the bare LUKS option names "hash-alg", "key-secret", etc. We want to namespace them "luks-hash-alg", "luks-key-secret" so that they don't clash with any general qcow options at a later date. Reviewed-by: Max Reitz Reviewed-

[Qemu-devel] [PATCH v6 11/18] qcow2: convert QCow2 to use QCryptoBlock for encryption

2017-04-25 Thread Daniel P. Berrange
This converts the qcow2 driver to make use of the QCryptoBlock APIs for encrypting image content, using the legacyy QCow2 AES scheme. With this change it is now required to use the QCryptoSecret object for providing passwords, instead of the current block password APIs / interactive prompting.

[Qemu-devel] [PATCH v6 03/18] qcow: document another weakness of qcow AES encryption

2017-04-25 Thread Daniel P. Berrange
Document that use of guest virtual sector numbers as the basis for the initialization vectors is a potential weakness, when combined with internal snapshots or multiple images using the same passphrase. This fixes the formatting of the itemized list too. Reviewed-by: Max Reitz Reviewed-by: Albert

[Qemu-devel] [PATCH v6 04/18] qcow: require image size to be > 1 for new images

2017-04-25 Thread Daniel P. Berrange
The qcow driver refuses to open images which are less than 2 bytes in size, but will happily create such images. Add a check in the create path to avoid this discrepancy. Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Eric Blake Signed-off-by: Daniel P. Berrange --- block/qco

[Qemu-devel] [PATCH v6 05/18] iotests: skip 042 with qcow which dosn't support zero sized images

2017-04-25 Thread Daniel P. Berrange
Test 042 is designed to verify operation with zero sized images. Such images are not supported with qcow (v1), so this test has always failed. Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/042 | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH v6 17/18] block: remove all encryption handling APIs

2017-04-25 Thread Daniel P. Berrange
Now that all encryption keys must be provided upfront via the QCryptoSecret API and associated block driver properties there is no need for any explicit encryption handling APIs in the block layer. Encryption can be handled transparently within the block driver. We only retain an API for querying w

[Qemu-devel] [PATCH v6 08/18] qcow: make encrypt_sectors encrypt in place

2017-04-25 Thread Daniel P. Berrange
Instead of requiring separate input/output buffers for encrypting data, change encrypt_sectors() to assume use of a single buffer, encrypting in place. One current caller uses the same buffer for input/output already and the other two callers are easily converted to do so. Reviewed-by: Alberto Gar

[Qemu-devel] [PATCH v6 07/18] block: deprecate "encryption=on" in favour of "encrypt.format=aes"

2017-04-25 Thread Daniel P. Berrange
Historically the qcow & qcow2 image formats supported a property "encryption=on" to enable their built-in AES encryption. We'll soon be supporting LUKS for qcow2, so need a more general purpose way to enable encryption, with a choice of formats. This introduces an "encrypt.format" option, which wi

[Qemu-devel] [PATCH v6 06/18] iotests: skip 048 with qcow which doesn't support resize

2017-04-25 Thread Daniel P. Berrange
Test 048 is designed to verify data preservation during an image resize. The qcow (v1) format impl has never supported resize so always fails. Reviewed-by: Max Reitz Reviewed-by: Alberto Garcia Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/048 | 2 +- 1 file changed, 1 insertion(+),

[Qemu-devel] [PATCH v6 14/18] qcow2: add iotests to cover LUKS encryption support

2017-04-25 Thread Daniel P. Berrange
This extends the 087 iotest to cover LUKS encryption when doing blockdev-add. Two further tests are added to validate read/write of LUKS encrypted images with a single file and with a backing file. Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange --- tests/

[Qemu-devel] [PATCH v6 15/18] iotests: enable tests 134 and 158 to work with qcow (v1)

2017-04-25 Thread Daniel P. Berrange
The 138 and 158 iotests exercise the legacy qcow2 aes encryption code path and they work fine with qcow v1 too. Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange --- tests/qemu-iotests/134 | 2 +- tests/qemu-iotests/158 | 2 +- 2 files changed, 2 insertions(+

[Qemu-devel] [PATCH v6 09/18] qcow: convert QCow to use QCryptoBlock for encryption

2017-04-25 Thread Daniel P. Berrange
This converts the qcow driver to make use of the QCryptoBlock APIs for encrypting image content. This is only wired up to permit use of the legacy QCow encryption format. Users who wish to have the strong LUKS format should switch to qcow2 instead. With this change it is now required to use the QC

[Qemu-devel] [PATCH v6 13/18] qcow2: add support for LUKS encryption format

2017-04-25 Thread Daniel P. Berrange
This adds support for using LUKS as an encryption format with the qcow2 file, using the new encrypt.format parameter to request "luks" format. e.g. # qemu-img create --object secret,data=123456,id=sec0 \ -f qcow2 -o encrypt.-format=luks,encrypt.key-secret=sec0 \ test.qcow2 10G The

[Qemu-devel] [PATCH v6 12/18] qcow2: extend specification to cover LUKS encryption

2017-04-25 Thread Daniel P. Berrange
Update the qcow2 specification to describe how the LUKS header is placed inside a qcow2 file, when using LUKS encryption for the qcow2 payload instead of the legacy AES-CBC encryption Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz Signed-off-by: Daniel P. Berrange --- docs/specs/qcow2.txt

[Qemu-devel] [PATCH v6 16/18] block: rip out all traces of password prompting

2017-04-25 Thread Daniel P. Berrange
Now that qcow & qcow2 are wired up to get encryption keys via the QCryptoSecret object, nothing is relying on the interactive prompting for passwords. All the code related to password prompting can thus be ripped out. Reviewed-by: Alberto Garcia Reviewed-by: Max Reitz Signed-off-by: Daniel P. Be

[Qemu-devel] [PATCH v6 10/18] qcow2: make qcow2_encrypt_sectors encrypt in place

2017-04-25 Thread Daniel P. Berrange
Instead of requiring separate input/output buffers for encrypting data, change qcow2_encrypt_sectors() to assume use of a single buffer, encrypting in place. The current callers all used the same buffer for input/output already. Reviewed-by: Eric Blake Reviewed-by: Fam Zheng Reviewed-by: Alberto

[Qemu-devel] [PATCH v6 18/18] block: pass option prefix down to crypto layer

2017-04-25 Thread Daniel P. Berrange
While the crypto layer uses a fixed option name "key-secret", the upper block layer may have a prefix on the options. e.g. "luks-key-secret", "aes-key-secret", in order to avoid clashes between crypto option names & other block option names. To ensure the crypto layer can report accurate error mess

Re: [Qemu-devel] [PATCH] vmw_pvscsi: check message ring page count at initialisation

2017-04-25 Thread Dmitry Fleytman
> On 25 Apr 2017, at 16:06 PM, P J P wrote: > > Vmware Paravirtual SCSI emulation uses command descriptors to > process SCSI commands. These come with their message ring buffers. > A guest could set the message ring page count to an arbitrary value > resulting in infinite loop. Add check to avoi

Re: [Qemu-devel] QEMU travis builds: can we move the preseed tarball to qemu.org ?

2017-04-25 Thread Alex Bennée
Daniel P. Berrange writes: > On Tue, Apr 25, 2017 at 04:24:18PM +0100, Alex Bennée wrote: >> >> Daniel P. Berrange writes: >> >> > On Tue, Apr 25, 2017 at 03:51:17PM +0100, Peter Maydell wrote: >> >> Hi; a recent travis build failure made me notice that our .travis.yml >> >> config references a

Re: [Qemu-devel] [Qemu-block] qemu-io aborts at quit after reopen

2017-04-25 Thread Alberto Garcia
On Tue, Apr 25, 2017 at 11:13:17PM +0800, Fam Zheng wrote: > Hi Kevin, > > This happens both on master and on your block-next tree: > > $ qemu-io -f raw null-co:// -c 'reopen -r' > Unexpected error in bdrv_check_perm() at /stor/work/qemu/block.c:1437: > Block node is read-only > A

Re: [Qemu-devel] [PATCH v6 00/18]Convert QCow[2] to QCryptoBlock & add LUKS support

2017-04-25 Thread no-reply
Hi, This series failed build test on s390x host. Please find the details below. Type: series Message-id: 20170425153858.25660-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/18]Convert QCow[2] to QCryptoBlock & add LUKS support === TEST SCRIPT BEGIN === #!/bin/bash # Testing script wil

Re: [Qemu-devel] [Qemu-stable] [PATCH v2 1/1] qemu-img: wait for convert coroutines to complete

2017-04-25 Thread Anton Nefedov
On 04/25/2017 12:55 PM, Peter Lieven wrote: Am 24.04.2017 um 22:13 schrieb Anton Nefedov: On 24/04/2017 21:16, Peter Lieven wrote: Am 24.04.2017 um 18:27 schrieb Anton Nefedov : On 04/21/2017 03:37 PM, Peter Lieven wrote: Am 21.04.2017 um 14:19 schrieb Anton Nefedov: On 04/21/2017 01:

[Qemu-devel] [Bug 1289898] Re: qemu-system-ppc64 easily cause file corruption

2017-04-25 Thread Thomas Huth
*** This bug is a duplicate of bug 1463812 *** https://bugs.launchpad.net/bugs/1463812 ** This bug has been marked a duplicate of bug 1463812 qemu-system-ppc64 V2.30 cause RHEL5.9 disk corruption -- You received this bug notification because you are a member of qemu- devel-ml, which is su

Re: [Qemu-devel] QEMU travis builds: can we move the preseed tarball to qemu.org ?

2017-04-25 Thread Jeff Cody
On Apr 25, 2017 11:55 AM, "Alex Bennée" wrote: Daniel P. Berrange writes: > On Tue, Apr 25, 2017 at 04:24:18PM +0100, Alex Bennée wrote: >> >> Daniel P. Berrange writes: >> >> > On Tue, Apr 25, 2017 at 03:51:17PM +0100, Peter Maydell wrote: >> >> Hi; a recent travis build failure made me noti

Re: [Qemu-devel] [PATCH 0/2] linux-user: fix eventfd()

2017-04-25 Thread Laurent Vivier
Ping? Laurent Le 01/03/2017 à 10:37, Laurent Vivier a écrit : > This patch series byte-swap the uint64_t data stream > of a file-descriptor opened with eventfd(). > > It allows to pass more LTP test cases: > > eventfd011 TPASS : counter value matches required > eventfd012 TPASS :

Re: [Qemu-devel] [PATCH] linux-user: fix fadvise64_64() on ppc

2017-04-25 Thread Laurent Vivier
Ping? Laurent Le 02/03/2017 à 01:11, Laurent Vivier a écrit : > On ppc, advice is arg2, not arg6: > > long ppc_fadvise64_64(int fd, int advice, u32 offset_high, u32 offset_low, > u32 len_high, u32 len_low) > > Signed-off-by: Laurent Vivier > --- > linux-user/syscall.c |

Re: [Qemu-devel] [PATCH] linux-user: fix inotify

2017-04-25 Thread Laurent Vivier
Ping? Laurent Le 02/03/2017 à 01:54, Laurent Vivier a écrit : > When a fd is opened using inotify_init(), a read provides > one or more inotify_event structures: > > struct inotify_event { > int wd; > uint32_t mask; > uint32_t cookie; > uint32_t len; >

Re: [Qemu-devel] [PATCH 5/6] monitor: Move hmp_info_snapshots from savevm.c to hmp.c

2017-04-25 Thread Juan Quintela
Laurent Vivier wrote: > On 25/04/2017 12:24, Juan Quintela wrote: >> It only uses block/* functions, nothing from migration. >> >> Signed-off-by: Juan Quintela > > Reviewed-by: Laurent Vivier > > Perhaps the monitor.h include in savevm.c can be removed in PATCH 1/6? hmp_info_snapshots still us

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Juan Quintela
Laurent Vivier wrote: > On 25/04/2017 12:24, Juan Quintela wrote: >> This way we use the "normal" way of printing errors for hmp commands. >> >> -- >> Paolo suggestion > > "Suggested-by" tag? Thanks. >> { >> +Error *err = NULL; >> + >> if (replay_snapshot) { >> if (replay_mode

Re: [Qemu-devel] [PATCH for-2.10 14/23] virt-arm: get numa node mapping from possible_cpus instead of numa_get_node_for_cpu()

2017-04-25 Thread Andrew Jones
On Wed, Mar 22, 2017 at 02:32:39PM +0100, Igor Mammedov wrote: > Signed-off-by: Igor Mammedov > --- > hw/arm/virt-acpi-build.c | 19 +++ > hw/arm/virt.c| 13 +++-- > 2 files changed, 14 insertions(+), 18 deletions(-) > > diff --git a/hw/arm/virt-acpi-build.c b

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Laurent Vivier
On 25/04/2017 19:00, Juan Quintela wrote: > Laurent Vivier wrote: >> On 25/04/2017 12:24, Juan Quintela wrote: >>> This way we use the "normal" way of printing errors for hmp commands. >>> >>> -- >>> Paolo suggestion >> >> "Suggested-by" tag? > > Thanks. >>> { >>> +Error *err = NULL; >>> + >

Re: [Qemu-devel] [PATCH for-2.10 08/23] virt-arm: add node-id property to CPU

2017-04-25 Thread Andrew Jones
On Wed, Mar 22, 2017 at 02:32:33PM +0100, Igor Mammedov wrote: > it will allow switching from cpu_index to property based > numa mapping in follow up patches. > > Signed-off-by: Igor Mammedov > --- > hw/arm/virt.c| 15 +++ > target/arm/cpu.c | 1 + > 2 files changed, 16 insertio

Re: [Qemu-devel] [PULL 0/21] Please pull xen-20170421-tag for 2.10

2017-04-25 Thread Stefano Stabellini
On Tue, 25 Apr 2017, Markus Armbruster wrote: > Stefano Stabellini writes: > > > On Mon, 24 Apr 2017, Peter Maydell wrote: > >> On 24 April 2017 at 22:25, Stefano Stabellini > >> wrote: > >> > diff --git a/hw/9pfs/xen-9pfs.h b/hw/9pfs/xen-9pfs.h > >> > new file mode 100644 > >> > index 000.

Re: [Qemu-devel] [BUG] Migrate failes between boards with different PMC counts

2017-04-25 Thread Dr. David Alan Gilbert
* Zhuangyanying (ann.zhuangyany...@huawei.com) wrote: > > > > -Original Message- > > From: Daniel P. Berrange [mailto:berra...@redhat.com] > > Sent: Monday, April 24, 2017 6:34 PM > > To: Dr. David Alan Gilbert > > Cc: Zhuangyanying; Zhanghailiang; wangxin (U); qemu-devel@nongnu.org; > >

Re: [Qemu-devel] [PATCH v6 00/18]Convert QCow[2] to QCryptoBlock & add LUKS support

2017-04-25 Thread no-reply
Hi, This series failed automatic build test. Please find the testing commands and their output below. If you have docker installed, you can probably reproduce it locally. Message-id: 20170425153858.25660-1-berra...@redhat.com Subject: [Qemu-devel] [PATCH v6 00/18]Convert QCow[2] to QCryptoBlock &

Re: [Qemu-devel] Help needed: Sparc 64, kernel panic

2017-04-25 Thread Ajallooiean Hossein
Hi Mark Sorry for pinging so early. Im just wondering if youve had time to go over my email below. Any help would be greatly appreciated. Thanks Hoss From: Qemu-devel on behalf of Ajallooiean Hossein Sent: Sunday, April 23, 2017 1:42:08 AM To: qemu-de

Re: [Qemu-devel] [PATCH v2] crypto_gen_random() now also works on windows

2017-04-25 Thread Geert Martin Ijewski
Am 25.04.2017 um 15:42 schrieb Daniel P. Berrange: On Mon, Apr 24, 2017 at 07:51:49PM +0200, Geert Martin Ijewski wrote: +#ifdef _WIN32 +#include +HCRYPTPROV hCryptProv; +#else +int fd; /* a file handle to either /dev/urandom or /dev/random */ +#endif Lets mark both these vars 'static' Ah

[Qemu-devel] [PATCH v3] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto lib

2017-04-25 Thread Geert Martin Ijewski
If no crypto library is included in the build, QEMU uses qcrypto_random_bytes() to generate random data. That function tried to open /dev/urandom or /dev/random and if openeing neither file worked it errored out. Those files obviously do not exist on windows, so there the code uses CryptGenRan

Re: [Qemu-devel] [PATCH 6/6] migration: Pass Error ** argument to {save, load}_vmstate

2017-04-25 Thread Juan Quintela
Laurent Vivier wrote: > On 25/04/2017 19:00, Juan Quintela wrote: >> Laurent Vivier wrote: >>> On 25/04/2017 12:24, Juan Quintela wrote: { +Error *err = NULL; + if (replay_snapshot) { if (replay_mode == REPLAY_MODE_RECORD) { -if (save_

[Qemu-devel] [PATCH v3] hw/misc: Add Exynos4210 Pseudo Random Number Generator

2017-04-25 Thread Krzysztof Kozlowski
Add emulation for Exynos4210 Pseudo Random Number Generator which could work on fixed seeds or with seeds provided by True Random Number Generator block inside the SoC. Implement only the fixed seeds part of it in polling mode (no interrupts). Emulation tested with two independent Linux kernel ex

Re: [Qemu-devel] [PATCH] hw/s390x/ipl: Fix crash with virtio-scsi-pci device

2017-04-25 Thread Christian Borntraeger
On 04/25/2017 03:18 PM, Thomas Huth wrote: > qemu-system-s390x currently crashes when it is started with a > virtio-scsi-pci device, e.g.: > > qemu-system-s390x -nographic -enable-kvm -device virtio-scsi-pci \ >-drive file=/tmp/disk.dat,if=none,id=d1,format=raw \ >

Re: [Qemu-devel] [PATCH v2 1/9] tpm-backend: Remove unneeded member variable from backend class

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: TPMDriverOps inside TPMBackend is not required, as it is supposed to be a class member. The only possible reason for keeping in TPMBackend was, to get the backend type in tpm.c where dedicated backend api, tpm_backend_get_type() is present. Signed-

Re: [Qemu-devel] [PATCH v2 2/9] tpm-backend: Move thread handling inside TPMBackend

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: Move thread handling inside TPMBackend, this way backend implementations need not to maintain their own thread life cycle, instead they needs to implement 'handle_request()' class method that always been called from a thread. This change made tpm_b

Re: [Qemu-devel] [PATCH v2 3/9] tpm-backend: Initialize and free data members in it's own methods

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: Initialize and free TPMBackend data members in it's own instance_init() and instance_finalize methods. Took the opportunity to fix object cleanup in tpm_backend_{create,destroy} methods Signed-off-by: Amarnath Valluri --- backends/tpm.c

Re: [Qemu-devel] [PATCH v2 4/9] tpm-backend: Made few interface methods optional

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: This allows backend implementations left optional interface methods. For mandatory methods assertion checks added. Signed-off-by: Amarnath Valluri --- backends/tpm.c | 28 +--- hw/tpm/tpm_passthrough.c | 16 ---

[Qemu-devel] [PULL 0/21] Please pull xen-20170421-v2-tag for 2.10

2017-04-25 Thread Stefano Stabellini
Added a fix for the clang build, see alpine.DEB.2.10.1704251014320.2875@sstabellini-ThinkPad-X260 The following changes since commit 55a19ad8b2d0797e3a8fe90ab99a9bb713824059: Update version for v2.9.0-rc1 release (2017-03-21 17:13:29 +) are available in the git repository at: git://xen

[Qemu-devel] [PATCH 02/21] xen: rename xen_modified_memory() to xen_hvm_modified_memory()

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant This patch is a purely cosmetic change that avoids a name collision in a subsequent patch. Signed-off-by: Paul Durrant Reviewed-by: Anthony Perard Reviewed-by: Stefano Stabellini --- include/exec/ram_addr.h | 4 ++-- include/hw/xen/xen.h| 2 +- xen-hvm-stub.c

[Qemu-devel] [PATCH 06/21] xen: use 5 digit xen versions

2017-04-25 Thread Stefano Stabellini
From: Juergen Gross Today qemu is using e.g. the value 480 for Xen version 4.8.0. As some Xen version tests are using ">" relations this scheme will lead to problems when Xen version 4.10.0 is being reached. Instead of the 3 digit schem use a 5 digit scheme (e.g. 40800 for version 4.8.0). Signe

[Qemu-devel] [PATCH 03/21] xen: create wrappers for all other uses of xc_hvm_XXX() functions

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant This patch creates inline wrapper functions in xen_common.h for all open coded calls to xc_hvm_XXX() functions outside of xen_common.h so that use of xen_xc can be made implicit. This again is in preparation for the move to using libxendevicemodel. Signed-off-by: Paul Durrant

[Qemu-devel] [PATCH 01/21] xen: make use of xen_xc implicit in xen_common.h inlines

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant Doing this will make the transition to using the new libxendevicemodel interface less intrusive on the callers of these functions, since using the new library will require a change of handle. NOTE: The patch also moves the 'externs' for xen_xc and xen_fmem from xen_backe

[Qemu-devel] [PATCH 04/21] configure: detect presence of libxendevicemodel

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant This patch adds code in configure to set CONFIG_XEN_CTRL_INTERFACE_VERSION to a new value of 490 if libxendevicemodel is present in the build environment. Signed-off-by: Paul Durrant Signed-off-by: Stefano Stabellini Reviewed-by: Anthony Perard Reviewed-by: Stefano Stabelli

[Qemu-devel] [PATCH 12/21] xen/9pfs: introduce Xen 9pfs backend

2017-04-25 Thread Stefano Stabellini
Introduce the Xen 9pfs backend: add struct XenDevOps to register as a Xen backend and add struct V9fsTransport to register as v9fs transport. All functions are empty stubs for now. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Ane

[Qemu-devel] [PATCH 14/21] xen/9pfs: receive requests from the frontend

2017-04-25 Thread Stefano Stabellini
Upon receiving an event channel notification from the frontend, schedule the bottom half. From the bottom half, read one request from the ring, create a pdu and call pdu_submit to handle it. For now, only handle one request per ring at a time. Signed-off-by: Stefano Stabellini CC: anthony.per...

[Qemu-devel] [PATCH 05/21] xen: use libxendevicemodel when available

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant This patch modifies the wrapper functions in xen_common.h to use the new xendevicemodel interface if it is available along with compatibility code to use the old libxenctrl interface if it is not. Signed-off-by: Paul Durrant Signed-off-by: Stefano Stabellini Reviewed-by: Ant

[Qemu-devel] [PATCH 09/21] configure: use pkg-config for obtaining xen version

2017-04-25 Thread Stefano Stabellini
From: Juergen Gross Instead of trying to guess the Xen version to use by compiling various test programs first just ask the system via pkg-config. Only if it can't return the version fall back to the test program scheme. If configure is being called with dedicated flags for the Xen libraries use

[Qemu-devel] [PATCH 18/21] add xen-9p-backend to MAINTAINERS under Xen

2017-04-25 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: gr...@kaod.org CC: anthony.per...@citrix.com --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 779c429..420505e 100644 --- a/MAINTAINERS +++ b/MAINTAI

[Qemu-devel] [PATCH 15/21] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal

2017-04-25 Thread Stefano Stabellini
Implement xen_9pfs_init_in/out_iov_from_pdu and xen_9pfs_pdu_vmarshal/vunmarshall by creating new sg pointing to the data on the ring. This is safe as we only handle one request per ring at any given time. Signed-off-by: Stefano Stabellini CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: An

[Qemu-devel] [PATCH 07/21] xen: use libxendevice model to restrict operations

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant This patch adds a command-line option (-xen-domid-restrict) which will use the new libxendevicemodel API to restrict devicemodel [1] operations to the specified domid. (Such operations are not applicable to the xenpv machine type). This patch also adds a tracepoint to allow su

[Qemu-devel] [PATCH 13/21] xen/9pfs: connect to the frontend

2017-04-25 Thread Stefano Stabellini
Write the limits of the backend to xenstore. Connect to the frontend. Upon connection, allocate the rings according to the protocol specification. Initialize a QEMUBH to schedule work upon receiving an event channel notification from the frontend. Signed-off-by: Stefano Stabellini CC: anthony.pe

[Qemu-devel] [PATCH 17/21] xen/9pfs: build and register Xen 9pfs backend

2017-04-25 Thread Stefano Stabellini
Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V CC: Greg Kurz --- hw/9pfs/Makefile.objs| 1 + hw/xen/xen_backend.c | 3 +++ include/hw/xen/xen_backend.h | 3 +++ 3 files changed, 7 insertions(+) di

[Qemu-devel] [Bug 1686170] [NEW] qemu-system-x86_64+gdb: unable to correctly disassemble "real mode" (i8086) instructions after attaching to QEMU started with "-S -s" options

2017-04-25 Thread Alain Kalker
Public bug reported: OS: Void Linux x86_64 (glibc) QEMU version: 2.9.0 GDB version: 7.12.1 Problem description: After I updated QEMU from version 2.8.1 to 2.9.0, I found that when I try to connect GDB to a running QEMU and try to debug Real mode machine code, I can no longer set architecture t

[Qemu-devel] [PATCH 08/21] xen: additionally restrict xenforeignmemory operations

2017-04-25 Thread Stefano Stabellini
From: Paul Durrant Commit f0f272baf3a7 "xen: use libxendevice model to restrict operations" added a command-line option (-xen-domid-restrict) to limit operations using the libxendevicemodel API to a specified domid. The commit also noted that the restriction would be extended to cover operations

[Qemu-devel] [PATCH 19/21] move xen-common.c to hw/xen/

2017-04-25 Thread Stefano Stabellini
From: Anthony Xu move xen-common.c to hw/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target | 2 - hw/xen/Makefile.objs | 2 +- hw/xen/xen-common.c | 169 +++ stubs/Makefile.objs | 1 + stubs/xen-com

[Qemu-devel] [PATCH 11/21] 9p: introduce a type for the 9p header

2017-04-25 Thread Stefano Stabellini
Use the new type in virtio-9p-device. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz Reviewed-by: Philippe Mathieu-Daudé CC: anthony.per...@citrix.com CC: jgr...@suse.com CC: Aneesh Kumar K.V CC: Greg Kurz --- hw/9pfs/9p.h | 6 ++ hw/9pfs/virtio-9p-device.c | 6 +-

[Qemu-devel] [PATCH 21/21] move xen-mapcache.c to hw/i386/xen/

2017-04-25 Thread Stefano Stabellini
From: Anthony Xu move xen-mapcache.c to hw/i386/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target| 3 - default-configs/i386-softmmu.mak | 1 - default-configs/x86_64-softmmu.mak | 1 - hw/i386/xen/Makefile.objs | 2 +-

[Qemu-devel] [PATCH 10/21] xen: import ring.h from xen

2017-04-25 Thread Stefano Stabellini
Do not use the ring.h header installed on the system. Instead, import the header into the QEMU codebase. This avoids problems when QEMU is built against a Xen version too old to provide all the ring macros. Signed-off-by: Stefano Stabellini Reviewed-by: Greg Kurz CC: anthony.per...@citrix.com CC

[Qemu-devel] [PATCH 16/21] xen/9pfs: send responses back to the frontend

2017-04-25 Thread Stefano Stabellini
Once a request is completed, xen_9pfs_push_and_notify gets called. In xen_9pfs_push_and_notify, update the indexes (data has already been copied to the sg by the common code) and send a notification to the frontend. Schedule the bottom-half to check if we already have any other requests pending.

[Qemu-devel] [PATCH 20/21] move xen-hvm.c to hw/i386/xen/

2017-04-25 Thread Stefano Stabellini
From: Anthony Xu move xen-hvm.c to hw/i386/xen/ Signed-off -by: Anthony Xu Reviewed-by: Stefano Stabellini --- Makefile.target |3 +- hw/i386/xen/Makefile.objs |2 +- hw/i386/xen/trace-events | 11 + hw/i386/xen/xen-hvm.c | 1429 +++

Re: [Qemu-devel] [PATCH v2 5/9] tmp backend: Add new api to read backend TpmInfo

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: TPM configuration options are backend implementation details and shall not be part of base TPMBackend object, and these shall not be accessed directly outside of the class, hence added a new interface method, get_tpm_options() to TPMDriverOps., whic

Re: [Qemu-devel] [PATCH v3] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto lib

2017-04-25 Thread Daniel P. Berrange
On Tue, Apr 25, 2017 at 07:28:07PM +0200, Geert Martin Ijewski wrote: > If no crypto library is included in the build, QEMU uses > qcrypto_random_bytes() to generate random data. That function tried to open > /dev/urandom or /dev/random and if openeing neither file worked it errored > out. > > Tho

Re: [Qemu-devel] [PATCH v2 6/9] tpm-backend: Remove unneeded destroy() method from TpmDriverOps interface

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: As TPMBackend is a Qemu Object, we can use object_unref() inplace of tpm_backend_destroy() to free the backend object, hence removed destroy() from TPMDriverOps interface. Signed-off-by: Amarnath Valluri --- backends/tpm.c | 11 ---

Re: [Qemu-devel] [PATCH v2 5/9] tmp backend: Add new api to read backend TpmInfo

2017-04-25 Thread Eric Blake
On 04/25/2017 01:51 PM, Stefan Berger wrote: >> +++ b/qapi-schema.json >> @@ -5140,6 +5140,16 @@ >> { 'command': 'query-tpm-types', 'returns': ['TpmType'] } >> >> ## >> +# @TPMOptions: >> +# >> +# Base type for TPM options >> +# >> +# Since: 2.10 >> +## >> +{ 'struct': 'TPMOptions', >> + 'dat

Re: [Qemu-devel] [PATCH v2 7/9] tpm-backend: Move realloc_buffer() implementation to base class

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: Provide base implementation of realloc_buffer(), so that backend implementations can resue. Signed-off-by: Amarnath Valluri --- backends/tpm.c | 9 - hw/tpm/tpm_passthrough.c | 12 2 files changed, 8 insertions(

Re: [Qemu-devel] [PATCH v3] crypto: qcrypto_random_bytes() now works on windows w/o any other crypto lib

2017-04-25 Thread Eric Blake
On 04/25/2017 12:28 PM, Geert Martin Ijewski wrote: > If no crypto library is included in the build, QEMU uses > qcrypto_random_bytes() to generate random data. That function tried to > open /dev/urandom or /dev/random and if openeing neither file worked it s/openeing/opening/ s/opening neither fi

Re: [Qemu-devel] [PATCH v2 8/9] tpm-passthrough: move reusable code to utils

2017-04-25 Thread Stefan Berger
On 04/07/2017 10:30 AM, Amarnath Valluri wrote: Signed-off-by: Amarnath Valluri --- hw/tpm/tpm_passthrough.c | 64 hw/tpm/tpm_util.c| 25 +++ hw/tpm/tpm_util.h| 4 +++ 3 files changed, 34 insertions(+), 59 del

Re: [Qemu-devel] [PATCH 2/2] qemu-img: fix some spelling errors

2017-04-25 Thread Max Reitz
On 24.04.2017 17:53, Eric Blake wrote: > On 04/24/2017 10:47 AM, Eric Blake wrote: >> On 04/24/2017 10:37 AM, Philippe Mathieu-Daudé wrote: >> > /* > - * Returns true iff the first sector pointed to by 'buf' contains at > least > - * a non-NUL byte. > + * Returns true if the fi

<    1   2   3   4   5   >